Hey everyone, Here's the state of the #13605 patch and what it currently is doing:
- Added partition options which can do French/English, latex outputs, Ferrers' diagram characters, some ordering - Deprecating the following methods and classes: * evaluation() * dominate() -- Changed name to dominated_partitions() * OrderedPartitions_nk -- Renamed to OrderedPartitions since the function OrderedPartitions just created this * PartitionsInBox_hw -- Renamed to PartitionsInBox since the function PartitionsInBox just created this * PartitionsGreatestLE_nk -- Renamed to PartitionsGreatestLE since the function PartitionsGreatestLE just created this * PartitionsGreatestEQ_nk -- Renamed to PartitionsGreatestEQ since the function PartitionsGreatestEQ just created this - Changed *_lengths into *_length_tableau() (ex. arm_lengths() becomes arm_length_tableau() ) and deprecated old names - Added comparison methods to Partition_class - Made Partition_class an element (had to touch two symmetric function files for this as well) - Made Partitions() into the class Partitions which now does the work of Partitions_all, however Partitions(options) still returns the appropriate parent - Made Partitions_n inherit from Partitions - Made the other finite set of partitions inherit from Partitions_n except those that inherited from IntegerListsLex - IntegerListsLex no longer inherits from CombinatorialClass, but instead from Parent with elements of ClonableArray - All classes Partitions* are not in the category framework except PartitionsRestricted which will eventually be removed. - Removed the ferrers_diagram() function (not the method of Partition_class) since it was deprecated a long time ago (2-3 years as I recall) - Added same options for tuple of partitions. - Cleaned up the documention Right now there are about 8 tests which fail in partition.py. 5 of them are because I don't know how to get the old pickle information for the classes I changed, so Andrew any advice? The other 3 are more serious and have to do with docstring testing. Apparently if a parent class has a category which has a default implementation of a method, that category's implementation is what's called, despite if the parent defines the same function. However this does not show up in a sage session. Also there are a few questions I want to ask. Tableaux should also have options (French vs. English in particular), but should they be linked to the options for Partitions? Same question to PartitionTuples with Partitions. Does anybody disagree with or have any suggestions/recommendations on any of the above changes? Thanks, Travis -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/sPhMHijN0AAJ. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.