Hi Travis!
On Tue, Oct 30, 2012 at 04:02:08PM -0700, Travis Scrimshaw wrote:
> Here's the state of the #13605 patch and what it currently is doing:
Thanks for all your hard work! Yippee in particular for long desired
things like:
> - IntegerListsLex no longer inherits from CombinatorialClass, but instead
> from Parent with elements of ClonableArray
Have you made some timings to measure the improvement?
> - Added partition options which can do French/English, latex outputs,
> Ferrers' diagram characters, some ordering
Just checking since I haven't followed seriously sage-combinat-devel
lately; for the semantic-changing options:
+1 on Partitions(order=...)
-1 on Partitions().options(order=...)
> - Deprecating the following methods and classes:
> * evaluation()
What is the rationale?
> * OrderedPartitions_nk -- Renamed to OrderedPartitions since the
> function OrderedPartitions just created this
> * ... and all variants ...
It is likely that we will eventually have OrderedPartitions()
construct the set of all ordered partitions. It would thus be natural
to reserve the name OrderedPartitions for the class of this set.
> - Changed *_lengths into *_length_tableau() (ex. arm_lengths() becomes
> arm_length_tableau() ) and deprecated old names
What is the rational?
> - Made Partitions_n inherit from Partitions
This breaks the "is_a" rule: the set of all partitions of 3 is not an
instance of the class Partitions; the (by the way unique) instance of
the latter indeed models the set of all partitions. Hmm, I would have
expected UniqueRepresentation to bark about this.
> - Made the other finite set of partitions inherit from Partitions_n except
> those that inherited from IntegerListsLex
Idem.
> The other 3 are more serious and have to do with docstring
> testing. Apparently if a parent class has a category which has a
> default implementation of a method, that category's
> implementation is what's called, despite if the parent defines
> the same function.
This is not supposed to happen. Let me know if you manage to narrow
down the problem into something reproducible.
> Also there are a few questions I want to ask. Tableaux should
> also have options (French vs. English in particular), but should
> they be linked to the options for Partitions? Same question to
> PartitionTuples with Partitions.
I propose to start with the options being linked. Indeed, the standard
use case will be for someone to always prefer English or always prefer
French notation, and there should be a single point of truth for
storing this user preference. If later someone really wants distinct
conventions for tableaux or partitions, then that person will take on
the task to have linked options as a default, with a way to unlink
them.
Thanks again!
Cheers,
Nicolas
--
Nicolas M. Thiéry "Isil" <nthi...@users.sf.net>
http://Nicolas.Thiery.name/
--
You received this message because you are subscribed to the Google Groups
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-devel@googlegroups.com.
To unsubscribe from this group, send email to
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sage-combinat-devel?hl=en.
