On Tue, 7 Feb 2023, 13:33 David Roe, <roed.m...@gmail.com> wrote: > > > On Tue, Feb 7, 2023 at 10:28 AM Eric Gourgoulhon <egourgoul...@gmail.com> > wrote: > >> Hi, >> >> Thanks again for all the hard work for the github migration! >> >> I would like to create a team "Manifolds" of https://github.com/sagemath, >> with sufficient permissions so that I can add users to it. How shall I >> proceed? Are there any team creation request on the github interface or >> should some sagemath admin do it? >> > > I think people in the Core group can create teams. > > >> Maybe a preliminary question: do we want to create github teams to >> organize Sage development by topics? >> > > I think this is a good idea: we can use it to help us organize code > reviews, and people can @mention a team if they're looking for advice on a > certain topic. After talking to Julian RĂ¼th some, here's a proposal for > how to carry this out (given that Github's code owners > <https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners> > functionality requires write permission to the repo, and that only repo > owners can add people to teams). > > * Julian and I can work on creating a bot for managing component teams. > There will be a top level "Components" team, with a sub-team associated to > each of our existing components. > * The bot will be contained in a new repo in the sagemath organization, > and will run on a google cloud instance that Julian sets up (we could run > it on Github Actions, but that would use up one of our runners that we use > for linting and doctesting PRs). >
we don't have our Actions runners, as far as I know. Thus I don't understand "use up" here. But it would be good to set up dedicated Actions runners, ones we don't have to share. Julian can give others access to the machine, and if Julian disappears for > some reason and we want to shut the bot down years from now, an > organization admin can just revoke the bot's permissions. > * It will operate by monitoring pull requests: > 1. If someone who is not a member of the Sage organization has a pull > request merged, it will invite them to the SageMath organization (with > whatever privileges we end up settling on for that status). They'll accept > via normal means (whatever the email tells them to do). > 2. If someone who is not part of any component team has a pull request > merged (including the above case), it will reply with a description of the > component teams and an offer to join some; anyone can join a team by making > a comment addressed to the bot. It will remember that an offer is made, > and not spam people on future PRs if they choose not to join a component > team. > 3. When an author's Nth pull request is merged (maybe N=5?) it will > offer to add them to the triage team, giving them the power to change > labels. > 4. When a component tag is added to a PR (or a new PR created with a > component set), if there is no reviewer already requested then the bot will > request review from someone on that component team (eventually we may > refine this process based on what lines are being modified in the PR). > Details on how a person is chosen are still to be worked out, but we think > it's helpful to have a single person responsible rather than a large group. > 5. If a reviewer declines or if a review is not given within a week > (this duration can be up for discussion), the bot will request review from > another member of that component team. > > Thoughts or suggestions? > David > > >> Eric. >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sage-devel" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to sage-devel+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/sage-devel/1120db7e-9536-4b06-8d43-b1d1a920de3dn%40googlegroups.com >> <https://groups.google.com/d/msgid/sage-devel/1120db7e-9536-4b06-8d43-b1d1a920de3dn%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/CAChs6_m9ZKUt0_J13hGLeFpSDY1J-RSSGKM%3Dc65RrPEewv2L%2Bg%40mail.gmail.com > <https://groups.google.com/d/msgid/sage-devel/CAChs6_m9ZKUt0_J13hGLeFpSDY1J-RSSGKM%3Dc65RrPEewv2L%2Bg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAAWYfq06cmEbN_3hp%3DUHr93DjL%3DqhNNJuVANPJ4y-NeZG48z3w%40mail.gmail.com.