In response to Eric's suggestion of having the whole team set as the reviewer, my main concern is that having a diffuse responsibility will make it more likely for tickets to slip through the cracks. If you want to review a ticket and someone else is assigned by the bot, I think taking over as reviewer would be totally acceptable.
Sending notifications <https://github.com/marketplace/actions/issue-label-notifier> to the corresponding team when a component label is added is probably another thing that the bot could do (probably just by adding an @team comment to the PR). I think the standard in the open source world is to allow PRs from outsiders, partly as a way to draw people in. John, what's your motivation for restricting to only members? David On Tue, Feb 7, 2023 at 5:39 PM John Cremona <john.crem...@gmail.com> wrote: > Re David's #1: Could we only allow PRs to be made by members? (Or is > that against the spirit of open source?) Then, a new contributor would > first ask to become a member, and then would be able to make a PR. > > John > > On Tue, 7 Feb 2023 at 16:29, Eric Gourgoulhon <egourgoul...@gmail.com> > wrote: > >> Thanks for your reply. >> >> Le mardi 7 février 2023 à 14:33:04 UTC+1, David Roe a écrit : >> 4. When a component tag is added to a PR (or a new PR created with a >> component set), if there is no reviewer already requested then the bot will >> request review from someone on that component team (eventually we may >> refine this process based on what lines are being modified in the PR). >> Details on how a person is chosen are still to be worked out, but we think >> it's helpful to have a single person responsible rather than a large group. >> 5. If a reviewer declines or if a review is not given within a week >> (this duration can be up for discussion), the bot will request review from >> another member of that component team. >> >> I would rather favor a mode in which the bot sends a notification to the >> whole team at each tagged PR, instead of picking members one per one, so >> that any team member that is interested by the PR, feels competent and has >> the time to do the review can do it. >> >> Eric. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sage-devel" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to sage-devel+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/sage-devel/3de741ca-1c8f-461c-9df8-0eaf95ca8444n%40googlegroups.com >> <https://groups.google.com/d/msgid/sage-devel/3de741ca-1c8f-461c-9df8-0eaf95ca8444n%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/CAD0p0K5%3D1qjnk%3DJM4auH6rmD9ZH1srQQMavGcMwztgMGYHSv%3DA%40mail.gmail.com > <https://groups.google.com/d/msgid/sage-devel/CAD0p0K5%3D1qjnk%3DJM4auH6rmD9ZH1srQQMavGcMwztgMGYHSv%3DA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAChs6_nX_6uvSD9zizA142znd00%3DnxY6jN4X4SvdtVaA8X%2Bvqw%40mail.gmail.com.
