Just to add that the PR as it is now changes over 100 files, and about 2000 lines of code. And it goes about 4 different topics.
Thanks, Martin, for taking time looking into it. It seems that it puts about 50% or more of Sage into sagemath-categories, cause it includes SR (with calculus), polynomial rings, etc. One may ask whether it's worthwhile to have at all in this form. Dima On 27 September 2024 22:25:06 BST, 'Martin R' via sage-devel <sage-devel@googlegroups.com> wrote: >I don't understand this PR. The diagram you link to indicates that >sagemath-categories is almost at the bottom, whereas sagemath-symbolics is >almost at the top of the hierarchy that you propose. However, the PR >includes a file > >src/sage/calculus/all__sagemath_categories.py ><https://github.com/sagemath/sage/pull/36380/files/ff660fc58ff941b259204d759e9a5157fcec32a7#diff-f852c2f1e2e357e9b8163b0e9b13fcba3c048b868e411896e748ec81e3c6ec24> >from sage.calculus.functional import diff, derivative, expand, simplify, >taylor > >and many similar files, e.g. src/sage/combinat/all__sagemath_categories.py, >src/sage/groups/all__sagemath_groups.py, importing things like >from sage.groups.generic import (discrete_log, discrete_log_rho, >discrete_log_lambda, linear_relation, multiple, multiples, >order_from_multiple) > >All of these are then imported by src/sage/all__sagemath_categories.py > >I don't think that I understand the purpose of sagemath_categories. > >Martin >On Friday 27 September 2024 at 22:38:44 UTC+2 Matthias Koeppe wrote: > >> On Friday, September 27, 2024 at 1:02:50 PM UTC-7 Dima Pasechnik wrote: >> >> This PR bundles together totally unrelated things. >> >> >> No, it does not. >> >> >> What do sagemath-objects and sagemath-categories have to do with demoting >> brial to optional? >> >> >> *sagemath-objects* and *sagemath-categories *are basic distributions that >> are at the bottom of the dependency graph (see diagram in >> https://github.com/sagemath/sage/pull/35095). >> >> Now the distribution *sagemath-brial* depends on a larger set of >> extension modules than what is currently shipped in *sagemath-objects* >> and *sagemath-categories. *(What is currently shipped is a set of modules >> that was ready as of Sage 9.6; >> https://github.com/sagemath/sage/issues/29865). >> >> Hence I have set the scope of this PR to enlarge *sagemath-objects* and >> *sagemath-categories* to be more useful. This includes but is not limited >> to be suitable as a build dependency for *sagemath-brial*. >> >> > >-- >You received this message because you are subscribed to the Google Groups >"sage-devel" group. >To unsubscribe from this group and stop receiving emails from it, send an >email to sage-devel+unsubscr...@googlegroups.com. >To view this discussion on the web visit >https://groups.google.com/d/msgid/sage-devel/861373f8-5423-4acd-b508-0d9f371f7955n%40googlegroups.com. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/8BD62C49-4A3E-4BF6-A911-B9C8FE0C96E8%40gmail.com.
