Hi! Vincent Delecroix and I are recalling different advices concerning "how to review a ticket that has dependencies". Since I think the question is important, I'd like to get a clarification of our policy.
Assume there is ticket 1234 that depends on ticket 987. Moreover, assume that 987 needs work. Would it still be possible to give a positive review to 1234? Of course, 1234 would only be merged after 987 received a positive review, too. I recall that in the past (but it could be a sweet memory from pre-git era) I was told that it *is* possible: The review of 1234 is (at least as a rule of thumb) based on the changes introduced in 1234 on top of its dependencies. However, Vincent recalls the opposite. It seems that the question of tickets with dependencies hasn't been addressed explicitly in "The reviewer's checklist". It is advised to "Read the diff", which can be obtained by clicking on the branch name --- this would imply that "diff" means "diff with respect to the current beta", but not "diff with respect to the ticket dependencies". Since "explicit is better than implicit", I think the answers given here should eventually be included in the reviewer's checklist. Best regards, Simon -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
