On Tuesday, January 28, 2014 10:21:41 AM UTC+1, John Cremona wrote: > > On 28 January 2014 09:17, Jean-Pierre Flori <[email protected]<javascript:>> > wrote: > > > > > > On Tuesday, January 28, 2014 10:10:40 AM UTC+1, John Cremona wrote: > >> > >> On 27 January 2014 20:55, Jean-Pierre Flori <[email protected]> wrote: > >> > > >> > > >> > On Sunday, January 26, 2014 6:12:38 PM UTC+1, John Cremona wrote: > >> >> > >> >> Thanks for the quick reply! > >> >> > >> >> On 26 January 2014 17:02, Volker Braun <[email protected]> wrote: > >> >> > I think we don't allow dashes in version numbers, only numbers and > >> >> > dots. > >> >> > It > >> >> > might be version 01-26 of eclib-2014 etc... > >> >> > > >> > > >> > Yes, it seems dashes break our scripts. > >> > We have the smae problem with singular whose upstream version > numbering > >> > is > >> > 3-1-6 rather than the usual 3.1.6 > >> > >> Luckily in this case I can easily change the convention for eclib's > >> version numbering! > >> > >> A more complicated version of our scripts should surely be able to > >> handle this given that we have a whole file dedicated to the text of > >> the package version? > >> > > Sure. > > IIRC the regexp currently used to split out the package name from the > > package version looks for the last dash. > > Maybe the first dash followed by a number would be more sensible. > > But of course someone could always craft a package name which will > defeat > > the regexp... > > I was thinking that the package-version.txt could be used to define > exactly what string to but between the package name (e.g. eclib) and > suffix (e.g. .tar.gz or .tar .bz2) to determine the current upstream > tarball filename. If there is a patch level that could be defined > seprately, say on a second line in the same file or in a second file > called patch-level.txt (default none if the file does not exist). > Oh sure! That's much smarter... The dash problem is indeed an artifact of the way we used to deal with spkg tarballs... We now have the package name as the directory name and the version number within the txt file. I don't have a strong opinion about splitting the patch level into a different txt file.
-- You received this message because you are subscribed to the Google Groups "sage-git" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
