Hi Nathann, after this line (line 9520 in http://trac.sagemath.org/sage_trac/attachment/ticket/11735/trac_11735.patch): g.delete_vertices([vv for vv in g.neighbors(v) if vv != y and vv != x]) How can one be sure that x and y are still connected? (otherwise no path x -- y exists) I don't know whether this holds for the current code. In the paper another method of choosing v,x,y is described, and the authors prove that x,y stay connected. For the patch, I'm not familiar with the version control system used and unfortunately I don't have time to learn it now.
Regards, Jan On Sep 1, 6:23 pm, Nathann Cohen <nathann.co...@gmail.com> wrote: > Hello ! > > I'm finally back to the civilisation if you want us to deal with this patch > :-) > > Nathann > > On 29 August 2011 15:46, Nathann Cohen <nathann.co...@gmail.com> wrote: > > > Hello Jan !!! > > > I am sorry for my veeeery slow answers, I am on vacation right now, with > > very very bad WiFi connections when I get some. If you think you would sleep > > better with copying the implementation given in the paper, then the best is > > probably to write a patch for this. I like mine better, just because I feel > > like I understand how it works, but to be honest I do not really mind in > > this case as it is sooooo easy to check whether the code is correct. What > > would you think of writing a patch to change the current behaviour to match > > the paper using your code, while letting my version of it (the updated/fixed > > one) in the code as a comment ? > > > Before returning the result, it should be checked, for instance like I did > > in my patch. If at some point the value returned is incorrect, the exception > > should be > > "There was an error in the computed answer... Please report the bug" or > > something alike so that we quickly learn of it and fix the mistake. What do > > you think ? > > > What I fear the most are silent mistakes.. The ones you do not notice. In > > these situations I don't mind Sage answering me that it wasn't able to do > > the computations, especially when the patch is already written :-) > > > If you have time to create the patch, I will try to review it as soon as I > > get back to the civilisation (possibly next friday). Otherwise we'll talk > > about it then :-) > > > Thank you for your work, by the way ! > > > Nathann -- To post to this group, send email to sage-support@googlegroups.com To unsubscribe from this group, send email to sage-support+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-support URL: http://www.sagemath.org
