Greg Smith:

> Things looked fine until I reached:
>
> Document::charClassification Document::WordCharClass(unsigned char ch) {
>         if ((SC_CP_UTF8 == dbcsCodePage) && (ch >= 0x80))
>                 return ccWord;
>         return charClass[ch];
> }

   The CharClassify class could either gain a flag to determine that
it is in UTF-8 mode or Document could set values 0x80 to 0xFF to
ccWord whenever in UTF-8.

> 2) Having moved enum charClassification into class charClassify, it is now a
> very ugly:
>
>    charClassify::charClassification
>
> when used in Document. Perhaps charClassify::Class would be less of a
> mouthful, or you may have a preference.

   I'd prefer something longer than "cc" but "Class" is too close to
the keyword.

   Neil

_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest

Reply via email to