On Tue, Apr 7, 2009 at 1:42 PM, Mark Struberg <[email protected]> wrote:
>
> Hi Imran!
>
> What is the special usecase for this?
> Maybe multi-module builds where the current pom is only 1 sub-module of the
> whole build?
>
It is not a special case but the usual case that I am want it to work
as it should :). Lets think of a multi-module build or a project that
has the pom.xml in a sub-directory of the project. I will try to
explain more with 2 examples.
First, a single module project. Let us suppose that we have a project
tree as follows:
root
|->project
|->pom.xml
|->some_other_stuff
Now when maven will take changelog of it the history rationally should
include only histories of the changes under 'project' sub-tree and not
of all the project. Adding the '.' will do just that.
Secondly, let us take a multi-module project. In that case when a
changelog is requested it should show the changes made to that tree,
and not whole project. Adding the '.' will do just that.
> I'm not really sure if we can safely assume to always execute in the modules
> path. To be honest, I doubt it! I have something in my mind, but I'm not sure
> which case it was. Maybe CI builds, hmmm? In those cases a single '.' would
> not be sufficient.
>
I would be grateful if you would kindly state an example where it
would not be sufficient with the change and was without it.
> And there is a really subtle difference with git in releasing multi-module
> builds.
>
Yes that is true, but I do not see that effecting release process :).
> As you know, Git only handles full trees and not single files. So the
> behaviour of a release differes if the git repo contains all the modules
> (including parent) or if there is a git-submodule involved.
>
What I am not sure how does it adversely effect release behavior? It
is not clear to me.
> So there are most probably still a few things left to do.
>
Please point them out and I will gladly help out. But this is a change
I think would be beneficial to many not to mention that I am eagerly
waiting to see its introduction :). Without this in a multi-module
scenario changelog does not make much (if any at all) sense.
Thank you,
> LieGrue,
> strub
>
> --- Imran M Yousuf <[email protected]> schrieb am Di, 7.4.2009:
>
>> Von: Imran M Yousuf <[email protected]>
>> Betreff: [PATCH] Git Change log takes current path into account
>> An: [email protected]
>> CC: "Mark Struberg" <[email protected]>
>> Datum: Dienstag, 7. April 2009, 5:23
>> Hi,
>>
>> I was just checking the commands generated by git changelog
>> and I
>> noticed that it does not respect the path, whereas it is
>> very easy to
>> integrate it, mentioning a simple '.' at the end of the
>> 'git
>> whatchanged' command does the trick and thats what the
>> attached patch
>> does.
>>
>> I would be grateful if this would be integrated with the
>> current
>> version as this change has a grave positive effect on maven
>> site's
>> changelog report.
>>
>> Thank you,
>>
>> --
>> Imran M Yousuf
>> Entrepreneur & Software Engineer
>> Smart IT Engineering
>> Dhaka, Bangladesh
>> Email: [email protected]
>> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>> Mobile: +880-1711402557
>>
>
>
>
>
--
Imran M Yousuf
Entrepreneur & Software Engineer
Smart IT Engineering
Dhaka, Bangladesh
Email: [email protected]
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557
