RE: [lang] next version etc
-Original Message- From: Henri Yandell [mailto:[EMAIL PROTECTED] Sent: Friday, April 14, 2006 6:04 PM To: Jakarta Commons Developers List Subject: [lang] next version etc I want to do something fun...so how about a Lang release. First up; 2.2 or 3.0? It would be nice to have one without enum and the other deprecated bits. IMO: 2.2, then 3.0 which removes 'enum' and anything that Java 5/6 complains about. Or... The ticket list below is long and diverse in scope and time needed. A possible release early, release often track could be: - Release 2.2 now, with only critical fixes. Time frame: now=weeks. - Release 2.3: implement easy fixes and apply no-brainer patches. Time frame: +1 month. - Release 2.4: implement trickier new features that require discussion and time to implement. Time frame: Months. - Release 3.0: - discuss breaking the API by removing deprecated methods? - discuss changing the base JRE requirement? - discuss deprecating any date/time code that can be replaced with Joda-Time. - builds/works on Java 5? - builds/works on Java 6? Some brief comments on some of the list items: Second up; text? I think it needs to go into our next version regardless of version number, or we need to decide to drop it. I will use text.VariableFormatter in our product. If 2.2 does not come out soon, I am going to pluck it out of there for our own use ;) I have no plans to use the Str* classes though. Third, bugs. Here're my thoughts: 20015: WONTIFX? Gary's on making Entities public. Looks like a lump of work to do, is it likely to happen or should we just decide that Entities shouldn't be public? I don't recall user's being desperate to use this class. Release early, release often. Let's leave this one for later. 26659: WONTFIX? Seems like too much in the way of date work - suggest JODA instead unless a patch is offered. I use Joda-Time now. I would even like to propose deprecating DateUtils 'softly' in favor of Joda-Time. I am sure many will not like this at all since Joda-Time is pretty large. 29692: Patch recently added. Consider and either apply or WONTFIX. Seems too specific/complex. 30082: WONTFIX. This is too specific an issue to be putting in Lang I believe. I agreed. 30184: Consider for lang.text. There are no unit tests provided (I know, the class is pretty simple). 31602: Sean/Stephen, thoughts? Should we WONTFIX as too complicated, or is it simple enough and we can do it? 33102: FIX: On the one hand, it's pretty simple stuff, and we'd have to support the roll(..) method. On the other hand, user's like this stuff and it's not hard to add it, even if we overload with Calendar as well. 4 methods would be needed. +0. Joda-Time? 33401: FIX: it's a bit redundant, but I've no reason not to have these methods available. Any -1s? Needs better method names IMO. -0. I'm always in favor of release early, release often when there are no unit tests with a code proposal ;) 33609: FIX. Javadoc needs improving. Nothing wrong with better docs! :) 33825: WONTFIX. Standard java.time question - is it valuable and simple, or should we just point to JODA? I'm going to go with WONTFIX as my default answer on time enhancements. I'm with you: Joda-Time. 33889: Unsure. Could be a CharSet enhancement instead of just a camel case method. Thoughts? 33997: I think this is a useful method - just need to make sure the implementation is the best possible. What about commons-math? 34284: FIX: NullPointer; test and fix. 34351: FIX: I don't see any reason not to try to write Albert's method. If not obvious when digging into it, then we can WONTFIX. 35400: WONTFIX. I'm -1 to a new classloader in lang, starts to leave the scope of 'simple' to my ignorant brain :) 35588: Part of the lang.text call. I need text.VariableFormatter. If 2.2 does not come out soon, I am going to pluck it out of there for our own use ;) 35826: Bring up with [math]. I think it could be in either, not sure I have the itch to write a BigXxx replacement though. Indeed, what does [math] think about that? It would be interesting to know what the [math] folks think about project boundaries for class like that. 36061: FIX. Seems simple enough - bug and patches. Some of these bugs might be obsolete. I thought I'd take care of object cycles a while back. Hm, but that might have been for the ReflectionToStringBuilder class, not the ToStringBuilder. 36512: FIX. I think there's value for a .forName improvement. Personally, I would only do the super simple stuff, primitives I suppose. Arrays of primitives ok... Basically, anything that you can say in Java code: int, int[]. Yeah, that's nice. But I would not want to have us invent a mini-language which the talk of eating up spaces starts to feel like. My vote would be to keep it simple in the first cut, if it is there at all. 3: Thoughts? Is it worth putting that inside the
svn commit: r394443 - /jakarta/commons/proper/jexl/trunk/xdocs/reference/syntax.xml
Author: dion
Date: Sun Apr 16 01:35:04 2006
New Revision: 394443
URL: http://svn.apache.org/viewcvs?rev=394443view=rev
Log:
Add bitwise operators, conditionals
Modified:
jakarta/commons/proper/jexl/trunk/xdocs/reference/syntax.xml
Modified: jakarta/commons/proper/jexl/trunk/xdocs/reference/syntax.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/xdocs/reference/syntax.xml?rev=394443r1=394442r2=394443view=diff
==
--- jakarta/commons/proper/jexl/trunk/xdocs/reference/syntax.xml (original)
+++ jakarta/commons/proper/jexl/trunk/xdocs/reference/syntax.xml Sun Apr 16
01:35:04 2006
@@ -29,6 +29,7 @@
lia href=#LiteralsLiterals/a/li
lia href=#FunctionsFunctions/a/li
lia href=#OperatorsOperators/a/li
+ lia href=#ConditionalConditional Statements/a/li
/ol
/p
p
@@ -71,7 +72,7 @@
tr
tdScripts/td
td
-A script in Jexl is made up of zero or more statements.
+A script in Jexl is made up of zero or more statements. Scripts
can be read from a String, File or URL.
/td
/tr
tr
@@ -189,10 +190,38 @@
/td
/tr
tr
+ tdBitwise codeand/code/td
+ td
+The usual codeamp;/code operator is used, e.g.
+source33 amp; 4/source, 0010 0001 amp; 0100 = 0.
+ /td
+/tr
+tr
+ tdBitwise codeor/code/td
+ td
+The usual code|/code operator is used, e.g.
+source33 | 4/source, 0010 0001 | 0100 = 0010 0101 = 37.
+ /td
+/tr
+tr
+ tdBitwise codexor/code/td
+ td
+The usual code^/code operator is used, e.g.
+source33 ^ 4/source, 0010 0001 ^ 0100 = 0010 0100 = 37.
+ /td
+/tr
+tr
+ tdBitwise codecomplement/code/td
+ td
+The usual code~/code operator is used, e.g.
+source~33/source, ~0010 0001 = 1101 1110 = -34.
+ /td
+/tr
+tr
tdEquality/td
td
The usual code==/code operator can be used as well as the
abbreviation codeeq/code.
-For example
+For example
sourceval1 == val2/source and
sourceval1 eq val2/source are equivalent.
ol
@@ -315,6 +344,34 @@
/tr
/table
/section
+section name=Conditional
+ table
+trth width=15%Operator/ththDescription/th/tr
+tr
+ tdif/td
+ td
+Classic, if/else statement, e.g.
+codeif ((x * 2) == 5) {y = 1;} else {y = 2;}/code
+ /td
+/tr
+tr
+ tdforeach/td
+ td
+Loop through items of an Array, Collection, Map, Iterator or
Enumeration, e.g.
+codeforeach (item in list) { x = x + item; }/code
+Where codeitem/code and codelist/code are variables.
+ /td
+/tr
+tr
+ tdwhile/td
+ td
+Loop until a condition is satisfied, e.g.
+codewhile (x lt 10) { x = x + 2; }/code
+ /td
+/tr
+ /table
+/section
+
/body
/document
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39314] - [pool] Pool grows beyond poolsize with WHEN_EXHAUSTED_BLOCK
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39314. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39314 --- Additional Comments From [EMAIL PROTECTED] 2006-04-16 10:26 --- (In reply to comment #6) First, there is no pool size setting in GenericObjectPool. This bug report is based on the incorrect assumption that there is such a thing. There are maxActive and maxIdle settings but they are not the same thing as the pool size. OK, please tell me then, how can I have the naive pool concept given in Wikipedia with commons pool, i.e. a finite set of initialised objects that can be requested from the pool and be returned to the pool? Concrete, how can commons pool manage a finite pool of 20 LDAP connections? Which pool implementation should I use, so that makeObject() only gets called 20 times and there are only 20 LDAP connections in the pool? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-xml-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-xml-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 101 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-xml-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/gump_work/build_commons-jelly_commons-jelly-tags-xml-test.html Work Name: build_commons-jelly_commons-jelly-tags-xml-test (Type: Build) Work ended in a state of : Failed Elapsed: 18 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-16042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-16042006.jar - [junit] [junit] [junit] Testcase: testImportResourcesFromUncompiledScript(org.apache.commons.jelly.tags.xml.TestImport): FAILED [junit] expected:... xmlns=http://www.w3.org/TR/xhtml1/strict;... but was:.. [junit] junit.framework.ComparisonFailure: expected:... xmlns=http://www.w3.org/TR/xhtml1/strict;... but was:.. [junit] at org.apache.commons.jelly.tags.xml.TestImport.testImportResourcesFromUncompiledScript(TestImport.java:77) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] [junit] [junit] [ERROR] TEST org.apache.commons.jelly.tags.xml.TestImport FAILED [junit] Running org.apache.commons.jelly.tags.xml.TestXMLTags [junit] Tests run: 19, Failures: 0, Errors: 0, Time elapsed: 3.033 sec [junit] Testsuite: org.apache.commons.jelly.tags.xml.TestXMLTags [junit] Tests run: 19, Failures: 0, Errors: 0, Time elapsed: 3.033 sec [junit] [junit] - Standard Output --- [junit] TestXMLTags.testNamespaceReplace() text=test-node xmlns:test=http://apache/testNS; xmlns=http://java/ns; test:abc=testValuetest-subnode xmlns= attr=testtest-anotherSubNode/test-anotherSubNodetest-anotherSubNodeAgain xmlns:other=http://java/ns; xmlns=http://java/ns; other:abc=testValue/test-anotherSubNodeAgain/test-subnodetest-subnode attr=testtest-anotherSubNode/test-anotherSubNodetest-anotherSubNodeAgain xmlns:other=http://java/ns; other:abc=testValue/test-anotherSubNodeAgain/test-subnode/test-node [junit] top-node xmlns=abctest-node xmlns:test=http://apache/testNS; xmlns=http://apache/trueNS; test:abc=testValue abc2=testValue abc3=testValuetest:test-subnodenode-at-same-ns-as-top xmlns=abc/node-at-same-ns-as-top/test:test-subnode/test-node/top-node [junit] top-nodetest-node xmlns:test=http://apache/testNS; xmlns=http://apache/trueNS; test:abc=testValue abc2=testValue
[EMAIL PROTECTED]: Project commons-jelly-tags-xml-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-xml-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 101 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-xml-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/gump_work/build_commons-jelly_commons-jelly-tags-xml-test.html Work Name: build_commons-jelly_commons-jelly-tags-xml-test (Type: Build) Work ended in a state of : Failed Elapsed: 18 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-16042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-16042006.jar - [junit] [junit] [junit] Testcase: testImportResourcesFromUncompiledScript(org.apache.commons.jelly.tags.xml.TestImport): FAILED [junit] expected:... xmlns=http://www.w3.org/TR/xhtml1/strict;... but was:.. [junit] junit.framework.ComparisonFailure: expected:... xmlns=http://www.w3.org/TR/xhtml1/strict;... but was:.. [junit] at org.apache.commons.jelly.tags.xml.TestImport.testImportResourcesFromUncompiledScript(TestImport.java:77) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] [junit] [junit] [ERROR] TEST org.apache.commons.jelly.tags.xml.TestImport FAILED [junit] Running org.apache.commons.jelly.tags.xml.TestXMLTags [junit] Tests run: 19, Failures: 0, Errors: 0, Time elapsed: 3.033 sec [junit] Testsuite: org.apache.commons.jelly.tags.xml.TestXMLTags [junit] Tests run: 19, Failures: 0, Errors: 0, Time elapsed: 3.033 sec [junit] [junit] - Standard Output --- [junit] TestXMLTags.testNamespaceReplace() text=test-node xmlns:test=http://apache/testNS; xmlns=http://java/ns; test:abc=testValuetest-subnode xmlns= attr=testtest-anotherSubNode/test-anotherSubNodetest-anotherSubNodeAgain xmlns:other=http://java/ns; xmlns=http://java/ns; other:abc=testValue/test-anotherSubNodeAgain/test-subnodetest-subnode attr=testtest-anotherSubNode/test-anotherSubNodetest-anotherSubNodeAgain xmlns:other=http://java/ns; other:abc=testValue/test-anotherSubNodeAgain/test-subnode/test-node [junit] top-node xmlns=abctest-node xmlns:test=http://apache/testNS; xmlns=http://apache/trueNS; test:abc=testValue abc2=testValue abc3=testValuetest:test-subnodenode-at-same-ns-as-top xmlns=abc/node-at-same-ns-as-top/test:test-subnode/test-node/top-node [junit] top-nodetest-node xmlns:test=http://apache/testNS; xmlns=http://apache/trueNS; test:abc=testValue abc2=testValue
[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-html has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 101 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-html : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-html-16042006.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build) Work ended in a state of : Failed Elapsed: 12 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-16042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-html has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 101 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-html : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-html-16042006.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build) Work ended in a state of : Failed Elapsed: 12 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-16042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 101 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-16042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:102) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 101 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-16042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:102) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78) [junit] at
svn commit: r394457 - /jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
Author: skitching
Date: Sun Apr 16 04:27:11 2006
New Revision: 394457
URL: http://svn.apache.org/viewcvs?rev=394457view=rev
Log:
Fix error where getResources() would return parent items first, even when
parentFirst attribute was set to false.
Modified:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
Modified:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java?rev=394457r1=394456r2=394457view=diff
==
---
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
(original)
+++
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
Sun Apr 16 04:27:11 2006
@@ -21,8 +21,9 @@
import java.io.InputStream;
import java.net.URL;
import java.net.URLClassLoader;
-
-// TODO: use HashTable instead of HashMap for java1.1 support
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Enumeration;
import java.util.HashMap;
import java.util.Iterator;
import java.util.Map;
@@ -232,6 +233,25 @@
return local;
}
return super.getResource(name);
+}
+}
+
+/**
+ * Same as parent class method except that when parentFirst is false
+ * any resources in the local classpath are returned before resources
+ * in the parent.
+ */
+public Enumeration getResources(String name) throws IOException {
+if (parentFirst) {
+return super.getResources(name);
+} else {
+Enumeration localUrls = super.findResources(name);
+Enumeration parentUrls = getParent().getResources(name);
+
+ArrayList localItems = Collections.list(localUrls);
+ArrayList parentItems = Collections.list(parentUrls);
+localItems.addAll(parentItems);
+return Collections.enumeration(localItems);
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-fmt (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-fmt has an issue affecting its community integration. This issue affects 6 projects, and has been outstanding for 7 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-javaflow : Commons Javaflow - commons-jelly-tags-fmt : Commons Jelly - jaxme2 - jaxmeapi - jaxmejs - jaxmexs Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-fmt-16042006.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt/gump_work/build_commons-jelly_commons-jelly-tags-fmt.html Work Name: build_commons-jelly_commons-jelly-tags-fmt (Type: Build) Work ended in a state of : Failed Elapsed: 13 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-commands-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-classpath-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-core-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-bsf-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-reflect-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-util-2.0b4.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/beanshell/target/commons-jelly-tags-beanshell-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-16042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124) [junit] at java.net.URLClassLoader.defineClass(URLClassLoader.java:260) [junit] at java.net.URLClassLoader.access$100(URLClassLoader.java:56) [junit] at java.net.URLClassLoader$1.run(URLClassLoader.java:195) [junit] at java.security.AccessController.doPrivileged(Native Method) [junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:188) [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:306) [junit] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:268) [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:251) [junit] at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319) [junit] at org.apache.commons.jelly.tags.ant.AntTagLibrary.createProject(AntTagLibrary.java:127) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-fmt (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-fmt has an issue affecting its community integration. This issue affects 6 projects, and has been outstanding for 7 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-javaflow : Commons Javaflow - commons-jelly-tags-fmt : Commons Jelly - jaxme2 - jaxmeapi - jaxmejs - jaxmexs Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-fmt-16042006.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt/gump_work/build_commons-jelly_commons-jelly-tags-fmt.html Work Name: build_commons-jelly_commons-jelly-tags-fmt (Type: Build) Work ended in a state of : Failed Elapsed: 13 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-commands-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-classpath-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-core-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-bsf-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-reflect-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-util-2.0b4.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/beanshell/target/commons-jelly-tags-beanshell-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-16042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124) [junit] at java.net.URLClassLoader.defineClass(URLClassLoader.java:260) [junit] at java.net.URLClassLoader.access$100(URLClassLoader.java:56) [junit] at java.net.URLClassLoader$1.run(URLClassLoader.java:195) [junit] at java.security.AccessController.doPrivileged(Native Method) [junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:188) [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:306) [junit] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:268) [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:251) [junit] at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319) [junit] at org.apache.commons.jelly.tags.ant.AntTagLibrary.createProject(AntTagLibrary.java:127) [junit] at
svn commit: r394459 - /jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/PriorityConfigTestCase.java
Author: skitching
Date: Sun Apr 16 04:34:33 2006
New Revision: 394459
URL: http://svn.apache.org/viewcvs?rev=394459view=rev
Log:
Update javadoc only
Modified:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/PriorityConfigTestCase.java
Modified:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/PriorityConfigTestCase.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/PriorityConfigTestCase.java?rev=394459r1=394458r2=394459view=diff
==
---
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/PriorityConfigTestCase.java
(original)
+++
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/PriorityConfigTestCase.java
Sun Apr 16 04:34:33 2006
@@ -30,6 +30,15 @@
/**
* Tests that verify that the process of configuring logging on startup
* works correctly by selecting the file with the highest priority.
+ * p
+ * This test sets up a classpath where:
+ * ul
+ * li first file (in parent loader) has priority=10 (parentFirst=true)
+ * li second file found has no priority set
+ * li third file found has priority=20
+ * li fourth file found also has priority=20
+ * /ul
+ * The result should be that the third file is used.
*/
public class PriorityConfigTestCase extends TestCase {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394460 - /jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
Author: skitching
Date: Sun Apr 16 04:35:22 2006
New Revision: 394460
URL: http://svn.apache.org/viewcvs?rev=394460view=rev
Log:
Add unit test to verify that priority of first-found config file is respected
Added:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
(with props)
Added:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java?rev=394460view=auto
==
---
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
(added)
+++
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
Sun Apr 16 04:35:22 2006
@@ -0,0 +1,119 @@
+/*
+ * Copyright 2006 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.logging.config;
+
+
+import java.net.URL;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+
+import org.apache.commons.logging.LogFactory;
+import org.apache.commons.logging.PathableClassLoader;
+import org.apache.commons.logging.PathableTestSuite;
+
+
+/**
+ * Tests that verify that the process of configuring logging on startup
+ * works correctly by selecting the file with the highest priority.
+ * p
+ * This test sets up a classpath where:
+ * ul
+ * li first file found has priority=20
+ * li second file (in parent path) has priority=10 (parentFirst=false)
+ * /ul
+ * The result should be that the first file is used.
+ */
+
+public class FirstPriorityConfigTestCase extends TestCase {
+
+// --- JUnit Infrastructure Methods
+
+
+/**
+ * Return the tests included in this test suite.
+ */
+public static Test suite() throws Exception {
+Class thisClass = PriorityConfigTestCase.class;
+
+// Determine the URL to this .class file, so that we can then
+// append the priority dirs to it. For tidiness, load this
+// class through a dummy loader though this is not absolutely
+// necessary...
+PathableClassLoader dummy = new PathableClassLoader(null);
+dummy.useSystemLoader(junit.);
+dummy.addLogicalLib(testclasses);
+dummy.addLogicalLib(commons-logging);
+
+String thisClassPath = thisClass.getName().replace('.', '/') +
.class;
+URL baseUrl = dummy.findResource(thisClassPath);
+
+// Now set up the desired classloader hierarchy. We'll put a config
+// file of priority=10 in the container path, and ones of both
+// no priority and priority=20 in the webapp path.
+//
+// A second properties file with priority=20 is also added,
+// so we can check that the first one in the classpath is
+// used.
+PathableClassLoader containerLoader = new PathableClassLoader(null);
+containerLoader.useSystemLoader(junit.);
+containerLoader.addLogicalLib(commons-logging);
+
+URL pri10URL = new URL(baseUrl, priority10/);
+containerLoader.addURL(pri10URL);
+
+PathableClassLoader webappLoader = new
PathableClassLoader(containerLoader);
+webappLoader.setParentFirst(false);
+webappLoader.addLogicalLib(testclasses);
+
+URL pri20URL = new URL(baseUrl, priority20/);
+webappLoader.addURL(pri20URL);
+
+// load the test class via webapp loader, and use the webapp loader
+// as the tccl loader too.
+Class testClass = webappLoader.loadClass(thisClass.getName());
+return new PathableTestSuite(testClass, webappLoader);
+}
+
+/**
+ * Set up instance variables required by this test case.
+ */
+public void setUp() throws Exception {
+LogFactory.releaseAll();
+}
+
+/**
+ * Tear down instance variables required by this test case.
+ */
+public void tearDown() {
+LogFactory.releaseAll();
+}
+
+// --- Test Methods
+
+/**
+ * Verify that the config file being used is the one containing
+ * the desired configId value.
+ */
+
[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-define-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 101 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-define-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build) Work ended in a state of : Failed Elapsed: 13 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-16042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:118) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208) [junit] at junit.framework.TestSuite.run(TestSuite.java:203) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536) [junit] Apr 16, 2006 4:23:13 AM org.apache.commons.jelly.expression.xpath.XPathExpression evaluate [junit] SEVERE: Error constructing xpath [junit] org.jaxen.XPathSyntaxException: Node-set expected [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:131) [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:156) [junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101) [junit] at org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78) [junit] at org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] at junit.framework.TestCase.runBare(TestCase.java:127) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-define-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 101 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-define-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build) Work ended in a state of : Failed Elapsed: 13 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-16042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-16042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-16042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:118) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208) [junit] at junit.framework.TestSuite.run(TestSuite.java:203) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536) [junit] Apr 16, 2006 4:23:13 AM org.apache.commons.jelly.expression.xpath.XPathExpression evaluate [junit] SEVERE: Error constructing xpath [junit] org.jaxen.XPathSyntaxException: Node-set expected [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:131) [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:156) [junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101) [junit] at org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78) [junit] at org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] at junit.framework.TestCase.runBare(TestCase.java:127) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at
svn commit: r394461 - /jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Author: skitching
Date: Sun Apr 16 04:36:37 2006
New Revision: 394461
URL: http://svn.apache.org/viewcvs?rev=394461view=rev
Log:
Fix bug where priority of first commons-logging.properties file found was
ignored.
Also improve diagnostics output.
Modified:
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Modified:
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java?rev=394461r1=394460r2=394461view=diff
==
---
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
(original)
+++
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Sun Apr 16 04:36:37 2006
@@ -1387,16 +1387,39 @@
if (newProps != null) {
if (props == null) {
props = newProps;
+String priorityStr = props.getProperty(PRIORITY_KEY);
+priority = 0.0;
+if (priorityStr != null) {
+priority = Double.parseDouble(priorityStr);
+}
+
+if (isDiagnosticsEnabled()) {
+logDiagnostic(
+[LOOKUP] First properties file found at ' +
url + ');
+}
} else {
String newPriorityStr =
newProps.getProperty(PRIORITY_KEY);
+double newPriority = 0.0;
if (newPriorityStr != null) {
-double newPriority =
Double.valueOf(newPriorityStr).doubleValue();
-if (newPriority priority) {
-props = newProps;
-priority = newPriority;
+newPriority = Double.parseDouble(newPriorityStr);
+}
+
+if (newPriority priority) {
+props = newProps;
+priority = newPriority;
+
+if (isDiagnosticsEnabled()) {
+logDiagnostic(
+[LOOKUP] New properties file found at '
+ url + '
++ has higher priority than earlier
file.);
}
+} else {
+logDiagnostic(
+[LOOKUP] New properties file found at ' +
url + '
++ has less priority than earlier file --
ignoring.);
}
}
+
}
}
} catch (SecurityException e) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394462 - /jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Author: skitching
Date: Sun Apr 16 04:43:29 2006
New Revision: 394462
URL: http://svn.apache.org/viewcvs?rev=394462view=rev
Log:
Improve diagnostics
Modified:
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Modified:
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java?rev=394462r1=394461r2=394462view=diff
==
---
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
(original)
+++
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Sun Apr 16 04:43:29 2006
@@ -1373,6 +1373,7 @@
Properties props = null;
double priority = 0.0;
+URL propsUrl = null;
try {
Enumeration urls = getResources(classLoader, fileName);
@@ -1386,6 +1387,7 @@
Properties newProps = getProperties(url);
if (newProps != null) {
if (props == null) {
+propsUrl = url;
props = newProps;
String priorityStr = props.getProperty(PRIORITY_KEY);
priority = 0.0;
@@ -1395,7 +1397,8 @@
if (isDiagnosticsEnabled()) {
logDiagnostic(
-[LOOKUP] First properties file found at ' +
url + ');
+[LOOKUP] Properties file found at ' + url +
'
++ with priority + priority);
}
} else {
String newPriorityStr =
newProps.getProperty(PRIORITY_KEY);
@@ -1405,18 +1408,27 @@
}
if (newPriority priority) {
+if (isDiagnosticsEnabled()) {
+if (isDiagnosticsEnabled()) {
+logDiagnostic(
+[LOOKUP] Properties file at ' + url
+ '
++ with priority + newPriority
++ overrides file at ' + propsUrl +
'
++ with priority + priority);
+}
+}
+
+propsUrl = url;
props = newProps;
priority = newPriority;
-
+} else {
if (isDiagnosticsEnabled()) {
logDiagnostic(
-[LOOKUP] New properties file found at '
+ url + '
-+ has higher priority than earlier
file.);
+[LOOKUP] Properties file at ' + url + '
++ with priority + newPriority
++ does not override file at ' +
propsUrl + '
++ with priority + priority);
}
-} else {
-logDiagnostic(
-[LOOKUP] New properties file found at ' +
url + '
-+ has less priority than earlier file --
ignoring.);
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394463 - /jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
Author: skitching
Date: Sun Apr 16 05:01:57 2006
New Revision: 394463
URL: http://svn.apache.org/viewcvs?rev=394463view=rev
Log:
Handle case of null parent classloader
Modified:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
Modified:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java?rev=394463r1=394462r2=394463view=diff
==
---
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
(original)
+++
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
Sun Apr 16 05:01:57 2006
@@ -246,7 +246,22 @@
return super.getResources(name);
} else {
Enumeration localUrls = super.findResources(name);
-Enumeration parentUrls = getParent().getResources(name);
+
+ClassLoader parent = getParent();
+if (parent == null) {
+// Alas, there is no method to get matching resources
+// from a null (BOOT) parent classloader. Calling
+// ClassLoader.getSystemClassLoader isn't right. Maybe
+// calling Class.class.getResources(name) would do?
+//
+// However for the purposes of unit tests, we can
+// simply assume that no relevant resources are
+// loadable from the parent; unit tests will never be
+// putting any of their resources in a boot classloader
+// path!
+return localUrls;
+}
+Enumeration parentUrls = parent.getResources(name);
ArrayList localItems = Collections.list(localUrls);
ArrayList parentItems = Collections.list(parentUrls);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394465 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ScriptImpl.java
Author: dion
Date: Sun Apr 16 05:10:52 2006
New Revision: 394465
URL: http://svn.apache.org/viewcvs?rev=394465view=rev
Log:
pmd cleanup
Modified:
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ScriptImpl.java
Modified:
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ScriptImpl.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ScriptImpl.java?rev=394465r1=394464r2=394465view=diff
==
---
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ScriptImpl.java
(original)
+++
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ScriptImpl.java
Sun Apr 16 05:10:52 2006
@@ -25,9 +25,9 @@
public class ScriptImpl implements Script {
/** text of the script */
-private String text;
+private final String text;
/** syntax tree */
-private ASTJexlScript parsedScript;
+private final ASTJexlScript parsedScript;
public ScriptImpl(String scriptText, ASTJexlScript scriptTree) {
text = scriptText;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394466 - /jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Author: skitching
Date: Sun Apr 16 05:11:05 2006
New Revision: 394466
URL: http://svn.apache.org/viewcvs?rev=394466view=rev
Log:
Improve diagnostic output
Modified:
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Modified:
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java?rev=394466r1=394465r2=394466view=diff
==
---
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
(original)
+++
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Sun Apr 16 05:11:05 2006
@@ -455,6 +455,12 @@
}
factory = newFactory(factoryClass, baseClassLoader,
contextClassLoader);
+} else {
+if (isDiagnosticsEnabled()) {
+logDiagnostic(
+[LOOKUP] No system property [ + FACTORY_PROPERTY
++ ] defined.);
+}
}
} catch (SecurityException e) {
if (isDiagnosticsEnabled()) {
@@ -522,6 +528,13 @@
}
factory = newFactory(factoryClassName,
baseClassLoader, contextClassLoader );
}
+} else {
+// is == null
+if (isDiagnosticsEnabled()) {
+logDiagnostic(
+[LOOKUP] No resource file with name ' +
SERVICE_ID
++ ' found.);
+}
}
} catch( Exception ex ) {
// note: if the specified LogFactory class wasn't compatible
with LogFactory
@@ -539,32 +552,37 @@
}
-// Third try a properties file.
-// If the properties file exists, it'll be read and the properties
-// used. IMHO ( costin ) System property and JDK1.3 jar service
-// should be enough for detecting the class name. The properties
-// should be used to set the attributes ( which may be specific to
-// the webapp, even if a default logger is set at JVM level by a
-// system property )
+// Third try looking into the properties file read earlier (if found)
if (factory == null) {
-if (isDiagnosticsEnabled()) {
-logDiagnostic(
-[LOOKUP] Looking for a properties file of name ' +
FACTORY_PROPERTIES
-+ ' to define the LogFactory subclass to use...);
-}
if (props != null) {
if (isDiagnosticsEnabled()) {
logDiagnostic(
-[LOOKUP] Properties file found. Looking for property
'
+[LOOKUP] Looking in properties file for entry with
key '
+ FACTORY_PROPERTY
+ ' to define the LogFactory subclass to use...);
}
String factoryClass = props.getProperty(FACTORY_PROPERTY);
if (factoryClass != null) {
+if (isDiagnosticsEnabled()) {
+logDiagnostic(
+[LOOKUP] Properties file specifies LogFactory
subclass '
++ factoryClass + ');
+}
factory = newFactory(factoryClass, baseClassLoader,
contextClassLoader);
// what about handling an exception from newFactory??
+} else {
+if (isDiagnosticsEnabled()) {
+logDiagnostic(
+[LOOKUP] Properties file has no entry specifying
LogFactory subclass.);
+}
+}
+} else {
+if (isDiagnosticsEnabled()) {
+logDiagnostic(
+[LOOKUP] No properties file available to determine
++ LogFactory subclass from..);
}
}
}
@@ -1436,9 +1454,22 @@
}
} catch (SecurityException e) {
if (isDiagnosticsEnabled()) {
-logDiagnostic(SecurityException thrown);
+logDiagnostic(SecurityException thrown while trying to
find/read config files.);
+}
+}
+
+if (isDiagnosticsEnabled()) {
+if (props == null) {
+logDiagnostic(
+[LOOKUP] No properties file of name ' +
FACTORY_PROPERTIES
++ ' found.);
+} else {
+logDiagnostic(
+[LOOKUP] Properties file of name ' + FACTORY_PROPERTIES
+
svn commit: r394467 - /jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
Author: skitching
Date: Sun Apr 16 05:15:30 2006
New Revision: 394467
URL: http://svn.apache.org/viewcvs?rev=394467view=rev
Log:
Improve diagnostics
Modified:
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
Modified:
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java?rev=394467r1=394466r2=394467view=diff
==
---
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
(original)
+++
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
Sun Apr 16 05:15:30 2006
@@ -20,6 +20,7 @@
import java.lang.reflect.Constructor;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
+import java.net.URL;
import java.util.Enumeration;
import java.util.Hashtable;
import java.util.Vector;
@@ -682,32 +683,41 @@
if (isDiagnosticsEnabled()) {
logDiagnostic([ENV] Trying to get configuration for item +
property);
}
-if (isDiagnosticsEnabled()) {
-logDiagnostic([ENV] Looking for attribute + property);
-}
+
Object valueObj = getAttribute(property);
if (valueObj != null) {
if (isDiagnosticsEnabled()) {
-logDiagnostic([ENV] Found value [ + valueObj + ] for +
property);
+logDiagnostic([ENV] Found LogFactory attribute [ + valueObj
+ ] for + property);
}
return valueObj.toString();
}
if (isDiagnosticsEnabled()) {
-logDiagnostic([ENV] Looking for system property + property);
+logDiagnostic([ENV] No LogFactory attribute found for +
property);
}
+
try {
String value = System.getProperty(property);
+if (value != null) {
+if (isDiagnosticsEnabled()) {
+logDiagnostic([ENV] Found system property [ + value + ]
for + property);
+}
+return value;
+}
+
if (isDiagnosticsEnabled()) {
-logDiagnostic([ENV] Found value [ + value + ] for +
property);
+logDiagnostic([ENV] No system property found for property +
property);
}
-return value;
} catch (SecurityException e) {
if (isDiagnosticsEnabled()) {
-logDiagnostic([ENV] Security prevented reading system
property.);
+logDiagnostic([ENV] Security prevented reading system
property + property);
}
}
-
+
+if (isDiagnosticsEnabled()) {
+logDiagnostic([ENV] No configuration defined for item +
property);
+}
+
return null;
}
@@ -749,7 +759,7 @@
throws LogConfigurationException
{
if (isDiagnosticsEnabled()) {
-logDiagnostic(Attempting to discover a Log implementation...);
+logDiagnostic(Discovering a Log implementation...);
}
initConfiguration();
@@ -760,6 +770,11 @@
String specifiedLogClassName = findUserSpecifiedLogClassName();
if (specifiedLogClassName != null) {
+if (isDiagnosticsEnabled()) {
+logDiagnostic(Attempting to load user-specified log class '
+
+specifiedLogClassName + '...);
+}
+
result = createLogFromClass(specifiedLogClassName,
logCategory,
true);
@@ -812,6 +827,11 @@
// service file in META-INF to force use of that logging lib anyway,
// rather than relying on discovery.
+if (isDiagnosticsEnabled()) {
+logDiagnostic(
+No user-specified Log implementation; performing discovery +
+using the standard supported logging implementations...);
+}
for(int i=0; (iclassesToDiscover.length) (result == null); ++i) {
result = createLogFromClass(classesToDiscover[i], logCategory,
true);
}
@@ -946,6 +966,35 @@
+ ' from classloader
+ objectId(currentCL));
try {
+if (isDiagnosticsEnabled()) {
+// show exactly where we are loading this class from.
+URL url;
+String resourceName = logAdapterClassName.replace('.',
'/') + .class;
+if (currentCL != null) {
+url = currentCL.getResource(resourceName );
+} else {
+url = ClassLoader.getSystemResource(resourceName
[logging] diagnostics, RC failure in webapp
Hi,
I've been able to reproduce the logging problem I reported earlier with
very little trouble. However I am unable to figure out *why* it's
failing.
To summarise: Class Log4JLogger is being loaded from a classloader; that
classloader can see file Log4JLogger.class fine as a resource.
Log4JLogge depends on org.apache.log4j.Category, but that is also
visible from the classloader. Yet Log4JLogger gets NoClassDefFound when
loaded. Very puzzling.
As you can see, while investigating this I found the need for some more
diagnostics so I've added them.
In particular, method createLogFromClass now uses
ClassLoader.getResource to get a URL for the logging adapter class it is
trying to load, and outputs the URL as a diagnostic. This is really
useful as it indicates which directory or jar the file is being loaded
from.
To duplicate the problem:
* install tomcat 5.5.15 (well, that's the version I'm using anyway)
* create directory
${tomcat.home}/webapps/testapp/WEB-INF/classes
${tomcat.home}/webapps/testapp/WEB-INF/lib
* place commons-logging-1.0.4.jar and log4j-1.2.12.jar in WEB-INF/lib
* place a commons-logging.properties file in WEB-INF/classes, with:
org.apache.commons.logging.Log=\
org.apache.commons.logging.impl.Log4JLogger
* overwrite ${tomcat.home}/bin/commons-logging-api.jar with the
commons-logging-1.1-RC8.jar
* export JAVA_OPTS=-Dorg.apache.commons.logging.\
diagnostics.dest=STDOUT
* start tomcat, look at ${tomcat.home}/logs/catalina.out
The (enhanced) logging clearly indicates that Log4JLogger is being
loaded from the WEB-INF/lib/commons-logging-1.0.4.jar file. However when
loadClass is called, a NoClassDefFound exception occurs whose message is
org/apache/log4j/Category. However that class clearly *is* in the
log4j jarfile in the same lib directory. Log4j has no external
dependencies, so I can't see that Category could be missing any of *its*
dependencies.
As a test I wrote a simple stand-alone app that creates a
java.net.URLClassLoader, adds commons-logging-1.0.4 and log4j.1.12, and
uses reflection to load Log4JLogger. This works fine.
I've not tried any lib versions other than the ones above, eg
log4j1.2.9.
I'll try to find time to look into this again tomorrow, but if anyone
else wants to have a shot, please do so! I'm guessing I'm missing
something very obvious but I just can't see it.
One thing I was trying to do (and failed) was to enable logging for
category org.apache.catalina.loader, as the WebappClassLoader class in
there has some potentially useful logging. I tried tweaking
${tomcat.home}/conf/logging.properties but that didn't seem to have any
effect.
Regards,
Simon
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36839] - [lang] StringUtils.splitByWholeSeparator ignores empty items
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36839. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36839 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394489 - /jakarta/commons/proper/jexl/trunk/src/conf/
Author: dion Date: Sun Apr 16 07:21:18 2006 New Revision: 394489 URL: http://svn.apache.org/viewcvs?rev=394489view=rev Log: add checkstyle header Added: jakarta/commons/proper/jexl/trunk/src/conf/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394490 - /jakarta/commons/proper/jexl/trunk/src/conf/header.txt
Author: dion Date: Sun Apr 16 07:21:26 2006 New Revision: 394490 URL: http://svn.apache.org/viewcvs?rev=394490view=rev Log: add checkstyle header Added: jakarta/commons/proper/jexl/trunk/src/conf/header.txt Added: jakarta/commons/proper/jexl/trunk/src/conf/header.txt URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/conf/header.txt?rev=394490view=auto == --- jakarta/commons/proper/jexl/trunk/src/conf/header.txt (added) +++ jakarta/commons/proper/jexl/trunk/src/conf/header.txt Sun Apr 16 07:21:26 2006 @@ -0,0 +1,15 @@ +/* + * Copyright 2002,2004 The Apache Software Foundation. + * + * Licensed under the Apache License, Version 2.0 (the License); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ \ No newline at end of file - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394491 - /jakarta/commons/proper/jexl/trunk/src/conf/header.txt
Author: dion Date: Sun Apr 16 07:22:49 2006 New Revision: 394491 URL: http://svn.apache.org/viewcvs?rev=394491view=rev Log: props Modified: jakarta/commons/proper/jexl/trunk/src/conf/header.txt (contents, props changed) Modified: jakarta/commons/proper/jexl/trunk/src/conf/header.txt URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/conf/header.txt?rev=394491r1=394490r2=394491view=diff == --- jakarta/commons/proper/jexl/trunk/src/conf/header.txt (original) +++ jakarta/commons/proper/jexl/trunk/src/conf/header.txt Sun Apr 16 07:22:49 2006 @@ -1,15 +1,15 @@ -/* - * Copyright 2002,2004 The Apache Software Foundation. - * - * Licensed under the Apache License, Version 2.0 (the License); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an AS IS BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. +/* + * Copyright 2002,2004 The Apache Software Foundation. + * + * Licensed under the Apache License, Version 2.0 (the License); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. */ Propchange: jakarta/commons/proper/jexl/trunk/src/conf/header.txt -- svn:eol-style = native Propchange: jakarta/commons/proper/jexl/trunk/src/conf/header.txt -- svn:keywords = Date Author Id Revision HeadURL - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] next version etc
-- 20015: WONTIFX? Gary's on making Entities public. Looks like a lump of work to do, is it likely to happen or should we just decide that Entities shouldn't be public? I don't recall user's being desperate to use this class. Release early, release often. Let's leave this one for later. -1.- XML at this level is out of scope -- 26659: WONTFIX? Seems like too much in the way of date work - suggest JODA instead unless a patch is offered. I use Joda-Time now. I would even like to propose deprecating DateUtils 'softly' in favor of Joda-Time. I am sure many will not like this at all since Joda-Time is pretty large. -1. There are many complications getting this kind of calculation right, and people should be forced to use a proper tool ;-) -- 29692: Patch recently added. Consider and either apply or WONTFIX. Seems too specific/complex. -1. A multiline string isn't really the same as a regular string. Its more at the business logic level to define how a multiline string works (ie. perhaps it should be a class holding a String[]) -- 30082: WONTFIX. This is too specific an issue to be putting in Lang I believe. I agree. Much of StringEscapeUtils is dubious scope for lang. Adding this doesn't help. -- 30184: Consider for lang.text. There are no unit tests provided (I know, the class is pretty simple). Could be added, though I'm not especially fussed. -- 31602: Sean/Stephen, thoughts? Should we WONTFIX as too complicated, or is it simple enough and we can do it? -1, This stalled because its a mess of possible issues. There isn't even a solution in Joda-Time yet. -- 33102: FIX: On the one hand, it's pretty simple stuff, and we'd have to support the roll(..) method. On the other hand, user's like this stuff and it's not hard to add it, even if we overload with Calendar as well. 4 methods would be needed. +0. Joda-Time? +1 to add, -0 to roll. -- 33401: FIX: it's a bit redundant, but I've no reason not to have these methods available. Any -1s? Needs better method names IMO. -0. I'm always in favor of release early, release often when there are no unit tests with a code proposal ;) -1, these seem too specific to me -- 33609: FIX. Javadoc needs improving. Nothing wrong with better docs! :) +1. -- 33825: WONTFIX. Standard java.time question - is it valuable and simple, or should we just point to JODA? I'm going to go with WONTFIX as my default answer on time enhancements. I'm with you: Joda-Time. -1. The JDK doesn't support time or date ranges. Trying to patch support in would lead to large amounts of code in the end. -- 33889: Unsure. Could be a CharSet enhancement instead of just a camel case method. Thoughts? +1. But stick with a fairly simple implementation. -- 33997: I think this is a useful method - just need to make sure the implementation is the best possible. What about commons-math? Trouble is that double can't accurately hold some numeric values. I believe that this is what BigDecimal is for. I won't stop a mathematician having a go though. -- 34284: FIX: NullPointer; test and fix. +1 FIX -- 34351: FIX: I don't see any reason not to try to write Albert's method. If not obvious when digging into it, then we can WONTFIX. Not something I've ever hit, but no objections to FIX. -- 35400: WONTFIX. I'm -1 to a new classloader in lang, starts to leave the scope of 'simple' to my ignorant brain :) Probably should fix this, but classloaders just go wrong. -1 -- 35588: Part of the lang.text call. I need text.VariableFormatter. If 2.2 does not come out soon, I am going to pluck it out of there for our own use ;) Do you need all its complexity with escaping? -- 35826: Bring up with [math]. I think it could be in either, not sure I have the itch to write a BigXxx replacement though. Indeed, what does [math] think about that? It would be interesting to know what the [math] folks think about project boundaries for class like that. There is almost certainly a need for these classes, but I'm not volunteering to write them from scratch. 36061: FIX. Seems simple enough - bug and patches. Some of these bugs might be obsolete. I thought I'd take care of object cycles a while back. Hm, but that might have been for the ReflectionToStringBuilder class, not the ToStringBuilder. FIX if still an issue -- 36512: FIX. I think there's value for a .forName improvement. Personally, I would only do the super simple stuff, primitives I suppose. Arrays of primitives ok... Basically, anything that you can say in Java code: int, int[]. Yeah, that's nice. But I would not want to have us invent a mini-language which the talk of eating up spaces starts to feel like. My vote would be to keep it simple in the first cut, if it is there at all. +1, but treat this with care. Its a potential feature scope into parsing the whole of Java. -- 3: Thoughts? Is
svn commit: r394492 - in /jakarta/commons/proper/jexl/trunk: project.properties project.xml
Author: dion
Date: Sun Apr 16 07:23:29 2006
New Revision: 394492
URL: http://svn.apache.org/viewcvs?rev=394492view=rev
Log:
Add checkstyle and findbugs reports
Modified:
jakarta/commons/proper/jexl/trunk/project.properties
jakarta/commons/proper/jexl/trunk/project.xml
Modified: jakarta/commons/proper/jexl/trunk/project.properties
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/project.properties?rev=394492r1=394491r2=394492view=diff
==
--- jakarta/commons/proper/jexl/trunk/project.properties (original)
+++ jakarta/commons/proper/jexl/trunk/project.properties Sun Apr 16 07:23:29
2006
@@ -1,5 +1,3 @@
-maven.checkstyle.properties = checkstyle.xml
-
# uncomment the next line to work in offline mode (no jar download no
linkcheck)
#maven.mode.online=
maven.changelog.factory=org.apache.maven.svnlib.SvnChangeLogFactory
@@ -51,3 +49,7 @@
rulesets/coupling.xml,\
rulesets/design.xml,\
rulesets/strings.xml
+
+maven.checkstyle.format=sun
+maven.checkstyle.excludes=org/apache/commons/jexl/parser/Parser*.java,org/apache/commons/jexl/parser/SimpleCharStream.java,org/apache/commons/jexl/parser/Token*.java
+maven.checkstyle.header.file=${basedir}/src/conf/header.txt
\ No newline at end of file
Modified: jakarta/commons/proper/jexl/trunk/project.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/project.xml?rev=394492r1=394491r2=394492view=diff
==
--- jakarta/commons/proper/jexl/trunk/project.xml (original)
+++ jakarta/commons/proper/jexl/trunk/project.xml Sun Apr 16 07:23:29 2006
@@ -144,6 +144,18 @@
/comment
/properties
/dependency
+dependency
+ groupIdmaven-plugins/groupId
+ artifactIdmaven-findbugs-plugin/artifactId
+ version1.1/version
+ urlhttp://maven-plugins.sourceforge.net/maven-findbugs-plugin//url
+ typeplugin/type
+ properties
+comment
+lt;stronggt;Site Onlylt;/stronggt; - v1.1 (minimum)
+/comment
+ /properties
+/dependency
/dependencies
build
nagEmailAddresscommons-dev@jakarta.apache.org/nagEmailAddress
@@ -160,6 +172,8 @@
reports
reportmaven-changelog-plugin/report
reportmaven-changes-plugin/report
+reportmaven-checkstyle-plugin/report
+reportmaven-findbugs-plugin/report
reportmaven-developer-activity-plugin/report
reportmaven-file-activity-plugin/report
reportmaven-javadoc-plugin/report
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394494 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/Expression.java
Author: dion
Date: Sun Apr 16 07:31:48 2006
New Revision: 394494
URL: http://svn.apache.org/viewcvs?rev=394494view=rev
Log:
Checkstyle
Modified:
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/Expression.java
Modified:
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/Expression.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/Expression.java?rev=394494r1=394493r2=394494view=diff
==
---
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/Expression.java
(original)
+++
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/Expression.java
Sun Apr 16 07:31:48 2006
@@ -1,12 +1,12 @@
/*
* Copyright 2002,2004 The Apache Software Foundation.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -20,9 +20,9 @@
/**
* p
* Represents a single JEXL expression. This simple interface
- * provides access to the underlying expression through getExpression(),
+ * provides access to the underlying expression through getExpression(),
* and it provides hooks to add a pre- and post- expression resolver.
- * /p
+ * /p
*
* p
* An expression is different than a script - it is simply a reference of
@@ -33,37 +33,38 @@
* @author a href=mailto:[EMAIL PROTECTED]Geir Magnusson Jr./a
* @version $Id$
*/
-public interface Expression
-{
+public interface Expression {
/**
* Evaluates the expression with the variables contained in the
- * supplied [EMAIL PROTECTED] JexlContext}.
- *
+ * supplied [EMAIL PROTECTED] JexlContext}.
+ *
* @param context A JexlContext containing variables.
* @return The result of this evaluation
+ * @throws Exception on any error
*/
Object evaluate(JexlContext context) throws Exception;
/**
* Returns the JEXL expression this Expression was created with.
- *
+ *
* @return The JEXL expression to be evaluated
*/
String getExpression();
/**
- * allows addition of a resolver to allow custom interdiction of
- * expression evaluation
+ * Allows addition of a resolver to allow custom interdiction of
+ * expression evaluation.
*
- * @param resolver resolver to be called before Jexl expression evaluated
+ * @param resolver resolver to be called before Jexl expression evaluated
*/
void addPreResolver(JexlExprResolver resolver);
/**
- * allows addition of a resolver to allow custom interdiction of
- * expression evaluation
+ * Allows addition of a resolver to allow custom interdiction of
+ * expression evaluation.
*
- * @param resolver resolver to be called if Jexl expression evaluated to
null
+ * @param resolver resolver to be called if Jexl expression
+ * evaluated to null.
*/
void addPostResolver(JexlExprResolver resolver);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394495 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
Author: dion
Date: Sun Apr 16 07:45:23 2006
New Revision: 394495
URL: http://svn.apache.org/viewcvs?rev=394495view=rev
Log:
Checkstyle
Modified:
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
Modified:
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java?rev=394495r1=394494r2=394495view=diff
==
---
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
(original)
+++
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
Sun Apr 16 07:45:23 2006
@@ -1,12 +1,12 @@
/*
* Copyright 2002,2004 The Apache Software Foundation.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -29,16 +29,16 @@
import org.apache.commons.logging.LogFactory;
/**
- * p
+ * p
* Creates Expression objects. To create a JEXL Expression object, pass
* valid JEXL syntax to the static createExpression() method:
* /p
- *
+ *
* pre
* String jexl = array[1];
* Expression expression = ExpressionFactory.createExpression( jexl );
* /pre
- *
+ *
* p
* When an [EMAIL PROTECTED] Expression} object is created, the JEXL syntax is
* parsed and verified. If the supplied expression is neither an
@@ -48,8 +48,7 @@
* @author a href=mailto:[EMAIL PROTECTED]Geir Magnusson Jr./a
* @version $Id$
*/
-public class ExpressionFactory
-{
+public class ExpressionFactory {
/**
* The Log to which all ExpressionFactory messages will be logged.
*/
@@ -57,10 +56,12 @@
LogFactory.getLog(org.apache.commons.jexl.ExpressionFactory);
/**
- * The singleton ExpressionFactory also holds a single instance of [EMAIL
PROTECTED] Parser}.
+ * The singleton ExpressionFactory also holds a single instance of
+ * [EMAIL PROTECTED] Parser}.
* When parsing expressions, ExpressionFactory synchronizes on Parser.
*/
-protected static Parser parser = new Parser(new StringReader(;));
//$NON-NLS-1$
+protected static Parser parser =
+new Parser(new StringReader(;)); //$NON-NLS-1$
/**
* ExpressionFactory is a singleton and this is the private
@@ -72,14 +73,14 @@
* Private constructor, the single instance is always obtained
* with a call to getInstance().
*/
-private ExpressionFactory(){}
+private ExpressionFactory() {
+}
/**
* Returns the single instance of ExpressionFactory.
* @return the instance of ExpressionFactory.
*/
-protected static ExpressionFactory getInstance()
-{
+protected static ExpressionFactory getInstance() {
return ef;
}
@@ -89,13 +90,12 @@
* must contain either a reference or an expression.
* @param expression A String containing valid JEXL syntax
* @return An Expression object which can be evaluated with a JexlContext
- * @throws Exception An exception can be thrown if there is a problem
parsing
- * his expression, or if the expression is neither an
- * expression or a reference.
+ * @throws Exception An exception can be thrown if there is a problem
+ * parsing this expression, or if the expression is neither an
+ * expression or a reference.
*/
public static Expression createExpression(String expression)
-throws Exception
-{
+throws Exception {
return getInstance().createNewExpression(expression);
}
@@ -108,23 +108,22 @@
* @throws Exception for a variety of reasons - mostly malformed
* Jexl expression
*/
-protected Expression createNewExpression(String expression)
+protected Expression createNewExpression(final String expression)
throws Exception {
-
+
String expr = cleanExpression(expression);
// Parse the Expression
SimpleNode tree;
-synchronized(parser)
-{
-log.debug( Parsing expression: + expr );
+synchronized (parser) {
+log.debug(Parsing expression: + expr);
tree = parser.parse(new StringReader(expr));
}
if (tree.jjtGetNumChildren() 1 log.isWarnEnabled()) {
-log.warn( The JEXL Expression created will be a reference
+log.warn(The JEXL Expression created will be a
svn commit: r394496 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
Author: dion
Date: Sun Apr 16 07:55:33 2006
New Revision: 394496
URL: http://svn.apache.org/viewcvs?rev=394496view=rev
Log:
Checkstyle
Modified:
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
Modified:
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java?rev=394496r1=394495r2=394496view=diff
==
---
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
(original)
+++
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
Sun Apr 16 07:55:33 2006
@@ -56,11 +56,11 @@
LogFactory.getLog(org.apache.commons.jexl.ExpressionFactory);
/**
- * The singleton ExpressionFactory also holds a single instance of
+ * The singleton ExpressionFactory also holds a single instance of
* [EMAIL PROTECTED] Parser}.
* When parsing expressions, ExpressionFactory synchronizes on Parser.
*/
-protected static Parser parser =
+protected static Parser parser =
new Parser(new StringReader(;)); //$NON-NLS-1$
/**
@@ -90,7 +90,7 @@
* must contain either a reference or an expression.
* @param expression A String containing valid JEXL syntax
* @return An Expression object which can be evaluated with a JexlContext
- * @throws Exception An exception can be thrown if there is a problem
+ * @throws Exception An exception can be thrown if there is a problem
* parsing this expression, or if the expression is neither an
* expression or a reference.
*/
@@ -131,18 +131,18 @@
SimpleNode node = (SimpleNode) tree.jjtGetChild(0);
// TODO: Can we get rid of these checks?
-if( node instanceof ASTReferenceExpression
+if (node instanceof ASTReferenceExpression
|| node instanceof ASTExpressionExpression
|| node instanceof ASTStatementExpression
-|| node instanceof ASTIfStatement
+|| node instanceof ASTIfStatement
|| node instanceof ASTWhileStatement
|| node instanceof ASTForeachStatement
-)
-{
+) {
return new ExpressionImpl(expression, node);
}
log.error( Invalid Expression, node of type: +
node.getClass().getName() );
-throw new Exception(Invalid Expression: not a Reference, Expression,
Statement or If);
+throw new Exception(Invalid Expression: not a Reference, Expression,
++ Statement or If);
}
/**
@@ -152,8 +152,7 @@
*/
private String cleanExpression(String expression) {
String expr = expression.trim();
-if (!expr.endsWith(;))
-{
+if (!expr.endsWith(;)) {
expr += ;;
}
return expr;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] next version etc
On 4/15/06, Gary Gregory [EMAIL PROTECTED] wrote: -Original Message- From: Henri Yandell [mailto:[EMAIL PROTECTED] Sent: Friday, April 14, 2006 6:04 PM To: Jakarta Commons Developers List Subject: [lang] next version etc I want to do something fun...so how about a Lang release. First up; 2.2 or 3.0? It would be nice to have one without enum and the other deprecated bits. IMO: 2.2, then 3.0 which removes 'enum' and anything that Java 5/6 complains about. Or... The ticket list below is long and diverse in scope and time needed. A possible release early, release often track could be: - Release 2.2 now, with only critical fixes. Time frame: now=weeks. - Release 2.3: implement easy fixes and apply no-brainer patches. Time frame: +1 month. - Release 2.4: implement trickier new features that require discussion and time to implement. Time frame: Months. I think it's worthwhile to group the issues into the separations you've suggested, then we can discuss release points. Size of groups would determine whether the above makes sense. My immediate feel is that it's too many releases - good for Lang but bad for the other Commons components if we suck up 4 or 5 of our interest level in this way. - Release 3.0: - discuss breaking the API by removing deprecated methods? There needs to be discussion? :) General rule is that we drop deprecateds at the next major. - discuss changing the base JRE requirement? Any reasons jumping to mind to change? - discuss deprecating any date/time code that can be replaced with Joda-Time. This should be done in 2.2/ASAP. I'm not sure we have that much that should be deprecated - we just need to be getting good at drawing the line of what is fine to implement and what is too much. - builds/works on Java 5? - builds/works on Java 6? +1 to both. Trying to build commons components under Harmony is on my todo list too. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30082] - [lang] escape to javascript for use as href in window.open
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30082. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30082 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2006-04-16 17:06 --- Agreement on commons-dev to WONTFIX this issue. It's too specific for Lang's domain of java.lang improvements. Sorry Edgar. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31602] - [lang] DateUtils should be able to adjust for weekends, etc.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31602. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31602 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2006-04-16 17:07 --- Agreement on commons-dev to WONTFIX this one. From Stephen: -1, This stalled because its a mess of possible issues. There isn't even a solution in Joda-Time yet. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35826] - [lang] A Mutable BigDecimal and BigInteger?
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35826. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35826 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2006-04-16 17:10 --- Answering the original question, nope there's no one working on such a thing. Lang would take it (unless Math wanted to add it) if an implementation and unit tests were offered up, but there's no itch to work on such a thing within the current committers. Thanks. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r394462 - /jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
See below...
[EMAIL PROTECTED] wrote:
Author: skitching
Date: Sun Apr 16 04:43:29 2006
New Revision: 394462
URL: http://svn.apache.org/viewcvs?rev=394462view=rev
Log:
Improve diagnostics
Modified:
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Modified:
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java?rev=394462r1=394461r2=394462view=diff
==
---
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
(original)
+++
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Sun Apr 16 04:43:29 2006
@@ -1373,6 +1373,7 @@
Properties props = null;
double priority = 0.0;
+URL propsUrl = null;
try {
Enumeration urls = getResources(classLoader, fileName);
@@ -1386,6 +1387,7 @@
Properties newProps = getProperties(url);
if (newProps != null) {
if (props == null) {
+propsUrl = url;
props = newProps;
String priorityStr = props.getProperty(PRIORITY_KEY);
priority = 0.0;
@@ -1395,7 +1397,8 @@
if (isDiagnosticsEnabled()) {
logDiagnostic(
-[LOOKUP] First properties file found at ' + url +
');
+[LOOKUP] Properties file found at ' + url +
'
++ with priority + priority);
}
} else {
String newPriorityStr =
newProps.getProperty(PRIORITY_KEY);
@@ -1405,18 +1408,27 @@
}
if (newPriority priority) {
+if (isDiagnosticsEnabled()) {
+if (isDiagnosticsEnabled()) {
One check should be enough, don't you think ;-)
+logDiagnostic(
+[LOOKUP] Properties file at ' + url +
'
++ with priority + newPriority
++ overrides file at ' + propsUrl + '
++ with priority + priority);
+}
+}
+
+propsUrl = url;
props = newProps;
priority = newPriority;
-
+} else {
if (isDiagnosticsEnabled()) {
logDiagnostic(
-[LOOKUP] New properties file found at ' + url +
'
-+ has higher priority than earlier file.);
+[LOOKUP] Properties file at ' + url + '
++ with priority + newPriority
++ does not override file at ' + propsUrl + '
++ with priority + priority);
}
-} else {
-logDiagnostic(
-[LOOKUP] New properties file found at ' + url +
'
-+ has less priority than earlier file --
ignoring.);
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Dennis Lundberg
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394519 - in /jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree: NodeCombiner.java OverrideCombiner.java UnionCombiner.java ViewNode.java
Author: oheger
Date: Sun Apr 16 10:29:10 2006
New Revision: 394519
URL: http://svn.apache.org/viewcvs?rev=394519view=rev
Log:
Added NodeCombiner classes
Added:
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/NodeCombiner.java
(with props)
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/OverrideCombiner.java
(with props)
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/UnionCombiner.java
(with props)
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/ViewNode.java
(with props)
Added:
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/NodeCombiner.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/NodeCombiner.java?rev=394519view=auto
==
---
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/NodeCombiner.java
(added)
+++
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/NodeCombiner.java
Sun Apr 16 10:29:10 2006
@@ -0,0 +1,120 @@
+/*
+ * Copyright 2006 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License)
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.configuration.tree;
+
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * p
+ * A base class for node combiner implementations.
+ * /p
+ * p
+ * A emnode combiner/em is an object that knows how two hierarchical node
+ * structures can be combined into a single one. Of course, there are many
+ * possible ways of implementing such a combination, e.g. constructing a union,
+ * an intersection, or an override structure (were nodes in the first
+ * hierarchy take precedence over nodes in the second hierarchy). This abstract
+ * base class only provides some helper methods and defines the common
interface
+ * for node combiners. Concrete sub classes will implement the diverse
+ * combination algorithms.
+ * /p
+ * p
+ * For some concrete combiner implementations it is important to distinguish
+ * whether a node is a single node or whether it belongs to a list structure.
+ * Alone from the input structures, the combiner will not always be able to
make
+ * this decision. So sometimes it may be necessary for the developer to
+ * configure the combiner and tell it, which nodes should be treated as list
+ * nodes. For this purpose the codeaddListNode()/code method exists. It
+ * can be passed the name of a node, which should be considered a list node.
+ * /p
+ *
+ * @version $Id$
+ * @since 1.3
+ */
+public abstract class NodeCombiner
+{
+/**
+ * Creates a new instance of codeNodeCombiner/code.
+ */
+public NodeCombiner()
+{
+listNodes = new HashSet();
+}
+
+/** Stores a list with node names that are known to be list nodes. */
+protected Set listNodes;
+
+/**
+ * Adds the name of a node to the list of known list nodes. This means that
+ * nodes with this name will never be combined.
+ *
+ * @param nodeName the name to be added
+ */
+public void addListNode(String nodeName)
+{
+listNodes.add(nodeName);
+}
+
+/**
+ * Returns a set with the names of nodes that are known to be list nodes.
+ *
+ * @return a set with the names of list nodes
+ */
+public Set getListNodes()
+{
+return Collections.unmodifiableSet(listNodes);
+}
+
+/**
+ * Checks if a node is a list node. This implementation tests if the given
+ * node name is contained in the set of known list nodes. Derived classes
+ * which use different criteria may overload this method.
+ *
+ * @param node the node to be tested
+ * @return a flag whether this is a list node
+ */
+public boolean isListNode(ConfigurationNode node)
+{
+return listNodes.contains(node.getName());
+}
+
+/**
+ * Combines the hierarchies represented by the given root nodes. This
method
+ * must be defined in concrete sub classes with the implementation of a
+ * specific combination algorithm.
+ *
+ * @param node1 the first root node
+ * @param node2 the second root node
+ * @return the resulting combined node
svn commit: r394521 - in /jakarta/commons/proper/configuration/trunk: ./ conf/ src/test/org/apache/commons/configuration/tree/
Author: oheger Date: Sun Apr 16 10:32:02 2006 New Revision: 394521 URL: http://svn.apache.org/viewcvs?rev=394521view=rev Log: Added tests for NodeCombiner classes Added: jakarta/commons/proper/configuration/trunk/conf/testcombine1.xml (with props) jakarta/commons/proper/configuration/trunk/conf/testcombine2.xml (with props) jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/tree/AbstractCombinerTest.java (with props) jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/tree/TestOverrideCombiner.java (with props) jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/tree/TestUnionCombiner.java (with props) jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/tree/TestViewNode.java (with props) Modified: jakarta/commons/proper/configuration/trunk/build.xml jakarta/commons/proper/configuration/trunk/project.xml Modified: jakarta/commons/proper/configuration/trunk/build.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/configuration/trunk/build.xml?rev=394521r1=394520r2=394521view=diff == --- jakarta/commons/proper/configuration/trunk/build.xml (original) +++ jakarta/commons/proper/configuration/trunk/build.xml Sun Apr 16 10:32:02 2006 @@ -1,6 +1,6 @@ ?xml version=1.0 encoding=UTF-8? !-- - Copyright 2004-2005 The Apache Software Foundation + Copyright 2004-2006 The Apache Software Foundation Licensed under the Apache License, Version 2.0 (the License); you may not use this file except in compliance with the License. @@ -147,6 +147,7 @@ /exclude exclude name=**/XPathTest.java /exclude + exclude name=**/AbstractCombinerTest.java/ /fileset /batchtest /junit Added: jakarta/commons/proper/configuration/trunk/conf/testcombine1.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/configuration/trunk/conf/testcombine1.xml?rev=394521view=auto == --- jakarta/commons/proper/configuration/trunk/conf/testcombine1.xml (added) +++ jakarta/commons/proper/configuration/trunk/conf/testcombine1.xml Sun Apr 16 10:32:02 2006 @@ -0,0 +1,52 @@ +?xml version=1.0 encoding=ISO-8859-1 ? + +config + gui +bgcolorgreen/bgcolor +selcoloryellow/selcolor +level default=21/level + /gui + net +proxy + urlhttp://www.url1.org/url + urlhttp://www.url2.org/url + urlhttp://www.url3.org/url +/proxy +service + urlhttp://service1.org/url +/service +server +/server + /net + base +services + security +login + userAdmin/user + passwd type=secret/ +/login + /security +/services + /base + database +tables + table id=1 +namedocuments/name +fields + field +namedocid/name +typelong/type + /field + field +namedocname/name +typevarchar/type + /field + field +nameauthorID/name +typeint/type + /field +/fields + /table +/tables + /database +/config Propchange: jakarta/commons/proper/configuration/trunk/conf/testcombine1.xml -- svn:eol-style = native Propchange: jakarta/commons/proper/configuration/trunk/conf/testcombine1.xml -- svn:keywords = Date Author Id Revision HeadURL Propchange: jakarta/commons/proper/configuration/trunk/conf/testcombine1.xml -- svn:mime-type = text/xml Added: jakarta/commons/proper/configuration/trunk/conf/testcombine2.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/configuration/trunk/conf/testcombine2.xml?rev=394521view=auto == --- jakarta/commons/proper/configuration/trunk/conf/testcombine2.xml (added) +++ jakarta/commons/proper/configuration/trunk/conf/testcombine2.xml Sun Apr 16 10:32:02 2006 @@ -0,0 +1,48 @@ +?xml version=1.0 encoding=ISO-8859-1 ? + +config + base +services + security +login + user type=defaultscotty/user + passwdBeamMeUp/passwd +/login + /security +/services + /base + gui +bgcolorblack/bgcolor +fgcolorblue/fgcolor +level min=14/level + /gui + net +server + urlhttp://appsvr1.com/url + urlhttp://appsvr2.com/url + urlhttp://testsvr.com/url + urlhttp://backupsvr.com/url +/server +service + url type=2http://service2.org/url + url type=2http://service3.org/url +
Re: [logging] diagnostics, RC failure in webapp
Simon Kitching wrote:
Hi,
I've been able to reproduce the logging problem I reported earlier with
very little trouble. However I am unable to figure out *why* it's
failing.
To summarise: Class Log4JLogger is being loaded from a classloader; that
classloader can see file Log4JLogger.class fine as a resource.
Log4JLogge depends on org.apache.log4j.Category, but that is also
visible from the classloader. Yet Log4JLogger gets NoClassDefFound when
loaded. Very puzzling.
As you can see, while investigating this I found the need for some more
diagnostics so I've added them.
I just tried to build commons-logging trunk with your enhanced diagnostics
using JDK 1.4 on Windows XP. The tests won't build because:
compile.tests:
[javac] Compiling 30 source files to
G:\apache\jakarta-commons-logging\target\tests
[javac]
G:\apache\jakarta-commons-logging\src\test\org\apache\commons\logging\PathableClassLoader.java:244:
getResources(java.lang.String) in org.apache
.commons.logging.PathableClassLoader cannot override
getResources(java.lang.String) in java.lang.ClassLoader; overridden method is
final
[javac] public Enumeration getResources(String name) throws IOException
{
[javac]^
[javac] 1 error
/snip
--
Dennis Lundberg
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394528 - in /jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event: ./ ConfigurationEvent.java ConfigurationListener.java EventSource.java
Author: oheger
Date: Sun Apr 16 10:54:22 2006
New Revision: 394528
URL: http://svn.apache.org/viewcvs?rev=394528view=rev
Log:
Added new classes for supporting event listeners
Added:
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/ConfigurationEvent.java
(with props)
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/ConfigurationListener.java
(with props)
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/EventSource.java
(with props)
Added:
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/ConfigurationEvent.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/ConfigurationEvent.java?rev=394528view=auto
==
---
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/ConfigurationEvent.java
(added)
+++
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/ConfigurationEvent.java
Sun Apr 16 10:54:22 2006
@@ -0,0 +1,132 @@
+/*
+ * Copyright 2006 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License)
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.configuration.event;
+
+import java.util.EventObject;
+
+/**
+ * p
+ * An event class for reporting updates on a configuration object.
+ * /p
+ * p
+ * Event objects of this type are used for quot;rawquot; events, i.e.
+ * unfiltered modifications of any kind. A level with semantically higher
events
+ * (e.g. for property changes) may be built on top of this fundamental event
+ * mechanism.
+ * /p
+ * p
+ * Each event can contain the following data:
+ * ul
+ * liA source object, which is usually the configuration object that was
+ * modified./li
+ * liThe event's type. This is a numeric value that corresponds to constant
+ * declarations in concrete configuration classes. It describes what exactly
has
+ * happended./li
+ * liIf available, the name of the property whose modification caused the
+ * event./li
+ * liIf available, the value of the property that caused this event./li
+ * liA flag whether this event was generated before or after the update of
+ * the source configuration. A modification of a configuration typically causes
+ * two events: one event before and one event after the modification is
+ * performed. This allows event listeners to react at the correct point of
time./li
+ * /ul
+ * /p
+ *
+ * @version $Id$
+ * @since 1.3
+ */
+public class ConfigurationEvent extends EventObject
+{
+/**
+ * The serial version UID.
+ */
+private static final long serialVersionUID = 3277238219073504136L;
+
+/** Stores the event type. */
+private int type;
+
+/** Stores the property name. */
+private String propertyName;
+
+/** Stores the property value. */
+private Object propertyValue;
+
+/** Stores the before update flag. */
+private boolean beforeUpdate;
+
+/**
+ * Creates a new instance of codeConfigurationEvent/code and
+ * initializes it.
+ *
+ * @param source the event source
+ * @param type the event's type
+ * @param propertyName the name of the affected property
+ * @param propertyValue the value of the affected property
+ * @param beforeUpdate the before update flag
+ */
+public ConfigurationEvent(Object source, int type, String propertyName,
+Object propertyValue, boolean beforeUpdate)
+{
+super(source);
+this.type = type;
+this.propertyName = propertyName;
+this.propertyValue = propertyValue;
+this.beforeUpdate = beforeUpdate;
+}
+
+/**
+ * Returns the name of the affected property. This can be bnull/b if no
+ * property change has lead to this event.
+ *
+ * @return the name of the property
+ */
+public String getPropertyName()
+{
+return propertyName;
+}
+
+/**
+ * Returns the value of the affected property if available.
+ *
+ * @return the value of the property; can be bnull/b
+ */
+public Object getPropertyValue()
+{
+return propertyValue;
+}
+
+/**
+ * Returns the type of this
svn commit: r394529 - /jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/
Author: oheger
Date: Sun Apr 16 10:55:55 2006
New Revision: 394529
URL: http://svn.apache.org/viewcvs?rev=394529view=rev
Log:
Added event listener support to basic configuration classes
Modified:
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractConfiguration.java
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/BaseConfiguration.java
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/HierarchicalConfiguration.java
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/MapConfiguration.java
Modified:
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractConfiguration.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractConfiguration.java?rev=394529r1=394528r2=394529view=diff
==
---
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractConfiguration.java
(original)
+++
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractConfiguration.java
Sun Apr 16 10:55:55 2006
@@ -26,12 +26,32 @@
import org.apache.commons.collections.Predicate;
import org.apache.commons.collections.iterators.FilterIterator;
+import org.apache.commons.configuration.event.EventSource;
import org.apache.commons.lang.BooleanUtils;
/**
- * Abstract configuration class. Provide basic functionality but does not store
- * any data. If you want to write your own Configuration class then you should
- * implement only abstract methods from this class.
+ * pAbstract configuration class. Provides basic functionality but does not
+ * store any data./p
+ * pIf you want to write your own Configuration class then you should
+ * implement only abstract methods from this class. A lot of functionality
+ * needed by typical implementations of the codeConfiguration/conde
+ * interface is already provided by this base class. Following is a list of
+ * feauters implemented here:
+ * ulliData conversion support. The various data types required by the
+ * codeConfiguration/code interface are already handled by this base class.
+ * A concrete sub class only needs to provide a generic
codegetProperty()/code
+ * method./li
+ * liSupport for variable interpolation. Property values containing special
+ * variable tokens (like code${var}/code) will be replaced by their
+ * corresponding values./li
+ * liSupport for string lists. The values of properties to be added to this
+ * configuration are checked whether they contain a list delimiter character.
If
+ * this is the case and if list splitting is enabled, the string is splitted
and
+ * multiple values are added for this property./li
+ * liBasic event support. Whenever this configuration is modified registered
+ * event listeners are notified. Refer to the various codeEVENT_XXX/code
+ * constants to get an impression about which event types are supported./li
+ * /ul/p
*
* @author a href=mailto:[EMAIL PROTECTED]Konstantin Shaposhnikov /a
* @author a href=mailto:[EMAIL PROTECTED]Oliver Heger /a
@@ -39,8 +59,20 @@
* @version $Id: AbstractConfiguration.java,v 1.29 2004/12/02 22:05:52 ebourg
* Exp $
*/
-public abstract class AbstractConfiguration implements Configuration
+public abstract class AbstractConfiguration extends EventSource implements
Configuration
{
+/** Constant for the add property event type.*/
+public static final int EVENT_ADD_PROPERTY = 1;
+
+/** Constant for the clear property event type.*/
+public static final int EVENT_CLEAR_PROPERTY = 2;
+
+/** Constant for the set property event type.*/
+public static final int EVENT_SET_PROPERTY = 3;
+
+/** Constant for the clear configuration event type.*/
+public static final int EVENT_CLEAR = 4;
+
/** start token */
protected static final String START_TOKEN = ${;
@@ -187,6 +219,8 @@
*/
public void addProperty(String key, Object value)
{
+fireEvent(EVENT_ADD_PROPERTY, key, value, true);
+
if (!isDelimiterParsingDisabled())
{
Iterator it = PropertyConverter.toIterator(value,
getListDelimiter());
@@ -199,6 +233,8 @@
{
addPropertyDirect(key, value);
}
+
+fireEvent(EVENT_ADD_PROPERTY, key, value, false);
}
/**
@@ -279,32 +315,74 @@
*/
public void setProperty(String key, Object value)
{
-clearProperty(key);
-addProperty(key, value);
+fireEvent(EVENT_SET_PROPERTY, key,
svn commit: r394530 - in /jakarta/commons/proper/configuration/trunk: ./ src/test/org/apache/commons/configuration/event/
Author: oheger Date: Sun Apr 16 10:56:48 2006 New Revision: 394530 URL: http://svn.apache.org/viewcvs?rev=394530view=rev Log: Test classes for event listener support Added: jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/event/ jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/event/AbstractTestConfigurationEvents.java (with props) jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/event/AbstractTestFileConfigurationEvents.java (with props) jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/event/TestEventSource.java (with props) jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/event/TestHierarchicalConfigurationEvents.java (with props) jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/event/TestMapConfigurationEvents.java (with props) jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/event/TestPropertiesConfigurationEvents.java (with props) jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/event/TestXMLConfigurationEvents.java (with props) Modified: jakarta/commons/proper/configuration/trunk/build.xml jakarta/commons/proper/configuration/trunk/project.xml Modified: jakarta/commons/proper/configuration/trunk/build.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/configuration/trunk/build.xml?rev=394530r1=394529r2=394530view=diff == --- jakarta/commons/proper/configuration/trunk/build.xml (original) +++ jakarta/commons/proper/configuration/trunk/build.xml Sun Apr 16 10:56:48 2006 @@ -148,6 +148,8 @@ exclude name=**/XPathTest.java /exclude exclude name=**/AbstractCombinerTest.java/ + exclude name=**/AbstractTestConfigurationEvents.java/ + exclude name=**/AbstractTestFileConfigurationEvents.java/ /fileset /batchtest /junit Modified: jakarta/commons/proper/configuration/trunk/project.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/configuration/trunk/project.xml?rev=394530r1=394529r2=394530view=diff == --- jakarta/commons/proper/configuration/trunk/project.xml (original) +++ jakarta/commons/proper/configuration/trunk/project.xml Sun Apr 16 10:56:48 2006 @@ -431,6 +431,8 @@ exclude**/TestAbstractConfiguration.java/exclude exclude**/XPathTest.java/exclude exclude**/AbstractCombinerTest.java/exclude +exclude**/AbstractTestConfigurationEvents.java/exclude +exclude**/AbstractTestFileConfigurationEvents.java/exclude /excludes resources resource Added: jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/event/AbstractTestConfigurationEvents.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/event/AbstractTestConfigurationEvents.java?rev=394530view=auto == --- jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/event/AbstractTestConfigurationEvents.java (added) +++ jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/event/AbstractTestConfigurationEvents.java Sun Apr 16 10:56:48 2006 @@ -0,0 +1,255 @@ +/* + * Copyright 2006 The Apache Software Foundation. + * + * Licensed under the Apache License, Version 2.0 (the License) + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.configuration.event; + +import java.util.LinkedList; + +import org.apache.commons.configuration.AbstractConfiguration; +import org.apache.commons.configuration.event.ConfigurationEvent; +import org.apache.commons.configuration.event.ConfigurationListener; + +import junit.framework.TestCase; + +/** + * Base class for testing events generated by configuration classes derived from + * AbstractConfiguration. This class implements a couple of tests related to + * event generation. Concrete sub classes only have to implement the + * codecreateConfiguration()/code method for creating an instance of a + * specific configuration class. Because tests for detail events depend
DO NOT REPLY [Bug 38929] - [configuration] Support event listeners for configurations
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38929. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38929 --- Additional Comments From [EMAIL PROTECTED] 2006-04-16 17:58 --- I checked in a slightly modified version of my last patch because I need this functionality now for continuing work on the re-design of ConfigurationFactory. This should provide basic support for events that are fired whenever a configuration is modified. More sophisticated event support may be implemented on top of these classes. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [lang] next version etc
-Original Message-
From: Stephen Colebourne [mailto:[EMAIL PROTECTED]
Sent: Sunday, April 16, 2006 7:23 AM
To: Jakarta Commons Developers List
Subject: Re: [lang] next version etc
snip
--
30184: Consider for lang.text.
There are no unit tests provided (I know, the class is pretty
simple).
Could be added, though I'm not especially fussed.
IMO, we should always add unit tests with new code. This is a case of
eating our own dog food, process-wise. If we do not lead by example, we
are not encouraging patch submitters to submit unit tests with their own
patches.
snip
35588: Part of the lang.text call.
I need text.VariableFormatter. If 2.2 does not come out soon, I am
going
to pluck it out of there for our own use ;)
Do you need all its complexity with escaping?
I want to provide our users with highly flexible configuration files
(and scripts) where Java system properties and environment variables are
available.
It is possible that some of our users would need escaping things like
'$' and '{}'. The flexibility I would be willing to give up is what
characters to use for $ and {}, but this is the part that adds the least
amount of complexity.
If you are thinking of removing the ability to do things that correspond
to ${aVarPiece${anotherPiece}}, then I am somewhat indifferent right
now. It just seems like a lot of work to undo the code and the unit
tests since the current implementation works and it well covered by unit
tests. Furthermore, it seems to me like once a feature like
VariableFormatter is released, implementing the above feature would be
the next step in the evolution of the class. Just my POV though...
snip
36925: Status Gary?
I like the feature and it is done and it tested. The only thing I
can
think of is trying to make the API names better (they seem fine now
to
me).
I would like to see method override taking in a Collection of Strings,
otherwise its done.
I am working on this now.
snip
Gary
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [collections] proposed new features - MapIndexing, MapPartitioning
Hi Paul, Thanks for your proposal. I took a look, and it seems like an intriguing idea. However, they are really too specific for [collections] itself. The functor package in [collections] has to try and stay focussed on just the very basic functors, as there are literally thousands of possible good implementations out there. Maybe someone should startup a sourceforge fuctor implementations project! Stephen Paul Feuer wrote: Hi all, (I looked at various FAQ's and some previous mailing list answers to I want to contribute and I hope I do it right ;) I'm a fan of collections and use it all over the place, but have a two of functions I'd like to propose. I use these functions in some operations of Collections of Maps that are returned by our database layer at work. (The proposed code, however, is not the property of the company - it was specially developed for including in the commons project.) I'm not sure if org.apache.commons.collections.functors is the best place for these, but the map package seemed to be only Map implementations, so the functors package seemed like a better home. Tho I was surprised to see no TestCases in the functors package. The indexing operation has come in handy when sending DB results out to a JSP - transforming it this way allows easy keyed access to each record. The partitioning operation is useful when we need to bucket groups of records. In each case, it could be argued that, given a large enough collection, someone would not want to repeat the traversal of the collection if they were going to do addition per-record processing, but the same could be said for a lot of the Transformer implementations. They're great commodity operations. Links are provided to my proposed implementations and test cases below: http://fe4.com/opensrc/apache/org/apache/commons/collections/functors/index.html Let me know if this is not the right approach to contributing!! I'm looking to get involved and want to do it right! cheers, ./paul 1) MapIndexingTransformer proposed package: org.apache.commons.collections.functors (?) link: http://fe4.com/opensrc/apache/org/apache/commons/collections/functors/MapIndexingTransformer.java.html http://fe4.com/opensrc/apache/org/apache/commons/collections/functors/TestMapIndexingTransformer.java.html Transforms a Collection of Maps into a Map using a value of each Map to key that Map in the output. In pseudocode: indexValueToMapMap = Map for each record in input Collection get value from record at indexKey indexValueToMapMap[ index ] = record Thus the input: Collection [ Map[ ID=1, NAME=Paul ], Map[ ID=2, NAME=Kim ] ] is indexed on ID into Map [ 1 = Map[ ID=1, NAME=Paul ], 2 = Map[ ID=2, NAME=Kim ] ] 2) MapPartitioningTransformer proposed package: org.apache.commons.collections.functors (?) link: http://fe4.com/opensrc/apache/org/apache/commons/collections/functors/MapPartitioningTransformer.java.html http://fe4.com/opensrc/apache/org/apache/commons/collections/functors/TestMapPartitioningTransformer.java.html Transform a Collection of Maps by grouping together those Maps that share a common value for some key. In other words, the input to this Transformer is a Collection of Maps as you might see coming from a database, and for each of the records, they may share some common value at a given key. Partitioning on that value will create collections for each unique value of that key in the input collection. In pseudocode: partitionNameToCollection = Map for each record of inputCollection get value as partitionName from record at partitionKey with partitionNameToCollection add record at partitionName return partitionNameToCollection Thus the input: Collection[ Map[ ID=1, GROUP=New York City, NAME=Paul ] Map[ ID=2, GROUP=New York City, NAME=Kim ] Map[ ID=3, GROUP=Atlanta, NAME=Marcia ] Map[ ID=4, GROUP=Atlanta, NAME=Will ] ] is partitioned on GROUP into: Map[ group1 = Collection[ Map[ ID=1, GROUP=New York City, NAME=Paul ] Map[ ID=2, GROUP=New York City, NAME=Kim ] ] group2 = Collection[ Map[ ID=3, GROUP=Atlanta, NAME=Marcia ] Map[ ID=4, GROUP=Atlanta, NAME=Will ] ] ] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39272] - [io] FileUtils needs a toString that takes a filename and returns its contents as a string
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39272. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39272 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2006-04-16 19:43 --- These two proposals seem like a bad idea. 1) FileUtils operates on Files. Thats why its named as is. File objects are just a much more reliable way to hold and manage files. 2) Using a default encoding is bad practice. The default may vary between a development PC and live Unix box. Also, UTF8 would be much preferred in most situations. There may be a separate call for methods that hard code the UTF8 encoding, but thats a different call, and the methods would be named xxxUTF8(). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32144] - [io] Add a secureDelete method to FileUtils.java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32144. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32144 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2006-04-16 19:45 --- This would appear to be a complex piece of work requiring detailed knowledge that may change over time. Also, it could expose us to security questions etc if we get it wrong. Cllosing as out of scope for [io]. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394553 - in /jakarta/commons/proper/lang/trunk/src: java/org/apache/commons/lang/time/DateUtils.java test/org/apache/commons/lang/time/DateUtilsTest.java
Author: scolebourne
Date: Sun Apr 16 13:29:57 2006
New Revision: 394553
URL: http://svn.apache.org/viewcvs?rev=394553view=rev
Log:
Add methods that operate on a Date object
rfe 33102, from David Bowers
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DateUtils.java
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/time/DateUtilsTest.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DateUtils.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DateUtils.java?rev=394553r1=394552r2=394553view=diff
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DateUtils.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DateUtils.java
Sun Apr 16 13:29:57 2006
@@ -272,6 +272,139 @@
//---
/**
+ * Adds a number of years to a date returning a new object.
+ * The original date object is unchanged.
+ *
+ * @param date the date, not null
+ * @param amount the amount to add, may be negative
+ * @return the new date object with the amount added
+ * @throws IllegalArgumentException if the date is null
+ */
+public static Date addYears(Date date, int amount) {
+return add(date, Calendar.YEAR, amount);
+}
+
+//---
+/**
+ * Adds a number of months to a date returning a new object.
+ * The original date object is unchanged.
+ *
+ * @param date the date, not null
+ * @param amount the amount to add, may be negative
+ * @return the new date object with the amount added
+ * @throws IllegalArgumentException if the date is null
+ */
+public static Date addMonths(Date date, int amount) {
+return add(date, Calendar.MONTH, amount);
+}
+
+//---
+/**
+ * Adds a number of weeks to a date returning a new object.
+ * The original date object is unchanged.
+ *
+ * @param date the date, not null
+ * @param amount the amount to add, may be negative
+ * @return the new date object with the amount added
+ * @throws IllegalArgumentException if the date is null
+ */
+public static Date addWeeks(Date date, int amount) {
+return add(date, Calendar.WEEK_OF_YEAR, amount);
+}
+
+//---
+/**
+ * Adds a number of days to a date returning a new object.
+ * The original date object is unchanged.
+ *
+ * @param date the date, not null
+ * @param amount the amount to add, may be negative
+ * @return the new date object with the amount added
+ * @throws IllegalArgumentException if the date is null
+ */
+public static Date addDays(Date date, int amount) {
+return add(date, Calendar.DAY_OF_MONTH, amount);
+}
+
+//---
+/**
+ * Adds a number of hours to a date returning a new object.
+ * The original date object is unchanged.
+ *
+ * @param date the date, not null
+ * @param amount the amount to add, may be negative
+ * @return the new date object with the amount added
+ * @throws IllegalArgumentException if the date is null
+ */
+public static Date addHours(Date date, int amount) {
+return add(date, Calendar.HOUR_OF_DAY, amount);
+}
+
+//---
+/**
+ * Adds a number of minutes to a date returning a new object.
+ * The original date object is unchanged.
+ *
+ * @param date the date, not null
+ * @param amount the amount to add, may be negative
+ * @return the new date object with the amount added
+ * @throws IllegalArgumentException if the date is null
+ */
+public static Date addMinutes(Date date, int amount) {
+return add(date, Calendar.MINUTE, amount);
+}
+
+//---
+/**
+ * Adds a number of seconds to a date returning a new object.
+ * The original date object is unchanged.
+ *
+ * @param date the date, not null
+ * @param amount the amount to add, may be negative
+ * @return the new date object with the amount added
+ * @throws IllegalArgumentException if the date is null
+ */
+public static Date addSeconds(Date date, int amount) {
+return add(date, Calendar.SECOND, amount);
+}
+
+//---
+/**
+ * Adds a number of
DO NOT REPLY [Bug 33102] - [lang] add generic add method to DateUtils
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33102. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33102 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2006-04-16 20:30 --- Implemented in svn 394553 -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32144] - [io] Add a secureDelete method to FileUtils.java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32144. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32144 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX | --- Additional Comments From [EMAIL PROTECTED] 2006-04-16 20:42 --- Ok, I may agree that this is not that trivial to do right. But then I suggest that [io] at least offers an interface/factory concept where those who dare to be secure (!?) could register/overwrite the simple File.delete() with a better approach as they deem appropriate. This should be possible WITHOUT the need to recompile the commons-io.jar! This is important because many higher level frameworks ship with the jar included and one doesn't want to patch the io.jar upon each release of e.g. struts... What do you think? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394555 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DateUtils.java
Author: scolebourne
Date: Sun Apr 16 13:55:25 2006
New Revision: 394555
URL: http://svn.apache.org/viewcvs?rev=394555view=rev
Log:
Javadoc to explain what iterator methods actually do
bug 33609
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DateUtils.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DateUtils.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DateUtils.java?rev=394555r1=394554r2=394555view=diff
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DateUtils.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DateUtils.java
Sun Apr 16 13:55:25 2006
@@ -697,22 +697,28 @@
//---
/**
- * pThis constructs an codeIterator/code that will
- * start and stop over a date range based on the focused
- * date and the range style./p
+ * pThis constructs an codeIterator/code over each day in a date
+ * range defined by a focus date and range style./p
*
* pFor instance, passing Thursday, July 4, 2002 and a
- * codeRANGE_MONTH_SUNDAY/code will return an
- * codeIterator/code that starts with Sunday, June 30,
- * 2002 and ends with Saturday, August 3, 2002.
- *
- * @param focus the date to work with
- * @param rangeStyle the style constant to use. Must be one of the range
- * styles listed for the [EMAIL PROTECTED] #iterator(Calendar, int)}
method.
+ * codeRANGE_MONTH_SUNDAY/code will return an codeIterator/code
+ * that starts with Sunday, June 30, 2002 and ends with Saturday, August 3,
+ * 2002, returning a Calendar instance for each intermediate day./p
*
- * @return the date iterator
- * @throws IllegalArgumentException if the date is codenull/code or if
- * the rangeStyle is not
+ * pThis method provides an iterator that returns Calendar objects.
+ * The days are progressed using [EMAIL PROTECTED] Calendar#add(int,
int)}./p
+ *
+ * @param focus the date to work with, not null
+ * @param rangeStyle the style constant to use. Must be one of
+ * [EMAIL PROTECTED] DateUtils#RANGE_MONTH_SUNDAY},
+ * [EMAIL PROTECTED] DateUtils#RANGE_MONTH_MONDAY},
+ * [EMAIL PROTECTED] DateUtils#RANGE_WEEK_SUNDAY},
+ * [EMAIL PROTECTED] DateUtils#RANGE_WEEK_MONDAY},
+ * [EMAIL PROTECTED] DateUtils#RANGE_WEEK_RELATIVE},
+ * [EMAIL PROTECTED] DateUtils#RANGE_WEEK_CENTER}
+ * @return the date iterator, which always returns Calendar instances
+ * @throws IllegalArgumentException if the date is codenull/code
+ * @throws IllegalArgumentException if the rangeStyle is invalid
*/
public static Iterator iterator(Date focus, int rangeStyle) {
if (focus == null) {
@@ -724,15 +730,17 @@
}
/**
- * pThis constructs an codeIterator/code that will
- * start and stop over a date range based on the focused
- * date and the range style./p
+ * pThis constructs an codeIterator/code over each day in a date
+ * range defined by a focus date and range style./p
*
* pFor instance, passing Thursday, July 4, 2002 and a
- * codeRANGE_MONTH_SUNDAY/code will return an
- * codeIterator/code that starts with Sunday, June 30,
- * 2002 and ends with Saturday, August 3, 2002.
- *
+ * codeRANGE_MONTH_SUNDAY/code will return an codeIterator/code
+ * that starts with Sunday, June 30, 2002 and ends with Saturday, August 3,
+ * 2002, returning a Calendar instance for each intermediate day./p
+ *
+ * pThis method provides an iterator that returns Calendar objects.
+ * The days are progressed using [EMAIL PROTECTED] Calendar#add(int,
int)}./p
+ *
* @param focus the date to work with
* @param rangeStyle the style constant to use. Must be one of
* [EMAIL PROTECTED] DateUtils#RANGE_MONTH_SUNDAY},
@@ -743,6 +751,7 @@
* [EMAIL PROTECTED] DateUtils#RANGE_WEEK_CENTER}
* @return the date iterator
* @throws IllegalArgumentException if the date is codenull/code
+ * @throws IllegalArgumentException if the rangeStyle is invalid
*/
public static Iterator iterator(Calendar focus, int rangeStyle) {
if (focus == null) {
@@ -817,15 +826,14 @@
}
/**
- * pThis constructs an codeIterator/code that will
- * start and stop over a date range based on the focused
- * date and the range style./p
+ * pThis constructs an codeIterator/code over each day in a date
+ * range defined by a focus date and range style./p
*
* pFor instance, passing Thursday, July 4, 2002 and a
- * codeRANGE_MONTH_SUNDAY/code will return an
- * codeIterator/code that starts with Sunday,
DO NOT REPLY [Bug 33609] - [lang] Unclear javadoc for DateUtils.iterator()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33609. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33609 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2006-04-16 20:55 --- Javadoc enhanced in svn 394555 We might want to consider deprecating these iterator methods as being a bit rubbish though. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394560 - /jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Author: skitching
Date: Sun Apr 16 14:20:21 2006
New Revision: 394560
URL: http://svn.apache.org/viewcvs?rev=394560view=rev
Log:
Fix dumb double-test. Thanks to Dennis Lundberg for pointing this out.
Modified:
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Modified:
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java?rev=394560r1=394559r2=394560view=diff
==
---
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
(original)
+++
jakarta/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
Sun Apr 16 14:20:21 2006
@@ -1427,13 +1427,11 @@
if (newPriority priority) {
if (isDiagnosticsEnabled()) {
-if (isDiagnosticsEnabled()) {
-logDiagnostic(
-[LOOKUP] Properties file at ' + url
+ '
-+ with priority + newPriority
-+ overrides file at ' + propsUrl +
'
-+ with priority + priority);
-}
+logDiagnostic(
+[LOOKUP] Properties file at ' + url + '
++ with priority + newPriority
++ overrides file at ' + propsUrl + '
++ with priority + priority);
}
propsUrl = url;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394563 - /jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
Author: skitching
Date: Sun Apr 16 14:30:19 2006
New Revision: 394563
URL: http://svn.apache.org/viewcvs?rev=394563view=rev
Log:
Remove recently-added implementation of getResources. As javadoc already stated,
this can't be implemented because in java 1.4 getResources is final :-(. Unit
tests that care about getResources() order will just have to use
parentFirst=true.
Modified:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
Modified:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java?rev=394563r1=394562r2=394563view=diff
==
---
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
(original)
+++
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java
Sun Apr 16 14:30:19 2006
@@ -98,6 +98,10 @@
* child-first lookup instead, to allow the components to override libs
* which are visible in shared classloaders provided by the container.
* p
+ * Note that the method getResources always behaves as if parentFirst=true,
+ * because of limitations in java 1.4; see the javadoc for method
+ * getResourcesInOrder for details.
+ * p
* This value defaults to true.
*/
public void setParentFirst(boolean state) {
@@ -237,11 +241,14 @@
}
/**
- * Same as parent class method except that when parentFirst is false
- * any resources in the local classpath are returned before resources
- * in the parent.
+ * Emulate a proper implementation of getResources which respects the
+ * setting for parentFirst.
+ * p
+ * Note that it's not possible to override the inherited getResources, as
+ * it's declared final in java1.4 (thought that's been removed for 1.5).
+ * The inherited implementation always behaves as if parentFirst=true.
*/
-public Enumeration getResources(String name) throws IOException {
+public Enumeration getResourcesInOrder(String name) throws IOException {
if (parentFirst) {
return super.getResources(name);
} else {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394564 - /jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/PriorityConfigTestCase.java
Author: skitching
Date: Sun Apr 16 14:30:57 2006
New Revision: 394564
URL: http://svn.apache.org/viewcvs?rev=394564view=rev
Log:
Add comment about getResources not respecting parentFirst
Modified:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/PriorityConfigTestCase.java
Modified:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/PriorityConfigTestCase.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/PriorityConfigTestCase.java?rev=394564r1=394563r2=394564view=diff
==
---
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/PriorityConfigTestCase.java
(original)
+++
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/PriorityConfigTestCase.java
Sun Apr 16 14:30:57 2006
@@ -39,6 +39,10 @@
* li fourth file found also has priority=20
* /ul
* The result should be that the third file is used.
+ * p
+ * Note that parentFirst=true is used in this test because method
+ * codePathableClassLoader.getResources/code always behaves as if
+ * parentFirst=true; see the PathableClassLoader javadoc for details.
*/
public class PriorityConfigTestCase extends TestCase {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32144] - [io] Add a secureDelete method to FileUtils.java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32144. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32144 --- Additional Comments From [EMAIL PROTECTED] 2006-04-16 21:56 --- An alternative approach is to use something like CGLIB to generate a custom variant of commons-io (either statically or at runtime) which overloads the implemented method. This is effectively using aspect-oriented programming. If you're using something like the Spring framework, this is really simple. This requirement doesn't seem to me to have wide enough demand to complicate IO with pluggable file-delete strategies. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [logging] diagnostics, RC failure in webapp
On Sun, 2006-04-16 at 19:49 +0200, Dennis Lundberg wrote:
I just tried to build commons-logging trunk with your enhanced diagnostics
using JDK 1.4 on Windows XP. The tests won't build because:
compile.tests:
[javac] Compiling 30 source files to
G:\apache\jakarta-commons-logging\target\tests
[javac]
G:\apache\jakarta-commons-logging\src\test\org\apache\commons\logging\PathableClassLoader.java:244:
getResources(java.lang.String) in org.apache
.commons.logging.PathableClassLoader cannot override
getResources(java.lang.String) in java.lang.ClassLoader; overridden method is
final
[javac] public Enumeration getResources(String name) throws
IOException {
[javac]^
[javac] 1 error
Doh! When I created this file many months ago, I described in the class
javadoc that getResources can't be overloaded in java1.4. I just didn't
read my own documentation :-)
Now Fixed. Thanks for pointing this out.
Cheers,
Simon
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Commons [2006/04/16]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 6508|Ass|Enh|2002-02-17|[lakta] HttpClient now supports proxyHost and prox| | 6826|Ass|Enh|2002-03-04|[lakta] Need to have xml files validated against D| | 6829|Ass|Enh|2002-03-04|[lakta] Allow easier way of user specified tests | | 7069|Ass|Enh|2002-03-13|[lakta] DTD and DOM Validators| | 7226|Opn|Enh|2002-03-19|[beanutils] Nested Bean Collection| | 7367|New|Nor|2002-03-22|[services] ServiceManager not actually serializabl| | 7465|New|Nor|2002-03-25|[lakta] Need better 'dist' build | | 7981|Ver|Nor|2002-04-11|[codec][PATCH] add 2 new methods for encoding stri| |10319|New|Enh|2002-06-28|[beanutils] Instantiate property if null in form b| |12807|New|Nor|2002-09-19|[lakta][PATCH] Update build.xml to use commons-log| |13390|New|Nor|2002-10-07|[lakta] ResponseHeaderHandler and ResponseHeaderVa| |13426|New|Enh|2002-10-08|[lakta][PATCH] xml-reference.xml responseHeader ad| |13743|Opn|Enh|2002-10-17|[beanutils] Need getPropertyType(Class theClass, S| |14394|Ver|Nor|2002-11-08|[beanutils] Excessive exceptions log under securit| |14667|Ver|Maj|2002-11-19|[beanutils] PropertyUtils.copyProperties does not | |15451|Opn|Enh|2002-12-17|[beanutils] Multiple mapped properties not possibl| |15519|Ver|Maj|2002-12-19|[beanutils] PropertyUtils.getPropertyType() for ja| |15744|New|Nor|2002-12-31|[scaffold] Scaffold ResultSet used after statement| |16038|Opn|Enh|2003-01-13|[beanutils] LocaleBeanUtils.copyProperties() does | |16394|Inf|Enh|2003-01-24|[validator] Enhance the IndexedListProperty to han| |16525|Opn|Enh|2003-01-29|[beanutils] BeanUtils.setProperty is over-zealous | |16600|New|Nor|2003-01-30|[lakta] JUnitTestAdapter throws SAXException becau| |16634|New|Enh|2003-01-31|[validator] Change ValidatorUtils.getValueAsString| |16873|New|Enh|2003-02-07|[lakta] Specifying a different latka.properties fi| |17002|New|Enh|2003-02-12|[beanutils] Problem with index property | |17102|New|Enh|2003-02-15|[lakta] Can't embed characters in paramValue | |17501|New|Enh|2003-02-27|[beanutils] Add dynamic discovery of mapped proper| |17662|New|Nor|2003-03-05|[cli] Unknown options are ignored instead of throw| |17682|New|Nor|2003-03-05|[cli] HelpFormatter does not wrap lines correctly | |17769|New|Blk|2003-03-07|[scaffold] pre-mature closing of Statement and Pre| |17957|New|Cri|2003-03-13|[launcher] - on OutOfMemoryError no message | |18087|New|Enh|2003-03-18|[beanutils] Add BeanFactory class for dynamic fact| |18773|New|Enh|2003-04-07|[reflect] Can add a method cache in MethodUtils | |19781|New|Min|2003-05-08|[beanutils] PropertyUtils.copyProperties throws ex| |19857|New|Enh|2003-05-12|[beanutils] Methods ConvertUtilsBean.convert could| |20015|Ass|Enh|2003-05-18|[lang] Make Entities public and unit test | |20027|New|Enh|2003-05-19|[beanutils] ConvertUtils enhancements | |20057|New|Nor|2003-05-20|[lakta] Difficulty to download sample Latka test| |20067|New|Nor|2003-05-20|[lakta] sample Latka test suite SUITE FAILED - c| |20520|New|Enh|2003-06-05|[beanutils] MethodUtils: Need easy way to invoke s| |20523|New|Enh|2003-06-05|[fileupload] Model FileUpload model to mimic javax| |20549|New|Enh|2003-06-06|[beanutils] Handling of exceptions thrown during B| |20686|New|Enh|2003-06-11|[beanutils] Register converters by both target cla| |20836|New|Enh|2003-06-17|[beanutils] Localizing beanutils | |20838|New|Enh|2003-06-17|[fileupload] Add a new property maxFileSize to con| |20968|New|Enh|2003-06-20|[beanutils][PATCH] Include bean getClass in Proper| |21076|New|Enh|2003-06-25|[beanutils] Add aggressive mode for BeanUtils.co| |21433|New|Enh|2003-07-09|[scaffold] StorageBeanBase should use a resource n| |21483|New|Enh|2003-07-10|[beanutils] BeanUtils and PropertyUtils toString f| |21693|New|Enh|2003-07-17|[beanutils] copyProperties method should not exit | |21793|New|Nor|2003-07-22|[scaffold] StatementUtils fix |
svn commit: r394574 - in /jakarta/commons/proper/cli/trunk: ./ xdocs/ xdocs/style/
Author: scolebourne
Date: Sun Apr 16 15:44:32 2006
New Revision: 394574
URL: http://svn.apache.org/viewcvs?rev=394574view=rev
Log:
Update website removing dependency on commons-build
Added:
jakarta/commons/proper/cli/trunk/xdocs/building.xml (with props)
jakarta/commons/proper/cli/trunk/xdocs/cvs-usage.xml (with props)
jakarta/commons/proper/cli/trunk/xdocs/issue-tracking.xml (with props)
jakarta/commons/proper/cli/trunk/xdocs/release_1_0.xml (with props)
Removed:
jakarta/commons/proper/cli/trunk/xdocs/navigation-pdf.xml
jakarta/commons/proper/cli/trunk/xdocs/versions_and_branches.xml
Modified:
jakarta/commons/proper/cli/trunk/maven.xml
jakarta/commons/proper/cli/trunk/project.properties
jakarta/commons/proper/cli/trunk/project.xml
jakarta/commons/proper/cli/trunk/xdocs/index.xml
jakarta/commons/proper/cli/trunk/xdocs/navigation.xml
jakarta/commons/proper/cli/trunk/xdocs/style/project.css
Modified: jakarta/commons/proper/cli/trunk/maven.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/cli/trunk/maven.xml?rev=394574r1=394573r2=394574view=diff
==
--- jakarta/commons/proper/cli/trunk/maven.xml (original)
+++ jakarta/commons/proper/cli/trunk/maven.xml Sun Apr 16 15:44:32 2006
@@ -1,5 +1,5 @@
!--
-Copyright 2002-2004 The Apache Software Foundation.
+Copyright 2002-2006 The Apache Software Foundation.
Licensed under the Apache License, Version 2.0 (the License);
you may not use this file except in compliance with the License.
@@ -14,23 +14,6 @@
limitations under the License.
--
project default=jar:jar
-
- !-- == --
- !-- START : C O M M O N S - B U I L D --
- !-- == --
- !-- Required: Look and Feel for documentation within distributions --
- !-- == --
- postGoal name=xdoc:copy-resources
-copy todir=${basedir}/target/docs/style/ failonerror=false
- fileset dir=${basedir}/../commons-build/xdocs/style
-include name='**/*'/
-exclude name='**/CVS/**'/
- /fileset
-/copy
- /postGoal
- !-- == --
- !-- END: C O M M O N S - B U I L D --
- !-- == --
!-- Ensures that the conf directory and NOTICE.txt are included in the
source distro.
Modified: jakarta/commons/proper/cli/trunk/project.properties
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/cli/trunk/project.properties?rev=394574r1=394573r2=394574view=diff
==
--- jakarta/commons/proper/cli/trunk/project.properties (original)
+++ jakarta/commons/proper/cli/trunk/project.properties Sun Apr 16 15:44:32 2006
@@ -16,14 +16,13 @@
maven.checkstyle.properties=
maven.checkstyle.format=sun
-maven.xdoc.jsl=../commons-build/commons-site.jsl
maven.xdoc.date=left
maven.xdoc.version=${pom.currentVersion}
maven.xdoc.developmentProcessUrl=http://jakarta.apache.org/commons/charter.html
maven.xdoc.poweredby.image=maven-feather.png
maven.javadoc.links=http://java.sun.com/j2se/1.4/docs/api/
-maven.javadoc.stylesheet=${basedir}/style.css
+#maven.javadoc.stylesheet=${basedir}/style.css
# Jar Manifest and Additional Attributes
maven.jar.manifest=${basedir}/src/conf/MANIFEST.MF
Modified: jakarta/commons/proper/cli/trunk/project.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/cli/trunk/project.xml?rev=394574r1=394573r2=394574view=diff
==
--- jakarta/commons/proper/cli/trunk/project.xml (original)
+++ jakarta/commons/proper/cli/trunk/project.xml Sun Apr 16 15:44:32 2006
@@ -1,6 +1,6 @@
?xml version=1.0 encoding=UTF-8?
!--
- Copyright 2001-2004 The Apache Software Foundation
+ Copyright 2001-2006 The Apache Software Foundation
Licensed under the Apache License, Version 2.0 (the License);
you may not use this file except in compliance with the License.
@@ -25,26 +25,34 @@
Commons CLI provides a simple API for presenting, proecessing and
validating a command line interface.
/description
- logo/images/logo.jpg/logo
+ logo/images/logo.png/logo
- urlhttp://jakarta.apache.org/commons/${pom.artifactId.substring(8)}//url
+ urlhttp://jakarta.apache.org/commons/cli//url
packageorg.apache.commons/package
organization
nameApache Software Foundation/name
urlhttp://www.apache.org/url
-logohttp://jakarta.apache.org/images/jakarta-logo.gif/logo
+logohttp://jakarta.apache.org/images/original-jakarta-logo.gif/logo
/organization
+ licenses
+license
+
svn commit: r394575 - /jakarta/commons/proper/collections/trunk/xdocs/index.xml
Author: scolebourne Date: Sun Apr 16 15:46:29 2006 New Revision: 394575 URL: http://svn.apache.org/viewcvs?rev=394575view=rev Log: Remove CVS links, replace with SVN Modified: jakarta/commons/proper/collections/trunk/xdocs/index.xml Modified: jakarta/commons/proper/collections/trunk/xdocs/index.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/collections/trunk/xdocs/index.xml?rev=394575r1=394574r2=394575view=diff == --- jakarta/commons/proper/collections/trunk/xdocs/index.xml (original) +++ jakarta/commons/proper/collections/trunk/xdocs/index.xml Sun Apr 16 15:46:29 2006 @@ -61,10 +61,11 @@ ul liThe a href=apidocs-COLLECTIONS_3_1/index.htmlcurrent release 3.1/a/li liThe a href=apidocs-COLLECTIONS_2_1_1/index.htmlprevious version 2.1.1/a/li -liThe a href=apidocs/index.htmllatest CVS/a/li +liThe a href=apidocs/index.htmllatest SVN/a/li /ul p -The a href=http://cvs.apache.org/viewcvs/jakarta-commons/collections/;CVS repository/a can be browsed. +The a href=cvs-usage.htmlsubversion repository/a can be +a href=http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/collections/trunk/;browsed/a. /p /section !-- == -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r394576 - /jakarta/commons/proper/collections/trunk/xdocs/index.xml
Author: scolebourne Date: Sun Apr 16 15:51:27 2006 New Revision: 394576 URL: http://svn.apache.org/viewcvs?rev=394576view=rev Log: Fix Javadoc URLs Modified: jakarta/commons/proper/collections/trunk/xdocs/index.xml Modified: jakarta/commons/proper/collections/trunk/xdocs/index.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/collections/trunk/xdocs/index.xml?rev=394576r1=394575r2=394576view=diff == --- jakarta/commons/proper/collections/trunk/xdocs/index.xml (original) +++ jakarta/commons/proper/collections/trunk/xdocs/index.xml Sun Apr 16 15:51:27 2006 @@ -59,8 +59,8 @@ The JavaDoc API documents are available online: /p ul -liThe a href=apidocs-COLLECTIONS_3_1/index.htmlcurrent release 3.1/a/li -liThe a href=apidocs-COLLECTIONS_2_1_1/index.htmlprevious version 2.1.1/a/li +liThe a href=api-release/index.htmlcurrent release 3.1/a/li +liThe a href=api-2.1.1/index.htmlprevious version 2.1.1/a/li liThe a href=apidocs/index.htmllatest SVN/a/li /ul p - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Commons [2006/04/16]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 6508|Ass|Enh|2002-02-17|[lakta] HttpClient now supports proxyHost and prox| | 6826|Ass|Enh|2002-03-04|[lakta] Need to have xml files validated against D| | 6829|Ass|Enh|2002-03-04|[lakta] Allow easier way of user specified tests | | 7069|Ass|Enh|2002-03-13|[lakta] DTD and DOM Validators| | 7226|Opn|Enh|2002-03-19|[beanutils] Nested Bean Collection| | 7367|New|Nor|2002-03-22|[services] ServiceManager not actually serializabl| | 7465|New|Nor|2002-03-25|[lakta] Need better 'dist' build | | 7981|Ver|Nor|2002-04-11|[codec][PATCH] add 2 new methods for encoding stri| |10319|New|Enh|2002-06-28|[beanutils] Instantiate property if null in form b| |12807|New|Nor|2002-09-19|[lakta][PATCH] Update build.xml to use commons-log| |13390|New|Nor|2002-10-07|[lakta] ResponseHeaderHandler and ResponseHeaderVa| |13426|New|Enh|2002-10-08|[lakta][PATCH] xml-reference.xml responseHeader ad| |13743|Opn|Enh|2002-10-17|[beanutils] Need getPropertyType(Class theClass, S| |14394|Ver|Nor|2002-11-08|[beanutils] Excessive exceptions log under securit| |14667|Ver|Maj|2002-11-19|[beanutils] PropertyUtils.copyProperties does not | |15451|Opn|Enh|2002-12-17|[beanutils] Multiple mapped properties not possibl| |15519|Ver|Maj|2002-12-19|[beanutils] PropertyUtils.getPropertyType() for ja| |15744|New|Nor|2002-12-31|[scaffold] Scaffold ResultSet used after statement| |16038|Opn|Enh|2003-01-13|[beanutils] LocaleBeanUtils.copyProperties() does | |16394|Inf|Enh|2003-01-24|[validator] Enhance the IndexedListProperty to han| |16525|Opn|Enh|2003-01-29|[beanutils] BeanUtils.setProperty is over-zealous | |16600|New|Nor|2003-01-30|[lakta] JUnitTestAdapter throws SAXException becau| |16634|New|Enh|2003-01-31|[validator] Change ValidatorUtils.getValueAsString| |16873|New|Enh|2003-02-07|[lakta] Specifying a different latka.properties fi| |17002|New|Enh|2003-02-12|[beanutils] Problem with index property | |17102|New|Enh|2003-02-15|[lakta] Can't embed characters in paramValue | |17501|New|Enh|2003-02-27|[beanutils] Add dynamic discovery of mapped proper| |17662|New|Nor|2003-03-05|[cli] Unknown options are ignored instead of throw| |17682|New|Nor|2003-03-05|[cli] HelpFormatter does not wrap lines correctly | |17769|New|Blk|2003-03-07|[scaffold] pre-mature closing of Statement and Pre| |17957|New|Cri|2003-03-13|[launcher] - on OutOfMemoryError no message | |18087|New|Enh|2003-03-18|[beanutils] Add BeanFactory class for dynamic fact| |18773|New|Enh|2003-04-07|[reflect] Can add a method cache in MethodUtils | |19781|New|Min|2003-05-08|[beanutils] PropertyUtils.copyProperties throws ex| |19857|New|Enh|2003-05-12|[beanutils] Methods ConvertUtilsBean.convert could| |20015|Ass|Enh|2003-05-18|[lang] Make Entities public and unit test | |20027|New|Enh|2003-05-19|[beanutils] ConvertUtils enhancements | |20057|New|Nor|2003-05-20|[lakta] Difficulty to download sample Latka test| |20067|New|Nor|2003-05-20|[lakta] sample Latka test suite SUITE FAILED - c| |20520|New|Enh|2003-06-05|[beanutils] MethodUtils: Need easy way to invoke s| |20523|New|Enh|2003-06-05|[fileupload] Model FileUpload model to mimic javax| |20549|New|Enh|2003-06-06|[beanutils] Handling of exceptions thrown during B| |20686|New|Enh|2003-06-11|[beanutils] Register converters by both target cla| |20836|New|Enh|2003-06-17|[beanutils] Localizing beanutils | |20838|New|Enh|2003-06-17|[fileupload] Add a new property maxFileSize to con| |20968|New|Enh|2003-06-20|[beanutils][PATCH] Include bean getClass in Proper| |21076|New|Enh|2003-06-25|[beanutils] Add aggressive mode for BeanUtils.co| |21433|New|Enh|2003-07-09|[scaffold] StorageBeanBase should use a resource n| |21483|New|Enh|2003-07-10|[beanutils] BeanUtils and PropertyUtils toString f| |21693|New|Enh|2003-07-17|[beanutils] copyProperties method should not exit | |21793|New|Nor|2003-07-22|[scaffold] StatementUtils fix |
svn commit: r394603 - /jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
Author: skitching
Date: Sun Apr 16 20:30:38 2006
New Revision: 394603
URL: http://svn.apache.org/viewcvs?rev=394603view=rev
Log:
* Fix bug where unit tests weren't getting executed at all (wrong test class
name)
* Put both resources in child classloader rather than using parent, to avoid
confusion with parentFirst not being supported by
PathableClassLoader.getResources.
Modified:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
Modified:
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java?rev=394603r1=394602r2=394603view=diff
==
---
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
(original)
+++
jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
Sun Apr 16 20:30:38 2006
@@ -34,11 +34,10 @@
* This test sets up a classpath where:
* ul
* li first file found has priority=20
- * li second file (in parent path) has priority=10 (parentFirst=false)
+ * li second file found has priority=10
* /ul
* The result should be that the first file is used.
*/
-
public class FirstPriorityConfigTestCase extends TestCase {
// --- JUnit Infrastructure Methods
@@ -48,7 +47,7 @@
* Return the tests included in this test suite.
*/
public static Test suite() throws Exception {
-Class thisClass = PriorityConfigTestCase.class;
+Class thisClass = FirstPriorityConfigTestCase.class;
// Determine the URL to this .class file, so that we can then
// append the priority dirs to it. For tidiness, load this
@@ -73,15 +72,14 @@
containerLoader.useSystemLoader(junit.);
containerLoader.addLogicalLib(commons-logging);
-URL pri10URL = new URL(baseUrl, priority10/);
-containerLoader.addURL(pri10URL);
-
PathableClassLoader webappLoader = new
PathableClassLoader(containerLoader);
-webappLoader.setParentFirst(false);
webappLoader.addLogicalLib(testclasses);
-
+
URL pri20URL = new URL(baseUrl, priority20/);
webappLoader.addURL(pri20URL);
+
+URL pri10URL = new URL(baseUrl, priority10/);
+webappLoader.addURL(pri10URL);
// load the test class via webapp loader, and use the webapp loader
// as the tccl loader too.
@@ -113,7 +111,5 @@
LogFactory instance = LogFactory.getFactory();
String id = (String) instance.getAttribute(configId);
assertEquals(Correct config file loaded, priority20, id );
-
-fail(deliberate failure);
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[dbcp] Bz 33912 and testing for deadlock
I have reproduced the problem reported in Bz 33912, using both jdk 1.4 and 1.5 and commons-pool 1.2. I cannot reproduce the problem when I back the pool with commons-pool 1.3. The fix recommended in the bug report eliminates the deadlock when using commons-pool 1.2. I have a couple of questions that I would appreciate others' insight on. 1. Why does the deadlock not happen with [pool] 1.3? 2. Why does the recommended fix solve the problem? (I guess what I am asking here really is why exactly is the deadlock ocurring? I have partially validated the claim that the deadlock is due to contention with the evictor thread, but I don't see why localizing the synch eliminates this. The deadlock still occurs, btw, when a statement pool factory is provided). 3. What is a good way to set up a Junit test that detects a deadlock? Thanks in advance! Phil - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20015] - [lang] Make Entities public and unit test
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=20015. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=20015 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||LATER --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 03:44 --- Discussions on commons-dev led to a -1 and a vote for LATER. I'm in favour of not making it public as well, until users are actually asking for it. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26659] - [lang] add method to DateUtils to get the distance between 2 dates
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=26659. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=26659 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 03:48 --- After discussion on commons-dev, we've decided to mark this one as a WONTFIX. It's the other side of the simple/complex line we're drawing at which we'll be recommending that users use JODA Time instead of trying to keep trying to stretch the JDK time support. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29692] - [lang] String indentation feature request
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29692. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29692 --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 03:50 --- Talking on commons-dev, the opinion isn't very positive of adding this to StringUtils. I'm going to take a look at the code though as I'm pondering it as an idea for lang.text. I do think it's a valuable idea - but can we make a generic and yet simple API to handle user need? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 33825] - [lang] PATCH-New methods for DateUtils
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33825. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33825 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 03:55 --- After discussion on commons-dev, we're going to mark this as WONTFIX - it's a pretty large piece of scope and users will be better served by using JODA Time. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 33997] - [lang] optional precision round/trunc methods
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33997. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33997 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 04:11 --- Use BigDecimals. To round to 2 dp: bd.setScale(2, java.math.BigDecimal.ROUND_HALF_UP); -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35400] - [lang] Need ClassLoader support for SerializationUtils
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35400. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35400 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||LATER --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 04:18 --- Hesitant to get into the classloader world - seems to lead to bugs. Marking as LATER (to see if we get other users requesting the same thing). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36915] - [lang] change to ArrayUtils.toPrimitive and toObject
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36915. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36915 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 04:27 --- The blog urls don't work anymore - doesn't seem like a major issue either. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38800] - [lang] initial version of DateRange class
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38800. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38800 --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 04:35 --- This is the second suggestion of a DateRange... -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38800] - [lang] initial version of DateRange class
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38800. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38800 --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 04:36 --- http://issues.apache.org/bugzilla/show_bug.cgi?id=33825 -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38912] - [lang] Add Service class to locate SPI implementations
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38912. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38912 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 04:42 --- After discussion on commons-dev - out of scope for Lang. I'm not sure there's any huge advantage to trying to standardise the class pre-1.6, and the types of libraries that need this, don't tend to depend on Lang. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] next version etc
On 4/16/06, Gary Gregory [EMAIL PROTECTED] wrote:
-Original Message-
From: Stephen Colebourne [mailto:[EMAIL PROTECTED]
35588: Part of the lang.text call.
I need text.VariableFormatter. If 2.2 does not come out soon, I am
going
to pluck it out of there for our own use ;)
Do you need all its complexity with escaping?
I want to provide our users with highly flexible configuration files
(and scripts) where Java system properties and environment variables are
available.
It is possible that some of our users would need escaping things like
'$' and '{}'. The flexibility I would be willing to give up is what
characters to use for $ and {}, but this is the part that adds the least
amount of complexity.
If you are thinking of removing the ability to do things that correspond
to ${aVarPiece${anotherPiece}}, then I am somewhat indifferent right
now. It just seems like a lot of work to undo the code and the unit
tests since the current implementation works and it well covered by unit
tests. Furthermore, it seems to me like once a feature like
VariableFormatter is released, implementing the above feature would be
the next step in the evolution of the class. Just my POV though...
+1 to the escaping - it seems like it's just doing the right thing,
not an increased feature.
Increased feature would be: ${ENV.foo} :) Where ENV means the
environment (or ${D.foo} where it means the standard env).
Hen
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39322] New: - Clean up Lang for 3.0
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39322. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39322 Summary: Clean up Lang for 3.0 Product: Commons Version: 3.0 Final Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Lang AssignedTo: commons-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] Remove deprecated methods, classes and packages for Lang 3.0; and compile under Java 5 and 6. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39167] - [lang] escapeXML() - Not escaping low characters
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39167. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39167 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE | --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 05:05 --- Oops, not a dupe. It's at the opposite end of the spectrum. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38210] - [lang] StringEscaper.escapeXml() escapes characters 0x7f
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38210. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38210 --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 05:06 --- 39167 not a dupe - it's at the other end of the character range. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] next version etc
Summarising the 25 remaining open issues: Debatable: 29692 - I think a lang.text.Indenter would be valuable. (33825), 38800 - DateRange class. Two separate offerings of this class. What are the problems with having this? What are the hidden bugs? Remaining issue for next release: 30184 - CompositeFormat 33401 - check 34284 - NPE in EqualsBuilder 34351 - ClassUtils.getPublicMethod 35588 - text.VariableStuff 36061 - Error in ToStringBuilder 36873 - text.VariableStuff 37385 - Improve javadoc for EscapeUtils 38569 - StringEscapeUtils amphersand bug. 39254 - Expose DateIterator or add method 39315 - New method for EqualsBuilder 37499 - Improve parseDate API The following seem to involve significantly more time than the above - still could go in next release but time needs to be spent. 33889 - Split camel case code. 36512 - Enhanced forName 3 - EnumUtils in 1.5 36925 - ReflectionToStringBuilder and secure fields 37243 - DateUtils.trunc + DST bug 37690 - RandomString + Unicode 38210, 39167 - Complaints about the escapeXml functionality. 38401 - Bug in DurationFormatUtils Must wait until 3.0: 36886 - Change Exception in Validate.notNull 39322 - Clean up Lang Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39322] - [lang] Clean up Lang for 3.0
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39322. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39322 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Clean up Lang for 3.0 |[lang] Clean up Lang for 3.0 --- Additional Comments From [EMAIL PROTECTED] 2006-04-17 05:15 --- You'd think I'd remember the [lang] :) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[latka][all] Dormant Latka questions
In making Latka dormant, should we be doing anything about the 15 issues open for Latka in Bugzilla; and should we be doing anything about the jakarta.apache.org/commons/latka/ website? Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
