Re: [RE-VOTE] AntUnit 1.0 Beta 2

2006-10-28 Thread Conor MacNeill


Stefan Bodewig wrote:
 Hi,
 
 I've re-built AntUnit with -source 1.2 and uploaded everything to
 http://people.apache.org/~bodewig/antunit/.  I'd like to release
 those files as 1.0Beta2.
 
 Stefan
 

+1

Conor

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r468260 - /ant/antlibs/common/trunk/build.xml

2006-10-28 Thread Stefan Bodewig
On Fri, 27 Oct 2006, Peter Reilly [EMAIL PROTECTED] wrote:
 On 10/27/06, [EMAIL PROTECTED] [EMAIL PROTECTED]
 wrote:

 +property name=javac.-source value=1.2/
 +property name=javac.-target value=1.2/
 +property name=javac.debug value=on/


 Stefan,
 why do you have chosen the name -source (leading '-') instead of
 source?

To not confuse it with src and dest, maybe I was just feeling fancy,
don't know.

 and not do it for javac.debug ?

because it doesn't correspond to a -debug command line switch and
javac.-g would have been too cryptic.  Maybe I wasn't fancy enough.

We can always change things ...

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: A note on release votes

2006-10-28 Thread Stefan Bodewig
On Fri, 27 Oct 2006, Antoine Levy-Lambert [EMAIL PROTECTED] wrote:

 I prefer the procedure which I have used for Ant 1.6 and for the
 betas of 1.7 to define a release date in the vote thread, and then
 to build and publish the release mechanically on the release date.

I may have been a bit unclear.  This process simply doesn't comply
with ASF procedures.  We cannot vote on the release of an artifact
that we haven't seen yet.  We are required to check that the actual
released artifact is correct.  Where correct is determined by a number
of criteria.

http://incubator.apache.org/guides/releasemanagement.html

There is something called RAT by Robert Burrel Donkins to check
compliance of artifacts, this is used by quite a few incubator folks.
I haven't used it myself yet.

http://code.google.com/p/arat/

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: FW: antunit branch for 1.6.x compatibility

2006-10-28 Thread Stefan Bodewig
On Tue, 24 Oct 2006, Vladimir Egorov [EMAIL PROTECTED] wrote:

 TestLogic is an initiative by BEA Systems Inc. Tools team to provide
 an open source testing framework for the enterprise.

[...]

 The project is so far a private project on CodeShare. We are
 planning to open source when we reach some point of maturity

My personal advice would be to go public as soon as you can.  It is
far easier to attract new contributors if the code base isn't too
polished and there are still obvious places to work on.

 If there is enough interest we could certainly still create a 1.6
 compatible branch.
 
 From this posting I got a reply from Paul King, who explained that
 similar asserts are being used in WebTest project and that he would
 be interested to learn the outcome of this discussion.

Paul is subscribed here as well, haven't seen him chime in, yet.

It is mostly a question of how much ongoing work it would take when we
add new features to AntUnit.  Which parts of AntUnit would you use?
Only the assertions or the tasks and listeners as well?

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Ideas on support of javax.script'ing

2006-10-28 Thread Stefan Bodewig
On Fri, 27 Oct 2006, Peter Reilly [EMAIL PROTECTED] wrote:

 The idea is that ant-core code would first check for the language
 implementation in bsf and if that (the language or bsf) does not
 exist, ant-core will then check for javax.script support for the
 language.

Sounds good.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: A note on release votes

2006-10-28 Thread Antoine Levy-Lambert
Hello Stefan,

OK, maybe this does not comply with ASF procedures.
I see that tomcat seems to be doing releases the same way as what you
suggest and did for the antlib(s):

http://marc.theaimsgroup.com/?l=tomcat-devm=115859000312242w=2

This procedure for releases opens for me a number of questions :

- does it not force the project to actually hold two votes, one to choose a 
date to build a release candidate,
the second to decide whether this release candidate is valid ? If you decide 
spontaneously to build a release candidate
on a random date-time, chances are that it will not be accepted

- should the release manager tag the code in any case before building ? Now 
there is a danger that you create a
tag ANT_170 but then you get a negative vote, this is not 1.7.0 any more. Maybe 
the solution in this case is to remove the tag in subversion.
Or can you create an interim tag called for instance 
ANT_170_build20061030123405 and rename the tag to something else if the 
corresponding build is 
accepted as a release

- in the case of ant, the release manager must build with the assumption that 
the artefacts are going to be accepted as version x.y.z. The version is in
defaultManifest.mf, in version.txt, in the naming of the artifacts.

- since we will be releasing both to the maven directory tree and using our 
usual distribution system, does the release manager also need to upload the 
java-repository directory tree,
maybe as a zip file ?

- this procedure makes lose the time of the vote on the binary artifacts, where 
the release could actually already be made available

- there is no clear calendar. I find it better if a project commits itself to 
some clear milestones

If you say this system of creating a release candidate, uploading it to 
~release_manager/betadistribution, then voting on accepting this as version xyz 
is ASF procedure,
then I will have to live with it. But I will work to get the procedure changed 
towards more automation and more predictability. 

Regards,

Antoine


Stefan Bodewig wrote:
 On Fri, 27 Oct 2006, Antoine Levy-Lambert [EMAIL PROTECTED] wrote:

   
 I prefer the procedure which I have used for Ant 1.6 and for the
 betas of 1.7 to define a release date in the vote thread, and then
 to build and publish the release mechanically on the release date.
 

 I may have been a bit unclear.  This process simply doesn't comply
 with ASF procedures.  We cannot vote on the release of an artifact
 that we haven't seen yet.  We are required to check that the actual
 released artifact is correct.  Where correct is determined by a number
 of criteria.

 http://incubator.apache.org/guides/releasemanagement.html

 There is something called RAT by Robert Burrel Donkins to check
 compliance of artifacts, this is used by quite a few incubator folks.
 I haven't used it myself yet.

 http://code.google.com/p/arat/

 Stefan
   


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: FW: antunit branch for 1.6.x compatibility

2006-10-28 Thread Vladimir Egorov
 -Original Message-
 From: Stefan Bodewig [mailto:[EMAIL PROTECTED]
 Sent: Saturday, October 28, 2006 7:14 AM
 To: dev@ant.apache.org
 Subject: Re: FW: antunit branch for 1.6.x compatibility
 
 On Tue, 24 Oct 2006, Vladimir Egorov [EMAIL PROTECTED] wrote:
 
  TestLogic is an initiative by BEA Systems Inc. Tools team to provide
  an open source testing framework for the enterprise.
 
 [...]
 
  The project is so far a private project on CodeShare. We are
  planning to open source when we reach some point of maturity
 
 My personal advice would be to go public as soon as you can.  It is
 far easier to attract new contributors if the code base isn't too
 polished and there are still obvious places to work on.

Ok. I will see what I can do.

  If there is enough interest we could certainly still create a 1.6
  compatible branch.
 
  From this posting I got a reply from Paul King, who explained that
  similar asserts are being used in WebTest project and that he would
  be interested to learn the outcome of this discussion.
 
 Paul is subscribed here as well, haven't seen him chime in, yet.

Here is a snippet from Paul's email where he told me about WebTest:

 -Original Message-
 From: Paul King [mailto:[EMAIL PROTECTED]
 Sent: Friday, October 20, 2006 5:28 PM
 To: Vladimir Egorov
 Cc: Vishal Vishnoi; Gouri Pandeshwar
 Subject: Re: antunit branch for 1.6.x compatibility
[..]
 WebTest is available at: http://webtest.canoo.com
 
 It provides a complete testing framework for web applications,
 web services and email systems. WebTest has the notion of a test
 step. Each step is just an Ant task with a context and hooks for
 reporting. At the moment WebTest assertions don't extend AntUnit.
 They are all Ant Tasks and throw StepFailedException or
 StepExecutionException if an assertion isn't met. This in turn
 ties in with its reporting. At the moment we are looking at
 whether the verification steps should be made more like AntUnit.
 At the moment we don't want to give up Ant 1.6.5 compatibility
 and we aren't willing to give away the excellent reporting
 capabilities which WebTest is known for.
 
 There are many assertion steps. They all begin with verify.
 To give you a flavour, some of the ones related to web site
 and Ajax application testing are:
 
   verifyTitle,verifyText,verifyElement,verifyInputField
   verifyLinks,verifyXPath,verifyCheckbox,verifyCookie
 
 In your Ant script you would simply do:
 
   invoke url=http://dev2dev.bea.com/
   verifyText text=UPCOMING EVENTS/
 
 There are other assertions as well, e.g. on a pdf document:
 
 verifyEncryptionPermissions allow=fillIn
 deny=printing, modifyContents, copy, assembly/
 
 Emails you can test fields, content and attachments.
 Web Services you can test content and attachments using xpaths.
 Excel documents you can verify content and formulas.

Note how verify*s are similar to assert*s. Also: we don't want to give
up Ant 1.6.5 compatibility.

Here is a snippet from Paul's last email on the subject.

 -Original Message-
 From: Paul King [mailto:[EMAIL PROTECTED]
 Sent: Friday, October 20, 2006 10:30 PM
 To: Vladimir Egorov
 Cc: Vishal Vishnoi; Gouri Pandeshwar
 Subject: Re: antunit branch for 1.6.x compatibility
[..]
 If you do decide on a technical direction for going forward on how
 to represent your assertions (e.g. making them more aligned with
 AntUnit assertions), I'd be keen to hear from you on just that piece
 if that is deemed acceptable. I am likely to make changes to how
 WebTest represents its assertions over the next few months and any
 feedback on what you believe to be a useful direction would be
welcome.

This brings us to your next question.

 Which parts of AntUnit would you use?
 Only the assertions or the tasks and listeners as well?

Currently we are only interested in asserts library. It is easy to write
them, but it would not be good if the same thing was done differently in
different projects.

What is your take on this? I mean, some generic asserts are the same for
AntUnit, WebTest, and TestLogic, but some are specific to the project.
Do you think it is worth the effort to standardize on a common asserts
library and what should be the extension mechanism?

In the future, we may be interested in AntUnit runtime (task and
listeners) as well, depending on the direction our project takes.

--Vladimir

___
Notice:  This email message, together with any attachments, may contain
information  of  BEA Systems,  Inc.,  its subsidiaries  and  affiliated
entities,  that may be confidential,  proprietary,  copyrighted  and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.

-
To 

DO NOT REPLY [Bug 40313] - delete doesnt delete when defaultexcludes=false and no includes is set

2006-10-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40313.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40313


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED
   Target Milestone|--- |1.7.0




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40313] - delete doesnt delete when defaultexcludes=false and no includes is set

2006-10-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40313.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40313





--- Additional Comments From [EMAIL PROTECTED]  2006-10-28 12:08 ---
fixed in SVN, added 2 testcases. Hope my solution is OK.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40722] - include if=property logic changed for javac since ant 1.6.5

2006-10-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40722.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40722





--- Additional Comments From [EMAIL PROTECTED]  2006-10-28 12:32 ---
Created an attachment (id=19048)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=19048action=view)
updated build.xml

The target fileset of this build.xml works with Ant 1.6.5
It fails with the current SVN.
This issue is more general than an issue with the javac/ task, it is a change
in the behavior of fileset. Could it be even due to changes in introspection
mechanisms ?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: FW: antunit branch for 1.6.x compatibility

2006-10-28 Thread Steve Loughran

Stefan Bodewig wrote:

On Tue, 24 Oct 2006, Vladimir Egorov [EMAIL PROTECTED] wrote:


TestLogic is an initiative by BEA Systems Inc. Tools team to provide
an open source testing framework for the enterprise.


[...]


The project is so far a private project on CodeShare. We are
planning to open source when we reach some point of maturity


My personal advice would be to go public as soon as you can.  It is
far easier to attract new contributors if the code base isn't too
polished and there are still obvious places to work on.


Also, get on apache gump and build against the SVN_HEAD versions of all 
the other OSS projects, which means implicitly, a migration to Ant1.7+


That doesnt mean you have to commit to ant1.7 only, but you do make sure 
that ant1.7's changes dont break your app.


-steve

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



war and web.xml

2006-10-28 Thread Steve Loughran



I've been updating the war file task with better support for optional 
web.xml files. Its been a bit tricky, but I've got a good set of unit 
tests. I so love antunit, BTW :)


Here's the current setting

1 -Unless you say needxmlfile=false, the web.xml file is mandatory. 
This is compatible with what we have today


1.5 you can omit the webxml attribute if update=true; again, what we 
have today.


2 -We dont warn if the xml file is duplicated in a fileset, *provided* 
the path of that reference matches that of the webxml attribute. I.e you 
can duplicate it in any fileset without complaints.


These two keep everything compatible with what we had before. You forget 
a web.xml file, the build halts. Which is what you usually want.


3. if you set needxmlfile=false, then a web.xml file becomes *optional*. 
It is no longer an error to omit the file.


4. You can then pull in a web.xml file via the webxml attribute, or via 
a nested fileset. In either case we say
Although needxmlfile is false, a web.xml file was included  ... and 
point to the file that was added.


5. once you set needxmlfile=false, and omit the web.xml attribute, you 
can pull in a WEB-INF/web.xml from a fileset. What if there is 1 match 
in the fileset? The first one added wins; there is no extra warning message.


6. When updating an existing war file, if update=false and 
needxmlfile=false, then things get complex. The problem here is that 
there isnt a webxml file, so stuff from filesets get pulled in. but 
dependency logic in the fileset checking engages first.


(4), (5), and (6) bother me. I think its possible to create confusion as 
to which web.xml file gets pulled in. What do people think?







-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: FW: antunit branch for 1.6.x compatibility

2006-10-28 Thread Paul King

Stefan Bodewig wrote:

If there is enough interest we could certainly still create a 1.6
compatible branch.

From this posting I got a reply from Paul King, who explained that
similar asserts are being used in WebTest project and that he would
be interested to learn the outcome of this discussion.


Paul is subscribed here as well, haven't seen him chime in, yet.

It is mostly a question of how much ongoing work it would take when we
add new features to AntUnit.  Which parts of AntUnit would you use?
Only the assertions or the tasks and listeners as well?


I am listening but still pondering what the best path is before
making further suggestions. WebTest has a focus on Acceptance
Testing and has more extensive reporting than e.g. JUnit.
AntUnit currently has sufficient listener capability and
infrastructure to align it closely with JUnit-style tests.

WebTest's steps are just Ant Tasks with a context. So it would
not be impossible to make WebTest's verification steps AntUnit
assertions with a context. It would be an interesting way to
move forward but maybe it isn't critical at the moment.

See the thread 'Property expansion notification interesting?'
over the last few weeks to see one of the things we would need
to solve first.

I'll keep pondering,

Paul.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40722] - include if=property logic changed for javac since ant 1.6.5

2006-10-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40722.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40722





--- Additional Comments From [EMAIL PROTECTED]  2006-10-28 14:13 ---
It looks like the classes which control this behavior are AbstractFileSet.java,
PatternSet.java, DirectoryScanner.java
running ant -debug with ant-1.6.5 gives this output
fileset: Setup scanner in dir C:\dev\40722\src with patternSet{ includes:
[Class1.java:if-trigger.include] excludes: [] }

with the latest SVN
fileset: Setup scanner in dir C:\dev\40722\src with patternSet{ includes: []
excludes: [] }



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r468781 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/types/AbstractFileSet.java src/main/org/apache/tools/ant/types/PatternSet.java src/tests/antunit/types/fileset-test.xml

2006-10-28 Thread antoine
Author: antoine
Date: Sat Oct 28 15:54:48 2006
New Revision: 468781

URL: http://svn.apache.org/viewvc?view=revrev=468781
Log:
fix for Bugzilla 40722. Was identified as a directory scanning problem.

Added:
ant/core/trunk/src/tests/antunit/types/fileset-test.xml
Modified:
ant/core/trunk/WHATSNEW
ant/core/trunk/src/main/org/apache/tools/ant/types/AbstractFileSet.java
ant/core/trunk/src/main/org/apache/tools/ant/types/PatternSet.java

Modified: ant/core/trunk/WHATSNEW
URL: 
http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?view=diffrev=468781r1=468780r2=468781
==
--- ant/core/trunk/WHATSNEW (original)
+++ ant/core/trunk/WHATSNEW Sat Oct 28 15:54:48 2006
@@ -13,6 +13,9 @@
 * delete doesnt delete when defaultexcludes=false and no includes is set 
   fixed. Bugzilla 40313.
 
+* behavior change of DirectoryScanner/AbstractFileset when conditional include
+  patterns are used. Bugzilla 40722.
+
 Other changes:
 --
 

Modified: 
ant/core/trunk/src/main/org/apache/tools/ant/types/AbstractFileSet.java
URL: 
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/AbstractFileSet.java?view=diffrev=468781r1=468780r2=468781
==
--- ant/core/trunk/src/main/org/apache/tools/ant/types/AbstractFileSet.java 
(original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/types/AbstractFileSet.java Sat 
Oct 28 15:54:48 2006
@@ -459,12 +459,16 @@
 }
 ds.setBasedir(dir);
 
-PatternSet ps = mergePatterns(p);
+final int count = additionalPatterns.size();
+for (int i = 0; i  count; i++) {
+Object o = additionalPatterns.elementAt(i);
+defaultPatterns.append((PatternSet) o, p);
+}
 p.log(getDataTypeName() + : Setup scanner in dir  + dir
-+  with  + ps, Project.MSG_DEBUG);
++  with  + defaultPatterns, Project.MSG_DEBUG);
 
-ds.setIncludes(ps.getIncludePatterns(p));
-ds.setExcludes(ps.getExcludePatterns(p));
+ds.setIncludes(defaultPatterns.getIncludePatterns(p));
+ds.setExcludes(defaultPatterns.getExcludePatterns(p));
 if (ds instanceof SelectorScanner) {
 SelectorScanner ss = (SelectorScanner) ds;
 ss.setSelectors(getSelectors(p));

Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/PatternSet.java
URL: 
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/PatternSet.java?view=diffrev=468781r1=468780r2=468781
==
--- ant/core/trunk/src/main/org/apache/tools/ant/types/PatternSet.java 
(original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/types/PatternSet.java Sat Oct 
28 15:54:48 2006
@@ -117,11 +117,12 @@
  * @return a printable form of this object.
  */
 public String toString() {
+StringBuffer buf = new StringBuffer();
 if (name == null) {
-throw new BuildException(
-Missing attribute \name\ for a pattern);
+buf.append(noname);
+} else {
+buf.append(name);
 }
-StringBuffer buf = new StringBuffer(name);
 if ((ifCond != null) || (unlessCond != null)) {
 buf.append(:);
 String connector = ;

Added: ant/core/trunk/src/tests/antunit/types/fileset-test.xml
URL: 
http://svn.apache.org/viewvc/ant/core/trunk/src/tests/antunit/types/fileset-test.xml?view=autorev=468781
==
--- ant/core/trunk/src/tests/antunit/types/fileset-test.xml (added)
+++ ant/core/trunk/src/tests/antunit/types/fileset-test.xml Sat Oct 28 15:54:48 
2006
@@ -0,0 +1,32 @@
+project xmlns:au=antlib:org.apache.ant.antunit default=all
+
+  target name=test-fileset-with-if
+fileset id=this.xml dir=.
+  include if=trigger.include name=fileset-test.xml/
+/fileset
+pathconvert refid=this.xml property=this.xml.prop 
pathsep=${line.separator} setonempty=false/
+au:assertTrue message=fileset this.xml should not contain anything but 
contains ${this.xml.prop}
+not
+  isset property=this.xml.prop/
+/not
+/au:assertTrue
+  /target
+
+  target name=test-fileset-with-if-property-set
+property name=trigger.include value=true/
+fileset id=this.xml dir=.
+  include if=trigger.include name=fileset-test.xml/
+/fileset
+pathconvert refid=this.xml property=this.xml.prop 
pathsep=${line.separator} setonempty=false/
+au:assertPropertySet name=this.xml.prop message=fileset should contain 
one file/
+echo${this.xml.prop}/echo
+au:assertLogContains text=fileset-test.xml/
+  /target
+
+  target name=all
+au:antunit
+  fileset dir=${basedir} includes=fileset-test.xml/
+  

DO NOT REPLY [Bug 40722] - include if=property logic changed for javac since ant 1.6.5

2006-10-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40722.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40722


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED
   Target Milestone|--- |1.7.0




--- Additional Comments From [EMAIL PROTECTED]  2006-10-28 15:56 ---
fixed in SVN. 
I have had to shunt the procedure mergePatterns in AbstractFileset to do this.
The code which has been put back in setupDirectoryScanner(FileScanner ds,
Project p) comes from Ant 1.6.5

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: next release steps

2006-10-28 Thread Antoine Levy-Lambert
Hello,



Peter Reilly wrote:

 I have some pending work on classpaths in script,
 there is a number of problems with the current implementation.

 1) It does not work for language engines contained in the BSF jar.
This is  due to usual classloading delegation issues. This effects
the  languages javascript (rhino), tcl (jacl), jython and rexx.

 2) It is not implemented for scriptmapper, scriptcondition etc.

 3) It is not implemented for scriptdef

 4) One cannot have bsf.jar in the classpath element.

 I have fixes for 1,2 and 4. 3) should not be too hard.

I have no clue about these issues, but fixes are always welcome ...

 Other things that need to be done before ant 1.7.0 final:
 Fix some regressions.
 bugzilla:

 http://issues.apache.org/bugzilla/show_bug.cgi?id=40313
 delete doesnt delete when defaultexcludes=false and no includes is
 set

 http://issues.apache.org/bugzilla/show_bug.cgi?id=40722
 include if=property logic changed for javac since ant 1.6.5

I have done something to fix these 2 issues.
Do we want to keep this method in AbstractFileSet :
public synchronized PatternSet mergePatterns(Project p)
Maybe there is something useful in it ?
 I could free a slot for a next concrete release step on Sunday, November
 5th.

 +1 Perhaps call it RC1

 Peter



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36733] - NPE in XMLJUnitResultFormatter.formatOutput under Java 1.4.2_08

2006-10-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36733.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36733





--- Additional Comments From [EMAIL PROTECTED]  2006-10-28 17:08 ---
The patch of Maarten makes sense, but there is still no precise way to reproduce
the bug.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24106] - Suites are not reported correctly in JUnitReport

2006-10-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=24106.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24106





--- Additional Comments From [EMAIL PROTECTED]  2006-10-28 17:11 ---
This issue is very popular. Any one wants to write a patch for it ?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40839] New: - javac fails with NPE when compiling with eclipse ecj 3.1.x

2006-10-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40839.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40839

   Summary: javac fails with NPE when compiling with eclipse ecj
3.1.x
   Product: Ant
   Version: 1.7.0Beta3
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Core tasks
AssignedTo: dev@ant.apache.org
ReportedBy: [EMAIL PROTECTED]


Executing javac on any sources with ant 1.7 and ecj 3.1 (taken from eclipse
3.1.2) results in (-debug):

Apache Ant version 1.7.0Beta3 compiled on October 29 2006
Buildfile: build.xml
Adding reference: ant.PropertyHelper
Detected Java version: 1.5 in: /opt/sun-jdk-1.5.0.08/jre
Detected OS: Linux
Adding reference: ant.ComponentHelper
Setting ro project property: trigger.include - true
Setting ro project property: build.compiler -
org.eclipse.jdt.core.JDTCompilerAdapter
Setting ro project property: ant.file - /home/caster/gentoo/ant/tst/build.xml
setting java.net.useSystemProxies to true
Adding reference: ant.projectHelper
Adding reference: ant.parsing.context
Adding reference: ant.targets
parsing buildfile /home/caster/gentoo/ant/tst/build.xml with URI =
file:/home/caster/gentoo/ant/tst/build.xml
Setting ro project property: ant.project.name - test
Adding reference: test
Setting ro project property: ant.file.test - 
/home/caster/gentoo/ant/tst/build.xml
Project base dir set to: /home/caster/gentoo/ant/tst
 +Target:
 +Target: compile
 +Target: prepare
 +Target: clean
Attempting to create object of type org.apache.tools.ant.helper.DefaultExecutor
Adding reference: ant.executor
Build sequence for target(s) `compile' is [compile]
Complete build sequence is [compile, prepare, clean, ]

compile:
[antlib:org.apache.tools.ant] Could not load definitions from resource
org/apache/tools/ant/antlib.xml. It could not be found.
fileset: Setup scanner in dir /home/caster/gentoo/ant/tst/src with patternSet{
includes: [Class1.java:if-trigger.include] excludes: [] }
[javac] Class1.java added as Class1.class doesn't exist.
[javac] Compiling 1 source file to /home/caster/gentoo/ant/tst/classes
[javac] Using JDT compiler
dropping /opt/sun-jdk-1.5.0.08/jre/jre/lib/rt.jar from path as it doesn't exist
dropping /opt/sun-jdk-1.5.0.08/Classes/jce.jar from path as it doesn't exist
dropping /opt/sun-jdk-1.5.0.08/Classes/jsse.jar from path as it doesn't exist
dropping /opt/sun-jdk-1.5.0.08/jre/lib/core.jar from path as it doesn't exist
dropping /opt/sun-jdk-1.5.0.08/jre/lib/graphics.jar from path as it doesn't 
exist
dropping /opt/sun-jdk-1.5.0.08/jre/lib/security.jar from path as it doesn't 
exist
dropping /opt/sun-jdk-1.5.0.08/jre/lib/server.jar from path as it doesn't exist
dropping /opt/sun-jdk-1.5.0.08/jre/lib/xml.jar from path as it doesn't exist
dropping /opt/sun-jdk-1.5.0.08/Classes/classes.jar from path as it doesn't exist
dropping /opt/sun-jdk-1.5.0.08/Classes/ui.jar from path as it doesn't exist

BUILD FAILED
/home/caster/gentoo/ant/tst/build.xml:5: java.lang.NullPointerException
at
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:115)
at org.apache.tools.ant.Task.perform(Task.java:342)
at org.apache.tools.ant.Target.execute(Target.java:357)
at org.apache.tools.ant.Target.performTasks(Target.java:385)
at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1291)
at org.apache.tools.ant.Project.executeTarget(Project.java:1260)
at
org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
at org.apache.tools.ant.Project.executeTargets(Project.java:1143)
at org.apache.tools.ant.Main.runBuild(Main.java:698)
at org.apache.tools.ant.Main.startAnt(Main.java:199)
at org.apache.tools.ant.launch.Launcher.run(Launcher.java:298)
at org.apache.tools.ant.launch.Launcher.main(Launcher.java:104)
Caused by: java.lang.NullPointerException
at
org.apache.tools.ant.types.AbstractFileSet.setupDirectoryScanner(AbstractFileSet.java:467)
at
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:429)
at org.apache.tools.ant.types.FileSet.iterator(FileSet.java:69)
at 
org.apache.tools.ant.types.resources.Union.getCollection(Union.java:105)
at 
org.apache.tools.ant.types.resources.Union.getCollection(Union.java:88)
at
org.apache.tools.ant.types.resources.BaseResourceCollectionContainer.cacheCollection(BaseResourceCollectionContainer.java:244)
at
org.apache.tools.ant.types.resources.BaseResourceCollectionContainer.toString(BaseResourceCollectionContainer.java:229)
at 

DO NOT REPLY [Bug 40839] - javac fails with NPE when compiling with eclipse ecj 3.1.x

2006-10-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40839.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40839





--- Additional Comments From [EMAIL PROTECTED]  2006-10-28 20:44 ---
the sources of JDTCompilerAdapter can be seen here
http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.jdt.core/antadapter/org/eclipse/jdt/core/JDTCompilerAdapter.java

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40839] - javac fails with NPE when compiling with eclipse ecj 3.1.x

2006-10-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40839.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40839





--- Additional Comments From [EMAIL PROTECTED]  2006-10-28 20:46 ---
Can you add your build file to the bug report ? Or ideally just the piece which
is necessary to find the error.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]