[GitHub] [camel-quarkus] oscerd merged pull request #205: Auto configuration of metrics management strategies
oscerd merged pull request #205: Auto configuration of metrics management strategies URL: https://github.com/apache/camel-quarkus/pull/205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] jamesnetherton commented on a change in pull request #957: Automatically resolve dependencies for language expressions
jamesnetherton commented on a change in pull request #957: Automatically
resolve dependencies for language expressions
URL: https://github.com/apache/camel-k/pull/957#discussion_r328496551
##
File path: pkg/util/source/inspector.go
##
@@ -35,13 +35,22 @@ var (
doubleQuotedTo =
regexp.MustCompile(`\.to\s*\(\s*"([a-zA-Z0-9-]+:[^"]+)"`)
doubleQuotedToD =
regexp.MustCompile(`\.toD\s*\(\s*"([a-zA-Z0-9-]+:[^"]+)"`)
doubleQuotedToF =
regexp.MustCompile(`\.toF\s*\(\s*"([a-zA-Z0-9-]+:[^"]+)"`)
+ languageRegexp =
regexp.MustCompile(`language\s*\(\s*["|']([a-zA-Z0-9-]+[^"|']+)["|']\s*,.*\)`)
additionalDependencies = map[string]string{
- `.*JsonLibrary\.Jackson.*`: "camel:jackson",
- `.*\.hystrix().*`: "camel:hystrix",
- `.*restConfiguration().*`: "camel:rest",
- `.*rest(("[a-zA-Z0-9-/]+")*).*`: "camel:rest",
- `^\s*rest\s*{.*`:"camel:rest",
+ `.*JsonLibrary\.Jackson.*`:
"camel:jackson",
+ `.*\.hystrix().*`:
"camel:hystrix",
+ `.*restConfiguration().*`: "camel:rest",
+ `.*rest(("[a-zA-Z0-9-/]+")*).*`: "camel:rest",
+ `^\s*rest\s*{.*`: "camel:rest",
+ `.*\.groovy\s*\(.*\).*`:
"camel:groovy",
+ `.*\.(jsonpath|jsonpathWriteAsString)\s*\(.*\).*`:
"camel:jsonpath",
+ `.*\.ognl\s*\(.*\).*`: "camel:ognl",
+ `.*\.mvel\s*\(.*\).*`: "camel:mvel",
+ `.*\.?simple\s*\(.*\).*`: "camel:bean",
+ `.*\.xquery\s*\(.*\).*`:
"camel:saxon",
+ `.*\.xpath\s*\(.*\).*`:
"camel:xpath",
Review comment:
Thanks, I pushed a fix + test for that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli closed issue #137: Add the error log when setting component property failed
lburgazzoli closed issue #137: Add the error log when setting component property failed URL: https://github.com/apache/camel-k-runtime/issues/137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] lburgazzoli commented on issue #959: Include camel-k-runtime version in camel-catalog
lburgazzoli commented on issue #959: Include camel-k-runtime version in camel-catalog URL: https://github.com/apache/camel-k/issues/959#issuecomment-535393572 https://github.com/apache/camel-k-runtime/issues/141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #137: Add the error log when setting component property failed
lburgazzoli commented on issue #137: Add the error log when setting component property failed URL: https://github.com/apache/camel-k-runtime/issues/137#issuecomment-535393809 Fixed by https://github.com/apache/camel-k-runtime/pull/138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli opened a new issue #141: Include camel-k-runtime version in camel-catalog
lburgazzoli opened a new issue #141: Include camel-k-runtime version in camel-catalog URL: https://github.com/apache/camel-k-runtime/issues/141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] lburgazzoli opened a new issue #959: Include camel-k-runtime version in camel-catalog
lburgazzoli opened a new issue #959: Include camel-k-runtime version in camel-catalog URL: https://github.com/apache/camel-k/issues/959 We need to include the camel-k-runtime version in camel catalog and use it to match the right catalog for an integration This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] lburgazzoli commented on a change in pull request #957: Automatically resolve dependencies for language expressions
lburgazzoli commented on a change in pull request #957: Automatically resolve
dependencies for language expressions
URL: https://github.com/apache/camel-k/pull/957#discussion_r328482946
##
File path: pkg/util/source/inspector.go
##
@@ -35,13 +35,22 @@ var (
doubleQuotedTo =
regexp.MustCompile(`\.to\s*\(\s*"([a-zA-Z0-9-]+:[^"]+)"`)
doubleQuotedToD =
regexp.MustCompile(`\.toD\s*\(\s*"([a-zA-Z0-9-]+:[^"]+)"`)
doubleQuotedToF =
regexp.MustCompile(`\.toF\s*\(\s*"([a-zA-Z0-9-]+:[^"]+)"`)
+ languageRegexp =
regexp.MustCompile(`language\s*\(\s*["|']([a-zA-Z0-9-]+[^"|']+)["|']\s*,.*\)`)
additionalDependencies = map[string]string{
- `.*JsonLibrary\.Jackson.*`: "camel:jackson",
- `.*\.hystrix().*`: "camel:hystrix",
- `.*restConfiguration().*`: "camel:rest",
- `.*rest(("[a-zA-Z0-9-/]+")*).*`: "camel:rest",
- `^\s*rest\s*{.*`:"camel:rest",
+ `.*JsonLibrary\.Jackson.*`:
"camel:jackson",
+ `.*\.hystrix().*`:
"camel:hystrix",
+ `.*restConfiguration().*`: "camel:rest",
+ `.*rest(("[a-zA-Z0-9-/]+")*).*`: "camel:rest",
+ `^\s*rest\s*{.*`: "camel:rest",
+ `.*\.groovy\s*\(.*\).*`:
"camel:groovy",
+ `.*\.(jsonpath|jsonpathWriteAsString)\s*\(.*\).*`:
"camel:jsonpath",
+ `.*\.ognl\s*\(.*\).*`: "camel:ognl",
+ `.*\.mvel\s*\(.*\).*`: "camel:mvel",
+ `.*\.?simple\s*\(.*\).*`: "camel:bean",
+ `.*\.xquery\s*\(.*\).*`:
"camel:saxon",
+ `.*\.xpath\s*\(.*\).*`:
"camel:xpath",
Review comment:
I think `xpath` exists also in a form of `transform(xpath(...))`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] jamesnetherton opened a new pull request #957: Automatically resolve dependencies for language expressions
jamesnetherton opened a new pull request #957: Automatically resolve dependencies for language expressions URL: https://github.com/apache/camel-k/pull/957 fixes #914 fixes #929 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new issue #956: Upgrade to Camel 3.0.0-RC1
nicolaferraro opened a new issue #956: Upgrade to Camel 3.0.0-RC1 URL: https://github.com/apache/camel-k/issues/956 And current runtime snapshot, that already supports it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
astefanutti commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r328455298
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
@asifdxtreme thanks for your patience. That solves the CLI part. Then when
the platform is created without the CLI, the cache needs to be enabled by
default. That means turning the `KanikoBuildCache` field into a `*bool` and
defaulting to `true` when its value is `nil`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] asifdxtreme commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
asifdxtreme commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r328131853
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
Hi @astefanutti Thanks again for the suggestion and help to fix this issue,
as per your review suggestions I have updated the code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] nicolaferraro commented on issue #944: Release Camel K 1.0.0-M2
nicolaferraro commented on issue #944: Release Camel K 1.0.0-M2 URL: https://github.com/apache/camel-k/issues/944#issuecomment-534953231 Let's postpone release by a week to have more time to fix and tests issues in: https://github.com/apache/camel-k/milestone/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti opened a new pull request #955: chore: Remove unecessary watch on builds while reconciling integrations
astefanutti opened a new pull request #955: chore: Remove unecessary watch on builds while reconciling integrations URL: https://github.com/apache/camel-k/pull/955 No `Integration` CRs own `Build` CRs anymore. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli merged pull request #138: #137 Throw exception when setting component property failed
lburgazzoli merged pull request #138: #137 Throw exception when setting component property failed URL: https://github.com/apache/camel-k-runtime/pull/138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #201: Fix #184 Leverage platform http service
lburgazzoli commented on a change in pull request #201: Fix #184 Leverage
platform http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r327972365
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/QuarkusPlatformHttpEngine.java
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.platform.http.runtime;
+
+import javax.enterprise.context.ApplicationScoped;
+import javax.inject.Inject;
+import javax.inject.Named;
+
+import org.apache.camel.Consumer;
+import org.apache.camel.Processor;
+import org.apache.camel.component.platform.http.PlatformHttpConstants;
+import org.apache.camel.component.platform.http.PlatformHttpEndpoint;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.jboss.logging.Logger;
+
+import io.vertx.ext.web.Router;
+
+@ApplicationScoped
+@Named(PlatformHttpConstants.PLATFORM_HTTP_ENGINE_NAME)
+public class QuarkusPlatformHttpEngine implements PlatformHttpEngine {
Review comment:
can't the `QuarkusPlatformHttpEngine` be created and configured by a build
step ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #201: Fix #184 Leverage platform http service
lburgazzoli commented on a change in pull request #201: Fix #184 Leverage
platform http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r327971565
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/QuarkusPlatformHttpConsumer.java
##
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.platform.http.runtime;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+import io.vertx.core.MultiMap;
+import io.vertx.core.buffer.Buffer;
+import io.vertx.core.http.HttpMethod;
+import io.vertx.core.http.HttpServerRequest;
+import io.vertx.core.http.HttpServerResponse;
+import io.vertx.ext.web.Route;
+import io.vertx.ext.web.Router;
+import io.vertx.ext.web.RoutingContext;
+
+import org.apache.camel.Consumer;
+import org.apache.camel.Endpoint;
+import org.apache.camel.Exchange;
+import org.apache.camel.Message;
+import org.apache.camel.NoTypeConversionAvailableException;
+import org.apache.camel.Processor;
+import org.apache.camel.TypeConversionException;
+import org.apache.camel.TypeConverter;
+import org.apache.camel.component.platform.http.PlatformHttpComponent;
+import org.apache.camel.component.platform.http.PlatformHttpEndpoint;
+import org.apache.camel.component.platform.http.spi.Method;
+import org.apache.camel.spi.HeaderFilterStrategy;
+import org.apache.camel.support.DefaultConsumer;
+import org.apache.camel.support.DefaultMessage;
+import org.apache.camel.support.ExchangeHelper;
+import org.apache.camel.support.MessageHelper;
+import org.apache.camel.support.ObjectHelper;
+
+/**
+ * A Quarkus specific {@link Consumer} for the {@link PlatformHttpComponent}.
+ */
+public class QuarkusPlatformHttpConsumer extends DefaultConsumer {
+private final Router router;
+private final Object routeLock = new Object();
+private Route route;
+
+public QuarkusPlatformHttpConsumer(Endpoint endpoint, Processor processor,
Router router) {
+super(endpoint, processor);
+this.router = router;
+}
+
+@Override
+public PlatformHttpEndpoint getEndpoint() {
+return (PlatformHttpEndpoint) super.getEndpoint();
+}
+
+@Override
+protected void doStart() throws Exception {
+super.doStart();
+
+synchronized (routeLock) {
+route = router.route(getEndpoint().getPath());
+final Setmethods = getEndpoint().getEffectiveMethods();
+if (!methods.equals(Method.getAll())) {
+methods.stream().forEach(m ->
route.method(HttpMethod.valueOf(m.name(;
+}
+
+route.handler(ctx -> {
+try {
+Exchange e = toExchange(ctx,
getEndpoint().createExchange(),
+getEndpoint().getHeaderFilterStrategy());
+getProcessor().process(e);
+writeResponse(ctx, e,
getEndpoint().getHeaderFilterStrategy());
+} catch (Exception e1) {
+throw new RuntimeException(e1);
+}
+});
+}
+}
+
+@Override
+protected void doStop() throws Exception {
+synchronized (routeLock) {
Review comment:
don't think the lock is needed as `doStop` is atomic
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #201: Fix #184 Leverage platform http service
lburgazzoli commented on a change in pull request #201: Fix #184 Leverage
platform http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r327971495
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/QuarkusPlatformHttpConsumer.java
##
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.platform.http.runtime;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+import io.vertx.core.MultiMap;
+import io.vertx.core.buffer.Buffer;
+import io.vertx.core.http.HttpMethod;
+import io.vertx.core.http.HttpServerRequest;
+import io.vertx.core.http.HttpServerResponse;
+import io.vertx.ext.web.Route;
+import io.vertx.ext.web.Router;
+import io.vertx.ext.web.RoutingContext;
+
+import org.apache.camel.Consumer;
+import org.apache.camel.Endpoint;
+import org.apache.camel.Exchange;
+import org.apache.camel.Message;
+import org.apache.camel.NoTypeConversionAvailableException;
+import org.apache.camel.Processor;
+import org.apache.camel.TypeConversionException;
+import org.apache.camel.TypeConverter;
+import org.apache.camel.component.platform.http.PlatformHttpComponent;
+import org.apache.camel.component.platform.http.PlatformHttpEndpoint;
+import org.apache.camel.component.platform.http.spi.Method;
+import org.apache.camel.spi.HeaderFilterStrategy;
+import org.apache.camel.support.DefaultConsumer;
+import org.apache.camel.support.DefaultMessage;
+import org.apache.camel.support.ExchangeHelper;
+import org.apache.camel.support.MessageHelper;
+import org.apache.camel.support.ObjectHelper;
+
+/**
+ * A Quarkus specific {@link Consumer} for the {@link PlatformHttpComponent}.
+ */
+public class QuarkusPlatformHttpConsumer extends DefaultConsumer {
+private final Router router;
+private final Object routeLock = new Object();
+private Route route;
+
+public QuarkusPlatformHttpConsumer(Endpoint endpoint, Processor processor,
Router router) {
+super(endpoint, processor);
+this.router = router;
+}
+
+@Override
+public PlatformHttpEndpoint getEndpoint() {
+return (PlatformHttpEndpoint) super.getEndpoint();
+}
+
+@Override
+protected void doStart() throws Exception {
+super.doStart();
+
+synchronized (routeLock) {
Review comment:
don't think the lock is needed as `doStart` is atomic
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #201: Fix #184 Leverage platform http service
lburgazzoli commented on a change in pull request #201: Fix #184 Leverage
platform http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r327970095
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/PlatformHttpRecorder.java
##
@@ -0,0 +1,24 @@
+package org.apache.camel.quarkus.component.platform.http.runtime;
+
+import org.apache.camel.component.platform.http.PlatformHttpComponent;
+import org.apache.camel.component.platform.http.PlatformHttpConstants;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.apache.camel.quarkus.core.runtime.CamelRuntime;
+import org.apache.camel.spi.Registry;
+
+import io.quarkus.arc.runtime.BeanContainer;
+import io.quarkus.runtime.RuntimeValue;
+import io.quarkus.runtime.annotations.Recorder;
+
+@Recorder
+public class PlatformHttpRecorder {
+
+public void registerBeans(RuntimeValue runtime,
BeanContainer beanContainer) {
+final Registry registry = runtime.getValue().getRegistry();
+final QuarkusPlatformHttpEngine engine =
beanContainer.instance(QuarkusPlatformHttpEngine.class);
Review comment:
Can't the `QuarkusPlatformHttpEngine` be a parameter of the recorder so that
the bean container is not involved ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #201: Fix #184 Leverage platform http service
lburgazzoli commented on a change in pull request #201: Fix #184 Leverage
platform http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r327966004
##
File path:
extensions/platform-http/component/src/main/java/org/apache/camel/component/platform/http/PlatformHttpEndpoint.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.platform.http;
+
+import java.util.Collections;
+import java.util.Set;
+import java.util.TreeSet;
+
+import org.apache.camel.AsyncEndpoint;
+import org.apache.camel.Component;
+import org.apache.camel.Consumer;
+import org.apache.camel.Processor;
+import org.apache.camel.Producer;
+import org.apache.camel.component.platform.http.spi.Method;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.apache.camel.spi.HeaderFilterStrategy;
+import org.apache.camel.spi.HeaderFilterStrategyAware;
+import org.apache.camel.spi.UriEndpoint;
+import org.apache.camel.spi.UriParam;
+import org.apache.camel.support.DefaultEndpoint;
+
+@UriEndpoint(/* firstVersion = "3.?.0", */ scheme = "platform-http", title =
"Platform HTTP", syntax = "platform-http:[methods:]path", label = "http")
+public class PlatformHttpEndpoint extends DefaultEndpoint implements
AsyncEndpoint, HeaderFilterStrategyAware {
+
+private final String path;
+private final Set methods;
+
+@UriParam(label = "consumer", description = "A comma separated list of
HTTP methods to serve. This list will be merged with the methods specified in
the URI path. E.g. platform-http:GET,POST:/path?httpMethodRestrict=PUT,DELETE
will effectivelly result in GET,POST,PUT,DELETE. If no methods are specified,
all methods will be served.")
+private String httpMethodRestrict;
Review comment:
why not use `httpMethodRestrict` only as the other `http` components in
camel ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] astefanutti opened a new pull request #954: Jolokia and Prometheus traits fixes
astefanutti opened a new pull request #954: Jolokia and Prometheus traits fixes URL: https://github.com/apache/camel-k/pull/954 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] lburgazzoli merged pull request #953: fix(build): Go 1.13 compatibility
lburgazzoli merged pull request #953: fix(build): Go 1.13 compatibility URL: https://github.com/apache/camel-k/pull/953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti opened a new pull request #953: fix(build): Go 1.13 compatibility
astefanutti opened a new pull request #953: fix(build): Go 1.13 compatibility URL: https://github.com/apache/camel-k/pull/953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new issue #952: Upgrade to Knative 0.9
nicolaferraro opened a new issue #952: Upgrade to Knative 0.9 URL: https://github.com/apache/camel-k/issues/952 Leaving compatibility with 0.8. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro commented on issue #888: Camel K should use duck types to recognize Knative sinks
nicolaferraro commented on issue #888: Camel K should use duck types to recognize Knative sinks URL: https://github.com/apache/camel-k/issues/888#issuecomment-534550335 This is an issue with knative 0.8+ releases where e.g. channels have been moved from eventing.knative.dev to messaging.knative.dev This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] asifdxtreme commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
asifdxtreme commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r327515627
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
Thanks @astefanutti , I will look into this
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] astefanutti commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
astefanutti commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r327513592
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
It seems possible to check whether an option has been explicitly provided
with `flag.Flag.Changed`, e.g.:
```
func (o *installCmdOptions) install(cmd *cobra.Command, _ []string) error {
flag := cmd.Flags().Lookup("kaniko-cache")
if flag.Changed {
// ...
```
Ideally, we would need spf13/pflag#214, e.g. for knative/client#346, but
that's another issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] astefanutti commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
astefanutti commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r327479834
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
Sorry for the delay, I'm looking at it right now and I'll get back to you on
this today.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] asifdxtreme commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
asifdxtreme commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r327479299
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
Hi @astefanutti ,
Since we are not able to get any alternative solution for this, so can we go
ahead to merge this patch?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] nicolaferraro merged pull request #950: Resources GC improvements
nicolaferraro merged pull request #950: Resources GC improvements URL: https://github.com/apache/camel-k/pull/950 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro merged pull request #949: Upgrade Operator SDK to version 0.10.0
nicolaferraro merged pull request #949: Upgrade Operator SDK to version 0.10.0 URL: https://github.com/apache/camel-k/pull/949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro merged pull request #948: fix(builder): Clean ReplaceHost step leftover that causes nil pointer dereference panic
nicolaferraro merged pull request #948: fix(builder): Clean ReplaceHost step leftover that causes nil pointer dereference panic URL: https://github.com/apache/camel-k/pull/948 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro merged pull request #943: Add ability to execute tasks in Tekton pipeline
nicolaferraro merged pull request #943: Add ability to execute tasks in Tekton pipeline URL: https://github.com/apache/camel-k/pull/943 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro closed issue #942: Allow to run integrations in Tekton pipelines
nicolaferraro closed issue #942: Allow to run integrations in Tekton pipelines URL: https://github.com/apache/camel-k/issues/942 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti opened a new issue #951: Add documentation for integration platform configuration
astefanutti opened a new issue #951: Add documentation for integration platform configuration URL: https://github.com/apache/camel-k/issues/951 Integration platform CR is part of Camel K public API and as such should be documented. I've seen a number of people asking for how to configure repositories, Camel version, ... Documentation of the platform CR should address their needs. In addition, schema validation should be added to the CR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti commented on issue #939: Add Kamel CLI download link in OpenShift Web console
astefanutti commented on issue #939: Add Kamel CLI download link in OpenShift Web console URL: https://github.com/apache/camel-k/issues/939#issuecomment-534175254 There may not be any official documentation yet, though the CRD is explicit enough: openshift/console#1441. It is part of OpenShift 4.2 so the presence of the CRD must be checked. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti commented on issue #832: GC trait fails on some installations
astefanutti commented on issue #832: GC trait fails on some installations URL: https://github.com/apache/camel-k/issues/832#issuecomment-534086991 This should effectively be fixed with #950. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti opened a new pull request #950: Resources GC improvements
astefanutti opened a new pull request #950: Resources GC improvements URL: https://github.com/apache/camel-k/pull/950 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] WillemJiang commented on issue #138: #137 Add the error log when setting component property failed
WillemJiang commented on issue #138: #137 Add the error log when setting component property failed URL: https://github.com/apache/camel-k-runtime/pull/138#issuecomment-534047838 @lburgazzoli please review the new updated the code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti opened a new pull request #949: Upgrade Operator SDK to version 0.10.0
astefanutti opened a new pull request #949: Upgrade Operator SDK to version 0.10.0 URL: https://github.com/apache/camel-k/pull/949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti opened a new pull request #948: fix(builder): Clean ReplaceHost step leftover that causes nil pointer dereference panic
astefanutti opened a new pull request #948: fix(builder): Clean ReplaceHost step leftover that causes nil pointer dereference panic URL: https://github.com/apache/camel-k/pull/948 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] WillemJiang commented on a change in pull request #138: #137 Add the error log when setting component property failed
WillemJiang commented on a change in pull request #138: #137 Add the error log
when setting component property failed
URL: https://github.com/apache/camel-k-runtime/pull/138#discussion_r327010027
##
File path:
camel-k-loader-groovy/src/main/groovy/org/apache/camel/k/loader/groovy/dsl/ComponentConfiguration.groovy
##
@@ -49,13 +52,15 @@ class ComponentConfiguration {
}
if
(!PropertyBindingSupport.build().withCamelContext(component.camelContext).withTarget(component).withProperty(name,
value).bind()) {
+LOG.error("Cannot set the component {} property {}",
component.class.getName(), name)
Review comment:
Just removed the log.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k-runtime] WillemJiang commented on a change in pull request #138: #137 Add the error log when setting component property failed
WillemJiang commented on a change in pull request #138: #137 Add the error log
when setting component property failed
URL: https://github.com/apache/camel-k-runtime/pull/138#discussion_r327007650
##
File path:
camel-k-loader-groovy/src/main/groovy/org/apache/camel/k/loader/groovy/dsl/ComponentsConfiguration.groovy
##
@@ -48,10 +49,10 @@ class ComponentsConfiguration {
}
if (type.isAssignableFrom(component.class)) {
-callable.resolveStrategy = Closure.DELEGATE_FIRST
+// Just make sure the closure context is belong to component
+callable.resolveStrategy = Closure.DELEGATE_ONLY
Review comment:
I tried to throw the PropertyBindingException from the propertyMissing
method, I cannot get the exception when set the Closure.DELEGATE_FIRST. Could
you try to run code yourself?
It looks like Closure.DELEGATE_FIRST just eat up all the exception which is
thrown from ComponentsConfiguration.propertyMissing method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli commented on a change in pull request #138: #137 Add the error log when setting component property failed
lburgazzoli commented on a change in pull request #138: #137 Add the error log
when setting component property failed
URL: https://github.com/apache/camel-k-runtime/pull/138#discussion_r326984946
##
File path:
camel-k-loader-groovy/src/main/groovy/org/apache/camel/k/loader/groovy/dsl/ComponentsConfiguration.groovy
##
@@ -48,10 +49,10 @@ class ComponentsConfiguration {
}
if (type.isAssignableFrom(component.class)) {
-callable.resolveStrategy = Closure.DELEGATE_FIRST
+// Just make sure the closure context is belong to component
+callable.resolveStrategy = Closure.DELEGATE_ONLY
Review comment:
PropertyBindingException is propagated
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k-runtime] WillemJiang commented on a change in pull request #138: #137 Add the error log when setting component property failed
WillemJiang commented on a change in pull request #138: #137 Add the error log
when setting component property failed
URL: https://github.com/apache/camel-k-runtime/pull/138#discussion_r326982408
##
File path:
camel-k-loader-groovy/src/main/groovy/org/apache/camel/k/loader/groovy/dsl/ComponentConfiguration.groovy
##
@@ -49,13 +52,15 @@ class ComponentConfiguration {
}
if
(!PropertyBindingSupport.build().withCamelContext(component.camelContext).withTarget(component).withProperty(name,
value).bind()) {
+LOG.error("Cannot set the component {} property {}",
component.class.getName(), name)
Review comment:
I will remove the log things in my next commit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k-runtime] WillemJiang commented on a change in pull request #138: #137 Add the error log when setting component property failed
WillemJiang commented on a change in pull request #138: #137 Add the error log
when setting component property failed
URL: https://github.com/apache/camel-k-runtime/pull/138#discussion_r326982183
##
File path:
camel-k-loader-groovy/src/main/groovy/org/apache/camel/k/loader/groovy/dsl/ComponentsConfiguration.groovy
##
@@ -48,10 +49,10 @@ class ComponentsConfiguration {
}
if (type.isAssignableFrom(component.class)) {
-callable.resolveStrategy = Closure.DELEGATE_FIRST
+// Just make sure the closure context is belong to component
+callable.resolveStrategy = Closure.DELEGATE_ONLY
Review comment:
If I set the Closure.DELEGATE_FIRST, I cannot throw the exception from
propertyMissing method of ComponentsConfiguration.groovy. Is there any other
way to address this issue?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli commented on a change in pull request #138: #137 Add the error log when setting component property failed
lburgazzoli commented on a change in pull request #138: #137 Add the error log
when setting component property failed
URL: https://github.com/apache/camel-k-runtime/pull/138#discussion_r326972616
##
File path:
camel-k-loader-groovy/src/main/groovy/org/apache/camel/k/loader/groovy/dsl/ComponentsConfiguration.groovy
##
@@ -48,10 +49,10 @@ class ComponentsConfiguration {
}
if (type.isAssignableFrom(component.class)) {
-callable.resolveStrategy = Closure.DELEGATE_FIRST
+// Just make sure the closure context is belong to component
+callable.resolveStrategy = Closure.DELEGATE_ONLY
Review comment:
`Closure.DELEGATE_FIRST` was done on purpose to be able to reuse methods on
the `Component` class (although there's no method right now)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli commented on a change in pull request #138: #137 Add the error log when setting component property failed
lburgazzoli commented on a change in pull request #138: #137 Add the error log
when setting component property failed
URL: https://github.com/apache/camel-k-runtime/pull/138#discussion_r326972269
##
File path:
camel-k-loader-groovy/src/main/groovy/org/apache/camel/k/loader/groovy/dsl/ComponentConfiguration.groovy
##
@@ -49,13 +52,15 @@ class ComponentConfiguration {
}
if
(!PropertyBindingSupport.build().withCamelContext(component.camelContext).withTarget(component).withProperty(name,
value).bind()) {
+LOG.error("Cannot set the component {} property {}",
component.class.getName(), name)
Review comment:
think we do not need to log things if we thrown an exception
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #203: Release 0.2.0
oscerd commented on issue #203: Release 0.2.0 URL: https://github.com/apache/camel-quarkus/issues/203#issuecomment-533983969 Release 0.2.0 is now on vote. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd merged pull request #208: Disable deployment of synthetic test poms for now see #207
oscerd merged pull request #208: Disable deployment of synthetic test poms for now see #207 URL: https://github.com/apache/camel-quarkus/pull/208 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #208: Disable deployment of synthetic test poms for now see #207
asf-ci commented on issue #208: Disable deployment of synthetic test poms for now see #207 URL: https://github.com/apache/camel-quarkus/pull/208#issuecomment-533917237 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/170/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga opened a new pull request #208: Disable deployment of synthetic test poms for now see #207
ppalaga opened a new pull request #208: Disable deployment of synthetic test poms for now see #207 URL: https://github.com/apache/camel-quarkus/pull/208 @oscerd removing the deployment of the synthetic test poms according to your proposal. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga opened a new issue #207: The synthetic test poms are missing signatures
ppalaga opened a new issue #207: The synthetic test poms are missing signatures URL: https://github.com/apache/camel-quarkus/issues/207 ... and therefore closing the staging repository fails with messages listed in https://github.com/apache/camel-quarkus/issues/203#issuecomment-533786828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #203: Release 0.2.0
oscerd commented on issue #203: Release 0.2.0 URL: https://github.com/apache/camel-quarkus/issues/203#issuecomment-533868496 Actually the integration test poms are a complete mess, my proposal is to leave them out of the release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] lmorandini opened a new issue #947: Permission error on a OpenStack/Cinder persistent volume while creating a temporary dir
lmorandini opened a new issue #947: Permission error on a OpenStack/Cinder
persistent volume while creating a temporary dir
URL: https://github.com/apache/camel-k/issues/947
While adding my first integration (examples/Sample.java) the builder
objected, stating:
> kubectl logs camel-k-kit-bm3c5ovisftb3f6lsq80-builder
{"level":"info","ts":1569112916.446735,"logger":"camel-k.builder","msg":"Go
Version: go1.12.7"}
{"level":"info","ts":1569112916.4468539,"logger":"camel-k.builder","msg":"Go
OS/Arch: linux/amd64"}
{"level":"info","ts":1569112916.4468768,"logger":"camel-k.builder","msg":"Camel
K Version: 1.0.0-M2-SNAPSHOT"}
{"level":"error","ts":1569112916.595498,"logger":"camel-k","msg":"Unexpected
error while creating a temporary dir","error":"mkdir
/workspace/builder-933634098: permission
denied","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/home/lmorandini/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128\ngithub.com/apache/camel-k/pkg/util/log.Logger.Error\n\t/home/lmorandini/git/camel-k/pkg/util/log/log.go:75\ngithub.com/apache/camel-k/pkg/util/log.Error\n\t/home/lmorandini/git/camel-k/pkg/util/log/log.go:196\ngithub.com/apache/camel-k/pkg/builder.(*defaultBuilder).Build\n\t/home/lmorandini/git/camel-k/pkg/builder/builder.go:66\nmain.main\n\t/home/lmorandini/git/camel-k/cmd/builder/main.go:80\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:200"}
I started a K8s cluster on OpenStack, with a Cinder volume attached as
ReadWriteOnce (with a StorageClass set to default for Camel-K to pick it up).
More in detail, the PV definitioln is:
apiVersion: "v1"
kind: "PersistentVolume"
metadata:
name: "cinder-test"
spec:
capacity:
storage: "30Gi"
storageClassName: standard
accessModes:
- "ReadWriteOnce"
cinder:
fsType: "ext4"
volumeID: ${VOLUMEID}
...while the Storage Class definition is:
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: standard
annotations:
storageclass.kubernetes.io/is-default-class: "true"
provisioner: kubernetes.io/cinder
The Persistent Volume Claim that Camel-K (successfully) created during
installation is:
> kubectl describe pvc camel-k
Name: camel-k
Namespace: default
StorageClass: standard
Status:Bound
Volume:cinder-test
Labels:app=camel-k
Annotations: pv.kubernetes.io/bind-completed: yes
pv.kubernetes.io/bound-by-controller: yes
Finalizers:[kubernetes.io/pvc-protection]
Capacity: 30Gi
Access Modes: RWO
Mounted By:
Events:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #203: Release 0.2.0
oscerd commented on issue #203: Release 0.2.0 URL: https://github.com/apache/camel-quarkus/issues/203#issuecomment-533786844 I'm dropping the release and go back to 0.2.0-SNAPSHOT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #203: Release 0.2.0
oscerd commented on issue #203: Release 0.2.0 URL: https://github.com/apache/camel-quarkus/issues/203#issuecomment-533786828 It's not enough. The signature of the integration tests seems to be invalid. typeId | signature-staging -- | -- failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-jdbc-tests/0.2.0/camel-quarkus-integration-test-jdbc-tests-0.2.0.pom.asc' does not exist for 'camel-quarkus-integration-test-jdbc-tests-0.2.0.pom'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-jdbc-tests/0.2.0/camel-quarkus-integration-test-jdbc-tests-0.2.0.jar.asc' does not exist for 'camel-quarkus-integration-test-jdbc-tests-0.2.0.jar'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-paho-tests/0.2.0/camel-quarkus-integration-test-paho-tests-0.2.0.pom.asc' does not exist for 'camel-quarkus-integration-test-paho-tests-0.2.0.pom'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-paho-tests/0.2.0/camel-quarkus-integration-test-paho-tests-0.2.0.jar.asc' does not exist for 'camel-quarkus-integration-test-paho-tests-0.2.0.jar'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-core-cdi-tests/0.2.0/camel-quarkus-integration-test-core-cdi-tests-0.2.0.pom.asc' does not exist for 'camel-quarkus-integration-test-core-cdi-tests-0.2.0.pom'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-core-cdi-tests/0.2.0/camel-quarkus-integration-test-core-cdi-tests-0.2.0.jar.asc' does not exist for 'camel-quarkus-integration-test-core-cdi-tests-0.2.0.jar'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-infinispan-tests/0.2.0/camel-quarkus-integration-test-infinispan-tests-0.2.0.jar.asc' does not exist for 'camel-quarkus-integration-test-infinispan-tests-0.2.0.jar'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-infinispan-tests/0.2.0/camel-quarkus-integration-test-infinispan-tests-0.2.0.pom.asc' does not exist for 'camel-quarkus-integration-test-infinispan-tests-0.2.0.pom'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-netty-http-tests/0.2.0/camel-quarkus-integration-test-netty-http-tests-0.2.0.pom.asc' does not exist for 'camel-quarkus-integration-test-netty-http-tests-0.2.0.pom'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-netty-http-tests/0.2.0/camel-quarkus-integration-test-netty-http-tests-0.2.0.jar.asc' does not exist for 'camel-quarkus-integration-test-netty-http-tests-0.2.0.jar'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-csv-tests/0.2.0/camel-quarkus-integration-test-csv-tests-0.2.0.pom.asc' does not exist for 'camel-quarkus-integration-test-csv-tests-0.2.0.pom'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-csv-tests/0.2.0/camel-quarkus-integration-test-csv-tests-0.2.0.jar.asc' does not exist for 'camel-quarkus-integration-test-csv-tests-0.2.0.jar'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-zipfile-tests/0.2.0/camel-quarkus-integration-test-zipfile-tests-0.2.0.pom.asc' does not exist for 'camel-quarkus-integration-test-zipfile-tests-0.2.0.pom'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-zipfile-tests/0.2.0/camel-quarkus-integration-test-zipfile-tests-0.2.0.jar.asc' does not exist for 'camel-quarkus-integration-test-zipfile-tests-0.2.0.jar'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-microprofile-metrics-tests/0.2.0/camel-quarkus-integration-test-microprofile-metrics-tests-0.2.0.pom.asc' does not exist for 'camel-quarkus-integration-test-microprofile-metrics-tests-0.2.0.pom'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-microprofile-metrics-tests/0.2.0/camel-quarkus-integration-test-microprofile-metrics-tests-0.2.0.jar.asc' does not exist for 'camel-quarkus-integration-test-microprofile-metrics-tests-0.2.0.jar'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-core-tests/0.2.0/camel-quarkus-integration-test-core-tests-0.2.0.pom.asc' does not exist for 'camel-quarkus-integration-test-core-tests-0.2.0.pom'. failureMessage | Missing Signature: '/org/apache/camel/quarkus/camel-quarkus-integration-test-core-tests/0.2.0/camel-quarkus-integration-test-core-tests-0.2.0.jar.asc' does not exist for 'camel-quarkus-integration-test-core-tests-0.2.0.jar'. failureMessage | Missing Signature:
[GitHub] [camel-quarkus] oscerd commented on issue #206: Improve the maven deployment of the synthetic test jars
oscerd commented on issue #206: Improve the maven deployment of the synthetic test jars URL: https://github.com/apache/camel-quarkus/pull/206#issuecomment-533594536 I release on monday This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd merged pull request #206: Improve the maven deployment of the synthetic test jars
oscerd merged pull request #206: Improve the maven deployment of the synthetic test jars URL: https://github.com/apache/camel-quarkus/pull/206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #206: Improve the maven deployment of the synthetic test jars
asf-ci commented on issue #206: Improve the maven deployment of the synthetic test jars URL: https://github.com/apache/camel-quarkus/pull/206#issuecomment-533593540 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/169/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] bfitzpat opened a new issue #946: Starting a new integration in --dev mode and then starting it again without --dev mode leaves hanging process
bfitzpat opened a new issue #946: Starting a new integration in --dev mode and then starting it again without --dev mode leaves hanging process URL: https://github.com/apache/camel-k/issues/946 We have noticed while working on the tooling that if you deploy the same integration twice: * kamel run helloworld.groovy --dev * kamel run helloworld.groovy Though you end up with a single integration running in the system, the initial --dev process is still running in the background. `bfitzpat 24796 13849 0 07:49 pts/200:00:00 kamel run helloworld.groovy --dev` Should the second deployment actually kill the first? Or at least possibly pop up a warning message or ask if they want to kill it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga opened a new pull request #206: Improve the maven deployment of the synthetic test jars
ppalaga opened a new pull request #206: Improve the maven deployment of the synthetic test jars URL: https://github.com/apache/camel-quarkus/pull/206 @oscerd yet another attempt to fix the release 0.2.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] asifdxtreme commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
asifdxtreme commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r326565411
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
seems like only way possible is to keep another flag to track from where the
installation has been initiated, but this seems too much of flags for such a
small feature.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] mayurbm commented on issue #736: camel-k-cache crashes on minikube
mayurbm commented on issue #736: camel-k-cache crashes on minikube URL: https://github.com/apache/camel-k/issues/736#issuecomment-533482575 fix: Use restart policy OnFailure for Kaniko cache warmer doesn't solve the problem in minikube. I still get CrashLoopBackOff camel-k-cache 0/1 CrashLoopBackOff 8 20m in pod log I can see: vagrant@ubukube:~/camel/camel-k/build/maven$ kubectl logs camel-k-cache panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0xf13712] goroutine 1 [running]: github.com/GoogleContainerTools/kaniko/pkg/cache.WarmCache(0x1977fe0, 0xf25480, 0xc420331cd8) /go/src/github.com/GoogleContainerTools/kaniko/pkg/cache/warm.go:47 +0x372 github.com/GoogleContainerTools/kaniko/cmd/warmer/cmd.glob..func2(0x196f140, 0xc4203ca240, 0x0, 0x2) /go/src/github.com/GoogleContainerTools/kaniko/cmd/warmer/cmd/root.go:54 +0x2d github.com/GoogleContainerTools/kaniko/vendor/github.com/spf13/cobra.(*Command).execute(0x196f140, 0xc4200380a0, 0x2, 0x2, 0x196f140, 0xc4200380a0) /go/src/github.com/GoogleContainerTools/kaniko/vendor/github.com/spf13/cobra/command.go:766 +0x2c1 github.com/GoogleContainerTools/kaniko/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x196f140, 0x0, 0x4, 0x116cca9) /go/src/github.com/GoogleContainerTools/kaniko/vendor/github.com/spf13/cobra/command.go:852 +0x30a github.com/GoogleContainerTools/kaniko/vendor/github.com/spf13/cobra.(*Command).Execute(0x196f140, 0xc420331f78, 0xc42008a058) /go/src/github.com/GoogleContainerTools/kaniko/vendor/github.com/spf13/cobra/command.go:800 +0x2b main.main() /go/src/github.com/GoogleContainerTools/kaniko/cmd/warmer/main.go:26 +0x2d This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro commented on issue #941: kamel get still has a column for 'Context'
nicolaferraro commented on issue #941: kamel get still has a column for 'Context' URL: https://github.com/apache/camel-k/issues/941#issuecomment-533477477 Thanks for noticing. This should be fixed for next M2 release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new issue #945: Merge all binaries into a single one
nicolaferraro opened a new issue #945: Merge all binaries into a single one URL: https://github.com/apache/camel-k/issues/945 We currently generate `kamel`, `builder` and `operator` that amount to ~50MB each, and they are all added to the container image. We should unify them into a single one (`kamel`) and have other commands run as child (`kamel operator`, `kamel builder`). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] oscerd commented on issue #944: Release Camel K 1.0.0-M2
oscerd commented on issue #944: Release Camel K 1.0.0-M2 URL: https://github.com/apache/camel-k/issues/944#issuecomment-533468070 We still have some pending PRs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new issue #944: Release Camel K 1.0.0-M2
nicolaferraro opened a new issue #944: Release Camel K 1.0.0-M2 URL: https://github.com/apache/camel-k/issues/944 Time for a M2 release. Let's plan it for next Thrusday. I'm going to create a milestone so we can track issues that we want to be included. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new pull request #943: Add ability to execute tasks in Tekton pipeline
nicolaferraro opened a new pull request #943: Add ability to execute tasks in Tekton pipeline URL: https://github.com/apache/camel-k/pull/943 Fix #942 This basically adds: - The kamel binary into the Camel K image (and enables it to run in that context) - A tutorial about Camel K and Tekton that will show up in a new "Tutorials" section in the website cc: @christophd This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro commented on issue #939: Add Kamel CLI download link in OpenShift Web console
nicolaferraro commented on issue #939: Add Kamel CLI download link in OpenShift Web console URL: https://github.com/apache/camel-k/issues/939#issuecomment-533449404 Nice, where did you find doc about it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #203: Release 0.2.0
ppalaga commented on issue #203: Release 0.2.0 URL: https://github.com/apache/camel-quarkus/issues/203#issuecomment-533438555 I was able to reproduce using local file:// URLs for distribution management and scm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #203: Release 0.2.0
ppalaga commented on issue #203: Release 0.2.0 URL: https://github.com/apache/camel-quarkus/issues/203#issuecomment-533163772 Strange. I think I need to reproduce this deploying to a local filesystem repo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #204: Set the missing deploy plugin properties for the reusable-test-jar ex…
oscerd commented on issue #204: Set the missing deploy plugin properties for the reusable-test-jar ex… URL: https://github.com/apache/camel-quarkus/pull/204#issuecomment-533137798 It doesn't work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #203: Release 0.2.0
oscerd commented on issue #203: Release 0.2.0 URL: https://github.com/apache/camel-quarkus/issues/203#issuecomment-533135148 It fails anyway [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M1:deploy-file (deploy-reusable-test-jar) on project camel-quarkus-integration-test-core-parent: The parameters 'url' for goal org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M1:deploy-file are missing or invalid -> [Help 1] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #205: Auto configuration of metrics management strategies
asf-ci commented on issue #205: Auto configuration of metrics management strategies URL: https://github.com/apache/camel-quarkus/pull/205#issuecomment-533132759 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/168/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #205: Auto configuration of metrics management strategies
jamesnetherton opened a new pull request #205: Auto configuration of metrics management strategies URL: https://github.com/apache/camel-quarkus/pull/205 fixes #195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd merged pull request #204: Set the missing deploy plugin properties for the reusable-test-jar ex…
oscerd merged pull request #204: Set the missing deploy plugin properties for the reusable-test-jar ex… URL: https://github.com/apache/camel-quarkus/pull/204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #204: Set the missing deploy plugin properties for the reusable-test-jar ex…
asf-ci commented on issue #204: Set the missing deploy plugin properties for the reusable-test-jar ex… URL: https://github.com/apache/camel-quarkus/pull/204#issuecomment-533070907 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/167/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #204: Set the missing deploy plugin properties for the reusable-test-jar ex…
oscerd commented on issue #204: Set the missing deploy plugin properties for the reusable-test-jar ex… URL: https://github.com/apache/camel-quarkus/pull/204#issuecomment-533048956 I'll try a new release today, once we merged this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga opened a new pull request #204: Set the missing deploy plugin properties for the reusable-test-jar ex…
ppalaga opened a new pull request #204: Set the missing deploy plugin properties for the reusable-test-jar ex… URL: https://github.com/apache/camel-quarkus/pull/204 …ecution @oscerd this should fix the issues you reported in https://github.com/apache/camel-quarkus/issues/203?email_source=notifications_token=AAN53SLWK5OD4X3NWI5Z6WTQKHMCRA5CNFSM4IXRDYSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67EMLQ#issuecomment-532563502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro commented on issue #940: Making kamel CLI 90% faster on remote clusters
nicolaferraro commented on issue #940: Making kamel CLI 90% faster on remote clusters URL: https://github.com/apache/camel-k/pull/940#issuecomment-532871566 > Very useful when doing demos at conferences with bad wifi and clusters thousand kilometers away . You can call it "Conference Driven Development" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti closed issue #792: CLI too slow on remote clusters
astefanutti closed issue #792: CLI too slow on remote clusters URL: https://github.com/apache/camel-k/issues/792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti commented on issue #940: Making kamel CLI 90% faster on remote clusters
astefanutti commented on issue #940: Making kamel CLI 90% faster on remote clusters URL: https://github.com/apache/camel-k/pull/940#issuecomment-532816526 Very useful when doing demos at conferences with bad wifi and clusters thousand kilometers away . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti merged pull request #940: Making kamel CLI 90% faster on remote clusters
astefanutti merged pull request #940: Making kamel CLI 90% faster on remote clusters URL: https://github.com/apache/camel-k/pull/940 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] bfitzpat commented on issue #938: Kamel cli should send exit code when integration in --dev mode is deleted
bfitzpat commented on issue #938: Kamel cli should send exit code when integration in --dev mode is deleted URL: https://github.com/apache/camel-k/issues/938#issuecomment-532797549 I eventually found a way round it. It turned out that the node.js child process "exec" call was creating a process and a sub process every time I invoked a --dev integration, so I could kill one process but the subprocess was just hanging around like the undead. I've moved to using the child process "spawn" call and now it behaves better. I can kill the process and it's truly dead. Would still like to get some kind of relationship between the "delete" call in the cli and a running --dev mode integration so they know about one another. But at least in the tooling I have a way to simulate that good old "ctrl+c" in the console and it works. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] utherp0 opened a new issue #941: kamel get still has a column for 'Context'
utherp0 opened a new issue #941: kamel get still has a column for 'Context' URL: https://github.com/apache/camel-k/issues/941 I might be confused but having read the renaming discussion and seen that the context command from Kamel has gone, it seems odd that 'kamel get' does this: kamel get NAME PHASE CONTEXT sample Running This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] WillemJiang commented on issue #138: #137 Add the error log when setting component property failed
WillemJiang commented on issue #138: #137 Add the error log when setting component property failed URL: https://github.com/apache/camel-k-runtime/pull/138#issuecomment-532718712 @lburgazzoli Could you take a look at my recent change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new pull request #940: Making kamel CLI 90% faster on remote clusters
nicolaferraro opened a new pull request #940: Making kamel CLI 90% faster on remote clusters URL: https://github.com/apache/camel-k/pull/940 Fix #792 Latest released version: ``` [nferraro@localhost camel-k]$ time kamel-1.0.0-M1 run examples/routes.groovy integration "routes" created real0m16.353s user0m0.794s sys 0m0.068s ``` With this change: ``` [nferraro@localhost camel-k]$ time kamel run examples/routes.groovy integration "routes" created real0m1.898s user0m0.508s sys 0m0.036s ``` I.e. from **16 seconds** to just ~ **2 seconds**. This is fast because it does not initialize all kubernetes custom resources available in the cluster (~50 on a standard OpenShift installation) but focuses on the 5 resource groups that our CLI needs. Only drawback is that we should remember to sync the set of allowed API groups (you get a unknown-resource error in case you use a new group from the CLI client). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #203: Release 0.2.0
ppalaga commented on issue #203: Release 0.2.0 URL: https://github.com/apache/camel-quarkus/issues/203#issuecomment-532569772 Thanks for the heads up, I can have a look tomorrow (on PTO today). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #203: Release 0.2.0
oscerd commented on issue #203: Release 0.2.0 URL: https://github.com/apache/camel-quarkus/issues/203#issuecomment-532565363 @ppalaga FYI. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #203: Release 0.2.0
oscerd commented on issue #203: Release 0.2.0 URL: https://github.com/apache/camel-quarkus/issues/203#issuecomment-532563502 Release process was failing for failIfNoTests missing for surefire and now [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M1:deploy-file (deploy-reusable-test-jar) on project camel-quarkus-integration-test-core-parent: The parameters 'url' for goal org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M1:deploy-file are missing or invalid -> [Help 1] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti merged pull request #935: fix(knative): Use channel hostname to filter Knative history header
astefanutti merged pull request #935: fix(knative): Use channel hostname to filter Knative history header URL: https://github.com/apache/camel-k/pull/935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti opened a new issue #939: Add Kamel CLI download link in OpenShift Web console
astefanutti opened a new issue #939: Add Kamel CLI download link in OpenShift Web console URL: https://github.com/apache/camel-k/issues/939 The OpenShift Web console exposes a CRD to add custom download links for CLI tools like Knative and Tekton CLIs. It'd be cool to add a link for users to be able to download the `kamel` CLI as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #201: Fix #184 Leverage platform http service
asf-ci commented on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-532423201 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/166/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #201: Fix #184 Leverage platform http service
asf-ci commented on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-532385683 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/165/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #201: Fix #184 Leverage platform http service
asf-ci commented on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-532380723 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/164/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga edited a comment on issue #201: Fix #184 Leverage platform http service
ppalaga edited a comment on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-532355074 0ba21139b7346779bb91db8ee0f3feace70b59d7 removes a couple of `System.out.println()` leftovers. I actually wanted to check whether throwing a RuntimeException here is the best what can be done: https://github.com/apache/camel-quarkus/pull/201/files#diff-8012f112cafc5e8d5658a2bbf6812475R95 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #201: Fix #184 Leverage platform http service
asf-ci commented on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-532321253 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/163/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #201: Fix #184 Leverage platform http service
ppalaga commented on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-532290135 f99d4f6 solves the native image test problems. @lburgazzoli are there still some open questions from your PoV? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga opened a new issue #203: Release 0.2.0
ppalaga opened a new issue #203: Release 0.2.0 URL: https://github.com/apache/camel-quarkus/issues/203 We have a couple of new components to show. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
