Re: trunk build broken (Was: how to list all sitemap components)
Antonio Gallardo wrote: > > Sounds like, I need to improve my english. If for you my english is like > an "old Chinese proverb" (You need to think a lot to understand what is > behind the words). ;-) lol. No, it was my fault - reading too quickly and jumping to conclusions. --David
Re: trunk build broken (Was: how to list all sitemap components)
On Mie, 12 de Enero de 2005, 23:00, David Crossley dijo: > David Crossley wrote: >> Antonio Gallardo wrote: >> [snip] >> > I did some System.out of the process (included in the commit). Made a >> > workaround "hack" and I will commit. The hack works. :-D >> >> No difference for me. Doing 'build clean, build' still fails. > > Your fix works for me today (sorry, must have been my mistake). :-D > > [snip] >> > If the "hack" is OK, please copy paste back to 2.1. I am too tired to >> do >> > that now. ;-) > > Okay, i am doing that now. I see the commits, thanks for your time. > >> > A posible solution is try to generate core + blocks docs in 1 run. >> That >> > way "the current hack" can be gone. >> > >> > Currently, seems like we need 2 runs. I am not sure why we need 2 runs >> at >> > all. > > Ah, now i understand what you are saying. The docs-build.xml > calls twice. Yeah, just historical. It didn't > ever do scanning of the blocks. I added the second call recently. Sounds like, I need to improve my english. If for you my english is like an "old Chinese proverb" (You need to think a lot to understand what is behind the words). ;-) lol. Best Regards, Antonio Gallardo.
Re: trunk build broken (Was: how to list all sitemap components)
David Crossley wrote: > Antonio Gallardo wrote: > [snip] > > I did some System.out of the process (included in the commit). Made a > > workaround "hack" and I will commit. The hack works. :-D > > No difference for me. Doing 'build clean, build' still fails. Your fix works for me today (sorry, must have been my mistake). [snip] > > If the "hack" is OK, please copy paste back to 2.1. I am too tired to do > > that now. ;-) Okay, i am doing that now. > > A posible solution is try to generate core + blocks docs in 1 run. That > > way "the current hack" can be gone. > > > > Currently, seems like we need 2 runs. I am not sure why we need 2 runs at > > all. Ah, now i understand what you are saying. The docs-build.xml calls twice. Yeah, just historical. It didn't ever do scanning of the blocks. I added the second call recently. --David
Re: trunk build broken (Was: how to list all sitemap components)
Geoff Howard wrote: > David Crossley wrote: > > Antonio Gallardo wrote: > > > Can you post where the problem is showed to you trying a full build? I am > > > trying to get an idea if the problem is truly random or just because users > > > have diferent blocks configurations in local.blocks.properties. The > > > lastest seems to be the case, but lets to be sure. > > > > I showed that a few messages ago in this thread. > > Both Ross and i are doing a full build, javadocs and all, > > with no blocks disabled. It breaks in different places > > for each of us. > > It looks like you've moved on past the need to understand this, ... No, we still need to understand what is going on. > ... but I think > you're mistaken here, no? Ross is doing a default unmodified build, which > has some blocks excluded by default. You're reporting all blocks enabled > which would require some editing of the properties. Maybe i expressed that poorly ... I have no local*.properties > I'd guess that Antonio has > a separate set of blocks chosen, so this still may explain the > different fail points, > though it seems this is now just a curiosity in the larger problem. Probably. > Unfortunately, time to crawl back into my hole. Thanks for your help. --David
Re: trunk build broken (Was: how to list all sitemap components)
On Mie, 12 de Enero de 2005, 7:01, Geoff Howard dijo: > On Wed, 12 Jan 2005 16:57:31 +1100, David Crossley <[EMAIL PROTECTED]> > wrote: >> Antonio Gallardo wrote: >> > Can you post where the problem is showed to you trying a full build? I >> am >> > trying to get an idea if the problem is truly random or just because >> users >> > have diferent blocks configurations in local.blocks.properties. The >> > lastest seems to be the case, but lets to be sure. >> >> I showed that a few messages ago in this thread. >> Both Ross and i are doing a full build, javadocs and all, >> with no blocks disabled. It breaks in different places >> for each of us. > > It looks like you've moved on past the need to understand this, but I > think > you're mistaken here, no? Ross is doing a default unmodified build, which > has some blocks excluded by default. You're reporting all blocks enabled > which would require some editing of the properties. I'd guess that > Antonio has > a separate set of blocks chosen, so this still may explain the > different fail points, > though it seems this is now just a curiosity in the larger problem. Nope. I am using a full build (no local.* at all). Sorry guys, sometimes I need to work too. ;-) I will try to fix it today at night. Best Regards, Antonio Gallardo
Re: trunk build broken (Was: how to list all sitemap components)
On Wed, 12 Jan 2005 16:57:31 +1100, David Crossley <[EMAIL PROTECTED]> wrote: > Antonio Gallardo wrote: > > Can you post where the problem is showed to you trying a full build? I am > > trying to get an idea if the problem is truly random or just because users > > have diferent blocks configurations in local.blocks.properties. The > > lastest seems to be the case, but lets to be sure. > > I showed that a few messages ago in this thread. > Both Ross and i are doing a full build, javadocs and all, > with no blocks disabled. It breaks in different places > for each of us. It looks like you've moved on past the need to understand this, but I think you're mistaken here, no? Ross is doing a default unmodified build, which has some blocks excluded by default. You're reporting all blocks enabled which would require some editing of the properties. I'd guess that Antonio has a separate set of blocks chosen, so this still may explain the different fail points, though it seems this is now just a curiosity in the larger problem. Unfortunately, time to crawl back into my hole. Thanks, Geoff
Re: trunk build broken (Was: how to list all sitemap components)
Antonio Gallardo wrote: > Hi David: > > 4:00 a.m. here! :-( > > I guess I found and fixed the source error. (Am I telling the same again? > - lol.). > > I did some System.out of the process (included in the commit). Made a > workaround "hack" and I will commit. The hack works. :-D No difference for me. Doing 'build clean, build' still fails. > I guess the trouble is made by 1 of this 2 posibilities: > > 1-While we generate blocks docs qdox has no info of the cocoon core libs. > qdox is not able to know where is o.a.c.transformation.Tranformer or > inherancy as: > > HTMLGenerator isA ServiceableGenerator isA AbstractGenerator isA Generator It is not "generating" the blocks, just scanning their sources. > 2-A qdox bug in isA()? To me it is a lesser posibility. I checked in the > qdox JIRA and nothing similar is there: > > http://jira.codehaus.org/browse/QDOX > > WDYT? I don't know what to think yet. It needs more exploration. > BTW, is not funy to wait 7 minuts to see the results of a small change and > see if this is working. :-( I know, we must fine-tune the whole build system. > If the "hack" is OK, please copy paste back to 2.1. I am too tired to do > that now. ;-) > > A posible solution is try to generate core + blocks docs in 1 run. That > way "the current hack" can be gone. > > Currently, seems like we need 2 runs. I am not sure why we need 2 runs at > all. This is still the same workaround. > Now I am getting again in RequestAttributeGenerator (from scratchpad?): > > [Fatal Error] include-transformer.xml:1:896: The entity name must > immediately follow the '&' in the entity reference. I fixed that in SVN, perhaps you need 'svn up'. > Anyway, the hack shows how this can be fixed too. :-D > > I hope this helps. It does, thanks. --David
Re: trunk build broken (Was: how to list all sitemap components)
Antonio Gallardo wrote: > Hi David: > > 4:00 a.m. here! :-( > > I guess I found and fixed the source error. (Am I telling the same again? > - lol.). :-) There you go, doing one of your super-human efforts again. Thanks, that is an excellent step forward. --David
Re: trunk build broken (Was: how to list all sitemap components)
Hi David: 4:00 a.m. here! :-( I guess I found and fixed the source error. (Am I telling the same again? - lol.). I did some System.out of the process (included in the commit). Made a workaround "hack" and I will commit. The hack works. :-D I guess the trouble is made by 1 of this 2 posibilities: 1-While we generate blocks docs qdox has no info of the cocoon core libs. qdox is not able to know where is o.a.c.transformation.Tranformer or inherancy as: HTMLGenerator isA ServiceableGenerator isA AbstractGenerator isA Generator 2-A qdox bug in isA()? To me it is a lesser posibility. I checked in the qdox JIRA and nothing similar is there: http://jira.codehaus.org/browse/QDOX WDYT? BTW, is not funy to wait 7 minuts to see the results of a small change and see if this is working. :-( If the "hack" is OK, please copy paste back to 2.1. I am too tired to do that now. ;-) A posible solution is try to generate core + blocks docs in 1 run. That way "the current hack" can be gone. Currently, seems like we need 2 runs. I am not sure why we need 2 runs at all. Now I am getting again in RequestAttributeGenerator (from scratchpad?): [Fatal Error] include-transformer.xml:1:896: The entity name must immediately follow the '&' in the entity reference. Anyway, the hack shows how this can be fixed too. :-D I hope this helps. Best Regards, Antonio Gallardo
Re: trunk build broken (Was: how to list all sitemap components)
Antonio Gallardo wrote: > > I think I got the source of the problem: some transformers has "bad" > written javadocs that don't use the agreed format. Please do an SVN update > to see if it changes in your case too. Now I am getting a diferent one > after adding a new tag in the Includetranformer: It seems that you forgot to do 'build clean' so you are getting the workaround of 'build; build'. Now you are getting on to the actual docs generation and finding new errors, i.e. not the main issue yet. > [Fatal Error] include-transformer.xml:1:896: The entity name must > immediately follow the '&' in the entity reference. I fixed that by moving the @cocoon.sitemap.component.documentation tag down a bit. Perhaps it only allows limited html content. --David > The IncludeTransformer in placed: > > src/blocks/scratchpad/java/org/apache/cocoon/transformation/IncludeTransformer.java > > Best Regards, > > Antonio Gallardo
Re: trunk build broken (Was: how to list all sitemap components)
Antonio Gallardo wrote: > > I think I got the source of the problem: some transformers has "bad" > written javadocs that don't use the agreed format. Please do an SVN update > to see if it changes in your case too. Now I am getting a diferent one > after adding a new tag in the Includetranformer: > > [Fatal Error] include-transformer.xml:1:896: The entity name must > immediately follow the '&' in the entity reference. > > The IncludeTransformer in placed: > > src/blocks/scratchpad/java/org/apache/cocoon/transformation/IncludeTransformer.java I haven't yet looked at the result of your change due to the other "trunk broken" problem. However, be aware that there are many *.java components that are missing the "sitemap" javadoc stuff, even in the core which does not exhibit this "build failed". That is the purpose of http://cocoon.apache.org/2.1/plan/review-sitemap-docs.html ... we will gradually add all of that documentation. So i don't think that you have got the source of the problem. The SitemapTask reads each *.java and *if* it has that javadoc stuff then it generates a doc, otherwise it skips. During the "build docs" there is no problem doing the core stuff. There are many missing that info in src/java/o/a/c/transformation/*.java --David
Re: trunk build broken (Was: how to list all sitemap components)
On Mie, 12 de Enero de 2005, 1:27, David Crossley dijo: > Ralph Goers wrote: >> David Crossley wrote: >> >> >I showed that a few messages ago in this thread. >> >Both Ross and i are doing a full build, javadocs and all, >> >with no blocks disabled. It breaks in different places >> >for each of us. >> > >> Does it fail for you in BRANCH_2_1_X (before you disabled it) in the >> same place it did for me? Note that the error seems to be different. > > Are you talking about the PhpGenerator.java stumble? > If so then i just rm it to get past that problem. > > After that yes, cocoon-2_1_X fails at a different place: > For me with all blocks enabled, it fails at NekoHTMLGenerator. I suspect the aparently random point of fail (the exactly file) has nothing to do with the real problem. Is posible that it happens just because the random order nature of the HashMap used as file cache. So this is notimportant here. I think I got the source of the problem: some transformers has "bad" written javadocs that don't use the agreed format. Please do an SVN update to see if it changes in your case too. Now I am getting a diferent one after adding a new tag in the Includetranformer: [Fatal Error] include-transformer.xml:1:896: The entity name must immediately follow the '&' in the entity reference. The IncludeTransformer in placed: src/blocks/scratchpad/java/org/apache/cocoon/transformation/IncludeTransformer.java Best Regards, Antonio Gallardo
Re: trunk build broken (Was: how to list all sitemap components)
Ralph Goers wrote: > David Crossley wrote: > > >I showed that a few messages ago in this thread. > >Both Ross and i are doing a full build, javadocs and all, > >with no blocks disabled. It breaks in different places > >for each of us. > > > Does it fail for you in BRANCH_2_1_X (before you disabled it) in the > same place it did for me? Note that the error seems to be different. Are you talking about the PhpGenerator.java stumble? If so then i just rm it to get past that problem. After that yes, cocoon-2_1_X fails at a different place: For me with all blocks enabled, it fails at NekoHTMLGenerator. --David
Re: trunk build broken (Was: how to list all sitemap components)
David Crossley wrote: I showed that a few messages ago in this thread. Both Ross and i are doing a full build, javadocs and all, with no blocks disabled. It breaks in different places for each of us. --David Does it fail for you in BRANCH_2_1_X (before you disabled it) in the same place it did for me? Note that the error seems to be different. Ralph
Re: trunk build broken (Was: how to list all sitemap components)
Antonio Gallardo wrote: > David Crossley dijo: > > I showed that a few messages ago in this thread. > > Both Ross and i are doing a full build, javadocs and all, > > with no blocks disabled. It breaks in different places > > for each of us. > > Then the problem is somewhere in the Ant task: > > /tools/src/anttasks/SitemapTask.java > > Is this correct? That is the file that emits the error message and that is the task that is being executed. However, i cannot say if that is where the "problem" is. --David
Re: trunk build broken (Was: how to list all sitemap components)
On Mar, 11 de Enero de 2005, 23:57, David Crossley dijo: > I showed that a few messages ago in this thread. > Both Ross and i are doing a full build, javadocs and all, > with no blocks disabled. It breaks in different places > for each of us. Then the problem is somewhere in the Ant task: /tools/src/anttasks/SitemapTask.java Is this correct? Best Regards, Antonio Gallardo
Re: trunk build broken (Was: how to list all sitemap components)
Antonio Gallardo wrote: > David Crossley dijo: > > > > It is not the cause, it just enables to bug to manifest. > > OK. > > Can you post where the problem is showed to you trying a full build? I am > trying to get an idea if the problem is truly random or just because users > have diferent blocks configurations in local.blocks.properties. The > lastest seems to be the case, but lets to be sure. I showed that a few messages ago in this thread. Both Ross and i are doing a full build, javadocs and all, with no blocks disabled. It breaks in different places for each of us. --David
Re: trunk build broken (Was: how to list all sitemap components)
Antonio Gallardo wrote: > David Crossley dijo: > > Anyway, i spent most of the day investigating. > > Did "svn update -r" and am now right back to > > r106987 2004-11-30 and it is happening there too. > > Try r124700. Seems to be OK, but as you told there is off the build option. No, that is just where the bug was unmasked. --David
Re: trunk build broken (Was: how to list all sitemap components)
On Mar, 11 de Enero de 2005, 23:35, David Crossley dijo: > It is being done as part of the documentation effort. > http://cocoon.apache.org/2.1/plan/review-sitemap-docs.html > > It is not the cause, it just enables to bug to manifest. OK. Can you post where the problem is showed to you trying a full build? I am trying to get an idea if the problem is truly random or just because users have diferent blocks configurations in local.blocks.properties. The lastest seems to be the case, but lets to be sure. Best Regards, Antonio Gallardo.
Re: trunk build broken (Was: how to list all sitemap components)
On Mar, 11 de Enero de 2005, 23:30, David Crossley dijo: > Anyway, i spent most of the day investigating. > Did "svn update -r" and am now right back to > r106987 2004-11-30 and it is happening there too. Try r124700. Seems to be OK, but as you told there is off the build option. Best Regards, Antonio Gallardo.
Re: trunk build broken (Was: how to list all sitemap components)
Antonio Gallardo wrote: > > The lastest changes of docs-build.xml (SVN 124702): > > http://marc.theaimsgroup.com/?l=xml-cocoon-cvs&m=110523951602586&w=2 > > from: > > source="${java}"/> > > to: > > source="${blocks}"/> > > see the change: from ${java} -> ${block}. > > SVN 124701 is compile with 0 Errors. But 124702 is not. I guess there is > the problem. ;-) That is just where the problem was unmasked. > I am not sure why this change was done. Can someone review this? It is being done as part of the documentation effort. http://cocoon.apache.org/2.1/plan/review-sitemap-docs.html It is not the cause, it just enables to bug to manifest. Yes please, someone help. --David
Re: trunk build broken (Was: how to list all sitemap components)
Ross Gardler wrote: > David Crossley wrote: > >Geoff Howard wrote: > > > >>odd that this is breaking in different places for everyone. Do you > >>all have different sets of blocks enabled? > > > >I have all blocks enabled. Breaks for me on RequestAttributeGenerator > Mine is an unmodified checkout of SVN head. Breaks for Ross on JXTemplateGenerator. So it doesn't depend on which blocks are enabled. I figured out why we are suddenly seeing this. It must have been happening for ages. It was unmasked recently when i switched on scanning of blocks with Qdox to generate the sitemap documentation. I cannot figure out why it worked okay for me for the last two months. Perhaps i never did a build clean, though i cannot imagine that. Mystery. Anyway, i spent most of the day investigating. Did "svn update -r" and am now right back to r106987 2004-11-30 and it is happening there too. --David
Re: trunk build broken (Was: how to list all sitemap components)
On Mar, 11 de Enero de 2005, 10:55, Geoff Howard dijo: > odd that this is breaking in different places for everyone. Do you > all have different sets of blocks enabled? Seems like have to do with diferent blocks enabled ;-) In my case (a full build): BUILD FAILED /home/agallardo/svn/cocoon-2.2/tools/targets/docs-build.xml:55: Sitemap component org.apache.cocoon.transformation.IncludeTransformer does not implement a sitemap component interface. See below >> > BUILD FAILED >> > /Users/jerm/Development/Checkouts/Apache/Cocoon/trunk/tools/targets/ >> > docs-build.xml:55: Sitemap component >> > org.apache.cocoon.generation.NekoHTMLGenerator does not implement a >> > sitemap component interface. >> >> I may be at risk of repeating things already known, but... >> >> I just did a new svn checkout and got a similar error: >> >> Building component docs from blocks. >> Collecting sitemap components info >> >> BUILD FAILED >> D:\openSource\cocoon\tools\targets\docs-build.xml:55: Sitemap component >> org.apache.cocoon.template.jxtg.JXTemplateGenerator does not implement a >> sitemap component interface. The lastest changes of docs-build.xml (SVN 124702): http://marc.theaimsgroup.com/?l=xml-cocoon-cvs&m=110523951602586&w=2 from: to: see the change: from ${java} -> ${block}. SVN 124701 is compile with 0 Errors. But 124702 is not. I guess there is the problem. ;-) I am not sure why this change was done. Can someone review this? Best Regards, Antonio Gallardo.
Re: trunk build broken (Was: how to list all sitemap components)
David Crossley wrote: Geoff Howard wrote: odd that this is breaking in different places for everyone. Do you all have different sets of blocks enabled? I have all blocks enabled. Mine is an unmodified checkout of SVN head. Ross -- No virus found in this outgoing message. Checked by AVG Anti-Virus. Version: 7.0.300 / Virus Database: 265.6.10 - Release Date: 10/01/2005
Re: trunk build broken (Was: how to list all sitemap components)
Geoff Howard wrote: > odd that this is breaking in different places for everyone. Do you > all have different sets of blocks enabled? I have all blocks enabled. > If not, I'm suspicious of out of memory error or something odd like > that. In that case, any chance that the docs build tasks could mask > some odd condition like that with such an error? Watched top, and memory seemed to be okay when it failed. This problem only started happening recently. So perhaps some other change has caused it. It also happens in the 2.1 branch. I will try rolling back to previous revisions to find the breakdown. --David > > BUILD FAILED > > D:\openSource\cocoon\tools\targets\docs-build.xml:55: Sitemap component > > org.apache.cocoon.template.jxtg.JXTemplateGenerator does not implement a > > sitemap component interface.
Re: trunk build broken (Was: how to list all sitemap components)
odd that this is breaking in different places for everyone. Do you all have different sets of blocks enabled? If not, I'm suspicious of out of memory error or something odd like that. In that case, any chance that the docs build tasks could mask some odd condition like that with such an error? Geoff On Tue, 11 Jan 2005 14:01:08 +, Ross Gardler <[EMAIL PROTECTED]> wrote: > Jeremy Quinn wrote: > > I am getting the same problem, but with : > > > > BUILD FAILED > > /Users/jerm/Development/Checkouts/Apache/Cocoon/trunk/tools/targets/ > > docs-build.xml:55: Sitemap component > > org.apache.cocoon.generation.NekoHTMLGenerator does not implement a > > sitemap component interface. > > I may be at risk of repeating things already known, but... > > I just did a new svn checkout and got a similar error: > > Building component docs from blocks. > Collecting sitemap components info > > BUILD FAILED > D:\openSource\cocoon\tools\targets\docs-build.xml:55: Sitemap component > org.apache.cocoon.template.jxtg.JXTemplateGenerator does not implement a > sitemap component interface. > > Ross > > -- > No virus found in this outgoing message. > Checked by AVG Anti-Virus. > Version: 7.0.300 / Virus Database: 265.6.10 - Release Date: 10/01/2005 > >
Re: trunk build broken (Was: how to list all sitemap components)
Jeremy Quinn wrote: I am getting the same problem, but with : BUILD FAILED /Users/jerm/Development/Checkouts/Apache/Cocoon/trunk/tools/targets/ docs-build.xml:55: Sitemap component org.apache.cocoon.generation.NekoHTMLGenerator does not implement a sitemap component interface. I may be at risk of repeating things already known, but... I just did a new svn checkout and got a similar error: Building component docs from blocks. Collecting sitemap components info BUILD FAILED D:\openSource\cocoon\tools\targets\docs-build.xml:55: Sitemap component org.apache.cocoon.template.jxtg.JXTemplateGenerator does not implement a sitemap component interface. Ross -- No virus found in this outgoing message. Checked by AVG Anti-Virus. Version: 7.0.300 / Virus Database: 265.6.10 - Release Date: 10/01/2005
Re: trunk build broken (Was: how to list all sitemap components)
I am getting the same problem, but with : BUILD FAILED /Users/jerm/Development/Checkouts/Apache/Cocoon/trunk/tools/targets/ docs-build.xml:55: Sitemap component org.apache.cocoon.generation.NekoHTMLGenerator does not implement a sitemap component interface. This was after a ./build.sh clean webapp Doing a ./build.sh webapp straight afterwards, resulted in a successful build. regards Jeremy On 11 Jan 2005, at 03:22, David Crossley wrote: The Cocoon SitemapTask in trunk is suddenly throwing a wobbly. - ... Building component docs from blocks. Collecting sitemap components info BUILD FAILED /opt/cocoon-trunk/tools/targets/docs-build.xml:55: Sitemap component org.apache.cocoon.generation.HTMLGenerator does not implement a sitemap component interface. - It is very strange. If you immediately run './build.sh' again then there are no problems. It is the first build after a 'build clean' that has trouble and then only when it is scanning the "src/blocks" not when scanning "src/java". --David If email from this address is not signed IT IS NOT FROM ME Always check the label, folks ! smime.p7s Description: S/MIME cryptographic signature
trunk build broken (Was: how to list all sitemap components)
The Cocoon SitemapTask in trunk is suddenly throwing a wobbly. - ... Building component docs from blocks. Collecting sitemap components info BUILD FAILED /opt/cocoon-trunk/tools/targets/docs-build.xml:55: Sitemap component org.apache.cocoon.generation.HTMLGenerator does not implement a sitemap component interface. - It is very strange. If you immediately run './build.sh' again then there are no problems. It is the first build after a 'build clean' that has trouble and then only when it is scanning the "src/blocks" not when scanning "src/java". --David