Re: [summary] accept mod_fcgid codebase into httpd project
On Tue, Mar 17, 2009 at 6:44 PM, Chris Darroch chr...@pearsoncmg.comwrote: I'm +1 on the idea of moving toward inclusion in httpd trunk as a module, at least as a longer-term goal. My thoughts were: - Start by branching httpd/mod_fcgid/branches/2.x/mod_fcgid based on the current relicensed code, just in case an emergency turns up (security bug?) and we'd like to do a release based on the existing code; most likely, we won't use this going forward. Many people use mod_fcgid on Apache 2.0/2.2. The message should be that mod_fcgid development has moved to the ASF, and existing users are not being left behind in the transition. So a branch for mod_fcgid 2.x is maintained for httpd 2.0/2.2 users just as our own stable branches are maintained (FAR beyond emergencies, at least for 2.2.x). This isn't necessarily in opposition to what you said, but some might read it as something like Apache took over and they won't distribute fixes that work with my existing configurations except in extreme circumstances. (But of course we should include in httpd trunk for Apache 2.4 and beyond, and make any appropriate changes for consistency, new directions, etc.) - Before we can add to httpd trunk, we need to look at the directive names. There are a large number of config directives with names that don't imply FastCGI and in some cases are a little mysterious. I don't think we can drop 32 new directives into httpd with generic names like SocketPath and PassHeader. Trunk is a fine place to address those issues. BTW, thanks for all your work on this!!!
Re: [summary] accept mod_fcgid codebase into httpd project
Roy T. Fielding wrote: Done. I set all of Ryan Pan's commits to svn:author=pqf (for consistency), loaded the whole thing under httpd/mod_fcgid and fixed the eol-style to native. Please relicense the directory and files first before making any other changes. Thanks! I think the relicensing is all done; anyone who wants to check for errors will get a thank-you. After that, we should remove the generated artifacts and consider moving the subdirectory to a module dir under the server trunk. Which artifacts are you concerned about? I'm not 100% sure what you'd like done here. I'm +1 on the idea of moving toward inclusion in httpd trunk as a module, at least as a longer-term goal. My thoughts were: - Start by branching httpd/mod_fcgid/branches/2.x/mod_fcgid based on the current relicensed code, just in case an emergency turns up (security bug?) and we'd like to do a release based on the existing code; most likely, we won't use this going forward. - Fix the whitespace; currently if you set your tab stops to 4 chars it looks right and close to the httpd style, so it's just a conversion from tabs to spaces that remains. I've got a reformatted version ready to commit. - Before we can add to httpd trunk, we need to look at the directive names. There are a large number of config directives with names that don't imply FastCGI and in some cases are a little mysterious. I don't think we can drop 32 new directives into httpd with generic names like SocketPath and PassHeader. I have an old patch I can dust off to rename these; we should choose a prefix first, though. FCGI or FastCGI? The latter might conflict with mod_fastcgi, but then, why would anyone run both at the same time? Still, perhaps FCGI is best? As for the names themselves, I (natch) have a few suggestions which I think clarify the purpose of some of the more obscure ones and align them with other httpd modules a bit. E.g., DefaultMinClassProcessCount might become FCGIKeepServersPerScript or just FCGIKeep since it resembles mod_dbd's DBDKeep in its purpose. I'd like to branch and apply whitespace changes fairly soon; if folks think that's the wrong approach or if there errors in the newly-applied license text, please let me know! Cheers, Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B
Re: [summary] accept mod_fcgid codebase into httpd project
On Feb 18, 2009, at 1:13 PM, Chris Darroch wrote: Roy T. Fielding wrote: I'd suggest that we import the code into SVN by starting not with this temporary package, but with a cvs2svn export of the SourceForge commit history. The relicensing can then follow as a single subsequent commit. Sound OK? Yes, that is what I prefer as well. All paperwork is done, so please let us know when you have an export. I (or one of the other svnadmins) will have to massage it a bit to prefix the sourceforge ids, so just point us to the dump file when you have it ready. It should be in people.apache.org:/home/chrisd/donations/ mod_fcgid now. I used the default full cvs2svn conversion; if you want one with just the trunk and without the small number of CVS tags in the mod_fcgid repository, let me know. There weren't any branches or anything too complex in the SF repository. Done. I set all of Ryan Pan's commits to svn:author=pqf (for consistency), loaded the whole thing under httpd/mod_fcgid and fixed the eol-style to native. Please relicense the directory and files first before making any other changes. After that, we should remove the generated artifacts and consider moving the subdirectory to a module dir under the server trunk. Roy
Re: [summary] accept mod_fcgid codebase into httpd project
Chris Darroch wrote: Roy T. Fielding wrote: Yes, that is what I prefer as well. All paperwork is done, so please let us know when you have an export. I (or one of the other svnadmins) will have to massage it a bit to prefix the sourceforge ids, so just point us to the dump file when you have it ready. It should be in people.apache.org:/home/chrisd/donations/mod_fcgid now. I used the default full cvs2svn conversion; if you want one with just the trunk and without the small number of CVS tags in the mod_fcgid repository, let me know. There weren't any branches or anything too complex in the SF repository. Sorry not to follow up on this for a while; been busy with other stuff. Is there anything else I can help with here? I'd be happy to tackle munging IDs if someone can provide a quick tutorial on what's needed. I should probably also ask about setting up mailing lists, a Bugzilla entry, and getting Web site mojo for mod_fcgid. It would be good to have stuff up and running so we can let people on the old SourceForge mailing lists know about the adoption, among other things. Once the code's in SVN I figured I'd try to do the following: - apply license changes - create legacy 2.x branch - apply whitespace changes to match httpd standard - begin applying functional patches Thoughts? Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B
Re: [summary] accept mod_fcgid codebase into httpd project
Roy T. Fielding wrote: I'd suggest that we import the code into SVN by starting not with this temporary package, but with a cvs2svn export of the SourceForge commit history. The relicensing can then follow as a single subsequent commit. Sound OK? Yes, that is what I prefer as well. All paperwork is done, so please let us know when you have an export. I (or one of the other svnadmins) will have to massage it a bit to prefix the sourceforge ids, so just point us to the dump file when you have it ready. It should be in people.apache.org:/home/chrisd/donations/mod_fcgid now. I used the default full cvs2svn conversion; if you want one with just the trunk and without the small number of CVS tags in the mod_fcgid repository, let me know. There weren't any branches or anything too complex in the SF repository. Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B
Re: [summary] accept mod_fcgid codebase into httpd project
Roy T. Fielding wrote: I ended up fixing all website generation to utf-8 -- I am surprised that it lasted this long with just iso-8859-1. Thanks -- looks good! Yes, that is what I prefer as well. All paperwork is done, so please let us know when you have an export. I (or one of the other svnadmins) will have to massage it a bit to prefix the sourceforge ids, so just point us to the dump file when you have it ready. I'll tackle this next week, if tomorrow's not possible. Thanks very much, Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B
Re: [summary] accept mod_fcgid codebase into httpd project
On Jan 27, 2009, at 9:44 AM, Chris Darroch wrote: The httpd-mod_fcgid.xml file is my first whack at the IP clearance template. I renamed this .xml.utf8 this morning because I realized it has some non-ASCII UTF-8 character sequences in it. I don't know if those will pass through the Incubator's XML-to-HTML transformation smoothly; if not, they could probably be removed. I ended up fixing all website generation to utf-8 -- I am surprised that it lasted this long with just iso-8859-1. 4) The code package is a checkout of the CVS trunk from SourceForge; all I've done is insert LICENSE and NOTICE files, add AL 2.0 license text to all .c, .h, .rc, and .mk files (following the httpd example) and prune out some small text and CVS files. Assuming the Incubator IP clearance review passes, I'd suggest that we import the code into SVN by starting not with this temporary package, but with a cvs2svn export of the SourceForge commit history. The relicensing can then follow as a single subsequent commit. Sound OK? Yes, that is what I prefer as well. All paperwork is done, so please let us know when you have an export. I (or one of the other svnadmins) will have to massage it a bit to prefix the sourceforge ids, so just point us to the dump file when you have it ready. Roy
Re: [summary] accept mod_fcgid codebase into httpd project
Hi -- I wrote: The httpd-mod_fcgid.xml file is my first whack at the IP clearance template. I renamed this .xml.utf8 this morning because I realized it has some non-ASCII UTF-8 character sequences in it. I don't know if those will pass through the Incubator's XML-to-HTML transformation smoothly; if not, they could probably be removed. 4) The code package is a checkout of the CVS trunk from SourceForge; all I've done is insert LICENSE and NOTICE files, add AL 2.0 license text to all .c, .h, .rc, and .mk files (following the httpd example) and prune out some small text and CVS files. Assuming the Incubator IP clearance review passes, I'd suggest that we import the code into SVN by starting not with this temporary package, but with a cvs2svn export of the SourceForge commit history. The relicensing can then follow as a single subsequent commit. Sound OK? Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B
Re: [summary] accept mod_fcgid codebase into httpd project
William A. Rowe, Jr. wrote: sounds great, the form is here; http://svn.apache.org/repos/asf/incubator/public/trunk/site-author/ip-clearance/ip-clearance-template.xml Good god is incubator/public/trunk/ a mess ;-) I've tried to wade through this and the results are here: http://people.apache.org/~chrisd/donations/mod_fcgid/ The httpd-mod_fcgid.xml file is my first whack at the IP clearance template. You may want to adjust a few things: 1) For officer or member managing donation I put my name, but it should perhaps be whoever commits to the Incubator SVN, for which I lack karma. 2) I added a few extra paragraphs listing the specific information we've gathered here over the last couple of months; these may be something you want to delete. 3) The code package and MD5 and SHA1 signatures are in my personal directory. My reading of the form is that this is OK since the SLA doesn't specifically mention a checksum; as a result we just need a temporary location to host the package while it is reviewed. 4) The code package is a checkout of the CVS trunk from SourceForge; all I've done is insert LICENSE and NOTICE files, add AL 2.0 license text to all .c, .h, .rc, and .mk files (following the httpd example) and prune out some small text and CVS files. The NOTICE file contains an acknowledgment of Ryan's original work and the location of the FastCGI specification (but specifically not the mod_fastcgi code or documentation!) Hope that helps; let me know if there's more I can do. Thanks, Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B
Re: [summary] accept mod_fcgid codebase into httpd project
William A. Rowe, Jr. wrote: sounds great, the form is here; http://svn.apache.org/repos/asf/incubator/public/trunk/site-author/ip-clearance/ip-clearance-template.xml Good god is incubator/public/trunk/ a mess ;-) OK, I'll take a whack at filling it out and post back the results -- might take a few days. Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B
Re: [summary] accept mod_fcgid codebase into httpd project
William A. Rowe, Jr. wrote: Sorry, let this thread continue too long, sorry I've been distracted. +1; wrowe, sctemme, issac, rjung, trawick, lars, niq, covener, fielding, jerenkrantz and chrisd. and the support of Albert Lash, Brian Akins and Brian McCallister. The vote passes; next step is to submit the appropriate IP statement to the incubator, wait 72 hours for lazy consensus, and check it in. Thanks! Please let me know if there's anything I can do to help with the IP statement -- drafting, collating email message references, etc. IIRC it's the PMC which has to submit, but I'm happy to do some scut work beforehand if it's useful. Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B
Re: [summary] accept mod_fcgid codebase into httpd project
Chris Darroch wrote: Thanks! Please let me know if there's anything I can do to help with the IP statement -- drafting, collating email message references, etc. IIRC it's the PMC which has to submit, but I'm happy to do some scut work beforehand if it's useful. sounds great, the form is here; http://svn.apache.org/repos/asf/incubator/public/trunk/site-author/ip-clearance/ip-clearance-template.xml Good god is incubator/public/trunk/ a mess ;-)
[summary] accept mod_fcgid codebase into httpd project
William A. Rowe, Jr. wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote Sorry, let this thread continue too long, sorry I've been distracted. +1; wrowe, sctemme, issac, rjung, trawick, lars, niq, covener, fielding, jerenkrantz and chrisd. and the support of Albert Lash, Brian Akins and Brian McCallister. The vote passes; next step is to submit the appropriate IP statement to the incubator, wait 72 hours for lazy consensus, and check it in.
Re: accept mod_fcgid codebase into httpd project
William A. Rowe, Jr. wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote +/-1 [ ] Accept mod_fcgid into httpd Unless I missed a -1, that looked like a lot of +1s to me ... is there a standard length of time to wait before calling the vote to a close? Assuming the vote passed, what's the next step? The docs at http://incubator.apache.org/ip-clearance/index.html describe an IP clearance submission to the Incubator, to be written by the PMC. Would it help if I tried drafting a version of this which the PMC could then revise? Let me know what's best; thanks, Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B
Re: accept mod_fcgid codebase into httpd project
On Jan 12, 2009, at 12:53 PM, William A. Rowe, Jr. wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote +/-1 [ ] Accept mod_fcgid into httpd +1 S. -- Sander Temme scte...@apache.org PGP FP: 51B4 8727 466A 0BC3 69F4 B7B8 B2BE BC40 1529 24AF smime.p7s Description: S/MIME cryptographic signature
Re: accept mod_fcgid codebase into httpd project
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Jan 12, 2009, at 12:53 PM, William A. Rowe, Jr. wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote +/-1 [ ] Accept mod_fcgid into httpd +1 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAklrIPcACgkQ7bEFiW+VItiftwCdEEcYZnrBUo0qvqfm5xswAc8g jk8AoL1+ho/KrjAe6lnIMjDpeBZfVRzV =vG/V -END PGP SIGNATURE-
Re: accept mod_fcgid codebase into httpd project
On 12.01.2009 04:53, William A. Rowe, Jr. wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote +/-1 [+1] Accept mod_fcgid into httpd
Re: accept mod_fcgid codebase into httpd project
On Jan 11, 2009 10:53pm, William A. Rowe, Jr. wr...@rowe-clan.net wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote +/-1 [+1] Accept mod_fcgid into httpd And Thanks! to the mod_fcgid author and contributors!
Re: accept mod_fcgid codebase into httpd project
William A. Rowe, Jr. wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote +/-1 [ ] Accept mod_fcgid into httpd +1 ciao... -- Lars Eilebrecht l...@eilebrecht.net
Re: accept mod_fcgid codebase into httpd project
traw...@gmail.com wrote: [+1] Accept mod_fcgid into httpd +1 And Thanks! to the mod_fcgid author and contributors! +1 to that, too. -- Nick Kew
Re: accept mod_fcgid codebase into httpd project
On Sun, Jan 11, 2009 at 10:53 PM, William A. Rowe, Jr. wr...@rowe-clan.net wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote [ ] Accept mod_fcgid into httpd +1 -- Eric Covener cove...@gmail.com
Re: accept mod_fcgid codebase into httpd project
On 1/11/09 10:53 PM, William A. Rowe, Jr. wr...@rowe-clan.net wrote: [ ] Accept mod_fcgid into httpd +1 -- Brian Akins Chief Operations Engineer Turner Digital Media Technologies
Re: accept mod_fcgid codebase into httpd project
William A. Rowe, Jr. wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote [+1] Accept mod_fcgid into httpd And as others have already expressed, many thanks to Ryan and everyone else involved. Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B
Re: accept mod_fcgid codebase into httpd project
On Mon, Jan 12, 2009 at 12:59 PM, traw...@gmail.com wrote: On Jan 11, 2009 10:53pm, William A. Rowe, Jr. wr...@rowe-clan.net wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote +/-1 [+1] Accept mod_fcgid into httpd not that my vote counts but I think mod_fcgid's inclusion in the main httpd will be a good think. +1 And Thanks! to the mod_fcgid author and contributors! +1 to this as wel!
Re: accept mod_fcgid codebase into httpd project
+1 Roy
Re: accept mod_fcgid codebase into httpd project
On Sun, Jan 11, 2009 at 7:53 PM, William A. Rowe, Jr. wr...@rowe-clan.net wrote: [ ] Accept mod_fcgid into httpd +1. Thanks. -- justin
accept mod_fcgid codebase into httpd project
Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote +/-1 [ ] Accept mod_fcgid into httpd
Re: accept mod_fcgid codebase into httpd project
[+1] Accept mod_fcgid into httpd from me
Re: accept mod_fcgid codebase into httpd project
+1 On Sun, Jan 11, 2009 at 10:53 PM, William A. Rowe, Jr. wr...@rowe-clan.net wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote +/-1 [ ] Accept mod_fcgid into httpd
Re: accept mod_fcgid codebase into httpd project
+1 On Sun, Jan 11, 2009 at 7:55 PM, Albert Lash albert.l...@gmail.com wrote: +1 On Sun, Jan 11, 2009 at 10:53 PM, William A. Rowe, Jr. wr...@rowe-clan.net wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote +/-1 [ ] Accept mod_fcgid into httpd
