[jira] [Commented] (SOLR-8668) Remove support for (in favour of )
[
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124008#comment-16124008
]
Steve Rowe commented on SOLR-8668:
--
{{git bisect}} says that commit {{c64f9d6}} on this issue is where
{{QueryElevationComponentTest.testMarkExcludes()}} started reproducibly failing
- see SOLR-7992.
> Remove support for (in favour of )
>
>
> Key: SOLR-8668
> URL: https://issues.apache.org/jira/browse/SOLR-8668
> Project: Solr
> Issue Type: Improvement
>Reporter: Shai Erera
>Assignee: Christine Poerschke
>Priority: Blocker
> Fix For: 7.0
>
> Attachments: SOLR-8668-part1.patch, SOLR-8668-part1.patch,
> SOLR-8668.patch
>
>
> Following SOLR-8621, we should remove support for {{}} (and
> related {{}} and {{}}) in trunk/6x.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8668) Remove support for (in favour of )
[
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034750#comment-16034750
]
ASF subversion and git services commented on SOLR-8668:
---
Commit c64f9d64b4edc8c3761368befc394e879b2284ff in lucene-solr's branch
refs/heads/master from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c64f9d6 ]
SOLR-8668: In solrconfig.xml remove (and related
and )
support in favor of the element introduced by SOLR-8621 in
Solr 5.5.0.
(Christine Poerschke, hossman)
> Remove support for (in favour of )
>
>
> Key: SOLR-8668
> URL: https://issues.apache.org/jira/browse/SOLR-8668
> Project: Solr
> Issue Type: Improvement
>Reporter: Shai Erera
>Assignee: Christine Poerschke
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-8668-part1.patch, SOLR-8668-part1.patch,
> SOLR-8668.patch
>
>
> Following SOLR-8621, we should remove support for {{}} (and
> related {{}} and {{}}) in trunk/6x.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8668) Remove support for (in favour of )
[
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029686#comment-16029686
]
Christine Poerschke commented on SOLR-8668:
---
bq. ... this comment still exists ...
Oops, fixed now. Had seen that comment and thought of its removal but then got
distracted by the actual change ...
> Remove support for (in favour of )
>
>
> Key: SOLR-8668
> URL: https://issues.apache.org/jira/browse/SOLR-8668
> Project: Solr
> Issue Type: Improvement
>Reporter: Shai Erera
>Assignee: Christine Poerschke
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-8668-part1.patch, SOLR-8668-part1.patch
>
>
> Following SOLR-8621, we should remove support for {{}} (and
> related {{}} and {{}}) in trunk/6x.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8668) Remove support for (in favour of )
[
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029672#comment-16029672
]
Hoss Man commented on SOLR-8668:
bq. Good catch that! I've gone and renamed from effectiveUseCompoundFileSetting
to useCompoundFile ...
this comment still exists when the variable is used to build the IWC...
{code}
// do this after buildMergePolicy since the backcompat logic
// there may modify the effective useCompoundFile
-iwc.setUseCompoundFile(getUseCompoundFile());
+iwc.setUseCompoundFile(useCompoundFile);
{code}
...and that's now missleading/confusing.
> Remove support for (in favour of )
>
>
> Key: SOLR-8668
> URL: https://issues.apache.org/jira/browse/SOLR-8668
> Project: Solr
> Issue Type: Improvement
>Reporter: Shai Erera
>Assignee: Christine Poerschke
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-8668-part1.patch, SOLR-8668-part1.patch
>
>
> Following SOLR-8621, we should remove support for {{}} (and
> related {{}} and {{}}) in trunk/6x.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8668) Remove support for (in favour of )
[
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029637#comment-16029637
]
Christine Poerschke commented on SOLR-8668:
---
bq. The one thing that jumped out at me is
SolrIndexConfig.effectiveUseCompoundFileSetting. ...
Good catch that! I've gone and renamed from _effectiveUseCompoundFileSetting_
to _useCompoundFile_ (with no _get...()_) accessor to match the style of the
other settings.
Changes from master merged into the working branch and tests pass for me
locally.
https://github.com/apache/lucene-solr/compare/jira/solr-8668#files_bucket shows
all the changes. Further comments and reviews welcome as usual.
If there are no further comments then I'll aim to commit this to master branch
Thursday or Friday this week (June 1st or June 2nd).
> Remove support for (in favour of )
>
>
> Key: SOLR-8668
> URL: https://issues.apache.org/jira/browse/SOLR-8668
> Project: Solr
> Issue Type: Improvement
>Reporter: Shai Erera
>Assignee: Christine Poerschke
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-8668-part1.patch, SOLR-8668-part1.patch
>
>
> Following SOLR-8621, we should remove support for {{}} (and
> related {{}} and {{}}) in trunk/6x.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8668) Remove support for (in favour of )
[
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024566#comment-16024566
]
Christine Poerschke commented on SOLR-8668:
---
Thanks Hoss for taking a look at the working branch vs. master!
bq. ... but I'm guessing that's because an equivilent MergePolicyFactory based
test already exists?
Correct.
bq. The one thing that jumped out at me is
SolrIndexConfig.effectiveUseCompoundFileSetting. ...
Good question, I don't recall details right now but will take a look. Thanks
for flagging it up.
bq. ... Whoa, whoa ... what? ... no, no no! ... -1! ...
Yes, I agree, that logic needs to change. The warning-or-exception pondering
here preceded the SOLR-10572 clarifications i.e. yes, I agree we must throw an
exception/fail and actually that will also make the change here easier then
i.e. no part-1-and-then-part-2 splitting.
> Remove support for (in favour of )
>
>
> Key: SOLR-8668
> URL: https://issues.apache.org/jira/browse/SOLR-8668
> Project: Solr
> Issue Type: Improvement
>Reporter: Shai Erera
>Assignee: Christine Poerschke
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-8668-part1.patch, SOLR-8668-part1.patch
>
>
> Following SOLR-8621, we should remove support for {{}} (and
> related {{}} and {{}}) in trunk/6x.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8668) Remove support for (in favour of )
[
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023854#comment-16023854
]
Hoss Man commented on SOLR-8668:
Christine: I just skimmed {{git diff master...jira/solr-8668}} ...
Most everything looked sane to me. In a few places I got a little confused as
to why some tests/configs were removed instead of just replacing the existing
config with a MergePolicyFactory config -- but I'm guessing that's because an
equivilent MergePolicyFactory based test already exists?
The one thing that jumped out at me is
{{SolrIndexConfig.effectiveUseCompoundFileSetting}}. Now that
{{SolrIndexConfig.fixUseCFMergePolicyInitArg}} is removed, I think we
can/should simplify/remove the (mutable) {{effectiveUseCompoundFileSetting}}
and assocaited methods/hacks into a {{finel boolean useCompoundFile}} just like
every other SOlrIndexConfig setting. right?
bq. Hoping to commit this later this month ...
+1
{quote}
bq. do we need to throw an exception if anyone still configures
or is it fair to silently ignore it
I think a warning might be a fair compromise, instead of an exception or silent
ignoring.
{quote}
bq. part 2: small incremental change (replace throwing-exception with
log-warning)
Whoa, whoa ... what? ... no, no no! ... -1!
{{}} was deprecated (and stopped appearing in example configs) in
5.5! If someone has been upgrading Solr since then and never bothered to notice
the {{WARN}} in their log file informing them that they should switch to
{{}}, there is no sane reason to assume they will notice a
{{WARN}} in their 7.0 logs that it's being completely ignored. Doing that is
effectively the same as silently ignoring their config -- which means the
implicit default {{}} will be used while they *think* they
are using some very explicit {{}} and beating their heads against
the wall trying to understand why 7.0 is ignoring their "maxMergedSegmentMB"
etc
A WARNing is appropriate when config option X is deprecated but still supported
-- but once X is no longer supported at all we should _absolutely_ hard fail if
people are still trying to configure X -- so that so they _know_ they need to
change their config.
> Remove support for (in favour of )
>
>
> Key: SOLR-8668
> URL: https://issues.apache.org/jira/browse/SOLR-8668
> Project: Solr
> Issue Type: Improvement
>Reporter: Shai Erera
>Assignee: Christine Poerschke
>Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-8668-part1.patch, SOLR-8668-part1.patch
>
>
> Following SOLR-8621, we should remove support for {{}} (and
> related {{}} and {{}}) in trunk/6x.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8668) Remove support for (in favour of )
[
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974049#comment-15974049
]
Ishan Chattopadhyaya commented on SOLR-8668:
+1, thanks for working on this.
bq. do we need to throw an exception if anyone still configures
or is it fair to silently ignore it
I think a warning might be a fair compromise, instead of an exception or silent
ignoring.
> Remove support for (in favour of )
>
>
> Key: SOLR-8668
> URL: https://issues.apache.org/jira/browse/SOLR-8668
> Project: Solr
> Issue Type: Improvement
>Reporter: Shai Erera
>Priority: Blocker
> Fix For: master (7.0)
>
>
> Following SOLR-8621, we should remove support for {{}} (and
> related {{}} and {{}}) in trunk/6x.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8668) Remove support for (in favour of )
[
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973438#comment-15973438
]
Christine Poerschke commented on SOLR-8668:
---
Made a start on this with a first commit on
https://github.com/apache/lucene-solr/tree/jira/solr-8668 - not the most
exciting of changes admittedly but it would be good for to go
away from Solr 7.0 onwards in favour of given that
SOLR-8621 deprecated from Solr 5.5 onwards.
Collaboration and/or code reviews welcome, e.g. do we need to throw an
exception if anyone still configures or is it fair to silently
ignore it? solr/CHANGES.txt will obviously need to mention about
support being removed from 7.0 onwards.
> Remove support for (in favour of )
>
>
> Key: SOLR-8668
> URL: https://issues.apache.org/jira/browse/SOLR-8668
> Project: Solr
> Issue Type: Improvement
>Reporter: Shai Erera
>Priority: Blocker
> Fix For: master (7.0)
>
>
> Following SOLR-8621, we should remove support for {{}} (and
> related {{}} and {{}}) in trunk/6x.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8668) Remove support for (in favour of )
[
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875146#comment-15875146
]
Ishan Chattopadhyaya commented on SOLR-8668:
FYI, I ran into a MP vs MPF issue while backporting a test to branch_6x,
SOLR-10178. Possibly related to this issue?
> Remove support for (in favour of )
>
>
> Key: SOLR-8668
> URL: https://issues.apache.org/jira/browse/SOLR-8668
> Project: Solr
> Issue Type: Improvement
>Reporter: Shai Erera
>Priority: Blocker
> Fix For: master (7.0)
>
>
> Following SOLR-8621, we should remove support for {{}} (and
> related {{}} and {{}}) in trunk/6x.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
