Re: [VOTE] Release PyLucene 4.2.1-1

2013-04-18 Thread Christian Heimes
Am 18.04.2013 19:08, schrieb Andi Vajda:
> 
> On Thu, 18 Apr 2013, Thomas Koch wrote:
> 
>> Andi,
>> I now get a different error while compiling __init__.cpp:
>>
>> org/apache/lucene/util/automaton/CompiledAutomaton$AUTOMATON_TYPE.h(42) :
>> error C2059: Syntaxfehler: 'Zeichenfolge'
>> org/apache/lucene/util/automaton/CompiledAutomaton$AUTOMATON_TYPE.h(42) :
>> error C2238: Unerwartete(s) Token vor ';'
>>
>> The line complained about is #42
>>
>> 40static CompiledAutomaton$AUTOMATON_TYPE *NONE;
>> 41static CompiledAutomaton$AUTOMATON_TYPE *NORMAL;
>> 42static CompiledAutomaton$AUTOMATON_TYPE *PREFIX;
>> 43static CompiledAutomaton$AUTOMATON_TYPE *SINGLE;
>>
>> PREFIX seems to be another reserved word ... I could compile __init__.cpp
>> after renaming PREFIX to PREFIX1.
> 
> Instead of renaming PREFIX, could you please have JCC do it for you by
> adding it to the list of reserved words in the JCC invocation via the
> --reserved command line flag ? and rinse and repeat until all such conficts
> due to macro definitions are solved ?
> 
> Or were you able to complete the build already once PREFIX was renamed ?

I'm pretty sure the Windows build issue is caused by the PREFIX macro in
PC/pyconfig.h. I ran into the same issue a while ago. I have created a
bug report for the issue http://bugs.python.org/issue17791

Christian


Re: [VOTE] Release PyLucene 4.2.1

2013-04-17 Thread Andi Vajda


On Tue, 16 Apr 2013, Chris Hostetter wrote:


: A release candidate is available from:
: http://people.apache.org/~vajda/staging_area/

-1 to releasing the files with the following MD5 checksums...

c84b71c718cee06bff63d5757115aa71  pylucene-4.2.1-0-src.tar.gz
a49300178884804ba9f7438a19732b21  pylucene-4.2.1-0-src.tar.gz.asc
f9d4c51dc4a04fc65d7630c8c8371be5  pylucene-4.2.1-0-src.tar.gz.md5

Problems encountered...

1) pylucene-4.2.1-0-src.tar.gz.md5 is not formated such that it can be
easily verified using "md5sum -c" (refers to "stdin")


Fixed, using md5sum to generate checksum now.


2) NOTICE file does not correctly reflect year of the distribution (2009
instead of 2013)


Fixed.


3) INSTALL and README files that refer to files in "doc/documentation"
however there is no "doc" directory, and the file names refered to
("readme.html" and "install.html") do not exist in any directory.


Removed the reference to the no longer existing docs directory and edited 
side to no longer refer to now obsolete (and removed) Lucene in Action 
samples.



4) Attempting to "make" the project resulted in an immediate build failure
w/o a clear indication of what the problem was...

hossman@frisbee:~/tmp/pylucene_4_2_1_rc/pylucene-4.2.1-0$ make
cd lucene-java-4.2.1/lucene; ( ivy-fail ||  ivy-bootstrap)
/bin/sh: 1: ivy-fail: not found
/bin/sh: 1: ivy-bootstrap: not found
make: *** [ivy] Error 127

(based on the install.html from the pylucene website, i'm guessing this is
related to not manually editing the Makefile, or specifying some mandatory
variables to 'make' on the commandline, but it seems wrong not to have a
more straight forward error here if that is what's required.)


Fixed by adding error messages complaining about the missing env var(s).

Andi..


Re: [VOTE] Release PyLucene 4.2.1

2013-04-15 Thread Andi Vajda

On Apr 15, 2013, at 3:52, Michael McCandless  wrote:

> I'm having trouble on an Ubuntu 12.10 box, using Java 1.7_07 and Python 2.7.3.
> 
> I was able to build and install both JCC and PyLucene, apparently 
> successfully.
> 
> I can "import lucene" in Python and print lucene.VERSION and confirm it's 
> 4.2.1.
> 
> lucene.initVM(lucene.CLASSPATH) succeeds.
> 
> Yet, there are no Lucene classes in the lucene module?  When I print
> dir(lucene) I just get this:
> 
> ['CLASSPATH', 'ConstVariableDescriptor', 'FinalizerClass',
> 'FinalizerProxy', 'InvalidArgsError', 'JArray', 'JArray_bool',
> 'JArray_byte', 'JArray_char', 'JArray_double', 'JArray_float',
> 'JArray_int', 'JArray_long', 'JArray_object', 'JArray_short',
> 'JArray_string', 'JCCEnv', 'JCC_VERSION', 'JObject', 'JavaError',
> 'PrintWriter', 'StringWriter', 'VERSION', '__builtins__', '__dir__',
> '__doc__', '__file__', '__name__', '__package__', '__path__',
> '_lucene', 'findClass', 'getVMEnv', 'initVM', 'makeClass',
> 'makeInterface', 'os', 'sys']
> 
> Am I missing something silly...?  Shouldn't Lucene's classes (eg
> FSDirectory) be visible in globals() in the lucene module?

The one big change on the PyLucene side is that now Lucene classes are in a 
package structure that mirrors the Java one. Thus, to get FSDirectory you now 
need to:

  import lucene
  from org.apache.lucene.store import FSDirectory

Besides providing initVM() and a few other things such as JArray, importing 
lucene also installs the org package tree.

Andi..

> 
> Mike McCandless
> 
> http://blog.mikemccandless.com
> 
> On Sat, Apr 13, 2013 at 5:51 PM, Andi Vajda  wrote:
>> 
>> It looks like the time has finally come for a PyLucene 4.x release !
>> 
>> The PyLucene 4.2.1-0 release tracking the recent release of Apache Lucene
>> 4.2.1 is ready.
>> 
>> A release candidate is available from:
>> http://people.apache.org/~vajda/staging_area/
>> 
>> A list of changes in this release can be seen at:
>> http://svn.apache.org/repos/asf/lucene/pylucene/branches/pylucene_4_2/CHANGES
>> 
>> PyLucene 4.2.1 is built with JCC 2.16 included in these release artifacts:
>> http://svn.apache.org/repos/asf/lucene/pylucene/trunk/jcc/CHANGES
>> 
>> A list of Lucene Java changes can be seen at:
>> http://svn.apache.org/repos/asf/lucene/dev/tags/lucene_solr_4_2_1/lucene/CHANGES.txt
>> 
>> Please vote to release these artifacts as PyLucene 4.2.1-0.
>> 
>> Thanks !
>> 
>> Andi..
>> 
>> ps: the KEYS file for PyLucene release signing is at:
>> http://svn.apache.org/repos/asf/lucene/pylucene/dist/KEYS
>> http://people.apache.org/~vajda/staging_area/KEYS
>> 
>> pps: here is my +1