Re: [Django] #34964: Reversing the order of Q objects in a CheckConstraint generates a migration

2023-11-13 Thread Django
#34964: Reversing the order of Q objects in a CheckConstraint generates a 
migration
-+-
 Reporter:  Jacob Walls  |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  noop | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 I have a gut feeling that it's not worth doing, as there is a risk of
 potential regressions. If you modify `check` of `condition` you should be
 ready to deal with consequences of recreating the index, even if they
 theoretically have the same meaning 路 I'm not strongly against this
 patch, this is just a friendly warning ;)

 > ... with a table rebuild. That's something you might miss.

 I know how migrations work on SQLite ;)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bccc31af1-7b9bf239-db89-4061-af5d-f5477a3d2d31-00%40eu-central-1.amazonses.com.


Re: [Django] #34919: Missing scope attribute in admin doc table headers.

2023-11-13 Thread Django
#34919: Missing scope attribute in admin doc table headers.
-+-
 Reporter:  Louis-Cloud  |Owner:  jed212
 Type:  Bug  |   Status:  closed
Component:  contrib.admindocs|  Version:  4.2
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  table, scope,| Triage Stage:  Ready for
  screenreader, accessibility|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"bdf30b952c66701075bb7cbbbd3467d3e908fe62" bdf30b95]:
 {{{
 #!CommitTicketReference repository=""
 revision="bdf30b952c66701075bb7cbbbd3467d3e908fe62"
 Fixed #34919 -- Added scope attribute to admindocs model templates.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bccb90700-3026d776-b8cc-48c0-8364-a93d455f1c01-00%40eu-central-1.amazonses.com.


Re: [Django] #31700: Highlight destructive operations in makemigrations output

2023-11-13 Thread Django
#31700: Highlight destructive operations in makemigrations output
-+---
 Reporter:  Tom Forbes   |Owner:  Amir Karimi
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+---
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bcc38a554-a03ce82c-7237-48e9-85c9-3b5a8cc5f2f9-00%40eu-central-1.amazonses.com.


Re: [Django] #34919: Missing scope attribute in admin doc table headers.

2023-11-13 Thread Django
#34919: Missing scope attribute in admin doc table headers.
-+-
 Reporter:  Louis-Cloud  |Owner:  jed212
 Type:  Bug  |   Status:  assigned
Component:  contrib.admindocs|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  table, scope,| Triage Stage:  Ready for
  screenreader, accessibility|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bcc22aaeb-87950ec7-021b-4eca-9245-280111cf0617-00%40eu-central-1.amazonses.com.


Re: [Django] #34952: manage.py compilemessages may skip locale folders if ignore is used.

2023-11-13 Thread Django
#34952: manage.py compilemessages may skip locale folders if ignore is used.
-+-
 Reporter:  Andrew Cordery   |Owner:  Andrew
 |  Cordery
 Type:  Bug  |   Status:  closed
Component:   |  Version:  4.2
  Internationalization   |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * needs_better_patch:  1 => 0
 * resolution:   => fixed


Comment:

 Fixed by ad41f1c53aa9f2c938df32e4386d8a80138923fc.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bcc09ec21-957a79a3-1573-4395-9dd7-70ef2d959424-00%40eu-central-1.amazonses.com.


Re: [Django] #28519: Add filter(), exclude(), and other base QuerySet methods to combined QuerySets (union(), etc.)

2023-11-13 Thread Django
#28519: Add filter(), exclude(), and other base QuerySet methods to combined
QuerySets (union(), etc.)
-+-
 Reporter:  Stanislav Karpov |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  union,   | Triage Stage:  Accepted
  intersection, difference   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tom Carrick):

 * cc: Tom Carrick (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bca57b32b-15dbf706-530b-4404-a808-465d8e12b4f1-00%40eu-central-1.amazonses.com.


Re: [Django] #27909: Use AUTH_USER_MODEL in startproject template

2023-11-13 Thread Django
#27909: Use AUTH_USER_MODEL in startproject template
-+-
 Reporter:  David D Lowe |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Management |  Version:  1.10
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tom Carrick):

 * cc: Tom Carrick (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bca577b6d-3b586c22-c845-40fe-a642-3ba7f91367d0-00%40eu-central-1.amazonses.com.


Re: [Django] #34952: manage.py compilemessages may skip locale folders if ignore is used.

2023-11-13 Thread Django
#34952: manage.py compilemessages may skip locale folders if ignore is used.
-+-
 Reporter:  Andrew Cordery   |Owner:  Andrew
 |  Cordery
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  4.2
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc9de7e63-0ec25305-cc38-484b-85ba-c30bde7e3cd8-00%40eu-central-1.amazonses.com.


Re: [Django] #34970: Unclear wording in password validator docs

2023-11-13 Thread Django
#34970: Unclear wording in password validator docs
-+-
 Reporter:  Markus Amalthea  |Owner:  nobody
  Magnuson   |
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * stage:  Unreviewed => Accepted


Comment:

 Hi Markus, thanks for the ticket. I agree the wording is confusing,
 accepting. Would you like to propose a patch?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc9a2766a-a41afc82-0d7b-45ef-859c-31e7336c0eac-00%40eu-central-1.amazonses.com.


Re: [Django] #27692: Remember scroll position in list screen after coming back from edit screen - remove autofocus from search field

2023-11-13 Thread Django
#27692: Remember scroll position in list screen after coming back from edit 
screen
- remove autofocus from search field
-+-
 Reporter:  Ciske Boekelo|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  Remember scroll  | Triage Stage:  Accepted
  position autofocus search field|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tom Carrick):

 * cc: Tom Carrick (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc98391eb-d38edef6-0c30-4f1f-89fe-147894a9fa42-00%40eu-central-1.amazonses.com.


Re: [Django] #27466: Use a datepicker widget for Date[Time]RangeField in admin

2023-11-13 Thread Django
#27466: Use a datepicker widget for Date[Time]RangeField in admin
-+-
 Reporter:  Adrien Brunet|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  forms, admin,| Triage Stage:  Accepted
  jquery, datepicker |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Tom Carrick):

 * cc: Tom Carrick (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc97985f6-7b607c75-6943-441f-a3a1-d895c605b318-00%40eu-central-1.amazonses.com.


Re: [Django] #34964: Reversing the order of Q objects in a CheckConstraint generates a migration

2023-11-13 Thread Django
#34964: Reversing the order of Q objects in a CheckConstraint generates a 
migration
-+-
 Reporter:  Jacob Walls  |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  noop | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jacob Walls):

 Thanks for the extra context around those edge cases. I'd love to know
 more about them so I can look for them in my own projects.

 I notice we've been sorting the arguments to the Q constructor since
 #29125. So if someone did need to change the order to work around a
 database edge case, they'd ''want'' a change from `Q(A, B)` to `Q(A) &
 Q(B)` to generate a migration, since if B sorts before A, it can only be
 expressed in Django as the latter, and this PR would take away the
 migration to make it.

 The argument in favor of this change (which is very slight, I know) is
 that refactoring the code for consistency/readability with the surrounding
 constraints might generate a migration with a table rebuild. That's
 something you might miss. In other words, you need to know that it's not
 worth paying that cost when you're editing/reviewing the code. Until I
 knew about these edge cases, I thought that was a potential DX win to
 reduce cognitive burden.

 Finally, I guess if we still wanted this change we might ought to block it
 on a resolution of #25245. Should we Someday/Maybe this ticket, then?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc9007dd9-d21600f1-671b-4c72-a539-6fa428595e51-00%40eu-central-1.amazonses.com.


Re: [Django] #34970: Unclear wording in password validator docs

2023-11-13 Thread Django
#34970: Unclear wording in password validator docs
-+-
 Reporter:  Markus Amalthea  |Owner:  nobody
  Magnuson   |
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by David Sanders):

 It could be a little clearer but I believe it's referring to optional
 extra information like a dictionary of common passwords that are
 blacklisted.

 Do you have suggestions on how to improve it?  If you do you're welcome to
 submit a doc PR ☺️ 

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc8d355a6-98070c81-f94e-4f05-8851-31e4026354b5-00%40eu-central-1.amazonses.com.


Re: [Django] #25612: django.contrib.auth should include support for 2fa out of the box

2023-11-13 Thread Django
#25612: django.contrib.auth should include support for 2fa out of the box
--+---
 Reporter:  Alex Gaynor   |Owner:  theExplorer
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+---
Changes (by Tom Carrick):

 * cc: Tom Carrick (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc8c63b7e-8edda7b0-34e5-4980-b4b6-2185cc9a42f4-00%40eu-central-1.amazonses.com.


[Django] #34970: Unclear wording in password validator docs

2023-11-13 Thread Django
#34970: Unclear wording in password validator docs
-+-
   Reporter:  Markus |  Owner:  nobody
  Amalthea Magnuson  |
   Type: | Status:  new
  Cleanup/optimization   |
  Component: |Version:  4.2
  Documentation  |
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 [https://docs.djangoproject.com/en/4.2/topics/auth/passwords/#password-
 validation This page] has the following paragraph:

 Each password validator must provide a help text to explain the
 requirements to the user, validate a given password and return an error
 message if it does not meet the requirements, and optionally receive
 passwords that have been set. Validators can also have optional settings
 to fine tune their behavior.

 It's unclear to me what "optionally receive passwords" means. Is it a
 typo?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc8c4fbfc-c58fe1e9-c04a-4043-a325-4bb45eb00c0b-00%40eu-central-1.amazonses.com.


Re: [Django] #25582: Add a way to build URLs with query strings

2023-11-13 Thread Django
#25582: Add a way to build URLs with query strings
+---
 Reporter:  Thomas Güttler  |Owner:  Daniel Rios
 Type:  New feature |   Status:  assigned
Component:  Core (URLs) |  Version:  dev
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+---
Changes (by Tom Carrick):

 * cc: Tom Carrick (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc8c356e8-3a0265bc-056c-4d19-a5d8-d3ecb1ab4426-00%40eu-central-1.amazonses.com.


Re: [Django] #34966: Add a check for ModelAdmin.actions functions not taking three arguments

2023-11-13 Thread Django
#34966: Add a check for ModelAdmin.actions functions not taking three arguments
-+-
 Reporter:  Riccardo |Owner:  nobody
  Magliocchetti  |
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  admin actions| Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Hello Riccardo, thank you for your ticket and interest to make Django
 better.

 I understand your report, but Django can not possibly add checks for every
 function or method signature that Django users create when using the
 framework. In my experience, these errors are better caught by unit tests,
 there are plenty of examples in the Django source code and in other open
 projects that would provide examples about how to test Admin actions.

 Did you have unit tests that did not catch this? If so, perhaps you could
 seek further help in how to improve/fix those by using any of the user
 support channels from [https://docs.djangoproject.com/en/dev/faq/help
 /#how-do-i-do-x-why-doesn-t-y-work-where-can-i-go-to-get-help this link].
 I'll be closing this ticket as wontfix following the
 [https://docs.djangoproject.com/en/4.2/internals/contributing/triaging-
 tickets/#closing-tickets ticket triaging process].

 Thanks again!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc8c0bfde-8d17c575-42ce-4eb9-b6a3-70fa688ad285-00%40eu-central-1.amazonses.com.


Re: [Django] #34964: Reversing the order of Q objects in a CheckConstraint generates a migration

2023-11-13 Thread Django
#34964: Reversing the order of Q objects in a CheckConstraint generates a 
migration
-+-
 Reporter:  Jacob Walls  |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  noop | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 I have doubts, in my experience database optimizers are sometimes very
 picky and the order of statements may be significant even for commutative
 operators.

 Is it worth changing?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc8ba79d3-8d2b34c5-df2d-496a-ba78-f4b00f32bb92-00%40eu-central-1.amazonses.com.


Re: [Django] #34968: MultiPartParser silent large header fields size failures

2023-11-13 Thread Django
#34968: MultiPartParser silent large header fields size failures
-+-
 Reporter:  Standa Opichal   |Owner:  Standa
 Type:   |  Opichal
  Cleanup/optimization   |   Status:  assigned
Component:  HTTP handling|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Standa Opichal
 * needs_better_patch:  0 => 1
 * type:  Bug => Cleanup/optimization
 * status:  new => assigned
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc8a83c64-6375bc57-8eaa-43de-8509-c65c9b4afa7f-00%40eu-central-1.amazonses.com.


Re: [Django] #34969: Documentation is misleading about SQL equivalent

2023-11-13 Thread Django
#34969: Documentation is misleading about SQL equivalent
-+-
 Reporter:  Piotr Kotarba|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  3.2
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * type:  Uncategorized => Cleanup/optimization
 * resolution:   => duplicate


Comment:

 Duplicate of #20775.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc89f5b78-c74e429f-12f8-48b2-91b2-c721c1706584-00%40eu-central-1.amazonses.com.


[Django] #34969: Documentation is misleading about SQL equivalent

2023-11-13 Thread Django
#34969: Documentation is misleading about SQL equivalent
-+
   Reporter:  softwaredevPK  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Documentation  |Version:  3.2
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Below misleading has been checked for 3.2, but I assume it might also
 apply for all remaining version up to 4.2(not checked).

 Documentation says:
 {{{
 #!div style="font-size: 80%"
 Code highlighting:
   {{{#!python
   **Example:**
 Blog.objects.get(name__iexact="beatles blog")
 Blog.objects.get(name__iexact=None)

 **SQL equivalents:**
 SELECT ... WHERE name ILIKE 'beatles blog';
 SELECT ... WHERE name IS NULL;

   }}}
 }}}

 Based on a code of Django itself I have found out that not every backend
 uses ILIKE.
 For example postgresql or Oracle uses UPPER:

 {{{
 #!div style="font-size: 80%"
 Code highlighting:
   {{{#!python
   class DatabaseWrapper(BaseDatabaseWrapper):
 vendor = 'oracle'
 display_name = 'Oracle'
 _standard_operators = {
 'exact': '= %s',
 'iexact': '= UPPER(%s)',
   ... }

   }}}
 }}}


 You can check that under:
 django.db.backends.oracle.base.DatabaseWrapper

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc899ad89-9495bc0c-5f2d-4ff2-bef6-9047d1531f76-00%40eu-central-1.amazonses.com.


Re: [Django] #34967: Queries not generating GROUP BY clause with static annotation crashes on SQLite

2023-11-13 Thread Django
#34967: Queries not generating GROUP BY clause with static annotation crashes on
SQLite
-+-
 Reporter:  Simon Legtenborg |Owner:  David
 |  Sanders
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  sqlite   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b863c5ffde0bafa5eaa9f262103eaeb71877787c" b863c5ff]:
 {{{
 #!CommitTicketReference repository=""
 revision="b863c5ffde0bafa5eaa9f262103eaeb71877787c"
 Fixed #34967 -- Fixed queryset crash when grouping by constants on SQLite
 < 3.39.

 On SQLite < 3.39, this forces a GROUP BY clause with a HAVING clause
 when no grouping is specified.

 Co-authored-by: Simon Charette 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc8978dc2-03943ed4-5956-4a3f-bca3-79d33b01f10f-00%40eu-central-1.amazonses.com.


Re: [Django] #34968: MultiPartParser silent large header fields size failures

2023-11-13 Thread Django
#34968: MultiPartParser silent large header fields size failures
---+--
 Reporter:  opichals   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  HTTP handling  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by opichals):

 PR updated

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc881942f-9bf50221-599e-4878-a82a-528c6759b558-00%40eu-central-1.amazonses.com.


Re: [Django] #34968: MultiPartParser silent large header fields size failures

2023-11-13 Thread Django
#34968: MultiPartParser silent large header fields size failures
---+--
 Reporter:  opichals   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  HTTP handling  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by opichals):

 > I wonder how niche your use case is as it has worked this way since the
 beginning (d725cc9734272f867d41f7236235c28b3931a1b2).

 Indeed. We have seen it in production where our client had tried to upload
 files using Postman which includes also the unicode version of Content-
 Disposition filename which was more than 240 characters long effectively
 doubling the size of the header line itself which made it fail:
 {{{
 Content-Disposition: form-data; name="content"; filename="test.txt"
 filename*=UTF-8'test.txt'
 }}}

 > Maybe we could use a module constant for this 樂 e.g.
 django.http.multipartparser.MAX_HTTP_HEADER_LENGTH and set it initially to
 1024.

 Of course, going to adjust the PR.

 The name you're proposing seems like it could be confused with a single
 header line length limit.
 What about `django.http.multipartparser.MAX_TOTAL_HEADER_SIZE` (taken from
 https://github.com/openstack-archive/deb-python-
 eventlet/blob/master/eventlet/wsgi.py and also
 https://support.oracle.com/knowledge/Middleware/2302288_1.html)?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc87c0d18-3a1f490a-f2e1-4d77-9572-ab951c524d80-00%40eu-central-1.amazonses.com.


Re: [Django] #34968: MultiPartParser silent large header fields size failures

2023-11-13 Thread Django
#34968: MultiPartParser silent large header fields size failures
---+--
 Reporter:  opichals   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  HTTP handling  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Mariusz Felisiak):

 Thanks for the report. I wonder how niche your use case is as it has
 worked this way since the beginning
 (d725cc9734272f867d41f7236235c28b3931a1b2). Can it create a DoS vector
 attack? Maybe we could use a module constant for this 樂 e.g.
 `django.http.multipartparser.MAX_HTTP_HEADER_LENGTH` and set it initially
 to 1024.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc87312f2-982e6c46-7546-493c-93f3-e28c93129e44-00%40eu-central-1.amazonses.com.


Re: [Django] #34968: MultiPartParser silent large header fields size failures

2023-11-13 Thread Django
#34968: MultiPartParser silent large header fields size failures
---+--
 Reporter:  opichals   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  HTTP handling  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Description changed by opichals:

Old description:

> The `MultiPartParser` silently ignores parts of which the http header
> fields exceed 1024 bytes.
>
> This is caused by the 1024 value being hardcoded here
> https://github.com/django/django/blob/main/django/http/multipartparser.py#L743
>
> Here is a common http header fields limits across popular web servers
> (from https://stackoverflow.com/a/60623751/2448773):
>  * Apache - 8K
>  * Nginx - 4K-8K
>  * IIS - 8K-16K
>  * Tomcat - 8K – 48K
>  * Node (<13) - 8K; (>13) - 16K
>
> Also reported at https://stackoverflow.com/questions/70572148/django-
> silently-discarding-uploaded-files-with-long-paths

New description:

 The `MultiPartParser` silently ignores parts of which the http header
 fields exceed 1024 bytes. This causes file uploads to 'ignore' the
 attached file without receiving any type of error or exception.

 This is caused by the 1024 value being hardcoded here
 https://github.com/django/django/blob/main/django/http/multipartparser.py#L743

 Here is a common http header fields limits across popular web servers
 (from https://stackoverflow.com/a/60623751/2448773):
  * Apache - 8K
  * Nginx - 4K-8K
  * IIS - 8K-16K
  * Tomcat - 8K – 48K
  * Node (<13) - 8K; (>13) - 16K

 Also reported at https://stackoverflow.com/questions/70572148/django-
 silently-discarding-uploaded-files-with-long-paths

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc871692c-5c24b21e-b693-4249-b38c-7845d7288b86-00%40eu-central-1.amazonses.com.


Re: [Django] #34968: MultiPartParser silent large header fields size failures

2023-11-13 Thread Django
#34968: MultiPartParser silent large header fields size failures
---+--
 Reporter:  opichals   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  HTTP handling  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Description changed by opichals:

Old description:

> The `MultiPartParser` silently ignores parts of which the http header
> fields exceed 1024 bytes.
>
> This is caused by the 1024 value being hardcoded here
> https://github.com/django/django/blob/main/django/http/multipartparser.py#L743
>
> Also reported at https://stackoverflow.com/questions/70572148/django-
> silently-discarding-uploaded-files-with-long-paths

New description:

 The `MultiPartParser` silently ignores parts of which the http header
 fields exceed 1024 bytes.

 This is caused by the 1024 value being hardcoded here
 https://github.com/django/django/blob/main/django/http/multipartparser.py#L743

 Here is a common http header fields limits across popular web servers
 (from https://stackoverflow.com/a/60623751/2448773):
  * Apache - 8K
  * Nginx - 4K-8K
  * IIS - 8K-16K
  * Tomcat - 8K – 48K
  * Node (<13) - 8K; (>13) - 16K

 Also reported at https://stackoverflow.com/questions/70572148/django-
 silently-discarding-uploaded-files-with-long-paths

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc86dc64d-02057485-2b9a-4799-a534-b8914f1a5a40-00%40eu-central-1.amazonses.com.


[Django] #34968: MultiPartParser silent large header fields size failures

2023-11-13 Thread Django
#34968: MultiPartParser silent large header fields size failures
-+
   Reporter:  opichals   |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  HTTP handling  |Version:  4.2
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 The `MultiPartParser` silently ignores parts of which the http header
 fields exceed 1024 bytes.

 This is caused by the 1024 value being hardcoded here
 https://github.com/django/django/blob/main/django/http/multipartparser.py#L743

 Also reported at https://stackoverflow.com/questions/70572148/django-
 silently-discarding-uploaded-files-with-long-paths

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc869f0f5-64b7dcd7-3d33-4b4f-82b3-de8a57abfd43-00%40eu-central-1.amazonses.com.


Re: [Django] #34967: Queries not generating GROUP BY clause with static annotation crashes on SQLite

2023-11-13 Thread Django
#34967: Queries not generating GROUP BY clause with static annotation crashes on
SQLite
-+-
 Reporter:  Simon Legtenborg |Owner:  David
 |  Sanders
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc8604b57-ca212d41-2625-48a7-bbd6-05c9859bbddd-00%40eu-central-1.amazonses.com.


Re: [Django] #34919: Missing scope attribute in admin doc table headers.

2023-11-13 Thread Django
#34919: Missing scope attribute in admin doc table headers.
-+-
 Reporter:  Louis-Cloud  |Owner:  jed212
 Type:  Bug  |   Status:  assigned
Component:  contrib.admindocs|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  table, scope,| Triage Stage:  Accepted
  screenreader, accessibility|
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc83657b4-45d789ce-638e-400c-97a8-658e2bb360ca-00%40eu-central-1.amazonses.com.


Re: [Django] #34958: Intermittent `messages_tests.tests.TestLevelTags.test_lazy` test failure

2023-11-13 Thread Django
#34958: Intermittent `messages_tests.tests.TestLevelTags.test_lazy` test failure
-+-
 Reporter:  bcail|Owner:  Natalia
 |  Bidart
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"7a21ea5464b61a8fcd43cd1b9b5f99c94687600a" 7a21ea5]:
 {{{
 #!CommitTicketReference repository=""
 revision="7a21ea5464b61a8fcd43cd1b9b5f99c94687600a"
 [5.0.x] Fixed #34958 -- Fixed isolation of
 messages_tests.tests.TestLevelTags.test_lazy.

 Backport of 1b56b24f81a2e64b4bd3059abad9b6fd0c801c66 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc7d4dee5-a65f0403-cbbc-489b-9c2e-d04d90474ba2-00%40eu-central-1.amazonses.com.


Re: [Django] #34958: Intermittent `messages_tests.tests.TestLevelTags.test_lazy` test failure

2023-11-13 Thread Django
#34958: Intermittent `messages_tests.tests.TestLevelTags.test_lazy` test failure
-+-
 Reporter:  bcail|Owner:  Natalia
 |  Bidart
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"1b56b24f81a2e64b4bd3059abad9b6fd0c801c66" 1b56b24]:
 {{{
 #!CommitTicketReference repository=""
 revision="1b56b24f81a2e64b4bd3059abad9b6fd0c801c66"
 Fixed #34958 -- Fixed isolation of
 messages_tests.tests.TestLevelTags.test_lazy.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc7d2ce77-2ef64049-c39f-4ce1-acae-ead1a90876e3-00%40eu-central-1.amazonses.com.


Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

2023-11-13 Thread Django
#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  Vageeshan Mankala|Owner:  vageeshan
 Type:  Bug  |   Status:  assigned
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Jon Janzen (added)
 * needs_better_patch:  1 => 0
 * component:  Uncategorized => Core (Other)


Comment:

 #31949

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc7ca81d6-5ff1b231-e062-4fed-8143-46d2eb6a9690-00%40eu-central-1.amazonses.com.