Re: [E-devel] Propose a Eina_Path
Em sexta-feira, 11 de novembro de 2016, Hermet Park escreveu: > Hello everyone. > > Currently, I'm trying a prototype - Path Object using the evas map. > (specifically for a scenario, text on path). > It looks nice if it works on gl backend. (i will share the result later) > > But before we talk about path object stuff, I wanna propose a Eina_Path. > > After reviewed efl_gfx_shape interface again, > I realized path interface should be moved out from the efl_gfx_shape > interface so that Path Object also utilize the path stuff. > > Curently, efl_gfx_shape has more than path functionalities such as a > stroke, > > I think path stuff can become a more generic function set. > So, I'd like to move the path stuff into Eina. > > If then, path object will be able to utilize the Eina Path and > efl_gfx_shape will do also. > > ie) > Eina_Path *path = eina_path_add(); > eina_path_append_move_to(path, xxx); > eina_path_append_line_to(path, xxx); > eina_path_append_xxx (...); > > ... > > efl_gfx_shape_path_set(shape, path); > > also, > > elm_path_object_path_set(obj, path); > > If you agree on this, I will work on this stuff soon. > > Any objections? The name. I started to read this email thinking abou file path. :-) But as for moving it to eina, I don't think it's the right place. Eina has no other similar primitive. > > -- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Propose a Eina_Path
Maybe name could be other one. But I don't think bezier_curve, matrix are not much far from this path. -Original Message- From: "Gustavo Sverzut Barbieri" To: "Enlightenment developer list"; Cc: Sent: 2016-11-11 (금) 17:00:15 Subject: Re: [E-devel] Propose a Eina_Path Em sexta-feira, 11 de novembro de 2016, Hermet Park escreveu: > Hello everyone. > > Currently, I'm trying a prototype - Path Object using the evas map. > (specifically for a scenario, text on path). > It looks nice if it works on gl backend. (i will share the result later) > > But before we talk about path object stuff, I wanna propose a Eina_Path. > > After reviewed efl_gfx_shape interface again, > I realized path interface should be moved out from the efl_gfx_shape > interface so that Path Object also utilize the path stuff. > > Curently, efl_gfx_shape has more than path functionalities such as a > stroke, > > I think path stuff can become a more generic function set. > So, I'd like to move the path stuff into Eina. > > If then, path object will be able to utilize the Eina Path and > efl_gfx_shape will do also. > > ie) > Eina_Path *path = eina_path_add(); > eina_path_append_move_to(path, xxx); > eina_path_append_line_to(path, xxx); > eina_path_append_xxx (...); > > ... > > efl_gfx_shape_path_set(shape, path); > > also, > > elm_path_object_path_set(obj, path); > > If you agree on this, I will work on this stuff soon. > > Any objections? The name. I started to read this email thinking abou file path. :-) But as for moving it to eina, I don't think it's the right place. Eina has no other similar primitive. > > -- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Propose a Eina_Path
The name makes sense in a graphical context. Therefore if it can be somewhere less general than Eina then it could make sense. Andy On Fri, 11 Nov 2016 at 08:00, Gustavo Sverzut Barbieri wrote: > Em sexta-feira, 11 de novembro de 2016, Hermet Park > escreveu: > > > Hello everyone. > > > > Currently, I'm trying a prototype - Path Object using the evas map. > > (specifically for a scenario, text on path). > > It looks nice if it works on gl backend. (i will share the result later) > > > > But before we talk about path object stuff, I wanna propose a Eina_Path. > > > > After reviewed efl_gfx_shape interface again, > > I realized path interface should be moved out from the efl_gfx_shape > > interface so that Path Object also utilize the path stuff. > > > > Curently, efl_gfx_shape has more than path functionalities such as a > > stroke, > > > > I think path stuff can become a more generic function set. > > So, I'd like to move the path stuff into Eina. > > > > If then, path object will be able to utilize the Eina Path and > > efl_gfx_shape will do also. > > > > ie) > > Eina_Path *path = eina_path_add(); > > eina_path_append_move_to(path, xxx); > > eina_path_append_line_to(path, xxx); > > eina_path_append_xxx (...); > > > > ... > > > > efl_gfx_shape_path_set(shape, path); > > > > also, > > > > elm_path_object_path_set(obj, path); > > > > If you agree on this, I will work on this stuff soon. > > > > Any objections? > > > The name. I started to read this email thinking abou file path. :-) > > But as for moving it to eina, I don't think it's the right place. Eina has > no other similar primitive. > > > > > > > -- > > Developer Access Program for Intel Xeon Phi Processors > > Access to Intel Xeon Phi processor-based developer platforms. > > With one year of Intel Parallel Studio XE. > > Training and support from Colfax. > > Order your platform today. http://sdm.link/xeonphi > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > Gustavo Sverzut Barbieri > -- > Mobile: +55 (16) 99354-9890 > > -- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] FW: Propose a Eina_Path
Yes, but I have no idea about proper place than eina atm. I feel like It's more close to an data structure & utility function than interface. Any idea? -Original Message- From: "Andrew Williams" To: "Enlightenment developer list"; Cc: Sent: 2016-11-11 (금) 17:31:04 Subject: Re: [E-devel] Propose a Eina_Path The name makes sense in a graphical context. Therefore if it can be somewhere less general than Eina then it could make sense. Andy On Fri, 11 Nov 2016 at 08:00, Gustavo Sverzut Barbieri wrote: > Em sexta-feira, 11 de novembro de 2016, Hermet Park > escreveu: > > > Hello everyone. > > > > Currently, I'm trying a prototype - Path Object using the evas map. > > (specifically for a scenario, text on path). > > It looks nice if it works on gl backend. (i will share the result later) > > > > But before we talk about path object stuff, I wanna propose a Eina_Path. > > > > After reviewed efl_gfx_shape interface again, > > I realized path interface should be moved out from the efl_gfx_shape > > interface so that Path Object also utilize the path stuff. > > > > Curently, efl_gfx_shape has more than path functionalities such as a > > stroke, > > > > I think path stuff can become a more generic function set. > > So, I'd like to move the path stuff into Eina. > > > > If then, path object will be able to utilize the Eina Path and > > efl_gfx_shape will do also. > > > > ie) > > Eina_Path *path = eina_path_add(); > > eina_path_append_move_to(path, xxx); > > eina_path_append_line_to(path, xxx); > > eina_path_append_xxx (...); > > > > ... > > > > efl_gfx_shape_path_set(shape, path); > > > > also, > > > > elm_path_object_path_set(obj, path); > > > > If you agree on this, I will work on this stuff soon. > > > > Any objections? > > > The name. I started to read this email thinking abou file path. :-) > > But as for moving it to eina, I don't think it's the right place. Eina has > no other similar primitive. > > > > > > > -- > > Developer Access Program for Intel Xeon Phi Processors > > Access to Intel Xeon Phi processor-based developer platforms. > > With one year of Intel Parallel Studio XE. > > Training and support from Colfax. > > Order your platform today. http://sdm.link/xeonphi > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > Gustavo Sverzut Barbieri > -- > Mobile: +55 (16) 99354-9890 > > -- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] FW: Propose a Eina_Path
Alongside Evas_Rect and Evas_Line? On Fri, 11 Nov 2016 at 08:59, Hermet Park wrote: > Yes, but I have no idea about proper place than eina atm. > > I feel like It's more close to an data structure & utility function than > interface. > > Any idea? > > -Original Message- > From: "Andrew Williams" > To: "Enlightenment developer list"< > enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2016-11-11 (금) 17:31:04 > Subject: Re: [E-devel] Propose a Eina_Path > > The name makes sense in a graphical context. Therefore if it can be > somewhere less general than Eina then it could make sense. > > Andy > > On Fri, 11 Nov 2016 at 08:00, Gustavo Sverzut Barbieri > > wrote: > > > Em sexta-feira, 11 de novembro de 2016, Hermet Park > > > escreveu: > > > > > Hello everyone. > > > > > > Currently, I'm trying a prototype - Path Object using the evas map. > > > (specifically for a scenario, text on path). > > > It looks nice if it works on gl backend. (i will share the result > later) > > > > > > But before we talk about path object stuff, I wanna propose a > Eina_Path. > > > > > > After reviewed efl_gfx_shape interface again, > > > I realized path interface should be moved out from the efl_gfx_shape > > > interface so that Path Object also utilize the path stuff. > > > > > > Curently, efl_gfx_shape has more than path functionalities such as a > > > stroke, > > > > > > I think path stuff can become a more generic function set. > > > So, I'd like to move the path stuff into Eina. > > > > > > If then, path object will be able to utilize the Eina Path and > > > efl_gfx_shape will do also. > > > > > > ie) > > > Eina_Path *path = eina_path_add(); > > > eina_path_append_move_to(path, xxx); > > > eina_path_append_line_to(path, xxx); > > > eina_path_append_xxx (...); > > > > > > ... > > > > > > efl_gfx_shape_path_set(shape, path); > > > > > > also, > > > > > > elm_path_object_path_set(obj, path); > > > > > > If you agree on this, I will work on this stuff soon. > > > > > > Any objections? > > > > > > The name. I started to read this email thinking abou file path. :-) > > > > But as for moving it to eina, I don't think it's the right place. Eina > has > > no other similar primitive. > > > > > > > > > > > > -- > > > Developer Access Program for Intel Xeon Phi Processors > > > Access to Intel Xeon Phi processor-based developer platforms. > > > With one year of Intel Parallel Studio XE. > > > Training and support from Colfax. > > > Order your platform today. http://sdm.link/xeonphi > > > ___ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > -- > > Gustavo Sverzut Barbieri > > -- > > Mobile: +55 (16) 99354-9890 > > > > > -- > > Developer Access Program for Intel Xeon Phi Processors > > Access to Intel Xeon Phi processor-based developer platforms. > > With one year of Intel Parallel Studio XE. > > Training and support from Colfax. > > Order your platform today. http://sdm.link/xeonphi > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > -- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sour
[E-devel] FW: FW: Propose a Eina_Path
Thanks for your advice. But imo, it's unlike to graphical one such as evas_rect and evas_line... Path itself is more likely to the eina_rect... Because path itself is just data information. Also, efl_gfx_shape should rely on it. -Original Message- From: "Andrew Williams" To: "Enlightenment developer list"; Cc: Sent: 2016-11-11 (금) 20:07:44 Subject: Re: [E-devel] FW: Propose a Eina_Path Alongside Evas_Rect and Evas_Line? On Fri, 11 Nov 2016 at 08:59, Hermet Park wrote: > Yes, but I have no idea about proper place than eina atm. > > I feel like It's more close to an data structure & utility function than > interface. > > Any idea? > > -Original Message- > From: "Andrew Williams" > To: "Enlightenment developer list"< > enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2016-11-11 (금) 17:31:04 > Subject: Re: [E-devel] Propose a Eina_Path > > The name makes sense in a graphical context. Therefore if it can be > somewhere less general than Eina then it could make sense. > > Andy > > On Fri, 11 Nov 2016 at 08:00, Gustavo Sverzut Barbieri > > wrote: > > > Em sexta-feira, 11 de novembro de 2016, Hermet Park > > > escreveu: > > > > > Hello everyone. > > > > > > Currently, I'm trying a prototype - Path Object using the evas map. > > > (specifically for a scenario, text on path). > > > It looks nice if it works on gl backend. (i will share the result > later) > > > > > > But before we talk about path object stuff, I wanna propose a > Eina_Path. > > > > > > After reviewed efl_gfx_shape interface again, > > > I realized path interface should be moved out from the efl_gfx_shape > > > interface so that Path Object also utilize the path stuff. > > > > > > Curently, efl_gfx_shape has more than path functionalities such as a > > > stroke, > > > > > > I think path stuff can become a more generic function set. > > > So, I'd like to move the path stuff into Eina. > > > > > > If then, path object will be able to utilize the Eina Path and > > > efl_gfx_shape will do also. > > > > > > ie) > > > Eina_Path *path = eina_path_add(); > > > eina_path_append_move_to(path, xxx); > > > eina_path_append_line_to(path, xxx); > > > eina_path_append_xxx (...); > > > > > > ... > > > > > > efl_gfx_shape_path_set(shape, path); > > > > > > also, > > > > > > elm_path_object_path_set(obj, path); > > > > > > If you agree on this, I will work on this stuff soon. > > > > > > Any objections? > > > > > > The name. I started to read this email thinking abou file path. :-) > > > > But as for moving it to eina, I don't think it's the right place. Eina > has > > no other similar primitive. > > > > > > > > > > > > -- > > > Developer Access Program for Intel Xeon Phi Processors > > > Access to Intel Xeon Phi processor-based developer platforms. > > > With one year of Intel Parallel Studio XE. > > > Training and support from Colfax. > > > Order your platform today. http://sdm.link/xeonphi > > > ___ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > -- > > Gustavo Sverzut Barbieri > > -- > > Mobile: +55 (16) 99354-9890 > > > > > -- > > Developer Access Program for Intel Xeon Phi Processors > > Access to Intel Xeon Phi processor-based developer platforms. > > With one year of Intel Parallel Studio XE. > > Training and support from Colfax. > > Order your platform today. http://sdm.link/xeonphi > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > -- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ---
[EGIT] [apps/terminology] master 01/01: termiolink: add missing break
billiob pushed a commit to branch master. http://git.enlightenment.org/apps/terminology.git/commit/?id=234fe507f4d5f2e0b2789408018df0433302b8a9 commit 234fe507f4d5f2e0b2789408018df0433302b8a9 Author: Boris Faure Date: Fri Nov 11 12:38:54 2016 +0100 termiolink: add missing break --- src/bin/termiolink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/bin/termiolink.c b/src/bin/termiolink.c index c810c65..a54763d 100644 --- a/src/bin/termiolink.c +++ b/src/bin/termiolink.c @@ -240,6 +240,7 @@ termio_link_find(Evas_Object *obj, int cx, int cy, { goback = EINA_FALSE; goforward = EINA_TRUE; + break; } res = ty_sb_prepend(&sb, txt, txtlen); if (res < 0) goto end; --
Re: [E-devel] FW: FW: Propose a Eina_Path
It strange that eina defines a rectangle and no other shapes - is that even used outside a graphical context? A On Fri, 11 Nov 2016 at 11:17, Hermet Park wrote: > Thanks for your advice. > > But imo, it's unlike to graphical one such as evas_rect and evas_line... > Path itself is more likely to the eina_rect... > Because path itself is just data information. > Also, efl_gfx_shape should rely on it. > > -Original Message- > From: "Andrew Williams" > To: "Enlightenment developer list"< > enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2016-11-11 (금) 20:07:44 > Subject: Re: [E-devel] FW: Propose a Eina_Path > > Alongside Evas_Rect and Evas_Line? > > On Fri, 11 Nov 2016 at 08:59, Hermet Park wrote: > > > Yes, but I have no idea about proper place than eina atm. > > > > I feel like It's more close to an data structure & utility function than > > interface. > > > > Any idea? > > > > -Original Message- > > From: "Andrew Williams" > > To: "Enlightenment developer list"< > > enlightenment-devel@lists.sourceforge.net>; > > Cc: > > Sent: 2016-11-11 (금) 17:31:04 > > Subject: Re: [E-devel] Propose a Eina_Path > > > > The name makes sense in a graphical context. Therefore if it can be > > somewhere less general than Eina then it could make sense. > > > > Andy > > > > On Fri, 11 Nov 2016 at 08:00, Gustavo Sverzut Barbieri < > barbi...@gmail.com > > > > > wrote: > > > > > Em sexta-feira, 11 de novembro de 2016, Hermet Park < > her...@hermet.pe.kr > > > > > > escreveu: > > > > > > > Hello everyone. > > > > > > > > Currently, I'm trying a prototype - Path Object using the evas map. > > > > (specifically for a scenario, text on path). > > > > It looks nice if it works on gl backend. (i will share the result > > later) > > > > > > > > But before we talk about path object stuff, I wanna propose a > > Eina_Path. > > > > > > > > After reviewed efl_gfx_shape interface again, > > > > I realized path interface should be moved out from the efl_gfx_shape > > > > interface so that Path Object also utilize the path stuff. > > > > > > > > Curently, efl_gfx_shape has more than path functionalities such as a > > > > stroke, > > > > > > > > I think path stuff can become a more generic function set. > > > > So, I'd like to move the path stuff into Eina. > > > > > > > > If then, path object will be able to utilize the Eina Path and > > > > efl_gfx_shape will do also. > > > > > > > > ie) > > > > Eina_Path *path = eina_path_add(); > > > > eina_path_append_move_to(path, xxx); > > > > eina_path_append_line_to(path, xxx); > > > > eina_path_append_xxx (...); > > > > > > > > ... > > > > > > > > efl_gfx_shape_path_set(shape, path); > > > > > > > > also, > > > > > > > > elm_path_object_path_set(obj, path); > > > > > > > > If you agree on this, I will work on this stuff soon. > > > > > > > > Any objections? > > > > > > > > > The name. I started to read this email thinking abou file path. :-) > > > > > > But as for moving it to eina, I don't think it's the right place. Eina > > has > > > no other similar primitive. > > > > > > > > > > > > > > > > > -- > > > > Developer Access Program for Intel Xeon Phi Processors > > > > Access to Intel Xeon Phi processor-based developer platforms. > > > > With one year of Intel Parallel Studio XE. > > > > Training and support from Colfax. > > > > Order your platform today. http://sdm.link/xeonphi > > > > ___ > > > > enlightenment-devel mailing list > > > > enlightenment-devel@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > > > -- > > > Gustavo Sverzut Barbieri > > > -- > > > Mobile: +55 (16) 99354-9890 > > > > > > > > > -- > > > Developer Access Program for Intel Xeon Phi Processors > > > Access to Intel Xeon Phi processor-based developer platforms. > > > With one year of Intel Parallel Studio XE. > > > Training and support from Colfax. > > > Order your platform today. http://sdm.link/xeonphi > > > ___ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > -- > > Developer Access Program for Intel Xeon Phi Processors > > Access to Intel Xeon Phi processor-based developer platforms. > > With one year of Intel Parallel Studio XE. > > Training and support from Colfax. > > Order your platform today. http://sdm.link/xeonphi > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > ---
Re: [E-devel] EFL packaging on Debian
On Thu, Nov 10, 2016 at 11:06:04AM +0100, Stefan Schmidt wrote: > I did my monthly packaging update again and was hoping this moved to > unstable by now. It is still in experimental only as far as I can see. > Is there an automatic way this packages get from experimental to > unstable, testing stable? Or are you supposed to pursue Albin again to > get it uploaded to unstable? A few items on the current status: 1) All uploads will go through Albin (or some other sponsor). While reviewing, Albin had some questions on the internal EFL deps and shared symbol versioning. The packaging produces unusually strict (for Debian) dependencies. We're working through it. 2) experimental -> unstable is a manual migration. Once in unstable, packages automatically migrate to testing, and then to the next stable release. Packages are not normally added to existing stable releases. We uploaded to experimental for additional testing opportunity, since Debian contains packages which depend on EFL. When we're happy with the status, they'll be uploaded to unstable. 3) The packages in experimental break binary compatability with the existing unstable packages. For instance, you can't use the experimental packages break the terminology packages in unstable. (Why? The packages in unstable preserve a bit of pre-1.0 eina ABI that was released into Debian many years ago. That requires disabling magic debug, and in EFL 1.17 tests break with this config. We decided the eina tests are more valuable than the ancient ABI.) So it's going to take some time - sorry. Ross -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] how to configure touchpad like in Xorg
In fedora 24 i have enlightenment under xorgs and need to create config for my synaptcis touchpad to enable tap clicking and other stuff. Now in fedora 25 by default enlightenment runs under Xwayland (may be i need something change in gdm config to enable native wayland?). As i see Xwayland not write logfile under /var/log/Xorg.log, and my config for touchpad not works. So my question is: why enlightenment does not contains module to control basic touchpad features like finger scrolling and tap clickng? And second - how to fix my issue with touchpad now? Thanks! /etc/X11/xorg.conf.d/01-touchpad.conf Section "InputClass" Identifier "touchpad" Driver "synaptics" MatchIsTouchpad "on" Option "TapButton1" "1" Option "TapButton2" "2" Option "TapButton3" "3" Option "VertEdgeScroll" "on" Option "VertTwoFingerScroll" "on" Option "HorizEdgeScroll" "on" Option "HorizTwoFingerScroll" "on" Option "CircularScrolling" "on" Option "CircScrollTrigger" "2" Option "EmulateTwoFingerMinZ" "40" Option "EmulateTwoFingerMinW" "8" Option "CoastingSpeed" "0" Option "FingerLow" "30" Option "FingerHigh" "50" Option "MaxTapTime" "125" EndSection -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 06/12: docs: module: add some missing docs in our modules using eo
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=1976a0295162ce2e30401605a9bb614c7b219610 commit 1976a0295162ce2e30401605a9bb614c7b219610 Author: Stefan Schmidt Date: Fri Nov 11 10:59:08 2016 +0100 docs: module: add some missing docs in our modules using eo --- src/modules/elementary/web/none/elm_web_none.eo | 1 + src/modules/evas/engines/gl_generic/evas_ector_gl_buffer.eo | 1 + 2 files changed, 2 insertions(+) diff --git a/src/modules/elementary/web/none/elm_web_none.eo b/src/modules/elementary/web/none/elm_web_none.eo index 65d29aa..ad7b89b 100644 --- a/src/modules/elementary/web/none/elm_web_none.eo +++ b/src/modules/elementary/web/none/elm_web_none.eo @@ -1,5 +1,6 @@ class Elm.Web.None (Elm.Web) { + [[Elementary web module class]] implements { Efl.Canvas.Group.group_add; Elm.Web.tab_propagate.get; diff --git a/src/modules/evas/engines/gl_generic/evas_ector_gl_buffer.eo b/src/modules/evas/engines/gl_generic/evas_ector_gl_buffer.eo index a03cb9e..417ee53 100644 --- a/src/modules/evas/engines/gl_generic/evas_ector_gl_buffer.eo +++ b/src/modules/evas/engines/gl_generic/evas_ector_gl_buffer.eo @@ -1,4 +1,5 @@ class Evas.Ector.GL.Buffer (Efl.Object, Evas.Ector.Buffer, Ector.GL.Buffer.Base) { + [[Evas ector GL buffer class]] data: null; } --
[EGIT] [core/efl] master 04/12: docs: edje: finish up eo file docs for edje
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=e056e0b1d1ee26175f8d2b05554bdf2d9f48c868 commit e056e0b1d1ee26175f8d2b05554bdf2d9f48c868 Author: Stefan Schmidt Date: Fri Nov 11 10:25:33 2016 +0100 docs: edje: finish up eo file docs for edje --- src/lib/edje/edje_object.eo| 95 +++--- src/lib/edje/efl_canvas_layout_internal.eo | 6 +- 2 files changed, 51 insertions(+), 50 deletions(-) diff --git a/src/lib/edje/edje_object.eo b/src/lib/edje/edje_object.eo index 1d53b30..66269d3 100644 --- a/src/lib/edje/edje_object.eo +++ b/src/lib/edje/edje_object.eo @@ -3,6 +3,7 @@ import edje_types; class Edje.Object (Efl.Canvas.Group.Clipped, Efl.File, Efl.Container, Efl.Part, Efl.Observer) { + [[Edje object class]] legacy_prefix: edje_object; eo_prefix: edje_obj; event_prefix: edje_object; @@ -38,7 +39,7 @@ class Edje.Object (Efl.Canvas.Group.Clipped, Efl.File, Efl.Container, Efl.Part, @since 1.1.0]] } values { -rtl: bool; [[new value of flag $true/$false]] +rtl: bool; [[New value of flag $true/$false]] } } @property language { @@ -168,7 +169,7 @@ class Edje.Object (Efl.Canvas.Group.Clipped, Efl.File, Efl.Container, Efl.Part, See also @.scale.get() \@ref edje_scale_get() for more details]] -return: bool; +return: bool; [[$true on success, $false otherwise]] } get { [[Get a given Edje object's scaling factor. @@ -379,7 +380,7 @@ class Edje.Object (Efl.Canvas.Group.Clipped, Efl.File, Efl.Container, Efl.Part, Note: On failure, this function will make all non-$null geometry pointers' pointed variables be set to zero.]] - return: bool; + return: bool; [[$true on success, $false otherwise]] params { @out x: Evas.Coord; [[A pointer to a variable where to store the parts region's x coordinate]] @@ -634,7 +635,7 @@ class Edje.Object (Efl.Canvas.Group.Clipped, Efl.File, Efl.Container, Efl.Part, Note: unlike Evas, Edje colors are not pre-multiplied. That is, half-transparent white is 255 255 255 128.]] legacy: null; -return: bool; [[$true on sucess, $false on failure.]] +return: bool; [[$true on success, $false otherwise]] } get { [[Get Edje color class. @@ -654,7 +655,7 @@ class Edje.Object (Efl.Canvas.Group.Clipped, Efl.File, Efl.Container, Efl.Part, } keys { color_class: string; [[The name of color class]] -mode: Edje.Color_Class.Mode; +mode: Edje.Color_Class.Mode; [[Edje color class mode]] } values { r: int; [[Object Red value]] @@ -682,7 +683,7 @@ class Edje.Object (Efl.Canvas.Group.Clipped, Efl.File, Efl.Container, Efl.Part, Note: unlike Evas, Edje colors are not pre-multiplied. That is, half-transparent white is 255 255 255 128.]] legacy: null; -return: bool; +return: bool; [[$true on success, $false otherwise]] } get { [[Gets the object color class. @@ -703,7 +704,7 @@ class Edje.Object (Efl.Canvas.Group.Clipped, Efl.File, Efl.Container, Efl.Part, } keys { color_class: string; [[The name of color class]] -mode: Edje.Color_Class.Mode; +mode: Edje.Color_Class.Mode; [[Edje color class mode]] } values { r: int; [[Object Red value]] @@ -720,7 +721,7 @@ class Edje.Object (Efl.Canvas.Group.Clipped, Efl.File, Efl.Container, Efl.Part, return: string; [[The description of the target color class or $null if not found]] } keys { -color_class: string; +color_class: string; [[Color class description]] } } color_class_clear @const { @@ -826,13 +827,13 @@ class Edje.Object (Efl.Canvas.Group.Clipped, Efl.File, Efl.Container, Efl.Part, @since 1.17]] params { -@in size_class: string; +@in size_class: string; [[Size class name]] } } access_part_iterate { [[Iterate over all accessibility-enabled part names.]] legacy: null; - return: free(own(iterator), eina_iterator_free); + return: free(own(iterator), eina_iterator_free); [[Part name iterator]] } part_exists @const { [[Check if an Edje part exists in a given Edje object's group @@ -886,7 +887,7 @@ class Edje.Object (Efl.Canvas.Group.Clipped, Efl.File, Efl.Container, Efl.Part, part: string; [[The part name]] } values { -val_ret: double; +val_re
[EGIT] [core/efl] master 09/12: docs: efl_net_dialer: add missing docs for efl_net_dialer
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=44b3fb5ebc29076de041703eb1417611ddc3f85a commit 44b3fb5ebc29076de041703eb1417611ddc3f85a Author: Stefan Schmidt Date: Fri Nov 11 15:33:18 2016 +0100 docs: efl_net_dialer: add missing docs for efl_net_dialer --- src/lib/ecore_con/efl_net_dialer.eo | 12 +++--- src/lib/ecore_con/efl_net_dialer_http.eo | 46 ++-- src/lib/ecore_con/efl_net_dialer_ssl.eo | 6 +-- src/lib/ecore_con/efl_net_dialer_websocket.eo | 60 +-- 4 files changed, 62 insertions(+), 62 deletions(-) diff --git a/src/lib/ecore_con/efl_net_dialer.eo b/src/lib/ecore_con/efl_net_dialer.eo index e93fb2d..f9d6d02 100644 --- a/src/lib/ecore_con/efl_net_dialer.eo +++ b/src/lib/ecore_con/efl_net_dialer.eo @@ -32,9 +32,9 @@ interface Efl.Net.Dialer (Efl.Net.Socket) { dispatched. ]] params { -address: string @nonull; +address: string @nonull; [[Remote address]] } -return: Eina.Error; +return: Eina.Error; [[0 on success, error code otherwise]] } @property address_dial { @@ -47,7 +47,7 @@ interface Efl.Net.Dialer (Efl.Net.Socket) { get { } set @protected { } values { -address: string; +address: string; [[Remote address]] } } @@ -60,7 +60,7 @@ interface Efl.Net.Dialer (Efl.Net.Socket) { get { } set @protected { } values { -connected: bool; +connected: bool; [[$true if the socket is connected, $false otherwise]] } } @@ -94,7 +94,7 @@ interface Efl.Net.Dialer (Efl.Net.Socket) { get { } set { } values { -proxy_url: string; [[may be empty or NULL to unset]] +proxy_url: string; [[May be empty or NULL to unset]] } } @@ -106,7 +106,7 @@ interface Efl.Net.Dialer (Efl.Net.Socket) { get { } set { } values { -seconds: double; +seconds: double; [[Timeout value is seconds]] } } } diff --git a/src/lib/ecore_con/efl_net_dialer_http.eo b/src/lib/ecore_con/efl_net_dialer_http.eo index b8c327d..f3c331a 100644 --- a/src/lib/ecore_con/efl_net_dialer_http.eo +++ b/src/lib/ecore_con/efl_net_dialer_http.eo @@ -62,7 +62,7 @@ class Efl.Net.Dialer.Http (Efl.Loop_User, Efl.Net.Dialer, Efl.Io.Sizer) { get { } set { } values { -method: string; +method: string; [[HTTP method]] } } @@ -107,7 +107,7 @@ class Efl.Net.Dialer.Http (Efl.Loop_User, Efl.Net.Dialer, Efl.Io.Sizer) { } set { } values { -primary_mode: Efl.Net.Dialer.Http.Primary_Mode; +primary_mode: Efl.Net.Dialer.Http.Primary_Mode; [[Primary HTTP mode]] } } @@ -119,7 +119,7 @@ class Efl.Net.Dialer.Http (Efl.Loop_User, Efl.Net.Dialer, Efl.Io.Sizer) { get { } set { } values { -user_agent: string; +ser_agent: string; [[User-agent]] } } @@ -134,7 +134,7 @@ class Efl.Net.Dialer.Http (Efl.Loop_User, Efl.Net.Dialer, Efl.Io.Sizer) { get { } set { } values { -http_version: Efl.Net.Http.Version; +http_version: Efl.Net.Http.Version; [[HTTP version]] } } @@ -146,10 +146,10 @@ class Efl.Net.Dialer.Http (Efl.Loop_User, Efl.Net.Dialer, Efl.Io.Sizer) { get { } set { } values { -username: string; -password: string; -method: Efl.Net.Http.Authentication_Method @optional; [[authentication method to use, defaults to @Efl.Net.Http.Authentication_Method.basic]] -restricted: bool @optional; [[restrict method]] +username: string; [[HTTP authentication username]] +password: string; [[HTTP authentication password]] +method: Efl.Net.Http.Authentication_Method @optional; [[Authentication method to use, defaults to @Efl.Net.Http.Authentication_Method.basic]] +restricted: bool @optional; [[Restrict method]] } } @@ -161,7 +161,7 @@ class Efl.Net.Dialer.Http (Efl.Loop_User, Efl.Net.Dialer, Efl.Io.Sizer) { get { } set { } values { -allow_redirects: bool; +allow_redirects: bool; [[$true if redirects are followed, $false otherwise]] } } @@ -173,8 +173,8 @@ class Efl.Net.Dialer.Http (Efl.Loop_User, Efl.Net.Dialer, Efl.Io.Sizer) {
[EGIT] [core/efl] master 02/12: docs: eio: finish up missing eo file docs in eio
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=124effc5244658b05b5df6f6265cb0aa4297a119 commit 124effc5244658b05b5df6f6265cb0aa4297a119 Author: Stefan Schmidt Date: Fri Nov 11 09:15:24 2016 +0100 docs: eio: finish up missing eo file docs in eio --- src/lib/eio/efl_io_manager.eo | 16 src/lib/eio/eio_sentry.eo | 28 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/src/lib/eio/efl_io_manager.eo b/src/lib/eio/efl_io_manager.eo index 94c72bc..25756fa 100644 --- a/src/lib/eio/efl_io_manager.eo +++ b/src/lib/eio/efl_io_manager.eo @@ -42,7 +42,7 @@ class Efl.Io.Manager (Efl.Loop_User) xattr_ls { [[Lists all extended attributes asynchronously.]] params { - @in path: string;[[Path we want to list entries for]] + @in path: string; [[Path we want to list entries for]] } return: future)>; [[Extended attributes]] } @@ -60,17 +60,17 @@ class Efl.Io.Manager (Efl.Loop_User) [[Retrieves or sets information of a given extended attribute.]] set { values { -data: ptr(Eina.Binbuf); -flags: Eina.Xattr.Flags; +data: ptr(Eina.Binbuf); [[Data to set as information]] +flags: Eina.Xattr.Flags; [[Extended attributes flags]] } - return: future; + return: future; [[Future for asynchronous set operation]] } get { - return: future; + return: future; [[Information]] } keys { - path: string; -attribute: string; + path: string; [[File path]] +attribute: string; [[Attribute name]] } } @@ -91,7 +91,7 @@ class Efl.Io.Manager (Efl.Loop_User) @in file: ptr(Eina.File); [[Eina file handle]] // Here we're just interested whether the promise was fullfilled or not. No value needed. } - return: future; + return: future; [[Close return code]] } } } diff --git a/src/lib/eio/eio_sentry.eo b/src/lib/eio/eio_sentry.eo index 8948358..9f2add7 100644 --- a/src/lib/eio/eio_sentry.eo +++ b/src/lib/eio/eio_sentry.eo @@ -15,29 +15,29 @@ class Eio.Sentry (Efl.Object) add { [[Adds a new path to the list of monitored paths.]] params { -@in path: string; +@in path: string; [[Path to monitor]] } - return : bool; + return : bool; [[$true on success, $false otherwise]] } del { [[Removes the given path from the monitored list.]] params { -@in path: string; +@in path: string; [[Path to remove from monitoring]] } } } events { -file,created: Eio.Sentry.Event; -file,deleted: Eio.Sentry.Event; -file,modified: Eio.Sentry.Event; -file,closed: Eio.Sentry.Event; -directory,created: Eio.Sentry.Event; -directory,deleted: Eio.Sentry.Event; -directory,modified: Eio.Sentry.Event; -directory,closed: Eio.Sentry.Event; -self,rename: Eio.Sentry.Event; -self,deleted: Eio.Sentry.Event; -error: Eio.Sentry.Event; +file,created: Eio.Sentry.Event; [[Called when a file was created]] +file,deleted: Eio.Sentry.Event; [[Called when a file was deleted]] +file,modified: Eio.Sentry.Event; [[Called when a file was modified]] +file,closed: Eio.Sentry.Event; [[Called when a file was closed]] +directory,created: Eio.Sentry.Event; [[Called when a directory was created]] +directory,deleted: Eio.Sentry.Event; [[Called when a directory was deleted]] +directory,modified: Eio.Sentry.Event; [[called when a directory was modified]] +directory,closed: Eio.Sentry.Event; [[Called when a directory was closed]] +self,rename: Eio.Sentry.Event; [[Called when the object was renamed]] +self,deleted: Eio.Sentry.Event; [[Called when the object was deleted]] +error: Eio.Sentry.Event; [[Called in case of an error]] } implements { --
[EGIT] [core/efl] master 11/12: docs: efl_net_server: add missing docs for efl_net_server
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=f3d12112668af2648728a983518622dabb609ac2 commit f3d12112668af2648728a983518622dabb609ac2 Author: Stefan Schmidt Date: Fri Nov 11 15:35:18 2016 +0100 docs: efl_net_server: add missing docs for efl_net_server --- src/lib/ecore_con/efl_net_server_fd.eo | 6 +++--- src/lib/ecore_con/efl_net_server_udp.eo| 6 +++--- src/lib/ecore_con/efl_net_server_udp_client.eo | 2 +- src/lib/ecore_con/efl_net_server_unix.eo | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/lib/ecore_con/efl_net_server_fd.eo b/src/lib/ecore_con/efl_net_server_fd.eo index 2c494a6..dbafe1b 100644 --- a/src/lib/ecore_con/efl_net_server_fd.eo +++ b/src/lib/ecore_con/efl_net_server_fd.eo @@ -77,7 +77,7 @@ class Efl.Net.Server.Fd (Efl.Loop.Fd, Efl.Net.Server) { ]] get { } set { -return: bool (false); [[$true on success]] +return: bool (false); [[$true on success, $false otherwise]] } values { close_on_exec: bool; [[If $true close on exec will be used, $false otherwise]] @@ -88,7 +88,7 @@ class Efl.Net.Server.Fd (Efl.Loop.Fd, Efl.Net.Server) { [[Controls address reuse() using SO_REUSEADDR]] get { } set { -return: bool (false); [[$true on success]] +return: bool (false); [[$true on success, $false otherwise]] } values { reuse_address: bool; [[If $true the server will reuse the address, $false otherwise]] @@ -99,7 +99,7 @@ class Efl.Net.Server.Fd (Efl.Loop.Fd, Efl.Net.Server) { [[Controls port reuse() using SO_REUSEPORT (since linux 3.9)]] get { } set { -return: bool (false); [[$true on success]] +return: bool (false); [[$true on success, $false otherwise]] } values { reuse_port: bool; [[If $true the server will reuse the port, $false otherwise]] diff --git a/src/lib/ecore_con/efl_net_server_udp.eo b/src/lib/ecore_con/efl_net_server_udp.eo index e631a63..f6e60f1 100644 --- a/src/lib/ecore_con/efl_net_server_udp.eo +++ b/src/lib/ecore_con/efl_net_server_udp.eo @@ -67,7 +67,7 @@ class Efl.Net.Server.Udp (Efl.Net.Server.Fd) { params { address: string @nonull; [[Multicast group address]] } -return: Eina.Error; +return: Eina.Error; [[0 on success, error code otherwise]] } multicast_leave { @@ -78,7 +78,7 @@ class Efl.Net.Server.Udp (Efl.Net.Server.Fd) { params { address: string @nonull; [[Multicast group address]] } -return: Eina.Error; +return: Eina.Error; [[0 on success, error code otherwise]] } multicast_groups_get { @@ -100,7 +100,7 @@ class Efl.Net.Server.Udp (Efl.Net.Server.Fd) { return: Eina.Error; [[0 on success, error code otherwise]] } values { -loopback: bool; +loopback: bool; [[FIXME: should this be named ttl?]] } } diff --git a/src/lib/ecore_con/efl_net_server_udp_client.eo b/src/lib/ecore_con/efl_net_server_udp_client.eo index 9ef3fda..77a6fe1 100644 --- a/src/lib/ecore_con/efl_net_server_udp_client.eo +++ b/src/lib/ecore_con/efl_net_server_udp_client.eo @@ -20,7 +20,7 @@ class Efl.Net.Server.Udp.Client (Efl.Object, Efl.Net.Socket) { This will query the next pending datagram size, in bytes. If no datagrams are pending, 0 is returned. ]] -return: size; [[size in bytes]] +return: size; [[Size in bytes]] } } diff --git a/src/lib/ecore_con/efl_net_server_unix.eo b/src/lib/ecore_con/efl_net_server_unix.eo index 9f69758..5e87ba5 100644 --- a/src/lib/ecore_con/efl_net_server_unix.eo +++ b/src/lib/ecore_con/efl_net_server_unix.eo @@ -14,7 +14,7 @@ class Efl.Net.Server.Unix (Efl.Net.Server.Fd) { By default it's false and you will get EADDRINUSE. ]] values { -unlink_before_bind: bool; [[if $true, server will unlink() the path before bind() is called.]] +unlink_before_bind: bool; [[If $true, server will unlink() the path before bind() is called.]] } } } --
[EGIT] [core/efl] master 07/12: docs: efl_network*: add missing documentation
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=6570c2692100b4b9b1440d1a7244620d586773c6 commit 6570c2692100b4b9b1440d1a7244620d586773c6 Author: Stefan Schmidt Date: Fri Nov 11 15:28:49 2016 +0100 docs: efl_network*: add missing documentation --- src/lib/ecore_con/efl_network.eo | 6 +++--- src/lib/ecore_con/efl_network_url.eo | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lib/ecore_con/efl_network.eo b/src/lib/ecore_con/efl_network.eo index e2cdc79..2f95a05 100644 --- a/src/lib/ecore_con/efl_network.eo +++ b/src/lib/ecore_con/efl_network.eo @@ -104,7 +104,7 @@ abstract Efl.Network (Efl.Object) { legacy: null; } values { -connected: bool; [[Returns true if connected, false otherwise.]] +connected: bool; [[$true if connected, $false otherwise.]] } } @property timeout @virtual_pure { @@ -172,12 +172,12 @@ abstract Efl.Network (Efl.Object) { done_cb: Ecore_Con_Dns_Cb; [[Callback to notify when done.]] data: const(void_ptr); [[User data to be given to done_cb.]] } - return: bool; [[true if the request did not fail to be set up, false otherwise.]] + return: bool; [[$true if the request did not fail to be set up, $false otherwise.]] } } events { data,received: Ecore.Con.Event_Data.Received; [[Data received on connection]] -connection,upgraded; +connection,upgraded; [[FIXME: what does upgrade mean here??]] connection,error: string; [[Error received on connection]] } } diff --git a/src/lib/ecore_con/efl_network_url.eo b/src/lib/ecore_con/efl_network_url.eo index 971d6d5..9dacb51 100644 --- a/src/lib/ecore_con/efl_network_url.eo +++ b/src/lib/ecore_con/efl_network_url.eo @@ -5,7 +5,7 @@ class Efl.Network.Url (Efl.Object) { @property url { [[Controls the URL to send the request to.]] set { -return: bool (false); [[true on success, false on error.]] +return: bool (false); [[$true on success, $false on error.]] } get { } --
[EGIT] [core/efl] master 10/12: docs: efl_net_socket: add missing docs for efl_net_socket
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=c2754dc5623372490114e790386f8382bc1a251e commit c2754dc5623372490114e790386f8382bc1a251e Author: Stefan Schmidt Date: Fri Nov 11 15:34:08 2016 +0100 docs: efl_net_socket: add missing docs for efl_net_socket --- src/lib/ecore_con/efl_net_socket.eo | 4 ++-- src/lib/ecore_con/efl_net_socket_fd.eo | 2 +- src/lib/ecore_con/efl_net_socket_ssl.eo | 8 src/lib/ecore_con/efl_net_socket_tcp.eo | 6 +++--- src/lib/ecore_con/efl_net_socket_udp.eo | 26 +- 5 files changed, 23 insertions(+), 23 deletions(-) diff --git a/src/lib/ecore_con/efl_net_socket.eo b/src/lib/ecore_con/efl_net_socket.eo index fdd29ed..e7be445 100644 --- a/src/lib/ecore_con/efl_net_socket.eo +++ b/src/lib/ecore_con/efl_net_socket.eo @@ -25,7 +25,7 @@ interface Efl.Net.Socket (Efl.Io.Reader, Efl.Io.Writer, Efl.Io.Closer) { get { } set @protected { } values { -address: string; +address: string; [[Local address]] } } @@ -43,7 +43,7 @@ interface Efl.Net.Socket (Efl.Io.Reader, Efl.Io.Writer, Efl.Io.Closer) { get { } set @protected { } values { -address: string; +address: string; [[Remote address]] } } } diff --git a/src/lib/ecore_con/efl_net_socket_fd.eo b/src/lib/ecore_con/efl_net_socket_fd.eo index 711d387..8df4c75 100644 --- a/src/lib/ecore_con/efl_net_socket_fd.eo +++ b/src/lib/ecore_con/efl_net_socket_fd.eo @@ -24,7 +24,7 @@ class Efl.Net.Socket.Fd (Efl.Loop.Fd, Efl.Io.Reader.Fd, Efl.Io.Writer.Fd, Efl.Io get { } set @protected { } values { -family: int; +family: int; [[Address family]] } } } diff --git a/src/lib/ecore_con/efl_net_socket_ssl.eo b/src/lib/ecore_con/efl_net_socket_ssl.eo index 71b43c4..f32362a 100644 --- a/src/lib/ecore_con/efl_net_socket_ssl.eo +++ b/src/lib/ecore_con/efl_net_socket_ssl.eo @@ -14,7 +14,7 @@ class Efl.Net.Socket.Ssl (Efl.Loop_User, Efl.Net.Socket) { events { ssl,ready; [[Notifies the SSL handshake was done and the socket is now able to communicate]] -ssl,error: Eina.Error; [[an error such as @Efl.Net.Socket.Ssl.Error.HANDSHAKE]] +ssl,error: Eina.Error; [[An error such as @Efl.Net.Socket.Ssl.Error.HANDSHAKE]] } methods { @@ -36,7 +36,7 @@ class Efl.Net.Socket.Ssl (Efl.Loop_User, Efl.Net.Socket) { @property verify_mode { [[How to verify the remote peer.]] values { -verify_mode: Efl.Net.Ssl.Verify_Mode; +verify_mode: Efl.Net.Ssl.Verify_Mode; [[Remote verification mode]] } } @@ -48,7 +48,7 @@ class Efl.Net.Socket.Ssl (Efl.Loop_User, Efl.Net.Socket) { @.hostname_override. ]] values { -hostname_verify: bool; +hostname_verify: bool; [[$true if the hostname will be verified, $false otherwise]] } } @@ -66,7 +66,7 @@ class Efl.Net.Socket.Ssl (Efl.Loop_User, Efl.Net.Socket) { It's only used if @.hostname_verify is $true. ]] values { -hostname_override: string @nullable; +hostname_override: string @nullable; [[Hostname for this socket]] } } } diff --git a/src/lib/ecore_con/efl_net_socket_tcp.eo b/src/lib/ecore_con/efl_net_socket_tcp.eo index 3e6fb29..e7390d2 100644 --- a/src/lib/ecore_con/efl_net_socket_tcp.eo +++ b/src/lib/ecore_con/efl_net_socket_tcp.eo @@ -15,7 +15,7 @@ class Efl.Net.Socket.Tcp (Efl.Net.Socket.Fd) { return: bool (false); [[$true on success]] } values { -keep_alive: bool; +keep_alive: bool; [[$true if keep alive is enabled, $false otherwise]] } } @@ -26,7 +26,7 @@ class Efl.Net.Socket.Tcp (Efl.Net.Socket.Fd) { return: bool (false); [[$true on success]] } values { -no_delay: bool; +no_delay: bool; [[$true if no delay is enabled, $false otherwise]] } } @@ -37,7 +37,7 @@ class Efl.Net.Socket.Tcp (Efl.Net.Socket.Fd) { return: bool (false); [[$true on success]] } values { -cork: bool; +cork: bool; [[$true if cork is enabled, $false otherwise]] } } } diff --git a/src/lib/ecore_con/efl_net_socket_udp.eo b/src/lib/ecore_con/efl_net_socket_udp.eo index 4934bd9..ee41072 100644 --- a/src/lib/ecore_con/efl_net_socket_udp.eo +++ b/src/lib/ecore_con/efl_net_socket_udp.eo @@ -18,17 +18,17 @@ class Efl.Net.Socket.Udp (Efl.Net.Socket.Fd) { This
[EGIT] [core/efl] master 08/12: docs: efl_net_control*: ad missing docs in efl_net_control*
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=be9283c17cb5cf9182e27c7e7ecc56adb7e22a77 commit be9283c17cb5cf9182e27c7e7ecc56adb7e22a77 Author: Stefan Schmidt Date: Fri Nov 11 15:30:55 2016 +0100 docs: efl_net_control*: ad missing docs in efl_net_control* --- src/lib/ecore_con/efl_net_control.eo | 22 ++-- src/lib/ecore_con/efl_net_control_access_point.eo | 116 +++--- src/lib/ecore_con/efl_net_control_technology.eo | 4 +- 3 files changed, 71 insertions(+), 71 deletions(-) diff --git a/src/lib/ecore_con/efl_net_control.eo b/src/lib/ecore_con/efl_net_control.eo index e1fd4f6..756564a 100644 --- a/src/lib/ecore_con/efl_net_control.eo +++ b/src/lib/ecore_con/efl_net_control.eo @@ -10,9 +10,9 @@ enum Efl.Net.Control.State { @since 1.19 ]] -offline, [[no access point is connected]] -local, [[at least one access point was connected and the internet connectio wasn't verified]] -online, [[at least one access point was connected and the internet was verified]] +offline, [[No access point is connected]] +local, [[At least one access point was connected and the internet connectio wasn't verified]] +online, [[At least one access point was connected and the internet was verified]] } enum Efl.Net.Control.Agent_Request_Input.Field { @@ -23,7 +23,7 @@ enum Efl.Net.Control.Agent_Request_Input.Field { name = (1 << 0), [[Used for hidden WiFi access points. If ssid is present, this is an alternative to that.]] ssid = (1 << 1), [[Used for hidden WiFi access points. If name is present, this is an alternative to that.]] username = (1 << 2), [[Identity or username requested]] -passphrase = (1 << 3), [[password or passphrase requested]] +passphrase = (1 << 3), [[Password or passphrase requested]] wps = (1 << 4), [[Use WPS authentication. If passphrase is present, this is an alternative to that.]] } @@ -44,7 +44,7 @@ struct Efl.Net.Control.Agent_Request_Input { access_point: Efl.Net.Control.Access_Point; [[The access point that triggered this request.]] fields: Efl.Net.Control.Agent_Request_Input.Field; [[Bitwise OR of fields present in this request.]] passphrase_type: string; [[Extra detail on the meaning for the passphrase field, such as wep, psk, response (IEEE802.X GTC/OTP), string...]] -informational: list; [[such as the previous passphrase, VPN host]] +informational: list; [[Such as the previous passphrase, VPN host]] } struct Efl.Net.Control.Agent_Error { @@ -121,7 +121,7 @@ class Efl.Net.Control (Efl.Loop_User) { get { } set { } values { -radios_offline: bool; +radios_offline: bool; [[$true if all radios are offline, $false otherwise]] } } @@ -137,7 +137,7 @@ class Efl.Net.Control (Efl.Loop_User) { ]] get { } values { -state: Efl.Net.Control.State; +state: Efl.Net.Control.State; [[Network state]] } } @@ -151,12 +151,12 @@ class Efl.Net.Control (Efl.Loop_User) { ]] get { } values { -access_points: free(own(iterator), eina_iterator_free); +access_points: free(own(iterator), eina_iterator_free); [[Iterator of current access points]] } } @property technologies { -[[The iterator of current access points. +[[The iterator of current technologies. The iterator is valid only before the function returns to the main loop, by then, if the events @@ -165,7 +165,7 @@ class Efl.Net.Control (Efl.Loop_User) { ]] get { } values { -technologies: free(own(iterator), eina_iterator_free); +technologies: free(own(iterator), eina_iterator_free); [[Iterator of current technologies]] } } @@ -189,7 +189,7 @@ class Efl.Net.Control (Efl.Loop_User) { get { } set { } values { -agent_enabled: bool; +agent_enabled: bool; [[$true if to become the agent, $false otherwise]] } } diff --git a/src/lib/ecore_con/efl_net_control_access_point.eo b/src/lib/ecore_con/efl_net_control_access_point.eo index 469457b..163bae0 100644 --- a/src/lib/ecore_con/efl_net_control_access_point.eo +++ b/src/lib/ecore_con/efl_net_control_access_point.eo @@ -3,13 +3,13 @@ enum Efl.Net.Control.Access_Point.State { @since 1.19 ]] -idle, [[nothing is happening with this access point]] -association, [[the access point is trying to associate itself, this is the first state after a connection attempt]] -configuration, [[the access point is configuring itself, such as DHCP]] -local, [[the access point is connected, but
[EGIT] [core/efl] master 03/12: docs: ecore_adio: finish up eo docs for ecore_audio
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=acba97cd049ce9f4f21c78eaa935c87a252bf42c commit acba97cd049ce9f4f21c78eaa935c87a252bf42c Author: Stefan Schmidt Date: Fri Nov 11 09:26:22 2016 +0100 docs: ecore_adio: finish up eo docs for ecore_audio --- src/lib/ecore_audio/ecore_audio.eo | 19 +-- src/lib/ecore_audio/ecore_audio_in.eo | 4 ++-- src/lib/ecore_audio/ecore_audio_out.eo | 4 ++-- 3 files changed, 13 insertions(+), 14 deletions(-) diff --git a/src/lib/ecore_audio/ecore_audio.eo b/src/lib/ecore_audio/ecore_audio.eo index a80a4c9..74fd206 100644 --- a/src/lib/ecore_audio/ecore_audio.eo +++ b/src/lib/ecore_audio/ecore_audio.eo @@ -42,7 +42,7 @@ class Ecore.Audio (Efl.Object) get { } values { -paused: bool; [[true if object is paused, false if not]] +paused: bool; [[$true if object is paused, $false otherwise]] } } @property volume { @@ -68,14 +68,13 @@ class Ecore.Audio (Efl.Object) @since 1.8 ]] set { -return: bool; [[true if the source was set correctly (i.e. the file -was opened), EINA_FALSE otherwise - ]] +return: bool; [[$true if the source was set correctly (i.e. the file +was opened), $false otherwise]] } get { } values { -source: string; [[the source to set to (i.e. file, URL, device)]] +source: string; [[The source to set to (i.e. file, URL, device)]] } } @property format @virtual_pure { @@ -88,7 +87,7 @@ class Ecore.Audio (Efl.Object) @since 1.8 ]] -return: bool; [[true if the format was supported, false otherwise]] +return: bool; [[$true if the format was supported, $false otherwise]] } get { [[Get the format of the object @@ -100,7 +99,7 @@ class Ecore.Audio (Efl.Object) ]] } values { -format: Ecore.Audio.Format; [[the format of the object]] +format: Ecore.Audio.Format; [[The audio format of the object]] } } vio_set @virtual_pure { @@ -109,11 +108,11 @@ class Ecore.Audio (Efl.Object) @since 1.8 ]] params { - vio: ptr(Ecore.Audio.Vio); [[the @Ecore.Audio.Vio struct with + vio: ptr(Ecore.Audio.Vio); [[The @Ecore.Audio.Vio struct with the function callbacks ]] - data: void_ptr; [[user data to pass to the VIO functions]] - free_func: efl_key_data_free_func; [[this function takes care to + data: void_ptr; [[User data to pass to the VIO functions]] + free_func: efl_key_data_free_func; [[This function takes care to clean up $data when he VIO is destroyed. NULL means do nothing. diff --git a/src/lib/ecore_audio/ecore_audio_in.eo b/src/lib/ecore_audio/ecore_audio_in.eo index 4c7b439..e288ad7 100644 --- a/src/lib/ecore_audio/ecore_audio_in.eo +++ b/src/lib/ecore_audio/ecore_audio_in.eo @@ -54,7 +54,7 @@ class Ecore.Audio.In (Ecore.Audio) get { } values { -preloaded: bool; [[true if the input should be cached, false otherwise]] +preloaded: bool; [[$true if the input should be cached, false $otherwise]] } } @property looped { @@ -71,7 +71,7 @@ class Ecore.Audio.In (Ecore.Audio) get { } values { -looped: bool; [[true if the input should be looped, false otherwise]] +looped: bool; [[$true if the input should be looped, $false otherwise]] } } @property length { diff --git a/src/lib/ecore_audio/ecore_audio_out.eo b/src/lib/ecore_audio/ecore_audio_out.eo index 4192e73..4366607 100644 --- a/src/lib/ecore_audio/ecore_audio_out.eo +++ b/src/lib/ecore_audio/ecore_audio_out.eo @@ -10,7 +10,7 @@ class Ecore.Audio.Out (Ecore.Audio) @since 1.8 ]] - return: bool; [[true if the input was attached, false otherwise]] + return: bool; [[$true if the input was attached, $false otherwise]] params { @in input: Ecore.Audio.In; [[The input to attach to the output]] } @@ -20,7 +20,7 @@ class Ecore.Audio.Out (Ecore.Audio) @since 1.8 ]] - return: bool; [[true if the input was detached, false otherwise]] + return: bool; [[$true if the input was detached, $false otherwise]] params { @in input: Ecore.Audio.In; [[The input to detach to the output]]
[EGIT] [core/efl] master 12/12: docs: ecore_con: add all missing docs for ecore_con
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=b8dfc68ee257ca0a853f4233a1e96de4febbc904 commit b8dfc68ee257ca0a853f4233a1e96de4febbc904 Author: Stefan Schmidt Date: Fri Nov 11 15:35:48 2016 +0100 docs: ecore_con: add all missing docs for ecore_con This should fill all gaps we still had in ecore_con. Please make sure all new additions comes with docs as well. --- src/lib/ecore_con/ecore_con_eet_base.eo | 2 +- src/lib/ecore_con/efl_net_session.eo | 32 src/lib/ecore_con/efl_net_ssl_context.eo | 18 +- 3 files changed, 26 insertions(+), 26 deletions(-) diff --git a/src/lib/ecore_con/ecore_con_eet_base.eo b/src/lib/ecore_con/ecore_con_eet_base.eo index 82d41a2..fcbc835 100644 --- a/src/lib/ecore_con/ecore_con_eet_base.eo +++ b/src/lib/ecore_con/ecore_con_eet_base.eo @@ -19,7 +19,7 @@ class Ecore.Con.Eet.Base (Efl.Object) { get { } values { -data: Efl.Network.Server; +data: Efl.Network.Server; [[Server object]] } } @property data_callback { diff --git a/src/lib/ecore_con/efl_net_session.eo b/src/lib/ecore_con/efl_net_session.eo index 83ee334..af792a2 100644 --- a/src/lib/ecore_con/efl_net_session.eo +++ b/src/lib/ecore_con/efl_net_session.eo @@ -3,9 +3,9 @@ enum Efl.Net.Session.State { @since 1.19 ]] -offline, [[no access point is connected]] -local, [[at least one access point was connected and the internet connectio wasn't verified]] -online, [[at least one access point was connected and the internet was verified]] +offline, [[No access point is connected]] +local, [[At least one access point was connected and the internet connectio wasn't verified]] +online, [[At least one access point was connected and the internet was verified]] } /* keep in sync with efl_net_control_technology.eo, comment what doesn't make sense */ @@ -42,7 +42,7 @@ class Efl.Net.Session (Efl.Loop_User) { @since 1.19 ]] events { -changed; [[Some properties were changed.]] +changed; [[Called when some properties were changed.]] } methods { @@ -60,7 +60,7 @@ class Efl.Net.Session (Efl.Loop_User) { https://github.com/aldebaran/connman/blob/master/doc/session-policy-format.txt ]] params { -online_required: bool; [[if $false, access points with local state are enough. If $true, the access point must be in online state, with a validated internet connection]] +online_required: bool; [[If $false, access points with local state are enough. If $true, the access point must be in online state, with a validated internet connection]] technologies_allowed: Efl.Net.Session.Technology; [[Bitwise OR of technologies to allow]] } } @@ -79,7 +79,7 @@ class Efl.Net.Session (Efl.Loop_User) { [[The user-friendly access point name.]] get { } values { -name: string; +name: string; [[Access point name]] } } @@ -87,7 +87,7 @@ class Efl.Net.Session (Efl.Loop_User) { [[If the session connectivity is offline, local or online.]] get { } values { -state: Efl.Net.Session.State; +state: Efl.Net.Session.State; [[Network session state]] } } @@ -95,7 +95,7 @@ class Efl.Net.Session (Efl.Loop_User) { [[The access point technology that backs this session]] get { } values { -technology: Efl.Net.Session.Technology; +technology: Efl.Net.Session.Technology; [[Network session technology]] } } @@ -103,7 +103,7 @@ class Efl.Net.Session (Efl.Loop_User) { [[The interface allows the application to assign the socket to a given device using SO_BINDTODEVICE]] get { } values { -interface: string; +interface: string; [[Network interface to bind to]] } } @@ -111,9 +111,9 @@ class Efl.Net.Session (Efl.Loop_User) { [[IPv4 in use for this session.]] get { } values { -address: string; -netmask: string; -gateway: string; +address: string; [[IPv4 address]] +netmask: string; [[IPv4 netmask]] +gateway: string; [[IPv4 gateway]] } } @@ -121,10 +121,10 @@ class Efl.Net.Session (Efl.Loop_User) { [[IPv6 in use for this session.]] get { } values { -address: string; -prefix_length: uint8; -netmask: string; -gateway: string; +address: string; [[IPv6 ad
[EGIT] [core/efl] master 05/12: docs: ecore: finish up eo file docs in ecore
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=6a322b1b2c321d4eaaccddabd9eb1a28ac6accc3 commit 6a322b1b2c321d4eaaccddabd9eb1a28ac6accc3 Author: Stefan Schmidt Date: Fri Nov 11 10:58:22 2016 +0100 docs: ecore: finish up eo file docs in ecore --- src/lib/ecore/ecore_exe.eo| 6 +++--- src/lib/ecore/efl_io_closer_fd.eo | 3 ++- src/lib/ecore/efl_io_copier.eo| 11 ++- src/lib/ecore/efl_io_file.eo | 10 +- src/lib/ecore/efl_io_positioner_fd.eo | 3 ++- src/lib/ecore/efl_io_reader_fd.eo | 3 ++- src/lib/ecore/efl_io_sizer_fd.eo | 3 ++- src/lib/ecore/efl_io_writer_fd.eo | 3 ++- src/lib/ecore/efl_loop.eo | 8 src/lib/ecore/efl_loop_fd.eo | 6 +++--- src/lib/ecore/efl_loop_timer.eo | 2 +- src/lib/ecore/efl_loop_user.eo| 3 ++- src/lib/ecore/efl_promise.eo | 3 ++- 13 files changed, 36 insertions(+), 28 deletions(-) diff --git a/src/lib/ecore/ecore_exe.eo b/src/lib/ecore/ecore_exe.eo index b300b7b..09286fb 100644 --- a/src/lib/ecore/ecore_exe.eo +++ b/src/lib/ecore/ecore_exe.eo @@ -15,9 +15,9 @@ struct Ecore.Exe.Event_Data { [[Ecore exe event data structure]] exe: Efl.Object; [[The handle to the process. FIXME: should actually be Ecore.Exe, workaround cyclic]] - data: void_ptr; [[the raw binary data from the child process that was received]] - size: int; [[the size of this data in bytes]] - lines: ptr(Ecore.Exe.Event_Data.Line); [[an array of line data if line buffered, the last one has it's line member set to $NULL]] + data: void_ptr; [[The raw binary data from the child process that was received]] + size: int; [[The size of this data in bytes]] + lines: ptr(Ecore.Exe.Event_Data.Line); [[An array of line data if line buffered, the last one has it's line member set to $NULL]] } enum Ecore.Exe_Flags diff --git a/src/lib/ecore/efl_io_closer_fd.eo b/src/lib/ecore/efl_io_closer_fd.eo index 853f2b4..67e60be 100644 --- a/src/lib/ecore/efl_io_closer_fd.eo +++ b/src/lib/ecore/efl_io_closer_fd.eo @@ -6,10 +6,11 @@ mixin Efl.Io.Closer.Fd (Efl.Io.Closer) { methods { @property closer_fd { +[[Closer file descriptor]] get {} set @protected {} values { -fd: int; +fd: int; [[File descriptor]] } } } diff --git a/src/lib/ecore/efl_io_copier.eo b/src/lib/ecore/efl_io_copier.eo index 04a0a83..a5e07ac 100644 --- a/src/lib/ecore/efl_io_copier.eo +++ b/src/lib/ecore/efl_io_copier.eo @@ -30,7 +30,7 @@ class Efl.Io.Copier (Efl.Loop_User, Efl.Io.Closer) { [[Constructor-only property to set where to read data from]] } values { -source: Efl.Io.Reader; +source: Efl.Io.Reader; [[Reader source]] } } @@ -41,7 +41,7 @@ class Efl.Io.Copier (Efl.Loop_User, Efl.Io.Closer) { [[Constructor-only property to set where to write data to]] } values { -destination: Efl.Io.Writer; +destination: Efl.Io.Writer; [[Writer destination]] } } @@ -79,11 +79,12 @@ class Efl.Io.Copier (Efl.Loop_User, Efl.Io.Closer) { } @property progress { +[[Progress for read or write]] get { } values { -read: uint64 @optional; [[amount of bytes read from source]] -written: uint64 @optional; [[amount of bytes written to destination]] +read: uint64 @optional; [[Amount of bytes read from source]] +written: uint64 @optional; [[Amount of bytes written to destination]] total: uint64 @optional; [[If @.source is an Efl.Io.Sizer, its total size. Otherwise 0 to report unknown size]] } } @@ -109,7 +110,7 @@ class Efl.Io.Copier (Efl.Loop_User, Efl.Io.Closer) { The buffer is then owned by caller, which should call eina_binbuf_free() when it's done. ]] - return: free(own(ptr(Eina.Binbuf)), eina_binbuf_free) @warn_unused; + return: free(own(ptr(Eina.Binbuf)), eina_binbuf_free) @warn_unused; [[Binbuf]] } } diff --git a/src/lib/ecore/efl_io_file.eo b/src/lib/ecore/efl_io_file.eo index 841f173..d09fb52 100644 --- a/src/lib/ecore/efl_io_file.eo +++ b/src/lib/ecore/efl_io_file.eo @@ -10,7 +10,7 @@ class Efl.Io.File (Efl.Loop.Fd, Efl.File, Efl.Io.Reader.Fd, Efl.Io.Writer.Fd, Ef methods { @property flags { -[[bitwise OR'ed flags to open the file, like O_CREAT, O_APPEND... +[[Bitwise OR'ed flags to open the file, like O_CREAT, O_APPEND... Defaults to O_RDONLY | O_CLOEXEC. @@ -23,11 +23,11 @@ class Efl.Io.File (Efl.Loop.Fd, Efl.File, Efl.Io.Reader.Fd, Efl.Io.Writer.Fd, Ef
[EGIT] [core/efl] master 01/12: docs: efl_net*: add docs for newly added enums
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=c588d49caa67071ef36fe107bb781c5abaf63358 commit c588d49caa67071ef36fe107bb781c5abaf63358 Author: Stefan Schmidt Date: Thu Nov 10 17:45:11 2016 +0100 docs: efl_net*: add docs for newly added enums --- src/lib/ecore_con/efl_net_control_access_point.eo | 2 +- src/lib/ecore_con/efl_net_control_technology.eo | 30 +++ src/lib/ecore_con/efl_net_session.eo | 24 +- 3 files changed, 28 insertions(+), 28 deletions(-) diff --git a/src/lib/ecore_con/efl_net_control_access_point.eo b/src/lib/ecore_con/efl_net_control_access_point.eo index 041d873..469457b 100644 --- a/src/lib/ecore_con/efl_net_control_access_point.eo +++ b/src/lib/ecore_con/efl_net_control_access_point.eo @@ -30,7 +30,7 @@ enum Efl.Net.Control.Access_Point.Security { @since 1.19 ]] -unknow = 0, +unknow = 0, [[Unknown]] none = (1 << 0), [[open access, no security]] wep = (1 << 1), [[WEP]] psk = (1 << 2), [[PSK (Pre Shared Key), such as WPA or RSN]] diff --git a/src/lib/ecore_con/efl_net_control_technology.eo b/src/lib/ecore_con/efl_net_control_technology.eo index d91f947..26ef8df 100644 --- a/src/lib/ecore_con/efl_net_control_technology.eo +++ b/src/lib/ecore_con/efl_net_control_technology.eo @@ -3,16 +3,16 @@ enum Efl.Net.Control.Technology.Type { @since 1.19 ]] -unknown, -system, -ethernet, -wifi, -bluetooth, -cellular, -gps, -vpn, -gadget, -p2p, +unknown, [[Type: unknown]] +system, [[Type: system]] +ethernet, [[Type: ethernet]] +wifi, [[Type: WiFi]] +bluetooth, [[Type: Bluetooth]] +cellular, [[Type: cellular/mobile]] +gps, [[Type: GPS]] +vpn, [[Type: Virtual Private Network]] +gadget, [[Type: USB gadget]] +p2p, [[Type: Peer-2-Peer]] } class Efl.Net.Control.Technology (Efl.Loop_User) { @@ -37,7 +37,7 @@ class Efl.Net.Control.Technology (Efl.Loop_User) { get { } set { } values { -powered: bool; +powered: bool; [[$true if technology is powered, $false otherwise]] } } @@ -61,7 +61,7 @@ class Efl.Net.Control.Technology (Efl.Loop_User) { [[If $true the technology has at least one access point connected.]] get { } values { -connected: bool; +connected: bool;[[$true if technology is connected, $false otherwise]] } } @@ -69,7 +69,7 @@ class Efl.Net.Control.Technology (Efl.Loop_User) { [[The user-friendly technology name]] get { } values { -name: string; +name: string; [[Technology name]] } } @@ -77,7 +77,7 @@ class Efl.Net.Control.Technology (Efl.Loop_User) { [[The technology type, such as "ethernet" or "wifi"]] get { } values { -type: Efl.Net.Control.Technology.Type; +type: Efl.Net.Control.Technology.Type; [[Technology type]] } } @@ -96,7 +96,7 @@ class Efl.Net.Control.Technology (Efl.Loop_User) { state. Otherwise prefer to let the system passively do scans in a timely manner. ]] -return: future; /* NOTE: This should be future */ +return: future; [[Future return for finished background scan]] /* NOTE: This should be future */ } } diff --git a/src/lib/ecore_con/efl_net_session.eo b/src/lib/ecore_con/efl_net_session.eo index db85815..83ee334 100644 --- a/src/lib/ecore_con/efl_net_session.eo +++ b/src/lib/ecore_con/efl_net_session.eo @@ -12,19 +12,19 @@ enum Efl.Net.Session.State { enum Efl.Net.Session.Technology { [[Bitwise-able technologies to allow for a network session. - @since 1.19 + @since 1.9 ]] -unknown = 0, -/*system = (1 << 0), */ -ethernet = (1 << 1), -wifi = (1 << 2), -bluetooth = (1 << 3), -cellular = (1 << 4), -/*gps = (1 << 5), */ -vpn = (1 << 6), -gadget = (1 << 7), -/*p2p = (1 << 8), */ -all = (Efl.Net.Session.Technology.ethernet | Efl.Net.Session.Technology.wifi | Efl.Net.Session.Technology.bluetooth | Efl.Net.Session.Technology.cellular | Efl.Net.Session.Technology.vpn | Efl.Net.Session.Technology.gadget), +unknown = 0, [[Type: unknown]] +/*system = (1 << 0), [[Type: system]]*/ +ethernet = (1 << 1), [[Type: ethernet]] +wifi = (1 << 2), [[Type: WiFi]] +bluetooth = (1 << 3), [[Type: Bluetooth]] +cellular = (1 << 4), [[Type: cellular/mobile]] +/*gps = (1 << 5), [[Type: GPS]]*/ +vpn = (1 << 6), [[Type: Virtual Private Network]] +gadget = (1 << 7), [[Type: USB gadget]] +/*p2p = (1 << 8), [[Type: Peer-2-Peer]]*/ +all = (Efl.Net.Session.Technology.ethernet | Efl.Net.Session.Technology.
Re: [E-devel] [EGIT] [core/efl] master 07/12: docs: efl_network*: add missing documentation
Efl_network won't be in our API, only efl_net. So don't worry Em sexta-feira, 11 de novembro de 2016, Stefan Schmidt < ste...@datenfreihafen.org> escreveu: > stefan pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id= > 6570c2692100b4b9b1440d1a7244620d586773c6 > > commit 6570c2692100b4b9b1440d1a7244620d586773c6 > Author: Stefan Schmidt > > Date: Fri Nov 11 15:28:49 2016 +0100 > > docs: efl_network*: add missing documentation > --- > src/lib/ecore_con/efl_network.eo | 6 +++--- > src/lib/ecore_con/efl_network_url.eo | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/lib/ecore_con/efl_network.eo b/src/lib/ecore_con/efl_ > network.eo > index e2cdc79..2f95a05 100644 > --- a/src/lib/ecore_con/efl_network.eo > +++ b/src/lib/ecore_con/efl_network.eo > @@ -104,7 +104,7 @@ abstract Efl.Network (Efl.Object) { > legacy: null; > } > values { > -connected: bool; [[Returns true if connected, false > otherwise.]] > +connected: bool; [[$true if connected, $false otherwise.]] > } >} >@property timeout @virtual_pure { > @@ -172,12 +172,12 @@ abstract Efl.Network (Efl.Object) { > done_cb: Ecore_Con_Dns_Cb; [[Callback to notify when done.]] > data: const(void_ptr); [[User data to be given to done_cb.]] > } > - return: bool; [[true if the request did not fail to be set up, > false otherwise.]] > + return: bool; [[$true if the request did not fail to be set up, > $false otherwise.]] >} > } > events { > data,received: Ecore.Con.Event_Data.Received; [[Data received on > connection]] > -connection,upgraded; > +connection,upgraded; [[FIXME: what does upgrade mean here??]] > connection,error: string; [[Error received on connection]] > } > } > diff --git a/src/lib/ecore_con/efl_network_url.eo b/src/lib/ecore_con/efl_ > network_url.eo > index 971d6d5..9dacb51 100644 > --- a/src/lib/ecore_con/efl_network_url.eo > +++ b/src/lib/ecore_con/efl_network_url.eo > @@ -5,7 +5,7 @@ class Efl.Network.Url (Efl.Object) { >@property url { > [[Controls the URL to send the request to.]] > set { > -return: bool (false); [[true on success, false on error.]] > +return: bool (false); [[$true on success, $false on error.]] > } > get { > } > > -- > > > -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: elm_code: Fix double free on file close/free
ajwillia-ms pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=cc9e9c57d4b813d117a3fa8e59a74c0b2331a606 commit cc9e9c57d4b813d117a3fa8e59a74c0b2331a606 Author: Andy Williams Date: Fri Nov 11 15:00:46 2016 + elm_code: Fix double free on file close/free @fix --- src/lib/elementary/elm_code_file.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/lib/elementary/elm_code_file.c b/src/lib/elementary/elm_code_file.c index 4e8dee4..a87a7d0 100644 --- a/src/lib/elementary/elm_code_file.c +++ b/src/lib/elementary/elm_code_file.c @@ -210,19 +210,20 @@ EAPI void elm_code_file_free(Elm_Code_File *file) elm_code_line_free(l); } - if (file->file) - { -if (file->map) - eina_file_map_free(file->file, file->map); - -eina_file_close(file->file); - } + elm_code_file_close(file); free(file); } EAPI void elm_code_file_close(Elm_Code_File *file) { + if (!file->file) + return; + + if (file->map) + eina_file_map_free(file->file, file->map); + eina_file_close(file->file); + file->file = NULL; } EAPI Elm_Code_File_Line_Ending elm_code_file_line_ending_get(Elm_Code_File *file) --
[EGIT] [core/enlightenment] master 01/01: focus confirmation option in efm delete dialog
discomfitor pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=573035e262d3d69b7e8116969deaf85a7718ef89 commit 573035e262d3d69b7e8116969deaf85a7718ef89 Author: Mike Blumenkrantz Date: Fri Nov 11 09:58:58 2016 -0500 focus confirmation option in efm delete dialog fix T4797 --- src/bin/e_fm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/e_fm.c b/src/bin/e_fm.c index 65c657c..1a4ee29 100644 --- a/src/bin/e_fm.c +++ b/src/bin/e_fm.c @@ -11020,7 +11020,7 @@ _e_fm2_file_delete(Evas_Object *obj) e_object_del_attach_func_set(E_OBJECT(dialog), _e_fm2_file_delete_delete_cb); e_dialog_button_add(dialog, _("Delete"), NULL, _e_fm2_file_delete_yes_cb, ic); e_dialog_button_add(dialog, _("No"), NULL, _e_fm2_file_delete_no_cb, ic); - e_dialog_button_focus_num(dialog, 1); + e_dialog_button_focus_num(dialog, 0); e_dialog_title_set(dialog, _("Confirm Delete")); e_dialog_icon_set(dialog, "dialog-warning", 64); sel = e_fm2_selected_list_get(obj); --
Re: [E-devel] FW: FW: Propose a Eina_Path
On Nov 11, 2016 04:39, "Andrew Williams" wrote: > > It strange that eina defines a rectangle and no other shapes - is that even > used outside a graphical context? Eina started as a simple toolset and got a lot of stuff that was just refactoring of our stack. We have a tiler and rectangle along with matrix, just from the top of my head. I clearly see the need for having a path primitive, the question is where and under what name. It would be fine in eina, if not for the name that is confusing. It would be fine in Ector, if not for Ector depending on efl_gfx_shape. Thinking of it, for binding, we want this API to be in Eo. So why not extending efl_gfx_shape to provide what it is missing and have elementary use it. Added question what is the goal of elm_path object ? I am personnally looking forward to an elm_chart object a lot more. Best, Cedric > A > On Fri, 11 Nov 2016 at 11:17, Hermet Park wrote: > > > Thanks for your advice. > > > > But imo, it's unlike to graphical one such as evas_rect and evas_line... > > Path itself is more likely to the eina_rect... > > Because path itself is just data information. > > Also, efl_gfx_shape should rely on it. > > > > -Original Message- > > From: "Andrew Williams" > > To: "Enlightenment developer list"< > > enlightenment-devel@lists.sourceforge.net>; > > Cc: > > Sent: 2016-11-11 (금) 20:07:44 > > Subject: Re: [E-devel] FW: Propose a Eina_Path > > > > Alongside Evas_Rect and Evas_Line? > > > > On Fri, 11 Nov 2016 at 08:59, Hermet Park wrote: > > > > > Yes, but I have no idea about proper place than eina atm. > > > > > > I feel like It's more close to an data structure & utility function than > > > interface. > > > > > > Any idea? > > > > > > -Original Message- > > > From: "Andrew Williams" > > > To: "Enlightenment developer list"< > > > enlightenment-devel@lists.sourceforge.net>; > > > Cc: > > > Sent: 2016-11-11 (금) 17:31:04 > > > Subject: Re: [E-devel] Propose a Eina_Path > > > > > > The name makes sense in a graphical context. Therefore if it can be > > > somewhere less general than Eina then it could make sense. > > > > > > Andy > > > > > > On Fri, 11 Nov 2016 at 08:00, Gustavo Sverzut Barbieri < > > barbi...@gmail.com > > > > > > > wrote: > > > > > > > Em sexta-feira, 11 de novembro de 2016, Hermet Park < > > her...@hermet.pe.kr > > > > > > > > escreveu: > > > > > > > > > Hello everyone. > > > > > > > > > > Currently, I'm trying a prototype - Path Object using the evas map. > > > > > (specifically for a scenario, text on path). > > > > > It looks nice if it works on gl backend. (i will share the result > > > later) > > > > > > > > > > But before we talk about path object stuff, I wanna propose a > > > Eina_Path. > > > > > > > > > > After reviewed efl_gfx_shape interface again, > > > > > I realized path interface should be moved out from the efl_gfx_shape > > > > > interface so that Path Object also utilize the path stuff. > > > > > > > > > > Curently, efl_gfx_shape has more than path functionalities such as a > > > > > stroke, > > > > > > > > > > I think path stuff can become a more generic function set. > > > > > So, I'd like to move the path stuff into Eina. > > > > > > > > > > If then, path object will be able to utilize the Eina Path and > > > > > efl_gfx_shape will do also. > > > > > > > > > > ie) > > > > > Eina_Path *path = eina_path_add(); > > > > > eina_path_append_move_to(path, xxx); > > > > > eina_path_append_line_to(path, xxx); > > > > > eina_path_append_xxx (...); > > > > > > > > > > ... > > > > > > > > > > efl_gfx_shape_path_set(shape, path); > > > > > > > > > > also, > > > > > > > > > > elm_path_object_path_set(obj, path); > > > > > > > > > > If you agree on this, I will work on this stuff soon. > > > > > > > > > > Any objections? > > > > > > > > > > > > The name. I started to read this email thinking abou file path. :-) > > > > > > > > But as for moving it to eina, I don't think it's the right place. Eina > > > has > > > > no other similar primitive. > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Developer Access Program for Intel Xeon Phi Processors > > > > > Access to Intel Xeon Phi processor-based developer platforms. > > > > > With one year of Intel Parallel Studio XE. > > > > > Training and support from Colfax. > > > > > Order your platform today. http://sdm.link/xeonphi > > > > > ___ > > > > > enlightenment-devel mailing list > > > > > enlightenment-devel@lists.sourceforge.net > > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > > > > > > > -- > > > > Gustavo Sverzut Barbieri > > > > -- > > > > Mobile: +55 (16) 99354-9890 > > > > > > > > > > > > > -- > > > > Developer Access Program for Intel Xeon Phi Processors > > > > Access to I
[EGIT] [tools/clouseau] master 01/01: return 0 from main()
cedric pushed a commit to branch master. http://git.enlightenment.org/tools/clouseau.git/commit/?id=9f62d5914032c3d159f40b8e32e1901b145ec654 commit 9f62d5914032c3d159f40b8e32e1901b145ec654 Author: Shuhrat Dehkanov Date: Fri Nov 11 09:47:01 2016 -0800 return 0 from main() Summary: Although, underlying value of EINA_FALSE is 0 the type former is Bool. Hence, for the sake of consistency, let's return 0 from main(). Reviewers: jeanguyomarch, jeyzu Subscribers: hyunseok, minkyu Differential Revision: https://phab.enlightenment.org/D4392 Signed-off-by: Cedric Bail --- src/bin/clouseau_client.c | 2 +- src/bin/clouseaud.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/clouseau_client.c b/src/bin/clouseau_client.c index 32fcb0a..7d57fe4 100644 --- a/src/bin/clouseau_client.c +++ b/src/bin/clouseau_client.c @@ -2390,7 +2390,7 @@ main(int argc, char **argv) if (_clouseau_client_log_dom < 0) { EINA_LOG_ERR("Could not register log domain: %s", log_dom); -return EINA_FALSE; +return 0; } Evas_Object *win, *panes, *frame; diff --git a/src/bin/clouseaud.c b/src/bin/clouseaud.c index aa43089..93d57f8 100644 --- a/src/bin/clouseaud.c +++ b/src/bin/clouseaud.c @@ -403,7 +403,7 @@ int main(void) if (_clouseaud_log_dom < 0) { EINA_LOG_ERR("Could not register log domain: %s", log_dom); -return EINA_FALSE; +return 0; } if (!(server = ecore_con_server_add(ECORE_CON_REMOTE_TCP | ECORE_CON_SOCKET_ACTIVATE, --
[EGIT] [core/efl] master 01/01: eet: add to basic eet_image EAPIs checking on NULL @fix
cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=e6b074ad214abb6bb563c1762934631ad0ecc2d4 commit e6b074ad214abb6bb563c1762934631ad0ecc2d4 Author: Artem Popov Date: Fri Nov 11 09:57:38 2016 -0800 eet: add to basic eet_image EAPIs checking on NULL @fix Summary: to avoid segfaults with NULL raw data, add checking on NULL to basic eet_image APIS Reviewers: NikaWhite, cedric, myoungwoon, jpeg Reviewed By: jpeg Subscribers: t.naumenko, jpeg Differential Revision: https://phab.enlightenment.org/D4386 Signed-off-by: Cedric Bail --- src/lib/eet/eet_image.c | 12 1 file changed, 12 insertions(+) diff --git a/src/lib/eet/eet_image.c b/src/lib/eet/eet_image.c index 1da7985..b77d90e 100644 --- a/src/lib/eet/eet_image.c +++ b/src/lib/eet/eet_image.c @@ -1577,6 +1577,9 @@ eet_data_image_encode_cipher(const void *data, unsigned int ciphered_sz = 0; int size = 0; + if (!data) + return NULL; + switch (lossy) { case EET_IMAGE_LOSSLESS: @@ -1688,6 +1691,9 @@ eet_data_image_header_advance_decode_cipher(const void *data, unsigned int deciphered_sz = 0; int r = 0; + if (!data) + return NULL; + if (cipher_key) { if (!eet_decipher(data, size, cipher_key, strlen(cipher_key), @@ -2083,6 +2089,9 @@ eet_data_image_decode_cipher(const void *data, void *deciphered_d = NULL; unsigned int deciphered_sz = 0; + if (!data) + return NULL; + if (cipher_key) { if (!eet_decipher(data, size, cipher_key, strlen(cipher_key), @@ -2171,6 +2180,9 @@ eet_data_image_decode_to_cspace_surface_cipher(const void *data, void *deciphered_d = NULL; unsigned int deciphered_sz = 0; + if (!data) + return NULL; + if (cipher_key) { if (!eet_decipher(data, size, cipher_key, strlen(cipher_key), --
Re: [E-devel] [EGIT] [tools/clouseau] master 01/01: return 0 from main()
Shouldn't these return anything but 0? If these are in main(), returning 0 would mean the program terminated successfully, which is not the case here. Jean On Fri, Nov 11, 2016 at 6:54 PM, Shuhrat Dehkanov wrote: > cedric pushed a commit to branch master. > > http://git.enlightenment.org/tools/clouseau.git/commit/?id=9f62d5914032c3d159f40b8e32e1901b145ec654 > > commit 9f62d5914032c3d159f40b8e32e1901b145ec654 > Author: Shuhrat Dehkanov > Date: Fri Nov 11 09:47:01 2016 -0800 > > return 0 from main() > > Summary: > Although, underlying value of EINA_FALSE is 0 the type former is Bool. > Hence, for the sake of consistency, let's return 0 from main(). > > Reviewers: jeanguyomarch, jeyzu > > Subscribers: hyunseok, minkyu > > Differential Revision: https://phab.enlightenment.org/D4392 > > Signed-off-by: Cedric Bail > --- > src/bin/clouseau_client.c | 2 +- > src/bin/clouseaud.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/bin/clouseau_client.c b/src/bin/clouseau_client.c > index 32fcb0a..7d57fe4 100644 > --- a/src/bin/clouseau_client.c > +++ b/src/bin/clouseau_client.c > @@ -2390,7 +2390,7 @@ main(int argc, char **argv) > if (_clouseau_client_log_dom < 0) > { > EINA_LOG_ERR("Could not register log domain: %s", log_dom); > -return EINA_FALSE; > +return 0; > } > > Evas_Object *win, *panes, *frame; > diff --git a/src/bin/clouseaud.c b/src/bin/clouseaud.c > index aa43089..93d57f8 100644 > --- a/src/bin/clouseaud.c > +++ b/src/bin/clouseaud.c > @@ -403,7 +403,7 @@ int main(void) > if (_clouseaud_log_dom < 0) > { > EINA_LOG_ERR("Could not register log domain: %s", log_dom); > -return EINA_FALSE; > +return 0; > } > > if (!(server = ecore_con_server_add(ECORE_CON_REMOTE_TCP | > ECORE_CON_SOCKET_ACTIVATE, > > -- > > -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [tools/clouseau] master 01/01: return 0 from main()
It should. Got lazy because they are highly unlikely error. Will fix that. Cedric On Fri, Nov 11, 2016 at 10:15 AM, Jean Guyomarc'h wrote: > Shouldn't these return anything but 0? If these are in main(), > returning 0 would mean the program terminated successfully, which is > not the case here. > Jean > > > On Fri, Nov 11, 2016 at 6:54 PM, Shuhrat Dehkanov wrote: >> cedric pushed a commit to branch master. >> >> http://git.enlightenment.org/tools/clouseau.git/commit/?id=9f62d5914032c3d159f40b8e32e1901b145ec654 >> >> commit 9f62d5914032c3d159f40b8e32e1901b145ec654 >> Author: Shuhrat Dehkanov >> Date: Fri Nov 11 09:47:01 2016 -0800 >> >> return 0 from main() >> >> Summary: >> Although, underlying value of EINA_FALSE is 0 the type former is Bool. >> Hence, for the sake of consistency, let's return 0 from main(). >> >> Reviewers: jeanguyomarch, jeyzu >> >> Subscribers: hyunseok, minkyu >> >> Differential Revision: https://phab.enlightenment.org/D4392 >> >> Signed-off-by: Cedric Bail >> --- >> src/bin/clouseau_client.c | 2 +- >> src/bin/clouseaud.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/bin/clouseau_client.c b/src/bin/clouseau_client.c >> index 32fcb0a..7d57fe4 100644 >> --- a/src/bin/clouseau_client.c >> +++ b/src/bin/clouseau_client.c >> @@ -2390,7 +2390,7 @@ main(int argc, char **argv) >> if (_clouseau_client_log_dom < 0) >> { >> EINA_LOG_ERR("Could not register log domain: %s", log_dom); >> -return EINA_FALSE; >> +return 0; >> } >> >> Evas_Object *win, *panes, *frame; >> diff --git a/src/bin/clouseaud.c b/src/bin/clouseaud.c >> index aa43089..93d57f8 100644 >> --- a/src/bin/clouseaud.c >> +++ b/src/bin/clouseaud.c >> @@ -403,7 +403,7 @@ int main(void) >> if (_clouseaud_log_dom < 0) >> { >> EINA_LOG_ERR("Could not register log domain: %s", log_dom); >> -return EINA_FALSE; >> +return 0; >> } >> >> if (!(server = ecore_con_server_add(ECORE_CON_REMOTE_TCP | >> ECORE_CON_SOCKET_ACTIVATE, >> >> -- >> >> > > -- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Cedric BAIL -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [tools/clouseau] master 01/01: actually returning a value != from 0 would be more useful.
cedric pushed a commit to branch master. http://git.enlightenment.org/tools/clouseau.git/commit/?id=11c42ebdf9cb93a08b0a16b2eac02f3ce47132fa commit 11c42ebdf9cb93a08b0a16b2eac02f3ce47132fa Author: Cedric Bail Date: Fri Nov 11 10:55:16 2016 -0800 actually returning a value != from 0 would be more useful. --- src/bin/clouseau_client.c | 2 +- src/bin/clouseaud.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/clouseau_client.c b/src/bin/clouseau_client.c index 7d57fe4..8ea7990 100644 --- a/src/bin/clouseau_client.c +++ b/src/bin/clouseau_client.c @@ -2390,7 +2390,7 @@ main(int argc, char **argv) if (_clouseau_client_log_dom < 0) { EINA_LOG_ERR("Could not register log domain: %s", log_dom); -return 0; +return 3; } Evas_Object *win, *panes, *frame; diff --git a/src/bin/clouseaud.c b/src/bin/clouseaud.c index 93d57f8..6267b7c 100644 --- a/src/bin/clouseaud.c +++ b/src/bin/clouseaud.c @@ -403,7 +403,7 @@ int main(void) if (_clouseaud_log_dom < 0) { EINA_LOG_ERR("Could not register log domain: %s", log_dom); -return 0; +return 3; } if (!(server = ecore_con_server_add(ECORE_CON_REMOTE_TCP | ECORE_CON_SOCKET_ACTIVATE, --
[EGIT] [core/efl] master 01/01: elementary-cxx: Removed example from datetime
felipealmeida pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=5929f0311dfc12dac3f38b8f29802e3fa2d0e2d7 commit 5929f0311dfc12dac3f38b8f29802e3fa2d0e2d7 Author: Felipe Magno de Almeida Date: Fri Nov 11 18:06:53 2016 -0200 elementary-cxx: Removed example from datetime --- src/examples/elementary/Makefile.am | 6 --- src/examples/elementary/datetime_cxx_example.cc | 60 - 2 files changed, 66 deletions(-) diff --git a/src/examples/elementary/Makefile.am b/src/examples/elementary/Makefile.am index 0e91f9a..3e11f1e 100644 --- a/src/examples/elementary/Makefile.am +++ b/src/examples/elementary/Makefile.am @@ -185,7 +185,6 @@ calendar_cxx_example_03.cc \ calendar_cxx_example_04.cc \ calendar_cxx_example_05.cc \ clock_cxx_example.cc \ -datetime_cxx_example.cc \ icon_cxx_example_01.cc \ button_cxx_example_00.cc endif @@ -286,7 +285,6 @@ conformant_example_01 \ conformant_example_02 \ combobox_example_01 \ ctxpopup_example_01 \ -datetime_example \ dayselector_example \ diskselector_example_01 \ diskselector_example_02 \ @@ -408,7 +406,6 @@ calendar_cxx_example_03 \ calendar_cxx_example_04 \ calendar_cxx_example_05 \ clock_cxx_example \ -datetime_cxx_example \ icon_cxx_example_01 \ button_cxx_example_00 # examples_PROGRAMS += \ @@ -423,7 +420,6 @@ button_cxx_example_00 # icon_cxx_example_01 \ # hoversel_cxx_example_01 \ # glview_cxx_example_01 \ -# datetime_cxx_example \ # clock_cxx_example \ # calendar_cxx_example_05 \ # calendar_cxx_example_04 \ @@ -451,7 +447,6 @@ endif if HAVE_CXX11 icon_cxx_example_01_SOURCES = icon_cxx_example_01.cc -datetime_cxx_example_SOURCES = datetime_cxx_example.cc clock_cxx_example_SOURCES = clock_cxx_example.cc calendar_cxx_example_05_SOURCES = calendar_cxx_example_05.cc calendar_cxx_example_04_SOURCES = calendar_cxx_example_04.cc @@ -472,7 +467,6 @@ button_cxx_example_00_SOURCES = button_cxx_example_00.cc # icon_cxx_example_01_SOURCES = icon_cxx_example_01.cc # hoversel_cxx_example_01_SOURCES = hoversel_cxx_example_01.cc # glview_cxx_example_01_SOURCES = glview_cxx_example_01.cc -# datetime_cxx_example_SOURCES = datetime_cxx_example.cc # clock_cxx_example_SOURCES = clock_cxx_example.cc # calendar_cxx_example_05_SOURCES = calendar_cxx_example_05.cc # calendar_cxx_example_04_SOURCES = calendar_cxx_example_04.cc diff --git a/src/examples/elementary/datetime_cxx_example.cc b/src/examples/elementary/datetime_cxx_example.cc deleted file mode 100644 index d47a054..000 --- a/src/examples/elementary/datetime_cxx_example.cc +++ /dev/null @@ -1,60 +0,0 @@ -#ifdef HAVE_CONFIG_H -#include "config.h" -#include "elementary_config.h" -#endif - -#include - -EAPI_MAIN int -elm_main (int argc, char *argv[]) -{ - elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_HIDDEN); - - efl::ui::win::Standard win; - //win.title_set("Datetime"); - win.autohide_set(true); - - //::elm::Bg bg(efl::eo::parent = win); - //bg.size_hint_weight_set(EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); - //win.resize_object_add(bg); - //bg.efl::Gfx::size_set(100,100); - //bg.visible_set(true); - - efl::ui::Box bx(win); - //bx.size_hint_weight_set(EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); - //win.resize_object_add(bx); - bx.eo_cxx::efl::Gfx::size_set(20,20); - bx.visible_set(true); - - ::elm::Datetime datetime(bx); - // datetime.size_hint_weight_set(EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); - // datetime.size_hint_align_set(EVAS_HINT_FILL, EVAS_HINT_FILL); - datetime.field_visible_set(ELM_DATETIME_HOUR, false); - datetime.field_visible_set(ELM_DATETIME_MINUTE, false); - datetime.field_visible_set(ELM_DATETIME_AMPM, false); - //bx.pack_end(datetime); - datetime.visible_set(true); - - ::elm::Datetime datetime2(bx); - // datetime2.size_hint_weight_set(EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); - // datetime2.size_hint_align_set(EVAS_HINT_FILL, 0.5); - datetime2.field_visible_set(ELM_DATETIME_YEAR, false); - datetime2.field_visible_set(ELM_DATETIME_MONTH, false); - datetime2.field_visible_set(ELM_DATETIME_DATE, false); - //bx.pack_end(datetime2); - datetime2.eo_cxx::efl::Gfx::size_set(200,150); - datetime2.visible_set(true); - - ::elm::Datetime datetime3(bx); - // datetime3.size_hint_weight_set(EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); - // datetime3.size_hint_align_set(EVAS_HINT_FILL, 0.5); - //bx.pack_end(datetime3); - datetime3.eo_cxx::efl::Gfx::size_set(200,280); - datetime3.visible_set(true); - - win.visible_set(true); - - elm_run(); - return 0; -} -ELM_MAIN() --
Re: [E-devel] [EGIT] [tools/clouseau] master 01/01: return 0 from main()
Oh well, I was actually just replacing EINA_FALSE with its actual value.. But yes, I should have been a little more attentive. On Sat, Nov 12, 2016 at 3:27 AM, Cedric BAIL wrote: > It should. Got lazy because they are highly unlikely error. Will fix that. > > Cedric > > On Fri, Nov 11, 2016 at 10:15 AM, Jean Guyomarc'h > wrote: > > Shouldn't these return anything but 0? If these are in main(), > > returning 0 would mean the program terminated successfully, which is > > not the case here. > > Jean > > > > > > On Fri, Nov 11, 2016 at 6:54 PM, Shuhrat Dehkanov wrote: > >> cedric pushed a commit to branch master. > >> > >> http://git.enlightenment.org/tools/clouseau.git/commit/?id= > 9f62d5914032c3d159f40b8e32e1901b145ec654 > >> > >> commit 9f62d5914032c3d159f40b8e32e1901b145ec654 > >> Author: Shuhrat Dehkanov > >> Date: Fri Nov 11 09:47:01 2016 -0800 > >> > >> return 0 from main() > >> > >> Summary: > >> Although, underlying value of EINA_FALSE is 0 the type former is > Bool. > >> Hence, for the sake of consistency, let's return 0 from main(). > >> > >> Reviewers: jeanguyomarch, jeyzu > >> > >> Subscribers: hyunseok, minkyu > >> > >> Differential Revision: https://phab.enlightenment.org/D4392 > >> > >> Signed-off-by: Cedric Bail > >> --- > >> src/bin/clouseau_client.c | 2 +- > >> src/bin/clouseaud.c | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/src/bin/clouseau_client.c b/src/bin/clouseau_client.c > >> index 32fcb0a..7d57fe4 100644 > >> --- a/src/bin/clouseau_client.c > >> +++ b/src/bin/clouseau_client.c > >> @@ -2390,7 +2390,7 @@ main(int argc, char **argv) > >> if (_clouseau_client_log_dom < 0) > >> { > >> EINA_LOG_ERR("Could not register log domain: %s", log_dom); > >> -return EINA_FALSE; > >> +return 0; > >> } > >> > >> Evas_Object *win, *panes, *frame; > >> diff --git a/src/bin/clouseaud.c b/src/bin/clouseaud.c > >> index aa43089..93d57f8 100644 > >> --- a/src/bin/clouseaud.c > >> +++ b/src/bin/clouseaud.c > >> @@ -403,7 +403,7 @@ int main(void) > >> if (_clouseaud_log_dom < 0) > >> { > >> EINA_LOG_ERR("Could not register log domain: %s", log_dom); > >> -return EINA_FALSE; > >> +return 0; > >> } > >> > >> if (!(server = ecore_con_server_add(ECORE_CON_REMOTE_TCP | > ECORE_CON_SOCKET_ACTIVATE, > >> > >> -- > >> > >> > > > > > -- > > Developer Access Program for Intel Xeon Phi Processors > > Access to Intel Xeon Phi processor-based developer platforms. > > With one year of Intel Parallel Studio XE. > > Training and support from Colfax. > > Order your platform today. http://sdm.link/xeonphi > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > -- > Cedric BAIL > > > -- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [RFC] Ecore_Getopt STORE_DEF_* is strange
Hi all, I was using Ecore_Getopt with the STORE_DEF_* feature and noticed something I find quite strange, I could qualify as disturbing. The default storage thing seems very odd. (1) Values associated to optional parameters are not handled properly If you run the example, with minimal required arguments (e.g. ./src/examples/ecore/ecore_getopt_example string 33 banana zz), you will get the following (snipped): default-string = (null) default-bool = false default-short = 0 default-int = 0 default-long = 0 default-unsigned-short = 0 default-unsigned-int = 0 default-unsigned-long = 0 default-double = 0.00 The default -* things are values that are supposed to be default values. And they are all wrong. This is even specified in the automatic help of the same program (snipped): --default-string[=DEFAULT-STRING] Store a single string. Type: STR. Default: default-string-value. --default-bool[=DEFAULT-BOOL] Store a single boolean. Type: BOOL. Default: true. --default-short[=DEFAULT-SHORT] Store a single short. Type: SHORT. Default: 123. --default-int[=DEFAULT-INT] Store a single integer. Type: INT. Default: 1234. --default-long[=DEFAULT-LONG] Store a single long integer. Type: LONG. Default: 12345. --default-unsigned-short[=DEFAULT-UNSIGNED-SHORT] Store a single unsigned short integer. Type: USHORT. Default: 123. --default-unsigned-int[=DEFAULT-UNSIGNED-INT] Store a single unsigned integer. Type: UINT. Default: 1234. --default-unsigned-long[=DEFAULT-UNSIGNED-LONG] Store a single unsigned long integer. Type: ULONG. Default: 12345. --default-double[=DEFAULT-DOUBLE] Store a single double. Type: DOUBLE. Default: 12.345000. Every single use of the STORE_DEF stuff (in Ecore_Getopt) I've seen was to manually assign the variable containing the default value to the default value. To illustrate this, one typically mentions the default value in the Ecore_Getopt descriptor: ECORE_GETOPT_STORE_DEF_SHORT(0, "default-short", "Store a single short", 123), and pass this identical value to the Ecore_Getopt_Value thing: short def_val = 123; /* << Same than above */ Ecore_Getopt_Value values[] = { ECORE_GETOPT_VALUE_SHORT(&def_val), }; This behaviour seems very wrong to me, because the implementation of the default value is not left to the getopt but up to the developer. And the developer should not do that. It should provide the default value to the getopt (what it already does) and that's it. If it (mistakenly) affects to the 'def_val' variable in our previous example something different than what it has wirtten in the getopt descriptor, the help and the actual default value will mismatch. That's actually the case in the ecore_getopt example. The code tht the developer has to write should just be: short def_val; /* << default value, automatically assigned, nothing to do here */ Ecore_Getopt_Value values[] = { ECORE_GETOPT_VALUE_SHORT(&def_val), }; And after parsing, boom, "def_val" will contain the value specified by the programmer, or something else if the user has provided the option that allows to change the default value. (2) You can pass an option with phantom parameters to trigger the default values It gets a bit creepy when looking at the code of Ecore_Getopt. The default value affectation is of course already implemented, but is triggered when the option is provided without value... which I think does not make sense, at all. To illustrate, if I slightly alter my call to the example program: ./src/examples/ecore/ecore_getopt_example string 33 banana zz --default-string I get this (snipped): default-string = default-string-value default-bool = false default-short = 0 default-int = 0 default-long = 0 default-unsigned-short = 0 default-unsigned-int = 0 default-unsigned-long = 0 default-double = 0.00 So now, I have my default value, as specified in the help. But to do so, I actually needed to provide the name of the option without any parameter!? It feels very disturbing. I think such use of the option without any parameter should have errored. Imagine a network application that connects to port 8080 by default. This port can be changed with the --port option that takes exactly one argument (the port number). You could call your program like this: ./myprogram --port 993 The value will be set to 993, seems legit. But then, I can do this: ./myprogram --port And that's okay too... The port value would be set to 8080 (the default). What!? To me, that's just not right. So, here were my grieves. But I'm a man of