[ewg] [OPENSM] use standard varargs syntax in macro OSM_LOG()
Signed-off-by: Stan Smith (stan.sm...@intel.com) diff --git a/opensm/include/opensm/osm_log.h b/opensm/include/opensm/osm_log.h index 20999d9..135e752 100644 --- a/opensm/include/opensm/osm_log.h +++ b/opensm/include/opensm/osm_log.h @@ -390,10 +390,10 @@ extern void osm_log_msg_box(osm_log_t *log, osm_log_level_t level, extern void osm_log_raw(IN osm_log_t * const p_log, IN const osm_log_level_t verbosity, IN const char *p_buf); -#define OSM_LOG(log, level, fmt, arg...) do { \ - if (osm_log_is_active(log, (level))) \ - osm_log(log, level, "%s: " fmt, __func__, ##arg); \ - } while (0) +#define OSM_LOG(log, level, fmt, ...) do { \ + if (osm_log_is_active(log, (level))) \ + osm_log(log, level, "%s: " fmt, __func__, ## __VA_ARGS__); \ +} while (0) #define OSM_LOG_MSG_BOX(log, level, msg) \ osm_log_msg_box(log, level, __func__, msg) inc_opensm.pat Description: Binary data ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] RE: [ofw] [OPENSM] add Windows syntax for varags in a macro
>>> +#ifdef __WIN__ >>> +#define OSM_LOG(log, level, fmt, ...) \ >>> +do { \ >>> + if (osm_log_is_active(log, (level))) \ >>> + osm_log(log, level, "%s: " fmt, __func__, ## __VA_ARGS__); \ >> >> __VA_ARGS__ should work on any platform. libibmad : mad.h uses this >> for windows and linux. >> >>> +} while (0) >>> +#else >>> #define OSM_LOG(log, level, fmt, arg...) do { \ >>> if (osm_log_is_active(log, (level))) \ >>> osm_log(log, level, "%s: " fmt, __func__, ##arg); \ } while >(0) >>> +#endif > >As coded it would not compile. I'm suggesting to remove the #ifdef __WIN__ and remove the #else code. ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] RE: [ofw] [OPENSM] add Windows syntax for varags in a macro
Hefty, Sean wrote: >> +#ifdef __WIN__ >> +#define OSM_LOG(log, level, fmt, ...) \ >> +do { \ >> +if (osm_log_is_active(log, (level))) \ >> +osm_log(log, level, "%s: " fmt, __func__, ## __VA_ARGS__); \ > > __VA_ARGS__ should work on any platform. libibmad : mad.h uses this > for windows and linux. > >> +} while (0) >> +#else >> #define OSM_LOG(log, level, fmt, arg...) do { \ >> if (osm_log_is_active(log, (level))) \ >> osm_log(log, level, "%s: " fmt, __func__, ##arg); \ >> } while (0) >> +#endif As coded it would not compile. ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] RE: [ofw] [OPENSM] add Windows syntax for varags in a macro
>+#ifdef __WIN__ >+#define OSM_LOG(log, level, fmt, ...) \ >+do { \ >+ if (osm_log_is_active(log, (level))) \ >+ osm_log(log, level, "%s: " fmt, __func__, ## __VA_ARGS__); \ __VA_ARGS__ should work on any platform. libibmad : mad.h uses this for windows and linux. >+} while (0) >+#else > #define OSM_LOG(log, level, fmt, arg...) do { \ > if (osm_log_is_active(log, (level))) \ > osm_log(log, level, "%s: " fmt, __func__, ##arg); \ > } while (0) >+#endif ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] [OPENSM] add Windows syntax for varags in a macro
Hello, Adding Windows version of OSM_LOG macro to accommodate windows syntax for cpp varargs. Signed-off-by: Stan Smith (stan.sm...@intel.com) diff --git a/opensm/include/opensm/osm_log.h b/opensm/include/opensm/osm_log.h index 20999d9..54c8ea4 100644 --- a/opensm/include/opensm/osm_log.h +++ b/opensm/include/opensm/osm_log.h @@ -390,10 +390,18 @@ extern void osm_log_msg_box(osm_log_t *log, osm_log_level_t level, extern void osm_log_raw(IN osm_log_t * const p_log, IN const osm_log_level_t verbosity, IN const char *p_buf); +#ifdef __WIN__ +#define OSM_LOG(log, level, fmt, ...) \ +do { \ + if (osm_log_is_active(log, (level))) \ + osm_log(log, level, "%s: " fmt, __func__, ## __VA_ARGS__); \ +} while (0) +#else #define OSM_LOG(log, level, fmt, arg...) do { \ if (osm_log_is_active(log, (level))) \ osm_log(log, level, "%s: " fmt, __func__, ##arg); \ } while (0) +#endif #define OSM_LOG_MSG_BOX(log, level, msg) \ ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] [OPENSM] update functions to match .h prototypes
Hello, The following patches address inconsistencies between header file function prototypes and .c function definitions; missing 'const' attribute. Attached is a Linux EOL patch file in case a mailer hacks/reformats the text. Signed-off-by: Stan Smith (stan.sm...@intel.com) diff --git a/opensm/opensm/osm_inform.c b/opensm/opensm/osm_inform.c index 9b451bd..7d55a06 100644 --- a/opensm/opensm/osm_inform.c +++ b/opensm/opensm/osm_inform.c @@ -61,7 +61,7 @@ typedef struct osm_infr_match_ctxt { /** **/ -void osm_infr_delete(IN osm_infr_t * p_infr) +void osm_infr_delete(IN osm_infr_t * const p_infr) { free(p_infr); } @@ -214,7 +214,7 @@ Exit: **/ osm_infr_t *osm_infr_get_by_rec(IN osm_subn_t const *p_subn, IN osm_log_t * p_log, - IN osm_infr_t * p_infr_rec) + IN osm_infr_t * const p_infr_rec) { cl_list_item_t *p_list_item; @@ -572,7 +572,7 @@ static void log_notice(osm_log_t * log, osm_log_level_t level, sizeof gid_str)); } -ib_api_status_t osm_report_notice(IN osm_log_t * p_log, IN osm_subn_t * p_subn, +ib_api_status_t osm_report_notice(IN osm_log_t * const p_log, IN osm_subn_t * p_subn, IN ib_mad_notice_attr_t * p_ntc) { osm_infr_match_ctxt_t context; diff --git a/opensm/opensm/osm_lid_mgr.c b/opensm/opensm/osm_lid_mgr.c index 34625ba..8b620c3 100644 --- a/opensm/opensm/osm_lid_mgr.c +++ b/opensm/opensm/osm_lid_mgr.c @@ -106,14 +106,14 @@ typedef struct osm_lid_mgr_range { /** **/ -void osm_lid_mgr_construct(IN osm_lid_mgr_t * p_mgr) +void osm_lid_mgr_construct(IN osm_lid_mgr_t * const p_mgr) { memset(p_mgr, 0, sizeof(*p_mgr)); } /** **/ -void osm_lid_mgr_destroy(IN osm_lid_mgr_t * p_mgr) +void osm_lid_mgr_destroy(IN osm_lid_mgr_t * const p_mgr) { cl_list_item_t *p_item; @@ -224,7 +224,7 @@ Exit: /** **/ -ib_api_status_t osm_lid_mgr_init(IN osm_lid_mgr_t * p_mgr, IN osm_sm_t * sm) +ib_api_status_t osm_lid_mgr_init(IN osm_lid_mgr_t * const p_mgr, IN osm_sm_t * sm) { ib_api_status_t status = IB_SUCCESS; @@ -1145,7 +1145,7 @@ Exit: /** **/ -int osm_lid_mgr_process_sm(IN osm_lid_mgr_t * p_mgr) +int osm_lid_mgr_process_sm(IN osm_lid_mgr_t * const p_mgr) { int ret; @@ -1173,7 +1173,7 @@ int osm_lid_mgr_process_sm(IN osm_lid_mgr_t * p_mgr) 1.2 if a change is required send the port info 2 if any change send the signal PENDING... **/ -int osm_lid_mgr_process_subnet(IN osm_lid_mgr_t * p_mgr) +int osm_lid_mgr_process_subnet(IN osm_lid_mgr_t * const p_mgr) { cl_qmap_t *p_port_guid_tbl; osm_port_t *p_port; diff --git a/opensm/opensm/osm_sa_mcmember_record.c b/opensm/opensm/osm_sa_mcmember_record.c index c80dae7..bd4245b 100644 --- a/opensm/opensm/osm_sa_mcmember_record.c +++ b/opensm/opensm/osm_sa_mcmember_record.c @@ -888,7 +888,7 @@ osm_mgrp_t *osm_get_mgrp_by_mgid(IN osm_sa_t * sa, IN ib_gid_t * p_mgid) ib_api_status_t osm_mcmr_rcv_find_or_create_new_mgrp(IN osm_sa_t * sa, IN ib_net64_t comp_mask, IN ib_member_rec_t * -p_recvd_mcmember_rec, +const p_recvd_mcmember_rec, OUT osm_mgrp_t ** pp_mgrp) { opensm.pat Description: Binary data ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] [ANNOUNCE] libcxgb3 1.2.4 released
The libcxgb3 package is a userspace driver for Chelsio T3 iWARP RNICs. It is a plug-in module for libibverbs that allows programs to use Chelsio RDMA hardware directly from userspace. A new release, libcxgb3-1.2.4, is available from http://www.openfabrics.org/downloads/cxgb3/libcxgb3-1.2.4.tar.gz with md5sum d445ec6ee3004b78b43d069dcb99d836 libcxgb3-1.2.4.tar.gz This minor release fixes a bug where the qp attribute sq_sig_all was being ignored by libcxgb3. Vlad: Please pull this into ofed-1.5. Thanks, Steve. ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] Re: [ofa-general] help install ofed 1.4 on Centos 5.2
On Mon, 2009-09-28 at 10:45 -0500, Jon Mason wrote: > > The issue is having customers breaking when installing OFED due to them using > a kernel that was not in existance when that version of OFED shipped (and > thus should not be supported). This should be prevented from occuring (and > should be fairly easy to do). Agreed. It should be obvious, very early that the desired kernel is not (yet) supported. > There will always be a window between the latest kernel coming out (of > whatever flavor) and OFED's support of it. Indeed. This is even true of Lustre. However that window should not be open until the next "scheduled" release given that the release cycle is 6 months or more. We cut new releases that contain just the new kernel support when new kernels warrant it. I guess that's all I'm saying. > Unless OFED is changed to a release model where its releases coincide with > distro releases. That doesn't work either. There will always be unscheduled errata releases made to deal with urgent issues. I guess what I am promoting here is "bugfix" OFED releases that include newer kernel backport support on an as-needed basis. b. signature.asc Description: This is a digitally signed message part ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] Re: [ofa-general] help install ofed 1.4 on Centos 5.2
On Mon, Sep 28, 2009 at 11:33:29AM -0400, Brian J. Murrell wrote: > On Mon, 2009-09-28 at 10:07 -0500, Jon Mason wrote: > > > > We should add a upper limit for the kernels supported in the install > > script. So that when new kernels come out, we could very cleanly say > > that it is not supported. > > If I'm understanding you, you are addressing the issue of OFED not > building with a newer kernel than it was originally written to support. > I suppose to short-circuit the eventual build failure? > > If so, that doesn't deal at all with the real-world issue of leaving > people between the rock and hard place of having to either run > vulnerable kernels or alpha/beta quality OFED software. The issue is having customers breaking when installing OFED due to them using a kernel that was not in existance when that version of OFED shipped (and thus should not be supported). This should be prevented from occuring (and should be fairly easy to do). There will always be a window between the latest kernel coming out (of whatever flavor) and OFED's support of it. Unless OFED is changed to a release model where its releases coincide with distro releases. thanks, Jon > > b. > > ___ > ewg mailing list > ewg@lists.openfabrics.org > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] Re: [ofa-general] help install ofed 1.4 on Centos 5.2
On Mon, 2009-09-28 at 10:07 -0500, Jon Mason wrote: > > We should add a upper limit for the kernels supported in the install > script. So that when new kernels come out, we could very cleanly say > that it is not supported. If I'm understanding you, you are addressing the issue of OFED not building with a newer kernel than it was originally written to support. I suppose to short-circuit the eventual build failure? If so, that doesn't deal at all with the real-world issue of leaving people between the rock and hard place of having to either run vulnerable kernels or alpha/beta quality OFED software. b. signature.asc Description: This is a digitally signed message part ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] [GIT PULL ofed-1.5] iw_cxgb3 RHEL4 backport patches
Vlad, Please pull from: ssh://v...@sofa.openfabrics.org/~swise/scm/ofed_kernel.git ofed_1_5 This commit pulls in iw_cxgb3 backport patches for RHEL4 that were lost going from 1.4 to 1.5. It resolves bug 1737. Steve. commit c64b965f7d03f7d920042c63d5ac529fe243a4ab Author: Steve Wise Date: Mon Sep 28 08:59:21 2009 -0500 cxgb3: pull in ofed-1.4 RHEL4 backport patch. Missed this one. Signed-off-by: Steve Wise .../2.6.9_U6/iw_cxgb3_0030_setpagereserved.patch | 127 .../2.6.9_U7/iw_cxgb3_0030_setpagereserved.patch | 127 2 files changed, 254 insertions(+), 0 deletions(-) ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] Re: [ofa-general] help install ofed 1.4 on Centos 5.2
On Mon, Sep 28, 2009 at 10:15:08AM -0400, Brian J. Murrell wrote: > On Mon, 2009-09-28 at 09:42 +0200, Vladimir Sokolovsky wrote: > > > > Hi Chris, > > Kernel 2.6.18-164.el5 comes from RHEL5.4 and is not supported by OFED-1.4.X. > > You should try OFED-1.5. > > This is a problem we run into with Lustre somewhat frequently. > > The issue is that deploying OFED 1.5 (i.e. beta software) in a > production environment is completely unacceptable, yet leaving one's > systems open to kernel vulnerabilities is equally unacceptable. We should add a upper limit for the kernels supported in the install script. So that when new kernels come out, we could very cleanly say that it is not supported. Thoughts? Thanks, Jon > > By not backporting support for current kernels to the latest stable OFED > release you are putting people between a rock and a hard place. > > b. > > ___ > general mailing list > gene...@lists.openfabrics.org > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general > > To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] ofed-1.5 and RHEL4.8
Hey Tziporet, Is ofed-1.5 supposed to support RHEL4.8? I see no backports... Steve. ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg