Re: make(1) patches to bypass quietness prescribed by @-prefixed commands in Makefiles
On Sun, May 14, 2000 at 02:50:02PM -0500, Steve Price wrote: > I too like this idea and along the lines of what Lyndon suggested > how about the attached patch instead? This is a better patch to the proposed functionality. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: make(1) patches to bypass quietness prescribed by @-prefixed commands in Makefiles
On Sun, May 14, 2000 at 03:46:40PM -0400, Will Andrews wrote: > Ok, what do other people think? I mean, it'd be easy to change the flag to > use this feature. -dl seems fine for this particular feature. -d is a better place to put this than "-l", as this is a debugging feature. -- -- David([EMAIL PROTECTED]) To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: make(1) patches to bypass quietness prescribed by @-prefixed commands in Makefiles
Chuck> Compatibility with those other makes is pretty low to begin Chuck> with, but it doesn't hurt, I guess, to allow for this. -dl Chuck> is ok with me. I just wouldn't consider the compatibility Chuck> thing a real issue if it weren't this easy to satisfy. It's not a big deal for me. I just get annoyed at all the seemingly gratuitous incompatibilities between the different versions of something as fundamental as make. --lyndon To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: make(1) patches to bypass quietness prescribed by @-prefixed commands in Makefiles
On Sun, May 14, 2000 at 01:25:16PM -0600, Lyndon Nerenberg wrote: > I like the idea, but the -l flag conflicts with a different usage for > SVR4 derived makes (on at least AIX, Irix, and Solaris): > > -l load >Specifies that no new jobs (commands) should be started >if there are others jobs running and the load average >is at least load (a floating-point number). With no >argument, removes a previous load limit. > > Maybe this should instead be a -d sub-option? > > And I like the idea of adding the -l functionality described above. Ok, what do other people think? I mean, it'd be easy to change the flag to use this feature. -dl seems fine for this particular feature. -- Will Andrews <[EMAIL PROTECTED]> GCS/E/S @d- s+:+>+:- a--->+++ C++ UB P+ L- E--- W+++ !N !o ?K w--- ?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++> DI+++ D+ G++>+++ e-> h! r-->+++ y? To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: make(1) patches to bypass quietness prescribed by @-prefixed commands in Makefiles
I like the idea, but the -l flag conflicts with a different usage for SVR4 derived makes (on at least AIX, Irix, and Solaris): -l load Specifies that no new jobs (commands) should be started if there are others jobs running and the load average is at least load (a floating-point number). With no argument, removes a previous load limit. Maybe this should instead be a -d sub-option? And I like the idea of adding the -l functionality described above. --lyndon To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: make(1) patches to bypass quietness prescribed by @-prefixed commands in Makefiles
It sounds like a useful feature to me. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 [EMAIL PROTECTED] | TCP/IP since RFC 956 FreeBSD coreteam member | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
make(1) patches to bypass quietness prescribed by @-prefixed commands in Makefiles
Hi all,
Some time ago I was complaining about how there is no way to force make(1)
to display the commands executed by @-prefixed commands in Makefiles. So I
went around and talked to a few people and one guy clued me in on how I
would add something like this (sorry, I don't remember the name right now
as this was a few weeks ago..).
This option is useful for people with complex Makefile hierarchies who
cannot simply insert a `@${ECHO} "SOMEVAR = ${SOMEVAR}"` as needed in their
Makefiles or remove all the @'s in their Makefiles. In particular, I would
use this feature to debug ports.
Attached is the patch. If I can get permission, I'd like to commit this to
code on -current, with a possible MFC in a few weeks (?). I'd like to hear
any complaints about this code, including any style(9) mistakes, whether
this option would be considered bloat, and whether the variable name
``beLoud'' is appropriate in this context. ;-)
Thanks,
--
Will Andrews <[EMAIL PROTECTED]>
GCS/E/S @d- s+:+>+:- a--->+++ C++ UB P+ L- E--- W+++ !N !o ?K w---
?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++> DI+++ D+
G++>+++ e-> h! r-->+++ y?
Index: compat.c
===
RCS file: /extra/cvsroot/src/usr.bin/make/compat.c,v
retrieving revision 1.17
diff -u -r1.17 compat.c
--- compat.c2000/04/14 06:39:10 1.17
+++ compat.c2000/05/13 17:38:22
@@ -241,6 +241,8 @@
while ((*cmd == '@') || (*cmd == '-')) {
if (*cmd == '@') {
silent = TRUE;
+ if (beLoud)
+ silent = FALSE;
} else {
errCheck = FALSE;
}
Index: job.c
===
RCS file: /extra/cvsroot/src/usr.bin/make/job.c,v
retrieving revision 1.17
diff -u -r1.17 job.c
--- job.c 2000/01/17 06:43:40 1.17
+++ job.c 2000/05/13 17:38:12
@@ -556,6 +556,8 @@
while (*cmd == '@' || *cmd == '-') {
if (*cmd == '@') {
shutUp = TRUE;
+ if (beLoud)
+ shutUp = FALSE;
} else {
errOff = TRUE;
}
Index: main.c
===
RCS file: /extra/cvsroot/src/usr.bin/make/main.c,v
retrieving revision 1.35
diff -u -r1.35 main.c
--- main.c 1999/11/23 10:35:24 1.35
+++ main.c 2000/05/13 17:47:35
@@ -138,6 +138,7 @@
BooleanbeVerbose; /* -v flag */
BooleanoldVars;/* variable substitution style */
BooleancheckEnvFirst; /* -e flag */
+BooleanbeLoud; /* -l flag */
LstenvFirstVars; /* (-E) vars to override from env */
static Boolean jobsRunning;/* TRUE if the jobs might be running */
@@ -175,9 +176,9 @@
optind = 1; /* since we're called more than once */
#ifdef REMOTE
-# define OPTFLAGS "BD:E:I:L:PSV:d:ef:ij:km:nqrstv"
+# define OPTFLAGS "BD:E:I:L:PSV:d:ef:ij:klm:nqrstv"
#else
-# define OPTFLAGS "BD:E:I:PSV:d:ef:ij:km:nqrstv"
+# define OPTFLAGS "BD:E:I:PSV:d:ef:ij:klm:nqrstv"
#endif
rearg: while((c = getopt(argc, argv, OPTFLAGS)) != -1) {
switch(c) {
@@ -322,6 +323,10 @@
case 'k':
keepgoing = TRUE;
Var_Append(MAKEFLAGS, "-k", VAR_GLOBAL);
+ break;
+ case 'l':
+ beLoud = TRUE;
+ Var_Append(MAKEFLAGS, "-l", VAR_GLOBAL);
break;
case 'm':
Dir_AddDir(sysIncPath, optarg);
Index: make.h
===
RCS file: /extra/cvsroot/src/usr.bin/make/make.h,v
retrieving revision 1.12
diff -u -r1.12 make.h
--- make.h 1999/09/11 13:17:35 1.12
+++ make.h 2000/05/13 17:41:09
@@ -322,6 +322,8 @@
extern Boolean checkEnvFirst; /* TRUE if environment should be searched for
* all variables before the global context */
+extern Boolean beLoud; /* Force all commands to be outputted; ignores
+* @-prefixes, etc. */
extern Lst envFirstVars; /* List of specific variables for which the
* environment should be searched before the
* global context */
