[gwt-contrib] Trunk does not compile ?
Hi, I am trying to compile the trunk from scratch. I following instructions from the web site but the compilation fails (see log below). Could you help me ? Where is my mistake ? My env: - linux kernel: 2.6.28-11-generic #42-Ubuntu SMP Fri Apr 17 01:57:59 UTC 2009 i686 GNU/Linux - Java: Java HotSpot(TM) Server VM (build 1.5.0_16-b02, mixed mode) - Ant: Apache Ant version 1.7.1 compiled on June 27 2008 Regards, Seb trunk#ant Buildfile: build.xml build: dev: buildtools: build: ant-gwt: compile: [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/out/build-tools/ant-gwt/bin [gwt.javac] Compiling 5 source files to /home/sebastien/work/logiciels/ GWT/src/trunk/build/out/build-tools/ant-gwt/bin build: [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/lib [jar] Building jar: /home/sebastien/work/logiciels/GWT/src/trunk/ build/lib/ant-gwt.jar customchecks: compile: [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/out/build-tools/customchecks/bin [gwt.javac] Compiling 2 source files to /home/sebastien/work/logiciels/ GWT/src/trunk/build/out/build-tools/customchecks/bin build: [jar.bydate] Building jar: /home/sebastien/work/logiciels/GWT/src/ trunk/build/lib/gwt-customchecks.jar doctool: compile: [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/out/build-tools/doctool/bin [gwt.javac] Compiling 13 source files to /home/sebastien/work/ logiciels/GWT/src/trunk/build/out/build-tools/doctool/bin [gwt.javac] Note: Some input files use unchecked or unsafe operations. [gwt.javac] Note: Recompile with -Xlint:unchecked for details. build: [jar.bydate] Building jar: /home/sebastien/work/logiciels/GWT/src/ trunk/build/lib/gwt-doctool.jar -do: build: core: build.alldeps.jar: [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/out/dev/core [jar.bydate] Building jar: /home/sebastien/work/logiciels/GWT/src/ trunk/build/out/dev/core/alldeps.jar build: [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/out/dev/core/bin-dummy [gwt.javac] Compiling 1 source file to /home/sebastien/work/logiciels/ GWT/src/trunk/build/out/dev/core/bin-dummy [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/out/dev/core/bin [gwt.javac] Compiling 4 source files to /home/sebastien/work/logiciels/ GWT/src/trunk/build/out/dev/core/bin [gwt.javac] Compiling 724 source files to /home/sebastien/work/ logiciels/GWT/src/trunk/build/out/dev/core/bin [gwt.javac] Note: Some input files use or override a deprecated API. [gwt.javac] Note: Recompile with -Xlint:deprecation for details. [gwt.javac] Note: Some input files use unchecked or unsafe operations. [gwt.javac] Note: Recompile with -Xlint:unchecked for details. [copy] Copying 1 file to /home/sebastien/work/logiciels/GWT/src/ trunk/build/out/dev/core/bin BUILD FAILED /home/sebastien/work/logiciels/GWT/src/trunk/build.xml:104: The following error occurred while executing this line: /home/sebastien/work/logiciels/GWT/src/trunk/build.xml:26: The following error occurred while executing this line: /home/sebastien/work/logiciels/GWT/src/trunk/build.xml:57: The following error occurred while executing this line: /home/sebastien/work/logiciels/GWT/src/trunk/platforms.ant.xml:36: The following error occurred while executing this line: /home/sebastien/work/logiciels/GWT/src/trunk/platforms.ant.xml:13: The following error occurred while executing this line: /home/sebastien/work/logiciels/GWT/src/trunk/dev/core/build.xml:140: The following error occurred while executing this line: /home/sebastien/work/logiciels/GWT/src/trunk/common.ant.xml:231: svn info didn't get root URL: Chemin : . URL : http://google-web-toolkit.googlecode.com/svn/trunk Racine du dépôt : http://google-web-toolkit.googlecode.com/svn UUID du dépôt : 8db76d5a-ed1c-0410-87a9-c151d255dfc7 Révision : 5651 Type de nœud : répertoire Tâche programmée : normale Auteur de la dernière modification : sco...@google.com Révision de la dernière modification : 5651 Date de la dernière modification: 2009-07-01 03:16:39 +0200 (mer. 01 juil. 2009) --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: HelpRequired : GWT-Incubator: GlassPanel changes
There is a code review out to move GlassPanel to GWT trunk: http://gwt-code-reviews.appspot.com/39806/show http://gwt-code-reviews.appspot.com/39806/showNot sure if it will go through exactly as is, but this should help you isolate the code you need. If you are using GWT trunk, you can just click Download raw patch set and apply the patch to your svn checkout. http://gwt-code-reviews.appspot.com/39806/show Thanks, John LaBanca jlaba...@google.com On Tue, Jun 30, 2009 at 10:06 PM, Fred Sauer fre...@google.com wrote: Surya, In general you should be able to follow along http://code.google.com/p/google-web-toolkit-incubator/wiki/GlassPanel and just include the GlassPanel code in your project as you suggested. Any chance you are using GWT trunk rather than 1.6.4? If so, check to see you have the latest source code which includes the ie8 rule as seen in http://code.google.com/p/google-web-toolkit-incubator/source/browse/trunk/src/com/google/gwt/widgetideas/GlassPanel.gwt.xml Fred On Wed, Jun 24, 2009 at 4:34 AM, Surya master...@gmail.com wrote: Hi , I am fairly new to GWT and my requirement needs a glasspanel to be used. But due to the heavy size of incubator.jar file i would like to just copy the GlassPanel class and GlassPanelImpl into my own workspace and create a custom glasspanel . This would remove the dependency on incubator.jar file. All is well at compile time. But when i compile it , it throws an error saying GlassPanelImpl cannot be abstract Please suggest if i am missing anything. Any help would be greatly appreciated. Thanks and Regards, Surya. On May 5, 5:24 pm, David david.no...@gmail.com wrote: Hi, I just created a trimmed down GlassPanel that only contains what we need. Just as a thought on bug 1186, why not deprecate the ListBox widget and replace it with a custom widget. The standard listbox in the browser is underpowered when it comes to styling. I would like to put more than just strings in there. If that were the case then all these tricks to get dialogs to render correctly while dragging or to cancel events are no longer needed in IE6. David On Tue, May 5, 2009 at 12:49 PM, Thomas Broyer t.bro...@gmail.com wrote: On 5 mai, 10:15, stuckagain david.no...@gmail.com wrote: Hi, We are currently moving to the GWT 1.6 release and also updated to the latest incubator. I am having a problem with the GlassPanel widget in the incubator and looked a bit into the implementation. It has a functionality that it automatically grabs the focus. This functionality is not what we wanted so in a previous version if had just overriden the setFocus method to override this behaviour. We are using the GlassPanel to only block part of our UI when input fields are changed by the user. The side effect is that now when the user changes the input field, after one character, the GlassPanel is shown and the user has to click on the input field again to continue entering data. Could this automatically grabbing the focus be made optional ? Right now I can only see a solution by copying the code and deleting this unwanted functionality since the rework of the component no longer allows me to change the behaviour. the GlassPanel should be usable in more situations than just to block the complete window. I agree, and even in those situations, when used in combination with a modal popup panel, grabbing the focus isn't strictly necessary either (note that PopupPanel does not grab the focus, instead it eats up every event not targeted at the modal popup panel). I do believe actually that the lightbox effect should be done by the popup panel (when modal), as it would also solve issue 1186 [1] (defaulting to being fully transparent) [1]http://code.google.com/p/google-web-toolkit/issues/detail?id=1186 I also see in the code that in onAttach a FocusPanelImpl is attached to the root panel... does this mean that every time I remove the GlassPanel from the page and reattach that it will add another FocusPanelImpl ? That looks like a leak to me (the onDetach does not remove it unless I overlooked it ?) As said on the JavaDoc for this FocusPanelImpl class, it removes itself (it does this as soon as it gains the focus, which it grabs as soon as it's attached to the document). Another comment is the usage of a WindowResizeListener. Isn't this duplicate code from the ResizableWidgetCollection ? GlassPanel has unfortunately not been updated for a while (including for GWT 1.6: uses WindowResizeListener instead of ResizeHandler, EventPreview instead of NativePreviewHandler, etc.). Maybe it's time to rewrite it, and/or split it into more a set of widgets, each one specialized on one thing (lightbox+dialog, cover part of the page, etc.)- Hide quoted text - - Show quoted text - -- Fred Sauer Developer Advocate
[gwt-contrib] Re: Trunk does not compile ?
Hi, I compiled with success by commenting the lines 230-231 in the ./ common.ant.xml Ant file. Indeed the call to svinfo task failed (I do not know why). Now, it works ! Regards, Seb On 1 juil, 09:28, Sebastien chassa...@gmail.com wrote: Hi, I am trying to compile the trunk from scratch. I following instructions from the web site but the compilation fails (see log below). Could you help me ? Where is my mistake ? My env: - linux kernel: 2.6.28-11-generic #42-Ubuntu SMP Fri Apr 17 01:57:59 UTC 2009 i686 GNU/Linux - Java: Java HotSpot(TM) Server VM (build 1.5.0_16-b02, mixed mode) - Ant: Apache Ant version 1.7.1 compiled on June 27 2008 Regards, Seb trunk#ant Buildfile: build.xml build: dev: buildtools: build: ant-gwt: compile: [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/out/build-tools/ant-gwt/bin [gwt.javac] Compiling 5 source files to /home/sebastien/work/logiciels/ GWT/src/trunk/build/out/build-tools/ant-gwt/bin build: [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/lib [jar] Building jar: /home/sebastien/work/logiciels/GWT/src/trunk/ build/lib/ant-gwt.jar customchecks: compile: [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/out/build-tools/customchecks/bin [gwt.javac] Compiling 2 source files to /home/sebastien/work/logiciels/ GWT/src/trunk/build/out/build-tools/customchecks/bin build: [jar.bydate] Building jar: /home/sebastien/work/logiciels/GWT/src/ trunk/build/lib/gwt-customchecks.jar doctool: compile: [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/out/build-tools/doctool/bin [gwt.javac] Compiling 13 source files to /home/sebastien/work/ logiciels/GWT/src/trunk/build/out/build-tools/doctool/bin [gwt.javac] Note: Some input files use unchecked or unsafe operations. [gwt.javac] Note: Recompile with -Xlint:unchecked for details. build: [jar.bydate] Building jar: /home/sebastien/work/logiciels/GWT/src/ trunk/build/lib/gwt-doctool.jar -do: build: core: build.alldeps.jar: [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/out/dev/core [jar.bydate] Building jar: /home/sebastien/work/logiciels/GWT/src/ trunk/build/out/dev/core/alldeps.jar build: [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/out/dev/core/bin-dummy [gwt.javac] Compiling 1 source file to /home/sebastien/work/logiciels/ GWT/src/trunk/build/out/dev/core/bin-dummy [mkdir] Created dir: /home/sebastien/work/logiciels/GWT/src/trunk/ build/out/dev/core/bin [gwt.javac] Compiling 4 source files to /home/sebastien/work/logiciels/ GWT/src/trunk/build/out/dev/core/bin [gwt.javac] Compiling 724 source files to /home/sebastien/work/ logiciels/GWT/src/trunk/build/out/dev/core/bin [gwt.javac] Note: Some input files use or override a deprecated API. [gwt.javac] Note: Recompile with -Xlint:deprecation for details. [gwt.javac] Note: Some input files use unchecked or unsafe operations. [gwt.javac] Note: Recompile with -Xlint:unchecked for details. [copy] Copying 1 file to /home/sebastien/work/logiciels/GWT/src/ trunk/build/out/dev/core/bin BUILD FAILED /home/sebastien/work/logiciels/GWT/src/trunk/build.xml:104: The following error occurred while executing this line: /home/sebastien/work/logiciels/GWT/src/trunk/build.xml:26: The following error occurred while executing this line: /home/sebastien/work/logiciels/GWT/src/trunk/build.xml:57: The following error occurred while executing this line: /home/sebastien/work/logiciels/GWT/src/trunk/platforms.ant.xml:36: The following error occurred while executing this line: /home/sebastien/work/logiciels/GWT/src/trunk/platforms.ant.xml:13: The following error occurred while executing this line: /home/sebastien/work/logiciels/GWT/src/trunk/dev/core/build.xml:140: The following error occurred while executing this line: /home/sebastien/work/logiciels/GWT/src/trunk/common.ant.xml:231: svn info didn't get root URL: Chemin : . URL :http://google-web-toolkit.googlecode.com/svn/trunk Racine du dépôt :http://google-web-toolkit.googlecode.com/svn UUID du dépôt : 8db76d5a-ed1c-0410-87a9-c151d255dfc7 Révision : 5651 Type de nœud : répertoire Tâche programmée : normale Auteur de la dernière modification : sco...@google.com Révision de la dernière modification : 5651 Date de la dernière modification: 2009-07-01 03:16:39 +0200 (mer. 01 juil. 2009) --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Trunk does not compile ?
Yep. It'll be looking for English-language regexp matching. Rather than commenting out the lines, you may be able to win by defining gwt.svnrev and gwt.svnrev.file in a local.ant.properties file at the top level... although it looks like that might not work, we can easily modify the svninfo task so it doesn't do anything if its output properties are already defined. That may be as robust as using non-locale-varying markers in the svn (or git) output, or using SvnKit and expecting version compatibility (which is the other common error here). Sigh. I still think we wouldn't have lost much by figuring the brand in our build machine, and setting that as a property on the build command. ;-) On Wed, Jul 1, 2009 at 10:31 AM, John Tamplin j...@google.com wrote: On Wed, Jul 1, 2009 at 10:24 AM, Sebastien chassa...@gmail.com wrote: I compiled with success by commenting the lines 230-231 in the ./ common.ant.xml Ant file. Indeed the call to svinfo task failed (I do not know why). Now, it works ! My guess is it was confused by the French output of svn info. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5655 - Fix sort order.
Author: j...@google.com
Date: Wed Jul 1 08:34:11 2009
New Revision: 5655
Modified:
changes/jat/ihm/user/super/com/google/gwt/emul/java/util/Date.java
Log:
Fix sort order.
Modified: changes/jat/ihm/user/super/com/google/gwt/emul/java/util/Date.java
==
--- changes/jat/ihm/user/super/com/google/gwt/emul/java/util/Date.java
(original)
+++ changes/jat/ihm/user/super/com/google/gwt/emul/java/util/Date.java Wed
Jul 1 08:34:11 2009
@@ -25,18 +25,12 @@
public class Date implements Cloneable, ComparableDate, Serializable {
/**
- * JavaScript Date instance.
- */
- @SuppressWarnings(unused) // used from JSNI
- private JavaScriptObject jsdate;
-
- /**
* Used only by toString().
*/
private static final String[] DAYS = {
Sun, Mon, Tue, Wed, Thu, Fri, Sat
};
-
+
/**
* Used only by toString().
*/
@@ -111,6 +105,12 @@
int min, int sec) /*-{
return Date.UTC(year + 1900, month, date, hrs, min, sec);
}-*/;
+
+ /**
+ * JavaScript Date instance.
+ */
+ @SuppressWarnings(unused) // used from JSNI
+ private JavaScriptObject jsdate;
public Date() {
init();
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5653 - Merging trunk r5627 into this branch.
Author: j...@google.com
Date: Wed Jul 1 06:29:01 2009
New Revision: 5653
Modified:
branches/snapshot-2009.06.02-r5498/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
branches/snapshot-2009.06.02-r5498/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
Log:
Merging trunk r5627 into this branch.
Modified:
branches/snapshot-2009.06.02-r5498/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
==
---
branches/snapshot-2009.06.02-r5498/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
(original)
+++
branches/snapshot-2009.06.02-r5498/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
Wed Jul 1 06:29:01 2009
@@ -37,6 +37,20 @@
}-*/;
@Override
+ public native EventTarget eventGetRelatedTarget(NativeEvent evt) /*-{
+// Hack around Mozilla bug 497780 (relatedTarget sometimes returns XUL
+// elements). Trying to access relatedTarget.nodeName will throw an
+// exception if it's a XUL element.
+var relatedTarget = evt.relatedTarget;
+try {
+ var nodeName = relatedTarget.nodeName;
+ return relatedTarget;
+} catch (e) {
+ return null;
+}
+ }-*/;
+
+ @Override
public int getAbsoluteLeft(Element elem) {
return
getAbsoluteLeftImpl(elem.getOwnerDocument().getViewportElement(),
elem);
Modified:
branches/snapshot-2009.06.02-r5498/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
==
---
branches/snapshot-2009.06.02-r5498/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
(original)
+++
branches/snapshot-2009.06.02-r5498/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
Wed Jul 1 06:29:01 2009
@@ -39,22 +39,30 @@
private static JavaScriptObject dispatchEvent;
@Override
- public native Element eventGetFromElement(Event evt) /*-{
-if (evt.type == mouseover)
- return evt.relatedTarget;
-if (evt.type == mouseout)
- return evt.target;
+ public Element eventGetFromElement(Event evt) {
+if (evt.getType().equals(mouseover)) {
+ return evt.getRelatedTarget().cast();
+}
+
+if (evt.getType().equals(mouseout)) {
+ return evt.getTarget().cast();
+}
+
return null;
- }-*/;
+ }
@Override
- public native Element eventGetToElement(Event evt) /*-{
-if (evt.type == mouseover)
- return evt.target;
-if (evt.type == mouseout)
- return evt.relatedTarget;
+ public Element eventGetToElement(Event evt) {
+if (evt.getType().equals(mouseover)) {
+ return evt.getTarget().cast();
+}
+
+if (evt.getType().equals(mouseout)) {
+ return evt.getRelatedTarget().cast();
+}
+
return null;
- }-*/;
+ }
@Override
public native Element getChild(Element elem, int index) /*-{
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: HelpRequired : GWT-Incubator: GlassPanel changes
On Wed, Jun 24, 2009 at 7:34 AM, Surya master...@gmail.com wrote: Hi , I am fairly new to GWT and my requirement needs a glasspanel to be used. But due to the heavy size of incubator.jar file i would like to Heavy size in what sense? You're aware that only the classes you touch will be in the compiled output, right? And as a Java jar file, incubator doesn't seem amazingly fat to me... just copy the GlassPanel class and GlassPanelImpl into my own workspace and create a custom glasspanel . This would remove the dependency on incubator.jar file. All is well at compile time. But when i compile it , it throws an error saying GlassPanelImpl cannot be abstract Please suggest if i am missing anything. Any help I think you also need GlassPanel.gwt.xml, and the various alternative implementations in the rebind clauses there: GlassPanelImpl*, in effect. As it happens, GlassPanelImpl is *supposed *to be abstract... but you're not supposed to use it, but instead one of the subclasses specialized for your browser, by deferred binding. Also, though you hopefully know this already, you want to have both .class and .java files in your extracted file; classes for hosted mode debugging, sources for the GWT compiler to process. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5656 - Add ASM visitor tests.
Author: j...@google.com
Date: Wed Jul 1 08:34:40 2009
New Revision: 5656
Added:
changes/jat/ihm/dev/core/test/com/google/gwt/dev/javac/asm/CollectReferencesVisitorTest.java
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/asm/CollectClassData.java
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/asm/CollectReferencesVisitor.java
changes/jat/ihm/dev/core/test/com/google/gwt/dev/javac/asm/AsmTestCase.java
changes/jat/ihm/dev/core/test/com/google/gwt/dev/javac/asm/CollectClassDataTest.java
Log:
Add ASM visitor tests.
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/asm/CollectClassData.java
==
---
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/asm/CollectClassData.java
(original)
+++
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/asm/CollectClassData.java
Wed Jul 1 08:34:40 2009
@@ -20,7 +20,6 @@
import com.google.gwt.dev.asm.MethodVisitor;
import com.google.gwt.dev.asm.Opcodes;
import com.google.gwt.dev.asm.commons.EmptyVisitor;
-import com.google.gwt.dev.resource.Resource;
import com.google.gwt.dev.util.Name;
import java.util.ArrayList;
@@ -134,7 +133,9 @@
private ListCollectAnnotationData annotations = new
ArrayListCollectAnnotationData();
private String source = null;
- private ListResource innerClasses = new ArrayListResource();
+
+ // TODO(jat): do we need to collect inner classes?
+// private ListResource innerClasses = new ArrayListResource();
// internal name
private String name;
@@ -194,12 +195,12 @@
return fields;
}
- /**
- * @return the innerClasses
- */
- public ListResource getInnerClasses() {
-return innerClasses;
- }
+// /**
+// * @return the innerClasses
+// */
+// public ListResource getInnerClasses() {
+//return innerClasses;
+// }
/**
* @return the interfaces
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/asm/CollectReferencesVisitor.java
==
---
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/asm/CollectReferencesVisitor.java
(original)
+++
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/asm/CollectReferencesVisitor.java
Wed Jul 1 08:34:40 2009
@@ -15,10 +15,13 @@
*/
package com.google.gwt.dev.javac.asm;
+import com.google.gwt.dev.asm.AnnotationVisitor;
import com.google.gwt.dev.asm.FieldVisitor;
import com.google.gwt.dev.asm.MethodVisitor;
import com.google.gwt.dev.asm.Type;
import com.google.gwt.dev.asm.commons.EmptyVisitor;
+import com.google.gwt.dev.asm.signature.SignatureReader;
+import com.google.gwt.dev.asm.signature.SignatureVisitor;
import java.util.HashSet;
import java.util.Set;
@@ -27,22 +30,80 @@
* Collect all the types which are referenced by a particular class.
*/
public class CollectReferencesVisitor extends EmptyVisitor {
- // TODO(jat): support annotation types, types in generic signatures
- private static final EmptyVisitor emptyVisitor = new EmptyVisitor();
-
+ /**
+ * Collect type names from generic signatures.
+ *
+ * All we care about is picking up type names, so we just return
ourselves
+ * for nested visitors.
+ */
+ private class CollectGenericTypes implements SignatureVisitor {
+public SignatureVisitor visitArrayType() {
+ return this;
+}
+
+public void visitBaseType(char descriptor) {
+}
+
+public SignatureVisitor visitClassBound() {
+ return this;
+}
+
+public void visitClassType(String name) {
+ referencedTypes.add(name);
+}
+
+public void visitEnd() {
+}
+
+public SignatureVisitor visitExceptionType() {
+ return this;
+}
+
+public void visitFormalTypeParameter(String name) {
+}
+
+public void visitInnerClassType(String name) {
+}
+
+public SignatureVisitor visitInterface() {
+ return this;
+}
+
+public SignatureVisitor visitInterfaceBound() {
+ return this;
+}
+
+public SignatureVisitor visitParameterType() {
+ return this;
+}
+
+public SignatureVisitor visitReturnType() {
+ return this;
+}
+
+public SignatureVisitor visitSuperclass() {
+ return this;
+}
+
+public void visitTypeArgument() {
+}
+
+public SignatureVisitor visitTypeArgument(char wildcard) {
+ return this;
+}
+
+public void visitTypeVariable(String name) {
+}
+ }
+
// internal names
- private SetString referencedTypes = new HashSetString();
+ protected SetString referencedTypes = new HashSetString();
public SetString getReferencedTypes() {
return referencedTypes;
}
- /**
- * @param name internal name of the class
- * @param superName internal name of the super class
- * @param interfaces array of internal names of implemented interfaces
- */
@Override
public void visit(int
[gwt-contrib] [google-web-toolkit commit] r5652 - Modifies WebAppCreator to allow creating crawl-enabled projects.
Author: kpro...@google.com
Date: Wed Jul 1 06:11:31 2009
New Revision: 5652
Added:
branches/crawlability/user/src/com/google/gwt/user/tools/.classpathcrawlablesrc
branches/crawlability/user/src/com/google/gwt/user/tools/.projectcrawlablesrc
branches/crawlability/user/src/com/google/gwt/user/tools/webcrawlable.xmlsrc
Modified:
branches/crawlability/common.ant.xml
branches/crawlability/eclipse/dev/mac/.project
branches/crawlability/eclipse/samples/Hello/Hello-gwtc.launch
branches/crawlability/eclipse/samples/Hello/Hello.launch
branches/crawlability/eclipse/samples/Showcase/.classpath
branches/crawlability/eclipse/samples/Showcase/Showcase.launch
branches/crawlability/eclipse/user/.classpath
branches/crawlability/samples/showcase/src/com/google/gwt/sample/showcase/Showcase.gwt.xml
branches/crawlability/samples/showcase/src/com/google/gwt/sample/showcase/client/Showcase.java
branches/crawlability/servlet/build.xml
branches/crawlability/user/src/com/google/gwt/user/client/ui/ListBox.java
branches/crawlability/user/src/com/google/gwt/user/tools/WebAppCreator.java
Log:
Modifies WebAppCreator to allow creating crawl-enabled projects.
NOTE: In WebAppCreator in this revision, crawlable defaults to true, so I
can use this in the eclipse plugin. Once the eclipse plugin is modified,
this should default to false.
Modified: branches/crawlability/common.ant.xml
==
--- branches/crawlability/common.ant.xml(original)
+++ branches/crawlability/common.ant.xmlWed Jul 1 06:11:31 2009
@@ -120,6 +120,11 @@
/classpath
/taskdef
+ !-- jarjar is used to re-package HtmlUnit --
+ taskdef name=jarjar
+ classname=com.tonicsystems.jarjar.JarJarTask
classpath=${gwt.tools.lib}/tonicsystems/jarjar-1.0rc8.jar/
+
+
!-- Global Custom Tasks --
presetdef name=gwt.ant
ant inheritall=false target=${target}
Modified: branches/crawlability/eclipse/dev/mac/.project
==
--- branches/crawlability/eclipse/dev/mac/.project (original)
+++ branches/crawlability/eclipse/dev/mac/.project Wed Jul 1 06:11:31 2009
@@ -24,12 +24,12 @@
link
namecore/name
type2/type
- locationGWT_ROOT/dev/core/location
+ locationURIGWT_ROOT/dev/core/locationURI
/link
link
namemac/name
type2/type
- locationGWT_ROOT/dev/mac/location
+ locationURIGWT_ROOT/dev/mac/locationURI
/link
/linkedResources
/projectDescription
Modified: branches/crawlability/eclipse/samples/Hello/Hello-gwtc.launch
==
--- branches/crawlability/eclipse/samples/Hello/Hello-gwtc.launch
(original)
+++ branches/crawlability/eclipse/samples/Hello/Hello-gwtc.launch Wed Jul
1 06:11:31 2009
@@ -1,13 +1,18 @@
-?xml version=1.0 encoding=UTF-8 standalone=no?
-launchConfiguration type=org.eclipse.jdt.launching.localJavaApplication
+?xml version=1.0 encoding=UTF-8?launchConfiguration
type=org.eclipse.jdt.launching.localJavaApplication
+listAttribute key=org.eclipse.debug.core.MAPPED_RESOURCE_PATHS
+listEntry value=/Hello/
+/listAttribute
+listAttribute key=org.eclipse.debug.core.MAPPED_RESOURCE_TYPES
+listEntry value=4/
+/listAttribute
booleanAttribute key=org.eclipse.debug.core.appendEnvironmentVariables
value=true/
listAttribute key=org.eclipse.jdt.launching.CLASSPATH
-listEntry value=lt;?xml version=quot;1.0quot;
encoding=quot;UTF-8quot;?gt;#10;lt;runtimeClasspathEntry
containerPath=quot;org.eclipse.jdt.launching.JRE_CONTAINERquot;
javaProject=quot;Helloquot; path=quot;1quot;
type=quot;4quot;/gt;#10;/
-listEntry value=lt;?xml version=quot;1.0quot;
encoding=quot;UTF-8quot;?gt;#10;lt;runtimeClasspathEntry
internalArchive=quot;/Hello/core/srcquot; path=quot;3quot;
type=quot;2quot;/gt;#10;/
-listEntry value=lt;?xml version=quot;1.0quot;
encoding=quot;UTF-8quot;?gt;#10;lt;runtimeClasspathEntry
internalArchive=quot;/gwt-user/core/srcquot; path=quot;3quot;
type=quot;2quot;/gt;#10;/
-listEntry value=lt;?xml version=quot;1.0quot;
encoding=quot;UTF-8quot;?gt;#10;lt;runtimeClasspathEntry
internalArchive=quot;/gwt-user/core/superquot; path=quot;3quot;
type=quot;2quot;/gt;#10;/
-listEntry value=lt;?xml version=quot;1.0quot;
encoding=quot;UTF-8quot;?gt;#10;lt;runtimeClasspathEntry
internalArchive=quot;/gwt-dev-windows/core/superquot; path=quot;3quot;
type=quot;2quot;/gt;#10;/
-listEntry value=lt;?xml version=quot;1.0quot;
encoding=quot;UTF-8quot;?gt;#10;lt;runtimeClasspathEntry
[gwt-contrib] [google-web-toolkit commit] r5654 - Updating branch-info.
Author: j...@google.com Date: Wed Jul 1 06:29:26 2009 New Revision: 5654 Modified: branches/snapshot-2009.06.02-r5498/branch-info.txt Log: Updating branch-info. Modified: branches/snapshot-2009.06.02-r5498/branch-info.txt == --- branches/snapshot-2009.06.02-r5498/branch-info.txt (original) +++ branches/snapshot-2009.06.02-r5498/branch-info.txt Wed Jul 1 06:29:26 2009 @@ -28,3 +28,5 @@ svn merge -c5538 https://google-web-toolkit.googlecode.com/svn/trunk . /trunk 5554 was merged into this branch (fix breaking API change) svn merge -c5554 https://google-web-toolkit.googlecode.com/svn/trunk . +/trunk 5627 was merged (r5653) into snapshot + $ svn merge -c5627 https://google-web-toolkit.googlecode.com/svn/trunk --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] SOYC generates more dependency trees
Reviewers: kathrin, Description: Currently, SOYC shows dependency information for a whole-program dependency trace. This patch additionally shows the various dependency graphs used by the code splitter to decide what code goes into what fragment. The display of this information can use work. Since the patch is getting large, though, I was thinking we might want to go ahead with it and at least get the information included at all. Thoughts welcome on that plan; it would also be possible to spend time polishing up the UI further. This patch has several parts: 1. The CodeSplitter can record its dependencies as it goes. 2. Correspondingly, DependencyRecorder is updated to handle recording multiple dependency graphs to the same file. 3. The dashboard now has dependency linkers that specify what dependency page to link to from each size breakdown. 4. For the total-size breakdown, there is a split status page added, because it's ambiguous which dependency graph to show. 5. For the leftovers size breakdown, there is a leftovers page added, again because it's ambiguous which dependency graph to show. 6. To improve the text within the UI, the initial split point sequence is now recorded to splitPointsN.xml.gz. Please review this at http://gwt-code-reviews.appspot.com/50806 Affected files: dev/core/src/com/google/gwt/core/ext/soyc/impl/DependencyRecorder.java dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java tools/soyc-vis/src/com/google/gwt/soyc/GlobalInformation.java tools/soyc-vis/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java tools/soyc-vis/src/com/google/gwt/soyc/SoycDashboard.java --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Comment on UsingOOPHM in google-web-toolkit
Comment by Dominik.J.Steiner: Hi, did anyone find a workaround for Eclipse and Mac OSX and how to remove the -XstartOnFirstThread from the classpath when launching from within eclipse? For more information: http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: derpc review: hosted-mode user code, rebind, and related tests
On Wed, Jul 1, 2009 at 2:59 PM, Bob Vawter robertvaw...@google.com wrote: append: where is quoting the RPC_SEPARATOR_CHAR handled if it is contained within the string? That's unnecessary, since the length of the string is known. The following separator character is just there to ensure that the decoder is synchronized with the payload and could be removed. Ok, though if I am right below there will have to be a escaping/descaping going on here. I don't see where all the quoting is handled like ServerSerializationStreamReader deserializeStringTable (and others) did before -- various browsers have issues with different characters (current Android doesn't handle any non-ASCII due to a double-decode problem), and while I am not looking at the web-mode code with OOPHM (and hopefully eventually an Android plugin among others) I still think this needs to be solved here. Maybe I am missing it since otherwise I don't see how UnicodeEscapingTest2 could pass on all browsers. You're saying that it can't correctly write a UTF-8 string into an XHR or eval() JS containing UTF8 string literals? I'll run this test on my Android 1.5 device. The tests we did before showed that the existing RPC mechanism failed with any non-ASCII characters on Android, because it was doing the equivalent of UTF8encode(UTF8encode(string)) when sending from the browser to the server. Also, WebKit in general mangles a bunch of characters so it needs additional quoting (though more recent versions may be better). Take a look at ClientSerializationStreamWriter.getQuotingRegex() for where we produce a regex that matches any characters which must be quoted to safely make it to the server. The only test that fails is the one that creates bad strings with low surrogate characters not followed by a high surrogate character. Why is that tested? User code might include those in strings. The code referenced above properly quotes them. RpcRequestBuilder.java The constants are duplicated between client and servlet code. Ok.. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Comment on UsingOOPHM in google-web-toolkit
Comment by Dominik.J.Steiner: Actually, I just added the gwt-dev-oophm.jar to the start of the eclipse launch config, didn't fiddle with the -XstartOnFirstThread nor the swt classes and started the launch config. No swing window came up, but then from firefox conecting to http://localhost:8080/MyHtml.html?gwt.hosted=192.168.0.2:9997 I could load the GWT App and better yet while using FF put breakpoints and debug as I was able to do in the former GWT Shell. So as far as i can tell the OOPHM works on Mac OSX and Eclipse by just adding the gwt-dev-oophm.jar to the top of the classpath on the eclipse launch config, only the swing window doesn't appear. For more information: http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5658 - Fixes issue #3700, avoids unnecessary copy of resources with up-to-date timestamps.
Author: sco...@google.com
Date: Wed Jul 1 12:24:55 2009
New Revision: 5658
Modified:
trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java
Log:
Fixes issue #3700, avoids unnecessary copy of resources with up-to-date
timestamps.
Review by: jgw
Modified:
trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java
==
---
trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java
(original)
+++
trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java
Wed Jul 1 12:24:55 2009
@@ -649,7 +649,7 @@
private void writeArtifactToFile(TreeLogger logger, EmittedArtifact
artifact,
File outFile, SetString createdDirs) throws
UnableToCompleteException {
if (!outFile.exists()
-|| (outFile.lastModified() = artifact.getLastModified())) {
+|| (outFile.lastModified() artifact.getLastModified())) {
if (!mkdirs(outFile.getParentFile(), createdDirs)) {
logger.log(TreeLogger.ERROR, Unable to create directory for
file '
+ outFile.getAbsolutePath() + ');
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5657 - Fixes issue #3700, avoids unnecessary copy of resources with up-to-date timestamps.
Author: sco...@google.com
Date: Wed Jul 1 12:16:27 2009
New Revision: 5657
Modified:
releases/1.6/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java
Log:
Fixes issue #3700, avoids unnecessary copy of resources with up-to-date
timestamps.
Review by: jgw
Modified:
releases/1.6/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java
==
---
releases/1.6/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java
(original)
+++
releases/1.6/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java
Wed Jul 1 12:16:27 2009
@@ -449,7 +449,7 @@
}
if (!outFile.exists()
- || (outFile.lastModified() = artifact.getLastModified())) {
+ || (outFile.lastModified() artifact.getLastModified())) {
Util.copy(artifactLogger, artifact.getContents(artifactLogger),
outFile);
outFile.setLastModified(artifact.getLastModified());
}
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: IE8 disappearing history
Joel, The 1.6 release branch does not exhibit the problem; it works fine. The next thing I'll try is copying the IFrame linker changes over to the 1.6 branch and see if that's enough to cause the problem. Unless you have another suggestion? - Amir On Jun 30, 5:32 am, Joel Webber j...@google.com wrote: Amir, I'd be very interested in any way you can find to reproduce this bug reliably. The History implementation in IE8 is very simple, because they added direct support for using the url #hash to update the history state, and for the onhashchange event. It is possible that we're doing something in the iframe linker's bootstrap script to tickle this bug, though it's not clear to me what that might be. Since you're building with trunk right now, you could also try building against the current contents of the 1.6 release branch (/releases/1.6), which has full IE8 support, but not the linker changes. We're going to be releasing out of this branch very soon (as soon as we merge the fix for a Firefox 3.5 regression they are shipping today). Cheers, joel. On Tue, Jun 30, 2009 at 12:01 AM, Amir Kashani amirkash...@gmail.comwrote: I’m having a strange issue with trunk and IE8 where the browser’s history stack inexplicably “disappears”. That is, the history drop down list empties (including previously visited non-GWT sites, like MSN) and the back/forward buttons don’t work. My guess is that this is a bug in IE8 that GWT is somehow triggering since as far as I know, an application can’t explicitly clear a browser’s back history. I haven’t been able to find a definitive set of steps to duplicate this. I’ll be clicking along, adding items to the history stack and regularly checking the history drop-down menu until at some point, the list is either completely empty or only contains the current page. Other times, I’ll click back or forward, and as soon as I do, the buttons become disabled (list is empty). To complicate matters, I haven’t been able to create a simple example that exhibits the bug; it only occurs with my fairly large application. I _think_ I’ve narrowed down the issue to a change made to the IFrame linker in r5393. Using r5392, history works exactly as expected. Unfortunately, I can’t use r5393 directly, as it has a bug which isn’t fixed way until r5523, where document.body is accessed before it is initialized, causing my app to not load at all. Swapping out IFrameTemplate.js with r5523’s version exhibits the broken behavior with r5393. I can’t for the life of me explain how the IFrame linker change causes this, or why it’s not a consistent set of steps (timing issue?) or why it only happens with my application and not smaller ones. Any insight or tips on how to further track down the problem so I can submit a coherent bug report would be greatly appreciated. - Amir --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] NewParenthesisRemovalOptimization
Reviewers: scottb,
Description:
This patch removes trailing parenthesis from Javascript 'new' operators
if there are no constructor arguments.
new Foo() - new Foo
Please review this at http://gwt-code-reviews.appspot.com/49804
Affected files:
dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
Index: dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
===
--- dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
(revision 5638)
+++ dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
(working copy)
@@ -583,16 +583,18 @@
_rparen();
}
-_lparen();
-boolean sep = false;
-for (Object element : x.getArguments()) {
- JsExpression arg = (JsExpression) element;
- sep = _sepCommaOptSpace(sep);
- _parenPushIfCommaExpr(arg);
- accept(arg);
- _parenPopIfCommaExpr(arg);
+if (x.getArguments().size() 0) {
+ _lparen();
+ boolean sep = false;
+ for (Object element : x.getArguments()) {
+JsExpression arg = (JsExpression) element;
+sep = _sepCommaOptSpace(sep);
+_parenPushIfCommaExpr(arg);
+accept(arg);
+_parenPopIfCommaExpr(arg);
+ }
+ _rparen();
}
-_rparen();
return false;
}
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: NewParenthesisRemovalOptimization
Compiling the Mail application removes ~860 bytes off the smallest
permutation, compiling Showcase removes about 1.6k off the largest
permutation.
-Ray
On Wed, Jul 1, 2009 at 4:50 PM, cromwell...@gmail.com wrote:
Reviewers: scottb,
Description:
This patch removes trailing parenthesis from Javascript 'new' operators
if there are no constructor arguments.
new Foo() - new Foo
Please review this at http://gwt-code-reviews.appspot.com/49804
Affected files:
dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
Index: dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
===
--- dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
(revision 5638)
+++ dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
(working copy)
@@ -583,16 +583,18 @@
_rparen();
}
-_lparen();
-boolean sep = false;
-for (Object element : x.getArguments()) {
- JsExpression arg = (JsExpression) element;
- sep = _sepCommaOptSpace(sep);
- _parenPushIfCommaExpr(arg);
- accept(arg);
- _parenPopIfCommaExpr(arg);
+if (x.getArguments().size() 0) {
+ _lparen();
+ boolean sep = false;
+ for (Object element : x.getArguments()) {
+JsExpression arg = (JsExpression) element;
+sep = _sepCommaOptSpace(sep);
+_parenPushIfCommaExpr(arg);
+accept(arg);
+_parenPopIfCommaExpr(arg);
+ }
+ _rparen();
}
-_rparen();
return false;
}
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: NewParenthesisRemovalOptimization
LGTM, but only if you fix the darn for-each using Object var!
On Wed, Jul 1, 2009 at 7:50 PM, cromwell...@gmail.com wrote:
Reviewers: scottb,
Description:
This patch removes trailing parenthesis from Javascript 'new' operators
if there are no constructor arguments.
new Foo() - new Foo
Please review this at http://gwt-code-reviews.appspot.com/49804
Affected files:
dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
Index: dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
===
--- dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
(revision 5638)
+++ dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
(working copy)
@@ -583,16 +583,18 @@
_rparen();
}
-_lparen();
-boolean sep = false;
-for (Object element : x.getArguments()) {
- JsExpression arg = (JsExpression) element;
- sep = _sepCommaOptSpace(sep);
- _parenPushIfCommaExpr(arg);
- accept(arg);
- _parenPopIfCommaExpr(arg);
+if (x.getArguments().size() 0) {
+ _lparen();
+ boolean sep = false;
+ for (Object element : x.getArguments()) {
+JsExpression arg = (JsExpression) element;
+sep = _sepCommaOptSpace(sep);
+_parenPushIfCommaExpr(arg);
+accept(arg);
+_parenPopIfCommaExpr(arg);
+ }
+ _rparen();
}
-_rparen();
return false;
}
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
