Re: [PHP-DEV] [VOTE] Improved Linux process title support in the CLI SAPI

2013-03-05 Thread Keyur Govande
On Fri, Feb 22, 2013 at 3:06 PM, Keyur Govande wrote:

> On Fri, Feb 22, 2013 at 2:59 PM, Hannes Magnusson <
> hannes.magnus...@gmail.com> wrote:
>
>> On Fri, Feb 22, 2013 at 11:52 AM, Rasmus Lerdorf 
>> wrote:
>> > On 02/22/2013 11:48 AM, Hannes Magnusson wrote:
>> >> On Thu, Feb 21, 2013 at 4:42 PM, Keyur Govande 
>> wrote:
>> >>> Hi everyone,
>> >>>
>> >>> With the 2 weeks discussion period up, I'm moving this RFC to the
>> Voting
>> >>> stage. I'd like to get this into 5.5.
>> >>>
>> >>> Most of the reaction has been positive and is archived here:
>> >>> http://marc.info/?t=13602158203&r=1&w=2
>> >>
>> >> Just out of curiosity, I don't see it covered in the other thread; Is
>> >> there a reason why it cannot support sapi/fpm?
>> >
>> > fpm has its own implementation already. I suppose we could swap out the
>> > one in fpm and replace it with this one, but that seems like a separate
>> > decision.
>>
>> Right, which makes me worry about the function name.. cli_*.
>>
>> -Hannes
>>
>
> If FPM wants to use these too, the implementation can be easily shared and
> the wrappers around these can be created and called php_fpm_*. The reason
> for CLI in the names was to indicate the limited availability of these
> methods.
>

Voting is now closed. The RFC is accepted with 28 for and 1 against. Thanks
everyone!


Re: [PHP-DEV] [VOTE] Improved Linux process title support in the CLI SAPI

2013-02-22 Thread Keyur Govande
On Fri, Feb 22, 2013 at 2:59 PM, Hannes Magnusson <
hannes.magnus...@gmail.com> wrote:

> On Fri, Feb 22, 2013 at 11:52 AM, Rasmus Lerdorf 
> wrote:
> > On 02/22/2013 11:48 AM, Hannes Magnusson wrote:
> >> On Thu, Feb 21, 2013 at 4:42 PM, Keyur Govande 
> wrote:
> >>> Hi everyone,
> >>>
> >>> With the 2 weeks discussion period up, I'm moving this RFC to the
> Voting
> >>> stage. I'd like to get this into 5.5.
> >>>
> >>> Most of the reaction has been positive and is archived here:
> >>> http://marc.info/?t=13602158203&r=1&w=2
> >>
> >> Just out of curiosity, I don't see it covered in the other thread; Is
> >> there a reason why it cannot support sapi/fpm?
> >
> > fpm has its own implementation already. I suppose we could swap out the
> > one in fpm and replace it with this one, but that seems like a separate
> > decision.
>
> Right, which makes me worry about the function name.. cli_*.
>
> -Hannes
>

If FPM wants to use these too, the implementation can be easily shared and
the wrappers around these can be created and called php_fpm_*. The reason
for CLI in the names was to indicate the limited availability of these
methods.


Re: [PHP-DEV] [VOTE] Improved Linux process title support in the CLI SAPI

2013-02-22 Thread Hannes Magnusson
On Fri, Feb 22, 2013 at 11:52 AM, Rasmus Lerdorf  wrote:
> On 02/22/2013 11:48 AM, Hannes Magnusson wrote:
>> On Thu, Feb 21, 2013 at 4:42 PM, Keyur Govande  
>> wrote:
>>> Hi everyone,
>>>
>>> With the 2 weeks discussion period up, I'm moving this RFC to the Voting
>>> stage. I'd like to get this into 5.5.
>>>
>>> Most of the reaction has been positive and is archived here:
>>> http://marc.info/?t=13602158203&r=1&w=2
>>
>> Just out of curiosity, I don't see it covered in the other thread; Is
>> there a reason why it cannot support sapi/fpm?
>
> fpm has its own implementation already. I suppose we could swap out the
> one in fpm and replace it with this one, but that seems like a separate
> decision.

Right, which makes me worry about the function name.. cli_*.

-Hannes

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] [VOTE] Improved Linux process title support in the CLI SAPI

2013-02-22 Thread Rasmus Lerdorf
On 02/22/2013 11:48 AM, Hannes Magnusson wrote:
> On Thu, Feb 21, 2013 at 4:42 PM, Keyur Govande  wrote:
>> Hi everyone,
>>
>> With the 2 weeks discussion period up, I'm moving this RFC to the Voting
>> stage. I'd like to get this into 5.5.
>>
>> Most of the reaction has been positive and is archived here:
>> http://marc.info/?t=13602158203&r=1&w=2
> 
> Just out of curiosity, I don't see it covered in the other thread; Is
> there a reason why it cannot support sapi/fpm?

fpm has its own implementation already. I suppose we could swap out the
one in fpm and replace it with this one, but that seems like a separate
decision.

-Rasmus


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] [VOTE] Improved Linux process title support in the CLI SAPI

2013-02-22 Thread Hannes Magnusson
On Thu, Feb 21, 2013 at 4:42 PM, Keyur Govande  wrote:
> Hi everyone,
>
> With the 2 weeks discussion period up, I'm moving this RFC to the Voting
> stage. I'd like to get this into 5.5.
>
> Most of the reaction has been positive and is archived here:
> http://marc.info/?t=13602158203&r=1&w=2

Just out of curiosity, I don't see it covered in the other thread; Is
there a reason why it cannot support sapi/fpm?

-Hannes

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] [VOTE] Improved Linux process title support in the CLI SAPI

2013-02-22 Thread Christopher Jones



On 02/22/2013 10:22 AM, Christopher Jones wrote:



On 02/21/2013 04:42 PM, Keyur Govande wrote:

Hi everyone,

With the 2 weeks discussion period up, I'm moving this RFC to the Voting
stage. I'd like to get this into 5.5.

Most of the reaction has been positive and is archived here:
http://marc.info/?t=13602158203&r=1&w=2

Please vote on https://wiki.php.net/rfc/cli_process_title. Voting ends on
March 4, 2013.

Thanks,
Keyur.



The patch is failing to link php in the current 5.5 snapshot, 
php5.5-201302221630.


Doh!  buildconf is my friend.  Thanks Johannes.

Chris

--
christopher.jo...@oracle.com  http://twitter.com/ghrd
Newly updated, free PHP & Oracle book:
http://www.oracle.com/technetwork/topics/php/underground-php-oracle-manual-098250.html

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] [VOTE] Improved Linux process title support in the CLI SAPI

2013-02-22 Thread Christopher Jones



On 02/21/2013 04:42 PM, Keyur Govande wrote:

Hi everyone,

With the 2 weeks discussion period up, I'm moving this RFC to the Voting
stage. I'd like to get this into 5.5.

Most of the reaction has been positive and is archived here:
http://marc.info/?t=13602158203&r=1&w=2

Please vote on https://wiki.php.net/rfc/cli_process_title. Voting ends on
March 4, 2013.

Thanks,
Keyur.



The patch is failing to link php in the current 5.5 snapshot, 
php5.5-201302221630.

I did:

$ cd php5.5-201302221630

$ patch --strip 1 < 280.patch
patching file sapi/cli/config.m4
patching file sapi/cli/config.w32
patching file sapi/cli/php_cli.c
patching file sapi/cli/php_cli_process_title.c
patching file sapi/cli/php_cli_process_title.h
patching file sapi/cli/php_cli_server.c
patching file sapi/cli/php_cli_server.h
patching file sapi/cli/ps_title.c
patching file sapi/cli/ps_title.h
patching file sapi/cli/tests/cli_process_title.phpt
patching file sapi/cli/php_cli_process_title.c

$ ./configure --disable-all
[ . . . ]

$ make
[ . . . ]

/bin/bash /home/cjones/Desktop/php5.5-201302221630/libtool --silent --preserve-dup-deps --mode=link cc -export-dynamic -g -O2 -fvisibility=hidden ext/date/php_date.lo ext/date/lib/astro.lo ext/date/lib/dow.lo ext/date/lib/parse_date.lo 
ext/date/lib/parse_tz.lo ext/date/lib/timelib.lo ext/date/lib/tm2unixtime.lo ext/date/lib/unixtime2tm.lo ext/date/lib/parse_iso_intervals.lo ext/date/lib/interval.lo ext/ereg/ereg.lo ext/ereg/regex/regcomp.lo ext/ereg/regex/regexec.lo 
ext/ereg/regex/regerror.lo ext/ereg/regex/regfree.lo ext/pcre/pcrelib/pcre_chartables.lo ext/pcre/pcrelib/pcre_ucd.lo ext/pcre/pcrelib/pcre_compile.lo ext/pcre/pcrelib/pcre_config.lo ext/pcre/pcrelib/pcre_exec.lo ext/pcre/pcrelib/pcre_fullinfo.lo 
ext/pcre/pcrelib/pcre_get.lo ext/pcre/pcrelib/pcre_globals.lo ext/pcre/pcrelib/pcre_maketables.lo ext/pcre/pcrelib/pcre_newline.lo ext/pcre/pcrelib/pcre_ord2utf8.lo ext/pcre/pcrelib/pcre_refcount.lo ext/pcre/pcrelib/pcre_study.lo 
ext/pcre/pcrelib/pcre_tables.lo ext/pcre/pcrelib/pcre_valid_utf8.lo ext/pcre/pcrelib/pcre_version.lo ext/pcre/pcrelib/pcre_xclass.lo ext/pcre/php_pcre.lo ext/reflection/php_reflection.lo ext/spl/php_spl.lo ext/spl/spl_functions.lo ext/spl/spl_engine.lo 
ext/spl/spl_iterators.lo ext/spl/spl_array.lo ext/spl/spl_directory.lo ext/spl/spl_exceptions.lo ext/spl/spl_observer.lo ext/spl/spl_dllist.lo ext/spl/spl_heap.lo ext/spl/spl_fixedarray.lo ext/standard/crypt_freesec.lo ext/standard/crypt_blowfish.lo 
ext/standard/crypt_sha512.lo ext/standard/crypt_sha256.lo ext/standard/php_crypt_r.lo ext/standard/array.lo ext/standard/base64.lo ext/standard/basic_functions.lo ext/standard/browscap.lo ext/standard/crc32.lo ext/standard/crypt.lo 
ext/standard/cyr_convert.lo ext/standard/datetime.lo ext/standard/dir.lo ext/standard/dl.lo ext/standard/dns.lo ext/standard/exec.lo ext/standard/file.lo ext/standard/filestat.lo ext/standard/flock_compat.lo ext/standard/formatted_print.lo 
ext/standard/fsock.lo ext/standard/head.lo ext/standard/html.lo ext/standard/image.lo ext/standard/info.lo ext/standard/iptc.lo ext/standard/lcg.lo ext/standard/link.lo ext/standard/mail.lo ext/standard/math.lo ext/standard/md5.lo ext/standard/metaphone.lo 
ext/standard/microtime.lo ext/standard/pack.lo ext/standard/pageinfo.lo ext/standard/quot_print.lo ext/standard/rand.lo ext/standard/soundex.lo ext/standard/string.lo ext/standard/scanf.lo ext/standard/syslog.lo ext/standard/type.lo ext/standard/uniqid.lo 
ext/standard/url.lo ext/standard/var.lo ext/standard/versioning.lo ext/standard/assert.lo ext/standard/strnatcmp.lo ext/standard/levenshtein.lo ext/standard/incomplete_class.lo ext/standard/url_scanner_ex.lo ext/standard/ftp_fopen_wrapper.lo 
ext/standard/http_fopen_wrapper.lo ext/standard/php_fopen_wrapper.lo ext/standard/credits.lo ext/standard/css.lo ext/standard/var_unserializer.lo ext/standard/ftok.lo ext/standard/sha1.lo ext/standard/user_filters.lo ext/standard/uuencode.lo 
ext/standard/filters.lo ext/standard/proc_open.lo ext/standard/streamsfuncs.lo ext/standard/http.lo ext/standard/password.lo TSRM/TSRM.lo TSRM/tsrm_strtok_r.lo TSRM/tsrm_virtual_cwd.lo main/main.lo main/snprintf.lo main/spprintf.lo main/php_sprintf.lo 
main/fopen_wrappers.lo main/alloca.lo main/php_scandir.lo main/php_ini.lo main/SAPI.lo main/rfc1867.lo main/php_content_types.lo main/strlcpy.lo main/strlcat.lo main/mergesort.lo main/reentrancy.lo main/php_variables.lo main/php_ticks.lo main/network.lo 
main/php_open_temporary_file.lo main/output.lo main/getopt.lo main/streams/streams.lo main/streams/cast.lo main/streams/memory.lo main/streams/filter.lo main/streams/plain_wrapper.lo main/streams/userspace.lo main/streams/transports.lo 
main/streams/xp_socket.lo main/streams/mmap.lo main/streams/glob_wrapper.lo Zend/zend_language_parser.lo Zend/zend_language_scanner.lo Zend/zend_ini_parser.lo Zend/zend_ini_scanner.lo Zend/zend_alloc.lo Zend/zend_compile.lo Zend/zend_constants.lo 
Zend/zend_dynamic_array.lo Zend/z