Re: Backporting has started and the RC is scheduled for 19th May

2021-05-13 Thread jn...@cloudbees.com 
bridge-method-injector 1.21 

 
has been released.

On Tuesday, May 11, 2021 at 12:34:27 PM UTC+1 jn...@cloudbees.com wrote:

> https://issues.jenkins.io/browse/JENKINS-65605 for tracking purposes.
>
> KK has been pinged to see if someone can get access, (even if just to 
> approve a transfer request).
>
> /James
>
> On Tuesday, May 11, 2021 at 11:05:58 AM UTC+1 timja...@gmail.com wrote:
>
>> The bridge method injector project looks abandoned? We may need to fork 
>> it to release a fix 
>>
>> On Tue, 11 May 2021 at 11:00, jn...@cloudbees.com  
>> wrote:
>>
>>> There are 2 regressions that I know of currently in 2.288,  one is a 
>>> blocker and the other possibly so.
>>>
>>> 1. the `WithBridgeMethods` annotation no longer works and so we would 
>>> break compatibility with plugins using bridge methods from core  PR to fix 
>>> the injector is 
>>> https://github.com/infradna/bridge-method-injector/pull/25 and this 
>>> will need a release and a Jenkins PR and then backporting. (will create a 
>>> Jira soon)
>>>
>>> 2. the HTML form submission has broken quite a few tests (could be 
>>> HTMLUnit bug, or other but there are a number of plugins now with failing 
>>> tests when bumping to this core) 
>>> -> https://issues.jenkins.io/browse/JENKINS-65585  , 
>>> https://github.com/jenkinsci/jenkins/pull/5405#issuecomment-836265920 
>>> and https://github.com/jenkinsci/jenkins/pull/5479
>>>
>>>
>>> /James
>>>
>>> On Monday, May 10, 2021 at 3:55:22 PM UTC+1 Oleg Nenashev wrote:
>>>
 Then let's postpone it until .2 at least

 On Mon, May 10, 2021 at 4:44 PM Basil Crow  wrote:

> On Mon, May 10, 2021 at 2:35 AM Oleg Nenashev  
> wrote:
> >
> > I wonder whether we should also create a Remoting 4.8 backport this 
> time: https://github.com/jenkinsci/remoting/releases/tag/remoting-4.8
> > There are 2 bugfixes which seem important though we could also just 
> embed 4.8 into the LTS line. THere is one performance RFE and one minor 
> feature added, so just backporting the version looks safe enough
>
> #449 is off-by-default and anyway only applies to the Swarm client
> rather than the Jenkins controller. The other changes, while not
> regression fixes, seem safe to me. I don't feel strongly either way.
>
> -- 
> You received this message because you are subscribed to a topic in the 
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit 
> https://groups.google.com/d/topic/jenkinsci-dev/TPQum9wHFVg/unsubscribe
> .
> To unsubscribe from this group and all its topics, send an email to 
> jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjqR22pncxWPsmBq3biGDZZWtHBoN2Bm%2B1qfbv%3DXY1WhEQ%40mail.gmail.com
> .
>
 -- 
>>>
>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to jenkinsci-de...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/c1032e1c-b60b-4780-8d9e-a4fd116f9c36n%40googlegroups.com
>>>  
>>> 
>>> .
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/d24d1e9e-b315-427b-89d9-1d86a970d621n%40googlegroups.com.

Re: Backporting has started and the RC is scheduled for 19th May

2021-05-11 Thread jn...@cloudbees.com 
https://issues.jenkins.io/browse/JENKINS-65605 for tracking purposes.

KK has been pinged to see if someone can get access, (even if just to 
approve a transfer request).

/James

On Tuesday, May 11, 2021 at 11:05:58 AM UTC+1 timja...@gmail.com wrote:

> The bridge method injector project looks abandoned? We may need to fork it 
> to release a fix 
>
> On Tue, 11 May 2021 at 11:00, jn...@cloudbees.com  
> wrote:
>
>> There are 2 regressions that I know of currently in 2.288,  one is a 
>> blocker and the other possibly so.
>>
>> 1. the `WithBridgeMethods` annotation no longer works and so we would 
>> break compatibility with plugins using bridge methods from core  PR to fix 
>> the injector is 
>> https://github.com/infradna/bridge-method-injector/pull/25 and this will 
>> need a release and a Jenkins PR and then backporting. (will create a Jira 
>> soon)
>>
>> 2. the HTML form submission has broken quite a few tests (could be 
>> HTMLUnit bug, or other but there are a number of plugins now with failing 
>> tests when bumping to this core) 
>> -> https://issues.jenkins.io/browse/JENKINS-65585  , 
>> https://github.com/jenkinsci/jenkins/pull/5405#issuecomment-836265920 
>> and https://github.com/jenkinsci/jenkins/pull/5479
>>
>>
>> /James
>>
>> On Monday, May 10, 2021 at 3:55:22 PM UTC+1 Oleg Nenashev wrote:
>>
>>> Then let's postpone it until .2 at least
>>>
>>> On Mon, May 10, 2021 at 4:44 PM Basil Crow  wrote:
>>>
 On Mon, May 10, 2021 at 2:35 AM Oleg Nenashev  
 wrote:
 >
 > I wonder whether we should also create a Remoting 4.8 backport this 
 time: https://github.com/jenkinsci/remoting/releases/tag/remoting-4.8
 > There are 2 bugfixes which seem important though we could also just 
 embed 4.8 into the LTS line. THere is one performance RFE and one minor 
 feature added, so just backporting the version looks safe enough

 #449 is off-by-default and anyway only applies to the Swarm client
 rather than the Jenkins controller. The other changes, while not
 regression fixes, seem safe to me. I don't feel strongly either way.

 -- 
 You received this message because you are subscribed to a topic in the 
 Google Groups "Jenkins Developers" group.
 To unsubscribe from this topic, visit 
 https://groups.google.com/d/topic/jenkinsci-dev/TPQum9wHFVg/unsubscribe
 .
 To unsubscribe from this group and all its topics, send an email to 
 jenkinsci-de...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjqR22pncxWPsmBq3biGDZZWtHBoN2Bm%2B1qfbv%3DXY1WhEQ%40mail.gmail.com
 .

>>> -- 
>>
> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/c1032e1c-b60b-4780-8d9e-a4fd116f9c36n%40googlegroups.com
>>  
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/548b7ee5-8e71-4144-86e0-6265035e85adn%40googlegroups.com.

Re: Backporting has started and the RC is scheduled for 19th May

2021-05-11 Thread Tim Jacomb 
The bridge method injector project looks abandoned? We may need to fork it
to release a fix

On Tue, 11 May 2021 at 11:00, jn...@cloudbees.com 
wrote:

> There are 2 regressions that I know of currently in 2.288,  one is a
> blocker and the other possibly so.
>
> 1. the `WithBridgeMethods` annotation no longer works and so we would
> break compatibility with plugins using bridge methods from core  PR to fix
> the injector is https://github.com/infradna/bridge-method-injector/pull/25
> and this will need a release and a Jenkins PR and then backporting. (will
> create a Jira soon)
>
> 2. the HTML form submission has broken quite a few tests (could be
> HTMLUnit bug, or other but there are a number of plugins now with failing
> tests when bumping to this core)
> -> https://issues.jenkins.io/browse/JENKINS-65585  ,
> https://github.com/jenkinsci/jenkins/pull/5405#issuecomment-836265920 and
> https://github.com/jenkinsci/jenkins/pull/5479
>
>
> /James
>
> On Monday, May 10, 2021 at 3:55:22 PM UTC+1 Oleg Nenashev wrote:
>
>> Then let's postpone it until .2 at least
>>
>> On Mon, May 10, 2021 at 4:44 PM Basil Crow  wrote:
>>
>>> On Mon, May 10, 2021 at 2:35 AM Oleg Nenashev 
>>> wrote:
>>> >
>>> > I wonder whether we should also create a Remoting 4.8 backport this
>>> time: https://github.com/jenkinsci/remoting/releases/tag/remoting-4.8
>>> > There are 2 bugfixes which seem important though we could also just
>>> embed 4.8 into the LTS line. THere is one performance RFE and one minor
>>> feature added, so just backporting the version looks safe enough
>>>
>>> #449 is off-by-default and anyway only applies to the Swarm client
>>> rather than the Jenkins controller. The other changes, while not
>>> regression fixes, seem safe to me. I don't feel strongly either way.
>>>
>>> --
>>> You received this message because you are subscribed to a topic in the
>>> Google Groups "Jenkins Developers" group.
>>> To unsubscribe from this topic, visit
>>> https://groups.google.com/d/topic/jenkinsci-dev/TPQum9wHFVg/unsubscribe.
>>> To unsubscribe from this group and all its topics, send an email to
>>> jenkinsci-de...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjqR22pncxWPsmBq3biGDZZWtHBoN2Bm%2B1qfbv%3DXY1WhEQ%40mail.gmail.com
>>> .
>>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/c1032e1c-b60b-4780-8d9e-a4fd116f9c36n%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bie%3DyS8M3rhGWjUEZ3jz%2B4YfFV47Etfxw92tGfV3gRFjqg%40mail.gmail.com.

Re: Backporting has started and the RC is scheduled for 19th May

2021-05-11 Thread jn...@cloudbees.com 
There are 2 regressions that I know of currently in 2.288,  one is a 
blocker and the other possibly so.

1. the `WithBridgeMethods` annotation no longer works and so we would break 
compatibility with plugins using bridge methods from core  PR to fix the 
injector is https://github.com/infradna/bridge-method-injector/pull/25 and 
this will need a release and a Jenkins PR and then backporting. (will 
create a Jira soon)

2. the HTML form submission has broken quite a few tests (could be HTMLUnit 
bug, or other but there are a number of plugins now with failing tests when 
bumping to this core) 
-> https://issues.jenkins.io/browse/JENKINS-65585  
, https://github.com/jenkinsci/jenkins/pull/5405#issuecomment-836265920 
and https://github.com/jenkinsci/jenkins/pull/5479


/James

On Monday, May 10, 2021 at 3:55:22 PM UTC+1 Oleg Nenashev wrote:

> Then let's postpone it until .2 at least
>
> On Mon, May 10, 2021 at 4:44 PM Basil Crow  wrote:
>
>> On Mon, May 10, 2021 at 2:35 AM Oleg Nenashev  
>> wrote:
>> >
>> > I wonder whether we should also create a Remoting 4.8 backport this 
>> time: https://github.com/jenkinsci/remoting/releases/tag/remoting-4.8
>> > There are 2 bugfixes which seem important though we could also just 
>> embed 4.8 into the LTS line. THere is one performance RFE and one minor 
>> feature added, so just backporting the version looks safe enough
>>
>> #449 is off-by-default and anyway only applies to the Swarm client
>> rather than the Jenkins controller. The other changes, while not
>> regression fixes, seem safe to me. I don't feel strongly either way.
>>
>> -- 
>> You received this message because you are subscribed to a topic in the 
>> Google Groups "Jenkins Developers" group.
>> To unsubscribe from this topic, visit 
>> https://groups.google.com/d/topic/jenkinsci-dev/TPQum9wHFVg/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to 
>> jenkinsci-de...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjqR22pncxWPsmBq3biGDZZWtHBoN2Bm%2B1qfbv%3DXY1WhEQ%40mail.gmail.com
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/c1032e1c-b60b-4780-8d9e-a4fd116f9c36n%40googlegroups.com.

Re: Backporting has started and the RC is scheduled for 19th May

2021-05-10 Thread Oleg Nenashev 
Then let's postpone it until .2 at least

On Mon, May 10, 2021 at 4:44 PM Basil Crow  wrote:

> On Mon, May 10, 2021 at 2:35 AM Oleg Nenashev 
> wrote:
> >
> > I wonder whether we should also create a Remoting 4.8 backport this
> time: https://github.com/jenkinsci/remoting/releases/tag/remoting-4.8
> > There are 2 bugfixes which seem important though we could also just
> embed 4.8 into the LTS line. THere is one performance RFE and one minor
> feature added, so just backporting the version looks safe enough
>
> #449 is off-by-default and anyway only applies to the Swarm client
> rather than the Jenkins controller. The other changes, while not
> regression fixes, seem safe to me. I don't feel strongly either way.
>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/jenkinsci-dev/TPQum9wHFVg/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjqR22pncxWPsmBq3biGDZZWtHBoN2Bm%2B1qfbv%3DXY1WhEQ%40mail.gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCzaDuPMSo3VWCjQvQ35u7eyRuzwwetecsg-1xfWstNYQ%40mail.gmail.com.

Re: Backporting has started and the RC is scheduled for 19th May

2021-05-10 Thread Basil Crow 
On Mon, May 10, 2021 at 2:35 AM Oleg Nenashev  wrote:
>
> I wonder whether we should also create a Remoting 4.8 backport this time: 
> https://github.com/jenkinsci/remoting/releases/tag/remoting-4.8
> There are 2 bugfixes which seem important though we could also just embed 4.8 
> into the LTS line. THere is one performance RFE and one minor feature added, 
> so just backporting the version looks safe enough

#449 is off-by-default and anyway only applies to the Swarm client
rather than the Jenkins controller. The other changes, while not
regression fixes, seem safe to me. I don't feel strongly either way.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjqR22pncxWPsmBq3biGDZZWtHBoN2Bm%2B1qfbv%3DXY1WhEQ%40mail.gmail.com.

Re: Backporting has started and the RC is scheduled for 19th May

2021-05-10 Thread Daniel Beck 
On Mon, May 10, 2021 at 11:35 AM Oleg Nenashev 
wrote:

> Thanks to Raihaan for stepping up as the release lead for 2.289.1!
> So far the changes look good. We might have a few extra backports to do
> before the deadline, and everyone is welcome to expedite potential
> backports into the tomorrow's weekly.
>
> I wonder whether we should also create a Remoting 4.8 backport this time:
> https://github.com/jenkinsci/remoting/releases/tag/remoting-4.8
> There are 2 bugfixes which seem important though we could also just embed
> 4.8 into the LTS line. THere is one performance RFE and one minor feature
> added, so just backporting the version looks safe enough
>

Which bug fixes specifically would you consider important enough to
backport this early, creating a risk of regressions? Are they regression
fixes?

The exact timeline and interaction between changes is unclear to me, but
IIUC, a "late backport" created half of the mess with 2.277.x.

Folks who want the latest & greatest features and non-critical bug fixes
can always choose the weekly release line; LTS is for stability. As long as
each line isn't worse than the one before (~regressions), we shouldn't try
to force unproven changes into it last minute.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtKRzpmSr7NOOa87OF2pykAhpo2s8Yi7ieJJOABhPqPP-Q%40mail.gmail.com.

Re: Backporting has started and the RC is scheduled for 19th May

2021-05-10 Thread Oleg Nenashev 
Thanks to Raihaan for stepping up as the release lead for 2.289.1!
So far the changes look good. We might have a few extra backports to do 
before the deadline, and everyone is welcome to expedite potential 
backports into the tomorrow's weekly.

I wonder whether we should also create a Remoting 4.8 backport this time: 
https://github.com/jenkinsci/remoting/releases/tag/remoting-4.8
There are 2 bugfixes which seem important though we could also just embed 
4.8 into the LTS line. THere is one performance RFE and one minor feature 
added, so just backporting the version looks safe enough

[image: Untitled.png]




On Saturday, May 8, 2021 at 3:50:17 PM UTC+2 raihaan...@gmail.com wrote:

>
> Candidates: https://issues.jenkins-ci.org/issues/?filter=12146
>
> Fixed: 
> https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%202.289.1-fixed
>
> Rejected: 
> https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%202.289.1-rejected
>
> Cheers,
> Raihaan
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/cfde25d5-e907-452d-a722-cfd21f29c477n%40googlegroups.com.

Backporting has started and the RC is scheduled for 19th May

2021-05-08 Thread raihaan...@gmail.com 

Candidates: https://issues.jenkins-ci.org/issues/?filter=12146

Fixed: 
https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%202.289.1-fixed

Rejected: 
https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%202.289.1-rejected

Cheers,
Raihaan

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/7e1874d7-7435-4516-ab73-bb80648677b9n%40googlegroups.com.