D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Stefan Brüns]

bruns requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18829

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in configcommand.cpp:43
> Does this need to be a `while`? Why not a regular old `if`? Are you trying to 
> handle the case where it ends with multiple trailing slashes?

Exactly

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18829

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/9/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 Feb 2019 23:48:04 +
 Build duration:
3 min 36 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5683/9485)43%
(2221/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)95%
(843/886)52%
(271/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(849/1674)42%
(437/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/944)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
  

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/7/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 Feb 2019 23:46:44 +
 Build duration:
2 min 11 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3159/3861)48%
(4680/9810)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(864/883)49%
(1873/3805)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/12/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Feb 2019 23:46:44 +
 Build duration:
2 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3159/3861)48%
(4680/9810)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(864/883)49%
(1873/3805)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D18833: Get rid of mostly unused filePathToStat overload

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:ad4d29c4b170: Get rid of mostly unused filePathToStat 
overload (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18833?vs=51143&id=51232

REVISION DETAIL
  https://phabricator.kde.org/D18833

AFFECTED FILES
  src/engine/experimental/databasesanitizer.cpp
  src/engine/idutils.h

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18835: Handle as container element in SVG

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:f86639982645: Handle  as container element in 
SVG (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18835?vs=51145&id=51231

REVISION DETAIL
  https://phabricator.kde.org/D18835

AFFECTED FILES
  autotests/samplefiles/test_with_container.svg
  autotests/xmlextractortest.cpp
  autotests/xmlextractortest.h
  src/extractors/xmlextractor.cpp

To: bruns, #baloo, #frameworks, astippich, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17287: Enable sharing URLs via email

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:73ea50ef1af2: Enable sharing URLs via email (authored by 
nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17287?vs=46639&id=51230#toc

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17287?vs=46639&id=51230

REVISION DETAIL
  https://phabricator.kde.org/D17287

AFFECTED FILES
  src/plugins/ShareUrlPluginType.json
  src/plugins/email/emailplugin.cpp
  src/plugins/email/emailplugin.json

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17287: Enable sharing URLs via email

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  emailUrl

REVISION DETAIL
  https://phabricator.kde.org/D17287

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17305: Add KDE Connect SMS plugin

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  kdeconnectsms

REVISION DETAIL
  https://phabricator.kde.org/D17305

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18864: FlatBuffers schema syntax highlighting

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Hi Harald, nice hearing from you. Patch looks good and can almost go in as 
is. But could you address the two comments and also add a test file for unit 
testing? It can be short, is not required to make sense, and best is also MIT 
licensed.

INLINE COMMENTS

> flatbuffers.xml:4
> +
> + +version="1" kateversion="5.0"

Could you add license="MIT"?

> flatbuffers.xml:58
> + char="""/>
> + String="-?[0-9]+" />
> + char="/" char1="/"/>

Does the Int rule do the same?

https://docs.kde.org/stable5/en/applications/katepart/highlight.html

...or does it not include the minus sign?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  flatbuffers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18864

To: harald, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

[Ben Cooksley]

Hi David,

Unfortunately it seems that the issue is still occurring as it has
reappeared and blocked a Linux builder for ~22 hours.
Same behaviour as last time i'm afraid - the kioslave processes had
been directly launched by the test and were hanging as they were
previously.

Any ideas?

Cheers,
Ben

D18846: allow to compile without Q_FOREACH support

[Dominik Haumann]

dhaumann added a comment.


  Btw, could we add a cmake definition to disallow foreach?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18846

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D18865: Change C/C++ header/source mimetype icons to circle/line style

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:fdf910145bef: Change C/C++ header/source mimetype icons 
to circle/line style (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18865?vs=51219&id=51221

REVISION DETAIL
  https://phabricator.kde.org/D18865

AFFECTED FILES
  icons-dark/mimetypes/16/text-x-c++hdr.svg
  icons-dark/mimetypes/16/text-x-c++src.svg
  icons-dark/mimetypes/16/text-x-chdr.svg
  icons-dark/mimetypes/16/text-x-csrc.svg
  icons-dark/mimetypes/22/text-x-c++hdr.svg
  icons-dark/mimetypes/22/text-x-c++src.svg
  icons-dark/mimetypes/22/text-x-chdr.svg
  icons-dark/mimetypes/22/text-x-csrc.svg
  icons-dark/mimetypes/32/text-x-c++hdr.svg
  icons-dark/mimetypes/32/text-x-c++src.svg
  icons-dark/mimetypes/32/text-x-chdr.svg
  icons-dark/mimetypes/32/text-x-csrc.svg
  icons-dark/mimetypes/64/text-x-c++hdr.svg
  icons-dark/mimetypes/64/text-x-c++src.svg
  icons-dark/mimetypes/64/text-x-chdr.svg
  icons-dark/mimetypes/64/text-x-csrc.svg
  icons/mimetypes/16/text-x-c++hdr.svg
  icons/mimetypes/16/text-x-c++src.svg
  icons/mimetypes/16/text-x-chdr.svg
  icons/mimetypes/16/text-x-csrc.svg
  icons/mimetypes/22/text-x-c++hdr.svg
  icons/mimetypes/22/text-x-c++src.svg
  icons/mimetypes/22/text-x-chdr.svg
  icons/mimetypes/22/text-x-csrc.svg
  icons/mimetypes/32/text-x-c++hdr.svg
  icons/mimetypes/32/text-x-c++src.svg
  icons/mimetypes/32/text-x-chdr.svg
  icons/mimetypes/32/text-x-csrc.svg
  icons/mimetypes/64/text-x-c++hdr.svg
  icons/mimetypes/64/text-x-c++src.svg
  icons/mimetypes/64/text-x-chdr.svg
  icons/mimetypes/64/text-x-csrc.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18865: Change C/C++ header/source mimetype icons to circle/line style

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh so much better!

REPOSITORY
  R266 Breeze Icons

BRANCH
  text-x-c (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18865

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18865: Change C/C++ header/source mimetype icons to circle/line style

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18865

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18865: Change C/C++ header/source mimetype icons to circle/line style

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  text-x-c (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18865

AFFECTED FILES
  icons-dark/mimetypes/16/text-x-c++hdr.svg
  icons-dark/mimetypes/16/text-x-c++src.svg
  icons-dark/mimetypes/16/text-x-chdr.svg
  icons-dark/mimetypes/16/text-x-csrc.svg
  icons-dark/mimetypes/22/text-x-c++hdr.svg
  icons-dark/mimetypes/22/text-x-c++src.svg
  icons-dark/mimetypes/22/text-x-chdr.svg
  icons-dark/mimetypes/22/text-x-csrc.svg
  icons-dark/mimetypes/32/text-x-c++hdr.svg
  icons-dark/mimetypes/32/text-x-c++src.svg
  icons-dark/mimetypes/32/text-x-chdr.svg
  icons-dark/mimetypes/32/text-x-csrc.svg
  icons-dark/mimetypes/64/text-x-c++hdr.svg
  icons-dark/mimetypes/64/text-x-c++src.svg
  icons-dark/mimetypes/64/text-x-chdr.svg
  icons-dark/mimetypes/64/text-x-csrc.svg
  icons/mimetypes/16/text-x-c++hdr.svg
  icons/mimetypes/16/text-x-c++src.svg
  icons/mimetypes/16/text-x-chdr.svg
  icons/mimetypes/16/text-x-csrc.svg
  icons/mimetypes/22/text-x-c++hdr.svg
  icons/mimetypes/22/text-x-c++src.svg
  icons/mimetypes/22/text-x-chdr.svg
  icons/mimetypes/22/text-x-csrc.svg
  icons/mimetypes/32/text-x-c++hdr.svg
  icons/mimetypes/32/text-x-c++src.svg
  icons/mimetypes/32/text-x-chdr.svg
  icons/mimetypes/32/text-x-csrc.svg
  icons/mimetypes/64/text-x-c++hdr.svg
  icons/mimetypes/64/text-x-c++src.svg
  icons/mimetypes/64/text-x-chdr.svg
  icons/mimetypes/64/text-x-csrc.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18830: Handle folders matching substrings of included/excluded folders correctly

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18830

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18612: Cache the default KColorScheme configuration

[Milian Wolff]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:c0cc6b8a200a: Cache the default KColorScheme 
configuration (authored by mwolff).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18612?vs=50541&id=51212#toc

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18612?vs=50541&id=51212

REVISION DETAIL
  https://phabricator.kde.org/D18612

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kcolorschemetest.cpp
  src/kcolorscheme.cpp

To: mwolff, #kate, #kdevelop, dfaure, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18837: Fix missing shadows on C/C++ header mimetype icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:0eea3019324f: Fix missing shadows on C/C++ header 
mimetype icons (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18837?vs=51150&id=51205

REVISION DETAIL
  https://phabricator.kde.org/D18837

AFFECTED FILES
  icons-dark/mimetypes/32/text-x-c++hdr.svg
  icons-dark/mimetypes/32/text-x-chdr.svg
  icons/mimetypes/32/text-x-c++hdr.svg
  icons/mimetypes/32/text-x-chdr.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18835: Handle as container element in SVG

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks for the test. :)

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18835

To: bruns, #baloo, #frameworks, astippich, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18612: Cache the default KColorScheme configuration

[Milian Wolff]

mwolff added a comment.


  pushed this now with a proper benchmark too, shows a ~10x performance win 
when a non-empty PATH is set

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18612

To: mwolff, #kate, #kdevelop, dfaure, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> configcommand.cpp:43
> +{
> +while (path.endsWith(QLatin1Char('/'))) {
> +path.chop(1);

Does this need to be a `while`? Why not a regular old `if`? Are you trying to 
handle the case where it ends with multiple trailing slashes?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18829

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

[Nathaniel Graham]

ngraham added a comment.


  @anemeth can provide the details, but IIRC we did wind up concluding that we 
needed this workaround in various places.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18798

To: anemeth, #frameworks, kde-frameworks-devel, ngraham, davidedmundson
Cc: elvisangelaccio, ngraham, kde-frameworks-devel, michaelh, bruns

D18833: Get rid of mostly unused filePathToStat overload

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18833

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18813: Filter out invalid content in lists

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D18813

To: leinir, #knewstuff, ngraham
Cc: ngraham, apol, kde-frameworks-devel, michaelh, ZrenBot, bruns

D18864: FlatBuffers schema syntax highlighting

[Harald Fernengel]

harald created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
harald requested review of this revision.

REVISION SUMMARY
  Support for FlatBuffers schema, for grammar see
  https://google.github.io/flatbuffers/flatbuffers_grammar.html

TEST PLAN
  Opened some Flatbuffers in kate and Qt Creator

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  flatbuffers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18864

AFFECTED FILES
  data/syntax/flatbuffers.xml

To: harald
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20FreeBSDQt5.12/9/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 08 Feb 2019 18:53:23 +
 Build duration:
1 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.kcolorschemetest

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.12 - Build # 4 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 Feb 2019 18:53:23 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5ConfigWidgets_compat_report.htmllogs/KF5ConfigWidgets/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.kcolorschemetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)41%
(13/32)41%
(13/32)33%
(910/2718)25%
(345/1363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests80%
(4/5)80%
(4/5)94%
(313/333)51%
(105/206)src47%
(9/19)47%
(9/19)28%
(597/2163)21%
(240/1137)tests0%
(0/8)0%
(0/8)0%
(0/222)0%
(0/20)

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.10 - Build # 8 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.10/8/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Feb 2019 18:53:22 +
 Build duration:
2 min 28 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5ConfigWidgets_compat_report.htmllogs/KF5ConfigWidgets/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.kcolorschemetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)41%
(13/32)41%
(13/32)33%
(910/2718)25%
(345/1363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests80%
(4/5)80%
(4/5)94%
(313/333)51%
(105/206)src47%
(9/19)47%
(9/19)28%
(597/2163)21%
(240/1137)tests0%
(0/8)0%
(0/8)0%
(0/222)0%
(0/20)

D18702: Remove monochrome font preferences icon

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b5c94b245d1a: Remove monochrome font preferences icon 
(authored by GB_2).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18702?vs=51167&id=51200

REVISION DETAIL
  https://phabricator.kde.org/D18702

AFFECTED FILES
  icons-dark/apps/22/preferences-desktop-font.svg
  icons/apps/22/preferences-desktop-font.svg

To: GB_2, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  remove-monochrome-font-preferences-icon-and-improve-font-selection-icon 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18855: Improve font selection icon

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:11e51771626b: Improve font selection icon (authored by 
GB_2).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18855?vs=51195&id=51196

REVISION DETAIL
  https://phabricator.kde.org/D18855

AFFECTED FILES
  icons-dark/actions/16/gtk-select-font.svg
  icons-dark/actions/22/gtk-select-font.svg
  icons-dark/actions/24/gtk-select-font.svg
  icons/actions/16/gtk-select-font.svg
  icons/actions/22/gtk-select-font.svg
  icons/actions/24/gtk-select-font.svg

To: GB_2, #vdg, ngraham
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D18855: Improve font selection icon

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-font-selection-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18855

To: GB_2, #vdg, ngraham
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D18837: Fix missing shadows on C/C++ header mimetype icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice. Next can you improve the hideous pixellated "c" and "h" characters for 
the C and C++ source and header files?
  F6601734: Screenshot_20190208_093323.png 

  F6601722: Screenshot_20190208_093123.png 

  
  Blech.
  
  Interestingly enough, the C++ header file already has a nice "h":
  F6601739: Screenshot_20190208_093413.png 


REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-text-x-hdr (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18837

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18855: Improve font selection icon

[Björn Feber]

GB_2 created this revision.
GB_2 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Improves the font selection icon by making the three dots black/white instead 
of orange.
  F6584835: Improved Font Selection Icon.png 


TEST PLAN
  Search for `gtk-select-font` in Cuttlefish.

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-font-selection-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18855

AFFECTED FILES
  icons-dark/actions/16/gtk-select-font.svg
  icons-dark/actions/22/gtk-select-font.svg
  icons-dark/actions/24/gtk-select-font.svg
  icons/actions/16/gtk-select-font.svg
  icons/actions/22/gtk-select-font.svg
  icons/actions/24/gtk-select-font.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D18853: Fix sharing files with spaces or quotes in names via Telegram

[Mikhail Rudenko]

mikhailru added a reviewer: apol.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D18853

To: mikhailru, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18853: Fix sharing files with spaces or quotes in names via Telegram

[Mikhail Rudenko]

mikhailru created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mikhailru requested review of this revision.

REVISION SUMMARY
  At present, when one tries to share files with
  certain names via Telegram using Dolphin's share menu,
  Dolphin crashes (names contain unbalanced quotes) or a wrong
  name is passed to Telegram (names with spaces). The root cause
  is KShell::splitArgs returning empty QStringList or doing
  wrong splits for the above classes of names. This patch
  postpones the substitution of "%u" with the actual filename
  until splitting is done, thus avoiding undesired behavior.

TEST PLAN
  1. Create test files:
  
  $ echo test | tee test\ .txt | tee test\'.txt > test\".txt
  
  2. Start Dolphin and share the files via Telegram.
  
  3. No errors and crashes should occur in the process.

REPOSITORY
  R495 Purpose Library

BRANCH
  telegram-sharing-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18853

AFFECTED FILES
  src/plugins/telegram/telegramplugin.cpp

To: mikhailru
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18739: Sync QML module padding to reflect system setting pages

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:ab33762a6a60: Sync QML module padding to reflect system 
setting pages (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18739?vs=51174&id=51185#toc

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18739?vs=51174&id=51185

REVISION DETAIL
  https://phabricator.kde.org/D18739

AFFECTED FILES
  src/kcmultidialog.cpp

To: davidedmundson, #plasma, broulik
Cc: ngraham, zzag, broulik, vpilo, kde-frameworks-devel, michaelh, bruns

D16735: Implement text_input_unstable_v3

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> test_text_input.cpp:545-548
> +QFETCH(bool, clientCommits);
> +if (clientCommits) {
> +textInput->commit();
> +}

Personal opinion: tests have to be easy to follow, it's okay if we copy some 
code. I'd prefer to have a specialized test, e.g. testSurroundingTextV3.

> test_text_input.cpp:1001
> +
> +QTest::newRow("UnstableV3") << TextInputInterfaceVersion::UnstableV3;
> +}

If there is only one row, we don't need _data().

> textinput.h:122
> + * of the surrounding text or cursor position.
> + */
> +enum class ChangeCause : uint32_t {

**/

> textinput_p.h:83
> +/**
> + * Creates a new TextInputManagerUnstableV0.
> + * Note: after constructing the TextInputManagerUnstableV0 it is not yet 
> valid and one needs

V3?

> textinput_interface_v3.cpp:137-140
> +/*
> + * Pending data can only be amended when the interface
> + * is (about to be) enabled.
> + */

Please use single line comments instead.

> textinput_interface_v3.cpp:428
> +
> +namespace {
> +static TextInputInterface::ChangeCause 
> waylandCauseToKWayland(zwp_text_input_v3_change_cause wlCause)

We don't need this namespace because waylandCauseToKWayland is static.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16735

To: romangg, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18739: Sync QML module padding to reflect system setting pages

[Nathaniel Graham]

ngraham added a comment.


  Looks like this also fixes https://bugs.kde.org/show_bug.cgi?id=396942

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18739

To: davidedmundson, #plasma, broulik
Cc: ngraham, zzag, broulik, vpilo, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/8/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 Feb 2019 14:21:45 +
 Build duration:
3 min 45 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5683/9485)43%
(2221/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)95%
(843/886)52%
(271/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(849/1674)42%
(437/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/944)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
  

D18804: Workaround for the bug 393630 - Framework part

[Nathaniel Graham]

ngraham removed a dependent revision: D18805: Workaround for the bug 393630 - 
SystemTray part.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18804

To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18851: [Extractor] Exclude GPG encrypted data from being indexed

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:3aa911d4a0ac: [Extractor] Exclude GPG encrypted data from 
being indexed (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18851?vs=51183&id=51184

REVISION DETAIL
  https://phabricator.kde.org/D18851

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18851: [Extractor] Exclude GPG encrypted data from being indexed

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18851

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18851: [Extractor] Exclude GPG encrypted data from being indexed

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  application/pgp-encrypted may be encoded as base64 and thus inherits from
  text/plain, but contains no extractable plaintext at all.
  
  CCBUG: 386791

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18851

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18813: Filter out invalid content in lists

[Nathaniel Graham]

ngraham added a comment.


  Conceptually this makes sense, provided we can rely on `content.isValid()` 
returning valid results. :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D18813

To: leinir, #knewstuff
Cc: ngraham, apol, kde-frameworks-devel, michaelh, ZrenBot, bruns

D18849: [KPropertiesDialog] Fix group combobox

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18849

To: cfeck, #frameworks, #dolphin, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18849: [KPropertiesDialog] Fix group combobox

[Christoph Feck]

cfeck created this revision.
cfeck added reviewers: Frameworks, Dolphin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cfeck requested review of this revision.

REVISION SUMMARY
  `groupList` was never initialized with `KUser::groupNames()`, causing the 
subsequent combobox setup to be skipped.
  
  BUG: 403074

TEST PLAN
  `kpropertiesdialogtest` shows a combobox with `users` and `audio` groups on 
my system. Without this patch, no combobox appears.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18849

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: cfeck, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18768: Extend Open Document thumbnailer to Open Packaging Conventions format

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:c6da4dabf635: Extend Open Document thumbnailer to Open 
Packaging Conventions format (authored by broulik).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18768?vs=51173&id=51178

REVISION DETAIL
  https://phabricator.kde.org/D18768

AFFECTED FILES
  thumbnail/opendocumentcreator.cpp
  thumbnail/opendocumentthumbnail.desktop

To: broulik, #plasma, #vdg, #frameworks, davidedmundson
Cc: davidedmundson, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D18846: allow to compile without Q_FOREACH support

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b1ecf6aa60c2: allow to compile without Q_FOREACH support 
(authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18846?vs=51171&id=51177#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18846?vs=51171&id=51177

REVISION DETAIL
  https://phabricator.kde.org/D18846

AFFECTED FILES
  autotests/foldingtest.cpp
  autotests/highlighter_benchmark.cpp
  autotests/htmlhighlighter_test.cpp
  autotests/syntaxrepository_test.cpp
  autotests/testhighlighter.cpp
  examples/codeeditor.cpp
  src/cli/kate-syntax-highlighter.cpp
  src/indexer/katehighlightingindexer.cpp
  src/lib/definition.cpp
  src/lib/repository.cpp

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D18768: Extend Open Document thumbnailer to Open Packaging Conventions format

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18768

To: broulik, #plasma, #vdg, #frameworks, davidedmundson
Cc: davidedmundson, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D18739: Sync QML module padding to reflect system setting pages

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> kcmultidialog.cpp:40-41
>  #include 
> +#include 
> +#include 
>  

It looks like includes are sorted. Maybe keep it that way?

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18739

To: davidedmundson, #plasma, broulik
Cc: zzag, broulik, vpilo, kde-frameworks-devel, michaelh, ngraham, bruns

D18846: allow to compile without Q_FOREACH support

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18846

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D18739: Sync QML module padding to reflect system setting pages

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18739

To: davidedmundson, #plasma, broulik
Cc: broulik, vpilo, kde-frameworks-devel, michaelh, ngraham, bruns

D18768: Extend Open Document thumbnailer to Open Packaging Conventions format

[Kai Uwe Broulik]

broulik retitled this revision from "Extend Open Document thumbnailer to Office 
Open XML" to "Extend Open Document thumbnailer to Open Packaging Conventions 
format".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18768

To: broulik, #plasma, #vdg, #frameworks, davidedmundson
Cc: davidedmundson, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D18739: Sync QML module padding to reflect system setting pages

[David Edmundson]

davidedmundson updated this revision to Diff 51174.
davidedmundson added a comment.


  more hacks

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18739?vs=51165&id=51174

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18739

AFFECTED FILES
  src/kcmultidialog.cpp

To: davidedmundson, #plasma
Cc: broulik, vpilo, kde-frameworks-devel, michaelh, ngraham, bruns

D18768: Extend Open Document thumbnailer to Office Open XML

[Kai Uwe Broulik]

broulik updated this revision to Diff 51173.
broulik added a comment.


  - Read thumbnail location from `rels`
  - Add `.xps` file format (used in Windows for printing, I believe) which also 
follows the spec and qualifies as "office document"

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18768?vs=50981&id=51173

REVISION DETAIL
  https://phabricator.kde.org/D18768

AFFECTED FILES
  thumbnail/opendocumentcreator.cpp
  thumbnail/opendocumentthumbnail.desktop

To: broulik, #plasma, #vdg, #frameworks, davidedmundson
Cc: davidedmundson, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D18846: allow to compile without Q_FOREACH support

[Christoph Cullmann]

cullmann updated this revision to Diff 51171.
cullmann added a comment.


  Missed 2 Q_FOREACH variants

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18846?vs=51168&id=51171

REVISION DETAIL
  https://phabricator.kde.org/D18846

AFFECTED FILES
  autotests/foldingtest.cpp
  autotests/highlighter_benchmark.cpp
  autotests/htmlhighlighter_test.cpp
  autotests/syntaxrepository_test.cpp
  autotests/testhighlighter.cpp
  autotests/theme_test.cpp
  examples/codeeditor.cpp
  src/cli/kate-syntax-highlighter.cpp
  src/indexer/katehighlightingindexer.cpp
  src/lib/definition.cpp
  src/lib/repository.cpp

To: cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D18768: Extend Open Document thumbnailer to Office Open XML

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  It seems we can get the correct path via the _rels file as per
  https://en.wikipedia.org/wiki/Open_Packaging_Conventions
  
  which avoids guessing, and allows us to support more file formats in one go

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18768

To: broulik, #plasma, #vdg, #frameworks, davidedmundson
Cc: davidedmundson, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D18813: Filter out invalid content in lists

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 51169.
leinir marked an inline comment as done.
leinir added a comment.


  Swap the logic around a bit, makes for an easier to read patch and whatnot.

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18813?vs=51099&id=51169

REVISION DETAIL
  https://phabricator.kde.org/D18813

AFFECTED FILES
  src/attica/atticaprovider.cpp

To: leinir, #knewstuff
Cc: apol, kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns

D18813: Filter out invalid content in lists

[Dan Leinir Turthra Jensen]

leinir marked an inline comment as done.
leinir added inline comments.

INLINE COMMENTS

> apol wrote in atticaprovider.cpp:277
> Maybe it would be easier to read if we had a `if (!content.isValid()) 
> continue; ...`.

Hmm... the patch certainly would, i'll swap that around a bit. Generally don't 
like negations too much if i can avoid them, hunting exclamation marks just 
gets tiring after a while, but yeah, smaller patch is good anyway :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D18813

To: leinir, #knewstuff
Cc: apol, kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns

D18846: allow to compile without Q_FOREACH support

[Christoph Cullmann]

cullmann created this revision.
cullmann added a reviewer: vkrause.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  replaces Q_FOREACH with C++11 for

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18846

AFFECTED FILES
  autotests/foldingtest.cpp
  autotests/highlighter_benchmark.cpp
  autotests/htmlhighlighter_test.cpp
  autotests/syntaxrepository_test.cpp
  autotests/testhighlighter.cpp
  examples/codeeditor.cpp
  src/cli/kate-syntax-highlighter.cpp
  src/indexer/katehighlightingindexer.cpp
  src/lib/definition.cpp
  src/lib/repository.cpp

To: cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D18702: Remove monochrome font preferences icon

[Björn Feber]

GB_2 retitled this revision from "Remove monochrome font preferences icon and 
improve font selection icon" to "Remove monochrome font preferences icon".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

[Björn Feber]

GB_2 updated this revision to Diff 51167.
GB_2 added a comment.


  Revert font selection icon change

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18702?vs=50782&id=51167

BRANCH
  remove-monochrome-font-preferences-icon-and-improve-font-selection-icon 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18702

AFFECTED FILES
  icons-dark/apps/22/preferences-desktop-font.svg
  icons/apps/22/preferences-desktop-font.svg

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

[Björn Feber]

GB_2 edited the summary of this revision.
GB_2 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18739: Sync QML module padding to reflect system setting pages

[David Edmundson]

davidedmundson added a comment.


  Running kcmshell5 icons style was a good suggestion.
  
  We have to change an internal layout and only one of the edges - which leads 
to this monstrosity :/

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18739

To: davidedmundson, #plasma
Cc: broulik, vpilo, kde-frameworks-devel, michaelh, ngraham, bruns

D18739: Sync QML module padding to reflect system setting pages

[David Edmundson]

davidedmundson updated this revision to Diff 51165.
davidedmundson added a comment.


  remove hardcoded value

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18739?vs=51163&id=51165

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18739

AFFECTED FILES
  src/kcmultidialog.cpp

To: davidedmundson, #plasma
Cc: broulik, vpilo, kde-frameworks-devel, michaelh, ngraham, bruns

D18739: Sync QML module padding to reflect system setting pages

[David Edmundson]

davidedmundson updated this revision to Diff 51163.
davidedmundson edited the summary of this revision.
davidedmundson edited the test plan for this revision.
davidedmundson added a comment.


  update

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18739?vs=50897&id=51163

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18739

AFFECTED FILES
  src/kcmultidialog.cpp

To: davidedmundson, #plasma
Cc: broulik, vpilo, kde-frameworks-devel, michaelh, ngraham, bruns

D18813: Filter out invalid content in lists

[Aleix Pol Gonzalez]

apol added a comment.


  I guess the patch makes sense overall.

INLINE COMMENTS

> atticaprovider.cpp:277
> +for (const Content &content : contents) {
> +if (content.isValid()) {
> +if (checker.filterAccepts(content.tags())) {

Maybe it would be easier to read if we had a `if (!content.isValid()) continue; 
...`.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D18813

To: leinir, #knewstuff
Cc: apol, kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Vlad Zagorodniy]

zzag added a comment.


  Also, it's worth to mention glowbar from Oxygen theme 
(plasma-framework/src/desktoptheme/oxygen/widgets/glowbar.svgz).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: zzag, rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Vlad Zagorodniy]

zzag added a comment.


  In D18834#407533 , @ndavis wrote:
  
  > I had a look through the Screen Edge effect code and while I'm no expert, I 
didn't see anything that would obviously make the corners large.
  
  
  The screen edge effect scales corner tiles and I don't think this will be 
changed.
  
  If slightly bigger corner glows is really such a big issue, then as a 
potential solution, the gradients could be "scaled" down a little bit.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: zzag, rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18739: Sync QML module padding to reflect system setting pages

[Valerio Pilo]

vpilo added a comment.


  In D18739#407649 , @broulik wrote:
  
  > If you open multiple KCMs switching between QML- and Widget-ones leads to 
awkward outside margin changes with this patch.
  >
  >   kcmshell5 icons style
  >
  >
  > Switch between the two and observe how the sidebar dances (this is likely 
the same issue as when doing the same in System Settings in Icons mode rather 
than Sidebar)
  
  
  I didn't realize you could open multiple KCMs. With that, it's much easier 
for me to see that there's multiple differences between QML- and Widget- based 
KCMs. Disabling window decoration borders, it's even more visible.
  
  | F6600583: qml.png  | F6600582: 
widget.png  |  |

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18739

To: davidedmundson, #plasma
Cc: broulik, vpilo, kde-frameworks-devel, michaelh, ngraham, bruns

Re: CI for prison: missing dependency

[Ben Cooksley]

On Fri, Feb 8, 2019 at 5:57 AM Volker Krause  wrote:
>
> On Saturday, 2 February 2019 19:15:36 CET Ben Cooksley wrote:
> > On Sun, Feb 3, 2019 at 12:02 AM David Faure  wrote:
> > > On samedi 2 février 2019 11:20:28 CET CI System wrote:
> > > > -- The following REQUIRED packages have not been found:
> > > >
> > > > * QRencode, The QRencode library,
> > >
> > > Can this be added to the CI?
> >
> > Unfortunately Android doesn't use the standard mechanisms for this - I
> > think we have to compile stuff ourselves.
> > Any idea on this Aleix?
>
> looking at
> https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/7/
> console
>
> libqrencode is actually built and installed, but the unresolved $WORKSPACE and
> $HOME in the install path looks suspicious, I'm not seeing that in other
> builds:
> "-- Installing: INSTALL_ROOT=$WORKSPACE/install-divert/home/user/workspace/
> Frameworks/prison/kf5-qt5 AndroidQt5.11/build/libqrencode/$HOME/install-
> prefix/include/qrencode.h"
>
> Maybe that's the problem? CMake wouldn't pick up dependencies in that location
> then I guess.
>

I've now corrected the issue in the CI system which was causing this
behaviour to occur.

> Thanks,
> Volker

Cheers,
Ben

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 13 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/13/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Fri, 08 Feb 2019 09:54:10 +
 Build duration:
1 min 4 sec and counting

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 12 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/12/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Fri, 08 Feb 2019 09:37:11 +
 Build duration:
1 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 248 lines...]HUDSON_HOME   = '/home/production/data'WORKSPACE = '/home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'SHELL = '/bin/sh'USER  = 'user'BUILD_ID  = '12'OLDPWD= '/home/user'DEBIAN_FRONTEND   = 'noninteractive'STAGE_NAME= 'Configuring Build'MAIL  = '/var/mail/user'ANDROID_NDK_TOOLCHAIN_PREFIX = 'arm-linux-androideabi'ANDROID_HOME  = '/opt/android-sdk'PATH  = '/opt/Qt/5.11.3/android_armv7/bin:/opt/kdeandroid-deps/bin:/opt/cmake/bin:/opt/Qt/5.11.3/android_armv7/bin:/opt/android-sdk/tools:/opt/android-sdk/tools/bin:/opt/android-sdk/platform-tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'LANGUAGE  = 'en_US.UTF-8'CMAKE_PREFIX_PATH = '/home/user/install-prefix:/opt/Qt/5.11.3/android_armv7:/opt/kdeandroid-deps'HOME  = '/home/user'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/display/redirect'ANDROID_NDK_PLATFORM  = 'android-21'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DBUILD_COVERAGE=ON -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix;/opt/Qt/5.11.3/android_armv7;/opt/kdeandroid-deps"  "/home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11"-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=-- Android: Targeting API '14' with architecture 'arm', ABI 'armeabi-v7a', and processor 'armv7-a'-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=-- Android: Selected GCC toolchain 'arm-linux-androideabi-4.9'-- The C compiler identification is GNU 4.9.0-- The CXX compiler identification is GNU 4.9.0-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Failed-- Could NOT find QRencode (missing: QRencode_LIBRARIES QRencode_INCLUDE_DIRS) -- Could NOT find Dmtx (missing: Dmtx_LIBRARIES Dmtx_INCLUDE_DIRS) -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following OPTIONAL packages have been found: * Qt5Network (required version >= 5.11.3) * Qt5Qml (required version >= 5.11.3) * Qt5Quick-- The following REQUIRED packages have been found: * ECM (required version >= 5.55.0), Extra CMake Modules.,  * Qt5Core * Qt5Gui * Qt5Test * Qt5Widgets * Qt5 (required version >= 5.10.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RECOMMENDED packages have not been found: * Dmtx, The Datamatrix library, -- The following REQUIRED packages have not been found: * QRencode, The QRencode library, CMake Error at /opt/cmake/share/cmake-3.12/Modules/FeatureSummary.cmake:459 (message):  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake  run.Call Stack (most recent call first):  CMakeLists.txt:93 (feature_summary)-- Configuring incomplete, errors occurred!See also "/home/user/wor

D18739: Sync QML module padding to reflect system setting pages

[Kai Uwe Broulik]

broulik added a comment.


  If you open multiple KCMs switching between QML- and Widget-ones leads to 
awkward outside margin changes with this patch.
  
kcmshell5 icons style
  
  Switch between the two and observe how the sidebar dances (this is likely the 
same issue as when doing the same in System Settings in Icons mode rather than 
Sidebar)

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18739

To: davidedmundson, #plasma
Cc: broulik, vpilo, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/8/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 Feb 2019 08:57:29 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/16/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Feb 2019 08:57:29 +
 Build duration:
4 min 44 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/20/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 08 Feb 2019 08:57:29 +
 Build duration:
2 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:054b494bb3f2: Change glowbar.svgz to smoother style 
(authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18834?vs=51144&id=51154

REVISION DETAIL
  https://phabricator.kde.org/D18834

AFFECTED FILES
  src/desktoptheme/breeze/widgets/glowbar.svgz

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis added a comment.


  Well, there's nothing wrong within the patch itself, so I'll land it.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18804: Workaround for the bug 393630 - Framework part

[Tranter Madi]

trmdi abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18804

To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18837: Fix missing shadows on C/C++ header mimetype icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Some shadow objects had no fill because the gradients they referenced were 
missing.
  
  BUG: 401793
  FIXED-IN: 5.56

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-text-x-hdr (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18837

AFFECTED FILES
  icons-dark/mimetypes/32/text-x-c++hdr.svg
  icons-dark/mimetypes/32/text-x-chdr.svg
  icons/mimetypes/32/text-x-c++hdr.svg
  icons/mimetypes/32/text-x-chdr.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns