Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Sept. 25, 2013, 10:48 a.m.) Status -- This change has been discarded. Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.cpp 2057b47 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd Diff: http://git.reviewboard.kde.org/r/112364/diff/ Testing --- Extensive editing of sample files, and changing back and forth between different activity types, which tended to show problem areas. atype run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On Sept. 25, 2013, 3:21 a.m., Cristian Oneț wrote: I would not ship this patch. I'll elaborate a bit more my comments at https://bugs.kde.org/show_bug.cgi?id=312816#c6 and I'll base my arguments on this recording I made http://kmymoney2.sourceforge.net/screencasts/112364.ogv about how this patch behaves. 1. It breaks with the current behavior of the application (auto resizing columns after data has been entered to fit the entered data) 2. It introduces bugs, I mean, setting a maxWidth of 9,999,999.00 for the amount fields!? This is exactly what was hurting the number column and the fix should be all about removing a limitation not adding new ones You've concentrated on forms mode, where there is not much wrong. 1. Depending on content, there was some clipping. 2. There already was in Thomas's implementation a width restriction for the number column, so I eased it substantially. The existing excessive width of some columns can result in clipping elsewhere. There are still problems with non/unnecessary appearance of investment widgets. - Allan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review40732 --- On Sept. 15, 2013, 4:26 p.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Sept. 15, 2013, 4:26 p.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.cpp 2057b47 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd Diff: http://git.reviewboard.kde.org/r/112364/diff/ Testing --- Extensive editing of sample files, and changing back and forth between different activity types, which tended to show problem areas. atype run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On Sept. 25, 2013, 3:21 a.m., Cristian Oneț wrote: I would not ship this patch. I'll elaborate a bit more my comments at https://bugs.kde.org/show_bug.cgi?id=312816#c6 and I'll base my arguments on this recording I made http://kmymoney2.sourceforge.net/screencasts/112364.ogv about how this patch behaves. 1. It breaks with the current behavior of the application (auto resizing columns after data has been entered to fit the entered data) 2. It introduces bugs, I mean, setting a maxWidth of 9,999,999.00 for the amount fields!? This is exactly what was hurting the number column and the fix should be all about removing a limitation not adding new ones Allan Anderson wrote: You've concentrated on forms mode, where there is not much wrong. 1. Depending on content, there was some clipping. 2. There already was in Thomas's implementation a width restriction for the number column, so I eased it substantially. The existing excessive width of some columns can result in clipping elsewhere. There are still problems with non/unnecessary appearance of investment widgets. I know that the problem with unnecessary widgets is still there, I thought you are working on that (see the discussion with me, the patch I sent you, your discussion with David). We should still fix that issue. I thought that this review request (patch) only handles the number column issue (BUG 312816) at least the latest version of the patch. I just tried to show that the patch does more damage than good, I agree that there are some issues now but they should be fixed in a proper way so that we don't break current behavior. I'm sure that all those issues that you've observed with the investment editor without the transaction form can be fixed while keeping the current behavior of the transaction form. With the patch I attached to BUG 312816 I agree that the first time a long check number is entered the user will not see it entirely, but, after the transaction is entered the width of that column is adjusted to fit the entered data, thus next time the user will not have this issue when entering a similar check number. I prefer this, you could say, sloppy implementation because of it's very small incidence to the one which makes the column size change at each key press (with a big incidence). - Cristian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review40732 --- On Sept. 25, 2013, 10:48 a.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Sept. 25, 2013, 10:48 a.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.cpp 2057b47 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd Diff: http://git.reviewboard.kde.org/r/112364/diff/ Testing --- Extensive editing of sample files, and changing back and forth between different activity types, which tended to show problem areas. atype run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review40732 --- I would not ship this patch. I'll elaborate a bit more my comments at https://bugs.kde.org/show_bug.cgi?id=312816#c6 and I'll base my arguments on this recording I made http://kmymoney2.sourceforge.net/screencasts/112364.ogv about how this patch behaves. 1. It breaks with the current behavior of the application (auto resizing columns after data has been entered to fit the entered data) 2. It introduces bugs, I mean, setting a maxWidth of 9,999,999.00 for the amount fields!? This is exactly what was hurting the number column and the fix should be all about removing a limitation not adding new ones - Cristian Oneț On Sept. 15, 2013, 4:26 p.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Sept. 15, 2013, 4:26 p.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.cpp 2057b47 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd Diff: http://git.reviewboard.kde.org/r/112364/diff/ Testing --- Extensive editing of sample files, and changing back and forth between different activity types, which tended to show problem areas. atype run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Sept. 15, 2013, 4:26 p.m.) Review request for KMymoney. Changes --- As agreed below, this is to concentrate on the column width issues. It is almost exclusively in the Register class, with revised versions of Register::adjustColumn(int col) and Register::resize(int col, bool force), which are much the same as in the original submission. This will ensure each column is wide enough for its data, so no need (or ability) for the user to resize any individual columns. Also, at the moment, while entering or editing a transaction, the width of all the edit edit boxes is considerably hidden by calculator or date entry buttons. This is improved, and the Number column width can expand while editing, so the user can actually see all of his entry, instead of it scrolling out of sight. The whole window may be resized, as now, but I'm abandoning, for now, the long-standing issue of investment edit widgets appearing/disappearing illogically. The overall size of the patch is much reduced. It is a replacement for the original one. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs (updated) - kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.cpp 2057b47 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd Diff: http://git.reviewboard.kde.org/r/112364/diff/ Testing --- Extensive editing of sample files, and changing back and forth between different activity types, which tended to show problem areas. atype run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote: kmymoney/dialogs/transactioneditor.h, line 155 http://git.reviewboard.kde.org/r/112364/diff/1/?file=185613#file185613line155 Is making this public a good idea? I had already reverted it here to protected. On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote: kmymoney/dialogs/investactivities.cpp, line 219 http://git.reviewboard.kde.org/r/112364/diff/1/?file=185610#file185610line219 Is there a reason why the show of shares and price was move out from the for loop? Within the loop, they were handled as QWidgets and were misbehaving. I needed them to be kMyMoneyEdit, to access its children. On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote: kmymoney/dialogs/investactivities.cpp, line 318 http://git.reviewboard.kde.org/r/112364/diff/1/?file=185610#file185610line318 Same questions as Buy::showWidgets() Same answer. On Sept. 10, 2013, 7:20 a.m., Allan Anderson wrote: Another nice thing would be to have a separate patch for each individual functionality. Right now we have two things here 1 - ledger resizing and 2 - investment editor fix for widgets that are visible when they should not be. For me it's not that easy to make a review this way. Allan Anderson wrote: The two came along together. I can do this for these changes in the investment editor, but most of the trouble was in the new code, even though the methods were identical or near-identical. So, for these, there is no patch fixing something, as there was no code there before. Anyway, I'll see if I can do some separation. Allan Anderson wrote: Incidentally, this problem with the edit widgets disappearing/appearing when wanted/unwanted is present in an unpatched git HEAD, and has been there for a long while. Opening any investment transaction, then resizing the window, will produce it with one or more widgets. From some fresh experiments, if a hide() (or show()) does not do the necessary, then often replacing with setCalculatorButtonVisible(false) and lineedit()-hide() does the trick. Sadly though, that does not work in every case, and it looks like the only sure-fire fix is the one I came up with, setting the widget height to zero instead of hiding. What I'm working on and proposing is, for now, to concentrate on the column width issues. It is almost exclusively in the Register class, with revised versions of Register::adjustColumn(int col) and Register::resize(int col, bool force), which are much the same as in the original submission. This will ensure each column is wide enough for its data, so no need (or ability) for the user to resize any individual columns. Also, at the moment, while entering or editing a transaction, the width of all the edit edit boxes is considerably hidden by calculator or date entry buttons. This is improved, and the number column width can expand while editing, so the user can actually see all of his entry, instead of it scrolling out of sight. The whole window may be resized, as now, but I'm abandoning the long-standing issue of investment edit widgets appearing/disappearing illogically. The overall size of the patch is much reduced. I hope you agree for me to proceed with this. - Allan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review39691 --- On Aug. 29, 2013, 5:12 p.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Aug. 29, 2013, 5:12 p.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On Sept. 10, 2013, 7:20 a.m., Allan Anderson wrote: Another nice thing would be to have a separate patch for each individual functionality. Right now we have two things here 1 - ledger resizing and 2 - investment editor fix for widgets that are visible when they should not be. For me it's not that easy to make a review this way. Allan Anderson wrote: The two came along together. I can do this for these changes in the investment editor, but most of the trouble was in the new code, even though the methods were identical or near-identical. So, for these, there is no patch fixing something, as there was no code there before. Anyway, I'll see if I can do some separation. Allan Anderson wrote: Incidentally, this problem with the edit widgets disappearing/appearing when wanted/unwanted is present in an unpatched git HEAD, and has been there for a long while. Opening any investment transaction, then resizing the window, will produce it with one or more widgets. From some fresh experiments, if a hide() (or show()) does not do the necessary, then often replacing with setCalculatorButtonVisible(false) and lineedit()-hide() does the trick. Sadly though, that does not work in every case, and it looks like the only sure-fire fix is the one I came up with, setting the widget height to zero instead of hiding. Allan Anderson wrote: What I'm working on and proposing is, for now, to concentrate on the column width issues. It is almost exclusively in the Register class, with revised versions of Register::adjustColumn(int col) and Register::resize(int col, bool force), which are much the same as in the original submission. This will ensure each column is wide enough for its data, so no need (or ability) for the user to resize any individual columns. Also, at the moment, while entering or editing a transaction, the width of all the edit edit boxes is considerably hidden by calculator or date entry buttons. This is improved, and the number column width can expand while editing, so the user can actually see all of his entry, instead of it scrolling out of sight. The whole window may be resized, as now, but I'm abandoning the long-standing issue of investment edit widgets appearing/disappearing illogically. The overall size of the patch is much reduced. I hope you agree for me to proceed with this. Sure, go on, I'm happy with the solution you've described. I'll take a look at the investment edit widgets issue when I can. - Cristian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review39691 --- On Aug. 29, 2013, 5:12 p.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Aug. 29, 2013, 5:12 p.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/investactivities.cpp 50f33ed kmymoney/dialogs/investtransactioneditor.h 3e62c2a kmymoney/dialogs/investtransactioneditor.cpp e9f87fb kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.h 04a6303 kmymoney/views/kgloballedgerview.cpp 78d98b2 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On Fri, 13 Sep 2013 10:50:53 - Cristian Oneț onet.crist...@gmail.com wrote: On Sept. 10, 2013, 7:20 a.m., Allan Anderson wrote: Another nice thing would be to have a separate patch for each individual functionality. Right now we have two things here 1 - ledger resizing and 2 - investment editor fix for widgets that are visible when they should not be. For me it's not that easy to make a review this way. Allan Anderson wrote: The two came along together. I can do this for these changes in the investment editor, but most of the trouble was in the new code, even though the methods were identical or near-identical. So, for these, there is no patch fixing something, as there was no code there before. Anyway, I'll see if I can do some separation. Allan Anderson wrote: Incidentally, this problem with the edit widgets disappearing/appearing when wanted/unwanted is present in an unpatched git HEAD, and has been there for a long while. Opening any investment transaction, then resizing the window, will produce it with one or more widgets. From some fresh experiments, if a hide() (or show()) does not do the necessary, then often replacing with setCalculatorButtonVisible(false) and lineedit()-hide() does the trick. Sadly though, that does not work in every case, and it looks like the only sure-fire fix is the one I came up with, setting the widget height to zero instead of hiding. Allan Anderson wrote: What I'm working on and proposing is, for now, to concentrate on the column width issues. It is almost exclusively in the Register class, with revised versions of Register::adjustColumn(int col) and Register::resize(int col, bool force), which are much the same as in the original submission. This will ensure each column is wide enough for its data, so no need (or ability) for the user to resize any individual columns. Also, at the moment, while entering or editing a transaction, the width of all the edit edit boxes is considerably hidden by calculator or date entry buttons. This is improved, and the number column width can expand while editing, so the user can actually see all of his entry, instead of it scrolling out of sight. The whole window may be resized, as now, but I'm abandoning the long-standing issue of investment edit widgets appearing/disappearing illogically. The overall size of the patch is much reduced. I hope you agree for me to proceed with this. Sure, go on, I'm happy with the solution you've described. I'll take a look at the investment edit widgets issue when I can. Yes, I noticed you've been a bit busy! Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote: kmymoney/dialogs/investtransactioneditor.h, line 166 http://git.reviewboard.kde.org/r/112364/diff/1/?file=185611#file185611line166 Is register really an 'int'? This is in fact not used. I suspect the 'int' was a 'helpful guess' from KDevelop that I didn't pursue. On Sept. 10, 2013, 7:20 a.m., Allan Anderson wrote: Another nice thing would be to have a separate patch for each individual functionality. Right now we have two things here 1 - ledger resizing and 2 - investment editor fix for widgets that are visible when they should not be. For me it's not that easy to make a review this way. Allan Anderson wrote: The two came along together. I can do this for these changes in the investment editor, but most of the trouble was in the new code, even though the methods were identical or near-identical. So, for these, there is no patch fixing something, as there was no code there before. Anyway, I'll see if I can do some separation. Incidentally, this problem with the edit widgets disappearing/appearing when wanted/unwanted is present in an unpatched git HEAD, and has been there for a long while. Opening any investment transaction, then resizing the window, will produce it with one or more widgets. From some fresh experiments, if a hide() (or show()) does not do the necessary, then often replacing with setCalculatorButtonVisible(false) and lineedit()-hide() does the trick. Sadly though, that does not work in every case, and it looks like the only sure-fire fix is the one I came up with, setting the widget height to zero instead of hiding. - Allan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review39691 --- On Aug. 29, 2013, 5:12 p.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Aug. 29, 2013, 5:12 p.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/investactivities.cpp 50f33ed kmymoney/dialogs/investtransactioneditor.h 3e62c2a kmymoney/dialogs/investtransactioneditor.cpp e9f87fb kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.h 04a6303 kmymoney/views/kgloballedgerview.cpp 78d98b2 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd kmymoney/widgets/transactionform.cpp 642e98f Diff: http://git.reviewboard.kde.org/r/112364/diff/ Testing --- Extensive editing of sample files, and changing back and forth between different activity types, which tended to show problem areas. atype run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review39691 --- kmymoney/dialogs/investactivities.cpp http://git.reviewboard.kde.org/r/112364/#comment29234 Could you add a little comment on why do you need to set the rowHeight later to this value? kmymoney/dialogs/investactivities.cpp http://git.reviewboard.kde.org/r/112364/#comment29235 Also I don't see a reason why the timeouts passed to QTimer::signleShot vary that much, 5, 100, 150, is there a reason for it? kmymoney/dialogs/investactivities.cpp http://git.reviewboard.kde.org/r/112364/#comment29236 Is there a reason why the show of shares and price was move out from the for loop? kmymoney/dialogs/investactivities.cpp http://git.reviewboard.kde.org/r/112364/#comment29237 Same questions as Buy::showWidgets() kmymoney/dialogs/investtransactioneditor.h http://git.reviewboard.kde.org/r/112364/#comment29232 Is register really an 'int'? kmymoney/dialogs/transactioneditor.h http://git.reviewboard.kde.org/r/112364/#comment29238 Is making this public a good idea? Another nice thing would be to have a separate patch for each individual functionality. Right now we have two things here 1 - ledger resizing and 2 - investment editor fix for widgets that are visible when they should not be. For me it's not that easy to make a review this way. - Cristian Oneț On Aug. 29, 2013, 5:12 p.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Aug. 29, 2013, 5:12 p.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/investactivities.cpp 50f33ed kmymoney/dialogs/investtransactioneditor.h 3e62c2a kmymoney/dialogs/investtransactioneditor.cpp e9f87fb kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.h 04a6303 kmymoney/views/kgloballedgerview.cpp 78d98b2 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd kmymoney/widgets/transactionform.cpp 642e98f Diff: http://git.reviewboard.kde.org/r/112364/diff/ Testing --- Extensive editing of sample files, and changing back and forth between different activity types, which tended to show problem areas. atype run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote: kmymoney/dialogs/investactivities.cpp, line 198 http://git.reviewboard.kde.org/r/112364/diff/1/?file=185610#file185610line198 Could you add a little comment on why do you need to set the rowHeight later to this value? From the last paragraph of the description above - I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote: kmymoney/dialogs/investactivities.cpp, line 204 http://git.reviewboard.kde.org/r/112364/diff/1/?file=185610#file185610line204 Also I don't see a reason why the timeouts passed to QTimer::signleShot vary that much, 5, 100, 150, is there a reason for it? I can't give an explanation for why the should differ. Having previously encountered this same problem some why ago, Thomas advised using the timer. As before, I started off using a small value, but found that this didn't work in the new near-identical code area. So, I started to increase the delay. In come cases, I had to use a large delay in order to see that the widget did finally respond. I then started to reduce the value until failure, and then back-off. Having got a particular widget finally responding, after further work I found that the problem was still sometimes there and had to make further adjustments. In many cases, this 'tuning' was revisited. When finally all appeared OK, I then found that during actual window resizing, some widgets would flicker quite badly during their repositioning, depending upon the speed of mouse movement. The only way I could resolve that was by zeroing the widget height instead of hiding it. On Sept. 10, 2013, 7:20 a.m., Allan Anderson wrote: Another nice thing would be to have a separate patch for each individual functionality. Right now we have two things here 1 - ledger resizing and 2 - investment editor fix for widgets that are visible when they should not be. For me it's not that easy to make a review this way. The two came along together. I can do this for these changes in the investment editor, but most of the trouble was in the new code, even though the methods were identical or near-identical. So, for these, there is no patch fixing something, as there was no code there before. Anyway, I'll see if I can do some separation. - Allan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review39691 --- On Aug. 29, 2013, 5:12 p.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Aug. 29, 2013, 5:12 p.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/investactivities.cpp 50f33ed kmymoney/dialogs/investtransactioneditor.h 3e62c2a kmymoney/dialogs/investtransactioneditor.cpp e9f87fb kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.h 04a6303
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote: kmymoney/dialogs/investactivities.cpp, line 204 http://git.reviewboard.kde.org/r/112364/diff/1/?file=185610#file185610line204 Also I don't see a reason why the timeouts passed to QTimer::signleShot vary that much, 5, 100, 150, is there a reason for it? Allan Anderson wrote: I can't give an explanation for why the should differ. Having previously encountered this same problem some why ago, Thomas advised using the timer. As before, I started off using a small value, but found that this didn't work in the new near-identical code area. So, I started to increase the delay. In come cases, I had to use a large delay in order to see that the widget did finally respond. I then started to reduce the value until failure, and then back-off. Having got a particular widget finally responding, after further work I found that the problem was still sometimes there and had to make further adjustments. In many cases, this 'tuning' was revisited. When finally all appeared OK, I then found that during actual window resizing, some widgets would flicker quite badly during their repositioning, depending upon the speed of mouse movement. The only way I could resolve that was by zeroing the widget height instead of hiding it. There must be a simpler way to do this. If this approach is so timing dependent it could be that the solution does not even work on a slower or faster machine/system. - Cristian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review39691 --- On Aug. 29, 2013, 5:12 p.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Aug. 29, 2013, 5:12 p.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/investactivities.cpp 50f33ed kmymoney/dialogs/investtransactioneditor.h 3e62c2a kmymoney/dialogs/investtransactioneditor.cpp e9f87fb kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.h 04a6303 kmymoney/views/kgloballedgerview.cpp 78d98b2 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd kmymoney/widgets/transactionform.cpp 642e98f Diff: http://git.reviewboard.kde.org/r/112364/diff/ Testing --- Extensive editing of sample files, and changing back and forth between different activity types, which tended to show problem areas. atype run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On 2013.09.10 06:41, Cristian Oneț wrote: On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote: Allan Anderson wrote: I can't give an explanation for why the should differ. Having previously encountered this same problem some why ago, Thomas advised using the timer. As before, I started off using a small value, but found that this didn't work in the new near-identical code area. So, I started to increase the delay. In come cases, I had to use a large delay in order to see that the widget did finally respond. I then started to reduce the value until failure, and then back-off. Having got a particular widget finally responding, after further work I found that the problem was still sometimes there and had to make further adjustments. In many cases, this 'tuning' was revisited. When finally all appeared OK, I then found that during actual window resizing, some widgets would flicker quite badly during their repositioning, depending upon the speed of mouse movement. The only way I could resolve that was by zeroing the widget height instead of hiding it. There must be a simpler way to do this. If this approach is so timing dependent it could be that the solution does not even work on a slower or faster machine/system. Would it be worth the effort to make a temporary version where the timer value is a parameter, so it would be easier for more people to test it on different speed machines, without having to recompile just to change that value? If different timer values are needed for different widgets, then it begins to smell to me like the timing is not really the problem but just a workaround. Jack ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
On Tue, 10 Sep 2013 10:01:57 -0400 Jack ostrof...@sbcglobal.net wrote: On 2013.09.10 06:41, Cristian Oneț wrote: On Sept. 10, 2013, 7:20 a.m., Cristian Oneț wrote: Allan Anderson wrote: I can't give an explanation for why the should differ. Having previously encountered this same problem some why ago, Thomas advised using the timer. As before, I started off using a small value, but found that this didn't work in the new near-identical code area. So, I started to increase the delay. In come cases, I had to use a large delay in order to see that the widget did finally respond. I then started to reduce the value until failure, and then back-off. Having got a particular widget finally responding, after further work I found that the problem was still sometimes there and had to make further adjustments. In many cases, this 'tuning' was revisited. When finally all appeared OK, I then found that during actual window resizing, some widgets would flicker quite badly during their repositioning, depending upon the speed of mouse movement. The only way I could resolve that was by zeroing the widget height instead of hiding it. There must be a simpler way to do this. If this approach is so timing dependent it could be that the solution does not even work on a slower or faster machine/system. Would it be worth the effort to make a temporary version where the timer value is a parameter, so it would be easier for more people to test it on different speed machines, without having to recompile just to change that value? If different timer values are needed for different widgets, then it begins to smell to me like the timing is not really the problem but just a workaround. Jack What puzzles me is that in the present version of the investmenregister, this same 'timing' issue has been there for some while. I raised BUG:276322 and REVIEW:6791 two years ago -(If an existing cash dividend transaction is selected, the form shows widgets for Date, Amount, Total and Status, which is what is expected. If that transaction is then opened for editing, additional widgets show for Security, Quantity and Price, which aren't expected for a cash dividend). When I use very similar code in a different class, the issue is much more pronounced. So, as 4.7.0 is no longer a target, I've gone back to the beginning - again - to investigate. Thanks Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review38967 --- Tested this on MacOSX. Worked nicely. No problems found. - Marko Käning On Aug. 29, 2013, 5:12 p.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Aug. 29, 2013, 5:12 p.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/investactivities.cpp 50f33ed kmymoney/dialogs/investtransactioneditor.h 3e62c2a kmymoney/dialogs/investtransactioneditor.cpp e9f87fb kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.h 04a6303 kmymoney/views/kgloballedgerview.cpp 78d98b2 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd kmymoney/widgets/transactionform.cpp 642e98f Diff: http://git.reviewboard.kde.org/r/112364/diff/ Testing --- Extensive editing of sample files, and changing back and forth between different activity types, which tended to show problem areas. atype run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review38966 --- Tested this on MacOSX. Worked nicely. No problems found. - Marko Käning On Aug. 29, 2013, 5:12 p.m., Allan Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- (Updated Aug. 29, 2013, 5:12 p.m.) Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/investactivities.cpp 50f33ed kmymoney/dialogs/investtransactioneditor.h 3e62c2a kmymoney/dialogs/investtransactioneditor.cpp e9f87fb kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.h 04a6303 kmymoney/views/kgloballedgerview.cpp 78d98b2 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd kmymoney/widgets/transactionform.cpp 642e98f Diff: http://git.reviewboard.kde.org/r/112364/diff/ Testing --- Extensive editing of sample files, and changing back and forth between different activity types, which tended to show problem areas. atype run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] Review Request 112364: BUG:312816 - Implement resizing of ledger Number column (and others)., and Interest category and amount disappear when new fee entered in Dividend.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/ --- Review request for KMymoney. Description --- If I choose to use a complex system for check numbers, such that the whole number is not visible, the only way I have available is to stretch the whole window. However, even that doesn't help, as the whole of the increase is grabbed by the Details column. I accept that it is likely that that column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the width of the Balance column, when that column may be likely to have the greatest value? Ditto for the Date. This fix allows modification of column widths, but also resizes the individual columns to more suitable widths. I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that. I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide() methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved the issue, although with some complication. This addresses bugs 312816 and 322768. http://bugs.kde.org/show_bug.cgi?id=312816 http://bugs.kde.org/show_bug.cgi?id=322768 Diffs - kmymoney/dialogs/investactivities.cpp 50f33ed kmymoney/dialogs/investtransactioneditor.h 3e62c2a kmymoney/dialogs/investtransactioneditor.cpp e9f87fb kmymoney/dialogs/transactioneditor.h f07dafb kmymoney/dialogs/transactioneditor.cpp 39049cf kmymoney/views/kgloballedgerview.h 04a6303 kmymoney/views/kgloballedgerview.cpp 78d98b2 kmymoney/widgets/register.h eebe78d kmymoney/widgets/register.cpp 1bdf5bd kmymoney/widgets/transactionform.cpp 642e98f Diff: http://git.reviewboard.kde.org/r/112364/diff/ Testing --- Extensive editing of sample files, and changing back and forth between different activity types, which tended to show problem areas. atype run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
