[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Liz Reachanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #7 from Liz Rea --- Hi Katrin, I put a chopPunctuation on the href attribute, it'll chop of whatever ending punctuation people feel inclined to put there. What do you think? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 --- Comment #6 from Liz Rea--- Created attachment 70241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70241=edit Bug 16804 - semicolons break series search in 490 To test: * have OPACSuppression on * have a record with a 490 field a la: 490 _a something ; _v 123 * go to the opac and search for this record * click the Series link from the detail Without this patch, there will be no results. With this patch, you will get relevant results (possibly the same record back) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Liz Reachanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Liz Reachanged: What|Removed |Added Attachment #67622|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Liz Reachanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 --- Comment #8 from Liz Rea--- well not *any*, specifically these: .:,;/ ' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins , part 7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 --- Comment #1 from Owen Leonard--- Created attachment 70229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70229=edit Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 This patch updates the last of the UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. >From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_210c.tt - unimarc_field_210c_bis.tt - unimarc_field_225a.tt - unimarc_field_225a_bis.tt - unimarc_field_4XX.tt - unimarc_field_700-4.tt - unimarc_leader.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins , part 7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Owen Leonardchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 David Gustafssonchanged: What|Removed |Added Attachment #70202|0 |1 is obsolete|| --- Comment #5 from David Gustafsson --- Created attachment 70230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70230=edit Bug 19893 - Alternative optimized indexing for Elasticsearch Add alternative optimized indexing for Elasticsearch How to test: 1) Time a full elasticsearch re-index by running the rebuild_elastic_search.pl with the -d flag: `koha-shell -c "time rebuild_elastic_search.pl -d"`. 2) Enable ExperimentalElasticSearchIndexing system preference (found under Global System preferences -> Administration -> Search Engine). 3) Time a full re-index again, it should be about twice at fast (for a couple of thousand biblios, with fewer biblios results may be more unpredictable). Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19884] Improve performance of GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 Jonathan Druartchanged: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #13 from Jonathan Druart --- Hi David, It looks like you find a good place where we can improve speed performance, good catch. However it is like we are going backward reintroducing raw SQL queries. I would prefer to avoid such changes. Did you try to make a mix of both approaches, like: generate only 1 query with my $items = Koha::Items->search({ -in => $barcodes }); in place of your my $items = C4::Items::GetItems($itemnumbers); I guess we will need to call $items->unblessed and an interesting addition would be to fill itype according to ->effective_itemtype (so perf will be impacted if not item-level_itypes, like in your patch). Does it make sense? Something else, did you make sure serials will not be impacted? GetItem fetches serialseq and publisheddate. At first glance it looks safe but we need to be sure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19816] output_pref must raised an exception if called with dateformat => rfc3339 and > dateonly => 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Tomás Cohen Arazichanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Tomás Cohen Arazi --- Even if the RFC doesn't target date-only representations, full-date is proposed to be used in OpenAPI, so we should support it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19904] Release team 18.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19904 Jonathan Druartchanged: What|Removed |Added Keywords||rel_18_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19905] Don't append wildcard to query terms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 --- Comment #3 from David Gustafsson--- *librarians, not libraries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19905] Don't append wildcard to query terms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 David Gustafssonchanged: What|Removed |Added Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #14 from Jonathan Druart--- QA: Please make sure bug 19772 is fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t honor IntranetNumbersPreferPhrase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Note to myself: the variable is not sent from all the scripts that include search_indexes.inc. Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 --- Comment #9 from Jonathan Druart--- Created attachment 70228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70228=edit Bug 18477: Use ->store to update the timestamp -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19883] Add a selenium script to hit all the pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19883 --- Comment #4 from Jonathan Druart--- (In reply to Marcel de Rooy from comment #3) > Nice goal on itself. Protecting the database is obviously needed. > Do several scripts need basic parameters at the beginning already (not only > what is filled on a form)? So the script needs to know these; could be a > maintenance headache? I plan to test with GET parameters only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jon Knightchanged: What|Removed |Added Status|Signed Off |Failed QA CC||j.p.kni...@lboro.ac.uk --- Comment #11 from Jon Knight --- (In reply to Jonathan Druart from comment #6) > (In reply to Jonathan Druart from comment #3) > > Please provide tests! > > Reading the code the change is obvious (the same call exists for other > methods), but why do we call $self->SUPER::store instead of $self->store? > > Back to NQA I just had a look at this and it would appear to call the parent's store method because if it calls its own there's a loop: the $self->store() method in Koha/ArticleRequest.pm can call its $self->open() method. I tested it by doing the obvious: replacing $self-SUPER::store with $self->store and sure enough its a memory hogging loop that crashed by dev VM's web server. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #6 from David Gustafsson--- Fixed an instance of hard-coded Elasticsearch mapping document type in update_mappings(). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19905] Don't append wildcard to query terms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 --- Comment #1 from David Gustafsson--- Created attachment 70227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70227=edit Bug 19905 - Don't append wildcard to query terms Appending '*' to query terms makes Elasticsearch skip search analysis. This will for example cause issues with search links in biblio details for values other than a just single term, since the indexed value has been tokenized. How to test: 1) Find a biblio with a field value containing word boundaries and/or punctuation marks. For example: "au:Author, Name". 2) Perform a search using this query, this should not produce any results. 3) Apply patch. 4) Search using the same query again, it should now produce the expected results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19905] Don't append wildcard to query terms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 David Gustafssonchanged: What|Removed |Added Status|NEW |Needs Signoff --- Comment #2 from David Gustafsson --- I just now discovered that the link I was testing this with (Publisher, using the query Provider:, is not quoting the value, but most (perhaps all) of the other links are. So an alternative solution to this issue could be add quotes in the xsl-template. Still we have received serveral complaints from libraries failing to perform searches using unquoted field values, and though we could tell everyone to always use quotes, it feels like Koha would provide a better user experience if wildcard queries where not the default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druartchanged: What|Removed |Added Status|Failed QA |Signed Off --- Comment #10 from Jonathan Druart --- There is a big lack of test and add a test here will take me too much time. The fix sounds trivial and the ->store method is obviously missing. I am willing to push these patches as it, if QA is ok with that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druartchanged: What|Removed |Added Attachment #70228|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druartchanged: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #13 from Jonathan Druart --- Indeed Jon, so we need tests :) Thanks for the catch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19905] Don't append wildcard to query terms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 --- Comment #4 from David Gustafsson--- Looking through the tests I now saw there is an "QueryAutoTruncate" option that was enabled in my instance. So turning this off will most likely fix this issue for us, and I now realize it cannot just be removed (without also removing this option), making this fix an incorrect one. I have not tested it out myself, but I think there may be other issues with the current autotruncation, should not the whole phrase be searched (the "raw" field for example) or else you will get strange results for wildcard queries containing multiple tokens (since it is the tokanized values that will be matched against)? But that is another possible issue, and should perhaps not be addressed here. But for now I'm disabling the option, and this issues should perhaps be closed. There is still an issue with the Provider-link not being quoted (and might not work if "QueryAutoTruncate" is enabled), but better to open another issue for that one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 --- Comment #12 from Jonathan Druart--- Created attachment 70231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70231=edit Bug 18477: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19903] Add Koha::Patron::Restrictions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19903 Tomás Cohen Arazichanged: What|Removed |Added CC||kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19903] New: Add Koha::Patron::Restrictions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19903 Bug ID: 19903 Summary: Add Koha::Patron::Restrictions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org We need a Koha::Object-based class to replace (the so-called) Koha::Patron::Debarments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19303] Move C4::Members::GetFirstValidEmailAddress to Koha::Patron-> first_valid_email_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for transfer-slip.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t honor IntranetNumbersPreferPhrase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 --- Comment #5 from Katrin Fischer--- It doesn't effect the OPAC from what I could tell when testing. It just switches the indexes in the new search options pull down on the simple search according to the pref from ,wrdl to ,phr for callnumber, copying the existing behaviour for advanced search. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19905] Don't append wildcard to query terms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 David Gustafssonchanged: What|Removed |Added Assignee|koha-b...@lists.koha-commun |glask...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19905] New: Don't append wildcard to query terms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 Bug ID: 19905 Summary: Don't append wildcard to query terms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: glask...@gmail.com Discovered this issue while testing the search links in biblio-details. The links are hard-coded in the template with queries not using quotes for field values, which makes QueryBuilder::_truncate_terms append '*' to the search term. Since wild card searches skips the analyzer-phase, most of our links does not work (since a lot of field values has word boundaries and/or punctuation marks, for example the query "Provider:Taschen," will be converted to "Provider:Taschen,*" and since the indexed value for Provider is "Taschen" this search will produce no results. In my opinion (if I'm not misunderstanding the purpose of this code) appending '*' to words should be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t honor IntranetNumbersPreferPhrase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- I do not recreate the bug, and I do not understand the fix. Could you detail please? (In reply to Victor Grousset/tuxayo from comment #0) > It's very likely to also affect the OPAC Does it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9302] Add ability to merge patron records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Ed Vealchanged: What|Removed |Added CC||ev...@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #9 from Nick Clemens--- Created attachment 70226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70226=edit Bug 17374 - Add cardnumber to list of searchable patron fields To test: 1 - Apply patch 2 - Perform a 'cardnumber' search for patrons 3 - Verify results as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemenschanged: What|Removed |Added Status|Failed QA |Signed Off --- Comment #10 from Nick Clemens --- (In reply to Katrin Fischer from comment #8) > 1) If you leave the preference empty, the default will show. The default > doesn't include cardnumber, I think it might be good to include it on top. > > 2) When using the preference, the default will still show, so there is no > way to remove fields. Wouldn't it make more sense to use the non-empty pref > instead of the default? For example a lot of libraries don't use the sort > fields and could remove them from the list this way. > > The current behaviour seems especially confusing since the preference is not > empty by default but includes a list of values. Deleting one of them will > have no effect as long as the value is in the list of default. > > Failing for 2). 1 - Attached patch (this may be better as its own report) 2 - I think this is beyond scope here. The preference is intended to simply control the fields searched when using a 'standard' search. Adding these the dropdown is a convenience feature. I think removing fields is better done by javascript for customization. The list of fields here and the list in the pref didn't have parity before so introducing now would be a bigger change. Moving back to QA queue for second opinion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18183] jQuery append error related to script tags in cloneItemBlock
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19904] New: Release team 18.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19904 Bug ID: 19904 Summary: Release team 18.05 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Blocks: 18303 Updating about team page for 18.05 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 [Bug 18303] Release team omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18303] Release team omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 Jonathan Druartchanged: What|Removed |Added Depends on||19904 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19904 [Bug 19904] Release team 18.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18183] jQuery append error related to script tags in cloneItemBlock
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15378] Remove 'lost' items from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15378 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19906] Move template JavaScript to the footer: NORMARC editor plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19906 Owen Leonardchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19906] Move template JavaScript to the footer: NORMARC editor plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19906 --- Comment #1 from Owen Leonard--- Created attachment 70234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70234=edit Bug 19906: Move template JavaScript to the footer: NORMARC editor plugins This patch updates NORMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a NORMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. >From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - normarc_field_007.tt - normarc_field_008.tt - normarc_leader.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19303] Move C4::Members::GetFirstValidEmailAddress to Koha::Patron-> first_valid_email_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 Josef Moravecchanged: What|Removed |Added Patch complexity|--- |Small patch CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19303] Move C4::Members::GetFirstValidEmailAddress to Koha::Patron-> first_valid_email_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 Josef Moravecchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19303] Move C4::Members::GetFirstValidEmailAddress to Koha::Patron-> first_valid_email_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 Josef Moravecchanged: What|Removed |Added Attachment #68107|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 70221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70221=edit Bug 19303: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address This new Koha::Patron->first_valid_email_address already exists, it should be called directly Test plan: - With a logged in user who have an email address defined, send a basket. The email should be marked sent by this email address - On the "Holds awaiting pickup", the email address must be displayed as well Signed-off-by: David Bourgault Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Josef Moravecchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 --- Comment #6 from Josef Moravec--- Created attachment 70223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70223=edit Bug 19304: (QA follow-up) Fix number of tests in Members.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Josef Moravecchanged: What|Removed |Added Attachment #68111|0 |1 is obsolete|| --- Comment #5 from Josef Moravec --- Created attachment 70222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70222=edit Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address This subroutine is quite trivial and can be replaced easily with a new method of Koha::Patron Test plan: Overdue notices and shelf sharing must be send the to an email address, according to the value of the pref AutoEmailPrimaryAddress Signed-off-by: David Bourgault Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Josef Moravecchanged: What|Removed |Added CC||josef.mora...@gmail.com Patch complexity|--- |Small patch QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Josef Moravecchanged: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||josef.mora...@gmail.com --- Comment #142 from Josef Moravec --- Hi, these patchset doesn't apply. So just few comments from quick reading of the code: You don't have to change signature of GetHiddenItemnumbers, you can ask for patron category here... And you can than leave the $search_context as is. Also the "opac" param in GetMarcBiblio and EmbedItemsInMarcBiblio is not needed, you can use C4::Context->interface when you need to know the actual interface And some squashing would be nice here ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15985] Include transacting library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Josef Moravecchanged: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com Status|Signed Off |Patch doesn't apply --- Comment #5 from Josef Moravec --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #16 from Josef Moravec--- Comment on attachment 67802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67802 Bug 12365 - Notes for rules Review of attachment 67802: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12365=67802) - ::: Koha/Schema/Result/Issuingrule.pm @@ +300,5 @@ > extra => { list => ["no", "yes", "bib_only", "item_only"] }, > is_nullable => 0, >}, > + "note", > + { data_type => "varchar", is_nullable => 1, size => 100 }, The Schema files changes should be generated by update_dbix_class_files.pl script and should be in separate commit. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ +436,5 @@ >Item level holds >Article requests >Rental discount (%) > + Note > + The colspan parameter is not needed here and should be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Josef Moravecchanged: What|Removed |Added CC||josef.mora...@gmail.com Status|Signed Off |Failed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18183] jQuery append error related to script tags in cloneItemBlock
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Josef Moravecchanged: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18183] jQuery append error related to script tags in cloneItemBlock
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Josef Moravecchanged: What|Removed |Added Attachment #67821|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 70224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70224=edit Bug 18183: jQuery append error related to script tags in cloneItemBlock See the detailed explanation of the error on Bugzilla. As a workaround, we move the append of clone to outeritemblock before the append of data (long string with item fields and script tags) to clone. This patch also moves two vars inside the success function, since they are not used outside of it. Test plan: [1] Set AcqCreateItem to receiving. [2] Receive an order. Verify that adding, updating or deleting an item block still works as expected. Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18183] jQuery append error related to script tags in cloneItemBlock
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Josef Moravecchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15378] Remove 'lost' items from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15378 Josef Moravecchanged: What|Removed |Added Patch complexity|--- |Trivial patch CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15378] Remove 'lost' items from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15378 Josef Moravecchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15378] Remove 'lost' items from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15378 Josef Moravecchanged: What|Removed |Added Attachment #68071|0 |1 is obsolete|| --- Comment #7 from Josef Moravec --- Created attachment 70225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70225=edit Bug 15378: Allow removal of lost items from course reserves It seems that this restriction is not necessary, it should be possible to remove lost items from course reserves. Test plan: Create a course and add reserve with a lost item => Without this patch the "Remove" button is disabled and the item cannot be removed from the course => With this patch applied the button is enable and the item can be removed Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19886] Two Factor Authentication: Yubikey
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19886 Jon Knightchanged: What|Removed |Added CC||j.p.kni...@lboro.ac.uk --- Comment #1 from Jon Knight --- Is this something that needs to be built into Koha, or is it better to make use of existing third party systems such as PrivacyIDEA (https://www.privacyidea.org/) that can be used in conjuction with normal SSO mechanisms? For example we (Loughborough University) have tested Yubikeys with PrivacyIDEA and simpleSAMLphp IdP and it works, and we already know that Koha can use the SAML2.0 authentication assertions from the IdP (as that's what we're doing in production with PTFS-E). PrivacyIDEA also can also support Google Authentication as suggested in Bug 19887. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Nick Clemenschanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #187 from Nick Clemens --- Tried testing, seems to be some issues: 1 - Template code in subscription-add.js file breaks serial biblio search: 620 //[% IF Koha.Preference('Mana') == 1 %] 2 - When I attempt to save a serial: Variable "$loggedinuser" is not available at /home/vagrant/kohaclone/serials/subscription-add.pl line 371. Variable "$template" is not available at /home/vagrant/kohaclone/serials/subscription-add.pl line 372. Variable "$loggedinuser" is not available at /home/vagrant/kohaclone/serials/subscription-add.pl line 371. Variable "$template" is not available at /home/vagrant/kohaclone/serials/subscription-add.pl line 372. Can't use string ("koha_login_context") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/Koha/Subscription/Numberpatterns.pm line 63. 3 - Blank modal when attempting to share report with no notes 4 - Internal server error when trying to share a new report with notes: Use of uninitialized value $loggedinuser in string ne at /home/vagrant/kohaclone/Koha/SharedContent.pm line 106. Can't call method "first_valid_email_address" on an undefined value at /home/vagrant/kohaclone/Koha/SharedContent.pm line 108. I stopped testing at this point -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Josef Moravecchanged: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com Status|Signed Off |Failed QA --- Comment #4 from Josef Moravec --- Hi Owen, looks good, but few thinks: So, if I want to update child to adult, and have more patron categories for adults, than I should see the form for choosing one of them, but I get blank page... Also the javascript function confirm_updatechild is defined twice: in members-menu.js and update-child.tt. Few buttons in patron toolbar on checkouts screen does not work - circulation.tt is not part of this patch and so does not include members-menu.js. I think you will fix this bug 19728, true? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Josef Moravecchanged: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com Status|Signed Off |Failed QA --- Comment #6 from Josef Moravec --- The datepicker in import patrons tool is shown only by dateofbirth field. Should be also on dateexpiry and dateenrolled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #144 from Liz Rea--- a+ preserving attribution. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsettchanged: What|Removed |Added Status|Patch doesn't apply |ASSIGNED --- Comment #143 from M. Tompsett --- (In reply to Josef Moravec from comment #142) > these patchset doesn't apply. Thanks for looking and noticing this. > So just few comments from quick reading of the > code: > > You don't have to change signature of GetHiddenItemnumbers, you can ask for > patron category here... And you can than leave the $search_context as is. I can't recall the reason off the top of my head, and even after rebasing this locally -- I have yet to test and put it back up. But I've got a feeling it had something to so with the nesting of some search functions which were not easily determined to be opac or intranet otherwise. > Also the "opac" param in GetMarcBiblio and EmbedItemsInMarcBiblio is not > needed, you can use C4::Context->interface when you need to know the > actual interface. It is better to pass it in my opinion to refactor the parameters list, so that test functions don't require special mocking to get the C4::Context function to return the correct value in different cases (like shell script utilities). And this makes maintenance for other changes in the future easier for others, and brings the code up to preferred coding style (https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_should_be_used_as_arguments) > And some squashing would be nice here ;) I was tweaking, testing, fixing, repeating multiple times. Also, smaller patches are easier to test individually. I will squash as much as possible. I do, however, not want to lose the fact that Aleisha Amohia put in a massive effort which helped me see how to solve my C4::Search mess problem that I had hit while working on originally in bug 10589. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19890] authorised value branches is not visible from dropdown in Admin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19890 Hugh Rundlechanged: What|Removed |Added CC||k...@hughr.me --- Comment #2 from Hugh Rundle --- Yep that would be perfect. That way it's clear they already exist, and also that authorised_values is not the place to change them. Something like "[category name] is listed here for information only. To change or add values for [category name] use [appropriate place]. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image Failed - " Cannot process file as an image"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898 --- Comment #3 from Craig--- (In reply to Jonathan Druart from comment #2) > The relevant code of the warning is: > > 1084 my $branches = { map { $_->branchcode => > $_->unblessed } Koha::Libraries->search }; > 1085 if ( $type ne 'opac' and > C4::Context->boolean_preference('AutoLocation') ) { > 1086 > 1087 # we have to check they are coming from the > right ip range > 1088 my $domain = > $branches->{$branchcode}->{'branchip'}; > 1089 $domain =~ s|\.\*||g; > 1090 if ( $ip !~ /^$domain/ ) { > 1091 $loggedin = 0; > 1092 $cookie = $query->cookie( > 1093 -name => 'CGISESSID', > 1094 -value=> '', > 1095 -HttpOnly => 1 > 1096 ); > 1097 $info{'wrongip'} = 1; > 1098 } > 1099 } > > > It says that you have AutoLocation turned on and the "branchip" field of the > branches table does not match your IP. It also says that you are using a non > superlibrarian account. > > Could you confirm this? > If the IP does not match, it is expected that you are rejected, but in that > case it should be the same behaviour with other scripts. Hi Jonathan, Thanks for this. I am indeed using a superlibrarian account, so I'm surprised that it is reporting otherwise. I have only one patron in the system, me, and it was initially setup as superlibrarian staff. You are correct about Autolocation, it was turned on. But I have since disabled it. The IP address field in the bramches table is blank. Unfortunately, after turning off Autolocation, restarting Koha, and restarting memcache, the error still persists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837 --- Comment #3 from Nick Clemens--- Created attachment 70240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70240=edit Bug 19837 - Add error feedback for duplicatred or unfound cardnumbers To test: 1 - Enter some patrons on a list 2 - 'Enter multiple cardnumbers' 3 - Make sure to add some that are already in list, some that don't exist, and some new patrons 4 - Verify results are as expected with warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837 Nick Clemenschanged: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- I added some error feedback, it could certainly be made prettier, take a look please Owen? Ideally we would be able to add by borrowernumber as well, but I think that is for another bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hallchanged: What|Removed |Added Attachment #68934|0 |1 is obsolete|| --- Comment #33 from Kyle M Hall --- Created attachment 70232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70232=edit Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off Test Plan: 1) Apply patch 2) Turn off AllowOnShelfHolds 3) Create a bib with one item, mark the item as 'on order' 4) Attempt to place a hold on the item, you should now be able to do so -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hallchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18593] Suggestions aren' t updated when one biblio is merged with another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 --- Comment #5 from Jonathan Druart--- Created attachment 70233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70233=edit Bug 18593: Move suggestions when bibliographic records are merged When bibliographic records are merged, the suggestions.biblionumber field should be replaced with the new record. Ideally we should have kept an history of the merges, to know what was the original record. Now we cannot fix the broken links. Test plan: 1) Create a suggestion in OPAC 2) Accept the suggestion in staff 3) Add order from this suggestion 4) Go to cataloguing search and search for the record and another 5) Merge the suggestion record with the catalog record - catalog record wins (should be the more common case when a patron suggests something that already exists) 6) Verify that after merging, the new title displays in the acquisition record 7) Verify that the suggestion info no longer displays in basket >From Katrin's test plan: 8) Verify that the new title doesn't display in suggestions. The old title will still show as suggested (not updated) => This is the title from suggestions.title, I think it makes sense to show this one. Maybe we should open a new bug report to improve the display of the suggestion, and link to the bibliographic record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18593] Suggestions aren' t updated when one biblio is merged with another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 Jonathan Druartchanged: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18593] Suggestions aren' t updated when one biblio is merged with another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 Jonathan Druartchanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19906] New: Move template JavaScript to the footer: NORMARC editor plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19906 Bug ID: 19906 Summary: Move template JavaScript to the footer: NORMARC editor plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 17858 NORMARC plugin templates already have JavaScript at the bottom of the template instead of the top, but they should still be modified to be consistent with other templates which have been updated as part of Bug 17858. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Owen Leonardchanged: What|Removed |Added Depends on||19906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19906 [Bug 19906] Move template JavaScript to the footer: NORMARC editor plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image Failed - " Cannot process file as an image"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- The relevant code of the warning is: 1084 my $branches = { map { $_->branchcode => $_->unblessed } Koha::Libraries->search }; 1085 if ( $type ne 'opac' and C4::Context->boolean_preference('AutoLocation') ) { 1086 1087 # we have to check they are coming from the right ip range 1088 my $domain = $branches->{$branchcode}->{'branchip'}; 1089 $domain =~ s|\.\*||g; 1090 if ( $ip !~ /^$domain/ ) { 1091 $loggedin = 0; 1092 $cookie = $query->cookie( 1093 -name => 'CGISESSID', 1094 -value=> '', 1095 -HttpOnly => 1 1096 ); 1097 $info{'wrongip'} = 1; 1098 } 1099 } It says that you have AutoLocation turned on and the "branchip" field of the branches table does not match your IP. It also says that you are using a non superlibrarian account. Could you confirm this? If the IP does not match, it is expected that you are rejected, but in that case it should be the same behaviour with other scripts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #10 from Josef Moravec--- Created attachment 70236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70236=edit Bug 11046: Add the form YYY-? for uncertain years This form occurred in Dutch ISBD rules. The question mark should follow the hyphen(s). Test plan: Run t/db_dependent/Biblio/TransformMarcToKoha.t Signed-off-by: Marcel de Rooy TransformMarcToKoha tests passed. Also this patch passed QA test tool Signed-off-by: Alex Buckley Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravecchanged: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravecchanged: What|Removed |Added Attachment #68349|0 |1 is obsolete|| Attachment #68350|0 |1 is obsolete|| --- Comment #9 from Josef Moravec --- Created attachment 70235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70235=edit Bug 11046: Better handling of uncertain years for publicationyear This patch makes it possible that uncertain year like 18.. or 197x are converted to 1800 or 1970 in Koha field copyrightdate (MARC21) or publicationyear (UNIMARC). (The corresponding MARC record will not be changed obviously.) This change will allow for better results when sorting search results or list contents on copyrightdate. Currently, things like 18.. will sort together with zero. Note: The regex now allows four possible uncertain year markers: x or X, question mark or dot. Test plan: [1] Run t/db_dependent/Biblio/TransformMarcToKoha.t [2] Edit a biblio record. Save 18.. into 260c. Check biblio.copyrightdate. Signed-off-by: Marcel de Rooy Followed test plan, patch worked as described, it also passed QA test tool Signed-off-by: Alex Buckley Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19801] Internal note added to the detail's user page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 --- Comment #5 from Liz Rea--- Created attachment 70239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70239=edit Bug 19801 - Fixes for QA - Fixes indentation - changes messages to patron_messages (even though it's not like that on the circulation page.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16782] Display report URL in staff client report interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #18 from Liz Rea--- Thankfully this still applies. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13376] Include a user-editable area/ page for terms and conditions of use in the opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Liz Reachanged: What|Removed |Added Keywords||Academy --- Comment #5 from Liz Rea --- This bug got derailed, I still think the original feature proposal is a good one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravecchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Josef Moravecchanged: What|Removed |Added Attachment #68509|0 |1 is obsolete|| Attachment #68510|0 |1 is obsolete|| --- Comment #8 from Josef Moravec --- Created attachment 70237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70237=edit Bug 18417 - Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) To test: 1 - Apply patch 2 - Open advanced cataloging editor 3 - Try using Alt+P and Alt+C and note symbols are added 4 - Save record and ensure symbols are saved Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 --- Comment #9 from Josef Moravec--- Created attachment 70238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70238=edit Bug 18417: (follow-up) Document new shortcuts in dropdown Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Josef Moravecchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Josef Moravecchanged: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19801] Internal note added to the detail's user page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Liz Reachanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19890] authorised value branches is not visible from dropdown in Admin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19890 Jonathan Druartchanged: What|Removed |Added Version|16.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19890] authorised value branches is not visible from dropdown in Admin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19890 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- There are 3 authorised value "special categories": branches, itemtypes, cn_source. They are used to link a MARC subfield to a branchcode, itemtype or classification source. They are not proper authorised values (in the sense of the authorised_values table), but are needed to restrict the input. We could add them to the category dropdown list and remove the ability to add value to them (display a friendly message instead to explain the situation). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/