Re: [Libreoffice-commits] core.git: sw/qa
On 07/10/2015 01:09 PM, Varun wrote: commit 6a0efa9873b1a5cae4ae0719a7ae1eee97838168 Author: Varun varun.dh...@studentpartner.com Date: Thu Jul 9 23:33:24 2015 +0530 Added Test for tdf#80663 table row/column delete undo crash Change-Id: Ica62926486831f126cce54d651e230cee3360074 Reviewed-on: https://gerrit.libreoffice.org/16901 Reviewed-by: Michael Stahl mst...@redhat.com Tested-by: Michael Stahl mst...@redhat.com Looks like that new test unearthed an undo-related bug, as my asan+ubsan build now reproducible fails during CppunitTest_sw_uiwriter with sw/source/core/undo/untbl.cxx:997:25: runtime error: downcast of address 0x2b35a17ec0a8 which does not point to an object of type 'SwTableBoxFormat' 0x2b35a17ec0a8: note: object is of type 'SwTableFormat' 00 00 00 00 90 d9 e5 58 35 2b 00 00 a0 d2 7e a1 35 2b 00 00 f8 b1 7e a1 35 2b 00 00 00 60 6e 97 ^~~ vptr for 'SwTableFormat' #0 0x2b3552aac15e in _SaveTable::CreateNew(SwTable, bool, bool) sw/source/core/undo/untbl.cxx:997:25 #1 0x2b3552af07cd in SwUndoTableNdsChg::UndoImpl(sw::UndoRedoContext) sw/source/core/undo/untbl.cxx:1801:5 #2 0x2b35528ca7b7 in SwUndo::UndoWithContext(SfxUndoContext) sw/source/core/undo/undobj.cxx:214:5 #3 0x2b351a54712b in SfxListUndoAction::UndoWithContext(SfxUndoContext) svl/source/undo/undo.cxx:1352:9 #4 0x2b351a52c2d6 in SfxUndoManager::ImplUndo(SfxUndoContext*) svl/source/undo/undo.cxx:810:13 #5 0x2b351a52d805 in SfxUndoManager::UndoWithContext(SfxUndoContext) svl/source/undo/undo.cxx:778:12 #6 0x2b355277e92d in sw::UndoManager::impl_DoUndoRedo(sw::UndoManager::UndoOrRedo_t) sw/source/core/undo/docundo.cxx:483:16 #7 0x2b355277fdb3 in sw::UndoManager::Undo() sw/source/core/undo/docundo.cxx:516:16 #8 0x2b352b2e85e4 in SwUiWriterTest::testTdf80663() sw/qa/extras/uiwriter/uiwriter.cxx:1283:5 #9 0x2b352b46599f in CppUnit::TestCallerSwUiWriterTest::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166:6 #10 0x2b34eb488a7d in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 #11 0x2b35037c47a6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const, CppUnit::ProtectorContext const) test/source/vclbootstrapprotector.cxx:57:14 #12 0x2b34eb443fc7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 #13 0x2b34fab4aa96 in (anonymous namespace)::Prot::protect(CppUnit::Functor const, CppUnit::ProtectorContext const) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:88:12 #14 0x2b34eb443fc7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 #15 0x2b34f6e1cda4 in (anonymous namespace)::Prot::protect(CppUnit::Functor const, CppUnit::ProtectorContext const) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 #16 0x2b34eb443fc7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 #17 0x2b34eb3cb93c in CppUnit::DefaultProtector::protect(CppUnit::Functor const, CppUnit::ProtectorContext const) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 #18 0x2b34eb443fc7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 #19 0x2b34eb43ff71 in CppUnit::ProtectorChain::protect(CppUnit::Functor const, CppUnit::ProtectorContext const) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:77:18 #20 0x2b34eb50a1b5 in CppUnit::TestResult::protect(CppUnit::Functor const, CppUnit::Test*, std::string const) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:181:10 #21 0x2b34eb4855d6 in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:5 #22 0x2b34eb48c013 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5 #23 0x2b34eb48af7d in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 #24 0x2b34eb48c013 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5 #25 0x2b34eb48af7d in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 #26 0x2b34eb548cf6 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:5 #27 0x2b34eb508039 in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:148:3 #28
[Libreoffice-commits] core.git: 2 commits - basegfx/source vcl/source
basegfx/source/range/b2drangeclipper.cxx |1 -
vcl/source/edit/textundo.cxx |1 -
vcl/source/window/event.cxx |1 -
3 files changed, 3 deletions(-)
New commits:
commit d537a439fe0bec348d6cf0e14dadee773b38bcd4
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Jul 13 18:20:48 2015 +0200
Revert Avoid loplugin:staticmethods in non-debug build
This reverts commit 97df2dee8ea4f33f4efb7467cfeec2d8954c006c, obsoleted by
cbce40e965acef51822b31d73da5fbc271fbcad0 Make content of OSL_ASSERT,
DBG_ASSERT, etc. visiblie in non-debug builds.
diff --git a/vcl/source/edit/textundo.cxx b/vcl/source/edit/textundo.cxx
index e28387b..1ba423a 100644
--- a/vcl/source/edit/textundo.cxx
+++ b/vcl/source/edit/textundo.cxx
@@ -108,7 +108,6 @@ bool TextUndoManager::Redo()
void TextUndoManager::UndoRedoStart()
{
DBG_ASSERT( GetView(), Undo/Redo: Active View? );
-(void) this; // avoid loplugin:staticmethods
}
void TextUndoManager::UndoRedoEnd()
diff --git a/vcl/source/window/event.cxx b/vcl/source/window/event.cxx
index ea819cd..ec6a9b6 100644
--- a/vcl/source/window/event.cxx
+++ b/vcl/source/window/event.cxx
@@ -295,7 +295,6 @@ void Window::RemoveUserEvent( ImplSVEvent * nUserEvent )
Window::RemoveUserEvent(): Event doesn't send to this window
or is already removed );
DBG_ASSERT( nUserEvent-mbCall,
Window::RemoveUserEvent(): Event is already removed );
-(void) this; // avoid loplugin:staticmethods
if ( nUserEvent-mpWindow )
{
commit 1a945712f6d5ce0cb31c6eff5892d6d33475976b
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Jul 13 18:19:48 2015 +0200
Revert Avoid loplugin:staticmethods in non-debug build
This reverts commit d0ba487bae3a0f6d1fcb9af13397c85e70ad8e1b, obsoleted by
cbce40e965acef51822b31d73da5fbc271fbcad0 Make content of OSL_ASSERT,
DBG_ASSERT, etc. visiblie in non-debug builds.
diff --git a/basegfx/source/range/b2drangeclipper.cxx
b/basegfx/source/range/b2drangeclipper.cxx
index 0f58395..d39c33c 100644
--- a/basegfx/source/range/b2drangeclipper.cxx
+++ b/basegfx/source/range/b2drangeclipper.cxx
@@ -370,7 +370,6 @@ namespace basegfx
OSL_ENSURE( isSweepLineEnteringRect ||
mpLeadingRightEdge == rActiveEdge,
ImplPolygon::intersect(): sweep initial own edge
hit: wrong leading edge );
-(void) this; // avoid loplugin:staticmethods
}
void handleFinalOwnRightEdge(ActiveEdge rActiveEdge)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92720] New: EDITING: Report-Builder - Report fails to open with Charts in a Report
https://bugs.documentfoundation.org/show_bug.cgi?id=92720 Bug ID: 92720 Summary: EDITING: Report-Builder - Report fails to open with Charts in a Report Product: LibreOffice Version: 5.0.0.3 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@familiegrosskopf.de Created attachment 117223 -- https://bugs.documentfoundation.org/attachment.cgi?id=117223action=edit Dialog with failure-message, when opening report with chart Download https://bugs.documentfoundation.org/attachment.cgi?id=117222 . Try to run the report report_gender_chart. Fails with LO 5.0.0.3 rc with the attached message in a dialog. report_gender_chart_new fails the same way. Both reports are reports with a chart. Reports with charts could be opened with all versions 4.*, fails before with the message failed to parse the report. Have tested this with OpenSUSE 13.2 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[GSoC] Reuse Mozilla's rolling update mechanism for LibreOffice - Weekly Report 7
This is the week 7 progress report of the GSoC bug Reuse Mozilla's rolling update mechanism for LibreOffice. Last week: - successfully built Mozilla's mar creation executable on a Windows LibreOffice build - came close to successfully building Mozilla's updater executable on a Windows LibreOffice build Goals for this week: - successfully build Mozilla's updater executable on a Windows LibreOffice build Nathan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92719] EDITING: Charts in Report-Builder show Date instead of Number, if Number is Decimal
https://bugs.documentfoundation.org/show_bug.cgi?id=92719 rob...@familiegrosskopf.de changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92720] EDITING: Report-Builder - Report fails to open with Charts in a Report
https://bugs.documentfoundation.org/show_bug.cgi?id=92720 rob...@familiegrosskopf.de changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||719 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92719] EDITING: Charts in Report-Builder show Date instead of Number, if Number is Decimal
https://bugs.documentfoundation.org/show_bug.cgi?id=92719 rob...@familiegrosskopf.de changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||720 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92720] EDITING: Report-Builder - Report fails to open with Charts in a Report
https://bugs.documentfoundation.org/show_bug.cgi?id=92720 rob...@familiegrosskopf.de changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83535] Base’s title bar displays the wrong language when certain language packs are installed
https://bugs.documentfoundation.org/show_bug.cgi?id=83535 Andras Timar tima...@gmail.com changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #19 from Andras Timar tima...@gmail.com --- *** Bug 92507 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92507] Headers of windows in Base sometimes in wrong language
https://bugs.documentfoundation.org/show_bug.cgi?id=92507 Andras Timar tima...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Andras Timar tima...@gmail.com --- *** This bug has been marked as a duplicate of bug 83535 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: configure.ac
configure.ac |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit f3df77accae2941ba9c6a5e48b84d661f7a87863
Author: Tor Lillqvist t...@collabora.com
Date: Tue Jul 14 11:01:48 2015 +0300
With --enable-gtk3 we need GLib = 2.38
The G_ADD_PRIVATE used in libreofficekit/source/gtk/lokdocview.cxx is from
2.38.
Change-Id: I2058932f8252d2715f970f020160f4f960987125
diff --git a/configure.ac b/configure.ac
index 7c362aa6..87d7990 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9972,11 +9972,11 @@ if test x$enable_gtk3 = xyes; then
AC_MSG_ERROR([System cairo required for gtk3 support, do not combine
--enable-gtk3 with --without-system-cairo])
fi
: ${with_system_cairo:=yes}
-PKG_CHECK_MODULES(GTK3, gtk+-3.0 = 3.2 gtk+-unix-print-3.0
gmodule-no-export-2.0 cairo, ENABLE_GTK3=TRUE, ENABLE_GTK3=)
+PKG_CHECK_MODULES(GTK3, gtk+-3.0 = 3.2 gtk+-unix-print-3.0
gmodule-no-export-2.0 glib-2.0 = 2.38 cairo, ENABLE_GTK3=TRUE,
ENABLE_GTK3=)
if test x$ENABLE_GTK3 = xTRUE; then
R=gtk3
else
-AC_MSG_ERROR([gtk3 libraries of the correct versions, not found])
+AC_MSG_ERROR([gtk3 or dependent libraries of the correct versions, not
found])
fi
GTK3_CFLAGS=$(printf '%s' $GTK3_CFLAGS | sed -e s/-I/${ISYSTEM?}/g)
fi
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92719] New: EDITING: Charts in Report-Builder show Date instead of Number, if Number is Decimal
https://bugs.documentfoundation.org/show_bug.cgi?id=92719 Bug ID: 92719 Summary: EDITING: Charts in Report-Builder show Date instead of Number, if Number is Decimal Product: LibreOffice Version: 4.3.0.4 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@familiegrosskopf.de Created attachment 117222 -- https://bugs.documentfoundation.org/attachment.cgi?id=117222action=edit Open the report report_gender_chart for editing and execute it. Open the attached database. Execute the report report_gender_chart. Since LO 4.3 it shows DATE-formatted values at x-axis. Now open the report for editing. Preview shows the right values for x-axis. Close the report and execute the report report_gender_chart_new. Shows the right values in x-axis of the chart. Difference between the queries for the charts is: report_gender_chart has numbers in the x-axis, which seem to be sometimes decimal numbers with one decimalpoint like '20.0' or '50.0'. This decimalpoint isn't shown in query, but appers when changing the numbers to text-format. report_gender_chart_new has text-formatted values for the x-axis. Could be this buggy behavior could reproduced only with language-settings, where date is formatted like 14.07.2015. There is another bug with LO 5.0.0.3 - both reports for charts could not be opened. Will report this also. So please test with LO 4.4.4.3. I tested with this and older versions. Worked right with LO 4.1.* and LO 4.2.3.1 (last installed 4.2-version here). Failed first with LO 4.3.0.4. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-qa] Reminder: QA Meeting on Wednesday
Hi all, Quick reminder that we'll be having our QA Meeting this Wednesday at the *earlier* time we tried out at our last meeting: https://wiki.documentfoundation.org/QA/Meetings/2015/July_15 Here's the direct link to the handy-dandy when-is-it-in-my-local-time-zone? tool :- https://www.timeanddate.com/worldclock/fixedtime.html?hour=11min=30sec=0day=15month=07year=2015 Hope to see you there! Best, --R -- Robinson Tryon QA Engineer - The Document Foundation LibreOffice Community Outreach Herald qu...@libreoffice.org 802-379-9482 | IRC: colonelqubit on Freenode ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/unusedmethods.cxx | 17 +++--
compilerplugins/clang/unusedmethods.py |3 +--
2 files changed, 8 insertions(+), 12 deletions(-)
New commits:
commit a04354ecb34216d7fb9868f701fd3ee2b70883c8
Author: Noel Grandin n...@peralex.com
Date: Mon Jul 13 13:31:13 2015 +0200
improve the unusedmethods plugin
to find stuff called from 2 levels+ inside template methods
Change-Id: I4ba308a992e64a091e5364b8aa89e44d6772dcb0
diff --git a/compilerplugins/clang/unusedmethods.cxx
b/compilerplugins/clang/unusedmethods.cxx
index 655dfe2..162bff0 100644
--- a/compilerplugins/clang/unusedmethods.cxx
+++ b/compilerplugins/clang/unusedmethods.cxx
@@ -33,7 +33,6 @@ to auto-remove the method declarations
Note that the actual process may involve a fair amount of undoing, hand
editing, and general messing around
to get it to work :-)
-TODO ignore calls from a method to itself, so we can eliminate unused
recursive methods
TODO deal with calls to superclass/member constructors from other
constructors, so
we can find unused constructors
TODO need to handle places where the code takes the address of a method, that
needs to count
@@ -139,7 +138,7 @@ static bool isStandardStuff(const std::string s)
}
// prevent recursive templates from blowing up the stack
-static std::setstd::string traversedTemplateFunctionSet;
+static std::setstd::string traversedFunctionSet;
bool UnusedMethods::VisitCallExpr(CallExpr* expr)
{
@@ -150,14 +149,12 @@ bool UnusedMethods::VisitCallExpr(CallExpr* expr)
if (calleeFunctionDecl == nullptr) {
return true;
}
-// if we see a call to a templated function, it effectively creates new
code,
-// so we need to examine it's interior to see if it, in turn, calls
anything else
-if (calleeFunctionDecl-getTemplatedKind() !=
FunctionDecl::TemplatedKind::TK_NonTemplate
-|| calleeFunctionDecl-isFunctionTemplateSpecialization())
-{
-if
(traversedTemplateFunctionSet.insert(calleeFunctionDecl-getQualifiedNameAsString()).second)
-TraverseFunctionDecl(calleeFunctionDecl);
-}
+// if we see a call to a function, it may effectively create new code,
+// if the function is templated. However, if we are inside a template
function,
+// calling another function on the same template, the same problem occurs.
+// Rather than tracking all of that, just traverse anything we have not
already traversed.
+if
(traversedFunctionSet.insert(calleeFunctionDecl-getQualifiedNameAsString()).second)
+TraverseFunctionDecl(calleeFunctionDecl);
CXXMethodDecl* calleeMethodDecl =
dyn_cast_or_nullCXXMethodDecl(calleeFunctionDecl);
if (calleeMethodDecl == nullptr) {
diff --git a/compilerplugins/clang/unusedmethods.py
b/compilerplugins/clang/unusedmethods.py
index ef2beb9..1d4208c 100755
--- a/compilerplugins/clang/unusedmethods.py
+++ b/compilerplugins/clang/unusedmethods.py
@@ -29,7 +29,6 @@ exclusionSet = set([
void comphelper::IEventProcessor::release(),
void SotMutexHolder::acquire(),
void SotMutexHolder::release(),
-class Rectangle ComboBox::GetDropDownPosSizePixel() const
# only used by Windows build
_Bool basegfx::B2ITuple::equalZero() const,
class basegfx::B2DPolyPolygon
basegfx::unotools::UnoPolyPolygon::getPolyPolygonUnsafe() const,
@@ -47,7 +46,7 @@ exclusionSet = set([
int PhysicalFontFace::GetWidth() const,
void PhysicalFontFace::SetBitmapSize(int,int),
_Bool SalObject::IsEraseBackgroundEnabled(),
-# instantiated from a template in VCL, not sure why it is not being picked
up
+# instantiated from templates, not sure why it is not being picked up
class basegfx::B2DPolygon OutputDevice::PixelToLogic(const class
basegfx::B2DPolygon ,const class MapMode ) const,
# only used by OSX build
void StyleSettings::SetHideDisabledMenuItems(_Bool),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92684] Calc Help Conversion document L.O.
https://bugs.documentfoundation.org/show_bug.cgi?id=92684 Andras Timar tima...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |tima...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92721] New: Recent brackages in LIBO version
https://bugs.documentfoundation.org/show_bug.cgi?id=92721 Bug ID: 92721 Summary: Recent brackages in LIBO version Product: LibreOffice Version: 4.4.4.3 release Hardware: Other OS: Mac OS X (All) Status: UNCONFIRMED Severity: blocker Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: suga...@gmail.com Created attachment 117224 -- https://bugs.documentfoundation.org/attachment.cgi?id=117224action=edit check the column width and Line chart behaviour in LIBO and EXCEL Issue 1: Create a new spreadsheet, Insert double Line charts and save as xlsx. Open the same in EXCEL and it shows the up/down bar in line chart. The older versions were file. Issue 2: Create a new spreadsheet, change the width of some columns and save as xlsx, Open the same in EXCEL and column width is the default width. The older versions were fine, I guess!! PS: Test file is attached. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1038d628b3ece37251e3900e7c4014393c13dc3b Author: Andras Timar andras.ti...@collabora.com Date: Tue Jul 14 09:27:11 2015 +0200 Updated core Project: help 053cee1d890e225245b9d8004ab94cf27b1a9621 tdf#92684 embed places section instead of the deleted defaultdir section Change-Id: I2e360913ca041996c2fe5638a992d1f999e3b67f diff --git a/helpcontent2 b/helpcontent2 index 3fb910b..053cee1 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 3fb910bf25d846dd7bc1902e8fe54518b417e793 +Subproject commit 053cee1d890e225245b9d8004ab94cf27b1a9621 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/01/01070001.xhp |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 053cee1d890e225245b9d8004ab94cf27b1a9621 Author: Andras Timar andras.ti...@collabora.com Date: Tue Jul 14 09:27:11 2015 +0200 tdf#92684 embed places section instead of the deleted defaultdir section Change-Id: I2e360913ca041996c2fe5638a992d1f999e3b67f diff --git a/source/text/shared/01/01070001.xhp b/source/text/shared/01/01070001.xhp index 2a05122..ec00edf 100644 --- a/source/text/shared/01/01070001.xhp +++ b/source/text/shared/01/01070001.xhp @@ -47,8 +47,7 @@ embed href=text/shared/01/0107.xhp#levelup/ paragraph role=heading id=hd_id3153312 xml-lang=en-US level=2 l10n=U oldref=5Create New Directory/paragraph embed href=text/shared/01/0107.xhp#createdir/ -paragraph role=heading id=hd_id3155535 xml-lang=en-US level=2 l10n=U oldref=6Default Directory/paragraph -embed href=text/shared/01/0107.xhp#defaultdir/ +embed href=text/shared/01/0107.xhp#places/ paragraph role=heading id=hd_id3154317 xml-lang=en-US level=2 l10n=U oldref=7Display area/paragraph embed href=text/shared/01/0107.xhp#fileview/ paragraph role=heading id=hd_id3147209 xml-lang=en-US level=2 l10n=U oldref=8File Name/paragraph ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92723] New: Font replacements not activatable in master
https://bugs.documentfoundation.org/show_bug.cgi?id=92723 Bug ID: 92723 Summary: Font replacements not activatable in master Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thack...@nexgo.de Hello @ll, while configuring LO Version: 5.1.0.0.alpha1+ Build ID: 9be553f4c61f220ebbe212dc76cb9cce4ae1c106 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-07-13_22:45:19 Locale: de-DE (de_DE.UTF-8) (parallel installed, following the instructions from https://wiki.documentfoundation.org/Installing_in_parallel/Linux) on Debian Testing AMD64, I discovered the following: 1. Start LO 2. Go to Tools - Options – LibreOfficeDev – Fonts 3. Mark Apply replacement table 4. Enter e.g. Arial in Font 5. Enter e.g. Liberation Sans in Replace with 6. Try to enable it either on Always or Screen only On my system, nothing happens ... :( I am not able to enable font replacement in this dialogue ... :( This works in LO Version: 4.4.4.3 Build-ID: 40m0(Build:3) Gebietsschema: de_DE.UTF-8 (Debian's version with Germanophone lang- as well as helppack) as well as with Version: 5.0.1.0.0+ Build ID: b0153639c17d40061480a7bbde11fa0249e3051f TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:libreoffice-5-0, Time: 2015-07-14_03:50:43 Locale: de-DE (de_DE.UTF-8) (also parallel installed) and Version: 5.0.0.3 Build-ID: f79b5ba13f5e6cbad23f8038060e556217e66632 Gebietsschema: de-DE (de_DE.UTF-8) (the same as before ... ;) ) If you need any further information, feel free to ask :) Have a nice day Thomas. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - filter/CppunitTest_filter_utils.mk filter/Module_filter.mk filter/qa filter/source forms/source sw/qa
filter/CppunitTest_filter_utils.mk | 41 +++
filter/Module_filter.mk|1
filter/qa/cppunit/utils-test.cxx | 77 +
filter/source/msfilter/util.cxx| 70 +-
forms/source/component/clickableimage.cxx | 21 +++
forms/source/component/clickableimage.hxx |5 +
sw/qa/extras/globalfilter/globalfilter.cxx | 24 -
7 files changed, 226 insertions(+), 13 deletions(-)
New commits:
commit 16f9cf57e20ffbe34cb184f694f465708250a578
Author: Zolnai Tamás zolnaitamas2...@gmail.com
Date: Tue Jul 14 09:44:10 2015 +0200
tdf#92471: Improve color conversion to MSO highlighting
The simple color distance on RGB color space is not good enough.
It leads to a better result if we use the scheme of the primary
colors.
This method works well with MSO highlighting color palette, but
not neccessarily in general. In highlighting palette light and
dark variant of the same color type (e.g. blue and light blue) has
the exactly same scheme.
Change-Id: Ied08b4c388b8020326709d01d2de290afdd9d77b
diff --git a/filter/CppunitTest_filter_utils.mk
b/filter/CppunitTest_filter_utils.mk
new file mode 100644
index 000..4735abb
--- /dev/null
+++ b/filter/CppunitTest_filter_utils.mk
@@ -0,0 +1,41 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,filter_utils))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,filter_utils))
+$(eval $(call gb_CppunitTest_use_ure,filter_utils))
+
+$(eval $(call gb_CppunitTest_use_configuration,filter_utils))
+
+$(eval $(call gb_CppunitTest_use_libraries,filter_utils, \
+ comphelper \
+ unotest \
+ cppuhelper \
+ cppu \
+ msfilter \
+ sal \
+ $(gb_UWINAPI) \
+))
+
+$(eval $(call gb_CppunitTest_use_components,filter_utils,\
+ configmgr/source/configmgr \
+ filter/source/config/cache/filterconfig1 \
+ framework/util/fwk \
+ framework/util/fwl \
+ i18npool/util/i18npool \
+ ucb/source/core/ucb1 \
+ ucb/source/ucp/file/ucpfile1 \
+))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,filter_utils, \
+ filter/qa/cppunit/utils-test \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/filter/Module_filter.mk b/filter/Module_filter.mk
index 33f0f74..4cb6462 100644
--- a/filter/Module_filter.mk
+++ b/filter/Module_filter.mk
@@ -81,6 +81,7 @@ endif
$(eval $(call gb_Module_add_check_targets,filter,\
CppunitTest_filter_xslt \
CppunitTest_filter_priority \
+CppunitTest_filter_utils \
))
ifneq ($(DISABLE_CVE_TESTS),TRUE)
diff --git a/filter/qa/cppunit/utils-test.cxx b/filter/qa/cppunit/utils-test.cxx
new file mode 100644
index 000..5e306ef
--- /dev/null
+++ b/filter/qa/cppunit/utils-test.cxx
@@ -0,0 +1,77 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include cppunit/TestAssert.h
+#include cppunit/TestFixture.h
+#include cppunit/extensions/HelperMacros.h
+#include cppunit/plugin/TestPlugIn.h
+
+#include sal/types.h
+#include rtl/ustrbuf.hxx
+#include filter/msfilter/util.hxx
+
+#include unotest/bootstrapfixturebase.hxx
+
+namespace {
+
+class UtilsTest
+: public test::BootstrapFixtureBase
+{
+public:
+void testTransColToIco();
+
+CPPUNIT_TEST_SUITE(UtilsTest);
+CPPUNIT_TEST(testTransColToIco);
+CPPUNIT_TEST_SUITE_END();
+};
+
+void UtilsTest::testTransColToIco()
+{
+const sal_uInt32 aStdCol[] = {
+0xee, 0x99, 0xff6600, 0xff, 0xff00cc, 0xff33ff, 0x9900ff,
0xff, 0x00ccff, 0x66, 0x33ff99, 0x99ff66, 0xccff00,
+0xdd, 0x66, 0xffcc00, 0xff, 0xff66cc, 0xff99ff, 0xcc66ff,
0xff, 0xff, 0x99, 0x66ff99, 0x99ff99, 0xccff66,
+0xcc, 0x00, 0xff9900, 0xff, 0xff3399, 0xff66ff, 0x9933ff,
0xff, 0x3399ff, 0x00, 0x00ff66, 0x66ff66, 0x99ff33,
+0xb2b2b2, 0xcc9900, 0xff3300, 0xff, 0xff0066, 0xff00ff, 0x6600ff,
0xff, 0x0066ff, 0x00, 0x00cc33, 0x00cc00, 0x66ff00,
+0x99, 0x996600, 0xcc3300, 0xcc, 0xcc0066, 0xcc00cc, 0x6600cc,
0xcc, 0x0066cc, 0x00, 0x009933, 0x009900, 0x66cc00,
+0x808080, 0x663300, 0x801900, 0x99, 0x990066, 0x990099, 0x330099,
0x99, 0x006699, 0x00, 0x007826, 0x006600, 0x669900,
+0x66, 0x00, 0x461900, 0x33, 0x330033, 0x660066,
[Libreoffice-bugs] [Bug 92274] Problem with the speed of generating pdf in headless mode
https://bugs.documentfoundation.org/show_bug.cgi?id=92274 --- Comment #8 from Tomas Kralik krali...@gmail.com --- first excuse I was away from civilization, so I did not react :-) Yes, I've used these switches to install OO on Red Hat EL 6.6 and Mint 17.1KDE and normally I passed the test. (In reply to Beluga from comment #5) LibreOffice 4.4.4 took 2 seconds to convert it. OpenOffice 3.3 freezes in the command line, when I try: -headless -accept=socket,host=localhost,port=8100;urp; -nocrashreport -nodefault -nofirststartwizard -nolockcheck -nologo -norestore -convert-to pdf vzor.odt How do you do the pdf conversion exactly? You didn't include the parameters. Do you use the exact same parameters as in my above line? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63955] CRASH on FILEOPEN .odp presentation. Bad allocation - Crash. 100% reproducible.
https://bugs.documentfoundation.org/show_bug.cgi?id=63955 --- Comment #10 from Caolán McNamara caol...@redhat.com --- There's a 19 kilometer long dashed line in this presentation, and the time and memory is exhausted generating the polygons for the dashes -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/toolkit package/source toolkit/inc
include/toolkit/awt/scrollabledialog.hxx |8
include/toolkit/awt/vclxgraphics.hxx |2 --
include/toolkit/awt/vclxregion.hxx |1 -
include/toolkit/awt/vclxtopwindow.hxx |3 +--
include/toolkit/controls/controlmodelcontainerbase.hxx |1 -
include/toolkit/controls/unocontrols.hxx |2 --
package/source/zipapi/MemoryByteGrabber.hxx| 15 ---
toolkit/inc/helper/unowrapper.hxx | 16
8 files changed, 1 insertion(+), 47 deletions(-)
New commits:
commit a792aa2c48490e43f7460c7418048d32dc891a62
Author: Noel Grandin n...@peralex.com
Date: Tue Jul 14 10:25:32 2015 +0200
loplugin:unusedmethods toolkit,package
Change-Id: I83618cd2fd12fb0c1691dc7255fc7192e68649cd
Reviewed-on: https://gerrit.libreoffice.org/17031
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/include/toolkit/awt/scrollabledialog.hxx
b/include/toolkit/awt/scrollabledialog.hxx
index a085e65..42b70fe 100644
--- a/include/toolkit/awt/scrollabledialog.hxx
+++ b/include/toolkit/awt/scrollabledialog.hxx
@@ -31,13 +31,9 @@ namespace toolkit
public:
virtual ~ScrollableInterface() {}
virtual voidSetScrollWidth( long nWidth ) = 0;
-virtual longGetScrollWidth() = 0;
virtual voidSetScrollHeight( long nHeight ) = 0;
-virtual longGetScrollHeight() = 0;
virtual voidSetScrollLeft( long nLeft ) = 0;
-virtual longGetScrollLeft() = 0;
virtual voidSetScrollTop( long Top ) = 0;
-virtual longGetScrollTop() = 0;
};
template class T
@@ -61,13 +57,9 @@ namespace toolkit
virtual ~ScrollableWrapper();
virtual void dispose() SAL_OVERRIDE;
virtual voidSetScrollWidth( long nWidth ) SAL_OVERRIDE;
-virtual longGetScrollWidth() SAL_OVERRIDE { return
maScrollArea.Width(); }
virtual voidSetScrollHeight( long nHeight ) SAL_OVERRIDE;
-virtual longGetScrollHeight() SAL_OVERRIDE { return
maScrollArea.Height(); }
virtual voidSetScrollLeft( long nLeft ) SAL_OVERRIDE;
-virtual longGetScrollLeft() SAL_OVERRIDE { return mnScrollPos.X();
}
virtual voidSetScrollTop( long Top ) SAL_OVERRIDE;
-virtual longGetScrollTop() SAL_OVERRIDE { return mnScrollPos.Y() ;
}
void setScrollVisibility( ScrollBarVisibility rState );
DECL_LINK( ScrollBarHdl, ScrollBar* );
diff --git a/include/toolkit/awt/vclxgraphics.hxx
b/include/toolkit/awt/vclxgraphics.hxx
index fdd3d40..547e096 100644
--- a/include/toolkit/awt/vclxgraphics.hxx
+++ b/include/toolkit/awt/vclxgraphics.hxx
@@ -84,8 +84,6 @@ public:
voidSetOutputDevice( OutputDevice* pOutDev );
OutputDevice* GetOutputDevice() const { return mpOutputDevice; }
-const vcl::Font GetFont() const { return maFont; }
-
// ::com::sun::star::uno::XInterface
::com::sun::star::uno::Any SAL_CALL queryInterface( const
::com::sun::star::uno::Type rType )
throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
voidSAL_CALL acquire() throw()
SAL_OVERRIDE { OWeakObject::acquire(); }
diff --git a/include/toolkit/awt/vclxregion.hxx
b/include/toolkit/awt/vclxregion.hxx
index 1206a4f..599b9b7 100644
--- a/include/toolkit/awt/vclxregion.hxx
+++ b/include/toolkit/awt/vclxregion.hxx
@@ -49,7 +49,6 @@ public:
VCLXRegion();
virtual ~VCLXRegion();
-voidSetRegion( const vcl::Region rRegion ) { maRegion =
rRegion; }
const vcl::Region GetRegion() const { return
maRegion; }
// ::com::sun::star::uno::XInterface
diff --git a/include/toolkit/awt/vclxtopwindow.hxx
b/include/toolkit/awt/vclxtopwindow.hxx
index a8b5e2b..890d731 100644
--- a/include/toolkit/awt/vclxtopwindow.hxx
+++ b/include/toolkit/awt/vclxtopwindow.hxx
@@ -42,9 +42,8 @@ private:
const bool m_bWHWND;
protected:
- ::com::sun::star::uno::Reference ::com::sun::star::awt::XMenuBar
mxMenuBar;
+::com::sun::star::uno::Reference ::com::sun::star::awt::XMenuBar
mxMenuBar;
-bool isSystemDependentWindowPeer() const { return m_bWHWND; }
virtual vcl::Window* GetWindowImpl() = 0;
virtual ::cppu::OInterfaceContainerHelper GetTopWindowListenersImpl() = 0;
diff --git a/include/toolkit/controls/controlmodelcontainerbase.hxx
b/include/toolkit/controls/controlmodelcontainerbase.hxx
index 0d44bc3..091a7e2 100644
--- a/include/toolkit/controls/controlmodelcontainerbase.hxx
+++ b/include/toolkit/controls/controlmodelcontainerbase.hxx
@@ -216,7 +216,6 @@ typedef ::cppu::AggImplInheritanceHelper3
UnoControlContainer
class ControlContainerBase : public ContainerControl_IBase
[Libreoffice-commits] core.git: include/framework
include/framework/ContextChangeEventMultiplexerTunnel.hxx | 24 ++
1 file changed, 24 insertions(+)
New commits:
commit 8a1e063aaff5244171f5b9164980a027b734
Author: Michael Stahl mst...@redhat.com
Date: Tue Jul 14 12:22:18 2015 +0200
oops, forgot to add new header file
Change-Id: I83ce7cb1b06ad69250aee48e9a8c1167ae7ef239
diff --git a/include/framework/ContextChangeEventMultiplexerTunnel.hxx
b/include/framework/ContextChangeEventMultiplexerTunnel.hxx
new file mode 100644
index 000..efa2db5
--- /dev/null
+++ b/include/framework/ContextChangeEventMultiplexerTunnel.hxx
@@ -0,0 +1,24 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include framework/fwedllapi.h
+#include com/sun/star/ui/XContextChangeEventListener.hpp
+#include functional
+
+namespace framework {
+
+// this is pretty horrible, don't use it!
+FWE_DLLPUBLIC css::uno::Referencecss::ui::XContextChangeEventListener
+GetFirstListenerWith(
+css::uno::Referencecss::uno::XInterface const xEventFocus,
+std::functionbool
(css::uno::Referencecss::ui::XContextChangeEventListener const) const
rPredicate);
+
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 32359] Collation in lists doesn’t take into account language-specific letters (Ñ for Spanish, ÅÄÖ for Swedish, …)
https://bugs.documentfoundation.org/show_bug.cgi?id=32359 --- Comment #7 from Aled cymro...@gmail.com --- This is not a bug, but rather a feature request, and it is still valid as it has not been rectified/addressed as of LibreOffice 4.4 (Windows 7). User RGB filed the original bug/request with regard the Spanish alphabet, mentioning other languages too. The request is essentially for numbered/ordered lists to use the alphabet of the document language or another languag chosen by the user, whether Spanish, Italian or, in my case, Welsh (Cymraeg), as in the example below. English Cymraeg (a) first(a) cyntaf (b) second (b) ail (c) third(c) trydydd (d) fourth (ch) pedwerydd (e) fifth(d) pumed (f) sixth(dd) chweched I wonder if this is something that might be considered an easy hack and added here? https://wiki.documentfoundation.org/Development/Easy_Hacks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92724] LibreOffice does not render word document correctly, 4 pages instead of 3 as in word
https://bugs.documentfoundation.org/show_bug.cgi?id=92724 steve -_- st...@openmailbox.org changed: What|Removed |Added Priority|medium |low Status|UNCONFIRMED |NEW Summary|LibreOffice does not render |LibreOffice does not render |word document correctly |word document correctly, 4 ||pages instead of 3 as in ||word Ever confirmed|0 |1 Severity|critical|minor --- Comment #2 from steve -_- st...@openmailbox.org --- Adjusting Importance. This is not critical at all: https://wiki.documentfoundation.org/images/0/06/Prioritizing_Bugs_Flowchart.jpg Thejack: thanks for your report though. I am confirming this issue. OS X 10.10.4 LO Version: 5.1.0.0.alpha1+ Build ID: 122a15f4a6c09d35db58fe3a7b943b5ea79cbe65 TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2015-07-09_23:56:41 Locale: de-DE (de.UTF-8) Also in 4.4.4.3. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/pass/crash-1.emf |binary
vcl/source/filter/wmf/enhwmf.cxx |2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 346fa5ada6a976969a19389531fc8671f6a40643
Author: Caolán McNamara caol...@redhat.com
Date: Sun Jul 12 21:07:21 2015 +0100
emf: test for negative numbers
Change-Id: I9d9b6f3e9592ca7b85cee5422e43d4ca46b8bb36
(cherry picked from commit 4661b2dd34bd7c56b6d783d49f265e9ecde19caa)
Reviewed-on: https://gerrit.libreoffice.org/17000
Reviewed-by: David Tardon dtar...@redhat.com
Reviewed-by: Eike Rathke er...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/pass/crash-1.emf
b/vcl/qa/cppunit/graphicfilter/data/emf/pass/crash-1.emf
new file mode 100644
index 000..bbc0285
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/emf/pass/crash-1.emf differ
diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx
index f02871d..345d06b 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -1441,7 +1441,7 @@ bool EnhWMFReader::ReadEnhWMF()
DBG_ASSERT( ( nOptions ( ETO_PDY | ETO_GLYPH_INDEX ) )
== 0, SJ: ETO_PDY || ETO_GLYPH_INDEX in EMF );
Point aPos( ptlReferenceX, ptlReferenceY );
-if ( nLen nLen static_castsal_Int32( SAL_MAX_UINT32
/ sizeof(sal_Int32) ) )
+if ( nLen 0 nLen static_castsal_Int32(
SAL_MAX_UINT32 / sizeof(sal_Int32) ) )
{
if ( offDx (( nCurPos + offDx + nLen * 4 ) =
nNextPos ) )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92055] Crash after docking the media playback toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=92055 --- Comment #12 from Beluga todven...@suomi24.fi --- No crash when docking undocking media playback and slide view toolbars several times. Note that I was able to crash it last month (comment 1). Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64) Build ID: 8de7d44f96252e97e224d42466698114370dbaa3 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-13_21:43:47 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92055] Crash after docking the media playback toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=92055 --- Comment #13 from Beluga todven...@suomi24.fi --- Pasted wrong OS info. Correct: Ubuntu 15.04 64-bit Version: 5.1.0.0.alpha1+ Build ID: 0bd582834b46dbbc5037310d45bac8885e6f2a07 TinderBox: Linux-rpm_deb-x86_64@46-TDF-dbg, Branch:master, Time: 2015-07-14_01:14:35 Locale: en-US (en_US.UTF-8) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92725] Adding new record in table duplicates values in previous field
https://bugs.documentfoundation.org/show_bug.cgi?id=92725 David Burleigh david.burle...@gmx.com changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) OS|All |Linux (All) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92726] Presentation Minimizer does not preserve animations when making static replacements for OLE objects
https://bugs.documentfoundation.org/show_bug.cgi?id=92726 Shimi Chen shimi.c...@gmail.com changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) Version|4.4.4.3 release |Inherited From OOo OS|All |Linux (All) --- Comment #1 from Shimi Chen shimi.c...@gmail.com --- Steps to reproduce with the attachment: 1. Open with LibreOffice Impress 2. Make sure that the Appear animation is set for the math element 3. Tools - Minimize Presentation... 4. go to 4. OLE objects and make sure For all OLE objects is chosen 5. Finish 6. Save the minimized presentation 7. Open the minimized presentation you saved 8. The animation is not there -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Multiselection needs work?
On Mon, 2015-07-13 at 23:30 +0200, Julien Nabet wrote: I thought about a step by step/commit by commit process to change getFiles, and if necessary getSelectedFiles first, then unwinding each use of getFiles and submit a patch for each one. Do you think it could be a problem? Sounds lovely to me =) Thanks ! Michael. -- michael.me...@collabora.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-5-0-0' - sl_SI/description.xml sl_SI/README_th_sl_SI.txt sl_SI/th_sl_SI_v2.dat
sl_SI/README_th_sl_SI.txt |4 sl_SI/description.xml |4 sl_SI/th_sl_SI_v2.dat | 1954 +++--- 3 files changed, 1523 insertions(+), 439 deletions(-) New commits: commit 6fdfef4b1255fae6716ab3a789e3247586e27763 Author: Andras Timar andras.ti...@collabora.com Date: Mon Jul 13 23:55:57 2015 +0200 Updated Slovenian thesaurus Change-Id: If822610ad6d9eca02629959cf8040fe1680f8140 (cherry picked from commit a06da898df0371577c5c2466480f6c807e6c211f) Reviewed-on: https://gerrit.libreoffice.org/17027 Reviewed-by: David Tardon dtar...@redhat.com Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sl_SI/README_th_sl_SI.txt b/sl_SI/README_th_sl_SI.txt index a90862c..396fef0 100644 --- a/sl_SI/README_th_sl_SI.txt +++ b/sl_SI/README_th_sl_SI.txt @@ -2,7 +2,7 @@ The Slovenian thesaurus is developed as a part of project/ Slovenski tezaver nastaja v okviru projekta: OdprtiTezaver (www.tezaver.si) This dictionary pack includes version/Paket vsebuje razliÄico: - 1.7.17000 + 1.7.17500 Thesaurus managed and edited by/Tezaver pripravlja in ureja: Martin Srebotnjak (miles at filmsi net) Thesaurus data licensed under both/Podatki tezavra so izdani pod licencama: @@ -18,7 +18,7 @@ Bug report/O napakah poroÄajte: http://external.openoffice.org/ form data: Product Name: Slovenian thesaurus -Product Version: 1.7.17000 +Product Version: 1.7.17500 Vendor or Owner Name: Martin Srebotnjak Vendor or Owner Contact: mi...@filmsi.net OpenOffice.org Contact: fil...@openoffice.org diff --git a/sl_SI/description.xml b/sl_SI/description.xml index 07b658b..85cab19 100644 --- a/sl_SI/description.xml +++ b/sl_SI/description.xml @@ -1,6 +1,6 @@ ?xml version=1.0 encoding=UTF-8? description xmlns=http://openoffice.org/extensions/description/2006; xmlns:d=http://openoffice.org/extensions/description/2006; xmlns:xlink=http://www.w3.org/1999/xlink; -version value=2014.12.29 / +version value=2015.07.13 / identifier value=libreoffice.sl.hunspell.dictionaries / display-name name lang=en-USSlovenian spelling dictionary, hyphenation rules, and thesaurus/name @@ -10,6 +10,6 @@ OpenOffice.org-minimal-version value=3.0 d:name=OpenOffice.org 3.0 / /dependencies publisher -name xlink:href=http://sl.libreoffice.org/slovenjenje-2/jezikovne-razsiritve/; lang=sl-SIsl.libreoffice.org/name +name xlink:href=http://sl.libreoffice.org/skupnost/slovenjenje/jezikovne-razsiritve/; lang=sl-SIsl.libreoffice.org/name /publisher /description diff --git a/sl_SI/th_sl_SI_v2.dat b/sl_SI/th_sl_SI_v2.dat index f1a6a7c..2971d0f 100644 --- a/sl_SI/th_sl_SI_v2.dat +++ b/sl_SI/th_sl_SI_v2.dat @@ -37,7 +37,8 @@ ISO8859-2 (sam.)|prvenstvo ¹ank|1 (sam.)|¹ank (pogovorno)|toèilna miza|toèilni pult -¹ansa|1 +¹ansa|2 +(sam.)|¹ansa (pogovorno)|izgled|mo¾nost|mogoèost|obet|upanje (sam.)|¹ansa (pogovorno)|prilika|prilo¾nost ¹anson|1 (sam.)|chanson|pesem|popevka @@ -47,12 +48,14 @@ ISO8859-2 (sam.)|¹antavost (slab¹alno)|¹epavost|kruljavost (ekspresivno) ¹apa|1 (sam.)|taca +¹ar¾a|1 +(sam.)|¹ar¾a (zastarelo)|èin ¹ar¾er|1 (sam.)|okvir ¹ariti|1 (gl.)|brèkati|brkljariti (ekspresivno)|brkljati (pogovorno)|brskati|stikati ¹arm|1 -(sam.)|dra¾|dra¾est|mik|mikavnost|oèarljivost|privlaènost +(sam.)|dra¾|dra¾est|ljubkost|mik|mikavnost|oèarljivost|privlaènost ¹arnir|1 (sam.)|zapirnica ¹arovit|1 @@ -65,6 +68,8 @@ ISO8859-2 (gl.)|¹u¹njati ¹èavje|1 (sam.)|¹avje +¹èebljati|1 +(gl.)|èebljati ¹èegetavèek|1 (sam.)|klitoris ¹èetka|1 @@ -84,7 +89,7 @@ ISO8859-2 ¹enk|1 (sam.)|¹enk (pogovorno)|dar|darilo|naklonilo (zastarelo)|naklonitev (zastarelo)|podarek (zastarelo)|poklon (zastarelo)|poklonilo (zastarelo)|poklonitev (zastarelo)|poklonstvo (zastarelo)|prezent (zastarelo)|vezilo (zastarelo) ¹ent|1 -(sam.)|¹ment|hudiè|hudiman|hudimar|hudir|parkelj|peklen¹èek|rogaè|satan|sku¹njavec|vrag|vragec|vranè|zlobec|zlodej +(sam.)|¹ment|hudiè|hudiman|hudimar|hudir|hudnik|parkelj|peklen¹èek|rogaè|satan|sku¹njavec|vrag|vragec|vranè|zlobec|zlodej ¹entjan¾evka|1 (sam.)|Hypericum perforatum (strokovno)|krènica|krvavec ¹epast|1 @@ -143,13 +148,16 @@ ISO8859-2 (sam.)|¹pièenje (pogovorno)|ostrenje ¹initi|1 (gl.)|¹vigniti|blisniti (ekspresivno) +¹ipkova u¹ica|1 +(sam.)|Macrosiphon rosae (strokovno) ¹iptarski|1 (prid.)|albanski ¹iren|1 (prid.)|¹iro¹iren (ekspresivno)|obse¾en|prostran ¹irjava|1 (sam.)|prostranstvo|vse¹ir -¹irjenje|1 +¹irjenje|2 +(sam.)|dilatacija|raz¹irjanje (sam.)|iradiacija|raz¹irjanje ¹iro¹iren|1 (prid.)|¹iren|¹iro¹iren (ekspresivno)|obse¾en|prostran @@ -172,7 +180,7 @@ ISO8859-2 ¹irokoustnost|1 (sam.)|¹irokoustnost (ekspresivno)|bahavost|hvalisavost|razustnost ¹kandalozen|1 -(prid.)|¹kandalozen (ekspresivno)|grozen (ekspresivno)|nekvaliteten|neprebavljiv (ekspresivno)|neu¾iten (ekspresivno)|neznosen|obupen|po¹asten
[Libreoffice-commits] help.git: Branch 'libreoffice-5-0' - source/text
source/text/shared/01/01070001.xhp |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit df04396f17c0ed2d76bc10f60fda61fc1ee34ce5 Author: Andras Timar andras.ti...@collabora.com Date: Tue Jul 14 09:27:11 2015 +0200 tdf#92684 embed places section instead of the deleted defaultdir section Change-Id: I2e360913ca041996c2fe5638a992d1f999e3b67f (cherry picked from commit 053cee1d890e225245b9d8004ab94cf27b1a9621) Reviewed-on: https://gerrit.libreoffice.org/17029 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/source/text/shared/01/01070001.xhp b/source/text/shared/01/01070001.xhp index 2a05122..ec00edf 100644 --- a/source/text/shared/01/01070001.xhp +++ b/source/text/shared/01/01070001.xhp @@ -47,8 +47,7 @@ embed href=text/shared/01/0107.xhp#levelup/ paragraph role=heading id=hd_id3153312 xml-lang=en-US level=2 l10n=U oldref=5Create New Directory/paragraph embed href=text/shared/01/0107.xhp#createdir/ -paragraph role=heading id=hd_id3155535 xml-lang=en-US level=2 l10n=U oldref=6Default Directory/paragraph -embed href=text/shared/01/0107.xhp#defaultdir/ +embed href=text/shared/01/0107.xhp#places/ paragraph role=heading id=hd_id3154317 xml-lang=en-US level=2 l10n=U oldref=7Display area/paragraph embed href=text/shared/01/0107.xhp#fileview/ paragraph role=heading id=hd_id3147209 xml-lang=en-US level=2 l10n=U oldref=8File Name/paragraph ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Branch 'libreoffice-4-4' - source/text
source/text/shared/01/01070001.xhp |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 9b9960279d36f9bfcfd898108b556838da21aa85 Author: Andras Timar andras.ti...@collabora.com Date: Tue Jul 14 09:27:11 2015 +0200 tdf#92684 embed places section instead of the deleted defaultdir section Change-Id: I2e360913ca041996c2fe5638a992d1f999e3b67f (cherry picked from commit 053cee1d890e225245b9d8004ab94cf27b1a9621) Reviewed-on: https://gerrit.libreoffice.org/17030 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/source/text/shared/01/01070001.xhp b/source/text/shared/01/01070001.xhp index 2a05122..ec00edf 100644 --- a/source/text/shared/01/01070001.xhp +++ b/source/text/shared/01/01070001.xhp @@ -47,8 +47,7 @@ embed href=text/shared/01/0107.xhp#levelup/ paragraph role=heading id=hd_id3153312 xml-lang=en-US level=2 l10n=U oldref=5Create New Directory/paragraph embed href=text/shared/01/0107.xhp#createdir/ -paragraph role=heading id=hd_id3155535 xml-lang=en-US level=2 l10n=U oldref=6Default Directory/paragraph -embed href=text/shared/01/0107.xhp#defaultdir/ +embed href=text/shared/01/0107.xhp#places/ paragraph role=heading id=hd_id3154317 xml-lang=en-US level=2 l10n=U oldref=7Display area/paragraph embed href=text/shared/01/0107.xhp#fileview/ paragraph role=heading id=hd_id3147209 xml-lang=en-US level=2 l10n=U oldref=8File Name/paragraph ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3d167a7e0e15403e3bd390c612fd4bc163975a37 Author: Andras Timar andras.ti...@collabora.com Date: Tue Jul 14 09:27:11 2015 +0200 Updated core Project: help 9b9960279d36f9bfcfd898108b556838da21aa85 tdf#92684 embed places section instead of the deleted defaultdir section Change-Id: I2e360913ca041996c2fe5638a992d1f999e3b67f (cherry picked from commit 053cee1d890e225245b9d8004ab94cf27b1a9621) Reviewed-on: https://gerrit.libreoffice.org/17030 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/helpcontent2 b/helpcontent2 index 172c582..9b99602 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 172c582a5c6f5f93997d99872114f9f1b2c6e415 +Subproject commit 9b9960279d36f9bfcfd898108b556838da21aa85 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a5266c84adae943c988ed3e2c797a6c610b36cca Author: Andras Timar andras.ti...@collabora.com Date: Tue Jul 14 09:27:11 2015 +0200 Updated core Project: help df04396f17c0ed2d76bc10f60fda61fc1ee34ce5 tdf#92684 embed places section instead of the deleted defaultdir section Change-Id: I2e360913ca041996c2fe5638a992d1f999e3b67f (cherry picked from commit 053cee1d890e225245b9d8004ab94cf27b1a9621) Reviewed-on: https://gerrit.libreoffice.org/17029 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/helpcontent2 b/helpcontent2 index 176f822..df04396 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 176f822e7a3569ffeb3026df7fc074fd8c0163cc +Subproject commit df04396f17c0ed2d76bc10f60fda61fc1ee34ce5 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4f60b3bcde456c8c6f1f55193bb662366f703dbb Author: Andras Timar andras.ti...@collabora.com Date: Mon Jul 13 23:55:57 2015 +0200 Updated core Project: dictionaries 6fdfef4b1255fae6716ab3a789e3247586e27763 Updated Slovenian thesaurus Change-Id: If822610ad6d9eca02629959cf8040fe1680f8140 (cherry picked from commit a06da898df0371577c5c2466480f6c807e6c211f) Reviewed-on: https://gerrit.libreoffice.org/17027 Reviewed-by: David Tardon dtar...@redhat.com Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/dictionaries b/dictionaries index 2d64c57..6fdfef4 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit 2d64c57a4375fe489b16c358ce38848c938bc201 +Subproject commit 6fdfef4b1255fae6716ab3a789e3247586e27763 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: offapi/com
offapi/com/sun/star/ui/dialogs/XFilePicker.idl | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) New commits: commit c657740b0f6caa5d0c7d54db37aca013d6ac1c8c Author: Julien Nabet serval2...@yahoo.fr Date: Mon Jul 13 12:20:50 2015 +0200 getFiles: simplify even more description Conflicts: offapi/com/sun/star/ui/dialogs/XFilePicker.idl Change-Id: I89cec47234e275d4753a779e320fc6288c6a4fbc Reviewed-on: https://gerrit.libreoffice.org/16985 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Michael Meeks michael.me...@collabora.com Tested-by: Michael Meeks michael.me...@collabora.com diff --git a/offapi/com/sun/star/ui/dialogs/XFilePicker.idl b/offapi/com/sun/star/ui/dialogs/XFilePicker.idl index 7552854..17b56cc 100644 --- a/offapi/com/sun/star/ui/dialogs/XFilePicker.idl +++ b/offapi/com/sun/star/ui/dialogs/XFilePicker.idl @@ -87,21 +87,8 @@ published interface XFilePicker: com::sun::star::ui::dialogs::XExecutableDialog @returns p The complete path of the file or directory currently selected -in URL format. There are two different cases: -ol -liMulti-selection is disabled: -The first and only entry of the sequence contains the complete -path/filename in URL format./li - -liMulti-selection is enabled: -If only one file is selected, the first entry -of the sequence contains the complete path/filename in URL format. -If multiple files are selected, only the first entry is retrieved with -the path in URL format./li -/ol - +in URL format. This always returns only the first entry of the sequence. br/ - pstrongNotes for the implementation of a FileSave dialog:/strongIf there exists a checkbox Automatic File Extension which is checked and a valid filter is currently selected the dialog may automatically add an extension to the selected file name./p ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-qa] SI GUI Java Feedback (now on github)
Hi :) Double click works now, but if you start it via cmd line (not neccessarily java -jar) you will see a bit of an output. As I start my summer job next Monday, I won't develop it further till September or so. You may find the repo here: https://github.com/reisi007/Java-SI-GUI/ [Please file bugs there] -- Liebe Grüße, / Yours, Florian Reisinger ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: Gerrit: Reliability and fidelity of verification results
Hi, On Mon, Jul 13, 2015 at 04:51:01PM -0500, Norbert Thiebaud wrote: Do not get me wrong. I applaud the effort to get rid of boost if we can.. that is a big and expensive dep. Except that I doubt we'll ever be able to do that. boost is used not only by libreoffice, but also by many bundled libs. And there is a lot of it used that'll hardly ever have an equivalent in the std. library. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92471] FILESAVE: New DOCX export of text with highlighting works not for all colors
https://bugs.documentfoundation.org/show_bug.cgi?id=92471 --- Comment #8 from Zolnai Tamás zolnaitamas2...@gmail.com --- (In reply to ralf.krapf from comment #6) I see. Because not everyone is an expert in exporting, Shading would be possibly the better default setting? Highlighting is the default, because it is called highlighting in both programs (MSO Word and LO Writer), so it can be expected that highlighting (LO) is exported as highlighting (MSO). I read also some user problems about that users can't remove highlighting in Word, because it was actually shading (it seems highlighting feature is more familiar in Word than shading): http://www.wordbanter.com/showthread.php?t=85055 I added a better conversion algorithm now which works much better with LO standard color palette, so hopefully the conversion during export won't be a problem. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: accessibility/inc compilerplugins/clang framework/inc framework/source include/svtools svtools/inc svtools/source
accessibility/inc/accessibility/extended/AccessibleGridControl.hxx | 18 - compilerplugins/clang/unusedmethods.cxx|2 framework/inc/uielement/fontmenucontroller.hxx |1 framework/inc/uielement/fontsizemenucontroller.hxx |1 framework/inc/uielement/headermenucontroller.hxx |1 framework/inc/uielement/langselectionmenucontroller.hxx|1 framework/inc/uielement/macrosmenucontroller.hxx |1 framework/source/uielement/controlmenucontroller.cxx | 13 - framework/source/uielement/fontmenucontroller.cxx |8 framework/source/uielement/fontsizemenucontroller.cxx |9 framework/source/uielement/headermenucontroller.cxx|8 framework/source/uielement/langselectionmenucontroller.cxx | 32 --- framework/source/uielement/macrosmenucontroller.cxx| 16 - framework/source/uielement/objectmenucontroller.cxx| 10 - include/svtools/accessibilityoptions.hxx |2 include/svtools/accessibletable.hxx| 14 - include/svtools/accessibletableprovider.hxx|2 include/svtools/addresstemplate.hxx|1 include/svtools/apearcfg.hxx |1 include/svtools/asynclink.hxx |2 include/svtools/brwbox.hxx | 10 - include/svtools/calendar.hxx | 58 -- include/svtools/ctrlbox.hxx| 43 +--- include/svtools/ctrltool.hxx |2 include/svtools/dialogcontrolling.hxx |1 include/svtools/editbrowsebox.hxx |6 include/svtools/editimplementation.hxx |7 include/svtools/filectrl.hxx | 15 - include/svtools/fileview.hxx |1 include/svtools/fmtfield.hxx |4 include/svtools/framestatuslistener.hxx|1 include/svtools/grfmgr.hxx |3 include/svtools/headbar.hxx| 16 - include/svtools/hyperlabel.hxx |5 include/svtools/imapcirc.hxx |3 include/svtools/imapobj.hxx| 20 -- include/svtools/imappoly.hxx |5 include/svtools/imaprect.hxx |3 include/svtools/inetimg.hxx| 12 - include/svtools/ivctrl.hxx | 20 -- include/svtools/miscopt.hxx|3 include/svtools/parhtml.hxx|7 include/svtools/parrtf.hxx |5 include/svtools/popupmenucontrollerbase.hxx|1 include/svtools/prnsetup.hxx |1 include/svtools/ruler.hxx | 21 -- include/svtools/simptabl.hxx |9 include/svtools/stdmenu.hxx|6 include/svtools/svlbitm.hxx|8 include/svtools/svparser.hxx | 13 - include/svtools/svtabbx.hxx|1 include/svtools/tabbar.hxx | 16 - include/svtools/table/tableinputhandler.hxx|4 include/svtools/table/tablemodel.hxx | 77 include/svtools/toolpanelopt.hxx |2 include/svtools/transfer.hxx | 23 +- include/svtools/treelist.hxx |4 include/svtools/treelistbox.hxx| 10 - include/svtools/treelistentry.hxx |1 include/svtools/valueset.hxx | 51 + include/svtools/wizardmachine.hxx |3 include/svtools/wizdlg.hxx |7 include/svtools/xwindowitem.hxx|1 svtools/inc/table/defaultinputhandler.hxx |4 svtools/inc/table/tablecontrol.hxx | 28 ---
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/xbm/fail/crash-1.xbm | 12
vcl/qa/cppunit/graphicfilter/data/xbm/pass/grafix4.xbm | 2011 +
vcl/qa/cppunit/graphicfilter/filters-test.cxx |4
vcl/source/filter/ixbm/xbmread.cxx |2
4 files changed, 2028 insertions(+), 1 deletion(-)
New commits:
commit cd501c499743897254e0fa1ca821053b0b36a977
Author: Caolán McNamara caol...@redhat.com
Date: Sat Jul 11 17:23:06 2015 +0100
fix and test for xbm import crash
Change-Id: I47e7cb259908ffc6a00475369af1a841acda1da7
(cherry picked from commit 7eb693f87b6a01044999564cce0a18fefca11c99)
Reviewed-on: https://gerrit.libreoffice.org/17004
Reviewed-by: David Tardon dtar...@redhat.com
Reviewed-by: Eike Rathke er...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/fail/.gitignore
b/vcl/qa/cppunit/graphicfilter/data/xbm/fail/.gitignore
new file mode 100644
index 000..e69de29
diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/fail/crash-1.xbm
b/vcl/qa/cppunit/graphicfilter/data/xbm/fail/crash-1.xbm
new file mode 100644
index 000..9d2a434
--- /dev/null
+++ b/vcl/qa/cppunit/graphicfilter/data/xbm/fail/crash-1.xbm
@@ -0,0 +1,12 @@
+#define?te_width 31
+#define te_height = {
+ 0x0e, 0x20, 0x02, 0x38, 0x11, 0x70, 0x07, 0x 0x44,
+ 0x11, 1x2e, 0x3a, 0x44, 0x8e, 0x24, 0x92, 0x38, 0xdf, 0x25, 0xd2,0x7d,
+ 0x91, 0x24 0x92, 0x44, 0x95: 0x24, 0x92, 0x54, 0xf5, 0x7f, 0xff, 0x57,
+ 0x95, 0x24, 0x92, 0x54, 0x95, 0x 4,54, 0x95, 0x24, 0x92, 0x54,
+ 0x95, 0x24,x54, 0x95, 0x24, 0x92, 0x54, 0x95, 0x24, 0x92, 0x54,
+ 0x95, 0x24, 0x92, 0x54, 0x95, 0x24, 0x92,0x54, 0x95, 0x24, 0x92, 0x54,
+ 0x95, 0x24,ÏÏÏ 0x92, 0x54, 0x95, 0x24, 0x92, 0x54, 0xf5, 0x7f, 0xff,
0x57,
+ 0x95,0x24, 0x92, 0x54, 0x95, 0x24, 0x92, 0x54, 0, 0x54, 0xf5, 0xd= {
+ 25, 0xd2, 0x7d,
+0x00, 0x7c };
\ No newline at end of file
diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/indeterminate/.gitignore
b/vcl/qa/cppunit/graphicfilter/data/xbm/indeterminate/.gitignore
new file mode 100644
index 000..e69de29
diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/pass/.gitignore
b/vcl/qa/cppunit/graphicfilter/data/xbm/pass/.gitignore
new file mode 100644
index 000..e69de29
diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/pass/grafix4.xbm
b/vcl/qa/cppunit/graphicfilter/data/xbm/pass/grafix4.xbm
new file mode 100755
index 000..aad9f03
--- /dev/null
+++ b/vcl/qa/cppunit/graphicfilter/data/xbm/pass/grafix4.xbm
@@ -0,0 +1,2011 @@
+#define Grafix1_width 485
+#define Grafix1_height 395
+static char Grafix1_bits[] = {
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-2.emf |binary
vcl/source/filter/wmf/winmtf.cxx | 26 +
2 files changed, 15 insertions(+), 11 deletions(-)
New commits:
commit 14a3f7c013f35be2fd8cb70610b28b23c0aa3e3a
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 08:33:50 2015 +0100
emf: test for empty polygons
Change-Id: I3c8896230e3d48a37f4b8d702b0f673e44f45ba4
(cherry picked from commit 7df4d8544c6b12e31bcb81d9389d03ae7c11bfea)
Reviewed-on: https://gerrit.libreoffice.org/16999
Reviewed-by: David Tardon dtar...@redhat.com
Reviewed-by: Eike Rathke er...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-2.emf
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-2.emf
new file mode 100644
index 000..6adabec
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-2.emf differ
diff --git a/vcl/source/filter/wmf/winmtf.cxx b/vcl/source/filter/wmf/winmtf.cxx
index f14f934..20e2b5c 100644
--- a/vcl/source/filter/wmf/winmtf.cxx
+++ b/vcl/source/filter/wmf/winmtf.cxx
@@ -1294,18 +1294,22 @@ void WinMtfOutput::DrawPolyLine( Polygon rPolygon,
bool bTo, bool bRecordPath )
{
UpdateClipRegion();
-ImplMap( rPolygon );
-if ( bTo )
-{
-rPolygon[ 0 ] = maActPos;
-maActPos = rPolygon[ rPolygon.GetSize() - 1 ];
-}
-if ( bRecordPath )
-aPathObj.AddPolyLine( rPolygon );
-else
+sal_uInt16 nPoints = rPolygon.GetSize();
+if (nPoints = 1)
{
-UpdateLineStyle();
-mpGDIMetaFile-AddAction( new MetaPolyLineAction( rPolygon,
maLineStyle.aLineInfo ) );
+ImplMap( rPolygon );
+if ( bTo )
+{
+rPolygon[ 0 ] = maActPos;
+maActPos = rPolygon[ rPolygon.GetSize() - 1 ];
+}
+if ( bRecordPath )
+aPathObj.AddPolyLine( rPolygon );
+else
+{
+UpdateLineStyle();
+mpGDIMetaFile-AddAction( new MetaPolyLineAction( rPolygon,
maLineStyle.aLineInfo ) );
+}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92725] New: Adding new record in table duplicates values in previous field
https://bugs.documentfoundation.org/show_bug.cgi?id=92725 Bug ID: 92725 Summary: Adding new record in table duplicates values in previous field Product: LibreOffice Version: 5.0.0.3 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: david.burle...@gmx.com In the Table view, when adding a new record, the value of the field in the previous record is automatically duplicated in the new record and must be overwritten with the intended value for the new record. This is different from the behavior in version 4.x and all previous version that I have used, and is very undesirable. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/CppunitTest_filter_utils.mk
filter/CppunitTest_filter_utils.mk |4 1 file changed, 4 insertions(+) New commits: commit bd8e8db250f99445dc1a8baa7ffc6ddfe90fdf5b Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jul 14 10:52:31 2015 +0200 Missing boost_headers Change-Id: Ie42c10d09a7b6194919e57e88022e05e4cbd7016 diff --git a/filter/CppunitTest_filter_utils.mk b/filter/CppunitTest_filter_utils.mk index 4735abb..d719b60 100644 --- a/filter/CppunitTest_filter_utils.mk +++ b/filter/CppunitTest_filter_utils.mk @@ -14,6 +14,10 @@ $(eval $(call gb_CppunitTest_use_ure,filter_utils)) $(eval $(call gb_CppunitTest_use_configuration,filter_utils)) +$(eval $(call gb_CppunitTest_use_externals,filter_utils, \ +boost_headers \ +)) + $(eval $(call gb_CppunitTest_use_libraries,filter_utils, \ comphelper \ unotest \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92727] New: Тест 1
https://bugs.documentfoundation.org/show_bug.cgi?id=92727 Bug ID: 92727 Summary: Тест 1 Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: a.klept...@yandex.ru Тест 1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91452] Assigning Formats by Formula Help
https://bugs.documentfoundation.org/show_bug.cgi?id=91452 --- Comment #4 from gmarco gmmell...@inwind.it --- (In reply to Valter Mura from comment #3) These imperfections are due to imperfect synchronization between online help and web help. I don't think it is a synchronization question, the imperfections are in the web version already. At https://help.libreoffice.org/Calc/Assigning_Formats_by_Formula/it: Per applicare una formula a tutte le celle nell'area selezionata, potete utilizzare la finestra di dialogo Cerca e sostituisci. the popup says Trova e sostituisci and the English version too says Find (=trova) 2.che si apre selezionando Modifica - Cerca e sostituisci. here something is missing; I suggested 2. Richiamate il menu di contesto selezionando Modifica - Trova e sostituisci. (English is 2.Select the menu command Edit - Find Replace.) . 5.Contrassegnate i campi Espressione regolare e Solo nella selezione. Fate clic su Cerca tutto. here it is missing, in English too, what to do before mark the fields; I suggested 5. Cliccate la casella Altre opzioni per estenderne la visualizzazione e contrassegnate i campi Espressione regolare e Solo nella selezione. Fate clic su Sostituisci tutto. (note that at end you have to click on Sostituisci tutto instead of Cerca tutto) 6.Fate clic su Sostituisci tutto. you should say (English too) Fate clic su Chiudi. Vengono evidenziate tutte le celle con un contenuto che sono state selezionate. the sentence should follow item 6. (English too) and is a bad translation; English says All cells with contents that were included in the selection are now highlighted. and I suggested Tutte le celle precedentemente selezionate, con un contenuto, sono ora evidenziate. Hoping I have better clarified the question. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-1.gif |binary
vcl/source/filter/igif/decode.cxx |2 ++
2 files changed, 2 insertions(+)
New commits:
commit 6029d711a7af1a68ffa8d0cb0a0bd8092984f659
Author: Caolán McNamara caol...@redhat.com
Date: Sat Jul 11 15:31:19 2015 +0100
fix gif import crash
Change-Id: I3a5e0efef6843fb8f8b485fa2369ac5b99513c31
(cherry picked from commit 839e051c658a638a259be6a6bb091b654fac405f)
Reviewed-on: https://gerrit.libreoffice.org/17003
Reviewed-by: David Tardon dtar...@redhat.com
Reviewed-by: Eike Rathke er...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-1.gif
b/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-1.gif
new file mode 100644
index 000..860f9e1
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-1.gif differ
diff --git a/vcl/source/filter/igif/decode.cxx
b/vcl/source/filter/igif/decode.cxx
index 46a666f..1b18f5e 100644
--- a/vcl/source/filter/igif/decode.cxx
+++ b/vcl/source/filter/igif/decode.cxx
@@ -197,6 +197,8 @@ bool GIFLZWDecompressor::ProcessOneCode()
pE = pTable + nCode;
do
{
+if (pOutBufData == pOutBuf) //can't go back past start
+return false;
nOutBufDataLen++;
*(--pOutBufData) = pE-nData;
pE = pE-pPrev;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92724] New: LibreOffice does not render document correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=92724 Bug ID: 92724 Summary: LibreOffice does not render document correctly Product: LibreOffice Version: 5.0.0.3 rc Hardware: All OS: All Status: UNCONFIRMED Severity: critical Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thej...@protonmail.ch Created attachment 117225 -- https://bugs.documentfoundation.org/attachment.cgi?id=117225action=edit File which causes the failure When opening the attached document in Word, there are 3 pages shown, but LibreOffice shows four pages, one of them empty. This page is not shown in Word. LibreOffice 5.x is the first version affected by this bug. Furthermore, LibreOffice flickers when scrolling. Any suggestions? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: framework/inc framework/source include/sfx2 sfx2/source
framework/inc/helper/mischelper.hxx | 12 +++
framework/source/fwe/classes/sfxhelperfunctions.cxx | 10 ++
framework/source/fwi/helper/mischelper.cxx | 15 +++
framework/source/services/ContextChangeEventMultiplexer.cxx | 47 +++-
include/sfx2/sidebar/SidebarController.hxx |9 --
sfx2/source/sidebar/SidebarController.cxx | 27 +-
6 files changed, 90 insertions(+), 30 deletions(-)
New commits:
commit 9be8c4f21200aeec5b334d9536b3b7a0b72c24fa
Author: Michael Stahl mst...@redhat.com
Date: Mon Jul 13 18:54:17 2015 +0200
sfx2: remove the global SidebarController::maSidebarControllerContainer
This global was crashing on exit, unsurprising as it contains UNO
services that reference VCL objects.
It turns out that there is already a UNO singleton
framework::ContextChangeEventMultiplexer that effectively contains this
mapping already, so try to hook that up without creating a public API of
it, which is made quite a bit harder by framework's inexplicable
multitude of libraries.
Change-Id: I4baf67b42c630191fa8879d650eeb62520c331a5
diff --git a/framework/inc/helper/mischelper.hxx
b/framework/inc/helper/mischelper.hxx
index 6aa0015..7f45aa6 100644
--- a/framework/inc/helper/mischelper.hxx
+++ b/framework/inc/helper/mischelper.hxx
@@ -28,6 +28,7 @@
#include com/sun/star/container/XContainerListener.hpp
#include com/sun/star/frame/XFrame.hpp
#include com/sun/star/uno/XComponentContext.hpp
+#include com/sun/star/ui/XContextChangeEventListener.hpp
#include cppuhelper/implbase1.hxx
@@ -36,6 +37,7 @@
#include rtl/ustring.hxx
#include fwidllapi.h
+#include functional
#include set
namespace framework
@@ -304,6 +306,16 @@ class WeakDocumentEventListener : public
::cppu::WeakImplHelper1com::sun::star:
}
};
+FWI_DLLPUBLIC css::uno::Referencecss::ui::XContextChangeEventListener
+GetFirstListenerWith_Impl(
+css::uno::Referencecss::uno::XInterface const xEventFocus,
+std::functionbool
(css::uno::Referencecss::ui::XContextChangeEventListener const) const
rPredicate);
+
+FWI_DLLPUBLIC extern auto (*g_pGetMultiplexerListener)(
+css::uno::Referencecss::uno::XInterface const,
+std::functionbool
(css::uno::Referencecss::ui::XContextChangeEventListener const) const)
+- css::uno::Referencecss::ui::XContextChangeEventListener;
+
} // namespace framework
#endif // INCLUDED_FRAMEWORK_INC_HELPER_MISCHELPER_HXX
diff --git a/framework/source/fwe/classes/sfxhelperfunctions.cxx
b/framework/source/fwe/classes/sfxhelperfunctions.cxx
index a1f0826..c04105c 100644
--- a/framework/source/fwe/classes/sfxhelperfunctions.cxx
+++ b/framework/source/fwe/classes/sfxhelperfunctions.cxx
@@ -18,6 +18,8 @@
*/
#include framework/sfxhelperfunctions.hxx
+#include framework/ContextChangeEventMultiplexerTunnel.hxx
+#include helper/mischelper.hxx
#include tools/diagnose_ex.h
@@ -163,6 +165,14 @@ void SAL_CALL ActivateToolPanel( const
::com::sun::star::uno::Reference ::com::
(*pActivator)( i_rFrame, i_rPanelURL );
}
+using namespace ::com::sun::star;
+uno::Referenceui::XContextChangeEventListener GetFirstListenerWith(
+uno::Referenceuno::XInterface const xEventFocus,
+std::functionbool (uno::Referenceui::XContextChangeEventListener
const) const rPredicate)
+{
+return GetFirstListenerWith_Impl(xEventFocus, rPredicate);
+}
+
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/framework/source/fwi/helper/mischelper.cxx
b/framework/source/fwi/helper/mischelper.cxx
index 5b1e15f..06cc061 100644
--- a/framework/source/fwi/helper/mischelper.cxx
+++ b/framework/source/fwi/helper/mischelper.cxx
@@ -212,6 +212,21 @@ void FillLangItems( std::set OUString rLangItems,
}
}
+auto (*g_pGetMultiplexerListener)(
+uno::Referenceuno::XInterface const,
+std::functionbool (uno::Referenceui::XContextChangeEventListener
const) const)
+- uno::Referenceui::XContextChangeEventListener = nullptr;
+
+uno::Referenceui::XContextChangeEventListener
+GetFirstListenerWith_Impl(
+uno::Referenceuno::XInterface const xEventFocus,
+std::functionbool (uno::Referenceui::XContextChangeEventListener
const) const rPredicate)
+{
+assert(g_pGetMultiplexerListener != nullptr); // should not be called too
early, nor too late
+return g_pGetMultiplexerListener(xEventFocus, rPredicate);
+}
+
+
} // namespace framework
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/framework/source/services/ContextChangeEventMultiplexer.cxx
b/framework/source/services/ContextChangeEventMultiplexer.cxx
index 6fe88ee..d672704 100644
--- a/framework/source/services/ContextChangeEventMultiplexer.cxx
+++ b/framework/source/services/ContextChangeEventMultiplexer.cxx
@@ -17,6 +17,8 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
+#include helper/mischelper.hxx
+
#include
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - fpicker/source officecfg/registry
fpicker/source/office/RemoteFilesDialog.cxx| 29 +++--
fpicker/source/office/RemoteFilesDialog.hxx|1
officecfg/registry/data/org/openoffice/Office/Common.xcu |3 +
officecfg/registry/data/org/openoffice/Setup.xcu |1
officecfg/registry/schema/org/openoffice/Office/Common.xcs |5 ++
5 files changed, 36 insertions(+), 3 deletions(-)
New commits:
commit d04b85c8f8e85bcb5c1fc05ba7e71713259b768f
Author: Szymon KÅos eszka...@gmail.com
Date: Tue Jul 14 13:10:53 2015 +0200
RemoteFilesDialog: remember last used service
Change-Id: I494b1d43d28d8e6c37ce9d391b37580be6a9be31
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index 533940d..5ea0658 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -225,6 +225,13 @@ void RemoteFilesDialog::dispose()
{
m_pFileView-SetSelectHdl( Link() );
+std::shared_ptr comphelper::ConfigurationChanges batch(
comphelper::ConfigurationChanges::create( m_context ) );
+
+Sequence OUString lastService( 1 );
+lastService[0] = m_sLastServiceUrl;
+
+officecfg::Office::Common::Misc::FilePickerLastService::set( lastService,
batch );
+
if( m_bIsUpdated )
{
Sequence OUString placesUrlsList( m_aServices.size() );
@@ -238,12 +245,12 @@ void RemoteFilesDialog::dispose()
++i;
}
-std::shared_ptr comphelper::ConfigurationChanges batch(
comphelper::ConfigurationChanges::create( m_context ) );
officecfg::Office::Common::Misc::FilePickerPlacesUrls::set(
placesUrlsList, batch );
officecfg::Office::Common::Misc::FilePickerPlacesNames::set(
placesNamesList, batch );
-batch-commit();
}
+batch-commit();
+
m_pContainer.disposeAndClear(); // container must be first!
m_pTreeView.disposeAndClear();
m_pFileView.disposeAndClear();
@@ -315,6 +322,13 @@ void RemoteFilesDialog::FillServicesListbox()
Sequence OUString placesUrlsList(
officecfg::Office::Common::Misc::FilePickerPlacesUrls::get( m_context ) );
Sequence OUString placesNamesList(
officecfg::Office::Common::Misc::FilePickerPlacesNames::get( m_context ) );
+unsigned int nPos = 0;
+unsigned int i = 0;
+Sequence OUString lastService(
officecfg::Office::Common::Misc::FilePickerLastService::get( m_context ) );
+
+if( lastService.getLength() 0 )
+m_sLastServiceUrl = lastService[0];
+
for( sal_Int32 nPlace = 0; nPlace placesUrlsList.getLength() nPlace
placesNamesList.getLength(); ++nPlace )
{
ServicePtr pService( new Place( placesNamesList[nPlace],
placesUrlsList[nPlace], true ) );
@@ -328,12 +342,19 @@ void RemoteFilesDialog::FillServicesListbox()
if( !sPrefix.isEmpty() )
sPrefix += : ;
+if( placesUrlsList[nPlace] == m_sLastServiceUrl )
+nPos = i;
+
m_pServices_lb-InsertEntry( sPrefix + placesNamesList[nPlace] );
+
+i++;
}
}
if( m_pServices_lb-GetEntryCount() 0 )
-m_pServices_lb-SelectEntryPos( 0 );
+{
+m_pServices_lb-SelectEntryPos( nPos );
+}
EnableControls();
}
@@ -507,6 +528,8 @@ IMPL_LINK_NOARG ( RemoteFilesDialog, SelectServiceHdl )
m_pTreeView-Expand( pRoot );
m_pName_ed-GrabFocus();
+
+m_sLastServiceUrl = sURL;
}
}
diff --git a/fpicker/source/office/RemoteFilesDialog.hxx
b/fpicker/source/office/RemoteFilesDialog.hxx
index 3462305..05f9ca1 100644
--- a/fpicker/source/office/RemoteFilesDialog.hxx
+++ b/fpicker/source/office/RemoteFilesDialog.hxx
@@ -114,6 +114,7 @@ private:
OUString m_sPath;
OUString m_sStdDir;
+OUString m_sLastServiceUrl;
unsigned int m_nCurrentFilter;
::com::sun::star::uno::Sequence OUString m_aBlackList;
diff --git a/officecfg/registry/data/org/openoffice/Office/Common.xcu
b/officecfg/registry/data/org/openoffice/Office/Common.xcu
index 6394722..8940778 100644
--- a/officecfg/registry/data/org/openoffice/Office/Common.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Common.xcu
@@ -568,6 +568,9 @@
prop oor:name=FilePickerPlacesNames
value/
/prop
+prop oor:name=FilePickerLastService
+ value/
+/prop
prop oor:name=CmisServersUrls
value
ithttps://www.googleapis.com/drive/v2/it
diff --git a/officecfg/registry/data/org/openoffice/Setup.xcu
b/officecfg/registry/data/org/openoffice/Setup.xcu
index 9b17125..2a77ab1 100644
--- a/officecfg/registry/data/org/openoffice/Setup.xcu
+++ b/officecfg/registry/data/org/openoffice/Setup.xcu
@@ -898,6 +898,7 @@
it/org.openoffice.Office.Common/Misc/UseSystemPrintDialog/it
it/org.openoffice.Office.Common/Misc/FilePickerPlacesNames/it
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - include/vcl
include/vcl/printerinfomanager.hxx |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit 95898b6bd3ae0fc2b4c0df0a59fa07041f4940a4
Author: Caolán McNamara caol...@redhat.com
Date: Sun Jul 12 15:56:40 2015 +0100
coverity#1311653 Uninitialized scalar field
Change-Id: Ib1cc81ce30752a3794a009ee8cae826abdb9fc03
(cherry picked from commit ca1a5ebf49d377d93c6c8c57a14d64460babf176)
Reviewed-on: https://gerrit.libreoffice.org/17001
Reviewed-by: David Tardon dtar...@redhat.com
Reviewed-by: Eike Rathke er...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/include/vcl/printerinfomanager.hxx
b/include/vcl/printerinfomanager.hxx
index 52245c4..3f1debf 100644
--- a/include/vcl/printerinfomanager.hxx
+++ b/include/vcl/printerinfomanager.hxx
@@ -52,8 +52,9 @@ struct PrinterInfo : JobData
OUString m_aFeatures;
bool m_bPapersizeFromSetup;
-PrinterInfo() :
-JobData()
+PrinterInfo()
+: JobData()
+, m_bPapersizeFromSetup(false)
{}
};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf |binary
vcl/source/filter/wmf/enhwmf.cxx |4 ++--
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit ae58f6fcb0cc9eb83781602aabbf0a35add26f42
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 09:45:55 2015 +0100
emf: fix another hang
Change-Id: I971ba5f422827f3b8fcdb86c447fc48415225eca
(cherry picked from commit fe20502c86ef6156a54bb37ba2560c8b64d129a4)
Reviewed-on: https://gerrit.libreoffice.org/16998
Reviewed-by: David Tardon dtar...@redhat.com
Reviewed-by: Eike Rathke er...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf
new file mode 100644
index 000..e3baf3b
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf differ
diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx
index 741ec15..dcd802c 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -1728,9 +1728,9 @@ bool EnhWMFReader::ReadHeader()
pWMF-ReadInt32(nRecordCount);
-if (nRecordCount == 0)
+if (nRecordCount = 0)
{
-SAL_WARN(vcl.emf, EMF\t\tEMF Header object shows record counter as
0! This shouldn't
+SAL_WARN(vcl.emf, EMF\t\tEMF Header object shows record counter as
= 0! This shouldn't
be possible... indicator of possible file
corruption?);
return false;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-1.emf |binary
vcl/source/filter/wmf/enhwmf.cxx |2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
New commits:
commit fdea2a41da361ee160aaeac1af47eec4499b
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 09:10:12 2015 +0100
emf: fix hang
Change-Id: I2410308ecccb8c5318a718bafadc7b40a98cb82b
(cherry picked from commit 8695633023cc321a095753db98bdc69d2aeee058)
Reviewed-on: https://gerrit.libreoffice.org/16976
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com
(cherry picked from commit bcf9f7c7e06ee97106b5a555a97599e6b0ed1c13)
Reviewed-on: https://gerrit.libreoffice.org/16992
Reviewed-by: Eike Rathke er...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-1.emf
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-1.emf
new file mode 100644
index 000..634fccd
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-1.emf differ
diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx
index 345d06b..741ec15 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -663,7 +663,7 @@ bool EnhWMFReader::ReadEnhWMF()
SAL_INFO(vcl.emf, \tGDI comment, length: length);
-if( pWMF-good() length = 4 ) {
+if( pWMF-good() length = 4 length = pWMF-remainingSize()
) {
sal_uInt32 id;
pWMF-ReadUInt32( id );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf |binary
vcl/source/filter/wmf/winwmf.cxx | 10 +++---
2 files changed, 7 insertions(+), 3 deletions(-)
New commits:
commit dcc1159192182f76891625c96b1edc601d4193f8
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jul 10 08:40:42 2015 +0100
avoid endless loop with busted wmf
Change-Id: I104de360f2e861e959ad2dad434a768440877f6f
(cherry picked from commit fd2749455fe25e24b448a44f9ada6113e5ac0d13)
Reviewed-on: https://gerrit.libreoffice.org/16914
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
(cherry picked from commit 55486cf648813bc0c46eaf0df2f0544a5d57ccb2)
Reviewed-on: https://gerrit.libreoffice.org/16993
Reviewed-by: David Tardon dtar...@redhat.com
Reviewed-by: Eike Rathke er...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf
new file mode 100644
index 000..7ba05cb
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf differ
diff --git a/vcl/source/filter/wmf/winwmf.cxx b/vcl/source/filter/wmf/winwmf.cxx
index c7d1315..5e25949 100644
--- a/vcl/source/filter/wmf/winwmf.cxx
+++ b/vcl/source/filter/wmf/winwmf.cxx
@@ -1394,9 +1394,13 @@ void WMFReader::ReadWMF()
}
}
}
-nPos += nRecSize * 2;
-if ( nPos = nEndPos )
-pWMF-Seek( nPos );
+const sal_uInt32 nAvailableBytes = nEndPos - nPos;
+const sal_uInt32 nMaxPossibleRecordSize = nAvailableBytes/2;
+if (nRecSize = nMaxPossibleRecordSize)
+{
+nPos += nRecSize * 2;
+pWMF-Seek(nPos);
+}
else
pWMF-SetError( SVSTREAM_FILEFORMAT_ERROR );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-3.emf |binary
vcl/source/filter/wmf/enhwmf.cxx |4 +++-
2 files changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 5b8ec42cd7d09291c0662aacbaaa507eafda1ea4
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 20:44:16 2015 +0100
fix a third emf crash
Change-Id: I3b5d0daf05e3272d2afa0da84ff0b1f8d5c965a4
(cherry picked from commit 173fd90387e8bb7f33c2608628f12c7f772f0277)
Reviewed-on: https://gerrit.libreoffice.org/17023
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-3.emf
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-3.emf
new file mode 100644
index 000..92da5f0
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-3.emf differ
diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx
index 553f871..63e4104 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -1425,7 +1425,9 @@ bool EnhWMFReader::ReadEnhWMF()
DBG_ASSERT( ( nOptions ( ETO_PDY | ETO_GLYPH_INDEX ) )
== 0, SJ: ETO_PDY || ETO_GLYPH_INDEX in EMF );
Point aPos( ptlReferenceX, ptlReferenceY );
-if ( nLen 0 nLen static_castsal_Int32(
SAL_MAX_UINT32 / sizeof(sal_Int32) ) )
+bool bLenSane = nLen 0 nLen static_castsal_Int32(
SAL_MAX_UINT32 / sizeof(sal_Int32) );
+bool bOffStringSane = nOffString = nEndPos - nCurPos;
+if (bLenSane bOffStringSane)
{
if ( offDx (( nCurPos + offDx + nLen * 4 ) =
nNextPos ) )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-3.emf |binary
vcl/source/filter/wmf/enhwmf.cxx |4 +++-
2 files changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 729ba6999667fea9bc4ee6966f63368726a290f5
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 20:44:16 2015 +0100
fix a third emf crash
Change-Id: I3b5d0daf05e3272d2afa0da84ff0b1f8d5c965a4
(cherry picked from commit 173fd90387e8bb7f33c2608628f12c7f772f0277)
Reviewed-on: https://gerrit.libreoffice.org/17022
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-3.emf
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-3.emf
new file mode 100644
index 000..92da5f0
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-3.emf differ
diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx
index dcd802c..c20ab5f 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -1441,7 +1441,9 @@ bool EnhWMFReader::ReadEnhWMF()
DBG_ASSERT( ( nOptions ( ETO_PDY | ETO_GLYPH_INDEX ) )
== 0, SJ: ETO_PDY || ETO_GLYPH_INDEX in EMF );
Point aPos( ptlReferenceX, ptlReferenceY );
-if ( nLen 0 nLen static_castsal_Int32(
SAL_MAX_UINT32 / sizeof(sal_Int32) ) )
+bool bLenSane = nLen 0 nLen static_castsal_Int32(
SAL_MAX_UINT32 / sizeof(sal_Int32) );
+bool bOffStringSane = nOffString = nEndPos - nCurPos;
+if (bLenSane bOffStringSane)
{
if ( offDx (( nCurPos + offDx + nLen * 4 ) =
nNextPos ) )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92681] Menu list doesn't always close
https://bugs.documentfoundation.org/show_bug.cgi?id=92681 sworddrag...@aol.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from sworddrag...@aol.com --- I had tested this with the version from the Ubuntu 15.10 dev repository. But there is already a newer version available (4.4.4.3) where this issue does still exists. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-5-0' - sl_SI/description.xml sl_SI/README_th_sl_SI.txt sl_SI/th_sl_SI_v2.dat
sl_SI/README_th_sl_SI.txt |4 sl_SI/description.xml |4 sl_SI/th_sl_SI_v2.dat | 1954 +++--- 3 files changed, 1523 insertions(+), 439 deletions(-) New commits: commit bf7a33714170fc040fcfa0b0f0770cf217e5b79c Author: Andras Timar andras.ti...@collabora.com Date: Mon Jul 13 23:55:57 2015 +0200 Updated Slovenian thesaurus Change-Id: If822610ad6d9eca02629959cf8040fe1680f8140 (cherry picked from commit a06da898df0371577c5c2466480f6c807e6c211f) Reviewed-on: https://gerrit.libreoffice.org/17026 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/sl_SI/README_th_sl_SI.txt b/sl_SI/README_th_sl_SI.txt index a90862c..396fef0 100644 --- a/sl_SI/README_th_sl_SI.txt +++ b/sl_SI/README_th_sl_SI.txt @@ -2,7 +2,7 @@ The Slovenian thesaurus is developed as a part of project/ Slovenski tezaver nastaja v okviru projekta: OdprtiTezaver (www.tezaver.si) This dictionary pack includes version/Paket vsebuje razliÄico: - 1.7.17000 + 1.7.17500 Thesaurus managed and edited by/Tezaver pripravlja in ureja: Martin Srebotnjak (miles at filmsi net) Thesaurus data licensed under both/Podatki tezavra so izdani pod licencama: @@ -18,7 +18,7 @@ Bug report/O napakah poroÄajte: http://external.openoffice.org/ form data: Product Name: Slovenian thesaurus -Product Version: 1.7.17000 +Product Version: 1.7.17500 Vendor or Owner Name: Martin Srebotnjak Vendor or Owner Contact: mi...@filmsi.net OpenOffice.org Contact: fil...@openoffice.org diff --git a/sl_SI/description.xml b/sl_SI/description.xml index 07b658b..85cab19 100644 --- a/sl_SI/description.xml +++ b/sl_SI/description.xml @@ -1,6 +1,6 @@ ?xml version=1.0 encoding=UTF-8? description xmlns=http://openoffice.org/extensions/description/2006; xmlns:d=http://openoffice.org/extensions/description/2006; xmlns:xlink=http://www.w3.org/1999/xlink; -version value=2014.12.29 / +version value=2015.07.13 / identifier value=libreoffice.sl.hunspell.dictionaries / display-name name lang=en-USSlovenian spelling dictionary, hyphenation rules, and thesaurus/name @@ -10,6 +10,6 @@ OpenOffice.org-minimal-version value=3.0 d:name=OpenOffice.org 3.0 / /dependencies publisher -name xlink:href=http://sl.libreoffice.org/slovenjenje-2/jezikovne-razsiritve/; lang=sl-SIsl.libreoffice.org/name +name xlink:href=http://sl.libreoffice.org/skupnost/slovenjenje/jezikovne-razsiritve/; lang=sl-SIsl.libreoffice.org/name /publisher /description diff --git a/sl_SI/th_sl_SI_v2.dat b/sl_SI/th_sl_SI_v2.dat index f1a6a7c..2971d0f 100644 --- a/sl_SI/th_sl_SI_v2.dat +++ b/sl_SI/th_sl_SI_v2.dat @@ -37,7 +37,8 @@ ISO8859-2 (sam.)|prvenstvo ¹ank|1 (sam.)|¹ank (pogovorno)|toèilna miza|toèilni pult -¹ansa|1 +¹ansa|2 +(sam.)|¹ansa (pogovorno)|izgled|mo¾nost|mogoèost|obet|upanje (sam.)|¹ansa (pogovorno)|prilika|prilo¾nost ¹anson|1 (sam.)|chanson|pesem|popevka @@ -47,12 +48,14 @@ ISO8859-2 (sam.)|¹antavost (slab¹alno)|¹epavost|kruljavost (ekspresivno) ¹apa|1 (sam.)|taca +¹ar¾a|1 +(sam.)|¹ar¾a (zastarelo)|èin ¹ar¾er|1 (sam.)|okvir ¹ariti|1 (gl.)|brèkati|brkljariti (ekspresivno)|brkljati (pogovorno)|brskati|stikati ¹arm|1 -(sam.)|dra¾|dra¾est|mik|mikavnost|oèarljivost|privlaènost +(sam.)|dra¾|dra¾est|ljubkost|mik|mikavnost|oèarljivost|privlaènost ¹arnir|1 (sam.)|zapirnica ¹arovit|1 @@ -65,6 +68,8 @@ ISO8859-2 (gl.)|¹u¹njati ¹èavje|1 (sam.)|¹avje +¹èebljati|1 +(gl.)|èebljati ¹èegetavèek|1 (sam.)|klitoris ¹èetka|1 @@ -84,7 +89,7 @@ ISO8859-2 ¹enk|1 (sam.)|¹enk (pogovorno)|dar|darilo|naklonilo (zastarelo)|naklonitev (zastarelo)|podarek (zastarelo)|poklon (zastarelo)|poklonilo (zastarelo)|poklonitev (zastarelo)|poklonstvo (zastarelo)|prezent (zastarelo)|vezilo (zastarelo) ¹ent|1 -(sam.)|¹ment|hudiè|hudiman|hudimar|hudir|parkelj|peklen¹èek|rogaè|satan|sku¹njavec|vrag|vragec|vranè|zlobec|zlodej +(sam.)|¹ment|hudiè|hudiman|hudimar|hudir|hudnik|parkelj|peklen¹èek|rogaè|satan|sku¹njavec|vrag|vragec|vranè|zlobec|zlodej ¹entjan¾evka|1 (sam.)|Hypericum perforatum (strokovno)|krènica|krvavec ¹epast|1 @@ -143,13 +148,16 @@ ISO8859-2 (sam.)|¹pièenje (pogovorno)|ostrenje ¹initi|1 (gl.)|¹vigniti|blisniti (ekspresivno) +¹ipkova u¹ica|1 +(sam.)|Macrosiphon rosae (strokovno) ¹iptarski|1 (prid.)|albanski ¹iren|1 (prid.)|¹iro¹iren (ekspresivno)|obse¾en|prostran ¹irjava|1 (sam.)|prostranstvo|vse¹ir -¹irjenje|1 +¹irjenje|2 +(sam.)|dilatacija|raz¹irjanje (sam.)|iradiacija|raz¹irjanje ¹iro¹iren|1 (prid.)|¹iren|¹iro¹iren (ekspresivno)|obse¾en|prostran @@ -172,7 +180,7 @@ ISO8859-2 ¹irokoustnost|1 (sam.)|¹irokoustnost (ekspresivno)|bahavost|hvalisavost|razustnost ¹kandalozen|1 -(prid.)|¹kandalozen (ekspresivno)|grozen (ekspresivno)|nekvaliteten|neprebavljiv (ekspresivno)|neu¾iten (ekspresivno)|neznosen|obupen|po¹asten (ekspresivno)|slab|stra¹en (ekspresivno) +(prid.)|¹kandalozen
[Libreoffice-bugs] [Bug 92724] LibreOffice does not render word document correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=92724 thej...@protonmail.ch changed: What|Removed |Added Summary|LibreOffice does not render |LibreOffice does not render |document correctly |word document correctly -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47832] FILESAVE: Pictures on buttons, created in forms, gone after reopening form
https://bugs.documentfoundation.org/show_bug.cgi?id=47832 --- Comment #38 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Zolnai Tamás committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=70f152983f3425a77df2f65b4798417640d47b76 tdf#47832: Pictures on buttons, created in forms, gone after reopening form It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47832] FILESAVE: Pictures on buttons, created in forms, gone after reopening form
https://bugs.documentfoundation.org/show_bug.cgi?id=47832 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|bibisected |bibisected target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92471] FILESAVE: New DOCX export of text with highlighting works not for all colors
https://bugs.documentfoundation.org/show_bug.cgi?id=92471 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92471] FILESAVE: New DOCX export of text with highlighting works not for all colors
https://bugs.documentfoundation.org/show_bug.cgi?id=92471 --- Comment #7 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Zolnai Tamás committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=16f9cf57e20ffbe34cb184f694f465708250a578 tdf#92471: Improve color conversion to MSO highlighting It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92724] LibreOffice does not render word document correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=92724 --- Comment #1 from thej...@protonmail.ch --- When I delete the first section break in Word, LibreOffice shows the document correctly! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90502] CRASH - failed assertion in unittest sw_globalfilter in master build OSX (ImplLogicToPixel)
https://bugs.documentfoundation.org/show_bug.cgi?id=90502 --- Comment #19 from Julien Nabet serval2...@yahoo.fr --- Badfully, it still fails with same message. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92726] New: Presentation Minimizer does not preserve animations when making static replacements for OLE objects
https://bugs.documentfoundation.org/show_bug.cgi?id=92726 Bug ID: 92726 Summary: Presentation Minimizer does not preserve animations when making static replacements for OLE objects Product: LibreOffice Version: 4.4.4.3 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: shimi.c...@gmail.com Created attachment 117226 -- https://bugs.documentfoundation.org/attachment.cgi?id=117226action=edit When minimized the appear animation for the formula is gone Build ID: 4.4.4.3 Arch Linux build-2 When using the Presentation Minimizer and the default setting for making static replacement for OLE objects, the animations of the OLE objects disappear. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Gerrit: Reliability and fidelity of verification results
On Tue, Jul 14, 2015 at 3:49 AM, David Tardon dtar...@redhat.com wrote: Hi, On Mon, Jul 13, 2015 at 04:51:01PM -0500, Norbert Thiebaud wrote: Do not get me wrong. I applaud the effort to get rid of boost if we can.. that is a big and expensive dep. Except that I doubt we'll ever be able to do that. boost is used not only by libreoffice, but also by many bundled libs. And there is a lot of it used that'll hardly ever have an equivalent in the std. library. Then that make the notion of dropping maverick only to be able to go from boost::bind to std:: even less appealing. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
About fix for tdf#82744: WebDAV LOCK is released when document is saved
Hi all, while implementing a fix for: https://bugs.documentfoundation.org/show_bug.cgi?id=82744 using ideas from a similar patch I proposed in AOO: https://bz.apache.org/ooo/show_bug.cgi?id=126305 I came across a comment on top of method SfxMedium::ShowLockedDocumentDialog. The comment states that lock/unlock should be put in the relevant ucb component. Unfortunately I started implementing the fix managing the WebDAV lock/unlock from the framework instead. Implementing the same thing directly in ucb/webdav appears difficult, because I didn't find there anything that has a lifetime usable for lock/unlock. So, given the two choices: 1) do I continue to implement the fix in framework, hopefully finishing it in few days, or 2) do I start studying what to rewrite in webdav ucb component in order to support the lock/unlock directly there, in this case I have no idea what to to ATM; it can take some time to work out a suitable solution. What would be the best course of action? -- Kind Regards, Giuseppe Castagno aka beppec56 Acca Esse http://www.acca-esse.eu giuseppe.castagno at acca-esse.eu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: forms/source
forms/source/component/clickableimage.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 4c5498ec5ee478e27fd62bdcf9de1208c692422c
Author: Noel Grandin n...@peralex.com
Date: Tue Jul 14 12:37:13 2015 +0200
fix windows build
Change-Id: I505b7b0e6bf86093fbed1aa7e28b710e12116e6e
diff --git a/forms/source/component/clickableimage.cxx
b/forms/source/component/clickableimage.cxx
index 77c2410..bef40ab 100644
--- a/forms/source/component/clickableimage.cxx
+++ b/forms/source/component/clickableimage.cxx
@@ -866,7 +866,7 @@ namespace frm
}
else
{
-m_xGraphicObject = GraphicObject::create( m_xContext );
+m_xGraphicObject = css::graphic::GraphicObject::create( m_xContext
);
m_xGraphicObject-setGraphic( xGraphic );
}
return 1L;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91497] When column is too narrow - autofit does not expand the column.
https://bugs.documentfoundation.org/show_bug.cgi?id=91497 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|5.0.0.0.beta1 |Inherited From OOo Ever confirmed|0 |1 Severity|normal |minor --- Comment #9 from Beluga todven...@suomi24.fi --- (In reply to Edmund Laugasson from comment #8) Created attachment 117214 [details] Bug still exist - autofit columns does not work Ok, so I didn't understand that the table needs to be placed to the right side of the page. Now I could reproduce. Note: In 5.1 there is no Table - Autofit menu item anymore! So with 5.1 I used the toolbar icon https://help.libreoffice.org/Writer/Optimal_Width Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64) Build ID: 8de7d44f96252e97e224d42466698114370dbaa3 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-13_21:43:47 Locale: fi-FI (fi_FI) Versio: 5.0.0.3 Käännöksen ID: f79b5ba13f5e6cbad23f8038060e556217e66632 Maa-asetus: fi-FI (fi_FI) Ubuntu 15.04 64-bit OpenOffice.org 3.3.0 OOO330m20 (Build:9567) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: wizards/com
wizards/com/sun/star/wizards/web/WWD_Events.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 2f0d1a23759c1b973593bfba642d01fb3df3c269 Author: Julien Nabet serval2...@yahoo.fr Date: Sat Jul 4 16:20:32 2015 +0200 tdf#92404: Web Wizard - no result / crash Fixes Traceback (most recent call last): File /home/laci/m/bibisect/lo-linux-dbgutil-daily/opt/program/wizards/web/WWD_Events.py, line 249, in addDocument oLoadDocs = self.LoadDocs(self.xMSF, self.xUnoDialog, files, self) TypeError: __init__() missing 1 required positional argument: 'parent_' and: Traceback (most recent call last): File /home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py, line 252, in addDocument oLoadDocs.loadDocuments() File /home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py, line 934, in loadDocuments doc.cp_URL = FileAccess.connectURLs(files[0], self.files[i]) NameError: global name 'files' is not defined Change-Id: I737117a6981e541f12453bb9d9b2680f5fb79142 Reviewed-on: https://gerrit.libreoffice.org/16756 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/wizards/com/sun/star/wizards/web/WWD_Events.py b/wizards/com/sun/star/wizards/web/WWD_Events.py index fbe439a..eaca38d 100644 --- a/wizards/com/sun/star/wizards/web/WWD_Events.py +++ b/wizards/com/sun/star/wizards/web/WWD_Events.py @@ -246,7 +246,7 @@ class WWD_Events(WWD_Startup): sd = self.getStatusDialog() sd.setLabel(self.resources.resValidatingDocuments) sd.execute(self, task, self.resources.prodName) -oLoadDocs = self.LoadDocs(self.xMSF, self.xUnoDialog, files, self) +oLoadDocs = self.LoadDocs(self.xMSF, self.xUnoDialog, files, task, self) oLoadDocs.loadDocuments() task.removeTaskListener(sd) else: @@ -926,7 +926,7 @@ class WWD_Events(WWD_Startup): if start == 0: doc.cp_URL = self.files[i] else: -doc.cp_URL = FileAccess.connectURLs(files[0], self.files[i]) +doc.cp_URL = FileAccess.connectURLs(self.files[0], self.files[i]) ''' so - i check each document and if it is ok I add it. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 59284] [META] Cell border related issues (Make it easier to apply borders to cells)
https://bugs.documentfoundation.org/show_bug.cgi?id=59284 Nis Jørgensen n...@superlativ.dk changed: What|Removed |Added See Also|https://bugs.freedesktop.or | |g/show_bug.cgi?id=38304 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40147] Bad Performance of Print Preview in Print Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=40147 famo richard.l...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #17 from famo richard.l...@gmail.com --- This bug is indeed fixed. Horaay! Marking as RESOLVED FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-2.gif |binary vcl/source/filter/igif/decode.cxx |3 +++ 2 files changed, 3 insertions(+) New commits: commit 11fb5b5cce6ebb857bd6ede39815b37256db3e1f Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 12 10:56:48 2015 +0100 fix another gif import crash Change-Id: I0ffa569e0c4240e11184df7dd56b95d87a12425d (cherry picked from commit ee35b72064d8d1333709b102b051360018f8044b) Reviewed-on: https://gerrit.libreoffice.org/17002 Reviewed-by: David Tardon dtar...@redhat.com Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-2.gif b/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-2.gif new file mode 100644 index 000..b7265f8 Binary files /dev/null and b/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-2.gif differ diff --git a/vcl/source/filter/igif/decode.cxx b/vcl/source/filter/igif/decode.cxx index 1b18f5e..2b445e9 100644 --- a/vcl/source/filter/igif/decode.cxx +++ b/vcl/source/filter/igif/decode.cxx @@ -193,6 +193,9 @@ bool GIFLZWDecompressor::ProcessOneCode() nOldCode = nCode; +if (nCode 4096) +return false; + // write character(/-sequence) of code nCode in the output buffer: pE = pTable + nCode; do ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - wizards/com
wizards/com/sun/star/wizards/web/WWD_Events.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit bdc50ac10d5987b7d0545d765f4097c9246a2dc0 Author: Julien Nabet serval2...@yahoo.fr Date: Sat Jul 4 16:20:32 2015 +0200 tdf#92404: Web Wizard - no result / crash Fixes Traceback (most recent call last): File /home/laci/m/bibisect/lo-linux-dbgutil-daily/opt/program/wizards/web/WWD_Events.py, line 249, in addDocument oLoadDocs = self.LoadDocs(self.xMSF, self.xUnoDialog, files, self) TypeError: __init__() missing 1 required positional argument: 'parent_' and: Traceback (most recent call last): File /home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py, line 252, in addDocument oLoadDocs.loadDocuments() File /home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py, line 934, in loadDocuments doc.cp_URL = FileAccess.connectURLs(files[0], self.files[i]) NameError: global name 'files' is not defined Change-Id: I737117a6981e541f12453bb9d9b2680f5fb79142 Reviewed-on: https://gerrit.libreoffice.org/16756 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com (cherry picked from commit 2f0d1a23759c1b973593bfba642d01fb3df3c269) Reviewed-on: https://gerrit.libreoffice.org/17035 diff --git a/wizards/com/sun/star/wizards/web/WWD_Events.py b/wizards/com/sun/star/wizards/web/WWD_Events.py index 72b393e..4f2208c 100644 --- a/wizards/com/sun/star/wizards/web/WWD_Events.py +++ b/wizards/com/sun/star/wizards/web/WWD_Events.py @@ -246,7 +246,7 @@ class WWD_Events(WWD_Startup): sd = self.getStatusDialog() sd.setLabel(self.resources.resValidatingDocuments) sd.execute(self, task, self.resources.prodName) -oLoadDocs = self.LoadDocs(self.xMSF, self.xUnoDialog, files, self) +oLoadDocs = self.LoadDocs(self.xMSF, self.xUnoDialog, files, task, self) oLoadDocs.loadDocuments() task.removeTaskListener(sd) else: @@ -926,7 +926,7 @@ class WWD_Events(WWD_Startup): if start == 0: doc.cp_URL = self.files[i] else: -doc.cp_URL = FileAccess.connectURLs(files[0], self.files[i]) +doc.cp_URL = FileAccess.connectURLs(self.files[0], self.files[i]) ''' so - i check each document and if it is ok I add it. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - wizards/com
wizards/com/sun/star/wizards/web/WWD_Events.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 4f0f8a5c6860bde571ab8babc6559cfd638d6c3d Author: Julien Nabet serval2...@yahoo.fr Date: Sat Jul 4 16:20:32 2015 +0200 tdf#92404: Web Wizard - no result / crash Fixes Traceback (most recent call last): File /home/laci/m/bibisect/lo-linux-dbgutil-daily/opt/program/wizards/web/WWD_Events.py, line 249, in addDocument oLoadDocs = self.LoadDocs(self.xMSF, self.xUnoDialog, files, self) TypeError: __init__() missing 1 required positional argument: 'parent_' and: Traceback (most recent call last): File /home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py, line 252, in addDocument oLoadDocs.loadDocuments() File /home/julien/compile-libreoffice/libreoffice/instdir/program/wizards/web/WWD_Events.py, line 934, in loadDocuments doc.cp_URL = FileAccess.connectURLs(files[0], self.files[i]) NameError: global name 'files' is not defined Change-Id: I737117a6981e541f12453bb9d9b2680f5fb79142 Reviewed-on: https://gerrit.libreoffice.org/16756 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com (cherry picked from commit 2f0d1a23759c1b973593bfba642d01fb3df3c269) Reviewed-on: https://gerrit.libreoffice.org/17034 diff --git a/wizards/com/sun/star/wizards/web/WWD_Events.py b/wizards/com/sun/star/wizards/web/WWD_Events.py index 72b393e..4f2208c 100644 --- a/wizards/com/sun/star/wizards/web/WWD_Events.py +++ b/wizards/com/sun/star/wizards/web/WWD_Events.py @@ -246,7 +246,7 @@ class WWD_Events(WWD_Startup): sd = self.getStatusDialog() sd.setLabel(self.resources.resValidatingDocuments) sd.execute(self, task, self.resources.prodName) -oLoadDocs = self.LoadDocs(self.xMSF, self.xUnoDialog, files, self) +oLoadDocs = self.LoadDocs(self.xMSF, self.xUnoDialog, files, task, self) oLoadDocs.loadDocuments() task.removeTaskListener(sd) else: @@ -926,7 +926,7 @@ class WWD_Events(WWD_Startup): if start == 0: doc.cp_URL = self.files[i] else: -doc.cp_URL = FileAccess.connectURLs(files[0], self.files[i]) +doc.cp_URL = FileAccess.connectURLs(self.files[0], self.files[i]) ''' so - i check each document and if it is ok I add it. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92580] Crash: when creating a table via wizard, go back then forth in a step
https://bugs.documentfoundation.org/show_bug.cgi?id=92580 --- Comment #7 from Michael Meeks michael.me...@collabora.com --- Unfortunately the valgrind log is not so useful: Rerun with --error-limit=no to disable this cutoff. Your AMD openCL drivers are creating a -large- amount of false positives unfortunately that swamps any real signal. Would love to re-test (and re-valgrind if it recurrs) with the latest master. Thanks ! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40147] Bad Performance of Print Preview in Print Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=40147 --- Comment #19 from Cor Nouws c...@nouenoff.nl --- (In reply to famo from comment #17) This bug is indeed fixed. Horaay! Thanks for checking and confirming! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92724] LibreOffice does not render word document correctly, 4 pages instead of 3 as in word
https://bugs.documentfoundation.org/show_bug.cgi?id=92724 --- Comment #4 from thej...@protonmail.ch --- Created attachment 117228 -- https://bugs.documentfoundation.org/attachment.cgi?id=117228action=edit patched document.xml -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92724] LibreOffice does not render word document correctly, 4 pages instead of 3 as in word
https://bugs.documentfoundation.org/show_bug.cgi?id=92724 --- Comment #5 from thej...@protonmail.ch --- Created attachment 117229 -- https://bugs.documentfoundation.org/attachment.cgi?id=117229action=edit Patched Word -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92729] New: FILESAVE: Calc crashes when saving large files
https://bugs.documentfoundation.org/show_bug.cgi?id=92729 Bug ID: 92729 Summary: FILESAVE: Calc crashes when saving large files Product: LibreOffice Version: 4.4.4.3 release Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gbech...@comcast.net Calc crashes when saving a large ODS file. This problem started immediately after installing 4.4.4.3. Versions prior to this work fine. This bug sounds very similar to bug 89882 (https://bugs.documentfoundation.org//show_bug.cgi?id=89882). I have the file that causes the problem, however it is filled with private and proprietary information and I can't provide it under the licensing terms. I'd be happy to help find an alternative example file, if the libreoffice team can help find an alternative. I've been using Libreoffice for many years. This particular spreadsheet is for my daily hours and it is very important to my daily time reporting. Would very much appreciate a fix. Thanks, Gordon -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91310] [META] Fallout from VclPtr merge
https://bugs.documentfoundation.org/show_bug.cgi?id=91310 Bug 91310 depends on bug 92706, which changed state. Bug 92706 Summary: CRASH - when autmatically launching table creation wizard after registration of database https://bugs.documentfoundation.org/show_bug.cgi?id=92706 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92706] CRASH - when autmatically launching table creation wizard after registration of database
https://bugs.documentfoundation.org/show_bug.cgi?id=92706 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Blocks||91310 Resolution|--- |FIXED --- Comment #4 from Michael Meeks michael.me...@collabora.com --- Pushed a fix to Jenkins for master, -5-0 and -5-0-0 - thanks ! =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 8d/0c956faa72044280cd9088928cea548a7776e5
8d/0c956faa72044280cd9088928cea548a7776e5 |1 + 1 file changed, 1 insertion(+) New commits: commit 8378f4637d5b550c7fa3710a120cb11f6ba9a65a Author: Caolán McNamara caol...@redhat.com Date: Tue Jul 14 12:44:57 2015 +0100 Notes added by 'git notes add' diff --git a/8d/0c956faa72044280cd9088928cea548a7776e5 b/8d/0c956faa72044280cd9088928cea548a7776e5 new file mode 100644 index 000..8e5c182 --- /dev/null +++ b/8d/0c956faa72044280cd9088928cea548a7776e5 @@ -0,0 +1 @@ +ignore: aoo ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - c6/3d7d7754d7e53f43275763b73f6fc6c6076eea
c6/3d7d7754d7e53f43275763b73f6fc6c6076eea |1 + 1 file changed, 1 insertion(+) New commits: commit 04ca5c27c0d7c5554e153b5920ccd8e8f89147cb Author: Caolán McNamara caol...@redhat.com Date: Tue Jul 14 12:45:41 2015 +0100 Notes added by 'git notes add' diff --git a/c6/3d7d7754d7e53f43275763b73f6fc6c6076eea b/c6/3d7d7754d7e53f43275763b73f6fc6c6076eea new file mode 100644 index 000..8e5c182 --- /dev/null +++ b/c6/3d7d7754d7e53f43275763b73f6fc6c6076eea @@ -0,0 +1 @@ +ignore: aoo ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91770] Crash on closing on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=91770 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 --- Comment #14 from Michael Meeks michael.me...@collabora.com --- No info; - moving back to unconfirmed for now; Jay ? =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - sw/source
sw/source/core/undo/untbl.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit e0cf60a4acfcb7788ebd145a1ddb7354b5d7d39a Author: Michael Stahl mst...@redhat.com Date: Tue Jul 14 14:35:43 2015 +0200 sw: _SaveTable::CreateNew() fix invalid cast ... ... of SwTableFormat to SwTableBoxFormat for the temporary SwTableBox. Change-Id: I74118b1b028bd71561f9afe6acd1cc95991a3761 diff --git a/sw/source/core/undo/untbl.cxx b/sw/source/core/undo/untbl.cxx index 40f9ef9..f1cfb15 100644 --- a/sw/source/core/undo/untbl.cxx +++ b/sw/source/core/undo/untbl.cxx @@ -993,8 +993,9 @@ void _SaveTable::CreateNew( SwTable rTable, bool bCreateFrms, pFormat-SetInCache( false ); } -// SwTableBox must have a format -SwTableBox aParent( static_castSwTableBoxFormat*(pFormat), rTable.GetTabLines().size(), 0 ); +// SwTableBox must have a format - the SwTableBox takes ownership of it +SwTableBoxFormat *const pNewFormat(pFormat-GetDoc()-MakeTableBoxFormat()); +SwTableBox aParent(pNewFormat, rTable.GetTabLines().size(), 0); // fill FrameFormats with defaults (0) pFormat = 0; commit 7132dfe7b5030ef5a27a65e5ceaeca67dac96f13 Author: Michael Stahl mst...@redhat.com Date: Tue Jul 14 14:34:55 2015 +0200 sw: assert _SaveTable::CreateNew() deletes everything in temp box Change-Id: Ib668bb948a2cd557db7b8804f8a81800048f88bd diff --git a/sw/source/core/undo/untbl.cxx b/sw/source/core/undo/untbl.cxx index c2c34a0..40f9ef9 100644 --- a/sw/source/core/undo/untbl.cxx +++ b/sw/source/core/undo/untbl.cxx @@ -1068,6 +1068,7 @@ void _SaveTable::CreateNew( SwTable rTable, bool bCreateFrms, } aParent.GetTabLines().erase( aParent.GetTabLines().begin(), aParent.GetTabLines().begin() + n ); +assert(aParent.GetTabLines().empty()); if( bCreateFrms ) aTmpBox.MakeFrms( rTable ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: About fix for tdf#82744: WebDAV LOCK is released when document is saved
BTW, what does HAVE_FEATURE_MULTIUSER_ENVIRONMENT compile time flag (inside the commit recalled above) mean? The HAVE_FEATURE_* macros are (or should be) documented where defined, in config_host/config_features.h.in. In practice, HAVE_FEATURE_MULTIUSER_ENVIRONMENT currently means anything except Android and iOS. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92728] New: EDITING: Context menu Paste only → Text pastes nothing
https://bugs.documentfoundation.org/show_bug.cgi?id=92728 Bug ID: 92728 Summary: EDITING: Context menu Paste only → Text pastes nothing Product: LibreOffice Version: 4.4.4.3 release Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 25563...@planet.ms In LibreOffice Calc, Version: 4.4.4.3, Build ID: 2c39ebcf046445232b798108aa8a7e7d89552ea8, Locale: en.UTF-8, on OS OS X Yosemite, Version 10.10.4 (14E46), the following unexpected/faulty reproducible behavior occurs: When selecting formatted text in an external source (e.g. from an RTF-formatted TextEdit document), then right-clicking into a Calc cell, selecting Paste only → Text from the context menu, nothing is being pasted into the cell. However, when the alternative action Edit → Paste Special → Unformatted Text is performed the Toolbar menu (or by using the keyboard shortcut, ⌘⇧V), the unformatted contents from the external source is pasted correctly. This may be related to Bug #62196 (EDITING: copy-paste from non-LibO-text-source pastes previous clipboard contents). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40147] Bad Performance of Print Preview in Print Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=40147 Timur gti...@gmail.com changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #18 from Timur gti...@gmail.com --- If a specific commit/fix is not known, then it's not Fixed, but WorksForMe. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: About fix for tdf#82744: WebDAV LOCK is released when document is saved
On 07/14/2015 12:34 PM, Giuseppe Castagno wrote: I came across a comment on top of method SfxMedium::ShowLockedDocumentDialog. The comment states that lock/unlock should be put in the relevant ucb component. You mean the FIXME: ... comment added with http://cgit.freedesktop.org/libreoffice/core/commit/?id=063b32804c58f663e42444f676af1a1e3a1cc2a8 Don't use lock files when sandboxed on OS X? I wouldn't worry too much about it. IIUC, it is concerned with LO's home-grown locking scheme (involving additional .~lock.*# files), which is only marginally related to the question whether to send WebDAV UNLOCK when saving vs. when closing a document. Unfortunately I started implementing the fix managing the WebDAV lock/unlock from the framework instead. You mean, you somehow manage with modifications to the framework code to cause the sending of WebDAV UNLOCK to happen upon closing a document, instead upon saving it? Sounds good then, IMO. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 63955] CRASH on FILEOPEN .odp presentation. Bad allocation - Crash. 100% reproducible.
https://bugs.documentfoundation.org/show_bug.cgi?id=63955 --- Comment #13 from Gerry gerry.trep...@googlemail.com --- Hi Caolán, thanks for looking into the bug and providing a fix. Is there anything that I can assist on this bug (e.g. testing)? I think I'll install an old OpenOffice.org 1.1 to see where this 19 km line comes from in this .sdd file :-) If it is of any help I could prepare a new conversion to .odp or provide a screenshot of that original document. Thanks a lot! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: About fix for tdf#82744: WebDAV LOCK is released when document is saved
Hi Stephan, On 07/14/2015 02:12 PM, Stephan Bergmann wrote: On 07/14/2015 12:34 PM, Giuseppe Castagno wrote: I came across a comment on top of method SfxMedium::ShowLockedDocumentDialog. The comment states that lock/unlock should be put in the relevant ucb component. You mean the FIXME: ... comment added with http://cgit.freedesktop.org/libreoffice/core/commit/?id=063b32804c58f663e42444f676af1a1e3a1cc2a8 Don't use lock files when sandboxed on OS X? I wouldn't worry too much about it. IIUC, it is concerned with LO's home-grown locking scheme (involving additional .~lock.*# files), which is only marginally related to the question whether to send WebDAV UNLOCK when saving vs. when closing a document. exactly that, 3rd hunk of the commit you pointed me to. Unfortunately I started implementing the fix managing the WebDAV lock/unlock from the framework instead. You mean, you somehow manage with modifications to the framework code to cause the sending of WebDAV UNLOCK to happen upon closing a document, instead upon saving it? Sounds good then, IMO. the framework changes I'working on are meant to manage correctly the lock/unlock in WebDAV. ASA I have a working commit, I'll push to gerrit. BTW, what does HAVE_FEATURE_MULTIUSER_ENVIRONMENT compile time flag (inside the commit recalled above) mean? -- Kind Regards, Giuseppe Castagno aka beppec56 Acca Esse http://www.acca-esse.eu giuseppe.castagno at acca-esse.eu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: About fix for tdf#82744: WebDAV LOCK is released when document is saved
Hi Tor, On 07/14/2015 03:13 PM, Tor Lillqvist wrote: BTW, what does HAVE_FEATURE_MULTIUSER_ENVIRONMENT compile time flag (inside the commit recalled above) mean? The HAVE_FEATURE_* macros are (or should be) documented where defined, in config_host/config_features.h.in http://config_features.h.in. In practice, HAVE_FEATURE_MULTIUSER_ENVIRONMENT currently means anything except Android and iOS. thanks, exactly the clarification I needed. -- Kind Regards, Giuseppe Castagno aka beppec56 Acca Esse http://www.acca-esse.eu giuseppe.castagno at acca-esse.eu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 90661] EDITING: Drag from Navigator As Copy or As Link doesn't work starting with Libo 4.4+
https://bugs.documentfoundation.org/show_bug.cgi?id=90661 --- Comment #3 from Beluga todven...@suomi24.fi --- I still get the same results as in my comment 1 Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64) Build ID: 8de7d44f96252e97e224d42466698114370dbaa3 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-13_21:43:47 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91310] [META] Fallout from VclPtr merge
https://bugs.documentfoundation.org/show_bug.cgi?id=91310 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Depends on||92706 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/igif/decode.cxx |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
New commits:
commit 59197f1892777a5629bad210b9ed1071ed550570
Author: Caolán McNamara caol...@redhat.com
Date: Tue Jul 14 12:43:05 2015 +0100
use same limit in ProcessOneCode as AddToTable
Change-Id: Id0345e5d867d18bf7eb341f04086226b7fa79680
diff --git a/vcl/source/filter/igif/decode.cxx
b/vcl/source/filter/igif/decode.cxx
index 2b445e9..0008f63 100644
--- a/vcl/source/filter/igif/decode.cxx
+++ b/vcl/source/filter/igif/decode.cxx
@@ -109,11 +109,9 @@ HPBYTE GIFLZWDecompressor::DecompressBlock( HPBYTE pSrc,
sal_uInt8 cBufSize,
bool GIFLZWDecompressor::AddToTable( sal_uInt16 nPrevCode, sal_uInt16
nCodeFirstData )
{
-GIFLZWTableEntry* pE;
-
if( nTableSize 4096 )
{
-pE = pTable + nTableSize;
+GIFLZWTableEntry* pE = pTable + nTableSize;
pE-pPrev = pTable + nPrevCode;
pE-pFirst = pE-pPrev-pFirst;
GIFLZWTableEntry *pEntry = pTable[nCodeFirstData].pFirst;
@@ -130,7 +128,6 @@ bool GIFLZWDecompressor::AddToTable( sal_uInt16 nPrevCode,
sal_uInt16 nCodeFirst
bool GIFLZWDecompressor::ProcessOneCode()
{
-GIFLZWTableEntry* pE;
sal_uInt16 nCode;
boolbRet = false;
boolbEndOfBlock = false;
@@ -193,11 +190,11 @@ bool GIFLZWDecompressor::ProcessOneCode()
nOldCode = nCode;
-if (nCode 4096)
+if (nCode = 4096)
return false;
// write character(/-sequence) of code nCode in the output buffer:
-pE = pTable + nCode;
+GIFLZWTableEntry* pE = pTable + nCode;
do
{
if (pOutBufData == pOutBuf) //can't go back past start
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
