[jira] [Updated] (OFBIZ-9747) Error while updating Agreement

2017-09-23 Thread Padmavati Rawat (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Padmavati Rawat updated OFBIZ-9747:
---
Attachment: ErroronAgreement.png

> Error while updating Agreement 
> ---
>
> Key: OFBIZ-9747
> URL: https://issues.apache.org/jira/browse/OFBIZ-9747
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/updateAgreement
>Reporter: Padmavati Rawat
> Attachments: ErroronAgreement.png
>
>
> Steps:
> 1. Search any existing Agreement.
> 2. Click on the update button.
> 3. Try to change the Role Type Id From, Role Type Id To and Agreement Type Id.
> 4. Click on submit button.
> Actual:
> Error displayed on the screen on clicking submit button.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9747) Error while updating Agreement

2017-09-23 Thread Priya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priya Sharma reassigned OFBIZ-9747:
---

Assignee: Priya Sharma

> Error while updating Agreement 
> ---
>
> Key: OFBIZ-9747
> URL: https://issues.apache.org/jira/browse/OFBIZ-9747
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/updateAgreement
>Reporter: Padmavati Rawat
>Assignee: Priya Sharma
> Attachments: ErroronAgreement.png
>
>
> Steps:
> 1. Search any existing Agreement.
> 2. Click on the update button.
> 3. Try to change the Role Type Id From, Role Type Id To and Agreement Type Id.
> 4. Click on submit button.
> Actual:
> Error displayed on the screen on clicking submit button.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9678) Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId in UserPreference entity

2017-09-23 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9678.
--
   Resolution: Implemented
Fix Version/s: Upcoming Release

Thanks Aditya

Completed: At revision: 1809375  


> Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId 
> in UserPreference entity
> 
>
> Key: OFBIZ-9678
> URL: https://issues.apache.org/jira/browse/OFBIZ-9678
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9678.patch
>
>
> UserPreference.userLoginId is related to UserLogin.userLoginId.
> UserPreference.userPrefGroupTypeId is related to 
> UserPrefGroupType.userPrefGroupTypeId.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9753) 'Find Opportunities' field name is reflecting in place of 'Opportunity Id' on FindSalesOpportunity screen.

2017-09-23 Thread Sonal Patwari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sonal Patwari updated OFBIZ-9753:
-
Description: 
Navigate to SFA component > Opportunities > FindSalesOpportunity.
On opportunity search field 'Find Opportunities' is reflecting instead of 
'Opportunity Id' 
Here is the links for reference:
[Find Sales 
Opportunity|https://demo-stable.ofbiz.apache.org/sfa/control/FindSalesOpportunity]
Be


  was:
Navigate to SFA component > Opportunities > FindSalesOpportunity.
On opportunity search field 'Find Opportunities' is reflecting instead of 
'Opportunity Id' 
Here is the links for reference:
[Find Sales 
Opportunity|https://demo-stable.ofbiz.apache.org/sfa/control/FindSalesOpportunity]



> 'Find Opportunities' field name is reflecting in place of 'Opportunity Id' on 
> FindSalesOpportunity screen.
> --
>
> Key: OFBIZ-9753
> URL: https://issues.apache.org/jira/browse/OFBIZ-9753
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Sonal Patwari
> Attachments: SFA Manager_Find Opportunities.png
>
>
> Navigate to SFA component > Opportunities > FindSalesOpportunity.
> On opportunity search field 'Find Opportunities' is reflecting instead of 
> 'Opportunity Id' 
> Here is the links for reference:
> [Find Sales 
> Opportunity|https://demo-stable.ofbiz.apache.org/sfa/control/FindSalesOpportunity]
> Be



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9753) 'Find Opportunities' field name is reflecting in place of 'Opportunity Id' on FindSalesOpportunity screen.

2017-09-23 Thread Sonal Patwari (JIRA)
Sonal Patwari created OFBIZ-9753:


 Summary: 'Find Opportunities' field name is reflecting in place of 
'Opportunity Id' on FindSalesOpportunity screen.
 Key: OFBIZ-9753
 URL: https://issues.apache.org/jira/browse/OFBIZ-9753
 Project: OFBiz
  Issue Type: Bug
Affects Versions: Release Branch 16.11
Reporter: Sonal Patwari


Navigate to SFA component > Opportunities > FindSalesOpportunity.
On opportunity search field 'Find Opportunities' is reflecting instead of 
'Opportunity Id' 
Here is the links for reference:
[Find Sales 
Opportunity|https://demo-stable.ofbiz.apache.org/sfa/control/FindSalesOpportunity]




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9358) Integrating google phone number library for validating telecom numbers

2017-09-23 Thread Renuka Srishti (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-9358:
--
Attachment: OFBIZ-9358.patch

Here is the updated patch as per the discussion we have.

> Integrating google phone number library for validating telecom numbers
> --
>
> Key: OFBIZ-9358
> URL: https://issues.apache.org/jira/browse/OFBIZ-9358
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Release
>Reporter: Suraj Khurana
>Assignee: Arun Patidar
> Attachments: OFBIZ-9358.patch, OFBIZ-9358.patch, OFBIZ-9358.patch, 
> OFBIZ-9358.patch, OFBIZ-9358.patch
>
>
> As per discussion at 
> https://lists.apache.org/list.html?d...@ofbiz.apache.org:lte=1M:Validating%20telecom%20numbers
> Need to integrate Google telephone number to validate telephone numbers 
> formats of various countries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9752) UI Improvements while Creating Lead in SFA component

2017-09-23 Thread Garima jain (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177650#comment-16177650
 ] 

Garima jain commented on OFBIZ-9752:


This Issue does not exist, hence closing the ticket.

> UI Improvements while Creating Lead in SFA component
> 
>
> Key: OFBIZ-9752
> URL: https://issues.apache.org/jira/browse/OFBIZ-9752
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Rubia Elza Joshep
>Assignee: Garima jain
> Attachments: screenshot-1.png
>
>
> Steps to regenerate-
> 1) Open URL https://demo-trunk.ofbiz.apache.org/sfa/control/NewLead
> 2) In the Create new lead form, the Lead source and the contact list label is 
> repeated twice.
> Expected: Lead source and the contact list field should be displayed only 
> once.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9748) Required field indicator (*) is missing on the Add an association section

2017-09-23 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9748.
--
   Resolution: Implemented
Fix Version/s: Upcoming Release

Thanks Rohit,

Completed: At revision: 1809378  


> Required field indicator (*) is missing on the Add an association section
> -
>
> Key: OFBIZ-9748
> URL: https://issues.apache.org/jira/browse/OFBIZ-9748
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Rohit Rai
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9748.patch
>
>
> 1. Go to, Content.
> 2. Find contents using the find form and select any content from the list./
> 3. Click on the submenu "Association"
> 4. ContentIdTo and ContentAssocTypeId are required field in add association 
> form, the indicator is missing from the UI.
> Link to the form,
> https://demo-trunk.ofbiz.apache.org/content/control/createContentAssoc



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9581) Merge extended entity definition in data model component into the existing entity definition

2017-09-23 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-9581.
---
   Resolution: Done
Fix Version/s: Upcoming Release

> Merge extended entity definition in data model component into the existing 
> entity definition
> 
>
> Key: OFBIZ-9581
> URL: https://issues.apache.org/jira/browse/OFBIZ-9581
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9581.patch, OFBIZ-9581.patch
>
>
> Commonly used entities extended in data model component like UserLogin, 
> UserLoginHistory, Visit etc can be merged to their existing definition only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9754) Required field indicator (*) is missing from create web site parties.

2017-09-23 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai updated OFBIZ-9754:
-
Description: 
1. Go to content -> websites
2. Find websites and select a website from the list.
3. Required field indicator for party id is missing from create web site 
parties,
direct link,

  was:
1. Go to content -> websites
2. Find websites and select a website from the list.
3. Required field indicator for party id is missing from create web site 
parties,
direct link,
https://localhost:8443/content/control/createWebSiteRole


> Required field indicator (*) is missing from create web site parties.
> -
>
> Key: OFBIZ-9754
> URL: https://issues.apache.org/jira/browse/OFBIZ-9754
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
>
> 1. Go to content -> websites
> 2. Find websites and select a website from the list.
> 3. Required field indicator for party id is missing from create web site 
> parties,
> direct link,



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9754) Required field indicator (*) is missing from create web site parties.

2017-09-23 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai updated OFBIZ-9754:
-
Attachment: OFBIZ-9754.patch

Attaching a patch for the task.

> Required field indicator (*) is missing from create web site parties.
> -
>
> Key: OFBIZ-9754
> URL: https://issues.apache.org/jira/browse/OFBIZ-9754
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
> Attachments: OFBIZ-9754.patch
>
>
> 1. Go to content -> websites
> 2. Find websites and select a website from the list.
> 3. Required field indicator for party id is missing from create web site 
> parties,
> direct link,



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9465) Replace Inline Javascript with External Javascript

2017-09-23 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-9465:
---

Assignee: Deepak Dixit  (was: Aditya Sharma)

> Replace Inline Javascript with External Javascript 
> ---
>
> Key: OFBIZ-9465
> URL: https://issues.apache.org/jira/browse/OFBIZ-9465
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
> Attachments: OFBIZ-9465_example.patch, OFBIZ-9465.patch, 
> OFBIZ-9465.patch
>
>
> As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline 
> javascript for various macros like renderLookupField, 
> makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be 
> replaced with a generic code written as external javascript. Generic 
> Javascript code should be written in OfbizUtil.js and appropriate classes or 
> identifiers should be used for applying that. Any additional data can be 
> passed with HTML 5 custom data attribute 
> (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes).
> As suggested by Jacques in  https://s.apache.org/y8P1 will introduce 
> require.js for the split javascript files in a sub-task.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9503) Fixed Asset Id field is below update button on EditInventoryItem page

2017-09-23 Thread Dhaval Wagela (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dhaval Wagela reassigned OFBIZ-9503:


Assignee: Dhaval Wagela  (was: Aditya Sharma)

> Fixed Asset Id field is below update button on EditInventoryItem page
> -
>
> Key: OFBIZ-9503
> URL: https://issues.apache.org/jira/browse/OFBIZ-9503
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: Dhaval Wagela
>Priority: Trivial
>
> Steps to reproduce:
> 1. Go to Facility component 
> (https://demo-trunk.ofbiz.apache.org/facility/control/main)
> 2. Select facility and click on submit button 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditFacility)
> 3. Click on Inventory item in sub menu 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditFacilityInventoryItems?facilityId=WebStoreWarehouse)
> 4. Click on id link of any inventory item 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditInventoryItem?inventoryItemId=9003=WebStoreWarehouse)
> Fixed Asset Id field is below Update button



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9756) Required field indicator (*) is missing from create contact list.

2017-09-23 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai updated OFBIZ-9756:
-
Attachment: OFBIZ-9756.patch

Attached the patch.

> Required field indicator (*) is missing from create contact list.
> -
>
> Key: OFBIZ-9756
> URL: https://issues.apache.org/jira/browse/OFBIZ-9756
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
> Attachments: OFBIZ-9756.patch
>
>
> 1. go to content -> website
> 2. find websites -> select a website from the link
> 3. Click on contact lists from the submenu.
> contact list id is a required field,
> Quick link to test the issue,
> https://demo-trunk.ofbiz.apache.org/content/control/createWebSiteContactList



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9678) Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId in UserPreference entity

2017-09-23 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177677#comment-16177677
 ] 

Deepak Dixit commented on OFBIZ-9678:
-

I think relation type should be one-no-fk.


> Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId 
> in UserPreference entity
> 
>
> Key: OFBIZ-9678
> URL: https://issues.apache.org/jira/browse/OFBIZ-9678
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9678.patch
>
>
> UserPreference.userLoginId is related to UserLogin.userLoginId.
> UserPreference.userPrefGroupTypeId is related to 
> UserPrefGroupType.userPrefGroupTypeId.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-1585) Credit card valdation does not work properly during anonymous quick checkout process

2017-09-23 Thread Amit Gadaley (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley updated OFBIZ-1585:

Attachment: OFBIZ-1585.patch

Provided the updated patch. Thanks [~arunpati] for the guidance. It is 
dependent on the issue reported under OFBIZ-9755.

> Credit card valdation does not work properly during anonymous quick checkout 
> process
> 
>
> Key: OFBIZ-1585
> URL: https://issues.apache.org/jira/browse/OFBIZ-1585
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
> Environment: Ubuntu 7.10, Firefox 2.0.0.11
>Reporter: Raj Saini
>Assignee: Amit Gadaley
>Priority: Minor
> Attachments: credit-card-validation2.png, credit-card-validation.png, 
> OFBIZ-1585.patch, OFBIZ-1585.patch, OFBIZ-1585.patch
>
>
> If a credit card is selected as payment method and process button is pressed 
> without adding all mandatory fields of credit card, order will be summited 
> despite showing the validation error on credit card and user have no choice 
> of rectifying the validation errors. 
> Screenshot is attached showing this behavior 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9753) 'Find Opportunities' field name is reflecting in place of 'Opportunity Id' on FindSalesOpportunity screen.

2017-09-23 Thread Parakh Maheshwari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Parakh Maheshwari updated OFBIZ-9753:
-
Attachment: OFBIZ-9753.patch

> 'Find Opportunities' field name is reflecting in place of 'Opportunity Id' on 
> FindSalesOpportunity screen.
> --
>
> Key: OFBIZ-9753
> URL: https://issues.apache.org/jira/browse/OFBIZ-9753
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Sonal Patwari
>Assignee: Parakh Maheshwari
> Attachments: OFBIZ-9753.patch, SFA Manager_Find Opportunities.png
>
>
> Navigate to SFA component > Opportunities > FindSalesOpportunity.
> On opportunity search field 'Find Opportunities' is reflecting instead of 
> 'Opportunity Id' 
> Here is the links for reference:
> [Find Sales 
> Opportunity|https://demo-stable.ofbiz.apache.org/sfa/control/FindSalesOpportunity]
> Below is the image attached for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9753) 'Find Opportunities' field name is reflecting in place of 'Opportunity Id' on FindSalesOpportunity screen.

2017-09-23 Thread Parakh Maheshwari (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177686#comment-16177686
 ] 

Parakh Maheshwari commented on OFBIZ-9753:
--

*Fix:* Change 'Find Opportunities' field to  'Opportunity Id' at 
FindSalesOpportunity screen.
Attaching the patch for the same.

> 'Find Opportunities' field name is reflecting in place of 'Opportunity Id' on 
> FindSalesOpportunity screen.
> --
>
> Key: OFBIZ-9753
> URL: https://issues.apache.org/jira/browse/OFBIZ-9753
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Sonal Patwari
>Assignee: Parakh Maheshwari
> Attachments: OFBIZ-9753.patch, SFA Manager_Find Opportunities.png
>
>
> Navigate to SFA component > Opportunities > FindSalesOpportunity.
> On opportunity search field 'Find Opportunities' is reflecting instead of 
> 'Opportunity Id' 
> Here is the links for reference:
> [Find Sales 
> Opportunity|https://demo-stable.ofbiz.apache.org/sfa/control/FindSalesOpportunity]
> Below is the image attached for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9757) Required field indicator (*) is missing on create data resource

2017-09-23 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai updated OFBIZ-9757:
-
Description: 
go to,
content -> dataresource -> create new
direct link to test the issue,
no required symbol for the required parameters, as a result service throws 
missing parameter error.

https://demo-trunk.ofbiz.apache.org/content/control/EditDataResource

  was:
go to,
content -> dataresource -> create new
direct link to test the issue,
https://demo-trunk.ofbiz.apache.org/content/control/EditDataResource


> Required field indicator (*) is missing on create data resource
> ---
>
> Key: OFBIZ-9757
> URL: https://issues.apache.org/jira/browse/OFBIZ-9757
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
>
> go to,
> content -> dataresource -> create new
> direct link to test the issue,
> no required symbol for the required parameters, as a result service throws 
> missing parameter error.
> https://demo-trunk.ofbiz.apache.org/content/control/EditDataResource



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9503) Fixed Asset Id field is below update button on EditInventoryItem page

2017-09-23 Thread Dhaval Wagela (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dhaval Wagela updated OFBIZ-9503:
-
Attachment: OFBIZ-9503.patch

> Fixed Asset Id field is below update button on EditInventoryItem page
> -
>
> Key: OFBIZ-9503
> URL: https://issues.apache.org/jira/browse/OFBIZ-9503
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: Dhaval Wagela
>Priority: Trivial
> Attachments: OFBIZ-9503.patch
>
>
> Steps to reproduce:
> 1. Go to Facility component 
> (https://demo-trunk.ofbiz.apache.org/facility/control/main)
> 2. Select facility and click on submit button 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditFacility)
> 3. Click on Inventory item in sub menu 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditFacilityInventoryItems?facilityId=WebStoreWarehouse)
> 4. Click on id link of any inventory item 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditInventoryItem?inventoryItemId=9003=WebStoreWarehouse)
> Fixed Asset Id field is below Update button



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-9503) Fixed Asset Id field is below update button on EditInventoryItem page

2017-09-23 Thread Dhaval Wagela (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177702#comment-16177702
 ] 

Dhaval Wagela edited comment on OFBIZ-9503 at 9/23/17 10:15 AM:


Fixed the issue and provided the patch.
The screen is also rendered on clicking *New Inventory Item* button using the 
following link.
[Edit 
Inventory|https://localhost:8443/facility/control/EditInventoryItem?inventoryItemId=9003=WebStoreWarehouse]


was (Author: dhaval.wagela):
Fixed the issue and provided the patch.
The screen is also rendered on clicking *New Inventory Item* button using the 
following link.
[New 
Inventory|https://localhost:8443/facility/control/EditInventoryItem?inventoryItemId=9003=WebStoreWarehouse]

> Fixed Asset Id field is below update button on EditInventoryItem page
> -
>
> Key: OFBIZ-9503
> URL: https://issues.apache.org/jira/browse/OFBIZ-9503
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: Dhaval Wagela
>Priority: Trivial
> Attachments: OFBIZ-9503.patch
>
>
> Steps to reproduce:
> 1. Go to Facility component 
> (https://demo-trunk.ofbiz.apache.org/facility/control/main)
> 2. Select facility and click on submit button 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditFacility)
> 3. Click on Inventory item in sub menu 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditFacilityInventoryItems?facilityId=WebStoreWarehouse)
> 4. Click on id link of any inventory item 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditInventoryItem?inventoryItemId=9003=WebStoreWarehouse)
> Fixed Asset Id field is below Update button



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7183) Completed Service Order Items are being allowed to be received along with finished goods over Approved PO

2017-09-23 Thread Swapnil Shah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177735#comment-16177735
 ] 

Swapnil Shah commented on OFBIZ-7183:
-

[~jacques.le.roux] Done !!

> Completed Service Order Items are being allowed to be received along with 
> finished goods over Approved PO 
> --
>
> Key: OFBIZ-7183
> URL: https://issues.apache.org/jira/browse/OFBIZ-7183
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Release
>Reporter: Swapnil Shah
>Assignee: Ankush Upadhyay
> Attachments: COMP_REC_1.png
>
>
> Whenever a PO has both service type and finished good products then order 
> items having service type products get completed on Order approval itself. 
> But when such PO is received the service type items (despite being completed) 
> are listed along with finished goods to be received and eventually get 
> received as well if done so. 
> We could try preventing service type items to be listed like we do for any 
> regular finished good items when they get completed.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9762) Getting error in select frequency drop down on eCommerce shopping list screen

2017-09-23 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177740#comment-16177740
 ] 

Deepak Dixit commented on OFBIZ-9762:
-

Thanks  Mohammed Rehan Khan for your contribution.
This has been fixed at ofbiz-pluings at r#1809401

This issue does not exists in older release. 

> Getting error in select frequency drop down on eCommerce shopping list screen 
>  
> ---
>
> Key: OFBIZ-9762
> URL: https://issues.apache.org/jira/browse/OFBIZ-9762
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Mohammed Rehan Khan
>Assignee: Deepak Dixit
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9762.patch, screenshot-1.png
>
>
> Steps to regenerate this issue
> 1) Login to eCommerce component
> 2) Click on shopping list tab
> 3) Add new shopping list item for "Automatic Re-order" type list 
> 4) Click on select frequency drop-down of shopping list recorder section
> Please refer the attached screenshot for the error. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9762) Getting error in select frequency drop down on eCommerce shopping list screen

2017-09-23 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-9762.
---

> Getting error in select frequency drop down on eCommerce shopping list screen 
>  
> ---
>
> Key: OFBIZ-9762
> URL: https://issues.apache.org/jira/browse/OFBIZ-9762
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Mohammed Rehan Khan
>Assignee: Deepak Dixit
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9762.patch, screenshot-1.png
>
>
> Steps to regenerate this issue
> 1) Login to eCommerce component
> 2) Click on shopping list tab
> 3) Add new shopping list item for "Automatic Re-order" type list 
> 4) Click on select frequency drop-down of shopping list recorder section
> Please refer the attached screenshot for the error. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9680) No option to add Event Purpose on Events page.

2017-09-23 Thread Lalit Dashora (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora reassigned OFBIZ-9680:


Assignee: (was: Lalit Dashora)

> No option to add Event Purpose on Events page.
> --
>
> Key: OFBIZ-9680
> URL: https://issues.apache.org/jira/browse/OFBIZ-9680
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Sonal Patwari
> Attachments: OFBIZ-9680.patch
>
>
> Navigate to SFA component > Events > Create Event.
> - While creating an event, there is no option to enter purpose.
> - On Events screen there is 'Purpose' field in the table which remains empty 
> as there is no option for adding it.
> Here are the helpful links :
> - [Events Page|https://demo-stable.ofbiz.apache.org/sfa/control/Events]
> - [Create Event|https://demo-stable.ofbiz.apache.org/sfa/control/EditEvent]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9535) Error in payment address for purchase invoice via service createinvoicefororder

2017-09-23 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9535.
-

> Error in payment address for purchase invoice via service 
> createinvoicefororder
> ---
>
> Key: OFBIZ-9535
> URL: https://issues.apache.org/jira/browse/OFBIZ-9535
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Assignee: Akash Jain
> Fix For: 16.11.04
>
> Attachments: InvoiceServices.java.patch
>
>
> During the creation of an invoice via the service " createinvoicefororder ", 
> the address of payment of the supplier is not filtered by date.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9767) Missing FK constraints in OrderItem entity for ShoppingListItem

2017-09-23 Thread Chandan Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandan Khandelwal updated OFBIZ-9767:
--
Attachment: OFBIZ-9767.patch

> Missing FK constraints in OrderItem entity for ShoppingListItem
> ---
>
> Key: OFBIZ-9767
> URL: https://issues.apache.org/jira/browse/OFBIZ-9767
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Chandan Khandelwal
> Attachments: OFBIZ-9767.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9767) Missing FK constraints in OrderItem entity for ShoppingListItem

2017-09-23 Thread Chandan Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177756#comment-16177756
 ] 

Chandan Khandelwal commented on OFBIZ-9767:
---

Added patch with FK constraints in OrderItem.  

> Missing FK constraints in OrderItem entity for ShoppingListItem
> ---
>
> Key: OFBIZ-9767
> URL: https://issues.apache.org/jira/browse/OFBIZ-9767
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Chandan Khandelwal
> Attachments: OFBIZ-9767.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9769) Instead of using title and labels, use single label for independent fields

2017-09-23 Thread Garima jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Garima jain updated OFBIZ-9769:
---
Description: 
If there are multiple input fields and all belong to same group/category(like 
address1, address2, city and state input fields belong to Address category) in 
a form then we can use a title for such type of categories. But, if there is 
only a single field (like Email address has single input field) then we should 
not use the title for it.


 Here is the reference 
https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer

Like for Email address does not require Title and label both we can only use 
title for it.



  was:
If there are multiple input fields and all belong to same group/category(like 
address1, address2, city and state input fields belong to Address category) in 
a form then we can use a title for such type of categories. But, if there is 
only a single field (like Email address has single input field) then we should 
not use the title for it.


 Here is the reference 
https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer

Like for Email address does not require Title and label both we can only on 
title for single fields.




> Instead of using title and labels, use single label for independent fields
> --
>
> Key: OFBIZ-9769
> URL: https://issues.apache.org/jira/browse/OFBIZ-9769
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Reporter: Garima jain
>Priority: Minor
>
> If there are multiple input fields and all belong to same group/category(like 
> address1, address2, city and state input fields belong to Address category) 
> in a form then we can use a title for such type of categories. But, if there 
> is only a single field (like Email address has single input field) then we 
> should not use the title for it.
>  Here is the reference 
> https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer
> Like for Email address does not require Title and label both we can only use 
> title for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-7183) Completed Service Order Items are being allowed to be received along with finished goods over Approved PO

2017-09-23 Thread Ankush Upadhyay (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-7183:
---
Attachment: orderitem.jpg

> Completed Service Order Items are being allowed to be received along with 
> finished goods over Approved PO 
> --
>
> Key: OFBIZ-7183
> URL: https://issues.apache.org/jira/browse/OFBIZ-7183
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Release
>Reporter: Swapnil Shah
>Assignee: Ankush Upadhyay
> Attachments: COMP_REC_1.png, OFBIZ-7183.patch, orderitem.jpg, 
> OrderItem.png, RecceiveInventory.png
>
>
> Whenever a PO has both service type and finished good products then order 
> items having service type products get completed on Order approval itself. 
> But when such PO is received the service type items (despite being completed) 
> are listed along with finished goods to be received and eventually get 
> received as well if done so. 
> We could try preventing service type items to be listed like we do for any 
> regular finished good items when they get completed.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9489) Add new Rule Based Number Format for Indian Number System in International Components for Unicode (ICU) OFBiz usage.

2017-09-23 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-9489.
---
   Resolution: Fixed
Fix Version/s: Upcoming Release

Committed revision 1809424.

Thanks Pradhan Yash Sharma for your contribution.

> Add new Rule Based Number Format for Indian Number System in International 
> Components for Unicode (ICU) OFBiz usage.
> 
>
> Key: OFBIZ-9489
> URL: https://issues.apache.org/jira/browse/OFBIZ-9489
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: 16.11.03
>Reporter: Pradhan Yash Sharma
>Assignee: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9489.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9490) Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and formatting can be done, rather than system providing all ruleset support.

2017-09-23 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-9490.
---
   Resolution: Fixed
Fix Version/s: Upcoming Release

> Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and 
> formatting can be done, rather than system providing all ruleset support.
> --
>
> Key: OFBIZ-9490
> URL: https://issues.apache.org/jira/browse/OFBIZ-9490
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: 16.11.03
>Reporter: Pradhan Yash Sharma
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9490.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7328) Promotion is applied multiple times in case of Order Flat Amount action

2017-09-23 Thread Aditi Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177655#comment-16177655
 ] 

Aditi Patidar commented on OFBIZ-7328:
--

Thanks, Vishal for reporting this issue.

It's data setup related issue. Need to set use limit otherwise, it will run at 
max three times. The console also shows the error message if use limit not set 
and rules applied iteratively and limit crossed. In the mentioned scenario cart 
amount reaches to zero because cart subtotal will be less than $30.

> Promotion is applied multiple times in case of Order Flat Amount action
> ---
>
> Key: OFBIZ-7328
> URL: https://issues.apache.org/jira/browse/OFBIZ-7328
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Vishal Chhabria
>Assignee: Aditi Patidar
>
> Steps to regenerate - 
> Create a promotion with 
> condition - > cart subtotal greater than equal to zero.
> action - > Order Amount Flat - 10
> Expected - 10 $ should be deducted from cart.
> Actual - Promotion keeps on applying unless cart amount reaches 0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9747) Error while updating Agreement

2017-09-23 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177661#comment-16177661
 ] 

Suraj Khurana commented on OFBIZ-9747:
--

Party selected must be in specific role, best possible solution could be error 
message can be made user-friendly or to call ensurePartyRole first.

> Error while updating Agreement 
> ---
>
> Key: OFBIZ-9747
> URL: https://issues.apache.org/jira/browse/OFBIZ-9747
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/updateAgreement
>Reporter: Padmavati Rawat
> Attachments: ErroronAgreement.png
>
>
> Steps:
> 1. Search any existing Agreement.
> 2. Click on the update button.
> 3. Try to change the Role Type Id From, Role Type Id To and Agreement Type Id.
> 4. Click on submit button.
> Actual:
> Error displayed on the screen on clicking submit button.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9755) ShoppingCart's 'getPaymentMethodTypes' method should use 'getPaymentMethodTypeIds' internally instead of 'getPaymentMethodIds'

2017-09-23 Thread Amit Gadaley (JIRA)
Amit Gadaley created OFBIZ-9755:
---

 Summary: ShoppingCart's 'getPaymentMethodTypes' method should use 
'getPaymentMethodTypeIds' internally instead of 'getPaymentMethodIds'
 Key: OFBIZ-9755
 URL: https://issues.apache.org/jira/browse/OFBIZ-9755
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Trunk
Reporter: Amit Gadaley
Assignee: Amit Gadaley
 Fix For: Trunk


ShoppingCart's 'getPaymentMethodTypes' method should use 
'getPaymentMethodTypeIds' internally instead of 'getPaymentMethodIds'. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9754) Required field indicator (*) is missing from create web site parties.

2017-09-23 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai updated OFBIZ-9754:
-
Description: 
1. Go to content -> websites
2. Find websites and select a website from the list.
3. Required field indicator for party id is missing from create web site 
parties,
direct link,
https://demo-trunk.ofbiz.apache.org/content/control/EditWebSiteParties?webSiteId=WebStorePos

  was:
1. Go to content -> websites
2. Find websites and select a website from the list.
3. Required field indicator for party id is missing from create web site 
parties,
direct link,


> Required field indicator (*) is missing from create web site parties.
> -
>
> Key: OFBIZ-9754
> URL: https://issues.apache.org/jira/browse/OFBIZ-9754
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
> Attachments: OFBIZ-9754.patch
>
>
> 1. Go to content -> websites
> 2. Find websites and select a website from the list.
> 3. Required field indicator for party id is missing from create web site 
> parties,
> direct link,
> https://demo-trunk.ofbiz.apache.org/content/control/EditWebSiteParties?webSiteId=WebStorePos



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9745) Labels messed up because of missing UiLabels

2017-09-23 Thread Ankit Joshi (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Joshi updated OFBIZ-9745:
---
Attachment: OFBIZ-9745.patch

Attached the patch with a proper fix.

> Labels messed up because of missing UiLabels
> 
>
> Key: OFBIZ-9745
> URL: https://issues.apache.org/jira/browse/OFBIZ-9745
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Ankit Joshi
>Assignee: Ankit Joshi
>Priority: Minor
>  Labels: SFA
> Attachments: OFBIZ-9745.patch, SFAUserLogin1.png, SFAUserLogin2.png, 
> SFAUserLogin3.png
>
>
> 1) Navigate to SFA and search for contacts.
> 2) Move to Contact Profile detail screen.
> 3) Try following processes with UserLogin 
>   i) Create / Update  User Login.
>   ii) Assign / Edit Security Group to the User Login.
> Result: Several UX labels messed up because of missing UiLabels.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9745) Labels messed up because of missing UiLabels

2017-09-23 Thread Ankit Joshi (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Joshi reassigned OFBIZ-9745:
--

Assignee: (was: Ankit Joshi)

> Labels messed up because of missing UiLabels
> 
>
> Key: OFBIZ-9745
> URL: https://issues.apache.org/jira/browse/OFBIZ-9745
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Ankit Joshi
>Priority: Minor
>  Labels: SFA
> Attachments: OFBIZ-9745.patch, SFAUserLogin1.png, SFAUserLogin2.png, 
> SFAUserLogin3.png
>
>
> 1) Navigate to SFA and search for contacts.
> 2) Move to Contact Profile detail screen.
> 3) Try following processes with UserLogin 
>   i) Create / Update  User Login.
>   ii) Assign / Edit Security Group to the User Login.
> Result: Several UX labels messed up because of missing UiLabels.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Reopened] (OFBIZ-9678) Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId in UserPreference entity

2017-09-23 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-9678:


OK, I can confirm that all tests pass when I revert r1809375, I reopen

> Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId 
> in UserPreference entity
> 
>
> Key: OFBIZ-9678
> URL: https://issues.apache.org/jira/browse/OFBIZ-9678
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9678.patch
>
>
> UserPreference.userLoginId is related to UserLogin.userLoginId.
> UserPreference.userPrefGroupTypeId is related to 
> UserPrefGroupType.userPrefGroupTypeId.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9752) UI Improvements while Creating Lead in SFA component

2017-09-23 Thread Garima jain (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177693#comment-16177693
 ] 

Garima jain commented on OFBIZ-9752:


This is not an issue. It is the common pattern for input fields. 


> UI Improvements while Creating Lead in SFA component
> 
>
> Key: OFBIZ-9752
> URL: https://issues.apache.org/jira/browse/OFBIZ-9752
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Rubia Elza Joshep
>Assignee: Garima jain
> Attachments: screenshot-1.png
>
>
> Steps to regenerate-
> 1) Open URL https://demo-trunk.ofbiz.apache.org/sfa/control/NewLead
> 2) In the Create new lead form, the Lead source and the contact list label is 
> repeated twice.
> Expected: Lead source and the contact list field should be displayed only 
> once.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9754) Required field indicator (*) is missing from create web site parties.

2017-09-23 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9754:
--

Assignee: Jacques Le Roux  (was: Rohit Rai)

> Required field indicator (*) is missing from create web site parties.
> -
>
> Key: OFBIZ-9754
> URL: https://issues.apache.org/jira/browse/OFBIZ-9754
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-9754.patch
>
>
> 1. Go to content -> websites
> 2. Find websites and select a website from the list.
> 3. Required field indicator for party id is missing from create web site 
> parties,
> direct link,
> https://demo-trunk.ofbiz.apache.org/content/control/EditWebSiteParties?webSiteId=WebStorePos



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9757) Required field indicator (*) is missing on edit data resource role

2017-09-23 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai updated OFBIZ-9757:
-
Attachment: OFBIZ-9757.patch

Attaching the patch.

> Required field indicator (*) is missing on edit data resource role
> --
>
> Key: OFBIZ-9757
> URL: https://issues.apache.org/jira/browse/OFBIZ-9757
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
> Attachments: OFBIZ-9757.patch
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> no required symbol for the required parameters, as a result, service throws 
> missing parameter error.
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-7253) UI issue on web pos for different themes

2017-09-23 Thread Yogesh Naroliya (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177710#comment-16177710
 ] 

Yogesh Naroliya edited comment on OFBIZ-7253 at 9/23/17 10:27 AM:
--

Thanks [~anurag.chan...@hotwaxsystems.com] for feedback.

Please find a attached patch to back port fix for release 16.11. 
I have also verified it on local instance for all available themes and it is 
working as expected.


was (Author: yogesh.naroliya):
Please find a attached patch to back port fix for release 16.11. 
I have also verified it on local instance for all available themes and it is 
working as expected.

> UI issue on web pos for different themes
> 
>
> Key: OFBIZ-7253
> URL: https://issues.apache.org/jira/browse/OFBIZ-7253
> Project: OFBiz
>  Issue Type: Bug
>  Components: webpos
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Anurag Chandak
>Assignee: Arun Patidar
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-7253-REL16.11.patch, OFBIZ-7253-Trunk.patch, 
> WebPos-BlueLight-Theme.png, WebPos-FlatGray-Theme.png
>
>
> Steps to regenerate:
> - Go to web pos
> - Do login with any terminal
> - UI of "Cart", "Browse Categories" and "Products from this category" 
> screenlets are not proper.
> NOTE: This issue is found on the Flat Grey theme.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9754) Required field indicator (*) is missing from create web site parties.

2017-09-23 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9754.
--
   Resolution: Implemented
Fix Version/s: Upcoming Release

Thanks Rohit,

Completed: At revision: 1809387  


> Required field indicator (*) is missing from create web site parties.
> -
>
> Key: OFBIZ-9754
> URL: https://issues.apache.org/jira/browse/OFBIZ-9754
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9754.patch
>
>
> 1. Go to content -> websites
> 2. Find websites and select a website from the list.
> 3. Required field indicator for party id is missing from create web site 
> parties,
> direct link,
> https://demo-trunk.ofbiz.apache.org/content/control/EditWebSiteParties?webSiteId=WebStorePos



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9758) Party Id label missing from edit data resource role

2017-09-23 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai updated OFBIZ-9758:
-
Attachment: OFBIZ-9758.patch

Attaching the patch.

> Party Id label missing from edit data resource role
> ---
>
> Key: OFBIZ-9758
> URL: https://issues.apache.org/jira/browse/OFBIZ-9758
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
> Attachments: OFBIZ-9758.patch
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> Party Id label is missing,
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9760) Using Bootstrap Framework for E-Commerce Website

2017-09-23 Thread Saurabh Dixit (JIRA)
Saurabh Dixit created OFBIZ-9760:


 Summary: Using Bootstrap Framework for E-Commerce Website
 Key: OFBIZ-9760
 URL: https://issues.apache.org/jira/browse/OFBIZ-9760
 Project: OFBiz
  Issue Type: Improvement
  Components: ecommerce
Affects Versions: Trunk
Reporter: Saurabh Dixit
Assignee: Saurabh Dixit


Use of the bootstrap framework so that the UI of the e-commerce would be more 
arranged and user-friendly



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9761) Update regex used for validating credit cards

2017-09-23 Thread Amit Gadaley (JIRA)
Amit Gadaley created OFBIZ-9761:
---

 Summary: Update regex used for validating credit cards 
 Key: OFBIZ-9761
 URL: https://issues.apache.org/jira/browse/OFBIZ-9761
 Project: OFBiz
  Issue Type: Bug
Affects Versions: Trunk
Reporter: Amit Gadaley
Assignee: Amit Gadaley
 Fix For: Trunk


Update regex used for validating credit cards:

All Visa card numbers start with a 4. New cards have 16 digits. Old cards have 
13.

MasterCard numbers either start with the numbers 51 through 55 or with the 
numbers 2221 through 2720. All have 16 digits.

American Express card numbers start with 34 or 37 and have 15 digits.

Diners Club card numbers begin with 300 through 305, 36 or 38. All have 14 
digits. There are Diners Club cards that begin with 5 and have 16 digits. These 
are a joint venture between Diners Club and MasterCard and should be processed 
like a MasterCard.

Discover card numbers begin with 6011 or 65. All have 16 digits.

JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning with 
35 have 16 digits.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9762) Getting error in select frequency drop down on eCommerce shopping list screen

2017-09-23 Thread Mohammed Rehan Khan (JIRA)
Mohammed Rehan Khan created OFBIZ-9762:
--

 Summary: Getting error in select frequency drop down on eCommerce 
shopping list screen  
 Key: OFBIZ-9762
 URL: https://issues.apache.org/jira/browse/OFBIZ-9762
 Project: OFBiz
  Issue Type: Bug
  Components: ecommerce
Affects Versions: Trunk
Reporter: Mohammed Rehan Khan
Assignee: Mohammed Rehan Khan


Steps to regenerate this issue

1) Login to eCommerce component
2) Click on shopping list tab
3) Add new shopping list item
4) Click on select frequency drop-down of shopping list recorder section

Please refer the attached screenshot for the error. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9763) Create separate Permission Services for CRUD services of ShoppingList and ShoppingListItem

2017-09-23 Thread Chinmay Patidar (JIRA)
Chinmay Patidar created OFBIZ-9763:
--

 Summary: Create separate Permission Services for CRUD services of 
ShoppingList and ShoppingListItem
 Key: OFBIZ-9763
 URL: https://issues.apache.org/jira/browse/OFBIZ-9763
 Project: OFBiz
  Issue Type: Improvement
  Components: ecommerce, party
Affects Versions: Release Branch 16.11, Trunk
Reporter: Chinmay Patidar
Assignee: Chinmay Patidar
 Fix For: Trunk


In CRUD services for ShoppingList and ShoppingListItem entities, the security 
related checks are present inline in the services. This implementation violates 
the best practice of keeping security implementation different from the 
business logic.

We need to implement security services for such operations and to call them as 
a permission-service from the CRUD operation services definition



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9764) UI error on Shopping Lists screen

2017-09-23 Thread Chinmay Patidar (JIRA)
Chinmay Patidar created OFBIZ-9764:
--

 Summary: UI error on Shopping Lists screen
 Key: OFBIZ-9764
 URL: https://issues.apache.org/jira/browse/OFBIZ-9764
 Project: OFBiz
  Issue Type: Improvement
  Components: ecommerce
Affects Versions: Trunk
Reporter: Chinmay Patidar
Assignee: Chinmay Patidar
 Fix For: Trunk


Shopping Lists screen on ecommerce is not rendering. Getting following error -
'Found string literal: "DAILY". Expecting: number'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9762) Getting error in select frequency drop down on eCommerce shopping list screen

2017-09-23 Thread Mohammed Rehan Khan (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammed Rehan Khan updated OFBIZ-9762:
---
Description: 
Steps to regenerate this issue

1) Login to eCommerce component
2) Click on shopping list tab
3) Add new shopping list item for "Automatic Re-order" type list 
4) Click on select frequency drop-down of shopping list recorder section

Please refer the attached screenshot for the error. 

  was:
Steps to regenerate this issue

1) Login to eCommerce component
2) Click on shopping list tab
3) Add new shopping list item
4) Click on select frequency drop-down of shopping list recorder section

Please refer the attached screenshot for the error. 


> Getting error in select frequency drop down on eCommerce shopping list screen 
>  
> ---
>
> Key: OFBIZ-9762
> URL: https://issues.apache.org/jira/browse/OFBIZ-9762
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Mohammed Rehan Khan
>Assignee: Mohammed Rehan Khan
> Attachments: screenshot-1.png
>
>
> Steps to regenerate this issue
> 1) Login to eCommerce component
> 2) Click on shopping list tab
> 3) Add new shopping list item for "Automatic Re-order" type list 
> 4) Click on select frequency drop-down of shopping list recorder section
> Please refer the attached screenshot for the error. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9764) UI error on Shopping Lists screen

2017-09-23 Thread Chinmay Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chinmay Patidar closed OFBIZ-9764.
--
Resolution: Duplicate

The same issue has been reported in OFBIZ-9764. Thus closing this.

> UI error on Shopping Lists screen
> -
>
> Key: OFBIZ-9764
> URL: https://issues.apache.org/jira/browse/OFBIZ-9764
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Chinmay Patidar
>Assignee: Chinmay Patidar
> Fix For: Trunk
>
>
> Shopping Lists screen on ecommerce is not rendering. Getting following error -
> 'Found string literal: "DAILY". Expecting: number'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-9620) Extend SecurityGroup entity and add name/groupName field

2017-09-23 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-9620.
--
   Resolution: Fixed
Fix Version/s: Upcoming Release

> Extend SecurityGroup entity and add name/groupName field 
> -
>
> Key: OFBIZ-9620
> URL: https://issues.apache.org/jira/browse/OFBIZ-9620
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9620.patch
>
>
> Currently, SecurityGroup entity has groupId and description fields in that, 
> it should also have groupName/name field as well, as a description can be 
> very long and groupName can be used to represent SecurityGroup in a better 
> manner.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9751) Request handler exception in create billing account from suppliers profile page

2017-09-23 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-9751:
-
Attachment: OFBIZ-9751.patch

Updated the patch with some improvements.

> Request handler exception in create billing account from suppliers profile 
> page
> ---
>
> Key: OFBIZ-9751
> URL: https://issues.apache.org/jira/browse/OFBIZ-9751
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
> Environment: 
> https://demo-trunk.ofbiz.apache.org/partymgr/control/EditBillingAccount?partyId=DemoSupplier
>Reporter: Padmavati Rawat
>Assignee: Suraj Khurana
> Attachments: Errorinaddbillingaccount.png, OFBIZ-9751.patch, 
> OFBIZ-9751.patch
>
>
> Steps:
> 1. Navigate to any supplier profile page.
> 2. Select Create billing account in payment methods.
> 3. Click on Save button.
> Actual:
> Getting Request handler exception on screen.
> Expected:
> Billing account should be created successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9742) Ftl error shown on Edit Shopping List page in ecommerce component

2017-09-23 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-9742.
---

> Ftl error shown on Edit Shopping List page in ecommerce component
> -
>
> Key: OFBIZ-9742
> URL: https://issues.apache.org/jira/browse/OFBIZ-9742
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Reporter: Parakh Maheshwari
>Assignee: Deepak Dixit
> Fix For: Upcoming Release
>
> Attachments: FTLError.png, OFBIZ-9742.patch
>
>
> Steps to regenerate the issue:
> 1)Login to E-commerce component :
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
> 2)Navigate to Shopping Lists.
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/editShoppingList]
> 3)Ftl error show on Shopping List page.
>  NOTE: Please refer the screenshot for the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9761) Update regex used for validating credit cards

2017-09-23 Thread Amit Gadaley (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley updated OFBIZ-9761:

Attachment: OFBIZ-9761.patch

Updated regex used for validating credit cards of MasterCard, Discover, and 
JCB. Provided patch for the same.

> Update regex used for validating credit cards 
> --
>
> Key: OFBIZ-9761
> URL: https://issues.apache.org/jira/browse/OFBIZ-9761
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Assignee: Amit Gadaley
> Fix For: Trunk
>
> Attachments: OFBIZ-9761.patch
>
>
> Update regex used for validating credit cards:
> MasterCard numbers either start with the numbers 51 through 55 or with the 
> numbers 2221 through 2720. All have 16 digits.
> Discover card numbers begin with 6011 or 65. All have 16 digits.
> JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning 
> with 35 have 16 digits.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9678) Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId in UserPreference entity

2017-09-23 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177753#comment-16177753
 ] 

Deepak Dixit commented on OFBIZ-9678:
-

Thanks Jacques,

Now I think we can close this. 

> Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId 
> in UserPreference entity
> 
>
> Key: OFBIZ-9678
> URL: https://issues.apache.org/jira/browse/OFBIZ-9678
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9678.patch, OFBIZ-9678.patch
>
>
> UserPreference.userLoginId is related to UserLogin.userLoginId.
> UserPreference.userPrefGroupTypeId is related to 
> UserPrefGroupType.userPrefGroupTypeId.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9769) Instead of using title and labels, use single label for independent fields

2017-09-23 Thread Garima jain (JIRA)
Garima jain created OFBIZ-9769:
--

 Summary: Instead of using title and labels, use single label for 
independent fields
 Key: OFBIZ-9769
 URL: https://issues.apache.org/jira/browse/OFBIZ-9769
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Reporter: Garima jain
Priority: Minor


If there are multiple input fields and all belong to same group/category(like 
address1, address2, city and state input fields belong to Address category) in 
a form then we can use a title for such type of categories. But, if there is 
only a single field (like Email address has single input field) then we should 
not use the title for it.


 Here is the reference 
https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7183) Completed Service Order Items are being allowed to be received along with finished goods over Approved PO

2017-09-23 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177781#comment-16177781
 ] 

Jacques Le Roux commented on OFBIZ-7183:


Thanks Swapnil. I'll collect Jacopo's and my comments on this and put them in 
the contributor best practices.

> Completed Service Order Items are being allowed to be received along with 
> finished goods over Approved PO 
> --
>
> Key: OFBIZ-7183
> URL: https://issues.apache.org/jira/browse/OFBIZ-7183
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Release
>Reporter: Swapnil Shah
>Assignee: Ankush Upadhyay
> Attachments: COMP_REC_1.png, OFBIZ-7183.patch, OrderItem.png, 
> RecceiveInventory.png
>
>
> Whenever a PO has both service type and finished good products then order 
> items having service type products get completed on Order approval itself. 
> But when such PO is received the service type items (despite being completed) 
> are listed along with finished goods to be received and eventually get 
> received as well if done so. 
> We could try preventing service type items to be listed like we do for any 
> regular finished good items when they get completed.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Issue Comment Deleted] (OFBIZ-9752) UI Improvements while Creating Lead in SFA component

2017-09-23 Thread Garima jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Garima jain updated OFBIZ-9752:
---
Comment: was deleted

(was: This Issue does not exist, hence closing the ticket.)

> UI Improvements while Creating Lead in SFA component
> 
>
> Key: OFBIZ-9752
> URL: https://issues.apache.org/jira/browse/OFBIZ-9752
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Rubia Elza Joshep
>Assignee: Garima jain
> Attachments: screenshot-1.png
>
>
> Steps to regenerate-
> 1) Open URL https://demo-trunk.ofbiz.apache.org/sfa/control/NewLead
> 2) In the Create new lead form, the Lead source and the contact list label is 
> repeated twice.
> Expected: Lead source and the contact list field should be displayed only 
> once.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9696) Fix type entities to follow convention of hasTable

2017-09-23 Thread Aman Agrawal (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177659#comment-16177659
 ] 

Aman Agrawal commented on OFBIZ-9696:
-

Update SQL queries for ShipmentGatewayConfig and PaymentGatewayConfig entity 
modifications.

UPDATE Shipment_Gateway_Config SET shipment_gateway_conf_type_id = 
'SHIP_GATEWAY_DHL' WHERE shipment_gateway_conf_type_id = 'DHL';
UPDATE Shipment_Gateway_Config SET shipment_gateway_conf_type_id = 
'SHIP_GATEWAY_FEDEX' WHERE shipment_gateway_conf_type_id = 'FEDEX';
UPDATE Shipment_Gateway_Config SET shipment_gateway_conf_type_id = 
'SHIP_GATEWAY_UPS' WHERE shipment_gateway_conf_type_id = 'UPS';
UPDATE Shipment_Gateway_Config SET shipment_gateway_conf_type_id = 
'SHIP_GATEWAY_USPS' WHERE shipment_gateway_conf_type_id = 'USPS';

UPDATE Payment_Gateway_Config SET payment_gateway_config_type_id = 
'PAY_GATWY_SAGEPAY' WHERE payment_gateway_config_type_id = 'SAGEPAY';
UPDATE Payment_Gateway_Config SET payment_gateway_config_type_id = 
'PAY_GATWY_AUTH_NET' WHERE payment_gateway_config_type_id = 'AUTHORIZE_NET';
UPDATE Payment_Gateway_Config SET payment_gateway_config_type_id = 
'PAY_GATWY_CYBERSRC' WHERE payment_gateway_config_type_id = 'CYBERSOURCE';
UPDATE Payment_Gateway_Config SET payment_gateway_config_type_id = 
'PAY_GATWY_EWAY' WHERE payment_gateway_config_type_id = 'EWAY';
UPDATE Payment_Gateway_Config SET payment_gateway_config_type_id = 
'PAY_GATWY_PAYFLOWPRO' WHERE payment_gateway_config_type_id = 'PAYFLOWPRO';
UPDATE Payment_Gateway_Config SET payment_gateway_config_type_id = 
'PAY_GATWY_PAYPAL' WHERE payment_gateway_config_type_id = 'PAYPAL';
UPDATE Payment_Gateway_Config SET payment_gateway_config_type_id = 
'PAY_GATWY_CLRCOMRC' WHERE payment_gateway_config_type_id = 'CLEARCOMMERCE';
UPDATE Payment_Gateway_Config SET payment_gateway_config_type_id = 
'PAY_GATWY_WORLDPAY' WHERE payment_gateway_config_type_id = 'WORLDPAY';
UPDATE Payment_Gateway_Config SET payment_gateway_config_type_id = 
'PAY_GATWY_ORBITAL' WHERE payment_gateway_config_type_id = 'ORBITAL';
UPDATE Payment_Gateway_Config SET payment_gateway_config_type_id = 
'PAY_GATWY_SECUREPAY' WHERE payment_gateway_config_type_id = 'SECUREPAY';
UPDATE Payment_Gateway_Config SET payment_gateway_config_type_id = 
'PAY_GATWY_IDEAL' WHERE payment_gateway_config_type_id = 'IDEAL';

> Fix type entities to follow convention of hasTable
> --
>
> Key: OFBIZ-9696
> URL: https://issues.apache.org/jira/browse/OFBIZ-9696
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
> Attachments: OFBIZ-9696-2.patch, OFBIZ-9696.patch
>
>
> 'hasTable' field of 'Type' entities is used to give an idea that detail 
> entity exists or not. We generally get the name of detail entity on the basis 
> of typeId field value. 
> For example : 
> ContactMechType,contactMechTypeId = "POSTAL_ADDRESS"  then we go to 
> PostalAddress for detail.
> similarly,
> ContactMechType,contactMechTypeId = "TELECOM_NUMBER"  then we go to 
> TelecomNumber for detail.
> We should follow the naming convention.
> Below are some entities that are not following the pattern. Some of them are:
>- ShipmentGatewayConfigType
>- PaymentGatewayConfigType



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9489) Add new Rule Based Number Format for Indian Number System in International Components for Unicode (ICU) OFBiz usage.

2017-09-23 Thread Pradhan Yash Sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177657#comment-16177657
 ] 

Pradhan Yash Sharma commented on OFBIZ-9489:


Patch Available.

> Add new Rule Based Number Format for Indian Number System in International 
> Components for Unicode (ICU) OFBiz usage.
> 
>
> Key: OFBIZ-9489
> URL: https://issues.apache.org/jira/browse/OFBIZ-9489
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: 16.11.03
>Reporter: Pradhan Yash Sharma
>Assignee: Pradhan Yash Sharma
>Priority: Minor
> Attachments: OFBIZ-9489.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9581) Merge extended entity definition in data model component into the existing entity definition

2017-09-23 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177658#comment-16177658
 ] 

Deepak Dixit commented on OFBIZ-9581:
-

Thanks Aditya for your contribution. 

This has been committed at ofbiz-framework trunk at r#1809376

> Merge extended entity definition in data model component into the existing 
> entity definition
> 
>
> Key: OFBIZ-9581
> URL: https://issues.apache.org/jira/browse/OFBIZ-9581
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9581.patch, OFBIZ-9581.patch
>
>
> Commonly used entities extended in data model component like UserLogin, 
> UserLoginHistory, Visit etc can be merged to their existing definition only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9603) EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], caught in Finalize

2017-09-23 Thread Parakh Maheshwari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Parakh Maheshwari reassigned OFBIZ-9603:


Assignee: (was: Parakh Maheshwari)

> EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], 
> caught in Finalize
> 
>
> Key: OFBIZ-9603
> URL: https://issues.apache.org/jira/browse/OFBIZ-9603
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Priority: Minor
>
> Steps to regenerate issue:
> 1. Go to SFA component (https://localhost:8443/sfa/control/main)
> 2. Click on sub-menu "Leads" (https://localhost:8443/sfa/control/FindLeads)
> Following error in logs:
> {code:java}
> 2017-08-22 08:59:50,496 |Finalizer|EntityListIterator
> |E| 
> ==
> EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], 
> caught in Finalize
> ==
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9753) 'Find Opportunities' field name is reflecting in place of 'Opportunity Id' on FindSalesOpportunity screen.

2017-09-23 Thread Parakh Maheshwari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Parakh Maheshwari reassigned OFBIZ-9753:


Assignee: Parakh Maheshwari

> 'Find Opportunities' field name is reflecting in place of 'Opportunity Id' on 
> FindSalesOpportunity screen.
> --
>
> Key: OFBIZ-9753
> URL: https://issues.apache.org/jira/browse/OFBIZ-9753
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Sonal Patwari
>Assignee: Parakh Maheshwari
> Attachments: SFA Manager_Find Opportunities.png
>
>
> Navigate to SFA component > Opportunities > FindSalesOpportunity.
> On opportunity search field 'Find Opportunities' is reflecting instead of 
> 'Opportunity Id' 
> Here is the links for reference:
> [Find Sales 
> Opportunity|https://demo-stable.ofbiz.apache.org/sfa/control/FindSalesOpportunity]
> Below is the image attached for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9678) Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId in UserPreference entity

2017-09-23 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177670#comment-16177670
 ] 

Jacques Le Roux commented on OFBIZ-9678:


Hi Aditya I think we have issues with recent data model changes, see 
https://ci.apache.org/builders/ofbiz-trunk-framework/builds/471
and while loading
{code}
2017-09-23 11:05:42,654 |main |EntitySaxReader   
|I| Transaction Timeout set to 2 hours (7200 seconds)
2017-09-23 11:05:42,865 |main |GenericDelegator  
|E| Failure in create operation for entity [UserPreference]: 
org.apache.ofbiz.entity.GenericEntityException: Error while inserting:
 [GenericEntity:UserPreference][createdStamp,2017-09-23 
11:05:42.86(java.sql.Timestamp)][createdTxStamp,2017-09-23 
11:05:42.654(java.sql.Timestamp)][lastUpdatedStamp,2017-09-23 
11:05:42.86(java.sql.Timestamp)
][lastUpdatedTxStamp,2017-09-23 
11:05:42.654(java.sql.Timestamp)][userLoginId,_NA_(java.lang.String)][userPrefGroupTypeId,GLOBAL_PREFERENCES(java.lang.String)][userPrefTypeId,VISUAL_THEME(java.lang.String)][u
serPrefValue,DEFAULT(java.lang.String)] (SQL Exception while executing the 
following:INSERT INTO OFBIZ.USER_PREFERENCE (USER_LOGIN_ID, USER_PREF_TYPE_ID, 
USER_PREF_GROUP_TYPE_ID, USER_PREF_VALUE, USER_PREF_DA
TA_TYPE, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 
'USER_PREFERENCE' caused a violation of foreign key constraint 'UP_USER
_LOGIN' for key (_NA_).  The statement has been rolled back.)). Rolling back 
transaction.
2017-09-23 11:05:42,865 |main |TransactionUtil   
|W| Calling transaction setRollbackOnly; this stack trace shows where this is 
happening:
java.lang.Exception: Failure in create operation for entity [UserPreference]: 
org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
[GenericEntity:UserPreference][createdStamp,2017-09-23 11:0
5:42.86(java.sql.Timestamp)][createdTxStamp,2017-09-23 
11:05:42.654(java.sql.Timestamp)][lastUpdatedStamp,2017-09-23 
11:05:42.86(java.sql.Timestamp)][lastUpdatedTxStamp,2017-09-23 
11:05:42.654(java.sql.Timest
amp)][userLoginId,_NA_(java.lang.String)][userPrefGroupTypeId,GLOBAL_PREFERENCES(java.lang.String)][userPrefTypeId,VISUAL_THEME(java.lang.String)][userPrefValue,DEFAULT(java.lang.String)]
 (SQL Exception while
 executing the following:INSERT INTO OFBIZ.USER_PREFERENCE (USER_LOGIN_ID, 
USER_PREF_TYPE_ID, USER_PREF_GROUP_TYPE_ID, USER_PREF_VALUE, 
USER_PREF_DATA_TYPE, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_
STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 
'USER_PREFERENCE' caused a violation of foreign key constraint 'UP_USER_LOGIN' 
for key (_NA_).  The statement has been rolled back.
)). Rolling back transaction.
{code}
I'm not yet sure, but not only here but maybe also with 
https://ci.apache.org/builders/ofbiz-trunk-framework/builds/472 checking...

> Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId 
> in UserPreference entity
> 
>
> Key: OFBIZ-9678
> URL: https://issues.apache.org/jira/browse/OFBIZ-9678
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9678.patch
>
>
> UserPreference.userLoginId is related to UserLogin.userLoginId.
> UserPreference.userPrefGroupTypeId is related to 
> UserPrefGroupType.userPrefGroupTypeId.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9475) Refactor serialize and non-serialize inventory item implementaion

2017-09-23 Thread Vaibhav Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vaibhav Jain updated OFBIZ-9475:

Attachment: OFBIZ-9475.patch

Here is the updated patch.

Following changes are done in this patch.
1. Create inventory item detail for both serialized and non-serialized 
inventory item.
2. ATP, QOH, and AQT of both serialized and non-serialised inventory item are 
the sum of avilableToPromiseDiff, quantityOnHandDiffTotal and 
accountingQuantityTotal of inventory item detail entity.
3. Status of both inventory items is not entertaining yet. This will be done in 
next phase.
4. Removed statuses created specifically for the non-serialised inventory item. 
The Same status will be used for both serialized and non-serialised inventory 
item.

> Refactor serialize and non-serialize inventory item implementaion
> -
>
> Key: OFBIZ-9475
> URL: https://issues.apache.org/jira/browse/OFBIZ-9475
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Vaibhav Jain
> Attachments: OFBIZ-9475.patch, OFBIZ-9475.patch, OFBIZ-9475.patch, 
> OFBIZ-9475.patch
>
>
> As discussed on dev mailing list [1][2] we need to refactor serialize and 
> non-serialize inventory item design.
> As per current implementation serialize inventory item work on status and 
> non-serialized inventory item work on inventory item detail.
> Proposed Design:
> - Use inventory item detail for both serialise and non-serialize inventory 
> item. Only one additional condition for serialized inventory item that qoh 
> can't be greater then one.
> - We can maintain inventory item status record for both type
> [1] http://markmail.org/thread/bd2bpiv6c5wvl7km
> [2] http://ofbiz.markmail.org/thread/kro5kcggp4fcose7
> As we do a lot of discussion in the respective mail threads.
> [1] http://markmail.org/thread/bd2bpiv6c5wvl7km
> [2] http://ofbiz.markmail.org/thread/kro5kcggp4fcose7
> According to this email threads, I conclude that:-
> There are 2 types of the inventory item in OFBiz.
> 1. *Serialized*
> 2. *Non serialized*
> Majorly there are 3 entities to manage the various transaction of serialised 
> and non-serialized inventory items.
> 1. _InventoryItem_
> 2. _InventoryItemDetail_
> 3. _InventoryItemStatus_
> Following changes need to be done in the workflow of inventory item records:-
> 1) There is no need to manage a different workflow for serialised and non- 
> serialised inventory items.
> 2) Transaction of serialised and non-serialised inventory item should be 
> managed in both InventoryItemStatus and InventoryItemDetail entity.
>  a) Transaction of serialised inventory items is managed by 
> inventoryItemstatus entity not managed in inventoryItemDetail entity. While 
> inventoryItemDetail and inventoryItemStatus should be managed for both 
> serialised and non-serialised inventory items.
>  b) As ATP/QOH/AQT are updated on the basis of ATPDIFF/QOHDIFF/AQTDIFF in 
> non-serialised inventory item. We should follow the same pattern for 
> serialised inventory item.
>  c) Change in ATP/QOH/AQT is tracked by inventoryItemDetail entity.
>  d)Status transaction of an inventory item is tracked in 
> InventoryItemStatus entity.
> 3) No need to manage separate status for serialised and non-serialised 
> inventory item. They are already distinguished on the basis of inventory item 
> type.
> 1. *Serialised*:-
> In a serialised inventory item as of now ATP/QOH/AQT are managed on the 
> basis of inventory item status.While  ATP/QOH/AQT should be the sum of 
> ATPDIFF/QOHDIFF/AQTDIFF of inventory item detail.
> Ex:
> 1. If we receive 2 inventory of serialised inventory item then 2 separate 
> inventory item records are created
> InventoryItem:-
> inventoryItemId="10001",status="AVAILABLE", ATP="1", QOH="1",AQT="1"
> inventoryItemId="10002",status="AVAILABLE", ATP="1", QOH="1",AQT="1"
> InventoryItemDetail:-
> inventoryItemId="10001", inventoryItemDetailSeqId="10001", ATPDIFF="1", 
> QOHDIFF="1", AQTDIFF="1"
> inventoryItemId="10002", inventoryItemDetailSeqId="10002", ATPDIFF="1", 
> QOHDIFF="1", AQTDIFF="1"
> InventoryItemStatus:-
> inventoryItemId="10001" statusId="AVAILABLE" 
> inventoryItemId="10002" statusId="AVAILABLE" 
> 2. If status of inventory item is changed from AVAILABLE -> PROMISED then 
> InventoryItem:-
> inventoryItemId="10001",status="PROMISED", ATP="1", QOH="1",AQT="1"
> inventoryItemId="10002",status="AVAILABLE", ATP="1", QOH="1",AQT="1"
> InventoryItemDetail:-
> inventoryItemId="10001", inventoryItemDetailSeqId="10001",  ATPDIFF="1", 
> QOHDIFF="1", AQTDIFF="1"
> inventoryItemId="10001", inventoryItemDetailSeqId="10002",  ATPDIFF="-1", 
> QOHDIFF="0", AQTDIFF="0"
> inventoryItemId="10002", inventoryItemDetailSeqId="10002",  

[jira] [Commented] (OFBIZ-9748) Required field indicator (*) is missing on the Add an association section

2017-09-23 Thread Rohit Rai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177668#comment-16177668
 ] 

Rohit Rai commented on OFBIZ-9748:
--

Thanks Jacques. :)

> Required field indicator (*) is missing on the Add an association section
> -
>
> Key: OFBIZ-9748
> URL: https://issues.apache.org/jira/browse/OFBIZ-9748
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Rohit Rai
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9748.patch
>
>
> 1. Go to, Content.
> 2. Find contents using the find form and select any content from the list./
> 3. Click on the submenu "Association"
> 4. ContentIdTo and ContentAssocTypeId are required field in add association 
> form, the indicator is missing from the UI.
> Link to the form,
> https://demo-trunk.ofbiz.apache.org/content/control/createContentAssoc



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9741) Required field indicator (*) is missing from the required field on create website content form

2017-09-23 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9741.
-

> Required field indicator (*) is missing from the required field on create 
> website content form
> --
>
> Key: OFBIZ-9741
> URL: https://issues.apache.org/jira/browse/OFBIZ-9741
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Akash Jain
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9741.patch
>
>
> 1. Go to Content -> WebSites
> 2. Select a website from the list of sites.
> 3. click on content from the submenu, it will lead you to follow link
> https://demo-trunk.ofbiz.apache.org/content/control/ListWebSiteContent?webSiteId=WebStorePos
> 4. Content Id is a required parameter for the service, a required field 
> indicator must be placed on the form.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9678) Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId in UserPreference entity

2017-09-23 Thread Aditya Sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177690#comment-16177690
 ] 

Aditya Sharma commented on OFBIZ-9678:
--

Yes, Sure Jacques I will :)

> Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId 
> in UserPreference entity
> 
>
> Key: OFBIZ-9678
> URL: https://issues.apache.org/jira/browse/OFBIZ-9678
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9678.patch, OFBIZ-9678.patch
>
>
> UserPreference.userLoginId is related to UserLogin.userLoginId.
> UserPreference.userPrefGroupTypeId is related to 
> UserPrefGroupType.userPrefGroupTypeId.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9751) Request handler exception in create billing account from suppliers profile page

2017-09-23 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-9751:


Assignee: Suraj Khurana

> Request handler exception in create billing account from suppliers profile 
> page
> ---
>
> Key: OFBIZ-9751
> URL: https://issues.apache.org/jira/browse/OFBIZ-9751
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
> Environment: 
> https://demo-trunk.ofbiz.apache.org/partymgr/control/EditBillingAccount?partyId=DemoSupplier
>Reporter: Padmavati Rawat
>Assignee: Suraj Khurana
> Attachments: Errorinaddbillingaccount.png
>
>
> Steps:
> 1. Navigate to any supplier profile page.
> 2. Select Create billing account in payment methods.
> 3. Click on Save button.
> Actual:
> Getting Request handler exception on screen.
> Expected:
> Billing account should be created successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9757) Required field indicator (*) is missing on create data resource

2017-09-23 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai reassigned OFBIZ-9757:


Assignee: Rohit Rai

> Required field indicator (*) is missing on create data resource
> ---
>
> Key: OFBIZ-9757
> URL: https://issues.apache.org/jira/browse/OFBIZ-9757
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
>
> go to,
> content -> dataresource -> create new
> direct link to test the issue,
> https://demo-trunk.ofbiz.apache.org/content/control/EditDataResource



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9678) Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId in UserPreference entity

2017-09-23 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177699#comment-16177699
 ] 

Jacques Le Roux commented on OFBIZ-9678:


Thanks Aditya,

Finally completed: At revision: 1809383  :)


> Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId 
> in UserPreference entity
> 
>
> Key: OFBIZ-9678
> URL: https://issues.apache.org/jira/browse/OFBIZ-9678
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9678.patch, OFBIZ-9678.patch
>
>
> UserPreference.userLoginId is related to UserLogin.userLoginId.
> UserPreference.userPrefGroupTypeId is related to 
> UserPrefGroupType.userPrefGroupTypeId.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9757) Required field indicator (*) is missing on create data resource

2017-09-23 Thread Rohit Rai (JIRA)
Rohit Rai created OFBIZ-9757:


 Summary: Required field indicator (*) is missing on create data 
resource
 Key: OFBIZ-9757
 URL: https://issues.apache.org/jira/browse/OFBIZ-9757
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Reporter: Rohit Rai


go to,
content -> dataresource -> create new
direct link to test the issue,
https://demo-trunk.ofbiz.apache.org/content/control/EditDataResource



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9503) Fixed Asset Id field is below update button on EditInventoryItem page

2017-09-23 Thread Dhaval Wagela (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177702#comment-16177702
 ] 

Dhaval Wagela commented on OFBIZ-9503:
--

Fixed the issue and provided the patch.
The screen is also rendered on clicking *New Inventory Item* button using the 
following link.
[New 
Inventory|https://localhost:8443/facility/control/EditInventoryItem?inventoryItemId=9003=WebStoreWarehouse]

> Fixed Asset Id field is below update button on EditInventoryItem page
> -
>
> Key: OFBIZ-9503
> URL: https://issues.apache.org/jira/browse/OFBIZ-9503
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: Dhaval Wagela
>Priority: Trivial
>
> Steps to reproduce:
> 1. Go to Facility component 
> (https://demo-trunk.ofbiz.apache.org/facility/control/main)
> 2. Select facility and click on submit button 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditFacility)
> 3. Click on Inventory item in sub menu 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditFacilityInventoryItems?facilityId=WebStoreWarehouse)
> 4. Click on id link of any inventory item 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditInventoryItem?inventoryItemId=9003=WebStoreWarehouse)
> Fixed Asset Id field is below Update button



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9757) Required field indicator (*) is missing on edit data resource role

2017-09-23 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai updated OFBIZ-9757:
-
Description: 
go to,
content -> dataresource -> Find DataResource -> select a data resource from the 
list -> role
no required symbol for the required parameters, as a result, service throws 
missing parameter error.

direct link to test the issue,
https://localhost:8443/content/control/addDataResourceRole

  was:
go to,
content -> dataresource -> Find DataResource -> select a data resource from the 
list -> roles
no required symbol for the required parameters, as a result service throws 
missing parameter error.

direct link to test the issue,
https://localhost:8443/content/control/addDataResourceRole


> Required field indicator (*) is missing on edit data resource role
> --
>
> Key: OFBIZ-9757
> URL: https://issues.apache.org/jira/browse/OFBIZ-9757
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> no required symbol for the required parameters, as a result, service throws 
> missing parameter error.
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9758) Party Id label missing from edit data resource role

2017-09-23 Thread Rohit Rai (JIRA)
Rohit Rai created OFBIZ-9758:


 Summary: Party Id label missing from edit data resource role
 Key: OFBIZ-9758
 URL: https://issues.apache.org/jira/browse/OFBIZ-9758
 Project: OFBiz
  Issue Type: Bug
  Components: content
Reporter: Rohit Rai
Assignee: Rohit Rai


go to,
content -> dataresource -> Find DataResource -> select a data resource from the 
list -> role

Party Id label is missing,
direct link to test the issue,
https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9525) MRP incorrectly computes quantity already received in open purchase order shipments

2017-09-23 Thread Amit Gadaley (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley updated OFBIZ-9525:

Attachment: (was: OFBIZ-9525_trunk.diff)

> MRP incorrectly computes quantity already received in open purchase order 
> shipments
> ---
>
> Key: OFBIZ-9525
> URL: https://issues.apache.org/jira/browse/OFBIZ-9525
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk, 16.11.03
>Reporter: Jacopo Cappellato
>Assignee: Jacopo Cappellato
> Attachments: OFBIZ-9525_14.12.patch
>
>
> The MRP algorithm incorrectly computes the quantity of items partially 
> received in a purchase shipment because it leverages the 
> OrderReadHelper.getItemShippedQuantity(...) method that is intended to be 
> used to count the quantity shipped of a sales order.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9758) Party Id label missing from edit data resource role

2017-09-23 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai updated OFBIZ-9758:
-
Attachment: OFBIZ-9758.png

> Party Id label missing from edit data resource role
> ---
>
> Key: OFBIZ-9758
> URL: https://issues.apache.org/jira/browse/OFBIZ-9758
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
> Attachments: OFBIZ-9758.patch, OFBIZ-9758.png
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> Party Id label is missing,
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9525) MRP incorrectly computes quantity already received in open purchase order shipments

2017-09-23 Thread Amit Gadaley (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley updated OFBIZ-9525:

Attachment: OFBIZ-9525_trunk.patch

Updated patch for trunk.

> MRP incorrectly computes quantity already received in open purchase order 
> shipments
> ---
>
> Key: OFBIZ-9525
> URL: https://issues.apache.org/jira/browse/OFBIZ-9525
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk, 16.11.03
>Reporter: Jacopo Cappellato
>Assignee: Jacopo Cappellato
> Attachments: OFBIZ-9525_14.12.patch, OFBIZ-9525_trunk.patch
>
>
> The MRP algorithm incorrectly computes the quantity of items partially 
> received in a purchase shipment because it leverages the 
> OrderReadHelper.getItemShippedQuantity(...) method that is intended to be 
> used to count the quantity shipped of a sales order.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9597) Documentation: Customer Relationship Management (CRM) Process Overview

2017-09-23 Thread archana.asthana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177719#comment-16177719
 ] 

archana.asthana commented on OFBIZ-9597:


Reviewed the content and the diagrams in [CRM Process 
Review|https://cwiki.apache.org/confluence/x/RpJjB] and made the necessary 
changes.

> Documentation: Customer Relationship Management (CRM) Process Overview 
> ---
>
> Key: OFBIZ-9597
> URL: https://issues.apache.org/jira/browse/OFBIZ-9597
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pranay Pandey
>Assignee: Sonal Patwari
>  Labels: BPRB, CRM, OBPRB
>
> CRM process overview to be documented. 
> *Doc Content:* 
> Every CRM business activity to be covered with below-given headings-
> - Process Overview
> - Business Purpose (significance of having efficient CRM capabilities in real 
> world)
> - Activity Diagrams (Level-1,2, and 3 as applicable to demonstrate the 
> process flow)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9759) Fiscal Gl type is reflecting twice in drop-down of Cost Centers.

2017-09-23 Thread Tejas Khanna (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tejas Khanna updated OFBIZ-9759:

Summary: Fiscal Gl type is reflecting twice in drop-down of Cost Centers.  
(was: Fiscal Gl type is reflecting twice in drop-down of Cost Centers screen.)

> Fiscal Gl type is reflecting twice in drop-down of Cost Centers.
> 
>
> Key: OFBIZ-9759
> URL: https://issues.apache.org/jira/browse/OFBIZ-9759
> Project: OFBiz
>  Issue Type: Improvement
> Environment: 
> https://ofbiz-trunk.hotwaxsystems.com/accounting/control/GlAccountBalanceByCostCenter?organizationPartyId=Company
>Reporter: Tejas Khanna
>Priority: Minor
>
> Steps to reproduce:
> 1. Select Accounting from Applications.
> 2. Select Organization GL Settings from Accounting Manager.
> 3. Click on accounting.
> 4. Click on Reports
> 5. Select Cost Centers
> 6. Choose Fiscal Gl Type drop-down.
> Actual result: on selecting Gl Type from drop-down, selected Gl Type is 
> reflecting twice.
> Expected result: Selected value should come only once in drop-down after 
> report generation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9747) Error while updating Agreement

2017-09-23 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai reassigned OFBIZ-9747:


Assignee: Rohit Rai

> Error while updating Agreement 
> ---
>
> Key: OFBIZ-9747
> URL: https://issues.apache.org/jira/browse/OFBIZ-9747
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/updateAgreement
>Reporter: Padmavati Rawat
>Assignee: Rohit Rai
> Attachments: ErroronAgreement.png
>
>
> Steps:
> 1. Search any existing Agreement.
> 2. Click on the update button.
> 3. Try to change the Role Type Id From, Role Type Id To and Agreement Type Id.
> 4. Click on submit button.
> Actual:
> Error displayed on the screen on clicking submit button.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9759) Fiscal Gl type is reflecting twice in drop-down of Cost Centers.

2017-09-23 Thread Ritesh Kumar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ritesh Kumar reassigned OFBIZ-9759:
---

Assignee: Ritesh Kumar

> Fiscal Gl type is reflecting twice in drop-down of Cost Centers.
> 
>
> Key: OFBIZ-9759
> URL: https://issues.apache.org/jira/browse/OFBIZ-9759
> Project: OFBiz
>  Issue Type: Improvement
> Environment: 
> https://ofbiz-trunk.hotwaxsystems.com/accounting/control/GlAccountBalanceByCostCenter?organizationPartyId=Company
>Reporter: Tejas Khanna
>Assignee: Ritesh Kumar
>Priority: Minor
>
> Steps to reproduce:
> 1. Select Accounting from Applications.
> 2. Select Organization GL Settings from Accounting Manager.
> 3. Click on accounting.
> 4. Click on Reports
> 5. Select Cost Centers
> 6. Choose Fiscal Gl Type drop-down.
> Actual result: on selecting Gl Type from drop-down, selected Gl Type is 
> reflecting twice.
> Expected result: Selected value should come only once in drop-down after 
> report generation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9603) EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], caught in Finalize

2017-09-23 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177730#comment-16177730
 ] 

Jacques Le Roux commented on OFBIZ-9603:


The problem with calls to performFind is that it returns an EntityListIterator 
and we don't close it, like here in listLeads for 
PartyRoleAndContactMechDetail. Not yet quite sure how to handle this but maybe 
in form widget actions.service.

> EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], 
> caught in Finalize
> 
>
> Key: OFBIZ-9603
> URL: https://issues.apache.org/jira/browse/OFBIZ-9603
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Priority: Minor
>
> Steps to regenerate issue:
> 1. Go to SFA component (https://localhost:8443/sfa/control/main)
> 2. Click on sub-menu "Leads" (https://localhost:8443/sfa/control/FindLeads)
> Following error in logs:
> {code:java}
> 2017-08-22 08:59:50,496 |Finalizer|EntityListIterator
> |E| 
> ==
> EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], 
> caught in Finalize
> ==
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9620) Extend SecurityGroup entity and add name/groupName field

2017-09-23 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-9620.


> Extend SecurityGroup entity and add name/groupName field 
> -
>
> Key: OFBIZ-9620
> URL: https://issues.apache.org/jira/browse/OFBIZ-9620
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9620.patch
>
>
> Currently, SecurityGroup entity has groupId and description fields in that, 
> it should also have groupName/name field as well, as a description can be 
> very long and groupName can be used to represent SecurityGroup in a better 
> manner.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9696) Fix type entities to follow convention of hasTable

2017-09-23 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177737#comment-16177737
 ] 

Arun Patidar commented on OFBIZ-9696:
-

Committed changes in rev: 1809396.

Also, added data update queries to confluence page: 
https://cwiki.apache.org/confluence/x/LoBr

Thanks Aman Agrawal for your contribution.

> Fix type entities to follow convention of hasTable
> --
>
> Key: OFBIZ-9696
> URL: https://issues.apache.org/jira/browse/OFBIZ-9696
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9696-2.patch, OFBIZ-9696.patch
>
>
> 'hasTable' field of 'Type' entities is used to give an idea that detail 
> entity exists or not. We generally get the name of detail entity on the basis 
> of typeId field value. 
> For example : 
> ContactMechType,contactMechTypeId = "POSTAL_ADDRESS"  then we go to 
> PostalAddress for detail.
> similarly,
> ContactMechType,contactMechTypeId = "TELECOM_NUMBER"  then we go to 
> TelecomNumber for detail.
> We should follow the naming convention.
> Below are some entities that are not following the pattern. Some of them are:
>- ShipmentGatewayConfigType
>- PaymentGatewayConfigType



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9760) Using Bootstrap Framework for E-Commerce Website

2017-09-23 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177745#comment-16177745
 ] 

Deepak Dixit commented on OFBIZ-9760:
-

Taher Comments from Dev List

=
Essentially there are only certain locations in the ecommerce
component that require bling bling and fancy UI, and even some of
those can be done through Macros for the benefit of using them
elsewhere in the framework. So perhaps maybe we should think of the
items below in implementing what is proposed in this thread:
- If the feature is easy and straight forward, then the widget
implementation can be pure.
- If the feature is difficult, then it depends:
  - is it worth introducing in other components? If yes, it's better
to enhance the widget system by having XML translation to freemarker
macros
  - is it specific to the e-commerce component and not reusable
elsewhere? Then yeah fine drop down to  and do
your thing

The above approach might give us some advantages like:
- Reducing complexity: As it stands, I find the e-commerce component
to be one of the most challenging components to maintain and develop
because of the handcrafted interface
- Reuse: If we are apply the implementation through macros then we can
reuse everything in themes which means other components gain value
automatically.
- Reducing fragmentation: Having e-commerce behave one way and other
components behave another way is an added layer of complexity that can
be avoided if we work at the underlying widget infrastructure level.

Overall, good initiative. I'm always attracted first and foremost to
DRY so whenever people make suggestions for improvement the automatic
first thought in my mind is ... well how can we unify that everywhere.

Cheers
=


> Using Bootstrap Framework for E-Commerce Website
> 
>
> Key: OFBIZ-9760
> URL: https://issues.apache.org/jira/browse/OFBIZ-9760
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Saurabh Dixit
>Assignee: Saurabh Dixit
>
> Use of the bootstrap framework so that the UI of the e-commerce would be more 
> arranged and user-friendly



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9765) While fetching product inventory, it shoudl also return accounting quantity as well

2017-09-23 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-9765:


 Summary: While fetching product inventory, it shoudl also return 
accounting quantity as well
 Key: OFBIZ-9765
 URL: https://issues.apache.org/jira/browse/OFBIZ-9765
 Project: OFBiz
  Issue Type: Improvement
 Environment: Accounting quantity should also be returned while 
fetching product inventory total.
Reporter: Suraj Khurana
Assignee: Suraj Khurana






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9760) Using Bootstrap Framework for E-Commerce Website

2017-09-23 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177769#comment-16177769
 ] 

Jacques Le Roux commented on OFBIZ-9760:


Hi Deepak, 

I agree with Taher, but I can't find his email in dev ML, do you have a link?

> Using Bootstrap Framework for E-Commerce Website
> 
>
> Key: OFBIZ-9760
> URL: https://issues.apache.org/jira/browse/OFBIZ-9760
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Saurabh Dixit
>Assignee: Saurabh Dixit
>
> Use of the bootstrap framework so that the UI of the e-commerce would be more 
> arranged and user-friendly



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9604) Documentation: Product Information Management (PIM) Process Overview

2017-09-23 Thread Archana Asthana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1613#comment-1613
 ] 

Archana Asthana commented on OFBIZ-9604:


Reviewed the [PIM Process Overview|https://cwiki.apache.org/confluence/x/TpJjB] 
and made few edits in the document. 

> Documentation: Product Information Management (PIM) Process Overview
> 
>
> Key: OFBIZ-9604
> URL: https://issues.apache.org/jira/browse/OFBIZ-9604
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Humera Khan
>Assignee: Humera Khan
>  Labels: BPRB, OBPRB, PIM
>
> Product Information Management process overview to be documented.
> *Doc Content*
> Every Product Information Management business activity to be covered with 
> below-given headings-
> - Process Overview
> - Business Purpose (significance of having efficient Product Information 
> Management capabilities in real world)
> - Activity Diagrams (Level-1,2, and 3 as applicable to demonstrate the 
> process flow)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9358) Integrating google phone number library for validating telecom numbers

2017-09-23 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-9358.
---
   Resolution: Fixed
Fix Version/s: Upcoming Release

Committed in trunk at revision 1809412.

Thanks Suraj Khurana and Renuka Srishti for your contribution.

> Integrating google phone number library for validating telecom numbers
> --
>
> Key: OFBIZ-9358
> URL: https://issues.apache.org/jira/browse/OFBIZ-9358
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Release
>Reporter: Suraj Khurana
>Assignee: Arun Patidar
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9358.patch, OFBIZ-9358.patch, OFBIZ-9358.patch, 
> OFBIZ-9358.patch, OFBIZ-9358.patch
>
>
> As per discussion at 
> https://lists.apache.org/list.html?d...@ofbiz.apache.org:lte=1M:Validating%20telecom%20numbers
> Need to integrate Google telephone number to validate telephone numbers 
> formats of various countries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9760) Using Bootstrap Framework for E-Commerce Website

2017-09-23 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1610#comment-1610
 ] 

Deepak Dixit commented on OFBIZ-9760:
-

Ahh,

I think Taher did reply instead of reply-all, I replied on it and included user 
mailing list. 

> Using Bootstrap Framework for E-Commerce Website
> 
>
> Key: OFBIZ-9760
> URL: https://issues.apache.org/jira/browse/OFBIZ-9760
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Saurabh Dixit
>Assignee: Saurabh Dixit
>
> Use of the bootstrap framework so that the UI of the e-commerce would be more 
> arranged and user-friendly



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9678) Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId in UserPreference entity

2017-09-23 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9678.
--
Resolution: Implemented

Yes thanks Deepak, forgot it :)

> Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId 
> in UserPreference entity
> 
>
> Key: OFBIZ-9678
> URL: https://issues.apache.org/jira/browse/OFBIZ-9678
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9678.patch, OFBIZ-9678.patch
>
>
> UserPreference.userLoginId is related to UserLogin.userLoginId.
> UserPreference.userPrefGroupTypeId is related to 
> UserPrefGroupType.userPrefGroupTypeId.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9604) Documentation: Product Information Management (PIM) Process Overview

2017-09-23 Thread Humera Khan (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1618#comment-1618
 ] 

Humera Khan commented on OFBIZ-9604:


Thanks Archana for review and modifications.

I have added level 3 diagram of 'Create Product Store' and 'Create Category' 
process [here|https://cwiki.apache.org/confluence/x/TpJjB] , next I will be 
added the diagrams for all the possible associations with the product.

> Documentation: Product Information Management (PIM) Process Overview
> 
>
> Key: OFBIZ-9604
> URL: https://issues.apache.org/jira/browse/OFBIZ-9604
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Humera Khan
>Assignee: Humera Khan
>  Labels: BPRB, OBPRB, PIM
>
> Product Information Management process overview to be documented.
> *Doc Content*
> Every Product Information Management business activity to be covered with 
> below-given headings-
> - Process Overview
> - Business Purpose (significance of having efficient Product Information 
> Management capabilities in real world)
> - Activity Diagrams (Level-1,2, and 3 as applicable to demonstrate the 
> process flow)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-8323) can enter empty content for product facility

2017-09-23 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-8323.


> can enter empty content for product facility
> 
>
> Key: OFBIZ-8323
> URL: https://issues.apache.org/jira/browse/OFBIZ-8323
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Rishi Solanki
> Fix For: Upcoming Release, Release Branch 16.11
>
> Attachments: OFBIZ-8323.patch
>
>
> -go to 
> https://localhost:8443/catalog/control/EditProductFacilities?productId=WG-9943
> -click on add button.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9490) Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and formatting can be done, rather than system providing all ruleset support.

2017-09-23 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177791#comment-16177791
 ] 

Arun Patidar commented on OFBIZ-9490:
-

Committed revision 1809425.

Thanks Pradhan Yash Sharma for your contribution.

> Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and 
> formatting can be done, rather than system providing all ruleset support.
> --
>
> Key: OFBIZ-9490
> URL: https://issues.apache.org/jira/browse/OFBIZ-9490
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: 16.11.03
>Reporter: Pradhan Yash Sharma
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-9490.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9754) Required field indicator (*) is missing from create web site parties.

2017-09-23 Thread Rohit Rai (JIRA)
Rohit Rai created OFBIZ-9754:


 Summary: Required field indicator (*) is missing from create web 
site parties.
 Key: OFBIZ-9754
 URL: https://issues.apache.org/jira/browse/OFBIZ-9754
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Reporter: Rohit Rai
Assignee: Rohit Rai


1. Go to content -> websites
2. Find websites and select a website from the list.
3. Required field indicator for party id is missing from create web site 
parties,
direct link,
https://localhost:8443/content/control/createWebSiteRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-7328) Promotion is applied multiple times in case of Order Flat Amount action

2017-09-23 Thread Mridul Pathak (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mridul Pathak reassigned OFBIZ-7328:


Assignee: Mridul Pathak  (was: Aditi Patidar)

> Promotion is applied multiple times in case of Order Flat Amount action
> ---
>
> Key: OFBIZ-7328
> URL: https://issues.apache.org/jira/browse/OFBIZ-7328
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Vishal Chhabria
>Assignee: Mridul Pathak
>
> Steps to regenerate - 
> Create a promotion with 
> condition - > cart subtotal greater than equal to zero.
> action - > Order Amount Flat - 10
> Expected - 10 $ should be deducted from cart.
> Actual - Promotion keeps on applying unless cart amount reaches 0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-1585) Credit card valdation does not work properly during anonymous quick checkout process

2017-09-23 Thread Amit Gadaley (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley reassigned OFBIZ-1585:
---

Assignee: Amit Gadaley  (was: Divesh Dutta)

> Credit card valdation does not work properly during anonymous quick checkout 
> process
> 
>
> Key: OFBIZ-1585
> URL: https://issues.apache.org/jira/browse/OFBIZ-1585
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
> Environment: Ubuntu 7.10, Firefox 2.0.0.11
>Reporter: Raj Saini
>Assignee: Amit Gadaley
>Priority: Minor
> Attachments: credit-card-validation2.png, credit-card-validation.png, 
> OFBIZ-1585.patch, OFBIZ-1585.patch
>
>
> If a credit card is selected as payment method and process button is pressed 
> without adding all mandatory fields of credit card, order will be summited 
> despite showing the validation error on credit card and user have no choice 
> of rectifying the validation errors. 
> Screenshot is attached showing this behavior 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


  1   2   >