[Differential] [Commented On] D2156: improve output identification

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  I have two identical screens set up as part of my 3 monitor set. I can test 
this.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: lbeltrame, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2156: improve output identification

[Sebastian Kügler]

sebas added a comment.


  I'd like to get some feedback on the approach, however. I think this is
  actually a nice minimal fix, as we can't really change how the id is 
generated. I may be missing something here.
  
  This obviously needs some testing. It shouldn't break existing setups, but I 
can't really verify if it actually works, since I don't have identical screens. 
In *theory*, I think this is a sound fix for this quite serious bug.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 21 lines] D2156: improve output identification

[Sebastian Kügler]

sebas created this revision.
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When identical outputs (i.e. outputs with the same edid) are connected,
  the serializer can't match the outputs solely by their id, it will most
  likely return the wrong one and set that up.
  
  In this case, we also compare the output's name with the name saved in
  the config: this one is different for every monitor.
  
  This change should allow to configure and restore setups with identical
  screens connected.
  
  BUG:325277

TEST PLAN
  Only compile-tested so far. I'm running out of nightly hours.

REPOSITORY
  rKSCREEN KScreen

BRANCH
  identicalmonitors

REVISION DETAIL
  https://phabricator.kde.org/D2156

AFFECTED FILES
  kded/serializer.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 20 lines] D2154: kscreen kcm: block changed signal after save

[Sebastian Kügler]

sebas updated this revision to Diff 5139.
sebas added a comment.


  - use compile-time connection

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2154?vs=5137=5139

BRANCH
  blockkcmchanges

REVISION DETAIL
  https://phabricator.kde.org/D2154

AFFECTED FILES
  kcm/src/kcm_kscreen.cpp
  kcm/src/kcm_kscreen.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 10 lines] D2155: kded: fix up invalid current mode before saving

[Sebastian Kügler]

sebas created this revision.
sebas added a reviewer: graesslin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When resizing a virtual machine, the current mode may become invalid.
  In this case, we set the current mode id to the preferred modes and
  avoid failing canBeApplied.
  
  CCBUG:356864

TEST PLAN
  Only compile-tested

REPOSITORY
  rKSCREEN KScreen

BRANCH
  fixupmodeid

REVISION DETAIL
  https://phabricator.kde.org/D2155

AFFECTED FILES
  kded/daemon.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 16 lines] D2154: kscreen kcm: block changed signal after save

[Sebastian Kügler]

sebas created this revision.
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When changing position (and potentially other properties) of the screen
  setup, we receive delayed signals way after the sync operation finishes.
  This enables the apply button after the config has been applied, leading
  to the apply/discard confirmation dialog when closing (or navigating
  away from) the kscreen kcm.
  
  This patch disables propagation of the changed() signal at the highest
  level, meaning that config widgets internally still get updated, but the
  apply button only gets enabled after 1000 milliseconds. This magic value
  is what I've figured out by testing. It's long enough to re-request edid
  information on two outputs, but short enough to get in the way from
  further changes.
  
  I'm not super-happy with the timer, but I don't see any other way to fix
  this glitch in the user experience. We don't really have a way on X11 to
  know when all changes are flushed.
  
  BUG:365467

TEST PLAN
  Tested systemsettings and kcmshell, with this patch, it works reliably and 
doesn't get in the way.

REPOSITORY
  rKSCREEN KScreen

BRANCH
  blockkcmchanges

REVISION DETAIL
  https://phabricator.kde.org/D2154

AFFECTED FILES
  kcm/src/kcm_kscreen.cpp
  kcm/src/kcm_kscreen.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The situation of KWallet, and what to do about it?

[Albert Astals Cid]

El dimecres, 13 de juliol de 2016, a les 11:41:14 CEST, Thomas Pfeiffer va 
escriure:
> On Linux we could use GNOME Keyring, but if we don't want that, we'd of
> course still have to implement our own backend. 

We could implement our own backend, and call it ... kwallet? :D

SCNR

Cheers,
  Albert
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The situation of KWallet, and what to do about it?

[Albert Astals Cid]

El dijous, 7 de juliol de 2016, a les 12:36:26 CEST, Thomas Pfeiffer va 
escriure:
> Hi everyone,
> I'm addressing both the Plasma team and kde-devel because this issue affects
> Plasma as well as many applications, and Valentin as the current maintainer
> of KWallet as well as KSecretService, a potential replacement for it.
> 
> KWallet plays a central role in Plasma and many KDE applications as the
> central password storage. However, it being very old and not having been
> actively developed for a long time, it has lots of problems, including:
> 
> - It has weak security, as it does not restrict applications accessing it by
> default, and even when it does, it does so simply based on application name
> which allows any malicious process to impersonate an allowed one

This is basically because "Linux sucks" and no other solution different than 
kwallet can do it better unless you go to a "full lockdown" mode of who and 
how you can start applications (i.e. like on the Ubuntu Phone only upstart can 
start applications).

Yes, it is unfortunate but it has to do with the fact that we don't control 
the OS we run on.

Cheers,
  Albert
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The situation of KWallet, and what to do about it?

[Albert Astals Cid]

El dijous, 7 de juliol de 2016, a les 18:43:57 CEST, Elvis Angelaccio va 
escriure:
> Hi,
> thanks for raising this topic!
> 
> 2016-07-07 12:36 GMT+02:00 Thomas Pfeiffer :
> > Hi everyone,
> > I'm addressing both the Plasma team and kde-devel because this issue
> > affects Plasma as well as many applications, and Valentin as the current
> > maintainer of KWallet as well as KSecretService, a potential replacement
> > for it.
> > 
> > KWallet plays a central role in Plasma and many KDE applications as the
> > central password storage. However, it being very old and not having been
> > actively developed for a long time, it has lots of problems, including:
> > 
> > - It has weak security, as it does not restrict applications accessing it
> > by default, and even when it does, it does so simply based on application
> > name which allows any malicious process to impersonate an allowed one
> > - The initial setup has huge usability problems, as it forces users to
> > make
> > a choice on a very advanced technical level (encryption methods, no
> > less!),
> > and the option it suggests (GPG) is a nightmare to set up for ordinary
> > users - It does support unlocking via PAM, but does not tell users what
> > they need to do to make that work, which results in most users having to
> > enter the KWallet password at each system start, which many find very
> > annoying (we get lots of negative feedback for that)
> > - It works only with KDE Frameworks-based applications
> > - One cannot easily write a QML GUI for it, making it unsuitable for
> > mobile
> > 
> > Valentin has been working on KSecretService for quite a while, which is
> > based on the freedesktop Secrets API [1] that is also supported in GNOME
> > Keyring, and would solve many (and ideally all) of the above problems.
> > However, Valentin told me he does not have the time to work on
> > KSecretService any more.
> > 
> > This means we have to find a solution to these problems. The options I see
> > currently are
> > - Improve KWallet (unlikely to fix all the problems without massive
> > changes
> > in it, though)
> > - Find someone to finish and maintain KSecretService
> > - Build a wrapper around one of the other existing keyring technologies
> > - Each application (and each Plasma component that stores passwords)
> > implements its own encrypted password storage
> > 
> > 
> > - We make encrypted password storage optional and non-default (easiest
> > solution, but not exactly in line with KDE's vision)
> 
> I disagree on this point. Even if KWallet were free of usability
> issues, it would still provide a false sense of security. The user
> thinks that his/her passwords are safe, while in fact they are not.

How exactly the passwords are not safe?

Cheers,
  Albert

> If we don't have enough manpower to develop and mantain a proper
> keychain in Plasma, we should tell our users. This way they can make
> sure that, for example, the unsafely stored Wi-Fi passphrase is not
> used for other accounts. This is already closer to our vision than the
> current situation.
> 
> My vote is: we either do it right, or we give up. If someone steps up
> to fix this problem, great. Otherwise we should start to slowly port
> away from KWallet.
> 
> > So, what do we do?
> > 
> > Cheers,
> > Thomas
> 
> Cheers,
> Elvis
> 
> > https://www.freedesktop.org/wiki/Specifications/secret-storage-spec/secret
> > s-api-0.1.html


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: versioned dependencies on breeze

[Antonio Rojas]

Martin Graesslin wrote:

> Well if KWin depends on Breeze you cannot parallel build KWin and Breeze.
> That should be obvious.

It could be theoretically possible to build Kwin and Breeze 5.7.1 in 
parallel against 5.7.0 packages if the dependencies were not versioned 
(actually parallel build was just an example - our main issue is that this 
makes it harder to build packages in a clean chroot)
 
> It does not make sense to have KWin depend on a Breeze of the previous
> version. Neither plasma-integration. Thus I even think that from a
> technical point of view that would be wrong.
> 

Not sure if it makes sense or not, just pointing out that this makes things 
harder for packagers.

It just seems strange to me that the dependency on Breeze (which is used to 
set the default style and doesn't actually use any API) is versioned, while 
for instance the dependency on libKWorkspace in plasma-desktop or 
powerdevil, which should be much more sensitive to API changes, is not 
versioned.

Perhaps a compromise could be to depend on the latest major version of the 
modules (since it seems unlikely that a bug fix release would break things)


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2112: Add a shortcut for Meta+P

[Sebastian Kügler]

sebas added a comment.


  For the record, this change has been backported to Plasma 5.7, shipped with 
5.7.1.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2112

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, davidedmundson, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2033: Clear idle timeouts when session becomes inactive

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Don't worry, Oliver, I actually wasn't going to push this before I had 
further feedback from you. :)
  
  I'll address the clear all idle timeouts call (oh, how I wish I had already 
done the powerdevil-as-separate-binary thing) and then should be good to go, 
minus the erase iterator part.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2033

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, sebas, oliverhenshaw
Cc: sebas, oliverhenshaw, graesslin, plasma-devel, jensreuterberg, abetts
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2073: Add a KCM setting to control pulse audio module combine-sinks

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAPA65b7db38: Add a KCM setting to control pulse 
audio module combine-sinks (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2073?vs=5135=5136#toc

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2073?vs=5135=5136

REVISION DETAIL
  https://phabricator.kde.org/D2073

AFFECTED FILES
  src/CMakeLists.txt
  src/gconfitem.cpp
  src/gconfitem.h
  src/kcm/package/contents/ui/CardView.qml
  src/modulemanager.cpp
  src/modulemanager.h
  src/qml/plugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, drosca
Cc: drosca, broulik, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 626 lines] D2073: Add a KCM setting to control pulse audio module combine-sinks

[davidedmundson (David Edmundson)]

davidedmundson updated this revision to Diff 5135.
davidedmundson added a comment.


  spaces

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2073?vs=5134=5135

BRANCH
  qgconf

REVISION DETAIL
  https://phabricator.kde.org/D2073

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/gconfitem.cpp
  src/gconfitem.h
  src/kcm/package/contents/ui/CardView.qml
  src/modulemanager.cpp
  src/modulemanager.h
  src/qml/plugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, drosca
Cc: drosca, broulik, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Requested Changes To] D2033: Clear idle timeouts when session becomes inactive

[oliverhenshaw (Oliver Henshaw)]

oliverhenshaw requested changes to this revision.
oliverhenshaw added a reviewer: oliverhenshaw.
oliverhenshaw added a comment.
This revision now requires changes to proceed.


  I may not have much pull, but I'd rather these changes were revised again 
before being landed. Sorry!
  
  Note that although this is the right thing to do, the bug reporter found this 
change did not fix their problem - 
https://bugs.kde.org/show_bug.cgi?id=354250#c25 . I haven't tested it myself 
but it makes sense that the call to erase idle timeouts will eventually make 
xlib calls, which will block if your xserver is blocked (which it seems to for 
some users when switched to another VT)

INLINE COMMENTS

> powerdevilcore.cpp:141-143
> +// Bug 354250: Simulate user activity when session becomes inactive,
> +// this keeps us from sending the computer to sleep when switching to an 
> idle session.
> +// (this is just being lazy as it will result in us clearing everything

This comment should reflect that this is actively a good choice and not just a 
workaround for a corner case. IIRC the policyagent will forbid actions when the 
session is not active so not scheduling idle timeouts is just good efficiency.

> oliverhenshaw wrote in powerdevilcore.cpp:151
> Like you said, other kidletime users might not care whether the session is 
> active or not. This will remove all timeouts set by other kded services, 
> right?
> 
> Just off the top of my head, Is ActionPool::unloadAllActiveActions() better 
> here, or is that not appropriate? It's too late in the day here for me to 
> look into that today.

Again, removeAllIdleTimeouts is too big a hammer, when  arbitrary other kded 
services use the same kidletime instance.

> powerdevilcore.cpp:777-780
> +for (auto it = m_pendingResumeFromIdleActions.constBegin(), end = 
> m_pendingResumeFromIdleActions.constEnd(); it != end; ++it) {
> +(*it)->onWakeupFromIdle();
>  }
> +m_pendingResumeFromIdleActions.clear();

It would be better for this set of changes to have its own review and own 
commit message.

Also how can this solve a crash bug? I'm speculating wildly here, but: As far 
as I can see, using the iterator returned by erase() should be safe. Unless 
there's not really an implicit null pointer check in the while loop and the 
compiler optimises it away? Or perhaps onWakeFromIdle() for some action ends up 
invalidating the iterator somehow, possibly if it re-enters another instance of 
onResumingFromIdle()? If so, clearing m_pendingResumeFromIdleActions is 
definitely wrong because there could well have been a nested call to 
onKIdleTimeoutReached()

Either way, the real bug is somewhere else.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2033

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, sebas, oliverhenshaw
Cc: sebas, oliverhenshaw, graesslin, plasma-devel, jensreuterberg, abetts
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2073: Add a KCM setting to control pulse audio module combine-sinks

[drosca (David Rosca)]

drosca accepted this revision.
drosca added a comment.
This revision is now accepted and ready to land.


  Please fix that last style issue and push, thanks!

INLINE COMMENTS

> modulemanager.h:42
> +public:
> +ModuleManager(QObject *parent=nullptr);
> +~ModuleManager();

This needs spaces around = `*parent = nullptr`

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  qgconf

REVISION DETAIL
  https://phabricator.kde.org/D2073

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, drosca
Cc: drosca, broulik, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Abandoned] D2092: Fix icon loading in Widget Explorer

[davidedmundson (David Edmundson)]

davidedmundson abandoned this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2092

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson
Cc: broulik, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 626 lines] D2073: Add a KCM setting to control pulse audio module combine-sinks

[davidedmundson (David Edmundson)]

davidedmundson updated this revision to Diff 5134.
davidedmundson added a comment.


  Addressed David's comments

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2073?vs=5133=5134

BRANCH
  qgconf

REVISION DETAIL
  https://phabricator.kde.org/D2073

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/gconfitem.cpp
  src/gconfitem.h
  src/kcm/package/contents/ui/CardView.qml
  src/modulemanager.cpp
  src/modulemanager.h
  src/qml/plugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, drosca
Cc: drosca, broulik, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Requested Changes To] D2073: Add a KCM setting to control pulse audio module combine-sinks

[drosca (David Rosca)]

drosca requested changes to this revision.
drosca added a reviewer: drosca.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> modulemanager.cpp:33
> +QObject(parent),
> +m_combineSinksConfig(new GConfItem(PA_GCONF_PATH_MODULES"/combine", 
> this))
> +{

Can this be QStringLiteral?

> modulemanager.cpp:35
> +{
> +connect(m_combineSinksConfig, ::subtreeChanged , this, 
> ::combineSinksChanged);
> +}

remove space before comma: `::subtreeChanged ,`

> modulemanager.cpp:45
> +{
> +return m_combineSinksConfig->value("enabled").toBool();
> +}

QStringLiteral

> modulemanager.h:42
> +public:
> +ModuleManager(QObject *parent=0);
> +~ModuleManager();

*parent = nullptr

> modulemanager.h:50
> +
> +protected:
> +private:

remove

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2073

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, drosca
Cc: drosca, broulik, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 627 lines] D2073: Add a KCM setting to control pulse audio module combine-sinks

[davidedmundson (David Edmundson)]

davidedmundson updated this revision to Diff 5133.
davidedmundson added a comment.


  Coding style changes

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2073?vs=4919=5133

BRANCH
  qgconf

REVISION DETAIL
  https://phabricator.kde.org/D2073

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/gconfitem.cpp
  src/gconfitem.h
  src/kcm/package/contents/ui/CardView.qml
  src/modulemanager.cpp
  src/modulemanager.h
  src/qml/plugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: drosca, broulik, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 252 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/252/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 17:02:41 +
Build duration: 17 min

CHANGE SET
Revision 3e0c3f4db409d11361162f249ae5006e4a57a324 by hein: (Move formerly 
launcher-backed window tasks out of launcher area on)
  change: edit libtaskmanager/tasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5305 
(37%)CONDITIONAL 1382/5456 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3030 (5%)CONDITIONAL 
88/3183 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 251 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/251/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 16:49:39 +
Build duration: 12 min

CHANGE SET
Revision c3941de089b886d4fbfcc99bfec0bc62e03db894 by hein: (Fix edge case with 
launchInPlace + SortManual + group.)
  change: edit libtaskmanager/tasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5301 
(37%)CONDITIONAL 1382/5446 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3026 (5%)CONDITIONAL 
88/3173 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 39 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 17:01:15 +
Build duration: 41 sec

CHANGE SET
Revision 3e0c3f4db409d11361162f249ae5006e4a57a324 by hein: (Move formerly 
launcher-backed window tasks out of launcher area on)
  change: edit libtaskmanager/tasksmodel.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 38 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/38/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 16:47:19 +
Build duration: 44 sec

CHANGE SET
Revision c3941de089b886d4fbfcc99bfec0bc62e03db894 by hein: (Fix edge case with 
launchInPlace + SortManual + group.)
  change: edit libtaskmanager/tasksmodel.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 250 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/250/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 16:33:53 +
Build duration: 12 min

CHANGE SET
Revision c7732a7cfbbd52aee3facc426cf1a24f6e21d78a by hein: (Fix warning.)
  change: edit libtaskmanager/xwindowtasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5299 
(37%)CONDITIONAL 1382/5446 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3024 (5%)CONDITIONAL 
88/3173 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 29 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 16:43:09 +
Build duration: 1 min 6 sec

CHANGE SET
Revision a1378f8591691ecf32ab4b87349d2037ae9c569a by hein: (Fix managing 
separateLaunchers prop for Icontasks.)
  change: edit applets/taskmanager/package/contents/ui/main.qml
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 37 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 16:33:23 +
Build duration: 4 min 8 sec

CHANGE SET
Revision c7732a7cfbbd52aee3facc426cf1a24f6e21d78a by hein: (Fix warning.)
  change: edit libtaskmanager/xwindowtasksmodel.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 249 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/249/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 15:46:42 +
Build duration: 12 min

CHANGE SET
Revision 70e2684cace606dae1621034dd02f1605b26723c by Marco Martin: (create a 
containment per screen on activity creation)
  change: edit shell/shellcorona.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5299 
(37%)CONDITIONAL 1382/5446 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3024 (5%)CONDITIONAL 
88/3173 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 36 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/36/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 15:46:22 +
Build duration: 5 min 57 sec

CHANGE SET
Revision 70e2684cace606dae1621034dd02f1605b26723c by Marco Martin: (create a 
containment per screen on activity creation)
  change: edit shell/shellcorona.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] WindowMetadata framework fundamentals

[Thomas Pfeiffer]

Hi sebas,


On 13.07.2016 02:18, Sebastian Kügler wrote:

During the Plasma sprint in March, we've been fleshing out plans to create a
mechanisms for apps to be represented by the shell.

The goals it to achieve a richer integration between apps and the workspace.
The idea is that windows can announce a richer set of metadata that can be
used to enhance the window's representation in the workspace/shell. Think of

- task switchers with more meaningful thumbnails of better quality

Exciting times :)

- server-side decoration actions to "remote-control" the app
- user-visible features similar to the mpris-controls in the task bar

So does that mean that parts (or all) of the DWD ideas will be implemented
using WindowMetadata?

- currently open document

Don't most applications expose that in their window title, anyway?

More thoughts on this are explained on this wiki page
https://community.kde.org/KWin/Window_Metadata (which is not quite up-to-date
with the implementation I'm proposing here).

These features are achieved by using D-Bus for client-server communication.

I've written some basic components that provide the basic mechanisms for that.
There's a library for the clients, one for the server, qtquick components for
both sides, autotests and interactive testing apps. The functionality is
fairly slim, I've only implemented to allow apps to announce titles and
thumbnails. The title property is rather simple, the thumbnail property is a
bit more involved -- the server (compositor, task manager, task switcher,
etc.) requests thumbnails to be passed via a connection-private file
descriptor and communicates the semantics over D-Bus.

Here's a run-down of what's currently there. I think it provides a good base
for the above goals. It's not complete by any means, api docs are also missing
still (I expect some semantics to change).

Attached, find a README.md file that explains the implementation and its
components.

The code can be found in the kde:scratch/sebas/windowmetadata repository.

Feedback is most welcome.

The caveat that writing text into the thumbnail is problematic is a pretty big 
problem
from my perspective. For example in a text editor, I don't see how relevant 
information
can be represented by a "pretty picture". I'd rather put e.g. the first X 
characters into

the thumbnail there, so that even if the document does not have a name yet, it 
can
be recognized by its context.
Or in a terminal I'd show the last output line or something.
Outside of graphics applications or media players, I don't see how anything 
without text

is supposed to transport meaningful information.

Isn't there any way to work around the DPI problem?
If not, I'd suggest to allow the application to choose whether it wants a 
thumbnail or text

to be shown. Then graphical applications could render a thumbnail, while most 
others
would just make it show text.

I'm super-excited to see the window metadata idea come to life, as it promises 
tons of
possibilities. It would be sad if we'd limit these possibilities by restricting 
ourselves to

"pretty pictures". The goal is to create actually useful thumbnails, after all.

Hope that helps!

- Thomas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Andreas Kainz]

> On Juli 13, 2016, 12:04 nachm., Thomas Pfeiffer wrote:
> > kcms/phonon/kcm_phonon.desktop, line 13
> > 
> >
> > It does also contain settings for video recording devices, so it is not 
> > just audio.

this kcm confuse me to be honest.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/#review97343
---


On Juli 13, 2016, 8:26 vorm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128434/
> ---
> 
> (Updated Juli 13, 2016, 8:26 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> change see in the diff
> 
> 
> Diffs
> -
> 
>   kcms/baloo/kcm_baloofile.desktop 919fc8e 
>   kcms/desktoppaths/desktoppath.desktop 2567c76 
>   kcms/keys/keys.desktop ac6afb6 
>   kcms/ksmserver/kcmsmserver.desktop 8ed358b 
>   kcms/phonon/kcm_phonon.desktop ed804a3 
>   kcms/standard_actions/standard_actions.desktop a454dbd 
>   kcms/translations/translations.desktop daf9469 
> 
> Diff: https://git.reviewboard.kde.org/r/128434/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> adjustments
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Andreas Kainz]

> On Juli 13, 2016, 12:04 nachm., Thomas Pfeiffer wrote:
> > kcms/baloo/kcm_baloofile.desktop, line 15
> > 
> >
> > Hm, I'm not sure. From a user's perspective, it's relevant where the 
> > search can find things, "indexing" is more of an implementation detail for 
> > the user.

but there is plasma search and file search, maybe you find a better name for 
plasma search. for me plasma search is something like I'd like to search 
(where) and file search mean more wheren the search results come from -> 
indexed file. 

But I understand that File Indexing may be to technical. In win7 it's called 
index options but also change how windows searches


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/#review97343
---


On Juli 13, 2016, 8:26 vorm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128434/
> ---
> 
> (Updated Juli 13, 2016, 8:26 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> change see in the diff
> 
> 
> Diffs
> -
> 
>   kcms/baloo/kcm_baloofile.desktop 919fc8e 
>   kcms/desktoppaths/desktoppath.desktop 2567c76 
>   kcms/keys/keys.desktop ac6afb6 
>   kcms/ksmserver/kcmsmserver.desktop 8ed358b 
>   kcms/phonon/kcm_phonon.desktop ed804a3 
>   kcms/standard_actions/standard_actions.desktop a454dbd 
>   kcms/translations/translations.desktop daf9469 
> 
> Diff: https://git.reviewboard.kde.org/r/128434/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> adjustments
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Andreas Kainz]

> On Juli 13, 2016, 12:04 nachm., Thomas Pfeiffer wrote:
> > kcms/keys/keys.desktop, line 14
> > 
> >
> > I thought we wanted to have both in the same KCM, just under different 
> > headings?
> > We should only change that if we actually decide to split all 
> > application shortcuts out into a separate KCM.

good point. +1


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/#review97343
---


On Juli 13, 2016, 8:26 vorm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128434/
> ---
> 
> (Updated Juli 13, 2016, 8:26 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> change see in the diff
> 
> 
> Diffs
> -
> 
>   kcms/baloo/kcm_baloofile.desktop 919fc8e 
>   kcms/desktoppaths/desktoppath.desktop 2567c76 
>   kcms/keys/keys.desktop ac6afb6 
>   kcms/ksmserver/kcmsmserver.desktop 8ed358b 
>   kcms/phonon/kcm_phonon.desktop ed804a3 
>   kcms/standard_actions/standard_actions.desktop a454dbd 
>   kcms/translations/translations.desktop daf9469 
> 
> Diff: https://git.reviewboard.kde.org/r/128434/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> adjustments
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

[Painless Roaster]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128423/
---

(Updated Čec. 13, 2016, 1:13 odp.)


Review request for Plasma.


Bugs: https://bugs.kde.org/show_bug.cgi?id=361097

https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097


Repository: plasma-desktop


Description
---

fix rename file (or folder) in folder plugin (and desktop in folder mode)
 - enable multiline edit
 - fix size and position
 - fix escape from edit if user pressed Esc
 - fix suppress open file (or folder) if user clicked in editbox
 - fix size and position in popup mode


Diffs
-

  containments/desktop/package/contents/ui/FolderView.qml ced3507 

Diff: https://git.reviewboard.kde.org/r/128423/diff/


Testing
---


Thanks,

Painless Roaster

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128431: Fix race condition when new applications open

[Martin Tobias Holmedahl Sandsmark]

> On July 13, 2016, 10:44 a.m., Aleix Pol Gonzalez wrote:
> > Would it be possible to have a test there? It will be easier to review for 
> > us.

what would the test test?

nothing should call updateOrAddProcess(), ideally I'd just make it private, but 
I'm not sure how stable the libksysguard API is supposed to be.


- Martin Tobias Holmedahl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128431/#review97342
---


On July 12, 2016, 9:22 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128431/
> ---
> 
> (Updated July 12, 2016, 9:22 p.m.)
> 
> 
> Review request for Plasma and John Tapsell.
> 
> 
> Bugs: 261255
> https://bugs.kde.org/show_bug.cgi?id=261255
> 
> 
> Repository: libksysguard
> 
> 
> Description
> ---
> 
> When opening and closing an application quickly it sometimes got "stuck" in 
> ksysguard because it was added by ProcessModel while 
> Processes::processesUpdated() was running, so Processes never processed it.
> 
> 
> Diffs
> -
> 
>   processui/ProcessModel.cpp c55cea6 
> 
> Diff: https://git.reviewboard.kde.org/r/128431/diff/
> 
> 
> Testing
> ---
> 
> It doesn't happen anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Porting C++ plasmoid and dataengine to plasma5

[Simone Gaiarin]

Hi all,
time ago I've designed  a Plasma 4 plasmoid together with a dataengine to
configure and control a process (redshift).

The structure is the following:
- The plasmoid allow the user to start and stop the process, this is done
by running a servicejob to commmunicate the dataengine to take an action
- The dataengine controls the process (start and stop it) [I need a custom
dataengine and I cannot use the executable dataengine]
- Multiple instances of the plasmoid and the dataengine share the
configuaration via KConfigXT (Singleton) in this way when the user access
the plasmoid configuration this is propagated to the dataengine and synced
with other instances of the plasmoid

Now I want to port this to plasma 5 but I'm facing huge difficulties. I've
managed to port the dataengine, rewrite the CMakeFiles and I've partially
rewritten the apple in QML.

The problem now is how to manage the configuration.

I know that the plasmoid configuration can be accessed  via
plasmoid.configuration and that I can map the fields in main.xml to the ui
elements of the config dialog. The problem is how to synchronize this
configuration with the other instances of the plasmoid (each plasmoid has
his own configuration in plasma 5).
How to pass this configuration to the dataengine?
Any idea to do this in a simple way?

I've tried to extend my plasmoid with a C++ plugin so that in C++ I can
still use the old KConfigXT system in order to share a config file between
the plasmoid and the dataengine.

My current solution is pretty ugly but it works. It's the following:
- When the configuration of the plasmoid is edited (I check this throught
the signal userConfiguringChanged) I get the values from
plasmoid.configuration and send it to the plasmoid C++ plugin (with a
custom method writeConfig)
- The plasmoid C++ plugin use KonfigXT to save the configuration and emits
a signal myConfigChanged
- The plasmoid run the service job so that the dataengine can act
- From all the instances of the plasmoid I monitor the dataengine onNewData
signal and when it is catched I read the configuration from the C++ plugin
(with a custom method readConfig) and the plugin read it from disk

In the configuration of all the instances of the plasmoid and the
dataengine one are synchronized all the time. It's overly complicated
though compared to the plasma 4 solution.

Various doubt:
1) The plasmoid configuration system is explained here:
http://aseigo.blogspot.dk/2013/02/elegant-plasmoid-configuration.html. Is
it there any other page of documentation for this?

2) Which is the proper way to extend the QML plasmoid in C++. I've seen two
approaches.
- plasmoid.nativeInterface as suggested
in plasma-framework/templates/cpp-plasmoid/ (<- This should be documented
in techbase, it's quite hidden)
- The other as explained here
http://doc.qt.io/qt-5/qtqml-tutorials-extending-qml-example.html and how
I've seen implemented in many plasmoids

Regards
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/#review97343
---



See the inline comments. The things I've +1'd can be shipped from my perspective


kcms/baloo/kcm_baloofile.desktop (line 15)


Hm, I'm not sure. From a user's perspective, it's relevant where the search 
can find things, "indexing" is more of an implementation detail for the user.



kcms/keys/keys.desktop (line 14)


I thought we wanted to have both in the same KCM, just under different 
headings?
We should only change that if we actually decide to split all application 
shortcuts out into a separate KCM.



kcms/ksmserver/kcmsmserver.desktop (line 3)


+1



kcms/phonon/kcm_phonon.desktop (line 13)


It does also contain settings for video recording devices, so it is not 
just audio.



kcms/standard_actions/standard_actions.desktop (line 15)


+1



kcms/translations/translations.desktop (line 14)


+1


- Thomas Pfeiffer


On July 13, 2016, 8:26 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128434/
> ---
> 
> (Updated July 13, 2016, 8:26 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> change see in the diff
> 
> 
> Diffs
> -
> 
>   kcms/baloo/kcm_baloofile.desktop 919fc8e 
>   kcms/desktoppaths/desktoppath.desktop 2567c76 
>   kcms/keys/keys.desktop ac6afb6 
>   kcms/ksmserver/kcmsmserver.desktop 8ed358b 
>   kcms/phonon/kcm_phonon.desktop ed804a3 
>   kcms/standard_actions/standard_actions.desktop a454dbd 
>   kcms/translations/translations.desktop daf9469 
> 
> Diff: https://git.reviewboard.kde.org/r/128434/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> adjustments
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2102: Add support for xdg-shell

[Martin Gräßlin]

graesslin marked 9 inline comments as done.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  xdg-shell

REVISION DETAIL
  https://phabricator.kde.org/D2102

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, jensreuterberg, abetts
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2102: Add support for xdg-shell

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLANDb0acd7ad7539: Add support for xdg-shell (authored by 
graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2102?vs=5071=5120#toc

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2102?vs=5071=5120

REVISION DETAIL
  https://phabricator.kde.org/D2102

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_wayland_registry.cpp
  autotests/client/test_xdg_shell.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-shell-unstable-v5.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgshell.cpp
  src/client/xdgshell.h
  src/client/xdgshell_p.h
  src/client/xdgshell_v5.cpp
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/generic_shell_surface_p.h
  src/server/shell_interface.cpp
  src/server/shell_interface.h
  src/server/xdgshell_interface.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_interface_p.h
  src/server/xdgshell_v5_interface.cpp
  src/server/xdgshell_v5_interface_p.h
  src/tools/mapping.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, jensreuterberg, abetts
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2108: Add support for xdg-shell version 5 interface

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINc3af4c3f9cac: Add support for xdg-shell version 5 
interface (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2108?vs=5001=5121#toc

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2108?vs=5001=5121

REVISION DETAIL
  https://phabricator.kde.org/D2108

AFFECTED FILES
  autotests/integration/debug_console_test.cpp
  autotests/integration/decoration_input_test.cpp
  autotests/integration/dont_crash_no_border.cpp
  autotests/integration/input_stacking_order.cpp
  autotests/integration/kwin_wayland_test.h
  autotests/integration/scene_qpainter_test.cpp
  autotests/integration/shell_client_test.cpp
  autotests/integration/test_helpers.cpp
  shell_client.cpp
  shell_client.h
  wayland_server.cpp
  wayland_server.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 248 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/248/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 10:39:15 +
Build duration: 12 min

CHANGE SET
Revision 1fd011ae918d241140dcbbcddf7bde2d06f1b608 by hein: (Fix 
startup-to-window matchup based on AppName.)
  change: edit libtaskmanager/tasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5299 
(37%)CONDITIONAL 1382/5446 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3024 (5%)CONDITIONAL 
88/3173 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128431: Fix race condition when new applications open

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128431/#review97342
---



Would it be possible to have a test there? It will be easier to review for us.

- Aleix Pol Gonzalez


On July 12, 2016, 11:22 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128431/
> ---
> 
> (Updated July 12, 2016, 11:22 p.m.)
> 
> 
> Review request for Plasma and John Tapsell.
> 
> 
> Bugs: 261255
> https://bugs.kde.org/show_bug.cgi?id=261255
> 
> 
> Repository: libksysguard
> 
> 
> Description
> ---
> 
> When opening and closing an application quickly it sometimes got "stuck" in 
> ksysguard because it was added by ProcessModel while 
> Processes::processesUpdated() was running, so Processes never processed it.
> 
> 
> Diffs
> -
> 
>   processui/ProcessModel.cpp c55cea6 
> 
> Diff: https://git.reviewboard.kde.org/r/128431/diff/
> 
> 
> Testing
> ---
> 
> It doesn't happen anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 35 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 10:38:15 +
Build duration: 46 sec

CHANGE SET
Revision 1fd011ae918d241140dcbbcddf7bde2d06f1b608 by hein: (Fix 
startup-to-window matchup based on AppName.)
  change: edit libtaskmanager/tasksmodel.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The situation of KWallet, and what to do about it?

[Thomas Pfeiffer]

On 11.07.2016 22:29, Mark Gaiser wrote:
On Mon, Jul 11, 2016 at 9:58 PM, Thomas Pfeiffer > wrote:


On 07.07.2016 19:50, Kevin Ottens wrote:

There's two sides to that problem in fact, use from applications and the
service provided by our workspace.

I think that for applications the answer is neither KSecretService nor
KWallet, etc. For the goal of making it easier for our applications to 
be
shipped on more platforms, what we want in fact is to port them away 
from
anything platform specific to something like QtKeyChain:
https://inqlude.org/libraries/qtkeychain.html


This way, the actual storage becomes a workspace decision. That could 
keep
being KWallet if improved, or KSecretService, or a simple D-Bus service
wrapping libsecret... For sure it would at least simplify things on the
KWallet/KSecretService side, they wouldn't need to be frameworks anymore
(QtKeyChain or equivalent would play that role) just to expose a D-Bus 
API
(likely the Secret Service one in the end).


Oh, indeed, that would absolutely make sense! Deploying and using
applications which use KWallet outside of Plasma must be a pain right now.

So how do we make that happen? Deprecate the KWallet framework and
recommend to use QtKeyChain instead, and then in parallel decide which
bakcend to use for QtKeyChain in Plasma?


I don't get that. How is deprecating KWallet paves the way to make something 
new with QtKeyChain?


Of course deprecating KWallet alone does not do anything, but I think it will be 
necessary to "motivate" application developers to port away from it.


As far as i can tell, QtKeyChain isn't a keychain at all, it's a wrapper 
around platform specific keychains that provides a unified interface for 
keychain functionality. It itself doesn't implement a keychain (or it does on 
windows?).


Yes, QtKeychain wraps available keychains from the platform it runs on.
However: "Since Windows does not provide a service for secure storage QtKeychain 
uses the Windows API function CryptProtectData to encrypt the password with the 
user’s logon credentials. The encrypted data is then persisted via QSettings."


On Linux we could use GNOME Keyring, but if we don't want that, we'd of course 
still have to implement our own backend. The advantage would be that it would be 
much easier to replace that at any point without having to adapt applications.




Or do you mean deprecating/removing the *graphical* KWallet part and 
re-implementing that in top of QtKeyChain?


Yes, that's what I mean.


Using QtKeyChain would be interesting imho. Specially if that itself is 
extended to use other web backends as keychain.


Yes, that would be great!
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D1989#39559, @bdhruve wrote:
  
  > I am not getting how to proceed further now, can you please help me on 
this? Also, current confusion i have is, should kwin_wayland nested window 
appear when i run qmlscene? Because currently it does appear.
  
  
  No, it should not show. If it shows it means that it picks the wrong backend. 
This of course explains why the slot is not hit. It doesn't connect to the 
Wayland server you start thus it never tries to create a surface.
  
  Now the question is why it doesn't pick the right platform. The evaluation 
for that is in main_wayland.cpp - if I see correctly the problem is that there 
it's only checked for env variable WAYLAND_DISPLAY, but not also for 
WAYLAND_SOCKET.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, #plasma_on_wayland, graesslin
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2083: Use hiddenInternal() for a ShellClient which got unmapped

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINa35ffa93d7d3: Use hiddenInternal() for a ShellClient 
which got unmapped (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2083?vs=4938=5116

REVISION DETAIL
  https://phabricator.kde.org/D2083

AFFECTED FILES
  abstract_client.h
  autotests/integration/shell_client_test.cpp
  client.h
  composite.cpp
  input.cpp
  scene.cpp
  shell_client.cpp
  shell_client.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2084: [libkwineffects] Add signals windowShown and windowHidden to EffectsHandler

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN5ee958ca7e4c: [libkwineffects] Add signals windowShown 
and windowHidden to EffectsHandler (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2084?vs=4939=5117

REVISION DETAIL
  https://phabricator.kde.org/D2084

AFFECTED FILES
  autotests/integration/shell_client_test.cpp
  effects.cpp
  libkwineffects/kwineffects.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2085: [effects] Adjust SlidingPopups to new windowShown and windowHidden signals

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINc6b25627105a: [effects] Adjust SlidingPopups to new 
windowShown and windowHidden signals (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2085?vs=4940=5118#toc

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2085?vs=4940=5118

REVISION DETAIL
  https://phabricator.kde.org/D2085

AFFECTED FILES
  effects/slidingpopups/slidingpopups.cpp
  effects/slidingpopups/slidingpopups.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, kwin, hardening, jensreuterberg, abetts
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2059: Merge signal connections for AbstractClient in Workspace

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN445335ba5f33: Merge signal connections for AbstractClient 
in Workspace (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2059?vs=4888=5115

REVISION DETAIL
  https://phabricator.kde.org/D2059

AFFECTED FILES
  autotests/integration/shell_client_test.cpp
  wayland_server.cpp
  workspace.cpp
  workspace.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, kwin, hardening, jensreuterberg, abetts
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2085: [effects] Adjust SlidingPopups to new windowShown and windowHidden signals

[Martin Gräßlin]

graesslin marked an inline comment as done.

REPOSITORY
  rKWIN KWin

BRANCH
  sliding-popups-window-shown-hidden

REVISION DETAIL
  https://phabricator.kde.org/D2085

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, kwin, hardening, jensreuterberg, abetts
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1976: Image of the Day wallpaper plugin

[bgupta (Boudhayan Gupta)]

bgupta added a comment.


  I'll re-work a bunch of stuff, including image caching, and placement of 
credit text/logo based on where the panel is. Then I'll file a new revision.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D1976

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bgupta, #plasma, sebas
Cc: broulik, garg, sebas, graesslin, davidedmundson, plasma-devel, #plasma, 
jensreuterberg, abetts
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/
---

(Updated Juli 13, 2016, 8:26 vorm.)


Review request for Plasma.


Changes
---

renaming

Appearance/Application Style/GNOME Application Style (GTK) -> GNOME Applications
Workspace/Startup and Shutdown -> Service
Workspace/Startup and Shutdown/Desktop Session -> Session Management
Workspace/Startup and Shutdown/Login Screen (SDDM) -> Login Screen
Workspace/Search/File Search -> File Indexing
Personalization/Regional Settings -> Location
Personalization/Applications/Locations -> Personalization/Applications/Paths
Hardware/Display and Monitor -> Display
Hardware/Display and Monitor/Display Configuration -> Display
Hardware/Multimedia -> Audio
Hardware/Multimedia/Audio Volume -> Volume
Hardware/Multimedia/Audio and Video -> Audio

rearrange
=
Workspace/Desktop Behavior/Workspace -> remove or add desktop settings (for the 
active activity)
Workspace/Desktop Behavior/Screen Locking -> Hardware/Power Management/Screen 
Locking
Workspace/Desktop Behavior/Accessibility -> Workspace/Accessibility
Personalization/Online Account -> Personalization/Account/Online Account
Hardware/Digital Camera -> Hardware/Removable Devices/Digital Camera
Hardware/Device Actions -> Hardware/Removable Devices/Device Actions
Hardware/Removable Devices -> Hardware/Removable Devices/Removable Devices

Network Section
===
Rename from Network to Connecitivity and make a new Structure
Network
Proxy
Timeouts (old: Connection Preferences)
SSL certificats
Shares
Webbrowser
Identification
Shortcuts
Cache
Cookies
KDE Connect
KDE Connect
Bluetooth
Devices
Adapters
Advanced Settings (better naming needed)


Repository: plasma-desktop


Description
---

change see in the diff


Diffs
-

  kcms/baloo/kcm_baloofile.desktop 919fc8e 
  kcms/desktoppaths/desktoppath.desktop 2567c76 
  kcms/keys/keys.desktop ac6afb6 
  kcms/ksmserver/kcmsmserver.desktop 8ed358b 
  kcms/phonon/kcm_phonon.desktop ed804a3 
  kcms/standard_actions/standard_actions.desktop a454dbd 
  kcms/translations/translations.desktop daf9469 

Diff: https://git.reviewboard.kde.org/r/128434/diff/


Testing
---


File Attachments (updated)


adjustments
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 365318] KRDC is unreadable under breeze dark theme

[Jens Reuterberg via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365318

Jens Reuterberg  changed:

   What|Removed |Added

 CC||ohy...@gmail.com

--- Comment #12 from Jens Reuterberg  ---
Neither Okular, k3b or ktorrent are affected by what gtk theme you use
though... unless you have set the KDE themes to pick up the GTK theme - which
looking at it seems unlikely. 

With the GTK theme there is a generation shift that happened quite recently
(and may not have picked up) where GTK3 apps suddenly didn't work with the old
GTK3 theme. But that seems like it's not whats happening at all (that glitch
just messed with rightclick menu's being white-on-white). 

What happens when you set the entire destop via Look n Feel to "Breeze Dark"
and then go to GTK theme, set that in turn to Breeze Dark (and Breeze Dark
Icons) - then do the log-in-log-out dance?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2149: [platforms/fbdev] Handle error conditions more gracefully

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> bshah wrote in fb_backend.cpp:102
> Perhaps print warning here as well.

The method initImageFormat already prints a warning.

REPOSITORY
  rKWIN KWin

BRANCH
  fbdev-init-failed-5.7

REVISION DETAIL
  https://phabricator.kde.org/D2149

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bshah, plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2149: [platforms/fbdev] Handle error conditions more gracefully

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a reviewer: bshah.
bshah added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> fb_backend.cpp:102
> +if (m_imageFormat == QImage::Format_Invalid) {
> +emit initFailed();
> +return;

Perhaps print warning here as well.

REPOSITORY
  rKWIN KWin

BRANCH
  fbdev-init-failed-5.7

REVISION DETAIL
  https://phabricator.kde.org/D2149

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bshah, plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 11 lines] D2149: [platforms/fbdev] Handle error conditions more gracefully

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  So far if the framebuffer platform run into an error on initialization
  it did not continue and caused the system to freeze. With this change
  it properly emits the initFailed signal in all error conditions which
  causes kwin_wayland to terminate. This is a much better situation than
  just staying in a running, but frozen state.

REPOSITORY
  rKWIN KWin

BRANCH
  fbdev-init-failed-5.7

REVISION DETAIL
  https://phabricator.kde.org/D2149

AFFECTED FILES
  plugins/platforms/fbdev/fb_backend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2078: Handle situation of no XDG_RUNTIME_DIR gracefully

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN3c04d5295d5b: Handle situation of no XDG_RUNTIME_DIR 
gracefully (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2078?vs=4924=5112#toc

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2078?vs=4924=5112

REVISION DETAIL
  https://phabricator.kde.org/D2078

AFFECTED FILES
  autotests/integration/CMakeLists.txt
  autotests/integration/debug_console_test.cpp
  autotests/integration/decoration_input_test.cpp
  autotests/integration/dont_crash_aurorae_destroy_deco.cpp
  autotests/integration/dont_crash_cancel_animation.cpp
  autotests/integration/dont_crash_empty_deco.cpp
  autotests/integration/dont_crash_glxgears.cpp
  autotests/integration/dont_crash_no_border.cpp
  autotests/integration/input_stacking_order.cpp
  autotests/integration/internal_window.cpp
  autotests/integration/lockscreen.cpp
  autotests/integration/maximize_test.cpp
  autotests/integration/move_resize_window_test.cpp
  autotests/integration/no_xdg_runtime_dir_test.cpp
  autotests/integration/plasma_surface_test.cpp
  autotests/integration/plasmawindow_test.cpp
  autotests/integration/platformcursor.cpp
  autotests/integration/pointer_input.cpp
  autotests/integration/quick_tiling_test.cpp
  autotests/integration/scene_qpainter_test.cpp
  autotests/integration/shade_test.cpp
  autotests/integration/shell_client_test.cpp
  autotests/integration/start_test.cpp
  autotests/integration/struts_test.cpp
  autotests/integration/touch_input_test.cpp
  autotests/integration/transient_no_input_test.cpp
  autotests/integration/transient_placement.cpp
  autotests/integration/xclipboardsync_test.cpp
  main_wayland.cpp
  wayland_server.cpp
  wayland_server.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2135: [platforms/drm] Properly handle case that mapping the blank buffer fails

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINcd9a0afafa56: [platforms/drm] Properly handle case that 
mapping the blank buffer fails (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2135?vs=5073=5109

REVISION DETAIL
  https://phabricator.kde.org/D2135

AFFECTED FILES
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_output.cpp
  plugins/platforms/drm/drm_output.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2136: Call QCoreApplication::exit instead of stdlib exit to terminate if platform fails

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN56c2e158ee4e: Call QCoreApplication::exit instead of 
stdlib exit to terminate if platform… (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2136?vs=5075=5110

REVISION DETAIL
  https://phabricator.kde.org/D2136

AFFECTED FILES
  main_wayland.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2134: [platforms/fbdev] Properly detect a BGR image format

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINaaf8ce16dfb2: [platforms/fbdev] Properly detect a BGR 
image format (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2134?vs=5098=5108

REVISION DETAIL
  https://phabricator.kde.org/D2134

AFFECTED FILES
  plugins/platforms/fbdev/fb_backend.cpp
  plugins/platforms/fbdev/fb_backend.h
  plugins/platforms/fbdev/scene_qpainter_fb_backend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Andreas Kainz]

> On Juli 13, 2016, 12:28 vorm., Sebastian Kügler wrote:
> > Only the original string should be changed, not the translations.
> > 
> > Have you run this by Thomas Pfeiffer, these strings are the result of 
> > careful restructuring we did before 5.0. Also, we shouldn't change these 
> > names too lightly, since they're very user-visible and important to 
> > recognized. Many people remember these names, so we're introducing quite 
> > come re-learning to users with it.

I know that there was an survey and that's the reason I'll talked with Thomas 
if it is possible to make some adjustments. I get the feedback that some are 
needed and should be done. Not all adjustments are here in the request cause I 
have to do also some changes in the systemsetting repository.

Not everything here was coordinated with Thomas, cause I'd like to inform also 
the plasma devs to get your input as well.

If possible I would use this review request for talk about some adjustments and 
maybe we can together make the changes cause there are several repos where some 
changes are needed and it would be very complex. Or I'll find a solution with 
Thomas and ping you when everything is finished.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/#review97333
---


On Juli 12, 2016, 11:41 nachm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128434/
> ---
> 
> (Updated Juli 12, 2016, 11:41 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> change see in the diff
> 
> 
> Diffs
> -
> 
>   kcms/baloo/kcm_baloofile.desktop 919fc8e 
>   kcms/desktoppaths/desktoppath.desktop 2567c76 
>   kcms/keys/keys.desktop ac6afb6 
>   kcms/ksmserver/kcmsmserver.desktop 8ed358b 
>   kcms/phonon/kcm_phonon.desktop ed804a3 
>   kcms/standard_actions/standard_actions.desktop a454dbd 
>   kcms/translations/translations.desktop daf9469 
> 
> Diff: https://git.reviewboard.kde.org/r/128434/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2091: [server] Properly send a selection clear prior to keyboard focus enter

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLANDe65884f9eba6: [server] Properly send a selection 
clear prior to keyboard focus enter (authored by graesslin).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2091?vs=4955=5107

REVISION DETAIL
  https://phabricator.kde.org/D2091

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_selection.cpp
  autotests/client/test_wayland_seat.cpp
  src/server/seat_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, sebas
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2077: [server] Handle no XDG_RUNTIME_DIR situation more gracefully

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND9033c364ba99: [server] Handle no XDG_RUNTIME_DIR 
situation more gracefully (authored by graesslin).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2077?vs=4923=5106

REVISION DETAIL
  https://phabricator.kde.org/D2077

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_no_xdg_runtime_dir.cpp
  src/server/display.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, sebas
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Andreas Kainz]

> On Juli 13, 2016, 12:28 vorm., Sebastian Kügler wrote:
> > kcms/baloo/kcm_baloofile.desktop, line 22
> > 
> >
> > The [$LANG] lines are all automatically added, they are generated 
> > by the translation system. That means that the translators will take care 
> > of that. The patch should only change the first line, without the []. The 
> > translations will then be automatically updated a few hours later by the 
> > "scripty" daemon, once translators have picked up the string changes.

Didn`t know


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/#review97333
---


On Juli 12, 2016, 11:41 nachm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128434/
> ---
> 
> (Updated Juli 12, 2016, 11:41 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> change see in the diff
> 
> 
> Diffs
> -
> 
>   kcms/baloo/kcm_baloofile.desktop 919fc8e 
>   kcms/desktoppaths/desktoppath.desktop 2567c76 
>   kcms/keys/keys.desktop ac6afb6 
>   kcms/ksmserver/kcmsmserver.desktop 8ed358b 
>   kcms/phonon/kcm_phonon.desktop ed804a3 
>   kcms/standard_actions/standard_actions.desktop a454dbd 
>   kcms/translations/translations.desktop daf9469 
> 
> Diff: https://git.reviewboard.kde.org/r/128434/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: versioned dependencies on breeze

[Martin Graesslin]

On Tuesday, July 12, 2016 6:39:25 PM CEST Antonio Rojas wrote:
> In Plasma 5.7 both kwin and plasma-integration added strict versioned
> dependencies on Breeze:
> 
> find_package(Breeze ${PROJECT_VERSION} CONFIG)
> 
> Can this please be changed to depend on the actual minimum version required?
> There is no other versioned dependency between Plasma modules and it is
> quite inconvenient for packaging (as eg. it prevents parallel building)

Well if KWin depends on Breeze you cannot parallel build KWin and Breeze. That 
should be obvious.

The reason for the added dependency is that distributions complained about 
Plasma not properly specifying the dependencies it has. Thus I introduced them 
in a way that it doesn't require manual effort to keep them up to date. If I 
have to switch to minimum version it's starting to get manual effort with the 
risk of weird errors we have not expected yet.

It does not make sense to have KWin depend on a Breeze of the previous 
version. Neither plasma-integration. Thus I even think that from a technical 
point of view that would be wrong.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel