D23296: Simplify rendering of raised toolbuttons with menu

[Noah Davis]

ndavis added a comment.


  Hmm. I was thinking about doing something like this mockup: F7265921: 
Screenshot_20190820_203213.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23296

To: hpereiradacosta, #breeze, ndavis
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23305: Add plugin showing nvidia GPU load stats

[David Edmundson]

davidedmundson updated this revision to Diff 64180.
davidedmundson added a comment.


  remove stray copy pasted line

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23305?vs=64160=64180

BRANCH
  plugins2

REVISION DETAIL
  https://phabricator.kde.org/D23305

AFFECTED FILES
  processplugins/CMakeLists.txt
  processplugins/nvidia/CMakeLists.txt
  processplugins/nvidia/nvidia.cpp
  processplugins/nvidia/nvidia.h
  processplugins/nvidia/nvidia.json

To: davidedmundson, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23305: Add plugin showing nvidia GPU load stats

[Aleix Pol Gonzalez]

apol added a comment.


  Otherwise LGTM

INLINE COMMENTS

> CMakeLists.txt:2
> +add_library(ksysguard_plugin_nvidia MODULE nvidia.cpp)
> +include_directories(${X11_XRes_INCLUDE_PATH})
> +

copy-paste? I don't see why XRes is needed.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D23305

To: davidedmundson, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23306: Add AppStream metadata file

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D23306#515662 , @mak wrote:
  
  > In D23306#515616 , @kossebau 
wrote:
  >
  > > Thanks! Though reading it, leaves open questions with me:
  > >
  > > - what is meant by "referenced"? only via ?
  >
  >
  > In modern metainfo files yes, only via `launchable`. However, if a 
component `id` has a .desktop suffix, as was required in the past, and a 
matching .desktop file is found, that also counts as referenced and the 
desktop-entry file will be read.
  
  
  As developer trying to write metainfo files, I would welcome this logic also 
documented n the docs. The current content of the docs is confusing to me at 
least.
  
  >> - if there are two desktop files referenced by  where one has 
the ignore entry set, will this overrule the "Data will only be fetched from a 
desktop file if one  tag is present" rules above?
  > 
  > No. A `launchable` tag always beats whatever was defined in the 
desktop-entry file itself, so if there is one launchable tag, the .desktop 
entry file will be taken into consideration no matter what was defined in it 
(to e.g. merge in category information). Any equivalent data in the metainfo 
file beats that of the desktop-entry file though. If there are multiple 
`launchable` entries, the generator has no idea which .desktop file to read, so 
rather than reading any and getting information wrong, it will read none 
(requiring the metainfo author to add all data they want in there explicitly).
  >  This could maybe be made smarter, but tbh this case is so rare that just 
making the metainfo files more complete in such events seems like the better 
approach.
  
  So, in our case here, `systemsettings.desktop` actually means there is 
no need to add `X-AppStream-Ignore=true` to "kdesystemsettings.desktop" ? 
Because the generators would ignore it already due to a `` present 
and pointing to the other desktop file?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Matthias Klumpp]

mak added a comment.


  In D23306#515616 , @kossebau wrote:
  
  > In D23306#515609 , @mak wrote:
  >
  > > @kossebau How to hide .desktop files from AppStream is now more visible 
in 
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html#spec-appdata-introduction
 as a hint.
  >
  >
  > Thanks! Though reading it, leaves open questions with me:
  >
  > - what is meant by "referenced"? only via ?
  
  
  In modern metainfo files yes, only via `launchable`. However, if a component 
`id` has a .desktop suffix, as was required in the past, and a matching 
.desktop file is found, that also counts as referenced and the desktop-entry 
file will be read.
  
  > - if there are two desktop files referenced by  where one has 
the ignore entry set, will this overrule the "Data will only be fetched from a 
desktop file if one  tag is present" rules above?
  
  No. A `launchable` tag always beats whatever was defined in the desktop-entry 
file itself, so if there is one launchable tag, the .desktop entry file will be 
taken into consideration no matter what was defined in it (to e.g. merge in 
category information). Any equivalent data in the metainfo file beats that of 
the desktop-entry file though. If there are multiple `launchable` entries, the 
generator has no idea which .desktop file to read, so rather than reading any 
and getting information wrong, it will read none (requiring the metainfo author 
to add all data they want in there explicitly).
  This could maybe be made smarter, but tbh this case is so rare that just 
making the metainfo files more complete in such events seems like the better 
approach.
  
  In D23306#515621 , @ngraham wrote:
  
  > @mak The link 
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-compulsory_for_desktop
 seems broken. I found a reference to `compulsory_for_desktop` at 
https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html, 
but it points to a nonexistent page.
  
  
  Hmm, it works fine here - maybe refresh the page? (the page was recently 
updated and your browser may still have an older, cached version)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown

[Nathaniel Graham]

ngraham updated this revision to Diff 64177.
ngraham added a comment.


  Re-add other conditions

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23279?vs=64172=64177

BRANCH
  only-show-switch-user-button-when-more-than-one-session-is-active (branched 
from master)

REVISION DETAIL
  https://phabricator.kde.org/D23279

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: ngraham, mart, #plasma, #vdg, filipf
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown

[Nathaniel Graham]

ngraham added a comment.


  No, you're right, those should still be there.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  only-show-switch-user-button-when-more-than-one-session-is-active (branched 
from master)

REVISION DETAIL
  https://phabricator.kde.org/D23279

To: ngraham, mart, #plasma, #vdg, filipf
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  I don't know if there would be some use in keeping 
`sessionsModel.canStartNewSession && sessionsModel.canSwitchUser` around, but 
the button should always be visible (when technically possible I guess).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  only-show-switch-user-button-when-more-than-one-session-is-active (branched 
from master)

REVISION DETAIL
  https://phabricator.kde.org/D23279

To: ngraham, mart, #plasma, #vdg, filipf
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

[Nathaniel Graham]

ngraham updated this revision to Diff 64172.
ngraham added a comment.


  Always show the button

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23279?vs=64080=64172

BRANCH
  only-show-switch-user-button-when-more-than-one-session-is-active (branched 
from master)

REVISION DETAIL
  https://phabricator.kde.org/D23279

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: ngraham, mart, #plasma, #vdg
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Nathaniel Graham]

ngraham updated this revision to Diff 64171.
ngraham added a comment.


  Add `project_group` and `compulsory_for_desktop` tags

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23306?vs=64169=64171

BRANCH
  add-appdata-file (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23306

AFFECTED FILES
  app/CMakeLists.txt
  app/kdesystemsettings.desktop
  app/org.kde.systemsettings.appdata.xml

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Nathaniel Graham]

ngraham added a comment.


  @mak The link 
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-compulsory_for_desktop
 seems broken. I found a reference to `compulsory_for_desktop` at 
https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html, 
but it points to a nonexistent page.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

[Filip Fila]

filipf added a comment.


  In D23279#515614 , @ngraham wrote:
  
  > In D23279#515610 , @filipf wrote:
  >
  > > What if someone else is logged in, they locked their screen and I want to 
switch the session?
  >
  >
  > Or are you thinking with a multi-user system where user A logs in and locks 
the screen, and then user B wants to log in? Hmm.
  
  
  Yep, that's the scenario I had in mind.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23279

To: ngraham, mart, #plasma, #vdg
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D23306#515609 , @mak wrote:
  
  > @kossebau How to hide .desktop files from AppStream is now more visible in 
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html#spec-appdata-introduction
 as a hint.
  
  
  Thanks! Though reading it, leaves open questions with me:
  
  - what is meant by "referenced"? only via ?
  - if there are two desktop files referenced by  where one has the 
ignore entry set, will this overrule the "Data will only be fetched from a 
desktop file if one  tag is present" rules above?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

[Nathaniel Graham]

ngraham added a comment.


  In D23279#515610 , @filipf wrote:
  
  > What if someone else is logged in, they locked their screen and I want to 
switch the session?
  
  
  Then there are multiple sessions because you're already logged-in, so the 
button will be visible and you'll be able to get to your session. Or are you 
thinking with a multi-user system where user A logs in and locks the screen, 
and then user B wants to log in? Hmm.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23279

To: ngraham, mart, #plasma, #vdg
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23117: kcmlookandfeel - Correctly set the Splash Screen to what the Look & Feel intends for it to be set to

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23117

To: The-Feren-OS-Dev, #plasma
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

[Filip Fila]

filipf added a comment.


  What if someone else is logged in, they locked their screen and I want to 
switch the session?
  
  Might be something urgent, and if I don't have a button to leave their lock 
screen I might have to reboot and lose their work.
  
  > No more Switch User button on the ** login screen** unless there are 
multiple sessions
  
  You mean lock screen?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23279

To: ngraham, mart, #plasma, #vdg
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Matthias Klumpp]

mak added a comment.


  In D23306#515595 , @ngraham wrote:
  
  > In fact there are three possible relationships:
  >
  > - App is associated with desktop, but not required by it or limited to it 
(e.g. Dolphin, Gwenview, Nautilus, GNOME Music)
  
  
  --> `project_group` 
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-project_group
  
  > - App requires desktop (e.g. KDE System Settings, GNOME System Settings, 
GNOME Tweaks)
  
  --> `compulsory_for_desktop` 
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-compulsory_for_desktop
  (Also potentially `extends`, if the thing in question is an addon / 
desktop-shell extension)
  
  > - Desktop requires app (e.g. KDE System Settings, GNOME System Settings)
  
  --> `compulsory_for_desktop` 
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-compulsory_for_desktop
  
  > If we had the ability to mark things according to the above relationships 
that would be amazing.
  
  We actually can, I think...
  
  @kossebau How to hide .desktop files from AppStream is now more visible in 
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html#spec-appdata-introduction
 as a hint.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23308: Add a warning message about needing globally installed theme files

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Settings sync only works for theme files that are installed globally.
  
  We should add a warning message so users aren't confused when some aspect of 
the feature doesn't work.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sync-warning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23308

AFFECTED FILES
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23283: When asked to switch sessions, skip to session creation if there's nothing to switch to

[gregormi]

gregormi added a comment.


  Looks great. Thanks, Nate. (Sidenote: I wonder if there is an obvious way to 
close the additional session. Currently, I use the keyboard: Ctrl+Shift+F8 and 
then Ctrl+Alt+Back,Back)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23283

To: ngraham, #plasma, #vdg
Cc: gregormi, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Nathaniel Graham]

ngraham added a comment.


  In fact there are three possible relationships:
  
  - App is associated with desktop, but not required by it or limited to it 
(e.g. Dolphin, Gwenview, Nautilus, GNOME Music)
  - App requires desktop (e.g. KDE System Settings, GNOME System Settings, 
GNOME Tweaks)
  - Desktop requires app (e.g. KDE System Settings, GNOME System Settings)
  
  If we had the ability to mark things according to the above relationships 
that would be amazing.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Xwang]

https://bugs.kde.org/show_bug.cgi?id=350365

--- Comment #38 from Xwang  ---
After the plasma restart and a reboot the issue has resolved on my pc.
I use sddm as login.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Marco Richetta]

https://bugs.kde.org/show_bug.cgi?id=350365

--- Comment #37 from Marco Richetta  ---
(In reply to Xwang from comment #36)
> And I can confirm that 
> a) the battery indicator works correctly in the login screen when you the
> session is locked
> b) restarting plasma with kquitapp5 plasmashell ; kstart5 plasmashell is a
> workaround that solves the issue till the following reboot.

Can't reproduce the behaviour described on b). Also, do you use some custom
login screen?

Operating System: KDE neon 5.16
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.61.0
Qt Version: 5.12.3
Kernel Version: 4.15.0-58-generic

-- 
You are receiving this mail because:
You are the assignee for the bug.

D23306: Add AppStream metadata file

[Matthias Klumpp]

mak added a comment.


  In D23306#515592 , @ngraham wrote:
  
  > In D23306#515589 , @mak wrote:
  >
  > > In D23306#515577 , @ngraham 
wrote:
  > >
  > > > Adjust according to review comments
  > >
  > >
  > > This will work. I would change `System Settings` to ` 
KDE System Settings` or `Plasma System Settings`, just like 
GNOME sets a name like "GNOME Videos" instead of "Videos" in their metadata. 
Otherwise this name will confuse users of GNOME, I guess.
  >
  >
  > This gets at the original reason why System Settings has two .desktop 
files: one adds "KDE" onto the beginning of the name when it's not run in 
Plasma. Ideally we would want the same thing in AppStream:
  >
  > - Show "KDE Plasma System Settings" in search and browse lists, where the 
fact that it's for KDE Plasma is otherwise not apparent
  > - Show "System Settings" in Discover's Updates lists, where the fact that 
it's for KDE Plasma is implied and redundant because you're seeing it in 
Plasma's software updater
  >
  >   Is such a thing possible?
  
  
  Not at the moment... Discover can use the compulsory information to group the 
components into a "System components" group and it could also use the AppStream 
ID to arbitrarily override component names.
  The AppStream metainfo data is intended to be completely desktop agnostic and 
reliably the same on every software center, that's why we don't allow apps to 
change names depending on which software center they are in.
  However, software centers may use the compulsory information to actually 
completely hide components from foreign desktops, so not having a KDE prefix 
may not even be necessary. I am not sure if GNOME Software actually hides the 
apps based on the compulsory information (as this may also cause problems, e.g. 
I would consider Dolphin to be compulsory for Plasma, but GNOME people may 
potentially also want to install that file manager, so hiding it in GNOME 
Software may actually be wrong here).

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Nathaniel Graham]

ngraham added a comment.


  In D23306#515589 , @mak wrote:
  
  > In D23306#515577 , @ngraham 
wrote:
  >
  > > Adjust according to review comments
  >
  >
  > This will work. I would change `System Settings` to ` 
KDE System Settings` or `Plasma System Settings`, just like 
GNOME sets a name like "GNOME Videos" instead of "Videos" in their metadata. 
Otherwise this name will confuse users of GNOME, I guess.
  
  
  This gets at the original reason why System Settings has two .desktop files: 
one adds "KDE" onto the beginning of the name when it's not run in Plasma. 
Ideally we would want the same thing in AppStream:
  
  - Show "KDE Plasma System Settings" in search and browse lists, where the 
fact that it's for KDE Plasma is otherwise not apparent
  - Show "System Settings" in Discover's Updates lists, where the fact that 
it's for KDE Plasma is implied and redundant because you're seeing it in 
Plasma's software updater
  
  Is such a thing possible?
  
  > You'll also highly likely want to set `compulsory_for_desktop` ( 
https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html#tag-ct-compulsory_for_desktop
 ) to prevent this app to be removable on Plasma.
  >  So adding
  > 
  >   KDE
  >   Plasma
  > 
  > 
  > will do the trick (AppStream recognizes "Plasma", but the desktop is 
actually known as "KDE" everywhere in Freedesktop, so just using "KDE" would 
probably be sufficient and compatible with everything. Having "Plasma" as well 
won't hurt though)
  >  Ypu may want FSFAP  as 
`metadata_license` as it's much shorter than CC0 and mixes well with GPL. 
However that's a personal choice and not required for anything. CC0 would work 
just fine.
  
  Thanks, will do.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Matthias Klumpp]

mak added a comment.


  Adding a `project_group` may also be a nice idea: 
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-project_group

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Matthias Klumpp]

mak added a comment.


  In D23306#515585 , @kossebau wrote:
  
  > @mak: tnanks for the hint. will also see to use X-AppStream-Ignore for 
kdevelop then. any chance we can see this trick documented on 
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html
 , please? :)
  
  
  There should probably be another note block on that page... ;-)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Matthias Klumpp]

mak added a comment.


  In D23306#515577 , @ngraham wrote:
  
  > Adjust according to review comments
  
  
  This will work. I would change `System Settings` to ` KDE 
System Settings` or `Plasma System Settings`, just like 
GNOME sets a name like "GNOME Videos" instead of "Videos" in their metadata. 
Otherwise this name will confuse users of GNOME, I guess.
  You'll also highly likely want to set `compulsory_for_desktop` ( 
https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html#tag-ct-compulsory_for_desktop
 ) to prevent this app to be removable on Plasma.
  So adding
  
KDE
Plasma
  
  will do the trick (AppStream recognizes "Plasma", but the desktop is actually 
known as "KDE" everywhere in Freedesktop, so just using "KDE" would probably be 
sufficient and compatible with everything. Having "Plasma" as well won't hurt 
though)
  Ypu may want FSFAP  as 
`metadata_license` as it's much shorter than CC0 and mixes well with GPL. 
However that's a personal choice and not required for anything. CC0 would work 
just fine.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23302: Stop installing two desktop files

[Ben Cooksley]

bcooksley added a comment.


  The split with two different desktop files was imposed upon us by the GNOME 
packagers at Ubuntu so eliminating the extra file isn't an option I'm afraid.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23302

To: ngraham, apol, #plasma
Cc: bcooksley, mak, kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Nathaniel Graham]

ngraham updated this revision to Diff 64169.
ngraham added a comment.


  Add `` tag so searching for it from the old URLs still works

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23306?vs=64168=64169

BRANCH
  add-appdata-file (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23306

AFFECTED FILES
  app/CMakeLists.txt
  app/kdesystemsettings.desktop
  app/org.kde.systemsettings.appdata.xml

To: ngraham, apol, mak, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @mak: tnanks for the hint. will also see to use X-AppStream-Ignore for 
kdevelop then. any chance we can see this trick documented on 
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html
 , please? :)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the into @mak, that's very helpful. I've removed one of the 
launchable tags since only one .desktop file has the info that you would want 
to use to launch it as a KDE user. And I've added `X-AppStream-Ignore=true` to 
one of the .desktop files.
  
  Does this look correct now?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23302: Stop installing two desktop files

[Matthias Klumpp]

mak added a comment.


  @kossebau You'll also want to annotate the .desktop files correctly to hide 
them. See https://phabricator.kde.org/D23306#515575 for details.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23302

To: ngraham, apol, #plasma
Cc: mak, kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Nathaniel Graham]

ngraham updated this revision to Diff 64168.
ngraham added a comment.


  Adjust according to review comments

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23306?vs=64161=64168

BRANCH
  add-appdata-file (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23306

AFFECTED FILES
  app/CMakeLists.txt
  app/kdesystemsettings.desktop
  app/org.kde.systemsettings.appdata.xml

To: ngraham, apol, mak, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Matthias Klumpp]

mak added a comment.


  There's also a FAQ entry for this, apparently I only documented this for 
Debian Developers back in the day ^^
  
  > 
https://wiki.debian.org/AppStream/Guidelines#How_to_exclude_.desktop_files_from_the_metadata
  
==
  
  We may actually be at a point where we could only process stuff that has 
metainfo files by default in appstream-generator now... Something to consider 
for future releases.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Matthias Klumpp]

mak added a comment.


  @ngraham
  
  > Alternative to D23302 . According to 
the AppStream documentation 
(https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html),
  >  adding an AppStream metadata file with multiple launchable tags will 
prevent AppStream
  >  info generators from parsing desktop files to determine metadata,
  
  I don't think this will do what you intend. What will actually happen here is 
that an AppStream generator will not *merge* in data from any of the desktop 
files into the final metadata collection, only being limited to what is in the 
.desktop file. Having the two `launchable` tags though will make software 
centers ask the user which app they want to launch if they click on the 
"Launch" button in a software center, which in this case are both identical.
  
  If you just want to hide a .desktop file from being processed by AppStream, 
there is a much simpler solution: Just add `X-AppStream-Ignore=true` to the 
.desktop file in question, and it will be hidden (unless it is referenced in a 
metainfo file of course, in which case it may still be used as data source for 
that metainfo file).

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23307: [weather] [envcan] Add additional current condition icon mappings

[Shawn Starr]

spstarr added a comment.


  Ideally, this list shouldn't be so long since the XML schema 
http://dd.weatheroffice.ec.gc.ca/citypage_weather/docs/current_conditions_icon_code_descriptions_e.csv
 lists them all, except thats not what the XML shows :/ I should ask EC why the 
discrepancy

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23307

To: spstarr, #plasma, kossebau
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23307: [weather] [envcan] Add additional current condition icon mappings

[Nathaniel Graham]

ngraham resigned from this revision.
ngraham added a comment.


  Ah ok.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23307

To: spstarr, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23307: [weather] [envcan] Add additional current condition icon mappings

[Shawn Starr]

spstarr added a comment.


  Thats the XML however, it is matching 'rainshowers'

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23307

To: spstarr, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23307: [weather] [envcan] Add additional current condition icon mappings

[Nathaniel Graham]

ngraham edited reviewers, added: Plasma; removed: Plasma: Workspaces.
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Change "rainshowers" to "rain showers" ("rainshower" isn't a word)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23307

To: spstarr, #plasma, ngraham, #plasma_workspaces
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23307: [weather] [envcan] Add additional current condition icon mappings

[Shawn Starr]

spstarr added a comment.


  Current XML shows (until the storm ends)
  
  Thunderstorm with heavy rainshowers

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23307

To: spstarr, #plasma_workspaces
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23307: [weather] [envcan] Add additional current condition icon mappings

[Shawn Starr]

spstarr added a comment.


  Will merge once reviewed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23307

To: spstarr, #plasma_workspaces
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23307: [weather] [envcan] Add additional current condition icon mappings

[Shawn Starr]

spstarr created this revision.
spstarr added a reviewer: Plasma: Workspaces.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
spstarr requested review of this revision.

REVISION SUMMARY
  [weather] [envcan] Add additional current condition icon mappings

TEST PLAN
  Built and tested with changes and see the correct current condition icon 
shown.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23307

AFFECTED FILES
  dataengines/weather/ions/data/envcan_i18n.dat
  dataengines/weather/ions/envcan/ion_envcan.cpp

To: spstarr, #plasma_workspaces
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23302: Stop installing two desktop files

[Nathaniel Graham]

ngraham added a subscriber: mak.
ngraham added a comment.


  Abandoning in favor of D23306 , which 
adds an AppStream metadata file with multiple `launchable` tags. If I'm reading 
the docs right, this should allow the information from the referenced 
`.desktop` files to NOT be merged into the data from the `appdata.xml` file, 
which, if it works, should be the right approach for KDevelop too. Hopefully 
@mak will chime in regarding whether this is accurate or not.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23302

To: ngraham, apol, #plasma
Cc: mak, kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23306: Add AppStream metadata file

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, mak, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Alternative to D23302 . According to the 
AppStream documentation 
(https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html),
  adding an AppStream metadata file with multiple `launchable` tags will 
prevent AppStream
  info generators from parsing desktop files to determine metadata, which 
sbhould solve
  the problem of System Settings showing up twice in Discover and other 
software centers
  due to how it installs more than one `.desktop` file.

TEST PLAN
  Cannot test AppStream changes :/

REPOSITORY
  R124 System Settings

BRANCH
  add-appdata-file (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23306

AFFECTED FILES
  app/CMakeLists.txt
  app/org.kde.systemsettings.appdata.xml

To: ngraham, apol, mak, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23305: Add plugin showing nvidia GPU load stats

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This plugin shows the process GPU load and GPU memory usage for users of
  Nvidia graphic cards.
  
  Data is fetched by running the (fortunately lightweight) process
  nvidia-smi to extract data. If this binary is not available this plugin
  does nothing and the columns will not be available.
  
  It's not feasible to try try and reverse engineer nvidia-smi to recreate
  the functionality to do it without the extra executable. The headers are
  hidden within a giant proprietary SDK, and internally it's just opening
  a completely arbitrary address in /dev/mem.

TEST PLAN
  Ran webGL test in firefox, FF process, Xorg and kwin all spiked

REPOSITORY
  R111 KSysguard Library

BRANCH
  plugins2

REVISION DETAIL
  https://phabricator.kde.org/D23305

AFFECTED FILES
  processplugins/CMakeLists.txt
  processplugins/nvidia/CMakeLists.txt
  processplugins/nvidia/nvidia.cpp
  processplugins/nvidia/nvidia.h
  processplugins/nvidia/nvidia.json

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23288: Move XResources out of the central model into a plugin

[David Edmundson]

davidedmundson updated this revision to Diff 64157.
davidedmundson added a comment.


  update

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23288?vs=64135=64157

REVISION DETAIL
  https://phabricator.kde.org/D23288

AFFECTED FILES
  CMakeLists.txt
  processplugins/CMakeLists.txt
  processplugins/xres/CMakeLists.txt
  processplugins/xres/xres.cpp
  processplugins/xres/xres.h
  processplugins/xres/xres.json
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h

To: davidedmundson, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23287: Create a plugin framework for processes

[David Edmundson]

davidedmundson updated this revision to Diff 64155.
davidedmundson added a comment.


  update

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23287?vs=64136=64155

REVISION DETAIL
  https://phabricator.kde.org/D23287

AFFECTED FILES
  processcore/CMakeLists.txt
  processcore/extended_process_list.cpp
  processcore/extended_process_list.h
  processcore/formatter.cpp
  processcore/formatter.h
  processcore/process_data_provider.cpp
  processcore/process_data_provider.h
  processcore/processes.cpp
  processcore/processes.h
  processcore/unit.cpp
  processcore/unit.h
  processui/ProcessModel.cpp
  processui/ProcessModel_p.h

To: davidedmundson, #plasma
Cc: alexde, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23302: Stop installing two desktop files

[Nathaniel Graham]

ngraham added a comment.


  Those are excellent questions. Reading through 
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html,
 it seems like .desktop files only get parsed if there's no appdata.xml 
file--which indeed, System Settings lacks. Maybe that's the right approach 
here...

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23302

To: ngraham, apol, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23302: Stop installing two desktop files

[Friedrich W. H. Kossebau]

kossebau added a comment.


  As KDevelop is affected similar, because we want two different entries to 
appear in the system application menu, can someone tell where appstream defines 
that there shall be only one menu desltop file per application? Why do those 
installers even look at the menu entry defining desktop files, should they not 
use the appdata files to model their world of application entities?
  
  Can't the "world of appstream installers and checkers" not be adapted to the 
actual real world?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23302

To: ngraham, apol, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23302: Stop installing two desktop files

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  System Settings installs two desktop files, and uses one with "KDE" in the 
name when
  run in a non-Plasma session. Unfortunately in today's world, this causes 
System Settings
  to appear twice in app lists (Discover, GNOME Software, appstreamCLI, etc). 
For example:
  F7265164: Two System Settings in search list.png 

  F7265165: Two System Settings in updates list.png 

  
  It wasn't a bad idea, but I don't think it really works anymore.

TEST PLAN
  Can't test AppStream changes :/

REPOSITORY
  R124 System Settings

BRANCH
  remove-redundant-desktop-file (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23302

AFFECTED FILES
  app/CMakeLists.txt
  app/kdesystemsettings.desktop
  app/main.cpp

To: ngraham, apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23301: [Cuttlefish] Use only a single AppStream ID

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:06912303ea4b: [Cuttlefish] Use only a single AppStream ID 
(authored by ngraham).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23301?vs=64149=64150

REVISION DETAIL
  https://phabricator.kde.org/D23301

AFFECTED FILES
  cuttlefish/org.kde.cuttlefish.appdata.xml

To: ngraham, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23298: Unify busy spinner appearance on update page

[Nathaniel Graham]

ngraham added a comment.


  If there's a way to show an actual progress indicator in a way that ensures 
its accuracy, that would be much better, yeah. I'll be happy to abandon this 
patch if you can do that (I don't know how, sorry).

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D23298

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23301: [Cuttlefish] Use only a single AppStream ID

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now Cuttlefish provides both `org.kde.plasma.cuttlefish` and
  `org.kde.cuttlefish.desktop` AppStream IDs, causing it to appear twice in 
Discover and
  other software center apps.
  
  This patch standardizes on `org.kde.plasma.cuttlefish`, and provides a 
compatibility
  shim so you can still access it from the old URL 
(appstream://org.kde.cuttlefish.desktop)
  
  BUG: 42
  FIXED-IN: 5.16.5

TEST PLAN
  Don't know how to test this

REPOSITORY
  R118 Plasma SDK

BRANCH
  unify-appstream-id (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23301

AFFECTED FILES
  cuttlefish/org.kde.cuttlefish.appdata.xml

To: ngraham, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23298: Unify busy spinner appearance on update page

[Aleix Pol Gonzalez]

apol added a comment.


  As is, it looks unfinished to me. I prefer to give some kind of hint of 
what's happening, especially since this could take a while, yesterday I opened 
one laptop after a month (neon git unstable) or so and it took easily a minute 
to show anything there.
  In fact, we could look into showing progress here, which is what I wanted 
looking at the thing spin to no end.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D23298

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23271: [Battery Monitor] Call battery capacity "Capacity degradation" for better clarity

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a1654867e784: [Battery Monitor] Call battery capacity 
Capacity degradation for better… (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23271?vs=64142=64144

REVISION DETAIL
  https://phabricator.kde.org/D23271

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: ngraham, #vdg, broulik, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23270: [Energy] Put battery capacity info in battery section and call it "Capacity degradation"

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:c7984fa8548c: [Energy] Put battery capacity info in 
battery section and call it Capacity… (authored by ngraham).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23270?vs=64141=64143

REVISION DETAIL
  https://phabricator.kde.org/D23270

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: ngraham, meven, broulik, #vdg, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23271: [Battery Monitor] Call battery capacity "degradation" for better clarity

[Nathaniel Graham]

ngraham updated this revision to Diff 64142.
ngraham added a comment.


  Use the superior agreed-upon string "Capacity degradation"

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23271?vs=64123=64142

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23271

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: ngraham, #vdg, broulik, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23298: Unify busy spinner appearance on update page

[Nathaniel Graham]

ngraham added a comment.


  All it used to say was "Fetching updates..." which I think is adequately 
implied by it being a busy spinner on the Updates page. The spinner on the main 
page doesn't say, "Fetching applications" or whatever, so I was trying to be 
consistent with that. Your call though.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D23298

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23298: Unify busy spinner appearance on update page

[Aleix Pol Gonzalez]

apol added a comment.


  We don't want any text?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D23298

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

[Nathaniel Graham]

ngraham updated this revision to Diff 64141.
ngraham added a comment.


  Rename to "Capacity degradation" for extra clarity, and move to the end of 
the Battery section

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23270?vs=64062=64141

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23270

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: ngraham, meven, broulik, #vdg, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23298: Unify busy spinner appearance on update page

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The busy spinner on the main page is in the center of the view. Let's do the 
same thing
  on the updates page. As part of this, we can get rid of the "Fetching 
updates..." text,
  because it's already perfectly clear what's going on.

TEST PLAN
  F7264935: Spinner.webm 

REPOSITORY
  R134 Discover Software Store

BRANCH
  unify-busy-spinners (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23298

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

[Alexander Potashev]

aspotashev added a comment.


  In D23270#515349 , @ngraham wrote:
  
  > "Capacity degradation" is perfectly clear IMO.
  
  
  You may be right, my opinion is biased.

REPOSITORY
  R102 KInfoCenter

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23270

To: ngraham, meven, broulik, #vdg, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

[Nathaniel Graham]

ngraham added a comment.


  In D23270#515348 , @aspotashev 
wrote:
  
  > I think you missed my point, the regular "what's this" tool is indeed 
poorly discoverable. Consider this type of "tooltip" for the KCM:
  >  F7264910: Screenshot_20190820_201847.png 

  >  And for the plasmoid we may use an "i" icon instead to make it compact.
  
  
  Ah I see what you mean, thanks. However this isn't a UI that we use in other 
places and I don't think it it's even necessary. "Capacity degradation" is 
perfectly clear IMO. What more would we need to explain? Again I feel like if 
possible it's preferable to use a term that doesn't need explanation rather 
than going to great pains to provide an explanation via a secondary mechanism.

REPOSITORY
  R102 KInfoCenter

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23270

To: ngraham, meven, broulik, #vdg, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

[Alexander Potashev]

aspotashev added a comment.


  In D23270#515331 , @ngraham wrote:
  
  > Hmm, both suggestions seem to be designed to explain what "capacity" means 
rather than replacing it with something that doesn't need explanation at all. I 
don't really see the point of  keeping the word "Capacity" visible when we can 
replace it with something that doesn't need additional explanation.
  
  
  Ok, let's go with "degradation: nn%" + a "what's this" link.
  
  > Also, I don't think QML stuff do "What's This?" text, and even if it could 
I wouldn't want to use it because the "What's This?" feature is 
poorly-discoverable and not a substitute for clarity in the user-visible 
strings.
  
  I think you missed my point, the regular "what's this" tool is indeed poorly 
discoverable. Consider this type of "tooltip" for the KCM:
  F7264910: Screenshot_20190820_201847.png 

  And for the plasmoid we may use an "i" icon instead to make it compact.

REPOSITORY
  R102 KInfoCenter

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23270

To: ngraham, meven, broulik, #vdg, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23292: Make update page labels consistent with topUpdateComp

[Nathaniel Graham]

ngraham added a comment.


  Figured it out from your email address. :) Do please update your `.gitconfig` 
file for future patches though!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D23292

To: MrPepe, #discover_software_store, ngraham
Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23292: Make update page labels consistent with topUpdateComp

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:7a2dc6941478: Make update page labels consistent with 
topUpdateComp (authored by MrPepe, committed by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23292?vs=64124=64137

REVISION DETAIL
  https://phabricator.kde.org/D23292

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: MrPepe, #discover_software_store, ngraham
Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

[Nathaniel Graham]

ngraham added a comment.


  If keeping the word "capacity" is a sticking point, I'd like to go with 
@meven's suggestion of "Capacity degredation". Would that be acceptable?

REPOSITORY
  R102 KInfoCenter

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23270

To: ngraham, meven, broulik, #vdg, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23287: Create a plugin framework for processes

[David Edmundson]

davidedmundson updated this revision to Diff 64136.
davidedmundson added a comment.


  update

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23287?vs=64100=64136

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23287

AFFECTED FILES
  processcore/CMakeLists.txt
  processcore/extended_process_list.cpp
  processcore/extended_process_list.h
  processcore/formatter.cpp
  processcore/formatter.h
  processcore/process_data_provider.cpp
  processcore/process_data_provider.h
  processcore/processes.cpp
  processcore/processes.h
  processcore/unit.cpp
  processcore/unit.h
  processui/ProcessModel.cpp
  processui/ProcessModel_p.h

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23287: Create a plugin framework for processes

[David Edmundson]

davidedmundson marked 7 inline comments as done.
davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in extended_process_list.cpp:62
> Add `reserve` call

I can't add a meaningful one.

p->attributes() is itself another vector of size 0 to N.

> broulik wrote in process_data_provider.h:54
> Why `const`?

Simply why not?
Doesn't really make a difference.

> broulik wrote in ProcessModel.cpp:518
> Can this become out of sync, given you capture `i` as a copy into the lambda?

If mExtraAttributes changed during the lifespan, it would, but that currently 
doesn't happen.

We show all columns and then enable or disable them to populate updates.

> broulik wrote in ProcessModel.cpp:1304
> `value.type() == QVariant::String`?

from qt docs:

Returns the storage type of the value stored in the variant. Although this 
function is declared as returning QVariant::Type, the return value should be 
interpreted as QMetaType::Type. In particular, QVariant::UserType is returned 
here only if the value is equal or greater than QMetaType::User.

> broulik wrote in ProcessModel.cpp:1305
> Shouldn't those be or'd together? Interestingly, Qt documentation also uses 
> addition.

For independent flags it's the same thing.

Can change if you like, but it matches the docs.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D23287

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

[Nathaniel Graham]

ngraham added a comment.


  In D23270#515330 , @aspotashev 
wrote:
  
  > In D23270#515293 , @ngraham 
wrote:
  >
  > > At least, that's how it was for me. I did not understand what "Capacity:" 
was referring to until I started browsing the code. "Capacity" is an ambiguous 
and non-descriptive term that does not really communicate the concept we're 
trying to get across.
  >
  >
  > How about this: "Capacity: 79% (degraded by 21%)"?
  >  Or keep the label as is and add a link "What's this?" that would show a 
popup with an in-depth description of battery capacity, degradation, why it 
happens and what to do about it.
  
  
  Hmm, both suggestions seem to be designed to explain what "capacity" means 
rather than replacing it with something that doesn't need explanation at all. I 
don't really see the point of  keeping the word "Capacity" visible when we can 
replace it with something that doesn't need additional explanation.
  
  Also, I don't think QML stuff do "What's This?" text, and even if it could I 
wouldn't want to use it because the "What's This?" feature is 
poorly-discoverable and not a substitute for clarity in the user-visible 
strings.

REPOSITORY
  R102 KInfoCenter

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23270

To: ngraham, meven, broulik, #vdg, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

[Alexander Potashev]

aspotashev added a comment.


  In D23270#515293 , @ngraham wrote:
  
  > At least, that's how it was for me. I did not understand what "Capacity:" 
was referring to until I started browsing the code. "Capacity" is an ambiguous 
and non-descriptive term that does not really communicate the concept we're 
trying to get across.
  
  
  How about this: "Capacity: 79% (degraded by 21%)"?
  
  Or keep the label as is and add a link "What's this?" that would show a popup 
with an in-depth description of battery capacity, degradation, why it happens 
and what to do about it.

REPOSITORY
  R102 KInfoCenter

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23270

To: ngraham, meven, broulik, #vdg, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23288: Move XResources out of the central model into a plugin

[David Edmundson]

davidedmundson updated this revision to Diff 64135.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.


  update

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23288?vs=64125=64135

BRANCH
  plugins

REVISION DETAIL
  https://phabricator.kde.org/D23288

AFFECTED FILES
  processplugins/CMakeLists.txt
  processplugins/xres/CMakeLists.txt
  processplugins/xres/xres.cpp
  processplugins/xres/xres.h
  processplugins/xres/xres.json
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h

To: davidedmundson, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23288: Move XResources out of the central model into a plugin

[David Edmundson]

davidedmundson marked 4 inline comments as done.
davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in xres.h:1
> Copyright?
> 
> First time I see `#pragma once` in KDE software.

I've used #pragma once all over the place already, hasn't seemed to cause an 
issue.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D23288

To: davidedmundson, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23152: [energy kcm] Display Vendor and model

[Nathaniel Graham]

ngraham added a comment.


  If the serial number is a property of the battery, then yes, it belongs in 
the Battery section IMO.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23152

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

[Nathaniel Graham]

ngraham added a comment.


  In D23270#515102 , @aspotashev 
wrote:
  
  > I don't like this change because it introduces a Plasma-specific formula 
and makes the user guess how to match "degradation: 21%" against let's say 
"capacity: 85%" s/he saw when using a different OS or desktop environment. For 
example:
  >
  > 1. User looks at battery status in Plasma 5.16 and remembers battery 
capacity is 85%,
  > 2. User updates to Plasma 5.17 and now there is "degradation 21%". How does 
one know if battery health improved or worsened over time and if the change was 
substantial?
  
  
  I think the more likely scenario is as follows:
  
  1. User looks at battery status in Plasma 5.16, sees "capacity" at 85%, and 
has no idea what this means, because it implies that the battery is 85% charged 
but this can't be the case as other stats conflict with this interpretation
  2. User updates to Plasma 5.17 and now there is "Degradation 21%". User now 
understands that this means their battery capacity is degraded. Maybe the 
string could be even further improved as "Capacity degredation:" as @meven 
suggested.
  
  At least, that's how it was for me. I did not understand what "Capacity:" was 
referring to until I started browsing the code. "Capacity" is an ambiguous and 
non-descriptive term that does not really communicate the concept we're trying 
to get across.

REPOSITORY
  R102 KInfoCenter

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23270

To: ngraham, meven, broulik, #vdg, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23292: Make update page labels consistent with topUpdateComp

[Nathaniel Graham]

ngraham added a comment.


  @MrPepe I cannot land this patch because our commit hookscript requires a 
last name in addition to a first name. Can you tell me your last name and 
adjust your `.gitconfig` file to include that in future patches?
  
  Thanks!

REPOSITORY
  R134 Discover Software Store

BRANCH
  consistentLabels

REVISION DETAIL
  https://phabricator.kde.org/D23292

To: MrPepe, #discover_software_store, ngraham
Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23288: Move XResources out of the central model into a plugin

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> xres.cpp:1
> +#include "xres.h"
> +

What's the copyright?

> xres.cpp:6
> +#include 
> +#include 
> +

Scope shouldn't be necessary

> xres.h:1
> +#pragma once
> +

Copyright?

First time I see `#pragma once` in KDE software.

> ProcessModel.h:157
>  HeadingCommand,
> -HeadingXMemory,
> +HeadingXMemory, ///Deprecated. See plugins
>  HeadingXTitle,

if you pass 3/// you can just as well use `///<@deprecated. in xres plugin now`

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D23288

To: davidedmundson, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23292: Make update page labels consistent with topUpdateComp

[Aleix Pol Gonzalez]

apol added a comment.


  Thanks. The problem with the knsbackendtest is most likely unrelated. You can 
ignore it here.
  
  Do you have permissions to land the patch?

REPOSITORY
  R134 Discover Software Store

BRANCH
  consistentLabels

REVISION DETAIL
  https://phabricator.kde.org/D23292

To: MrPepe, #discover_software_store, ngraham
Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23296: Simplify rendering of raised toolbuttons with menu

[Hugo Pereira Da Costa]

hpereiradacosta created this revision.
hpereiradacosta added reviewers: Breeze, ndavis.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hpereiradacosta requested review of this revision.

REVISION SUMMARY
  Following on https://phabricator.kde.org/D23169, it turns out one can 
simplify the toolbuttons with menu rendering strongly by rendering the whole 
frame at once, and removing the code for detecting the presence of the menu 
alltogether. This makes for cleaner code with no visual difference with respect 
to how it should look (and no 'double-shadow').

TEST PLAN
  F7264651: Screenshot_20190820_174107.png 

  This is how toolbuttons with menu appear with this patch. (no change with 
respect to without)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23296

AFFECTED FILES
  kstyle/breezestyle.cpp

To: hpereiradacosta, #breeze, ndavis
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23294: [Notifications] Bring back dismissed progress in case of crash

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When the application crashes, we would mark the job as failed but not 
undismiss it.

TEST PLAN
  5.16
  
  - Started a copy in dolphin, minimized the copy popup, killed dolphin
  
  → Got the popup back saying the app crashed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23294

AFFECTED FILES
  libnotificationmanager/jobsmodel_p.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23293: [Notifications] Implement JobViewV2

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This implements a new `JobViewV2` which uses extensible variant maps rather 
than individual function calls, allowing for compression of calls and 
extensibility.
  The new API uses `infoMessage` correctly as a state message, e.g. "Connecting 
to host" rather than mixing it with the "Copying..." heading.
  It also supports an "immediate" flag that the caller can use to indicate 
progress should be immediately shown, so in cases where the user is likely to 
want to use the file afterwards (e.g. download through p-b-i or receiving a 
file through KDE Connect) a job popup is shown even for small/short transfers.

TEST PLAN
  This has to go into 5.16 branch as I implemented the interface in 5.16 but it 
is defunct, so when we ever start using it in KIO it will see the interface but 
it will not work.
  
  Used a WIP branch of kjobwidgets/kio and been using the new API without a 
hitch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23293

AFFECTED FILES
  libnotificationmanager/job.cpp
  libnotificationmanager/job_p.cpp
  libnotificationmanager/job_p.h
  libnotificationmanager/jobsmodel_p.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22087: Build without foreach

[Nicolas Fella]

nicolasfella updated this revision to Diff 64127.
nicolasfella added a comment.


  - Comments

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22087?vs=60630=64127

BRANCH
  arcpatch-D22087

REVISION DETAIL
  https://phabricator.kde.org/D22087

AFFECTED FILES
  CMakeLists.txt
  applets/digital-clock/plugin/timezonemodel.cpp
  applets/systemtray/container/systemtraycontainer.cpp
  components/sessionsprivate/sessionsmodel.cpp
  components/shellprivate/interactiveconsole/interactiveconsole.cpp
  components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp
  components/shellprivate/widgetexplorer/widgetexplorer.cpp
  containmentactions/applauncher/launch.cpp
  containmentactions/contextmenu/menu.cpp
  containmentactions/switchactivity/switch.cpp
  dataengines/activities/activityengine.cpp
  dataengines/apps/appsengine.cpp
  dataengines/apps/appsource.cpp
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/geolocation/geolocation.cpp
  dataengines/hotplug/hotplugengine.cpp
  dataengines/mpris2/mpris2engine.cpp
  dataengines/mpris2/multiplexedservice.cpp
  dataengines/powermanagement/powermanagementengine.cpp
  dataengines/soliddevice/soliddeviceengine.cpp
  dataengines/statusnotifieritem/statusnotifieritem_engine.cpp
  dataengines/systemmonitor/systemmonitor.cpp
  dataengines/time/solarsystem.cpp
  dataengines/time/timeengine.cpp
  kioslave/applications/kio_applications.cpp
  kioslave/desktop/kio_desktop.cpp
  klipper/configdialog.cpp
  klipper/editactiondialog.cpp
  klipper/historyurlitem.cpp
  klipper/urlgrabber.cpp
  krunner/view.cpp
  ksmserver/client.cpp
  ksmserver/logout.cpp
  ksmserver/server.cpp
  ksplash/ksplashqml/splashapp.cpp
  libdbusmenuqt/dbusmenuimporter.cpp
  libdbusmenuqt/dbusmenushortcut_p.cpp
  libdbusmenuqt/dbusmenutypes_p.cpp
  libkworkspace/kdisplaymanager.cpp
  libtaskmanager/abstractwindowtasksmodel.cpp
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/startuptasksmodel.cpp
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasktools.cpp
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp
  logout-greeter/greeter.cpp
  plasma-windowed/plasmawindowedview.cpp
  plasmacalendarintegration/holidaysevents.cpp
  runners/activities/activityrunner.cpp
  runners/appstream/appstreamrunner.cpp
  runners/bookmarks/bookmarkmatch.cpp
  runners/bookmarks/bookmarkmatch.h
  runners/bookmarks/bookmarksrunner.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/opera.cpp
  runners/bookmarks/fetchsqlite.cpp
  runners/kill/killrunner.cpp
  runners/powerdevil/PowerDevilRunner.cpp
  runners/recentdocuments/recentdocuments.cpp
  runners/services/servicerunner.cpp
  runners/sessions/sessionrunner.cpp
  runners/webshortcuts/webshortcutrunner.cpp
  runners/windowedwidgets/windowedwidgetsrunner.cpp
  runners/windows/windowsrunner.cpp
  shell/containmentconfigview.cpp
  shell/coronatesthelper.cpp
  shell/currentcontainmentactionsmodel.cpp
  shell/panelshadows.cpp
  shell/screenpool.cpp
  shell/scripting/appinterface.cpp
  shell/scripting/applet.cpp
  shell/scripting/containment.cpp
  shell/scripting/scriptengine.cpp
  shell/scripting/scriptengine_v1.cpp
  shell/shellcorona.cpp
  startkde/kcminit/main.cpp
  startkde/plasma-session/autostart.cpp
  startkde/plasma-session/shutdown.cpp
  startkde/plasma-session/startup.cpp
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/image.cpp
  wallpapers/image/slidemodel.cpp

To: nicolasfella, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D22087: Build without foreach

[Nicolas Fella]

nicolasfella marked 5 inline comments as done.
nicolasfella added inline comments.

INLINE COMMENTS

> apol wrote in dbusmenushortcut_p.cpp:60
> const &, also this should possibly be transformed into a splitRef.

Doesn't work trivially because of the token.replace() below

> apol wrote in chrome.cpp:54
> const&?

Not trivially possible because of the 'new ProfileBookmarks(profile)' below

> apol wrote in screenpool.cpp:174
> Iterating through keys isn't very optimal, I'd use iterators here.

Agreed, but in another patch

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22087

To: nicolasfella, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23271: [Battery Monitor] Call battery capacity "degradation" for better clarity

[Alexander Potashev]

aspotashev added a comment.


  I disagree with this change, see https://phabricator.kde.org/D23270#515102

REPOSITORY
  R120 Plasma Workspace

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23271

To: ngraham, #vdg, broulik, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23288: Move XResources out of the central model into a plugin

[David Edmundson]

davidedmundson updated this revision to Diff 64125.
davidedmundson added a comment.


  Rebase diff

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23288?vs=64098=64125

REVISION DETAIL
  https://phabricator.kde.org/D23288

AFFECTED FILES
  processplugins/CMakeLists.txt
  processplugins/xres/CMakeLists.txt
  processplugins/xres/xres.cpp
  processplugins/xres/xres.h
  processplugins/xres/xres.json
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23292: Make update page labels consistent with topUpdateComp

[Felipe Peter]

MrPepe added a comment.


  This was my first contribution so I was following the wiki guide. 
  Running ctest showed that knsbackendtest fails. Is that a setup problem on my 
side or something that actually does not work?

REPOSITORY
  R134 Discover Software Store

BRANCH
  consistentLabels

REVISION DETAIL
  https://phabricator.kde.org/D23292

To: MrPepe, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23287: Create a plugin framework for processes

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> extended_process_list.cpp:62
> +{
> +QVector rc;
> +for (auto p: qAsConst(d->m_providers)) {

Add `reserve` call

> extended_process_list.cpp:76
> +if (!factory) {
> +return;
> +}

Shouldn't this be a `continue`?

> extended_process_list.h:38
> +private:
> +void loadPlugins();
> +class Private;

Shouldn't that be in the `Private`?

> formatter.h:37
> + */
> +enum FormatOption {
> +FormatOptionNone = 0,

This would look nicer with `enum class` but I don't really mind

> process_data_provider.cpp:38
> +QHash m_data;
> +bool m_enabled = 0;
> +};

`false`

> process_data_provider.h:21
> +
> +#include 
> +#include 

Unused

> process_data_provider.h:22
> +#include 
> +#include 
> +#include 

Unused

> process_data_provider.h:31
> +
> +class ProcessDataProvider;
> +

Not used before its declaration below?

> process_data_provider.h:54
> +bool enabled() const;
> +void setEnabled(const bool enable);
> +

Why `const`?

> process_data_provider.h:91
> +
> +KSysGuard::Unit unit() const;
> +void setUnit(KSysGuard::Unit unit);

Docs

> process_data_provider.h:133
> + */
> +KSysGuard::Processes* processes() const;
> +

Coding style: asterisk after space

> unit.h:24
> +#include 
> +#include 
> +#include 

Unused

> ProcessModel.cpp:515
> +for (int i = 0 ; i < mExtraAttributes.count(); i ++) {
> +mExtraAttributes[i]->setEnabled(true); // In future we will toggle 
> this based on column visibility
> +

Store `mExtraAttributes` in a variable

> ProcessModel.cpp:518
> +connect(mExtraAttributes[i], 
> ::ProcessAttribute::dataChanged, this, [this, i](KSysGuard::Process 
> *process) {
> +const QModelIndex index = q->getQModelIndex(process->parent(), 
> mHeadings.count() + i);
> +emit q->dataChanged(index, index);

Can this become out of sync, given you capture `i` as a copy into the lambda?

> ProcessModel.cpp:983
> +
> +if (section >= d->mHeadings.count() && section < columnCount()) {
> +int attr = section - d->mHeadings.count();

So when you now request a column >= `columnCount()` this cndition won't be met 
and you potentially access out of bounds below somewhere

> ProcessModel.cpp:1304
> +if (value.canConvert(QMetaType::LongLong)
> +&& static_cast(value.type()) != 
> QMetaType::QString) {
> +return Qt::AlignRight + Qt::AlignVCenter;

`value.type() == QVariant::String`?

> ProcessModel.cpp:1305
> +&& static_cast(value.type()) != 
> QMetaType::QString) {
> +return Qt::AlignRight + Qt::AlignVCenter;
> +}

Shouldn't those be or'd together? Interestingly, Qt documentation also uses 
addition.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D23287

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23292: Make update page labels consistent with topUpdateComp

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  How serindipitous; I was just about to do this myself! Needless to say, LGTM.

REPOSITORY
  R134 Discover Software Store

BRANCH
  consistentLabels

REVISION DETAIL
  https://phabricator.kde.org/D23292

To: MrPepe, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23292: Make update page labels consistent with topUpdateComp

[Felipe Peter]

MrPepe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
MrPepe requested review of this revision.

REVISION SUMMARY
  Made the labels on the update page consistent with the ones shown in the 
topUpdateComp of the main window

TEST PLAN
  Check for updates and see that the labels have changed

REPOSITORY
  R134 Discover Software Store

BRANCH
  consistentLabels

REVISION DETAIL
  https://phabricator.kde.org/D23292

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: MrPepe
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23126: Add browser action for status reporting

[Carl Schwan]

ognarb added a reviewer: ognarb.
ognarb added a comment.


  I will provide more feedback tomorrow, when I have more time.

INLINE COMMENTS

> action_popup.css:32
> +
> +main {
> +

Why it is empty?

> action_popup.css:45
> +}
> +.message.error {
> +

same

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23126

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

[Nathaniel Graham]

ngraham added a comment.


  In D23270#514911 , @meven wrote:
  
  > > To further reduce the confusion, the battery's degradation lavel is 
relocated to the Battery section.
  >
  > I don't think that is necessary.
  >  What is confusing in a degradation value in an energy section ?
  >  It is clearly an energy degradation value.
  
  
  No, energy doesn't degrade, but a battery does. Degradation is  a property of 
the physical battery itself, not its energy.
  
  > If we want to make things clearer we could name "Degradation" "Capacity 
degradation" for instance
  
  That could work.

REPOSITORY
  R102 KInfoCenter

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23270

To: ngraham, meven, broulik, #vdg, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23271: [Battery Monitor] Call battery capacity "degradation" for better clarity

[Nathaniel Graham]

ngraham updated this revision to Diff 64123.
ngraham marked an inline comment as done.
ngraham added a comment.


  Add context

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23271?vs=64063=64123

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23271

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: ngraham, #vdg, broulik, #plasma, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23283: When asked to switch sessions, skip to session creation if there's nothing to switch to

[Nathaniel Graham]

ngraham added a comment.


  In D23283#514927 , @broulik wrote:
  
  > Screenshots please
  
  
  Done; added screenshots and videos to the Test Plan section.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23283

To: ngraham, #plasma, #vdg
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23284: Add keyboard control for ProceedDialog buttons

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:44c8b0fe8d7a: Add keyboard control for ProceedDialog 
buttons (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23284?vs=64089=64121

REVISION DETAIL
  https://phabricator.kde.org/D23284

AFFECTED FILES
  discover/qml/DiscoverWindow.qml

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

[Alexander Potashev]

aspotashev added a comment.


  I don't like this change because it introduces a Plasma-specific formula and 
makes the user guess how to match "degradation: 21%" against let's say 
"capacity: 85%" s/he saw when using a different OS or desktop environment. For 
example:
  
  1. User looks at battery status in Plasma 5.16 and remembers battery capacity 
is 85%,
  2. User updates to Plasma 5.17 and now there is "degradation 21%". How does 
one know if battery health improved or worsened over time and if the change was 
substantial?

REPOSITORY
  R102 KInfoCenter

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23270

To: ngraham, meven, broulik, #vdg, #plasma, filipf
Cc: aspotashev, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Xwang]

https://bugs.kde.org/show_bug.cgi?id=350365

--- Comment #36 from Xwang  ---
(In reply to Xwang from comment #35)
> Today I got th same iisue upgrading plasma from 5.60.0-1 to 5.61.0-1 as
> described here
> https://bbs.archlinux.org/viewtopic.php?id=248579

And I can confirm that 
a) the battery indicator works correctly in the login screen when you the
session is locked
b) restarting plasma with kquitapp5 plasmashell ; kstart5 plasmashell is a
workaround that solves the issue till the following reboot.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Xwang]

https://bugs.kde.org/show_bug.cgi?id=350365

Xwang  changed:

   What|Removed |Added

 CC||xwaang1...@gmail.com

--- Comment #35 from Xwang  ---
Today I got th same iisue upgrading plasma from 5.60.0-1 to 5.61.0-1 as
described here
https://bbs.archlinux.org/viewtopic.php?id=248579

-- 
You are receiving this mail because:
You are the assignee for the bug.

D23287: Create a plugin framework for processes

[David Edmundson]

davidedmundson updated this revision to Diff 64100.
davidedmundson added a comment.


  Update

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23287?vs=64097=64100

REVISION DETAIL
  https://phabricator.kde.org/D23287

AFFECTED FILES
  processcore/CMakeLists.txt
  processcore/extended_process_list.cpp
  processcore/extended_process_list.h
  processcore/formatter.cpp
  processcore/formatter.h
  processcore/process_data_provider.cpp
  processcore/process_data_provider.h
  processcore/processes.cpp
  processcore/processes.h
  processcore/unit.cpp
  processcore/unit.h
  processui/ProcessModel.cpp
  processui/ProcessModel_p.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23285: Prevent dragging QQC2 ComboBox contents outside menu

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:ec1b5c60c19f: Prevent dragging QQC2 ComboBox contents 
outside menu (authored by GB_2).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23285?vs=64092=64099

REVISION DETAIL
  https://phabricator.kde.org/D23285

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: GB_2, #plasma, #frameworks, #vdg, filipf, apol
Cc: #vdg, #frameworks, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23288: Move XResources out of the central model into a plugin

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  XRes works in an odd way, the evaluation is inside the processui model,
  then it gets sent back into the process and proxied round.
  
  It leaves code in ProcessCore that doesn't work in a way one would expect.
  Though for API compat it can't be completely tidied up yet.
  
  By moving to a plugin we get no more ifdefs, no more special casing
  inside the core model.
  
  XRes extraction code is unchanged only moved

REPOSITORY
  R111 KSysguard Library

BRANCH
  plugins

REVISION DETAIL
  https://phabricator.kde.org/D23288

AFFECTED FILES
  processplugins/CMakeLists.txt
  processplugins/xres/CMakeLists.txt
  processplugins/xres/xres.cpp
  processplugins/xres/xres.h
  processplugins/xres/xres.json
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart