Re: Review Request 45391: HAWQ - Add option to enable or disabling exchanging keys during HAWQ start.

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45391/
---

(Updated March 29, 2016, 5:54 a.m.)


Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, and 
Oleksandr Diachenko.


Changes
---

Applied feedback


Bugs: AMBARI-15595
https://issues.apache.org/jira/browse/AMBARI-15595


Repository: ambari


Description
---

In HAWQ, SSH Keys are exchanged currently during every start of HAWQ Master. 
This patch introduces a flag to enable / disable exchanging keys during start.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
 fc5385f 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 d634fb2 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
 7c3a832 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 9d8b32d 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 4dc3cc8 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py e98b253 
  ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json 99d43cb 
  ambari-web/app/data/HDP2.3/site_properties.js e706d40 

Diff: https://reviews.apache.org/r/45391/diff/


Testing
---

yes
bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-28 10:42:36,732 
- Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to 
false or is not available in hawq-env.xml
ok
test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
test_install_default (test_hawqsegment.TestHawqSegment) ... ok
test_start_default (test_hawqsegment.TestHawqSegment) ... ok
test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
test_install_default (test_hawqstandby.TestHawqStandby) ... ok
test_start_default (test_hawqstandby.TestHawqStandby) ... ok
test_stop_default (test_hawqstandby.TestHawqStandby) ... ok

--
Ran 27 tests in 0.175s

OK


Thanks,

bhuvnesh chaudhary

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45347/
---

(Updated March 28, 2016, 7:19 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, Sebastian 
Toader, and Sid Wagle.


Changes
---

Add Id column to blueprint_settings table.


Bugs: AMBARI-15592
https://issues.apache.org/jira/browse/AMBARI-15592


Repository: ambari


Description
---

AMBARI-15592: Auto-start services - support blueprint deployment.

** Issue: **
Define a JSON structure to specify settings for auto start in a blueprint and 
use that information to enable or disable auto start for components during 
deployment.

** Changes **
Added a new section in the blueprint called "settings" which is a collection of 
various setting names to collection of properties. For auto start, the 
following setting names are used:
*recovery_settings*: {"recovery_enabled" : "true" } specifies that auto start 
should be enabled for all components. Can also be specified within a 
collection, to support a uniform schema.
*service_settings*: Collection of service names and the recovery values. 
[{"name":"HDFS", "recovery_enabled":"false"},{...}] overrides cluster level 
recovery settings.
*component_settings*: Collection of component names and the corresponding 
recovery values.  [{"name":"HDFS_CLIENT", "recovery_enabled":"true"},{...}]. 
Overrides both service settings and recovery settings.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
 8578d6beca91bf411d0c3dafeaee42d2dd23caea 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPK.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
 a5e2fa1c7a2adaadc8bbe9de15b913cd9a7ca456 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
11311dba0f1174248d24276a41837d7284e41607 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintFactory.java
 cca28ca1529d6bccdf7a870dab7c317c1a334b1d 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
 bea036421c64b70b4bceffcbd0d13c26020a7ed1 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Settings.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/SettingsFactory.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 38a3614ae3543ae1de0ea0bfd4191951c6d5c5ff 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
f8c97ca11040bff414626189591d86d4781be478 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
b306c0ab7687c6fe05c818acefa2d063e5b111ed 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
37744f8bc729e374a1db76f6509a6e85bffb37d0 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
eba1745d8c7a3e1b677cb8b8fc33d9ae09d0cf68 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
cad0a39d824fdbf03b1ec6cd2a99dec79fa916d2 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
346af50961fa1b2a41bd0a81121a08ec8ed70a2f 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
e238a7665dff5a52426be9e334e4a48f53c7dbee 
  ambari-server/src/main/resources/META-INF/persistence.xml 
513035f5baf6eacfcc69507069d311418546a09c 
  ambari-server/src/main/resources/properties.json 
01c15f2b1c3564c37e8203ec70f2d2b812135b13 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintEntityTest.java
 c660d19aee1727fd4734c07c0e5130f5bbe3c3cf 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPKTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/SettingsFactoryTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/SettingsTest.java 
PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 7b2d797486061a1377622806f7680176fa8ad458 

Diff: https://reviews.apache.org/r/45347/diff/


Testing
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [6.402s]
[INFO] Apache Ambari Project POM . SUCCESS [0.039s]
[INFO] Ambari Web  SUCCESS [24.133s]
[INFO] Ambari Views .. SUCCESS [1.280s]
[INFO] Ambari Admin View .

Review Request 45413: AMBARI-15611. Moving masters causes services to be shut down unnecessarily, causing downtime that's avoidable

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45413/
---

Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, Srimanth Gunturi, 
and Yusaku Sako.


Bugs: AMBARI-15611
https://issues.apache.org/jira/browse/AMBARI-15611


Repository: ambari


Description
---

When some services like Timeline service get moved to another host, unneeded 
services get shut down because of not exact mapping.


Diffs
-

  ambari-web/app/controllers/main/service/reassign/step4_controller.js 1d28834 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
4406bb0 

Diff: https://reviews.apache.org/r/45413/diff/


Testing
---

Manually tested on live cluster. All unit tests passed.
  25630 tests complete (25 seconds)
  154 tests pending


Thanks,

Richard Zang

Re: Review Request 45407: AMBARI-15114: Stack Featurize HBASE Service

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45407/#review125789
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 28, 2016, 11:38 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45407/
> ---
> 
> (Updated March 28, 2016, 11:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-15114
> https://issues.apache.org/jira/browse/AMBARI-15114
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize Accumulo Service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  f766a82 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2f0e6bf 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  c31bbf6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  9515f61 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  c17d219 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  9b0a195 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  87e4899 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py
>  e155cec 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/status_params.py
>  3ec84ee 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py
>  92c0f70 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  97bd19c 
> 
> Diff: https://reviews.apache.org/r/45407/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test  -DskipSurefireTests
> 
> [INFO] Ambari Metrics Common . SUCCESS [10.435s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [4.762s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.089s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.367s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [2.908s]
> [INFO] Ambari Metrics Collector .. SUCCESS [54.190s]
> [INFO] Ambari Metrics Monitor  SUCCESS [6.394s]
> [INFO] Ambari Metrics Grafana  SUCCESS [25.258s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [32.222s]
> [INFO] Ambari Server . SUCCESS [1:35.838s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.657s]
> [INFO] Ambari Agent .. SUCCESS [14.795s]
> [INFO] Ambari Client . SUCCESS [0.111s]
> [INFO] Ambari Python Client .. SUCCESS [1.233s]
> [INFO] Ambari Groovy Client .. SUCCESS [19.737s]
> [INFO] Ambari Shell .. SUCCESS [0.290s]
> [INFO] Ambari Python Shell ... SUCCESS [0.163s]
> [INFO] Ambari Groovy Shell ... SUCCESS [14.603s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 4:57.086s
> [INFO] Finished at: Mon Mar 28 16:29:18 PDT 2016
> [INFO] Final Memory: 111M/759M
> [INFO] --
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45395: Ambari API does not return HDFS RPC metrics based on ports

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45395/#review125784
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 (line 102)


Doesn't this need to be ConcurrentHashMap?



ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java
 (line 81)


Decription doesn't match function.


- Sid Wagle


On March 28, 2016, 6:19 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45395/
> ---
> 
> (Updated March 28, 2016, 6:19 p.m.)
> 
> 
> Review request for Ambari and Sid Wagle.
> 
> 
> Bugs: AMBARI-15606
> https://issues.apache.org/jira/browse/AMBARI-15606
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ISSUE: Ambari API does not return HDFS RPC metrics based on ports (Example 
> 8020 and 8040)
> When creating Ambari Widget we don't see an option to monitor by port. Hence 
> the monitoring of Random port or aggregate doesn't give correct information
> 
> After the patch, ambari automatically replaces port number with the 
> corresponding suffix
> client for the port specified in hdfs-site/dfs.namenode.rpc-address
> datanode for the port specified in hdfs-site/dfs.namenode.servicerpc-address
> healthcheck  for the port specified in 
> hdfs-site/dfs.namenode.lifeline.rpc-address
> 
> Request/response example
> 
> {
>   "href" : 
> "http://10.2.2.22:1081/api/v1/clusters/c1/services/HDFS/components/NAMENODE?fields=host_components/metrics/rpc/*,host_components/metrics/runtime/*";,
>   "ServiceComponentInfo" : {
> "cluster_name" : "c1",
> "component_name" : "NAMENODE",
> "service_name" : "HDFS"
>   },
>   "host_components" : [
> {
>   "href" : 
> "http://10.2.2.22:1081/api/v1/clusters/c1/hosts/c6401.ambari.apache.org/host_components/NAMENODE";,
>   "HostRoles" : {
> "cluster_name" : "c1",
> "component_name" : "NAMENODE",
> "host_name" : "c6401.ambari.apache.org"
>   },
>   "metrics" : {
> "rpc" : {
>   "client" : {
> "NumOpenConnections" : 0,
> "ReceivedBytes" : 2508,
> "RpcProcessingTime_avg_time" : 0.0,
> "RpcProcessingTime_num_ops" : 12,
> "RpcQueueTime_avg_time" : 0.0,
> "RpcQueueTime_num_ops" : 12,
> "SentBytes" : 408,
> "callQueueLen" : 0,
> "rpcAuthenticationFailures" : 0,
> "rpcAuthenticationSuccesses" : 0,
> "rpcAuthorizationFailures" : 0,
> "rpcAuthorizationSuccesses" : 12
>   },
>   "datanode" : {
> "NumOpenConnections" : 2,
> "ReceivedBytes" : 3269926,
> "RpcProcessingTime_avg_time" : 0.0,
> "RpcProcessingTime_num_ops" : 6029,
> "RpcQueueTime_avg_time" : 0.0,
> "RpcQueueTime_num_ops" : 6029,
> "SentBytes" : 248169,
> "callQueueLen" : 0,
> "rpcAuthenticationFailures" : 0,
> "rpcAuthenticationSuccesses" : 0,
> "rpcAuthorizationFailures" : 0,
> "rpcAuthorizationSuccesses" : 288
>   }
> },
> "runtime" : {
>   "StartTime" : 1459170322047
> }
>   }
> }
>   ]
> }
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  4b15b80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  7747753 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java
>  15d44b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
>  b883d2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java
>  41da279 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  b0e2e7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java
>  35ba605 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/PropertyHelperTest.java
>  2beb462 
> 
> Diff: https://reviews.apache.org/r/45395/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 45407: AMBARI-15114: Stack Featurize HBASE Service

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45407/
---

Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Bugs: AMBARI-15114
https://issues.apache.org/jira/browse/AMBARI-15114


Repository: ambari


Description
---

Stack Featurize Accumulo Service


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 f766a82 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 2f0e6bf 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
 c31bbf6 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
 9515f61 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
 c17d219 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 9b0a195 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
 87e4899 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py
 e155cec 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/status_params.py
 3ec84ee 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py
 92c0f70 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 97bd19c 

Diff: https://reviews.apache.org/r/45407/diff/


Testing
---

mvn clean test  -DskipSurefireTests

[INFO] Ambari Metrics Common . SUCCESS [10.435s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [4.762s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.089s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.367s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [2.908s]
[INFO] Ambari Metrics Collector .. SUCCESS [54.190s]
[INFO] Ambari Metrics Monitor  SUCCESS [6.394s]
[INFO] Ambari Metrics Grafana  SUCCESS [25.258s]
[INFO] Ambari Metrics Assembly ... SUCCESS [32.222s]
[INFO] Ambari Server . SUCCESS [1:35.838s]
[INFO] Ambari Functional Tests ... SUCCESS [2.657s]
[INFO] Ambari Agent .. SUCCESS [14.795s]
[INFO] Ambari Client . SUCCESS [0.111s]
[INFO] Ambari Python Client .. SUCCESS [1.233s]
[INFO] Ambari Groovy Client .. SUCCESS [19.737s]
[INFO] Ambari Shell .. SUCCESS [0.290s]
[INFO] Ambari Python Shell ... SUCCESS [0.163s]
[INFO] Ambari Groovy Shell ... SUCCESS [14.603s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 4:57.086s
[INFO] Finished at: Mon Mar 28 16:29:18 PDT 2016
[INFO] Final Memory: 111M/759M
[INFO] --


Thanks,

Juanjo  Marron

Re: Review Request 45321: Ambari calculates stack downgrade as ABORTED under incorrect conditions. UI shows 'Downgrade paused' and button to resume downgrade even when progress is happening

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45321/
---

(Updated March 28, 2016, 11:14 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
Hurley, and Nate Cole.


Changes
---

Fixed unit tests and removed getSuspended() method since isSuspended() already 
exists.


Bugs: AMBARI-15569
https://issues.apache.org/jira/browse/AMBARI-15569


Repository: ambari


Description
---

*STR:*
1. Install Ambari 2.2.0
2. Upgrade stack from HDP-2.2.4 to HDP-2.3.2
3. At finalize step, choose downgrade option
4. Introduce failures in some clients such as Zookeeper and Yarn.

In this case, the status of some tasks are marked as ABORTED.
This causes the overall status of the Downgrade to be ABORTED, and hence the UI 
shows an incorrect message and button.
Technically, the Downgrade is still progressing, yet the UI shows "Downgrade 
paused" and a button to "Resume Downgrade"

This means that the calculations of the stages is incorrect.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java
 1d8df9b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 d43daca 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
 fd866a1 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java
 8d80fa6 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
 c18a8b6 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 d37f3ba 

Diff: https://reviews.apache.org/r/45321/diff/


Testing
---

Verified on live cluster and ran unit tests in CalculateStatusTest.java


Thanks,

Alejandro Fernandez

Review Request 45405: AMBARI-15610 Add Service Wizard: invalid host name doesn't prevent proceeding to next page

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45405/
---

Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Oleg Nechiporenko, 
Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15610
https://issues.apache.org/jira/browse/AMBARI-15610


Repository: ambari


Description
---

On "Add Service Wizard Assign Masters" page, invalid host name (when there are 
more than 25 hosts, we use input field instead of select list) does not disable 
the "next" button. After clicking the next button, wizard navigates to "Assign 
Slaves and Clients" page and the (wrong) input of the host name gets ignored 
without notification.


Diffs
-

  ambari-web/app/messages.js 4fa6ba5 
  ambari-web/app/mixins/wizard/assign_master_components.js 93ecac3 
  ambari-web/app/views/common/assign_master_components_view.js bfc674d 

Diff: https://reviews.apache.org/r/45405/diff/


Testing
---

Local ambari-web test passed.
24689 tests complete (21 seconds)
145 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 45391: HAWQ - Add option to enable or disabling exchanging keys during HAWQ start.

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45391/#review125766
---


Ship it!





ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
 (line 36)


Since this would appear as a checkbox on the configs, the description 
wouldn't show. The last time I checked, checkboxes do not show descriptions 
while hovering over the checkbox



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
 (line 39)


Enable/Disable (with no space before or after slash)



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
 (line 41)


or when HAWQ **components** are added to new hosts?

exchanged every time **during**  HAWQ Master start?



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 (line 43)


The hawq_hosts_file is probably required only on HAWQMASTER before running 
custom action HAWQ Check.

Should we create/overwrite the file right before running HAWQ Check so that 
it has the most recent host list before running HAWQ Check.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 (line 46)


setup_passwordless_ssh is used only by HAWQMASTER.

You may move this function to hawqmaster.py if you are keen.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 (line 60)


Do you think it would be better to provide the user the list of hosts on 
which ssh key exchange failed?


- Matt


On March 28, 2016, 10:42 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45391/
> ---
> 
> (Updated March 28, 2016, 10:42 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, and 
> Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-15595
> https://issues.apache.org/jira/browse/AMBARI-15595
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In HAWQ, SSH Keys are exchanged currently during every start of HAWQ Master. 
> This patch introduces a flag to enable / disable exchanging keys during start.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
>  fc5385f 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  d634fb2 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  7c3a832 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  9d8b32d 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
>  d3c9009 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 4dc3cc8 
>   ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json 99d43cb 
>   ambari-web/app/data/HDP2.3/site_properties.js e706d40 
> 
> Diff: https://reviews.apache.org/r/45391/diff/
> 
> 
> Testing
> ---
> 
> yes
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestH

Re: Review Request 45325: Add the Config, Start and Stop logic for: (1). Hive Server Interactive, and (2). Associate the LLAP lifecycle to it.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/#review125762
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 (line 107)


Why does this need to accept self?



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 (line 147)


Stylistically, better to always end with a "return False", and only return 
True in the success condition.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 (line 155)


May want to enclose the content of finally inside its own try-except



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 (line 163)


Use LOG.


- Alejandro Fernandez


On March 27, 2016, 11:14 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45325/
> ---
> 
> (Updated March 27, 2016, 11:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15573
> https://issues.apache.org/jira/browse/AMBARI-15573
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), 
> and (2). Associate the LLAP lifecycle to it.
> 
> - Start of HSI : Create LLAP package, start LLAP and then start HSI.
> - Stop: Stop HSI and then LLAP.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  f07b76f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  3532efc 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  8a4e7e6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  12cf336 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  6f05fbc 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  a6e4a47 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 
> 1e349a1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  face571 
> 
> Diff: https://reviews.apache.org/r/45325/diff/
> 
> 
> Testing
> ---
> 
> Yes.
>  - 2.6: Installation, config, Start and Stop of Hive Server Interactive after 
> Hive Server Batch -> Works.
>  - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> 
> Works
>  - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along 
> with Hive Server Batch -> Works.
>  - 2.5 : Negative testing :  Only Hive Batch gets installed. (Hive Server 
> Interactive not present).
>  - 
>  - Python UT : Passes.
>  - mvn clean test : ongoing. Will update.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

[Nate Cole]

> On March 28, 2016, 2:44 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 424
> > 
> >
> > Let's use an ID here for the PK, so we can reference it in other tables 
> > as a FK.
> > We can make blueprint_name a UQ
> 
> Alejandro Fernandez wrote:
> Also, let's give names to the FK and UK.
> 
> Nahappan Somasundaram wrote:
> Blueprint name per row is not unique. Depending on the numbe of settings, 
> the blueprint_name will be repeated. A sequential ID column can be added for 
> future use as a FK lookup.
> 
> Nahappan Somasundaram wrote:
> The blueprint_configuration and blueprint_settings tables are read only 
> once during the template deployment. If we want to reference the blueprint 
> name using an UQ id, then the blueprint table needs an ID column. Then 
> blueprint_configuration  and blueprint_settings table need to be modified, 
> which is a lot of ask for one read.
> 
> In the blueprint_settings table, blueprint_name and setting_name form the 
> composite PK. Adding an ID column in this table does not add much value 
> unless we plan to use it later for quick lookup or search.
> 
> Alejandro Fernandez wrote:
> Let's use the PK as the ID then. We can enforce uniqueness of name and 
> setting via business logic and/or named UQ.
> We've ran into problem in the past by not using IDs as PKs.

+1 for id column as PK.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45347/#review125704
---


On March 27, 2016, 5:51 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45347/
> ---
> 
> (Updated March 27, 2016, 5:51 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, 
> Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15592
> https://issues.apache.org/jira/browse/AMBARI-15592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15592: Auto-start services - support blueprint deployment.
> 
> ** Issue: **
> Define a JSON structure to specify settings for auto start in a blueprint and 
> use that information to enable or disable auto start for components during 
> deployment.
> 
> ** Changes **
> Added a new section in the blueprint called "settings" which is a collection 
> of various setting names to collection of properties. For auto start, the 
> following setting names are used:
> *recovery_settings*: {"recovery_enabled" : "true" } specifies that auto start 
> should be enabled for all components. Can also be specified within a 
> collection, to support a uniform schema.
> *service_settings*: Collection of service names and the recovery values. 
> [{"name":"HDFS", "recovery_enabled":"false"},{...}] overrides cluster level 
> recovery settings.
> *component_settings*: Collection of component names and the corresponding 
> recovery values.  [{"name":"HDFS_CLIENT", "recovery_enabled":"true"},{...}]. 
> Overrides both service settings and recovery settings.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
>  8578d6beca91bf411d0c3dafeaee42d2dd23caea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPK.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  87225adc0afafc111b865120fd71742dc4e096f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> 11311dba0f1174248d24276a41837d7284e41607 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintFactory.java
>  cca28ca1529d6bccdf7a870dab7c317c1a334b1d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  bea036421c64b70b4bceffcbd0d13c26020a7ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Settings.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/SettingsFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  38a3614ae3543ae1de0ea0bfd4191951c6d5c5ff 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> f8c97ca11040bff414626189591d86d4781be478 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> b306c0ab7687c6fe05c818acefa2d063e5b111ed 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> 37744f8bc729e374a1db76f6509a6e85bffb37d0 

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

[Juanjo Marron]

> On March 28, 2016, 6:28 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py,
> >  line 56
> > 
> >
> > The point of this function was to have a dictionary with the key being 
> > each possible stack name. If we always return "hadoop-client", might as 
> > well just return it as a string no matter what.

The didct value is changing depending the component. The key is always the same 
("HDP" and stack_name now).

Since several services were already pushed to trunk with this same approcah, I 
would propose to solve first stack featurization for all the services and 
create a new JIRA to modify get_stack_to_component() after that.

I think the method def get_stack_to_component(self): in script.py can be 
redefined to obtain the stack_name at script.py level (method def 
get_stack_name()) and to return just a string with the component name at 
service level.


> On March 28, 2016, 6:28 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py,
> >  line 22
> > 
> >
> > Can we remove the import *?

Most of the service scripts still include the from resource_management import * 
line. 
I found 123 matches searching in common-services.
It would be great to clean up the extra/non use imports, but if @afernandez 
agrees, I think it is out of the scope of this stack featuraization work


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45338/#review125695
---


On March 28, 2016, 4:09 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45338/
> ---
> 
> (Updated March 28, 2016, 4:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15053
> https://issues.apache.org/jira/browse/AMBARI-15053
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Featurize HDP specific logic from YARN and MR service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  f766a82 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2f0e6bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
>  2966581 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
>  53b0e53 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  9fc1e32 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  fd14d0f 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  52f42b0 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  e51ca8a 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  83bf460 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  4110d39 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
>  d300279 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  97bd19c 
> 
> Diff: https://reviews.apache.org/r/45338/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [17.789s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.379s]
> [INFO] Ambari Web  SUCCESS [1:28.925s]
> [INFO] Ambari Views .. SUCCESS [7.096s]
> [INFO] Ambari Admin View . SUCCESS [18.829s]
> [INFO] ambari-metrics  SUCCESS [0.358s]
> [INFO] Ambari Metrics Common . SUCCESS [1.222s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [2.142s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.640s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.800s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [2.858s]
> [INFO] Ambari 

Re: Review Request 45321: Ambari calculates stack downgrade as ABORTED under incorrect conditions. UI shows 'Downgrade paused' and button to resume downgrade even when progress is happening

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45321/#review125740
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
 (lines 203 - 205)


I see this in trunk already as isSuspended() ?


- Nate Cole


On March 24, 2016, 6:28 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45321/
> ---
> 
> (Updated March 24, 2016, 6:28 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-15569
> https://issues.apache.org/jira/browse/AMBARI-15569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *STR:*
> 1. Install Ambari 2.2.0
> 2. Upgrade stack from HDP-2.2.4 to HDP-2.3.2
> 3. At finalize step, choose downgrade option
> 4. Introduce failures in some clients such as Zookeeper and Yarn.
> 
> In this case, the status of some tasks are marked as ABORTED.
> This causes the overall status of the Downgrade to be ABORTED, and hence the 
> UI shows an incorrect message and button.
> Technically, the Downgrade is still progressing, yet the UI shows "Downgrade 
> paused" and a button to "Resume Downgrade"
> 
> This means that the calculations of the stages is incorrect.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java
>  1d8df9b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  d43daca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  fd866a1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java
>  8d80fa6 
> 
> Diff: https://reviews.apache.org/r/45321/diff/
> 
> 
> Testing
> ---
> 
> Verified on live cluster and ran unit tests in CalculateStatusTest.java
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 45391: HAWQ - Add option to enable or disabling exchanging keys during HAWQ start.

[bhuvnesh chaudhary]

> On March 28, 2016, 6:03 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py,
> >  line 313
> > 
> >
> > can use default("/configuration/hdfs-site/dfs.allow.truncate", None)

Thanks for the review Alejandro, will make the change.


- bhuvnesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45391/#review125690
---


On March 28, 2016, 5:42 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45391/
> ---
> 
> (Updated March 28, 2016, 5:42 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, and 
> Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-15595
> https://issues.apache.org/jira/browse/AMBARI-15595
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In HAWQ, SSH Keys are exchanged currently during every start of HAWQ Master. 
> This patch introduces a flag to enable / disable exchanging keys during start.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
>  fc5385f 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  d634fb2 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  7c3a832 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  9d8b32d 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
>  d3c9009 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 4dc3cc8 
>   ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json 99d43cb 
>   ambari-web/app/data/HDP2.3/site_properties.js e706d40 
> 
> Diff: https://reviews.apache.org/r/45391/diff/
> 
> 
> Testing
> ---
> 
> yes
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-28 
> 10:42:36,732 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys 
> is either set to false or is not available in hawq-env.xml
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> 
> --
> Ran 27 tests in 0.175s
> 
> OK
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 45208: Cleanup LDAP sync process

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45208/
---

(Updated March 28, 2016, 8:23 p.m.)


Review request for Ambari, Daniel Gergely, Robert Levas, and Sebastian Toader.


Changes
---

- added additional TRACE logging
- added regexp
- added unit tests


Bugs: AMBARI-15383
https://issues.apache.org/jira/browse/AMBARI-15383


Repository: ambari


Description
---

Cleanup LDAP sync process:
- speedup sync with "--all" (do not check nested groups recursively...ambari 
gather all of the groups first, and it's enough to just process them 
sequentially)
- fixing issue: uppercase member attributes (in ambari.properties) don't work 
well with the queries


Diffs (updated)
-

  ambari-server/conf/unix/log4j.properties ab3ea0b 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 c2bc22f 
  
ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
 75df9cc 
  
ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
 3ea 

Diff: https://reviews.apache.org/r/45208/diff/


Testing (updated)
---

Testing is in progress


Thanks,

Oliver Szabo

Re: Review Request 45220: /tmp hdfs folder created with mode 0777

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45220/#review125733
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 25, 2016, 9:18 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45220/
> ---
> 
> (Updated March 25, 2016, 9:18 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-15531
> https://issues.apache.org/jira/browse/AMBARI-15531
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When cluster created via blueprint the /tmp folder may be created implicitly 
> by various components with permissions that prevent other components to write 
> to it. In the specific case described by the linked issue, the folder has 
> been created when starting the historyserver, and later on the folder 
> couldn't be written by the hiveserver2. (ideally the folder is expected to be 
> created when the namenode starts)
> 
> The patch fixes the specific case described in the bug, however a more 
> robust/generic solution is needed to properly sort out the problem.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  05e19cf 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> b1634d0 
> 
> Diff: https://reviews.apache.org/r/45220/diff/
> 
> 
> Testing
> ---
> 
> Unit tests in progress.
> Manual testing under way
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

[Alejandro Fernandez]

> On March 28, 2016, 6:44 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 676
> > 
> >
> > How do we ensure this is TEXT and not VARCHAR?
> 
> Nahappan Somasundaram wrote:
> Is there a way to specify a column as a TEXT in DBColumnInfo?

We need to ensure the datatype is consistent in both cases: fresh install vs 
upgrade


> On March 28, 2016, 6:44 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 424
> > 
> >
> > Let's use an ID here for the PK, so we can reference it in other tables 
> > as a FK.
> > We can make blueprint_name a UQ
> 
> Alejandro Fernandez wrote:
> Also, let's give names to the FK and UK.
> 
> Nahappan Somasundaram wrote:
> Blueprint name per row is not unique. Depending on the numbe of settings, 
> the blueprint_name will be repeated. A sequential ID column can be added for 
> future use as a FK lookup.
> 
> Nahappan Somasundaram wrote:
> The blueprint_configuration and blueprint_settings tables are read only 
> once during the template deployment. If we want to reference the blueprint 
> name using an UQ id, then the blueprint table needs an ID column. Then 
> blueprint_configuration  and blueprint_settings table need to be modified, 
> which is a lot of ask for one read.
> 
> In the blueprint_settings table, blueprint_name and setting_name form the 
> composite PK. Adding an ID column in this table does not add much value 
> unless we plan to use it later for quick lookup or search.

Let's use the PK as the ID then. We can enforce uniqueness of name and setting 
via business logic and/or named UQ.
We've ran into problem in the past by not using IDs as PKs.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45347/#review125704
---


On March 27, 2016, 9:51 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45347/
> ---
> 
> (Updated March 27, 2016, 9:51 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, 
> Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15592
> https://issues.apache.org/jira/browse/AMBARI-15592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15592: Auto-start services - support blueprint deployment.
> 
> ** Issue: **
> Define a JSON structure to specify settings for auto start in a blueprint and 
> use that information to enable or disable auto start for components during 
> deployment.
> 
> ** Changes **
> Added a new section in the blueprint called "settings" which is a collection 
> of various setting names to collection of properties. For auto start, the 
> following setting names are used:
> *recovery_settings*: {"recovery_enabled" : "true" } specifies that auto start 
> should be enabled for all components. Can also be specified within a 
> collection, to support a uniform schema.
> *service_settings*: Collection of service names and the recovery values. 
> [{"name":"HDFS", "recovery_enabled":"false"},{...}] overrides cluster level 
> recovery settings.
> *component_settings*: Collection of component names and the corresponding 
> recovery values.  [{"name":"HDFS_CLIENT", "recovery_enabled":"true"},{...}]. 
> Overrides both service settings and recovery settings.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
>  8578d6beca91bf411d0c3dafeaee42d2dd23caea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPK.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  87225adc0afafc111b865120fd71742dc4e096f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> 11311dba0f1174248d24276a41837d7284e41607 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintFactory.java
>  cca28ca1529d6bccdf7a870dab7c317c1a334b1d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  bea036421c64b70b4bceffcbd0d13c26020a7ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Settings.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/SettingsFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

[Nahappan Somasundaram]

> On March 28, 2016, 11:44 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 424
> > 
> >
> > Let's use an ID here for the PK, so we can reference it in other tables 
> > as a FK.
> > We can make blueprint_name a UQ
> 
> Alejandro Fernandez wrote:
> Also, let's give names to the FK and UK.
> 
> Nahappan Somasundaram wrote:
> Blueprint name per row is not unique. Depending on the numbe of settings, 
> the blueprint_name will be repeated. A sequential ID column can be added for 
> future use as a FK lookup.

The blueprint_configuration and blueprint_settings tables are read only once 
during the template deployment. If we want to reference the blueprint name 
using an UQ id, then the blueprint table needs an ID column. Then 
blueprint_configuration  and blueprint_settings table need to be modified, 
which is a lot of ask for one read.

In the blueprint_settings table, blueprint_name and setting_name form the 
composite PK. Adding an ID column in this table does not add much value unless 
we plan to use it later for quick lookup or search.


- Nahappan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45347/#review125704
---


On March 27, 2016, 2:51 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45347/
> ---
> 
> (Updated March 27, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, 
> Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15592
> https://issues.apache.org/jira/browse/AMBARI-15592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15592: Auto-start services - support blueprint deployment.
> 
> ** Issue: **
> Define a JSON structure to specify settings for auto start in a blueprint and 
> use that information to enable or disable auto start for components during 
> deployment.
> 
> ** Changes **
> Added a new section in the blueprint called "settings" which is a collection 
> of various setting names to collection of properties. For auto start, the 
> following setting names are used:
> *recovery_settings*: {"recovery_enabled" : "true" } specifies that auto start 
> should be enabled for all components. Can also be specified within a 
> collection, to support a uniform schema.
> *service_settings*: Collection of service names and the recovery values. 
> [{"name":"HDFS", "recovery_enabled":"false"},{...}] overrides cluster level 
> recovery settings.
> *component_settings*: Collection of component names and the corresponding 
> recovery values.  [{"name":"HDFS_CLIENT", "recovery_enabled":"true"},{...}]. 
> Overrides both service settings and recovery settings.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
>  8578d6beca91bf411d0c3dafeaee42d2dd23caea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPK.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  87225adc0afafc111b865120fd71742dc4e096f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> 11311dba0f1174248d24276a41837d7284e41607 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintFactory.java
>  cca28ca1529d6bccdf7a870dab7c317c1a334b1d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  bea036421c64b70b4bceffcbd0d13c26020a7ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Settings.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/SettingsFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  38a3614ae3543ae1de0ea0bfd4191951c6d5c5ff 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> f8c97ca11040bff414626189591d86d4781be478 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> b306c0ab7687c6fe05c818acefa2d063e5b111ed 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> 37744f8bc729e374a1db76f6509a6e85bffb37d0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> eba1745d8c7a3e1b677cb8b8fc33d9ae09d0cf68 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> cad0a39d824fdbf03b1ec6cd2a99dec79fa916d2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sq

Re: Review Request 45390: Database Changes to Support Alert Repeat Tolerance

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45390/#review125719
---


Ship it!




Ship It!

- Robert Nettleton


On March 28, 2016, 5:21 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45390/
> ---
> 
> (Updated March 28, 2016, 5:21 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Nettleton.
> 
> 
> Bugs: AMBARI-15602
> https://issues.apache.org/jira/browse/AMBARI-15602
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{alert_definition}} table will be updated to include a nullable column 
> which represents the custom repeat/retry tolerance value. This value will 
> override that which is set in the {{cluster-env/alerts_repeat_tolerance}} 
> property.
> 
> {code}
> CREATE TABLE alert_definition (
>   definition_id BIGINT NOT NULL,
>   cluster_id BIGINT NOT NULL,
>   ...
>   repeat_tolerance SMALLINT,
>   repeat_tolerance_enabled TINYINT,
>   ...
>   PRIMARY KEY (definition_id),
>   FOREIGN KEY (cluster_id) REFERENCES clusters(cluster_id),
>   CONSTRAINT uni_alert_def_name UNIQUE(cluster_id,definition_name)
> );
> {code}
> 
> The scope of work includes:
> - SQL File changes
> - Entity changes
> - ResourceProvider changes to expose these values
> - UpgradeCatalog changes
> - Tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
>  08a708f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
>  b08935c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  38a3614 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f8c97ca 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b306c0a 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 37744f8 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql eba1745 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> cad0a39 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 346af50 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e238a76 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7b2d797 
> 
> Diff: https://reviews.apache.org/r/45390/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 45294: Add OS button on Edit repository version page shows extra space when no repositories have been selected for removal

[Sangeeta Ravindran]

> On March 28, 2016, 6:56 p.m., Alexandr Antonenko wrote:
> > Ship It!

Thank you Alexander. Can you please help push the fix?


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45294/#review125711
---


On March 27, 2016, 8:27 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45294/
> ---
> 
> (Updated March 27, 2016, 8:27 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Oleg Nechiporenko, and Xi Wang.
> 
> 
> Bugs: AMBARI-15548
> https://issues.apache.org/jira/browse/AMBARI-15548
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Add OS button shows an empty drop down when there are no entries in the 
> list i.e. when no repositories have been deleted.
> Need to hide the drop-down when none of the repositories are selected for 
> deletion.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
>  2c3f000 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  a7dcaa5 
> 
> Diff: https://reviews.apache.org/r/45294/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 45390: Database Changes to Support Alert Repeat Tolerance

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45390/#review125714
---


Ship it!




Ship It!

- Nate Cole


On March 28, 2016, 1:21 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45390/
> ---
> 
> (Updated March 28, 2016, 1:21 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Nettleton.
> 
> 
> Bugs: AMBARI-15602
> https://issues.apache.org/jira/browse/AMBARI-15602
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{alert_definition}} table will be updated to include a nullable column 
> which represents the custom repeat/retry tolerance value. This value will 
> override that which is set in the {{cluster-env/alerts_repeat_tolerance}} 
> property.
> 
> {code}
> CREATE TABLE alert_definition (
>   definition_id BIGINT NOT NULL,
>   cluster_id BIGINT NOT NULL,
>   ...
>   repeat_tolerance SMALLINT,
>   repeat_tolerance_enabled TINYINT,
>   ...
>   PRIMARY KEY (definition_id),
>   FOREIGN KEY (cluster_id) REFERENCES clusters(cluster_id),
>   CONSTRAINT uni_alert_def_name UNIQUE(cluster_id,definition_name)
> );
> {code}
> 
> The scope of work includes:
> - SQL File changes
> - Entity changes
> - ResourceProvider changes to expose these values
> - UpgradeCatalog changes
> - Tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
>  08a708f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
>  b08935c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  38a3614 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f8c97ca 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b306c0a 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 37744f8 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql eba1745 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> cad0a39 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 346af50 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e238a76 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7b2d797 
> 
> Diff: https://reviews.apache.org/r/45390/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

[Nahappan Somasundaram]

> On March 28, 2016, 11:44 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 424
> > 
> >
> > Let's use an ID here for the PK, so we can reference it in other tables 
> > as a FK.
> > We can make blueprint_name a UQ
> 
> Alejandro Fernandez wrote:
> Also, let's give names to the FK and UK.

Blueprint name per row is not unique. Depending on the numbe of settings, the 
blueprint_name will be repeated. A sequential ID column can be added for future 
use as a FK lookup.


> On March 28, 2016, 11:44 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 676
> > 
> >
> > How do we ensure this is TEXT and not VARCHAR?

Is there a way to specify a column as a TEXT in DBColumnInfo?


- Nahappan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45347/#review125704
---


On March 27, 2016, 2:51 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45347/
> ---
> 
> (Updated March 27, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, 
> Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15592
> https://issues.apache.org/jira/browse/AMBARI-15592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15592: Auto-start services - support blueprint deployment.
> 
> ** Issue: **
> Define a JSON structure to specify settings for auto start in a blueprint and 
> use that information to enable or disable auto start for components during 
> deployment.
> 
> ** Changes **
> Added a new section in the blueprint called "settings" which is a collection 
> of various setting names to collection of properties. For auto start, the 
> following setting names are used:
> *recovery_settings*: {"recovery_enabled" : "true" } specifies that auto start 
> should be enabled for all components. Can also be specified within a 
> collection, to support a uniform schema.
> *service_settings*: Collection of service names and the recovery values. 
> [{"name":"HDFS", "recovery_enabled":"false"},{...}] overrides cluster level 
> recovery settings.
> *component_settings*: Collection of component names and the corresponding 
> recovery values.  [{"name":"HDFS_CLIENT", "recovery_enabled":"true"},{...}]. 
> Overrides both service settings and recovery settings.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
>  8578d6beca91bf411d0c3dafeaee42d2dd23caea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPK.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  87225adc0afafc111b865120fd71742dc4e096f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> 11311dba0f1174248d24276a41837d7284e41607 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintFactory.java
>  cca28ca1529d6bccdf7a870dab7c317c1a334b1d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  bea036421c64b70b4bceffcbd0d13c26020a7ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Settings.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/SettingsFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  38a3614ae3543ae1de0ea0bfd4191951c6d5c5ff 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> f8c97ca11040bff414626189591d86d4781be478 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> b306c0ab7687c6fe05c818acefa2d063e5b111ed 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> 37744f8bc729e374a1db76f6509a6e85bffb37d0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> eba1745d8c7a3e1b677cb8b8fc33d9ae09d0cf68 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> cad0a39d824fdbf03b1ec6cd2a99dec79fa916d2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 346af50961fa1b2a41bd0a81121a08ec8ed70a2f 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
> e238a7665dff5a52426be9e334e4a48f53c7dbee 
>   ambari-server/src/main/resources/META-INF/persistenc

Re: Review Request 45385: Make oozie tmp dir configurable

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45385/#review125712
---




ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
 (line 132)


Should we create /var/tmp/oozie dir by ambari agent ?


- Dmytro Sen


On Март 28, 2016, 3:48 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45385/
> ---
> 
> (Updated Март 28, 2016, 3:48 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15600
> https://issues.apache.org/jira/browse/AMBARI-15600
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Oozie tmp dir is hardcoded as of now. We should give ability for user to 
> change ethis property on UI and use this customized value in code.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
>  3cb2d60 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  61cbd8c 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json b8842c4 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_oozie_mysql.json 
> 898ed33 
>   ambari-server/src/test/python/stacks/2.0.6/configs/oozie_existing_sqla.json 
> 09e34f9 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json e053ca0 
> 
> Diff: https://reviews.apache.org/r/45385/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 45294: Add OS button on Edit repository version page shows extra space when no repositories have been selected for removal

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45294/#review125711
---


Ship it!




Ship It!

- Alexandr Antonenko


On March 27, 2016, 8:27 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45294/
> ---
> 
> (Updated March 27, 2016, 8:27 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Oleg Nechiporenko, and Xi Wang.
> 
> 
> Bugs: AMBARI-15548
> https://issues.apache.org/jira/browse/AMBARI-15548
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Add OS button shows an empty drop down when there are no entries in the 
> list i.e. when no repositories have been deleted.
> Need to hide the drop-down when none of the repositories are selected for 
> deletion.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
>  2c3f000 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  a7dcaa5 
> 
> Diff: https://reviews.apache.org/r/45294/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 45385: Make oozie tmp dir configurable

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45385/#review125709
---


Ship it!




Ship It!

- Dmytro Sen


On Март 28, 2016, 3:48 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45385/
> ---
> 
> (Updated Март 28, 2016, 3:48 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15600
> https://issues.apache.org/jira/browse/AMBARI-15600
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Oozie tmp dir is hardcoded as of now. We should give ability for user to 
> change ethis property on UI and use this customized value in code.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
>  3cb2d60 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  61cbd8c 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json b8842c4 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_oozie_mysql.json 
> 898ed33 
>   ambari-server/src/test/python/stacks/2.0.6/configs/oozie_existing_sqla.json 
> 09e34f9 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json e053ca0 
> 
> Diff: https://reviews.apache.org/r/45385/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

[Alejandro Fernandez]

> On March 28, 2016, 6:44 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 424
> > 
> >
> > Let's use an ID here for the PK, so we can reference it in other tables 
> > as a FK.
> > We can make blueprint_name a UQ

Also, let's give names to the FK and UK.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45347/#review125704
---


On March 27, 2016, 9:51 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45347/
> ---
> 
> (Updated March 27, 2016, 9:51 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, 
> Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15592
> https://issues.apache.org/jira/browse/AMBARI-15592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15592: Auto-start services - support blueprint deployment.
> 
> ** Issue: **
> Define a JSON structure to specify settings for auto start in a blueprint and 
> use that information to enable or disable auto start for components during 
> deployment.
> 
> ** Changes **
> Added a new section in the blueprint called "settings" which is a collection 
> of various setting names to collection of properties. For auto start, the 
> following setting names are used:
> *recovery_settings*: {"recovery_enabled" : "true" } specifies that auto start 
> should be enabled for all components. Can also be specified within a 
> collection, to support a uniform schema.
> *service_settings*: Collection of service names and the recovery values. 
> [{"name":"HDFS", "recovery_enabled":"false"},{...}] overrides cluster level 
> recovery settings.
> *component_settings*: Collection of component names and the corresponding 
> recovery values.  [{"name":"HDFS_CLIENT", "recovery_enabled":"true"},{...}]. 
> Overrides both service settings and recovery settings.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
>  8578d6beca91bf411d0c3dafeaee42d2dd23caea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPK.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  87225adc0afafc111b865120fd71742dc4e096f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> 11311dba0f1174248d24276a41837d7284e41607 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintFactory.java
>  cca28ca1529d6bccdf7a870dab7c317c1a334b1d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  bea036421c64b70b4bceffcbd0d13c26020a7ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Settings.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/SettingsFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  38a3614ae3543ae1de0ea0bfd4191951c6d5c5ff 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> f8c97ca11040bff414626189591d86d4781be478 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> b306c0ab7687c6fe05c818acefa2d063e5b111ed 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> 37744f8bc729e374a1db76f6509a6e85bffb37d0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> eba1745d8c7a3e1b677cb8b8fc33d9ae09d0cf68 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> cad0a39d824fdbf03b1ec6cd2a99dec79fa916d2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 346af50961fa1b2a41bd0a81121a08ec8ed70a2f 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
> e238a7665dff5a52426be9e334e4a48f53c7dbee 
>   ambari-server/src/main/resources/META-INF/persistence.xml 
> 513035f5baf6eacfcc69507069d311418546a09c 
>   ambari-server/src/main/resources/properties.json 
> 01c15f2b1c3564c37e8203ec70f2d2b812135b13 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintEntityTest.java
>  c660d19aee1727fd4734c07c0e5130f5bbe3c3cf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPKTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45347/#review125704
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 676)


How do we ensure this is TEXT and not VARCHAR?



ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql (line 424)


Let's use an ID here for the PK, so we can reference it in other tables as 
a FK.
We can make blueprint_name a UQ


- Alejandro Fernandez


On March 27, 2016, 9:51 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45347/
> ---
> 
> (Updated March 27, 2016, 9:51 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, 
> Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15592
> https://issues.apache.org/jira/browse/AMBARI-15592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15592: Auto-start services - support blueprint deployment.
> 
> ** Issue: **
> Define a JSON structure to specify settings for auto start in a blueprint and 
> use that information to enable or disable auto start for components during 
> deployment.
> 
> ** Changes **
> Added a new section in the blueprint called "settings" which is a collection 
> of various setting names to collection of properties. For auto start, the 
> following setting names are used:
> *recovery_settings*: {"recovery_enabled" : "true" } specifies that auto start 
> should be enabled for all components. Can also be specified within a 
> collection, to support a uniform schema.
> *service_settings*: Collection of service names and the recovery values. 
> [{"name":"HDFS", "recovery_enabled":"false"},{...}] overrides cluster level 
> recovery settings.
> *component_settings*: Collection of component names and the corresponding 
> recovery values.  [{"name":"HDFS_CLIENT", "recovery_enabled":"true"},{...}]. 
> Overrides both service settings and recovery settings.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
>  8578d6beca91bf411d0c3dafeaee42d2dd23caea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPK.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  87225adc0afafc111b865120fd71742dc4e096f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> 11311dba0f1174248d24276a41837d7284e41607 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintFactory.java
>  cca28ca1529d6bccdf7a870dab7c317c1a334b1d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  bea036421c64b70b4bceffcbd0d13c26020a7ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Settings.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/SettingsFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  38a3614ae3543ae1de0ea0bfd4191951c6d5c5ff 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> f8c97ca11040bff414626189591d86d4781be478 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> b306c0ab7687c6fe05c818acefa2d063e5b111ed 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> 37744f8bc729e374a1db76f6509a6e85bffb37d0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> eba1745d8c7a3e1b677cb8b8fc33d9ae09d0cf68 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> cad0a39d824fdbf03b1ec6cd2a99dec79fa916d2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 346af50961fa1b2a41bd0a81121a08ec8ed70a2f 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
> e238a7665dff5a52426be9e334e4a48f53c7dbee 
>   ambari-server/src/main/resources/META-INF/persistence.xml 
> 513035f5baf6eacfcc69507069d311418546a09c 
>   ambari-server/src/main/resources/properties.json 
> 01c15f2b1c3564c37e8203ec70f2d2b812135b13 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintEntityTest.java
>  c660d19aee1727fd4734c07c0e5130f5bbe3c3cf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPKTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityTest.ja

Re: Review Request 45052: AMBARI-15478:Clearer manual step messages for Oozie and hive database backup and restore

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45052/#review125697
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 28, 2016, 1:28 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45052/
> ---
> 
> (Updated March 28, 2016, 1:28 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-15478
> https://issues.apache.org/jira/browse/AMBARI-15478
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Both oozie and hive can be configured to use database that run on a different 
> host than the oozie server/hive metastore server. The messages right now 
> indicate the databases are on the oozie server/hive metastore server node.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
>  ab1c053 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
>  430114b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  ab5b958 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  0f6a2f9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  74453e7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  5d1520b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 5fa0966 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  fe05d91 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4ad5d6d 
> 
> Diff: https://reviews.apache.org/r/45052/diff/
> 
> 
> Testing
> ---
> 
> patch cluster and run upgrades
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45338/#review125695
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
 (line 22)


Can we remove the import *?



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
 (line 68)


Same comment as below.



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
 (line 23)


Can we remove import *?



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
 (line 56)


The point of this function was to have a dictionary with the key being each 
possible stack name. If we always return "hadoop-client", might as well just 
return it as a string no matter what.


- Alejandro Fernandez


On March 28, 2016, 4:09 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45338/
> ---
> 
> (Updated March 28, 2016, 4:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15053
> https://issues.apache.org/jira/browse/AMBARI-15053
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Featurize HDP specific logic from YARN and MR service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  f766a82 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2f0e6bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
>  2966581 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
>  53b0e53 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  9fc1e32 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  fd14d0f 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  52f42b0 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  e51ca8a 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  83bf460 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  4110d39 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
>  d300279 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  97bd19c 
> 
> Diff: https://reviews.apache.org/r/45338/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [17.789s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.379s]
> [INFO] Ambari Web  SUCCESS [1:28.925s]
> [INFO] Ambari Views .. SUCCESS [7.096s]
> [INFO] Ambari Admin View . SUCCESS [18.829s]
> [INFO] ambari-metrics  SUCCESS [0.358s]
> [INFO] Ambari Metrics Common . SUCCESS [1.222s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [2.142s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.640s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.800s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [2.858s]
> [INFO] Ambari Metrics Collector .. SUCCESS [30.150s]
> [INFO] Ambari Metrics Monitor  SUCCESS [3.053s]
> [INFO] Ambari Metrics Grafana  SUCCESS [20.581s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [39.513s]
> [INFO] Ambari Server . SUCCESS [1:42.265s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.830s]
> [INFO] Ambari Agent .. SUCCESS [9.914s]
> [INFO] Ambari Client . SUCCESS [0.286s]
> [INF

Review Request 45395: Ambari API does not return HDFS RPC metrics based on ports

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45395/
---

Review request for Ambari and Sid Wagle.


Bugs: AMBARI-15606
https://issues.apache.org/jira/browse/AMBARI-15606


Repository: ambari


Description
---

ISSUE: Ambari API does not return HDFS RPC metrics based on ports (Example 8020 
and 8040)
When creating Ambari Widget we don't see an option to monitor by port. Hence 
the monitoring of Random port or aggregate doesn't give correct information

After the patch, ambari automatically replaces port number with the 
corresponding suffix
client for the port specified in hdfs-site/dfs.namenode.rpc-address
datanode for the port specified in hdfs-site/dfs.namenode.servicerpc-address
healthcheck  for the port specified in 
hdfs-site/dfs.namenode.lifeline.rpc-address

Request/response example

{
  "href" : 
"http://10.2.2.22:1081/api/v1/clusters/c1/services/HDFS/components/NAMENODE?fields=host_components/metrics/rpc/*,host_components/metrics/runtime/*";,
  "ServiceComponentInfo" : {
"cluster_name" : "c1",
"component_name" : "NAMENODE",
"service_name" : "HDFS"
  },
  "host_components" : [
{
  "href" : 
"http://10.2.2.22:1081/api/v1/clusters/c1/hosts/c6401.ambari.apache.org/host_components/NAMENODE";,
  "HostRoles" : {
"cluster_name" : "c1",
"component_name" : "NAMENODE",
"host_name" : "c6401.ambari.apache.org"
  },
  "metrics" : {
"rpc" : {
  "client" : {
"NumOpenConnections" : 0,
"ReceivedBytes" : 2508,
"RpcProcessingTime_avg_time" : 0.0,
"RpcProcessingTime_num_ops" : 12,
"RpcQueueTime_avg_time" : 0.0,
"RpcQueueTime_num_ops" : 12,
"SentBytes" : 408,
"callQueueLen" : 0,
"rpcAuthenticationFailures" : 0,
"rpcAuthenticationSuccesses" : 0,
"rpcAuthorizationFailures" : 0,
"rpcAuthorizationSuccesses" : 12
  },
  "datanode" : {
"NumOpenConnections" : 2,
"ReceivedBytes" : 3269926,
"RpcProcessingTime_avg_time" : 0.0,
"RpcProcessingTime_num_ops" : 6029,
"RpcQueueTime_avg_time" : 0.0,
"RpcQueueTime_num_ops" : 6029,
"SentBytes" : 248169,
"callQueueLen" : 0,
"rpcAuthenticationFailures" : 0,
"rpcAuthenticationSuccesses" : 0,
"rpcAuthorizationFailures" : 0,
"rpcAuthorizationSuccesses" : 288
  }
},
"runtime" : {
  "StartTime" : 1459170322047
}
  }
}
  ]
}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 4b15b80 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 7747753 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java
 15d44b2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
 b883d2b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java
 41da279 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 b0e2e7a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java
 35ba605 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/PropertyHelperTest.java
 2beb462 

Diff: https://reviews.apache.org/r/45395/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 45391: HAWQ - Add option to enable or disabling exchanging keys during HAWQ start.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45391/#review125690
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 (line 313)


can use default("/configuration/hdfs-site/dfs.allow.truncate", None)


- Alejandro Fernandez


On March 28, 2016, 5:42 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45391/
> ---
> 
> (Updated March 28, 2016, 5:42 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, and 
> Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-15595
> https://issues.apache.org/jira/browse/AMBARI-15595
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In HAWQ, SSH Keys are exchanged currently during every start of HAWQ Master. 
> This patch introduces a flag to enable / disable exchanging keys during start.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
>  fc5385f 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  d634fb2 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  7c3a832 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  9d8b32d 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
>  d3c9009 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 4dc3cc8 
>   ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json 99d43cb 
>   ambari-web/app/data/HDP2.3/site_properties.js e706d40 
> 
> Diff: https://reviews.apache.org/r/45391/diff/
> 
> 
> Testing
> ---
> 
> yes
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-28 
> 10:42:36,732 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys 
> is either set to false or is not available in hawq-env.xml
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> 
> --
> Ran 27 tests in 0.175s
> 
> OK
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Review Request 45391: HAWQ - Add option to enable or disabling exchanging keys during HAWQ start.

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45391/
---

Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, and 
Oleksandr Diachenko.


Bugs: AMBARI-15595
https://issues.apache.org/jira/browse/AMBARI-15595


Repository: ambari


Description
---

In HAWQ, SSH Keys are exchanged currently during every start of HAWQ Master. 
This patch introduces a flag to enable / disable exchanging keys during start.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
 fc5385f 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 d634fb2 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
 7c3a832 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 9d8b32d 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
 d3c9009 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 4dc3cc8 
  ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json 99d43cb 
  ambari-web/app/data/HDP2.3/site_properties.js e706d40 

Diff: https://reviews.apache.org/r/45391/diff/


Testing
---

yes
bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-28 10:42:36,732 
- Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to 
false or is not available in hawq-env.xml
ok
test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
test_install_default (test_hawqsegment.TestHawqSegment) ... ok
test_start_default (test_hawqsegment.TestHawqSegment) ... ok
test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
test_install_default (test_hawqstandby.TestHawqStandby) ... ok
test_start_default (test_hawqstandby.TestHawqStandby) ... ok
test_stop_default (test_hawqstandby.TestHawqStandby) ... ok

--
Ran 27 tests in 0.175s

OK


Thanks,

bhuvnesh chaudhary

Re: Review Request 45325: Add the Config, Start and Stop logic for: (1). Hive Server Interactive, and (2). Associate the LLAP lifecycle to it.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/#review125686
---


Ship it!




Ship It!

- Sumit Mohanty


On March 27, 2016, 11:14 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45325/
> ---
> 
> (Updated March 27, 2016, 11:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15573
> https://issues.apache.org/jira/browse/AMBARI-15573
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), 
> and (2). Associate the LLAP lifecycle to it.
> 
> - Start of HSI : Create LLAP package, start LLAP and then start HSI.
> - Stop: Stop HSI and then LLAP.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  f07b76f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  3532efc 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  8a4e7e6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  12cf336 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  6f05fbc 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  a6e4a47 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 
> 1e349a1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  face571 
> 
> Diff: https://reviews.apache.org/r/45325/diff/
> 
> 
> Testing
> ---
> 
> Yes.
>  - 2.6: Installation, config, Start and Stop of Hive Server Interactive after 
> Hive Server Batch -> Works.
>  - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> 
> Works
>  - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along 
> with Hive Server Batch -> Works.
>  - 2.5 : Negative testing :  Only Hive Batch gets installed. (Hive Server 
> Interactive not present).
>  - 
>  - Python UT : Passes.
>  - mvn clean test : ongoing. Will update.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 45390: Database Changes to Support Alert Repeat Tolerance

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45390/
---

Review request for Ambari, Nate Cole and Robert Nettleton.


Bugs: AMBARI-15602
https://issues.apache.org/jira/browse/AMBARI-15602


Repository: ambari


Description
---

The {{alert_definition}} table will be updated to include a nullable column 
which represents the custom repeat/retry tolerance value. This value will 
override that which is set in the {{cluster-env/alerts_repeat_tolerance}} 
property.

{code}
CREATE TABLE alert_definition (
  definition_id BIGINT NOT NULL,
  cluster_id BIGINT NOT NULL,
  ...
  repeat_tolerance SMALLINT,
  repeat_tolerance_enabled TINYINT,
  ...
  PRIMARY KEY (definition_id),
  FOREIGN KEY (cluster_id) REFERENCES clusters(cluster_id),
  CONSTRAINT uni_alert_def_name UNIQUE(cluster_id,definition_name)
);
{code}

The scope of work includes:
- SQL File changes
- Entity changes
- ResourceProvider changes to expose these values
- UpgradeCatalog changes
- Tests


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
 08a708f 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
 b08935c 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 38a3614 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f8c97ca 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b306c0a 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 37744f8 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql eba1745 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
cad0a39 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 346af50 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e238a76 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 7b2d797 

Diff: https://reviews.apache.org/r/45390/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Re: Review Request 45379: Introduce "Copy Path to clipboard" feature for Files browser view UI

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45379/#review125675
---




contrib/views/files/src/main/resources/ui/app/controllers/files.js (line 93)


We dont need a separate condition when length is 1.



contrib/views/files/src/main/resources/ui/app/controllers/files.js (line 97)


This can be written as:
```
multiplePaths = entities.map((entity) => {
return entity.get('path');
});

return multiplePaths.join(', ');
```


- DIPAYAN BHOWMICK


On March 28, 2016, 10:18 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45379/
> ---
> 
> (Updated March 28, 2016, 10:18 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Srimanth 
> Gunturi.
> 
> 
> Bugs: AMBARI-15598
> https://issues.apache.org/jira/browse/AMBARI-15598
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Introduce ember-cli-clipboard addon to the application and used the same 
> component to do the needful.
> 
> 
> Diffs
> -
> 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js 9fc11b6 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs 3e178bc 
>   contrib/views/files/src/main/resources/ui/package.json 8250489 
> 
> Diff: https://reviews.apache.org/r/45379/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45338/
---

(Updated March 28, 2016, 4:09 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Summary (updated)
-

AMBARI-15053: Stack Featurize YARN and MR services


Bugs: AMBARI-15053
https://issues.apache.org/jira/browse/AMBARI-15053


Repository: ambari


Description (updated)
---

Featurize HDP specific logic from YARN and MR service


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 f766a82 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 2f0e6bf 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
 2966581 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
 53b0e53 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
 9fc1e32 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
 fd14d0f 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 52f42b0 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 e51ca8a 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
 83bf460 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 4110d39 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
 d300279 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 97bd19c 

Diff: https://reviews.apache.org/r/45338/diff/


Testing (updated)
---

mvn clean test -DskipSurefireTests


[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [17.789s]
[INFO] Apache Ambari Project POM . SUCCESS [0.379s]
[INFO] Ambari Web  SUCCESS [1:28.925s]
[INFO] Ambari Views .. SUCCESS [7.096s]
[INFO] Ambari Admin View . SUCCESS [18.829s]
[INFO] ambari-metrics  SUCCESS [0.358s]
[INFO] Ambari Metrics Common . SUCCESS [1.222s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [2.142s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.640s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.800s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [2.858s]
[INFO] Ambari Metrics Collector .. SUCCESS [30.150s]
[INFO] Ambari Metrics Monitor  SUCCESS [3.053s]
[INFO] Ambari Metrics Grafana  SUCCESS [20.581s]
[INFO] Ambari Metrics Assembly ... SUCCESS [39.513s]
[INFO] Ambari Server . SUCCESS [1:42.265s]
[INFO] Ambari Functional Tests ... SUCCESS [2.830s]
[INFO] Ambari Agent .. SUCCESS [9.914s]
[INFO] Ambari Client . SUCCESS [0.286s]
[INFO] Ambari Python Client .. SUCCESS [1.151s]
[INFO] Ambari Groovy Client .. SUCCESS [17.175s]
[INFO] Ambari Shell .. SUCCESS [0.251s]
[INFO] Ambari Python Shell ... SUCCESS [0.157s]
[INFO] Ambari Groovy Shell ... SUCCESS [10.952s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:20.634s
[INFO] Finished at: Thu Mar 25 11:22:15 PDT 2016
[INFO] Final Memory: 112M/531M


Thanks,

Juanjo  Marron

Re: Review Request 45385: Make oozie tmp dir configurable

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45385/#review125649
---


Ship it!




Ship It!

- Andrew Onischuk


On March 28, 2016, 3:48 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45385/
> ---
> 
> (Updated March 28, 2016, 3:48 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15600
> https://issues.apache.org/jira/browse/AMBARI-15600
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Oozie tmp dir is hardcoded as of now. We should give ability for user to 
> change ethis property on UI and use this customized value in code.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
>  3cb2d60 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  61cbd8c 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json b8842c4 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_oozie_mysql.json 
> 898ed33 
>   ambari-server/src/test/python/stacks/2.0.6/configs/oozie_existing_sqla.json 
> 09e34f9 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json e053ca0 
> 
> Diff: https://reviews.apache.org/r/45385/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 45385: Make oozie tmp dir configurable

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45385/
---

Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-15600
https://issues.apache.org/jira/browse/AMBARI-15600


Repository: ambari


Description
---

Oozie tmp dir is hardcoded as of now. We should give ability for user to change 
ethis property on UI and use this customized value in code.


Diffs
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
 3cb2d60 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 61cbd8c 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json b8842c4 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_oozie_mysql.json 
898ed33 
  ambari-server/src/test/python/stacks/2.0.6/configs/oozie_existing_sqla.json 
09e34f9 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json e053ca0 

Diff: https://reviews.apache.org/r/45385/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 45052: AMBARI-15478:Clearer manual step messages for Oozie and hive database backup and restore

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45052/
---

Review request for Ambari and Alejandro Fernandez.


Summary (updated)
-

AMBARI-15478:Clearer manual step messages for Oozie and hive database backup 
and restore


Bugs: AMBARI-15478
https://issues.apache.org/jira/browse/AMBARI-15478


Repository: ambari


Description (updated)
---

Both oozie and hive can be configured to use database that run on a different 
host than the oozie server/hive metastore server. The messages right now 
indicate the databases are on the oozie server/hive metastore server node.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
 ab1c053 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
 430114b 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
 ab5b958 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
 0f6a2f9 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 74453e7 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 5d1520b 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
5fa0966 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 fe05d91 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
4ad5d6d 

Diff: https://reviews.apache.org/r/45052/diff/


Testing (updated)
---

patch cluster and run upgrades


Thanks,

Di Li

Re: Review Request 45302: Use repository version number to indicate repository to use when installing

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45302/#review125630
---


Ship it!




Ship It!

- Jonathan Hurley


On March 27, 2016, 9:03 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45302/
> ---
> 
> (Updated March 27, 2016, 9:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15564
> https://issues.apache.org/jira/browse/AMBARI-15564
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a way to supply the repo_version to use when creating a cluster.  This 
> will result in a new cluster_version record BEFORE any hosts have been added 
> to the cluster.  This work effectively unblocks the UI to be able to supply a 
> version when creating the cluster.  Including Blueprints.
> 
> What this patch does NOT do (other patches will address this):
> - Refactor how RepositoryVersionState is computed for installs to work just 
> like upgrades.
> - Create a cluster using a Version Definition File (VDF) url, pull down the 
> file, and create the repo_version record.  To use this feature, the 
> repo_version must be created BEFORE supplying the version with the cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  32da5e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  23d43aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java
>  5c7548c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  f7d359c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  a1740fb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java
>  cc8cfdb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> ddd07f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java
>  119205a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  8d6fec1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  87225ad 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  c317162 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  ec38f22 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
>  57cbebc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java
>  1613d11 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  6e7c975 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  91f4993 
> 
> Diff: https://reviews.apache.org/r/45302/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 3992, Failures: 0, Errors: 0, Skipped: 33
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:21.378s
> [INFO] Finished at: Thu Mar 24 15:59:06 EDT 2016
> [INFO] Final Memory: 33M/610M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 45302: Use repository version number to indicate repository to use when installing

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45302/#review125623
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On March 27, 2016, 4:03 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45302/
> ---
> 
> (Updated March 27, 2016, 4:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15564
> https://issues.apache.org/jira/browse/AMBARI-15564
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a way to supply the repo_version to use when creating a cluster.  This 
> will result in a new cluster_version record BEFORE any hosts have been added 
> to the cluster.  This work effectively unblocks the UI to be able to supply a 
> version when creating the cluster.  Including Blueprints.
> 
> What this patch does NOT do (other patches will address this):
> - Refactor how RepositoryVersionState is computed for installs to work just 
> like upgrades.
> - Create a cluster using a Version Definition File (VDF) url, pull down the 
> file, and create the repo_version record.  To use this feature, the 
> repo_version must be created BEFORE supplying the version with the cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  32da5e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  23d43aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java
>  5c7548c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  f7d359c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  a1740fb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java
>  cc8cfdb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> ddd07f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java
>  119205a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  8d6fec1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  87225ad 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  c317162 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  ec38f22 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
>  57cbebc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java
>  1613d11 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  6e7c975 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  91f4993 
> 
> Diff: https://reviews.apache.org/r/45302/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 3992, Failures: 0, Errors: 0, Skipped: 33
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:21.378s
> [INFO] Finished at: Thu Mar 24 15:59:06 EDT 2016
> [INFO] Final Memory: 33M/610M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 45379: Introduce "Copy Path to clipboard" feature for Files browser view UI

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45379/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Srimanth Gunturi.


Bugs: AMBARI-15598
https://issues.apache.org/jira/browse/AMBARI-15598


Repository: ambari


Description
---

Introduce ember-cli-clipboard addon to the application and used the same 
component to do the needful.


Diffs
-

  contrib/views/files/src/main/resources/ui/app/controllers/files.js 9fc11b6 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs 3e178bc 
  contrib/views/files/src/main/resources/ui/package.json 8250489 

Diff: https://reviews.apache.org/r/45379/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 45378: After enabling SSL for Resource Manager, getting a constant Ambari Alert: Connection failed to https://0.0.0.0:8044/ws/v1/node/info (No JSON object could be decoded)

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45378/#review125620
---


Ship it!




Ship It!

- Andrew Onischuk


On March 28, 2016, 10:02 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45378/
> ---
> 
> (Updated March 28, 2016, 10:02 a.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-15597
> https://issues.apache.org/jira/browse/AMBARI-15597
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled SSL for ResourceManager HA.
> The following parameter changed in yarn-site.xml
> 
> yarn.nodemanager.webapp.https.address
> 0.0.0.0:8044
> 
> After implementing SSL, they started getting the following Ambari Alert from 
> all the nodes.
> 
> Connection failed to https://0.0.0.0:8044/ws/v1/node/info (No JSON object 
> could be decoded)
> 
> We tested the Python socket.getfqdn() inside the alert_nodemanager_health.py 
> and it worked correctly.
> 
> print socket.getfqdn("0.0.0.0")
> 
> CAUSE:
> We think that Kerberos looks for the yarn.nodemanager.webapp.https.address 
> hostname in yarn-site.xml and because it sees “0.0.0.0” instead of the 
> hostname, it can’t get the keytabs of the host.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanager_health.py
>  2105bed 
> 
> Diff: https://reviews.apache.org/r/45378/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 45284: Ambari LDAP integration cannot handle LDAP directories with multiple entries for the same user

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45284/#review125619
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On March 27, 2016, 8:42 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45284/
> ---
> 
> (Updated March 27, 2016, 8:42 p.m.)
> 
> 
> Review request for Ambari, Andriy Babiichuk, Andrii Tkach, Dmitro 
> Lisnichenko, Myroslav Papirkovskyy, Oliver Szabo, Robert Levas, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-15554
> https://issues.apache.org/jira/browse/AMBARI-15554
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> In case LDAP set up with multiple Domains which are joined into a Forrest 
> with trusts between the different Domains users may appear in different 
> locations in LDAP.
> Since users who wants to access Ambari can be in any domain Ambari has to 
> search the whole forrest, and as the users appearing in multiple domains are 
> identical Ambari cannot filter out all but one of the user entries.
> 
> Solution:
> 1.If the LDAP search upon login to Ambari leads to multiple match user match 
> due to the user appears in multiple domains show an error message to user 
> prompting for providing domain as well to log-in. (e.g. Login Failed: Please 
> append your domain to your username and try again. Example: username@domain)
> 
> 2. When user provides domain information at login as well Ambari looks up the 
> user in LDAP using different filter which is configurable. If this 
> configuration is not set Ambari defaults to filter by userPrincipalName
> 
> 3. A map of login name (login alias) to ambari user name is stored in the 
> session so as later whenever is needed the login name can be resolved to 
> ambari user name (user name stored in ambari database).
> 
> 4. User related rest API calls includes user name in the URL. There is a 
> filter set up for these resolve the user name in the URL to ambari user name 
> if needed.
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/log4j.properties 2ee32d4 
>   ambari-server/pom.xml 1e44517 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/UserNameOverrideFilter.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  bf18325 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  076f850 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  20cf2fd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthoritiesPopulator.java
>  fc7f73a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java
>  ed68c01 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapUtils.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java
>  0c675b8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/DuplicateLdapUserFoundAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java
>  8eeaf35 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 3bbc785 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/UserNameOverrideFilterTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  3ecb5aa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/AmbariLdapUtilsTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthenticationTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
>  d48be85 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticatorTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
>  ada5ff5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/LdapServerPropertiesTest.java
>  0797239 
>   
> ambari-server/src/test/java/org/apache/ambari/

Review Request 45378: After enabling SSL for Resource Manager, getting a constant Ambari Alert: Connection failed to https://0.0.0.0:8044/ws/v1/node/info (No JSON object could be decoded)

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45378/
---

Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-15597
https://issues.apache.org/jira/browse/AMBARI-15597


Repository: ambari


Description
---

Enabled SSL for ResourceManager HA.
The following parameter changed in yarn-site.xml

yarn.nodemanager.webapp.https.address
0.0.0.0:8044

After implementing SSL, they started getting the following Ambari Alert from 
all the nodes.

Connection failed to https://0.0.0.0:8044/ws/v1/node/info (No JSON object could 
be decoded)

We tested the Python socket.getfqdn() inside the alert_nodemanager_health.py 
and it worked correctly.

print socket.getfqdn("0.0.0.0")

CAUSE:
We think that Kerberos looks for the yarn.nodemanager.webapp.https.address 
hostname in yarn-site.xml and because it sees “0.0.0.0” instead of the 
hostname, it can’t get the keytabs of the host.


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanager_health.py
 2105bed 

Diff: https://reviews.apache.org/r/45378/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 45284: Ambari LDAP integration cannot handle LDAP directories with multiple entries for the same user

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45284/#review125610
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Березень 27, 2016, 8:42 після полудня, Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45284/
> ---
> 
> (Updated Березень 27, 2016, 8:42 після полудня)
> 
> 
> Review request for Ambari, Andriy Babiichuk, Andrii Tkach, Dmitro 
> Lisnichenko, Myroslav Papirkovskyy, Oliver Szabo, Robert Levas, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-15554
> https://issues.apache.org/jira/browse/AMBARI-15554
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> In case LDAP set up with multiple Domains which are joined into a Forrest 
> with trusts between the different Domains users may appear in different 
> locations in LDAP.
> Since users who wants to access Ambari can be in any domain Ambari has to 
> search the whole forrest, and as the users appearing in multiple domains are 
> identical Ambari cannot filter out all but one of the user entries.
> 
> Solution:
> 1.If the LDAP search upon login to Ambari leads to multiple match user match 
> due to the user appears in multiple domains show an error message to user 
> prompting for providing domain as well to log-in. (e.g. Login Failed: Please 
> append your domain to your username and try again. Example: username@domain)
> 
> 2. When user provides domain information at login as well Ambari looks up the 
> user in LDAP using different filter which is configurable. If this 
> configuration is not set Ambari defaults to filter by userPrincipalName
> 
> 3. A map of login name (login alias) to ambari user name is stored in the 
> session so as later whenever is needed the login name can be resolved to 
> ambari user name (user name stored in ambari database).
> 
> 4. User related rest API calls includes user name in the URL. There is a 
> filter set up for these resolve the user name in the URL to ambari user name 
> if needed.
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/log4j.properties 2ee32d4 
>   ambari-server/pom.xml 1e44517 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/UserNameOverrideFilter.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  bf18325 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  076f850 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  20cf2fd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthoritiesPopulator.java
>  fc7f73a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java
>  ed68c01 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapUtils.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java
>  0c675b8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/DuplicateLdapUserFoundAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java
>  8eeaf35 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 3bbc785 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/UserNameOverrideFilterTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  3ecb5aa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/AmbariLdapUtilsTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthenticationTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
>  d48be85 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticatorTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
>  ada5ff5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/LdapServerPropertiesTest.java
>  0797239 
>   
> ambari-server/src/t