[kudu-CR] [compaction] support turn on/off FLAGS enable maintenance manager at runtime

2023-01-15 Thread Yuqi Du (Code Review) 
Yuqi Du has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19398 )

Change subject: [compaction] support turn on/off 
FLAGS_enable_maintenance_manager at runtime
..


Patch Set 2: Code-Review+1

> Patch Set 2: Verified+1 Code-Review+1
>
> LGTM, but I'm curious what's use case of it, this flag seems only useful in 
> tests.

Yes. You are right.

I also think that this patch is not important, the scenarios of using it may be 
rare, only some special scenarios should change the flag for administrators.

But the purpose of provided the this flag, it should support change it.
So I decide to submit this patch.


--
To view, visit http://gerrit.cloudera.org:8080/19398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f7029b22a4c8ce58094501e71a6c22271d4f0b2
Gerrit-Change-Number: 19398
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Ashwani Raina 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Mon, 16 Jan 2023 07:28:35 +
Gerrit-HasComments: No

[kudu-CR] [tools] add --tables flag to 'local replica delete'

2023-01-15 Thread Yifan Zhang (Code Review) 
Hello Alexey Serbin, Ashwani Raina, Yingchun Lai, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19411

to look at the new patch set (#5).

Change subject: [tools] add --tables flag to 'local_replica delete'
..

[tools] add --tables flag to 'local_replica delete'

This patch updates the 'local_replica delete' tool to allow deletion
multiple tablets by table name. Sometimes it is not convenient for
users to specify multiple tablet ids, but table names will be much
easier to get.

In order to support delete all tablets of specified tables, the
 argument is updated to  which
support basic glob syntax. As a result, now we can not tell users
whether there is an illegal tablet id pattern well and truly, unless
all the specified tablet id patterns are tablet ids.

The default value of --tables flag is empty, which means all tables
will be included, so the tool can achieve same effect as before if
this flag is not specified.

A new test is added to verify the new functionality.

Change-Id: I2d862a715f05179b2e8def0d1cdfe58c32299329
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
2 files changed, 102 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/19411/5
--
To view, visit http://gerrit.cloudera.org:8080/19411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d862a715f05179b2e8def0d1cdfe58c32299329
Gerrit-Change-Number: 19411
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Ashwani Raina 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai

[kudu-CR] [tools] add --tables flag to 'local replica delete'

2023-01-15 Thread Yifan Zhang (Code Review) 
Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19411 )

Change subject: [tools] add --tables flag to 'local_replica delete'
..


Patch Set 4:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/19411/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19411/3//COMMIT_MSG@9
PS3, Line 9: allow deletion
   : multiple tablets by table
> nit: allow deletion of multiple tablets
Done


http://gerrit.cloudera.org:8080/#/c/19411/3//COMMIT_MSG@11
PS3, Line 11: y multipl
> nit: users
Done


http://gerrit.cloudera.org:8080/#/c/19411/3/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/19411/3/src/kudu/tools/kudu-tool-test.cc@4208
PS3, Line 4208: specified tablet id does not exist");
> If tabletid is specified and should work just like a pattern, it would make
Done


http://gerrit.cloudera.org:8080/#/c/19411/3/src/kudu/tools/kudu-tool-test.cc@4329
PS3, Line 4329: ASSERT_EQ(kDefaultTableName, 
tablet_replicas[0]->tablet()->metadata()->table_name());
> nit: Also check the left replica's table name is not kTableName?
Done


http://gerrit.cloudera.org:8080/#/c/19411/3/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:

http://gerrit.cloudera.org:8080/#/c/19411/3/src/kudu/tools/tool_action_local_replica.cc@801
PS3, Line 801:   if (tablet_ids_str.find('*') == string::npos && uniq_count > 
tablets_to_delete.size()) {
> Because the input is pattern now, one pattern may match multiple tablet ids
Yes. So with this change, we can only identify wrong tablet ids but not wrong 
tablet id patterns.


http://gerrit.cloudera.org:8080/#/c/19411/3/src/kudu/tools/tool_action_local_replica.cc@1392
PS3, Line 1392: AddOptionalParameter("tables")
> I am not sure if I get this. Where are we storing table name from user in c
It is stored in gflag value.



--
To view, visit http://gerrit.cloudera.org:8080/19411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d862a715f05179b2e8def0d1cdfe58c32299329
Gerrit-Change-Number: 19411
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Ashwani Raina 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Comment-Date: Mon, 16 Jan 2023 07:07:33 +
Gerrit-HasComments: Yes

[kudu-CR] [tools] add --tables flag to 'local replica delete'

2023-01-15 Thread Yifan Zhang (Code Review) 
Hello Alexey Serbin, Ashwani Raina, Yingchun Lai, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19411

to look at the new patch set (#4).

Change subject: [tools] add --tables flag to 'local_replica delete'
..

[tools] add --tables flag to 'local_replica delete'

This patch updates the 'local_replica delete' tool to allow deletion
multiple tablets by table name. Sometimes it is not convenient for
users to specify multiple tablet ids, but table names will be much
easier to get.

In order to support delete all tablets of specified tables, the
 argument is updated to  which
support basic glob syntax. As a result, now we can not tell users
whether there is an illegal tablet id pattern well and truly, unless
all the specified tablet id patterns are tablet ids.

The default value of --tables flag is empty, which means all tables
will be included, so the tool can achieve same effect as before if
this flag is not specified.

A new test was added to verify the new functionality.

Change-Id: I2d862a715f05179b2e8def0d1cdfe58c32299329
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
2 files changed, 102 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/19411/4
--
To view, visit http://gerrit.cloudera.org:8080/19411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d862a715f05179b2e8def0d1cdfe58c32299329
Gerrit-Change-Number: 19411
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Ashwani Raina 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai

[kudu-CR] [tools] Return immediately after the limit number of rows have been dumped

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19369 )

Change subject: [tools] Return immediately after the limit number of rows have 
been dumped
..


Patch Set 6: Code-Review+1

(6 comments)

A few nits left to fix, otherwise looks good to me.

http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tablet/rowset.h
File src/kudu/tablet/rowset.h:

http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tablet/rowset.h@180
PS6, Line 180:  // If 'rows_left' is nullptr, there is no limit on the number 
of rows to dump.
 :   // If the content of 'rows_left' equal to or less than 0, no 
rows will be dumped.
It seems this part is not relevant for this function anymore.

Probably, the whole doc for this function now needs to be moved to line 313?  
And this comment updated, removing this irrelevant part?


http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tablet/rowset.cc
File src/kudu/tablet/rowset.cc:

http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tablet/rowset.cc@53
PS6, Line 53:
style nit: the indent here should be 2 spaces, not 4


http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:

http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc@1037
PS6, Line 1037: No matter if there are any rows to be printed, the metadata 
will be printed.
When the --dump_metadata flag is set to 'true', the metadata is always printed 
regardless of the number of rows to print.


http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc@1091
PS6, Line 1091: It's not needed to read the next block when reach rows limit
How about:

  There is no need to read the next block when the row limit has been reached.


http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc@1097
PS6, Line 1097: larger
nit: greater


http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc@1097
PS6, Line 1097: will always been
  :   // printed in pairs.
... are always printed in pairs



--
To view, visit http://gerrit.cloudera.org:8080/19369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia758ba910fccbbc06ac6c59a795574fb86d4e279
Gerrit-Change-Number: 19369
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Ashwani Raina 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Mon, 16 Jan 2023 07:04:27 +
Gerrit-HasComments: Yes

[kudu-CR] [codegen] update CodegenTest.TestDumpMC for ppc64le

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19015 )

Change subject: [codegen] update CodegenTest.TestDumpMC for ppc64le
..

[codegen] update CodegenTest.TestDumpMC for ppc64le

The equivalent of x86_64's "retq" assembler instruction on ppc64le
is "blr".

Change-Id: I81933185665a131200ea8ac4e0cc323e6226a355
Reviewed-on: http://gerrit.cloudera.org:8080/19015
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
---
M src/kudu/codegen/codegen-test.cc
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/19015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I81933185665a131200ea8ac4e0cc323e6226a355
Gerrit-Change-Number: 19015
Gerrit-PatchSet: 3
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [codegen] update CodegenTest.TestDumpMC for ppc64le

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19015 )

Change subject: [codegen] update CodegenTest.TestDumpMC for ppc64le
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81933185665a131200ea8ac4e0cc323e6226a355
Gerrit-Change-Number: 19015
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Jan 2023 06:15:45 +
Gerrit-HasComments: No

[kudu-CR] Adds ppc64le to architectures which do not support avx2

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19014 )

Change subject: Adds ppc64le to architectures which do not support avx2
..

Adds ppc64le to architectures which do not support avx2

__powerpc64__  preprocessor flag is added to the list of architectures
in the #if statement which skips avx2 based code generation for
architectures which do not this feature.

 Changes to be committed:
modified:   src/kudu/cfile/bitshuffle_arch_wrapper.cc#

Change-Id: I3477193cb966402099a8ce9a7f98702c3107d1e6
Reviewed-on: http://gerrit.cloudera.org:8080/19014
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
---
M src/kudu/cfile/bitshuffle_arch_wrapper.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/19014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3477193cb966402099a8ce9a7f98702c3107d1e6
Gerrit-Change-Number: 19014
Gerrit-PatchSet: 3
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Adds ppc64le to architectures which do not support avx2

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19014 )

Change subject: Adds ppc64le to architectures which do not support avx2
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3477193cb966402099a8ce9a7f98702c3107d1e6
Gerrit-Change-Number: 19014
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Jan 2023 06:14:40 +
Gerrit-HasComments: No

[kudu-CR] [tools] Return immediately after the limit number of rows have been dumped

2023-01-15 Thread Wang Xixu (Code Review) 
Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19369 )

Change subject: [tools] Return immediately after the limit number of rows have 
been dumped
..


Patch Set 6: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/19369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia758ba910fccbbc06ac6c59a795574fb86d4e279
Gerrit-Change-Number: 19369
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Ashwani Raina 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Mon, 16 Jan 2023 06:07:22 +
Gerrit-HasComments: No

[kudu-CR] [KUDU-3430] Implement getting flags filter logic in tool side

2023-01-15 Thread Yingchun Lai (Code Review) 
Yingchun Lai has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19393 )

Change subject: [KUDU-3430] Implement getting flags filter logic in tool side
..

[KUDU-3430] Implement getting flags filter logic in tool side

When using new version of Kudu tool (version: 1.16.0) to
execute command: "kudu tserver get_flags localhost:7050
-flags=block_cache_capacity_mb" on the old version of Kudu
TServer (version: 1.10.1)，it returned all flags not the
specified flags.

That because the filter logic was not implemented on the
server side (Kudu version 1.10.1).

So it is better to implement the filter logic on the Kudu
tool side also.

Change-Id: I0a2ddc2540d7aa70d3dd2e6c4101bb227e94c858
Reviewed-on: http://gerrit.cloudera.org:8080/19393
Reviewed-by: Yingchun Lai 
Tested-by: Yingchun Lai 
---
M src/kudu/server/generic_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
3 files changed, 57 insertions(+), 15 deletions(-)

Approvals:
  Yingchun Lai: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/19393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a2ddc2540d7aa70d3dd2e6c4101bb227e94c858
Gerrit-Change-Number: 19393
Gerrit-PatchSet: 12
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yingchun Lai

[kudu-CR] Adds opname test for ‘BLR” for ppc64le architecture

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has abandoned this change. ( 
http://gerrit.cloudera.org:8080/19017 )

Change subject: Adds opname test for ‘BLR” for ppc64le architecture
..


Abandoned

this is a duplicate https://gerrit.cloudera.org/#/c/19016/
--
To view, visit http://gerrit.cloudera.org:8080/19017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I6dcd657967250c907e2088030018c91099b5507e
Gerrit-Change-Number: 19017
Gerrit-PatchSet: 1
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [codegen] update CodegenTest.TestDumpMC for ppc64le

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has uploaded a new patch set (#2) to the change originally 
created by harinreddy. ( http://gerrit.cloudera.org:8080/19015 )

Change subject: [codegen] update CodegenTest.TestDumpMC for ppc64le
..

[codegen] update CodegenTest.TestDumpMC for ppc64le

The equivalent of x86_64's "retq" assembler instruction on ppc64le
is "blr".

Change-Id: I81933185665a131200ea8ac4e0cc323e6226a355
---
M src/kudu/codegen/codegen-test.cc
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/19015/2
--
To view, visit http://gerrit.cloudera.org:8080/19015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81933185665a131200ea8ac4e0cc323e6226a355
Gerrit-Change-Number: 19015
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Adds powerpc architecture so that build completes

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19018 )

Change subject: Adds powerpc architecture so that build completes
..

Adds powerpc architecture so that build completes

  has_popcnt_ = 1;
  has_mmx_ = 1;
  has_sse_ = 1;
  has_sse2_ = 1;
  has_sse3_ = 1;
  has_ssse3_ = 1;
  has_sse41_ = 1;
  has_sse42_ = 1;

 Changes to be committed:
modified:   src/kudu/gutil/cpu.cc

Change-Id: I6f2e086d3dedbdf2f6e30080645f49344c2d635f
Reviewed-on: http://gerrit.cloudera.org:8080/19018
Tested-by: Alexey Serbin 
Reviewed-by: Alexey Serbin 
---
M src/kudu/gutil/cpu.cc
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/19018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f2e086d3dedbdf2f6e30080645f49344c2d635f
Gerrit-Change-Number: 19018
Gerrit-PatchSet: 3
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Adds powerpc architecture so that build completes

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19018 )

Change subject: Adds powerpc architecture so that build completes
..


Patch Set 2: Verified+1

unrelated test failure in TabletServerTest.TestTimeBasedFlushDMS


--
To view, visit http://gerrit.cloudera.org:8080/19018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f2e086d3dedbdf2f6e30080645f49344c2d635f
Gerrit-Change-Number: 19018
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Jan 2023 04:10:52 +
Gerrit-HasComments: No

[kudu-CR] Adds powerpc architecture so that build completes

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has removed a vote on this change.

Change subject: Adds powerpc architecture so that build completes
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6f2e086d3dedbdf2f6e30080645f49344c2d635f
Gerrit-Change-Number: 19018
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Adds powerpc architecture so that build completes

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19018 )

Change subject: Adds powerpc architecture so that build completes
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f2e086d3dedbdf2f6e30080645f49344c2d635f
Gerrit-Change-Number: 19018
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Jan 2023 04:10:59 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1945: Support non unique primary key for Java client

2023-01-15 Thread Wenzhe Zhou (Code Review) 
Wenzhe Zhou has uploaded a new patch set (#18). ( 
http://gerrit.cloudera.org:8080/19384 )

Change subject: KUDU-1945: Support non unique primary key for Java client
..

KUDU-1945: Support non unique primary key for Java client

This patch adds new APIs to create ColumnSchema with non unique
primary key for Java client. When a table with non unique primary
key is created, Auto-Incrementing Column "auto_increment_id" will
be added automatically to the table as the key column. The non-unique
key columns and the auto-incrementing column together form the
effective primary key.

UPSERT/UPSERT_IGNORE operations are not supported now for Kudu table
with auto-incrementing column due to limitation in Kudu server.

Auto-Incrementing column cannot be added, removed or renamed with
Alter Table APIs.

Testing:
 - Added unit-test for Java client library.
 - Manually ran integration test with Impala for creating table
   with non unique primary key, and ran queries for operations:
   describe/insert/update/delete/upsert/CTAS/select/alter, etc.
   Passed Kudu related end-end tests.

Change-Id: I7e2501d6b3d66f6466959e4f3f1ed0f5e08dfe5c
---
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
11 files changed, 586 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/19384/18
--
To view, visit http://gerrit.cloudera.org:8080/19384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e2501d6b3d66f6466959e4f3f1ed0f5e08dfe5c
Gerrit-Change-Number: 19384
Gerrit-PatchSet: 18
Gerrit-Owner: Wenzhe Zhou 
Gerrit-Reviewer: Abhishek Chennaka 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler 
Gerrit-Reviewer: Marton Greber 
Gerrit-Reviewer: Wenzhe Zhou

[kudu-CR] Adds architecture: PowerPC to LLVM TARGETS TO BUILD

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19013 )

Change subject: Adds architecture: PowerPC to LLVM_TARGETS_TO_BUILD
..

Adds architecture: PowerPC to LLVM_TARGETS_TO_BUILD

This patch includes  “PowerPC” in the llvm targets to be built
in the thirdparty directory.

LLVM_TARGETS_TO_BUILD="X86;AArch64;PowerPC"

modified:   thirdparty/build-definitions.sh

Change-Id: Id3979189cd4202257820db11888d8d78a05beb21
Reviewed-on: http://gerrit.cloudera.org:8080/19013
Tested-by: Alexey Serbin 
Reviewed-by: Alexey Serbin 
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/19013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3979189cd4202257820db11888d8d78a05beb21
Gerrit-Change-Number: 19013
Gerrit-PatchSet: 3
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Adds architecture: PowerPC to LLVM TARGETS TO BUILD

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19013 )

Change subject: Adds architecture: PowerPC to LLVM_TARGETS_TO_BUILD
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3979189cd4202257820db11888d8d78a05beb21
Gerrit-Change-Number: 19013
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 15 Jan 2023 20:22:40 +
Gerrit-HasComments: No

[kudu-CR] Adds architecture: PowerPC to LLVM TARGETS TO BUILD

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has removed a vote on this change.

Change subject: Adds architecture: PowerPC to LLVM_TARGETS_TO_BUILD
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id3979189cd4202257820db11888d8d78a05beb21
Gerrit-Change-Number: 19013
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Adds architecture: PowerPC to LLVM TARGETS TO BUILD

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19013 )

Change subject: Adds architecture: PowerPC to LLVM_TARGETS_TO_BUILD
..


Patch Set 2: Verified+1

unrelated test failures the newly introduced 
ClientTestAutoIncrementingColumn.ConcurrentWrites (TSAN)


--
To view, visit http://gerrit.cloudera.org:8080/19013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3979189cd4202257820db11888d8d78a05beb21
Gerrit-Change-Number: 19013
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 15 Jan 2023 20:22:33 +
Gerrit-HasComments: No

[kudu-CR] [codegen] use "BLR" instead of "RET" for ppc64le

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19016 )

Change subject: [codegen] use "BLR" instead of "RET" for ppc64le
..

[codegen] use "BLR" instead of "RET" for ppc64le

ppc64le does not have the assembler instruction "RET".
This patch updates the codegen to handle the "BLR" instruction
(Branch to Link Register) for ppc64 which is equivalent to "RET"
in x86_64.

Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Reviewed-on: http://gerrit.cloudera.org:8080/19016
Tested-by: Alexey Serbin 
Reviewed-by: Alexey Serbin 
---
M src/kudu/codegen/code_generator.cc
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/19016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Gerrit-Change-Number: 19016
Gerrit-PatchSet: 5
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [codegen] use "BLR" instead of "RET" for ppc64le

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19016 )

Change subject: [codegen] use "BLR" instead of "RET" for ppc64le
..


Patch Set 4: Verified+1

unrelated test failure in EnableKudu1097AndDownTS/MoveTabletParamTest.Test/5 
(ASAN)


--
To view, visit http://gerrit.cloudera.org:8080/19016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Gerrit-Change-Number: 19016
Gerrit-PatchSet: 4
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 15 Jan 2023 17:50:16 +
Gerrit-HasComments: No

[kudu-CR] [codegen] use "BLR" instead of "RET" for ppc64le

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19016 )

Change subject: [codegen] use "BLR" instead of "RET" for ppc64le
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Gerrit-Change-Number: 19016
Gerrit-PatchSet: 4
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 15 Jan 2023 17:50:23 +
Gerrit-HasComments: No

[kudu-CR] [codegen] use "BLR" instead of "RET" for ppc64le

2023-01-15 Thread Alexey Serbin (Code Review) 
Alexey Serbin has removed a vote on this change.

Change subject: [codegen] use "BLR" instead of "RET" for ppc64le
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Gerrit-Change-Number: 19016
Gerrit-PatchSet: 4
Gerrit-Owner: harinreddy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [compaction] support turn on/off FLAGS enable maintenance manager at runtime

2023-01-15 Thread Yingchun Lai (Code Review) 
Yingchun Lai has removed a vote on this change.

Change subject: [compaction] support turn on/off 
FLAGS_enable_maintenance_manager at runtime
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7f7029b22a4c8ce58094501e71a6c22271d4f0b2
Gerrit-Change-Number: 19398
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Ashwani Raina 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du

[kudu-CR] [compaction] support turn on/off FLAGS enable maintenance manager at runtime

2023-01-15 Thread Yingchun Lai (Code Review) 
Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19398 )

Change subject: [compaction] support turn on/off 
FLAGS_enable_maintenance_manager at runtime
..


Patch Set 2: Verified+1 Code-Review+1

LGTM, but I'm curious what's use case of it, this flag seems only useful in 
tests.


--
To view, visit http://gerrit.cloudera.org:8080/19398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f7029b22a4c8ce58094501e71a6c22271d4f0b2
Gerrit-Change-Number: 19398
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Ashwani Raina 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang 
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Reviewer: Yuqi Du 
Gerrit-Comment-Date: Sun, 15 Jan 2023 14:38:23 +
Gerrit-HasComments: No

[kudu-CR] [KUDU-3430] Implement getting flags filter logic in tool side

2023-01-15 Thread Yingchun Lai (Code Review) 
Yingchun Lai has removed a vote on this change.

Change subject: [KUDU-3430] Implement getting flags filter logic in tool side
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0a2ddc2540d7aa70d3dd2e6c4101bb227e94c858
Gerrit-Change-Number: 19393
Gerrit-PatchSet: 11
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yingchun Lai

[kudu-CR] [KUDU-3430] Implement getting flags filter logic in tool side

2023-01-15 Thread Yingchun Lai (Code Review) 
Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19393 )

Change subject: [KUDU-3430] Implement getting flags filter logic in tool side
..


Patch Set 11: Verified+1 Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2ddc2540d7aa70d3dd2e6c4101bb227e94c858
Gerrit-Change-Number: 19393
Gerrit-PatchSet: 11
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Comment-Date: Sun, 15 Jan 2023 14:32:51 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1945: Support non unique primary key for Java client

2023-01-15 Thread Wenzhe Zhou (Code Review) 
Wenzhe Zhou has uploaded a new patch set (#17). ( 
http://gerrit.cloudera.org:8080/19384 )

Change subject: KUDU-1945: Support non unique primary key for Java client
..

KUDU-1945: Support non unique primary key for Java client

This patch adds new APIs to create ColumnSchema with non unique
primary key for Java client. When a table with non unique primary
key is created, Auto-Incrementing Column "auto_increment_id" will
be added automatically to the table as the key column. The non-unique
key columns and the auto-incrementing column together form the
effective primary key.

UPSERT/UPSERT_IGNORE operations are not supported now for Kudu table
with auto-incrementing column due to limitation in Kudu server.

Auto-Incrementing column cannot be added, removed or renamed with
Alter Table APIs.

Testing:
 - Added unit-test for Java client library.
 - Manually ran integration test with Impala for creating table
   with non unique primary key, and ran queries for operations:
   describe/insert/update/delete/upsert/CTAS/select/alter, etc.
   Passed Kudu related end-end tests.

Change-Id: I7e2501d6b3d66f6466959e4f3f1ed0f5e08dfe5c
---
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
11 files changed, 580 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/19384/17
--
To view, visit http://gerrit.cloudera.org:8080/19384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e2501d6b3d66f6466959e4f3f1ed0f5e08dfe5c
Gerrit-Change-Number: 19384
Gerrit-PatchSet: 17
Gerrit-Owner: Wenzhe Zhou 
Gerrit-Reviewer: Abhishek Chennaka 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler 
Gerrit-Reviewer: Marton Greber 
Gerrit-Reviewer: Wenzhe Zhou