Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

2017-12-05 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64144/#review192890
---


Ship it!




Ship It!

- Jie Yu


On Dec. 5, 2017, 7:06 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64144/
> ---
> 
> (Updated Dec. 5, 2017, 7:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan 
> Schlicht.
> 
> 
> Bugs: MESOS-8193
> https://issues.apache.org/jira/browse/MESOS-8193
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a framework does not request feedback about an operation,
> the master should acknowledge offer operation status updates
> to the agent so that the updates are not retried.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4 
> 
> 
> Diff: https://reviews.apache.org/r/64144/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

2017-12-04 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64144/
---

(Updated Dec. 5, 2017, 7:06 a.m.)


Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan 
Schlicht.


Bugs: MESOS-8193
https://issues.apache.org/jira/browse/MESOS-8193


Repository: mesos


Description
---

When a framework does not request feedback about an operation,
the master should acknowledge offer operation status updates
to the agent so that the updates are not retried.


Diffs (updated)
-

  src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4 


Diff: https://reviews.apache.org/r/64144/diff/3/

Changes: https://reviews.apache.org/r/64144/diff/2-3/


Testing
---

make check


Thanks,

Greg Mann

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

2017-12-04 Thread Greg Mann 


> On Nov. 30, 2017, 10:51 p.m., Jie Yu wrote:
> > src/common/protobuf_utils.hpp
> > Lines 156 (patched)
> > 
> >
> > We typically does not have helper to create internal message (between 
> > agent/master).
> > 
> > I suggest we just inline this

Good call; done.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64144/#review192378
---


On Dec. 4, 2017, 10:22 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64144/
> ---
> 
> (Updated Dec. 4, 2017, 10:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan 
> Schlicht.
> 
> 
> Bugs: MESOS-8193
> https://issues.apache.org/jira/browse/MESOS-8193
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a framework does not request feedback about an operation,
> the master should acknowledge offer operation status updates
> to the agent so that the updates are not retried.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4 
> 
> 
> Diff: https://reviews.apache.org/r/64144/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

2017-12-04 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64144/
---

(Updated Dec. 4, 2017, 10:22 p.m.)


Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan 
Schlicht.


Changes
---

Moved master's acknowledgement sending code out of the conditional checking for 
a terminal update - master should acknowledge all updates whether they are 
terminal or not.


Bugs: MESOS-8193
https://issues.apache.org/jira/browse/MESOS-8193


Repository: mesos


Description
---

When a framework does not request feedback about an operation,
the master should acknowledge offer operation status updates
to the agent so that the updates are not retried.


Diffs (updated)
-

  src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4 


Diff: https://reviews.apache.org/r/64144/diff/2/

Changes: https://reviews.apache.org/r/64144/diff/1-2/


Testing
---

make check


Thanks,

Greg Mann

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

2017-12-01 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64144/#review192583
---




src/master/master.cpp
Lines 7500-7502 (patched)


Remove NONE case here.


- Greg Mann


On Nov. 29, 2017, 5:47 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64144/
> ---
> 
> (Updated Nov. 29, 2017, 5:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan 
> Schlicht.
> 
> 
> Bugs: MESOS-8193
> https://issues.apache.org/jira/browse/MESOS-8193
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a framework does not request feedback about an operation,
> the master should acknowledge offer operation status updates
> to the agent so that the updates are not retried.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 6f991e86e46512d5a2bc4e67e160189fccb77f6a 
>   src/common/protobuf_utils.cpp c0ff306ae6c16cbba6fd08469b639b9f906c672b 
>   src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 
> 
> 
> Diff: https://reviews.apache.org/r/64144/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

2017-11-30 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64144/#review192396
---




src/master/master.cpp
Lines 7495 (patched)


Can you add a CHECK here asserting that the slave has RESOURCE_PROVIDER 
capability?


- Jie Yu


On Nov. 29, 2017, 5:47 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64144/
> ---
> 
> (Updated Nov. 29, 2017, 5:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan 
> Schlicht.
> 
> 
> Bugs: MESOS-8193
> https://issues.apache.org/jira/browse/MESOS-8193
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a framework does not request feedback about an operation,
> the master should acknowledge offer operation status updates
> to the agent so that the updates are not retried.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 6f991e86e46512d5a2bc4e67e160189fccb77f6a 
>   src/common/protobuf_utils.cpp c0ff306ae6c16cbba6fd08469b639b9f906c672b 
>   src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 
> 
> 
> Diff: https://reviews.apache.org/r/64144/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

2017-11-30 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64144/#review192378
---




src/common/protobuf_utils.hpp
Lines 156 (patched)


We typically does not have helper to create internal message (between 
agent/master).

I suggest we just inline this



src/master/master.cpp
Lines 7489-7490 (original), 7489-7494 (patched)


With reliable status update and ack in mind, i don't think we can remove 
the offfer operation in master if it's `latest_status` is terminal. There might 
be a queue of pending status update that hasn't been acked.

Instead, we should look at the last received status (i.e., 
operation->statuses(latest)) and check if that's terminal.



src/master/master.cpp
Line 7490 (original), 7490 (patched)


Maybe make that a CHECK for now?


- Jie Yu


On Nov. 29, 2017, 5:47 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64144/
> ---
> 
> (Updated Nov. 29, 2017, 5:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan 
> Schlicht.
> 
> 
> Bugs: MESOS-8193
> https://issues.apache.org/jira/browse/MESOS-8193
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a framework does not request feedback about an operation,
> the master should acknowledge offer operation status updates
> to the agent so that the updates are not retried.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 6f991e86e46512d5a2bc4e67e160189fccb77f6a 
>   src/common/protobuf_utils.cpp c0ff306ae6c16cbba6fd08469b639b9f906c672b 
>   src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 
> 
> 
> Diff: https://reviews.apache.org/r/64144/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

2017-11-29 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64144/
---

Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan 
Schlicht.


Bugs: MESOS-8193
https://issues.apache.org/jira/browse/MESOS-8193


Repository: mesos


Description
---

When a framework does not request feedback about an operation,
the master should acknowledge offer operation status updates
to the agent so that the updates are not retried.


Diffs
-

  src/common/protobuf_utils.hpp 6f991e86e46512d5a2bc4e67e160189fccb77f6a 
  src/common/protobuf_utils.cpp c0ff306ae6c16cbba6fd08469b639b9f906c672b 
  src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 


Diff: https://reviews.apache.org/r/64144/diff/1/


Testing
---

make check


Thanks,

Greg Mann