[Samba] Samba 4 bind 9.7.2 CentOS 5.5
For those of you looking for an rpm to install bind 9.7.2, here ya go. These were built with mock so they should be safe. They are a backport from Fedora rawhide (fc15) but do not have gpg signature. http://www.taylortelephone.com/bind9/ Jonn -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] [Announce] Samba 3.5.6 Available for Download
== When one teaches, two learn. Robert Half == Release Announcements = This is the latest stable release of Samba 3.5. Major enhancements in Samba 3.5.6 include: o Fix smbd panic on invalid NetBIOS session request (bug #7698). o Fix smbd crash caused by %D in printer admin (bug #7541). o Fix crash bug with invalid SPNEGO token (bug #7694). o Fix Winbind internal error (bug #7636). Changes since 3.5.5 --- o Jeremy Allison j...@samba.org * BUG 7577: Fix SPNEGO auth when contacting Win7 system using Microsoft Live Sign-in Assistant. * BUG 7578: Fix 'net idmap restore' setting HWM to avoid duplicates. * BUG 7581: Fix admin users when using vfs_acl_xattr. * BUG 7583: Fix smbclient to connect to Alfresco JLAN CIFS server using Kerberos. * BUG 7589: Fix using cached credentials in ntlm_auth. * BUG 7590: Fix Winbind offline login. * BUG 7617: Fix smbd coredump due to uninitialized variables in the performance counter code. * BUG 7636: Fix Winbind internal error. * BUG 7651: Fix mknod and mkfifo failing with No such file or directory. * BUG 7693: Fix smbd changing mode of files on rename. * BUG 7694: Fix crash bug with invalid SPNEGO token. * BUG 7698: Fix smbd panic on invalid NetBIOS session request. o Günther Deschner g...@samba.org * BUG 7541: Fix smbd crash caused by %D in printer admin. * BUG 7568: Make sure cm_connect_lsa_tcp does not reset the secure channel. * BUG 7658: Fix dereferencing type-punned pointer will break strict-aliasing rules warnings). * BUG 7665: Fix memory leak in netapi connection manager. o Björn Jacke b...@sernet.de * BUG 7244: Fall back to cups-config for underlinked libs. * BUG 7474: Fix build on platforms without st_blocks and st_blksize stat struct members. o Volker Lendecke v...@samba.org * BUG 7336: Enable idmap_passdb module build as shared. * BUG 7531: Fix the charset_pull routine. * BUG 7635: Fix 'smbclient -M'. * BUG 7656: Fix scalability problem with hundreds of printers. * BUG 7684: Fix fd leak in libwbclient.so. * BUG 7688: Fix crash bug in rpcclient. * BUG 7470: Standardize S_IREAD and S_IWRITE. * BUG 7715: Fix file corruption when setting Samba write wache wize. o Jim McDonough j...@samba.org * BUG 7280: Fix auto printers with registry config. o Andreas Schneider a...@samba.org * BUG 7538: Fix GUID_from_data_blob() with length of 32. o Chere Zhou chere.z...@isilon.com * BUG 7662: Align change notify replies on 4-byte boundary. ## Reporting bugs Development Discussion ### Please discuss this release on the samba-technical mailing list or by joining the #samba-technical IRC channel on irc.freenode.net. If you do report problems then please try to send high quality feedback. If you don't provide vital information to help us track down the problem then you will probably be ignored. All bug reports should be filed under the Samba 3.5 product in the project's Bugzilla database (https://bugzilla.samba.org/). == == Our Code, Our Bugs, Our Responsibility. == The Samba Team == Download Details The uncompressed tarballs and patch files have been signed using GnuPG (ID 6568B7EA). The source code can be downloaded from: http://download.samba.org/samba/ftp/stable The release notes are available online at: http://www.samba.org/samba/history/samba-3.5.6.html Binary packages will be made available on a volunteer basis from http://download.samba.org/samba/ftp/Binary_Packages/ Our Code, Our Bugs, Our Responsibility. (https://bugzilla.samba.org/) --Enjoy The Samba Team -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] vfs_acl_xattr issue
Hello, I'm using samba 3.4.8~dfsg-2 with vfs objects = acl_xattr. [share] path = /home/users/ valid users = read only = No create mask = 0666 directory mask = 0770 vfs objects = acl_xattr Here is my problem, i'm connecting to my share, which have a folder 'f01' with some acl. I created a folder and broke inherit 'f02'. Now if i create a folder in 'f02' without change it (so it's called New folder, the checkbox inherit acl is checked). If i rename New folder as something the checkbox inherit acl is becoming unchecked. F01 = tutu,toto,titi (inherited checked) \_F02 = tutu,toto (inherited unchecked) \_New folder = tutu,toto (inherited checked) \_something = tutu,toto (inherited unchecked) Can you help me? thanks -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] CTDB with 3 nodes and local disks without a dedicated SAN
Hi Daniel, thank you very much for your fast answer! you should try iscsi drbd gfs if you think and mix wisely it should start. THis is, you have on central point of storage where all three nodes write to and this storage backed up. wouldn't I have one single point of failure then (in terms of HA) or did I get something wrong? My latest try with ctdb did not work on CentOs. The package was brocken. Good to know, thanks, I'll compile it from source then as I also run CentOS 5.5, wanted to use 3.5 anyway. And I think it is not possible to cluster a DC. Could you elaborate more on this? Do you mean it's not possible to cluster samba acting as a DC? If that's what you're saying and it's true I must have missed the biggest point. I'd like to set up 3 samba nodes clustered with CTDB, with each node/machine having its own sets of local disks. It would be great if 2 machines and/or sets of local disks could fail the same time without taking down samba. Is this only possible using DRBD as suggested in the current Samba 3 book? The book by Volker Lendecke, Karolin Seeger, Björn Jacke and Michael Adam. Maybe it's only available in German, I don't know. Thank you, Max -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] tdbbackup with bouncing/shutting down samba possible?
Hi, We are a small company, which has just started using samba. Recently we have faced a few issues regarding the TDBs getting corrupted. I have read that the only way of getting around this issue, is to regularly take tdbbackups. But, this process needs a downtime of my samba server, which we would not want. Instead, is there a way where I can take the tdbbackup with out shutting down samba server. That is, perhaps a way by which we just effectively shutdown TDBs one by one, taking there backups. If that is possible, then we can schedule this activity at the time when the load on the server is at the lowest point. I tried to google it but could not find anything about this. Any ideas/thoughts on how can we take tdbbackups without shutting down samba? Regards, Rick -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] tdbbackup with bouncing/shutting down samba possible?
On Sat, Oct 09, 2010 at 01:58:20AM +0530, Rick Gates wrote: Hi, We are a small company, which has just started using samba. Recently we have faced a few issues regarding the TDBs getting corrupted. I have read that the only way of getting around this issue, is to regularly take tdbbackups. But, this process needs a downtime of my samba server, which we would not want. tdbbackup can backup a live tdb. Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] CTDB with 3 nodes and local disks without a dedicated SAN
Hi On 8 October 2010 13:04, Max m...@mailspot.at wrote: [...] you should try iscsi drbd gfs if you think and mix wisely it should start. THis is, you have on central point of storage where all three nodes write to and this storage backed up. wouldn't I have one single point of failure then (in terms of HA) or did I get something wrong? Yes. Maybe you could use a distributed, replicated filesystem like Ceph. Not sure though. I've never used ctdb or Ceph. -- Michael Wood esiot...@gmail.com -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] tdbbackup with bouncing/shutting down samba possible?
Hi Rick, here's a small excerpt from the tdbbackup man page: The tdbbackup utility can safely be run at any time. It was designed so that it can be used at any time to validate the integrity of tdb files, even during Samba operation. There is no need to stop samba during backup creation. regards Marten Am 08.10.2010 22:28, schrieb Rick Gates: Hi, We are a small company, which has just started using samba. Recently we have faced a few issues regarding the TDBs getting corrupted. I have read that the only way of getting around this issue, is to regularly take tdbbackups. But, this process needs a downtime of my samba server, which we would not want. Instead, is there a way where I can take the tdbbackup with out shutting down samba server. That is, perhaps a way by which we just effectively shutdown TDBs one by one, taking there backups. If that is possible, then we can schedule this activity at the time when the load on the server is at the lowest point. I tried to google it but could not find anything about this. Any ideas/thoughts on how can we take tdbbackups without shutting down samba? Regards, Rick -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Build status as of Fri Oct 8 06:00:01 2010
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2010-10-07 00:00:27.0 -0600 +++ /home/build/master/cache/broken_results.txt 2010-10-08 00:00:02.0 -0600 @@ -1,11 +1,11 @@ -Build status as of Thu Oct 7 06:00:02 2010 +Build status as of Fri Oct 8 06:00:01 2010 Build counts: Tree Total Broken Panic build_farm 0 0 0 -ccache 32 3 0 +ccache 32 2 0 ccache-maint 31 2 0 -ldb 32 15 0 +ldb 32 17 0 libreplace 32 11 0 lorikeet 0 0 0 pidl 18 18 0 @@ -13,10 +13,10 @@ rsync32 13 0 samba-docs 0 0 0 samba-web0 0 0 -samba_3_current 32 31 4 +samba_3_current 32 32 4 samba_3_master 32 26 0 samba_3_next 32 29 0 -samba_4_0_waf 35 31 0 -talloc 32 6 0 -tdb 30 9 0 +samba_4_0_waf 35 30 0 +talloc 32 8 0 +tdb 30 11 0
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 7915142 s3: Fix input check in is_encrypted_packet
from cd04af7 Fix bug 7716 - acl_xattr and acl_tdb modules don't store
unmodified copies of security descriptors.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 7915142848f07b477f2c26d0034a79840757b8af
Author: Volker Lendecke v...@samba.org
Date: Wed Oct 6 17:40:58 2010 +0200
s3: Fix input check in is_encrypted_packet
Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Fri Oct 8 07:40:52 UTC 2010 on sn-devel-104
---
Summary of changes:
source3/smbd/seal.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/smbd/seal.c b/source3/smbd/seal.c
index 0cf730e..1d8d464 100644
--- a/source3/smbd/seal.c
+++ b/source3/smbd/seal.c
@@ -55,7 +55,9 @@ bool is_encrypted_packet(const uint8_t *inbuf)
uint16_t enc_num;
/* Ignore non-session messages or non 0xFF'E' messages. */
- if(CVAL(inbuf,0) || !(inbuf[4] == 0xFF inbuf[5] == 'E')) {
+ if(CVAL(inbuf,0)
+ || (smb_len(inbuf) 8)
+ || !(inbuf[4] == 0xFF inbuf[5] == 'E')) {
return false;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via 3c35914 s3: Fix input check in is_encrypted_packet
from b0d0af8 Fix bug 7716 - acl_xattr and acl_tdb modules don't store
unmodified copies of security descriptors.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit 3c35914be1ce5f7ca4734066db3ce246c50587fb
Author: Volker Lendecke v...@samba.org
Date: Wed Oct 6 17:40:58 2010 +0200
s3: Fix input check in is_encrypted_packet
---
Summary of changes:
source3/smbd/seal.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/smbd/seal.c b/source3/smbd/seal.c
index 0cf730e..1d8d464 100644
--- a/source3/smbd/seal.c
+++ b/source3/smbd/seal.c
@@ -55,7 +55,9 @@ bool is_encrypted_packet(const uint8_t *inbuf)
uint16_t enc_num;
/* Ignore non-session messages or non 0xFF'E' messages. */
- if(CVAL(inbuf,0) || !(inbuf[4] == 0xFF inbuf[5] == 'E')) {
+ if(CVAL(inbuf,0)
+ || (smb_len(inbuf) 8)
+ || !(inbuf[4] == 0xFF inbuf[5] == 'E')) {
return false;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 4e95081 s3-waf: slowly getting modules to match how they look like
in old build.
from 7915142 s3: Fix input check in is_encrypted_packet
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 4e9508172d5d436513b829294b5a73223292d348
Author: Günther Deschner g...@samba.org
Date: Thu Oct 7 21:28:04 2010 +0200
s3-waf: slowly getting modules to match how they look like in old build.
Guenther
Autobuild-User: Günther Deschner g...@samba.org
Autobuild-Date: Fri Oct 8 09:31:01 UTC 2010 on sn-devel-104
---
Summary of changes:
source3/auth/wscript_build | 38 +++---
source3/libgpo/gpext/wscript_build | 14 +-
source3/modules/wscript_build | 216 ++--
source3/winbindd/wscript_build | 64 ++--
source3/wscript_build |8 +-
5 files changed, 170 insertions(+), 170 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/auth/wscript_build b/source3/auth/wscript_build
index a8da5e0..62a730c 100644
--- a/source3/auth/wscript_build
+++ b/source3/auth/wscript_build
@@ -18,69 +18,69 @@ AUTH_SRC = '''auth.c auth_util.c token_util.c
user_krb5.c
auth_compat.c auth_ntlmssp.c'''
-bld.SAMBA_SUBSYSTEM('AUTH',
+bld.SAMBA_SUBSYSTEM('auth',
source=AUTH_SRC,
deps='''PLAINTEXT_AUTH SLCACHE DCUTIL''',
vars=locals())
-bld.SAMBA_MODULE('AUTH_SAM',
- subsystem='AUTH',
+bld.SAMBA_MODULE('auth_sam',
+ subsystem='auth',
source=AUTH_SAM_SRC,
init_function='',
internal_module=bld.SAMBA3_IS_STATIC_MODULE('AUTH_SAM'),
enabled=bld.SAMBA3_IS_ENABLED_MODULE('AUTH_SAM'))
-bld.SAMBA_MODULE('AUTH_UNIX',
- subsystem='AUTH',
+bld.SAMBA_MODULE('auth_unix',
+ subsystem='auth',
source=AUTH_UNIX_SRC,
init_function='',
internal_module=bld.SAMBA3_IS_STATIC_MODULE('AUTH_UNIX'),
enabled=bld.SAMBA3_IS_ENABLED_MODULE('AUTH_UNIX'))
-bld.SAMBA_MODULE('AUTH_WINBIND',
- subsystem='AUTH',
+bld.SAMBA_MODULE('auth_winbind',
+ subsystem='auth',
source=AUTH_WINBIND_SRC,
init_function='',
internal_module=bld.SAMBA3_IS_STATIC_MODULE('AUTH_WINBIND'),
enabled=bld.SAMBA3_IS_ENABLED_MODULE('AUTH_WINBIND'))
-bld.SAMBA_MODULE('AUTH_WBC',
- subsystem='AUTH',
+bld.SAMBA_MODULE('auth_wbc',
+ subsystem='auth',
source=AUTH_WBC_SRC,
init_function='',
internal_module=bld.SAMBA3_IS_STATIC_MODULE('AUTH_WBC'),
enabled=bld.SAMBA3_IS_ENABLED_MODULE('AUTH_WBC'))
-bld.SAMBA_MODULE('AUTH_SERVER',
- subsystem='AUTH',
+bld.SAMBA_MODULE('auth_server',
+ subsystem='auth',
source=AUTH_SERVER_SRC,
init_function='',
internal_module=bld.SAMBA3_IS_STATIC_MODULE('AUTH_SERVER'),
enabled=bld.SAMBA3_IS_ENABLED_MODULE('AUTH_SERVER'))
-bld.SAMBA_MODULE('AUTH_DOMAIN',
- subsystem='AUTH',
+bld.SAMBA_MODULE('auth_domain',
+ subsystem='auth',
source=AUTH_DOMAIN_SRC,
init_function='',
internal_module=bld.SAMBA3_IS_STATIC_MODULE('AUTH_DOMAIN'),
enabled=bld.SAMBA3_IS_ENABLED_MODULE('AUTH_DOMAIN'))
-bld.SAMBA_MODULE('AUTH_BUILTIN',
- subsystem='AUTH',
+bld.SAMBA_MODULE('auth_builtin',
+ subsystem='auth',
source=AUTH_BUILTIN_SRC,
init_function='',
internal_module=bld.SAMBA3_IS_STATIC_MODULE('AUTH_BUILTIN'),
enabled=bld.SAMBA3_IS_ENABLED_MODULE('AUTH_BUILTIN'))
-bld.SAMBA_MODULE('AUTH_NETLOGOND',
- subsystem='AUTH',
+bld.SAMBA_MODULE('auth_netlogond',
+ subsystem='auth',
source=AUTH_NETLOGOND_SRC,
init_function='',
internal_module=bld.SAMBA3_IS_STATIC_MODULE('AUTH_NETLOGOND'),
enabled=bld.SAMBA3_IS_ENABLED_MODULE('AUTH_NETLOGOND'))
-bld.SAMBA_MODULE('AUTH_SCRIPT',
- subsystem='AUTH',
+bld.SAMBA_MODULE('auth_script',
+ subsystem='auth',
source=AUTH_SCRIPT_SRC,
init_function='',
internal_module=bld.SAMBA3_IS_STATIC_MODULE('AUTH_SCRIPT'),
diff --git a/source3/libgpo/gpext/wscript_build
b/source3/libgpo/gpext/wscript_build
index 8f7164a..b35396d 100644
---
[SCM] Samba Shared Repository - annotated tag release-3-5-6 created
The annotated tag, release-3-5-6 has been created at 626e571bc73207cbf441b29427f349b6e72c1fc2 (tag) tagging 7d36ff6e592292d3feaf532a2cbb5480b9faa94c (commit) replaces release-3-5-5 tagged by Karolin Seeger on Thu Oct 7 20:29:48 2010 +0200 - Log - tag release-3-5-6 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.12 (GNU/Linux) iD8DBQBMrhGwbzORW2Vot+oRAv30AJ9vaCtRzQ1z+JanYvJML+NVHpYyVgCeNC1e 3NtxStuGBD3XNQEL99EWQfY= =+g0G -END PGP SIGNATURE- Andreas Schneider (1): s3-librpc: Fixed GUID_from_data_blob() with length of 32. Andrew Tridgell (1): librpc: split out a separate GUID_from_ndr_blob() function Björn Jacke (2): s3: fall back to cups-config for underlinked libs s3: fix build on platforms without st_blocks and st_blksize stat struct members Chere Zhou (1): s3:smbd: Align change notify replies on 4-byte boundary Günther Deschner (7): s3-printing: Fix Bug #7541, %D in printer admin causing smbd crash. s3-winbind: Fix Bug #7568: Make sure cm_connect_lsa_tcp does not reset the secure channel. s3-dcerpc: avoid talloc_move on schannel creds in cli_rpc_pipe_open_schannel_with_key(). s3-net: fix a dereferencing type-punned pointer will break strict-aliasing rules warning. s3-rpcclient: fix two more invalid typecasts in spoolss commands. s3-spoolss: add and use spoolss_printerinfo2_to_setprinterinfo2(). s3-libnetapi: Fix Bug #7665, memory leak in netapi connection manager. Jeremy Allison (12): s3-libsmb: Fix bug #7583. s3-libsmb: Fix bug #7577. s3: Fix bug 7578 Fix bug #7617 - smbd coredump due to uninitialized variables in the performance counter code. Fix bug 7590 - offline login fails because winbind deletes cache on every startup. Fix bug 7581 - Users in admin users in smb.conf file are unable to read/write all files when the acl_xattr vfs module is used. Fix bug #7589 - ntlm_auth fails to use cached credentials. Final part of fix for bug #7636 - winbind internal error, backtrace. Fix bug #7651 - mknod and mkfifo fails with No such file or directory Fix bug #7693 - smbd changing mode of files on rename Fix bug #7698 - Assert causes smbd to panic on invalid NetBIOS session request. Fix bug 7694 - Crash bug with invalid SPNEGO token. Jim McDonough (1): s3-printing: fix BUG 7280 - auto printers not loading with registry config Karolin Seeger (5): WHATSNEW: Prepare release notes for Samba 3.5.6. VERSION: Bump version number up to 3.5.6. WHATSNEW: Update changes since 3.5.5. WHATSNEW: Update release notes. WHATSNEW: Update release notes. Stefan Metzmacher (2): pidl: Samba3/ClientNDR - Correctly copy arrays, if r.out.size r.in.size. rerun: make samba3-idl Volker Lendecke (9): s3: Fix bug 7336: Enable idmap_passdb module build as shared s3: Fix bug 7635 s3: Cache results of finding printer names libwbclient: Fix a fd-leak at dlclose-time s3: Fix the charset_pull routine s3: Remove a global variable in bugfix for bug 7665 s3: Fix bug 7688, rpcclient command line completion crashing s3: Fix bug 7470 s3: Stop using the write cache after an oplock break --- -- Samba Shared Repository
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via c1a4109 Fix German umlauts. from 719c28d Update generated news. http://gitweb.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit c1a410925032719b1f299133fe8ec8720d56d094 Author: Karolin Seeger ksee...@samba.org Date: Fri Oct 8 14:25:33 2010 +0200 Fix German umlauts. Karolin --- Summary of changes: history/samba-3.5.6.html |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/history/samba-3.5.6.html b/history/samba-3.5.6.html index 6292b36..d283e6c 100755 --- a/history/samba-3.5.6.html +++ b/history/samba-3.5.6.html @@ -51,7 +51,7 @@ o Jeremy Allison lt;j...@samba.orggt; * BUG 7698: Fix smbd panic on invalid NetBIOS session request. -o Günther Deschner lt;g...@samba.orggt; +o Guuml;nther Deschner lt;g...@samba.orggt; * BUG 7541: Fix smbd crash caused by %D in printer admin. * BUG 7568: Make sure cm_connect_lsa_tcp does not reset the secure channel. * BUG 7658: Fix dereferencing type-punned pointer will break @@ -59,7 +59,7 @@ o Günther Deschner lt;g...@samba.orggt; * BUG 7665: Fix memory leak in netapi connection manager. -o Björn Jacke lt;b...@sernet.degt; +o Bjouml;rn Jacke lt;b...@sernet.degt; * BUG 7244: Fall back to cups-config for underlinked libs. * BUG 7474: Fix build on platforms without st_blocks and st_blksize stat struct members. -- Samba Website Repository
[SCM] Samba Shared Repository - branch v3-5-test updated
The branch, v3-5-test has been updated via 34aa6f4 WHATASNEW: Start 3.5.7 release notes. via 7e0ae1b VERSION: Bump version number up to 3.5.7. from 2c88eee WHATSNEW: Update release notes. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test - Log - commit 34aa6f4b920fee5adf4376d7626efb4782ae039a Author: Karolin Seeger ksee...@samba.org Date: Fri Oct 8 14:36:50 2010 +0200 WHATASNEW: Start 3.5.7 release notes. Karolin commit 7e0ae1b5538da956d2d301cf0fe01f82f98fe024 Author: Karolin Seeger ksee...@samba.org Date: Fri Oct 8 14:35:23 2010 +0200 VERSION: Bump version number up to 3.5.7. Karolin --- Summary of changes: WHATSNEW.txt| 46 -- source3/VERSION |2 +- 2 files changed, 45 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index aae68e6..a9edeb1 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,4 +1,46 @@ = + Release Notes for Samba 3.5.7 + , 2010 + = + + +This is the latest stable release of Samba 3.5. + +Major enhancements in Samba 3.5.7 include: + + o + +Changes since 3.5.5 +--- + + +o Jeremy Allison j...@samba.org + + +## +Reporting bugs Development Discussion +### + +Please discuss this release on the samba-technical mailing list or by +joining the #samba-technical IRC channel on irc.freenode.net. + +If you do report problems then please try to send high quality +feedback. If you don't provide vital information to help us track down +the problem then you will probably be ignored. All bug reports should +be filed under the Samba 3.5 product in the project's Bugzilla +database (https://bugzilla.samba.org/). + + +== +== Our Code, Our Bugs, Our Responsibility. +== The Samba Team +== + + +Release notes for older releases follow: + + + = Release Notes for Samba 3.5.6 October 8, 2010 = @@ -94,8 +136,8 @@ database (https://bugzilla.samba.org/). == -Release notes for older releases follow: - +-- + = Release Notes for Samba 3.5.5 diff --git a/source3/VERSION b/source3/VERSION index 31bd843..7a0f588 100644 --- a/source3/VERSION +++ b/source3/VERSION @@ -25,7 +25,7 @@ SAMBA_VERSION_MAJOR=3 SAMBA_VERSION_MINOR=5 -SAMBA_VERSION_RELEASE=6 +SAMBA_VERSION_RELEASE=7 # Bug fix releases use a letter for the patch revision # -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-5-stable updated
The branch, v3-5-stable has been updated via 01a15b1 WHATASNEW: Start 3.5.7 release notes. via c9622dd VERSION: Bump version number up to 3.5.7. via 7d36ff6 WHATSNEW: Update release notes. via 77ca7e2 s3: Stop using the write cache after an oplock break via 7d1db0a Fix bug 7694 - Crash bug with invalid SPNEGO token. via 6348973 WHATSNEW: Update release notes. via b1f6379 Fix bug #7698 - Assert causes smbd to panic on invalid NetBIOS session request. via afc0d4a s3: Fix bug 7470 via 9fe3146 WHATSNEW: Update changes since 3.5.5. via fef3e8b s3: Fix bug 7688, rpcclient command line completion crashing via 5764e04 s3: Remove a global variable in bugfix for bug 7665 (cherry picked from commit cf364274cbae996fbe186b2c2792b212f189e26a) via 72b1f4f s3-libnetapi: Fix Bug #7665, memory leak in netapi connection manager. via 31c319f s3: Fix the charset_pull routine via df774be s3: fix build on platforms without st_blocks and st_blksize stat struct members via 44c7f7d Fix bug #7693 - smbd changing mode of files on rename via 2a284c4 s3:smbd: Align change notify replies on 4-byte boundary via 01ac9d5 libwbclient: Fix a fd-leak at dlclose-time via 48cbe7a s3-spoolss: add and use spoolss_printerinfo2_to_setprinterinfo2(). via f7718e0 s3-rpcclient: fix two more invalid typecasts in spoolss commands. via 6653e9c s3-net: fix a dereferencing type-punned pointer will break strict-aliasing rules warning. via 0212976 s3: Cache results of finding printer names via c72fe31 Fix bug #7651 - mknod and mkfifo fails with No such file or directory via 99cb69f s3-dcerpc: avoid talloc_move on schannel creds in cli_rpc_pipe_open_schannel_with_key(). via 1c1eb9a Final part of fix for bug #7636 - winbind internal error, backtrace. via 3bb92eb s3: fall back to cups-config for underlinked libs via c97aa70 s3: Fix bug 7635 via b8f9c3c Fix bug #7589 - ntlm_auth fails to use cached credentials. via deb10a5 Fix bug 7581 - Users in admin users in smb.conf file are unable to read/write all files when the acl_xattr vfs module is used. via 8f93503 s3-printing: fix BUG 7280 - auto printers not loading with registry config (cherry picked from commit bb92b0e1571e4766ab20bb3eea53f9e7f9567a5f) via 0a66309 Fix bug 7590 - offline login fails because winbind deletes cache on every startup. via 63a8bb8 rerun: make samba3-idl via 7e1964f pidl: Samba3/ClientNDR - Correctly copy arrays, if r.out.size r.in.size. via 514fa59 Fix bug #7617 - smbd coredump due to uninitialized variables in the performance counter code. via aefad86 s3-winbind: Fix Bug #7568: Make sure cm_connect_lsa_tcp does not reset the secure channel. via 0f90a35 s3: Fix bug 7578 via f5dbdef s3-libsmb: Fix bug #7577. via 872c43a s3-libsmb: Fix bug #7583. via b369a7e librpc: split out a separate GUID_from_ndr_blob() function via f72dbd0 s3: Fix bug 7336: Enable idmap_passdb module build as shared (cherry picked from commit 8c0fbc410798512b7a4b7db73bcb24cde6fa7849) (cherry picked from commit b4803af11525823ea508d0ca4e58402d55901194) via 2913db0 s3-printing: Fix Bug #7541, %D in printer admin causing smbd crash. via 41374f1 s3-librpc: Fixed GUID_from_data_blob() with length of 32. from 2ee3b08 VERSION: Bump version number up to 3.5.6. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-stable - Log - commit 01a15b10d185fcb3be6ceaf29fd0b70a5b0c98fd Author: Karolin Seeger ksee...@samba.org Date: Fri Oct 8 14:36:50 2010 +0200 WHATASNEW: Start 3.5.7 release notes. Karolin (cherry picked from commit 34aa6f4b920fee5adf4376d7626efb4782ae039a) commit c9622dd25fea4a5f11b33799d3897af6eff47183 Author: Karolin Seeger ksee...@samba.org Date: Fri Oct 8 14:35:23 2010 +0200 VERSION: Bump version number up to 3.5.7. Karolin (cherry picked from commit 7e0ae1b5538da956d2d301cf0fe01f82f98fe024) commit 7d36ff6e592292d3feaf532a2cbb5480b9faa94c Author: Karolin Seeger ksee...@samba.org Date: Thu Oct 7 18:21:32 2010 +0200 WHATSNEW: Update release notes. Karolin (cherry picked from commit 2c88eee4a311a9d62d121063051c0e3adf145000) commit 77ca7e289e916ed627bb7b343b94a0ee5e078e87 Author: Volker Lendecke v...@samba.org Date: Sat Oct 2 17:07:00 2010 +0200 s3: Stop using the write cache after an oplock break Fix bug #7715 (Setting Samba Write Cache Size Can Cause File Corruption). (cherry picked from commit 9f8292e5f765dff586bfbb261b54da4d4b27a837) commit 7d1db0a35bd8e835147c5dce3bcb0444ccc12dd6 Author: Jeremy Allison j...@samba.org Date: Sun Sep 26 04:59:31 2010 -0700 Fix bug 7694 - Crash bug with invalid SPNEGO token.
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via 719c28d Update generated news. via 526a459 Announce Samba 3.5.6. from 031a630 Make 'patch' happy. http://gitweb.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit 719c28d534decad98a314620b872088180632160 Author: Karolin Seeger ksee...@samba.org Date: Fri Oct 8 12:22:47 2010 +0200 Update generated news. Karolin commit 526a4592c24b20fbc86f3d089f376ca6b8737d71 Author: Karolin Seeger ksee...@samba.org Date: Thu Oct 7 21:07:21 2010 +0200 Announce Samba 3.5.6. Karolin --- Summary of changes: generated_news/latest_10_bodies.html| 23 generated_news/latest_10_headlines.html |4 +- generated_news/latest_2_bodies.html | 25 history/header_history.html |1 + history/samba-3.5.6.html| 92 +++ latest_stable_release.html |6 +- 6 files changed, 122 insertions(+), 29 deletions(-) create mode 100755 history/samba-3.5.6.html Changeset truncated at 500 lines: diff --git a/generated_news/latest_10_bodies.html b/generated_news/latest_10_bodies.html index 7c7c183..4f145fd 100644 --- a/generated_news/latest_10_bodies.html +++ b/generated_news/latest_10_bodies.html @@ -1,4 +1,16 @@ + h5a name=3.5.6 8 October 2010/a/h5 + p class=headlineSamba 3.5.6 Available for Download/p + pThis is the latest stable release of the Samba 3.5 series./p + +pThe uncompressed tarballs and patch files have been signed +using GnuPG (ID 6568B7EA). The source code can be +a href=http://samba.org/samba/ftp/stable/samba-3.5.6.tar.gz;downloaded +now/a. A a href=http://samba.org/samba/ftp/patches/patch-3.5.5-3.5.6.diffs.gz;patch against +Samba 3.5.5/a is also available. See a href=http://samba.org/samba/history/samba-3.5.6.html;the +release notes for more info/a./p + + h5a name=4.0.0alpha1321 September 2010/a/h5 p class=headlineSamba 4.0.0alpha13 available/p pSamba 4 is the ambitious next version of the Samba suite that is being @@ -174,15 +186,4 @@ now/a. A a href=http://samba.org/samba/ftp/patches/patch-3.5.2-3.5.3.diffs.g Samba 3.5.2/a is also available. See a href=http://samba.org/samba/history/samba-3.5.3.html;the release notes for more info/a./p - - h5a name=3.4.811 May 2010/a/h5 - p class=headlineSamba 3.4.8 Available for Download/p - pThis is the latest stable release of the Samba 3.4 series./p - -pThe uncompressed tarballs and patch files have been signed -using GnuPG (ID 6568B7EA). The source code can be -a href=http://samba.org/samba/ftp/stable/samba-3.4.8.tar.gz;downloaded -now/a. See a href=http://samba.org/samba/history/samba-3.4.8.html;the -release notes for more info/a./p - diff --git a/generated_news/latest_10_headlines.html b/generated_news/latest_10_headlines.html index be4863a..35b03f3 100644 --- a/generated_news/latest_10_headlines.html +++ b/generated_news/latest_10_headlines.html @@ -1,4 +1,6 @@ ul + li 8 October 2010 a href=#3.5.6Samba 3.5.6 Available for Download/a/li + li21 September 2010 a href=#4.0.0alpha13Samba 4.0.0alpha13 available/a/li li14 September 2010 a href=#3.5.5Samba 3.5.5 Security Release Available/a/li @@ -16,6 +18,4 @@ li28 May 2010 a href=#Samba_Team_Blog_4Samba Team Blog #4/a/li li19 May 2010 a href=#3.5.3Samba 3.5.3 Available for Download/a/li - - li11 May 2010 a href=#3.4.8Samba 3.4.8 Available for Download/a/li /ul diff --git a/generated_news/latest_2_bodies.html b/generated_news/latest_2_bodies.html index 43e031a..156c9f4 100644 --- a/generated_news/latest_2_bodies.html +++ b/generated_news/latest_2_bodies.html @@ -1,4 +1,16 @@ + h5a name=3.5.6 8 October 2010/a/h5 + p class=headlineSamba 3.5.6 Available for Download/p + pThis is the latest stable release of the Samba 3.5 series./p + +pThe uncompressed tarballs and patch files have been signed +using GnuPG (ID 6568B7EA). The source code can be +a href=http://samba.org/samba/ftp/stable/samba-3.5.6.tar.gz;downloaded +now/a. A a href=http://samba.org/samba/ftp/patches/patch-3.5.5-3.5.6.diffs.gz;patch against +Samba 3.5.5/a is also available. See a href=http://samba.org/samba/history/samba-3.5.6.html;the +release notes for more info/a./p + + h5a name=4.0.0alpha1321 September 2010/a/h5 p class=headlineSamba 4.0.0alpha13 available/p pSamba 4 is the ambitious next version of the Samba suite that is being @@ -20,17 +32,4 @@ a href=http://samba.org/samba/ftp/samba4/samba-4.0.0alpha13.tar.gz;downloaded now/a. See the a href=http://lists.samba.org/archive/samba-technical/2010-September/073481.html;announcement/a on the mailing list for more information./p - - h5a name=3.5.514 September
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 584ac76 s4:ldap.py - split it up and move SAM related stuff to
sam.py
from 61c7b67 s4:ldap_server: rewrite to socket layer to use tstream
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 584ac76a4f959ee8fa491407e3039a34bc5c627a
Author: Matthias Dieter Wallnöfer m...@samba.org
Date: Thu Oct 7 09:42:07 2010 +0200
s4:ldap.py - split it up and move SAM related stuff to sam.py
ldap.py would still need some additional split-up but it's a start.
Autobuild-User: Matthias Dieter Wallnöfer m...@samba.org
Autobuild-Date: Fri Oct 8 14:05:18 UTC 2010 on sn-devel-104
---
Summary of changes:
source4/dsdb/tests/python/ldap.py | 553 +--
source4/dsdb/tests/python/sam.py | 663 +
source4/selftest/tests.py |1 +
3 files changed, 665 insertions(+), 552 deletions(-)
create mode 100755 source4/dsdb/tests/python/sam.py
Changeset truncated at 500 lines:
diff --git a/source4/dsdb/tests/python/ldap.py
b/source4/dsdb/tests/python/ldap.py
index 2b75bd6..4e054ba 100755
--- a/source4/dsdb/tests/python/ldap.py
+++ b/source4/dsdb/tests/python/ldap.py
@@ -43,7 +43,7 @@ import unittest
from samba.ndr import ndr_pack, ndr_unpack
from samba.dcerpc import security
-parser = optparse.OptionParser(ldap [options] host)
+parser = optparse.OptionParser(ldap.py [options] host)
sambaopts = options.SambaOptions(parser)
parser.add_option_group(sambaopts)
parser.add_option_group(options.VersionOptions(parser))
@@ -1225,557 +1225,6 @@ objectClass: container
self.delete_force(self.ldb, cn=ldaptestgroup,cn=users, +
self.base_dn)
-def test_users_groups(self):
-This tests the SAM users and groups behaviour
-print Testing users and groups behaviour\n
-
-ldb.add({
-dn: cn=ldaptestgroup,cn=users, + self.base_dn,
-objectclass: group})
-
-ldb.add({
-dn: cn=ldaptestgroup2,cn=users, + self.base_dn,
-objectclass: group})
-
-res1 = ldb.search(cn=ldaptestgroup,cn=users, + self.base_dn,
- scope=SCOPE_BASE, attrs=[objectSID])
-self.assertTrue(len(res1) == 1)
-group_rid_1 = security.dom_sid(ldb.schema_format_value(objectSID,
- res1[0][objectSID][0])).split()[1]
-
-res1 = ldb.search(cn=ldaptestgroup2,cn=users, + self.base_dn,
- scope=SCOPE_BASE, attrs=[objectSID])
-self.assertTrue(len(res1) == 1)
-group_rid_2 = security.dom_sid(ldb.schema_format_value(objectSID,
- res1[0][objectSID][0])).split()[1]
-
-# Try to create a user with an invalid primary group
-try:
-ldb.add({
-dn: cn=ldaptestuser,cn=users, + self.base_dn,
-objectclass: [user, person],
-primaryGroupID: 0})
-self.fail()
-except LdbError, (num, _):
-self.assertEquals(num, ERR_UNWILLING_TO_PERFORM)
-self.delete_force(self.ldb, cn=ldaptestuser,cn=users, + self.base_dn)
-
-# Try to Create a user with a valid primary group
-try:
-ldb.add({
-dn: cn=ldaptestuser,cn=users, + self.base_dn,
-objectclass: [user, person],
-primaryGroupID: str(group_rid_1)})
-self.fail()
-except LdbError, (num, _):
-self.assertEquals(num, ERR_UNWILLING_TO_PERFORM)
-self.delete_force(self.ldb, cn=ldaptestuser,cn=users, + self.base_dn)
-
-# Test to see how we should behave when the user account doesn't
-# exist
-m = Message()
-m.dn = Dn(ldb, cn=ldaptestuser,cn=users, + self.base_dn)
-m[primaryGroupID] = MessageElement(0, FLAG_MOD_REPLACE,
- primaryGroupID)
-try:
-ldb.modify(m)
-self.fail()
-except LdbError, (num, _):
-self.assertEquals(num, ERR_NO_SUCH_OBJECT)
-
-# Test to see how we should behave when the account isn't a user
-m = Message()
-m.dn = Dn(ldb, cn=ldaptestgroup,cn=users, + self.base_dn)
-m[primaryGroupID] = MessageElement(0, FLAG_MOD_REPLACE,
- primaryGroupID)
-try:
-ldb.modify(m)
-self.fail()
-except LdbError, (num, _):
-self.assertEquals(num, ERR_OBJECT_CLASS_VIOLATION)
-
-# Test default primary groups on add operations
-
-ldb.add({
-dn: cn=ldaptestuser,cn=users, + self.base_dn,
-objectclass: [user, person]})
-
-res1 = ldb.search(cn=ldaptestuser,cn=users, + self.base_dn,
- scope=SCOPE_BASE, attrs=[primaryGroupID])
-self.assertTrue(len(res1) == 1)
-
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 61c7b67 s4:ldap_server: rewrite to socket layer to use tstream
via 9300f92 s4:lib/tls: buffer writes in tstream_tls_push_function()
via a3d44d5 s4:lib/tls: make more clear what the immediate event is for
via cce2f9d s4:lib/tls: fix enabled logic in tstream_tls_params_server()
from 4e95081 s3-waf: slowly getting modules to match how they look like
in old build.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 61c7b67df9ba484c0e810c07c8da852edf1ef2fc
Author: Stefan Metzmacher me...@samba.org
Date: Wed Sep 22 14:24:03 2010 +0200
s4:ldap_server: rewrite to socket layer to use tstream
This should make our sasl and tls handling much more robust
against partial sent pdus.
metze
Autobuild-User: Stefan Metzmacher me...@samba.org
Autobuild-Date: Fri Oct 8 11:55:26 UTC 2010 on sn-devel-104
commit 9300f922ae570756651c6f9979dd3e490ce2fd4e
Author: Stefan Metzmacher me...@samba.org
Date: Fri Oct 8 10:19:07 2010 +0200
s4:lib/tls: buffer writes in tstream_tls_push_function()
This works arround bugs in gnutls_handshake(),
which diesn't handle EAGAIN correctly, when they use the
push function.
Thanks to marcel.rit...@rrze.uni-erlangen.de and
Matthieu Patou m...@samba.org for the debugging work
on bug #7218.
metze
commit a3d44d5504e1aa2b9e2e5564f644512bf36c01ee
Author: Stefan Metzmacher me...@samba.org
Date: Fri Oct 8 09:39:49 2010 +0200
s4:lib/tls: make more clear what the immediate event is for
metze
commit cce2f9dde4ae9fb9eec3b8cc7cdaf24534f33142
Author: Stefan Metzmacher me...@samba.org
Date: Thu Oct 7 11:16:48 2010 +0200
s4:lib/tls: fix enabled logic in tstream_tls_params_server()
metze
---
Summary of changes:
source4/ldap_server/ldap_bind.c | 93 +++--
source4/ldap_server/ldap_extended.c | 105 -
source4/ldap_server/ldap_server.c | 762 ---
source4/ldap_server/ldap_server.h | 35 +-
source4/lib/tls/tls.h |2 +-
source4/lib/tls/tls_tstream.c | 110 +-
6 files changed, 784 insertions(+), 323 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/ldap_server/ldap_bind.c b/source4/ldap_server/ldap_bind.c
index 529a12d..5036353 100644
--- a/source4/ldap_server/ldap_bind.c
+++ b/source4/ldap_server/ldap_bind.c
@@ -25,7 +25,9 @@
#include lib/ldb/include/ldb_errors.h
#include dsdb/samdb/samdb.h
#include auth/gensec/gensec.h
+#include auth/gensec/gensec_tstream.h
#include param/param.h
+#include ../lib/util/tevent_ntstatus.h
static NTSTATUS ldapsrv_BindSimple(struct ldapsrv_call *call)
{
@@ -94,20 +96,42 @@ static NTSTATUS ldapsrv_BindSimple(struct ldapsrv_call
*call)
return NT_STATUS_OK;
}
-struct ldapsrv_sasl_context {
+struct ldapsrv_sasl_postprocess_context {
struct ldapsrv_connection *conn;
- struct socket_context *sasl_socket;
+ struct tstream_context *sasl;
};
-static void ldapsrv_set_sasl(void *private_data)
+struct ldapsrv_sasl_postprocess_state {
+ uint8_t dummy;
+};
+
+static struct tevent_req *ldapsrv_sasl_postprocess_send(TALLOC_CTX *mem_ctx,
+ struct tevent_context *ev,
+ void *private_data)
{
- struct ldapsrv_sasl_context *ctx = talloc_get_type(private_data, struct
ldapsrv_sasl_context);
- talloc_steal(ctx-conn-connection, ctx-sasl_socket);
- talloc_unlink(ctx-conn-connection, ctx-conn-connection-socket);
+ struct ldapsrv_sasl_postprocess_context *context =
+ talloc_get_type_abort(private_data,
+ struct ldapsrv_sasl_postprocess_context);
+ struct tevent_req *req;
+ struct ldapsrv_sasl_postprocess_state *state;
+
+ req = tevent_req_create(mem_ctx, state,
+ struct ldapsrv_sasl_postprocess_state);
+ if (req == NULL) {
+ return NULL;
+ }
- ctx-conn-sockets.sasl = ctx-sasl_socket;
- ctx-conn-connection-socket = ctx-sasl_socket;
- packet_set_socket(ctx-conn-packet, ctx-conn-connection-socket);
+ TALLOC_FREE(context-conn-sockets.sasl);
+ context-conn-sockets.sasl = talloc_move(context-conn,
context-sasl);
+ context-conn-sockets.active = context-conn-sockets.sasl;
+
+ tevent_req_done(req);
+ return tevent_req_post(req, ev);
+}
+
+static NTSTATUS ldapsrv_sasl_postprocess_recv(struct tevent_req *req)
+{
+ return tevent_req_simple_recv_ntstatus(req);
}
static NTSTATUS ldapsrv_BindSASL(struct ldapsrv_call *call)
@@ -193,27 +217,41 @@ static NTSTATUS ldapsrv_BindSASL(struct ldapsrv_call
*call)
errstr = NULL;
} else if
ctdb_hash() = jenkins
Hi Ronnie,
@@ -99,14 +99,7 @@ bool ctdb_same_address(struct ctdb_address *a1, struct
ctdb_address *a2)
*/
uint32_t ctdb_hash(const TDB_DATA *key)
{
- uint32_t value; /* Used to compute the hash value. */
- uint32_t i; /* Used to cycle through random values. */
-
- /* Set the initial value from the key size. */
- for (value = 0x238F13AF * key-dsize, i=0; i key-dsize; i++)
- value = (value + (key-dptr[i] (i*5 % 24)));
-
- return (1103515243 * value + 12345);
+ return tdb_jenkins_hash(discard_const(key));
}
Don't we need to change the protocol version for this change?
See
http://gitweb.samba.org/?p=metze/ctdb/wip.git;a=shortlog;h=refs/heads/master-tdb
Here're also a few other ctdb/tdb related changes...
metze
signature.asc
Description: OpenPGP digital signature
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 615482a s3: Hang the isilon kernel oplocks off the NULL context via 703e438 s3: Hang the irix kernel oplocks off the NULL ctx via 613a0b6 s3: Hang the linux kernel oplocks off the NULL ctx via ef96bfe s3: Call printer_list_parent_init in the parent via 8125807 s3: Remove talloc_autofree_context() from get_printer_list_db() via 1e98d58 s3: Remove talloc_autofree_context() from loadparm.c via 220aa31 s3: Add a little test for the echo responder via 5e482ae s3: Implement echo_TestSleep via e36e67f tevent: Do not use talloc_autofree_context via b5ed09c Move talloc_enable_null_tracking() to the s3 daemons from 584ac76 s4:ldap.py - split it up and move SAM related stuff to sam.py http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 615482a83d6c18ead7d18624f157170effdebdf8 Author: Volker Lendecke v...@samba.org Date: Thu Oct 7 22:01:28 2010 +0200 s3: Hang the isilon kernel oplocks off the NULL context All I see is a fd_event that does not need a special destructor. Tim, Steven, I've added the #error as well for you to remove after review. Thanks, Volker Autobuild-User: Volker Lendecke vlen...@samba.org Autobuild-Date: Fri Oct 8 20:48:11 UTC 2010 on sn-devel-104 commit 703e4385991feb7a1c18651a03a9562a3964b8d6 Author: Volker Lendecke v...@samba.org Date: Thu Oct 7 21:50:17 2010 +0200 s3: Hang the irix kernel oplocks off the NULL ctx Just a fd_event to be cleaned up. The pipe is closed implicitly. commit 613a0b6c00690a9509129be8ae6a78101e3a21e8 Author: Volker Lendecke v...@samba.org Date: Thu Oct 7 21:48:38 2010 +0200 s3: Hang the linux kernel oplocks off the NULL ctx The destructor that is called removes the signal handler. But at process exit the signal handling is lost anyway. commit ef96bfe88530474a05fdb86955efa3a290f3d547 Author: Volker Lendecke v...@samba.org Date: Thu Oct 7 21:42:08 2010 +0200 s3: Call printer_list_parent_init in the parent Simo, please check! commit 812580736ac58a4f0b5d119790c53797f0a85d6e Author: Volker Lendecke v...@samba.org Date: Thu Oct 7 21:38:26 2010 +0200 s3: Remove talloc_autofree_context() from get_printer_list_db() Another db that does not need explicit closing commit 1e98d5859daceb7d2cbe550803aaec382d2bae86 Author: Volker Lendecke v...@samba.org Date: Thu Oct 7 21:29:19 2010 +0200 s3: Remove talloc_autofree_context() from loadparm.c None of these uses requires a special destructor commit 220aa311d100814be6d396dff96f3825fc01985f Author: Volker Lendecke v...@samba.org Date: Wed Oct 6 18:46:43 2010 +0200 s3: Add a little test for the echo responder commit 5e482aeebf43f95aa003c68d25f7773a944b227e Author: Volker Lendecke v...@samba.org Date: Wed Oct 6 18:45:41 2010 +0200 s3: Implement echo_TestSleep commit e36e67fe047dca505b675c4b6b79b9670a9ad91b Author: Volker Lendecke v...@samba.org Date: Fri Sep 24 19:13:05 2010 +0200 tevent: Do not use talloc_autofree_context commit b5ed09c3afe2c9122db6eec6dd994588d7d6a2c1 Author: Volker Lendecke v...@samba.org Date: Fri Sep 24 18:45:52 2010 +0200 Move talloc_enable_null_tracking() to the s3 daemons --- Summary of changes: lib/talloc/talloc.c |7 -- lib/tevent/tevent.c |5 +- lib/tevent/tevent_signal.c|2 +- source3/Makefile.in |3 +- source3/nmbd/nmbd.c |8 ++- source3/param/loadparm.c | 11 ++-- source3/printing/printer_list.c |2 +- source3/rpc_server/srv_echo_nt.c |2 +- source3/smbd/oplock.c |7 +- source3/smbd/server.c | 13 +++- source3/torture/proto.h |1 + source3/torture/test_async_echo.c | 142 + source3/torture/torture.c |1 + source3/winbindd/winbindd.c |8 ++- 14 files changed, 186 insertions(+), 26 deletions(-) create mode 100644 source3/torture/test_async_echo.c Changeset truncated at 500 lines: diff --git a/lib/talloc/talloc.c b/lib/talloc/talloc.c index cafe4d6..84947a7 100644 --- a/lib/talloc/talloc.c +++ b/lib/talloc/talloc.c @@ -1013,13 +1013,6 @@ _PUBLIC_ void *talloc_init(const char *fmt, ...) void *ptr; const char *name; - /* -* samba3 expects talloc_report_depth_cb(NULL, ...) -* reports all talloc'ed memory, so we need to enable -* null_tracking -*/ - talloc_enable_null_tracking(); - ptr = __talloc(NULL, 0); if (unlikely(ptr == NULL)) return NULL; diff --git a/lib/tevent/tevent.c b/lib/tevent/tevent.c index a91e568..4849bc1 100644 --- a/lib/tevent/tevent.c +++
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 76a8ae9 pytalloc: Fix warning that we are subtracting void* pointers from 615482a s3: Hang the isilon kernel oplocks off the NULL context http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 76a8ae9e0db0340bfa96c428d55afe9b885977e0 Author: Kamen Mazdrashki kame...@samba.org Date: Fri Oct 8 04:19:30 2010 +0300 pytalloc: Fix warning that we are subtracting void* pointers Autobuild-User: Kamen Mazdrashki kame...@samba.org Autobuild-Date: Fri Oct 8 23:36:54 UTC 2010 on sn-devel-104 --- Summary of changes: lib/talloc/pytalloc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/lib/talloc/pytalloc.c b/lib/talloc/pytalloc.c index bea6961..b0b7394 100644 --- a/lib/talloc/pytalloc.c +++ b/lib/talloc/pytalloc.c @@ -109,7 +109,7 @@ int py_talloc_default_cmp(PyObject *_obj1, PyObject *_obj2) if (obj1-ob_type != obj2-ob_type) return (obj1-ob_type - obj2-ob_type); - return (py_talloc_get_ptr(obj1) - py_talloc_get_ptr(obj2)); + return ((char *)py_talloc_get_ptr(obj1) - (char *)py_talloc_get_ptr(obj2)); } static void py_cobject_talloc_free(void *ptr) -- Samba Shared Repository
[SCM] CTDB repository - branch 1.2 updated - ctdb-1.0.114-370-g560533b
The branch, 1.2 has been updated via 560533bc0c009d94aae0a1e67486d238627f0f97 (commit) from 4ae189e1fb3b013d489828813f2d317c1c85633a (commit) http://gitweb.samba.org/?p=sahlberg/ctdb.git;a=shortlog;h=1.2 - Log - commit 560533bc0c009d94aae0a1e67486d238627f0f97 Author: Ronnie Sahlberg ronniesahlb...@gmail.com Date: Sat Oct 9 10:54:12 2010 +1100 dont stop checking interfaces after the first bond device continue the loop to process all other interfaces too --- Summary of changes: config/events.d/10.interface |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/config/events.d/10.interface b/config/events.d/10.interface index de2f92a..3dce668 100755 --- a/config/events.d/10.interface +++ b/config/events.d/10.interface @@ -72,7 +72,7 @@ monitor_interfaces() ok=1 # we only set ok for interfaces known to ctdbd ctdb setifacelink $IFACE up } - return 0; + continue; } case $IFACE in -- CTDB repository
[SCM] CTDB repository - branch 1.2-nodeflags updated - ctdb-1.0.114-372-gd300c63
The branch, 1.2-nodeflags has been updated via d300c635f78440665cd0a13b53e9420d154d784c (commit) from 30449442afe6450c52e293eabc21f04524d2cfbd (commit) http://gitweb.samba.org/?p=sahlberg/ctdb.git;a=shortlog;h=1.2-nodeflags - Log - commit d300c635f78440665cd0a13b53e9420d154d784c Author: Ronnie Sahlberg ronniesahlb...@gmail.com Date: Sat Oct 9 10:54:12 2010 +1100 dont stop checking interfaces after the first bond device continue the loop to process all other interfaces too --- Summary of changes: config/events.d/10.interface |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/config/events.d/10.interface b/config/events.d/10.interface index de2f92a..3dce668 100755 --- a/config/events.d/10.interface +++ b/config/events.d/10.interface @@ -72,7 +72,7 @@ monitor_interfaces() ok=1 # we only set ok for interfaces known to ctdbd ctdb setifacelink $IFACE up } - return 0; + continue; } case $IFACE in -- CTDB repository
[SCM] CTDB repository - branch master updated - ctdb-1.0.114-357-g500ade4
The branch, master has been updated via 500ade4e6a58ea786a665f6be7cf30f43c882570 (commit) from e9d04c5f419eaa0338a3beefba32c52be00242a8 (commit) http://gitweb.samba.org/?p=sahlberg/ctdb.git;a=shortlog;h=master - Log - commit 500ade4e6a58ea786a665f6be7cf30f43c882570 Author: Ronnie Sahlberg ronniesahlb...@gmail.com Date: Sat Oct 9 10:54:12 2010 +1100 dont stop checking interfaces after the first bond device continue the loop to process all other interfaces too --- Summary of changes: config/events.d/10.interface |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/config/events.d/10.interface b/config/events.d/10.interface index de2f92a..3dce668 100755 --- a/config/events.d/10.interface +++ b/config/events.d/10.interface @@ -72,7 +72,7 @@ monitor_interfaces() ok=1 # we only set ok for interfaces known to ctdbd ctdb setifacelink $IFACE up } - return 0; + continue; } case $IFACE in -- CTDB repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 9e1e581 More neccessary const.
via b69bec0 Add some const. Needed for my SD work.
from 76a8ae9 pytalloc: Fix warning that we are subtracting void* pointers
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 9e1e581120d966f40d3c781fc92b18fc5d63c38a
Author: Jeremy Allison j...@samba.org
Date: Fri Oct 8 16:51:24 2010 -0700
More neccessary const.
Autobuild-User: Jeremy Allison j...@samba.org
Autobuild-Date: Sat Oct 9 01:47:25 UTC 2010 on sn-devel-104
commit b69bec03cc210ccb2c5373115352a57ca6363f04
Author: Jeremy Allison j...@samba.org
Date: Fri Oct 8 16:50:40 2010 -0700
Add some const. Needed for my SD work.
Jeremy
---
Summary of changes:
libcli/security/secace.c | 14 +++---
libcli/security/secace.h | 14 +++---
source3/include/proto.h |2 +-
source3/lib/secdesc.c|2 +-
4 files changed, 16 insertions(+), 16 deletions(-)
Changeset truncated at 500 lines:
diff --git a/libcli/security/secace.c b/libcli/security/secace.c
index 2ee5bfa..5787e15 100644
--- a/libcli/security/secace.c
+++ b/libcli/security/secace.c
@@ -44,7 +44,7 @@ bool sec_ace_object(uint8_t type)
/**
* copy a struct security_ace structure.
*/
-void sec_ace_copy(struct security_ace *ace_dest, struct security_ace *ace_src)
+void sec_ace_copy(struct security_ace *ace_dest, const struct security_ace
*ace_src)
{
ace_dest-type = ace_src-type;
ace_dest-flags = ace_src-flags;
@@ -73,7 +73,7 @@ void init_sec_ace(struct security_ace *t, const struct
dom_sid *sid, enum securi
adds new SID with its permissions to ACE list
/
-NTSTATUS sec_ace_add_sid(TALLOC_CTX *ctx, struct security_ace **pp_new, struct
security_ace *old, unsigned *num, struct dom_sid *sid, uint32_t mask)
+NTSTATUS sec_ace_add_sid(TALLOC_CTX *ctx, struct security_ace **pp_new, struct
security_ace *old, unsigned *num, const struct dom_sid *sid, uint32_t mask)
{
unsigned int i = 0;
@@ -99,7 +99,7 @@ NTSTATUS sec_ace_add_sid(TALLOC_CTX *ctx, struct security_ace
**pp_new, struct s
modify SID's permissions at ACL
/
-NTSTATUS sec_ace_mod_sid(struct security_ace *ace, size_t num, struct dom_sid
*sid, uint32_t mask)
+NTSTATUS sec_ace_mod_sid(struct security_ace *ace, size_t num, const struct
dom_sid *sid, uint32_t mask)
{
unsigned int i = 0;
@@ -118,7 +118,7 @@ NTSTATUS sec_ace_mod_sid(struct security_ace *ace, size_t
num, struct dom_sid *s
delete SID from ACL
/
-NTSTATUS sec_ace_del_sid(TALLOC_CTX *ctx, struct security_ace **pp_new, struct
security_ace *old, uint32_t *num, struct dom_sid *sid)
+NTSTATUS sec_ace_del_sid(TALLOC_CTX *ctx, struct security_ace **pp_new, struct
security_ace *old, uint32_t *num, const struct dom_sid *sid)
{
unsigned int i = 0;
unsigned int n_del = 0;
@@ -150,7 +150,7 @@ NTSTATUS sec_ace_del_sid(TALLOC_CTX *ctx, struct
security_ace **pp_new, struct s
Compares two struct security_ace structures
/
-bool sec_ace_equal(struct security_ace *s1, struct security_ace *s2)
+bool sec_ace_equal(const struct security_ace *s1, const struct security_ace
*s2)
{
/* Trivial case */
@@ -178,7 +178,7 @@ bool sec_ace_equal(struct security_ace *s1, struct
security_ace *s2)
return true;
}
-int nt_ace_inherit_comp( struct security_ace *a1, struct security_ace *a2)
+int nt_ace_inherit_comp(const struct security_ace *a1, const struct
security_ace *a2)
{
int a1_inh = a1-flags SEC_ACE_FLAG_INHERITED_ACE;
int a2_inh = a2-flags SEC_ACE_FLAG_INHERITED_ACE;
@@ -195,7 +195,7 @@ int nt_ace_inherit_comp( struct security_ace *a1, struct
security_ace *a2)
Comparison function to apply the order explained below in a group.
***/
-int nt_ace_canon_comp( struct security_ace *a1, struct security_ace *a2)
+int nt_ace_canon_comp( const struct security_ace *a1, const struct
security_ace *a2)
{
if ((a1-type == SEC_ACE_TYPE_ACCESS_DENIED)
(a2-type != SEC_ACE_TYPE_ACCESS_DENIED))
diff --git a/libcli/security/secace.h b/libcli/security/secace.h
index 8b6625d..1322177 100644
--- a/libcli/security/secace.h
+++ b/libcli/security/secace.h
@@ -24,15 +24,15 @@
#include librpc/gen_ndr/security.h
bool sec_ace_object(uint8_t type);
-void sec_ace_copy(struct security_ace *ace_dest, struct security_ace *ace_src);
+void sec_ace_copy(struct security_ace *ace_dest, const struct security_ace
*ace_src);
void
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via e8f3281 More neccessary const.
via 4c516ec Add some const. Needed for my SD work.
from 3c35914 s3: Fix input check in is_encrypted_packet
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit e8f32819d7294ace4d24d04dd4cd86b85408bc28
Author: Jeremy Allison j...@samba.org
Date: Fri Oct 8 16:51:24 2010 -0700
More neccessary const.
Autobuild-User: Jeremy Allison j...@samba.org
Autobuild-Date: Sat Oct 9 01:47:25 UTC 2010 on sn-devel-104
(cherry picked from commit 9e1e581120d966f40d3c781fc92b18fc5d63c38a)
commit 4c516ec8c38bb421b3752e291be4ac68bf0ef307
Author: Jeremy Allison j...@samba.org
Date: Fri Oct 8 16:50:40 2010 -0700
Add some const. Needed for my SD work.
Jeremy
(cherry picked from commit b69bec03cc210ccb2c5373115352a57ca6363f04)
---
Summary of changes:
libcli/security/secace.c | 14 +++---
libcli/security/secace.h | 14 +++---
source3/include/proto.h |2 +-
source3/lib/secdesc.c|2 +-
4 files changed, 16 insertions(+), 16 deletions(-)
Changeset truncated at 500 lines:
diff --git a/libcli/security/secace.c b/libcli/security/secace.c
index 2ee5bfa..5787e15 100644
--- a/libcli/security/secace.c
+++ b/libcli/security/secace.c
@@ -44,7 +44,7 @@ bool sec_ace_object(uint8_t type)
/**
* copy a struct security_ace structure.
*/
-void sec_ace_copy(struct security_ace *ace_dest, struct security_ace *ace_src)
+void sec_ace_copy(struct security_ace *ace_dest, const struct security_ace
*ace_src)
{
ace_dest-type = ace_src-type;
ace_dest-flags = ace_src-flags;
@@ -73,7 +73,7 @@ void init_sec_ace(struct security_ace *t, const struct
dom_sid *sid, enum securi
adds new SID with its permissions to ACE list
/
-NTSTATUS sec_ace_add_sid(TALLOC_CTX *ctx, struct security_ace **pp_new, struct
security_ace *old, unsigned *num, struct dom_sid *sid, uint32_t mask)
+NTSTATUS sec_ace_add_sid(TALLOC_CTX *ctx, struct security_ace **pp_new, struct
security_ace *old, unsigned *num, const struct dom_sid *sid, uint32_t mask)
{
unsigned int i = 0;
@@ -99,7 +99,7 @@ NTSTATUS sec_ace_add_sid(TALLOC_CTX *ctx, struct security_ace
**pp_new, struct s
modify SID's permissions at ACL
/
-NTSTATUS sec_ace_mod_sid(struct security_ace *ace, size_t num, struct dom_sid
*sid, uint32_t mask)
+NTSTATUS sec_ace_mod_sid(struct security_ace *ace, size_t num, const struct
dom_sid *sid, uint32_t mask)
{
unsigned int i = 0;
@@ -118,7 +118,7 @@ NTSTATUS sec_ace_mod_sid(struct security_ace *ace, size_t
num, struct dom_sid *s
delete SID from ACL
/
-NTSTATUS sec_ace_del_sid(TALLOC_CTX *ctx, struct security_ace **pp_new, struct
security_ace *old, uint32_t *num, struct dom_sid *sid)
+NTSTATUS sec_ace_del_sid(TALLOC_CTX *ctx, struct security_ace **pp_new, struct
security_ace *old, uint32_t *num, const struct dom_sid *sid)
{
unsigned int i = 0;
unsigned int n_del = 0;
@@ -150,7 +150,7 @@ NTSTATUS sec_ace_del_sid(TALLOC_CTX *ctx, struct
security_ace **pp_new, struct s
Compares two struct security_ace structures
/
-bool sec_ace_equal(struct security_ace *s1, struct security_ace *s2)
+bool sec_ace_equal(const struct security_ace *s1, const struct security_ace
*s2)
{
/* Trivial case */
@@ -178,7 +178,7 @@ bool sec_ace_equal(struct security_ace *s1, struct
security_ace *s2)
return true;
}
-int nt_ace_inherit_comp( struct security_ace *a1, struct security_ace *a2)
+int nt_ace_inherit_comp(const struct security_ace *a1, const struct
security_ace *a2)
{
int a1_inh = a1-flags SEC_ACE_FLAG_INHERITED_ACE;
int a2_inh = a2-flags SEC_ACE_FLAG_INHERITED_ACE;
@@ -195,7 +195,7 @@ int nt_ace_inherit_comp( struct security_ace *a1, struct
security_ace *a2)
Comparison function to apply the order explained below in a group.
***/
-int nt_ace_canon_comp( struct security_ace *a1, struct security_ace *a2)
+int nt_ace_canon_comp( const struct security_ace *a1, const struct
security_ace *a2)
{
if ((a1-type == SEC_ACE_TYPE_ACCESS_DENIED)
(a2-type != SEC_ACE_TYPE_ACCESS_DENIED))
diff --git a/libcli/security/secace.h b/libcli/security/secace.h
index 8b6625d..1322177 100644
--- a/libcli/security/secace.h
+++ b/libcli/security/secace.h
@@ -24,15 +24,15 @@
#include librpc/gen_ndr/security.h
bool sec_ace_object(uint8_t type);
-void sec_ace_copy(struct security_ace
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 2d2dbf5 s4-test-msds_intid: Verify ATTIDs for Linked Attributes
via 6853883 s4-test-msds_intid: Simplify parameters for
_make_error_message() function
from 9e1e581 More neccessary const.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 2d2dbf53ee110bfcd2f193d3e5c8d0e27759c4f3
Author: Kamen Mazdrashki kame...@samba.org
Date: Sat Oct 9 05:40:32 2010 +0300
s4-test-msds_intid: Verify ATTIDs for Linked Attributes
Autobuild-User: Kamen Mazdrashki kame...@samba.org
Autobuild-Date: Sat Oct 9 03:43:34 UTC 2010 on sn-devel-104
commit 6853883f3f171c69b28a0888548aaa464e163ac7
Author: Kamen Mazdrashki kame...@samba.org
Date: Sat Oct 9 04:22:24 2010 +0300
s4-test-msds_intid: Simplify parameters for _make_error_message() function
so it can be used in more places - when checking for
Linked Attributes ATTIDs for instance
---
Summary of changes:
source4/torture/drs/rpc/msds_intid.c | 73 +-
1 files changed, 63 insertions(+), 10 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/torture/drs/rpc/msds_intid.c
b/source4/torture/drs/rpc/msds_intid.c
index ea5bdc6..2b2fa5e 100644
--- a/source4/torture/drs/rpc/msds_intid.c
+++ b/source4/torture/drs/rpc/msds_intid.c
@@ -460,17 +460,17 @@ static bool _test_GetNCChanges(struct torture_context
*tctx,
}
static char * _make_error_message(TALLOC_CTX *mem_ctx,
- const struct dsdb_attribute *dsdb_attr,
- const struct drsuapi_DsReplicaAttribute
*drs_attr,
- const struct
drsuapi_DsReplicaObjectListItemEx *drs_obj)
+ enum drsuapi_DsAttributeId drs_attid,
+ const struct dsdb_attribute *dsdb_attr,
+ const struct
drsuapi_DsReplicaObjectIdentifier *identifier)
{
return talloc_asprintf(mem_ctx, \nInvalid ATTID for %1$s (%2$s)\n
drs_attid: %3$11d (0x%3$08X)\n
msDS_IntId: %4$11d (0x%4$08X)\n
attributeId_id: %5$11d (0x%5$08X),
dsdb_attr-lDAPDisplayName,
- drs_obj-object.identifier-dn,
- drs_attr-attid,
+ identifier-dn,
+ drs_attid,
dsdb_attr-msDS_IntId,
dsdb_attr-attributeID_id);
}
@@ -489,6 +489,7 @@ static bool test_dsintid_schema(struct torture_context
*tctx, struct DsIntIdTest
const struct drsuapi_DsReplicaAttribute *drs_attr;
const struct drsuapi_DsReplicaAttributeCtr *attr_ctr;
const struct drsuapi_DsReplicaObjectListItemEx *cur;
+ const struct drsuapi_DsReplicaLinkedAttribute *la;
TALLOC_CTX *mem_ctx;
mem_ctx = talloc_new(ctx);
@@ -518,15 +519,40 @@ static bool test_dsintid_schema(struct torture_context
*tctx, struct DsIntIdTest
torture_assert(tctx,
drs_attr-attid ==
dsdb_attr-attributeID_id,
- _make_error_message(ctx, dsdb_attr,
drs_attr, cur))
+ _make_error_message(ctx, drs_attr-attid,
+ dsdb_attr,
+
cur-object.identifier));
if (dsdb_attr-msDS_IntId) {
torture_assert(tctx,
- drs_attr-attid !=
dsdb_attr-msDS_IntId,
- _make_error_message(ctx,
dsdb_attr, drs_attr, cur))
+ drs_attr-attid !=
dsdb_attr-msDS_IntId,
+ _make_error_message(ctx,
drs_attr-attid,
+ dsdb_attr,
+
cur-object.identifier));
}
}
}
+ /* verify ATTIDs for Linked Attributes */
+ torture_comment(tctx, Verify ATTIDs for Linked Attributes (%u)\n,
+ ctr6-linked_attributes_count);
+ for (i = 0; i ctr6-linked_attributes_count; i++) {
+ la = ctr6-linked_attributes[i];
+ dsdb_attr = dsdb_attribute_by_attributeID_id(ldap_schema,
la-attid);
+
+ torture_assert(tctx,
+ la-attid == dsdb_attr-attributeID_id,
+ _make_error_message(ctx, la-attid,
+
