Re: [Spacewalk-devel] Problem with pxt page port
Sorry you need to rebase for that error to go away.. http://git.fedorahosted.org/git/?p=spacewalk.git;a=commit;h=03cb8abfc7e7b838134071c9745acaf5609cc3ec fixes that issue - Original Message - From: Colin Coe colin@gmail.com To: spacewalk-devel@redhat.com Sent: Wednesday, October 13, 2010 8:09:36 PM GMT -05:00 US/Canada Eastern Subject: Re: [Spacewalk-devel] Problem with pxt page port Hi Partha, Thank you for looking at this. When I apply your patch, I get trace backs in catalina.out with --- com.redhat.rhn.common.util.MethodNotFoundException: Could not find method called: getName in class: java.util.HashMap with params: [] at com.redhat.rhn.common.util.MethodUtil.callMethod(MethodUtil.java:196) at com.redhat.rhn.frontend.taglibs.list.DataSetManipulator.getAlphaBarIndex(DataSetManipulator.java:497) at com.redhat.rhn.frontend.taglibs.list.ListTag.doAfterBody(ListTag.java:461) at org.apache.jsp.WEB_002dINF.pages.systems.customkey.updatekey_jsp._jspx_meth_rl_005flist_005f0(updatekey_jsp.java:485) at org.apache.jsp.WEB_002dINF.pages.systems.customkey.updatekey_jsp._jspx_meth_rl_005flistset_005f0(updatekey_jsp.java:296) at org.apache.jsp.WEB_002dINF.pages.systems.customkey.updatekey_jsp._jspx_meth_html_005fhtml_005f0(updatekey_jsp.java:154) at org.apache.jsp.WEB_002dINF.pages.systems.customkey.updatekey_jsp._jspService(updatekey_jsp.java:91) --- Not sure what I doing wrong CC On Thu, Oct 14, 2010 at 5:45 AM, Partha Aji p...@redhat.com wrote: Few changes need to be made on your patch .. I basically updated the UpdateCustomKeyAction and updatekey.jsp . Look at the attached patch. - Original Message - From: Cliff Perry cpe...@redhat.com To: spacewalk-devel@redhat.com Sent: Tuesday, October 12, 2010 9:45:17 PM GMT -05:00 US/Canada Eastern Subject: Re: [Spacewalk-devel] Problem with pxt page port Colin Coe wrote: Hi all I'm having some problems porting a page. the page is '/network/systems/custominfo/edit.pxt' and the problem is displaying the list of systems with this custom data with the correct pagination. I can do it with out the pagination but the pxt file used the pagination so I'm attempting to as well. Could someone have a look and comment? I'm sure what I've done is pretty close. Thanks CC ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel Colin, I don't know enough to help directly. I assume your using one of the list tags for pagination? We have several wiki pages on this which may or may not help. https://fedorahosted.org/spacewalk/wiki/ListTag https://fedorahosted.org/spacewalk/wiki/ListTagAdaptations https://fedorahosted.org/spacewalk/wiki/ListTagDecorators Cliff ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel -- RHCE#805007969328369 ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] The next time you git pull
I updated quite a bit of schema + java + backend code to get the symlink targets to use stuff from rhnConfigInfo instead of storing it as a blob in rhnConfigContent. More info in the description of this commit. http://git.fedorahosted.org/git/?p=spacewalk.git;a=commit;h=592b5c8619abd9094fd7cd9f8b7b10e5ceca608a If you are using nightly builds you are ok, but if you are using the devel schema this commit will likely break it, so run the following upgrade scripts % cd /spacewalk/schema/spacewalk/upgrade/spacewalk-schema-1.0-to-spacewalk-schema-1.1/ % sqlplus connect_string 101-update-config-schema.sql % sqlplus connect_string 102-rhn_config-pks.sql % sqlplus connect_string 103-rhn_config-pkb.sql % sqlplus connect_string 104-rhnconfigrevision-trigger.sql % sqlplus connect_string 105-lookup_config_info.sql and if you have symlinks in your config channels, run /spacewalk/scripts/update_symlinks.py Partha ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Org update
I removed some unused columns from the web_customer table which may result in breakage when you git pull and run the devel environment. Errors like Caused by: java.sql.SQLException: ORA-00904:ORG6_.STAGING_CONTENT_ENABLED: invalid identifier So to fix those cd /spacewalk/schema/spacewalk/upgrade/spacewalk-schema-1.0-to-spacewalk-schema-1.1/ run the sql scripts from 021 - 026 Partha ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Removed the bulk-subscribe and unsubscribe which is not used anywhere
Jan the ssm change channel stuff got ported to Java. I should remove alter pxt
also.. I 'll dig a bit more on this later today. Thanks for thepointer..
Partha
- Original Message -
From: Jan Pazdziora jpazdzi...@redhat.com
To: Partha Aji p...@redhat.com
Cc: spacewalk-devel@redhat.com
Sent: Thursday, June 10, 2010 8:51:49 AM GMT -05:00 US/Canada Eastern
Subject: Re: Removed the bulk-subscribe and unsubscribe which is not used
anywhere
commit 59a24c76ec52099cdea609e94923d3af4e34c57e
Author: Partha Aji p...@redhat.com
Date: Fri May 28 19:09:01 2010 -0400
Removed the bulk-subscribe and unsubscribe which is not used anywhere
diff --git a/web/modules/sniglets/Sniglets/ListView/SystemList.pm
b/web/modules/sniglets/Sniglets/ListView/SystemList.pm
index 70f422a..647b058 100644
--- a/web/modules/sniglets/Sniglets/ListView/SystemList.pm
+++ b/web/modules/sniglets/Sniglets/ListView/SystemList.pm
@@ -85,11 +85,6 @@ sub _register_modes {
-datasource = RHN::DataSource::System-new,
-provider = \visible_to_uid_provider);
- Sniglets::ListView::List-add_mode(-mode = ssm_channel_change_conf,
- -datasource = RHN::DataSource::System-new,
- -provider = \ssm_channel_change_conf_provider,
- -action_callback = \ssm_channel_change_conf_cb);
-
Sniglets::ListView::List-add_mode(-mode =
systems_with_package_nvre_in_set,
-datasource = RHN::DataSource::System-new);
@@ -663,85 +658,6 @@ sub ssm_channel_change_conf_provider {
return %ret;
Partha, the ssm_channel_change_conf seems to be used in
web/html/network/systems/ssm/channels/alter_subscriptions_conf.pxt:
rhn-listview class=Sniglets::ListView::SystemList
mode=ssm_channel_change_conf
empty_list_message
No systems would be affected by your channel subscription choices.
/empty_list_message
column name=Name label=server_name align=left/
column name=To Subscribe label=channels_to_subscribe align=left/
column name=To Unsubscribe label=channels_to_unsubscribe
align=left/
action name=Change Subscriptions label=ssm_change_channel_subscriptions
/
/rhn-listview
Is it correct that we are removing it? Or does the .pxt refer to
different ssm_channel_change_conf?
--
Jan Pazdziora | adelton at #satellite*, #brno
Satellite Engineering, Red Hat
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] The next time you git pull ....
Work was recently done on duplicate system profile detection + elimination which included mod'ing existing kickstart scripts to automatically generate a reactivation key and register themselves using the reactivation even in the cases one is reprovisioning using boot isos. Basically if a system has system id, a KS post script will try to obtain a reactivation key using that system id and register the system. In the case you are working with a devel setup .. Do the following mods.. cd /var/lib/rhn/kickstart/snippets ln -s $SPACEWALK_GIT/java/conf/cobbler/snippets/keep_system_id ln -s $SPACEWALK_GIT/java/conf/cobbler/snippets/post_reactivation_key ln -s $SPACEWALK_GIT/java/conf/cobbler/snippets/redhat_register ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Re: java/code
Uh ? I am confused
public static final String _MEM = kickstart.virt_mem_size_mb;
return getInt(VIRT_MEM, 512) is just using that
Dunno how its any different from what you suggested..
I am I missing anything here ?
Partha
Jesus M. Rodriguez wrote:
Partha,
This should probably be
public int getDefaultVirtMemorySize() {
return Config.get().getInt(virt.default.memsize, 512);
}
That way we can override the value via config at any time.
jesus
On Wed, Jun 24, 2009 at 12:34 PM, Partha Ajipar...@fedoraproject.org wrote:
java/code/src/com/redhat/rhn/common/conf/Config.java |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 72a7c0fd5148ccc994065f9b9ad9d7408bb5223b
Author: Partha Aji p...@redhat.com
Date: Wed Jun 24 12:36:31 2009 -0400
507888 - Set the default virt mem value to 512 instead of 256
Apparently thats the minimum requirement.
diff --git a/java/code/src/com/redhat/rhn/common/conf/Config.java
b/java/code/src/com/redhat/rhn/common/conf/Config.java
index 13fe9c3..ad40462 100644
--- a/java/code/src/com/redhat/rhn/common/conf/Config.java
+++ b/java/code/src/com/redhat/rhn/common/conf/Config.java
@@ -807,7 +807,7 @@ public class Config {
* @return the memory size
*/
public int getDefaultVirtMemorySize() {
-return getInt(VIRT_MEM, 256);
+return getInt(VIRT_MEM, 512);
}
/**
___
spacewalk-commits mailing list
spacewalk-comm...@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/spacewalk-commits
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Big Commit to master
Next time you git pull you may see 309 files changed... I basically did
the following
Moved html:errors/ and html:messages id=message message=true
rhn:messages c:out escapeXml=false
value=${message}//rhn:messages/html:messages to layout_c.jsp
which is used by every page in our UI.. Now since its in a common place
it made sense to remove the senseless duplicate code across all jsps and
jspfs. Please let me know if you have any issues with the commit..
Partha
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Dojo?
We could make our list tags more ajaxy, but I think there was some effort to minimize the amount of java scriptiness to help with non java script browsers.. Right now (in theory) the new/old list tag is supposed to be able to run on Non JS browsers also albeit minor modifications... That being said however we are using some of the functions offered by prototype to asynchronously update rhn/session sets and the manage system sets and On Your Rhn snippets page also.. We could think about using more effects of these libraries if it adds a lot more value in terms of usability.. Partha Cliff wrote: Jesus M. Rodriguez wrote: On Sat, May 2, 2009 at 1:48 PM, Cliff cpe...@redhat.com wrote: So, anyone looked at dojo in the pass? If so, thoughts on it? Could/would it replace our list tag? Make it better? Compatible licenses? The old age problem of how to represent lots of data in a timely manner to Spacewalk folks and allow them to sort/select/filter/paginate that data. Not saying 'we need to be using this!' - but more interested in what others think about it :) http://en.wikipedia.org/wiki/Dojo_Toolkit I think Kevin looked at that once. We already have prototype.js (http://www.prototypejs.org/) and script.aculo.us (http://script.aculo.us/). My understanding they do similar jobs. What feature of dojo sparked your curiosity? Nothing majorly - I was reading about dojo, didn't know much, so just wanting others thoughts on it. Just because someone says it is cool, doesn't mean it would/wouldn't help us out. Cliff jesus ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Re: java/code java/spacewalk-java.spec
Thanks for the suggestions 1) I imagine this could have been unit tested a bit more than zero. - Added some unit tests. Thanks for pushing on it :) 2) can you explain to me the purpose of this if block? - If block was not necessary .. You are right ... Removed it.. 3) all the above should be pulled out of this 'bean' and put into a Manager or a Command of some sort. - Well I don't want to expose too many features in the domain model to the outside world.. If I have to implement this in a Manager layer I;'d have to do almost like a hierarchy BaseSnippet ReadOnlySnippet extends BaseSnippet EditableSnippet extends BaseSnippet and add a Manager there to do all the validation and other magic.. It seemed like too much work at that point.. Will look into this more tomorrow.. ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Fixed a iprange issue where the iprange delete URLs weren't being correctly ...
You'd get it if you saw the iprange.jspf.. The delete link wants the complete URL, a href = /rhn/ , the other line says html:form= which doesnot want the /rhn .. Partha jmrodri wrote: Why do we have to pass in the /rhn/ to the url here where we don't on the others? jesus Sent to you by jmrodri via Google Reader: Fixed a iprange issue where the iprange delete URLs weren't being correctly rendered via Fedora Hosted Git Repositories - spacewalk.git/rss log by Partha Aji p...@redhat.com on 3/12/09 Fixed a iprange issue where the iprange delete URLs weren't being correctly rendered - [DH] java/code/webapp/WEB-INF/pages/kickstart/kickstartips.jsp - [DH] java/code/webapp/WEB-INF/pages/kickstart/wizard/profile/advanced/iprange.jsp Things you can do from here: - Subscribe to Fedora Hosted Git Repositories - spacewalk.git/rss log using Google Reader - Get started using Google Reader to easily keep up with all your favorite sites ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Custom log4j.properties
In the past I ve been annoyed by the fact that I have to be dealing with git when ever I update log4j.propeties even if they are only local changes that I'd never want in the source control system Well in lieu of this I added a couple of lines to build.xml to copy from ~/.log4j.properties and overwrite regular log4j.properties only if ~/.log4j.properties exists. If it doesnot exist a harmless warning is printed saying ~/.log4j.properties does not exist so you can ignore... Partha ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Custom log4j.properties
Done... Jesus M. Rodriguez wrote: On Fri, Feb 27, 2009 at 4:30 PM, Partha Aji p...@redhat.com wrote: In the past I ve been annoyed by the fact that I have to be dealing with git when ever I update log4j.propeties even if they are only local changes that I'd never want in the source control system Well in lieu of this I added a couple of lines to build.xml to copy from ~/.log4j.properties and overwrite regular log4j.properties only if ~/.log4j.properties exists. If it doesnot exist a harmless warning is printed saying ~/.log4j.properties does not exist so you can ignore... Don't print any warning. jesus ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] space05 bugs
Is there a tracker for this ?? Jesus M. Rodriguez wrote: unaddressed bugs: 37 - http://tinyurl.com/bm3e9y total bugs: 84 - http://tinyurl.com/dx5skq We are planning on going out on March 15th (the Ides of March release). Please have your unaddressed bugs done by no later than March 9th. Sincerely, Spacewalk Nanny -- jesus m. rodriguez| jes...@redhat.com sr. software engineer | irc: zeus rhn satellite spacewalk | 919.754.4413 (w) rhce # 805008586930012| 919.623.0080 (c) +---+ | Those who cannot learn from history | | are doomed to repeat it. | | -- George Santayana | +---+ ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] space05 bugs
n/m .. space05. Sorry Partha Aji wrote: Is there a tracker for this ?? Jesus M. Rodriguez wrote: unaddressed bugs: 37 - http://tinyurl.com/bm3e9y total bugs: 84 - http://tinyurl.com/dx5skq We are planning on going out on March 15th (the Ides of March release). Please have your unaddressed bugs done by no later than March 9th. Sincerely, Spacewalk Nanny -- jesus m. rodriguez| jes...@redhat.com sr. software engineer | irc: zeus rhn satellite spacewalk | 919.754.4413 (w) rhce # 805008586930012| 919.623.0080 (c) +---+ | Those who cannot learn from history | | are doomed to repeat it. | | -- George Santayana | +---+ ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] 481766: Added the example text as require dint he bug .. Forgot abt it...
Nice s/Added the example text as require dint he bug/ Added the example text as required in the bug Damn typoisms. How do I change an old commit message in GIT ? Partha jmrodri wrote: This commit has the wrong commit message in it. Sent to you by jmrodri via Google Reader: 481766: Added the example text as require dint he bug .. Forgot abt it... via Fedora Hosted Git Repositories - spacewalk.git/rss log by Partha Aji p...@redhat.com on 2/15/09 481766: Added the example text as require dint he bug .. Forgot abt it... - [DH] java/code/src/com/redhat/rhn/frontend/strings/jsp/StringResource_en_US.xml Things you can do from here: - Subscribe to Fedora Hosted Git Repositories - spacewalk.git/rss log using Google Reader - Get started using Google Reader to easily keep up with all your favorite sites ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] 481766: Added the example text as require dint he bug .. Forgot abt it...
Oh was it supposed to be '-' ? So sorry /me forgets which punctuation went there.. I started with '-' theen backspaced and changed it to : Partha Jesus Rodriguez wrote: On Tue, Feb 17, 2009 at 10:15:48AM -0500, Partha Aji wrote: Nice s/Added the example text as require dint he bug/ Added the example text as required in the bug Damn typoisms. How do I change an old commit message in GIT ? I was more concerned with the colon after the bugzilla number. The typos, well, I'm used to those :) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Debugging Unit Tests
This sounds like a great idea..I usually use eclipse and unit tests running there and use the eclipse debugger to test stuff.. But doing it in ant will be very useful in cases where running unit tests in a specfic order causes the test to fail. Our continuous build system runs the tests via ant and in some instances ant picks up the unit tests in a order different from what eclipse picks up the unit tests. Problem there is that we cannot pickup which test is causing this error becasue the tests run fine in eclipse Using Jdob's approach this issue can be debugged much easier... Partha Jason Dobies wrote: I'm not sure how others do it (or if this is commonly known), but I was looking to attach a debugger to ant as it runs my test cases. Putting the following lines into the java/buildconf/build-utils.xml file in the junit task (roughly line 77) sets the tests to suspend until the debugger is attached. jvmarg value=-Xdebug/ jvmarg value=-Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005/ I'd like to look into a set up where we can do something like: ant -Dtestcase=foo -Dtestdebug test But the junit task doesn't support my first idea for how to do that, so it's gonna take a bit more looking. ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Debugging Unit Tests
Ideally test-debug should be the target name instead of test. way more convenient IMHO :) Jesus Rodriguez wrote: On Tue, Feb 03, 2009 at 05:35:58PM -0500, Jason Dobies wrote: I'm not sure how others do it (or if this is commonly known), but I was looking to attach a debugger to ant as it runs my test cases. Putting the following lines into the java/buildconf/build-utils.xml file in the junit task (roughly line 77) sets the tests to suspend until the debugger is attached. jvmarg value=-Xdebug/ jvmarg value=-Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005/ I'd like to look into a set up where we can do something like: ant -Dtestcase=foo -Dtestdebug test But the junit task doesn't support my first idea for how to do that, so it's gonna take a bit more looking. I just added it but you have to do -Dtestdebug=true. I couldn't get it to work with just -Dtestdebug :) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] SSM Asynchronous Actions
I dunno if its the longest but changing the base channel for a System used to take ~30 secs per system.. So if the user asked the base channel to be changed for 100 systems its almost 50 min to get that done easily timing out the request.. Partha Miroslav Suchý wrote: Jason Dobies wrote: As I was working on the performance enhancements for the SSM bulk channel subscription change (https://bugzilla.redhat.com/show_bug.cgi?id=469984) I started to wonder if our approach to the SSM in general could use a little work. Given the fact that there can potentially be a large number of servers selected, I think the whole setup lends itself towards an asynchronous model. Quick question: what is the longest time for SSM action execution. I mean either you personally experienced, or customer experienced or whoever else experienced. Do we speak about seconds, minutes or hours? ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] SSM Asynchronous Actions
I would vote against the MessageQueue because if you restart tomcat you've lost all of your scheduling. Whereas if you were using taskomatic, you still would have all the queued actions left in the DB. +1 I jsherrill were dicussing how we'd implement this I started with Table Queue - queue_id|Queue of Servers |Action_Type Table QueuArgs - queue_id|key|value Then I realize ugh ... Value can be an int, String , list of ids UGH... I then realize we already have rhnServerAction.. infrastructure to schedule the damn thing... We should just leverage that (may be add a flag that says taskomatic) and change the backend to ignore processing those rows that have the taskomatic flag Partha ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] SSM Asynchronous Actions
Does that mean that the MessageQueue can't be enhanced to use a database? Just because it doesn't right now doesn't mean it can't. I was merely suggesting the MessageQueue as a starting point to avoid inventing yet another threading system. It wouldn't be difficult to back the queue with a db table. And how often do you restart tomcat? on a dev system all the time sure. But in a production server? and what happens if you lose all of the items in the queue? what's the worse that has to happen? you restart them all? all of that is annoying if the number is large and the process is cumbersome. so let's not dismiss it entirely. Good points, and I agree we should consider serializing the queue items. We already have a table for Tasks that can be used with this: rhnTaskQueue Name Null?Type - ORG_IDNOT NULL NUMBER TASK_NAME NOT NULL VARCHAR2(64) TASK_DATANUMBER PRIORITYNUMBER EARLIEST NOT NULL DATE this table is mapped nicely in Hibernate with the class Task. One trouble we'll have with serializing using rhnTaskQueue table might be with the 'type' of task data. TASK_DATANUMBER Lets take an example here.. Lets say I want to subscribe 100 config channels to 100 systems. Now I 'd need task data to be a list of config channels... For other operations I need task data to be something else may be strings... One idea is to make task data a blob that stores json ed value (I don't like this but it may be workable) in the DB... I wonder if using something like MQ series or JMS where issues like serialization to hard drive is taken care of is a better solution than a home grown one.. In memory message queue is a good in the sense it'll let us pass in what ever we want as TaskData. But I am not sure I like the temporary nature... But of all the solutions here, I think it would be easier for us to just reuse rhnServerAction and that infrastructure.. Config* stuff is built in ... We could probably reuse the Event History UI to do the failed/pending actions/ rescheduling, all that is built in. Its almost like 1 query might to be changed for backend to ignore ssm-scheduled task form rhnServerAction.. (I am sure I am trivializing by saying 1 query but it shouldn;t be too difficult to work around that,. ) Partha ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Informal Devel Environment Survey
My setup involves the following 1) Workstation with Fedora on it. This workstation has eclipse + sudo yum install ant-nodeps junit ant-junit java-1.6.0-openjdk-devel sudo rpm -Uvh http://mirrors.dotsrc.org/jpackage/1.7/generic/free/RPMS/ivy-1.3.1-1jpp.noarch.rpm it also has a checkout of the spacewalk git repo. The checkout directory has the code directory listed in /etc/exports to make it available across systems for NFS mount. It also has a Vmware Server running on it with a Rhel 5 VM. 2) The Rhel 5 VM has Spacewalk setup from the https://fedorahosted.org/spacewalk/wiki/HowToInstall instructions .. I then go to https://fedorahosted.org/spacewalk/wiki/DevelopmentWorkstationSetup I skip the git checkoout part and instead mount the directory exported from fedora.., I follow every other step formt he development workstation setup. Idea is to do the development + compilation using the Eclipse IDE on Fedora and runtime with ant/tomcat5/apache etc on Rhel 5 where a 'spacewalk-like' environemnt is present. Trick is to maintain the same directory structure + user permission (including same UID + GIDs) information across both machines.. so for example if the git directory is in /opt/sw/spacewalk on fedora it is the same in rhel 5 .. if my UID is XXX on fedora, there must be a user with the same name and name UID in rhel 5. I would think a similar setup could work for Fedora/Centos combination also... This is a fairly complicated setup but i like the separation between development and runtime environment.. Partha Travis Camechis wrote: Sounds like a good idea. I think another useful think would to have people describe how they setup there environment. It would be good to see how people streamline there development and testing. One thing Im wondering is how people do a lot of there testing. It looks like testing a lot of the features could involve rebuilding VMS a lot and running the test ( not for sure since I haven't actually used the product yet ). Currently I set up my Development box on a CentOs workstation. I setup a NFS mount so I could mount my checkout on my F10 laptop. I also plan on installing a couple VMS on the Centos machine to act as test clients. I currently have one installed so far. On Fri, Jan 23, 2009 at 8:06 PM, Jesus M. Rodriguez jmro...@gmail.comwrote: On Fri, Jan 23, 2009 at 12:27 PM, Michael DeHaan mdeh...@redhat.com wrote: Jesus M. Rodriguez wrote: On Thu, Jan 22, 2009 at 3:03 PM, Coe, Colin C. (Unix Engineer) colin@woodside.com.au wrote: I've found that doing the steps under 'Deploying Development Schema' doesn't work (for me anyway) and ends up needing to redo the dev environment. Also, I'd like to see https://fedorahosted.org/spacewalk/wiki/JavaDesign fleshed out a lot more. Anything in particular? I'd be happy to update it. jesus ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel Could the dev-environment be more appliancey? How about a shell-script/recipe to automate environment setup, or publishing a kickstart for installation of a dev-environment in a virtual machine (with just the virt-install command and kickstart, you should be good to go)? One problem is grabbing the Oracle bits, for now, so that may have to be a one-off, but everything else, perhaps... The appliance idea is a decent one, and worth adding to the list of dev setups. I personally use a virt guest to do my development in. I wouldn't want the appliance to be the only way of dev setup. A great idea though. jesus ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Couple of questions
Coe, Colin C. (Unix Engineer) wrote:
Hi Partha,
Many thanks for the tip but please, is this a Java'ism or did I miss this in
the code?
Basically I looked at the ConfigContent.java and saw a
getContentsString method. The jsp el expressions want beanified names..
so in the jsp you'd strip out the 'get'..
Now I get the actual contents of existing files! Yay! Problem now is any
updates/changes to existing files are not saved and any new files created via Add
Files - Create File are empty. What do I need to do to manually populate the
textarea 'contents'?
Just curious what is special about this editor... Your problem could be
that the dyna form may not be working right as in the contents textarea
may not be getting translated correctly ... try
textarea name=contents rows=20 cols=80 id=contents...
instead of
textarea property=contents
Thanks again.
CC
From: spacewalk-devel-boun...@redhat.com [spacewalk-devel-boun...@redhat.com]
On Behalf Of Partha Aji [p...@redhat.com]
Sent: Monday, 5 January 2009 7:07 PM
To: spacewalk-devel@redhat.com
Subject: Re: [Spacewalk-devel] Couple of questions
Hey Colin,
Coe, Colin C. (Unix Engineer) wrote:
Hi all
First up, I'm working on a patch to add a 'nicer' editor to replace textareas
in specific places (Kickstart pre/post scripts and config file creatation and
editing). The problem I'm having is when I change
html:textarea property=contents rows=20 cols=80 /br /
to
textarea property=contents rows=20 cols=80
id=contents${revision.configContent}/textareabr /
in
java/code/webapp/WEB-INF/pages/common/fragments/configuration/channel/create.jspf,
I get the following displayed in the textarea and the newly created file is
empty.
com.redhat.rhn.domain.config.configcont...@21f3ee79[id=6,fileSize=0,md5sum=d41d8cd98f00b204e9800998ecf8427e,isBinary=false,contentsBlob=null,created=2009-01-05
08:31:30.0,modified=2009-01-05 08:31:30.0]
I realise that ${revision.configContent} is giving me the complete object, how
do I just what is contained in 'contentsBlob'? i.e. the file data rather than
the meta data. I've tried ${revision.configContent.contentsBlob} and
${revision.contentsBlob}, both give me tomcat errors.
Can 't you use ${revision.configContent.contentsString} ??
Partha
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
NOTICE: This email and any attachments are confidential.
They may contain legally privileged information or
copyright material. You must not read, copy, use or
disclose them without authorisation. If you are not an
intended recipient, please contact us at once by return
email and then delete both messages and all attachments.
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Couple of questions
Hey Colin,
Coe, Colin C. (Unix Engineer) wrote:
Hi all
First up, I'm working on a patch to add a 'nicer' editor to replace textareas in specific places (Kickstart pre/post scripts and config file creatation and editing). The problem I'm having is when I change
html:textarea property=contents rows=20 cols=80 /br /
to
textarea property=contents rows=20 cols=80
id=contents${revision.configContent}/textareabr /
in
java/code/webapp/WEB-INF/pages/common/fragments/configuration/channel/create.jspf,
I get the following displayed in the textarea and the newly created file is
empty.
com.redhat.rhn.domain.config.configcont...@21f3ee79[id=6,fileSize=0,md5sum=d41d8cd98f00b204e9800998ecf8427e,isBinary=false,contentsBlob=null,created=2009-01-05
08:31:30.0,modified=2009-01-05 08:31:30.0]
I realise that ${revision.configContent} is giving me the complete object, how
do I just what is contained in 'contentsBlob'? i.e. the file data rather than
the meta data. I've tried ${revision.configContent.contentsBlob} and
${revision.contentsBlob}, both give me tomcat errors.
Can 't you use ${revision.configContent.contentsString} ??
Partha
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] kickstartTreeHandler
Yeah I realized it was new in sw 0.4 ... Thats why I changed it :) ... Partha Mike McCune wrote: Jesus M. Rodriguez wrote: It's the right thing to do. /me hates having wordy method names when the namespaces should be enough. Good job. On Thu, Dec 11, 2008 at 10:33 PM, Partha Aji p...@redhat.com wrote: Thanks zeus :) .. I had the right intentions but I wonder if I was being a bit naive here.. Hopefully qa automation tests that were written for this are easy enough to change ,... If thats too much to change feel free to revert Partha this handler is new in 0.4 so I doubt anything has been written for that API yet... As long as you left the old one alone in KickstartHandler, we should be fine. Mike ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] New script to clear cobbler distros/profiles/system records
http://git.fedorahosted.org/git/spacewalk.git?p=spacewalk.git;a=blob;f=scripts/cobbler-clear ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Schema change needed
Another schema change needed (Re)Apply this file.. Makes the necessary change to get kickstart working.. 139-rhnKickstartableTrees.sql from $GIT_DIR/schema/spacewalk/upgrades/spacewalk-0.3-spacewalk-0.4/ and you should be good. Partha Justin Sherrill wrote: Another schema change needed, so you will probably need to update your DBs: (Re)Apply these two files: 137-rhnKickstartableTree.sql 112-rhnKSData-drop-name.sql from $GIT_DIR/schema/spacewalk/upgrades/spacewalk-0.3-spacewalk-0.4/ and you should be good. -Justin ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Spacewalk 0.4 update
Mike McCune wrote: Jesus M. Rodriguez wrote: Hey Spacewalk hackers, I'd like to wrap up feature and bug fixing by 12/5 so that we can start the package building process on Monday 12/8 for a release on 12/15. Let me know if this will be a problem. Feature freeze: 12/5 Packages: 12/9 QA freeze: 12/12 Release: 12/15 I'm thinking since the scope of features in 0.4 is much much larger than the previous releases we are going to need to spend more time in testing (multiorg and cobbler-koan come to mind) I'd advocate we instead release a QA build to the public on 12/15 and do the final release on say ... 12/22? Or after the break? I realize I'm calling for us to be late but it seems rational to me. Anyone else agree/disagree? +1. The cobbler koan feature will require significant testing w.r.t provisioning especially. 12/15 release at this point seems a bit too optimistic IMHO. ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] localization?
Zeus, Its a part of satsync. When you satsync it'll automatically sync ks trees to cobbler. Partha Jesus M. Rodriguez wrote: Partha, Is this script something that will need to be run during upgrades or just a dev util? If something the user will be using are we going to localize it? http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=b65ce694610b4bf8f4c8b792d7b8b24c1436821c jesus ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] spacewalk-cobber integration in main
On schema updater I thought I did a rename Oh well lemme delete the one in java/scripts ... Totally agree that spacewalk-schema-upgrade is the way to upgrade the thing officially.. Well schema-updater is just for more fine grained stuff.. Like Upgrade scripts starting from specific number and above.. Its useful only during devel phases as devs keep adding one table at a time... But sounds like the same can be achieved as Jan says by creating a directory and symlinking exactly the files you want updated (me doesn't think straighforwardly like that unfortunately :( ). So every one use the official one the one under schema upgrade directory as its more robust.. Jan is there documentation on the usage :).. Partha Jan Pazdziora wrote: On Thu, Oct 30, 2008 at 11:22:06AM -0700, Mike McCune wrote: For any development setups you will need to do the following: 1) Apply the following schema updates: spacewalk/scripts: ./schema-updater --connect=your db connect string --dir=/home/mmccune/devel/spacewalk/schema/spacewalk/upgrade/spacewalk-0.3-spacewalk-0.4/ --start=111 By the way, why do we have the exact same script in spacewalk/java/scripts/schema-updater as well? Shouldn't we keep one copy of that script, only, to avoid confusion? I further wonder why not to use the spacewalk-schema-upgrade script. I know that schema-updater was supposed to be more feature rich, but: you should be able to achieve the start / end behaviour with spacewalk-schema-upgrade by creating new directory with symlinks, and more importantly: we expect our users to use spacewalk-schema-upgrade to upgrade their Spacewalk Servers, and expect our customers to use it to upgrade their Satellites. Any testing or improvements we can give to spacewalk-schema-upgrade will bring benefits to our users and customers. Could we try to eat our own dog food? ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Java 6 or Java 5? for spacewalk
Thanks Jan :)... Changed my project settings to Java 5 :) Jan Pazdziora wrote: On Sun, Oct 12, 2008 at 02:55:11AM -0400, Partha Aji wrote: Recently I caused a couple of compile errors on Spacewalk... Basically my eclipse project has the compiler setting = Java 6. As a side effect of this when I have a class implement an interface the @Override tag gets inserted automatically.. Now this is perfectly good for java 6 or open jdk, but java 5 it breaks :(. Considering that we are shipping our current jars using stuff compiled with open jdk, is there any point in ensuring compatibility with java 5?... You want to be able to compile the thing with 1.5.0 and not rely on 1.6.0 because there is no s390x version of EPEL 5. If you mandate the use of 1.6.0, you will make it harder for Red Hat when they decide to build Satellite out of Spacewalk. ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Added a new Session Set
I added to Spacewalk 0.3 a sessionset. Basically these are an alternative to RhnSets and must replace them for 90% of the cases... For more info... https://fedorahosted.org/spacewalk/wiki/ListTag#SessionSet Basic advantages over our traditional Rhnsets 1) Uses a session lifecyle.. So when the session dies the checkbox selections the user makes dies with it.. 2) Flexible keying.. Certain lists need more than 2 keys to uniquely identify each row.. With the previous db set you were stuck with max 2 keys problem... With the new Session sets we use a simple string that can be as big as we want as the key. Given this nature one can conceive of using keys like id1|id2|id3 or even some sort of json like notation, and embed multiple keys (even though that may look overengineered). What the key means to the world is upto the DTO and ActionManager itself.. The tag does not assume any particualr format... 3) Its more minimalist than the rhnSet, in the sense it uses java.util.Set no fancy RhnSetManager, RhnSet, RhnSetElement, RhnSetDecl, SetCleanup, keys are just simple strings ... You write code as if you are dealing with a regular set.. Disadvantages: 1) Needs the new list tag.. Basically the older list tag made the taglibs responsible for set handling making it really hard to work it out there.. 2) If the set you populate this page is needed by a Perl page you have no option but to go with RhnSet... Other Observations: If your set is needed by another action that is expecting the RhnSet, then you 'd either need to change that also to use the session set.. For example we have these confirm pages.. The confirm pages share a set with the list pages.. So we must just make sure confirm page points to the same declaration label Look at the wiki page.. Feel free to ask questions on this... https://fedorahosted.org/spacewalk/wiki/ListTag#SessionSet Partha ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
