DO NOT REPLY [Bug 18698] New: - Exception message in JNDI realm is not Socket closed on different ldap implementations
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18698.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18698
Exception message in JNDI realm is not Socket closed on different ldap
implementations
Summary: Exception message in JNDI realm is not Socket closed
on different ldap implementations
Product: Tomcat 4
Version: 4.1.24
Platform: All
OS/Version: All
Status: NEW
Severity: Blocker
Priority: Other
Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
JDNIRealm.java:
public Principal authenticate(String username, String credentials) {
...
// If not a Socket closed. error then rethrow.
if (e.getMessage().indexOf(Socket closed) 0)
throw(e);
Socket closed is not the message I got, but connection closed. It is not a
good way to check the message of a exception and react on it. Please just remove
this two lines of code and try connect again, this will fix the problem
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Help on mod_jk for tomcat 4.0.x + httpd 2.0.40 on RedHat 8.0
Prasanth S wrote: Henri, I have autmake 1.6.3 , libtool 1.4.2, autoconf 2.53 I usually run ./buildconf before running the ./configurecommand. Just use configure which should be ready for you - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18658] - HTTP 404 when welcome-file doesn't exist but servlet-mapping exists
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18658. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18658 HTTP 404 when welcome-file doesn't exist but servlet-mapping exists [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 09:47 --- This is not clearly defined in the old Servlet specification, and will not be fixed in Tomcat 4.1.x. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18650] - Exception while processing a JAR file
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18650. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18650 Exception while processing a JAR file [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 09:49 --- The more likely is that there's somehow something wrong with that JAR. Sorry, but given the amount of usage 4.1.18 has gone through already, it is unlikely there's a bug there in Tomcat. If you think otherwise, attach a valid test JAR. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18650] - Exception while processing a JAR file
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18650. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18650 Exception while processing a JAR file [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME | --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 09:54 --- I tried installing the application with Tomcat 4.1.18 (with JDK 1.4.1) now it works fine. In the previous case i used JDK 1.3.1, does the version of JDK have any effect. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18650] - Exception while processing a JAR file
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18650. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18650 Exception while processing a JAR file [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 10:13 --- I don't know. This works fine for me. Please attach a test case (I doubt you can find a valid one). FYI, ContextConfig has zero changes between 4.1.18 and 4.1.24. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18650] - Exception while processing a JAR file
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18650. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18650 Exception while processing a JAR file [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME | --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 10:17 --- My question was regarding the ver. of JDK..does the version of JDK have any impact in this. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18701] New: - Broken Pipe exceptions thrown by StandardWrapperValve
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18701. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18701 Broken Pipe exceptions thrown by StandardWrapperValve Summary: Broken Pipe exceptions thrown by StandardWrapperValve Product: Tomcat 4 Version: 4.1.18 Platform: Sun OS/Version: Solaris Status: NEW Severity: Major Priority: Other Component: Connector:Coyote HTTP/1.1 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The following exception keeps getting thrown and caught repeatedly. Please could you give me a solution or workaround to this problem. Thanks Rob Godley 2003-04-04 04:55:12 StandardWrapperValve[default]: Servlet.service() for servlet default threw exception java.io.IOException: Broken pipe at java.net.SocketOutputStream.socketWrite(Native Method) at java.net.SocketOutputStream.write(SocketOutputStream.java:83) at org.apache.coyote.http11.InternalOutputBuffer$OutputStreamOutputBuffer.doWrite (InternalOutputBuffer.java:668) at org.apache.coyote.http11.filters.IdentityOutputFilter.doWrite (IdentityOutputFilter.java:160) at org.apache.coyote.http11.InternalOutputBuffer.doWrite (InternalOutputBuffer.java:523) at org.apache.coyote.Response.doWrite(Response.java:524) at org.apache.coyote.tomcat4.OutputBuffer.realWriteBytes (OutputBuffer.java:384) at org.apache.tomcat.util.buf.ByteChunk.flushBuffer(ByteChunk.java:360) at org.apache.tomcat.util.buf.ByteChunk.append(ByteChunk.java:338) at org.apache.coyote.tomcat4.OutputBuffer.writeBytes (OutputBuffer.java:411) at org.apache.coyote.tomcat4.OutputBuffer.write(OutputBuffer.java:398) at org.apache.coyote.tomcat4.CoyoteOutputStream.write (CoyoteOutputStream.java:110) at org.apache.catalina.servlets.DefaultServlet.copyRange (DefaultServlet.java:1996) at org.apache.catalina.servlets.DefaultServlet.copy (DefaultServlet.java:1745) at org.apache.catalina.servlets.DefaultServlet.serveResource (DefaultServlet.java:1073) at org.apache.catalina.servlets.DefaultServlet.doGet (DefaultServlet.java:506) at javax.servlet.http.HttpServlet.service(HttpServlet.java:740) at javax.servlet.http.HttpServlet.service(HttpServlet.java:853) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter (ApplicationFilterChain.java:247) at org.apache.catalina.core.ApplicationFilterChain.doFilter (ApplicationFilterChain.java:193) at org.apache.catalina.core.StandardWrapperValve.invoke (StandardWrapperValve.java:260) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardContextValve.invoke (StandardContextValve.java:191) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardContext.invoke (StandardContext.java:2415) at org.apache.catalina.core.StandardHostValve.invoke (StandardHostValve.java:180) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.valves.ErrorDispatcherValve.invoke (ErrorDispatcherValve.java:170) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.valves.ErrorReportValve.invoke (ErrorReportValve.java:172) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardEngineValve.invoke (StandardEngineValve.java:174) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.coyote.tomcat4.CoyoteAdapter.service (CoyoteAdapter.java:223) at org.apache.coyote.http11.Http11Processor.process
DO NOT REPLY [Bug 18701] - Broken Pipe exceptions thrown by StandardWrapperValve
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18701. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18701 Broken Pipe exceptions thrown by StandardWrapperValve [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 10:26 --- There is no problem, and this is a dupe of many many other reports. Please do not reopen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18701] - Broken Pipe exceptions thrown by StandardWrapperValve
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18701. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18701 Broken Pipe exceptions thrown by StandardWrapperValve --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 10:35 --- Please send me references to the resolution, I'd like to stop my log files from growing. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18701] - Broken Pipe exceptions thrown by StandardWrapperValve
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18701. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18701 Broken Pipe exceptions thrown by StandardWrapperValve --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 10:41 --- Either do a search in the lists or bugzilla. This is fixed in 4.1.24. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[GUMP] Build timed out - jk2
This email is autogenerated from the output from:
http://cvs.apache.org/builds/gump/2003-04-04/jakarta-tomcat-jk-native2.html
Buildfile: build.xml
init.taskdef:
guess.os:
[echo] build.properties i386.Linux
[echo] Linux:true Win32:${win32} Netware:${netware} Solaris:${solaris}
HPUX:${hpux}
init.win32.properties:
init.win32.mc:
init.win32:
init.netware:
init.os:
guess.server:
[echo] Apache2 /usr/local/apache2 true
[echo] Apache13 /usr true
[echo] IIS ${iis.home} ${iis.detect}
[echo] Iplanet ${iplanet.home} ${iplanet.detect}
[echo] JNI true
init:
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk2
apache20:
[mkdir] Created dir:
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk2/apache2
[so] Compiling 42 out of 42
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_channel_jni.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_channel.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_logger_file.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_env.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_channel_apr_socket.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_channel_socket.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_channel_un.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_config.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_config_file.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_endpoint.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_handler_response.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_handler_logon.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_logger_win32.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_msg_ajp.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_map.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_md5.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_mutex_proc.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_mutex.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_mutex_thread.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_nwmain.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_objCache.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_pool.c
[so] Warnings:
[so] /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_pool.c:
In function `jk2_pool_a_strdup':
[so]
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_pool.c:282:
warning: empty body in an if-statement
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_pool_apr.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_registry.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_requtil.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_shm.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_signal.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_uriEnv.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_uriMap.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_user.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_vm_default.c
[so] Warnings:
[so]
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_vm_default.c:449:77:
warning: backslash and newline separated by space
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_workerEnv.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_worker_ajp13.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_worker_jni.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_worker_lb.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_worker_run.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/common/jk_worker_status.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/server/apache2/jk_logger_apache2.c
Compiling
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native2/server/apache2/jk_map_aprtable.c
Compiling
[GUMP] Build timed out - jk
This email is autogenerated from the output from:
http://cvs.apache.org/builds/gump/2003-04-04/jakarta-tomcat-jk-native.html
Buildfile: build.xml
init:
[echo] /home/rubys
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk
[echo] linux=true solaris=${solaris} win32=${win32} hpux=${hpux}
netware=${netware}
apache20:
apache13:
iis:
netscape:
jni:
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk/jni
[so] Compiling 4 out of 4
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common/jk_map.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common/jk_pool.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common/jk_util.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/jni/jk_jnicb.c
Linking /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk/jni/jni_connect.so
/home/rubys/bin/timeout: timed out
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18571] - jk/native/common: stray '\' won't compile: gcc 2.95.{2,3}
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18571.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18571
jk/native/common: stray '\' won't compile: gcc 2.95.{2,3}
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution||INVALID
--- Additional Comments From [EMAIL PROTECTED] 2003-04-04 12:56 ---
It works for me with gcc 2.96.
Making the define fit on a single line will brake Apache edit recommandation...
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18571] - jk/native/common: stray '\' won't compile: gcc 2.95.{2,3}
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18571.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18571
jk/native/common: stray '\' won't compile: gcc 2.95.{2,3}
--- Additional Comments From [EMAIL PROTECTED] 2003-04-04 13:02 ---
gcc 2.96 was only shipped on RedHat machines, if i recall correctly. It is not in
general use, in
any case. Most Linux distros skipped from 2.95.3 to 3.x.
In any case, which is worse: breaking apache's recomendation or breaking the compile
process?
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18706] New: - HTTPS gets changed to HTTP://servername:443
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18706. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18706 HTTPS gets changed to HTTP://servername:443 Summary: HTTPS gets changed to HTTP://servername:443 Product: Tomcat 4 Version: 4.1.24 Platform: PC URL: https://probtest.iwka.de OS/Version: Linux Status: NEW Severity: Critical Priority: Other Component: Connector:Coyote HTTP/1.1 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] We have external SSL accelerator hardware in front of standalone tomcat servers which do the encryption from HTTPS to HTTP. Our connector definition looks like this: Connector className=org.apache.coyote.tomcat4.CoyoteConnector port=80 minProcessors=10 maxProcessors=100 enableLookups=false redirectPort=443 scheme=https acceptCount=10 debug=0 connectionTimeout=3 secure=true proxyPort=443 / When I call our site with https://probtest.iwka.de the url ist changed to http://probtest.iwka.de:443/index.html. And then our application doesn't work. If I call https://probtest.iwka.de/index.html (with /index.html) then all works without any problems! Also with the old HTTP11 Connector it works. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.c
hgomez 2003/04/04 05:27:43
Modified:jk/native/common jk_ajp_common.c
Log:
Fix problem reported by bugzilla 18571...
Revision ChangesPath
1.36 +2 -2 jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c
Index: jk_ajp_common.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- jk_ajp_common.c 14 Mar 2003 13:36:35 - 1.35
+++ jk_ajp_common.c 4 Apr 2003 13:27:43 - 1.36
@@ -1572,7 +1572,7 @@
unsigned elapsed = (unsigned)(now-ae-last_access);
if (elapsed aw-cache_timeout) {
jk_log(l, JK_LOG_DEBUG,
-In jk_endpoint_t::ajp_get_endpoint, \
+In jk_endpoint_t::ajp_get_endpoint,
cleaning cache slot = %d elapsed %d\n,
i, elapsed);
ajp_close_endpoint(aw-ep_cache[i], l);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18571] - jk/native/common: stray '\' won't compile: gcc 2.95.{2,3}
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18571.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18571
jk/native/common: stray '\' won't compile: gcc 2.95.{2,3}
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--- Additional Comments From [EMAIL PROTECTED] 2003-04-04 13:46 ---
Well I build JK on Redhat 6.2, 7.2 and 8.0 using gcc 2.91.66, 2.96 and 3.x.
I fixed the problem in jk_ajp_common.c but in jk_md5.c the multi defs are valid.
This code came from Apache HTTP server (1.3.x) and I didn't see error reports
with it.
BTW, if you're using Apache Web server you don't need this code, just define
USE_APACHE_MD5...
Regards
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 13172] - Port incorrect in getServerPort and in access log
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13172. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13172 Port incorrect in getServerPort and in access log [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|NEW --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 14:15 --- I'm trying a reassign to see if that gets any action. Why this bug fix is important: For messaging components, we use a non- standard port to force mutual certificate authentication. The code must make a check to verify it's on the correct port to be assured the authentication has occurred. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18545] - can not upload a file size greater than 2 G on tomcat4/linux
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18545. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18545 can not upload a file size greater than 2 G on tomcat4/linux [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 16:19 --- I assume you are referring to the example webapp 'struts-upload.war' included with the Struts binary distribution: In the config file 'struts-config.xml' you can find the following entry: ... !-- This is where you set the maximum file size for your file uploads. -1 is an unlimited size. If you don't specify this here, it defaults to -1. -- controller maxFileSize=2M / ... This limits the filesize to a maximum of 2 MB. Try changing this value to allow for bigger uploads. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
FW: JSPC for TOMCAT 4.124 generates unexpected internal error
I'm doing a simple test to compile the checkbox JSP from the TOMCAT examples with the -webinc switch The JAVA and XML files are properly generates but jasper complains (unexpectedly ) that the web.xml file is no found here is the output fragment: 2003-04-04 04:21:34 - uriRoot implicitly set to /dsa1/apache/jakarta/tomcat/web apps/examples 2003-04-04 04:21:34 - Internal Error: File /WEB-INF/web.xml not found 2003-04-04 04:21:34 - Class name is: checkresult 2003-04-04 04:21:34 - Java file name is: /dsa1/apache/jakarta/tomcat/webapps/exa mples/jsp/checkbox/checkresult.java 2003-04-04 04:21:34 - Accepted org.apache.jasper.compiler.Parser$Declaration at /checkresult.jsp(8,0) 2003-04-04 04:21:34 - Accepted org.apache.jasper.compiler.Parser$Bean at /checkr esult.jsp(9,0) 2003-04-04 04:21:35 - Accepted org.apache.jasper.compiler.Parser$SetProperty at /checkresult.jsp(11,0) 2003-04-04 04:21:35 - Accepted org.apache.jasper.compiler.Parser$Scriptlet at /c heckresult.jsp(14,0) 2003-04-04 04:21:35 - Accepted org.apache.jasper.compiler.Parser$Scriptlet at /c heckresult.jsp(18,0) 2003-04-04 04:21:35 - Accepted org.apache.jasper.compiler.Parser$Scriptlet at /c heckresult.jsp(23,0) 2003-04-04 04:21:35 - Accepted org.apache.jasper.compiler.Parser$Scriptlet at /c heckresult.jsp(34,0) 2003-04-04 04:21:35 - Accepted org.apache.jasper.compiler.Parser$Scriptlet at /c heckresult.jsp(38,0) 2003-04-04 04:21:35 - Accepted org.apache.jasper.compiler.Parser$Scriptlet at /c heckresult.jsp(43,0) 2003-04-04 04:21:35 - Compiling with: -encoding UTF8 -classpath /sys$common/java $140/lib/tools.jar:/dsa1/apache/jakarta/tomcat/bin/bootstrap.jar:.:/dsa1/apache/ jakarta/tomcat/lib/jasper-compiler.jar:/dsa1/apache/jakarta/tomcat/lib/jasper-ru ntime.jar:/dsa1/apache/jakarta/tomcat/lib/naming-factory.jar:/dsa1/apache/jakart a/tomcat/common/lib/activation.jar:/dsa1/apache/jakarta/tomcat/common/lib/ant.ja r:/dsa1/apache/jakarta/tomcat/common/lib/commons-collections.jar:/dsa1/apache/ja karta/tomcat/common/lib/commons-dbcp.jar:/dsa1/apache/jakarta/tomcat/common/lib/ commons-logging-api.jar:/dsa1/apache/jakarta/tomcat/common/lib/commons-pool.jar: /dsa1/apache/jakarta/tomcat/common/lib/jasper-compiler.jar:/dsa1/apache/jakarta/ tomcat/common/lib/jasper-runtime.jar:/dsa1/apache/jakarta/tomcat/common/lib/jdbc 2_0-stdext.jar:/dsa1/apache/jakarta/tomcat/common/lib/jndi.jar:/dsa1/apache/jaka rta/tomcat/common/lib/jta-spec1_0_1.jar:/dsa1/apache/jakarta/tomcat/common/lib/j ta.jar:/dsa1/apache/jakarta/tomcat/common/lib/mail.jar:/dsa1/apache/jakarta/tomc at/common/lib/naming-common.jar:/dsa1/apache/jakarta/tomcat/common/lib/naming-fa ctory.jar:/dsa1/apache/jakarta/tomcat/common/lib/naming-resources.jar:/dsa1/apac he/jakarta/tomcat/common/lib/servlet.jar:/dsa1/apache/jakarta/tomcat/common/lib/ tyrex-0.9.7.0.jar:/dsa1/apache/jakarta/tomcat/common/lib/xerces.jar:/sys$common/ java$140/lib/tools.jar:/dsa1/apache/jakarta/tomcat/bin/bootstrap.jar:.:/dsa1/apa che/jakarta/tomcat/lib/jasper-compiler.jar:/dsa1/apache/jakarta/tomcat/lib/jaspe r-runtime.jar:/dsa1/apache/jakarta/tomcat/lib/naming-factory.jar:/dsa1/apache/ja karta/tomcat/common/lib/activation.jar:/dsa1/apache/jakarta/tomcat/common/lib/an t.jar:/dsa1/apache/jakarta/tomcat/common/lib/commons-collections.jar:/dsa1/apach e/jakarta/tomcat/common/lib/commons-dbcp.jar:/dsa1/apache/jakarta/tomcat/common/ lib/commons-logging-api.jar:/dsa1/apache/jakarta/tomcat/common/lib/commons-pool. jar:/dsa1/apache/jakarta/tomcat/common/lib/jasper-compiler.jar:/dsa1/apache/jaka rta/tomcat/common/lib/jasper-runtime.jar:/dsa1/apache/jakarta/tomcat/common/lib/ jdbc2_0-stdext.jar:/dsa1/apache/jakarta/tomcat/common/lib/jndi.jar:/dsa1/apache/ jakarta/tomcat/common/lib/jta-spec1_0_1.jar:/dsa1/apache/jakarta/tomcat/common/l ib/jta.jar:/dsa1/apache/jakarta/tomcat/common/lib/mail.jar:/dsa1/apache/jakarta/ tomcat/common/lib/naming-common.jar:/dsa1/apache/jakarta/tomcat/common/lib/namin g-factory.jar:/dsa1/apache/jakarta/tomcat/common/lib/naming-resources.jar:/dsa1/ apache/jakarta/tomcat/common/lib/servlet.jar:/dsa1/apache/jakarta/tomcat/common/ lib/tyrex-0.9.7.0.jar:/dsa1/apache/jakarta/tomcat/common/lib/xerces.jar -d /dsa1 /apache/jakarta/tomcat/webapps/examples/jsp/checkbox /dsa1/apache/jakarta/tomcat /webapps/examples/jsp/checkbox/checkresult.java Check the web.xml file is really there: bash$ pwd /dsa1/apache/jakarta/tomcat/webapps/examples/web-inf bash$ ls classes jsp web.xml bash$ OK, spurious or normal behaviour ? thanks in advance Marc Dufresne OpenVMS Ambassador Pre-Sales Large Accounts HP France tel: + 33.1.5762.5413 mob: + 33.6 7498 5608 fax: +33 1 5762.7630 e-mail : [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Connector issues
Jeff Tulley wrote: I think I've got a fix for the connector thing, gotta still try it out to be sure. I just thought that the mbeans-descriptors fix is low hanging fruit. IE, with just a simple little fix, every time somebody is forced to go back to the old connector for one reason or another, they won't immediately come back to the list with the complaint of I'm getting the following exception. I had been in favor of making the exception look nicer (but got vetoed by Craig way back then). OTOH, I am against adding the declaration in the descriptors, which would make it sound the thing is supported. The AJP 1.3 connector is based on the code from the old HTTP/1.1 connector, which likely had issues in its thread pool (in addition to being very wasteful GC wise). I strongly advise against using it. But if an upgrade to commons-modeler would also fix the problem without changing deprecated code, I'm all for doing that instead. Let me go check out my code changes to CoyoteRequest, see how they work... Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Patch] Coyote losing parameters across form login (wasRe: Connectorissues)
Which? All of them? I had 3 attachments with the extension .patch (I could rename to .txt, though .patch has worked in the past I thought). And, 1 zip file that I renamed to test.zip.txt Please let me know which if any were visible, and the best way to send a zip file. Jeff Tulley ([EMAIL PROTECTED]) (801)861-5322 Novell, Inc., The Leading Provider of Net Business Solutions http://www.novell.com [EMAIL PROTECTED] 4/4/03 9:27:05 AM Jeff Tulley wrote: here is the code, please review 3 of them are patches for existing source code. test.zip (.txt, I couldn't remember if the mailing list strips off zip files) is a new junit TestCase to test my stuff in Parameters.java. I propose that be put in j-t-c/util/test, unless there is a better place. I don't know if there is a better way to submit a new directory via CVS since I cannot diff -u it. CoyoteRequest.java and Request.java fixes are very straightforward, just doing the same sort of thing that is done in the rest of the code. Parameters.java is where I took an already existing (private) method, made a copy of it, renamed and made the copy public, and then adapted it to work with multi-valued parameters. This seems to do the job correctly. The attachement doesn't work for me. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cant connect to cvs.apache.org
on SSH port 22 where do we report problems like this? Is anyone else experiencing it? Filip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18706] - HTTPS gets changed to HTTP://servername:443
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18706. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18706 HTTPS gets changed to HTTP://servername:443 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 18:35 --- *** This bug has been marked as a duplicate of 17656 *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17656] - scheme and secure Connector server.xml configuration attributes ignored by CoyoteConnector HTTP/1.1
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17656. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17656 scheme and secure Connector server.xml configuration attributes ignored by CoyoteConnector HTTP/1.1 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 18:35 --- *** Bug 18706 has been marked as a duplicate of this bug. *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk build.properties.sample
mmanders2003/04/04 11:02:34
Modified:jk build.properties.sample
Log:
Added additional paths necessary for building NetWare connectors.
Revision ChangesPath
1.16 +7 -1 jakarta-tomcat-connectors/jk/build.properties.sample
Index: build.properties.sample
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/build.properties.sample,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- build.properties.sample 17 Oct 2002 18:18:48 - 1.15
+++ build.properties.sample 4 Apr 2003 19:02:34 - 1.16
@@ -45,9 +45,15 @@
so.profile=false
# tools for other directories
-# Metrowerks and novel ndk
+# Metrowerks and Novell ndk
#mw.home=d:/tools/mw/6.0
#novellndk.home=d:/tools/novell/ndk/nwsdk
+#novelllibc.home=d:/tools/novell/ndk/libc
+#build.compiler.base=${mw.home}
+#build.compiler.cc=${mw.home}/bin/mwccnlm
+#build.compiler.ld=${mw.home}/bin/mwldnlm
+#netscape.home=${iplanet.home}
+#option_no_reuse_worker=true
# MSVC
#mssdk.home=c:/Program Files/Microsoft Visual Studio/VC98
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Patch] Coyote losing parameters across form login (was Re: Connectorissues)
Jeff Tulley wrote: Which? All of them? I had 3 attachments with the extension .patch (I could rename to .txt, though .patch has worked in the past I thought). And, 1 zip file that I renamed to test.zip.txt Please let me know which if any were visible, and the best way to send a zip file. The .zip is not valid, and the 3 other attachements are not there. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Patch] Coyote losing parameters across form login (wasRe: Connectorissues)
One more try, all files as .txt What is the best way to send a .zip
file?
Actually, I've attached the file that was in the zip as
AddParametersTest.java It should go in
j-t-c/util/test/org/apache/tomcat/util/http Nothing from /test down
currently exists in the util dir.
It looks like my previous submissions on this list also did not show
up. I should have checked more carefully.
I've also attached my patch for the minor type in SoTask.java
Sorry for the mess.
Jeff Tulley ([EMAIL PROTECTED])
(801)861-5322
Novell, Inc., The Leading Provider of Net Business Solutions
http://www.novell.com
[EMAIL PROTECTED] 4/4/03 12:17:48 PM
Jeff Tulley wrote:
Which? All of them? I had 3 attachments with the extension .patch
(I
could rename to .txt, though .patch has worked in the past I
thought).
And, 1 zip file that I renamed to test.zip.txt
Please let me know which if any were visible, and the best way to
send
a zip file.
The .zip is not valid, and the 3 other attachements are not there.
Remy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Index: Request.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Request.java,v
retrieving revision 1.15
diff -u -r1.15 Request.java
--- Request.java19 Sep 2002 06:39:43 - 1.15
+++ Request.java3 Apr 2003 17:28:56 -
@@ -385,6 +385,9 @@
public Parameters getParameters() {
return parameters;
}
+ public void addParameter(String name, String[] values) {
+ parameters.addParameterValues(name, values);
+ }
// Other attributes
Index: Parameters.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/Parameters.java,v
retrieving revision 1.8
diff -u -r1.8 Parameters.java
--- Parameters.java 29 Jun 2002 02:15:02 - 1.8
+++ Parameters.java 3 Apr 2003 17:30:39 -
@@ -336,6 +336,26 @@
paramHashStringArray.put(key, values);
}
+ public void addParameterValues( String key, String[] newValues) {
+ if( key==null ) return;
+ String values[];
+ if (paramHashStringArray.containsKey(key)) {
+ String oldValues[] = (String[])paramHashStringArray.
+ get(key);
+ values = new String[oldValues.length + newValues.length];
+ for (int i = 0; i oldValues.length; i++) {
+values[i] = oldValues[i];
+ }
+ for (int i = 0; i newValues.length; i++) {
+values[i+ oldValues.length] = newValues[i];
+ }
+ } else {
+ values = newValues;
+ }
+
+ paramHashStringArray.put(key, values);
+ }
+
public void setURLDecoder( UDecoder u ) {
urlDec=u;
}
Index: CoyoteRequest.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteRequest.java,v
retrieving revision 1.28
diff -u -r1.28 CoyoteRequest.java
--- CoyoteRequest.java 24 Nov 2002 11:56:15 - 1.28
+++ CoyoteRequest.java 3 Apr 2003 17:28:09 -
@@ -1262,7 +1262,7 @@
* @param values Corresponding values for this request parameter
*/
public void addParameter(String name, String values[]) {
-// Not used
+coyoteRequest.addParameter(name, values);
}
Index: SoTask.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-connectors/jk/jkant/java/org/apache/jk/ant/SoTask.java,v
retrieving revision 1.23
diff -u -r1.23 SoTask.java
--- SoTask.java 9 Jun 2002 00:10:02 - 1.23
+++ SoTask.java 3 Apr 2003 00:19:44 -
@@ -364,7 +364,7 @@
* (XXX including extension - this should be automatically added )
*/
public void setModule(String modName) {
-this.module = module;
+this.module = modName;
}
// XXX Add specific code for Netware, Windows and platforms where libtool
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Patch] Coyote losing parameters across form login (wasRe:Connectorissues)
One more, .java is stripped as well, it appears.
This is the AddParametersTest.java mentioned below. It is now
AddParametersTest.txt
Jeff Tulley ([EMAIL PROTECTED])
(801)861-5322
Novell, Inc., The Leading Provider of Net Business Solutions
http://www.novell.com
[EMAIL PROTECTED] 4/4/03 12:33:26 PM
One more try, all files as .txt What is the best way to send a .zip
file?
Actually, I've attached the file that was in the zip as
AddParametersTest.java It should go in
j-t-c/util/test/org/apache/tomcat/util/http Nothing from /test down
currently exists in the util dir.
It looks like my previous submissions on this list also did not show
up. I should have checked more carefully.
I've also attached my patch for the minor type in SoTask.java
Sorry for the mess.
Jeff Tulley ([EMAIL PROTECTED])
(801)861-5322
Novell, Inc., The Leading Provider of Net Business Solutions
http://www.novell.com
[EMAIL PROTECTED] 4/4/03 12:17:48 PM
Jeff Tulley wrote:
Which? All of them? I had 3 attachments with the extension
.patch
(I
could rename to .txt, though .patch has worked in the past I
thought).
And, 1 zip file that I renamed to test.zip.txt
Please let me know which if any were visible, and the best way to
send
a zip file.
The .zip is not valid, and the 3 other attachements are not there.
Remy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
/*
*
*
* The Apache Software License, Version 1.1
*
* Copyright (c) 2003 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
*notice, this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
*notice, this list of conditions and the following disclaimer in
*the documentation and/or other materials provided with the
*distribution.
*
* 3. The end-user documentation included with the redistribution, if
*any, must include the following acknowlegement:
* This product includes software developed by the
*Apache Software Foundation (http://www.apache.org/).
*Alternately, this acknowlegement may appear in the software itself,
*if and wherever such third-party acknowlegements normally appear.
*
* 4. The names The Jakarta Project, Tomcat, and Apache Software
*Foundation must not be used to endorse or promote products derived
*from this software without prior written permission. For written
*permission, please contact [EMAIL PROTECTED]
*
* 5. Products derived from this software may not be called Apache
*nor may Apache appear in their names without prior written
*permission of the Apache Group.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
*
* This software consists of voluntary contributions made by many
* individuals on behalf of the Apache Software Foundation. For more
* information on the Apache Software Foundation, please see
* http://www.apache.org/.
*
* [Additional notices, if required by prior licensing conditions]
*
*/
package org.apache.tomcat.util.http;
import java.util.Enumeration;
import junit.framework.Assert;
import junit.framework.TestCase;
public class AddParametersTest extends TestCase
{
/**
* Constructor for AddParametersTest.
* @param arg0
*/
public AddParametersTest(String arg0)
{
super(arg0);
}
public static void main(String[] args)
{
junit.textui.TestRunner.run(AddParametersTest.class);
}
public void testAddParameterValuesNullKey()
{
Parameters params = new Parameters();
Enumeration preEnum = params.getParameterNames();
while (preEnum.hasMoreElements())
{
Assert.fail(Should have been empty);
}
params.addParameterValues(null, new String[] {Some Value});
Enumeration
Re: [Patch] Coyote losing parameters across form login (was Re: Connectorissues)
Jeff Tulley wrote: One more try, all files as .txt What is the best way to send a .zip file? Actually, I've attached the file that was in the zip as AddParametersTest.java It should go in j-t-c/util/test/org/apache/tomcat/util/http Nothing from /test down currently exists in the util dir. It looks like my previous submissions on this list also did not show up. I should have checked more carefully. I've also attached my patch for the minor type in SoTask.java Sorry for the mess. Ok, well, I get a chance to review the patch. I don't like it, as it forces some hacks needed for FORM auth (which, FYI, I've always considered to be a bad hack) down the path to the cleaner Coyote objects. I think the patch will need some rework to avoid polluting the API (ie, the dirty code needs to stay in the facade - aka, CoyoteRequest). Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session ReplicatedSession.java
fhanik 2003/04/04 11:43:47
Modified:modules/cluster/src/share/org/apache/catalina/cluster/session
ReplicatedSession.java
Log:
servlet 2.4 spec requires setAttribute to throw an exception if attribute is not
serializable
Revision ChangesPath
1.4 +5 -5
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/ReplicatedSession.java
Index: ReplicatedSession.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/ReplicatedSession.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ReplicatedSession.java18 Mar 2003 05:16:42 - 1.3
+++ ReplicatedSession.java4 Apr 2003 19:43:47 - 1.4
@@ -141,10 +141,10 @@
*/
public void setAttribute(String name, Object value)
{
+if (!(value instanceof java.io.Serializable))
+throw new java.lang.IllegalArgumentException(Value for attribute
+name+ is not serializable.);
setIsDirty(true);
super.setAttribute(name,value);
-if (!(value instanceof java.io.Serializable))
-log(WARNING! Replication will fail, value for attribute +name+ is
not serializable.);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Patch] Coyote losing parameters across form login (was Re: Connectorissues)
Jeff Tulley wrote:
One more try, all files as .txt What is the best way to send a .zip
file?
Actually, I've attached the file that was in the zip as
AddParametersTest.java It should go in
j-t-c/util/test/org/apache/tomcat/util/http Nothing from /test down
currently exists in the util dir.
It looks like my previous submissions on this list also did not show
up. I should have checked more carefully.
I've also attached my patch for the minor type in SoTask.java
Sorry for the mess.
Upon more examination, it seems there's not much choice (unfortunately),
and I'll have to agree on most of the patch.
Index: Request.java
===
RCS file: /home/cvspublic/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Request.java,v
retrieving revision 1.15
diff -u -r1.15 Request.java
--- Request.java 19 Sep 2002 06:39:43 - 1.15
+++ Request.java 3 Apr 2003 17:28:56 -
@@ -385,6 +385,9 @@
public Parameters getParameters() {
return parameters;
}
+ public void addParameter(String name, String[] values) {
+ parameters.addParameterValues(name, values);
+ }
// Other attributes
This is not needed. getParamters().addParameterValues(name, values);
will be used instead (there's no getParamter instead).
Index: Parameters.java
===
RCS file: /home/cvspublic/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/Parameters.java,v
retrieving revision 1.8
diff -u -r1.8 Parameters.java
--- Parameters.java 29 Jun 2002 02:15:02 - 1.8
+++ Parameters.java 3 Apr 2003 17:30:39 -
@@ -336,6 +336,26 @@
paramHashStringArray.put(key, values);
}
+ public void addParameterValues( String key, String[] newValues) {
+ if( key==null ) return;
+ String values[];
+ if (paramHashStringArray.containsKey(key)) {
+ String oldValues[] = (String[])paramHashStringArray.
+ get(key);
+ values = new String[oldValues.length + newValues.length];
+ for (int i = 0; i oldValues.length; i++) {
+values[i] = oldValues[i];
+ }
+ for (int i = 0; i newValues.length; i++) {
+values[i+ oldValues.length] = newValues[i];
+ }
+ } else {
+ values = newValues;
+ }
+
+ paramHashStringArray.put(key, values);
+ }
+
public void setURLDecoder( UDecoder u ) {
urlDec=u;
}
Index: CoyoteRequest.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteRequest.java,v
retrieving revision 1.28
diff -u -r1.28 CoyoteRequest.java
--- CoyoteRequest.java 24 Nov 2002 11:56:15 - 1.28
+++ CoyoteRequest.java 3 Apr 2003 17:28:09 -
@@ -1262,7 +1262,7 @@
* @param values Corresponding values for this request parameter
*/
public void addParameter(String name, String values[]) {
-// Not used
+coyoteRequest.addParameter(name, values);
}
I'll apply the patch. Thanks.
Remy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Patch] Coyote losing parameters across form login(was Re: Connectorissues)
I wondered about that. But, it seemed that CoyoteRequest used the same method throughout the code - for instance on getParameter(String name), it already does a call to coyoteRequest.getParameters().getParameter(name), so I figured I should do the same. the variable coyoteRequest here is a o.a.coyote.Request This same method is also used with getProtocol, get and set ServerName, ServerPort, and with getAttributes. How then do you propose changing this? Other methods in CoyoteRequest keep such things local, but that is difficult with the parameters, since they would presumably exist in the original passed-in Request object. Oh, I see your other email. Yeah, you are seeing the same thing as me. There was a bit of a code smell rewriting that private method in Parameters.java, but it appeared to be the only choice with the way the current code is written. Jeff Tulley ([EMAIL PROTECTED]) (801)861-5322 Novell, Inc., The Leading Provider of Net Business Solutions http://www.novell.com [EMAIL PROTECTED] 4/4/03 12:42:41 PM Jeff Tulley wrote: One more try, all files as .txt What is the best way to send a .zip file? Actually, I've attached the file that was in the zip as AddParametersTest.java It should go in j-t-c/util/test/org/apache/tomcat/util/http Nothing from /test down currently exists in the util dir. It looks like my previous submissions on this list also did not show up. I should have checked more carefully. I've also attached my patch for the minor type in SoTask.java Sorry for the mess. Ok, well, I get a chance to review the patch. I don't like it, as it forces some hacks needed for FORM auth (which, FYI, I've always considered to be a bad hack) down the path to the cleaner Coyote objects. I think the patch will need some rework to avoid polluting the API (ie, the dirty code needs to stay in the facade - aka, CoyoteRequest). Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/jkant/java/org/apache/jk/ant JkData.java
mmanders2003/04/04 12:17:52
Modified:jk/jkant/java/org/apache/jk/ant JkData.java
Log:
Added unless conditional support.
Revision ChangesPath
1.2 +7 -0
jakarta-tomcat-connectors/jk/jkant/java/org/apache/jk/ant/JkData.java
Index: JkData.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/jkant/java/org/apache/jk/ant/JkData.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- JkData.java 7 Nov 2001 23:06:57 - 1.1
+++ JkData.java 4 Apr 2003 20:17:52 - 1.2
@@ -76,6 +76,7 @@
private String value;
private boolean isfile = false;
private String ifCond;
+String unlessCond;
Project project;
@@ -108,9 +109,15 @@
ifCond = s;
}
+public void setUnless( String s ) {
+unlessCond = s;
+}
+
public String getValue()
{
if( ifCond!=null project.getProperty(ifCond) == null )
+return null;
+if (unlessCond != null project.getProperty(unlessCond) != null)
return null;
return value;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c
mmanders2003/04/04 12:26:21
Modified:jk/native/apache-2.0 mod_jk.c
Log:
Updated to build correctly for NetWare.
Revision ChangesPath
1.70 +11 -7 jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c
Index: mod_jk.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v
retrieving revision 1.69
retrieving revision 1.70
diff -u -r1.69 -r1.70
--- mod_jk.c 2 Apr 2003 22:48:01 - 1.69
+++ mod_jk.c 4 Apr 2003 20:26:20 - 1.70
@@ -510,10 +510,10 @@
s-server_name = (char *)ap_get_server_name(r);
/* get the real port (otherwise redirect failed) */
-/* apr_sockaddr_port_get(port,r-connection-local_addr); */
-/* s-server_port = port; */
-/* XXX : Ã la jk2 */
- s-server_port = ap_get_server_port(r);
+apr_sockaddr_port_get(port,r-connection-local_addr);
+s-server_port = port;
+/* XXX : Ã la jk2 ???*/
+ /* s-server_port = ap_get_server_port(r); */
s-server_software = (char *)ap_get_server_version();
@@ -1880,7 +1880,11 @@
map_free(conf-automount);
if (conf-uw_map)
uri_worker_map_free(conf-uw_map, conf-log);
-jk_close_file_logger(conf-log);
+/* Since we are now using apache to do logging, this
+ * cleanup will just cause problems so don't do it
+ *
+ * jk_close_file_logger(conf-log);
+ */
}
s = s-next;
}
@@ -2023,7 +2027,7 @@
return overrides;
}
-static int jk_log_to_file(jk_logger_t *l,
+static int JK_METHOD jk_log_to_file(jk_logger_t *l,
int level,
const char *what)
{
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native build.xml
mmanders2003/04/04 12:29:21
Modified:jk/native build.xml
Log:
Since NetWare is built (cross-compiled) on Windows, I had to add logic to know if we
are actually targeting Windows or NetWare. If novellndk.home is defined and the path
actually exists, we assume NetWare.
Revision ChangesPath
1.38 +86 -86jakarta-tomcat-connectors/jk/native/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/build.xml,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- build.xml 18 Feb 2003 17:53:57 - 1.37
+++ build.xml 4 Apr 2003 20:29:21 - 1.38
@@ -97,12 +97,12 @@
include name=${build.compiler.base}/include /
!-- Platform specific includes --
- include name=${novellndk.dir}/include/nlm if=netware /
- include name=${novellndk.dir}/include if=netware /
+ include name=${novellndk.home}/include/nlm if=netware /
+ include name=${novellndk.home}/include if=netware /
include name=${java.home}/../include/netware if=netware /
include name=${java.home}/../include/hp-ux if=hpux /
include name=${java.home}/../include/linux if=linux/
-include name=${java.home}/../include/win32 if=win32 /
+include name=${java.home}/../include/win32 if=win32 unless=netware /
/includes
depends
fileset dir=${native.dir}/common includes=*.h /
@@ -118,28 +118,28 @@
def name=XP_NETWARE if=netware
info=Building for NetWare platform /
- import fileName=${novellndk.dir}/imports/clib.imp if=netware /
- import fileName=${novellndk.dir}/imports/lib0.imp if=netware /
- import fileName=${novellndk.dir}/imports/nlmlib.imp if=netware /
- import fileName=${novellndk.dir}/imports/threads.imp if=netware /
- import fileName=${novellndk.dir}/imports/socklib.imp if=netware /
+ import fileName=${novellndk.home}/imports/clib.imp if=netware /
+ import fileName=${novellndk.home}/imports/lib0.imp if=netware /
+ import fileName=${novellndk.home}/imports/nlmlib.imp if=netware /
+ import fileName=${novellndk.home}/imports/threads.imp if=netware /
+ import fileName=${novellndk.home}/imports/socklib.imp if=netware /
export fileName=${native.dir}/jni/jk_jnicb.exp if=netware /
linkOpt value=-desc quot;JNI Natives for Tomcatquot; if=netware /
linkOpt value=-screenname quot;System Consolequot; if=netware /
- linkOpt value=-nlmversion 1,2,2 if=netware /
+ linkOpt value=-nlmversion 1,2,3 if=netware /
linkOpt value=-threadname quot;JK_JNI Threadquot; if=netware /
linkOpt value=-stacksize 64000 if=netware /
def name=HPUX11 if=hpux /
- def name=WIN32 if=win32 /
- def name=DEBUG if=win32.debug /
- def name=NDEBUG if=win32.release /
- def name=_WINDOWS if=win32 /
- def name=_MBCS if=win32 /
- def name=_USRDLL if=win32 /
- def name=JNI_CONNECT_EXPORTS if=win32 /
- linkOpt value=/libpath:quot;${build.compiler.base}/libquot; if=win32 /
+ def name=WIN32 if=win32 unless=netware /
+ def name=DEBUG if=win32.debug unless=netware /
+ def name=NDEBUG if=win32.release unless=netware /
+ def name=_WINDOWS if=win32 unless=netware /
+ def name=_MBCS if=win32 unless=netware /
+ def name=_USRDLL if=win32 unless=netware /
+ def name=JNI_CONNECT_EXPORTS if=win32 unless=netware /
+ linkOpt value=/libpath:quot;${build.compiler.base}/libquot; if=win32
unless=netware /
/so
/target
@@ -178,31 +178,31 @@
include name=${java.home}/../include /
!-- Platform specific includes --
-include name=${java.home}/../include/win32 if=win32 /
+include name=${java.home}/../include/win32 if=win32 unless=netware /
include name=${java.home}/../include/hp-ux if=hpux /
include name=${java.home}/../include/netware if=netware /
include name=${java.home}/../include/linux if=linux/
- include name=${novelllibc.dir}/include if=netware /
- include name=${novelllibc.dir}/include/winsock if=netware /
+ include name=${novelllibc.home}/include if=netware /
+ include name=${novelllibc.home}/include/winsock if=netware /
/includes
depends
fileset dir=${native.dir}/common includes=*.h /
/depends
!-- Platform-specific tags --
- def name=WIN32 if=win32 /
- def name=DEBUG if=win32.debug /
- def name=NDEBUG if=win32.release /
- def name=_WINDOWS if=win32 /
- def name=_MBCS if=win32 /
- def name=_USRDLL if=win32 /
-
- import fileName=libapr.lib if=win32 /
- import
Re: JSP won't work unless have package in taglib .java file
Hi; If I have a tld object (ie TemplateDesc.java) with no project and place it in WEB-INF/classes - it won't work. But if I give it a package name and place it in WEB-INF/classes/package - then it works. The problem seems to be that with no package it generates the code: TemplateDesc _jspx_th_tl_TP_0 = (TemplateDesc) _jspx_tagPool_tl_TP.get(com.windwardreports.TemplateDesc.class); but with the package it generates: com.windwardreports.TemplateDesc _jspx_th_tl_TP_0 = (com.windwardreports.TemplateDesc) _jspx_tagPool_tl_TP.get(com.windwardreports.TemplateDesc.class); which makes sense. But why can it find it as part of a package but not with no package? thanks - dave - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ContainerBase.java
costin 2003/04/04 14:10:30
Modified:catalina/src/share/org/apache/catalina/core
ContainerBase.java
Log:
few small fixes in unregistration.
Added the controller - this will be the name of the component that
registers, or null if it's an outside entity.
For example, if a Container/Valve/etc is created automatically by tomcat,
then the code that creates it will set the field. When the controller stops,
it must also unregister all the components it registered ( and not more :-).
If the same Container is created by modeler from a config file or by
an embeding application by direct calls or other means - then the controller field
will not be set, which means that the container is responsible for its lifecycle.
Short version:
1. who register is responsible to unregister
2. you shouldn't unregister what you didn't registered
Revision ChangesPath
1.18 +8 -6
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ContainerBase.java
Index: ContainerBase.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ContainerBase.java,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- ContainerBase.java27 Mar 2003 03:06:39 - 1.17
+++ ContainerBase.java4 Apr 2003 22:10:30 - 1.18
@@ -1312,12 +1312,11 @@
if( logger instanceof LoggerBase ) {
LoggerBase lb=(LoggerBase)logger;
-if( lb.getObjectName()==null ) {
-ObjectName lname=lb.createObjectName();
+if( lb.getObjectName()!=null ) {
try {
-Registry.getRegistry().registerComponent(lb, lname, null);
+Registry.getRegistry().unregisterComponent(lb.getObjectName());
} catch( Exception ex ) {
-log.error( Can't register logger + lname, ex);
+log.error( Can't unregister logger + lb.getObjectName(), ex);
}
}
}
@@ -1325,8 +1324,10 @@
// unregister this component
if( oname != null ) {
try {
-Registry.getRegistry().unregisterComponent(oname);
-log.info(unregistering + oname);
+if( controller == oname ) {
+Registry.getRegistry().unregisterComponent(oname);
+log.debug(unregistering + oname);
+}
} catch( Throwable t ) {
log.error(Error unregistering , t );
}
@@ -1578,6 +1579,7 @@
protected String domain;
protected String suffix;
protected ObjectName oname;
+protected ObjectName controller;
protected MBeanServer mserver;
public ObjectName getObjectName() {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/http11 build.xml
costin 2003/04/04 14:15:40
Modified:http11 build.xml
Log:
Index, flag to skip docs
Revision ChangesPath
1.13 +6 -4 jakarta-tomcat-connectors/http11/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-connectors/http11/build.xml,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- build.xml 13 Mar 2003 18:00:51 - 1.12
+++ build.xml 4 Apr 2003 22:15:40 - 1.13
@@ -139,7 +139,7 @@
/target
- target name=javadoc
+ target name=javadoc unless=docs-uptodate
description=Create component Javadoc documentation
mkdir dir=${build.home}/docs/api/
javadoc sourcepath=${source.home}
@@ -170,6 +170,7 @@
/copy
property name=tomcat-http11.jar
value=${build.home}/lib/tomcat-${component.name}.jar/
jarjarfile=${tomcat-http11.jar}
+ index=true
basedir=${build.home}/classes
manifest=${conf.home}/MANIFEST.MF
include name=org/apache/coyote/http11/**/
@@ -179,8 +180,9 @@
target name=compile depends=static,compile-only
description=Compile shareable components
jar jarfile=${build.home}/lib/tomcat33-resource.jar
-basedir=${build.home}/classes
- includes=**/*.properties /
+ index=true
+ basedir=${build.home}/classes
+ includes=**/*.properties /
copy file=${tomcat-util.jar}
tofile=${build.home}/lib/tomcat-util.jar /
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Protocol.java
costin 2003/04/04 14:16:22
Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java
Log:
Unregister components fixes.
There are still few issues, but it seems to be working better for me.
Revision ChangesPath
1.22 +60 -24
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java
Index: Http11Protocol.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- Http11Protocol.java 17 Feb 2003 01:41:19 - 1.21
+++ Http11Protocol.java 4 Apr 2003 22:16:22 - 1.22
@@ -68,6 +68,7 @@
import java.util.*;
import org.apache.tomcat.util.res.StringManager;
import org.apache.tomcat.util.threads.ThreadPool;
+import org.apache.tomcat.util.threads.ThreadWithAttributes;
import org.apache.tomcat.util.net.*;
import org.apache.commons.modeler.Registry;
import javax.management.ObjectName;
@@ -159,15 +160,26 @@
log.info(sm.getString(http11protocol.init, + ep.getPort()));
}
-
+
+ObjectName tpOname;
+ObjectName rgOname;
+
public void start() throws Exception {
if( this.domain != null ) {
try {
-Registry.getRegistry().registerComponent(tp, domain,ThreadPool,
-type=ThreadPool,name=http + ep.getPort());
+// XXX We should be able to configure it separately
+// XXX It should be possible to use a single TP
+tpOname=new ObjectName(domain + : + type=ThreadPool,name=http +
ep.getPort());
+Registry.getRegistry().registerComponent(tp, tpOname, null );
+tp.addThreadPoolListener(new MXPoolListener(this, tp));
} catch (Exception e) {
log.error(Can't register threadpool );
}
+rgOname=new ObjectName( domain +
+:type=GlobalRequestProcessor,name=http +
+ep.getPort());
+Registry.getRegistry().registerComponent( cHandler.global,
+rgOname, null );
}
try {
@@ -180,7 +192,12 @@
}
public void destroy() throws Exception {
+log.info(Stoping http11 protocol on + ep.getPort() + + tpOname);
ep.stopEndpoint();
+if( tpOname!=null )
+Registry.getRegistry().unregisterComponent(tpOname);
+if( rgOname != null )
+Registry.getRegistry().unregisterComponent(rgOname);
}
// Properties
@@ -345,11 +362,42 @@
}
// Connection handler
+public static final int THREAD_DATA_PROCESSOR=1;
+public static final int THREAD_DATA_OBJECT_NAME=2;
+
+
+static class MXPoolListener implements ThreadPool.ThreadPoolListener {
+MXPoolListener( Http11Protocol proto, ThreadPool control ) {
+
+}
+
+public void threadStart(ThreadPool tp, Thread t) {
+System.out.println(Thread start );
+}
+
+public void threadEnd(ThreadPool tp, Thread t) {
+// Register our associated processor
+// TP uses only TWA
+System.out.println( thread ending );
+ThreadWithAttributes ta=(ThreadWithAttributes)t;
+Object tpData[]=ta.getThreadData(tp);
+if( tpData==null ) return;
+// Weird artifact - it should be cleaned up, but that may break
something
+// and it won't gain us too much
+if( tpData[1] instanceof Object[] ) {
+tpData=(Object [])tpData[1];
+}
+ObjectName
oname=(ObjectName)tpData[Http11Protocol.THREAD_DATA_OBJECT_NAME];
+System.out.println(X thread end + oname);
+if( oname==null ) return;
+Registry.getRegistry().unregisterComponent(oname);
+}
+}
static class Http11ConnectionHandler implements TcpConnectionHandler {
Http11Protocol proto;
static int count=0;
-RequestGroupInfo global=null;
+RequestGroupInfo global=new RequestGroupInfo();
Http11ConnectionHandler( Http11Protocol proto ) {
this.proto=proto;
@@ -363,11 +411,7 @@
public Object[] init() {
Object thData[]=new Object[3];
-//CoyoteProcessor adaptor = new CoyoteProcessor(cm);
-// XXX Should be on request
-// if( proto.secure )
-//
cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Protocol.java
costin 2003/04/04 14:19:30
Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java
Log:
println removal
I left one for thread stop - I'm still debuging this part.
Revision ChangesPath
1.23 +0 -2
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java
Index: Http11Protocol.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- Http11Protocol.java 4 Apr 2003 22:16:22 - 1.22
+++ Http11Protocol.java 4 Apr 2003 22:19:30 - 1.23
@@ -372,7 +372,6 @@
}
public void threadStart(ThreadPool tp, Thread t) {
-System.out.println(Thread start );
}
public void threadEnd(ThreadPool tp, Thread t) {
@@ -388,7 +387,6 @@
tpData=(Object [])tpData[1];
}
ObjectName
oname=(ObjectName)tpData[Http11Protocol.THREAD_DATA_OBJECT_NAME];
-System.out.println(X thread end + oname);
if( oname==null ) return;
Registry.getRegistry().unregisterComponent(oname);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 CoyoteConnector.java
costin 2003/04/04 14:21:35
Modified:coyote/src/java/org/apache/coyote/tomcat5
CoyoteConnector.java
Log:
Deal with the various registration orders.
Revision ChangesPath
1.23 +26 -14
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteConnector.java
Index: CoyoteConnector.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteConnector.java,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- CoyoteConnector.java 25 Mar 2003 17:47:46 - 1.22
+++ CoyoteConnector.java 4 Apr 2003 22:21:35 - 1.23
@@ -526,7 +526,10 @@
* Connector.
*/
public Container getContainer() {
-
+if( container==null ) {
+// Lazy - maybe it was added later
+findContainer();
+}
return (container);
}
@@ -1078,7 +1081,6 @@
}
-
/**
* Initialize this connector (create ServerSocket here!)
*/
@@ -1269,6 +1271,9 @@
try {
Registry.getRegistry().unregisterComponent(new
ObjectName(domain,type, Mapper));
+Registry.getRegistry().unregisterComponent(new ObjectName(domain
++ :type=protocolHandler,className=
++ protocolHandlerClassName));
} catch (MalformedObjectNameException e) {
log.info( Error unregistering mapper , e);
}
@@ -1391,18 +1396,13 @@
log.error( Unregistering - can't stop, t);
}
}
-
-public void init() throws Exception {
-
-if( this.getService() != null ) {
-log.info( Already configured );
-return;
-}
-if( container==null ) {
+
+private void findContainer() {
+try {
// Register to the service
ObjectName parentName=new ObjectName( domain + : +
type=Service);
-
+
log.info(Adding to + parentName );
if( mserver.isRegistered(parentName )) {
mserver.invoke(parentName, addConnector, new Object[] { this },
@@ -1418,16 +1418,28 @@
Object obj=mserver.getAttribute(engName, managedResource);
log.info(Found engine + obj + + obj.getClass());
container=(Container)obj;
-
+
// Internal initialize - we now have the Engine
initialize();
-
+
log.info(Initialized);
// As a side effect we'll get the container field set
// Also initialize will be called
return;
}
+} catch( Exception ex ) {
+log.error( Error finding container + ex);
+}
+}
+
+public void init() throws Exception {
+if( this.getService() != null ) {
+log.info( Already configured );
+return;
+}
+if( container==null ) {
+findContainer();
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 MapperListener.java
costin 2003/04/04 14:22:25
Modified:coyote/src/java/org/apache/coyote/tomcat5
MapperListener.java
Log:
Avoid problems if the engine is registered after the mapper.
Revision ChangesPath
1.11 +1 -0
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/MapperListener.java
Index: MapperListener.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/MapperListener.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- MapperListener.java 28 Mar 2003 14:23:59 - 1.10
+++ MapperListener.java 4 Apr 2003 22:22:25 - 1.11
@@ -264,6 +264,7 @@
throws Exception
{
ObjectName engineName=new ObjectName(domain + :type=Engine);
+if( ! mBeanServer.isRegistered(engineName)) return;
//if (container instanceof Engine) {
String defaultHost = (String)mBeanServer.getAttribute(engineName,
defaultHost);
// This should probablt be called later
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardEngine.java
jfarcand2003/04/04 14:46:17
Modified:catalina/src/share/org/apache/catalina/core
StandardEngine.java
Log:
Set the container before initializing a Service (throws a NPE when embedded).
Revision ChangesPath
1.9 +5 -5
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardEngine.java
Index: StandardEngine.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardEngine.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- StandardEngine.java 21 Mar 2003 07:34:39 - 1.8
+++ StandardEngine.java 4 Apr 2003 22:46:17 - 1.9
@@ -413,8 +413,8 @@
// for consistency...: we are probably in embeded mode
try {
service=new StandardService();
-service.initialize();
service.setContainer( this );
+service.initialize();
} catch( Throwable t ) {
t.printStackTrace();
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationDispatcher.java
jfarcand2003/04/04 14:51:18
Modified:catalina/src/share/org/apache/catalina/core
ApplicationDispatcher.java
Log:
Do not print the exception since it has been previously logged (and also that not
the proper exception)
Revision ChangesPath
1.13 +6 -6
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java
Index: ApplicationDispatcher.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- ApplicationDispatcher.java18 Mar 2003 16:23:36 - 1.12
+++ ApplicationDispatcher.java4 Apr 2003 22:51:18 - 1.13
@@ -13,7 +13,7 @@
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
- *
+ *5
* 1. Redistributions of source code must retain the above copyright
*notice, this list of conditions and the following disclaimer.
*
@@ -520,7 +520,7 @@
AccessController.doPrivileged(dp);
} catch (PrivilegedActionException pe) {
Exception e = pe.getException();
-pe.printStackTrace();
+
if (e instanceof ServletException)
throw (ServletException) e;
throw (IOException) e;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationDispatcher.java
jfarcand2003/04/04 15:11:27 Modified:catalina/src/share/org/apache/catalina/core ApplicationDispatcher.java Log: Remove magic number 5 :-) Revision ChangesPath 1.14 +5 -5 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java Index: ApplicationDispatcher.java === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java,v retrieving revision 1.13 retrieving revision 1.14 diff -u -r1.13 -r1.14 --- ApplicationDispatcher.java4 Apr 2003 22:51:18 - 1.13 +++ ApplicationDispatcher.java4 Apr 2003 23:11:27 - 1.14 @@ -13,7 +13,7 @@ * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions * are met: - *5 + * * 1. Redistributions of source code must retain the above copyright *notice, this list of conditions and the following disclaimer. * - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java
jfarcand2003/04/04 15:22:10
Modified:catalina/src/share/org/apache/catalina/core
StandardWrapper.java
Log:
Log the real exception since we are loosing the root cause.
Revision ChangesPath
1.21 +5 -4
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
Index: StandardWrapper.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- StandardWrapper.java 25 Mar 2003 19:07:56 - 1.20
+++ StandardWrapper.java 4 Apr 2003 23:22:09 - 1.21
@@ -1061,6 +1061,7 @@
// said so, so do not call unavailable(null).
throw f;
} catch (Throwable f) {
+log.error(StandardWrapper.Throwable, f );
instanceSupport.fireInstanceEvent(InstanceEvent.AFTER_INIT_EVENT,
servlet, f);
// If the servlet wanted to be unavailable it would have
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java
costin 2003/04/04 19:56:07
Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
Log:
Few more fixes - Amy, that should solve reloading problems ( at least it does for me
).
I'm not sure if we do reset everything completely - that's what I'm experimenting
with the new method. What needs to happen after stop() is similar with
the recycle() in request - no trace of the old context and config should
remain.
unregister deals with the mapper.
Doing few dozens restarts and looking at memory use will probably help
Revision ChangesPath
1.33 +85 -54
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
Index: StandardContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- StandardContext.java 25 Mar 2003 17:55:59 - 1.32
+++ StandardContext.java 5 Apr 2003 03:56:07 - 1.33
@@ -83,6 +83,8 @@
import javax.management.ObjectName;
import javax.management.MBeanServer;
import javax.management.MalformedObjectNameException;
+import javax.management.InstanceNotFoundException;
+import javax.management.MBeanRegistrationException;
import org.apache.naming.ContextBindings;
import org.apache.naming.resources.BaseDirContext;
import org.apache.naming.resources.FileDirContext;
@@ -4023,6 +4025,44 @@
}
+/**
+ * Stop this Context component. Experimental, please ignore.
+ *
+ * @exception LifecycleException if a shutdown error occurs
+ */
+public synchronized void stopNew() throws LifecycleException {
+// Mark this application as unavailable while we shut down
+setAvailable(false);
+
+// Binding thread
+ClassLoader oldCCL = bindThread();
+
+try {
+// Stop our filters
+filterStop();
+
+// Finalize our character set mapper
+setCharsetMapper(null);
+
+// Stop our application listeners
+listenerStop();
+
+// Stop resources
+resourcesStop();
+
+super.stop();
+} finally {
+
+// Unbinding thread
+unbindThread(oldCCL);
+
+}
+
+// Reset application context
+context = null;
+
+wrappers = new ArrayList();
+}
/**
* Stop this Context component.
@@ -4116,11 +4156,18 @@
context = null;
wrappers = new ArrayList();
+
+// This object will no longer be visible or used.
+try {
+resetContext();
+} catch( Exception ex ) {
+log.error( Error reseting context + this + + ex, ex );
+}
// Notify our interested LifecycleListeners
lifecycle.fireLifecycleEvent(AFTER_STOP_EVENT, null);
-
+
if (log.isDebugEnabled())
log.debug(Stopping complete);
}
@@ -4139,42 +4186,17 @@
*/
public void destroy() throws Exception {
super.destroy();
-
-
+}
+
+private void resetContext() throws Exception, MBeanRegistrationException {
// Restore the original state ( pre reading web.xml in start )
// If you extend this - override this method and make sure to clean up
children=new HashMap();
-
-StandardContext repl=new StandardContext();
-// All configurable options
-repl.setAltDDName(altDDName);
-repl.setCachingAllowed(cachingAllowed);
-repl.setCharsetMapperClass(mapperClass);
-repl.setConfigFile(configFile);
-repl.setCookies(cookies);
-repl.setCrossContext(crossContext);
-repl.setDefaultWebXml(defaultWebXml);
-//repl.setDistributable(distributable); // this is from web.xml
-repl.setDocBase(docBase);
-repl.setJ2EEApplication(j2EEApplication);
-repl.setJ2EEServer(j2EEServer);
-repl.setLazy(lazy);
-repl.setMapperClass(mapperClass);
-repl.setName(name);
-repl.setOverride(override);
-repl.setPath(getPath());
-repl.setPrivileged(privileged);
-repl.setReloadable(reloadable);
-repl.setReplaceWelcomeFiles(replaceWelcomeFiles);
-repl.setSessionTimeout(sessionTimeout);
-repl.setUseNaming(useNaming);
-repl.setWrapperClass(wrapperClass);
-repl.setWorkDir(workDir);
-repl.setSwallowOutput(swallowOutput);
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardHostValve.java
costin 2003/04/04 19:57:58
Modified:catalina/src/share/org/apache/catalina/core
StandardHostValve.java
Log:
Avoid NPE
Revision ChangesPath
1.3 +13 -7
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHostValve.java
Index: StandardHostValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- StandardHostValve.java13 Mar 2003 02:26:32 - 1.2
+++ StandardHostValve.java5 Apr 2003 03:57:58 - 1.3
@@ -145,6 +145,8 @@
throws IOException, ServletException {
// Validate the request and response object types
+// XXX This should move to Engine ( the entry point )
+// will it be skiped if the mapper maps the valve ?
if (!(request.getRequest() instanceof HttpServletRequest) ||
!(response.getResponse() instanceof HttpServletResponse)) {
return; // NOTE - Not much else we can do generically
@@ -161,9 +163,13 @@
}
// Bind the context CL to the current thread
-Thread.currentThread().setContextClassLoader
-(context.getLoader().getClassLoader());
-
+if( context.getLoader() != null ) {
+// Not started - it should check for availability first
+// This should eventually move to Engine, it's generic.
+Thread.currentThread().setContextClassLoader
+(context.getLoader().getClassLoader());
+}
+
// Update the session last access time for our session (if any)
HttpServletRequest hreq = (HttpServletRequest) request.getRequest();
String sessionId = hreq.getRequestedSessionId();
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardEngine.java
costin 2003/04/04 20:00:32
Modified:catalina/src/share/org/apache/catalina/core
StandardEngine.java
Log:
A bit of a hack for now. When the engine is destroyed it should clean up
the data that it loaded in registry - otherwise a start would see the
old data.
The real solution is to stop using the static methods in Registry. The registry
is just a helper associated with the app. This will also be more secure.
In any case - for next release of modeler the static methods will be deprecated
and the method that loads explicitely an mbean-descriptor will also be deprecated.
It is much cleaner to load the descriptors on demand, from the same package.
Revision ChangesPath
1.10 +15 -13
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardEngine.java
Index: StandardEngine.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardEngine.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- StandardEngine.java 4 Apr 2003 22:46:17 - 1.9
+++ StandardEngine.java 5 Apr 2003 04:00:32 - 1.10
@@ -65,23 +65,17 @@
package org.apache.catalina.core;
-import java.io.IOException;
-import javax.servlet.ServletException;
-import javax.servlet.ServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.management.ObjectName;
import javax.management.MBeanServer;
import javax.management.MalformedObjectNameException;
+import javax.management.ObjectName;
import org.apache.catalina.Container;
import org.apache.catalina.Context;
import org.apache.catalina.DefaultContext;
import org.apache.catalina.Engine;
import org.apache.catalina.Host;
import org.apache.catalina.LifecycleException;
-import org.apache.catalina.Request;
-import org.apache.catalina.Response;
-import org.apache.catalina.Service;
import org.apache.catalina.Realm;
+import org.apache.catalina.Service;
import org.apache.catalina.realm.JAASRealm;
import org.apache.catalina.util.ServerInfo;
import org.apache.commons.logging.Log;
@@ -385,6 +379,7 @@
domain=getName();
log.info( Register + domain );
oname=new ObjectName(domain + :type=Engine);
+controller=oname;
Registry.getRegistry().registerComponent(this, oname, null);
} catch( Throwable t ) {
log.info(Error registering , t );
@@ -422,10 +417,16 @@
}
-public void destroy() {
+public void destroy() throws LifecycleException {
if( ! initialized ) return;
initialized=false;
+// if we created it, make sure it's also destroyed
+((StandardService)service).destroy();
+// force all metadata to be reloaded.
+// That doesn't affect existing beans. We should make it per
+// registry - and stop using the static.
+Registry.getRegistry().resetMetadata();
}
/**
@@ -505,3 +506,4 @@
}
}
+
\ No newline at end of file
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup HostConfig.java
costin 2003/04/04 20:02:08
Modified:catalina/src/share/org/apache/catalina/startup
HostConfig.java
Log:
If a restart stops ( for example bad web.xml ), it should be possible to
fix the error and have the context load again. So errors in stop() should
be ignored.
Revision ChangesPath
1.8 +15 -8
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/HostConfig.java
Index: HostConfig.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/HostConfig.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- HostConfig.java 25 Mar 2003 17:57:54 - 1.7
+++ HostConfig.java 5 Apr 2003 04:02:08 - 1.8
@@ -93,6 +93,7 @@
import org.apache.catalina.LifecycleListener;
import org.apache.catalina.Logger;
import org.apache.catalina.core.StandardHost;
+import org.apache.catalina.core.StandardContext;
import org.apache.catalina.util.StringManager;
@@ -716,11 +717,17 @@
boolean result = true;
try {
((Lifecycle) context).stop();
-// Note: If the context was already stopped, a
-// Lifecycle exception will be thrown, and the context
-// won't be restarted
+} catch( Exception ex ) {
+log.warn(Erorr stopping context + context.getName() ++
+ex.toString());
+}
+// if the context was not started ( for example an error in web.xml)
+// we'll still get to try to start
+try {
((Lifecycle) context).start();
-} catch (LifecycleException e) {
+} catch (Exception e) {
+log.warn(Error restarting context + context.getName() + +
+e.toString());
result = false;
}
return result;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java
costin 2003/04/04 20:03:07
Modified:catalina/src/share/org/apache/catalina/core
StandardWrapper.java
Log:
Set the controller - so we are unregistered. Reduce the verbosity ( same message
was displayed 2 times )
Revision ChangesPath
1.22 +8 -8
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
Index: StandardWrapper.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- StandardWrapper.java 4 Apr 2003 23:22:09 - 1.21
+++ StandardWrapper.java 5 Apr 2003 04:03:07 - 1.22
@@ -677,9 +677,6 @@
*/
public Servlet allocate() throws ServletException {
-if (log.isDebugEnabled())
-log.debug(Allocating an instance);
-
// If we are currently unloading this servlet, throw an exception
if (unloading)
throw new ServletException
@@ -693,6 +690,9 @@
synchronized (this) {
if (instance == null) {
try {
+if (log.isDebugEnabled())
+log.debug(Allocating non-STM instance);
+
instance = loadServlet();
} catch (ServletException e) {
throw e;
@@ -1564,7 +1564,7 @@
ctx.getJ2EEServer();
oname=new ObjectName(onameStr);
-
+controller=oname;
Registry.getRegistry().registerComponent(this, oname, null );
} catch( Exception ex ) {
log.info(Error registering servlet with jmx + this);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardService.java
costin 2003/04/04 20:07:52
Modified:catalina/src/share/org/apache/catalina/core
StandardService.java
Log:
Implement the controller trick.
Replace println with log.
Don't overreact if start is called twice.
Make sure stop() is called before destroy.
Revision ChangesPath
1.6 +16 -17
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardService.java
Index: StandardService.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardService.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- StandardService.java 27 Mar 2003 03:06:39 - 1.5
+++ StandardService.java 5 Apr 2003 04:07:52 - 1.6
@@ -1,8 +1,4 @@
/*
- * $Header$
- * $Revision$
- * $Date$
- *
*
*
* The Apache Software License, Version 1.1
@@ -92,7 +88,6 @@
* not required.
*
* @author Craig R. McClanahan
- * @version $Revision$ $Date$
*/
public class StandardService
@@ -553,8 +548,7 @@
// Validate and update our current component state
if (!started) {
-throw new LifecycleException
-(sm.getString(standardService.stop.notStarted));
+return;
}
// Notify our interested LifecycleListeners
@@ -562,7 +556,7 @@
lifecycle.fireLifecycleEvent(STOP_EVENT, null);
-System.out.println
+log.info
(sm.getString(standardService.stop.name, this.name));
started = false;
@@ -582,16 +576,14 @@
}
}
}
-
-// unregister this service
-if( oname!=null ) {
-try {
-Registry.getRegistry().unregisterComponent(oname);
-log.info(unregistering + oname);
-} catch (Exception e) {
-log.error(Error unregistering ,e);
-}
+
+if( oname==controller ) {
+// we registered ourself on init().
+// That should be the typical case - this object is just for
+// backward compat, nobody should bother to load it explicitely
+Registry.getRegistry().unregisterComponent(oname);
}
+
// Notify our interested LifecycleListeners
lifecycle.fireLifecycleEvent(AFTER_STOP_EVENT, null);
@@ -619,6 +611,7 @@
Container engine=this.getContainer();
domain=engine.getName();
oname=new ObjectName(domain + :type=Service,serviceName=+name);
+this.controller=oname;
Registry.getRegistry().registerComponent(this, oname, null);
} catch (Exception e) {
log.error(Error registering ,e);
@@ -641,6 +634,11 @@
}
}
}
+
+public void destroy() throws LifecycleException {
+if( started ) stop();
+// unregister should be here probably
+}
public void init() {
try {
@@ -654,6 +652,7 @@
protected String domain;
protected String suffix;
protected ObjectName oname;
+protected ObjectName controller;
protected MBeanServer mserver;
public ObjectName getObjectName() {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util StringManager.java
costin 2003/04/04 20:10:34
Modified:catalina/src/share/org/apache/catalina/util
StringManager.java
Log:
Ok, classloader problems still happen - and it's better to get some meaningfull
messages ( the URLs ), and be able to debug the rest of the app. Otherwise - you
just get a stack trace.
I think we should also switch to the StringManager in util, it has few more tricks.
ResourceBundle is a very tricky class wrt class loaders
Revision ChangesPath
1.2 +19 -4
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/StringManager.java
Index: StringManager.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/StringManager.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- StringManager.java18 Jul 2002 16:47:43 - 1.1
+++ StringManager.java5 Apr 2003 04:10:34 - 1.2
@@ -69,6 +69,7 @@
import java.util.Locale;
import java.util.MissingResourceException;
import java.util.ResourceBundle;
+import java.net.URLClassLoader;
/**
* An internationalization / localization helper class which reduces
@@ -112,7 +113,18 @@
private StringManager(String packageName) {
String bundleName = packageName + .LocalStrings;
-bundle = ResourceBundle.getBundle(bundleName);
+try {
+bundle = ResourceBundle.getBundle(bundleName);
+return;
+} catch( MissingResourceException ex ) {
+ClassLoader cl=this.getClass().getClassLoader();
+
+System.out.println(Can't find resource + bundleName +
+ + cl);
+if( cl instanceof URLClassLoader ) {
+System.out.println( ((URLClassLoader)cl).getURLs());
+}
+}
}
/**
@@ -130,6 +142,8 @@
String str = null;
+if( bundle==null )
+return key;
try {
str = bundle.getString(key);
} catch (MissingResourceException mre) {
@@ -256,6 +270,7 @@
public synchronized static StringManager getManager(String packageName) {
StringManager mgr = (StringManager)managers.get(packageName);
+
if (mgr == null) {
mgr = new StringManager(packageName);
managers.put(packageName, mgr);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.2.txt
billbarker2003/04/04 23:19:59 Modified:.RELEASE-NOTES-3.3.2.txt Log: Document changes to the admin web-app. Revision ChangesPath 1.18 +3 -1 jakarta-tomcat/RELEASE-NOTES-3.3.2.txt Index: RELEASE-NOTES-3.3.2.txt === RCS file: /home/cvs/jakarta-tomcat/RELEASE-NOTES-3.3.2.txt,v retrieving revision 1.17 retrieving revision 1.18 diff -u -r1.17 -r1.18 --- RELEASE-NOTES-3.3.2.txt 26 Jan 2003 03:16:30 - 1.17 +++ RELEASE-NOTES-3.3.2.txt 5 Apr 2003 07:19:59 - 1.18 @@ -31,6 +31,8 @@ tasks allow the Tomcat work directory to be pre-populated with compiled JSPs. +13285 Added improvements to the admin web-app to include support for vhosts. + Server: Bug No. Description - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: JSPC for TOMCAT 4.124 generates unexpected internal error
Well, I've got just that. VMS will track every file accessed from JAVA (called file mapping). When set, I can see that JSPC first looks at descendant, then ascendant directories, until it reaches /examples. It probes /WEB-INF, then goes on... The fact that JSPC sets the default uriroot to ../examples, confirms it found the WEB-INF directory. the web.xml file is there: $dir DSA1:APACHE.JAKARTA.TOMCAT.webapps.examples.WEB-INF Directory DSA1:APACHE.JAKARTA.TOMCAT.webapps.examples.WEB-INF classes.DIR;1 jsp.DIR;1 web.xml;1 And, when run with -uriroot explicitely defined eg jspc -v4 -webinc check.xml -uriroot /dsa1/apache/jakarta/tomcat/webapps/examples -webapp . JSPC runs just fine: 2003-04-04 09:01:21 - Class name is: checkresult 2003-04-04 09:01:21 - Java file name is: /dsa1/apache/jakarta/tomcat/webapps/examples/jsp/checkbox/checkresult.java 2003-04-04 09:01:22 - Accepted org.apache.jasper.compiler.Parser$Declaration at /jsp/checkbox/checkresult.jsp(8,0) 2003-04-04 09:01:22 - Accepted org.apache.jasper.compiler.Parser$Bean at /jsp/ch eckbox/checkresult.jsp(9,0) 2003-04-04 09:01:22 - Accepted org.apache.jasper.compiler.Parser$SetProperty at /jsp/checkbox/checkresult.jsp(11,0) ... ...etc directory listing after jspc: Directory DSA1:APACHE.JAKARTA.TOMCAT.webapps.examples.jsp.checkbox check.html;1check.xml;1 checkresult.java;1 checkresult.jsp;1 CheckTest.html;1cresult.html;1 so the plot thickens... This appears to be linked to the -uriroot switch processing next? Marc Dufresne OpenVMS Ambassador Pre-Sales Large Accounts HP France ( : + 33.1.5762.5413 e-mail : [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] -Original Message- From: Karr, David [mailto:[EMAIL PROTECTED] Sent: Friday, April 04, 2003 8:30 PM To: Tomcat Users List Subject: RE: JSPC for TOMCAT 4.124 generates unexpected internal error Ok, well, one technique you might use to diagnose what's happening here is to use some tool for monitoring I/O operations, like truss on Solaris, or FileMon on Windows. You can search for references to that file name, and it will tell you what directories it is looking in. Hopefully that will give you a clue to why it's not finding it in the directory you expect. -Original Message- From: Dufresne, Marc [mailto:[EMAIL PROTECTED] the lower case is an artefact of GNV (BASH shell for OpenVMS) The actuall directory name *IS* in caps when watching JSPC do it's file search up the tree, it does in fact find the directory porperly. next? -Original Message- From: Karr, David [mailto:[EMAIL PROTECTED] Normal behavior. You need to change web-inf to WEB-INF. -Original Message- From: Dufresne, Marc [mailto:[EMAIL PROTECTED] I'm doing a simple test to compile the checkbox JSP from the TOMCAT examples with the -webinc switch The JAVA and XML files are properly generates but jasper complains (unexpectedly ) that the web.xml file is no found here is the output fragment: 2003-04-04 04:21:34 - uriRoot implicitly set to /dsa1/apache/jakarta/tomcat/web apps/examples 2003-04-04 04:21:34 - Internal Error: File /WEB-INF/web.xml not found Check the web.xml file is really there: bash$ pwd /dsa1/apache/jakarta/tomcat/webapps/examples/web-inf bash$ ls classes jsp web.xml bash$ OK, spurious or normal behaviour ? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
