Change in vdsm[ovirt-3.6]: virt: Correct disconnectAction parameter extraction
Milan Zamazal has posted comments on this change. Change subject: virt: Correct disconnectAction parameter extraction .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1695a56d3f7e68f8f9b8d2a929775edc4570985 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: stomp: use socket pending
Francesco Romani has posted comments on this change. Change subject: stomp: use socket pending .. Patch Set 2: Code-Review+1 can we have any bug for reference? We can piggyback on existing one. -- To view, visit https://gerrit.ovirt.org/63482 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: virt: Pass missing parameter on desktopLogoff
Milan Zamazal has posted comments on this change. Change subject: virt: Pass missing parameter on desktopLogoff .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b030d4a7a7ed7ad3f6279c66120d1f9e45d396 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "build tests: Require NOSE 1.3.7 and up for running t...
gerrit-hooks has posted comments on this change. Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running tests" .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I175c0752a5929d1b644cd41cf8d111bcce10f32d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Run mount tests multiple times
Dan Kenigsberg has posted comments on this change. Change subject: tests: Run mount tests multiple times .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/56545/7/tests/mountTests.py File tests/mountTests.py: Line 122: Line 123: @expandPermutations Line 124: class MountTests(TestCaseBase): Line 125: Line 126: @permutations([["%03d" % i] for i in range(500)]) doesn't this make it a @slowtest? why abuse permutation instead of adding a single `for` line? Line 127: @ValidateRunningAsRoot Line 128: def testLoopMount(self, _): Line 129: with namedTemporaryDir() as mpath: Line 130: # two nested with blocks to be python 2.6 friendly -- To view, visit https://gerrit.ovirt.org/56545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idaed2e8e1c5b2bd04c412233d94e94005c23189c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Wait for systemd temporary mount unit
Dan Kenigsberg has posted comments on this change. Change subject: mount: Wait for systemd temporary mount unit .. Patch Set 6: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/56544/6/lib/vdsm/storage/mount.py File lib/vdsm/storage/mount.py: Line 208: Line 209: TODO: find a way to wait for the specific event. Line 210: """ Line 211: with utils.stopwatch("Waiting for udev mount events", log=self.log): Line 212: timeout = config.getint('irs', 'scsi_settle_timeout') mount is unrelated to scsi! but so be it. Line 213: udevadm.settle(timeout) Line 214: Line 215: def isMounted(self): Line 216: try: -- To view, visit https://gerrit.ovirt.org/56544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: add a repo with a fresh nose
gerrit-hooks has posted comments on this change. Change subject: automation: add a repo with a fresh nose .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/63986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: add a repo with a fresh nose
Dan Kenigsberg has submitted this change and it was merged. Change subject: automation: add a repo with a fresh nose .. automation: add a repo with a fresh nose We need nose >= 1.3.7 to test vdsm, but don't have it on el7. One option discussed is not to run test when building for el7. As a quick-and dirty fix for upstream, this patch pulls nose from CentOS virt SIG. It does NOT solve the problem when building in brew or koji. Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599 Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/63986 Continuous-Integration: Jenkins CI Tested-by: Sandro Bonazzola Reviewed-by: Irit Goihman Reviewed-by: Nir Soffer --- M automation/check-patch.repos.el7 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: add a repo with a fresh nose
Dan Kenigsberg has posted comments on this change. Change subject: automation: add a repo with a fresh nose .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Edward Haas has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 5: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/63850/5/lib/vdsm/network/ovs/info.py File lib/vdsm/network/ovs/info.py: PS5, Line 221: None '' -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Wait for systemd temporary mount unit
Nir Soffer has posted comments on this change. Change subject: mount: Wait for systemd temporary mount unit .. Patch Set 6: Here example mount tests from next patch: 23:47:09 mountTests.MountTests 23:47:09 testLoopMount('000')OK 23:47:09 testLoopMount('001')OK 23:47:09 testLoopMount('002')OK 23:47:09 testLoopMount('003')OK 23:47:09 testLoopMount('004')OK 23:47:10 testLoopMount('005')OK 23:47:10 testLoopMount('006')OK 23:47:10 testLoopMount('007')OK 23:47:10 testLoopMount('008')OK 23:47:10 testLoopMount('009')OK 23:47:10 testLoopMount('010')OK 23:47:11 testLoopMount('011')OK 23:47:11 testLoopMount('012')OK 23:47:11 testLoopMount('013')OK 23:47:11 testLoopMount('014')OK 23:47:11 testLoopMount('015')OK 23:47:12 testLoopMount('016')OK 23:47:12 testLoopMount('017')OK 23:47:12 testLoopMount('018')OK 23:47:12 testLoopMount('019')OK 23:47:12 testLoopMount('020')OK 23:47:12 testLoopMount('021')OK 23:47:13 testLoopMount('022')OK 23:47:13 testLoopMount('023')OK 23:47:13 testLoopMount('024')OK 23:47:13 testLoopMount('025')OK 23:47:13 testLoopMount('026')OK 23:47:13 testLoopMount('027')OK 23:47:14 testLoopMount('028')OK 23:47:14 testLoopMount('029')OK 23:47:14 testLoopMount('030')OK 23:47:14 testLoopMount('031')OK 23:47:14 testLoopMount('032')OK 23:47:14 testLoopMount('033')OK 23:47:15 testLoopMount('034')OK 23:47:15 testLoopMount('035')OK 23:47:15 testLoopMount('036')OK 23:47:15 testLoopMount('037')OK 23:47:15 testLoopMount('038')OK 23:47:15 testLoopMount('039')OK 23:47:15 testLoopMount('040')OK 23:47:16 testLoopMount('041')OK 23:47:16 testLoopMount('042')OK 23:47:16 testLoopMount('043')OK 23:47:16 testLoopMount('044')OK 23:47:16 testLoopMount('045')OK 23:47:16 testLoopMount('046')OK 23:47:17 testLoopMount('047')OK 23:47:17 testLoopMount('048')OK 23:47:17 testLoopMount('049')OK 23:47:17 testLoopMount('050')OK 23:47:17 testLoopMount('051')OK 23:47:17 testLoopMount('052')OK 23:47:18 testLoopMount('053')OK 23:47:18 testLoopMount('054')OK 23:47:18 testLoopMount('055')OK 23:47:18 testLoopMount('056')OK 23:47:18 testLoopMount('057')OK 23:47:18 testLoopMount('058')OK 23:47:19 testLoopMount('059')OK 23:47:19 testLoopMount('060')OK 23:47:19 testLoopMount('061')OK 23:47:19 test
Change in vdsm[master]: mount: Wait for systemd temporary mount unit
Nir Soffer has posted comments on this change. Change subject: mount: Wait for systemd temporary mount unit .. Patch Set 6: Verified+1 Verified again using the tests, see the next patch running about 2000 mount tests. -- To view, visit https://gerrit.ovirt.org/56544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: upgrade: Support upgrade from v3 to v4.
gerrit-hooks has posted comments on this change. Change subject: upgrade: Support upgrade from v3 to v4. .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Wait for systemd temporary mount unit
Nir Soffer has posted comments on this change. Change subject: mount: Wait for systemd temporary mount unit .. Patch Set 6: This version uses the current option instead of a magic 5 seconds, remove the ugly duplicate code, and improve documentation. -- To view, visit https://gerrit.ovirt.org/56544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Run mount tests multiple times
gerrit-hooks has posted comments on this change. Change subject: tests: Run mount tests multiple times .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idaed2e8e1c5b2bd04c412233d94e94005c23189c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Wait for systemd temporary mount unit
gerrit-hooks has posted comments on this change. Change subject: mount: Wait for systemd temporary mount unit .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lib: move define.py under common
Nir Soffer has posted comments on this change. Change subject: lib: move define.py under common .. Patch Set 1: Please rebase, we had lot of merges today. -- To view, visit https://gerrit.ovirt.org/63953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I634d3bac718fe0615a2aca951ec47b976967ada1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lib: move the response.py under common
Nir Soffer has posted comments on this change. Change subject: lib: move the response.py under common .. Patch Set 2: Please rebase, we had lot of merges today. -- To view, visit https://gerrit.ovirt.org/63954 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6263fb8991a226516ba5d14e909a4a70ea0078d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mounts: Use more meaningful names
gerrit-hooks has posted comments on this change. Change subject: mounts: Use more meaningful names .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac1ba474856c9cf9f66d05dcce7ed152cbe2147b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lib: move exception.py under common
Nir Soffer has posted comments on this change. Change subject: lib: move exception.py under common .. Patch Set 1: Please rebase, we had lot of merges today. -- To view, visit https://gerrit.ovirt.org/63952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7742aa7dafe0e0e29044536ad19fbddbcab0f420 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Add tests for un-escaping spaces
Nir Soffer has submitted this change and it was merged. Change subject: tests: Add tests for un-escaping spaces .. tests: Add tests for un-escaping spaces Both remote and local path may contain spaces; in this case the spaces are escaped as '\040'. Actual '\' in the path is escaped as '\134'. We have code for un-escaping spaces, but no tests; Add the missing tests based on output from /proc/mounts. Mark one of the tests are broken since the current code can un-escape '\040' but fails for '\134'. Change-Id: I772b7e7e48f888f9b9790cd6963d65cd86912699 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/56549 Reviewed-by: Freddy Rolland Reviewed-by: Idan Shaby Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI --- M tests/mountTests.py 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I772b7e7e48f888f9b9790cd6963d65cd86912699 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Fix un-escaping of spaces
gerrit-hooks has posted comments on this change. Change subject: mount: Fix un-escaping of spaces .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaddcb8c023f80d4284b28ad070fd833374c3e857 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Add tests for un-escaping spaces
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for un-escaping spaces .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I772b7e7e48f888f9b9790cd6963d65cd86912699 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mounts: Use more meaningful names
Nir Soffer has submitted this change and it was merged. Change subject: mounts: Use more meaningful names .. mounts: Use more meaningful names Rename the constants and functions for un-escaping spaces to make the intent of the code more clear. Change-Id: Iac1ba474856c9cf9f66d05dcce7ed152cbe2147b Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/56551 Reviewed-by: Francesco Romani Reviewed-by: Freddy Rolland Continuous-Integration: Jenkins CI --- M lib/vdsm/storage/mount.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac1ba474856c9cf9f66d05dcce7ed152cbe2147b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mounts: Use more meaningful names
gerrit-hooks has posted comments on this change. Change subject: mounts: Use more meaningful names .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac1ba474856c9cf9f66d05dcce7ed152cbe2147b Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support
gerrit-hooks has posted comments on this change. Change subject: mount: Remove EL 6 /etc/mtab support .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49a66b19924accc93f626eca98b2e91a3b7f5e80 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Fix un-escaping of spaces
Nir Soffer has submitted this change and it was merged. Change subject: mount: Fix un-escaping of spaces .. mount: Fix un-escaping of spaces The regular expression match '\040' (" ") but failed to match '\134' ('\'). The pattern would also match invalid such as '\088', raising a ValueError when trying to un-escape. Fix the pattern to accept any octal value. Change-Id: Iaddcb8c023f80d4284b28ad070fd833374c3e857 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/56550 Reviewed-by: Francesco Romani Reviewed-by: Freddy Rolland Continuous-Integration: Jenkins CI --- M lib/vdsm/storage/mount.py M tests/mountTests.py 2 files changed, 1 insertion(+), 3 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaddcb8c023f80d4284b28ad070fd833374c3e857 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Add missing test for deleted mounts
gerrit-hooks has posted comments on this change. Change subject: tests: Add missing test for deleted mounts .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id280a9e8e3d6db273eb3398dd38e4553750c4631 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Simplify deleted suffix stripping
Nir Soffer has submitted this change and it was merged. Change subject: mount: Simplify deleted suffix stripping .. mount: Simplify deleted suffix stripping Replace pointless loop with single if statement. Change-Id: Icb08af0a6a5e7202741cda8b39fe3cddac468b21 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/56548 Reviewed-by: Francesco Romani Reviewed-by: Freddy Rolland Continuous-Integration: Jenkins CI --- M lib/vdsm/storage/mount.py 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb08af0a6a5e7202741cda8b39fe3cddac468b21 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Simplify deleted suffix stripping
gerrit-hooks has posted comments on this change. Change subject: mount: Simplify deleted suffix stripping .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb08af0a6a5e7202741cda8b39fe3cddac468b21 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Don't un-escape mount options
gerrit-hooks has posted comments on this change. Change subject: mount: Don't un-escape mount options .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7f666a565b9db9e4a713516f96a61aab535c596 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Don't un-escape mount options
Nir Soffer has submitted this change and it was merged. Change subject: mount: Don't un-escape mount options .. mount: Don't un-escape mount options We used to un-escape mount options, which may be useful when mount options could contain loop=/dev/loopN, if the path to the device contains spaces. Since we don't use /etc/mtab now, this issue is not relevant and un-escaping is not useful for anything. Change-Id: Ib7f666a565b9db9e4a713516f96a61aab535c596 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/56546 Reviewed-by: Ala Hino Reviewed-by: Allon Mureinik Reviewed-by: Francesco Romani Reviewed-by: Freddy Rolland Continuous-Integration: Jenkins CI --- M lib/vdsm/storage/mount.py 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7f666a565b9db9e4a713516f96a61aab535c596 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Add missing test for deleted mounts
Nir Soffer has submitted this change and it was merged. Change subject: tests: Add missing test for deleted mounts .. tests: Add missing test for deleted mounts Mount path may have a " (deleted)" suffix - we strip this suffix when parsing /proc/mounts output so the path is still considered as mounted. This patch adds the missing test before refactoring the relevant code. Change-Id: Id280a9e8e3d6db273eb3398dd38e4553750c4631 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/56547 Reviewed-by: Freddy Rolland Reviewed-by: Idan Shaby Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI --- M tests/mountTests.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id280a9e8e3d6db273eb3398dd38e4553750c4631 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support
Nir Soffer has submitted this change and it was merged. Change subject: mount: Remove EL 6 /etc/mtab support .. mount: Remove EL 6 /etc/mtab support On EL6 we used /etc/mtab to resolve loop devices backing image. On EL7 (and Fedora) /etc/mtab is a symlink to /proc/self/mounts - just like /proc/mounts, and we resolve loop mount backing files using /sys/block/major:minor/loop/backing_file. This patch removes the now useless support for /etc/mtab, the caching mechanism hiding the O(N^2) loop device resolving code, and the complex performance tests simulating a EL6 system with 1 loop devices. Change-Id: I49a66b19924accc93f626eca98b2e91a3b7f5e80 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/56517 Reviewed-by: Francesco Romani Reviewed-by: Freddy Rolland Continuous-Integration: Jenkins CI --- M lib/vdsm/storage/mount.py M tests/mountTests.py 2 files changed, 1 insertion(+), 154 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49a66b19924accc93f626eca98b2e91a3b7f5e80 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: upgrade: Support upgrade from v3 to v4.
gerrit-hooks has posted comments on this change. Change subject: upgrade: Support upgrade from v3 to v4. .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net libvirt hook: revert vmList change
Nir Soffer has posted comments on this change. Change subject: net libvirt hook: revert vmList change .. Patch Set 1: Ping -- To view, visit https://gerrit.ovirt.org/63762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpc: revert Host.getVMList command result change
Nir Soffer has posted comments on this change. Change subject: jsonrpc: revert Host.getVMList command result change .. Patch Set 1: Ping -- To view, visit https://gerrit.ovirt.org/63761 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: implementing StorageDomain.movePV
Nir Soffer has posted comments on this change. Change subject: implementing StorageDomain.movePV .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/63270/2/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 562: with self._extendlock: Line 563: lvm.movePV(self.sdUUID, guid) Line 564: self.updateMapping() Line 565: Line 566: def reduceDevice(self, guid): I think should call this reduce(), similar to extend(). Line 567: self._validateNotMetadataPV(guid) Line 568: with self._extendlock: Line 569: lvm.reduceVG(self.sdUUID, guid) Line 570: self.updateMapping() -- To view, visit https://gerrit.ovirt.org/63270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74183d13061d114a59da23874c86186457046e94 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: implementing StorageDomain.reduce
Nir Soffer has posted comments on this change. Change subject: implementing StorageDomain.reduce .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/63269/3/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 567: self._validateNotMetadataPV(guid) Line 568: with self._extendlock: Line 569: lvm.reduceVG(self.sdUUID, guid) Line 570: self.updateMapping() Line 571: lvm.removePV(guid) Why separate patch to remove the pv? Looks like bad rebase, and the entire reduceDevice method was meant to be added by this patch. Line 572: Line 573: def _validateNotMetadataPV(self, guid): Line 574: lvm_metadata_pv, _ = lvm.getFirstExt(self.sdUUID, sd.METADATA) Line 575: if lvm.isSamePV(lvm_metadata_pv, guid): https://gerrit.ovirt.org/#/c/63269/3/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 754: :type sdUUID: UUID Line 755: :param guid: A block device GUID Line 756: :type guid: str Line 757: """ Line 758: job = sdm.api.reduce_sd_device.Job(jobUUID, 1, sdUUID, guid) Document why host_id=1 is correct, see also comment in movePV patch. Line 759: self.sdm_schedule(job) Line 760: Line 761: @public Line 762: def resizePV(self, sdUUID, spUUID, guid, options=None): -- To view, visit https://gerrit.ovirt.org/63269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c68f64b6c90f0af4d3fa4da94d5747b4ad9cfd6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: implementing StorageDomain.movePV
Nir Soffer has posted comments on this change. Change subject: implementing StorageDomain.movePV .. Patch Set 2: (15 comments) https://gerrit.ovirt.org/#/c/63270/2/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 570: self.updateMapping() Line 571: Line 572: def _validateNotMetadataPV(self, guid): Line 573: lvm_metadata_pv, _ = lvm.getFirstExt(self.sdUUID, sd.METADATA) Line 574: if lvm.isSamePV(lvm_metadata_pv, guid): We don't need this helper. guid is always a guid, it should not be a device path. We must be super strict about what we accept in the api. If a user send a path instead of guid the request should fail when creating the job. Since we know guid is not a path, we don't need to normalize it. lvm.getFirstExt returns single format. If it returns a path, use os.path.basename() to the the guid. If it returns a guid, we are done. Line 575: raise se.CouldNotPerformOperationOnStorageDomainMetadataPV(guid) Line 576: Line 577: def getVolumeClass(self): Line 578: """ Line 571: Line 572: def _validateNotMetadataPV(self, guid): Line 573: lvm_metadata_pv, _ = lvm.getFirstExt(self.sdUUID, sd.METADATA) Line 574: if lvm.isSamePV(lvm_metadata_pv, guid): Line 575: raise se.CouldNotPerformOperationOnStorageDomainMetadataPV(guid) Error name is too long - how about CannotChangeMetadataPV? Line 576: Line 577: def getVolumeClass(self): Line 578: """ Line 579: Return a type specific volume generator object https://gerrit.ovirt.org/#/c/63270/2/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 780: :type sdUUID: UUID Line 781: :param guid: A block device GUID Line 782: :type guid: str Line 783: """ Line 784: job = sdm.api.move_sd_device_data.Job(jobUUID, 1, sdUUID, guid) Need to document why host_id=1 is correct in this case. If we have more code, maybe we need a constant like DETACHED_HOST_ID. Line 785: self.sdm_schedule(job) Line 786: Line 787: def _deatchStorageDomainFromOldPools(self, sdUUID): Line 788: # We are called with blank pool uuid, to avoid changing exiting https://gerrit.ovirt.org/#/c/63270/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 692: return pv Line 693: Line 694: Line 695: def isSamePV(pv_a, pv_b): Line 696: return _fqpvname(pv_a) == _fqpvname(pv_b) I don't like this normalization orgy. The module should accept only guid or only path device, but not both. These kind of helpers hide bugs in caller code. Line 697: Line 698: Line 699: def _createpv(devices, metadataSize, options=tuple()): Line 700: """ Line 889: Line 890: def _hasDataToMove(pvName): Line 891: pv = getPV(pvName) Line 892: if pv.pe_alloc_count == "0": Line 893: return False This helper is not very useful in this module, so better inline it in the function. Line 894: Line 895: return True Line 896: Line 897: def movePV(vgName, guid): Line 901: Raises se.CouldNotMovePhysicalVolumeData if pvmove fails Line 902: """ Line 903: pvName = _fqpvname(guid) Line 904: if not _hasDataToMove(pvName): Line 905: return Inlining _hasDataToMove is more clear: pv = getPV(pvName) if pv.pe_alloc_count == "0": return Line 906: Line 907: cmd = ["pvmove", pvName] Line 908: rc, out, err = _lvminfo.cmd(cmd) Line 909: if rc != 0: Line 904: if not _hasDataToMove(pvName): Line 905: return Line 906: Line 907: cmd = ["pvmove", pvName] Line 908: rc, out, err = _lvminfo.cmd(cmd) We must use filter including the devices belonging to this vg. Otherwise lvm will go and read all the devices in the system, which is very slow. This should work: ... = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName,))) Line 909: if rc != 0: Line 910: raise se.CouldNotMovePhysicalVolumeData(pvName, err) Line 911: Line 912: _lvminfo._invalidatepvs(pvName) Line 906: Line 907: cmd = ["pvmove", pvName] Line 908: rc, out, err = _lvminfo.cmd(cmd) Line 909: if rc != 0: Line 910: raise se.CouldNotMovePhysicalVolumeData(pvName, err) Exception name is too long, can we shorten it? Line 911: Line 912: _lvminfo._invalidatepvs(pvName) Line 913: _lvminfo._invalidatevgs(vgName) Line 914: Line 909: if rc != 0: Line 910: raise se.CouldNotMovePhysicalVolumeData(pvName, err) Line 911: Line 912: _lvminfo._invalidatepvs(pvName) Line 913: _lvminfo._invalidatevgs(vgName) We need to invalidate all lvs in to this vg, since some of them has moved to another pv. This should work: _lvminfo._invalidatelvs(vgName) Line 914: Line 915: Line 916: def getVG(vgName): Line 917: vg = _lvminfo.getVg(vgName) # returns single VG namedtuple https://gerrit.ovirt.org/#/c/63270/2/vdsm/storage/sd.py File vdsm/storage/sd.py: Line 367: def resize
Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name
Edward Haas has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63990/1//COMMIT_MSG Commit Message: Line 12: If the host is set initially by Network Manager, the names of the files Line 13: do no correspond to the expected format. Line 14: Line 15: This patch adjusts the ifcfg file name to the mentioned format and Line 16: erases any other ifcfg files that correspond to the same device. > Maybe AUTOCONNECT_PRIORITY in `man nm-settings-ifcfg-rh` would help. Perhaps I should elaborate more in the commit message. It is not meant to be NM friendly, it is aimed to 'fix' NM ifcfg files so VDSM can consume it. NM is disabled already. As far as I know, it is not valid to have multiple ifcfg files using the same device with VDSM. And I think only NM can work with multiple ifcfg files as part of the 'connection' definition. Line 17: Line 18: Change-Id: I0bf70ba936d5de1f17a90742644719216018f674 Line 19: TODO: Add functional tests. -- To view, visit https://gerrit.ovirt.org/63990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: implementing StorageDomain.movePV
Nir Soffer has posted comments on this change. Change subject: implementing StorageDomain.movePV .. Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/63270/2/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 545 Line 546 Line 547 Line 548 Line 549 Same... Line 552 Line 553 Line 554 Line 555 Line 556 Same issue with successful lvm command and failure to update mapping in old code... Line 559: Line 560: def movePV(self, guid): Line 561: self._validateNotMetadataPV(guid) Line 562: with self._extendlock: Line 563: lvm.movePV(self.sdUUID, guid) updateMapping should be needed only for domain version 0 - do we want to support removing devices on such domains? I guess not. If we want to support old domains, we must run update mapping even if movePV failed, since some extents may have moved, changing the pv mapping. Note that if both movePV and updateMapping failed, we should raise the original error from movePV, with the original traceback. We can do this: try: lvm.movePV(self.sdUUID, guid) except Exception: exc = sys.exc_info() else: exc = None try: self.updateMapping() except Exception: if exc is None: raise log.exception("descrption...") if exc: try: six.reraise(*exc) finally: del exc If updateMapping failed, we are left with incorrect mapping, not sure the current code can handle this case. Line 564: self.updateMapping() Line 565: Line 566: def reduceDevice(self, guid): Line 567: self._validateNotMetadataPV(guid) Line 565: Line 566: def reduceDevice(self, guid): Line 567: self._validateNotMetadataPV(guid) Line 568: with self._extendlock: Line 569: lvm.reduceVG(self.sdUUID, guid) No error handling here is fine, assuming that reduceVG remove the pv only if it was successful. However, what engine is going to do if reduceVG succeed, but updateMapping failed? the call will fail, but the pv was removed. Line 570: self.updateMapping() Line 571: Line 572: def _validateNotMetadataPV(self, guid): Line 573: lvm_metadata_pv, _ = lvm.getFirstExt(self.sdUUID, sd.METADATA) Line 569: lvm.reduceVG(self.sdUUID, guid) Line 570: self.updateMapping() Line 571: Line 572: def _validateNotMetadataPV(self, guid): Line 573: lvm_metadata_pv, _ = lvm.getFirstExt(self.sdUUID, sd.METADATA) Why the lvm_ prefix? do we have other kind of metadata_pv? Line 574: if lvm.isSamePV(lvm_metadata_pv, guid): Line 575: raise se.CouldNotPerformOperationOnStorageDomainMetadataPV(guid) Line 576: Line 577: def getVolumeClass(self): -- To view, visit https://gerrit.ovirt.org/63270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74183d13061d114a59da23874c86186457046e94 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Define the StorageDomain.reduce API
Nir Soffer has posted comments on this change. Change subject: Define the StorageDomain.reduce API .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62853/3/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 8216: - description: A UUID to be used for tracking the job progress Line 8217: name: jobID Line 8218: type: *UUID Line 8219: Line 8220: - description: The UUID of the Storage Domain > Why isn't the SD UUID the first param? (I see in most cases it is, that's a New storage apis are always running in a job, and accept job_id generated by engine as the first argument. See for example SDM.copy_data. Old apis running asynchronously return a task uuid. If communication between engine and vdsm brake before engine got a reply, it does not have any way to detect the task created in vdsm. New apis also use complex argument(s) so we don't have to pass around so many arguments via the different layers, and we can validate the input automatically using properties, see vdsm/storage/sdm/api/copy_data.py. Line 8221: name: storagedomainID Line 8222: type: *UUID Line 8223: Line 8224: - description: A block device GUID -- To view, visit https://gerrit.ovirt.org/62853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Define the StorageDomain.reduce API
Nir Soffer has posted comments on this change. Change subject: Define the StorageDomain.reduce API .. Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/62853/7/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 8228: type: *UUID Line 8229: Line 8230: - description: A block device GUID Line 8231: name: guid Line 8232: type: string I would like to have new style api similar to copy_data. This is also more correct as this operation is not really performed on the storage domain object, but passed to irs anyway, and run in a job. Line 8233: Line 8234: StorageDomain.resizePV: Line 8235: added: '3.6' Line 8236: description: Resize PV will cause the PV to use the entire size of the https://gerrit.ovirt.org/#/c/62853/7/vdsm/API.py File vdsm/API.py: Line 1078: def extend(self, storagepoolID, devlist, force=False): Line 1079: return self._irs.extendStorageDomain(self._UUID, storagepoolID, Line 1080: devlist, force) Line 1081: Line 1082: def reduce(self, jobID, guid): Please use the same name in all layers (jobID or jobUUID or job_id). Line 1083: return self._irs.reduceStorageDomain(jobID, self._UUID, guid) Line 1084: Line 1085: def resizePV(self, storagepoolID, guid): Line 1086: return self._irs.resizePV(self._UUID, storagepoolID, guid) https://gerrit.ovirt.org/#/c/62853/7/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 747: """ Line 748: Reduce a block-based Storage Domain by removing a device from it. Line 749: Line 750: :param UUID: The UUID of the job. Line 751: :type UUID: UUID UUID -> jobUUID Line 752: :param sdUUID: The UUID of the storage domain that owns the PV. Line 753: :type sdUUID: UUID Line 754: :param guid: A block device GUID Line 755: :type guid: str -- To view, visit https://gerrit.ovirt.org/62853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: upgrade: Support upgrade from v3 to v4.
Nir Soffer has posted comments on this change. Change subject: upgrade: Support upgrade from v3 to v4. .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: api: Use default argument instead of None
gerrit-hooks has posted comments on this change. Change subject: api: Use default argument instead of None .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie62aaca2271219e17ef86a70c09bfee5f13d1ec5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: api: Use default argument instead of None
Nir Soffer has uploaded a new change for review. Change subject: api: Use default argument instead of None .. api: Use default argument instead of None Since the supported versions are constant, we can define the default value during import time. Change-Id: Ie62aaca2271219e17ef86a70c09bfee5f13d1ec5 Signed-off-by: Nir Soffer --- M vdsm/API.py 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/64043/1 diff --git a/vdsm/API.py b/vdsm/API.py index 57a30df..05542af 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -1056,9 +1056,8 @@ def attach(self, storagepoolID): return self._irs.attachStorageDomain(self._UUID, storagepoolID) -def create(self, domainType, typeArgs, name, domainClass, version=None): -if version is None: -version = constants.SUPPORTED_DOMAIN_VERSIONS[0] +def create(self, domainType, typeArgs, name, domainClass, + version=constants.SUPPORTED_DOMAIN_VERSIONS[0]): return self._irs.createStorageDomain(domainType, self._UUID, name, typeArgs, domainClass, version) -- To view, visit https://gerrit.ovirt.org/64043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie62aaca2271219e17ef86a70c09bfee5f13d1ec5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ResourceManagerLock: Disable autoRelease
Nir Soffer has posted comments on this change. Change subject: ResourceManagerLock: Disable autoRelease .. Patch Set 1: Code-Review+2 I hate resourceManager, we must kill it soon. -- To view, visit https://gerrit.ovirt.org/63967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie70dca0079f773362bfebe6b9a08677c94314e68 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "build tests: Require NOSE 1.3.7 and up for running t...
Edward Haas has posted comments on this change. Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running tests" .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/64035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I175c0752a5929d1b644cd41cf8d111bcce10f32d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: build: Disable tests during build
Edward Haas has posted comments on this change. Change subject: build: Disable tests during build .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/63966/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-09-15 01:45:00 +0300 Line 6: Line 7: build: Disable tests during build Line 8: Line 9: Tests are needed for development, not for building a package. This > or skip the test on "broken" systems with buggy nose, until nose is fixed. Sounds like the 'skip' pattern. Being consistent is important, tests should either run or not, either pass or fail. Mixing is not helpful. I do not see the benefit of testing as part of creating rpms. This is a flow that makes sense to me: [develop]-->[run tests]-->[compile]-->[run all tests]-->[commit] After that is over, we assume the commits on the branch are stable and fully tested. At that point we go and build the deployment packages. There is no reason to run unit tests at that point, we MUST assume they are ok, otherwise something in the flow is broken. Line 10: allows us to use latest and greatest development tools, which are not Line 11: available in brew or koji. Line 12: Line 13: Since we install nose using pip, remove the build requires - we don't -- To view, visit https://gerrit.ovirt.org/63966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "build tests: Require NOSE 1.3.7 and up for running t...
Nir Soffer has posted comments on this change. Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running tests" .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I175c0752a5929d1b644cd41cf8d111bcce10f32d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net tests: Remove redundant label from func test template.
Edward Haas has posted comments on this change. Change subject: net tests: Remove redundant label from func test template. .. Patch Set 1: Verified-1 This will no longer pass due to: https://gerrit.ovirt.org/#/c/64035/ -- To view, visit https://gerrit.ovirt.org/63931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f75bb1d6aabceceff65d673ec776cd5b5c939c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "build tests: Require NOSE 1.3.7 and up for running t...
gerrit-hooks has posted comments on this change. Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running tests" .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I175c0752a5929d1b644cd41cf8d111bcce10f32d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "build tests: Require NOSE 1.3.7 and up for running t...
Edward Haas has uploaded a new change for review. Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running tests" .. Revert "build tests: Require NOSE 1.3.7 and up for running tests" NOSE is used during the VDSM build ('make rpm') where builders do not use pip, just rpms provided by the standard repos. Therefore, enforcing the nose version of 1.3.7 is not possible until it is updated in the repos of centos7/rhel7. This reverts commit 4e729ddd2b243d0953e2de5d31c42fc59859bf23. Change-Id: I175c0752a5929d1b644cd41cf8d111bcce10f32d Signed-off-by: Edward Haas --- M Makefile.am 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/64035/1 diff --git a/Makefile.am b/Makefile.am index 51fe2a5..aefd2b3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -132,12 +132,7 @@ .PHONY: tests tests: - @version=`nosetests --version | cut -d' ' -f3`; \ - if build-aux/vercmp $$version "1.3.7"; then \ - echo "Error: NOSE is too old, please install NOSE 1.3.7 or later"; \ - exit 1; \ - fi - @$(MAKE) -C tests/ check + $(MAKE) -C tests/ check all-local: \ vdsm.spec -- To view, visit https://gerrit.ovirt.org/64035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I175c0752a5929d1b644cd41cf8d111bcce10f32d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: add a repo with a fresh nose
Edward Haas has posted comments on this change. Change subject: automation: add a repo with a fresh nose .. Patch Set 1: This makes no sense to me, it's a mess. I am reverting the nose 1.3.7 hard requirement. -- To view, visit https://gerrit.ovirt.org/63986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lib: move the response.py under common
Nir Soffer has posted comments on this change. Change subject: lib: move the response.py under common .. Patch Set 2: Francesco, can you verify? -- To view, visit https://gerrit.ovirt.org/63954 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6263fb8991a226516ba5d14e909a4a70ea0078d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lib: move define.py under common
Nir Soffer has posted comments on this change. Change subject: lib: move define.py under common .. Patch Set 1: Francesco, can you verify? -- To view, visit https://gerrit.ovirt.org/63953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I634d3bac718fe0615a2aca951ec47b976967ada1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lib: move exception.py under common
Nir Soffer has posted comments on this change. Change subject: lib: move exception.py under common .. Patch Set 1: Francesco, can you verify? -- To view, visit https://gerrit.ovirt.org/63952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7742aa7dafe0e0e29044536ad19fbddbcab0f420 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: stomp: use socket pending
gerrit-hooks has posted comments on this change. Change subject: stomp: use socket pending .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/63482 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: Remove useless volume size monitoring
Nir Soffer has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 2: Verified-1 Rebae on master, fixing merge conflicts, no code change. I found that we report these values to engine, so the patch cannot be used as is, we should either stop reporting the values or collect them in a less risky way. -- To view, visit https://gerrit.ovirt.org/59801 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1436c2968f3e408ce38a913c6ca3146a25a312d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: Remove useless volume size monitoring
gerrit-hooks has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59801 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1436c2968f3e408ce38a913c6ca3146a25a312d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: API: modernize VM methods
Nir Soffer has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 15: Code-Review-1 Please address comments from version 9: https://gerrit.ovirt.org/#/c/61475/9/vdsm/API.py -- To view, visit https://gerrit.ovirt.org/61475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lib: move the response.py under common
Piotr Kliczewski has posted comments on this change. Change subject: lib: move the response.py under common .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63954 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6263fb8991a226516ba5d14e909a4a70ea0078d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lib: move define.py under common
Piotr Kliczewski has posted comments on this change. Change subject: lib: move define.py under common .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I634d3bac718fe0615a2aca951ec47b976967ada1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lib: move exception.py under common
Piotr Kliczewski has posted comments on this change. Change subject: lib: move exception.py under common .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7742aa7dafe0e0e29044536ad19fbddbcab0f420 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lib: response: helper to detect valid responses
Nir Soffer has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 12: Code-Review-1 (1 comment) -1 so we dont forget the missing docstring https://gerrit.ovirt.org/#/c/63760/12/lib/vdsm/common/response.py File lib/vdsm/common/response.py: Line 85: else: Line 86: return code != doneCode["code"] Line 87: Line 88: Line 89: def is_valid(res): docstring still missing Line 90: # catching AttributeError is even uglier Line 91: if not isinstance(res, dict): Line 92: return False Line 93: try: -- To view, visit https://gerrit.ovirt.org/63760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifab6a25bea1b4a187d8425275e86bdb2fecf4c7d Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: add a repo with a fresh nose
Nir Soffer has posted comments on this change. Change subject: automation: add a repo with a fresh nose .. Patch Set 1: Code-Review+1 This fixes the build in jenkins, but does not fix the build in brew/koji. -- To view, visit https://gerrit.ovirt.org/63986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: draft: Hook nic_libvirt_migration_destination, proposal 2
gerrit-hooks has posted comments on this change. Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60e4cc7f801033cc830aa1a0aad32afecafe4fea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: add a repo with a fresh nose
Irit Goihman has posted comments on this change. Change subject: automation: add a repo with a fresh nose .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: draft: vm_migration_libvirt_hook_plugins
gerrit-hooks has posted comments on this change. Change subject: draft: vm_migration_libvirt_hook_plugins .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e13a94fa28968e37cd2d4d99fe540c8b762f7cc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: draft: vm_migration_libvirt_hook_plugins
Marcin Mirecki has uploaded a new change for review. Change subject: draft: vm_migration_libvirt_hook_plugins .. draft: vm_migration_libvirt_hook_plugins Quick draft for vm migration libvirt hook plugins Change-Id: I7e13a94fa28968e37cd2d4d99fe540c8b762f7cc Signed-off-by: mirecki --- M vdsm/virt/vm_migrate_hook.py A vdsm/virt/vm_migrate_plugins/__init__.py 2 files changed, 72 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/64001/1 diff --git a/vdsm/virt/vm_migrate_hook.py b/vdsm/virt/vm_migrate_hook.py index 633e4f0..063fdd0 100755 --- a/vdsm/virt/vm_migrate_hook.py +++ b/vdsm/virt/vm_migrate_hook.py @@ -28,6 +28,8 @@ from vdsm.config import config from vdsm.network import api as net_api +import vm_migrate_plugins + _DEBUG_MODE = False LOG_FILE = '/tmp/libvirthook_ovs_migrate.log' @@ -82,24 +84,29 @@ def _set_bridge_interfaces(devices, target_vm_conf): -target_vm_nets_by_vnic_mac = {dev['macAddr']: dev['network'] - for dev in target_vm_conf['devices'] - if dev.get('type') == 'interface'} +target_vm_conf_by_mac = {dev['macAddr']: dev + for dev in target_vm_conf['devices'] + if dev.get('type') == 'interface'} + for interface in devices.findall('interface'): if interface.get('type') == 'bridge': -_bind_iface_to_bridge(interface, target_vm_nets_by_vnic_mac) +_bind_iface_to_bridge(interface, target_vm_conf_by_mac) -def _bind_iface_to_bridge(interface, target_vm_nets_by_vnic_mac): +def _bind_iface_to_bridge(interface, target_vm_conf_by_mac): elem_macaddr = interface.find('mac') mac_addr = elem_macaddr.get('address') -target_vm_net = target_vm_nets_by_vnic_mac[mac_addr] -target_ovs_bridge = net_api.ovs_bridge(target_vm_net) -if target_ovs_bridge: -_bind_iface_to_ovs_bridge(interface, target_ovs_bridge, target_vm_net) -else: -_bind_iface_to_linux_bridge(interface, target_vm_net) +interface_conf = target_vm_conf_by_mac[mac_addr] +target_vm_net = interface_conf['network'] +if vm_migrate_plugins.do_default_processing(interface, interface_conf): +target_ovs_bridge = net_api.ovs_bridge(target_vm_net) +if target_ovs_bridge: +_bind_iface_to_ovs_bridge(interface, target_ovs_bridge, + target_vm_net) +else: +_bind_iface_to_linux_bridge(interface, target_vm_net) +vm_migrate_plugins.process(interface, interface_conf) def _bind_iface_to_ovs_bridge(interface, target_ovs_bridge, target_vm_net): diff --git a/vdsm/virt/vm_migrate_plugins/__init__.py b/vdsm/virt/vm_migrate_plugins/__init__.py new file mode 100644 index 000..3e4b090 --- /dev/null +++ b/vdsm/virt/vm_migrate_plugins/__init__.py @@ -0,0 +1,54 @@ +# Copyright 2016 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# +# Refer to the README and COPYING files for full details of the license +# + +import abc +from importlib import import_module +from pkgutil import iter_modules + +import six + + +_DRIVERS = [] + + +def do_default_processing(domxml, device_conf): +result = True +for driver in _DRIVERS: +result = result and driver.create().do_default_processing(domxml, + device_conf) +return result + + +def process(domxml, device_conf): +for driver in _DRIVERS: +driver.create().process(domxml, device_conf) + + +class VmMigrateDriver(): + +@abc.abstractmethod +def do_default_processing(self, domxml, device_conf): +pass + +@abc.abstractmethod +def process(self, domxml, device_conf): +pass + +for _, module, _ in iter_modules([__path__[0]]): +_DRIVERS.append(import_module('{}.{}'.format(__name__, module))) -- To view, visit https://gerrit.ovirt.org/64001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7e13a94fa28968e37cd2d4d99fe540c8b762f7cc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki __
Change in vdsm[master]: Add new api to get the IO tune policies for all vms
Jenny Tokar has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/63748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jenny Tokar Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/63517/3/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 1187: vmName = node.find('./ovf:VirtualSystem/ovf:Name', ns) Line 1188: if vmName is not None: Line 1189: vm['vmName'] = vmName.text Line 1190: else: Line 1191: vm['vmName'] = os.path.splitext(os.path.basename(ova_path))[0] > nice idea. This could not raise, right? IMO it's safe. Line 1192: Line 1193: memSize = node.find('.//ovf:Item[rasd:ResourceType="%d"]/' Line 1194: 'rasd:VirtualQuantity' % _OVF_RESOURCE_MEMORY, ns) Line 1195: if memSize is not None: -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jobs: Guard against racy state changes
Nir Soffer has posted comments on this change. Change subject: jobs: Guard against racy state changes .. Patch Set 6: Code-Review-1 Please check this failing test: 13:17:35 == 13:17:35 FAIL: test_abort_running_job (jobsTests.JobsTests) 13:17:35 -- 13:17:35 Traceback (most recent call last): 13:17:35 File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/jobsTests.py", line 203, in test_abort_running_job 13:17:35 self.assertEqual(jobs.STATUS.RUNNING, job.status) 13:17:35 AssertionError: 'running' != 'pending' -- To view, visit https://gerrit.ovirt.org/63712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5366fcb962e9d34da6fca47b5171a6b132cf2e3b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sdm: Jobs may be run only when status=pending
gerrit-hooks has posted comments on this change. Change subject: sdm: Jobs may be run only when status=pending .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I601f6db19527635c1a00c3a4c2910eac4ac5371b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sdm: Jobs may be run only when status=pending
Adam Litke has abandoned this change. Change subject: sdm: Jobs may be run only when status=pending .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I601f6db19527635c1a00c3a4c2910eac4ac5371b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: wip: copy_data take resource locks
gerrit-hooks has posted comments on this change. Change subject: wip: copy_data take resource locks .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b008c38dab5478f13175659bd2103e994802cf7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: wip: copy_data take resource locks
Adam Litke has abandoned this change. Change subject: wip: copy_data take resource locks .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1b008c38dab5478f13175659bd2103e994802cf7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: wip: copy_data locking
gerrit-hooks has posted comments on this change. Change subject: wip: copy_data locking .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/60825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie44e1f1709ee81c14b3d165bbf3a6597ac50b68e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: wip: copy_data locking
Adam Litke has abandoned this change. Change subject: wip: copy_data locking .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/60825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie44e1f1709ee81c14b3d165bbf3a6597ac50b68e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Move TestingJob to sdmtestlib
gerrit-hooks has posted comments on this change. Change subject: tests: Move TestingJob to sdmtestlib .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf4b1707f3e6a56918a52511f23e21ead1bd5adc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Move TestingJob to sdmtestlib
Adam Litke has abandoned this change. Change subject: tests: Move TestingJob to sdmtestlib .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibf4b1707f3e6a56918a52511f23e21ead1bd5adc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sdm: Wire up when_finished callback
gerrit-hooks has posted comments on this change. Change subject: sdm: Wire up when_finished callback .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8db3abc6e57a4a06b90ea1c7bb4186b0b936a152 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jobs: Add when_finished callback and wire up abort
gerrit-hooks has posted comments on this change. Change subject: jobs: Add when_finished callback and wire up abort .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73d4c167a4cf1f1da4c1e2629b7afa9c01d338fd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sdm: Autoclear sdm jobs when finished
gerrit-hooks has posted comments on this change. Change subject: sdm: Autoclear sdm jobs when finished .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I666b65d3a73380d786ac1695e4de5c3c7923effd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sdm: Wire up when_finished callback
Adam Litke has abandoned this change. Change subject: sdm: Wire up when_finished callback .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8db3abc6e57a4a06b90ea1c7bb4186b0b936a152 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sdm: Autoclear sdm jobs when finished
Adam Litke has abandoned this change. Change subject: sdm: Autoclear sdm jobs when finished .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I666b65d3a73380d786ac1695e4de5c3c7923effd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Pass the Scheduler instance to HSM
gerrit-hooks has posted comments on this change. Change subject: Pass the Scheduler instance to HSM .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/61253 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0db5a0dd3f519737a554550efb785d8099d02a6f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jobs: Add when_finished callback and wire up abort
Adam Litke has abandoned this change. Change subject: jobs: Add when_finished callback and wire up abort .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I73d4c167a4cf1f1da4c1e2629b7afa9c01d338fd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Pass the Scheduler instance to HSM
Adam Litke has abandoned this change. Change subject: Pass the Scheduler instance to HSM .. Abandoned Alternate solution merged. -- To view, visit https://gerrit.ovirt.org/61253 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0db5a0dd3f519737a554550efb785d8099d02a6f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: gluster: set selinux labels while creating bricks
Ramesh N has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 5: Gluster has an selinux policy which expects the brick dirs to have specific selinux context/label set. Brick dirs are created as part of createBrick vdsm verb and we are trying to set selinux context on the newly created brick dirs. In case of gluster brick creation, user can choose any dir as brick mountpoint and create brick directory under the mount point. This is different from other cases where we always create dirs in a predefined path without any user intervention. So how can we ensure that correct labels are set on these newly created brick dirs? -- To view, visit https://gerrit.ovirt.org/62773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Shahar Havivi has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 3: > (1 comment) no, it works without extension as well: print os.path.splitext(os.path.basename("/a/b/c"))[0] -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Add tests for un-escaping spaces
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for un-escaping spaces .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I772b7e7e48f888f9b9790cd6963d65cd86912699 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Simplify deleted suffix stripping
gerrit-hooks has posted comments on this change. Change subject: mount: Simplify deleted suffix stripping .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb08af0a6a5e7202741cda8b39fe3cddac468b21 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support
gerrit-hooks has posted comments on this change. Change subject: mount: Remove EL 6 /etc/mtab support .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49a66b19924accc93f626eca98b2e91a3b7f5e80 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Don't un-escape mount options
gerrit-hooks has posted comments on this change. Change subject: mount: Don't un-escape mount options .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7f666a565b9db9e4a713516f96a61aab535c596 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mounts: Use more meaningful names
gerrit-hooks has posted comments on this change. Change subject: mounts: Use more meaningful names .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac1ba474856c9cf9f66d05dcce7ed152cbe2147b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Add missing test for deleted mounts
gerrit-hooks has posted comments on this change. Change subject: tests: Add missing test for deleted mounts .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id280a9e8e3d6db273eb3398dd38e4553750c4631 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: mount: Fix un-escaping of spaces
gerrit-hooks has posted comments on this change. Change subject: mount: Fix un-escaping of spaces .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaddcb8c023f80d4284b28ad070fd833374c3e857 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: test ovs info with southbound nic
gerrit-hooks has posted comments on this change. Change subject: net: test ovs info with southbound nic .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd3ab225172a0edfda9bb998c509ed3c2e318401 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org