Edward Haas has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63990/1//COMMIT_MSG Commit Message: Line 12: If the host is set initially by Network Manager, the names of the files Line 13: do no correspond to the expected format. Line 14: Line 15: This patch adjusts the ifcfg file name to the mentioned format and Line 16: erases any other ifcfg files that correspond to the same device. > Maybe AUTOCONNECT_PRIORITY in `man nm-settings-ifcfg-rh` would help. Perhaps I should elaborate more in the commit message. It is not meant to be NM friendly, it is aimed to 'fix' NM ifcfg files so VDSM can consume it. NM is disabled already. As far as I know, it is not valid to have multiple ifcfg files using the same device with VDSM. And I think only NM can work with multiple ifcfg files as part of the 'connection' definition. Line 17: Line 18: Change-Id: I0bf70ba936d5de1f17a90742644719216018f674 Line 19: TODO: Add functional tests. -- To view, visit https://gerrit.ovirt.org/63990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org