[webkit-changes] [109082] trunk/LayoutTests

[commit-queue]

Title: [109082] trunk/LayoutTests








Revision 109082
Author commit-qu...@webkit.org
Date 2012-02-27 23:02:01 -0800 (Mon, 27 Feb 2012)


Log Message
LayoutTests/fast/forms/number/input-number-events.html is failing since r108228
https://bugs.webkit.org/show_bug.cgi?id=79329

Remove trailing whitespace which makes test failure.

Patch by Yoshifumi Inoue  on 2012-02-27
Reviewed by Kent Tamura.

* fast/forms/number/input-number-events-expected.txt: Remove trailing whitespace at line 11.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/number/input-number-events-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (109081 => 109082)

--- trunk/LayoutTests/ChangeLog	2012-02-28 06:57:03 UTC (rev 109081)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 07:02:01 UTC (rev 109082)
@@ -1,3 +1,14 @@
+2012-02-27  Yoshifumi Inoue  
+
+LayoutTests/fast/forms/number/input-number-events.html is failing since r108228
+https://bugs.webkit.org/show_bug.cgi?id=79329
+
+Remove trailing whitespace which makes test failure.
+
+Reviewed by Kent Tamura.
+
+* fast/forms/number/input-number-events-expected.txt: Remove trailing whitespace at line 11.
+
 2012-02-27  David Barton  
 
 Fix  formatting, especially for a tall base, subscript, or superscript


Modified: trunk/LayoutTests/fast/forms/number/input-number-events-expected.txt (109081 => 109082)

--- trunk/LayoutTests/fast/forms/number/input-number-events-expected.txt	2012-02-28 06:57:03 UTC (rev 109081)
+++ trunk/LayoutTests/fast/forms/number/input-number-events-expected.txt	2012-02-28 07:02:01 UTC (rev 109082)
@@ -8,7 +8,7 @@
 PASS inputEventCounter is 0
 Click the upper button
 PASS numberInput.value is "1"
-PASS changeEventCounter is 1 
+PASS changeEventCounter is 1
 PASS inputEventCounter is 1
 Click again, but the value is not changed.
 PASS numberInput.value is "1"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109080] trunk/Source/WebCore

[commit-queue]

Title: [109080] trunk/Source/WebCore








Revision 109080
Author commit-qu...@webkit.org
Date 2012-02-27 22:49:21 -0800 (Mon, 27 Feb 2012)


Log Message
kCTFontTableOptionExcludeSynthetic is unneeded
https://bugs.webkit.org/show_bug.cgi?id=79744

Patch by Ned Holbrook  on 2012-02-27
Reviewed by Dan Bernstein.

The aforementioned option is a no-op, so no new tests.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::fontHasVerticalGlyphs): Specify no options.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (109079 => 109080)

--- trunk/Source/WebCore/ChangeLog	2012-02-28 06:47:29 UTC (rev 109079)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 06:49:21 UTC (rev 109080)
@@ -1,3 +1,15 @@
+2012-02-27  Ned Holbrook  
+
+kCTFontTableOptionExcludeSynthetic is unneeded
+https://bugs.webkit.org/show_bug.cgi?id=79744
+
+Reviewed by Dan Bernstein.
+
+The aforementioned option is a no-op, so no new tests.
+
+* platform/graphics/mac/SimpleFontDataMac.mm:
+(WebCore::fontHasVerticalGlyphs): Specify no options.
+
 2012-02-27  Wei James  
 
 Multi-Channel support in AudioBufferSourceNode


Modified: trunk/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm (109079 => 109080)

--- trunk/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm	2012-02-28 06:47:29 UTC (rev 109079)
+++ trunk/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm	2012-02-28 06:49:21 UTC (rev 109080)
@@ -57,7 +57,7 @@
 static bool fontHasVerticalGlyphs(CTFontRef ctFont)
 {
 // The check doesn't look neat but this is what AppKit does for vertical writing...
-RetainPtr tableTags(AdoptCF, CTFontCopyAvailableTables(ctFont, kCTFontTableOptionExcludeSynthetic));
+RetainPtr tableTags(AdoptCF, CTFontCopyAvailableTables(ctFont, kCTFontTableOptionNoOptions));
 CFIndex numTables = CFArrayGetCount(tableTags.get());
 for (CFIndex index = 0; index < numTables; ++index) {
 CTFontTableTag tag = (CTFontTableTag)(uintptr_t)CFArrayGetValueAtIndex(tableTags.get(), index);
@@ -72,7 +72,6 @@
 if (!fontData->platformData().cgFont())
 return false;
 
-
 return true;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109079] trunk/LayoutTests

[ossy]

Title: [109079] trunk/LayoutTests








Revision 109079
Author o...@webkit.org
Date 2012-02-27 22:47:29 -0800 (Mon, 27 Feb 2012)


Log Message
[Qt] Unreviewed morning gardening.

* platform/qt/Skipped: Skip new failing tests.
* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (109078 => 109079)

--- trunk/LayoutTests/ChangeLog	2012-02-28 06:34:10 UTC (rev 109078)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 06:47:29 UTC (rev 109079)
@@ -1,3 +1,10 @@
+2012-02-27  Csaba Osztrogonác  
+
+[Qt] Unreviewed morning gardening.
+
+* platform/qt/Skipped: Skip new failing tests.
+* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
+
 2012-02-27  Wei James  
 
 Multi-Channel support in AudioBufferSourceNode


Modified: trunk/LayoutTests/platform/qt/Skipped (109078 => 109079)

--- trunk/LayoutTests/platform/qt/Skipped	2012-02-28 06:34:10 UTC (rev 109078)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-02-28 06:47:29 UTC (rev 109079)
@@ -239,6 +239,7 @@
 fast/mutation/callback-second-argument.html
 fast/mutation/cross-document.html
 fast/mutation/database-callback-delivery.html
+fast/mutation/disconnect-cancel-pending.html
 fast/mutation/inline-event-listener.html
 fast/mutation/mutation-observer-constructor.html
 fast/mutation/mutation-callback-non-element-crash.html
@@ -2653,3 +2654,8 @@
 # [Qt] transitions/cancel-transition.html fails
 # https://bugs.webkit.org/show_bug.cgi?id=79564
 transitions/cancel-transition.html
+
+# Printed font-size should not be dependant on zoom level
+# New test introduced in r109073 fails on Qt
+# https://bugs.webkit.org/show_bug.cgi?id=79717
+printing/zoomed-document.html


Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (109078 => 109079)

--- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt	2012-02-28 06:34:10 UTC (rev 109078)
+++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt	2012-02-28 06:47:29 UTC (rev 109079)
@@ -1060,6 +1060,7 @@
 window.FileList.prototype [object FileListPrototype]
 window.FileList.prototype.item [function]
 window.FormData [object FormDataConstructor]
+window.FormData.length [number]
 window.FormData.prototype [object FormDataPrototype]
 window.FormData.prototype.append [function]
 window.Function [function]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109078] trunk/Source/WebKit/chromium

[koz]

Title: [109078] trunk/Source/WebKit/chromium








Revision 109078
Author k...@chromium.org
Date 2012-02-27 22:34:10 -0800 (Mon, 27 Feb 2012)


Log Message
Add missing parameter to didCreateScriptContext() so it overrides base class again.
https://bugs.webkit.org/show_bug.cgi?id=79742

Reviewed by Kent Tamura.

* tests/WebFrameTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (109077 => 109078)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-28 06:12:45 UTC (rev 109077)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-28 06:34:10 UTC (rev 109078)
@@ -1,3 +1,12 @@
+2012-02-27  James Kozianski  
+
+Add missing parameter to didCreateScriptContext() so it overrides base class again.
+https://bugs.webkit.org/show_bug.cgi?id=79742
+
+Reviewed by Kent Tamura.
+
+* tests/WebFrameTest.cpp:
+
 2012-02-27  Kenichi Ishibashi  
 
 [Chromium] Unreviewed gardening, Disable TransparencyWin.OpaqueCompositeLayerPixel


Modified: trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp (109077 => 109078)

--- trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp	2012-02-28 06:12:45 UTC (rev 109077)
+++ trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp	2012-02-28 06:34:10 UTC (rev 109078)
@@ -322,12 +322,12 @@
 std::vector releaseNotifications;
 
  private:
-virtual void didCreateScriptContext(WebFrame* frame, v8::Handle context, int worldId)
+virtual void didCreateScriptContext(WebFrame* frame, v8::Handle context, int extensionGroup, int worldId) OVERRIDE
 {
 createNotifications.push_back(new Notification(frame, context, worldId));
 }
 
-virtual void willReleaseScriptContext(WebFrame* frame, v8::Handle context, int worldId)
+virtual void willReleaseScriptContext(WebFrame* frame, v8::Handle context, int worldId) OVERRIDE
 {
 releaseNotifications.push_back(new Notification(frame, context, worldId));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109077] trunk/Source/WebKit/chromium

[bashi]

Title: [109077] trunk/Source/WebKit/chromium








Revision 109077
Author ba...@chromium.org
Date 2012-02-27 22:12:45 -0800 (Mon, 27 Feb 2012)


Log Message
[Chromium] Unreviewed gardening, Disable TransparencyWin.OpaqueCompositeLayerPixel

* tests/TransparencyWinTest.cpp:
(WebCore::TEST):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/TransparencyWinTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (109076 => 109077)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-28 06:03:41 UTC (rev 109076)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-28 06:12:45 UTC (rev 109077)
@@ -1,3 +1,10 @@
+2012-02-27  Kenichi Ishibashi  
+
+[Chromium] Unreviewed gardening, Disable TransparencyWin.OpaqueCompositeLayerPixel
+
+* tests/TransparencyWinTest.cpp:
+(WebCore::TEST):
+
 2012-02-27  Kinuko Yasuda  
 
 [chromium] Add createSnapshotFile API to WebFileSystem to create File snapshots for filesystem files


Modified: trunk/Source/WebKit/chromium/tests/TransparencyWinTest.cpp (109076 => 109077)

--- trunk/Source/WebKit/chromium/tests/TransparencyWinTest.cpp	2012-02-28 06:03:41 UTC (rev 109076)
+++ trunk/Source/WebKit/chromium/tests/TransparencyWinTest.cpp	2012-02-28 06:12:45 UTC (rev 109077)
@@ -303,7 +303,7 @@
 EXPECT_EQ(Color(Color::white), getPixelAt(src->context(), 4, 4));
 }
 
-TEST(TransparencyWin, OpaqueCompositeLayerPixel)
+TEST(TransparencyWin, DISABLED_OpaqueCompositeLayerPixel)
 {
 Color red(0x), darkRed(0xFFBF);
 Color green(0xFF00FF00);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109075] tags/Safari-535.23.1/Source/JavaScriptCore

[mrowe]

Title: [109075] tags/Safari-535.23.1/Source/_javascript_Core








Revision 109075
Author mr...@apple.com
Date 2012-02-27 21:59:07 -0800 (Mon, 27 Feb 2012)


Log Message
Merge r10.

Modified Paths

tags/Safari-535.23.1/Source/_javascript_Core/ChangeLog
tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedAllocator.h
tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedBlock.h
tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedSpace.cpp
tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedSpaceInlineMethods.h




Diff

Modified: tags/Safari-535.23.1/Source/_javascript_Core/ChangeLog (109074 => 109075)

--- tags/Safari-535.23.1/Source/_javascript_Core/ChangeLog	2012-02-28 05:49:02 UTC (rev 109074)
+++ tags/Safari-535.23.1/Source/_javascript_Core/ChangeLog	2012-02-28 05:59:07 UTC (rev 109075)
@@ -1,3 +1,26 @@
+2012-02-25  Mark Hahnenberg  
+
+Fix the CopiedBlock offset alignment in a cross platform fashion
+https://bugs.webkit.org/show_bug.cgi?id=79556
+
+Reviewed by Filip Pizlo.
+
+Replaced m_payload with a payload() method that calculates the offset
+of the payload with the proper alignment. This change allows us to 
+avoid alignment-related issues in a cross-platform manner.
+
+* heap/CopiedAllocator.h:
+(JSC::CopiedAllocator::currentUtilization):
+* heap/CopiedBlock.h:
+(JSC::CopiedBlock::CopiedBlock):
+(JSC::CopiedBlock::payload):
+(CopiedBlock):
+* heap/CopiedSpace.cpp:
+(JSC::CopiedSpace::doneFillingBlock):
+* heap/CopiedSpaceInlineMethods.h:
+(JSC::CopiedSpace::borrowBlock):
+(JSC::CopiedSpace::allocateFromBlock):
+
 2012-02-24  Daniel Bates  
 
 Fix change log entry for changeset r108819; add bug URL


Modified: tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedAllocator.h (109074 => 109075)

--- tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedAllocator.h	2012-02-28 05:49:02 UTC (rev 109074)
+++ tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedAllocator.h	2012-02-28 05:59:07 UTC (rev 109075)
@@ -93,7 +93,7 @@
 
 inline size_t CopiedAllocator::currentUtilization()
 {
-return static_cast(m_currentOffset - m_currentBlock->m_payload);
+return static_cast(m_currentOffset - m_currentBlock->payload());
 }
 
 inline void CopiedAllocator::resetLastAllocation(void* ptr)


Modified: tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedBlock.h (109074 => 109075)

--- tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedBlock.h	2012-02-28 05:49:02 UTC (rev 109074)
+++ tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedBlock.h	2012-02-28 05:59:07 UTC (rev 109075)
@@ -40,26 +40,31 @@
 public:
 CopiedBlock(PageAllocationAligned& allocation)
 : HeapBlock(allocation)
-, m_offset(m_payload)
+, m_offset(payload())
 , m_isPinned(false)
 {
-ASSERT(is8ByteAligned(static_cast(m_payload)));
+ASSERT(is8ByteAligned(static_cast(m_offset)));
 #if USE(JSVALUE64)
-memset(static_cast(m_payload), 0, static_cast((reinterpret_cast(this) + allocation.size()) - m_payload));
+char* offset = static_cast(m_offset);
+memset(static_cast(offset), 0, static_cast((reinterpret_cast(this) + allocation.size()) - offset));
 #else
 JSValue emptyValue;
 JSValue* limit = reinterpret_cast(reinterpret_cast(this) + allocation.size());
-for (JSValue* currentValue = reinterpret_cast(m_payload); currentValue < limit; currentValue++)
+for (JSValue* currentValue = reinterpret_cast(m_offset); currentValue < limit; currentValue++)
 *currentValue = emptyValue;
 #endif
 }
 
+char* payload()
+{
+return reinterpret_cast(this) + ((sizeof(CopiedBlock) + 7) & ~7);
+}
+
 private:
 void* m_offset;
 uintptr_t m_isPinned;
 uintptr_t m_padding;
 uintptr_t m_dummy;
-char m_payload[1];
 };
 
 } // namespace JSC


Modified: tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedSpace.cpp (109074 => 109075)

--- tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedSpace.cpp	2012-02-28 05:49:02 UTC (rev 109074)
+++ tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedSpace.cpp	2012-02-28 05:59:07 UTC (rev 109075)
@@ -153,7 +153,7 @@
 ASSERT(block->m_offset < reinterpret_cast(block) + HeapBlock::s_blockSize);
 ASSERT(m_inCopyingPhase);
 
-if (block->m_offset == block->m_payload) {
+if (block->m_offset == block->payload()) {
 recycleBlock(block);
 return;
 }
@@ -167,7 +167,7 @@
 
 {
 MutexLocker locker(m_memoryStatsLock);
-m_totalMemoryUtilized += static_cast(static_cast(block->m_offset) - block->m_payload);
+m_totalMemoryUtilized += static_cast(static_cast(block->m_offset) - block->payload());
 }
 
 {


Modified: tags/Safari-535.23.1/Source/_javascript_Core/heap/CopiedSpaceInlineMethods.h (109074 => 109075)

--- tags/Safari-535.23.1/Sou

[webkit-changes] [109074] trunk/Source/WebCore

[leo . yang]

Title: [109074] trunk/Source/WebCore








Revision 109074
Author leo.y...@torchmobile.com.cn
Date 2012-02-27 21:49:02 -0800 (Mon, 27 Feb 2012)


Log Message
[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntRect.h
https://bugs.webkit.org/show_bug.cgi?id=79732

Reviewed by Antonio Gomes.

Add conversion convenience between WebCore::IntRect and BlackBerry::Platform::IntRect.

The porting can't be built yet, no new tests.

* platform/graphics/IntRect.h:
(Platform):
(IntRect):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/IntRect.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (109073 => 109074)

--- trunk/Source/WebCore/ChangeLog	2012-02-28 05:42:45 UTC (rev 109073)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 05:49:02 UTC (rev 109074)
@@ -1,3 +1,18 @@
+2012-02-27  Leo Yang  
+
+[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntRect.h
+https://bugs.webkit.org/show_bug.cgi?id=79732
+
+Reviewed by Antonio Gomes.
+
+Add conversion convenience between WebCore::IntRect and BlackBerry::Platform::IntRect.
+
+The porting can't be built yet, no new tests.
+
+* platform/graphics/IntRect.h:
+(Platform):
+(IntRect):
+
 2012-02-27  Emil A Eklund  
 
 Printed font-size should not be dependant on zoom level


Modified: trunk/Source/WebCore/platform/graphics/IntRect.h (109073 => 109074)

--- trunk/Source/WebCore/platform/graphics/IntRect.h	2012-02-28 05:42:45 UTC (rev 109073)
+++ trunk/Source/WebCore/platform/graphics/IntRect.h	2012-02-28 05:49:02 UTC (rev 109074)
@@ -53,6 +53,12 @@
 #endif
 #elif PLATFORM(EFL)
 typedef struct _Eina_Rectangle Eina_Rectangle;
+#elif PLATFORM(BLACKBERRY)
+namespace BlackBerry {
+namespace Platform {
+class IntRect;
+}
+}
 #endif
 
 #if USE(CAIRO)
@@ -214,6 +220,11 @@
 operator NSRect() const;
 #endif
 
+#if PLATFORM(BLACKBERRY)
+IntRect(const BlackBerry::Platform::IntRect&);
+operator BlackBerry::Platform::IntRect() const;
+#endif
+
 private:
 IntPoint m_location;
 IntSize m_size;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109073] trunk

[eae]

Title: [109073] trunk








Revision 109073
Author e...@chromium.org
Date 2012-02-27 21:42:45 -0800 (Mon, 27 Feb 2012)


Log Message
Printed font-size should not be dependant on zoom level
https://bugs.webkit.org/show_bug.cgi?id=79717

Reviewed by Adam Barth.

Ignore full page zoom level when printing a document.

Source/WebCore:

Test: printing/zoomed-document.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

* printing/zoomed-document-expected.txt: Added.
* printing/zoomed-document.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp


Added Paths

trunk/LayoutTests/printing/zoomed-document-expected.txt
trunk/LayoutTests/printing/zoomed-document.html




Diff

Modified: trunk/LayoutTests/ChangeLog (109072 => 109073)

--- trunk/LayoutTests/ChangeLog	2012-02-28 05:29:54 UTC (rev 109072)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 05:42:45 UTC (rev 109073)
@@ -1,3 +1,15 @@
+2012-02-27  Emil A Eklund  
+
+Printed font-size should not be dependant on zoom level
+https://bugs.webkit.org/show_bug.cgi?id=79717
+
+Reviewed by Adam Barth.
+
+Ignore full page zoom level when printing a document.
+
+* printing/zoomed-document-expected.txt: Added.
+* printing/zoomed-document.html: Added.
+
 2012-02-27  Sheriff Bot  
 
 Unreviewed, rolling out r109041.


Added: trunk/LayoutTests/printing/zoomed-document-expected.txt (0 => 109073)

--- trunk/LayoutTests/printing/zoomed-document-expected.txt	(rev 0)
+++ trunk/LayoutTests/printing/zoomed-document-expected.txt	2012-02-28 05:42:45 UTC (rev 109073)
@@ -0,0 +1 @@
+PASS Document zoom should not apply when printing.


Added: trunk/LayoutTests/printing/zoomed-document.html (0 => 109073)

--- trunk/LayoutTests/printing/zoomed-document.html	(rev 0)
+++ trunk/LayoutTests/printing/zoomed-document.html	2012-02-28 05:42:45 UTC (rev 109073)
@@ -0,0 +1,27 @@
+
+
+
+test
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+
+var msg = 'Document zoom should not apply when printing.';
+var pass = true;
+
+for (var i = 0; i < 10; i++) {
+var numberOfPages = layoutTestController.numberOfPages(100, 30);
+if (numberOfPages != 1) {
+pass = false;
+msg += 'Got ' + numberOfPages + ' pages, expected 1.\n';
+}
+eventSender.zoomPageIn();
+}
+
+msg = (pass ? 'PASS' : 'FAIL') + ' ' + msg;
+document.querySelector('#console').textContent = msg;
+}
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (109072 => 109073)

--- trunk/Source/WebCore/ChangeLog	2012-02-28 05:29:54 UTC (rev 109072)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 05:42:45 UTC (rev 109073)
@@ -1,3 +1,17 @@
+2012-02-27  Emil A Eklund  
+
+Printed font-size should not be dependant on zoom level
+https://bugs.webkit.org/show_bug.cgi?id=79717
+
+Reviewed by Adam Barth.
+
+Ignore full page zoom level when printing a document.
+
+Test: printing/zoomed-document.html
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::collectMatchingRulesForList):
+
 2012-02-27  Kenichi Ishibashi  
 
 [Chromium] Unreviewed gardening, further compile fixes for


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (109072 => 109073)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-02-28 05:29:54 UTC (rev 109072)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-02-28 05:42:45 UTC (rev 109073)
@@ -1436,7 +1436,7 @@
 RefPtr documentStyle = RenderStyle::create();
 documentStyle->setDisplay(BLOCK);
 documentStyle->setRTLOrdering(document->visuallyOrdered() ? VisualOrder : LogicalOrder);
-documentStyle->setZoom(frame ? frame->pageZoomFactor() : 1);
+documentStyle->setZoom(frame && !document->printing() ? frame->pageZoomFactor() : 1);
 documentStyle->setPageScaleTransform(frame ? frame->frameScaleFactor() : 1);
 documentStyle->setUserModify(document->inDesignMode() ? READ_WRITE : READ_ONLY);
 documentStyle->setLocale(document->contentLanguage());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109072] trunk/Source/WebCore

[bashi]

Title: [109072] trunk/Source/WebCore








Revision 109072
Author ba...@chromium.org
Date 2012-02-27 21:29:54 -0800 (Mon, 27 Feb 2012)


Log Message
[Chromium] Unreviewed gardening, further compile fixes for
TransparencyWinTest.

* platform/graphics/chromium/TransparencyWin.h:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (109071 => 109072)

--- trunk/Source/WebCore/ChangeLog	2012-02-28 05:16:51 UTC (rev 109071)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 05:29:54 UTC (rev 109072)
@@ -1,5 +1,13 @@
 2012-02-27  Kenichi Ishibashi  
 
+[Chromium] Unreviewed gardening, further compile fixes for
+TransparencyWinTest.
+
+* platform/graphics/chromium/TransparencyWin.h:
+(WebCore):
+
+2012-02-27  Kenichi Ishibashi  
+
 [Chromium] Unreviewed gardening, fix compile error after r109043
 
 * platform/graphics/chromium/TransparencyWin.h:


Modified: trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.h (109071 => 109072)

--- trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.h	2012-02-28 05:16:51 UTC (rev 109071)
+++ trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.h	2012-02-28 05:29:54 UTC (rev 109072)
@@ -44,10 +44,10 @@
 namespace WebCore {
 
 class GraphicsContext;
-class TransparencyWin_NoLayer_Test;
-class TransparencyWin_WhiteLayer_Test;
-class TransparencyWin_TextComposite_Test;
-class TransparencyWin_OpaqueCompositeLayer_Test;
+class TransparencyWin_DISABLED_NoLayer_Test;
+class TransparencyWin_DISABLED_WhiteLayer_Test;
+class TransparencyWin_DISABLED_TextComposite_Test;
+class TransparencyWin_DISABLED_OpaqueCompositeLayer_Test;
 
 // Helper class that abstracts away drawing ClearType text and Windows form
 // controls either to the original context directly, or to an offscreen context






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109071] trunk/Source/WebCore

[bashi]

Title: [109071] trunk/Source/WebCore








Revision 109071
Author ba...@chromium.org
Date 2012-02-27 21:16:51 -0800 (Mon, 27 Feb 2012)


Log Message
[Chromium] Unreviewed gardening, fix compile error after r109043

* platform/graphics/chromium/TransparencyWin.h:
(TransparencyWin):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (109070 => 109071)

--- trunk/Source/WebCore/ChangeLog	2012-02-28 04:59:50 UTC (rev 109070)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 05:16:51 UTC (rev 109071)
@@ -1,3 +1,10 @@
+2012-02-27  Kenichi Ishibashi  
+
+[Chromium] Unreviewed gardening, fix compile error after r109043
+
+* platform/graphics/chromium/TransparencyWin.h:
+(TransparencyWin):
+
 2012-02-27  Adam Barth  
 
 EventFactory.in should be named EventNames.in


Modified: trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.h (109070 => 109071)

--- trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.h	2012-02-28 04:59:50 UTC (rev 109070)
+++ trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.h	2012-02-28 05:16:51 UTC (rev 109071)
@@ -156,10 +156,10 @@
 const IntRect& drawRect() { return m_drawRect; }
 
 private:
-friend TransparencyWin_NoLayer_Test;
-friend TransparencyWin_WhiteLayer_Test;
-friend TransparencyWin_TextComposite_Test;
-friend TransparencyWin_OpaqueCompositeLayer_Test;
+friend TransparencyWin_DISABLED_NoLayer_Test;
+friend TransparencyWin_DISABLED_WhiteLayer_Test;
+friend TransparencyWin_DISABLED_TextComposite_Test;
+friend TransparencyWin_DISABLED_OpaqueCompositeLayer_Test;
 
 class OwnedBuffers;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109070] trunk/Source/WebKit/chromium

[kinuko]

Title: [109070] trunk/Source/WebKit/chromium








Revision 109070
Author kin...@chromium.org
Date 2012-02-27 20:59:50 -0800 (Mon, 27 Feb 2012)


Log Message
[chromium] Add createSnapshotFile API to WebFileSystem to create File snapshots for filesystem files
https://bugs.webkit.org/show_bug.cgi?id=79394

Reviewed by Darin Fisher.

* public/platform/WebFileSystem.h:
(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata): Added.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebFileSystem.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (109069 => 109070)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-28 04:50:08 UTC (rev 109069)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-28 04:59:50 UTC (rev 109070)
@@ -1,3 +1,13 @@
+2012-02-27  Kinuko Yasuda  
+
+[chromium] Add createSnapshotFile API to WebFileSystem to create File snapshots for filesystem files
+https://bugs.webkit.org/show_bug.cgi?id=79394
+
+Reviewed by Darin Fisher.
+
+* public/platform/WebFileSystem.h:
+(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata): Added.
+
 2012-02-27  James Kozianski  
 
 [chromium] Plumb extensionGroup into didCreateScriptContext().


Modified: trunk/Source/WebKit/chromium/public/platform/WebFileSystem.h (109069 => 109070)

--- trunk/Source/WebKit/chromium/public/platform/WebFileSystem.h	2012-02-28 04:50:08 UTC (rev 109069)
+++ trunk/Source/WebKit/chromium/public/platform/WebFileSystem.h	2012-02-28 04:59:50 UTC (rev 109070)
@@ -71,6 +71,7 @@
 virtual void removeRecursively(const WebURL& path, WebFileSystemCallbacks*) { WEBKIT_ASSERT_NOT_REACHED(); }
 
 // Retrieves the metadata information of the file or directory at the given |path|.
+// This may not always return the local platform path in remote filesystem cases.
 // WebFileSystemCallbacks::didReadMetadata() must be called with a valid metadata when the retrieval is completed successfully.
 // WebFileSystemCallbacks::didFail() must be called otherwise.
 virtual void readMetadata(const WebURL& path, WebFileSystemCallbacks*) { WEBKIT_ASSERT_NOT_REACHED(); }
@@ -114,6 +115,15 @@
 // This is a fast, synchronous call, and should not stat the filesystem.
 virtual WebFileWriter* createFileWriter(const WebURL& path, WebFileWriterClient*) { WEBKIT_ASSERT_NOT_REACHED(); return 0; }
 
+// Creates a snapshot file for a given file specified by |path| and registers the file with the |blobURL|. It returns the metadata of the created snapshot file.
+// The returned metadata should include a local platform path to the snapshot image.
+// In local filesystem cases the backend may simply return the metadata of the file itself (as well as readMetadata does), while in remote filesystem case the backend may download the file into a temporary snapshot file and return the metadata of the temporary file.
+// The returned metadata is used to create a File object for the |path|.
+// The snapshot file is supposed to be deleted when the last reference to the |blobURL| is dropped.
+// WebFileSystemCallbacks::didReadMetadata() with the metadata of the snapshot file must be called when the operation is completed successfully.
+// WebFileSystemCallbacks::didFail() must be called otherwise.
+virtual void createSnapshotFileAndReadMetadata(const WebURL& blobURL, const WebURL& path, WebFileSystemCallbacks*) { WEBKIT_ASSERT_NOT_REACHED(); }
+
 protected:
 virtual ~WebFileSystem() { }
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109069] trunk

[bashi]

Title: [109069] trunk








Revision 109069
Author ba...@chromium.org
Date 2012-02-27 20:50:08 -0800 (Mon, 27 Feb 2012)


Log Message
Unreviewed, rolling out r109041.
http://trac.webkit.org/changeset/109041
https://bugs.webkit.org/show_bug.cgi?id=79741

Broke Chromium Win build (Requested by bashi on #webkit).

Patch by Sheriff Bot  on 2012-02-27

Tools:

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

* webintents/resources/web-intents-testing.js: Removed.
* webintents/web-intents-failure-expected.txt: Removed.
* webintents/web-intents-failure.html: Removed.
* webintents/web-intents-invoke-expected.txt: Removed.
* webintents/web-intents-invoke.html: Removed.
* webintents/web-intents-reload.html:
* webintents/web-intents-reply-expected.txt: Removed.
* webintents/web-intents-reply.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webintents/web-intents-reload.html
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h


Removed Paths

trunk/LayoutTests/webintents/resources/web-intents-testing.js
trunk/LayoutTests/webintents/web-intents-failure-expected.txt
trunk/LayoutTests/webintents/web-intents-failure.html
trunk/LayoutTests/webintents/web-intents-invoke-expected.txt
trunk/LayoutTests/webintents/web-intents-invoke.html
trunk/LayoutTests/webintents/web-intents-reply-expected.txt
trunk/LayoutTests/webintents/web-intents-reply.html




Diff

Modified: trunk/LayoutTests/ChangeLog (109068 => 109069)

--- trunk/LayoutTests/ChangeLog	2012-02-28 04:41:18 UTC (rev 109068)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 04:50:08 UTC (rev 109069)
@@ -1,3 +1,20 @@
+2012-02-27  Sheriff Bot  
+
+Unreviewed, rolling out r109041.
+http://trac.webkit.org/changeset/109041
+https://bugs.webkit.org/show_bug.cgi?id=79741
+
+Broke Chromium Win build (Requested by bashi on #webkit).
+
+* webintents/resources/web-intents-testing.js: Removed.
+* webintents/web-intents-failure-expected.txt: Removed.
+* webintents/web-intents-failure.html: Removed.
+* webintents/web-intents-invoke-expected.txt: Removed.
+* webintents/web-intents-invoke.html: Removed.
+* webintents/web-intents-reload.html:
+* webintents/web-intents-reply-expected.txt: Removed.
+* webintents/web-intents-reply.html: Removed.
+
 2012-02-27  Huang Dongsung  
 
 Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);


Deleted: trunk/LayoutTests/webintents/resources/web-intents-testing.js (109068 => 109069)

--- trunk/LayoutTests/webintents/resources/web-intents-testing.js	2012-02-28 04:41:18 UTC (rev 109068)
+++ trunk/LayoutTests/webintents/resources/web-intents-testing.js	2012-02-28 04:50:08 UTC (rev 109069)
@@ -1,40 +0,0 @@
-// Callback function to be used for a successful web intent call.
-function onSuccess(data) {
-  debug("* got reply: " + data);
-
-  if (window.layoutTestController) {
-window.layoutTestController.notifyDone();
-  }
-}
-
-// Callback function to be used for a failed web intent call.
-function onFailure(data) {
-  debug("* got failure: " + data);
-
-  if (window.layoutTestController) {
-window.layoutTestController.notifyDone();
-  }
-}
-
-// Launch a web intent call with callbacks.
-function startIntentWithCallbacks() {
-  navigator.startActivity(new Intent("action1", "mime/type1", "test"), onSuccess, onFailure);
-  debug("* sent intent");
-
-  if (window.layoutTestController) {
-window.layoutTestController.waitUntilDone();
-  } else {
-alert('This test needs to run in DRT');
-  }
-}
-
-// This button press simulator sets the user gesture indicator that an intent
-// requires to start.
-function simulateButtonPress() {
-  var button = document.getElementById("button");
-  if (eventSender) {
-eventSender.mouseMoveTo(button.getBoundingClientRect().left + 2, button.getBoundingClientRect().top + 12);
-eventSender.mouseDown();
-eventSender.mouseUp();
-  }
-}


Deleted: trunk/LayoutTests/webintents/web-intents-failure-expected.txt (109068 => 109069)

--- trunk/LayoutTests/webintents/web-intents-failure-expected.txt	2012-02-28 04:41:18 UTC (rev 109068)
+++ trunk/LayoutTests/webintents/web-intents-failure-expected.txt	2012-02-28 04:50:08 UTC (rev 109069)
@@ -1,7 +0,0 @@
-Received Web Intent: action="" type=mime/type1
-PASS successfullyParsed is true
-
-TEST COMPLETE
-* sent intent
-* got failure: ERROR
-


Deleted: trunk/LayoutTests/webintents/web-intents-failure.html (109068 => 109069)

--- trunk/LayoutTests/webintents/web-intents-failure.html	2012-02-28 04:41:18 UTC (rev 109068)
+++ trunk/LayoutTests/webintents/web-intents-failure.html	2012-02-28 04:50:08 UTC (rev 109069)
@

[webkit-changes] [109068] trunk/Source/WebCore

[abarth]

Title: [109068] trunk/Source/WebCore








Revision 109068
Author aba...@webkit.org
Date 2012-02-27 20:41:18 -0800 (Mon, 27 Feb 2012)


Log Message
EventFactory.in should be named EventNames.in
https://bugs.webkit.org/show_bug.cgi?id=79727

Reviewed by Kentaro Hara.

Originally EventFactory.in was just used to generate EventFactory.cpp,
but now we're able to generate a bunch of other Event-related code from
this "in" file.

In writing some documentation about how to use these mechanisms, the
name EventFactory.in didn't seem like the right name.  This patch
renames EventFactory.in to EventNames.in, which more accurately
describes the role of this file (and matches the naming convention of
HTMLTagNames.in).

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
(main):
* WebCore.xcodeproj/project.pbxproj:
* dom/EventNames.in: Copied from Source/WebCore/dom/EventFactory.in.
* dom/EventFactory.in: Removed.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/DerivedSources.pri
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gyp/scripts/action_makenames.py
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebCore/dom/EventNames.in


Removed Paths

trunk/Source/WebCore/dom/EventFactory.in




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (109067 => 109068)

--- trunk/Source/WebCore/CMakeLists.txt	2012-02-28 04:17:32 UTC (rev 109067)
+++ trunk/Source/WebCore/CMakeLists.txt	2012-02-28 04:41:18 UTC (rev 109068)
@@ -2448,7 +2448,7 @@
 LIST(APPEND WebCore_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/HTMLNames.cpp ${DERIVED_SOURCES_WEBCORE_DIR}/HTMLElementFactory.cpp ${DERIVED_SOURCES_WEBCORE_DIR}/JSHTMLElementWrapperFactory.cpp)
 
 
-GENERATE_EVENT_FACTORY(${WEBCORE_DIR}/dom/EventFactory.in EventFactory.cpp)
+GENERATE_EVENT_FACTORY(${WEBCORE_DIR}/dom/EventNames.in EventFactory.cpp)
 LIST(APPEND WebCore_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/EventFactory.cpp)
 
 


Modified: trunk/Source/WebCore/ChangeLog (109067 => 109068)

--- trunk/Source/WebCore/ChangeLog	2012-02-28 04:17:32 UTC (rev 109067)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 04:41:18 UTC (rev 109068)
@@ -1,3 +1,31 @@
+2012-02-27  Adam Barth  
+
+EventFactory.in should be named EventNames.in
+https://bugs.webkit.org/show_bug.cgi?id=79727
+
+Reviewed by Kentaro Hara.
+
+Originally EventFactory.in was just used to generate EventFactory.cpp,
+but now we're able to generate a bunch of other Event-related code from
+this "in" file.
+
+In writing some documentation about how to use these mechanisms, the
+name EventFactory.in didn't seem like the right name.  This patch
+renames EventFactory.in to EventNames.in, which more accurately
+describes the role of this file (and matches the naming convention of
+HTMLTagNames.in).
+
+* CMakeLists.txt:
+* DerivedSources.make:
+* DerivedSources.pri:
+* GNUmakefile.am:
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gyp/scripts/action_makenames.py:
+(main):
+* WebCore.xcodeproj/project.pbxproj:
+* dom/EventNames.in: Copied from Source/WebCore/dom/EventFactory.in.
+* dom/EventFactory.in: Removed.
+
 2012-02-27  Yoshifumi Inoue  
 
 [Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification


Modified: trunk/Source/WebCore/DerivedSources.make (109067 => 109068)

--- trunk/Source/WebCore/DerivedSources.make	2012-02-28 04:17:32 UTC (rev 109067)
+++ trunk/Source/WebCore/DerivedSources.make	2012-02-28 04:41:18 UTC (rev 109068)
@@ -866,8 +866,8 @@
  
 # Register event constructors and targets
 
-EventFactory.cpp EventHeaders.h EventInterfaces.h : dom/make_event_factory.pl dom/EventFactory.in
-	perl -I $(WebCore)/bindings/scripts $< --input $(WebCore)/dom/EventFactory.in
+EventFactory.cpp EventHeaders.h EventInterfaces.h : dom/make_event_factory.pl dom/EventNames.in
+	perl -I $(WebCore)/bindings/scripts $< --input $(WebCore)/dom/EventNames.in
 
 EventTargetHeaders.h EventTargetInterfaces.h : dom/make_event_factory.pl dom/EventTargetFactory.in
 	perl -I $(WebCore)/bindings/scripts $< --input $(WebCore)/dom/EventTargetFactory.in


Modified: trunk/Source/WebCore/DerivedSources.pri (109067 => 109068)

--- trunk/Source/WebCore/DerivedSources.pri	2012-02-28 04:17:32 UTC (rev 109067)
+++ trunk/Source/WebCore/DerivedSources.pri	2012-02-28 04:41:18 UTC (rev 109068)
@@ -43,7 +43,7 @@
 
 HTML_ENTITIES = $$PWD/html/parser/HTMLEntityNames.in
 
-EVENT_FACTORY = $$PWD/dom/EventFactory.in
+EVENTS_NAMES = $$PWD/dom/EventNames.in
 
 EVENT_TARGET_FACTORY = $$PWD/dom/EventTargetFactory.in
 
@@ -815,10 +815,10 @@
 
 # GENERATOR 5-E:
 eventfactory.output = EventFactory.cpp
-eve

[webkit-changes] [109067] trunk/Source/WebCore

[commit-queue]

Title: [109067] trunk/Source/WebCore








Revision 109067
Author commit-qu...@webkit.org
Date 2012-02-27 20:17:32 -0800 (Mon, 27 Feb 2012)


Log Message
[Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=79622

For ease of maintainability, this patch reorders attributes and methods declaration
matching with specification.

Patch by Yoshifumi Inoue  on 2012-02-27
Reviewed by Adam Barth.

No new tests. No behavior change.

* html/HTMLInputElement.idl: Reorder and remove obsolete comments.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLInputElement.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (109066 => 109067)

--- trunk/Source/WebCore/ChangeLog	2012-02-28 03:52:02 UTC (rev 109066)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 04:17:32 UTC (rev 109067)
@@ -1,3 +1,17 @@
+2012-02-27  Yoshifumi Inoue  
+
+[Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
+https://bugs.webkit.org/show_bug.cgi?id=79622
+
+For ease of maintainability, this patch reorders attributes and methods declaration
+matching with specification.
+
+Reviewed by Adam Barth.
+
+No new tests. No behavior change.
+
+* html/HTMLInputElement.idl: Reorder and remove obsolete comments.
+
 2012-02-27  Luke Macpherson   
 
 Sort CSSStyleSelector property handler constructors by CSS property name.


Modified: trunk/Source/WebCore/html/HTMLInputElement.idl (109066 => 109067)

--- trunk/Source/WebCore/html/HTMLInputElement.idl	2012-02-28 03:52:02 UTC (rev 109066)
+++ trunk/Source/WebCore/html/HTMLInputElement.idl	2012-02-28 04:17:32 UTC (rev 109067)
@@ -21,36 +21,33 @@
 module html {
 
 interface HTMLInputElement : HTMLElement {
-attribute [TreatNullAs=NullString] DOMString defaultValue;
+attribute [Reflect] DOMString accept;
+attribute [Reflect] DOMString alt;
+attribute [Reflect] DOMString autocomplete;
+attribute [Reflect] boolean autofocus;
 attribute [Reflect=checked] boolean defaultChecked;
+attribute boolean checked;
 attribute [Reflect] DOMString dirName;
+attribute [Reflect] boolean disabled;
 readonly attribute HTMLFormElement form;
+readonly attribute FileList files;
 attribute [Reflect, URL] DOMString formAction;
 attribute [TreatNullAs=NullString] DOMString formEnctype;
 attribute [TreatNullAs=NullString] DOMString formMethod;
 attribute [Reflect] boolean formNoValidate;
 attribute [Reflect] DOMString formTarget;
-readonly attribute ValidityState validity;
-attribute [Reflect] DOMString accept;
-attribute [Reflect] DOMString align;
-attribute [Reflect] DOMString alt;
-attribute boolean checked;
-attribute [Reflect] boolean disabled;
-attribute [Reflect] boolean autofocus;
-attribute [Reflect] DOMString autocomplete;
+attribute boolean indeterminate;
 readonly attribute [Conditional=DATALIST] HTMLElement list;
 attribute [Reflect] DOMString max;
 attribute long maxLength setter raises(DOMException);
 attribute [Reflect] DOMString min;
 attribute [Reflect] boolean multiple;
-attribute [Conditional=DIRECTORY_UPLOAD, Reflect] boolean webkitdirectory;
 attribute [Reflect] DOMString name;
 attribute [Reflect] DOMString pattern;
 attribute [Reflect] DOMString placeholder;
 attribute [Reflect] boolean readOnly;
 attribute [Reflect] boolean required;
 #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
-attribute [Reflect] DOMString accessKey;
 attribute [ObjCImplementedAsUnsignedLong] DOMString size; // DOM level 2 changed this to a long, but ObjC API is a string
 #else
 attribute unsigned long size; // Changed string -> long -> unsigned long
@@ -58,39 +55,28 @@
 attribute [Reflect, URL] DOMString src;
 attribute [Reflect] DOMString step;
 attribute [TreatNullAs=NullString] DOMString type; // readonly dropped as part of DOM level 2
-attribute [Reflect] DOMString useMap;
+attribute [TreatNullAs=NullString] DOMString defaultValue;
 attribute [TreatNullAs=NullString] DOMString value;
 #if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
 attribute Date valueAsDate setter raises(DOMException);
 #endif
 attribute double valueAsNumber setter raises(DOMException);
-readonly attribute [Conditional=DATALIST] HTMLOptionElement selectedOption;
-attribute [Reflect] boolean incremental;
 
 void stepUp(in [Optional] long n) raises(DOMException);
 void stepDown(in [Optional] long n) raises(DOMException);
 
 readonly attribute boolean willValidate;
+readonly attribute ValidityState validity;
 readonly attribute DOMString v

[webkit-changes] [109066] trunk/Tools

[commit-queue]

Title: [109066] trunk/Tools








Revision 109066
Author commit-qu...@webkit.org
Date 2012-02-27 19:52:02 -0800 (Mon, 27 Feb 2012)


Log Message
[chromium] Remove media tests from ChromiumGpu configurations
https://bugs.webkit.org/show_bug.cgi?id=79720

Patch by James Robinson  on 2012-02-27
Reviewed by Adam Barth.

We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
composited playback path via tests in the compositing/ directory.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
(_default_tests_paths):
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (109065 => 109066)

--- trunk/Tools/ChangeLog	2012-02-28 03:44:33 UTC (rev 109065)
+++ trunk/Tools/ChangeLog	2012-02-28 03:52:02 UTC (rev 109066)
@@ -1,3 +1,19 @@
+2012-02-27  James Robinson  
+
+[chromium] Remove media tests from ChromiumGpu configurations
+https://bugs.webkit.org/show_bug.cgi?id=79720
+
+Reviewed by Adam Barth.
+
+We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
+composited playback path via tests in the compositing/ directory.
+
+* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
+(_default_tests_paths):
+* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
+(ChromiumGpuTest.test_default_tests_paths):
+(ChromiumGpuTest.test_test_files):
+
 2012-02-27  Dirk Pranke  
 
 nrwt: log multiline stderr/crash output properly


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py (109065 => 109066)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py	2012-02-28 03:44:33 UTC (rev 109065)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py	2012-02-28 03:52:02 UTC (rev 109066)
@@ -50,27 +50,9 @@
 
 
 def _default_tests_paths(port):
-paths = []
-if port.name() != 'chromium-gpu-mac-leopard':
-# Only run tests requiring accelerated compositing on platforms that
-# support it.
-# FIXME: we should add the above paths here as well but let's test
-# the waters with media first.
-paths += ['media']
+return ['fast/canvas', 'canvas/philip']
 
-paths += ['fast/canvas', 'canvas/philip']
 
-if not paths:
-# FIXME: This is a hack until we can turn off the webkit_gpu
-# tests on the bots. If paths is empty, port.tests()
-# finds *everything*. However, we have to return something,
-# or NRWT thinks there's something wrong. So, we return a single
-# short directory. See https://bugs.webkit.org/show_bug.cgi?id=72498.
-paths = ['fast/html']
-
-return paths
-
-
 class ChromiumGpuAndroidPort(chromium_android.ChromiumAndroidPort):
 port_name = 'chromium-gpu-android'
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py (109065 => 109066)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py	2012-02-28 03:44:33 UTC (rev 109065)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py	2012-02-28 03:52:02 UTC (rev 109066)
@@ -109,8 +109,7 @@
 def test_paths(port_name):
 return chromium_gpu._default_tests_paths(PortFactory(MockSystemHost()).get(port_name))
 
-self.assertEqual(test_paths('chromium-gpu-linux'), ['media', 'fast/canvas', 'canvas/philip'])
-self.assertEqual(test_paths('chromium-gpu-mac-leopard'), ['fast/canvas', 'canvas/philip'])
+self.assertEqual(test_paths('chromium-gpu-linux'), ['fast/canvas', 'canvas/philip'])
 
 def test_test_files(self):
 host = MockSystemHost()
@@ -118,7 +117,6 @@
 '/mock-checkout/LayoutTests/canvas/philip/test.html': '',
 '/mock-checkout/LayoutTests/fast/canvas/test.html': '',
 '/mock-checkout/LayoutTests/fast/html/test.html': '',
-'/mock-checkout/LayoutTests/media/test.html': '',
 '/mock-checkout/LayoutTests/foo/bar.html': '',
 }
 host.filesystem = MockFileSystem(files)
@@ -126,8 +124,7 @@
 def test_paths(port_name):
 return PortFactory(host).get(port_name).tests([])
 
-self.assertEqual(test_paths('chromium-gpu-linux'), set(['canvas/philip/test.html', 'fast/canvas/test.html', 'media/test.html']))
-self.assertEqual(test_paths('chromium-gpu-mac-leopard'), set(['canvas/philip/test.html', 'fast/canvas/test.html']))
+self.assertEqual(test_paths('chromium-gpu-linux'), set(['canvas/philip/test.html', 'fast/canvas/test.html']))
 
 
 if __name__ == '__main__':






___

[webkit-changes] [109064] trunk/Source

[koz]

Title: [109064] trunk/Source








Revision 109064
Author k...@chromium.org
Date 2012-02-27 19:31:02 -0800 (Mon, 27 Feb 2012)


Log Message
[chromium] Plumb extensionGroup into didCreateScriptContext().
https://bugs.webkit.org/show_bug.cgi?id=79072

Reviewed by Darin Fisher.

Source/WebCore:

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
* loader/FrameLoaderClient.h:
(FrameLoaderClient):

Source/WebKit/chromium:

* public/WebFrameClient.h:
(WebKit::WebFrameClient::didCreateScriptContext):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp
trunk/Source/WebCore/loader/EmptyClients.h
trunk/Source/WebCore/loader/FrameLoaderClient.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebFrameClient.h
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (109063 => 109064)

--- trunk/Source/WebCore/ChangeLog	2012-02-28 03:29:26 UTC (rev 109063)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 03:31:02 UTC (rev 109064)
@@ -1,3 +1,19 @@
+2012-02-27  James Kozianski  
+
+[chromium] Plumb extensionGroup into didCreateScriptContext().
+https://bugs.webkit.org/show_bug.cgi?id=79072
+
+Reviewed by Darin Fisher.
+
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::V8DOMWindowShell::initContextIfNeeded):
+* bindings/v8/V8IsolatedContext.cpp:
+(WebCore::V8IsolatedContext::V8IsolatedContext):
+* loader/EmptyClients.h:
+(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
+* loader/FrameLoaderClient.h:
+(FrameLoaderClient):
+
 2012-02-27  Huang Dongsung  
 
 Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);


Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (109063 => 109064)

--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2012-02-28 03:29:26 UTC (rev 109063)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2012-02-28 03:31:02 UTC (rev 109064)
@@ -339,7 +339,7 @@
 
 setSecurityToken();
 
-m_frame->loader()->client()->didCreateScriptContext(m_context, 0);
+m_frame->loader()->client()->didCreateScriptContext(m_context, 0, 0);
 
 // FIXME: This is wrong. We should actually do this for the proper world once
 // we do isolated worlds the WebCore way.


Modified: trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp (109063 => 109064)

--- trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp	2012-02-28 03:29:26 UTC (rev 109063)
+++ trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp	2012-02-28 03:31:02 UTC (rev 109064)
@@ -75,7 +75,7 @@
 //changes.
 m_context->get()->UseDefaultSecurityToken();
 
-m_frame->loader()->client()->didCreateScriptContext(context(), m_world->id());
+m_frame->loader()->client()->didCreateScriptContext(context(), extensionGroup, m_world->id());
 }
 
 void V8IsolatedContext::destroy()


Modified: trunk/Source/WebCore/loader/EmptyClients.h (109063 => 109064)

--- trunk/Source/WebCore/loader/EmptyClients.h	2012-02-28 03:29:26 UTC (rev 109063)
+++ trunk/Source/WebCore/loader/EmptyClients.h	2012-02-28 03:31:02 UTC (rev 109064)
@@ -394,7 +394,7 @@
 virtual void registerForIconNotification(bool) { }
 
 #if USE(V8)
-virtual void didCreateScriptContext(v8::Handle, int worldId) { }
+virtual void didCreateScriptContext(v8::Handle, int extensionGroup, int worldId) { }
 virtual void willReleaseScriptContext(v8::Handle, int worldId) { }
 virtual bool allowScriptExtension(const String& extensionName, int extensionGroup, int worldId) { return false; }
 #endif


Modified: trunk/Source/WebCore/loader/FrameLoaderClient.h (109063 => 109064)

--- trunk/Source/WebCore/loader/FrameLoaderClient.h	2012-02-28 03:29:26 UTC (rev 109063)
+++ trunk/Source/WebCore/loader/FrameLoaderClient.h	2012-02-28 03:31:02 UTC (rev 109064)
@@ -280,7 +280,7 @@
 virtual void didPerformFirstNavigation() const = 0; // "Navigation" here means a transition from one page to another that ends up in the back/forward list.
 
 #if USE(V8)
-virtual void didCreateScriptContext(v8::Handle, int worldId) = 0;
+virtual void didCreateScriptContext(v8::Handle, int extensionGroup, int worldId) = 0;
 virtual void willReleaseScriptContext(v8::Handle, int worldId) = 0;
 virtual bool allowScriptExtension(const String& extensionName, int extensionGroup, int worldId) = 0;
 #endif


Modified: trunk/Source/WebKit/chromium/ChangeLo

[webkit-changes] [109063] trunk

[commit-queue]

Title: [109063] trunk








Revision 109063
Author commit-qu...@webkit.org
Date 2012-02-27 19:29:26 -0800 (Mon, 27 Feb 2012)


Log Message
Update flakiness dashboard unit test.
https://bugs.webkit.org/show_bug.cgi?id=79711

Patch by Dave Tu  on 2012-02-27
Reviewed by Ojan Vafai.

* Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

Modified Paths

trunk/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js




Diff

Modified: trunk/ChangeLog (109062 => 109063)

--- trunk/ChangeLog	2012-02-28 03:09:41 UTC (rev 109062)
+++ trunk/ChangeLog	2012-02-28 03:29:26 UTC (rev 109063)
@@ -1,3 +1,12 @@
+2012-02-27  Dave Tu  
+
+Update flakiness dashboard unit test.
+https://bugs.webkit.org/show_bug.cgi?id=79711
+
+Reviewed by Ojan Vafai.
+
+* Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
+
 2012-02-27  Ryosuke Niwa  
 
 Extract the logic to merge tests from MergeTestsHandler and add unit tests


Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js (109062 => 109063)

--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js	2012-02-28 03:09:41 UTC (rev 109062)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js	2012-02-28 03:29:26 UTC (rev 109063)
@@ -393,7 +393,7 @@
 assertEquals(selects.length, 3);
 var group = selects[2];
 assertEquals(group.parentNode.textContent.indexOf('Group:'), 0);
-assertEquals(group.children.length, 2);
+assertEquals(group.children.length, 3);
 
 g_currentState.testType = 'layout-tests';
 container.innerHTML = htmlForTestTypeSwitcher();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109062] trunk

[commit-queue]

Title: [109062] trunk








Revision 109062
Author commit-qu...@webkit.org
Date 2012-02-27 19:09:41 -0800 (Mon, 27 Feb 2012)


Log Message
Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);
incorrect source and destination rect used.
https://bugs.webkit.org/show_bug.cgi?id=79566

Source/WebCore:

Pass dstRect and bufferSrcRect to
CanvasRenderingContext2D::fullCanvasCompositedDrawImage() for the destination
and source rect, respectively.

Patch by Huang Dongsung  on 2012-02-27
Reviewed by Daniel Bates.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):

LayoutTests:

I amended canvas-composite-canvas to cover this bug, and I also amended
canvas-composite-image because I changed
LayoutTests/fast/canvas/resources/canvas-composite-image-common.js.
However, the change of canvas-composite-image is reasonable because
drawImage(HTMLImageElement) will be able to have a similar bug.

Patch by Huang Dongsung  on 2012-02-27
Reviewed by Daniel Bates.

* fast/canvas/canvas-composite-canvas.html:
* fast/canvas/canvas-composite-image.html:
* fast/canvas/resources/canvas-composite-image-common.js:
(setupContext):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/canvas-composite-canvas.html
trunk/LayoutTests/fast/canvas/canvas-composite-image.html
trunk/LayoutTests/fast/canvas/resources/canvas-composite-image-common.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (109061 => 109062)

--- trunk/LayoutTests/ChangeLog	2012-02-28 03:01:11 UTC (rev 109061)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 03:09:41 UTC (rev 109062)
@@ -1,3 +1,22 @@
+2012-02-27  Huang Dongsung  
+
+Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);
+incorrect source and destination rect used.
+https://bugs.webkit.org/show_bug.cgi?id=79566
+
+I amended canvas-composite-canvas to cover this bug, and I also amended
+canvas-composite-image because I changed
+LayoutTests/fast/canvas/resources/canvas-composite-image-common.js.
+However, the change of canvas-composite-image is reasonable because
+drawImage(HTMLImageElement) will be able to have a similar bug.
+
+Reviewed by Daniel Bates.
+
+* fast/canvas/canvas-composite-canvas.html:
+* fast/canvas/canvas-composite-image.html:
+* fast/canvas/resources/canvas-composite-image-common.js:
+(setupContext):
+
 2012-02-27  Shawn Singh  
 
 RenderLayer ClipRect not accounting for transforms


Modified: trunk/LayoutTests/fast/canvas/canvas-composite-canvas.html (109061 => 109062)

--- trunk/LayoutTests/fast/canvas/canvas-composite-canvas.html	2012-02-28 03:01:11 UTC (rev 109061)
+++ trunk/LayoutTests/fast/canvas/canvas-composite-canvas.html	2012-02-28 03:09:41 UTC (rev 109062)
@@ -9,7 +9,7 @@
 if (alpha)
   context.globalAlpha = 0.5;
 var sourceElement = document.getElementById('source-canvas');
-context.drawImage(sourceElement, 0, 0);
+context.drawImage(sourceElement, 10, 10);
   }
   
   function setupTest() {


Modified: trunk/LayoutTests/fast/canvas/canvas-composite-image.html (109061 => 109062)

--- trunk/LayoutTests/fast/canvas/canvas-composite-image.html	2012-02-28 03:01:11 UTC (rev 109061)
+++ trunk/LayoutTests/fast/canvas/canvas-composite-image.html	2012-02-28 03:09:41 UTC (rev 109062)
@@ -9,7 +9,7 @@
 if (alpha)
   context.globalAlpha = 0.5;
 var imageElement = document.getElementById('image');
-context.drawImage(imageElement, 0, 0);
+context.drawImage(imageElement, 10, 10);
   }
   
   function setupTest() {}


Modified: trunk/LayoutTests/fast/canvas/resources/canvas-composite-image-common.js (109061 => 109062)

--- trunk/LayoutTests/fast/canvas/resources/canvas-composite-image-common.js	2012-02-28 03:01:11 UTC (rev 109061)
+++ trunk/LayoutTests/fast/canvas/resources/canvas-composite-image-common.js	2012-02-28 03:09:41 UTC (rev 109062)
@@ -284,6 +284,7 @@
   context.translate(40, -10);
   context.scale(0.4, 0.6);
   context.rotate(Math.PI / 8);
+  context.translate(-10, -10);
 }
 
 function addOutput(element, style, innerHTML) {


Modified: trunk/Source/WebCore/ChangeLog (109061 => 109062)

--- trunk/Source/WebCore/ChangeLog	2012-02-28 03:01:11 UTC (rev 109061)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 03:09:41 UTC (rev 109062)
@@ -1,3 +1,18 @@
+2012-02-27  Huang Dongsung  
+
+Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);
+incorrect source and destination rect used.
+https://bugs.webkit.org/show_bug.cgi?id=79566
+
+Pass dstRect and bufferSrcRect to
+CanvasRenderingContext2D::fullCanvasCompositedDrawImage() for the destination
+and source rect, respectively.
+
+Reviewed by Daniel Bates.
+
+* html/canvas

[webkit-changes] [109060] trunk

[shawnsingh]

Title: [109060] trunk








Revision 109060
Author shawnsi...@chromium.org
Date 2012-02-27 18:36:59 -0800 (Mon, 27 Feb 2012)


Log Message
RenderLayer ClipRect not accounting for transforms
https://bugs.webkit.org/show_bug.cgi?id=76486

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/layer-creation/overlap-transformed-and-clipped.html

This patch changes calculateClipRects() so that the clipRect
offset is allowed to be converted across layers with
transforms. This is necessary because the RenderLayerCompositor
needs clipRects in document space, rather than with respect to
some local clipping layer.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::localToContainerPoint):
(WebCore):
* rendering/RenderObject.h:
(RenderObject):

LayoutTests:

* compositing/layer-creation/overlap-transformed-and-clipped-expected.png: Added.
* compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
* compositing/layer-creation/overlap-transformed-and-clipped.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h


Added Paths

trunk/LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.png
trunk/LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt
trunk/LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped.html




Diff

Modified: trunk/LayoutTests/ChangeLog (109059 => 109060)

--- trunk/LayoutTests/ChangeLog	2012-02-28 02:35:29 UTC (rev 109059)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 02:36:59 UTC (rev 109060)
@@ -1,3 +1,14 @@
+2012-02-27  Shawn Singh  
+
+RenderLayer ClipRect not accounting for transforms
+https://bugs.webkit.org/show_bug.cgi?id=76486
+
+Reviewed by Simon Fraser.
+
+* compositing/layer-creation/overlap-transformed-and-clipped-expected.png: Added.
+* compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
+* compositing/layer-creation/overlap-transformed-and-clipped.html: Added.
+
 2012-02-27  Adam Klein  
 
 [MutationObservers] Clear pending mutation records on disconnect()


Added: trunk/LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.png (0 => 109060)

--- trunk/LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.png	(rev 0)
+++ trunk/LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.png	2012-02-28 02:36:59 UTC (rev 109060)
@@ -0,0 +1,4 @@
+\x89PNG
+
+
+IHDR X\x9Av\x82p)tEXtchecksum38db6661a8f7b1efa64f4cb51638e167Krjk\x81IDATx\x9C\xED\xD91\x84@A\x96\x8F#^n\xD2/\xEA\xA2\xEA\x938hy\xCD\xCC\xBCκ\xD7\xEE	\xFC\x98\xCB
\xFC\xE3\xDC=\xF8
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90Y33\xBBG\xDF\xE0d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80

[webkit-changes] [109059] trunk/Source/JavaScriptCore

[oliver]

Title: [109059] trunk/Source/_javascript_Core








Revision 109059
Author oli...@apple.com
Date 2012-02-27 18:35:29 -0800 (Mon, 27 Feb 2012)


Log Message
sputnik/Unicode/Unicode_500/S7.2_A1.6_T1.html crashes in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=79728

Reviewed by Gavin Barraclough.

When initialising a chained get instruction we may end up in a state where
the instruction stream says we have a scopechain, but it has not yet been set
(eg. if allocating the StructureChain itself is what leads to the GC).  We could
re-order the allocation, but it occurs in a couple of places, so it seems less
fragile simply to null check the scopechain slot before we actually visit the slot.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitStructures):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (109058 => 109059)

--- trunk/Source/_javascript_Core/ChangeLog	2012-02-28 02:34:20 UTC (rev 109058)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-02-28 02:35:29 UTC (rev 109059)
@@ -1,3 +1,19 @@
+2012-02-27  Oliver Hunt  
+
+sputnik/Unicode/Unicode_500/S7.2_A1.6_T1.html crashes in the interpreter
+https://bugs.webkit.org/show_bug.cgi?id=79728
+
+Reviewed by Gavin Barraclough.
+
+When initialising a chained get instruction we may end up in a state where
+the instruction stream says we have a scopechain, but it has not yet been set
+(eg. if allocating the StructureChain itself is what leads to the GC).  We could
+re-order the allocation, but it occurs in a couple of places, so it seems less
+fragile simply to null check the scopechain slot before we actually visit the slot.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::visitStructures):
+
 2012-02-27  Filip Pizlo  
 
 Old JIT's style of JSVALUE64 strict equality is subtly wrong


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (109058 => 109059)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2012-02-28 02:34:20 UTC (rev 109058)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2012-02-28 02:35:29 UTC (rev 109059)
@@ -1581,13 +1581,15 @@
 }
 if (vPC[0].u.opcode == interpreter->getOpcode(op_get_by_id_chain) || vPC[0].u.opcode == interpreter->getOpcode(op_get_by_id_getter_chain) || vPC[0].u.opcode == interpreter->getOpcode(op_get_by_id_custom_chain)) {
 visitor.append(&vPC[4].u.structure);
-visitor.append(&vPC[5].u.structureChain);
+if (vPC[5].u.structureChain)
+visitor.append(&vPC[5].u.structureChain);
 return;
 }
 if (vPC[0].u.opcode == interpreter->getOpcode(op_put_by_id_transition)) {
 visitor.append(&vPC[4].u.structure);
 visitor.append(&vPC[5].u.structure);
-visitor.append(&vPC[6].u.structureChain);
+if (vPC[6].u.structureChain)
+visitor.append(&vPC[6].u.structureChain);
 return;
 }
 if (vPC[0].u.opcode == interpreter->getOpcode(op_put_by_id) && vPC[4].u.structure) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109058] trunk

[adamk]

Title: [109058] trunk








Revision 109058
Author ad...@chromium.org
Date 2012-02-27 18:34:20 -0800 (Mon, 27 Feb 2012)


Log Message
[MutationObservers] Clear pending mutation records on disconnect()
https://bugs.webkit.org/show_bug.cgi?id=78639

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/mutation/disconnect-cancel-pending.html

* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::disconnect): Clear pending records.
(WebCore::WebKitMutationObserver::deliver): Avoid calling the callback if no records are pending delivery.

LayoutTests:

* fast/mutation/disconnect-cancel-pending-expected.txt: Added.
* fast/mutation/disconnect-cancel-pending.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/WebKitMutationObserver.cpp


Added Paths

trunk/LayoutTests/fast/mutation/disconnect-cancel-pending-expected.txt
trunk/LayoutTests/fast/mutation/disconnect-cancel-pending.html




Diff

Modified: trunk/LayoutTests/ChangeLog (109057 => 109058)

--- trunk/LayoutTests/ChangeLog	2012-02-28 02:14:37 UTC (rev 109057)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 02:34:20 UTC (rev 109058)
@@ -1,3 +1,13 @@
+2012-02-27  Adam Klein  
+
+[MutationObservers] Clear pending mutation records on disconnect()
+https://bugs.webkit.org/show_bug.cgi?id=78639
+
+Reviewed by Ojan Vafai.
+
+* fast/mutation/disconnect-cancel-pending-expected.txt: Added.
+* fast/mutation/disconnect-cancel-pending.html: Added.
+
 2012-02-27  Brady Eidson  
 
  and https://bugs.webkit.org/show_bug.cgi?id=79725


Added: trunk/LayoutTests/fast/mutation/disconnect-cancel-pending-expected.txt (0 => 109058)

--- trunk/LayoutTests/fast/mutation/disconnect-cancel-pending-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/mutation/disconnect-cancel-pending-expected.txt	2012-02-28 02:34:20 UTC (rev 109058)
@@ -0,0 +1,14 @@
+Test that WebKitMutationObserver.disconnect cancels pending delivery
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Disconnecting should cancel any pending delivery...
+PASS mutations is null
+...and re-observing should not see any of the previously-generated records.
+PASS mutations.length is 1
+PASS mutations[0].attributeName is "bar"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/mutation/disconnect-cancel-pending.html (0 => 109058)

--- trunk/LayoutTests/fast/mutation/disconnect-cancel-pending.html	(rev 0)
+++ trunk/LayoutTests/fast/mutation/disconnect-cancel-pending.html	2012-02-28 02:34:20 UTC (rev 109058)
@@ -0,0 +1,45 @@
+
+
+description('Test that WebKitMutationObserver.disconnect cancels pending delivery');
+
+window.jsTestIsAsync = true;
+var mutations;
+var observer;
+
+function start() {
+mutations = null;
+div = document.createElement('div');
+
+observer = new WebKitMutationObserver(function(m) {
+mutations = m;
+});
+
+observer.observe(div, { attributes: true });
+div.setAttribute('foo', 'bar');
+observer.disconnect();
+setTimeout(next, 0);
+}
+
+function next() {
+debug('Disconnecting should cancel any pending delivery...');
+shouldBeNull('mutations');
+observer.observe(div, { attributes: true });
+div.setAttribute('bar', 'baz');
+setTimeout(finish, 0);
+}
+
+function finish() {
+debug('...and re-observing should not see any of the previously-generated records.');
+shouldBe('mutations.length', '1');
+shouldBe('mutations[0].attributeName', '"bar"');
+finishJSTest();
+}
+
+if (!window.WebKitMutationObserver)
+testFailed('This test requires ENABLE(MUTATION_OBSERVERS)');
+else
+start();
+
+
+

[webkit-changes] [109057] trunk

[rniwa]

Title: [109057] trunk








Revision 109057
Author rn...@webkit.org
Date 2012-02-27 18:14:37 -0800 (Mon, 27 Feb 2012)


Log Message
Extract the logic to merge tests from MergeTestsHandler and add unit tests
https://bugs.webkit.org/show_bug.cgi?id=79602

Reviewed by Hajime Morita.

Extracted Test.merge and TestResult.replace_to_change_test_name out of MergeTestsHandler,
and moved MergeTestsHandler into admin_handlers.py where it belongs.

Added new backend "model-manipulator" to execute tasks to merge tests.

Also revive the inadvertently removed manual submission form on the admin page.

* Websites/webkit-perf.appspot.com/admin_handlers.py:
(AdminDashboardHandler.get_tests):
(MergeTestsHandler):
(MergeTestsHandler.post):
* Websites/webkit-perf.appspot.com/app.yaml:
* Websites/webkit-perf.appspot.com/backends.yaml: Added.
* Websites/webkit-perf.appspot.com/css/admin.css:
* Websites/webkit-perf.appspot.com/js/admin.js:
* Websites/webkit-perf.appspot.com/main.py:
* Websites/webkit-perf.appspot.com/merge_tests_handler.py: Removed.
* Websites/webkit-perf.appspot.com/models.py:
(Test):
(Test.merge):
(TestResult.replace_to_change_test_name):
* Websites/webkit-perf.appspot.com/models_unittest.py:
(DataStoreTestsBase.assertOnlyInstance):
(DataStoreTestsBase):
(DataStoreTestsBase.assertOnlyInstances):
(DataStoreTestsBase.assertEqualUnorderedModelList):
(DataStoreTestsBase.assertEqualUnorderedList):
(_create_build):
(TestModelTests.test_merge):
(TestResultTests):
(TestResultTests.test_get_or_insert_value):
(TestResultTests.test_get_or_insert_stat_value):
(TestResultTests.test_replace_to_change_test_name):
(TestResultTests.test_replace_to_change_test_name_with_stat_value):
(TestResultTests.test_replace_to_change_test_name_overrides_conflicting_result):

Modified Paths

trunk/ChangeLog
trunk/Websites/webkit-perf.appspot.com/admin_handlers.py
trunk/Websites/webkit-perf.appspot.com/app.yaml
trunk/Websites/webkit-perf.appspot.com/css/admin.css
trunk/Websites/webkit-perf.appspot.com/js/admin.js
trunk/Websites/webkit-perf.appspot.com/main.py
trunk/Websites/webkit-perf.appspot.com/models.py
trunk/Websites/webkit-perf.appspot.com/models_unittest.py


Added Paths

trunk/Websites/webkit-perf.appspot.com/backends.yaml


Removed Paths

trunk/Websites/webkit-perf.appspot.com/merge_tests_handler.py




Diff

Modified: trunk/ChangeLog (109056 => 109057)

--- trunk/ChangeLog	2012-02-28 02:05:13 UTC (rev 109056)
+++ trunk/ChangeLog	2012-02-28 02:14:37 UTC (rev 109057)
@@ -1,3 +1,46 @@
+2012-02-27  Ryosuke Niwa  
+
+Extract the logic to merge tests from MergeTestsHandler and add unit tests
+https://bugs.webkit.org/show_bug.cgi?id=79602
+
+Reviewed by Hajime Morita.
+
+Extracted Test.merge and TestResult.replace_to_change_test_name out of MergeTestsHandler,
+and moved MergeTestsHandler into admin_handlers.py where it belongs.
+
+Added new backend "model-manipulator" to execute tasks to merge tests.
+
+Also revive the inadvertently removed manual submission form on the admin page.
+
+* Websites/webkit-perf.appspot.com/admin_handlers.py:
+(AdminDashboardHandler.get_tests):
+(MergeTestsHandler):
+(MergeTestsHandler.post):
+* Websites/webkit-perf.appspot.com/app.yaml:
+* Websites/webkit-perf.appspot.com/backends.yaml: Added.
+* Websites/webkit-perf.appspot.com/css/admin.css:
+* Websites/webkit-perf.appspot.com/js/admin.js:
+* Websites/webkit-perf.appspot.com/main.py:
+* Websites/webkit-perf.appspot.com/merge_tests_handler.py: Removed.
+* Websites/webkit-perf.appspot.com/models.py:
+(Test):
+(Test.merge):
+(TestResult.replace_to_change_test_name):
+* Websites/webkit-perf.appspot.com/models_unittest.py:
+(DataStoreTestsBase.assertOnlyInstance):
+(DataStoreTestsBase):
+(DataStoreTestsBase.assertOnlyInstances):
+(DataStoreTestsBase.assertEqualUnorderedModelList):
+(DataStoreTestsBase.assertEqualUnorderedList):
+(_create_build):
+(TestModelTests.test_merge):
+(TestResultTests):
+(TestResultTests.test_get_or_insert_value):
+(TestResultTests.test_get_or_insert_stat_value):
+(TestResultTests.test_replace_to_change_test_name):
+(TestResultTests.test_replace_to_change_test_name_with_stat_value):
+(TestResultTests.test_replace_to_change_test_name_overrides_conflicting_result):
+
 2012-02-27  ChangSeok Oh  
 
 [EFL] Support mutation observers


Modified: trunk/Websites/webkit-perf.appspot.com/admin_handlers.py (109056 => 109057)

--- trunk/Websites/webkit-perf.appspot.com/admin_handlers.py	2012-02-28 02:05:13 UTC (rev 109056)
+++ trunk/Websites/webkit-perf.appspot.com/admin_handlers.py	2012-02-28 02:14:37 UTC (rev 109057)
@@ -30,10 +30,14 @@
 import webapp2
 import json
 
+from google.appengine.api import taskqueue
 from google.appengine.api import users
 from google.

[webkit-changes] [109056] trunk/Tools

[dpranke]

Title: [109056] trunk/Tools








Revision 109056
Author dpra...@chromium.org
Date 2012-02-27 18:05:13 -0800 (Mon, 27 Feb 2012)


Log Message
nrwt: log multiline stderr/crash output properly
https://bugs.webkit.org/show_bug.cgi?id=79722

Reviewed by Adam Barth.

This cleans up some nits in the log output to make things
slightly easier to read (every line gets timestamped, etc.).

Also tweaks the log message for pixel hash mismatches.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._handle_error):
(SingleTestRunner._compare_image):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py




Diff

Modified: trunk/Tools/ChangeLog (109055 => 109056)

--- trunk/Tools/ChangeLog	2012-02-28 01:59:09 UTC (rev 109055)
+++ trunk/Tools/ChangeLog	2012-02-28 02:05:13 UTC (rev 109056)
@@ -1,3 +1,19 @@
+2012-02-27  Dirk Pranke  
+
+nrwt: log multiline stderr/crash output properly
+https://bugs.webkit.org/show_bug.cgi?id=79722
+
+Reviewed by Adam Barth.
+
+This cleans up some nits in the log output to make things
+slightly easier to read (every line gets timestamped, etc.).
+
+Also tweaks the log message for pixel hash mismatches.
+
+* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
+(SingleTestRunner._handle_error):
+(SingleTestRunner._compare_image):
+
 2012-02-27  Ryosuke Niwa  
 
 Touch the master.cfg to force a reconfig.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (109055 => 109056)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	2012-02-28 01:59:09 UTC (rev 109055)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	2012-02-28 02:05:13 UTC (rev 109056)
@@ -198,11 +198,14 @@
 
 if driver_output.crash:
 failures.append(test_failures.FailureCrash(bool(reference_filename)))
-_log.debug("%s Stacktrace for %s:\n%s" % (self._worker_name, testname,
-  driver_output.error))
+if driver_output.error:
+_log.debug("%s %s crashed, stack trace:" % (self._worker_name, testname))
+else:
+_log.debug("%s %s crashed, no stack trace" % (self._worker_name, testname))
 elif driver_output.error:
-_log.debug("%s %s output stderr lines:\n%s" % (self._worker_name, testname,
-   driver_output.error))
+_log.debug("%s %s output stderr lines:" % (self._worker_name, testname))
+for line in driver_output.error.splitlines():
+_log.debug("  %s" % line)
 return failures
 
 def _compare_output(self, driver_output, expected_driver_output):
@@ -266,7 +269,7 @@
 failures.append(test_failures.FailureImageHashMismatch(diff_result[1]))
 else:
 # See https://bugs.webkit.org/show_bug.cgi?id=69444 for why this isn't a full failure.
-_log.warning('%s -> pixel hash failed (but pixel test still passes)' % self._test_name)
+_log.warning('  %s -> pixel hash failed (but pixel test still passes)' % self._test_name)
 return failures
 
 def _run_reftest(self):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109055] trunk

[beidson]

Title: [109055] trunk








Revision 109055
Author beid...@apple.com
Date 2012-02-27 17:59:09 -0800 (Mon, 27 Feb 2012)


Log Message
 and https://bugs.webkit.org/show_bug.cgi?id=79725
 doesn't work in WebKit2

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Push the WK2  setting to WebCore::Settings.

LayoutTests:

* platform/wk2/Skipped: Unskip some tests that now pass.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (109054 => 109055)

--- trunk/LayoutTests/ChangeLog	2012-02-28 01:51:32 UTC (rev 109054)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 01:59:09 UTC (rev 109055)
@@ -1,3 +1,12 @@
+2012-02-27  Brady Eidson  
+
+ and https://bugs.webkit.org/show_bug.cgi?id=79725
+ doesn't work in WebKit2
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/wk2/Skipped: Unskip some tests that now pass.
+
 2012-02-27  Adam Klein  
 
 Always notify subtree of removal in ContainerNode::removeChildren


Modified: trunk/LayoutTests/platform/wk2/Skipped (109054 => 109055)

--- trunk/LayoutTests/platform/wk2/Skipped	2012-02-28 01:51:32 UTC (rev 109054)
+++ trunk/LayoutTests/platform/wk2/Skipped	2012-02-28 01:59:09 UTC (rev 109055)
@@ -203,7 +203,6 @@
 fast/canvas/webgl/uniform-array-length-overflow.html
 fast/overflow/horizontal-scroll-after-back.html
 http/tests/navigation/go-back-to-error-page.html
-http/tests/navigation/ping-cookie.html
 plugins/application-plugin-plugins-disabled.html
 fast/canvas/webgl/canvas-zero-size.html
 fast/canvas/webgl/context-lost-restored.html
@@ -302,10 +301,7 @@
 # LayoutTestController::applicationCacheDiskUsageForOrigin isn't implemented - https://bugs.webkit.org/show_bug.cgi?id=57127
 http/tests/appcache/origin-usage.html
 http/tests/canvas/webgl/origin-clean-conformance.html
-http/tests/inspector/network/ping.html
 http/tests/navigation/ping-cross-origin-from-https.html
-http/tests/navigation/ping-cross-origin.html
-http/tests/navigation/ping-same-origin.html
 http/tests/security/webgl-remote-read-remote-image-allowed.html
 http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
 http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html


Modified: trunk/Source/WebKit2/ChangeLog (109054 => 109055)

--- trunk/Source/WebKit2/ChangeLog	2012-02-28 01:51:32 UTC (rev 109054)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-28 01:59:09 UTC (rev 109055)
@@ -1,3 +1,13 @@
+2012-02-27  Brady Eidson  
+
+ and https://bugs.webkit.org/show_bug.cgi?id=79725
+ doesn't work in WebKit2
+
+Reviewed by Alexey Proskuryakov.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::updatePreferences): Push the WK2  setting to WebCore::Settings.
+
 2012-02-27  Enrica Casucci  
 
 WebKit2: implement platform strategy to access Pasteboard in the UI process.


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (109054 => 109055)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2012-02-28 01:51:32 UTC (rev 109054)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2012-02-28 01:59:09 UTC (rev 109055)
@@ -1893,6 +1893,7 @@
 settings->setMediaPlaybackRequiresUserGesture(store.getBoolValueForKey(WebPreferencesKey::mediaPlaybackRequiresUserGestureKey()));
 settings->setMediaPlaybackAllowsInline(store.getBoolValueForKey(WebPreferencesKey::mediaPlaybackAllowsInlineKey()));
 settings->setMockScrollbarsEnabled(store.getBoolValueForKey(WebPreferencesKey::mockScrollbarsEnabledKey()));
+settings->setHyperlinkAuditingEnabled(store.getBoolValueForKey(WebPreferencesKey::hyperlinkAuditingEnabledKey()));
 
 // : It is necessary to force compositing when accelerate drawing
 // is enabled on Mac so that scrollbars are always in their own layers.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109054] trunk

[adamk]

Title: [109054] trunk








Revision 109054
Author ad...@chromium.org
Date 2012-02-27 17:51:32 -0800 (Mon, 27 Feb 2012)


Log Message
Always notify subtree of removal in ContainerNode::removeChildren
https://bugs.webkit.org/show_bug.cgi?id=79316

Reviewed by Ryosuke Niwa.

Source/WebCore:

In the inDocument case, Node::removedFromDocument is called.
In the out-of-document case, call ContainerNode::removedFromTree to ensure,
e.g., form-associated elements are properly disconnected.

Test: fast/forms/form-associated-element-removal.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):

LayoutTests:

* fast/forms/form-associated-element-removal-expected.txt: Added.
* fast/forms/form-associated-element-removal.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp


Added Paths

trunk/LayoutTests/fast/forms/form-associated-element-removal-expected.txt
trunk/LayoutTests/fast/forms/form-associated-element-removal.html




Diff

Modified: trunk/LayoutTests/ChangeLog (109053 => 109054)

--- trunk/LayoutTests/ChangeLog	2012-02-28 01:47:58 UTC (rev 109053)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 01:51:32 UTC (rev 109054)
@@ -1,3 +1,13 @@
+2012-02-27  Adam Klein  
+
+Always notify subtree of removal in ContainerNode::removeChildren
+https://bugs.webkit.org/show_bug.cgi?id=79316
+
+Reviewed by Ryosuke Niwa.
+
+* fast/forms/form-associated-element-removal-expected.txt: Added.
+* fast/forms/form-associated-element-removal.html: Added.
+
 2012-02-27  Adrienne Walker  
 
 [chromium] Unreviewed gardening, mark another svg test as flaky crasher


Added: trunk/LayoutTests/fast/forms/form-associated-element-removal-expected.txt (0 => 109054)

--- trunk/LayoutTests/fast/forms/form-associated-element-removal-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/form-associated-element-removal-expected.txt	2012-02-28 01:51:32 UTC (rev 109054)
@@ -0,0 +1,11 @@
+Removing all children of a form should disassociate any form controls in that subtree
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS input.form is null
+PASS form.elements.length is 0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/forms/form-associated-element-removal.html (0 => 109054)

--- trunk/LayoutTests/fast/forms/form-associated-element-removal.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/form-associated-element-removal.html	2012-02-28 01:51:32 UTC (rev 109054)
@@ -0,0 +1,12 @@
+
+
+description("Removing all children of a form should disassociate any form controls in that subtree");
+var form = document.createElement('form');
+var input = document.createElement('input');
+form.appendChild(input);
+form.innerHTML = '';
+shouldBeNull("input.form");
+shouldBe("form.elements.length", "0");
+
+

[webkit-changes] [109053] trunk/Tools

[rniwa]

Title: [109053] trunk/Tools








Revision 109053
Author rn...@webkit.org
Date 2012-02-27 17:47:58 -0800 (Mon, 27 Feb 2012)


Log Message
Touch the master.cfg to force a reconfig.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildAndTestLeaksFactory):
(NewBuildAndTestFactory):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (109052 => 109053)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2012-02-28 01:36:25 UTC (rev 109052)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2012-02-28 01:47:58 UTC (rev 109053)
@@ -765,9 +765,11 @@
 TestClass = RunWebKitLeakTests
 ExtractTestResultsClass = ExtractTestResultsAndLeaks
 
+
 class NewBuildAndTestFactory(BuildAndTestFactory):
 TestClass = NewRunWebKitTests
 
+
 class TestWebKit2Factory(TestFactory):
 TestClass = RunWebKit2Tests
 


Modified: trunk/Tools/ChangeLog (109052 => 109053)

--- trunk/Tools/ChangeLog	2012-02-28 01:36:25 UTC (rev 109052)
+++ trunk/Tools/ChangeLog	2012-02-28 01:47:58 UTC (rev 109053)
@@ -1,3 +1,11 @@
+2012-02-27  Ryosuke Niwa  
+
+Touch the master.cfg to force a reconfig.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(BuildAndTestLeaksFactory):
+(NewBuildAndTestFactory):
+
 2012-02-27  Jacky Jiang  
 
 [BlackBerry] Upstream BlackBerry API web page related files






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109052] trunk/Source/WebCore

[abarth]

Title: [109052] trunk/Source/WebCore








Revision 109052
Author aba...@webkit.org
Date 2012-02-27 17:36:25 -0800 (Mon, 27 Feb 2012)


Log Message
Repair license blocks for files created during modularization
https://bugs.webkit.org/show_bug.cgi?id=79721

Reviewed by Eric Seidel.

We failed to copy the license blocks correctly when moving code into
these files.  This patch restores the correct license blocks.

* Modules/geolocation/NavigatorGeolocation.cpp:
* Modules/geolocation/NavigatorGeolocation.h:
* Modules/mediastream/NavigatorMediaStream.cpp:
* Modules/mediastream/NavigatorMediaStream.h:
* bindings/js/JSDOMWindowWebAudioCustom.cpp:
* bindings/js/JSDOMWindowWebSocketCustom.cpp:
* storage/DOMWindowSQLDatabase.cpp:
* storage/DOMWindowSQLDatabase.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.cpp
trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.h
trunk/Source/WebCore/Modules/mediastream/NavigatorMediaStream.cpp
trunk/Source/WebCore/Modules/mediastream/NavigatorMediaStream.h
trunk/Source/WebCore/bindings/js/JSDOMWindowWebAudioCustom.cpp
trunk/Source/WebCore/bindings/js/JSDOMWindowWebSocketCustom.cpp
trunk/Source/WebCore/storage/DOMWindowSQLDatabase.cpp
trunk/Source/WebCore/storage/DOMWindowSQLDatabase.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (109051 => 109052)

--- trunk/Source/WebCore/ChangeLog	2012-02-28 01:34:18 UTC (rev 109051)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 01:36:25 UTC (rev 109052)
@@ -1,3 +1,22 @@
+2012-02-27  Adam Barth  
+
+Repair license blocks for files created during modularization
+https://bugs.webkit.org/show_bug.cgi?id=79721
+
+Reviewed by Eric Seidel.
+
+We failed to copy the license blocks correctly when moving code into
+these files.  This patch restores the correct license blocks.
+
+* Modules/geolocation/NavigatorGeolocation.cpp:
+* Modules/geolocation/NavigatorGeolocation.h:
+* Modules/mediastream/NavigatorMediaStream.cpp:
+* Modules/mediastream/NavigatorMediaStream.h:
+* bindings/js/JSDOMWindowWebAudioCustom.cpp:
+* bindings/js/JSDOMWindowWebSocketCustom.cpp:
+* storage/DOMWindowSQLDatabase.cpp:
+* storage/DOMWindowSQLDatabase.h:
+
 2012-02-27  Julien Chaffraix  
 
 Extract the logic for computing the dirty rows / columns out of RenderTableSection::paintObject


Modified: trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.cpp (109051 => 109052)

--- trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.cpp	2012-02-28 01:34:18 UTC (rev 109051)
+++ trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.cpp	2012-02-28 01:36:25 UTC (rev 109052)
@@ -1,26 +1,23 @@
 /*
- * Copyright (C) 2012, Google Inc. All rights reserved.
+ *  Copyright (C) 2000 Harri Porten (por...@kde.org)
+ *  Copyright (c) 2000 Daniel Molkentin (molken...@kde.org)
+ *  Copyright (c) 2000 Stefan Schimanski (schi...@kde.org)
+ *  Copyright (C) 2003, 2004, 2005, 2006 Apple Computer, Inc.
+ *  Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are met:
+ *  This library is free software; you can redistribute it and/or
+ *  modify it under the terms of the GNU Lesser General Public
+ *  License as published by the Free Software Foundation; either
+ *  version 2 of the License, or (at your option) any later version.
  *
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
+ *  This library is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *  Lesser General Public License for more details.
  *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE
- * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
- * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
- * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
- * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
- * DAMAGE.
+ *  You shou

[webkit-changes] [109050] trunk/Tools

[rniwa]

Title: [109050] trunk/Tools








Revision 109050
Author rn...@webkit.org
Date 2012-02-27 17:32:09 -0800 (Mon, 27 Feb 2012)


Log Message
Add Windows and Linux Chromium perf bots
https://bugs.webkit.org/show_bug.cgi?id=79418

Reviewed by Tony Chang.

Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
the dedicated perf bot slave (uses the same hardware).

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (109049 => 109050)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-02-28 01:30:06 UTC (rev 109049)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-02-28 01:32:09 UTC (rev 109050)
@@ -55,12 +55,15 @@
 
 { "name": "google-windows-1", "platform": "chromium-win" },
 { "name": "google-windows-2", "platform": "chromium-win" },
+{ "name": "google-windows-perf", "platform": "chromium-win" },
 { "name": "google-mac-1", "platform": "chromium-mac" },
 { "name": "google-mac-2", "platform": "chromium-mac" },
 { "name": "google-mac-3", "platform": "chromium-mac" },
 { "name": "google-mac-4", "platform": "chromium-mac" },
+{ "name": "google-mac-perf", "platform": "chromium-mac" },
 { "name": "google-linux-1", "platform": "chromium-linux" },
 { "name": "google-linux-2", "platform": "chromium-linux" },
+{ "name": "google-linux-perf", "platform": "chromium-linux" },
 { "name": "google-linux-android", "platform": "chromium-android" },
 { "name": "google-linux-flexbox", "platform": "chromium-linux" },
 
@@ -232,6 +235,11 @@
   "slavenames": ["google-windows-2"]
 },
 {
+  "name": "Chromium Win Release (Perf)", "type": "BuildAndPerfTest", "builddir": "chromium-win-perf-tests",
+  "platform": "chromium-win", "configuration": "release", "architectures": ["i386"],
+  "slavenames": ["google-windows-perf"]
+},
+{
   "name": "Chromium Mac Release", "type": "Build", "builddir": "chromium-mac-release",
   "platform": "chromium-mac", "configuration": "release", "architectures": ["i386"],
   "slavenames": ["google-mac-1", "google-mac-3"]
@@ -239,9 +247,14 @@
 {
   "name": "Chromium Mac Release (Tests)", "type": "NewBuildAndTest", "builddir": "chromium-mac-release-tests",
   "platform": "chromium-mac", "configuration": "release", "architectures": ["i386"],
-  "slavenames": ["google-mac-2"]
+  "slavenames": ["google-mac-2", "google-mac-4"]
 },
 {
+  "name": "Chromium Mac Release (Perf)", "type": "BuildAndPerfTest", "builddir": "chromium-mac-perf-tests",
+  "platform": "chromium-mac", "configuration": "release", "architectures": ["i386"],
+  "slavenames": ["google-mac-perf"]
+},
+{
   "name": "Chromium Linux Release", "type": "Build", "builddir": "chromium-linux-release",
   "platform": "chromium-linux", "configuration": "release", "architectures": ["i386"],
   "slavenames": ["google-linux-1"]
@@ -252,6 +265,11 @@
   "slavenames": ["google-linux-2"]
 },
 {
+  "name": "Chromium Linux Release (Perf)", "type": "BuildAndPerfTest", "builddir": "chromium-linux-perf-tests",
+  "platform": "chromium-linx", "configuration": "release", "architectures": ["i386"],
+  "slavenames": ["google-linx-perf"]
+},
+{
   "name": "Chromium Linux Release (Grid Layout)", "type": "NewBuildAndTest", "builddir": "chromium-linux-flexbox",
   "platform": "chromium-linux", "configuration": "release", "architectures": ["i386"],
   "slavenames": ["google-linux-flexbox"]
@@ -262,11 +280,6 @@
   "slavenames": ["google-linux-android"]
 },
 {
-  "name": "Chromium Mac Release (Perf)", "type": "BuildAndPerfTest", "builddir": "chromium-mac-perf-tests",
-  "platform": "chromium-mac", "configuration": "release", "architectures": ["i386"],
-  "slavenames": ["google-mac-4"]
-},
-{

[webkit-changes] [109049] trunk/Tools

[wangxianzhu]

Title: [109049] trunk/Tools








Revision 109049
Author wangxian...@chromium.org
Date 2012-02-27 17:30:06 -0800 (Mon, 27 Feb 2012)


Log Message
Undefined variable 'current' when running chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=79696

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._read_prompt):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py




Diff

Modified: trunk/Tools/ChangeLog (109048 => 109049)

--- trunk/Tools/ChangeLog	2012-02-28 01:24:32 UTC (rev 109048)
+++ trunk/Tools/ChangeLog	2012-02-28 01:30:06 UTC (rev 109049)
@@ -1,3 +1,13 @@
+2012-02-27  Xianzhu Wang  
+
+Undefined variable 'current' when running chromium_android.py
+https://bugs.webkit.org/show_bug.cgi?id=79696
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(ChromiumAndroidDriver._read_prompt):
+
 2012-02-27  Greg Billock  
 
 Add more tests for web intents


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (109048 => 109049)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	2012-02-28 01:24:32 UTC (rev 109048)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	2012-02-28 01:30:06 UTC (rev 109049)
@@ -529,4 +529,4 @@
 return
 if last_char == '$':
 raise AssertionError('Adbd is not running as root')
-last_char = current
+last_char = current_char






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109048] trunk/LayoutTests

[enne]

Title: [109048] trunk/LayoutTests








Revision 109048
Author e...@google.com
Date 2012-02-27 17:24:32 -0800 (Mon, 27 Feb 2012)


Log Message
[chromium] Unreviewed gardening, mark another svg test as flaky crasher
https://bugs.webkit.org/show_bug.cgi?id=79707

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (109047 => 109048)

--- trunk/LayoutTests/ChangeLog	2012-02-28 01:19:47 UTC (rev 109047)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 01:24:32 UTC (rev 109048)
@@ -1,5 +1,12 @@
 2012-02-27  Adrienne Walker  
 
+[chromium] Unreviewed gardening, mark another svg test as flaky crasher
+https://bugs.webkit.org/show_bug.cgi?id=79707
+
+* platform/chromium/test_expectations.txt:
+
+2012-02-27  Adrienne Walker  
+
 [chromium] Unreviewed gardening, mark more svg tests as flaky crashers
 https://bugs.webkit.org/show_bug.cgi?id=79707
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109047 => 109048)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-28 01:19:47 UTC (rev 109047)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-28 01:24:32 UTC (rev 109048)
@@ -4260,3 +4260,4 @@
 BUGWK79707 SNOWLEOPARD : svg/as-background-image/svg-as-background-6.html = PASS TIMEOUT IMAGE CRASH
 BUGWK79707 MAC : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = TEXT IMAGE IMAGE+TEXT CRASH
 BUGWK79707 MAC : svg/custom/font-face-not-in-document.svg = PASS CRASH
+BUGWK79707 MAC : svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml = PASS CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109047] branches/chromium/1025

[rniwa]

Title: [109047] branches/chromium/1025








Revision 109047
Author rn...@webkit.org
Date 2012-02-27 17:19:47 -0800 (Mon, 27 Feb 2012)


Log Message
Merge 108111 - REGRESSION: empty span creates renders with non-zero height
https://bugs.webkit.org/show_bug.cgi?id=76465

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/css/empty-span.html
   fast/css/non-empty-span.html

Empty inlines with line-height, vertical-alignment or font metrics should only get a linebox if there is some
other content in the line. So only create line boxes for such elements on lines that are not empty.

This patch fixes a regression where an empty inline with line-height was propagating its height to an empty line.
It also fixes cases where lines with content that had a leading empty inline element weren't respecting the
vertical alignment or font-height of the empty inline.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::constructLine): only create line boxes for lines that are not empty.
(WebCore::requiresLineBoxForContent): an inline flow with line-height, vertical-alignment, or font-size
 will need a linebox if the rest of the line is not empty.
(WebCore):
(WebCore::alwaysRequiresLineBox): rename from inlineFlowRequiresLineBox.
(WebCore::requiresLineBox):
(WebCore::RenderBlock::LineBreaker::nextLineBreak): if the inline flow definitely requires a line, mark
 the line non-empty - otherwise hold off.

LayoutTests:

* fast/css/empty-span-expected.html: Added.
* fast/css/empty-span.html: Added.
* fast/css/non-empty-span.html: Added.
* platform/chromium/test_expectations.txt: Suppress result until rebaseline on MAC and WIN.
* platform/chromium-linux-x86/fast/css/non-empty-span-expected.png: Added.
* platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt: Added.

TBR=rob...@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9478022

Modified Paths

branches/chromium/1025/Source/WebCore/rendering/RenderBlockLineLayout.cpp


Added Paths

branches/chromium/1025/LayoutTests/fast/css/empty-span-expected.html
branches/chromium/1025/LayoutTests/fast/css/empty-span.html
branches/chromium/1025/LayoutTests/fast/css/non-empty-span.html
branches/chromium/1025/LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.png
branches/chromium/1025/LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt




Diff

Copied: branches/chromium/1025/LayoutTests/fast/css/empty-span-expected.html (from rev 108111, trunk/LayoutTests/fast/css/empty-span-expected.html) (0 => 109047)

--- branches/chromium/1025/LayoutTests/fast/css/empty-span-expected.html	(rev 0)
+++ branches/chromium/1025/LayoutTests/fast/css/empty-span-expected.html	2012-02-28 01:19:47 UTC (rev 109047)
@@ -0,0 +1,15 @@
+
+
+  
+  
+Before empty span
+
+After empty span
+Before empty span
+
+After empty span
+Before empty span
+
+After empty span
+  
+
\ No newline at end of file


Copied: branches/chromium/1025/LayoutTests/fast/css/empty-span.html (from rev 108111, trunk/LayoutTests/fast/css/empty-span.html) (0 => 109047)

--- branches/chromium/1025/LayoutTests/fast/css/empty-span.html	(rev 0)
+++ branches/chromium/1025/LayoutTests/fast/css/empty-span.html	2012-02-28 01:19:47 UTC (rev 109047)
@@ -0,0 +1,17 @@
+
+
+  
+  
+
+Before empty span
+
+After empty span
+Before empty span
+
+After empty span
+Before empty span
+
+After empty span
+  
+
\ No newline at end of file


Copied: branches/chromium/1025/LayoutTests/fast/css/non-empty-span.html (from rev 108111, trunk/LayoutTests/fast/css/non-empty-span.html) (0 => 109047)

--- branches/chromium/1025/LayoutTests/fast/css/non-empty-span.html	(rev 0)
+++ branches/chromium/1025/LayoutTests/fast/css/non-empty-span.html	2012-02-28 01:19:47 UTC (rev 109047)
@@ -0,0 +1,17 @@
+
+
+  
+  
+
+Before empty span
+X
+After empty span
+Before empty span
+X
+After empty span
+Before empty span
+X
+After empty span
+  
+
\ No newline at end of file


Copied: branches/chromium/1025/LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.png (from rev 108111, trunk/LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.png)

(Binary files differ)


Copied: branches/chromium/1025/LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt (from rev 108111, trunk/LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt) (0 => 109047)

--- branches/chromium/1025/LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt	(rev 0)
+++ branches/chromium/1025/LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt	2012-02-28 01:19:47 UTC (rev 109047)
@@ -0,0 +1,35 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x474
+  RenderBlock {HTML

[webkit-changes] [109046] trunk/LayoutTests

[enne]

Title: [109046] trunk/LayoutTests








Revision 109046
Author e...@google.com
Date 2012-02-27 17:16:55 -0800 (Mon, 27 Feb 2012)


Log Message
[chromium] Unreviewed gardening, mark more svg tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=79707

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (109045 => 109046)

--- trunk/LayoutTests/ChangeLog	2012-02-28 01:12:37 UTC (rev 109045)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 01:16:55 UTC (rev 109046)
@@ -1,3 +1,10 @@
+2012-02-27  Adrienne Walker  
+
+[chromium] Unreviewed gardening, mark more svg tests as flaky crashers
+https://bugs.webkit.org/show_bug.cgi?id=79707
+
+* platform/chromium/test_expectations.txt:
+
 2012-02-27  Daniel Bates  
 
 Add test case for ::selection:window-inactive


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109045 => 109046)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-28 01:12:37 UTC (rev 109045)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-28 01:16:55 UTC (rev 109046)
@@ -1032,7 +1032,8 @@
 // or change the test upstream to specify explicitly what font to use.
 // The mask part of this test is totally wrong.
 BUGCR3244 LEOPARD LINUX WIN : svg/as-background-image/svg-as-background-6.html = FAIL
-BUGWK54322 SNOWLEOPARD : svg/as-background-image/svg-as-background-6.html = TIMEOUT IMAGE
+// Commented out because of BUGWK79707 below
+//BUGWK54322 SNOWLEOPARD : svg/as-background-image/svg-as-background-6.html = TIMEOUT IMAGE
 
 // Our gradients are wrong here.
 BUGCR19559 LINUX WIN : svg/W3C-SVG-1.1/pservers-grad-08-b.svg = FAIL
@@ -3383,7 +3384,8 @@
 
 BUGWK71211 GPU LINUX DEBUG : fast/canvas/shadow-offset-3.html = PASS CRASH
 
-BUGWK71673 MAC : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = TEXT IMAGE IMAGE+TEXT
+// Commented out because of BUGWK79707 below
+//BUGWK71673 MAC : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = TEXT IMAGE IMAGE+TEXT
 BUGWK71673 WIN LINUX : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = PASS IMAGE IMAGE+TEXT
 
 BUGWK71278 SLOW WIN : fast/events/dispatch-message-string-data.html = PASS
@@ -3477,7 +3479,8 @@
 BUGWK73643 WIN MAC : svg/filters/filter-placement-issue.svg = IMAGE
 //BUGWK73643 WIN MAC : svg/filters/filterRes.svg = IMAGE
 BUGWK73643 WIN MAC : svg/filters/filterRes2.svg = IMAGE
-BUGWK73643 WIN MAC : svg/as-background-image/svg-as-background-2.html = IMAGE
+// This also occurs on MAC, but is merged with BUGWK79707 below
+BUGWK73643 WIN : svg/as-background-image/svg-as-background-2.html = IMAGE
 
 BUGWK73692 : media/event-attributes.html = TEXT PASS
 
@@ -4252,3 +4255,8 @@
 BUGWK79707 MAC RELEASE : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS CRASH
 BUGWK79707 MAC DEBUG : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS CRASH IMAGE+TEXT
 BUGWK79707 MAC : svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html = PASS CRASH
+BUGWK79707 MAC : svg/zoom/page/zoom-zoom-coords.xhtml = PASS CRASH
+BUGWK79707 MAC : svg/as-background-image/svg-as-background-2.html = PASS IMAGE CRASH
+BUGWK79707 SNOWLEOPARD : svg/as-background-image/svg-as-background-6.html = PASS TIMEOUT IMAGE CRASH
+BUGWK79707 MAC : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = TEXT IMAGE IMAGE+TEXT CRASH
+BUGWK79707 MAC : svg/custom/font-face-not-in-document.svg = PASS CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109045] trunk/LayoutTests

[dbates]

Title: [109045] trunk/LayoutTests








Revision 109045
Author dba...@webkit.org
Date 2012-02-27 17:12:37 -0800 (Mon, 27 Feb 2012)


Log Message
Add test case for ::selection:window-inactive
https://bugs.webkit.org/show_bug.cgi?id=79623

Reviewed by Beth Dakin.

Add reftest to ensure that we don't regress inactive selection color.

For completeness, support for inactive selection color was added in
 ().

* fast/selectors/selection-window-inactive-expected.html: Added.
* fast/selectors/selection-window-inactive.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/selectors/selection-window-inactive-expected.html
trunk/LayoutTests/fast/selectors/selection-window-inactive.html




Diff

Modified: trunk/LayoutTests/ChangeLog (109044 => 109045)

--- trunk/LayoutTests/ChangeLog	2012-02-28 01:10:26 UTC (rev 109044)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 01:12:37 UTC (rev 109045)
@@ -1,3 +1,18 @@
+2012-02-27  Daniel Bates  
+
+Add test case for ::selection:window-inactive
+https://bugs.webkit.org/show_bug.cgi?id=79623
+
+Reviewed by Beth Dakin.
+
+Add reftest to ensure that we don't regress inactive selection color.
+
+For completeness, support for inactive selection color was added in
+ ().
+
+* fast/selectors/selection-window-inactive-expected.html: Added.
+* fast/selectors/selection-window-inactive.html: Added.
+
 2012-02-27  Greg Billock  
 
 Add more tests for web intents


Added: trunk/LayoutTests/fast/selectors/selection-window-inactive-expected.html (0 => 109045)

--- trunk/LayoutTests/fast/selectors/selection-window-inactive-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/selectors/selection-window-inactive-expected.html	2012-02-28 01:12:37 UTC (rev 109045)
@@ -0,0 +1,8 @@
+
+
+span {
+background-color: rgba(63, 128, 33, 0.95);
+color: black;
+}
+
+Any textual selection in this sentence should have a green background when the window is inactive.


Added: trunk/LayoutTests/fast/selectors/selection-window-inactive.html (0 => 109045)

--- trunk/LayoutTests/fast/selectors/selection-window-inactive.html	(rev 0)
+++ trunk/LayoutTests/fast/selectors/selection-window-inactive.html	2012-02-28 01:12:37 UTC (rev 109045)
@@ -0,0 +1,18 @@
+
+
+::selection {
+background-color: blue;
+color: yellow;
+}
+::selection:window-inactive {
+background-color: rgba(63, 128, 33, 0.95); /* green; alpha < 1 so that we don't blend the background color with white. */ 
+color: black;
+}
+
+Any textual selection in this sentence should have a green background when the window is inactive.
+
+var span = document.querySelector("span");
+window.getSelection().setBaseAndExtent(span, 0, span, 1);
+if (window.layoutTestController)
+layoutTestController.setWindowIsKey(false);
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109044] branches/chromium/1025

[bashi]

Title: [109044] branches/chromium/1025








Revision 109044
Author ba...@chromium.org
Date 2012-02-27 17:10:26 -0800 (Mon, 27 Feb 2012)


Log Message
Merge 108724 - Don't clear IntentRequest callback pointers on stop()

This causes re-entry into ScriptExecutionContext when
the ActiveDOMCallback objects get deleted, which crashes.
Instead, just de-activate the object and wait for
context destruction to clean up.

Test crashes consistently without fix and passes with fix.
Added some test infrastructure to support this test.
https://bugs.webkit.org/show_bug.cgi?id=78638

Patch by Greg Billock  on 2012-02-23
Reviewed by Adam Barth.

* Modules/intents/IntentRequest.cpp:
(WebCore::IntentRequest::IntentRequest):
(WebCore::IntentRequest::stop):
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):
* Modules/intents/IntentRequest.h:
(IntentRequest):

TBR=gbill...@google.com
Review URL: https://chromiumcodereview.appspot.com/9479030

Modified Paths

branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.cpp
branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.h
branches/chromium/1025/Tools/DumpRenderTree/chromium/WebViewHost.cpp
branches/chromium/1025/Tools/DumpRenderTree/chromium/WebViewHost.h


Added Paths

branches/chromium/1025/LayoutTests/webintents/web-intents-reload-expected.txt
branches/chromium/1025/LayoutTests/webintents/web-intents-reload.html




Diff

Copied: branches/chromium/1025/LayoutTests/webintents/web-intents-reload-expected.txt (from rev 108724, trunk/LayoutTests/webintents/web-intents-reload-expected.txt) (0 => 109044)

--- branches/chromium/1025/LayoutTests/webintents/web-intents-reload-expected.txt	(rev 0)
+++ branches/chromium/1025/LayoutTests/webintents/web-intents-reload-expected.txt	2012-02-28 01:10:26 UTC (rev 109044)
@@ -0,0 +1,10 @@
+Received Web Intent: action="" type=type
+* loaded
+* sent mouseup
+* loaded replacement page
+ 
+
+
+Frame: 'frame'
+
+PASS


Copied: branches/chromium/1025/LayoutTests/webintents/web-intents-reload.html (from rev 108724, trunk/LayoutTests/webintents/web-intents-reload.html) (0 => 109044)

--- branches/chromium/1025/LayoutTests/webintents/web-intents-reload.html	(rev 0)
+++ branches/chromium/1025/LayoutTests/webintents/web-intents-reload.html	2012-02-28 01:10:26 UTC (rev 109044)
@@ -0,0 +1,49 @@
+
+  
+
+  var latch = true;
+
+  function buttonClicked() {
+frames[0].startIntent();
+  }
+
+  function frameloaded() {
+if (latch) {
+  latch = false;
+  startTest();
+  return;
+}
+
+debug("* loaded replacement page");
+
+if (window.layoutTestController) {
+  window.layoutTestController.notifyDone();
+}
+  }
+
+  function startTest() {
+if (window.layoutTestController) {
+  window.layoutTestController.waitUntilDone();
+  window.layoutTestController.dumpChildFramesAsText();
+}
+
+debug("* loaded");
+
+// We must simulate a button press with eventSender because intents
+// require a user gesture.
+var button = document.getElementById("button");
+if (eventSender) {
+  eventSender.mouseMoveTo(button.getBoundingClientRect().left + 2, button.getBoundingClientRect().top + 12);
+  eventSender.mouseDown();
+  eventSender.mouseUp();
+  debug("* sent mouseup");
+}
+  }
+
+  
+
+
+
+


Modified: branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.cpp (109043 => 109044)

--- branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.cpp	2012-02-28 01:05:27 UTC (rev 109043)
+++ branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.cpp	2012-02-28 01:10:26 UTC (rev 109044)
@@ -52,24 +52,26 @@
 , m_intent(intent)
 , m_successCallback(successCallback)
 , m_errorCallback(errorCallback)
+, m_stopped(false)
 {
 }
 
 void IntentRequest::contextDestroyed()
 {
 ContextDestructionObserver::contextDestroyed();
-m_successCallback.clear();
-m_errorCallback.clear();
+m_stopped = true;
 }
 
 void IntentRequest::stop()
 {
-m_successCallback.clear();
-m_errorCallback.clear();
+m_stopped = true;
 }
 
 void IntentRequest::postResult(SerializedScriptValue* data)
 {
+if (m_stopped)
+return;
+
 // Callback could lead to deletion of this.
 RefPtr protector(this);
 
@@ -84,6 +86,9 @@
 
 void IntentRequest::postFailure(SerializedScriptValue* data)
 {
+if (m_stopped)
+return;
+
 // Callback could lead to deletion of this.
 RefPtr protector(this);
 


Modified: branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.h (109043 => 109044)

--- branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.h	2012-02-28 01:05:27 UTC (rev 109043)
+++ branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.h	2012-02-28

[webkit-changes] [109043] trunk/Source/WebKit/chromium

[enne]

Title: [109043] trunk/Source/WebKit/chromium








Revision 109043
Author e...@google.com
Date 2012-02-27 17:05:27 -0800 (Mon, 27 Feb 2012)


Log Message
[chromium] Unreviewed gardening, disable TransparencyWinTest unit tests
https://bugs.webkit.org/show_bug.cgi?id=79718

* tests/TransparencyWinTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/TransparencyWinTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (109042 => 109043)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-28 01:05:10 UTC (rev 109042)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-28 01:05:27 UTC (rev 109043)
@@ -1,3 +1,10 @@
+2012-02-27  Adrienne Walker  
+
+[chromium] Unreviewed gardening, disable TransparencyWinTest unit tests
+https://bugs.webkit.org/show_bug.cgi?id=79718
+
+* tests/TransparencyWinTest.cpp:
+
 2012-02-26  Hajime Morrita  
 
 Move ChromeClient::showContextMenu() to ContextMenuClient


Modified: trunk/Source/WebKit/chromium/tests/TransparencyWinTest.cpp (109042 => 109043)

--- trunk/Source/WebKit/chromium/tests/TransparencyWinTest.cpp	2012-02-28 01:05:10 UTC (rev 109042)
+++ trunk/Source/WebKit/chromium/tests/TransparencyWinTest.cpp	2012-02-28 01:05:27 UTC (rev 109043)
@@ -98,7 +98,7 @@
 return out;
 }
 
-TEST(TransparencyWin, NoLayer)
+TEST(TransparencyWin, DISABLED_NoLayer)
 {
 OwnPtr src(ImageBuffer::create(IntSize(17, 16), ColorSpaceDeviceRGB));
 
@@ -137,7 +137,7 @@
 src->context()->restore();
 }
 
-TEST(TransparencyWin, WhiteLayer)
+TEST(TransparencyWin, DISABLED_WhiteLayer)
 {
 OwnPtr src(ImageBuffer::create(IntSize(16, 16), ColorSpaceDeviceRGB));
 
@@ -189,7 +189,7 @@
 src->context()->restore();
 }
 
-TEST(TransparencyWin, TextComposite)
+TEST(TransparencyWin, DISABLED_TextComposite)
 {
 OwnPtr src(ImageBuffer::create(IntSize(16, 16), ColorSpaceDeviceRGB));
 
@@ -208,7 +208,7 @@
 }
 }
 
-TEST(TransparencyWin, OpaqueCompositeLayer)
+TEST(TransparencyWin, DISABLED_OpaqueCompositeLayer)
 {
 OwnPtr src(ImageBuffer::create(IntSize(16, 16), ColorSpaceDeviceRGB));
 
@@ -277,7 +277,7 @@
 src->context()->restore();
 }
 
-TEST(TransparencyWin, WhiteLayerPixelTest)
+TEST(TransparencyWin, DISABLED_WhiteLayerPixelTest)
 {
 // Make a total transparent buffer, and draw the white layer inset by 1 px.
 OwnPtr src(ImageBuffer::create(IntSize(16, 16), ColorSpaceDeviceRGB));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109042] trunk/Source/WebCore

[jchaffraix]

Title: [109042] trunk/Source/WebCore








Revision 109042
Author jchaffr...@webkit.org
Date 2012-02-27 17:05:10 -0800 (Mon, 27 Feb 2012)


Log Message
Extract the logic for computing the dirty rows / columns out of RenderTableSection::paintObject
https://bugs.webkit.org/show_bug.cgi?id=79580

Reviewed by Eric Seidel.

Refactoring only.

* rendering/RenderTableSection.h:
(CellSpan):
(WebCore::CellSpan::CellSpan):
(WebCore::CellSpan::start):
(WebCore::CellSpan::end):
Added this class to hold the span information.

(WebCore::RenderTableSection::fullTableRowSpan):
(WebCore::RenderTableSection::fullTableColumnSpan):
Those functions return the span corresponding to the full table.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::dirtiedRows):
(WebCore::RenderTableSection::dirtiedColumns):
Those functions compute the rows / columns impacted by a |damageRect|. On the slow painting path, they
return the full table span.

(WebCore::RenderTableSection::paintObject):
Updated this function to call the new ones. Also we now inflate the local rectangle with the outlineSize.
This wasn't done previously and we had to manually patch some size comparison to account for the outline.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTableSection.cpp
trunk/Source/WebCore/rendering/RenderTableSection.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (109041 => 109042)

--- trunk/Source/WebCore/ChangeLog	2012-02-28 00:48:53 UTC (rev 109041)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 01:05:10 UTC (rev 109042)
@@ -1,3 +1,33 @@
+2012-02-27  Julien Chaffraix  
+
+Extract the logic for computing the dirty rows / columns out of RenderTableSection::paintObject
+https://bugs.webkit.org/show_bug.cgi?id=79580
+
+Reviewed by Eric Seidel.
+
+Refactoring only.
+
+* rendering/RenderTableSection.h:
+(CellSpan):
+(WebCore::CellSpan::CellSpan):
+(WebCore::CellSpan::start):
+(WebCore::CellSpan::end):
+Added this class to hold the span information.
+
+(WebCore::RenderTableSection::fullTableRowSpan):
+(WebCore::RenderTableSection::fullTableColumnSpan):
+Those functions return the span corresponding to the full table.
+
+* rendering/RenderTableSection.cpp:
+(WebCore::RenderTableSection::dirtiedRows):
+(WebCore::RenderTableSection::dirtiedColumns):
+Those functions compute the rows / columns impacted by a |damageRect|. On the slow painting path, they
+return the full table span.
+
+(WebCore::RenderTableSection::paintObject):
+Updated this function to call the new ones. Also we now inflate the local rectangle with the outlineSize.
+This wasn't done previously and we had to manually patch some size comparison to account for the outline.
+
 2012-02-27  Kentaro Hara  
 
 Rename resolve-supplemental.pl to preprocess-idls.pl


Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (109041 => 109042)

--- trunk/Source/WebCore/rendering/RenderTableSection.cpp	2012-02-28 00:48:53 UTC (rev 109041)
+++ trunk/Source/WebCore/rendering/RenderTableSection.cpp	2012-02-28 01:05:10 UTC (rev 109042)
@@ -993,18 +993,64 @@
 cell->paint(paintInfo, cellPoint);
 }
 
+CellSpan RenderTableSection::dirtiedRows(const LayoutRect& damageRect) const
+{
+if (m_forceSlowPaintPathWithOverflowingCell) 
+return fullTableRowSpan();
+
+LayoutUnit before = style()->isHorizontalWritingMode() ? damageRect.y() : damageRect.x();
+
+// binary search to find a row
+unsigned startRow = std::lower_bound(m_rowPos.begin(), m_rowPos.end(), before) - m_rowPos.begin();
+
+// The binary search above gives us the first row with
+// a y position >= the top of the paint rect. Thus, the previous
+// may need to be repainted as well.
+if (startRow == m_rowPos.size() || (startRow > 0 && (m_rowPos[startRow] >  before)))
+--startRow;
+
+LayoutUnit after = (style()->isHorizontalWritingMode() ? damageRect.maxY() : damageRect.maxX());
+unsigned endRow = std::lower_bound(m_rowPos.begin(), m_rowPos.end(), after) - m_rowPos.begin();
+if (endRow == m_rowPos.size())
+--endRow;
+
+if (!endRow && m_rowPos[0] - table()->outerBorderBefore() <= after)
+++endRow;
+
+return CellSpan(startRow, endRow);
+}
+
+
+CellSpan RenderTableSection::dirtiedColumns(const LayoutRect& damageRect) const
+{
+if (m_forceSlowPaintPathWithOverflowingCell) 
+return fullTableColumnSpan();
+
+// FIXME: Implement RTL.
+if (!style()->isLeftToRightDirection())
+return fullTableColumnSpan();
+
+LayoutUnit start = style()->isHorizontalWritingMode() ? damageRect.x() : damageRect.y();
+Vector& columnPos = table()->columnPositions();
+unsigned startCol = std::lower_bound(columnPos.begin(), columnPos.end(), start) - columnPos.begin();
+if ((startCol == columnPos.size()) || (startCo

[webkit-changes] [109041] trunk

[commit-queue]

Title: [109041] trunk








Revision 109041
Author commit-qu...@webkit.org
Date 2012-02-27 16:48:53 -0800 (Mon, 27 Feb 2012)


Log Message
Add more tests for web intents
https://bugs.webkit.org/show_bug.cgi?id=79527

Patch by Greg Billock  on 2012-02-27
Reviewed by Adam Barth.

Tools:

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::sendWebIntentResponse):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
(WebViewHost::currentIntentRequest):

LayoutTests:

* webintents/resources/web-intents-testing.js: Added.
* webintents/web-intents-failure-expected.txt: Added.
* webintents/web-intents-failure.html: Added.
* webintents/web-intents-invoke-expected.txt: Added.
* webintents/web-intents-invoke.html: Added.
* webintents/web-intents-reply-expected.txt: Added.
* webintents/web-intents-reply.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webintents/web-intents-reload.html
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h


Added Paths

trunk/LayoutTests/webintents/resources/web-intents-testing.js
trunk/LayoutTests/webintents/web-intents-failure-expected.txt
trunk/LayoutTests/webintents/web-intents-failure.html
trunk/LayoutTests/webintents/web-intents-invoke-expected.txt
trunk/LayoutTests/webintents/web-intents-invoke.html
trunk/LayoutTests/webintents/web-intents-reply-expected.txt
trunk/LayoutTests/webintents/web-intents-reply.html




Diff

Modified: trunk/LayoutTests/ChangeLog (109040 => 109041)

--- trunk/LayoutTests/ChangeLog	2012-02-28 00:37:58 UTC (rev 109040)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 00:48:53 UTC (rev 109041)
@@ -1,3 +1,18 @@
+2012-02-27  Greg Billock  
+
+Add more tests for web intents
+https://bugs.webkit.org/show_bug.cgi?id=79527
+
+Reviewed by Adam Barth.
+
+* webintents/resources/web-intents-testing.js: Added.
+* webintents/web-intents-failure-expected.txt: Added.
+* webintents/web-intents-failure.html: Added.
+* webintents/web-intents-invoke-expected.txt: Added.
+* webintents/web-intents-invoke.html: Added.
+* webintents/web-intents-reply-expected.txt: Added.
+* webintents/web-intents-reply.html: Added.
+
 2012-02-27  ChangSeok Oh  
 
 [EFL] Support mutation observers


Added: trunk/LayoutTests/webintents/resources/web-intents-testing.js (0 => 109041)

--- trunk/LayoutTests/webintents/resources/web-intents-testing.js	(rev 0)
+++ trunk/LayoutTests/webintents/resources/web-intents-testing.js	2012-02-28 00:48:53 UTC (rev 109041)
@@ -0,0 +1,40 @@
+// Callback function to be used for a successful web intent call.
+function onSuccess(data) {
+  debug("* got reply: " + data);
+
+  if (window.layoutTestController) {
+window.layoutTestController.notifyDone();
+  }
+}
+
+// Callback function to be used for a failed web intent call.
+function onFailure(data) {
+  debug("* got failure: " + data);
+
+  if (window.layoutTestController) {
+window.layoutTestController.notifyDone();
+  }
+}
+
+// Launch a web intent call with callbacks.
+function startIntentWithCallbacks() {
+  navigator.startActivity(new Intent("action1", "mime/type1", "test"), onSuccess, onFailure);
+  debug("* sent intent");
+
+  if (window.layoutTestController) {
+window.layoutTestController.waitUntilDone();
+  } else {
+alert('This test needs to run in DRT');
+  }
+}
+
+// This button press simulator sets the user gesture indicator that an intent
+// requires to start.
+function simulateButtonPress() {
+  var button = document.getElementById("button");
+  if (eventSender) {
+eventSender.mouseMoveTo(button.getBoundingClientRect().left + 2, button.getBoundingClientRect().top + 12);
+eventSender.mouseDown();
+eventSender.mouseUp();
+  }
+}


Added: trunk/LayoutTests/webintents/web-intents-failure-expected.txt (0 => 109041)

--- trunk/LayoutTests/webintents/web-intents-failure-expected.txt	(rev 0)
+++ trunk/LayoutTests/webintents/web-intents-failure-expected.txt	2012-02-28 00:48:53 UTC (rev 109041)
@@ -0,0 +1,7 @@
+Received Web Intent: action="" type=mime/type1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+* sent intent
+* got failure: ERROR
+


Added: trunk/LayoutTests/webintents/web-intents-failure.html (0 => 109041)

--- trunk/LayoutTests/webintents/web-intents-failure.html	(rev 0)
+++ trunk/LayoutTests/webintents/web-intents-failure.html	2012-02-28 00:48:53 UTC (rev 109041)
@@ -0,0 +1,20 @@
+
+  
+
+  function buttonClicked() {
+startIntentWithCallbacks();
+
+if (window.layoutTestController) {
+  // Empty args will send failure message.
+  window.layoutTestController.sendWebInten

[webkit-changes] [109040] trunk/Source/JavaScriptCore

[fpizlo]

Title: [109040] trunk/Source/_javascript_Core








Revision 109040
Author fpi...@apple.com
Date 2012-02-27 16:37:58 -0800 (Mon, 27 Feb 2012)


Log Message
Old JIT's style of JSVALUE64 strict equality is subtly wrong
https://bugs.webkit.org/show_bug.cgi?id=79700

Reviewed by Oliver Hunt.

* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::comparePtr):
(MacroAssemblerX86_64):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
* jit/JITOpcodes.cpp:
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
trunk/Source/_javascript_Core/jit/JITStubs.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (109039 => 109040)

--- trunk/Source/_javascript_Core/ChangeLog	2012-02-28 00:36:14 UTC (rev 109039)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-02-28 00:37:58 UTC (rev 109040)
@@ -1,3 +1,26 @@
+2012-02-27  Filip Pizlo  
+
+Old JIT's style of JSVALUE64 strict equality is subtly wrong
+https://bugs.webkit.org/show_bug.cgi?id=79700
+
+Reviewed by Oliver Hunt.
+
+* assembler/MacroAssemblerX86_64.h:
+(JSC::MacroAssemblerX86_64::comparePtr):
+(MacroAssemblerX86_64):
+* dfg/DFGOperations.cpp:
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
+(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
+* jit/JITOpcodes.cpp:
+(JSC::JIT::compileOpStrictEq):
+(JSC::JIT::emitSlow_op_stricteq):
+(JSC::JIT::emitSlow_op_nstricteq):
+* jit/JITStubs.cpp:
+(JSC::DEFINE_STUB_FUNCTION):
+
 2012-02-27  Gavin Barraclough  
 
 Implement support for op_negate and op_bitnot in the DFG JIT


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h (109039 => 109040)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h	2012-02-28 00:36:14 UTC (rev 109039)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h	2012-02-28 00:37:58 UTC (rev 109040)
@@ -334,6 +334,13 @@
 m_assembler.movzbl_rr(dest, dest);
 }
 
+void comparePtr(RelationalCondition cond, RegisterID left, RegisterID right, RegisterID dest)
+{
+m_assembler.cmpq_rr(right, left);
+m_assembler.setCC_r(x86Condition(cond), dest);
+m_assembler.movzbl_rr(dest, dest);
+}
+
 Jump branchAdd32(ResultCondition cond, TrustedImm32 src, AbsoluteAddress dest)
 {
 move(TrustedImmPtr(dest.m_ptr), scratchRegister);


Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (109039 => 109040)

--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2012-02-28 00:36:14 UTC (rev 109039)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2012-02-28 00:37:58 UTC (rev 109040)
@@ -736,8 +736,14 @@
 {
 JSGlobalData* globalData = &exec->globalData();
 NativeCallFrameTracer tracer(globalData, exec);
+
+JSValue src1 = JSValue::decode(encodedOp1);
+JSValue src2 = JSValue::decode(encodedOp2);
 
-return JSValue::strictEqual(exec, JSValue::decode(encodedOp1), JSValue::decode(encodedOp2));
+ASSERT((src1.isCell() && src2.isCell())
+   || src1.isDouble() || src2.isDouble());
+
+return JSValue::strictEqual(exec, src1, src2);
 }
 
 static void* handleHostCall(ExecState* execCallee, JSValue callee, CodeSpecializationKind kind)


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (109039 => 109040)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2012-02-28 00:36:14 UTC (rev 109039)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2012-02-28 00:37:58 UTC (rev 109040)
@@ -383,9 +383,6 @@
 
 bool SpeculativeJIT::nonSpeculativeStrictEq(Node& node, bool invert)
 {
-if (!invert && (isKnownNumeric(node.child1().index()) || isKnownNumeric(node.child2().index(
-return nonSpeculativeCompare(node, MacroAssembler::Equal, operationCompareStrictEq);
-
 NodeIndex branchNodeIndex = detectPeepHoleBranch();
 if (branchNodeIndex != NoNode) {
 ASSERT(node.adjustedRefCount() == 1);


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (109039 => 109040)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp	2012-02-28 00:36:14 UTC (rev 109039)
+++ 

[webkit-changes] [109039] trunk

[commit-queue]

Title: [109039] trunk








Revision 109039
Author commit-qu...@webkit.org
Date 2012-02-27 16:36:14 -0800 (Mon, 27 Feb 2012)


Log Message
[EFL] Support mutation observers
https://bugs.webkit.org/show_bug.cgi?id=79603

Patch by ChangSeok Oh  on 2012-02-27
Reviewed by Eric Seidel.

.:

Added a build-option for the mutation observers feature.

* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:

LayoutTests:

Rebased skipped tests regarding the mutation observers feature.

* platform/efl/Skipped:

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Source/cmake/OptionsEfl.cmake
trunk/Source/cmakeconfig.h.cmake




Diff

Modified: trunk/ChangeLog (109038 => 109039)

--- trunk/ChangeLog	2012-02-28 00:31:28 UTC (rev 109038)
+++ trunk/ChangeLog	2012-02-28 00:36:14 UTC (rev 109039)
@@ -1,3 +1,15 @@
+2012-02-27  ChangSeok Oh  
+
+[EFL] Support mutation observers
+https://bugs.webkit.org/show_bug.cgi?id=79603
+
+Reviewed by Eric Seidel.
+
+Added a build-option for the mutation observers feature.
+
+* Source/cmake/OptionsEfl.cmake:
+* Source/cmakeconfig.h.cmake:
+
 2012-02-26  Shinya Kawanaka  
 
 Rename ShadowRootList to ShadowTree.


Modified: trunk/LayoutTests/ChangeLog (109038 => 109039)

--- trunk/LayoutTests/ChangeLog	2012-02-28 00:31:28 UTC (rev 109038)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 00:36:14 UTC (rev 109039)
@@ -1,3 +1,14 @@
+2012-02-27  ChangSeok Oh  
+
+[EFL] Support mutation observers
+https://bugs.webkit.org/show_bug.cgi?id=79603
+
+Reviewed by Eric Seidel.
+
+Rebased skipped tests regarding the mutation observers feature.
+
+* platform/efl/Skipped:
+
 2012-02-27  Kentaro Hara  
 
 [JSC] Add [ConstructorParameters=] to all custom constructors


Modified: trunk/LayoutTests/platform/efl/Skipped (109038 => 109039)

--- trunk/LayoutTests/platform/efl/Skipped	2012-02-28 00:31:28 UTC (rev 109038)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-02-28 00:36:14 UTC (rev 109039)
@@ -1065,7 +1065,7 @@
 fast/filesystem
 http/tests/filesystem
 http/tests/security/filesystem-iframe-from-remote.html
-fast/mutation/end-of-task-delivery.html
+fast/mutation/filesystem-callback-delivery.html
 
 # The EFL port has no support for Geolocation
 fast/dom/Geolocation
@@ -1248,7 +1248,12 @@
 # Fails because MutationObservers are not notified at end-of-task
 # https://bugs.webkit.org/show_bug.cgi?id=78290
 fast/mutation/end-of-task-delivery.html
+fast/mutation/inline-event-listener.html
 
+# Fails because of the security policy of the user agent?
+# http://webkit.org/b/79604
+fast/mutation/database-callback-delivery.html
+
 # 
 # Tests which are expected to fail
 # 
@@ -2212,17 +2217,6 @@
 fast/mediastream/peerconnection-argument-types.html
 fast/mediastream/peerconnection-eventlistener-optional-argument.html
 fast/mediastream/peerconnection-removestream.html
-fast/mutation/callback-second-argument.html
-fast/mutation/cross-document.html
-fast/mutation/database-callback-delivery.html
-fast/mutation/filesystem-callback-delivery.html
-fast/mutation/inline-event-listener.html
-fast/mutation/mutation-observer-constructor.html
-fast/mutation/observe-attributes.html
-fast/mutation/observe-characterdata.html
-fast/mutation/observe-childList.html
-fast/mutation/observe-exceptions.html
-fast/mutation/observe-subtree.html
 fast/multicol
 fast/overflow/overflow-float-stacking.html
 fast/overflow/overflow-stacking.html


Modified: trunk/Source/cmake/OptionsEfl.cmake (109038 => 109039)

--- trunk/Source/cmake/OptionsEfl.cmake	2012-02-28 00:31:28 UTC (rev 109038)
+++ trunk/Source/cmake/OptionsEfl.cmake	2012-02-28 00:36:14 UTC (rev 109039)
@@ -82,6 +82,7 @@
 WEBKIT_FEATURE(ENABLE_MATHML "Enable MathML" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_METER_TAG "Enable Meter tag" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_MICRODATA "Enable HTML5 microdata support" DEFAULT OFF)
+WEBKIT_FEATURE(ENABLE_MUTATION_OBSERVERS "Enable HTML5 mutation observers support" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_NETSCAPE_PLUGIN_API "Enable Netscape plugin API" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_NOTIFICATIONS "Enable notifications" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_ORIENTATION_EVENTS "Enable orientation events" DEFAULT OFF)


Modified: trunk/Source/cmakeconfig.h.cmake (109038 => 109039)

--- trunk/Source/cmakeconfig.h.cmake	2012-02-28 00:31:28 UTC (rev 109038)
+++ trunk/Source/cmakeconfig.h.cmake	2012-02-28 00:36:14 UTC (rev 109039)
@@ -27,6 +27,7 @@
 #cmakedefine01 ENABLE_MATHML
 #cmakedefine01 ENABLE_METER_TAG
 #cmakedefine01 ENABLE_MICRODATA
+#cmakedefine01 ENABLE_MUTATION_OBSERVERS
 #cmakedefine01 ENABLE_NETSCAPE_PLUGIN_API
 #cmakedefine01 ENABLE_NOTIFICATIONS
 #cmakedefine01 ENABLE_ORIENTATION_EVENTS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/ma

[webkit-changes] [109038] trunk/Source/JavaScriptCore

[barraclough]

Title: [109038] trunk/Source/_javascript_Core








Revision 109038
Author barraclo...@apple.com
Date 2012-02-27 16:31:28 -0800 (Mon, 27 Feb 2012)


Log Message
Implement support for op_negate and op_bitnot in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=79617

Reviewed by Filip Pizlo.

Add an ArithNegate op to the DFG JIT, to implement op_negate.

This patch also adds support for op_negate to the JSVALUE64 baseline JIT
(JSVALUE32_64 already had this), so that we can profile the slowpath usage.

This is a 2.5%-3% Sunspider progression and a 1% win on Kraken.

* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::sub_S):
- Added sub_S from immediate.
(ARMv7Assembler):
(JSC::ARMv7Assembler::vneg):
- Added double negate.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::negateDouble):
- Added double negate.
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::branchNeg32):
- Added.
* assembler/MacroAssemblerX86.h:
(MacroAssemblerX86):
- moved loadDouble, absDouble to common.
* assembler/MacroAssemblerX86Common.h:
(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::absDouble):
- implementation can be shared.
(JSC::MacroAssemblerX86Common::negateDouble):
- Added.
(JSC::MacroAssemblerX86Common::loadDouble):
- allow absDouble to have a common implementation.
* assembler/MacroAssemblerX86_64.h:
(MacroAssemblerX86_64):
- moved loadDouble, absDouble to common.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- support ArithNegate.
* dfg/DFGArithNodeFlagsInferencePhase.cpp:
(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):
- support ArithNegate.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
- support ArithNegate.
(JSC::DFG::ByteCodeParser::parseBlock):
- support op_negate.
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- support ArithNegate.
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- support op_negate.
* dfg/DFGGraph.h:
(JSC::DFG::Graph::negateShouldSpeculateInteger):
- support ArithNegate.
* dfg/DFGNode.h:
(JSC::DFG::Node::hasArithNodeFlags):
- support ArithNegate.
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- support ArithNegate.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithNegate):
- support ArithNegate.
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- support ArithNegate.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- support ArithNegate.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- support ArithNegate.
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- Add support for op_negate in JSVALUE64.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
- Add support for op_negate in JSVALUE64.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGArithNodeFlagsInferencePhase.cpp
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGCapabilities.h
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITArithmetic.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (109037 => 109038)

--- trunk/Source/_javascript_Core/ChangeLog	2012-02-28 00:17:18 UTC (rev 109037)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-02-28 00:31:28 UTC (rev 109038)
@@ -1,3 +1,90 @@
+2012-02-27  Gavin Barraclough  
+
+Implement support for op_negate and op_bitnot in the DFG JIT
+https://bugs.webkit.org/show_bug.cgi?id=79617
+
+Reviewed by Filip Pizlo.
+
+Add an ArithNegate op to the DFG JIT, to implement op_negate.
+
+This patch also adds support for op_negate to the JSVALUE64 baseline JIT
+(JSVALUE32_64 already had this), so that we can profile the slowpath usage.
+
+This is a 2.5%-3% Sunspider progression and a 1% win on Kraken.
+
+* assembler/ARMv7Assembler.h:
+(JSC::ARMv7Assembler::sub_S):
+- Added sub_S from immediate.
+(ARMv7Assembler):
+

[webkit-changes] [109037] trunk/Source/WebCore/ChangeLog

[morrita]

Title: [109037] trunk/Source/WebCore/ChangeLog








Revision 109037
Author morr...@google.com
Date 2012-02-27 16:17:18 -0800 (Mon, 27 Feb 2012)


Log Message
Unreviewed, fixed wrong bug URL on the ChangeLog.

Modified Paths

trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/ChangeLog (109036 => 109037)

--- trunk/Source/WebCore/ChangeLog	2012-02-28 00:07:01 UTC (rev 109036)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 00:17:18 UTC (rev 109037)
@@ -728,7 +728,7 @@
 2012-02-27  MORITA Hajime  
 
 Removing ,  inside shadow DOM triggers assertion in updateListMarkerNumbers
-https://bugs.webkit.org/show_bug.cgi?id=79630
+https://bugs.webkit.org/show_bug.cgi?id=72440
 
 Reviewed by Ryosuke Niwa.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109036] trunk/Source/WebCore

[haraken]

Title: [109036] trunk/Source/WebCore








Revision 109036
Author hara...@chromium.org
Date 2012-02-27 16:07:01 -0800 (Mon, 27 Feb 2012)


Log Message
Rename resolve-supplemental.pl to preprocess-idls.pl
https://bugs.webkit.org/show_bug.cgi?id=79660

Reviewed by Adam Barth.

Due to r108322, resolve-supplemental.pl not only resolves supplemental
dependencies but also runs IDL attribute checker. For clarification,
this patch renames resolve-supplemental.pl to preprocess-idls.pl.

No tests. Confirm that all builds pass.

* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* UseJSC.cmake:
* UseV8.cmake:
* WebCore.gyp/WebCore.gyp:
* WebCore.vcproj/MigrateScripts:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/preprocess-idls.pl: Renamed from Source/WebCore/bindings/scripts/resolve-supplemental.pl.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/DerivedSources.pri
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/UseJSC.cmake
trunk/Source/WebCore/UseV8.cmake
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.vcproj/MigrateScripts
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl


Removed Paths

trunk/Source/WebCore/bindings/scripts/resolve-supplemental.pl




Diff

Modified: trunk/Source/WebCore/ChangeLog (109035 => 109036)

--- trunk/Source/WebCore/ChangeLog	2012-02-27 23:59:55 UTC (rev 109035)
+++ trunk/Source/WebCore/ChangeLog	2012-02-28 00:07:01 UTC (rev 109036)
@@ -1,5 +1,29 @@
 2012-02-27  Kentaro Hara  
 
+Rename resolve-supplemental.pl to preprocess-idls.pl
+https://bugs.webkit.org/show_bug.cgi?id=79660
+
+Reviewed by Adam Barth.
+
+Due to r108322, resolve-supplemental.pl not only resolves supplemental
+dependencies but also runs IDL attribute checker. For clarification,
+this patch renames resolve-supplemental.pl to preprocess-idls.pl.
+
+No tests. Confirm that all builds pass.
+
+* DerivedSources.make:
+* DerivedSources.pri:
+* GNUmakefile.am:
+* UseJSC.cmake:
+* UseV8.cmake:
+* WebCore.gyp/WebCore.gyp:
+* WebCore.vcproj/MigrateScripts:
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.xcodeproj/project.pbxproj:
+* bindings/scripts/preprocess-idls.pl: Renamed from Source/WebCore/bindings/scripts/resolve-supplemental.pl.
+
+2012-02-27  Kentaro Hara  
+
 [JSC] Add [ConstructorParameters=] to all custom constructors
 https://bugs.webkit.org/show_bug.cgi?id=78221
 


Modified: trunk/Source/WebCore/DerivedSources.make (109035 => 109036)

--- trunk/Source/WebCore/DerivedSources.make	2012-02-27 23:59:55 UTC (rev 109035)
+++ trunk/Source/WebCore/DerivedSources.make	2012-02-28 00:07:01 UTC (rev 109036)
@@ -893,13 +893,13 @@
 bindings/scripts/generate-bindings.pl \
 bindings/scripts/preprocessor.pm
 
-RESOLVE_SUPPLEMENTAL_SCRIPTS = \
+PREPROCESS_IDLS_SCRIPTS = \
 bindings/scripts/IDLParser.pm \
-bindings/scripts/resolve-supplemental.pl
+bindings/scripts/preprocess-idls.pl
 
 generator_script = perl $(addprefix -I $(WebCore)/, $(sort $(dir $(1 $(WebCore)/bindings/scripts/generate-bindings.pl
 
-resolve_supplemental_script = perl $(addprefix -I $(WebCore)/, $(sort $(dir $(1 $(WebCore)/bindings/scripts/resolve-supplemental.pl
+preprocess_idls_script = perl $(addprefix -I $(WebCore)/, $(sort $(dir $(1 $(WebCore)/bindings/scripts/preprocess-idls.pl
 
 # JS bindings generator
 
@@ -927,9 +927,9 @@
 space :=
 space +=
 
-$(SUPPLEMENTAL_DEPENDENCY_FILE) : $(RESOLVE_SUPPLEMENTAL_SCRIPTS) $(BINDING_IDLS) $(ADDITIONAL_IDLS) $(IDL_ATTRIBUTES_FILE)
+$(SUPPLEMENTAL_DEPENDENCY_FILE) : $(PREPROCESS_IDLS_SCRIPTS) $(BINDING_IDLS) $(ADDITIONAL_IDLS) $(IDL_ATTRIBUTES_FILE)
 	printf "$(subst $(space),,$(patsubst %,%\n,$(BINDING_IDLS) $(ADDITIONAL_IDLS)))" > $(IDL_FILES_TMP)
-	$(call resolve_supplemental_script, $(RESOLVE_SUPPLEMENTAL_SCRIPTS)) --defines "$(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT" --idlFilesList $(IDL_FILES_TMP) --supplementalDependencyFile $@ --idlAttributesFile $(IDL_ATTRIBUTES_FILE)
+	$(call preprocess_idls_script, $(PREPROCESS_IDLS_SCRIPTS)) --defines "$(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT" --idlFilesList $(IDL_FILES_TMP) --supplementalDependencyFile $@ --idlAttributesFile $(IDL_ATTRIBUTES_FILE)
 	rm -f $(IDL_FILES_TMP)
 
 JS%.h : %.idl $(JS_BINDINGS_SCRIPTS) $(SUPPLEMENTAL_DEPENDENCY_FILE)


Modified: trunk/Source/WebCore/DerivedSources.pri (109035 => 109036)

--- trunk/Source/WebCore/DerivedSources.pri	2012-02-27 23:59:55 UTC (rev 109035)
+++ trunk/Source/WebCore/DerivedSources.pri	2012-02-28 00:07:01 UTC (rev 109036)
@@ -665,23 +665,23 @@
 # GENERATOR 0: Resolve [Supplemental] dependency in IDLs
 SUPPLEMENTAL_DEPEN

[webkit-changes] [109035] trunk

[haraken]

Title: [109035] trunk








Revision 109035
Author hara...@chromium.org
Date 2012-02-27 15:59:55 -0800 (Mon, 27 Feb 2012)


Log Message
[JSC] Add [ConstructorParameters=] to all custom constructors
https://bugs.webkit.org/show_bug.cgi?id=78221

Reviewed by Adam Barth.

Source/WebCore:

This patch adds [ConstructorParameters=X] to IDL files that have
custom constructors, where X is the maximum number of arguments
of the constructor. [ConstructorParameters=X] is needed for custom
constructors, because custom constructors do not have a signature
in IDL files and thus CodeGeneratorJS.pm cannot know the number of
constructor arguments.

Test: fast/js/constructor-length.html

* dom/WebKitMutationObserver.idl:
* html/DOMFormData.idl:
* html/canvas/ArrayBuffer.idl:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* webaudio/AudioContext.idl:

* bindings/scripts/test/TestTypedArray.idl:

* bindings/scripts/test/JS/JSFloat64Array.cpp: Updated run-bindings-tests results.
(WebCore::JSFloat64ArrayConstructor::finishCreation):

LayoutTests:

The added tests check the length property of the custom constructors.

* fast/js/constructor-length.html:
* platform/mac/fast/js/constructor-length-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/constructor-length.html
trunk/LayoutTests/platform/mac/fast/js/constructor-length-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp
trunk/Source/WebCore/bindings/scripts/test/TestTypedArray.idl
trunk/Source/WebCore/dom/WebKitMutationObserver.idl
trunk/Source/WebCore/html/DOMFormData.idl
trunk/Source/WebCore/html/canvas/ArrayBuffer.idl
trunk/Source/WebCore/html/canvas/DataView.idl
trunk/Source/WebCore/html/canvas/Float32Array.idl
trunk/Source/WebCore/html/canvas/Float64Array.idl
trunk/Source/WebCore/html/canvas/Int16Array.idl
trunk/Source/WebCore/html/canvas/Int32Array.idl
trunk/Source/WebCore/html/canvas/Int8Array.idl
trunk/Source/WebCore/html/canvas/Uint16Array.idl
trunk/Source/WebCore/html/canvas/Uint32Array.idl
trunk/Source/WebCore/html/canvas/Uint8Array.idl
trunk/Source/WebCore/html/canvas/Uint8ClampedArray.idl
trunk/Source/WebCore/webaudio/AudioContext.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (109034 => 109035)

--- trunk/LayoutTests/ChangeLog	2012-02-27 23:56:09 UTC (rev 109034)
+++ trunk/LayoutTests/ChangeLog	2012-02-27 23:59:55 UTC (rev 109035)
@@ -1,3 +1,15 @@
+2012-02-27  Kentaro Hara  
+
+[JSC] Add [ConstructorParameters=] to all custom constructors
+https://bugs.webkit.org/show_bug.cgi?id=78221
+
+Reviewed by Adam Barth.
+
+The added tests check the length property of the custom constructors.
+
+* fast/js/constructor-length.html:
+* platform/mac/fast/js/constructor-length-expected.txt:
+
 2012-02-27  Adrienne Walker  
 
 [chromium] Unreviewed gardening, mark many svg tests as flaky crashers


Modified: trunk/LayoutTests/fast/js/constructor-length.html (109034 => 109035)

--- trunk/LayoutTests/fast/js/constructor-length.html	2012-02-27 23:56:09 UTC (rev 109034)
+++ trunk/LayoutTests/fast/js/constructor-length.html	2012-02-27 23:59:55 UTC (rev 109035)
@@ -7,17 +7,26 @@
 

[webkit-changes] [109034] trunk/Source/JavaScriptCore

[mahesh . kulkarni]

Title: [109034] trunk/Source/_javascript_Core








Revision 109034
Author mahesh.kulka...@nokia.com
Date 2012-02-27 15:56:09 -0800 (Mon, 27 Feb 2012)


Log Message
2012-02-27  Mahesh Kulkarni  

Unreviewed. Build fix for linux-bot (qt) after r109021.

* runtime/Error.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Error.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (109033 => 109034)

--- trunk/Source/_javascript_Core/ChangeLog	2012-02-27 23:48:52 UTC (rev 109033)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-02-27 23:56:09 UTC (rev 109034)
@@ -1,3 +1,9 @@
+2012-02-27  Mahesh Kulkarni  
+
+Unreviewed. Build fix for linux-bot (qt) after r109021.
+
+* runtime/Error.cpp:
+
 2012-02-27  Oliver Hunt  
 
 REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize


Modified: trunk/Source/_javascript_Core/runtime/Error.cpp (109033 => 109034)

--- trunk/Source/_javascript_Core/runtime/Error.cpp	2012-02-27 23:48:52 UTC (rev 109033)
+++ trunk/Source/_javascript_Core/runtime/Error.cpp	2012-02-27 23:56:09 UTC (rev 109034)
@@ -35,8 +35,9 @@
 #include "JSString.h"
 #include "NativeErrorConstructor.h"
 #include "SourceCode.h"
-#include "StringBuilder.h"
 
+#include 
+
 namespace JSC {
 
 static const char* linePropertyName = "line";






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109033] branches/chromium/1025/Source

[jamesr]

Title: [109033] branches/chromium/1025/Source








Revision 109033
Author jam...@google.com
Date 2012-02-27 15:48:52 -0800 (Mon, 27 Feb 2012)


Log Message
Disable occlusion tracking and draw culling for Chromium m18

https://bugs.webkit.org/show_bug.cgi?id=79429
BUG=115957

Modified Paths

branches/chromium/1025/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp
branches/chromium/1025/Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp
branches/chromium/1025/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
branches/chromium/1025/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
branches/chromium/1025/Source/WebKit/chromium/tests/LayerTextureUpdaterTest.cpp




Diff

Modified: branches/chromium/1025/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp (109032 => 109033)

--- branches/chromium/1025/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp	2012-02-27 23:40:52 UTC (rev 109032)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp	2012-02-27 23:48:52 UTC (rev 109033)
@@ -91,7 +91,6 @@
 PlatformCanvas::Painter::TextOption textOption =
 borderTexels ? PlatformCanvas::Painter::GrayscaleText : PlatformCanvas::Painter::SubpixelText;
 PlatformCanvas::Painter canvasPainter(&m_canvas, textOption);
-canvasPainter.skiaContext()->setTrackOpaqueRegion(!layerIsOpaque);
 paintContents(*canvasPainter.context(), contentRect, contentsScale);
 
 if (!layerIsOpaque)


Modified: branches/chromium/1025/Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp (109032 => 109033)

--- branches/chromium/1025/Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp	2012-02-27 23:40:52 UTC (rev 109032)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp	2012-02-27 23:48:52 UTC (rev 109033)
@@ -54,7 +54,6 @@
 SkCanvas* canvas = m_picture.beginRecording(contentRect.width(), contentRect.height());
 PlatformContextSkia platformContext(canvas);
 platformContext.setDeferred(true);
-platformContext.setTrackOpaqueRegion(!m_layerIsOpaque);
 GraphicsContext graphicsContext(&platformContext);
 paintContents(graphicsContext, contentRect, contentsScale);
 m_picture.endRecording();


Modified: branches/chromium/1025/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp (109032 => 109033)

--- branches/chromium/1025/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp	2012-02-27 23:40:52 UTC (rev 109032)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp	2012-02-27 23:48:52 UTC (rev 109033)
@@ -264,8 +264,6 @@
 CCRenderPassList passes;
 calculateRenderPasses(passes);
 
-optimizeRenderPasses(passes);
-
 m_layerRenderer->beginDrawingFrame();
 for (size_t i = 0; i < passes.size(); ++i)
 m_layerRenderer->drawRenderPass(passes[i].get());


Modified: branches/chromium/1025/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (109032 => 109033)

--- branches/chromium/1025/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp	2012-02-27 23:40:52 UTC (rev 109032)
+++ branches/chromium/1025/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp	2012-02-27 23:48:52 UTC (rev 109033)
@@ -522,6 +522,16 @@
 runTest(true);\
 }
 
+#define DISABLED_SINGLE_AND_MULTI_THREAD_TEST_F(TEST_FIXTURE_NAME) \
+TEST_F(TEST_FIXTURE_NAME, DISABLED_runSingleThread)\
+{  \
+runTest(false);\
+}  \
+TEST_F(TEST_FIXTURE_NAME, DISABLED_runMultiThread) \
+{  \
+runTest(true); \
+}
+
 SINGLE_AND_MULTI_THREAD_TEST_F(CCLayerTreeHostTestShortlived1)
 
 // Shortlived layerTreeHosts shouldn't die with a commit in flight.


Modified: branches/chromium/1025/Source/WebKit/chromium/tests/LayerTextureUpdaterTest.cpp (109032 => 109033)

--- branches/chromium/1025/Source/WebKit/chromium/tests/LayerTextureUpdaterTest.cpp	2012-02-27 23:40:52 UTC (rev 109032)
+++ branches/chromium/1025/Source/WebKit/chromium/tests/LayerTextureUpdaterTest.cpp	2012-02-27 23:48:52 UTC (rev 109033)
@@ -85,7 +85,7 @@
 EXPECT_EQ(a.y(), b.y()); \
 EXPECT_EQ(a.maxY(), b.maxY());
 
-TEST(LayerTextureUpdaterTest, testOpaqueRectPresentAfterOpaquePaint)
+TEST(LayerTextureUpdaterTest, DISABLED_testOpaqueRectPresentAfterOpaquePaint)
 {
 PaintFillOpaque fillOpaque;
 RefPtr updater;
@@ -111,7 +111,7 @@
 EXPECT_EQ_RECT(IntRect(0, 0, 400, 400), opaqueRect);
 }
 
-TEST(LayerTextureUpdaterTest, testOp

[webkit-changes] [109032] trunk/LayoutTests

[enne]

Title: [109032] trunk/LayoutTests








Revision 109032
Author e...@google.com
Date 2012-02-27 15:40:52 -0800 (Mon, 27 Feb 2012)


Log Message
[chromium] Unreviewed gardening, mark many svg tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=79707

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (109031 => 109032)

--- trunk/LayoutTests/ChangeLog	2012-02-27 23:40:12 UTC (rev 109031)
+++ trunk/LayoutTests/ChangeLog	2012-02-27 23:40:52 UTC (rev 109032)
@@ -1,5 +1,12 @@
 2012-02-27  Adrienne Walker  
 
+[chromium] Unreviewed gardening, mark many svg tests as flaky crashers
+https://bugs.webkit.org/show_bug.cgi?id=79707
+
+* platform/chromium/test_expectations.txt:
+
+2012-02-27  Adrienne Walker  
+
 [chromium] Unreviewed gardening, mark two fast/regex tests as failing
 
 * platform/chromium/test_expectations.txt:


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109031 => 109032)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-27 23:40:12 UTC (rev 109031)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-27 23:40:52 UTC (rev 109032)
@@ -2944,7 +2944,8 @@
 // Appears to be a configuration error in the Mac 10.6 deps
 // Has been going on for at least a few weeks (as of 20/5/2011)
 BUGCR83426 MAC : svg/as-border-image/svg-as-border-image-2.html = PASS IMAGE
-BUGCR83426 MAC : svg/as-border-image/svg-as-border-image.html = PASS IMAGE
+// Commented out because bug 79707 also specifies CRASH
+// BUGCR83426 MAC : svg/as-border-image/svg-as-border-image.html = PASS IMAGE
 BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-specular-01-f.svg = PASS IMAGE
 BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-turb-01-f.svg = PASS IMAGE
 BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-turb-02-f.svg = PASS IMAGE
@@ -3450,7 +3451,8 @@
 BUGWK77110 WIN DEBUG : accessibility/loading-iframe-sends-notification.html = PASS TEXT
 
 BUGWK73494 : svg/text/non-bmp-positioning-lists.svg = IMAGE+TEXT IMAGE
-BUGWK73494 : svg/as-image/svg-non-integer-scaled-image.html = IMAGE PASS
+// This happens on all platforms, but bug79707 specifies CRASH for MAC as well
+BUGWK73494 WIN LINUX : svg/as-image/svg-non-integer-scaled-image.html = IMAGE PASS
 
 BUGWK73872 LINUX : svg/custom/linking-uri-01-b.svg = PASS TIMEOUT
 
@@ -4214,7 +4216,9 @@
 BUGWK79454 : svg/text/text-viewbox-rescale.html = IMAGE
 
 // Flaky for DEBUG since r108585
-BUGWK79455 DEBUG : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS IMAGE+TEXT
+// This happens on all platforms, but bug79707 specifies CRASH for MAC as well
+// BUGWK79455 DEBUG : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS IMAGE+TEXT
+BUGWK79455 DEBUG WIN LINUX : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS IMAGE+TEXT
 
 // Flaky for DEBUG
 BUGWK79456 DEBUG : svg/repaint/image-with-clip-path.svg = PASS IMAGE
@@ -4234,3 +4238,17 @@
 
 BUGWK79702 : fast/regex/lastIndex.html = TEXT
 BUGWK79703 : fast/regex/overflow.html = TEXT
+
+// All MAC flaky crashers. Additional expectations come from preexisting bugs.
+BUGWK79707 MAC : svg/as-background-image/background-image-preserveaspectRatio-support.html = PASS CRASH
+BUGWK79707 MAC : svg/as-background-image/same-image-two-instances-background-image.html = PASS CRASH
+BUGWK79707 MAC : svg/as-border-image/svg-as-border-image.html = PASS CRASH IMAGE
+BUGWK79707 MAC : svg/as-image/drag-svg-as-image.html = PASS CRASH
+BUGWK79707 MAC : svg/as-image/svg-as-relative-image-with-explicit-size.html = PASS CRASH
+BUGWK79707 MAC : svg/as-image/svg-non-integer-scaled-image.html = PASS CRASH IMAGE
+BUGWK79707 MAC : svg/clip-path/clip-path-nonzero-evenodd.svg = PASS CRASH
+BUGWK79707 MAC : svg/custom/feDisplacementMap-01.svg = PASS CRASH
+BUGWK79707 MAC : svg/custom/font-face-name-without-name-attr.svg = PASS CRASH
+BUGWK79707 MAC RELEASE : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS CRASH
+BUGWK79707 MAC DEBUG : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS CRASH IMAGE+TEXT
+BUGWK79707 MAC : svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html = PASS CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109031] trunk/Source/WebCore

[kubo]

Title: [109031] trunk/Source/WebCore








Revision 109031
Author k...@profusion.mobi
Date 2012-02-27 15:40:12 -0800 (Mon, 27 Feb 2012)


Log Message
[BlackBerry][EFL] Provide dummy RunLoop implementations.
https://bugs.webkit.org/show_bug.cgi?id=79398

Reviewed by Antonio Gomes.

r108067 fixed the EFL build by not building RunLoop.cpp on EFL and
BlackBerry, as both platforms lack an implementation that provides the
missing methods for the RunLoop class.

However, RunLoop.cpp is a generic file which should not be included
directly in PlatformWinCE.cmake (plus it helps in converting the
AppleWin port to CMake).

Fix this by providing a dummy implementation of the missing RunLoop
methods for both EFL and BlackBerry.

* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* PlatformWinCE.cmake:
* platform/blackberry/RunLoopBlackBerry.cpp: Added.
(WebCore):
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::wakeUp):
* platform/efl/RunLoopEfl.cpp: Added.
(WebCore):
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::wakeUp):

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformBlackBerry.cmake
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebCore/PlatformWinCE.cmake


Added Paths

trunk/Source/WebCore/platform/blackberry/RunLoopBlackBerry.cpp
trunk/Source/WebCore/platform/efl/RunLoopEfl.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (109030 => 109031)

--- trunk/Source/WebCore/CMakeLists.txt	2012-02-27 23:32:01 UTC (rev 109030)
+++ trunk/Source/WebCore/CMakeLists.txt	2012-02-27 23:40:12 UTC (rev 109031)
@@ -1094,6 +1094,7 @@
 platform/MIMETypeRegistry.cpp
 platform/MemoryPressureHandler.cpp
 platform/PlatformEvent.cpp
+platform/RunLoop.cpp
 platform/RuntimeApplicationChecks.cpp
 platform/ScrollAnimator.cpp
 platform/ScrollableArea.cpp


Modified: trunk/Source/WebCore/ChangeLog (109030 => 109031)

--- trunk/Source/WebCore/ChangeLog	2012-02-27 23:32:01 UTC (rev 109030)
+++ trunk/Source/WebCore/ChangeLog	2012-02-27 23:40:12 UTC (rev 109031)
@@ -1,3 +1,36 @@
+2012-02-23  Raphael Kubo da Costa  
+
+[BlackBerry][EFL] Provide dummy RunLoop implementations.
+https://bugs.webkit.org/show_bug.cgi?id=79398
+
+Reviewed by Antonio Gomes.
+
+r108067 fixed the EFL build by not building RunLoop.cpp on EFL and
+BlackBerry, as both platforms lack an implementation that provides the
+missing methods for the RunLoop class.
+
+However, RunLoop.cpp is a generic file which should not be included
+directly in PlatformWinCE.cmake (plus it helps in converting the
+AppleWin port to CMake).
+
+Fix this by providing a dummy implementation of the missing RunLoop
+methods for both EFL and BlackBerry.
+
+* CMakeLists.txt:
+* PlatformBlackBerry.cmake:
+* PlatformEfl.cmake:
+* PlatformWinCE.cmake:
+* platform/blackberry/RunLoopBlackBerry.cpp: Added.
+(WebCore):
+(WebCore::RunLoop::RunLoop):
+(WebCore::RunLoop::~RunLoop):
+(WebCore::RunLoop::wakeUp):
+* platform/efl/RunLoopEfl.cpp: Added.
+(WebCore):
+(WebCore::RunLoop::RunLoop):
+(WebCore::RunLoop::~RunLoop):
+(WebCore::RunLoop::wakeUp):
+
 2012-02-27  John Sullivan  
 
 Build fix (on Lion at least).


Modified: trunk/Source/WebCore/PlatformBlackBerry.cmake (109030 => 109031)

--- trunk/Source/WebCore/PlatformBlackBerry.cmake	2012-02-27 23:32:01 UTC (rev 109030)
+++ trunk/Source/WebCore/PlatformBlackBerry.cmake	2012-02-27 23:40:12 UTC (rev 109031)
@@ -153,6 +153,7 @@
 platform/blackberry/PlatformTouchPointBlackBerry.cpp
 platform/blackberry/PopupMenuBlackBerry.cpp
 platform/blackberry/RenderThemeBlackBerry.cpp
+platform/blackberry/RunLoopBlackBerry.cpp
 platform/blackberry/SSLKeyGeneratorBlackBerry.cpp
 platform/blackberry/ScrollbarThemeBlackBerry.cpp
 platform/blackberry/SearchPopupMenuBlackBerry.cpp


Modified: trunk/Source/WebCore/PlatformEfl.cmake (109030 => 109031)

--- trunk/Source/WebCore/PlatformEfl.cmake	2012-02-27 23:32:01 UTC (rev 109030)
+++ trunk/Source/WebCore/PlatformEfl.cmake	2012-02-27 23:40:12 UTC (rev 109031)
@@ -47,6 +47,7 @@
   platform/efl/PopupMenuEfl.cpp
   platform/efl/RefPtrEfl.cpp
   platform/efl/RenderThemeEfl.cpp
+  platform/efl/RunLoopEfl.cpp
   platform/efl/ScrollViewEfl.cpp
   platform/efl/ScrollbarEfl.cpp
   platform/efl/ScrollbarThemeEfl.cpp


Modified: trunk/Source/WebCore/PlatformWinCE.cmake (109030 => 109031)

--- trunk/Source/WebCore/PlatformWinCE.cmake	2012-02-27 23:32:01 UTC (rev 109030)
+++ trunk/Source/WebCore/PlatformWinCE.cmake	2012-02-27 23:40:12 UTC (rev 109031)
@@ -32,7 +32,6 @@
 platform/Cursor.cpp
 platform/LocalizedStrings.cpp
 platform/PlatformStrategies.cpp
-platform/RunLoop.cpp
 platform/ScrollAnimatorWin.cpp
 
 plat

Re: [webkit-changes] [109026] trunk/Source/WebCore

[Adam Klein]

Thanks to sullivan for the fix. Sorry for the breakage.

On Mon, Feb 27, 2012 at 3:20 PM, Mark Rowe  wrote:

> This broke release builds:
>
> On 2012-02-27, at 14:53, ad...@chromium.org wrote:
>
>  Modified: trunk/Source/WebCore/dom/Attr.cpp (109025 => 109026)
>
> --- trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 22:19:27 UTC (rev 109025)
> +++ trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 22:53:25 UTC (rev 109026)@@ 
> -172,8 +172,6 @@ if (m_ignoreChildrenChanged > 0) return; -
> Node::childrenChanged(changedByParser, beforeChange, afterChange, 
> childCountDelta);
> - invalidateNodeListsCacheAfterAttributeChanged(m_attribute->name()); 
>  // FIXME: We should include entity references in the value
>
>
> <
> http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Build%29/builds/39282/steps/compile-webkit/logs/stdio
> >
>
> Please fix ASAP.
>
> - Mark
>
>
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109030] trunk/Source/WebCore

[sullivan]

Title: [109030] trunk/Source/WebCore








Revision 109030
Author sulli...@apple.com
Date 2012-02-27 15:32:01 -0800 (Mon, 27 Feb 2012)


Log Message
Build fix (on Lion at least).

* dom/Attr.cpp:
(WebCore::Attr::childrenChanged):
Removed names of unused parameters.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::childrenChanged):
Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Attr.cpp
trunk/Source/WebCore/dom/ContainerNode.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (109029 => 109030)

--- trunk/Source/WebCore/ChangeLog	2012-02-27 23:22:32 UTC (rev 109029)
+++ trunk/Source/WebCore/ChangeLog	2012-02-27 23:32:01 UTC (rev 109030)
@@ -1,3 +1,15 @@
+2012-02-27  John Sullivan  
+
+Build fix (on Lion at least).
+
+* dom/Attr.cpp:
+(WebCore::Attr::childrenChanged):
+Removed names of unused parameters.
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::childrenChanged):
+Ditto.
+
 2012-02-27  Kentaro Hara  
 
 Remove [ConstructorParameters] from IDL files that have [Constructor]


Modified: trunk/Source/WebCore/dom/Attr.cpp (109029 => 109030)

--- trunk/Source/WebCore/dom/Attr.cpp	2012-02-27 23:22:32 UTC (rev 109029)
+++ trunk/Source/WebCore/dom/Attr.cpp	2012-02-27 23:32:01 UTC (rev 109030)
@@ -167,7 +167,7 @@
 }
 }
 
-void Attr::childrenChanged(bool changedByParser, Node* beforeChange, Node* afterChange, int childCountDelta)
+void Attr::childrenChanged(bool, Node*, Node*, int)
 {
 if (m_ignoreChildrenChanged > 0)
 return;


Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (109029 => 109030)

--- trunk/Source/WebCore/dom/ContainerNode.cpp	2012-02-27 23:22:32 UTC (rev 109029)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp	2012-02-27 23:32:01 UTC (rev 109030)
@@ -828,7 +828,7 @@
 }
 }
 
-void ContainerNode::childrenChanged(bool changedByParser, Node* beforeChange, Node* afterChange, int childCountDelta)
+void ContainerNode::childrenChanged(bool changedByParser, Node*, Node*, int childCountDelta)
 {
 if (!changedByParser && childCountDelta)
 document()->updateRangesAfterChildrenChanged(this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109029] trunk/Source/WebCore

[haraken]

Title: [109029] trunk/Source/WebCore








Revision 109029
Author hara...@chromium.org
Date 2012-02-27 15:22:32 -0800 (Mon, 27 Feb 2012)


Log Message
Remove [ConstructorParameters] from IDL files that have [Constructor]
https://bugs.webkit.org/show_bug.cgi?id=79643

Reviewed by Adam Barth.

This patch removes [ConstructorParameters] from IDL files that have [Constructor],
since CodeGeneratorJS.pm can automatically detect the number of constructor
arguments by the [Constructor(...)] signature.

Test: fast/js/constructor-length.html

* Modules/mediastream/PeerConnection.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* css/WebKitCSSMatrix.idl:
* page/EventSource.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/PeerConnection.idl
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/css/WebKitCSSMatrix.idl
trunk/Source/WebCore/page/EventSource.idl
trunk/Source/WebCore/workers/SharedWorker.idl
trunk/Source/WebCore/workers/Worker.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (109028 => 109029)

--- trunk/Source/WebCore/ChangeLog	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/ChangeLog	2012-02-27 23:22:32 UTC (rev 109029)
@@ -1,3 +1,24 @@
+2012-02-27  Kentaro Hara  
+
+Remove [ConstructorParameters] from IDL files that have [Constructor]
+https://bugs.webkit.org/show_bug.cgi?id=79643
+
+Reviewed by Adam Barth.
+
+This patch removes [ConstructorParameters] from IDL files that have [Constructor],
+since CodeGeneratorJS.pm can automatically detect the number of constructor
+arguments by the [Constructor(...)] signature.
+
+Test: fast/js/constructor-length.html
+
+* Modules/mediastream/PeerConnection.idl:
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateConstructorDefinition):
+* css/WebKitCSSMatrix.idl:
+* page/EventSource.idl:
+* workers/SharedWorker.idl:
+* workers/Worker.idl:
+
 2012-02-27  Julien Chaffraix  
 
 Avoid doing 2 hash lookups if we override RenderBox's logical width / height


Modified: trunk/Source/WebCore/Modules/mediastream/PeerConnection.idl (109028 => 109029)

--- trunk/Source/WebCore/Modules/mediastream/PeerConnection.idl	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/Modules/mediastream/PeerConnection.idl	2012-02-27 23:22:32 UTC (rev 109029)
@@ -27,7 +27,6 @@
 interface [
 Conditional=MEDIA_STREAM,
 ActiveDOMObject,
-ConstructorParameters=2,
 Constructor(in DOMString serverConfiguration, in [Callback] SignalingCallback signalingCallback),
 CallWith=ScriptExecutionContext,
 JSCustomConstructor,


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (109028 => 109029)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-27 23:22:32 UTC (rev 109029)
@@ -3368,7 +3368,7 @@
 if (!defined $numberOfConstructorParameters) {
 if (IsConstructorTemplate($dataNode, "Event")) {
 $numberOfConstructorParameters = 2;
-} elsif ($dataNode->extendedAttributes->{"Constructor"} and !$dataNode->extendedAttributes->{"CustomConstructor"} and !$dataNode->extendedAttributes->{"JSCustomConstructor"}) {
+} elsif ($dataNode->extendedAttributes->{"Constructor"}) {
 $numberOfConstructorParameters = @{$dataNode->constructor->parameters};
 }
 }


Modified: trunk/Source/WebCore/css/WebKitCSSMatrix.idl (109028 => 109029)

--- trunk/Source/WebCore/css/WebKitCSSMatrix.idl	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/css/WebKitCSSMatrix.idl	2012-02-27 23:22:32 UTC (rev 109029)
@@ -27,7 +27,6 @@
 
 // Introduced in DOM Level ?:
 interface [
-ConstructorParameters=1,
 Constructor(in [Optional=DefaultIsNullString] DOMString cssValue),
 ConstructorRaisesException,
 ] WebKitCSSMatrix {


Modified: trunk/Source/WebCore/page/EventSource.idl (109028 => 109029)

--- trunk/Source/WebCore/page/EventSource.idl	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/page/EventSource.idl	2012-02-27 23:22:32 UTC (rev 109029)
@@ -33,7 +33,6 @@
 
 interface [
 ActiveDOMObject,
-ConstructorParameters=1,
 Constructor(in DOMString scriptUrl),
 CallWith=ScriptExecutionContext,
 ConstructorRaisesException,


Modified: trunk/Source/WebCore/workers/SharedWorker.idl (109028 => 109029)

--- trunk/Source/WebCore/workers/SharedWorker.idl	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/workers/SharedWorker.idl	2012-02-27 23:22:32 UTC (rev 109029)
@@ -35,7 +35,6 @@
 Conditional=SHARED_WORKERS,
 ActiveDOMObject,
 JSCustomConstructor,
-ConstructorParameters=2,
 C

Re: [webkit-changes] [109026] trunk/Source/WebCore

[Mark Rowe]

This broke release builds:

On 2012-02-27, at 14:53, ad...@chromium.org wrote:

> Modified: trunk/Source/WebCore/dom/Attr.cpp (109025 => 109026)
> 
> --- trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 22:19:27 UTC (rev 109025)
> +++ trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 22:53:25 UTC (rev 109026)
> @@ -172,8 +172,6 @@
>  if (m_ignoreChildrenChanged > 0)
>  return;
>  
> -Node::childrenChanged(changedByParser, beforeChange, afterChange, 
> childCountDelta);
> -
>  invalidateNodeListsCacheAfterAttributeChanged(m_attribute->name());
>  
>  // FIXME: We should include entity references in the value




Please fix ASAP.

- Mark

___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109028] trunk/Source/WebCore

[jchaffraix]

Title: [109028] trunk/Source/WebCore








Revision 109028
Author jchaffr...@webkit.org
Date 2012-02-27 15:09:34 -0800 (Mon, 27 Feb 2012)


Log Message
Avoid doing 2 hash lookups if we override RenderBox's logical width / height
https://bugs.webkit.org/show_bug.cgi?id=79591

Reviewed by Antonio Gomes.

Refactoring only.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::clearOverrideSize):
Instead of doing one hash lookup as part of hasOverride{Height|Width}, let's
just directly call HashMap::remove that will do the lookup instead.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (109027 => 109028)

--- trunk/Source/WebCore/ChangeLog	2012-02-27 22:59:10 UTC (rev 109027)
+++ trunk/Source/WebCore/ChangeLog	2012-02-27 23:09:34 UTC (rev 109028)
@@ -1,3 +1,17 @@
+2012-02-27  Julien Chaffraix  
+
+Avoid doing 2 hash lookups if we override RenderBox's logical width / height
+https://bugs.webkit.org/show_bug.cgi?id=79591
+
+Reviewed by Antonio Gomes.
+
+Refactoring only.
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::clearOverrideSize):
+Instead of doing one hash lookup as part of hasOverride{Height|Width}, let's
+just directly call HashMap::remove that will do the lookup instead.
+
 2012-02-27  Adam Klein  
 
 Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (109027 => 109028)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2012-02-27 22:59:10 UTC (rev 109027)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2012-02-27 23:09:34 UTC (rev 109028)
@@ -795,9 +795,9 @@
 
 void RenderBox::clearOverrideSize()
 {
-if (hasOverrideHeight())
+if (gOverrideHeightMap)
 gOverrideHeightMap->remove(this);
-if (hasOverrideWidth())
+if (gOverrideWidthMap)
 gOverrideWidthMap->remove(this);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109027] branches/subpixellayout/Source

[leviw]

Title: [109027] branches/subpixellayout/Source








Revision 109027
Author le...@chromium.org
Date 2012-02-27 14:59:10 -0800 (Mon, 27 Feb 2012)


Log Message
Build fix for Mac. Converting linesBoundingBox and borderBoundingBox, and ShadowData to integers. Removing a whitespace change to bring patch size down. Removing an extraneous printf.

Modified Paths

branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj
branches/subpixellayout/Source/WebCore/dom/ClientRect.h
branches/subpixellayout/Source/WebCore/editing/DeleteButtonController.cpp
branches/subpixellayout/Source/WebCore/page/animation/AnimationBase.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderBox.h
branches/subpixellayout/Source/WebCore/rendering/RenderBoxModelObject.h
branches/subpixellayout/Source/WebCore/rendering/RenderInline.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderInline.h
branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderObject.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderText.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderText.h
branches/subpixellayout/Source/WebCore/rendering/RenderView.cpp
branches/subpixellayout/Source/WebCore/rendering/style/RenderStyle.cpp
branches/subpixellayout/Source/WebCore/rendering/style/ShadowData.cpp
branches/subpixellayout/Source/WebCore/rendering/style/ShadowData.h
branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGInlineText.h
branches/subpixellayout/Source/WebKit/mac/WebView/WebRenderNode.mm




Diff

Modified: branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj (109026 => 109027)

--- branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2012-02-27 22:53:25 UTC (rev 109026)
+++ branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2012-02-27 22:59:10 UTC (rev 109027)
@@ -5014,6 +5014,7 @@
 		B8DBDB4C130B0F8A00F5CDB1 /* SetSelectionCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = B8DBDB48130B0F8A00F5CDB1 /* SetSelectionCommand.h */; };
 		B8DBDB4D130B0F8A00F5CDB1 /* SpellingCorrectionCommand.cpp in Sources */ = {isa = PBXBuildFile; fileRef = B8DBDB49130B0F8A00F5CDB1 /* SpellingCorrectionCommand.cpp */; };
 		B8DBDB4E130B0F8A00F5CDB1 /* SpellingCorrectionCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = B8DBDB4A130B0F8A00F5CDB1 /* SpellingCorrectionCommand.h */; };
+		BAB1C06A14FC3679004233FC /* FractionalLayoutPoint.h in Headers */ = {isa = PBXBuildFile; fileRef = 144FCE5414EC79E7000D17A3 /* FractionalLayoutPoint.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		BACF290113B2A0D500781F90 /* LayoutTypes.h in Headers */ = {isa = PBXBuildFile; fileRef = BACF290013B2A0D500781F90 /* LayoutTypes.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		BC00F0040E0A185500FD04E3 /* DOMFile.h in Headers */ = {isa = PBXBuildFile; fileRef = BC00EFFE0E0A185500FD04E3 /* DOMFile.h */; };
 		BC00F0050E0A185500FD04E3 /* DOMFile.mm in Sources */ = {isa = PBXBuildFile; fileRef = BC00EFFF0E0A185500FD04E3 /* DOMFile.mm */; };
@@ -22369,6 +22370,7 @@
 656D373A0ADBA5DE00A4554D /* FormState.h in Headers */,
 41885B9311B6FDA6003383BB /* FormSubmission.h in Headers */,
 935C476D09AC4D6300A6AAB4 /* FoundationExtras.h in Headers */,
+BAB1C06A14FC3679004233FC /* FractionalLayoutPoint.h in Headers */,
 144FCFE114EF2509000D17A3 /* FractionalLayoutRect.h in Headers */,
 144FCE5D14EC79E7000D17A3 /* FractionalLayoutSize.h in Headers */,
 144FCE5214EC79BC000D17A3 /* FractionalLayoutUnit.h in Headers */,


Modified: branches/subpixellayout/Source/WebCore/dom/ClientRect.h (109026 => 109027)

--- branches/subpixellayout/Source/WebCore/dom/ClientRect.h	2012-02-27 22:53:25 UTC (rev 109026)
+++ branches/subpixellayout/Source/WebCore/dom/ClientRect.h	2012-02-27 22:59:10 UTC (rev 109027)
@@ -34,7 +34,7 @@
 
 namespace WebCore {
 
-class IntRect;
+class IntRect; 
 
 class ClientRect : public RefCounted {
 public:


Modified: branches/subpixellayout/Source/WebCore/editing/DeleteButtonController.cpp (109026 => 109027)

--- branches/subpixellayout/Source/WebCore/editing/DeleteButtonController.cpp	2012-02-27 22:53:25 UTC (rev 109026)
+++ branches/subpixellayout/Source/WebCore/editing/DeleteButtonController.cpp	2012-02-27 22:59:10 UTC (rev 109027)
@@ -92,7 +92,7 @@
 return false;
 
 RenderBox* box = toRenderBox(renderer);
-LayoutRect borderBoundingBox = box->borderBoundingBox();
+IntRect borderBoundingBox = box->borderBoundingBox();
 if (borderBoundingBox.width() < minimumWidth || borderBoundingBox.height() < minimumHeight)
 return false;
 


Modified: branches/subpixellayout/Source/WebCore/page/animation/AnimationBase.cpp (109026 => 109027)

--- branches/subpixellayout/Source/WebCore/page/animation/AnimationBase.cpp	2012-02-27 22:53:25 UTC (rev 109026)
+++ branches/subpixellayou

[webkit-changes] [109026] trunk/Source/WebCore

[adamk]

Title: [109026] trunk/Source/WebCore








Revision 109026
Author ad...@chromium.org
Date 2012-02-27 14:53:25 -0800 (Mon, 27 Feb 2012)


Log Message
Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate
https://bugs.webkit.org/show_bug.cgi?id=79697

Reviewed by Ryosuke Niwa.

insertedIntoTree/removedFromTree are only used by subclasses of
ContainerNode. Moreover, attempting to make use of these notifications
in a non-container Node would currently not work, because
Node::removedFromDocument/insertedIntoDocument do not dispatch to these methods.
Rather than adding useless calls to an always-empty virtual method,
this patch moves these methods to ContainerNode.

Meanwhile, childrenChanged moves to ContainerNode for an obvious reason:
non-container Nodes have no children to change.

No new tests, refactoring only.

* dom/Attr.cpp:
(WebCore::Attr::childrenChanged): Remove call to now-nonexistent Node::childrenChanged.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild): Check that the removed child is a container node before notifying it of removal.
(WebCore::ContainerNode::parserRemoveChild): ditto.
(WebCore::ContainerNode::insertedIntoTree): Remove call to now-nonexistent Node::insertedIntoTree.
(WebCore::ContainerNode::removedFromTree): Remove call to now-nonexistent Node::removedFromTree.
(WebCore::ContainerNode::childrenChanged): Remove call to now-nonexistent Node::childrenChanged.
(WebCore::notifyChildInserted): Check that the inserted child is a container node before notifying it of insertion.
* dom/ContainerNode.h:
(ContainerNode): Migrate comments from Node.h, point back at it for more notification methods.
* dom/Node.h:
(Node): Move methods, update comments to point at ContainerNode.h.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Attr.cpp
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/ContainerNode.h
trunk/Source/WebCore/dom/Node.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (109025 => 109026)

--- trunk/Source/WebCore/ChangeLog	2012-02-27 22:19:27 UTC (rev 109025)
+++ trunk/Source/WebCore/ChangeLog	2012-02-27 22:53:25 UTC (rev 109026)
@@ -1,3 +1,36 @@
+2012-02-27  Adam Klein  
+
+Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate
+https://bugs.webkit.org/show_bug.cgi?id=79697
+
+Reviewed by Ryosuke Niwa.
+
+insertedIntoTree/removedFromTree are only used by subclasses of
+ContainerNode. Moreover, attempting to make use of these notifications
+in a non-container Node would currently not work, because
+Node::removedFromDocument/insertedIntoDocument do not dispatch to these methods.
+Rather than adding useless calls to an always-empty virtual method,
+this patch moves these methods to ContainerNode.
+
+Meanwhile, childrenChanged moves to ContainerNode for an obvious reason:
+non-container Nodes have no children to change.
+
+No new tests, refactoring only.
+
+* dom/Attr.cpp:
+(WebCore::Attr::childrenChanged): Remove call to now-nonexistent Node::childrenChanged.
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::removeChild): Check that the removed child is a container node before notifying it of removal.
+(WebCore::ContainerNode::parserRemoveChild): ditto.
+(WebCore::ContainerNode::insertedIntoTree): Remove call to now-nonexistent Node::insertedIntoTree.
+(WebCore::ContainerNode::removedFromTree): Remove call to now-nonexistent Node::removedFromTree.
+(WebCore::ContainerNode::childrenChanged): Remove call to now-nonexistent Node::childrenChanged.
+(WebCore::notifyChildInserted): Check that the inserted child is a container node before notifying it of insertion.
+* dom/ContainerNode.h:
+(ContainerNode): Migrate comments from Node.h, point back at it for more notification methods.
+* dom/Node.h:
+(Node): Move methods, update comments to point at ContainerNode.h.
+
 2012-02-27  Chris Rogers  
 
 Implement static compression curve parameters for DynamicsCompressorNode


Modified: trunk/Source/WebCore/dom/Attr.cpp (109025 => 109026)

--- trunk/Source/WebCore/dom/Attr.cpp	2012-02-27 22:19:27 UTC (rev 109025)
+++ trunk/Source/WebCore/dom/Attr.cpp	2012-02-27 22:53:25 UTC (rev 109026)
@@ -172,8 +172,6 @@
 if (m_ignoreChildrenChanged > 0)
 return;
 
-Node::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta);
-
 invalidateNodeListsCacheAfterAttributeChanged(m_attribute->name());
 
 // FIXME: We should include entity references in the value


Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (109025 => 109026)

--- trunk/Source/WebCore/dom/ContainerNode.cpp	2012-02-27 22:19:27 UTC (rev 109025)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp	2012-02-27 22:53:25 UTC (rev 109026)
@@ -463,8 +463,8 @@
 
 if (child

[webkit-changes] [109025] branches/subpixellayout/Source

[eae]

Title: [109025] branches/subpixellayout/Source








Revision 109025
Author e...@chromium.org
Date 2012-02-27 14:19:27 -0800 (Mon, 27 Feb 2012)


Log Message
Fix a IntRect/LayoutRect usage to avoid unnecessary type conversions on branch.

Modified Paths

branches/subpixellayout/Source/WebCore/dom/Document.cpp
branches/subpixellayout/Source/WebCore/dom/Element.cpp
branches/subpixellayout/Source/WebCore/dom/Element.h
branches/subpixellayout/Source/WebCore/rendering/HitTestResult.cpp
branches/subpixellayout/Source/WebCore/rendering/HitTestResult.h
branches/subpixellayout/Source/WebKit/chromium/src/WebElement.cpp
branches/subpixellayout/Source/WebKit/chromium/src/WebPluginContainerImpl.h
branches/subpixellayout/Source/WebKit/chromium/src/WebViewImpl.cpp
branches/subpixellayout/Source/WebKit/mac/WebView/WebHTMLView.mm
branches/subpixellayout/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp




Diff

Modified: branches/subpixellayout/Source/WebCore/dom/Document.cpp (109024 => 109025)

--- branches/subpixellayout/Source/WebCore/dom/Document.cpp	2012-02-27 22:19:12 UTC (rev 109024)
+++ branches/subpixellayout/Source/WebCore/dom/Document.cpp	2012-02-27 22:19:27 UTC (rev 109025)
@@ -1210,7 +1210,7 @@
 // When ignoreClipping is false, this method returns null for coordinates outside of the viewport.
 if (ignoreClipping)
 type |= HitTestRequest::IgnoreClipping;
-else if (!frameView->visibleContentRect().intersects(enclosingIntRect(HitTestResult::rectForPoint(point, topPadding, rightPadding, bottomPadding, leftPadding
+else if (!frameView->visibleContentRect().intersects(HitTestResult::rectForPoint(point, topPadding, rightPadding, bottomPadding, leftPadding)))
 return 0;
 
 HitTestRequest request(type);


Modified: branches/subpixellayout/Source/WebCore/dom/Element.cpp (109024 => 109025)

--- branches/subpixellayout/Source/WebCore/dom/Element.cpp	2012-02-27 22:19:12 UTC (rev 109024)
+++ branches/subpixellayout/Source/WebCore/dom/Element.cpp	2012-02-27 22:19:27 UTC (rev 109025)
@@ -459,13 +459,13 @@
 return 0;
 }
 
-LayoutRect Element::boundsInRootViewSpace()
+IntRect Element::boundsInRootViewSpace()
 {
 document()->updateLayoutIgnorePendingStylesheets();
 
 FrameView* view = document()->view();
 if (!view)
-return LayoutRect();
+return IntRect();
 
 Vector quads;
 #if ENABLE(SVG)
@@ -484,13 +484,13 @@
 }
 
 if (quads.isEmpty())
-return LayoutRect();
+return IntRect();
 
-LayoutRect result = quads[0].enclosingBoundingBox();
+IntRect result = quads[0].enclosingBoundingBox();
 for (size_t i = 1; i < quads.size(); ++i)
 result.unite(quads[i].enclosingBoundingBox());
 
-result = view->contentsToRootView(enclosingIntRect(result));
+result = view->contentsToRootView(result);
 return result;
 }
 


Modified: branches/subpixellayout/Source/WebCore/dom/Element.h (109024 => 109025)

--- branches/subpixellayout/Source/WebCore/dom/Element.h	2012-02-27 22:19:12 UTC (rev 109024)
+++ branches/subpixellayout/Source/WebCore/dom/Element.h	2012-02-27 22:19:27 UTC (rev 109025)
@@ -184,7 +184,7 @@
 virtual int scrollWidth();
 virtual int scrollHeight();
 
-LayoutRect boundsInRootViewSpace();
+IntRect boundsInRootViewSpace();
 
 PassRefPtr getClientRects();
 PassRefPtr getBoundingClientRect();


Modified: branches/subpixellayout/Source/WebCore/rendering/HitTestResult.cpp (109024 => 109025)

--- branches/subpixellayout/Source/WebCore/rendering/HitTestResult.cpp	2012-02-27 22:19:12 UTC (rev 109024)
+++ branches/subpixellayout/Source/WebCore/rendering/HitTestResult.cpp	2012-02-27 22:19:27 UTC (rev 109025)
@@ -589,7 +589,7 @@
 mutableRectBasedTestResult().add(currInline->node()->shadowAncestorNode());
 }
 }
-return !rect.contains(enclosingIntRect(rectForPoint(pointInContainer)));
+return !rect.contains(rectForPoint(pointInContainer));
 }
 
 bool HitTestResult::addNodeToRectBasedTestResult(Node* node, const LayoutPoint& pointInContainer, const FloatRect& rect)
@@ -643,16 +643,16 @@
 }
 }
 
-LayoutRect HitTestResult::rectForPoint(const LayoutPoint& point, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding)
+IntRect HitTestResult::rectForPoint(const LayoutPoint& point, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding)
 {
-LayoutPoint actualPoint(point);
-actualPoint -= LayoutSize(leftPadding, topPadding);
+IntPoint actualPoint(roundedIntPoint(point));
+actualPoint -= IntSize(leftPadding, topPadding);
 
 IntSize actualPadding(leftPadding + rightPadding, topPadding + bottomPadding);
 // As IntRect is left inclusive and right exclusive (seeing IntRect::contains(x, y)), adding "1".
 actualPadding += IntSize(1, 1);
 
-return LayoutRect(actualPoint, actualPadding);
+return IntRect(actualPoint, actualPadding);
 }
 
 const Hi

[webkit-changes] [109024] trunk/LayoutTests

[enne]

Title: [109024] trunk/LayoutTests








Revision 109024
Author e...@google.com
Date 2012-02-27 14:19:12 -0800 (Mon, 27 Feb 2012)


Log Message
[chromium] Unreviewed gardening, mark two fast/regex tests as failing

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (109023 => 109024)

--- trunk/LayoutTests/ChangeLog	2012-02-27 22:15:11 UTC (rev 109023)
+++ trunk/LayoutTests/ChangeLog	2012-02-27 22:19:12 UTC (rev 109024)
@@ -1,3 +1,9 @@
+2012-02-27  Adrienne Walker  
+
+[chromium] Unreviewed gardening, mark two fast/regex tests as failing
+
+* platform/chromium/test_expectations.txt:
+
 2012-02-27  Chris Rogers  
 
 Implement static compression curve parameters for DynamicsCompressorNode


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109023 => 109024)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-27 22:15:11 UTC (rev 109023)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-27 22:19:12 UTC (rev 109024)
@@ -4231,3 +4231,6 @@
 BUGWK79642 : accessibility/aria-describedby-on-input.html = TIMEOUT
 BUGWK79642 : fast/loader/subresource-willSendRequest-null.html = TIMEOUT
 BUGWK79642 : media/video-playbackrate.html = TIMEOUT
+
+BUGWK79702 : fast/regex/lastIndex.html = TEXT
+BUGWK79703 : fast/regex/overflow.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109023] trunk

[crogers]

Title: [109023] trunk








Revision 109023
Author crog...@google.com
Date 2012-02-27 14:15:11 -0800 (Mon, 27 Feb 2012)


Log Message
Implement static compression curve parameters for DynamicsCompressorNode
https://bugs.webkit.org/show_bug.cgi?id=78937

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/dynamicscompressor-basic.html

* platform/audio/DynamicsCompressor.cpp:
(WebCore::DynamicsCompressor::setParameterValue):
(WebCore):
(WebCore::DynamicsCompressor::initializeParameters):
(WebCore::DynamicsCompressor::process):
* platform/audio/DynamicsCompressor.h:
* platform/audio/DynamicsCompressorKernel.cpp:
(WebCore):
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::kneeCurve):
(WebCore::DynamicsCompressorKernel::saturate):
(WebCore::DynamicsCompressorKernel::slopeAt):
(WebCore::DynamicsCompressorKernel::kAtSlope):
(WebCore::DynamicsCompressorKernel::updateStaticCurveParameters):
(WebCore::DynamicsCompressorKernel::process):
* platform/audio/DynamicsCompressorKernel.h:
(DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::meteringGain):
* webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):
* webaudio/DynamicsCompressorNode.h:
(WebCore):
(WebCore::DynamicsCompressorNode::create):
(DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::threshold):
(WebCore::DynamicsCompressorNode::knee):
(WebCore::DynamicsCompressorNode::ratio):
(WebCore::DynamicsCompressorNode::reduction):
* webaudio/DynamicsCompressorNode.idl:

LayoutTests:

* webaudio/dynamicscompressor-basic-expected.txt: Added.
* webaudio/dynamicscompressor-basic.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/DynamicsCompressor.cpp
trunk/Source/WebCore/platform/audio/DynamicsCompressor.h
trunk/Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp
trunk/Source/WebCore/platform/audio/DynamicsCompressorKernel.h
trunk/Source/WebCore/webaudio/DynamicsCompressorNode.cpp
trunk/Source/WebCore/webaudio/DynamicsCompressorNode.h
trunk/Source/WebCore/webaudio/DynamicsCompressorNode.idl


Added Paths

trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt
trunk/LayoutTests/webaudio/dynamicscompressor-basic.html




Diff

Modified: trunk/LayoutTests/ChangeLog (109022 => 109023)

--- trunk/LayoutTests/ChangeLog	2012-02-27 22:03:41 UTC (rev 109022)
+++ trunk/LayoutTests/ChangeLog	2012-02-27 22:15:11 UTC (rev 109023)
@@ -1,3 +1,13 @@
+2012-02-27  Chris Rogers  
+
+Implement static compression curve parameters for DynamicsCompressorNode
+https://bugs.webkit.org/show_bug.cgi?id=78937
+
+Reviewed by Kenneth Russell.
+
+* webaudio/dynamicscompressor-basic-expected.txt: Added.
+* webaudio/dynamicscompressor-basic.html: Added.
+
 2012-02-27  Oliver Hunt  
 
 REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize


Added: trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt (0 => 109023)

--- trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt	(rev 0)
+++ trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt	2012-02-27 22:15:11 UTC (rev 109023)
@@ -0,0 +1,11 @@
+Basic tests for DynamicsCompressorNode API.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS threshold attribute has correct default value.
+PASS knee attribute has correct default value.
+PASS ratio attribute has correct default value.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/webaudio/dynamicscompressor-basic.html (0 => 109023)

--- trunk/LayoutTests/webaudio/dynamicscompressor-basic.html	(rev 0)
+++ trunk/LayoutTests/webaudio/dynamicscompressor-basic.html	2012-02-27 22:15:11 UTC (rev 109023)
@@ -0,0 +1,59 @@
+
+
+
+
+
+
+
+

+

+
+