[webkit-changes] [273476] trunk/Tools
Title: [273476] trunk/Tools
Revision 273476
Author rn...@webkit.org
Date 2021-02-24 23:32:19 -0800 (Wed, 24 Feb 2021)
Log Message
Build fix after r273465.
* TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm
Diff
Modified: trunk/Tools/ChangeLog (273475 => 273476)
--- trunk/Tools/ChangeLog 2021-02-25 07:00:48 UTC (rev 273475)
+++ trunk/Tools/ChangeLog 2021-02-25 07:32:19 UTC (rev 273476)
@@ -1,3 +1,9 @@
+2021-02-24 Ryosuke Niwa
+
+Build fix after r273465.
+
+* TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
+
2021-02-24 Kate Cheney
App-bound request parameter should be passed to main resource requests not the main frame
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm (273475 => 273476)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm 2021-02-25 07:00:48 UTC (rev 273475)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm 2021-02-25 07:32:19 UTC (rev 273476)
@@ -1537,6 +1537,7 @@
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
[configuration _setOverrideContentSecurityPolicy:@"script-src 'nonce-b'"];
+__block bool isDone = false;
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
NSMutableURLRequest *nonAppBoundRequest = [NSMutableURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"page-with-csp" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
APP_BOUND_REQUEST_ADDITIONS
@@ -1546,7 +1547,6 @@
[webView waitForMessage:@"MainFrame: B"];
[webView waitForMessage:@"Subframe: B"];
-__block bool isDone = false;
[webView _appBoundNavigationData: ^(struct WKAppBoundNavigationTestingData data) {
EXPECT_FALSE(data.hasLoadedAppBoundRequestTesting);
EXPECT_TRUE(data.hasLoadedNonAppBoundRequestTesting);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273475] branches/safari-611-branch/Source/WebCore/Modules/mediarecorder/ MediaRecorder.cpp
Title: [273475] branches/safari-611-branch/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp
Revision 273475
Author alanc...@apple.com
Date 2021-02-24 23:00:48 -0800 (Wed, 24 Feb 2021)
Log Message
Unreviewed build fix. rdar://problem/74501076
Modified Paths
branches/safari-611-branch/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp
Diff
Modified: branches/safari-611-branch/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp (273474 => 273475)
--- branches/safari-611-branch/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp 2021-02-25 06:50:56 UTC (rev 273474)
+++ branches/safari-611-branch/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp 2021-02-25 07:00:48 UTC (rev 273475)
@@ -313,7 +313,7 @@
void MediaRecorder::stopRecordingInternal()
{
-if (state() == RecordingState::Inactive) {
+if (state() == RecordingState::Inactive)
return;
for (auto& track : m_tracks)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273474] trunk/Source/WebCore
Title: [273474] trunk/Source/WebCore
Revision 273474
Author rn...@webkit.org
Date 2021-02-24 22:50:56 -0800 (Wed, 24 Feb 2021)
Log Message
Optimize the code to check if an element delegates focus to its shadow root or not
https://bugs.webkit.org/show_bug.cgi?id=222404
Reviewed by Simon Fraser.
Add a fast path for checking whether a given element is a shadow host with a shadow root
with delegatesFocus set to true in with a new node flag: DelegatesFocusToShadowRoot.
The flag is set in Element::attachShadow and never cleared as delegatesFocus can never be unset.
No new tests since there should be no observable behavioral differences.
* dom/Element.cpp:
(WebCore::Element::isKeyboardFocusable const): Optimized this code using the new flag.
(WebCore::shadowRootWithDelegatesFocus): Set the flag.
(WebCore::isProgramaticallyFocusable): Optimized this code using the new flag.
(WebCore::Element::focus): Ditto.
* dom/Node.h:
(WebCore::Node::delegatesFocusToShadowRoot const): Added.
(WebCore::Node::NodeFlag): Added NodeFlag::DelegatesFocusToShadowRoot.
(WebCore::Node::setDelegatesFocusToShadowRoot): Added.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Node.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (273473 => 273474)
--- trunk/Source/WebCore/ChangeLog 2021-02-25 06:45:27 UTC (rev 273473)
+++ trunk/Source/WebCore/ChangeLog 2021-02-25 06:50:56 UTC (rev 273474)
@@ -1,3 +1,27 @@
+2021-02-24 Ryosuke Niwa
+
+Optimize the code to check if an element delegates focus to its shadow root or not
+https://bugs.webkit.org/show_bug.cgi?id=222404
+
+Reviewed by Simon Fraser.
+
+Add a fast path for checking whether a given element is a shadow host with a shadow root
+with delegatesFocus set to true in with a new node flag: DelegatesFocusToShadowRoot.
+
+The flag is set in Element::attachShadow and never cleared as delegatesFocus can never be unset.
+
+No new tests since there should be no observable behavioral differences.
+
+* dom/Element.cpp:
+(WebCore::Element::isKeyboardFocusable const): Optimized this code using the new flag.
+(WebCore::shadowRootWithDelegatesFocus): Set the flag.
+(WebCore::isProgramaticallyFocusable): Optimized this code using the new flag.
+(WebCore::Element::focus): Ditto.
+* dom/Node.h:
+(WebCore::Node::delegatesFocusToShadowRoot const): Added.
+(WebCore::Node::NodeFlag): Added NodeFlag::DelegatesFocusToShadowRoot.
+(WebCore::Node::setDelegatesFocusToShadowRoot): Added.
+
2021-02-24 Rob Buis
[css-grid] Do not allow negative heights
Modified: trunk/Source/WebCore/dom/Element.cpp (273473 => 273474)
--- trunk/Source/WebCore/dom/Element.cpp 2021-02-25 06:45:27 UTC (rev 273473)
+++ trunk/Source/WebCore/dom/Element.cpp 2021-02-25 06:50:56 UTC (rev 273474)
@@ -315,11 +315,8 @@
{
if (!(isFocusable() && !shouldBeIgnoredInSequentialFocusNavigation() && tabIndexSetExplicitly().valueOr(0) >= 0))
return false;
-if (auto* root = shadowRoot()) {
-if (root->delegatesFocus())
-return false;
-}
-return true;
+ASSERT(delegatesFocusToShadowRoot() == (shadowRoot() && shadowRoot()->delegatesFocus()));
+return !delegatesFocusToShadowRoot();
}
bool Element::isMouseFocusable() const
@@ -2393,6 +2390,8 @@
if (init.mode == ShadowRootMode::UserAgent)
return Exception { TypeError };
auto shadow = ShadowRoot::create(document(), init.mode, init.delegatesFocus ? ShadowRoot::DelegatesFocus::Yes : ShadowRoot::DelegatesFocus::No);
+if (init.delegatesFocus)
+setDelegatesFocusToShadowRoot();
auto& result = shadow.get();
addShadowRoot(WTFMove(shadow));
return result;
@@ -2976,7 +2975,8 @@
{
ScriptDisallowedScope::InMainThread scriptDisallowedScope;
-if (shadowRootWithDelegatesFocus(element))
+ASSERT(element.delegatesFocusToShadowRoot() == !!shadowRootWithDelegatesFocus(element));
+if (element.delegatesFocusToShadowRoot())
return false;
// If the stylesheets have already been loaded we can reliably check isFocusable.
@@ -3023,7 +3023,9 @@
if (>document() != document.ptr())
return;
-if (auto root = shadowRootWithDelegatesFocus(*this)) {
+ASSERT(delegatesFocusToShadowRoot() == !!shadowRootWithDelegatesFocus(*this));
+if (delegatesFocusToShadowRoot()) {
+auto root = shadowRootWithDelegatesFocus(*this);
auto currentlyFocusedElement = makeRefPtr(document->focusedElement());
if (root->containsIncludingShadowDOM(currentlyFocusedElement.get())) {
if (document->page())
Modified: trunk/Source/WebCore/dom/Node.h (273473 => 273474)
--- trunk/Source/WebCore/dom/Node.h 2021-02-25 06:45:27 UTC (rev 273473)
+++ trunk/Source/WebCore/dom/Node.h 2021-02-25 06:50:56 UTC (rev 273474)
@@ -222,6 +222,7 @@
ShadowRoot*
[webkit-changes] [273473] trunk/Source/WebKit
Title: [273473] trunk/Source/WebKit Revision 273473 Author peng.l...@apple.com Date 2021-02-24 22:45:27 -0800 (Wed, 24 Feb 2021) Log Message [GPUP] Use a WeakPtr of GPUConnectionToWebProcess instead of a reference in some media related objects https://bugs.webkit.org/show_bug.cgi?id=93 Reviewed by Eric Carlson. A GPUConnectionToWebProcess object may be destroyed when we close a page, then crash will happen in callbacks accessing the GPUConnectionToWebProcess object. For example, in `RemoteSourceBufferProxy::sourceBufferPrivateBufferedRangesChanged()`. This patch replaces the references to a GPUConnectionToWebProcess with WeakPtr(s) in places where the issue may happen. No new tests. Fix some test crashes. * GPUProcess/GPUConnectionToWebProcess.cpp: (WebKit::GPUConnectionToWebProcess::isAlwaysOnLoggingAllowed const): (WebKit::GPUConnectionToWebProcess::mediaEngineConfigurationFactoryProxy): * GPUProcess/GPUConnectionToWebProcess.h: * GPUProcess/media/RemoteAudioHardwareListenerProxy.cpp: (WebKit::RemoteAudioHardwareListenerProxy::RemoteAudioHardwareListenerProxy): (WebKit::RemoteAudioHardwareListenerProxy::audioHardwareDidBecomeActive): (WebKit::RemoteAudioHardwareListenerProxy::audioHardwareDidBecomeInactive): (WebKit::RemoteAudioHardwareListenerProxy::audioOutputDeviceChanged): * GPUProcess/media/RemoteAudioHardwareListenerProxy.h: * GPUProcess/media/RemoteAudioTrackProxy.cpp: (WebKit::RemoteAudioTrackProxy::RemoteAudioTrackProxy): (WebKit::RemoteAudioTrackProxy::configurationChanged): * GPUProcess/media/RemoteAudioTrackProxy.h: * GPUProcess/media/RemoteCDMFactoryProxy.cpp: (WebKit::RemoteCDMFactoryProxy::RemoteCDMFactoryProxy): * GPUProcess/media/RemoteCDMFactoryProxy.h: * GPUProcess/media/RemoteCDMInstanceProxy.cpp: (WebKit::RemoteCDMInstanceProxy::unrequestedInitializationDataReceived): * GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp: (WebKit::RemoteCDMInstanceSessionProxy::updateKeyStatuses): (WebKit::RemoteCDMInstanceSessionProxy::sendMessage): (WebKit::RemoteCDMInstanceSessionProxy::sessionIdChanged): * GPUProcess/media/RemoteImageDecoderAVFProxy.cpp: (WebKit::RemoteImageDecoderAVFProxy::RemoteImageDecoderAVFProxy): (WebKit::RemoteImageDecoderAVFProxy::encodedDataStatusChanged): * GPUProcess/media/RemoteImageDecoderAVFProxy.h: * GPUProcess/media/RemoteLegacyCDMFactoryProxy.cpp: (WebKit::RemoteLegacyCDMFactoryProxy::RemoteLegacyCDMFactoryProxy): (WebKit::RemoteLegacyCDMFactoryProxy::~RemoteLegacyCDMFactoryProxy): (WebKit::RemoteLegacyCDMFactoryProxy::addProxy): (WebKit::RemoteLegacyCDMFactoryProxy::removeProxy): (WebKit::RemoteLegacyCDMFactoryProxy::addSession): (WebKit::RemoteLegacyCDMFactoryProxy::removeSession): * GPUProcess/media/RemoteLegacyCDMFactoryProxy.h: * GPUProcess/media/RemoteLegacyCDMProxy.cpp: (WebKit::RemoteLegacyCDMProxy::cdmMediaPlayer const): * GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp: (WebKit::RemoteLegacyCDMSessionProxy::sendMessage): (WebKit::RemoteLegacyCDMSessionProxy::sendError): (WebKit::RemoteLegacyCDMSessionProxy::mediaKeysStorageDirectory const): * GPUProcess/media/RemoteMediaEngineConfigurationFactoryProxy.cpp: (WebKit::RemoteMediaEngineConfigurationFactoryProxy::RemoteMediaEngineConfigurationFactoryProxy): * GPUProcess/media/RemoteMediaEngineConfigurationFactoryProxy.h: * GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp: (WebKit::RemoteMediaPlayerManagerProxy::RemoteMediaPlayerManagerProxy): (WebKit::RemoteMediaPlayerManagerProxy::createMediaPlayer): (WebKit::RemoteMediaPlayerManagerProxy::logger): (WebKit::RemoteMediaPlayerManagerProxy::logger const): Deleted. (WebKit::RemoteMediaPlayerManagerProxy::logChannel const): Deleted. * GPUProcess/media/RemoteMediaPlayerManagerProxy.h: (WebKit::RemoteMediaPlayerManagerProxy::gpuConnectionToWebProcess): (WebKit::RemoteMediaPlayerManagerProxy::gpuConnectionToWebProcess const): Deleted. (): Deleted. * GPUProcess/media/RemoteMediaPlayerProxy.cpp: (WebKit::RemoteMediaPlayerProxy::RemoteMediaPlayerProxy): (WebKit::RemoteMediaPlayerProxy::loadMediaSource): (WebKit::RemoteMediaPlayerProxy::requestResource): (WebKit::RemoteMediaPlayerProxy::mediaPlayerMediaKeysStorageDirectory const): (WebKit::RemoteMediaPlayerProxy::mediaPlayerMediaCacheDirectory const): (WebKit::RemoteMediaPlayerProxy::addRemoteAudioTrackProxy): (WebKit::RemoteMediaPlayerProxy::addRemoteVideoTrackProxy): (WebKit::RemoteMediaPlayerProxy::addRemoteTextTrackProxy): (WebKit::RemoteMediaPlayerProxy::mediaPlayerCachedKeyForKeyId const): (WebKit::RemoteMediaPlayerProxy::setLegacyCDMSession): (WebKit::RemoteMediaPlayerProxy::cdmInstanceAttached): (WebKit::RemoteMediaPlayerProxy::cdmInstanceDetached): (WebKit::RemoteMediaPlayerProxy::attemptToDecryptWithInstance): * GPUProcess/media/RemoteMediaPlayerProxy.h: * GPUProcess/media/RemoteMediaSourceProxy.cpp: (WebKit::RemoteMediaSourceProxy::RemoteMediaSourceProxy): (WebKit::RemoteMediaSourceProxy::~RemoteMediaSourceProxy): (WebKit::RemoteMediaSourceProxy::seekToTime):
[webkit-changes] [273472] trunk/LayoutTests
Title: [273472] trunk/LayoutTests Revision 273472 Author peng.l...@apple.com Date 2021-02-24 22:24:46 -0800 (Wed, 24 Feb 2021) Log Message [GPUP] Remove duplicated items in LayoutTests/gpu-process/TestExpectations related to media https://bugs.webkit.org/show_bug.cgi?id=222390 Unreviewed test gardening. We have enabled "Media in GPU Process" by default in WKTR, so platform-specific TestExpectations such as platform/wk2/TestExpectations will be used as the baseline for media related tests. * gpu-process/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/gpu-process/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (273471 => 273472) --- trunk/LayoutTests/ChangeLog 2021-02-25 06:10:40 UTC (rev 273471) +++ trunk/LayoutTests/ChangeLog 2021-02-25 06:24:46 UTC (rev 273472) @@ -1,3 +1,15 @@ +2021-02-24 Peng Liu + +[GPUP] Remove duplicated items in LayoutTests/gpu-process/TestExpectations related to media +https://bugs.webkit.org/show_bug.cgi?id=222390 + +Unreviewed test gardening. + +We have enabled "Media in GPU Process" by default in WKTR, so platform-specific TestExpectations +such as platform/wk2/TestExpectations will be used as the baseline for media related tests. + +* gpu-process/TestExpectations: + 2021-02-24 Rob Buis [css-grid] Do not allow negative heights Modified: trunk/LayoutTests/gpu-process/TestExpectations (273471 => 273472) --- trunk/LayoutTests/gpu-process/TestExpectations 2021-02-25 06:10:40 UTC (rev 273471) +++ trunk/LayoutTests/gpu-process/TestExpectations 2021-02-25 06:24:46 UTC (rev 273472) @@ -42,16 +42,6 @@ fast/repaint/canvas-object-fit.html [ Failure ] fast/repaint/canvas-putImageData.html [ Failure ] -# webkit.org/b/221694 -http/tests/media/clearkey/clear-key-hls-aes128.html [ Failure ] -http/tests/media/clearkey/collect-webkit-media-session.html [ Crash ] -http/tests/media/hls/hls-audio-tracks-locale-selection.html [ Failure ] -http/tests/media/hls/hls-hdr-switch.html [ Timeout ] -http/tests/media/hls/hls-progress.html [ Failure ] -http/tests/media/hls/video-controls-live-stream.html [ Timeout ] -http/tests/media/hls/video-duration-accessibility.html [ Timeout ] -http/tests/media/video-play-stall.html [ Failure Timeout ] - http/tests/security/canvas-remote-read-remote-video-allowed-anonymous.html [ Failure Timeout ] http/tests/security/canvas-remote-read-remote-video-allowed-with-credentials.html [ Failure Timeout ] http/tests/security/contentSecurityPolicy/audio-redirect-blocked.html [ Failure ] @@ -78,9 +68,6 @@ inspector/canvas/recording-2d-memoryLimit.html [ Crash ] inspector/canvas/recording-html-2d.html [ Crash ] -# webkit.org/b/221697 -imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/load-events-networkState.html [ Failure ] - # webkit.org/b/220375 media/modern-media-controls/media-controller/media-controller-auto-hide.html [ Crash Pass ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_loadedmetadata.html [ Crash ] @@ -87,61 +74,6 @@ imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_progress.html [ Crash ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash ] -# webkit.org/b/221688 -media/W3C/video/networkState/networkState_during_loadstart.html [ Failure Pass ] -media/W3C/video/readyState/readyState_during_loadedmetadata.html [ Crash Pass ] - -# webkit.org/b/221685 -media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Timeout Failure Pass ] -media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Timeout Pass ] -media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause-fullscreen.html [ Timeout Pass ] -media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html [ Failure Timeout ] -media/modern-media-controls/media-controller/media-controller-fullscreen-change.html [ Failure Pass ] -media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html [ Timeout Pass ] -media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html [ Timeout Pass ] -media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html [ Failure Pass ] -media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html [ Timeout Pass ] -media/modern-media-controls/placard/placard-ltr.html [ Failure Timeout Pass ] -media/modern-media-controls/scrubber-support/scrubber-support-drag.html [ Timeout Pass ] -media/modern-media-controls/seek-backward-support/seek-backward-support.html [ Timeout Pass ] - -# webkit.org/b/221689
[webkit-changes] [273471] trunk/Source/WebKit
Title: [273471] trunk/Source/WebKit
Revision 273471
Author bb...@apple.com
Date 2021-02-24 22:10:40 -0800 (Wed, 24 Feb 2021)
Log Message
[Cocoa] Web Inspector: expose the extension host that is used to load _WKInspectorExtension tabs
https://bugs.webkit.org/show_bug.cgi?id=222344
Reviewed by Devin Rousso.
Clients need access to the WKWebView that hosts extension content in order to implement message passing
and event delivery to the extension panel iframes. (Currently, that WebView is
the same underlying WKWebView for the whole interface, but that is open to change.)
* UIProcess/API/Cocoa/_WKInspectorExtensionHost.h: New property.
* UIProcess/API/Cocoa/_WKInspectorPrivate.h:
* UIProcess/API/Cocoa/_WKInspector.mm:
(-[_WKInspector extensionHostWebView]): Added.
(-[_WKInspector handle]): Deleted.
* UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
(-[_WKRemoteWebInspectorViewController extensionHostWebView]): Added.
(-[_WKRemoteWebInspectorViewController handle]): Deleted.
* Shared/API/Cocoa/WKBrowsingContextHandle.mm:
(-[WKBrowsingContextHandle description]):
Drive-by, add the standard -description for debugging purposes.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/API/Cocoa/WKBrowsingContextHandle.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionHost.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorPrivate.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (273470 => 273471)
--- trunk/Source/WebKit/ChangeLog 2021-02-25 05:59:46 UTC (rev 273470)
+++ trunk/Source/WebKit/ChangeLog 2021-02-25 06:10:40 UTC (rev 273471)
@@ -1,3 +1,30 @@
+2021-02-24 BJ Burg
+
+[Cocoa] Web Inspector: expose the extension host that is used to load _WKInspectorExtension tabs
+https://bugs.webkit.org/show_bug.cgi?id=222344
+
+
+Reviewed by Devin Rousso.
+
+Clients need access to the WKWebView that hosts extension content in order to implement message passing
+and event delivery to the extension panel iframes. (Currently, that WebView is
+the same underlying WKWebView for the whole interface, but that is open to change.)
+
+* UIProcess/API/Cocoa/_WKInspectorExtensionHost.h: New property.
+
+* UIProcess/API/Cocoa/_WKInspectorPrivate.h:
+* UIProcess/API/Cocoa/_WKInspector.mm:
+(-[_WKInspector extensionHostWebView]): Added.
+(-[_WKInspector handle]): Deleted.
+
+* UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
+(-[_WKRemoteWebInspectorViewController extensionHostWebView]): Added.
+(-[_WKRemoteWebInspectorViewController handle]): Deleted.
+
+* Shared/API/Cocoa/WKBrowsingContextHandle.mm:
+(-[WKBrowsingContextHandle description]):
+Drive-by, add the standard -description for debugging purposes.
+
2021-02-24 Alex Christensen
Add stubs to enable SafariForWebKitDevelopment to launch
Modified: trunk/Source/WebKit/Shared/API/Cocoa/WKBrowsingContextHandle.mm (273470 => 273471)
--- trunk/Source/WebKit/Shared/API/Cocoa/WKBrowsingContextHandle.mm 2021-02-25 05:59:46 UTC (rev 273470)
+++ trunk/Source/WebKit/Shared/API/Cocoa/WKBrowsingContextHandle.mm 2021-02-25 06:10:40 UTC (rev 273471)
@@ -93,4 +93,9 @@
return [[WKBrowsingContextHandle allocWithZone:zone] _initWithPageProxyID:_pageProxyID andWebPageID:_webPageID];
}
+- (NSString *)description
+{
+return [NSString stringWithFormat:@"<%@: %p; pageProxyID = %llu; webPageID = %llu>", NSStringFromClass(self.class), self, _pageProxyID.toUInt64(), _webPageID.toUInt64()];
+}
+
@end
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm (273470 => 273471)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm 2021-02-25 05:59:46 UTC (rev 273470)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm 2021-02-25 06:10:40 UTC (rev 273471)
@@ -33,6 +33,7 @@
#import "WebProcessProxy.h"
#import "_WKFrameHandleInternal.h"
#import "_WKInspectorPrivateForTesting.h"
+#import "_WKRemoteObjectRegistry.h"
#import
#import
#import
@@ -169,11 +170,6 @@
_inspector->setDiagnosticLoggingAvailable(!!delegate);
}
-- (WKBrowsingContextHandle *)handle
-{
-return self.inspectorWebView._handle;
-}
-
// MARK: _WKInspectorInternal methods
- (API::Object&)_apiObject
@@ -183,6 +179,11 @@
// MARK: _WKInspectorExtensionHost methods
+- (WKWebView *)extensionHostWebView
+{
+return self.inspectorWebView;
+}
+
- (void)registerExtensionWithID:(NSString *)extensionID displayName:(NSString *)displayName completionHandler:(void(^)(NSError *, _WKInspectorExtension *))completionHandler
{
#if ENABLE(INSPECTOR_EXTENSIONS)
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionHost.h (273470 => 273471)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionHost.h
[webkit-changes] [273470] trunk
Title: [273470] trunk
Revision 273470
Author commit-qu...@webkit.org
Date 2021-02-24 21:59:46 -0800 (Wed, 24 Feb 2021)
Log Message
[css-grid] Do not allow negative heights
https://bugs.webkit.org/show_bug.cgi?id=221439
Patch by Rob Buis on 2021-02-24
Reviewed by Darin Adler.
Source/WebCore:
Do not allow negative heights in calculations, instead
use Optional to indicate that the heights are not existing.
Test: fast/css-grid-layout/zero-height-crash.html
* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::DefiniteSizeStrategy::minLogicalSizeForChild const):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::replacedMinMaxLogicalHeightComputesAsNone const):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::gridGap const):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
LayoutTests:
Add test for this.
* fast/css-grid-layout/zero-height-crash-expected.txt: Added.
* fast/css-grid-layout/zero-height-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderGrid.cpp
Added Paths
trunk/LayoutTests/fast/css-grid-layout/zero-height-crash-expected.txt
trunk/LayoutTests/fast/css-grid-layout/zero-height-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (273469 => 273470)
--- trunk/LayoutTests/ChangeLog 2021-02-25 04:57:48 UTC (rev 273469)
+++ trunk/LayoutTests/ChangeLog 2021-02-25 05:59:46 UTC (rev 273470)
@@ -1,3 +1,15 @@
+2021-02-24 Rob Buis
+
+[css-grid] Do not allow negative heights
+https://bugs.webkit.org/show_bug.cgi?id=221439
+
+Reviewed by Darin Adler.
+
+Add test for this.
+
+* fast/css-grid-layout/zero-height-crash-expected.txt: Added.
+* fast/css-grid-layout/zero-height-crash.html: Added.
+
2021-02-24 Imanol Fernandez
Set xrCompatible in WebGLRenderingContextBase::getContextAttributes
Added: trunk/LayoutTests/fast/css-grid-layout/zero-height-crash-expected.txt (0 => 273470)
--- trunk/LayoutTests/fast/css-grid-layout/zero-height-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/zero-height-crash-expected.txt 2021-02-25 05:59:46 UTC (rev 273470)
@@ -0,0 +1 @@
+This test has PASSED if it does not CRASH.
Added: trunk/LayoutTests/fast/css-grid-layout/zero-height-crash.html (0 => 273470)
--- trunk/LayoutTests/fast/css-grid-layout/zero-height-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/zero-height-crash.html 2021-02-25 05:59:46 UTC (rev 273470)
@@ -0,0 +1,14 @@
+
+ body, p {
+display: grid;
+grid-gap: 100%;
+grid-template-rows: 0 0 0 repeat(auto-fit, 0);
+margin-top: 100px;
+min-height: fit-content;
+ }
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+This test has PASSED if it does not CRASH.
Modified: trunk/Source/WebCore/ChangeLog (273469 => 273470)
--- trunk/Source/WebCore/ChangeLog 2021-02-25 04:57:48 UTC (rev 273469)
+++ trunk/Source/WebCore/ChangeLog 2021-02-25 05:59:46 UTC (rev 273470)
@@ -1,3 +1,25 @@
+2021-02-24 Rob Buis
+
+[css-grid] Do not allow negative heights
+https://bugs.webkit.org/show_bug.cgi?id=221439
+
+Reviewed by Darin Adler.
+
+Do not allow negative heights in calculations, instead
+use Optional to indicate that the heights are not existing.
+
+Test: fast/css-grid-layout/zero-height-crash.html
+
+* rendering/GridTrackSizingAlgorithm.cpp:
+(WebCore::DefiniteSizeStrategy::minLogicalSizeForChild const):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::replacedMinMaxLogicalHeightComputesAsNone const):
+* rendering/RenderGrid.cpp:
+(WebCore::RenderGrid::layoutBlock):
+(WebCore::RenderGrid::gridGap const):
+(WebCore::RenderGrid::placeItemsOnGrid const):
+(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
+
2021-02-24 Julian Gonzalez
Crash in CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph()
Modified: trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp (273469 => 273470)
--- trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp 2021-02-25 04:57:48 UTC (rev 273469)
+++ trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp 2021-02-25 05:59:46 UTC (rev 273470)
@@ -1052,10 +1052,13 @@
LayoutUnit DefiniteSizeStrategy::minLogicalSizeForChild(RenderBox& child, const Length& childMinSize, LayoutUnit availableSize) const
{
GridTrackSizingDirection childInlineDirection = GridLayoutFunctions::flowAwareDirectionForChild(*renderGrid(), child, ForColumns);
-LayoutUnit indefiniteSize = direction() == childInlineDirection ? LayoutUnit() : LayoutUnit(-1);
GridTrackSizingDirection flowAwareDirection =
[webkit-changes] [273469] trunk/Source
Title: [273469] trunk/Source
Revision 273469
Author achristen...@apple.com
Date 2021-02-24 20:57:48 -0800 (Wed, 24 Feb 2021)
Log Message
Add stubs to enable SafariForWebKitDevelopment to launch
https://bugs.webkit.org/show_bug.cgi?id=222388
Reviewed by Myles Maxfield.
Source/_javascript_Core:
* _javascript_Core.xcodeproj/project.pbxproj:
* runtime/SymbolStubsForSafariCompatibility.mm: Added.
(WTF::String::String):
(WTF::JSONImpl::ObjectBase::getArray const):
(WTF::JSONImpl::ObjectBase::getValue const):
(WTF::JSONImpl::ObjectBase::getObject const):
(Inspector::BackendDispatcher::sendResponse):
Source/WebKit:
I manually verified that before this change, DYLD won't let it launch or it calls a missing selector,
but after this change it launches and loads web pages.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _inspectorDelegate]):
(-[WKWebView _setInspectorDelegate:]):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
Added Paths
trunk/Source/_javascript_Core/runtime/SymbolStubsForSafariCompatibility.mm
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (273468 => 273469)
--- trunk/Source/_javascript_Core/ChangeLog 2021-02-25 03:34:53 UTC (rev 273468)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-02-25 04:57:48 UTC (rev 273469)
@@ -1,3 +1,18 @@
+2021-02-24 Alex Christensen
+
+Add stubs to enable SafariForWebKitDevelopment to launch
+https://bugs.webkit.org/show_bug.cgi?id=222388
+
+Reviewed by Myles Maxfield.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* runtime/SymbolStubsForSafariCompatibility.mm: Added.
+(WTF::String::String):
+(WTF::JSONImpl::ObjectBase::getArray const):
+(WTF::JSONImpl::ObjectBase::getValue const):
+(WTF::JSONImpl::ObjectBase::getObject const):
+(Inspector::BackendDispatcher::sendResponse):
+
2021-02-24 Ryan Haddad
Unreviewed, reverting r273373.
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (273468 => 273469)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2021-02-25 03:34:53 UTC (rev 273468)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2021-02-25 04:57:48 UTC (rev 273469)
@@ -1792,6 +1792,7 @@
DCFDFBDA1D1F5D9E00FE3D72 /* B3TypeMap.h in Headers */ = {isa = PBXBuildFile; fileRef = DCFDFBD81D1F5D9800FE3D72 /* B3TypeMap.h */; };
DE26E9031CB5DD0500D2BE82 /* BuiltinExecutableCreator.h in Headers */ = {isa = PBXBuildFile; fileRef = DE26E9021CB5DD0500D2BE82 /* BuiltinExecutableCreator.h */; };
DEA7E2451BBC677F00D78440 /* JSTypedArrayViewPrototype.h in Headers */ = {isa = PBXBuildFile; fileRef = 53917E7C1B791106000EBD33 /* JSTypedArrayViewPrototype.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ DFBC2CA625E6D5B90081BDD1 /* SymbolStubsForSafariCompatibility.mm in Sources */ = {isa = PBXBuildFile; fileRef = DFBC2CA525E6D5790081BDD1 /* SymbolStubsForSafariCompatibility.mm */; };
E124A8F70E555775003091F1 /* OpaqueJSString.h in Headers */ = {isa = PBXBuildFile; fileRef = E124A8F50E555775003091F1 /* OpaqueJSString.h */; settings = {ATTRIBUTES = (Private, ); }; };
E307178324C7827100DF0644 /* IntlRelativeTimeFormat.h in Headers */ = {isa = PBXBuildFile; fileRef = A3BF885024480BE1001B9F35 /* IntlRelativeTimeFormat.h */; };
E307178424C7827700DF0644 /* IntlRelativeTimeFormatConstructor.h in Headers */ = {isa = PBXBuildFile; fileRef = A3BF884E24480BE0001B9F35 /* IntlRelativeTimeFormatConstructor.h */; };
@@ -4999,6 +5000,7 @@
DE26E9021CB5DD0500D2BE82 /* BuiltinExecutableCreator.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BuiltinExecutableCreator.h; sourceTree = ""; };
DE26E9061CB5DD9600D2BE82 /* BuiltinExecutableCreator.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = BuiltinExecutableCreator.cpp; sourceTree = ""; };
DE5A09FF1BA3AC3E003D4424 /* IntrinsicEmitter.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = IntrinsicEmitter.cpp; sourceTree = ""; };
+ DFBC2CA525E6D5790081BDD1 /* SymbolStubsForSafariCompatibility.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = SymbolStubsForSafariCompatibility.mm; sourceTree = ""; };
E124A8F50E555775003091F1 /* OpaqueJSString.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OpaqueJSString.h; sourceTree = ""; };
E124A8F60E555775003091F1 /* OpaqueJSString.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = OpaqueJSString.cpp; sourceTree = ""; };
E178633F0D9BECD74E75 /* InitializeThreading.h */ = {isa = PBXFileReference; fileEncoding = 4;
[webkit-changes] [273468] trunk/Source/WebCore
Title: [273468] trunk/Source/WebCore Revision 273468 Author commit-qu...@webkit.org Date 2021-02-24 19:34:53 -0800 (Wed, 24 Feb 2021) Log Message Crash in CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph() https://bugs.webkit.org/show_bug.cgi?id=222339 Patch by Julian Gonzalez on 2021-02-24 Reviewed by Ryosuke Niwa. Make a copy of Ref when inserting before highest blockquote node. * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/CompositeEditCommand.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (273467 => 273468) --- trunk/Source/WebCore/ChangeLog 2021-02-25 02:43:19 UTC (rev 273467) +++ trunk/Source/WebCore/ChangeLog 2021-02-25 03:34:53 UTC (rev 273468) @@ -1,3 +1,15 @@ +2021-02-24 Julian Gonzalez + +Crash in CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph() +https://bugs.webkit.org/show_bug.cgi?id=222339 + +Reviewed by Ryosuke Niwa. + +Make a copy of Ref when inserting before highest blockquote node. + +* editing/CompositeEditCommand.cpp: +(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): + 2021-02-24 Imanol Fernandez Set xrCompatible in WebGLRenderingContextBase::getContextAttributes Modified: trunk/Source/WebCore/editing/CompositeEditCommand.cpp (273467 => 273468) --- trunk/Source/WebCore/editing/CompositeEditCommand.cpp 2021-02-25 02:43:19 UTC (rev 273467) +++ trunk/Source/WebCore/editing/CompositeEditCommand.cpp 2021-02-25 03:34:53 UTC (rev 273468) @@ -1602,7 +1602,7 @@ auto* brPtr = br.ptr(); // We want to replace this quoted paragraph with an unquoted one, so insert a br // to hold the caret before the highest blockquote. -insertNodeBefore(WTFMove(br), *highestBlockquote); +insertNodeBefore(br.copyRef(), *highestBlockquote); VisiblePosition atBR(positionBeforeNode(brPtr)); // If the br we inserted collapsed, for example foo..., insert // a second one. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273467] trunk
Title: [273467] trunk Revision 273467 Author commit-qu...@webkit.org Date 2021-02-24 18:43:19 -0800 (Wed, 24 Feb 2021) Log Message Set xrCompatible in WebGLRenderingContextBase::getContextAttributes https://bugs.webkit.org/show_bug.cgi?id=222360 Patch by Imanol Fernandez on 2021-02-24 Reviewed by Sam Weinig. LayoutTests/imported/w3c: Update WebXR xrCompatible attribute test expectations. * web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt: Added. Source/WebCore: Fixes xrCompatibe false value in WebGLRenderingContextBase::getContextAttributes() after WebGLRenderingContextBase::makeXRCompatible call succeeds. Test: webGLCanvasContext_create_xrcompatible.https.html * html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::getContextAttributes): LayoutTests: Update WebXR xrCompatible attribute test expectations. * platform/wpe/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/platform/wpe/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (273466 => 273467) --- trunk/LayoutTests/ChangeLog 2021-02-25 02:32:04 UTC (rev 273466) +++ trunk/LayoutTests/ChangeLog 2021-02-25 02:43:19 UTC (rev 273467) @@ -1,3 +1,14 @@ +2021-02-24 Imanol Fernandez + +Set xrCompatible in WebGLRenderingContextBase::getContextAttributes +https://bugs.webkit.org/show_bug.cgi?id=222360 + +Reviewed by Sam Weinig. + +Update WebXR xrCompatible attribute test expectations. + +* platform/wpe/TestExpectations: + 2021-02-24 Jean-Yves Avenard [MSE] Media segment is incorrectly dropped when using negative timestampOffset or when source buffer appendWindow is set. Modified: trunk/LayoutTests/imported/w3c/ChangeLog (273466 => 273467) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-25 02:32:04 UTC (rev 273466) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-25 02:43:19 UTC (rev 273467) @@ -1,3 +1,14 @@ +2021-02-24 Imanol Fernandez + +Set xrCompatible in WebGLRenderingContextBase::getContextAttributes +https://bugs.webkit.org/show_bug.cgi?id=222360 + +Reviewed by Sam Weinig. + +Update WebXR xrCompatible attribute test expectations. + +* web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt: Added. + 2021-02-24 Ziran Sun [css-grid] Fix min/max widths of grid affected by ancestor Added: trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt (0 => 273467) --- trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt 2021-02-25 02:43:19 UTC (rev 273467) @@ -0,0 +1,4 @@ + +PASS Verify promise from a non-reentrant to makeXRCompatible() is resolved +PASS Verify promises from reentrant calls to makeXRCompatible() are resolved + Modified: trunk/LayoutTests/platform/wpe/TestExpectations (273466 => 273467) --- trunk/LayoutTests/platform/wpe/TestExpectations 2021-02-25 02:32:04 UTC (rev 273466) +++ trunk/LayoutTests/platform/wpe/TestExpectations 2021-02-25 02:43:19 UTC (rev 273467) @@ -628,7 +628,9 @@ # WebXR webkit.org/b/212897 imported/w3c/web-platform-tests/webxr/idlharness.https.window.html [ Failure ] +webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https.html [ Pass ] webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https.html [ Pass ] +webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https.html [ Pass ] webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_inline.https.html [ Pass ] webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_immersive.https.html [ Pass ] webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_immersive_unsupported.https.html [ Pass ] Modified: trunk/Source/WebCore/ChangeLog (273466 => 273467) --- trunk/Source/WebCore/ChangeLog 2021-02-25 02:32:04 UTC (rev 273466) +++ trunk/Source/WebCore/ChangeLog 2021-02-25 02:43:19 UTC (rev 273467) @@ -1,3 +1,18 @@ +2021-02-24 Imanol Fernandez + +Set xrCompatible in WebGLRenderingContextBase::getContextAttributes +https://bugs.webkit.org/show_bug.cgi?id=222360 + +Reviewed by Sam Weinig. + +Fixes xrCompatibe false value in WebGLRenderingContextBase::getContextAttributes() +
[webkit-changes] [273466] releases/Apple/Safari Technology Preview/ Safari Technology Preview 121/
Title: [273466] releases/Apple/Safari Technology Preview/Safari Technology Preview 121/ Revision 273466 Author repst...@apple.com Date 2021-02-24 18:32:04 -0800 (Wed, 24 Feb 2021) Log Message Added a tag for Safari Technology Preview release 121. Added Paths releases/Apple/Safari Technology Preview/Safari Technology Preview 121/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273465] trunk
Title: [273465] trunk Revision 273465 Author katherine_che...@apple.com Date 2021-02-24 17:45:50 -0800 (Wed, 24 Feb 2021) Log Message App-bound request parameter should be passed to main resource requests not the main frame https://bugs.webkit.org/show_bug.cgi?id=41 Reviewed by Chris Dumez. Source/WebKit: Bug fix to set the isAppBound parameter on the resource request if it is not on the main frame. Previously this only checked if the resource was not a main resource before setting the parameter. Otherwise mostly changes to add better testing. * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::appBoundNavigationData): (WebKit::NetworkProcess::clearAppBoundNavigationData): * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkProcess.messages.in: * NetworkProcess/NetworkSession.h: (WebKit::NetworkSession::appBoundNavigationTestingData): * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): * Scripts/webkit/messages.py: * Shared/NavigatingToAppBoundDomain.h: (WebKit::AppBoundNavigationTestingData::clearAppBoundNavigationDataTesting): (WebKit::AppBoundNavigationTestingData::updateAppBoundNavigationTestingData): (WebKit::AppBoundNavigationTestingData::encode const): (WebKit::AppBoundNavigationTestingData::decode): Struct to return data for tests. * UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h: * UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _appBoundNavigationData:]): (-[WKWebView _clearAppBoundNavigationData:]): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::appBoundNavigationData): (WebKit::WebPageProxy::clearAppBoundNavigationData): * UIProcess/WebPageProxy.h: * WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::loadResource): The fix. Tools: Adds more robust testing to report when appBound/nonAppBound requests load in the network process. This tests not only that the main frame’s document loader is properly set, but also that all loads initiated from app-bound requests are also app-bound to avoid regressions like this in the future. * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Utilize some CSP test resources that have the exact setup needed to test this fix. * TestWebKitAPI/cocoa/TestWKWebView.h: * TestWebKitAPI/cocoa/TestWKWebView.mm: (-[WKWebView appBoundNavigationData:]): (-[WKWebView clearAppBoundNavigationReports:]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp trunk/Source/WebKit/NetworkProcess/NetworkProcess.h trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in trunk/Source/WebKit/NetworkProcess/NetworkSession.h trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm trunk/Source/WebKit/Scripts/webkit/messages.py trunk/Source/WebKit/Shared/NavigatingToAppBoundDomain.h trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm Diff Modified: trunk/Source/WebKit/ChangeLog (273464 => 273465) --- trunk/Source/WebKit/ChangeLog 2021-02-25 01:18:07 UTC (rev 273464) +++ trunk/Source/WebKit/ChangeLog 2021-02-25 01:45:50 UTC (rev 273465) @@ -1,3 +1,46 @@ +2021-02-24 Kate Cheney + +App-bound request parameter should be passed to main resource requests not the main frame +https://bugs.webkit.org/show_bug.cgi?id=41 + + +Reviewed by Chris Dumez. + +Bug fix to set the isAppBound parameter on the resource request if it +is not on the main frame. Previously this only checked if the +resource was not a main resource before setting the parameter. + +Otherwise mostly changes to add better testing. + +* NetworkProcess/NetworkProcess.cpp: +(WebKit::NetworkProcess::appBoundNavigationData): +(WebKit::NetworkProcess::clearAppBoundNavigationData): +* NetworkProcess/NetworkProcess.h: +* NetworkProcess/NetworkProcess.messages.in: +* NetworkProcess/NetworkSession.h: +(WebKit::NetworkSession::appBoundNavigationTestingData): +* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: +(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): +* Scripts/webkit/messages.py: +* Shared/NavigatingToAppBoundDomain.h: +(WebKit::AppBoundNavigationTestingData::clearAppBoundNavigationDataTesting): +(WebKit::AppBoundNavigationTestingData::updateAppBoundNavigationTestingData): +(WebKit::AppBoundNavigationTestingData::encode const): +(WebKit::AppBoundNavigationTestingData::decode): +Struct to return data for tests. + +*
[webkit-changes] [273464] trunk/Source/WebKit
Title: [273464] trunk/Source/WebKit
Revision 273464
Author peng.l...@apple.com
Date 2021-02-24 17:18:07 -0800 (Wed, 24 Feb 2021)
Log Message
[GPUP] Refactor RemoteImageDecoderAVF::createFrameImageAtIndex()
https://bugs.webkit.org/show_bug.cgi?id=222300
Reviewed by Jer Noble.
Use callOnMainThreadAndWait() instead of callOnMainThread() and remove the semaphore.
No new tests, this has no behavior change.
* GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in:
* WebProcess/GPU/media/RemoteImageDecoderAVF.cpp:
(WebKit::RemoteImageDecoderAVF::createFrameImageAtIndex):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in
trunk/Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVF.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (273463 => 273464)
--- trunk/Source/WebKit/ChangeLog 2021-02-25 01:18:01 UTC (rev 273463)
+++ trunk/Source/WebKit/ChangeLog 2021-02-25 01:18:07 UTC (rev 273464)
@@ -1,3 +1,18 @@
+2021-02-24 Peng Liu
+
+[GPUP] Refactor RemoteImageDecoderAVF::createFrameImageAtIndex()
+https://bugs.webkit.org/show_bug.cgi?id=222300
+
+Reviewed by Jer Noble.
+
+Use callOnMainThreadAndWait() instead of callOnMainThread() and remove the semaphore.
+
+No new tests, this has no behavior change.
+
+* GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in:
+* WebProcess/GPU/media/RemoteImageDecoderAVF.cpp:
+(WebKit::RemoteImageDecoderAVF::createFrameImageAtIndex):
+
2021-02-24 Chris Dumez
Unreviewed, fix build with the latest iOS SDK.
Modified: trunk/Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in (273463 => 273464)
--- trunk/Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in 2021-02-25 01:18:01 UTC (rev 273463)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in 2021-02-25 01:18:07 UTC (rev 273464)
@@ -32,7 +32,7 @@
DeleteDecoder(WebCore::ImageDecoderIdentifier identifier)
SetExpectedContentSize(WebCore::ImageDecoderIdentifier identifier, long long expectedContentSize)
SetData(WebCore::ImageDecoderIdentifier identifier, IPC::SharedBufferDataReference data, bool allDataReceived) -> (uint32_t frameCount, WebCore::IntSize size, bool hasTrack, Optional> frameInfos) Synchronous
-CreateFrameImageAtIndex(WebCore::ImageDecoderIdentifier identifier, uint32_t index) -> (Optional sendRight) Async
+CreateFrameImageAtIndex(WebCore::ImageDecoderIdentifier identifier, uint32_t index) -> (Optional sendRight) Synchronous
}
#endif
Modified: trunk/Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVF.cpp (273463 => 273464)
--- trunk/Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVF.cpp 2021-02-25 01:18:01 UTC (rev 273463)
+++ trunk/Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVF.cpp 2021-02-25 01:18:07 UTC (rev 273464)
@@ -40,7 +40,6 @@
#include
#include
#include
-#include
namespace WebKit {
@@ -171,32 +170,22 @@
if (isMainThread())
return nullptr;
-BinarySemaphore decodeSemaphore;
-callOnMainThread([this, protectedThis = makeRef(*this), index, ] {
-gpuProcessConnection().connection().sendWithAsyncReply(Messages::RemoteImageDecoderAVFProxy::CreateFrameImageAtIndex(m_identifier, index), [&](auto&& sendRight) {
-if (!sendRight) {
-decodeSemaphore.signal();
-return;
-}
+callOnMainThreadAndWait([this, protectedThis = makeRef(*this), index] {
+Optional sendRight;
+if (!gpuProcessConnection().connection().sendSync(Messages::RemoteImageDecoderAVFProxy::CreateFrameImageAtIndex(m_identifier, index), Messages::RemoteImageDecoderAVFProxy::CreateFrameImageAtIndex::Reply(sendRight), 0))
+return;
-auto surface = WebCore::IOSurface::createFromSendRight(WTFMove(*sendRight), sRGBColorSpaceRef());
-if (!surface) {
-decodeSemaphore.signal();
-return;
-}
+if (!sendRight)
+return;
-auto image = IOSurface::sinkIntoImage(WTFMove(surface));
-if (!image) {
-decodeSemaphore.signal();
-return;
-}
+auto surface = WebCore::IOSurface::createFromSendRight(WTFMove(*sendRight), sRGBColorSpaceRef());
+if (!surface)
+return;
+if (auto image = IOSurface::sinkIntoImage(WTFMove(surface)))
m_frameImages.add(index, image);
-decodeSemaphore.signal();
-});
});
-decodeSemaphore.wait();
if (m_frameImages.contains(index))
return m_frameImages.get(index);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273463] trunk
Title: [273463] trunk Revision 273463 Author rn...@webkit.org Date 2021-02-24 17:18:01 -0800 (Wed, 24 Feb 2021) Log Message Fix typo in Introduction.md. https://bugs.webkit.org/show_bug.cgi?id=222387 Patch by Cameron McCormack on 2021-02-24 Reviewed by Ryosuke Niwa. * Introduction.md: Modified Paths trunk/ChangeLog trunk/Introduction.md Diff Modified: trunk/ChangeLog (273462 => 273463) --- trunk/ChangeLog 2021-02-25 01:04:09 UTC (rev 273462) +++ trunk/ChangeLog 2021-02-25 01:18:01 UTC (rev 273463) @@ -1,3 +1,12 @@ +2021-02-24 Cameron McCormack + +Fix typo in Introduction.md. +https://bugs.webkit.org/show_bug.cgi?id=222387 + +Reviewed by Ryosuke Niwa. + +* Introduction.md: + 2021-02-23 Don Olmstead [CMake] Fix JSCOnly build on Windows Modified: trunk/Introduction.md (273462 => 273463) --- trunk/Introduction.md 2021-02-25 01:04:09 UTC (rev 273462) +++ trunk/Introduction.md 2021-02-25 01:18:01 UTC (rev 273463) @@ -52,7 +52,7 @@ There are three different kinds of contributors in the WebKit project. - * Contributor - This category emcompasses everyone. Anyone who files a bug or contributes a code change or reviews a code change is considered as a contributor + * Contributor - This category encompasses everyone. Anyone who files a bug or contributes a code change or reviews a code change is considered as a contributor * Committer - A committer is someone who has write access to [WebKit's subversion repository](https://svn.webkit.org/repository/webkit/). * Reviewer - A reviewer is someone who has the right to review and approve code changes other contributors proposed. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273462] trunk/Source
Title: [273462] trunk/Source Revision 273462 Author da...@apple.com Date 2021-02-24 17:04:09 -0800 (Wed, 24 Feb 2021) Log Message [iOS] Reduce use of retain/release in WAKWindow and remove unneeded methods from that class https://bugs.webkit.org/show_bug.cgi?id=222330 Reviewed by Chris Dumez. Source/WebCore: * platform/ios/LegacyTileCache.h: Use pragma once, remove unneeded includes, tweak coding style a bit to match WebKit standard. Removed hasPendingDraw. added WEBCORE_EXPORT to setTileBordersVisible and setTilePaintCountersVisible so they can be used in WebKitLegacy. * platform/ios/LegacyTileCache.mm: (WebCore::LegacyTileCache::hasPendingDraw const): Deleted. * platform/ios/wak/WAKWindow.h: Use pragma once, remove unneeded includes, tweak coding style a bit to match WebKit standard. Removed hasPendingDraw, setTileControllerShouldUseLowScaleTiles, setTileBordersVisible, setTilePaintCountsVisible, setAcceleratedDrawingEnabled, freezeVisibleRect, and unfreezeVisibleRect. * platform/ios/wak/WAKWindow.mm: Removed "using namespace WebCore". Removed unused _WAKKeyWindow global. Converted currentEvent and gOrientationProvider globals to NeverDestroyed>. (orientationProvider): Added (currentEvent): Added. (-[WAKWindow isKeyWindow]): Remove dead code; this method already always returns YES. (-[WAKWindow makeKeyWindow]): Remove dead code. This method wrote to a global that was never read anywhere. (-[WAKWindow sendEventSynchronously:]): Use the currentEvent function and take advantage of the fact that it's a RetainPtr so we don't need a a local variable named currentEventProtector. (-[WAKWindow hasPendingDraw]): Deleted. No callers depend on this. (-[WAKWindow willRotate]): Set _frozenVisibleRect here directly instead of calling anoether method to do that. (-[WAKWindow didRotate]): Ditto. (-[WAKWindow freezeVisibleRect]): Deleted. The method above was the only caller for this method. (-[WAKWindow unfreezeVisibleRect]): Ditto. (+[WAKWindow setOrientationProvider:]): Use the orientationProvider function. Note, this now retains the passed-in object. This is safe; the only caller passes in a class, so there's no risk of a retain cycle. (+[WAKWindow hasLandscapeOrientation]): Use the orientationProvider function. (-[WAKWindow setTileBordersVisible:]): Deleted. The only caller for this was in WebKitLegacy, and refactored to use the tile cache directly. (-[WAKWindow setTilePaintCountsVisible:]): Ditto. (-[WAKWindow setAcceleratedDrawingEnabled:]): Ditto. (-[WAKWindow setTileControllerShouldUseLowScaleTiles:]): Deleted. No callers depend on this. (+[WAKWindow currentEvent]): Use the currentEvent function. Source/WebKitLegacy/mac: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Call LegacyTileCache functions directly rather than indirecting through WAKWindow methods. (-[WebView viewDidMoveToWindow]): Ditto. Also tweaked conditionals a little for clarity. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ios/LegacyTileCache.h trunk/Source/WebCore/platform/ios/LegacyTileCache.mm trunk/Source/WebCore/platform/ios/wak/WAKWindow.h trunk/Source/WebCore/platform/ios/wak/WAKWindow.mm trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebView/WebView.mm Diff Modified: trunk/Source/WebCore/ChangeLog (273461 => 273462) --- trunk/Source/WebCore/ChangeLog 2021-02-25 00:57:53 UTC (rev 273461) +++ trunk/Source/WebCore/ChangeLog 2021-02-25 01:04:09 UTC (rev 273462) @@ -1,3 +1,55 @@ +2021-02-23 Darin Adler + +[iOS] Reduce use of retain/release in WAKWindow and remove unneeded methods from that class +https://bugs.webkit.org/show_bug.cgi?id=222330 + +Reviewed by Chris Dumez. + +* platform/ios/LegacyTileCache.h: Use pragma once, remove unneeded includes, +tweak coding style a bit to match WebKit standard. Removed hasPendingDraw. +added WEBCORE_EXPORT to setTileBordersVisible and setTilePaintCountersVisible +so they can be used in WebKitLegacy. + +* platform/ios/LegacyTileCache.mm: +(WebCore::LegacyTileCache::hasPendingDraw const): Deleted. + +* platform/ios/wak/WAKWindow.h: Use pragma once, remove unneeded includes, +tweak coding style a bit to match WebKit standard. Removed hasPendingDraw, +setTileControllerShouldUseLowScaleTiles, setTileBordersVisible, +setTilePaintCountsVisible, setAcceleratedDrawingEnabled, freezeVisibleRect, +and unfreezeVisibleRect. + +* platform/ios/wak/WAKWindow.mm: Removed "using namespace WebCore". +Removed unused _WAKKeyWindow global. Converted currentEvent and +gOrientationProvider globals to NeverDestroyed>. +(orientationProvider): Added +(currentEvent): Added. +(-[WAKWindow isKeyWindow]): Remove dead code; this method already always +returns YES. +(-[WAKWindow makeKeyWindow]): Remove dead code. This method wrote to a +global that was never read
[webkit-changes] [273461] trunk
Title: [273461] trunk Revision 273461 Author commit-qu...@webkit.org Date 2021-02-24 16:57:53 -0800 (Wed, 24 Feb 2021) Log Message [MSE] Media segment is incorrectly dropped when using negative timestampOffset or when source buffer appendWindow is set. https://bugs.webkit.org/show_bug.cgi?id=60 Patch by Jean-Yves Avenard on 2021-02-24 Reviewed by Eric Carlson. Source/WebCore: Test: media/media-source/media-source-timestampoffset-trim.html CoreMedia packs multiple audio frames together into a single CMSampleBuffer, this allows for faster processing and easier insertion into the track buffer tree. However, per mediasoure spec [1], a frame is to be dropped according to its start time and duration. So if only the beginning of the MediaSample was to be dropped, we would have incorrectly dropped the lot. We now split the MediaSample if it is going to be dropped to ensure that all usable content is inserted into the track buffer. Audio splicing isn't done yet, but this gets us closer to it. [1] https://w3c.github.io/media-source/#sourcebuffer-coded-frame-processing * platform/graphics/SourceBufferPrivate.cpp: (WebCore::SourceBufferPrivate::didReceiveSample): * platform/graphics/SourceBufferPrivate.h: * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::didParseInitializationData): (WebCore::SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackId): * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp: (WebCore::SourceBufferPrivateGStreamer::didReceiveSample): * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h: LayoutTests: * media/media-source/media-source-timestampoffset-trim.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/SourceBufferPrivate.cpp trunk/Source/WebCore/platform/graphics/SourceBufferPrivate.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h Added Paths trunk/LayoutTests/media/media-source/media-source-timestampoffset-trim-expected.txt trunk/LayoutTests/media/media-source/media-source-timestampoffset-trim.html Diff Modified: trunk/LayoutTests/ChangeLog (273460 => 273461) --- trunk/LayoutTests/ChangeLog 2021-02-25 00:40:00 UTC (rev 273460) +++ trunk/LayoutTests/ChangeLog 2021-02-25 00:57:53 UTC (rev 273461) @@ -1,3 +1,12 @@ +2021-02-24 Jean-Yves Avenard + +[MSE] Media segment is incorrectly dropped when using negative timestampOffset or when source buffer appendWindow is set. +https://bugs.webkit.org/show_bug.cgi?id=60 + +Reviewed by Eric Carlson. + +* media/media-source/media-source-timestampoffset-trim.html: + 2021-02-24 Chris Dumez Device motion / orientation events not working in third-party iframes despite Feature-Policy allowing it Added: trunk/LayoutTests/media/media-source/media-source-timestampoffset-trim-expected.txt (0 => 273461) --- trunk/LayoutTests/media/media-source/media-source-timestampoffset-trim-expected.txt (rev 0) +++ trunk/LayoutTests/media/media-source/media-source-timestampoffset-trim-expected.txt 2021-02-25 00:57:53 UTC (rev 273461) @@ -0,0 +1,40 @@ +This tests that audio samples outside the appendWindow's interval are properly ignored. + +RUN(video.src = "" +EVENT(sourceopen) +RUN(sourceBuffer = source.addSourceBuffer(loader.type())) +RUN(sourceBuffer.appendBuffer(loader.initSegment())) +EVENT(update) +RUN(sourceBuffer.timestampOffset = -(framesToBeDroppedBeginning * framesInAACPacket) / sampleRate) +Append a media segment negative offset. +RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0))) +EVENT(update) +EXPECTED (sourceBuffer.buffered.length == '1') OK +EXPECTED (sourceBuffer.buffered.start(0) == '0') OK +EXPECTED (sourceBuffer.buffered.end(0) == '0.896') OK +RUN(sourceBuffer.remove(0, Infinity)) +EVENT(update) +RUN(sourceBuffer.timestampOffset = 0) +RUN(sourceBuffer.appendWindowStart = 0) +RUN(sourceBuffer.appendWindowEnd = Infinity) +RUN(sourceBuffer.appendWindowStart = (framesToBeDroppedBeginning * framesInAACPacket) / sampleRate) +Append a media segment with appendWindowStart set. +RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0))) +EVENT(update) +EXPECTED (sourceBuffer.buffered.length == '1') OK +EXPECTED (sourceBuffer.buffered.start(0) == '0.10667') OK +EXPECTED (sourceBuffer.buffered.end(0) == '1.0026') OK +RUN(sourceBuffer.remove(0, Infinity)) +EVENT(update) +RUN(sourceBuffer.timestampOffset = 0) +RUN(sourceBuffer.appendWindowStart = 0) +RUN(sourceBuffer.appendWindowEnd = Infinity) +RUN(sourceBuffer.appendWindowEnd = ((totalFramesInSegment - framesToBeDroppedEnd) * framesInAACPacket) / sampleRate) +Append a media segment with appendWindowEnd set.
[webkit-changes] [273460] branches/safari-611-branch/Source/WebKit
Title: [273460] branches/safari-611-branch/Source/WebKit Revision 273460 Author alanc...@apple.com Date 2021-02-24 16:40:00 -0800 (Wed, 24 Feb 2021) Log Message Cherry-pick r272935. rdar://problem/74500849 REGRESSION(r266890): [Cocoa] Fix InspectorDelegate / API::InspectorClient leak https://bugs.webkit.org/show_bug.cgi?id=221988 Reviewed by Devin Rousso. There was a logic error introduced into the new delegate situation after moving _WKInspectorDelegate from WKWebView to _WKInspector. When setting .delegate to nil, we shouldn't allocate dummy API::InspectorClient/ InspectorDelegate instances. As written, these instances form their own retain cycle and cause a leak if Web Inspector has been opened or if WKWebView._inspector is accessed (which lazily creates the delegates). * UIProcess/API/Cocoa/_WKInspector.mm: (-[_WKInspector setDelegate:]): Adopt new constructor and pass in the ObjC delegate. * UIProcess/Inspector/Cocoa/InspectorDelegate.h: * UIProcess/Inspector/Cocoa/InspectorDelegate.mm: (WebKit::InspectorDelegate::InspectorDelegate): (WebKit::InspectorDelegate::createInspectorClient): Deleted. (WebKit::InspectorDelegate::setDelegate): Deleted. Clean up this class so that we always receive the ObjC delegate via the constructor. If a nil delegate is passed---for example, when closing the WKWebView---then don't create an API::InspectorClient and set the WebInspectorProxy's client to nullptr. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272935 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-611-branch/Source/WebKit/ChangeLog branches/safari-611-branch/Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm branches/safari-611-branch/Source/WebKit/UIProcess/Inspector/Cocoa/InspectorDelegate.h branches/safari-611-branch/Source/WebKit/UIProcess/Inspector/Cocoa/InspectorDelegate.mm Diff Modified: branches/safari-611-branch/Source/WebKit/ChangeLog (273459 => 273460) --- branches/safari-611-branch/Source/WebKit/ChangeLog 2021-02-25 00:39:57 UTC (rev 273459) +++ branches/safari-611-branch/Source/WebKit/ChangeLog 2021-02-25 00:40:00 UTC (rev 273460) @@ -1,5 +1,68 @@ 2021-02-24 Russell Epstein +Cherry-pick r272935. rdar://problem/74500849 + +REGRESSION(r266890): [Cocoa] Fix InspectorDelegate / API::InspectorClient leak +https://bugs.webkit.org/show_bug.cgi?id=221988 + + +Reviewed by Devin Rousso. + +There was a logic error introduced into the new delegate situation after +moving _WKInspectorDelegate from WKWebView to _WKInspector. When setting +.delegate to nil, we shouldn't allocate dummy API::InspectorClient/ +InspectorDelegate instances. As written, these instances form their own retain +cycle and cause a leak if Web Inspector has been opened or if +WKWebView._inspector is accessed (which lazily creates the delegates). + +* UIProcess/API/Cocoa/_WKInspector.mm: +(-[_WKInspector setDelegate:]): +Adopt new constructor and pass in the ObjC delegate. + +* UIProcess/Inspector/Cocoa/InspectorDelegate.h: +* UIProcess/Inspector/Cocoa/InspectorDelegate.mm: +(WebKit::InspectorDelegate::InspectorDelegate): +(WebKit::InspectorDelegate::createInspectorClient): Deleted. +(WebKit::InspectorDelegate::setDelegate): Deleted. +Clean up this class so that we always receive the ObjC delegate +via the constructor. If a nil delegate is passed---for example, when +closing the WKWebView---then don't create an API::InspectorClient +and set the WebInspectorProxy's client to nullptr. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272935 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-02-16 BJ Burg + +REGRESSION(r266890): [Cocoa] Fix InspectorDelegate / API::InspectorClient leak +https://bugs.webkit.org/show_bug.cgi?id=221988 + + +Reviewed by Devin Rousso. + +There was a logic error introduced into the new delegate situation after +moving _WKInspectorDelegate from WKWebView to _WKInspector. When setting +.delegate to nil, we shouldn't allocate dummy API::InspectorClient/ +InspectorDelegate instances. As written, these instances form their own retain +cycle and cause a leak if Web Inspector has been opened or if +WKWebView._inspector is accessed (which lazily creates the delegates). + +* UIProcess/API/Cocoa/_WKInspector.mm: +(-[_WKInspector setDelegate:]): +Adopt new constructor and pass in the ObjC delegate. + +* UIProcess/Inspector/Cocoa/InspectorDelegate.h: +* UIProcess/Inspector/Cocoa/InspectorDelegate.mm: +(WebKit::InspectorDelegate::InspectorDelegate): +(WebKit::InspectorDelegate::createInspectorClient): Deleted. +
[webkit-changes] [273457] branches/safari-611-branch
Title: [273457] branches/safari-611-branch
Revision 273457
Author alanc...@apple.com
Date 2021-02-24 16:39:49 -0800 (Wed, 24 Feb 2021)
Log Message
Cherry-pick r272911. rdar://problem/74501076
MediaRecorder.stop() does not work correctly when recording has been paused.
https://bugs.webkit.org/show_bug.cgi?id=221916
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
* web-platform-tests/mediacapture-record/MediaRecorder-pause-resume-expected.txt:
* web-platform-tests/mediacapture-record/MediaRecorder-pause-resume.html:
Source/WebCore:
Proceed with stop steps in case of paused state, and not only in case of recording state.
Covered by added WPT test.
* Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::stopRecordingInternal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-611-branch/LayoutTests/imported/w3c/ChangeLog
branches/safari-611-branch/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-pause-resume-expected.txt
branches/safari-611-branch/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-pause-resume.html
branches/safari-611-branch/Source/WebCore/ChangeLog
branches/safari-611-branch/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp
Diff
Modified: branches/safari-611-branch/LayoutTests/imported/w3c/ChangeLog (273456 => 273457)
--- branches/safari-611-branch/LayoutTests/imported/w3c/ChangeLog 2021-02-25 00:39:45 UTC (rev 273456)
+++ branches/safari-611-branch/LayoutTests/imported/w3c/ChangeLog 2021-02-25 00:39:49 UTC (rev 273457)
@@ -1,3 +1,39 @@
+2021-02-24 Russell Epstein
+
+Cherry-pick r272911. rdar://problem/74501076
+
+MediaRecorder.stop() does not work correctly when recording has been paused.
+https://bugs.webkit.org/show_bug.cgi?id=221916
+
+
+Reviewed by Eric Carlson.
+
+LayoutTests/imported/w3c:
+
+* web-platform-tests/mediacapture-record/MediaRecorder-pause-resume-expected.txt:
+* web-platform-tests/mediacapture-record/MediaRecorder-pause-resume.html:
+
+Source/WebCore:
+
+Proceed with stop steps in case of paused state, and not only in case of recording state.
+Covered by added WPT test.
+
+* Modules/mediarecorder/MediaRecorder.cpp:
+(WebCore::MediaRecorder::stopRecordingInternal):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-02-16 Youenn Fablet
+
+MediaRecorder.stop() does not work correctly when recording has been paused.
+https://bugs.webkit.org/show_bug.cgi?id=221916
+
+
+Reviewed by Eric Carlson.
+
+* web-platform-tests/mediacapture-record/MediaRecorder-pause-resume-expected.txt:
+* web-platform-tests/mediacapture-record/MediaRecorder-pause-resume.html:
+
2021-02-17 Ruben Turcios
Cherry-pick r272755. rdar://problem/74409916
Modified: branches/safari-611-branch/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-pause-resume-expected.txt (273456 => 273457)
--- branches/safari-611-branch/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-pause-resume-expected.txt 2021-02-25 00:39:45 UTC (rev 273456)
+++ branches/safari-611-branch/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-pause-resume-expected.txt 2021-02-25 00:39:49 UTC (rev 273457)
@@ -1,3 +1,4 @@
PASS MediaRecorder handles pause() and resume() calls appropriately in state and events
+PASS MediaRecorder handles stop() in paused state appropriately
Modified: branches/safari-611-branch/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-pause-resume.html (273456 => 273457)
--- branches/safari-611-branch/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-pause-resume.html 2021-02-25 00:39:45 UTC (rev 273456)
+++ branches/safari-611-branch/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-pause-resume.html 2021-02-25 00:39:49 UTC (rev 273457)
@@ -64,6 +64,34 @@
assert_array_equals(events, ["start", "pause", "resume", "dataavailable", "stop"],
"Should have gotten expected events");
}, "MediaRecorder handles pause() and resume() calls appropriately in state and events");
+
+promise_test(async () => {
+let video = createVideoStream();
+let recorder = new MediaRecorder(video);
+let events = recordEvents(recorder,
+["start", "stop", "dataavailable", "pause", "resume", "error"]);
+
+recorder.start();
+assert_equals(recorder.state, "recording", "MediaRecorder has been started successfully");
+await new Promise(r => recorder._onstart_ = r);
+
+recorder.pause();
+
[webkit-changes] [273459] branches/safari-611-branch
Title: [273459] branches/safari-611-branch Revision 273459 Author alanc...@apple.com Date 2021-02-24 16:39:57 -0800 (Wed, 24 Feb 2021) Log Message Cherry-pick r272906. rdar://problem/74410175 [LFC][Integration] Pass child inline block scroll overflow to parent https://bugs.webkit.org/show_bug.cgi?id=221958 rdar://74050874 Reviewed by Zalan Bujtas. Source/WebCore: Integrated LFC fails to pass through overflow from nested inline blocks. Test: fast/overflow/inline-block-scroll-overflow.html * layout/integration/LayoutIntegrationInlineContentBuilder.cpp: (WebCore::LayoutIntegration::InlineContentBuilder::InlineContentBuilder): (WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const): Find the associated RenderBox and collect overflow from it. * layout/integration/LayoutIntegrationInlineContentBuilder.h: * layout/integration/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::constructContent): LayoutTests: * fast/overflow/inline-block-scroll-overflow-expected.html: Added. * fast/overflow/inline-block-scroll-overflow.html: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272906 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-611-branch/LayoutTests/ChangeLog branches/safari-611-branch/Source/WebCore/ChangeLog branches/safari-611-branch/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp branches/safari-611-branch/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.h branches/safari-611-branch/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp Added Paths branches/safari-611-branch/LayoutTests/fast/overflow/inline-block-scroll-overflow-expected.html branches/safari-611-branch/LayoutTests/fast/overflow/inline-block-scroll-overflow.html Diff Modified: branches/safari-611-branch/LayoutTests/ChangeLog (273458 => 273459) --- branches/safari-611-branch/LayoutTests/ChangeLog 2021-02-25 00:39:53 UTC (rev 273458) +++ branches/safari-611-branch/LayoutTests/ChangeLog 2021-02-25 00:39:57 UTC (rev 273459) @@ -1,5 +1,49 @@ 2021-02-24 Russell Epstein +Cherry-pick r272906. rdar://problem/74410175 + +[LFC][Integration] Pass child inline block scroll overflow to parent +https://bugs.webkit.org/show_bug.cgi?id=221958 +rdar://74050874 + +Reviewed by Zalan Bujtas. + +Source/WebCore: + +Integrated LFC fails to pass through overflow from nested inline blocks. + +Test: fast/overflow/inline-block-scroll-overflow.html + +* layout/integration/LayoutIntegrationInlineContentBuilder.cpp: +(WebCore::LayoutIntegration::InlineContentBuilder::InlineContentBuilder): +(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const): + +Find the associated RenderBox and collect overflow from it. + +* layout/integration/LayoutIntegrationInlineContentBuilder.h: +* layout/integration/LayoutIntegrationLineLayout.cpp: +(WebCore::LayoutIntegration::LineLayout::constructContent): + +LayoutTests: + +* fast/overflow/inline-block-scroll-overflow-expected.html: Added. +* fast/overflow/inline-block-scroll-overflow.html: Added. + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272906 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-02-16 Antti Koivisto + +[LFC][Integration] Pass child inline block scroll overflow to parent +https://bugs.webkit.org/show_bug.cgi?id=221958 +rdar://74050874 + +Reviewed by Zalan Bujtas. + +* fast/overflow/inline-block-scroll-overflow-expected.html: Added. +* fast/overflow/inline-block-scroll-overflow.html: Added. + +2021-02-24 Russell Epstein + Cherry-pick r272359. rdar://problem/74451201 [MSE] Move the call to didParseInitializationDataCallback() from the beginning of a cluster to the end of "tracks" element Added: branches/safari-611-branch/LayoutTests/fast/overflow/inline-block-scroll-overflow-expected.html (0 => 273459) --- branches/safari-611-branch/LayoutTests/fast/overflow/inline-block-scroll-overflow-expected.html (rev 0) +++ branches/safari-611-branch/LayoutTests/fast/overflow/inline-block-scroll-overflow-expected.html 2021-02-25 00:39:57 UTC (rev 273459) @@ -0,0 +1,5 @@ + +This text is long and it should wrap at the edge of the viewport. Pass if the green image can be scrolled into the viewport. This text is long and it should wrap at the edge of the viewport. Pass if the green image can be scrolled into the viewport. + + + Added: branches/safari-611-branch/LayoutTests/fast/overflow/inline-block-scroll-overflow.html (0 => 273459) --- branches/safari-611-branch/LayoutTests/fast/overflow/inline-block-scroll-overflow.html (rev 0) +++
[webkit-changes] [273458] branches/safari-611-branch/Source/WebCore
Title: [273458] branches/safari-611-branch/Source/WebCore Revision 273458 Author alanc...@apple.com Date 2021-02-24 16:39:53 -0800 (Wed, 24 Feb 2021) Log Message Cherry-pick r272977. rdar://problem/74500812 REGRESSION (r266695): Unable to scroll the menu in 北京114预约挂号 official account - WeChat https://bugs.webkit.org/show_bug.cgi?id=221948 Reviewed by Simon Fraser. r266695 caused this to regress, but it actually is a progression, because all browsers agree that this content, as it exists in the app, doesn't scroll. So, we don't want to revert the change itself, because it's a good change, but we also want to make sure that WeChat continues to work. So, we can temporarily quirk one particular element in the WeChat app, until the the content can be fixed (). Because this is a WeChat-specific quirk, it is untestable. I tested manually. * page/Quirks.cpp: (WebCore::Quirks::needsWeChatScrollingQuirk const): * page/Quirks.h: * platform/RuntimeApplicationChecks.h: * platform/cocoa/RuntimeApplicationChecksCocoa.mm: (WebCore::IOSApplication::isWechat): * platform/cocoa/VersionChecks.h: * style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272977 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-611-branch/Source/WebCore/ChangeLog branches/safari-611-branch/Source/WebCore/page/Quirks.cpp branches/safari-611-branch/Source/WebCore/page/Quirks.h branches/safari-611-branch/Source/WebCore/platform/RuntimeApplicationChecks.h branches/safari-611-branch/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm branches/safari-611-branch/Source/WebCore/platform/cocoa/VersionChecks.h branches/safari-611-branch/Source/WebCore/style/StyleAdjuster.cpp Diff Modified: branches/safari-611-branch/Source/WebCore/ChangeLog (273457 => 273458) --- branches/safari-611-branch/Source/WebCore/ChangeLog 2021-02-25 00:39:49 UTC (rev 273457) +++ branches/safari-611-branch/Source/WebCore/ChangeLog 2021-02-25 00:39:53 UTC (rev 273458) @@ -1,5 +1,61 @@ 2021-02-24 Russell Epstein +Cherry-pick r272977. rdar://problem/74500812 + +REGRESSION (r266695): Unable to scroll the menu in 北京114预约挂号 official account - WeChat +https://bugs.webkit.org/show_bug.cgi?id=221948 + + +Reviewed by Simon Fraser. + +r266695 caused this to regress, but it actually is a progression, because all browsers agree +that this content, as it exists in the app, doesn't scroll. So, we don't want to revert the +change itself, because it's a good change, but we also want to make sure that WeChat continues +to work. So, we can temporarily quirk one particular element in the WeChat app, until the +the content can be fixed (). + +Because this is a WeChat-specific quirk, it is untestable. I tested manually. + +* page/Quirks.cpp: +(WebCore::Quirks::needsWeChatScrollingQuirk const): +* page/Quirks.h: +* platform/RuntimeApplicationChecks.h: +* platform/cocoa/RuntimeApplicationChecksCocoa.mm: +(WebCore::IOSApplication::isWechat): +* platform/cocoa/VersionChecks.h: +* style/StyleAdjuster.cpp: +(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const): + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272977 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-02-16 Myles C. Maxfield + +REGRESSION (r266695): Unable to scroll the menu in 北京114预约挂号 official account - WeChat +https://bugs.webkit.org/show_bug.cgi?id=221948 + + +Reviewed by Simon Fraser. + +r266695 caused this to regress, but it actually is a progression, because all browsers agree +that this content, as it exists in the app, doesn't scroll. So, we don't want to revert the +change itself, because it's a good change, but we also want to make sure that WeChat continues +to work. So, we can temporarily quirk one particular element in the WeChat app, until the +the content can be fixed (). + +Because this is a WeChat-specific quirk, it is untestable. I tested manually. + +* page/Quirks.cpp: +(WebCore::Quirks::needsWeChatScrollingQuirk const): +* page/Quirks.h: +* platform/RuntimeApplicationChecks.h: +* platform/cocoa/RuntimeApplicationChecksCocoa.mm: +(WebCore::IOSApplication::isWechat): +* platform/cocoa/VersionChecks.h: +* style/StyleAdjuster.cpp: +(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const): + +2021-02-24 Russell Epstein + Cherry-pick r272911. rdar://problem/74501076 MediaRecorder.stop() does not work correctly when recording has been paused. Modified: branches/safari-611-branch/Source/WebCore/page/Quirks.cpp (273457 =>
[webkit-changes] [273456] branches/safari-611-branch/Source/WebKit
Title: [273456] branches/safari-611-branch/Source/WebKit Revision 273456 Author alanc...@apple.com Date 2021-02-24 16:39:45 -0800 (Wed, 24 Feb 2021) Log Message Cherry-pick r272629. rdar://problem/74410251 Make sure we are no longer show the previous page when running a JS prompt https://bugs.webkit.org/show_bug.cgi?id=215782 Reviewed by Simon Fraser. Make sure we are no longer show the previous page when running a JS prompt. If we have not yet done a layer tree commit since the last load commit, then we are likely still showing the previous page. If we are asked to run a JS prompt / alert / confirm at this point, it would be confusing to still show the previous page. In order to address the issue, we now make the view blank in such scenario (ideally, we'd have painted the new page but this is currently not a trivial thing to do). To make the view blank, the approach chosen was to add a blank overlay view on top of the content. This overlay view gets taken down as soon as we paint the view again. * SourcesCocoa.txt: * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _hasBlankOverlay]): (-[WKWebView _setHasBlankOverlay:]): * UIProcess/API/Cocoa/WKWebViewInternal.h: * UIProcess/API/Cocoa/WKWebViewPrivate.h: * UIProcess/Cocoa/PageClientImplCocoa.h: * UIProcess/Cocoa/PageClientImplCocoa.mm: (WebKit::PageClientImplCocoa::setHasBlankOverlay): * UIProcess/Cocoa/WKBlankOverlayView.h: Added. * UIProcess/Cocoa/WKBlankOverlayView.mm: Added. (-[WKBlankOverlayView initWithFrame:]): * UIProcess/PageClient.h: (WebKit::PageClient::setHasBlankOverlay): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFirstLayerTreeCommitAfterCommittingLoad): (WebKit::WebPageProxy::makeViewBlankIfUnpaintedSinceLastLoadCommit): (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::didCommitLayerTree): * UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::didUpdateRenderingAfterCommittingLoad): * WebKit.xcodeproj/project.pbxproj: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didCommitLoad): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::updateRendering): * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::didUpdateRendering): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272629 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-611-branch/Source/WebKit/ChangeLog branches/safari-611-branch/Source/WebKit/SourcesCocoa.txt branches/safari-611-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm branches/safari-611-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h branches/safari-611-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h branches/safari-611-branch/Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h branches/safari-611-branch/Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm branches/safari-611-branch/Source/WebKit/UIProcess/PageClient.h branches/safari-611-branch/Source/WebKit/UIProcess/WebPageProxy.cpp branches/safari-611-branch/Source/WebKit/UIProcess/WebPageProxy.h branches/safari-611-branch/Source/WebKit/UIProcess/WebPageProxy.messages.in branches/safari-611-branch/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm branches/safari-611-branch/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm branches/safari-611-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj branches/safari-611-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp branches/safari-611-branch/Source/WebKit/WebProcess/WebPage/WebPage.h branches/safari-611-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm branches/safari-611-branch/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm Added Paths branches/safari-611-branch/Source/WebKit/UIProcess/Cocoa/WKBlankOverlayView.h branches/safari-611-branch/Source/WebKit/UIProcess/Cocoa/WKBlankOverlayView.mm Diff Modified: branches/safari-611-branch/Source/WebKit/ChangeLog (273455 => 273456) --- branches/safari-611-branch/Source/WebKit/ChangeLog 2021-02-25 00:37:42 UTC (rev 273455) +++ branches/safari-611-branch/Source/WebKit/ChangeLog 2021-02-25 00:39:45 UTC (rev 273456) @@ -1,3 +1,119 @@ +2021-02-24 Russell Epstein + +Cherry-pick r272629. rdar://problem/74410251 + +Make sure we are no longer show the previous page when running a JS prompt +https://bugs.webkit.org/show_bug.cgi?id=215782 + + +Reviewed by Simon Fraser. + +Make sure we are no longer show the previous page when running a JS prompt. +If we have not yet done a layer tree
[webkit-changes] [273455] branches/safari-611-branch/Source/WebCore
Title: [273455] branches/safari-611-branch/Source/WebCore
Revision 273455
Author alanc...@apple.com
Date 2021-02-24 16:37:42 -0800 (Wed, 24 Feb 2021)
Log Message
Cherry-pick r272544. rdar://problem/74409562
[Cocoa] Encrypted media segments should generate a parser error if no encrypted media handler is present.
https://bugs.webkit.org/show_bug.cgi?id=221496
Reviewed by Eric Carlson.
The WebM format reader does not support encrypted media parsing, so the parser must generate an error rather
than continuing to parse encrypted media data.
* platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::OnElementEnd):
(WebCore::SourceBufferParserWebM::OnTrackEntry):
* platform/graphics/cocoa/SourceBufferParserWebM.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-611-branch/Source/WebCore/ChangeLog
branches/safari-611-branch/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp
branches/safari-611-branch/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h
Diff
Modified: branches/safari-611-branch/Source/WebCore/ChangeLog (273454 => 273455)
--- branches/safari-611-branch/Source/WebCore/ChangeLog 2021-02-25 00:37:38 UTC (rev 273454)
+++ branches/safari-611-branch/Source/WebCore/ChangeLog 2021-02-25 00:37:42 UTC (rev 273455)
@@ -1,5 +1,40 @@
2021-02-24 Russell Epstein
+Cherry-pick r272544. rdar://problem/74409562
+
+[Cocoa] Encrypted media segments should generate a parser error if no encrypted media handler is present.
+https://bugs.webkit.org/show_bug.cgi?id=221496
+
+Reviewed by Eric Carlson.
+
+The WebM format reader does not support encrypted media parsing, so the parser must generate an error rather
+than continuing to parse encrypted media data.
+
+* platform/graphics/cocoa/SourceBufferParserWebM.cpp:
+(WebCore::SourceBufferParserWebM::OnElementEnd):
+(WebCore::SourceBufferParserWebM::OnTrackEntry):
+* platform/graphics/cocoa/SourceBufferParserWebM.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-02-08 Jer Noble
+
+[Cocoa] Encrypted media segments should generate a parser error if no encrypted media handler is present.
+https://bugs.webkit.org/show_bug.cgi?id=221496
+
+Reviewed by Eric Carlson.
+
+The WebM format reader does not support encrypted media parsing, so the parser must generate an error rather
+than continuing to parse encrypted media data.
+
+* platform/graphics/cocoa/SourceBufferParserWebM.cpp:
+(WebCore::SourceBufferParserWebM::OnElementEnd):
+(WebCore::SourceBufferParserWebM::OnTrackEntry):
+* platform/graphics/cocoa/SourceBufferParserWebM.h:
+
+2021-02-24 Russell Epstein
+
Cherry-pick r272359. rdar://problem/74451201
[MSE] Move the call to didParseInitializationDataCallback() from the beginning of a cluster to the end of "tracks" element
Modified: branches/safari-611-branch/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp (273454 => 273455)
--- branches/safari-611-branch/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp 2021-02-25 00:37:38 UTC (rev 273454)
+++ branches/safari-611-branch/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp 2021-02-25 00:37:42 UTC (rev 273455)
@@ -41,6 +41,7 @@
#include "VideoTrackPrivateWebM.h"
#include "WebMAudioUtilitiesCocoa.h"
#include <_javascript_Core/DataView.h>
+#include <_javascript_Core/GenericTypedArrayViewInlines.h>
#include
#include
#include
@@ -775,6 +776,11 @@
INFO_LOG_IF_POSSIBLE(LOGIDENTIFIER, "state(", oldState, "->", m_state, "), id(", metadata.id, "), size(", metadata.size, ")");
if (metadata.id == Id::kTracks) {
+if (!m_keyIds.isEmpty() && !m_didProvideContentKeyRequestInitializationDataForTrackIDCallback) {
+ERROR_LOG_IF_POSSIBLE(LOGIDENTIFIER, "Encountered encrypted content without an key request callback");
+return Status(Status::Code(ErrorCode::ContentEncrypted));
+}
+
if (m_initializationSegmentEncountered && m_didParseInitializationDataCallback) {
m_callOnClientThreadCallback([this, protectedThis = makeRef(*this), initializationSegment = WTFMove(*m_initializationSegment)]() mutable {
m_didParseInitializationDataCallback(WTFMove(initializationSegment));
@@ -782,6 +788,12 @@
}
m_initializationSegmentEncountered = false;
m_initializationSegment = nullptr;
+
+if (!m_keyIds.isEmpty()) {
+for (auto& keyIdPair : m_keyIds)
+m_didProvideContentKeyRequestInitializationDataForTrackIDCallback(WTFMove(keyIdPair.second), keyIdPair.first);
+}
+
[webkit-changes] [273454] branches/safari-611-branch
Title: [273454] branches/safari-611-branch Revision 273454 Author alanc...@apple.com Date 2021-02-24 16:37:38 -0800 (Wed, 24 Feb 2021) Log Message Cherry-pick r272359. rdar://problem/74451201 [MSE] Move the call to didParseInitializationDataCallback() from the beginning of a cluster to the end of "tracks" element https://bugs.webkit.org/show_bug.cgi?id=221120 Reviewed by Daniel Bates. Source/WebCore: This patch updates the WebM parser regarding the timing to call didParseInitializationDataCallback() based on a discussion with Jer. Based on the spec, https://w3c.github.io/mse-byte-stream-format-webm/#webm-init-segments, "The user agent MUST accept and ignore any elements other than an EBML Header or a Cluster that occur before, in between, or after the Segment Information and Tracks elements." So the parser should have collected all required information of the initialization segment when it finishes parsing the "Tracks" element. Tests: media/media-source/media-source-webm.html * platform/graphics/cocoa/SourceBufferParserWebM.cpp: (WebCore::SourceBufferParserWebM::OnElementEnd): (WebCore::SourceBufferParserWebM::OnClusterBegin): LayoutTests: * media/media-source/media-source-webm-expected.txt: * media/media-source/media-source-webm.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272359 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-611-branch/LayoutTests/ChangeLog branches/safari-611-branch/LayoutTests/media/media-source/media-source-webm-expected.txt branches/safari-611-branch/LayoutTests/media/media-source/media-source-webm.html branches/safari-611-branch/Source/WebCore/ChangeLog branches/safari-611-branch/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp Diff Modified: branches/safari-611-branch/LayoutTests/ChangeLog (273453 => 273454) --- branches/safari-611-branch/LayoutTests/ChangeLog 2021-02-25 00:15:03 UTC (rev 273453) +++ branches/safari-611-branch/LayoutTests/ChangeLog 2021-02-25 00:37:38 UTC (rev 273454) @@ -1,3 +1,45 @@ +2021-02-24 Russell Epstein + +Cherry-pick r272359. rdar://problem/74451201 + +[MSE] Move the call to didParseInitializationDataCallback() from the beginning of a cluster to the end of "tracks" element +https://bugs.webkit.org/show_bug.cgi?id=221120 + +Reviewed by Daniel Bates. + +Source/WebCore: + +This patch updates the WebM parser regarding the timing to call didParseInitializationDataCallback() +based on a discussion with Jer. + +Based on the spec, https://w3c.github.io/mse-byte-stream-format-webm/#webm-init-segments, "The user +agent MUST accept and ignore any elements other than an EBML Header or a Cluster that occur before, +in between, or after the Segment Information and Tracks elements." So the parser should have collected +all required information of the initialization segment when it finishes parsing the "Tracks" element. + +Tests: media/media-source/media-source-webm.html + +* platform/graphics/cocoa/SourceBufferParserWebM.cpp: +(WebCore::SourceBufferParserWebM::OnElementEnd): +(WebCore::SourceBufferParserWebM::OnClusterBegin): + +LayoutTests: + +* media/media-source/media-source-webm-expected.txt: +* media/media-source/media-source-webm.html: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272359 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-02-03 Peng Liu + +[MSE] Move the call to didParseInitializationDataCallback() from the beginning of a cluster to the end of "tracks" element +https://bugs.webkit.org/show_bug.cgi?id=221120 + +Reviewed by Daniel Bates. + +* media/media-source/media-source-webm-expected.txt: +* media/media-source/media-source-webm.html: + 2021-02-23 Alan Coon Cherry-pick r273158. rdar://problem/74623451 Modified: branches/safari-611-branch/LayoutTests/media/media-source/media-source-webm-expected.txt (273453 => 273454) --- branches/safari-611-branch/LayoutTests/media/media-source/media-source-webm-expected.txt 2021-02-25 00:15:03 UTC (rev 273453) +++ branches/safari-611-branch/LayoutTests/media/media-source/media-source-webm-expected.txt 2021-02-25 00:37:38 UTC (rev 273454) @@ -1,4 +1,4 @@ -This tests the ability of the SourceBuffer to reset the parser after an abort(). A SourceBuffer in this state should be able to accept a new initialization segment or a new media segment. +This tests that a SourceBuffer can accept an initialization segment and a media segment and fire "update" events, and the video element fires a "resize" event after the SourceBuffer appends the initialization segment. RUN(video.src = "" EVENT(sourceopen) @@ -6,10 +6,11 @@ RUN(sourceBuffer = source.addSourceBuffer(loader.type())) RUN(sourceBuffer.appendBuffer(loader.initSegment())) EVENT(update) +EXPECTED
[webkit-changes] [273453] trunk/Source
Title: [273453] trunk/Source
Revision 273453
Author cdu...@apple.com
Date 2021-02-24 16:15:03 -0800 (Wed, 24 Feb 2021)
Log Message
Unreviewed, fix build with the latest iOS SDK.
Source/WebCore:
* platform/DragData.h:
(WebCore::DragData::operator=): Deleted.
Source/WebKit:
* Shared/FocusedElementInformation.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/DragData.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/FocusedElementInformation.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (273452 => 273453)
--- trunk/Source/WebCore/ChangeLog 2021-02-25 00:08:23 UTC (rev 273452)
+++ trunk/Source/WebCore/ChangeLog 2021-02-25 00:15:03 UTC (rev 273453)
@@ -1,5 +1,12 @@
2021-02-24 Chris Dumez
+Unreviewed, fix build with the latest iOS SDK.
+
+* platform/DragData.h:
+(WebCore::DragData::operator=): Deleted.
+
+2021-02-24 Chris Dumez
+
Device motion / orientation events not working in third-party iframes despite Feature-Policy allowing it
https://bugs.webkit.org/show_bug.cgi?id=221399
Modified: trunk/Source/WebCore/platform/DragData.h (273452 => 273453)
--- trunk/Source/WebCore/platform/DragData.h 2021-02-25 00:08:23 UTC (rev 273452)
+++ trunk/Source/WebCore/platform/DragData.h 2021-02-25 00:15:03 UTC (rev 273453)
@@ -116,25 +116,6 @@
Optional pageID() const { return m_pageID; }
-DragData& operator=(const DragData& data)
-{
-m_clientPosition = data.m_clientPosition;
-m_globalPosition = data.m_globalPosition;
-m_platformDragData = data.m_platformDragData;
-m_draggingSourceOperationMask = data.m_draggingSourceOperationMask;
-m_applicationFlags = data.m_applicationFlags;
-m_fileNames = data.m_fileNames;
-m_dragDestinationActionMask = data.m_dragDestinationActionMask;
-m_pageID = data.m_pageID;
-#if PLATFORM(COCOA)
-m_pasteboardName = data.m_pasteboardName;
-#endif
-#if PLATFORM(WIN)
-m_dragDataMap = data.m_dragDataMap;
-#endif
-return *this;
-}
-
std::unique_ptr createPasteboardContext() const;
private:
Modified: trunk/Source/WebKit/ChangeLog (273452 => 273453)
--- trunk/Source/WebKit/ChangeLog 2021-02-25 00:08:23 UTC (rev 273452)
+++ trunk/Source/WebKit/ChangeLog 2021-02-25 00:15:03 UTC (rev 273453)
@@ -1,3 +1,9 @@
+2021-02-24 Chris Dumez
+
+Unreviewed, fix build with the latest iOS SDK.
+
+* Shared/FocusedElementInformation.h:
+
2021-02-24 Per Arne Vollan
[iOS] Get default value in the UI process for whether synchronous XMLHttpRequest are allowed during unload
Modified: trunk/Source/WebKit/Shared/FocusedElementInformation.h (273452 => 273453)
--- trunk/Source/WebKit/Shared/FocusedElementInformation.h 2021-02-25 00:08:23 UTC (rev 273452)
+++ trunk/Source/WebKit/Shared/FocusedElementInformation.h 2021-02-25 00:15:03 UTC (rev 273453)
@@ -66,17 +66,8 @@
#if PLATFORM(IOS_FAMILY)
struct OptionItem {
-OptionItem() { }
+OptionItem() = default;
-OptionItem(const OptionItem& item)
-: text(item.text)
-, isGroup(item.isGroup)
-, isSelected(item.isSelected)
-, disabled(item.disabled)
-, parentGroupID(item.parentGroupID)
-{
-}
-
OptionItem(const String& text, bool isGroup, int parentID, bool selected, bool disabled)
: text(text)
, isGroup(isGroup)
@@ -85,6 +76,7 @@
, parentGroupID(parentID)
{
}
+
String text;
bool isGroup { false };
bool isSelected { false };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273452] trunk/Source/WebKit
Title: [273452] trunk/Source/WebKit
Revision 273452
Author pvol...@apple.com
Date 2021-02-24 16:08:23 -0800 (Wed, 24 Feb 2021)
Log Message
[iOS] Get default value in the UI process for whether synchronous XMLHttpRequest are allowed during unload
https://bugs.webkit.org/show_bug.cgi?id=222377
Reviewed by Brent Fulgham.
Getting this default value in the UI process instead of in every WebContent process should be a small speedup,
since getting this default value is a bit costly on iOS.
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* Shared/ios/WebPreferencesDefaultValuesIOS.h: Added.
* Shared/ios/WebPreferencesDefaultValuesIOS.mm:
(WebKit::cachedAllowsRequest):
(WebKit::allowsDeprecatedSynchronousXMLHttpRequestDuringUnload):
(WebKit::setAllowsDeprecatedSynchronousXMLHttpRequestDuringUnload):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::m_lastNavigationWasAppBound):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp
trunk/Source/WebKit/Shared/WebPageCreationParameters.h
trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
Added Paths
trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (273451 => 273452)
--- trunk/Source/WebKit/ChangeLog 2021-02-25 00:07:16 UTC (rev 273451)
+++ trunk/Source/WebKit/ChangeLog 2021-02-25 00:08:23 UTC (rev 273452)
@@ -1,3 +1,28 @@
+2021-02-24 Per Arne Vollan
+
+[iOS] Get default value in the UI process for whether synchronous XMLHttpRequest are allowed during unload
+https://bugs.webkit.org/show_bug.cgi?id=222377
+
+Reviewed by Brent Fulgham.
+
+Getting this default value in the UI process instead of in every WebContent process should be a small speedup,
+since getting this default value is a bit costly on iOS.
+
+* Shared/WebPageCreationParameters.cpp:
+(WebKit::WebPageCreationParameters::encode const):
+(WebKit::WebPageCreationParameters::decode):
+* Shared/WebPageCreationParameters.h:
+* Shared/ios/WebPreferencesDefaultValuesIOS.h: Added.
+* Shared/ios/WebPreferencesDefaultValuesIOS.mm:
+(WebKit::cachedAllowsRequest):
+(WebKit::allowsDeprecatedSynchronousXMLHttpRequestDuringUnload):
+(WebKit::setAllowsDeprecatedSynchronousXMLHttpRequestDuringUnload):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::creationParameters):
+* WebKit.xcodeproj/project.pbxproj:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::m_lastNavigationWasAppBound):
+
2021-02-24 Russell Epstein
Revert r272735. rdar://problem/74674837
Modified: trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp (273451 => 273452)
--- trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp 2021-02-25 00:07:16 UTC (rev 273451)
+++ trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp 2021-02-25 00:08:23 UTC (rev 273452)
@@ -184,6 +184,9 @@
encoder << textInteractionEnabled;
encoder << httpsUpgradeEnabled;
+#if PLATFORM(IOS)
+encoder << allowsDeprecatedSynchronousXMLHttpRequestDuringUnload;
+#endif
}
Optional WebPageCreationParameters::decode(IPC::Decoder& decoder)
@@ -591,6 +594,11 @@
if (!decoder.decode(parameters.httpsUpgradeEnabled))
return WTF::nullopt;
+#if PLATFORM(IOS)
+if (!decoder.decode(parameters.allowsDeprecatedSynchronousXMLHttpRequestDuringUnload))
+return WTF::nullopt;
+#endif
+
return parameters;
}
Modified: trunk/Source/WebKit/Shared/WebPageCreationParameters.h (273451 => 273452)
--- trunk/Source/WebKit/Shared/WebPageCreationParameters.h 2021-02-25 00:07:16 UTC (rev 273451)
+++ trunk/Source/WebKit/Shared/WebPageCreationParameters.h 2021-02-25 00:08:23 UTC (rev 273452)
@@ -256,6 +256,10 @@
bool textInteractionEnabled { true };
bool httpsUpgradeEnabled { true };
+
+#if PLATFORM(IOS)
+bool allowsDeprecatedSynchronousXMLHttpRequestDuringUnload { false };
+#endif
};
} // namespace WebKit
Copied: trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.h (from rev 273450, trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm) (0 => 273452)
--- trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.h (rev 0)
+++ trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.h 2021-02-25 00:08:23 UTC (rev 273452)
@@ -0,0 +1,34 @@
+/*
+ * Copyright (C) 2021 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are
[webkit-changes] [273451] tags/Safari-612.1.4.5/
Title: [273451] tags/Safari-612.1.4.5/ Revision 273451 Author repst...@apple.com Date 2021-02-24 16:07:16 -0800 (Wed, 24 Feb 2021) Log Message Tag Safari-612.1.4.5. Added Paths tags/Safari-612.1.4.5/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273450] trunk/Source/WTF
Title: [273450] trunk/Source/WTF Revision 273450 Author wei...@apple.com Date 2021-02-24 16:00:43 -0800 (Wed, 24 Feb 2021) Log Message Add platform enable for separated model investigation https://bugs.webkit.org/show_bug.cgi?id=222383 Reviewed by Dean Jackson. * wtf/PlatformEnableCocoa.h: Add define. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformEnableCocoa.h Diff Modified: trunk/Source/WTF/ChangeLog (273449 => 273450) --- trunk/Source/WTF/ChangeLog 2021-02-24 23:54:15 UTC (rev 273449) +++ trunk/Source/WTF/ChangeLog 2021-02-25 00:00:43 UTC (rev 273450) @@ -1,3 +1,13 @@ +2021-02-24 Sam Weinig + +Add platform enable for separated model investigation +https://bugs.webkit.org/show_bug.cgi?id=222383 + +Reviewed by Dean Jackson. + +* wtf/PlatformEnableCocoa.h: +Add define. + 2021-02-23 Don Olmstead [CMake] Fix JSCOnly build on Windows Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (273449 => 273450) --- trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2021-02-24 23:54:15 UTC (rev 273449) +++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2021-02-25 00:00:43 UTC (rev 273450) @@ -645,3 +645,7 @@ #if !defined(ENABLE_CSS_TRANSFORM_STYLE_OPTIMIZED_3D) && HAVE(UIKIT_WEBKIT_INTERNALS) #define ENABLE_CSS_TRANSFORM_STYLE_OPTIMIZED_3D 1 #endif + +#if !defined(ENABLE_SEPARATED_MODEL) && HAVE(UIKIT_WEBKIT_INTERNALS) && HAVE(CORE_ANIMATION_SEPARATED_LAYERS) +#define ENABLE_SEPARATED_MODEL 1 +#endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273449] branches/safari-612.1.4-branch/Source
Title: [273449] branches/safari-612.1.4-branch/Source Revision 273449 Author repst...@apple.com Date 2021-02-24 15:54:15 -0800 (Wed, 24 Feb 2021) Log Message Versioning. WebKit-7612.1.4.5 Modified Paths branches/safari-612.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig (273448 => 273449) --- branches/safari-612.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-02-24 23:39:31 UTC (rev 273448) +++ branches/safari-612.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-02-24 23:54:15 UTC (rev 273449) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (273448 => 273449) --- branches/safari-612.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-02-24 23:39:31 UTC (rev 273448) +++ branches/safari-612.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-02-24 23:54:15 UTC (rev 273449) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (273448 => 273449) --- branches/safari-612.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-02-24 23:39:31 UTC (rev 273448) +++ branches/safari-612.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-02-24 23:54:15 UTC (rev 273449) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/WebCore/Configurations/Version.xcconfig (273448 => 273449) --- branches/safari-612.1.4-branch/Source/WebCore/Configurations/Version.xcconfig 2021-02-24 23:39:31 UTC (rev 273448) +++ branches/safari-612.1.4-branch/Source/WebCore/Configurations/Version.xcconfig 2021-02-24 23:54:15 UTC (rev 273449) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (273448 => 273449) --- branches/safari-612.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-02-24 23:39:31 UTC (rev 273448) +++ branches/safari-612.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-02-24 23:54:15 UTC (rev 273449) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (273448 => 273449) --- branches/safari-612.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-02-24 23:39:31 UTC (rev 273448) +++ branches/safari-612.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-02-24 23:54:15 UTC (rev 273449) @@ -1,7 +1,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/WebKit/Configurations/Version.xcconfig (273448 => 273449) --- branches/safari-612.1.4-branch/Source/WebKit/Configurations/Version.xcconfig 2021-02-24 23:39:31 UTC (rev 273448) +++ branches/safari-612.1.4-branch/Source/WebKit/Configurations/Version.xcconfig 2021-02-24 23:54:15 UTC (rev 273449) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION =
[webkit-changes] [273448] tags/Safari-612.1.4.4/
Title: [273448] tags/Safari-612.1.4.4/ Revision 273448 Author repst...@apple.com Date 2021-02-24 15:39:31 -0800 (Wed, 24 Feb 2021) Log Message Tag Safari-612.1.4.4. Added Paths tags/Safari-612.1.4.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273447] branches/safari-612.1.4-branch/Source
Title: [273447] branches/safari-612.1.4-branch/Source Revision 273447 Author repst...@apple.com Date 2021-02-24 15:35:15 -0800 (Wed, 24 Feb 2021) Log Message Versioning. WebKit-7612.1.4.4 Modified Paths branches/safari-612.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig (273446 => 273447) --- branches/safari-612.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-02-24 23:29:40 UTC (rev 273446) +++ branches/safari-612.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-02-24 23:35:15 UTC (rev 273447) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (273446 => 273447) --- branches/safari-612.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-02-24 23:29:40 UTC (rev 273446) +++ branches/safari-612.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-02-24 23:35:15 UTC (rev 273447) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (273446 => 273447) --- branches/safari-612.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-02-24 23:29:40 UTC (rev 273446) +++ branches/safari-612.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-02-24 23:35:15 UTC (rev 273447) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/WebCore/Configurations/Version.xcconfig (273446 => 273447) --- branches/safari-612.1.4-branch/Source/WebCore/Configurations/Version.xcconfig 2021-02-24 23:29:40 UTC (rev 273446) +++ branches/safari-612.1.4-branch/Source/WebCore/Configurations/Version.xcconfig 2021-02-24 23:35:15 UTC (rev 273447) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (273446 => 273447) --- branches/safari-612.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-02-24 23:29:40 UTC (rev 273446) +++ branches/safari-612.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-02-24 23:35:15 UTC (rev 273447) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (273446 => 273447) --- branches/safari-612.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-02-24 23:29:40 UTC (rev 273446) +++ branches/safari-612.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-02-24 23:35:15 UTC (rev 273447) @@ -1,7 +1,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/WebKit/Configurations/Version.xcconfig (273446 => 273447) --- branches/safari-612.1.4-branch/Source/WebKit/Configurations/Version.xcconfig 2021-02-24 23:29:40 UTC (rev 273446) +++ branches/safari-612.1.4-branch/Source/WebKit/Configurations/Version.xcconfig 2021-02-24 23:35:15 UTC (rev 273447) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION =
[webkit-changes] [273446] tags/Safari-612.1.4.3/
Title: [273446] tags/Safari-612.1.4.3/ Revision 273446 Author repst...@apple.com Date 2021-02-24 15:29:40 -0800 (Wed, 24 Feb 2021) Log Message Tag Safari-612.1.4.3. Added Paths tags/Safari-612.1.4.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273445] branches/safari-612.1.4-branch/Source
Title: [273445] branches/safari-612.1.4-branch/Source Revision 273445 Author repst...@apple.com Date 2021-02-24 15:26:56 -0800 (Wed, 24 Feb 2021) Log Message Versioning. WebKit-7612.1.4.3 Modified Paths branches/safari-612.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.1.4-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig (273444 => 273445) --- branches/safari-612.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-02-24 23:17:35 UTC (rev 273444) +++ branches/safari-612.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-02-24 23:26:56 UTC (rev 273445) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (273444 => 273445) --- branches/safari-612.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-02-24 23:17:35 UTC (rev 273444) +++ branches/safari-612.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-02-24 23:26:56 UTC (rev 273445) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (273444 => 273445) --- branches/safari-612.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-02-24 23:17:35 UTC (rev 273444) +++ branches/safari-612.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-02-24 23:26:56 UTC (rev 273445) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/WebCore/Configurations/Version.xcconfig (273444 => 273445) --- branches/safari-612.1.4-branch/Source/WebCore/Configurations/Version.xcconfig 2021-02-24 23:17:35 UTC (rev 273444) +++ branches/safari-612.1.4-branch/Source/WebCore/Configurations/Version.xcconfig 2021-02-24 23:26:56 UTC (rev 273445) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (273444 => 273445) --- branches/safari-612.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-02-24 23:17:35 UTC (rev 273444) +++ branches/safari-612.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-02-24 23:26:56 UTC (rev 273445) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (273444 => 273445) --- branches/safari-612.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-02-24 23:17:35 UTC (rev 273444) +++ branches/safari-612.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-02-24 23:26:56 UTC (rev 273445) @@ -1,7 +1,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.4-branch/Source/WebKit/Configurations/Version.xcconfig (273444 => 273445) --- branches/safari-612.1.4-branch/Source/WebKit/Configurations/Version.xcconfig 2021-02-24 23:17:35 UTC (rev 273444) +++ branches/safari-612.1.4-branch/Source/WebKit/Configurations/Version.xcconfig 2021-02-24 23:26:56 UTC (rev 273445) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION =
[webkit-changes] [273444] trunk
Title: [273444] trunk Revision 273444 Author cdu...@apple.com Date 2021-02-24 15:17:35 -0800 (Wed, 24 Feb 2021) Log Message Device motion / orientation events not working in third-party iframes despite Feature-Policy allowing it https://bugs.webkit.org/show_bug.cgi?id=221399 Reviewed by Youenn Fablet. Source/WebCore: Allow third-party iframes to request access to device motion / orientation events if permitted via Feature-Policy. To match Blink, the following features need to be allowed via Feature-Policy: - DeviceOrientationEvent: gyroscope, accelerometer and magnetometer - DeviceMotionEvent: gyroscope and accelerometer Tests: http/tests/device-orientation/device-motion-allowed-in-first-party-only.html http/tests/device-orientation/device-motion-third-party-iframe-allowed-by-feature-policy.html http/tests/device-orientation/device-motion-third-party-iframe-denied-by-insufficient-feature-policy.html http/tests/device-orientation/device-motion-third-party-iframe-denied.html http/tests/device-orientation/device-orientation-allowed-in-first-party-only.html http/tests/device-orientation/device-orientation-third-party-iframe-allowed-by-feature-policy.html http/tests/device-orientation/device-orientation-third-party-iframe-denied-by-insufficient-feature-policy.html http/tests/device-orientation/device-orientation-third-party-iframe-denied.html * Sources.txt: * WebCore.xcodeproj/project.pbxproj: Drop DeviceOrientationOrMotionEvent class as it is no longer needed. * bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorld): Make sure we specify the document when taking a user gesture when asked to run a script. This is important because some clients want to know that there was a user gesture for a document within their origin (like device motion & orientation). * dom/DeviceMotionEvent.cpp: (WebCore::DeviceMotionEvent::requestPermission): * dom/DeviceMotionEvent.h: * dom/DeviceOrientationEvent.cpp: (WebCore::DeviceOrientationEvent::requestPermission): * dom/DeviceOrientationEvent.h: Move requestPermission() from DeviceOrientationOrMotionEvent class to its subclasses now that their implementations are slightly different. * dom/DeviceOrientationAndMotionAccessController.cpp: (WebCore::DeviceOrientationAndMotionAccessController::DeviceOrientationAndMotionAccessController): (WebCore::DeviceOrientationAndMotionAccessController::accessState const): (WebCore::DeviceOrientationAndMotionAccessController::shouldAllowAccess): (WebCore::DeviceOrientationAndMotionAccessController::clearPermissions): * dom/DeviceOrientationAndMotionAccessController.h: DeviceOrientationAndMotionAccessController is tied to the top document as used to have a single cached 'permission state' since we used to only support device orientation & motion events in first-party content. Now that we support those events in third-party content, I replaced the single 'permission state' data member into a map of 'permission state' per origin. This allows us to know synchronously (and without IPC to the UIProcess) the known permission state of each iframe. Also, I now pass the document to UserGestureIndicator::processingUserGesture() to make sure that interacting with the top frame does not allow a third-party iframe to request permission to use the device motion & orientation API. The user needs to interact with that third-party iframe to allow the iframe to prompt the user. * dom/DeviceOrientationOrMotionEvent.cpp: Removed. * dom/DeviceOrientationOrMotionEvent.h: Removed. Drop DeviceOrientationOrMotionEvent class now that the 2 subclasses need a slightly different implementation of requestPermission(). * dom/UserGestureIndicator.cpp: (WebCore::UserGestureToken::isValidForDocument const): Make parameter const since it can be. (WebCore::UserGestureIndicator::processingUserGesture): Check state first in the condition to avoid doing a null-deref when a UserGestureIndicator gets constructed with no |state| but with a non-null |document|. * dom/UserGestureIndicator.h: * html/FeaturePolicy.cpp: (WebCore::policyTypeName): (WebCore::FeaturePolicy::parse): (WebCore::FeaturePolicy::allows const): * html/FeaturePolicy.h: Add the following feature policies: accelerometer, gyroscope & magnetometer. https://github.com/w3c/webappsec-permissions-policy/blob/main/features.md * page/DOMWindow.cpp: (WebCore::DOMWindow::page const): (WebCore::DOMWindow::isAllowedToUseDeviceMotionOrOrientation const): (WebCore::DOMWindow::isAllowedToUseDeviceMotion const): (WebCore::DOMWindow::isAllowedToUseDeviceOrientation const): (WebCore::DOMWindow::hasPermissionToReceiveDeviceMotionOrOrientationEvents const): (WebCore::DOMWindow::startListeningForDeviceOrientationIfNecessary): (WebCore::DOMWindow::startListeningForDeviceMotionIfNecessary): * page/DOMWindow.h: Differentiate permission support for device motion and device orientation that they are different. In particular, the two types of events
[webkit-changes] [273443] tags/Safari-611.1.18.3.1/
Title: [273443] tags/Safari-611.1.18.3.1/ Revision 273443 Author repst...@apple.com Date 2021-02-24 15:03:17 -0800 (Wed, 24 Feb 2021) Log Message Tag Safari-611.1.18.3.1. Added Paths tags/Safari-611.1.18.3.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273442] trunk/Source/WebCore
Title: [273442] trunk/Source/WebCore
Revision 273442
Author cdu...@apple.com
Date 2021-02-24 15:02:00 -0800 (Wed, 24 Feb 2021)
Log Message
Regression(r269481) Kugou Music: Can not leave "MV" category after selecting it
https://bugs.webkit.org/show_bug.cgi?id=222380
Reviewed by Geoffrey Garen.
The new behavior in r269481 aligns us with the specification and with Blink so I
am adding a linked-on-after to maintain pre-r269481 behavior until Apps get
rebuilt against the new SDK.
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::supportedPropertyNames const):
* page/Quirks.cpp:
(WebCore::Quirks::shouldOmitHTMLDocumentSupportedPropertyNames):
* page/Quirks.h:
* platform/cocoa/VersionChecks.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLDocument.cpp
trunk/Source/WebCore/page/Quirks.cpp
trunk/Source/WebCore/page/Quirks.h
trunk/Source/WebCore/platform/cocoa/VersionChecks.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (273441 => 273442)
--- trunk/Source/WebCore/ChangeLog 2021-02-24 23:01:23 UTC (rev 273441)
+++ trunk/Source/WebCore/ChangeLog 2021-02-24 23:02:00 UTC (rev 273442)
@@ -1,5 +1,24 @@
2021-02-24 Chris Dumez
+Regression(r269481) Kugou Music: Can not leave "MV" category after selecting it
+https://bugs.webkit.org/show_bug.cgi?id=222380
+
+
+Reviewed by Geoffrey Garen.
+
+The new behavior in r269481 aligns us with the specification and with Blink so I
+am adding a linked-on-after to maintain pre-r269481 behavior until Apps get
+rebuilt against the new SDK.
+
+* html/HTMLDocument.cpp:
+(WebCore::HTMLDocument::supportedPropertyNames const):
+* page/Quirks.cpp:
+(WebCore::Quirks::shouldOmitHTMLDocumentSupportedPropertyNames):
+* page/Quirks.h:
+* platform/cocoa/VersionChecks.h:
+
+2021-02-24 Chris Dumez
+
Regression(r268700) postMessage changes prototype of basic types
https://bugs.webkit.org/show_bug.cgi?id=28
Modified: trunk/Source/WebCore/html/HTMLDocument.cpp (273441 => 273442)
--- trunk/Source/WebCore/html/HTMLDocument.cpp 2021-02-24 23:01:23 UTC (rev 273441)
+++ trunk/Source/WebCore/html/HTMLDocument.cpp 2021-02-24 23:02:00 UTC (rev 273442)
@@ -74,6 +74,7 @@
#include "HTMLHtmlElement.h"
#include "HTMLIFrameElement.h"
#include "HTMLNames.h"
+#include "Quirks.h"
#include "ScriptController.h"
#include "StyleResolver.h"
#include
@@ -140,6 +141,9 @@
Vector HTMLDocument::supportedPropertyNames() const
{
+if (Quirks::shouldOmitHTMLDocumentSupportedPropertyNames())
+return { };
+
auto properties = m_documentNamedItem.keys();
// The specification says these should be sorted in document order but this would be expensive
// and other browser engines do not comply with this part of the specification. For now, just
Modified: trunk/Source/WebCore/page/Quirks.cpp (273441 => 273442)
--- trunk/Source/WebCore/page/Quirks.cpp 2021-02-24 23:01:23 UTC (rev 273441)
+++ trunk/Source/WebCore/page/Quirks.cpp 2021-02-24 23:02:00 UTC (rev 273442)
@@ -660,6 +660,16 @@
#endif
}
+bool Quirks::shouldOmitHTMLDocumentSupportedPropertyNames()
+{
+#if PLATFORM(COCOA)
+static bool shouldOmitHTMLDocumentSupportedPropertyNames = !linkedOnOrAfter(SDKVersion::FirstWithHTMLDocumentSupportedPropertyNames);
+return shouldOmitHTMLDocumentSupportedPropertyNames;
+#else
+return false;
+#endif
+}
+
bool Quirks::shouldSilenceWindowResizeEvents() const
{
#if PLATFORM(IOS)
Modified: trunk/Source/WebCore/page/Quirks.h (273441 => 273442)
--- trunk/Source/WebCore/page/Quirks.h 2021-02-24 23:01:23 UTC (rev 273441)
+++ trunk/Source/WebCore/page/Quirks.h 2021-02-24 23:02:00 UTC (rev 273442)
@@ -147,6 +147,8 @@
WEBCORE_EXPORT bool shouldBypassUserGestureRequirementForWebAuthn() const;
#endif
+static bool shouldOmitHTMLDocumentSupportedPropertyNames();
+
private:
bool needsQuirks() const;
Modified: trunk/Source/WebCore/platform/cocoa/VersionChecks.h (273441 => 273442)
--- trunk/Source/WebCore/platform/cocoa/VersionChecks.h 2021-02-24 23:01:23 UTC (rev 273441)
+++ trunk/Source/WebCore/platform/cocoa/VersionChecks.h 2021-02-24 23:02:00 UTC (rev 273442)
@@ -65,6 +65,7 @@
FirstWithWKWebsiteDataStoreInitReturningNil = DYLD_IOS_VERSION_14_0,
FirstVersionWithiOSAppsOnMacOS = DYLD_IOS_VERSION_FIRST_WITH_IOS_APPS_ON_MACOS,
FirstWithDataURLFragmentRemoval = DYLD_IOS_VERSION_14_5,
+FirstWithHTMLDocumentSupportedPropertyNames = DYLD_IOS_VERSION_14_5,
FirstThatObservesClassProperty = DYLD_IOS_VERSION_14_5,
FirstWithNullOriginForNonSpecialSchemedURLs = DYLD_IOS_VERSION_15_0,
FirstWithoutWeChatScrollingQuirk = DYLD_IOS_VERSION_14_5,
@@ -86,6 +87,7 @@
FirstWithInitializeWebKit2MainThreadAssertion = DYLD_MACOSX_VERSION_10_16,
FirstWithWKWebsiteDataStoreInitReturningNil = DYLD_MACOSX_VERSION_10_16,
FirstWithDataURLFragmentRemoval =
[webkit-changes] [273441] tags/Safari-611.1.18.2.1/
Title: [273441] tags/Safari-611.1.18.2.1/ Revision 273441 Author rubent...@apple.com Date 2021-02-24 15:01:23 -0800 (Wed, 24 Feb 2021) Log Message Tag Safari-611.1.18.2.1. Added Paths tags/Safari-611.1.18.2.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273440] tags/Safari-611.1.18.1.2/
Title: [273440] tags/Safari-611.1.18.1.2/ Revision 273440 Author rubent...@apple.com Date 2021-02-24 14:49:32 -0800 (Wed, 24 Feb 2021) Log Message Tag Safari-611.1.18.1.2. Added Paths tags/Safari-611.1.18.1.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273439] tags/Safari-611.1.18.0.2/
Title: [273439] tags/Safari-611.1.18.0.2/ Revision 273439 Author repst...@apple.com Date 2021-02-24 14:45:17 -0800 (Wed, 24 Feb 2021) Log Message Tag Safari-611.1.18.0.2. Added Paths tags/Safari-611.1.18.0.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273438] trunk
Title: [273438] trunk Revision 273438 Author cdu...@apple.com Date 2021-02-24 14:03:41 -0800 (Wed, 24 Feb 2021) Log Message Regression(r268700) postMessage changes prototype of basic types https://bugs.webkit.org/show_bug.cgi?id=28 Reviewed by Geoffrey Garen. Source/WebCore: r268700 updated ScriptExecutionContext::globalObject() to call: `WebCore::globalObject(mainThreadNormalWorld(), downcast(*this).page())` instead of `frame ? frame->script().globalObject(mainThreadNormalWorld()) : nullptr` This was not right for subframes because globalObject() gets the globalObject from the page's main frame instead of the document's frame. This patch gets rid of the error-prone WebCore::globalObject() taking in a Page* and replaces it with one taking in a Frame* to avoid such issues in the future. Test: fast/dom/Window/postMessage-Object-prototype.html * bindings/js/ScriptState.cpp: (WebCore::globalObject): * bindings/js/ScriptState.h: * dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::globalObject): * inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::addSelfToGlobalObjectInWorld): (WebCore::InspectorFrontendHost::showContextMenu): LayoutTests: Add layout test coverage. * fast/dom/Window/postMessage-Object-prototype-expected.txt: Added. * fast/dom/Window/postMessage-Object-prototype.html: Added. * fast/dom/Window/resources/postMessage-Object-prototype-frame.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/ScriptState.cpp trunk/Source/WebCore/bindings/js/ScriptState.h trunk/Source/WebCore/dom/ScriptExecutionContext.cpp trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp Added Paths trunk/LayoutTests/fast/dom/Window/postMessage-Object-prototype-expected.txt trunk/LayoutTests/fast/dom/Window/postMessage-Object-prototype.html trunk/LayoutTests/fast/dom/Window/resources/postMessage-Object-prototype-frame.html Diff Modified: trunk/LayoutTests/ChangeLog (273437 => 273438) --- trunk/LayoutTests/ChangeLog 2021-02-24 22:02:34 UTC (rev 273437) +++ trunk/LayoutTests/ChangeLog 2021-02-24 22:03:41 UTC (rev 273438) @@ -1,3 +1,17 @@ +2021-02-24 Chris Dumez + +Regression(r268700) postMessage changes prototype of basic types +https://bugs.webkit.org/show_bug.cgi?id=28 + + +Reviewed by Geoffrey Garen. + +Add layout test coverage. + +* fast/dom/Window/postMessage-Object-prototype-expected.txt: Added. +* fast/dom/Window/postMessage-Object-prototype.html: Added. +* fast/dom/Window/resources/postMessage-Object-prototype-frame.html: Added. + 2021-02-24 Jonathan Bedard Unreviewed Windows test gardening to speed up EWS. Added: trunk/LayoutTests/fast/dom/Window/postMessage-Object-prototype-expected.txt (0 => 273438) --- trunk/LayoutTests/fast/dom/Window/postMessage-Object-prototype-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dom/Window/postMessage-Object-prototype-expected.txt 2021-02-24 22:03:41 UTC (rev 273438) @@ -0,0 +1,11 @@ +Tests that the prototype of objects serialized via postMessage is correct. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS event.data instanceof Object +PASS event.data.array instanceof Array +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/dom/Window/postMessage-Object-prototype.html (0 => 273438) --- trunk/LayoutTests/fast/dom/Window/postMessage-Object-prototype.html (rev 0) +++ trunk/LayoutTests/fast/dom/Window/postMessage-Object-prototype.html 2021-02-24 22:03:41 UTC (rev 273438) @@ -0,0 +1,16 @@ + + + +