Re: VOTE: EmptyPanel
On 5/19/07, Sean Sullivan <[EMAIL PROTECTED]> wrote: What was the result of this vote? Is EmptyPanel going to be added to Wicket 1.3? Just added. Eelco
Re: VOTE: EmptyPanel
What was the result of this vote? Is EmptyPanel going to be added to Wicket 1.3? On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: so i propose a vote to add this. i'm +1.
Re: VOTE: EmptyPanel
* Jonathan Locke: > > > so i propose a vote to add this. i'm +1. +1 I have one in every project. It is particularly useful for a reusable modal dialog that is defined in the page, and replaced/shown in various forms. -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/
Re: VOTE: EmptyPanel
On 5/5/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: You're right about that. EmptyPanel is better, and it should probably be final. Yes, I think EmptyPanel has the merit of being more obvious in its intent, and less error prone. Xavier Eelco On 5/5/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > will that really make things better? if you misname the markup file you will > now get component not found rather then markup not found. > > -igor > > > On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > > > > How about giving Panel.java an accompanying Panel.html file? That > > would obviate the need of adding EmptyPanel, and anyone subclassing > > Panel would override it by supplying their own markup. > > > > Martijn > > > > On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > > > +1, another class I can remove from our project :) > > > > > > On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > > so i propose a vote to add this. i'm +1. > > > > > > > > > > > > Eelco Hillenius wrote: > > > > > > > > > > Yeah. I actually think I proposed something like this, or at least > > > > > +1-ed one at more than a year ago. You'll have to dig in the > > archives > > > > > to find out why other people didn't agree back then, but I still > > think > > > > > it's much easier for users to discover something just because it has > > > > > an obvious name, and not to worry about that one extra class. > > > > > > > > > > Eelco > > > > > > > > > > > > > > > On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > > > >> > > > > >> In my work project, I've added and frequently use an EmptyPanel > > which is > > > > >> simply a panel with empty markup. Although you can do the same > > thing > > > > >> with > > > > >> WebMarkupContainer or implement this yourself, it does seem like a > > nice > > > > >> conceptual addition, particularly for newbies who might not think > > "hmm... > > > > >> i > > > > >> want an empty panel instead of this fancy panel if the user isn't > > logged > > > > >> in... oh WebMarkupContainer looks about right..." ;-) Anyway, I > > thought > > > > >> I'd > > > > >> mention it in case others feel this would be a nice addition to > > core. > > > > >> -- > > > > >> View this message in context: > > > > >> http://www.nabble.com/EmptyPanel--tf3692546.html#a10324363 > > > > >> Sent from the Wicket - Dev mailing list archive at Nabble.com. > > > > >> > > > > >> > > > > > > > > > > > > > > > > > > -- > > > > View this message in context: > > http://www.nabble.com/EmptyPanel--tf3692546.html#a10333463 > > > > Sent from the Wicket - Dev mailing list archive at Nabble.com. > > > > > > > > > > > > > > > > > -- > > > Learn Wicket at ApacheCon Europe: http://apachecon.com > > > Join the wicket community at irc.freenode.net: ##wicket > > > Wicket 1.2.6 contains a very important fix. Download Wicket now! > > > http://wicketframework.org > > > > > > > > > -- > > Learn Wicket at ApacheCon Europe: http://apachecon.com > > Join the wicket community at irc.freenode.net: ##wicket > > Wicket 1.2.6 contains a very important fix. Download Wicket now! > > http://wicketframework.org > > > -- Xavier Hanin - Independent Java Consultant Manage your dependencies with Ivy! http://incubator.apache.org/ivy/
Re: VOTE: EmptyPanel
You're right about that. EmptyPanel is better, and it should probably be final. Eelco On 5/5/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: will that really make things better? if you misname the markup file you will now get component not found rather then markup not found. -igor On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > > How about giving Panel.java an accompanying Panel.html file? That > would obviate the need of adding EmptyPanel, and anyone subclassing > Panel would override it by supplying their own markup. > > Martijn > > On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > > +1, another class I can remove from our project :) > > > > On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > > > > > > > > so i propose a vote to add this. i'm +1. > > > > > > > > > Eelco Hillenius wrote: > > > > > > > > Yeah. I actually think I proposed something like this, or at least > > > > +1-ed one at more than a year ago. You'll have to dig in the > archives > > > > to find out why other people didn't agree back then, but I still > think > > > > it's much easier for users to discover something just because it has > > > > an obvious name, and not to worry about that one extra class. > > > > > > > > Eelco > > > > > > > > > > > > On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > > >> > > > >> In my work project, I've added and frequently use an EmptyPanel > which is > > > >> simply a panel with empty markup. Although you can do the same > thing > > > >> with > > > >> WebMarkupContainer or implement this yourself, it does seem like a > nice > > > >> conceptual addition, particularly for newbies who might not think > "hmm... > > > >> i > > > >> want an empty panel instead of this fancy panel if the user isn't > logged > > > >> in... oh WebMarkupContainer looks about right..." ;-) Anyway, I > thought > > > >> I'd > > > >> mention it in case others feel this would be a nice addition to > core. > > > >> -- > > > >> View this message in context: > > > >> http://www.nabble.com/EmptyPanel--tf3692546.html#a10324363 > > > >> Sent from the Wicket - Dev mailing list archive at Nabble.com. > > > >> > > > >> > > > > > > > > > > > > > > -- > > > View this message in context: > http://www.nabble.com/EmptyPanel--tf3692546.html#a10333463 > > > Sent from the Wicket - Dev mailing list archive at Nabble.com. > > > > > > > > > > > > -- > > Learn Wicket at ApacheCon Europe: http://apachecon.com > > Join the wicket community at irc.freenode.net: ##wicket > > Wicket 1.2.6 contains a very important fix. Download Wicket now! > > http://wicketframework.org > > > > > -- > Learn Wicket at ApacheCon Europe: http://apachecon.com > Join the wicket community at irc.freenode.net: ##wicket > Wicket 1.2.6 contains a very important fix. Download Wicket now! > http://wicketframework.org >
Re: VOTE: EmptyPanel
will that really make things better? if you misname the markup file you will now get component not found rather then markup not found. -igor On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: How about giving Panel.java an accompanying Panel.html file? That would obviate the need of adding EmptyPanel, and anyone subclassing Panel would override it by supplying their own markup. Martijn On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > +1, another class I can remove from our project :) > > On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > > > > > so i propose a vote to add this. i'm +1. > > > > > > Eelco Hillenius wrote: > > > > > > Yeah. I actually think I proposed something like this, or at least > > > +1-ed one at more than a year ago. You'll have to dig in the archives > > > to find out why other people didn't agree back then, but I still think > > > it's much easier for users to discover something just because it has > > > an obvious name, and not to worry about that one extra class. > > > > > > Eelco > > > > > > > > > On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > >> > > >> In my work project, I've added and frequently use an EmptyPanel which is > > >> simply a panel with empty markup. Although you can do the same thing > > >> with > > >> WebMarkupContainer or implement this yourself, it does seem like a nice > > >> conceptual addition, particularly for newbies who might not think "hmm... > > >> i > > >> want an empty panel instead of this fancy panel if the user isn't logged > > >> in... oh WebMarkupContainer looks about right..." ;-) Anyway, I thought > > >> I'd > > >> mention it in case others feel this would be a nice addition to core. > > >> -- > > >> View this message in context: > > >> http://www.nabble.com/EmptyPanel--tf3692546.html#a10324363 > > >> Sent from the Wicket - Dev mailing list archive at Nabble.com. > > >> > > >> > > > > > > > > > > -- > > View this message in context: http://www.nabble.com/EmptyPanel--tf3692546.html#a10333463 > > Sent from the Wicket - Dev mailing list archive at Nabble.com. > > > > > > > -- > Learn Wicket at ApacheCon Europe: http://apachecon.com > Join the wicket community at irc.freenode.net: ##wicket > Wicket 1.2.6 contains a very important fix. Download Wicket now! > http://wicketframework.org > -- Learn Wicket at ApacheCon Europe: http://apachecon.com Join the wicket community at irc.freenode.net: ##wicket Wicket 1.2.6 contains a very important fix. Download Wicket now! http://wicketframework.org
Re: VOTE: EmptyPanel
That's actually not a bad idea. Xavier, you think you would have found that/ is it as obvious? Eelco On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: How about giving Panel.java an accompanying Panel.html file? That would obviate the need of adding EmptyPanel, and anyone subclassing Panel would override it by supplying their own markup. Martijn On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > +1, another class I can remove from our project :) > > On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > > > > > so i propose a vote to add this. i'm +1. > > > > > > Eelco Hillenius wrote: > > > > > > Yeah. I actually think I proposed something like this, or at least > > > +1-ed one at more than a year ago. You'll have to dig in the archives > > > to find out why other people didn't agree back then, but I still think > > > it's much easier for users to discover something just because it has > > > an obvious name, and not to worry about that one extra class. > > > > > > Eelco > > > > > > > > > On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > >> > > >> In my work project, I've added and frequently use an EmptyPanel which is > > >> simply a panel with empty markup. Although you can do the same thing > > >> with > > >> WebMarkupContainer or implement this yourself, it does seem like a nice > > >> conceptual addition, particularly for newbies who might not think "hmm... > > >> i > > >> want an empty panel instead of this fancy panel if the user isn't logged > > >> in... oh WebMarkupContainer looks about right..." ;-) Anyway, I thought > > >> I'd > > >> mention it in case others feel this would be a nice addition to core. > > >> -- > > >> View this message in context: > > >> http://www.nabble.com/EmptyPanel--tf3692546.html#a10324363 > > >> Sent from the Wicket - Dev mailing list archive at Nabble.com. > > >> > > >> > > > > > > > > > > -- > > View this message in context: http://www.nabble.com/EmptyPanel--tf3692546.html#a10333463 > > Sent from the Wicket - Dev mailing list archive at Nabble.com. > > > > > > > -- > Learn Wicket at ApacheCon Europe: http://apachecon.com > Join the wicket community at irc.freenode.net: ##wicket > Wicket 1.2.6 contains a very important fix. Download Wicket now! > http://wicketframework.org > -- Learn Wicket at ApacheCon Europe: http://apachecon.com Join the wicket community at irc.freenode.net: ##wicket Wicket 1.2.6 contains a very important fix. Download Wicket now! http://wicketframework.org
Re: VOTE: EmptyPanel
How about giving Panel.java an accompanying Panel.html file? That would obviate the need of adding EmptyPanel, and anyone subclassing Panel would override it by supplying their own markup. Martijn On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: +1, another class I can remove from our project :) On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > > so i propose a vote to add this. i'm +1. > > > Eelco Hillenius wrote: > > > > Yeah. I actually think I proposed something like this, or at least > > +1-ed one at more than a year ago. You'll have to dig in the archives > > to find out why other people didn't agree back then, but I still think > > it's much easier for users to discover something just because it has > > an obvious name, and not to worry about that one extra class. > > > > Eelco > > > > > > On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > >> > >> In my work project, I've added and frequently use an EmptyPanel which is > >> simply a panel with empty markup. Although you can do the same thing > >> with > >> WebMarkupContainer or implement this yourself, it does seem like a nice > >> conceptual addition, particularly for newbies who might not think "hmm... > >> i > >> want an empty panel instead of this fancy panel if the user isn't logged > >> in... oh WebMarkupContainer looks about right..." ;-) Anyway, I thought > >> I'd > >> mention it in case others feel this would be a nice addition to core. > >> -- > >> View this message in context: > >> http://www.nabble.com/EmptyPanel--tf3692546.html#a10324363 > >> Sent from the Wicket - Dev mailing list archive at Nabble.com. > >> > >> > > > > > > -- > View this message in context: http://www.nabble.com/EmptyPanel--tf3692546.html#a10333463 > Sent from the Wicket - Dev mailing list archive at Nabble.com. > > -- Learn Wicket at ApacheCon Europe: http://apachecon.com Join the wicket community at irc.freenode.net: ##wicket Wicket 1.2.6 contains a very important fix. Download Wicket now! http://wicketframework.org -- Learn Wicket at ApacheCon Europe: http://apachecon.com Join the wicket community at irc.freenode.net: ##wicket Wicket 1.2.6 contains a very important fix. Download Wicket now! http://wicketframework.org
Re: VOTE: EmptyPanel
+1, another class I can remove from our project :) On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: so i propose a vote to add this. i'm +1. Eelco Hillenius wrote: > > Yeah. I actually think I proposed something like this, or at least > +1-ed one at more than a year ago. You'll have to dig in the archives > to find out why other people didn't agree back then, but I still think > it's much easier for users to discover something just because it has > an obvious name, and not to worry about that one extra class. > > Eelco > > > On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: >> >> In my work project, I've added and frequently use an EmptyPanel which is >> simply a panel with empty markup. Although you can do the same thing >> with >> WebMarkupContainer or implement this yourself, it does seem like a nice >> conceptual addition, particularly for newbies who might not think "hmm... >> i >> want an empty panel instead of this fancy panel if the user isn't logged >> in... oh WebMarkupContainer looks about right..." ;-) Anyway, I thought >> I'd >> mention it in case others feel this would be a nice addition to core. >> -- >> View this message in context: >> http://www.nabble.com/EmptyPanel--tf3692546.html#a10324363 >> Sent from the Wicket - Dev mailing list archive at Nabble.com. >> >> > > -- View this message in context: http://www.nabble.com/EmptyPanel--tf3692546.html#a10333463 Sent from the Wicket - Dev mailing list archive at Nabble.com. -- Learn Wicket at ApacheCon Europe: http://apachecon.com Join the wicket community at irc.freenode.net: ##wicket Wicket 1.2.6 contains a very important fix. Download Wicket now! http://wicketframework.org
Re: VOTE: EmptyPanel
its a bit redundent api but because of the naming i guess its is fine to have. johan On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: so i propose a vote to add this. i'm +1. Eelco Hillenius wrote: > > Yeah. I actually think I proposed something like this, or at least > +1-ed one at more than a year ago. You'll have to dig in the archives > to find out why other people didn't agree back then, but I still think > it's much easier for users to discover something just because it has > an obvious name, and not to worry about that one extra class. > > Eelco > > > On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: >> >> In my work project, I've added and frequently use an EmptyPanel which is >> simply a panel with empty markup. Although you can do the same thing >> with >> WebMarkupContainer or implement this yourself, it does seem like a nice >> conceptual addition, particularly for newbies who might not think "hmm... >> i >> want an empty panel instead of this fancy panel if the user isn't logged >> in... oh WebMarkupContainer looks about right..." ;-) Anyway, I thought >> I'd >> mention it in case others feel this would be a nice addition to core. >> -- >> View this message in context: >> http://www.nabble.com/EmptyPanel--tf3692546.html#a10324363 >> Sent from the Wicket - Dev mailing list archive at Nabble.com. >> >> > > -- View this message in context: http://www.nabble.com/EmptyPanel--tf3692546.html#a10333463 Sent from the Wicket - Dev mailing list archive at Nabble.com.
Re: VOTE: EmptyPanel
+1 This is something I add to figure out how to do myself with a WebMarkupContainer, would have been easier with what you're proposing. Xavier On 5/5/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: +1 Eelco On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > > so i propose a vote to add this. i'm +1. > > > Eelco Hillenius wrote: > > > > Yeah. I actually think I proposed something like this, or at least > > +1-ed one at more than a year ago. You'll have to dig in the archives > > to find out why other people didn't agree back then, but I still think > > it's much easier for users to discover something just because it has > > an obvious name, and not to worry about that one extra class. > > > > Eelco > > > > > > On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > >> > >> In my work project, I've added and frequently use an EmptyPanel which is > >> simply a panel with empty markup. Although you can do the same thing > >> with > >> WebMarkupContainer or implement this yourself, it does seem like a nice > >> conceptual addition, particularly for newbies who might not think "hmm... > >> i > >> want an empty panel instead of this fancy panel if the user isn't logged > >> in... oh WebMarkupContainer looks about right..." ;-) Anyway, I thought > >> I'd > >> mention it in case others feel this would be a nice addition to core. > >> -- > >> View this message in context: > >> http://www.nabble.com/EmptyPanel--tf3692546.html#a10324363 > >> Sent from the Wicket - Dev mailing list archive at Nabble.com. > >> > >> > > > > > > -- > View this message in context: http://www.nabble.com/EmptyPanel--tf3692546.html#a10333463 > Sent from the Wicket - Dev mailing list archive at Nabble.com. > > -- Learn Ivy at ApacheCon: http://www.eu.apachecon.com/ Manage your dependencies with Ivy! http://incubator.apache.org/ivy/
Re: VOTE: EmptyPanel
+1 Eelco On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: so i propose a vote to add this. i'm +1. Eelco Hillenius wrote: > > Yeah. I actually think I proposed something like this, or at least > +1-ed one at more than a year ago. You'll have to dig in the archives > to find out why other people didn't agree back then, but I still think > it's much easier for users to discover something just because it has > an obvious name, and not to worry about that one extra class. > > Eelco > > > On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: >> >> In my work project, I've added and frequently use an EmptyPanel which is >> simply a panel with empty markup. Although you can do the same thing >> with >> WebMarkupContainer or implement this yourself, it does seem like a nice >> conceptual addition, particularly for newbies who might not think "hmm... >> i >> want an empty panel instead of this fancy panel if the user isn't logged >> in... oh WebMarkupContainer looks about right..." ;-) Anyway, I thought >> I'd >> mention it in case others feel this would be a nice addition to core. >> -- >> View this message in context: >> http://www.nabble.com/EmptyPanel--tf3692546.html#a10324363 >> Sent from the Wicket - Dev mailing list archive at Nabble.com. >> >> > > -- View this message in context: http://www.nabble.com/EmptyPanel--tf3692546.html#a10333463 Sent from the Wicket - Dev mailing list archive at Nabble.com.
VOTE: EmptyPanel
so i propose a vote to add this. i'm +1. Eelco Hillenius wrote: > > Yeah. I actually think I proposed something like this, or at least > +1-ed one at more than a year ago. You'll have to dig in the archives > to find out why other people didn't agree back then, but I still think > it's much easier for users to discover something just because it has > an obvious name, and not to worry about that one extra class. > > Eelco > > > On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: >> >> In my work project, I've added and frequently use an EmptyPanel which is >> simply a panel with empty markup. Although you can do the same thing >> with >> WebMarkupContainer or implement this yourself, it does seem like a nice >> conceptual addition, particularly for newbies who might not think "hmm... >> i >> want an empty panel instead of this fancy panel if the user isn't logged >> in... oh WebMarkupContainer looks about right..." ;-) Anyway, I thought >> I'd >> mention it in case others feel this would be a nice addition to core. >> -- >> View this message in context: >> http://www.nabble.com/EmptyPanel--tf3692546.html#a10324363 >> Sent from the Wicket - Dev mailing list archive at Nabble.com. >> >> > > -- View this message in context: http://www.nabble.com/EmptyPanel--tf3692546.html#a10333463 Sent from the Wicket - Dev mailing list archive at Nabble.com.