Re: [Libguestfs] [PATCH libnbd] README: Document additional packages

2023-04-17 Thread Nir Soffer
On Mon, Apr 17, 2023 at 7:38 PM Laszlo Ersek wrote: > > On 4/17/23 18:36, Nir Soffer wrote: > > When building from git we need autoconf, automake and libtool. > > > > Signed-off-by: Nir Soffer > > --- > > README.md | 7 +++ > > 1 file changed, 7 in

[Libguestfs] [PATCH libnbd] README: Document additional packages

2023-04-17 Thread Nir Soffer
When building from git we need autoconf, automake and libtool. Signed-off-by: Nir Soffer --- README.md | 7 +++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index c7166613..42a187c0 100644 --- a/README.md +++ b/README.md @@ -32,10 +32,17 @@ ## License very liberal

Re: RFR: JDK-8305885: Use ReadOnly*PropertyBase class where possible [v4]

2023-04-17 Thread Nir Lisker
On Mon, 17 Apr 2023 07:23:40 GMT, John Hendrikx wrote: >> These changes use base classes for custom properties where possible for the >> `ExpressionHelper` logic instead of duplicating these each time. > > John Hendrikx has updated the pull request incrementally with one additional > commit

Re: RFR: JDK-8305885: Use ReadOnly*PropertyBase class where possible [v4]

2023-04-17 Thread Nir Lisker
On Mon, 17 Apr 2023 07:23:40 GMT, John Hendrikx wrote: >> These changes use base classes for custom properties where possible for the >> `ExpressionHelper` logic instead of duplicating these each time. > > John Hendrikx has updated the pull request incrementally with one additional > commit

Re: RFR: JDK-8305885: Use ReadOnly*PropertyBase class where possible [v2]

2023-04-17 Thread Nir Lisker
On Fri, 14 Apr 2023 09:47:45 GMT, John Hendrikx wrote: >> These changes use base classes for custom properties where possible for the >> `ExpressionHelper` logic instead of duplicating these each time. > > John Hendrikx has refreshed the contents of this pull request, and previous > commits

Re: RFR: 8306021: Add event handler management to EventTarget [v4]

2023-04-17 Thread Nir Lisker
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: JDK-8305885: Use ReadOnly*PropertyBase class where possible [v2]

2023-04-16 Thread Nir Lisker
On Sat, 15 Apr 2023 01:36:48 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/TreeShowingExpression.java >> line 44: >> >>> 42: * an observable form. >>> 43: */ >>> 44: public class TreeShowingExpression extends ReadOnlyBooleanPropertyBase { >> >>

Re: RFR: 8306021: Add event handler management to EventTarget [v2]

2023-04-16 Thread Nir Lisker
On Mon, 17 Apr 2023 04:51:03 GMT, Michael Strauß wrote: > I don't know what "visual events" are, maybe input events? I thought something like that too, including scroll and touch events. Maybe @kevinrushforth knows. > Anyway, the added value of this entire javadoc seems to be rather low, I'm

Re: RFR: 8306021: Add event handler management to EventTarget [v2]

2023-04-16 Thread Nir Lisker
On Sat, 15 Apr 2023 18:01:28 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs

2023-04-15 Thread Nir Lisker
On Tue, 4 Apr 2023 15:22:48 GMT, John Hendrikx wrote: > This provides and uses a new implementation of `ExpressionHelper`, called > `ListenerManager` with improved semantics. > > # Behavior > > |Listener...|ExpressionHelper|ListenerManager| > |---|---|---| > |Invocation Order|In order they

Re: RFR: JDK-8224260: ChangeListener not triggered when adding a new listener in invalidated method [v2]

2023-04-11 Thread Nir Lisker
On Tue, 11 Apr 2023 07:57:56 GMT, John Hendrikx wrote: >> Fixes three issues in ExpressionHelper: >> >> - Current Value was not retained when changing from SingleChange to Generic, >> this can lead to missed changes >> - Current Value was not retained when changing from Generic to

Update javadoc tool version?

2023-04-10 Thread Nir Lisker
Hi, I noticed that the JDK's javadoc contains a 'NEW' section [1], but JavaFX's docs don't have it. Do we need to update the javadoc tool? [1] https://docs.oracle.com/en/java/javase/19/docs/api/new-list.html - Nir

Re: RFR: JDK-8303897 ObservableValue's when binding should only invalidate when strictly needed [v3]

2023-04-10 Thread Nir Lisker
On Mon, 10 Apr 2023 00:14:31 GMT, John Hendrikx wrote: > Well, I am just following the specification here, but JavaFX itself isn't... > > We may need to make a decision here. JavaFX is not consistent itself where it > applies `equals` and where it uses reference equality: Alright, so this is

Re: RFR: JDK-8224260: ChangeListener not triggered when adding a new listener in invalidated method

2023-04-10 Thread Nir Lisker
On Thu, 30 Mar 2023 21:53:48 GMT, John Hendrikx wrote: > Fixes three issues in ExpressionHelper: > > - Current Value was not retained when changing from SingleChange to Generic, > this can lead to missed changes > - Current Value was not retained when changing from Generic to SingleChange, >

Re: RFR: JDK-8303897 ObservableValue's when binding should only invalidate when strictly needed [v3]

2023-04-09 Thread Nir Lisker
On Sun, 9 Apr 2023 21:27:36 GMT, John Hendrikx wrote: >> Description copied from issue: >> >> There are up to two additional invalidations performed that really should be >> avoided, causing downstream fluent bindings to be recomputed with the same >> values. This is very confusing as these

Re: RFR: JDK-8303897 ObservableValue's when binding should only invalidate when strictly needed [v2]

2023-04-09 Thread Nir Lisker
On Sun, 9 Apr 2023 09:04:15 GMT, John Hendrikx wrote: > > Also, I really wish we could make `add/removeListener` throw on `null` :) > > You mean immediately? Because the `null` check is done by `ExpressionHelper` > already. What I wish for is that `removeListener` would throw when removing >

Re: RFR: JDK-8303897 ObservableValue's when binding should only invalidate when strictly needed [v2]

2023-04-09 Thread Nir Lisker
On Fri, 7 Apr 2023 06:36:50 GMT, John Hendrikx wrote: >> Description copied from issue: >> >> There are up to two additional invalidations performed that really should be >> avoided, causing downstream fluent bindings to be recomputed with the same >> values. This is very confusing as these

Re: RFR: JDK-8303897 ObservableValue's when binding should only invalidate when strictly needed [v2]

2023-04-08 Thread Nir Lisker
On Fri, 7 Apr 2023 06:36:50 GMT, John Hendrikx wrote: >> Description copied from issue: >> >> There are up to two additional invalidations performed that really should be >> avoided, causing downstream fluent bindings to be recomputed with the same >> values. This is very confusing as these

Re: RFR: JDK-8224260: ChangeListener not triggered when adding a new listener in invalidated method

2023-04-07 Thread Nir Lisker
On Thu, 30 Mar 2023 21:53:48 GMT, John Hendrikx wrote: > Fixes three issues in ExpressionHelper: > > - Current Value was not retained when changing from SingleChange to Generic, > this can lead to missed changes > - Current Value was not retained when changing from Generic to SingleChange, >

Re: RFR: 8283063: Optimize Observable{List/Set/Map}Wrapper.retainAll/removeAll [v5]

2023-04-04 Thread Nir Lisker
On Sun, 2 Apr 2023 23:50:15 GMT, Michael Strauß wrote: >> `Observable{List/Set/Map}Wrapper.retainAll/removeAll` can be optimized for >> some edge cases. >> >> 1. `removeAll(c)`: >> This is a no-op if 'c' is empty. >> For `ObservableListWrapper`, returning early skips an object allocation. For

Re: RFR: 8283063: Optimize Observable{List/Set/Map}Wrapper.retainAll/removeAll [v4]

2023-04-03 Thread Nir Lisker
On Sat, 1 Apr 2023 18:14:11 GMT, Michael Strauß wrote: >> `Observable{List/Set/Map}Wrapper.retainAll/removeAll` can be optimized for >> some edge cases. >> >> 1. `removeAll(c)`: >> This is a no-op if 'c' is empty. >> For `ObservableListWrapper`, returning early skips an object allocation. For

Re: RFR: 8304323 Provide infrastructure to make it possible for properties to delay listener registration

2023-03-22 Thread Nir Lisker
On Wed, 22 Mar 2023 14:10:20 GMT, Kevin Rushforth wrote: > @nlisker do you also want to review this? Yes, but it will take me a bit of time to get to it. - PR Comment: https://git.openjdk.org/jfx/pull/1023#issuecomment-1479756994

Re: [jfx20] RFR: 8304359: Create release notes for JavaFX 20 [v2]

2023-03-16 Thread Nir Lisker
On Thu, 16 Mar 2023 17:14:28 GMT, Kevin Rushforth wrote: >> Release notes for JavaFX 20, including one important change to note (the >> requirement of JDK 17 as the minimum needed to run JavaFX 20) and the list >> of enhancements and bugs fixed in this release. >> >> Note: This PR is targeted

Re: [Libguestfs] [PATCH v2 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length

2023-03-06 Thread Nir Soffer
;$sob" "$1" You can also use a pre-commit hook but the commit-msg hook is more convenient. And in github you can add the DCO application to the project: https://github.com/apps/dco Once installed it will check that all commits are signed off, and provide helpful error messages to contributors. Nir

Re: [Libguestfs] [PATCH v2 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length

2023-03-06 Thread Nir Soffer
;$sob" "$1" You can also use a pre-commit hook but the commit-msg hook is more convenient. And in github you can add the DCO application to the project: https://github.com/apps/dco Once installed it will check that all commits are signed off, and provide helpful error messages to contributors. Nir

Re: [Libguestfs] [PATCH v2 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length

2023-03-06 Thread Nir Soffer
;$sob" "$1" You can also use a pre-commit hook but the commit-msg hook is more convenient. And in github you can add the DCO application to the project: https://github.com/apps/dco Once installed it will check that all commits are signed off, and provide helpful error messages to contr

Re: [Libguestfs] [PATCH] docs: Prefer 'cookie' over 'handle'

2023-03-04 Thread Nir Soffer
make this more clear? > Makes no difference to implementations (other than older code > still using 'handle' may be slightly harder to tie back to the spec). To avoid confusion with older code that carefully used "handle" to match the spec, maybe add a note that "cookie" was named "handle" before? Nir

Re: [Libguestfs] [PATCH] docs: Prefer 'cookie' over 'handle'

2023-03-04 Thread Nir Soffer
make this more clear? > Makes no difference to implementations (other than older code > still using 'handle' may be slightly harder to tie back to the spec). To avoid confusion with older code that carefully used "handle" to match the spec, maybe add a note that &qu

Re: [Libguestfs] Checksums and other verification

2023-03-02 Thread Nir Soffer
On Thu, Mar 2, 2023 at 10:46 AM Richard W.M. Jones wrote: > > On Mon, Feb 27, 2023 at 07:09:33PM +0200, Nir Soffer wrote: > > On Mon, Feb 27, 2023 at 6:41 PM Richard W.M. Jones > > wrote: > > > I think it would be more useful if (or in addition) it could compute >

Re: [Libguestfs] Checksums and other verification

2023-02-28 Thread Nir Soffer
) values, and > maybe determine repeating patterns in the plaintext. I'm not a > cryptographer so I can't exactly show what security property is broken > by separating the IV from block[n]. > > > (This is what blkhash solves, but unfortunately the output isn't > > compatible with standard hashes.) > &

Re: [Libguestfs] Checksums and other verification

2023-02-27 Thread Nir Soffer
On Mon, Feb 27, 2023 at 6:41 PM Richard W.M. Jones wrote: > > On Mon, Feb 27, 2023 at 04:24:33PM +0200, Nir Soffer wrote: > > On Mon, Feb 27, 2023 at 3:56 PM Richard W.M. Jones > > wrote: > > > > > > > > > https://github.com/kubevirt/containerized-

Re: [Libguestfs] Checksums and other verification

2023-02-27 Thread Nir Soffer
ckage it for Fedora/CentOS Stream. I also work on "qemu-img checksum", getting more reviews on this can help: Lastest version: https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00971.html Last reveiw are here: https://lists.nongnu.org/archive/html/qemu-block/2022-12/ More work is nee

[jfx20] Integrated: 8293587: Fix mistakes in FX API docs

2023-02-24 Thread Nir Lisker
On Mon, 6 Feb 2023 23:00:17 GMT, Nir Lisker wrote: > Fixes and cleanup in the areas in the linked issue. This pull request has now been integrated. Changeset: 7bf2372b Author: Nir Lisker URL: https://git.openjdk.org/jfx/commit/7bf2372baf8ea719b8b611cd1476596d8c141c50 Stats:

Re: [Libguestfs] [PATCH 1/2] python: Avoid crash if callback parameters cannot be built

2023-02-20 Thread Nir Soffer
reased. I > distinctly remember that, because it surprised me -- I actually recalled > an *even earlier* experience reading the documentation, which had again > stated that "O" would increase the reference count. Maybe here: https://docs.python.org/2/c-api/arg.html#building-values Looks like another incompatibility between python 2 and 3. Nir ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v6]

2023-02-18 Thread Nir Lisker
On Wed, 15 Feb 2023 09:46:22 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v6]

2023-02-18 Thread Nir Lisker
On Wed, 15 Feb 2023 09:46:22 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v5]

2023-02-18 Thread Nir Lisker
On Sat, 18 Feb 2023 19:29:05 GMT, John Hendrikx wrote: > Confusing me again here :-) Did you mean to say "breadth-first" where you > said "depth-first" ? > > Breadth first is for sure a lot easier, as the old values are much easier to > get correct for it. > > I've given depth first some

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v5]

2023-02-18 Thread Nir Lisker
On Tue, 14 Feb 2023 23:27:07 GMT, John Hendrikx wrote: > I couldn't quite see which you prefer here; you said "This one makes sense" > but not quite sure which version it refers to (I suppose the depth first > version?) I should have said "this one makes sense **too**". The point was that

RFR: 8302816: Refactor sorting-related classes

2023-02-18 Thread Nir Lisker
Most of the changes revolve around unifying the sorting methods for a collection with `Comparable` elements with sorting methods that take an external `Comparator` by passing `Comparator.naturalOrder()` from the former to the latter. This eliminates method duplication and some warnings

Re: CFV: New OpenJFX Reviewer: Jose Pereda

2023-02-17 Thread Nir Lisker
Vote: Yes On Fri, Feb 17, 2023, 04:54 Philip Race wrote: > Vote: yes > > -phil > >

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v2]

2023-02-14 Thread Nir Lisker
On Sun, 5 Feb 2023 20:11:35 GMT, John Hendrikx wrote: > I don't think we should care about depth-first, breadth-first. The only thing > that I think is important here is that the contract of ChangeListener is > respected. I think that that contract should be: ... I'll be more concrete. Here

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages [v5]

2023-02-12 Thread Nir Lisker
On Sun, 12 Feb 2023 21:49:11 GMT, John Hendrikx wrote: >> Packages fixed: >> - com.sun.javafx.binding >> - com.sun.javafx.collections >> - javafx.beans >> - javafx.beans.binding >> - javafx.collections >> - javafx.collections.transformation > > John Hendrikx has updated the pull request

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages [v4]

2023-02-12 Thread Nir Lisker
On Sun, 1 Jan 2023 15:25:01 GMT, John Hendrikx wrote: >> modules/javafx.base/src/main/java/javafx/collections/FXCollections.java line >> 1640: >> >>> 1638: @Override >>> 1639: public Iterator iterator() { >>> 1640: return new Iterator<>() { >> >> Here the empty

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages [v4]

2023-02-12 Thread Nir Lisker
On Wed, 8 Feb 2023 15:05:46 GMT, John Hendrikx wrote: >> Packages fixed: >> - com.sun.javafx.binding >> - com.sun.javafx.collections >> - javafx.beans >> - javafx.beans.binding >> - javafx.collections >> - javafx.collections.transformation > > John Hendrikx has updated the pull request with a

[ovirt-users] Re: ImageIO Performance

2023-02-11 Thread Nir Soffer
On Thu, Feb 9, 2023 at 7:03 PM Nir Soffer wrote: > > On Mon, Feb 6, 2023 at 10:00 AM Jean-Louis Dupond via Users > wrote: > > > > Hi All, > > > > We backup our VM's with a custom script based on the > > https://github.com/oVirt/python-ovirt-engine-sdk4/blob

[ovirt-users] Re: ImageIO Performance

2023-02-09 Thread Nir Soffer
On Thu, Feb 9, 2023 at 7:03 PM Nir Soffer wrote: > > On Mon, Feb 6, 2023 at 10:00 AM Jean-Louis Dupond via Users > wrote: > The easiest way would be to enable debug logs - it will be even slower, > but we will see these logs showing all extents: Using the --debug option R

[ovirt-users] Re: ImageIO Performance

2023-02-09 Thread Nir Soffer
ll be 4 threads on the server size serving the data. Please share debug log of a slow backup, and info about the backup image storage for example, is this local file system or NFS? Nir ___ Users mailing list -- users@ovirt.org To unsubscribe send an

Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs [v5]

2023-02-07 Thread Nir Lisker
> Fixes and cleanup in the areas in the linked issue. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Addressed review comments - Changes: - all: https://git.openjdk.org/jfx/pull/1025/files - new: ht

Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs [v4]

2023-02-07 Thread Nir Lisker
> Fixes and cleanup in the areas in the linked issue. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Update modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java - Changes: - all: ht

Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs [v4]

2023-02-07 Thread Nir Lisker
On Tue, 7 Feb 2023 19:52:14 GMT, Kevin Rushforth wrote: >> A specialized layout... +1 > > +1 from me as well. Suggestion: * A specialized layout for rich text. - PR: https://git.openjdk.org/jfx/pull/1025

Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs [v3]

2023-02-07 Thread Nir Lisker
On Tue, 7 Feb 2023 13:05:21 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Update >> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java >

Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs [v3]

2023-02-07 Thread Nir Lisker
On Tue, 7 Feb 2023 12:25:14 GMT, John Hendrikx wrote: >> Nir Lisker has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Update >> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java >

Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs [v3]

2023-02-07 Thread Nir Lisker
On Tue, 7 Feb 2023 12:17:43 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Update >> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java >

Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs [v3]

2023-02-07 Thread Nir Lisker
> Fixes and cleanup in the areas in the linked issue. Nir Lisker has updated the pull request incrementally with three additional commits since the last revision: - Update modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java Co-authored-by: John Hendrikx - Upd

Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs [v2]

2023-02-07 Thread Nir Lisker
> Fixes and cleanup in the areas in the linked issue. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Update modules/javafx.controls/src/main/java/javafx/scene/control/ListView.java Co-authored-by: John Hendr

Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs

2023-02-06 Thread Nir Lisker
On Mon, 6 Feb 2023 23:00:17 GMT, Nir Lisker wrote: > Fixes and cleanup in the areas in the linked issue. Integrating can wait until a bit before the release to allow for more mistakes to be included. - PR: https://git.openjdk.org/jfx/pull/1025

[jfx20] RFR: 8293587: Fix mistakes in FX API docs

2023-02-06 Thread Nir Lisker
Fixes and cleanup in the areas in the linked issue. - Commit messages: - Initial commit Changes: https://git.openjdk.org/jfx/pull/1025/files Webrev: https://webrevs.openjdk.org/?repo=jfx=1025=00 Issue: https://bugs.openjdk.org/browse/JDK-8293587 Stats: 50 lines in 6 files

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages [v2]

2023-02-05 Thread Nir Lisker
On Sun, 1 Jan 2023 16:08:15 GMT, John Hendrikx wrote: >> Packages fixed: >> - com.sun.javafx.binding >> - com.sun.javafx.collections >> - javafx.beans >> - javafx.beans.binding >> - javafx.collections >> - javafx.collections.transformation > > John Hendrikx has updated the pull request

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v2]

2023-02-05 Thread Nir Lisker
On Tue, 3 Jan 2023 09:42:05 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v2]

2023-02-05 Thread Nir Lisker
On Tue, 3 Jan 2023 09:42:05 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a

Re: RFR: 8290765: Remove parent disabled/treeVisible listeners [v5]

2023-02-03 Thread Nir Lisker
On Fri, 3 Feb 2023 23:31:24 GMT, Michael Strauß wrote: >> `Node` adds InvalidationListeners to its parent's `disabled` and >> `treeVisible` properties and calls its own `updateDisabled()` and >> `updateTreeVisible(boolean)` methods when the property values change. >> >> These listeners are

Re: RFR: 8290765: Remove parent disabled/treeVisible listeners [v4]

2023-02-03 Thread Nir Lisker
On Sat, 28 Jan 2023 16:24:30 GMT, Michael Strauß wrote: >> `Node` adds InvalidationListeners to its parent's `disabled` and >> `treeVisible` properties and calls its own `updateDisabled()` and >> `updateTreeVisible(boolean)` methods when the property values change. >> >> These listeners are

Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of [v3]

2023-02-01 Thread Nir Lisker
On Wed, 1 Feb 2023 23:50:07 GMT, Glavo wrote: >> `List.of` is cleaner, and can slightly reduce the memory footprint for lists >> of one or two elements. >> >> Because `List.of` can only store non-null elements, I have only replaced a >> few usage. >> >> Can someone open an Issue on JBS for

Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of [v2]

2023-02-01 Thread Nir Lisker
On Wed, 1 Feb 2023 23:38:57 GMT, Glavo wrote: >> `List.of` is cleaner, and can slightly reduce the memory footprint for lists >> of one or two elements. >> >> Because `List.of` can only store non-null elements, I have only replaced a >> few usage. >> >> Can someone open an Issue on JBS for

Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of

2023-02-01 Thread Nir Lisker
On Wed, 1 Feb 2023 16:54:30 GMT, John Hendrikx wrote: >> modules/javafx.media/src/main/java/com/sun/media/jfxmedia/Media.java line >> 103: >> >>> 101: } >>> 102: } >>> 103: return returnValue; >> >> This method can be reduced to >> >> public List getTracks() {

Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of

2023-02-01 Thread Nir Lisker
On Wed, 1 Feb 2023 15:11:57 GMT, Glavo wrote: > I have considered this, but I didn't make this change because I was worried > that there would be less descriptive information when null was encountered. I think it's fine. The method is documented to throw and it happens immediately on entry.

Re: [External] : Re: Some classes could be sealed

2023-02-01 Thread Nir Lisker
e. So this doesn't seem > feasible. > > We could still seal Shape, Shape3D, LightBase, and Material, since all > permitted implementation are in the javafx.graphics module. It may or may > not be worth doing that. > > -- Kevin > > > On 2/1/2023 9:45 AM, Nir Lisker

Re: [External] : Re: Some classes could be sealed

2023-02-01 Thread Nir Lisker
bout the > tests that extend Node and run in the unnamed module. So this doesn't seem > feasible. > > We could still seal Shape, Shape3D, LightBase, and Material, since all > permitted implementation are in the javafx.graphics module. It may or may > not be worth doing that. > > -

Re: Some classes could be sealed

2023-02-01 Thread Nir Lisker
I'll add that internal classes, mostly NG___ peers, can also benefit from sealing. NGLightBase is an example. Material is another public class that can be sealed. On Wed, Feb 1, 2023 at 7:37 PM Kevin Rushforth wrote: > I agree that we should only seal existing classes that could not have been

Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of

2023-02-01 Thread Nir Lisker
On Thu, 26 Jan 2023 05:30:56 GMT, Glavo wrote: > `List.of` is cleaner, and can slightly reduce the memory footprint for lists > of one or two elements. > > Because `List.of` can only store non-null elements, I have only replaced a > few usage. > > Can someone open an Issue on JBS for me?

Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of

2023-02-01 Thread Nir Lisker
On Wed, 1 Feb 2023 11:21:04 GMT, Glavo wrote: >> Filed: https://bugs.openjdk.org/browse/JDK-8301604. Please let me know if >> the issue is not reported correctly. > > @theaoqi Thank you very much! @Glavo If you can't access JBS, you can submit a report via bugreport.java.com. @theaoqi If you

Re: RFR: 8138842: TableViewSelectionModel.selectIndices does not select index 0 [v2]

2023-02-01 Thread Nir Lisker
On Wed, 1 Feb 2023 09:17:33 GMT, Karthik P K wrote: >> I think it is also pretty clear the original author intended to check >> `rows.length == 0` and made the mistake that it would be called with `rows >> == null` when there are no further indices specified, which is incorrect. > > I believe

Re: RFR: 8138842: TableViewSelectionModel.selectIndices does not select index 0

2023-01-31 Thread Nir Lisker
On Tue, 31 Jan 2023 14:40:00 GMT, Karthik P K wrote: > In `selectIndices` method, zero length array is not considered while ignoring > row number given as parameter. > > Updated the code to consider both null and zero length array in the condition > before ignoring the row value given as

Re: RFR: 8138842: TableViewSelectionModel.selectIndices does not select index 0

2023-01-31 Thread Nir Lisker
On Tue, 31 Jan 2023 14:40:00 GMT, Karthik P K wrote: > In `selectIndices` method, zero length array is not considered while ignoring > row number given as parameter. > > Updated the code to consider both null and zero length array in the condition > before ignoring the row value given as

Re: [Libguestfs] [libnbd PATCH v2 3/3] nbdsh: Improve --help and initial banner contents.

2023-01-31 Thread Nir Soffer
when it breaks? I'm not sure what is the issue, but usually if you have a global variable created only in some flows, adding: thing = None At the start of the module makes sure that the name exists later, regardless of the flow taken. Code can take the ri

Re: [Libguestfs] [PATCH v2v v2] -o rhv-upload: Improve error message for invalid or missing -os parameter

2023-01-28 Thread Nir Soffer
detaches the domain from the data center in the window after the precheck completes and before the transfer starts. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1986386 > Reported-by: Junqin Zhou > Thanks: Nir Soffer > --- > output/rhv-upload-precheck.py | 27

Re: [Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain does not exist

2023-01-27 Thread Nir Soffer
On Fri, Jan 27, 2023 at 1:18 PM Nir Soffer wrote: > > On Thu, Jan 26, 2023 at 2:31 PM Richard W.M. Jones wrote: > > > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1986386 > > Reported-by: Junqin Zhou > > --- > > output/rhv-upload-precheck.py | 7 +

Re: [Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain does not exist

2023-01-27 Thread Nir Soffer
t; +raise RuntimeError("The storage domain ‘%s’ does not exist" % > + params['output_storage']) The fix is safe and makes sense. Not sure why we list all storage domains when we already know the name, maybe Albert would like to clean up this mess later. Nir ___

Re: [Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain

2023-01-27 Thread Nir Soffer
t; As I say above, I don't especially care about any of this. I'm not working on RHV since August 2022. Adding Albert who is current RHV storage maintainer. Nir ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list [v3]

2023-01-24 Thread Nir Lisker
On Tue, 24 Jan 2023 09:59:48 GMT, Ajit Ghaisas wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/ListView.java >> line 152: >> >>> 150: * Warning: Nodes should not be inserted directly into the items >>> list >>> 151: * ListView allows for the items list to contain

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list [v4]

2023-01-24 Thread Nir Lisker
On Tue, 24 Jan 2023 10:35:36 GMT, Ajit Ghaisas wrote: > > > > @nlisker, Can you please file an issue explaining how exactly you would like > `ListView` documentation to be restructured? Yes, I'll probably work on it during RDP 2. It's not the only control I want to go over. -

Re: TableViewBuilder idea

2023-01-22 Thread Nir Lisker
Isn't this something that an external library can do? I would think that writing an adapter that can read JPA annotations is the way to go. After all, most entities are not written with JavaFX properties. On Sun, Jan 22, 2023 at 2:08 AM Thiago Milczarek Sayão < thiago.sa...@gmail.com> wrote: >

Re: RFC: new property in ToggleGroup

2023-01-21 Thread Nir Lisker
We already have ToggleButton: Unlike RadioButtons, ToggleButtons in a ToggleGroup do not attempt to force > at least one selected ToggleButton in the group. That is, if a ToggleButton is selected, clicking on it will cause it to > become unselected. With RadioButton, clicking on the selected

Re: RFC: new property in ToggleGroup

2023-01-21 Thread Nir Lisker
I don't see it being especially useful. GUI's tend to work this way. I remember it was the same in Swing. On Sat, Jan 21, 2023 at 1:41 AM Kevin Rushforth wrote: > > > On 1/20/2023 2:57 PM, Andy Goryachev wrote: > > I just want to add one thing - the initial state of RadioMenuItems added > to a

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list [v3]

2023-01-20 Thread Nir Lisker
On Wed, 18 Jan 2023 09:25:08 GMT, Ajit Ghaisas wrote: >> This PR adds a warning about inserting Nodes directly into the virtualized >> containers such as ListView, TreeView, TableView and TreeTableView. It also >> adds code snippets showing the recommended pattern of using a custom cell >>

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list [v4]

2023-01-20 Thread Nir Lisker
On Fri, 20 Jan 2023 11:16:04 GMT, Ajit Ghaisas wrote: >> This PR adds a warning about inserting Nodes directly into the virtualized >> containers such as ListView, TreeView, TableView and TreeTableView. It also >> adds code snippets showing the recommended pattern of using a custom cell >>

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list

2023-01-14 Thread Nir Lisker
On Fri, 13 Jan 2023 12:32:53 GMT, Ajit Ghaisas wrote: > This PR adds a warning about inserting Nodes directly into the virtualized > containers such as ListView, TreeView, TableView and TreeTableView. It also > adds code snippets showing the recommended pattern of using a custom cell >

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list

2023-01-14 Thread Nir Lisker
On Fri, 13 Jan 2023 12:32:53 GMT, Ajit Ghaisas wrote: > This PR adds a warning about inserting Nodes directly into the virtualized > containers such as ListView, TreeView, TableView and TreeTableView. It also > adds code snippets showing the recommended pattern of using a custom cell >

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v11]

2023-01-11 Thread Nir Lisker
On Sun, 25 Dec 2022 04:04:40 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time i

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v11]

2023-01-10 Thread Nir Lisker
On Sun, 25 Dec 2022 04:04:40 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time i

Integrated: 8217853: Cleanup in the D3D native pipeline

2023-01-10 Thread Nir Lisker
On Mon, 2 May 2022 16:05:08 GMT, Nir Lisker wrote: > Refactoring and renaming changes to some of the D3D pipeline files and a few > changes on the Java side. These are various "leftovers" from previous issues > that we didn't want to touch at the time in order t

Re: CheckBoxTreeItem behavior - independent property

2023-01-04 Thread Nir Lisker
code that makes it not worth doing this? To me it looks like a bug, but the docs don't say anything about this point. On Sat, Nov 19, 2022 at 9:28 AM Nir Lisker wrote: > Hi, > > Another issue I stumbled across is the usage of the Independent property > on CheckBoxTreeItem. T

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v11]

2023-01-04 Thread Nir Lisker
On Sun, 25 Dec 2022 04:04:40 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time i

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v11]

2023-01-04 Thread Nir Lisker
On Sun, 25 Dec 2022 04:04:40 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time i

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v3]

2023-01-04 Thread Nir Lisker
On Tue, 3 Jan 2023 23:56:12 GMT, Nir Lisker wrote: >> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after >> expand/collapse events. The graphics node needs to be released from the >> previous checkbox so that it doesn't serve as the graphics of more tha

Integrated: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-04 Thread Nir Lisker
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote: > A simple fix for the graphics of a `CheckBoxTreeCell` not showing after > expand/collapse events. The graphics node needs to be released from the > previous checkbox so that it doesn't serve as the graphics of more than one &

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages [v2]

2023-01-03 Thread Nir Lisker
On Sun, 1 Jan 2023 16:08:15 GMT, John Hendrikx wrote: >> Packages fixed: >> - com.sun.javafx.binding >> - com.sun.javafx.collections >> - javafx.beans >> - javafx.beans.binding >> - javafx.collections >> - javafx.collections.transformation > > John Hendrikx has updated the pull request

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v3]

2023-01-03 Thread Nir Lisker
simply expand and collapse the root note repeatedly > while it has a child. Before the fix the graphic will disappear after a few > tries, after the fix it won't. You can test other hierarchies as well by > adding children to the tree. Nir Lisker has updated the pull request incremental

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v2]

2023-01-03 Thread Nir Lisker
On Tue, 3 Jan 2023 23:39:36 GMT, Andy Goryachev wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added copyright header and changed package name > > tests/performance/check

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v2]

2023-01-03 Thread Nir Lisker
simply expand and collapse the root note repeatedly > while it has a child. Before the fix the graphic will disappear after a few > tries, after the fix it won't. You can test other hierarchies as well by > adding children to the tree. Nir Lisker has updated the pull request incremental

<    1   2   3   4   5   6   7   8   9   10   >