Re: [caiman-discuss] DC - VMC - how does one use a custom AI manifest ?

On 03/31/10 07:21 PM, Alok Aggarwal wrote: On Wed, 31 Mar 2010, Erik Lafever wrote: Thanks Alok, That is the file that I was looking for. Should DC "depend" on that package? Is there any reason the xml is not included in the distribution- constructor package? The manifest is really an A

Re: [caiman-discuss] DC - VMC - how does one use a custom AI manifest ?

On 04/ 1/10 01:40 PM, Erik Lafever wrote: - erik.lafe...@oracle.com wrote: > ----- joseph.vl...@oracle.com wrote: > >> On 03/31/10 07:21 PM, Alok Aggarwal wrote: >>> >>> On Wed, 31 Mar 2010, Erik Lafever wrote: >>> >>>> Thanks Alok,

Re: [caiman-discuss] Please review easy change to DC script

On 04/ 4/10 11:41 PM, Jack Schwartz wrote: Hi everyone. This easy webrev is for a fix to the DC finalizer script which copies files into the boot_archive. It fixes how whole-directories are excluded. I have tested this fix by having built several images during Driver Update testing. Webr

Re: [caiman-discuss] Please review easy change to DC script

On 04/ 5/10 10:44 AM, Keith Mitchell wrote: On 04/ 5/10 05:16 AM, joseph.vl...@oracle.com wrote: On 04/ 4/10 11:41 PM, Jack Schwartz wrote: Hi everyone. This easy webrev is for a fix to the DC finalizer script which copies files into the boot_archive. It fixes how whole-directories are

Re: [caiman-discuss] Code Review for 15511

On 04/ 7/10 01:33 PM, Karen Tung wrote: Hi Sue, line 265, since the values for user_pass is already retrieved in line 240. Wouldn't it be better to check that value? thanks, --Karen On 04/ 7/10 09:17 AM, Sue Sohn wrote: Could I please get a review for the changes to fix: 15511 - Provide

Re: [caiman-discuss] Code Review for 15511

On 04/ 7/10 02:18 PM, Sue Sohn wrote: On 04/07/10 10:56, joseph.vl...@oracle.com wrote: On 04/ 7/10 01:33 PM, Karen Tung wrote: Hi Sue, line 265, since the values for user_pass is already retrieved in line 240. Wouldn't it be better to check that value? thanks, --Karen On 04/ 7/10

[caiman-discuss] test

test please ignore ___ caiman-discuss mailing list caiman-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Re: [caiman-discuss] Please review easy change to DC script

On 04/22/10 06:20 PM, Jack Schwartz wrote: Hi Joe and Keith. Thanks for your comments. I've finally had time to go back and work on this. Below is IMHO a solution which addresses all of your concerns: On 04/ 5/10 07:44 AM, Keith Mitchell wrote: On 04/ 5/10 05:16 AM, jose

Re: [caiman-discuss] CR for AI & DC bugs related to Great Pkg Rename

On 04/27/10 07:47 PM, Keith Mitchell wrote: Hi all, I'd like to request a review of the following changes to DC and AI default manifests that change the packages listed from the old "SUNW" names to the current hierarchical pkg names: http://cr.opensolaris.org/~kemitche/pkg_rename Associated

Re: [caiman-discuss] Heads-up: slim_source pushes have more formalized testing requirements

On 05/ 7/10 06:17 PM, Keith Mitchell wrote: Hi all, In the interest of improving the stability of the slim_source gate, and providing tools for developers to more rapidly verify that code changes don't cause regressions in related components, the testing requirements that must be met prior to

Re: [caiman-discuss] Heads-up: slim_source pushes have more formalized testing requirements

On 05/10/10 04:11 PM, joseph.vl...@oracle.com wrote: On 05/ 7/10 06:17 PM, Keith Mitchell wrote: Hi all, In the interest of improving the stability of the slim_source gate, and providing tools for developers to more rapidly verify that code changes don't cause regressions in re

Re: [caiman-discuss] CR request for: 15835 AI fails to create zpool on root disk due to mounted ufs

On 05/11/10 05:28 AM, Jan Damborsky wrote: Hi, could I please ask for reviewing fix for following bug ? 15835 AI fails to create zpool on root disk due to mounted ufs webrev: http://cr.opensolaris.org/~dambi/bug-15835 Thank you very much, Jan Tests carried out: * AI images containing the fi

Re: [caiman-discuss] Checkpoint DOC node proposal

On 05/12/10 09:59 AM, Dave Miner wrote: On 05/12/10 07:11 AM, Darren Kenny wrote: This is how I remember it too :) As I understood it, from previous discussions, the actual Checkpoint to be executed are not part of the manifest[1], as such it there was no /need/ to store them in the DOC - of

Re: [caiman-discuss] Checkpoint DOC node proposal

On 05/13/10 10:15 AM, Dave Miner wrote: On 05/13/10 10:11 AM, joseph.vl...@oracle.com wrote: On 05/12/10 09:59 AM, Dave Miner wrote: On 05/12/10 07:11 AM, Darren Kenny wrote: This is how I remember it too :) As I understood it, from previous discussions, the actual Checkpoint to be executed

Re: [caiman-discuss] Requesting code review for 15866

On 05/13/10 11:35 AM, Glenn Lagasse wrote: Hi All, Could I get a quick review of my change to address 15866 please? It's very simple. I need to get this integrated into build 140 which Keith is delivering to tomorrow afternoon. http://cr.opensolaris.org/~glagasse/slim_15866/ http://defect.op

Re: [caiman-discuss] workaround for #11500 ?

On 05/13/10 09:03 AM, Jan Hlodan wrote: Hello, I hit this bug: https://defect.opensolaris.org/bz/show_bug.cgi?id=11500 Is there any workaround how to install 134a via AI? Thank you for answer. Regards, Jan Hlodan ___ caiman-discuss mailing list caim

Re: [caiman-discuss] AI Multihomed Implementation Plan

On 05/13/10 07:43 PM, cl...@opensolaris.org wrote: Hi all, Here's what I'm envisioning for the AI multihomed implementation plan. Please let me know your oppinion of it or if it looks like anything is missing. Thank you, Clay UI Impa

Re: [caiman-discuss] AI Multihomed Implementation Plan

On 05/17/10 11:15 AM, Sebastien Roy wrote: On 05/17/10 10:10 AM, joseph.vl...@oracle.com wrote: Hey Clay, I'm ccing- Sebastien Roy, "Seb". Seb is a staff engineer and architect in the networking group. I don't think using driver name or IP address may be the correct th

Re: [caiman-discuss] AI Multihomed Implementation Plan

On 05/17/10 10:10 AM, joseph.vl...@oracle.com wrote: On 05/13/10 07:43 PM, cl...@opensolaris.org wrote: Hi all, Here's what I'm envisioning for the AI multihomed implementation plan. Please let me know your oppinion of it or if it looks like anything

Re: [caiman-discuss] Code Review for 13904, 14903, 15194

On 06/ 2/10 11:34 AM, Sue Sohn wrote: Could I please get a review of the changes for: 13904 Logical Partition display issues on partition edit screen 14903 Partition screen highlights both Solaris2 and Extended Partition sizes 15194 textui navigation issue with xvm Note: Tests are included fo

Re: [caiman-discuss] Code Review for 13904, 14903, 15194

On 06/ 2/10 01:06 PM, Keith Mitchell wrote: On 06/ 2/10 09:40 AM, joseph.vl...@oracle.com wrote: On 06/ 2/10 11:34 AM, Sue Sohn wrote: Could I please get a review of the changes for: 13904 Logical Partition display issues on partition edit screen 14903 Partition screen highlights both

Re: [caiman-discuss] vm image creation using iSCSI

Hey Alok, The iSCSI approach you outlined seem cool to me! The original plan for VMC was to use VirtualBox's "Supported" Python interface but it wasn't ready in time for the initial version. So we went with the shell interface. Perhaps it would be valuable to investigating the current availa

Re: [caiman-discuss] "Completing transfer process" (99%) takes loooong time

On 06/ 6/10 06:11 AM, NAKAJI Hiroyuki wrote: I'm trying textinstall-134-sparc on my Netra t105, which has 2 18GB drives and 1GB memory. 131 was ok. Thanks. What does the install_log file show? /tmp/install_log Joe ___ caiman-discuss mai

Re: [caiman-discuss] CR request for: SMF based SysConfig framework in AI

Hey Jan, I just realized my reply that I would do this review didn't go to caiman-discuss. So resending. I'm on it. Joe On 06/ 8/10 04:37 AM, Jan Damborsky wrote: Hi, could I please ask for reviewing changes enhancing Automated Installer with support for new SMF based System Configuratio

Re: [caiman-discuss] "Completing transfer process" (99%) takes loooong time

On 06/ 8/10 07:17 AM, NAKAJI Hiroyuki wrote: On 06/ 6/10 06:11 AM, NAKAJI Hiroyuki wrote: I'm trying textinstall-134-sparc on my Netra t105, which has 2 18GB drives and 1GB memory. 131 was ok. Thanks. What does the install_log file show? /tmp/install_log Here

Re: [caiman-discuss] CR request for: SMF based SysConfig framework in AI

On 06/ 8/10 04:37 AM, Jan Damborsky wrote: Hi, could I please ask for reviewing changes enhancing Automated Installer with support for new SMF based System Configuration framework [3c] ? Following bugs cover those changes: 15723 Teach AI to use new SMF based System Configuration framework for

Re: [caiman-discuss] CR request for: SMF based SysConfig framework in AI

Thanks Jan. My comments below. Joe On 06/ 9/10 12:45 PM, Jan Damborsky wrote: Hey Joe, thank you very much for review ! I have incorporated most of the suggestions, please see in line for questions/comments for those I was not sure about. The updated webrev is available at (including John's

Re: [caiman-discuss] CR request for: SMF based SysConfig framework in AI

Thank you Jan! The way you have things now are fine with me! Joe On 06/11/10 01:35 PM, Jan Damborsky wrote: Hi Joe, On 06/10/10 12:32 PM, joseph.vl...@oracle.com wrote: [...] +-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-= Issue: -- "Not al

Re: [caiman-discuss] Commit privileges for Sriman Bhavanam

On 06/16/10 03:32 PM, Evan Layton wrote: Sriman has now successfully provided fixes for the following bugs: 7877 - beadm create in debug mode gives error message but succeeds 8006 - beadm gives invalid error if zone snapshot already exists 10318 - be_mount should only mount shared file systems

Re: [caiman-discuss] Code review request, CR 6936371

On 06/17/10 04:19 PM, Dave Miner wrote: I'd appreciate a review of the fix at http://cr.opensolaris.org/~dminer/slim_6936371/ 6936371 install fails if OBP lists multiple paths for boot device Testing on the originally broken system is not entirely complete due to some configuration issues tha

Re: [caiman-discuss] CR request for 16105 (Light test framework for slim_source gate) and 15229 (.hgignore file updates)

On 06/21/10 06:41 PM, Keith Mitchell wrote: Hi all, I'd like to request a code review for my fixes for the following bugs: 16105 slim_source gate could use infrastructure for running unit tests 15229

Re: [caiman-discuss] CR request for 16105 (Light test framework for slim_source gate) and 15229 (.hgignore file updates)

/ http://cr.opensolaris.org/~kemitche/test_framework_v2.diff/ - Keith On 06/22/10 03:42 AM, joseph.vl...@oracle.com wrote: Keith, This is good stuff. Just a couple off issues. I haven't run it yet but will try later today. Joe .hgignore Issue: -- Will .hgignore be stored i

Re: [caiman-discuss] CR request for: 15678 /etc/default/kbd is to be obsoleted by 6944480, installers need to be accommodated

On 06/25/10 04:45 AM, Jan Damborsky wrote: Hi, could I please get a review of the changes for: 15678 /etc/default/kbd is to be obsoleted by 6944480, installers need to be accommodated Webrev: http://cr.opensolaris.org/~dambi/bug-15678 For reference, here are related ON changes (they are be

Re: [caiman-discuss] CR Request : Bug 16192 : auto-install core dumped when creating invalid size swap or dump

On 06/28/10 08:56 AM, Matt Keenan wrote: Quick Code review request for : Bug 16192 - auto-install core dumped when creating invalid size swap or dump http://defect.opensolaris.org/bz/show_bug.cgi?id=16192 Webrev : http://cr.opensolaris.org/~mattman/bug-16192/ Whilst auto-install does c

Re: [caiman-discuss] CR Request : Bug 16192 : auto-install core dumped when creating invalid size swap or dump

On 06/28/10 12:16 PM, Matt Keenan wrote: Thanks *Joe*, and John for your review. I've updated webrev relating to both sets of comments. cheers Matt On 06/28/10 04:58 PM, John Fischer wrote: Opps I meant Joe. John On 06/28/10 08:53 AM, John Fischer wrote: Matt, In addition to what Jack s

Re: [caiman-discuss] CR request for: 15678 /etc/default/kbd is to be obsoleted by 6944480, installers need to be accommodated

On 06/25/10 04:45 AM, Jan Damborsky wrote: Hi, could I please get a review of the changes for: 15678 /etc/default/kbd is to be obsoleted by 6944480, installers need to be accommodated Webrev: http://cr.opensolaris.org/~dambi/bug-15678 For reference, here are related ON changes (they are be

Re: [caiman-discuss] CR Request : Bug 16192 : auto-install core dumped when creating invalid size swap or dump

On 06/29/10 08:08 AM, Matt Keenan wrote: On 06/28/10 06:18 PM, joseph.vl...@oracle.com wrote: On 06/28/10 12:16 PM, Matt Keenan wrote: Thanks *Joe*, and John for your review. I've updated webrev relating to both sets of comments. cheers Matt On 06/28/10 04:58 PM, John Fischer wrote:

Re: [caiman-discuss] Please review test assertions for Multi-homed AI server support

On 06/30/10 04:36 AM, Jeffrey Huang wrote: Hi, Clay, Here is test assertion for Multi-homed AI server support, please review if you have time and any feedback are welcomed: http://opg-qe.central.sun.com/wiki/index.php/Ai_multi_homed_assertion As the schedule is quite tight, we tried to cov

Re: [caiman-discuss] Please review test assertions for Multi-homed AI server support

itely useful for next phase testing. I will sent out a revised version base on new implementations. Great Thanks Jeffrey 于 2010/6/30 20:51, joseph.vl...@oracle.com 写道: On 06/30/10 04:36 AM, Jeffrey Huang wrote: Hi, Clay, Here is test assertion for Multi-homed AI server support, please review i

Re: [caiman-discuss] CR request for: 15678 /etc/default/kbd is to be obsoleted by 6944480, installers need to be accommodated

Hi Jan, Thank you for the reply. I'm OK with how things are now. Joe On 07/ 8/10 04:13 AM, Jan Damborsky wrote: Hi Joe, thank you very much for review ! Please see my response in line. Jan On 06/28/10 11:41 PM, joseph.vl...@oracle.com wrote: On 06/25/10 04:45 AM, Jan Damborsky

Re: [caiman-discuss] Quick (and time sensitive) CR for 16525

On 07/12/10 03:49 PM, Keith Mitchell wrote: All, I need a quick review for my fix for bug 16525: http://cr.opensolaris.org/~kemitche/16525/ Copy-paste issue when generating the file led to a line that had "fmri=value=pkg:/...", which should've just been "fmri=pkg:/..." - Keith __

Re: [caiman-discuss] Please review: amended changes for SNAP->ON integration

On 07/10/10 07:45 PM, Jack Schwartz wrote: Hi everyone. This webrev supercedes the one I published a week ago, because the situation with SNAP->ON integration has changed. (Thanks to those who reviewed the last one!) It also includes some new changes. Webrev: http://cr.opensolaris.org/~sch

Re: [caiman-discuss] Please review: amended changes for SNAP->ON integration

On 07/12/10 07:51 PM, Jack Schwartz wrote: Hi Joe. Thanks for your review. On 07/12/10 02:13 PM, joseph.vl...@oracle.com wrote: On 07/10/10 07:45 PM, Jack Schwartz wrote: Hi everyone. This webrev supercedes the one I published a week ago, because the situation with SNAP->ON integration

Re: [caiman-discuss] Please review: amended changes for SNAP->ON integration

On 07/12/10 09:40 PM, joseph.vl...@oracle.com wrote: On 07/12/10 07:51 PM, Jack Schwartz wrote: Hi Joe. Thanks for your review. On 07/12/10 02:13 PM, joseph.vl...@oracle.com wrote: On 07/10/10 07:45 PM, Jack Schwartz wrote: Hi everyone. This webrev supercedes the one I published a week ago

Re: [caiman-discuss] code-review for AI multihomed

On 07/13/10 07:04 AM, clay.baenzi...@oracle.com wrote: Hi all, Could Joe and John please look this over and anyone else who might be interested? This is the wad of changes for introducing multihomed support to AI. Please get me your impressions by Monday 7/19. There is a known bug right n

Re: [caiman-discuss] Please review: amended changes for SNAP->ON integration

On 07/13/10 01:21 PM, Jack Schwartz wrote: Hi Joe. On 07/13/10 03:14 AM, joseph.vl...@oracle.com wrote: On 07/12/10 09:40 PM, joseph.vl...@oracle.com wrote: On 07/12/10 07:51 PM, Jack Schwartz wrote: Hi Joe. Thanks for your review. On 07/12/10 02:13 PM, joseph.vl...@oracle.com wrote: On

Re: [caiman-discuss] Please review: amended changes for SNAP->ON integration

On 07/13/10 06:17 PM, Jack Schwartz wrote: Hey Jack I thought of another thing. My understanding is that the popen/system call was used in beadm to invoke an ICT written in C. A C to Python bridge was in the planning for the ICT's written in Python but it was never done. Perhaps it might be be

Re: [caiman-discuss] code-review for AI multihomed

On 07/13/10 06:37 PM, cl...@opensolaris.org wrote: Hi Joe, [snip...] Hey Clay, Did you get a chance to file a bug for the known issue? If so what's the bug number? If not can you describe where in the code the issue is? As this bug should be fixed before push I haven't filed a bug, however

Re: [caiman-discuss] code-review for AI multihomed

Hey Clay, Have you had a chance to look at my code review comments? I have noticed you have responded to others comments but not mine and I was worried you didn't see mine. I sent them last week, July 14. Let me know if you haven't seen them. Thanks. Joe On 07/18/10 10:53 PM, cl...@opens

Re: [caiman-discuss] Please review: amended changes for SNAP->ON integration

On 07/16/10 09:19 PM, Jack Schwartz wrote: Hi everyone. be_run_cmd has been simplified per all of the feedback received. Please bless. Revised webrev, same location: http://cr.opensolaris.org/~schwartz/100710.1/webrev/ Delta: http://cr.opensolaris.org/~schwartz/100710.1/webrev.3.4.diff

Re: [caiman-discuss] Please review: amended changes for SNAP->ON integration

On 07/19/10 01:58 PM, Jack Schwartz wrote: On 07/19/10 06:17 AM, joseph.vl...@oracle.com wrote: On 07/16/10 09:19 PM, Jack Schwartz wrote: Hi everyone. be_run_cmd has been simplified per all of the feedback received. Please bless. Revised webrev, same location: http://cr.opensolaris.org

Re: [caiman-discuss] Please review: amended changes for SNAP->ON integration

Thanks for doing this Jack. Joe On 07/19/10 04:24 PM, Jack Schwartz wrote: Hi everyone. Based on last week's gyrations I trimmed all unnecessary fat from this function. This added check seems like unnecessary fat to me as this function is internal. But I want this code review to be done,

Re: [caiman-discuss] code-review for AI multihomed

: cr.opensolaris.org/~clayb/webrev.multihomed/joe/diff Thank you, Clay On Wed, 14 Jul 2010, joseph.vl...@oracle.com wrote: On 07/13/10 06:37 PM, cl...@opensolaris.org wrote: Hi Joe, [snip...] Hey Clay, Did you get a chance to file a bug for the

Re: [caiman-discuss] CR request for: support for configuring static IP via AI

On 07/26/10 09:26 AM, Jan Damborsky wrote: Hi Ethan, could I please ask you for reviewing the changes for following bugs ? 7850 RFE would like support for static network instead of nwam config 10781 RFE - AI Needs to Support DNS Name Service Configuration for Clients webrev: http://cr.openso

Re: [caiman-discuss] CR request for: support for configuring static IP via AI

On 07/26/10 10:39 AM, Jan Damborsky wrote: Hey Joe, thank you very much for review - please see my response below. Jan On 07/26/10 03:48 PM, joseph.vl...@oracle.com wrote: On 07/26/10 09:26 AM, Jan Damborsky wrote: Hi Ethan, could I please ask you for reviewing the changes for following

Re: [caiman-discuss] AI Multi-homed Final Code Review

On 07/30/10 07:18 AM, clay.baenzi...@oracle.com wrote: Hi all, If you have provided me feedback on the AI Multi-homed feature code, could you please ensure your desired changes have been affected? I would ideally like a go/no-go by COB Monday 8/2. Also, for everyone's information, it wa

Re: [caiman-discuss] AI Multi-homed Final Code Review (Take II)

Thanks Clay! Looks OK to me. Joe On 08/12/10 05:50 AM, clay.baenzi...@oracle.com wrote: Hi all, If you have provided me feedback on the AI Multi-homed feature code, could you please ensure your desired changes have been affected? I would ideally like a go/no-go by COB Friday 8/13 (as I will

Re: [caiman-discuss] Please review changes for 16796

On 08/13/10 01:16 PM, Glenn Lagasse wrote: Hello Caimaniacs, Could I get a couple of eyes on these changes please? It should take all of 3 minutes ;-) With the integration of beadm/libbe into ON, we need to stop delivering those objects from slim_source. This changeset takes care of that in

Re: [caiman-discuss] Please review changes for 16796

On 08/13/10 01:46 PM, Glenn Lagasse wrote: Hi Joe, * joseph.vl...@oracle.com (joseph.vl...@oracle.com) wrote: On 08/13/10 01:16 PM, Glenn Lagasse wrote: Hello Caimaniacs, Could I get a couple of eyes on these changes please? It should take all of 3 minutes ;-) With the integration of

Re: [caiman-discuss] Code Review for 6979162

On 08/23/10 12:34 PM, Sue Sohn wrote: Could I please get a review of the changes for: 6979162 Unit test shouldn't assume AI service is running http://monaco.sfbay.sun.com/detail.jsf?cr=6979162 Webrev: http://cr.opensolaris.org/~sohn/6979162 Thanks, Sue __

Re: [caiman-discuss] Code Review for 6979162

On 08/23/10 01:43 PM, Sue Sohn wrote: On 08/23/10 10:08, joseph.vl...@oracle.com wrote: On 08/23/10 12:34 PM, Sue Sohn wrote: Could I please get a review of the changes for: 6979162 Unit test shouldn't assume AI service is running http://monaco.sfbay.sun.com/detail.jsf?cr=6979162 Webrev:

Re: [caiman-discuss] Checkpoint/Software node validation

On 09/15/10 12:22 PM, jean.mccormack wrote: I was just talking with Ginnie about the interface between the checkpoints and their DOC software nodes. The design specifies that the checkpoint name must be the same as the software node name that contains it's input. Unfortunately, this interface is

Re: [caiman-discuss] Checkpoint/Software node validation

On 09/16/10 06:15 AM, Darren Kenny wrote: On 09/16/10 10:45 AM, joseph.vl...@oracle.com wrote: On 09/15/10 12:22 PM, jean.mccormack wrote: I was just talking with Ginnie about the interface between the checkpoints and their DOC software nodes. The design specifies that the checkpoint name must

[caiman-discuss] DHCP IP Address records macro entry

Hey Dave, I need a little help understanding how P IP Address records be set up. In looking at the Automated Installation Service and Image Management Design: http://hub.opensolaris.org/bin/view/Project+caiman/AI+Image+Management It is not clear to me how DHCP IP Address records should be

Re: [caiman-discuss] DHCP IP Address records macro entry

Hey Dave, Thank you for clarifying. My comments in-line below. Joe On 09/30/10 06:11 PM, Dave Miner wrote: On 09/30/10 02:32 PM, joseph.vl...@oracle.com wrote: Hey Dave, I need a little help understanding how P IP Address records be set up. In looking at the Automated Installation

Re: [caiman-discuss] DHCP IP Address records macro entry

On 10/ 4/10 03:26 PM, Dave Miner wrote: On 10/ 4/10 01:16 PM, joseph.vl...@oracle.com wrote: Hey Dave, Thank you for clarifying. My comments in-line below. Joe On 09/30/10 06:11 PM, Dave Miner wrote: On 09/30/10 02:32 PM, joseph.vl...@oracle.com wrote: Hey Dave, I need a little help

Re: [caiman-discuss] CR request for 6991546

On 10/13/10 11:55 AM, Jan Damborsky wrote: Hi, could I please get a code review for fix for following bug: 6991546 reset_image_uuid() assumes a publisher name of "opensolaris.org" webrev is available at: http://cr.opensolaris.org/~dambi/bug-6991546 Thank you, Jan tests accomplished: * GUI in

Re: [caiman-discuss] CR request for 6991546

On 10/14/10 03:02 AM, Jan Damborsky wrote: Hi Keith, On 10/13/10 06:36 PM, Keith Mitchell wrote: Hi Jan, It'd be better to check status and len() of the output before splitting the output - if the command errors out and returns an empty string for status, the "co[0].split()[1]" command will fa

Re: [caiman-discuss] CR request for 6991546

On 10/14/10 07:48 AM, Jan Damborsky wrote: On 10/14/10 01:05 PM, joseph.vl...@oracle.com wrote: On 10/14/10 03:02 AM, Jan Damborsky wrote: Hi Keith, On 10/13/10 06:36 PM, Keith Mitchell wrote: Hi Jan, It'd be better to check status and len() of the output before splitting the output

Re: [caiman-discuss] Please review ASAP: simple fix for stopper

LGTM too Jack. Joe On 10/18/10 02:18 AM, Jan Damborsky wrote: LGTM, Jack. Jan On 10/16/10 11:20 PM, Jack Schwartz wrote: Hi everyone. Here is a 4-line webrev for a fix that allows Driver Updates (DDU) to work in AI for B150+. It simply involves calling a python function which initializes

Re: [caiman-discuss] DC->CUD Project Code review

On 10/27/10 03:44 PM, Alok Aggarwal wrote: On Wed, 27 Oct 2010, joseph.vl...@oracle.com wrote: Alok and Drew, A flag day for pkg(5) was published a while back which stated: pkgsend(1) should no longer be used to create repositories pkgrepo(1) has been added as a utility for creating and

Re: [caiman-discuss] webrev for aimdns (CR 6977107) phase I

On 11/ 3/10 01:36 PM, John Fischer wrote: All, I am still waiting on the code review of aimdns. Thanks, John On 10/28/10 03:13 PM, John Fischer wrote: All, I have addressed an issue raised by Clay. The issue was around the SMF multihomed properties networks and exclude_networks. I have post

Re: [caiman-discuss] webrev for aimdns (CR 6977107) phase I

Hey John, My comments are attached. Some are just questions. Hope this helps. Joe On 11/ 3/10 01:36 PM, John Fischer wrote: All, I am still waiting on the code review of aimdns. Thanks, John On 10/28/10 03:13 PM, John Fischer wrote: All, I have addressed an issue raised by Clay. The iss

Re: [caiman-discuss] "Code" review request for README updates

On 11/ 4/10 09:55 PM, Keith Mitchell wrote: Hi all, Can I get a review of my changes for CR 6978164, which is an update to the README and default developer.sh file to point to Sun Studio 12.1? Webrev: http://cr.opensolaris.org/~kemitche/6978164/ The change in default compilers is deemed to be

Re: [caiman-discuss] Code review request - ManifestParser bug 6997263

On 11/ 5/10 07:42 AM, Dermot McCluskey wrote: Hi, Can I get a review for this fairly simple fix for ManifestParser bug: http://monaco.sfbay/detail.jsf?cr=6997263 Webrev is at: http://cr.opensolaris.org/~dermot/webrev-6997263/ Thanks, - Dermot ___ cai

Re: [caiman-discuss] Code review request - ManifestParser bug 6997263

Thanks Dermot, My responses below. Joe On 11/ 5/10 11:45 AM, Dermot McCluskey wrote: Joe, Thanks for reviewing. Responses below. On 11/05/10 13:20, joseph.vl...@oracle.com wrote: On 11/ 5/10 07:42 AM, Dermot McCluskey wrote: Hi, Can I get a review for this fairly simple fix for

Re: [caiman-discuss] webrev for aimdns (CR 6977107) phase I

Thanks John. I'm good with all or your responses. Thanks! Joe On 11/ 5/10 02:58 PM, John Fischer wrote: Joe, I'll have a new webrev out later today with the changes from yourself, Keith and Clay included. See below for details. Thanks, John On 11/ 4/10 12:19 PM, joseph.vl...@

Re: [caiman-discuss] CR request for 6991570, 6996538

On 11/10/10 05:06 AM, Jan Damborsky wrote: Hi Joe, could I please ask you to take a look at following two bug fixes residing in ICT world ? CRs: 6991570 Do not configure savecore directory, let svc:/system/dumpadm go with default value 6996538 Remove configure_nwam() ICT task - that workaround

Re: [caiman-discuss] CR request for 6991570, 6996538

Thanks Jan. This looks good now. Joe On 11/10/10 08:30 AM, Jan Damborsky wrote: Hi Joe, thank you very much for review. Please see my response in line. Jan On 11/10/10 01:23 PM, joseph.vl...@oracle.com wrote: On 11/10/10 05:06 AM, Jan Damborsky wrote: Hi Joe, could I please ask you to

Re: [caiman-discuss] Code review: 6995479 (use xorg.conf.vesa from X team)

On 11/16/10 10:44 AM, Dave Miner wrote: I'd appreciate review of the change at http://cr.opensolaris.org/~dminer/slim_6995479/ for 6995479 media-fs-root should consume X server interface for VESA configuration Thanks, Dave ___ caiman-discuss mailing

Re: [caiman-discuss] Code review: 6995479 (use xorg.conf.vesa from X team)

On 11/16/10 11:24 AM, Dave Miner wrote: On 11/16/10 11:07 AM, joseph.vl...@oracle.com wrote: On 11/16/10 10:44 AM, Dave Miner wrote: I'd appreciate review of the change at http://cr.opensolaris.org/~dminer/slim_6995479/ for 6995479 media-fs-root should consume X server interface for

Re: [caiman-discuss] Code review: 6995479 (use xorg.conf.vesa from X team)

On 11/16/10 12:05 PM, Dave Miner wrote: On 11/16/10 11:33 AM, joseph.vl...@oracle.com wrote: On 11/16/10 11:24 AM, Dave Miner wrote: On 11/16/10 11:07 AM, joseph.vl...@oracle.com wrote: On 11/16/10 10:44 AM, Dave Miner wrote: I'd appreciate review of the change at http://cr.opensolari

Re: [caiman-discuss] Code Review for 7001284

On 11/19/10 01:38 PM, Sue Sohn wrote: Could I please get a review of the changes for: 7001284 installadm list can have incorrect output if criteria has MIN or MAX unbounded Webrev: http://cr.opensolaris.org/~sohn/7001284 Thanks, Sue ___ caiman-discus

Re: [caiman-discuss] Code Review for 7001284

On 11/19/10 02:48 PM, Sue Sohn wrote: On 11/19/10 11:00 AM, joseph.vl...@oracle.com wrote: On 11/19/10 01:38 PM, Sue Sohn wrote: Could I please get a review of the changes for: 7001284 installadm list can have incorrect output if criteria has MIN or MAX unbounded Webrev: http

[caiman-discuss] Preliminary ISIM Project Code Review Request

This is a preliminary code review request for a selection of the Install Service Image Management project (ISIM). Please provide feedback by the end of next week, Friday 12.December.2010. Although there is more code in the webrev, for this review, please focus on the following bits: ai_image

[caiman-discuss] Preliminary ISIM Project Code Review Request

This is preliminary code review request for a selection of code for the Install Service Image Management project. The ISIM project design document can be found here: http://hub.opensolaris.org/bin/view/Project+caiman/AI+Image+Management The webrev can be found here: http://cr.opensolaris.org/~j

Re: [caiman-discuss] Preliminary ISIM Project Code Review Request

On 12/ 2/10 03:49 PM, joseph.vl...@oracle.com wrote: This is a preliminary code review request for a selection of the Install Service Image Management project (ISIM). Please provide feedback by the end of next week, Friday 12.December.2010. Although there is more code in the webrev, for this

Re: [caiman-discuss] Preliminary ISIM Project Code Review Request

On 12/ 2/10 04:08 PM, joseph.vl...@oracle.com wrote: This is preliminary code review request for a selection of code for the Install Service Image Management project. The ISIM project design document can be found here: http://hub.opensolaris.org/bin/view/Project+caiman/AI+Image+Management The

Re: [caiman-discuss] Proposed changes to installadm subcommands

On 12/ 6/10 05:13 PM, Sue Sohn wrote: Hi all, Ethan and I have been looking at the various changes that AI-related projects were planning to make to the installadm command structure to understand what the big picture might look like and how we might provide consistency among the subcommands whil

Re: [caiman-discuss] Preliminary ISIM Project Code Review Request

#x27;t catch correctly if you the cwd is a subdir of target path. Something like: if os.getcwd().startswith(target_path): would catch that case. (There's also a slim chance of symlinks making the target path look different from the cwd; if that's a concern than some manipulation f

Re: [caiman-discuss] Webrev for CR 7007574

On 12/16/10 08:58 PM, John Fischer wrote: All, My link to the code review is incorrect. It should be: http://cr.opensolaris.org/~johnfisc/7007574-aimdns Sorry about the confusion. Thanks Evan for catching that one. Thanks, John On 12/16/10 05:37 PM, John Fischer wrote: All, Can I get a re

Re: [caiman-discuss] Webrev for CR 7007574

On 12/17/10 11:03 AM, John Fischer wrote: Joe, See below. Thanks, John On 12/17/10 05:40 AM, joseph.vl...@oracle.com wrote: John, Looks good. I do have a question. In the below code: 393 while not self._restart_loop and not self.done: 394 try: 395 # process the appropriate service

Re: [caiman-discuss] webrev request for webserver design project - round 1

On 12/13/10 07:46 PM, John Fischer wrote: All, Ethan found an issue with aimdns. Thanks Ethan!! I have updated the webrev with the changes. The new webrev is at: http://cr.opensolaris.org/~johnfisc/webserver-design/ http://cr.opensolaris.org/~johnfisc/webserver-design-diff/ http://cr.opensolar

Re: [caiman-discuss] ICT to Checkpoint Conversion Design Doc

On 12/13/10 03:41 PM, Ginnie Wray wrote: Hi - I've added a proposal for converting the ICTs to checkpoints to the caiman-docs repository. It can be downloaded from: http://src.opensolaris.org/source/xref/caiman/caiman-docs/ICT/ict_conversion.pdf or pulled from the caiman-docs source directly.

Re: [caiman-discuss] webrev request for webserver design project - round 1

On 12/30/10 07:37 PM, John Fischer wrote: Joe, Thanks for taking the time to review these changes. I truly appreciate the extra work. See below. Thanks, John On 12/20/10 01:13 PM, joseph.vl...@oracle.com wrote: Looks good John. Just a few minor issues... I reviewed this list of files

Re: [caiman-discuss] SCI code review (parts A and D)

On 01/ 6/11 07:10 PM, Keith Mitchell wrote: Hi Jean, Joe, Karen, Thanks for volunteering to review the SCI code. The webrev is at: http://cr.opensolaris.org/~kemitche/sci.1/ Jean/Joe - you agreed to look at part [a]. Karen, part [d]. Again, it's mostly moved files and updated imports. - Keith