Re: [clang-tools-extra] r325097 - [clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag

On Wed, Feb 14, 2018 at 10:45 AM Ilya Biryukov wrote: > Personally, I'm not a big fan of environment variables. There are harder > to discover than command-line flags and I still have to change editor > config often to switch between different builds of clangd. > I know it

[PATCH] D43108: Support for the mno-stack-arg-probe flag

nruslan added a comment. @hans: I responded to the comments and also updated diff for clang with new changes. https://reviews.llvm.org/D43108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D10831: Attach attribute "trap-func-name" to IR function

ahatanak added a comment. AMDGPUAnnotateKernelFeatures::addFeatureAttributes looks for an llvm.trap instruction and adds attribute "amdgpu-queue-ptr" to the function if it finds one. Other than that, it looks like your idea would work too. Repository: rL LLVM

[PATCH] D43108: Support for the mno-stack-arg-probe flag

nruslan added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:4038 + if (Args.hasArg(options::OPT_mno_stack_arg_probe)) +CmdArgs.push_back("-mno-stack-arg-probe"); + hans wrote: > I think you can just do > > ``` > Args.AddLastArg(CmdArgs,

[PATCH] D43108: Support for the mno-stack-arg-probe flag

nruslan updated this revision to Diff 134377. nruslan marked 3 inline comments as done. nruslan added a comment. Added mstack-arg-probe, tests, and changes related to other comments of the reviewers https://reviews.llvm.org/D43108 Files: docs/ClangCommandLineReference.rst

[PATCH] D43062: [analyzer] Support CXXTemporaryObjectExpr constructors that have destructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325211: [analyzer] Inline constructors for destroyable temporaries. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r325211 - [analyzer] Inline constructors for destroyable temporaries.

Author: dergachev Date: Wed Feb 14 19:26:43 2018 New Revision: 325211 URL: http://llvm.org/viewvc/llvm-project?rev=325211=rev Log: [analyzer] Inline constructors for destroyable temporaries. Since r325210, in cfg-temporary-dtors mode, we can rely on the CFG to tell us that we're indeed

[PATCH] D43056: [CFG] [analyzer] Add construction context for CXXBindTemporaryExpr.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL325210: [CFG] Provide construction contexts for temproary objects. (authored by dergachev, committed by ). Herald added a

r325210 - [CFG] Provide construction contexts for temproary objects.

Author: dergachev Date: Wed Feb 14 19:13:36 2018 New Revision: 325210 URL: http://llvm.org/viewvc/llvm-project?rev=325210=rev Log: [CFG] Provide construction contexts for temproary objects. Constructors of C++ temporary objects that have destructors now can be queried to discover that they're

[PATCH] D43056: [CFG] [analyzer] Add construction context for CXXBindTemporaryExpr.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC325210: [CFG] Provide construction contexts for temproary objects. (authored by dergachev, committed by ). Repository:

Re: [PATCH] D10831: Attach attribute "trap-func-name" to IR function

It could, but then you'd need to change every front end to have the same sort of behavior, maybe you want to configure it differently, etc. That said, I really have no strong opinions here :) -eric On Wed, Feb 14, 2018 at 6:51 PM Peter Collingbourne via Phabricator < revi...@reviews.llvm.org>

[PATCH] D42875: [CFG] [analyzer] Add construction context for ReturnStmt.

NoQ added a comment. https://reviews.llvm.org/rC325202 is attached to this revision accidentally; it should have been attached to https://reviews.llvm.org/D42876. Repository: rL LLVM https://reviews.llvm.org/D42875 ___ cfe-commits mailing list

[PATCH] D42991: [analyzer] Use EvalCallOptions for destructors as well.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL325209: [analyzer] Decide on inlining destructors via EvalCallOptions. (authored by dergachev, committed by ). Herald

r325209 - [analyzer] Decide on inlining destructors via EvalCallOptions.

Author: dergachev Date: Wed Feb 14 18:51:58 2018 New Revision: 325209 URL: http://llvm.org/viewvc/llvm-project?rev=325209=rev Log: [analyzer] Decide on inlining destructors via EvalCallOptions. EvalCallOptions were introduced in r324018 for allowing various parts of ExprEngine to notify the

[PATCH] D10831: Attach attribute "trap-func-name" to IR function

pcc added a comment. Herald added subscribers: llvm-commits, mehdi_amini. Maybe I'm missing something, but I don't see why we need this attribute. Couldn't clang have been changed to implement `-ftrap-function` by generating a call to the trap function instead of emitting an `llvm.trap`

[PATCH] D42876: [analyzer] Support returning objects by value.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Committed this but put a wrong phabricator link in the commit message, sorry >_< https://reviews.llvm.org/rC325202 https://reviews.llvm.org/D42876 ___

[libcxx] r325205 - Fix test failure on compilers w/o deduction guides

Author: ericwf Date: Wed Feb 14 18:41:19 2018 New Revision: 325205 URL: http://llvm.org/viewvc/llvm-project?rev=325205=rev Log: Fix test failure on compilers w/o deduction guides Modified: libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.pass.cpp

r325203 - Reapply r325193

Author: kzhuravl Date: Wed Feb 14 18:37:04 2018 New Revision: 325203 URL: http://llvm.org/viewvc/llvm-project?rev=325203=rev Log: Reapply r325193 Added: cfe/trunk/test/Driver/amdgpu-macros.cl - copied unchanged from r325199, cfe/trunk/test/Driver/amdgpu-macros.cl Modified:

Re: r325195 - Add missing definition for class static after r325193.

I did not see this. I will reapply the patch. Sorry for the noise. From: cfe-commits on behalf of Richard Smith via cfe-commits Sent: Wednesday, February 14, 2018 8:01 PM To:

[PATCH] D43094: AMDGPU: Enable PIC by default for amdgcn

This revision was automatically updated to reflect the committed changes. Closed by commit rL325196: AMDGPU: Enable PIC by default for amdgcn (authored by kzhuravl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r325202 - [analyzer] Allow inlining constructors into return values.

Author: dergachev Date: Wed Feb 14 18:32:32 2018 New Revision: 325202 URL: http://llvm.org/viewvc/llvm-project?rev=325202=rev Log: [analyzer] Allow inlining constructors into return values. This only affects the cfg-temporary-dtors mode - in this mode we begin inlining constructors that are

r325201 - [analyzer] NFC: Remove dead checks when computing DeclStmt construction region.

Author: dergachev Date: Wed Feb 14 18:30:20 2018 New Revision: 325201 URL: http://llvm.org/viewvc/llvm-project?rev=325201=rev Log: [analyzer] NFC: Remove dead checks when computing DeclStmt construction region. In CFG, every DeclStmt has exactly one decl, which is always a variable. It is also

r325200 - Revert r325193 as it breaks buildbots

Author: kzhuravl Date: Wed Feb 14 18:27:45 2018 New Revision: 325200 URL: http://llvm.org/viewvc/llvm-project?rev=325200=rev Log: Revert r325193 as it breaks buildbots Removed: cfe/trunk/test/Driver/amdgpu-macros.cl Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp

[PATCH] D43104: [analyzer] Find correct region for simple temporary destructor calls and inline them if possible.

NoQ updated this revision to Diff 134351. NoQ added a comment. Whoops - recall that we still need to cleanup the temporaries map even, now that we know that we cannot assert that it's already empty. Clean up the map and enable the assertion that becomes tautological until the respective FIXME

[PATCH] D42876: [analyzer] Support returning objects by value.

NoQ updated this revision to Diff 134346. NoQ added a comment. Update the comment with some thoughts from http://lists.llvm.org/pipermail/cfe-dev/2018-February/056898.html https://reviews.llvm.org/D42876 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h

[PATCH] D43104: [analyzer] Find correct region for simple temporary destructor calls and inline them if possible.

NoQ updated this revision to Diff 134341. NoQ added a comment. All right, so the assertion that we actually destroy all temporaries in our `InitializedTemporaries` map is still violated quite often - every time we do any sort of lifetime extension, we're actually calling the destructor on a

r325196 - AMDGPU: Enable PIC by default for amdgcn

Author: kzhuravl Date: Wed Feb 14 17:01:53 2018 New Revision: 325196 URL: http://llvm.org/viewvc/llvm-project?rev=325196=rev Log: AMDGPU: Enable PIC by default for amdgcn Differential Revision: https://reviews.llvm.org/D43094 Added: cfe/trunk/test/Driver/amdgcn-toolchain-pic.cl Modified:

r325195 - Add missing definition for class static after r325193.

Author: rsmith Date: Wed Feb 14 17:01:06 2018 New Revision: 325195 URL: http://llvm.org/viewvc/llvm-project?rev=325195=rev Log: Add missing definition for class static after r325193. Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp URL:

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10166-10182 +EvalInfo Info(Ctx, Result, EvalInfo::EM_ConstantFold); +Info.IsNonTypeTemplateArgument = true; +LValue LV; +if (!EvaluateLValue(this, LV, Info) || Result.HasSideEffects || +

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10166-10182 +EvalInfo Info(Ctx, Result, EvalInfo::EM_ConstantFold); +Info.IsNonTypeTemplateArgument = true; +LValue LV; +if (!EvaluateLValue(this, LV, Info) || Result.HasSideEffects || +

[PATCH] D36802: AMDGPU: Cleanup most of the macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL325193: AMDGPU: Cleanup most of the macros (authored by kzhuravl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D36802?vs=134335=134336#toc

r325193 - AMDGPU: Cleanup most of the macros

Author: kzhuravl Date: Wed Feb 14 16:20:26 2018 New Revision: 325193 URL: http://llvm.org/viewvc/llvm-project?rev=325193=rev Log: AMDGPU: Cleanup most of the macros - Insert __AMD__ macro - Insert __AMDGPU__ macro - Insert __devicename__ macro - Add missing tests for arch macros Differential

[PATCH] D36802: AMDGPU: Cleanup most of the macros

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36802: AMDGPU: Cleanup most of the macros

kzhuravl updated this revision to Diff 134335. kzhuravl edited the summary of this revision. kzhuravl added a comment. Address review feedback. https://reviews.llvm.org/D36802 Files: lib/Basic/Targets/AMDGPU.cpp lib/Basic/Targets/AMDGPU.h test/Driver/amdgpu-macros.cl Index:

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:23 +def warn_return_std_move : Warning< + "adding 'std::move' here would select a better conversion sequence">, + InGroup, DefaultIgnore; Can we say something like "local

[PATCH] D43148: Adding msan support for FreeBSD

devnexen updated this revision to Diff 134331. https://reviews.llvm.org/D43148 Files: lib/Driver/ToolChains/FreeBSD.cpp Index: lib/Driver/ToolChains/FreeBSD.cpp === --- lib/Driver/ToolChains/FreeBSD.cpp +++

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone created this revision. Quuxplusone added a project: clang. Herald added a subscriber: cfe-commits. This patch adds two new diagnostics, which are off by default: **-Wreturn-std-move** Diagnose cases of `return x` or `throw x`, where `x` is the name of a local variable or parameter,

[PATCH] D43148: Adding msan support for FreeBSD

krytarowski added inline comments. Comment at: FreeBSD.cpp:397 Res |= SanitizerKind::FuzzerNoLink; +if (IsX86_64) +Res |= SanitizerKind::Memory; I would keep it in a dedicated `if (IsX86_64)` (similar to NetBSD). Otherwise it looks fine.

[PATCH] D43321: Improve documentation for attribute artificial

This revision was automatically updated to reflect the committed changes. Closed by commit rC325186: Improve documentation for attribute artificial (authored by erichkeane, committed by ). Repository: rC Clang https://reviews.llvm.org/D43321 Files: include/clang/Basic/AttrDocs.td Index:

[PATCH] D43105: [RISCV] Enable __int128_t and uint128_t through clang flag

apazos added inline comments. Comment at: lib/Basic/Targets/RISCV.h:85 + bool hasInt128Type(const LangOptions ) const override { +return Opts.UseInt128; + } kito-cheng wrote: > efriedma wrote: > > Maybe make this a cross-platform flag, rather than

r325186 - Improve documentation for attribute artificial

Author: erichkeane Date: Wed Feb 14 15:00:31 2018 New Revision: 325186 URL: http://llvm.org/viewvc/llvm-project?rev=325186=rev Log: Improve documentation for attribute artificial This patch is related to https://reviews.llvm.org/rC325081 The patch improves documentation for the attribute and

[PATCH] D43321: Improve documentation for attribute artificial

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D43321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43321: Improve documentation for attribute artificial

eandrews created this revision. eandrews added reviewers: rsmith, aaron.ballman, erichkeane. This patch is related to https://reviews.llvm.org/rC325081 The patch improves documentation for the attribute and removes reference to GCC documentation. https://reviews.llvm.org/D43321 Files:

[PATCH] D42611: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/CodeGen/thinlto-distributed-cfi-devirt.ll:59 + ; Check that the call was devirtualized. + ; CHECK-IR: %call = tail call i32 @_ZN1A1nEi + %1 = tail call { i8*, i1 }

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rnk created this revision. rnk added a reviewer: rsmith. When the C++ committee changed the wording around non-type template arguments, they naively thought that every global declarations address would be a constant expression, but this is not the case. There is no PE/COFF relocation that allows

r325184 - Moved CHECK in test closer to source code

Author: vitalybuka Date: Wed Feb 14 14:52:49 2018 New Revision: 325184 URL: http://llvm.org/viewvc/llvm-project?rev=325184=rev Log: Moved CHECK in test closer to source code Modified: cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll Modified:

[PATCH] D42611: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

This revision was automatically updated to reflect the committed changes. Closed by commit rL325182: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D42611?vs=134317=134321#toc

[PATCH] D42611: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

This revision was automatically updated to reflect the committed changes. Closed by commit rC325182: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK (authored by vitalybuka, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r325182 - [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

Author: vitalybuka Date: Wed Feb 14 14:41:15 2018 New Revision: 325182 URL: http://llvm.org/viewvc/llvm-project?rev=325182=rev Log: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK Summary: TypeID summaries are used by CFI and need to be serialized by ThinLTO indexing for

[PATCH] D43094: AMDGPU: Enable PIC by default for amdgcn

t-tye accepted this revision. t-tye added a comment. For now seems reasonable to fix amdgpu as PIC. If/when other clients of amdgpu have tool chains defined then can switch to controling in the toolchain isPICDefault() function. https://reviews.llvm.org/D43094

[PATCH] D35894: [clangd] Code hover for Clangd

simark added inline comments. Comment at: unittests/clangd/XRefsTests.cpp:561 + +EXPECT_EQ(H.contents.value, Test.expectedHover.str()) << Test.input; + } Note that I used `.str()` here to make the output of failing tests readable and useful. By default,

[PATCH] D36802: AMDGPU: Cleanup most of the macros

t-tye requested changes to this revision. t-tye added inline comments. This revision now requires changes to proceed. Comment at: lib/Basic/Targets/AMDGPU.cpp:362 +Builder.defineMacro(Twine("__") + Twine(GPUName)); +Builder.defineMacro(Twine("__") + Twine(GPUName) +

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

krytarowski added a comment. It looks good to me, I can land this for you. https://reviews.llvm.org/D43279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35894: [clangd] Code hover for Clangd

simark updated this revision to Diff 134306. simark added a comment. Generate Hover by pretty-printing the AST This new version of the patch generates the hover by pretty-printing the AST. The unit tests are updated accordingly. There are some inconsistencies in how things are printed. For

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 134305. MaskRay marked 2 inline comments as done. MaskRay added a comment. Add an option `Suggest`. Only suggest P0214 alternatives if it is true. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files:

[PATCH] D42606: [Coroutines] Use allocator overload when available

modocache updated this revision to Diff 134304. modocache added a comment. Thanks for the review, @GorNishanov, and for pointing out that part of the standard! I added a reference to the implicit object parameter, as well as some tests for that behavior. And thanks for pointing out the flaw in

r325175 - [Debug] Annotate compiler generated range-for loop variables.

Author: mattd Date: Wed Feb 14 13:22:11 2018 New Revision: 325175 URL: http://llvm.org/viewvc/llvm-project?rev=325175=rev Log: [Debug] Annotate compiler generated range-for loop variables. Summary: This change aims to simplify debugging by annotating the range-for loop artificial variables

[PATCH] D42813: [Debug] Annotate compiler generated range-for loop variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rC325175: [Debug] Annotate compiler generated range-for loop variables. (authored by mattd, committed by ). Repository: rC Clang https://reviews.llvm.org/D42813 Files: include/clang/Sema/Scope.h

r325171 - Clean up -fdiscard-value-name handling

Author: ericwf Date: Wed Feb 14 12:56:52 2018 New Revision: 325171 URL: http://llvm.org/viewvc/llvm-project?rev=325171=rev Log: Clean up -fdiscard-value-name handling Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL:

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle updated this revision to Diff 134296. malaperle added a comment. Fix some NITs, add more tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Protocol.h clangd/SourceCode.cpp clangd/SourceCode.h

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

jorisa added a comment. This is also a highly anticipated feature for us! Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43232: clang-format: use AfterControlStatement to format ObjC control blocks

benhamilton requested changes to this revision. benhamilton added a comment. This revision now requires changes to proceed. Thanks! Can you add a test for this, please? Repository: rC Clang https://reviews.llvm.org/D43232 ___ cfe-commits mailing

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

mstorsjo added a comment. In https://reviews.llvm.org/D43184#1005258, @rnk wrote: > Do you think we should do something like local vftables for itanium instead? > Can we assume all methods in the vtable will be exported by the DLL exporting > the class? Will this actually ever be needed for

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 134295. gtbercea added a comment. Fix test. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index:

[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

kevinl created this revision. kevinl added a reviewer: djasper. Herald added subscribers: cfe-commits, klimek. C++ code that used to be formatted as `if (! + object) {` is now formatted as `if (!+object) {` (we have a particular object in our codebase where unary `operator+` is overloaded to

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 134292. gtbercea added a comment. Revert. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index:

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

Hahnfeld added a comment. In https://reviews.llvm.org/D43197#1007963, @gtbercea wrote: > In https://reviews.llvm.org/D43197#1007918, @Hahnfeld wrote: > > > I'm still not sure we can't run this test on Windows. I think lots of other > > tests use `touch`, even some specific to Windows... > > >

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea added a comment. In https://reviews.llvm.org/D43197#1007918, @Hahnfeld wrote: > I'm still not sure we can't run this test on Windows. I think lots of other > tests use `touch`, even some specific to Windows... Let me know what you'd like me to do. I can add the test back. I do see

r325159 - [clang-format] Recognize percents as format specifiers in protos

Author: krasimir Date: Wed Feb 14 11:47:58 2018 New Revision: 325159 URL: http://llvm.org/viewvc/llvm-project?rev=325159=rev Log: [clang-format] Recognize percents as format specifiers in protos Summary: Frequently, a percent in protos denotes a formatting specifier for string replacement. Thus

[PATCH] D43294: [clang-format] Recognize percents as format specifiers in protos

This revision was automatically updated to reflect the committed changes. Closed by commit rC325159: [clang-format] Recognize percents as format specifiers in protos (authored by krasimir, committed by ). Changed prior to commit: https://reviews.llvm.org/D43294?vs=134232=134286#toc

[PATCH] D43277: limits: Use `false` instead of `type(0)`.

mclow.lists added a comment. I see no benefit to this change. `bool(0)` is `false`. Repository: rCXX libc++ https://reviews.llvm.org/D43277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42813: [Debug] Annotate compiler generated range-for loop variables.

mattd added a comment. > Great - can you commit this yourself or would you like me to do it for you? I've got it. Thanks! https://reviews.llvm.org/D42813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42813: [Debug] Annotate compiler generated range-for loop variables.

dblaikie added a comment. In https://reviews.llvm.org/D42813#1007865, @mattd wrote: > Thanks @dblaikie! I renamed the test, and cleaned up per your suggestion. I > originally regex'd the debug-info lines so that the test would verify that > the names were artificial; however, being that we

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

Hahnfeld added a comment. I'm still not sure we can't run this test on Windows. I think lots of other tests use `touch`, even some specific to Windows... Repository: rC Clang https://reviews.llvm.org/D43197 ___ cfe-commits mailing list

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 134278. gtbercea added a comment. Use %T. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c

[PATCH] D42813: [Debug] Annotate compiler generated range-for loop variables.

mattd updated this revision to Diff 134272. mattd added a comment. Thanks @dblaikie! I renamed the test, and cleaned up per your suggestion. I originally regex'd the debug-info lines so that the test would verify that the names were artificial; however, being that we already match them as

r325156 - Update for llvm change. NFC.

Author: rafael Date: Wed Feb 14 11:11:37 2018 New Revision: 325156 URL: http://llvm.org/viewvc/llvm-project?rev=325156=rev Log: Update for llvm change. NFC. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp cfe/trunk/tools/clang-offload-bundler/ClangOffloadBundler.cpp Modified:

r325154 - [Modules] Add more language features to be used with requires-declaration

Author: bruno Date: Wed Feb 14 11:01:03 2018 New Revision: 325154 URL: http://llvm.org/viewvc/llvm-project?rev=325154=rev Log: [Modules] Add more language features to be used with requires-declaration Features added: c99, c11, c17, cplusplus14 and cplusplus17. rdar://problem/36328787

[PATCH] D42813: [Debug] Annotate compiler generated range-for loop variables.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems good, thanks :) Comment at: test/CodeGenCXX/debug-for-range-scope-hints.cpp:1 +// RUN: %clang_cc1 -emit-llvm -debug-info-kind=limited %s -o - | FileCheck %s +

[PATCH] D43303: [Format] Fix for bug 35641

kadircet created this revision. kadircet added reviewers: rsmith, djasper. kadircet added a project: clang. Herald added a subscriber: cfe-commits. Bug was caused due to comments at the start of scope. For a code like: int func() { // int b; int c; } the comment at the first line

[PATCH] D42813: [Debug] Annotate compiler generated range-for loop variables.

mattd updated this revision to Diff 134263. mattd added a comment. - Added a division by 2 instead of the shift, it reads clearer. - Updated the associated comment, reflecting that we divide by two because the variables we are annotating are within the inner scope of the ranged-based for loop.

[PATCH] D43089: clang: Add ARCTargetInfo

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:8185 +unsigned FreeRegs) const { + // TODO: C++ ABI? + unsigned SizeInRegs = (getContext().getTypeSize(Ty) + 31) / 32; Please do go ahead

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

Hahnfeld added inline comments. Comment at: test/Driver/unix-openmp-offload-gpu.c:15 +/// bitcode library that will be found via the LIBRARY_PATH. +// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc +// RUN: env LIBRARY_PATH=/tmp gtbercea wrote: > Hahnfeld

[libcxx] r325147 - Add a catch for std::length_error for the case where the string can't handle 2GB. (like say 32-bit big-endian)

Author: marshall Date: Wed Feb 14 10:05:25 2018 New Revision: 325147 URL: http://llvm.org/viewvc/llvm-project?rev=325147=rev Log: Add a catch for std::length_error for the case where the string can't handle 2GB. (like say 32-bit big-endian) Modified:

[PATCH] D43298: [clang-format] Support repeated field lists in protos

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This patch adds support for list initialization of proto repeated fields: keys: [1, 2, 3] Repository: rC Clang https://reviews.llvm.org/D43298 Files: lib/Format/TokenAnnotator.cpp

RE: r325081 - Implement function attribute artificial

Thanks Richard. I’ll update the documentation and submit a new patch for review. Elizabeth From: Keane, Erich Sent: Wednesday, February 14, 2018 11:33 AM To: Richard Smith ; Andrews, Elizabeth Cc: cfe-commits

[PATCH] D43094: AMDGPU: Enable PIC by default for amdgcn

kzhuravl added a comment. Ping. https://reviews.llvm.org/D43094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43204: [OpenMP] Fix trailing space when printing pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rC325145: [OpenMP] Fix trailing space when printing pragmas, by Joel. E. Denny (authored by ABataev, committed by ). Repository: rC Clang https://reviews.llvm.org/D43204 Files:

[PATCH] D43204: [OpenMP] Fix trailing space when printing pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rL325145: [OpenMP] Fix trailing space when printing pragmas, by Joel. E. Denny (authored by ABataev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r325145 - [OpenMP] Fix trailing space when printing pragmas, by Joel. E. Denny

Author: abataev Date: Wed Feb 14 09:38:47 2018 New Revision: 325145 URL: http://llvm.org/viewvc/llvm-project?rev=325145=rev Log: [OpenMP] Fix trailing space when printing pragmas, by Joel. E. Denny Summary: -ast-print prints omp pragmas with a trailing space. While this behavior is likely of

[PATCH] D43290: clang-format: tweak formatting of variable initialization blocks

djasper added a comment. What you are doing makes sense to me. My only hesitation is whether we should maybe completely disallow breaking between = and { when Cpp11BracedListStyle is false instead of solving this via penalties. Specifically, | 80

[PATCH] D43294: [clang-format] Recognize percents as format specifiers in protos

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Ok.. I guess ;) Repository: rC Clang https://reviews.llvm.org/D43294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen updated this revision to Diff 134244. devnexen added a comment. Changing to pthread flag. https://reviews.llvm.org/D43279 Files: lib/Driver/ToolChains/FreeBSD.cpp Index: lib/Driver/ToolChains/FreeBSD.cpp === ---

[PATCH] D36802: AMDGPU: Cleanup most of the macros

kzhuravl added a comment. Ping. https://reviews.llvm.org/D36802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

krytarowski added inline comments. Comment at: FreeBSD.cpp:139 + CmdArgs.push_back("--no-as-needed"); + CmdArgs.push_back("-lpthread"); + CmdArgs.push_back("-lrt"); devnexen wrote: > krytarowski wrote: > > `-pthread`? > Did not seem needed maybe it s

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen added inline comments. Comment at: FreeBSD.cpp:139 + CmdArgs.push_back("--no-as-needed"); + CmdArgs.push_back("-lpthread"); + CmdArgs.push_back("-lrt"); krytarowski wrote: > `-pthread`? Did not seem needed maybe it s different for NetBSD ?

[PATCH] D43204: [OpenMP] Fix trailing space when printing pragmas

jdenny added a comment. In https://reviews.llvm.org/D43204#1007502, @ABataev wrote: > LG Alexey: Thanks for accepting. I do not have commit privileges. Would you please commit for me? https://reviews.llvm.org/D43204 ___ cfe-commits mailing list

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

krytarowski added inline comments. Comment at: FreeBSD.cpp:139 + CmdArgs.push_back("--no-as-needed"); + CmdArgs.push_back("-lpthread"); + CmdArgs.push_back("-lrt"); `-pthread`? Repository: rC Clang https://reviews.llvm.org/D43279

[PATCH] D43089: clang: Add ARCTargetInfo

petecoup added a comment. Hi Tatyana, Thanks for taking a look here, and sorry for the delay. I tried to follow the other target's usage patterns here. I'm happy to update/change this...I'll add a couple of clang reviewers here to weigh in? https://reviews.llvm.org/D43089

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea added inline comments. Comment at: test/Driver/unix-openmp-offload-gpu.c:15 +/// bitcode library that will be found via the LIBRARY_PATH. +// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc +// RUN: env LIBRARY_PATH=/tmp Hahnfeld wrote: > Hahnfeld

  1   2   >