[clang] 7063ac1 - [HIP] Allow target addr space in target builtins

Author: Anshil Gandhi Date: 2021-08-19T23:51:58-06:00 New Revision: 7063ac1afa656bdbb851c8ef120ff699c2e98483 URL: https://github.com/llvm/llvm-project/commit/7063ac1afa656bdbb851c8ef120ff699c2e98483 DIFF: https://github.com/llvm/llvm-project/commit/7063ac1afa656bdbb851c8ef120ff699c2e98483.diff

[libclc] 59510c4 - libclc: Fix rounding during type conversion

Author: Daniel Stone Date: 2021-08-19T22:24:19-07:00 New Revision: 59510c421208e178de63b3640787d02ad56deb37 URL: https://github.com/llvm/llvm-project/commit/59510c421208e178de63b3640787d02ad56deb37 DIFF: https://github.com/llvm/llvm-project/commit/59510c421208e178de63b3640787d02ad56deb37.diff

[PATCH] D106620: [Clang][LLVM] generate btf_tag annotations for func parameters

yonghong-song updated this revision to Diff 367711. yonghong-song added a comment. - fix llvm/unittests failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106620/new/ https://reviews.llvm.org/D106620 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D106619: [Clang][LLVM] generate btf_tag annotations for DIGlobalVariable

yonghong-song updated this revision to Diff 367710. yonghong-song added a comment. - fix llvm/unittest failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106619/new/ https://reviews.llvm.org/D106619 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D106616: [Clang][LLVM] generate btf_tag annotations for DIDerived types

yonghong-song updated this revision to Diff 367709. yonghong-song added a comment. - use creation-parameters for annotations instead of replacement-style APIs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106616/new/

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added a comment. @asb Thanks for report that, there is no warning and build error when I build with GCC 7 (which is default compiler in Ubuntu 18.04), but I can reproduce that with clang 13, seems like I should switch my default compiler :P Repository: rG LLVM Github Monorepo

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 367704. kito-cheng added a comment. Changes: - Fix build warning and build error with clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D105168 Files:

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

woodruffw created this revision. woodruffw added reviewers: klimek, rsmith. woodruffw added a project: clang. woodruffw requested review of this revision. Herald added a subscriber: cfe-commits. Without this, the combination of `-ast-dump=json` and `-ast-dump-filter FILTER` produces invalid

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui updated this revision to Diff 367700. kamleshbhalui added a comment. clang formatted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/ https://reviews.llvm.org/D108421 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp Index:

[clang] 508b066 - [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

Author: Anshil Gandhi Date: 2021-08-19T20:51:19-06:00 New Revision: 508b06699a396cc6f2f2602dab350860cb69f087 URL: https://github.com/llvm/llvm-project/commit/508b06699a396cc6f2f2602dab350860cb69f087 DIFF: https://github.com/llvm/llvm-project/commit/508b06699a396cc6f2f2602dab350860cb69f087.diff

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d4faa8ac3e7: [PowerPC] Implement cmplxl builtins (authored by Conanap). Changed prior to commit:

[clang] 9d4faa8 - [PowerPC] Implement cmplxl builtins

Author: Albion Fung Date: 2021-08-19T21:36:43-05:00 New Revision: 9d4faa8ac3e7f98b1ca09951d4d3a015aeedab38 URL: https://github.com/llvm/llvm-project/commit/9d4faa8ac3e7f98b1ca09951d4d3a015aeedab38 DIFF: https://github.com/llvm/llvm-project/commit/9d4faa8ac3e7f98b1ca09951d4d3a015aeedab38.diff

[PATCH] D105267: [X86] AVX512FP16 instructions enabling 4/6

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, thanks. May wait 1 or 2 days for the comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105267/new/

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei added a comment. In D105265#2955329 , @vitalybuka wrote: > I suspect this error from this or D105331 > https://lab.llvm.org/buildbot/#/builders/85/builds/6132 Thanks @vitalybuka for the information. I didn't

[clang] cab12fc - [DebugInfo] convert btf_tag attrs to annotations for DIComposite types

Author: Yonghong Song Date: 2021-08-19T18:01:29-07:00 New Revision: cab12fc28c75ea82b747d636a9d20f0840777299 URL: https://github.com/llvm/llvm-project/commit/cab12fc28c75ea82b747d636a9d20f0840777299 DIFF: https://github.com/llvm/llvm-project/commit/cab12fc28c75ea82b747d636a9d20f0840777299.diff

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:538 +for (size_t I = 0; I < FD->getNumParams(); ++I) { + if (const auto *Param = FD->getParamDecl(I)) { +auto T = Param->getType(); tom-anders wrote: >

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 added a comment. >> and it would be more of an optimization than correctness issue as far as I >> understand Yeah, this is right, indeed. Maybe @rpbeltran has some idea or motivating cases for OR pattern? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

nathanchance added a comment. I am still running a series of builds against the Linux kernel but I already see one instance of this warning where the suggestion would change the meaning of the code in an incorrect way: drivers/input/touchscreen.c:81:17: warning: use of bitwise '|' with

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

LuoYuanke added a comment. I understand now. Thanks, Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105268/new/ https://reviews.llvm.org/D105268 ___ cfe-commits mailing list

[PATCH] D108401: [WebAssembly] Make bitmask instructions return unsigned ints

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd3bd63df26a: [WebAssembly] Make bitmask instructions return unsigned ints (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D108401?vs=367591=367653#toc Repository: rG LLVM

[clang] fd3bd63 - [WebAssembly] Make bitmask instructions return unsigned ints

Author: Thomas Lively Date: 2021-08-19T16:23:47-07:00 New Revision: fd3bd63df26ad0a3865fd1fcbdbbd0063f2b0761 URL: https://github.com/llvm/llvm-project/commit/fd3bd63df26ad0a3865fd1fcbdbbd0063f2b0761 DIFF: https://github.com/llvm/llvm-project/commit/fd3bd63df26ad0a3865fd1fcbdbbd0063f2b0761.diff

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

tiagoma added a comment. I am getting false positives with struct S{}; void f(__unaligned S*); void scope() { S s; f(); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943

[PATCH] D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory

a.elovikov created this revision. a.elovikov added reviewers: erichkeane, craig.topper. Herald added subscribers: pengfei, hiraditya, tpr, mgorny. a.elovikov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Some part of

[PATCH] D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp

a.elovikov created this revision. a.elovikov added reviewers: erichkeane, craig.topper. Herald added a subscriber: hiraditya. a.elovikov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. ...that is located under

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

a.elovikov created this revision. a.elovikov added reviewers: erichkeane, craig.topper. a.elovikov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108422

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui created this revision. kamleshbhalui added reviewers: MaskRay, pengfei. kamleshbhalui added a project: OpenMP. Herald added subscribers: guansong, yaxunl. kamleshbhalui requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits,

[PATCH] D108401: [WebAssembly] Make bitmask instructions return unsigned ints

tlively added a comment. Thanks! Will move the relevant test changes up from https://reviews.llvm.org/D108412 to here before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108401/new/ https://reviews.llvm.org/D108401

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov marked 3 inline comments as done. a.elovikov added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1071 +assert(llvm::is_contained(Priorities, Priority) && + "Priorites don't form consequtive range!"); + } erichkeane wrote:

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov updated this revision to Diff 367640. a.elovikov added a comment. Apply reviewers' suggestions. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151 Files:

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fded193e7a8: [DebugInfo] generate btf_tag annotations for DIComposite types (authored by yonghong-song). Changed prior to commit:

[PATCH] D108412: [WebAssembly] Add SIMD intrinsics using unsigned integers

tlively added a comment. In D108412#2955996 , @craig.topper wrote: > Did you read this twitter thread too or just coincidence? > https://twitter.com/rygorous/status/1428207170403725316?s=20 Yes I did :D Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D108407: [CodeGen][WIP] Avoid generating Record layouts for pointee types

dblaikie added a comment. Notion seems plausible - though if there's some way to refactor so there's less need for manual insertion/maintenance of calls to `ConvertTypeForMem` that'd be good/important. I don't think there'd be anything fundamentally wrong with this approach - though checking

[PATCH] D108412: [WebAssembly] Add SIMD intrinsics using unsigned integers

craig.topper added a comment. Did you read this twitter thread too or just coincidence? https://twitter.com/rygorous/status/1428207170403725316?s=20 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108412/new/ https://reviews.llvm.org/D108412

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

rpbeltran added a comment. Thanks! And sorry for missing that point in your first comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108415: [WebAssembly] Make shift values unsigned in wasm_simd128.h

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On some platforms, negative

[PATCH] D108412: [WebAssembly] Add SIMD intrinsics using unsigned integers

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For each SIMD intrinsic

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 added a comment. @rpbeltran please check new revision, I added support for bitwise OR. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 ___ cfe-commits mailing list

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 added a comment. In D108003#2955009 , @aeubanks wrote: > In D108003#2944178 , @aeubanks > wrote: > >> I ran this over Chrome and ran into a use case that looks legitimate. It >> seems like the pattern

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 updated this revision to Diff 367611. xbolva00 edited the summary of this revision. xbolva00 added a comment. - Only warn when both sides have potentional side effects (conversative, but covers motivating case, reduces useless noise - which may hide real bug - caused by this warning) -

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka added inline comments. Comment at: llvm/test/CodeGen/X86/asan-check-memaccess-or.ll:47 + %2 = bitcast i64* %x to i8* + call void @llvm.asan.check.memaccess(i8* %2, i64 2147450880, i32 0, + i32 3, i32 3, i32 1)

[PATCH] D108407: [CodeGen][WIP] Avoid generating Record layouts for pointee types

teemperor added a comment. I'm mostly putting this up to get some early feedback if anyone sees a problem with using opaque types here (e.g. it breaks some optimizations, etc.). If it does, it would still be nice if we could at least make this happen on some opt-in bases as it would be very

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], eugenis wrote: > vitalybuka wrote: > > pcc wrote: > > > eugenis wrote: > > > >

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

pcc added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], kstoimenov wrote: > eugenis wrote: > > vitalybuka wrote: > > > pcc wrote: > > > > eugenis

[PATCH] D108407: [CodeGen][WIP] Avoid generating Record layouts for pointee types

teemperor created this revision. teemperor added reviewers: dblaikie, rjmccall, rsmith, v.g.vassilev. teemperor added a project: clang. Herald added a subscriber: dexonsmith. teemperor requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits. Herald added a project:

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov marked an inline comment as done. kstoimenov added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], eugenis wrote: > vitalybuka wrote: > > pcc

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

vitalybuka added inline comments. Comment at: clang/test/CodeGen/asan-use-callbacks.cpp:9 +// RUN: -fsanitize=address %s -fsanitize-address-outline-instrumentation \ +// RUN: -mllvm -asan-optimize-callbacks \ +// RUN: | FileCheck %s --check-prefixes=CHECK-OPTIMIZED

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

vitalybuka added inline comments. Comment at: clang/test/CodeGen/asan-use-callbacks.cpp:9 +// RUN: -fsanitize=address %s -fsanitize-address-outline-instrumentation \ +// RUN: -mllvm -asan-optimize-callbacks \ +// RUN: | FileCheck %s --check-prefixes=CHECK-OPTIMIZED

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 367601. kstoimenov retitled this revision from "[asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86." to "[asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.".

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

eugenis added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], vitalybuka wrote: > pcc wrote: > > eugenis wrote: > > > vitalybuka wrote: > > > >

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], pcc wrote: > eugenis wrote: > > vitalybuka wrote: > > > kstoimenov wrote: > > > >

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

pcc added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], eugenis wrote: > vitalybuka wrote: > > kstoimenov wrote: > > > vitalybuka wrote: > > > >

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added a comment. Thank you so much for Alex's review!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 ___ cfe-commits mailing list

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc274b1986680: Add implicit map for a list item appears in a reduction clause. (authored by jyu2). Changed prior to commit: https://reviews.llvm.org/D108132?vs=366991=367597#toc Repository: rG LLVM

[clang] c274b19 - Add implicit map for a list item appears in a reduction clause.

Author: Jennifer Yu Date: 2021-08-19T12:53:47-07:00 New Revision: c274b198668040acc239b349ef1f7820c91a95c8 URL: https://github.com/llvm/llvm-project/commit/c274b198668040acc239b349ef1f7820c91a95c8 DIFF: https://github.com/llvm/llvm-project/commit/c274b198668040acc239b349ef1f7820c91a95c8.diff

[PATCH] D106994: [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

vsapsai added a comment. Tested clang with this change on internal code and there were no regressions. Also have done limited testing of runtime behavior of projects built with this clang - no errors encountered. So the testing so far hasn't found any issues. Repository: rG LLVM Github

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

erichkeane added a comment. This whole function seems a little suspect, but I don't have a good example of a place it would break. Is there no cases where a lookup could result in the same COUNT but different declaration set? I guess it is more the question of whether a transparent context

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

yonghong-song added a comment. In D106615#2955622 , @dblaikie wrote: > Looks alright - please commit the LLVM and Clang portions of this separately. > (LLVM first, shouldn't require any changes to clang/should be standalone, > then committing the clang

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, rsmith, rjmccall, jyknight. aaron.ballman requested review of this revision. Herald added a project: clang. When calculating the name to display for inline namespaces, we have custom logic to try to hide redundant

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks alright - please commit the LLVM and Clang portions of this separately. (LLVM first, shouldn't require any changes to clang/should be standalone, then committing the clang change

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

RKSimon added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:4231 + // Only look at the first documentation if there are several. + // (As of now, only one attribute has multiple documentation entries). + break; sammccall

[PATCH] D108401: [WebAssembly] Make bitmask instructions return unsigned ints

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since they are bitmasks, it

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield updated this revision to Diff 367589. JonChesterfield added a comment. - whitespace, drop asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llvm.org/D108380 Files:

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield updated this revision to Diff 367587. JonChesterfield added a comment. - delete log2 accessors per review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llvm.org/D108380 Files:

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:538 +for (size_t I = 0; I < FD->getNumParams(); ++I) { + if (const auto *Param = FD->getParamDecl(I)) { +auto T = Param->getType(); sammccall wrote:

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 367585. kstoimenov added a comment. Removed unused encodeMemToShadowInfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files:

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 added a comment. In D108003#2955058 , @rpbeltran wrote: > This patch seems like a great contribution! Really glad to see this being > added. I did have a question though on why this only appears to catch "&" vs > "&&" instead of doing the same

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

eugenis added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], vitalybuka wrote: > kstoimenov wrote: > > vitalybuka wrote: > > > vitalybuka wrote: > > >

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:102 +return R; + } }; jdoerfert wrote: > JonChesterfield wrote: > > jdoerfert wrote: > > > It should be in the device rtl then, no? > > This header is

[PATCH] D108377: [asan] Implemented custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 367577. kstoimenov added a comment. Update before expanding intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files:

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 367575. kstoimenov added a comment. Update before expanding intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files:

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

vitalybuka added a subscriber: eugenis. vitalybuka added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], kstoimenov wrote: > vitalybuka wrote: > >

[PATCH] D108380: [openmp][nfc] Refactor GridValues

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:102 +return R; + } }; JonChesterfield wrote: > jdoerfert wrote: > > It should be in the device rtl then, no? > This header is currently used from clang and the

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:547 +if (isa(Arg)) { + Location = Arg->getBeginLoc(); +} else if (auto *M = dyn_cast(Arg)) { tom-anders wrote: > sammccall wrote:

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov marked an inline comment as done. kstoimenov added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], vitalybuka wrote: > vitalybuka wrote: > >

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

MaskRay added a comment. If you want to do this proper, you may look at how -fbinutils-version= was implemented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80392/new/ https://reviews.llvm.org/D80392

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. `MCTargetOptionsCommandFlags.cpp` may be a better place for the internal cl::opt option. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:30 +cl::opt +

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

vitalybuka added a subscriber: kstoimenov. vitalybuka added a comment. FYI @kstoimenov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105265 ___ cfe-commits mailing

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders planned changes to this revision. tom-anders added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:547 +if (isa(Arg)) { + Location = Arg->getBeginLoc(); +} else if (auto *M = dyn_cast(Arg)) {

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

vitalybuka added a comment. I suspect this error from this or D105331 https://lab.llvm.org/buildbot/#/builders/85/builds/6132 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

dexonsmith added a comment. The patch seems mostly straightforward, but can you clarify whether there was a functionality change for clang-scan-deps? My reading of the code suggests not, because it was using ResourceDirectoryCache before and still will... in which case, can you walk me through

Re: [clang] f22e586 - [Sema] CheckObjCBridgeNSCast - fix dead code warning. NFCI.

Sorry, It's not. On Thu, 19 Aug 2021 at 11:21, Vitaly Buka wrote: > Could this be a crash from this patch > https://lab.llvm.org/buildbot/#/builders/85/builds/6135/steps/10/logs/stdio > ? > > On Wed, 18 Aug 2021 at 03:53, Simon Pilgrim via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >>

Re: [clang] f22e586 - [Sema] CheckObjCBridgeNSCast - fix dead code warning. NFCI.

Could this be a crash from this patch https://lab.llvm.org/buildbot/#/builders/85/builds/6135/steps/10/logs/stdio ? On Wed, 18 Aug 2021 at 03:53, Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Simon Pilgrim > Date: 2021-08-18T11:53:27+01:00 > New Revision:

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:102 +return R; + } }; jdoerfert wrote: > It should be in the device rtl then, no? This header is currently used from clang and the (amdgpu, could also be

[PATCH] D108377: [asan] Implemented custom calling convention similar used by HWASan for X86.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:571 + getShadowMapping(TargetTriple, M.getDataLayout().getPointerSizeInBits(), + ClEnableKasan.getNumOccurrences() > 0); + *ShadowBase =

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

vitalybuka added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], vitalybuka wrote: > PTAL at lvm.read_register.i32 > > How about: > >

[PATCH] D105177: [clangd] Implemented indexing of standard library

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/StdLibIndexTests.cpp:51 + Req.AnyScope = true; + EXPECT_THAT(match(*Index, Req), + UnorderedElementsAre(llvm::StringRef("myfunc"), kuhnel wrote: > @sammccall I seem to be

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

vitalybuka added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], PTAL at lvm.read_register.i32 How about: llvm.asan.check.memaccess ->

[PATCH] D108380: [openmp][nfc] Refactor GridValues

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:102 +return R; + } }; It should be in the device rtl then, no? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:314 // (these tend to be vague, like Type or Unknown) +// - Resolved tokens (i.e. without the "dependent-name" modifier) with kind +// "Unknown" are less reliable than resolved

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

Hahnfeld added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:209-211 + Version = FS.exists(LibDevicePath + "/libdevice.10.bc") +? Version = CudaVersion::NEW +: Version = CudaVersion::CUDA_70; tra

[PATCH] D108392: [OpenCL] Fix parsing of opencl-c.h in CL 3.0 with device-scope atomics enabled

kpet created this revision. kpet added a reviewer: Anastasia. Herald added subscribers: ldrumm, jfb, kristof.beyls, yaxunl. kpet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also declare and test the __opencl_c_atomic_scope_device and

[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

dexonsmith added inline comments. Comment at: llvm/lib/CodeGen/MIRSampleProfile.cpp:289 + +bool MIRProfileLoaderPass::runOnMachineFunction(MachineFunction ) { + if (!MIRSampleLoader->isValid()) JDevlieghere wrote: > Why is this outside the `llvm` namespace? I

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

yaron.keren added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4268 // Read the AST block. if (ASTReadResult Result = ReadASTBlock(F, ClientLoadCapabilities)) + return Failure; vsapsai wrote: > yaron.keren wrote: > > Result

[PATCH] D108377: [asan] Implemented custom calling convention similar used by HWASan for X86.

vitalybuka added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:151 +// Get AddressSanitizer parameters. +void getAddressSanitizerParams(Module , uint64_t *ShadowBase, + int *MappingScale, bool

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4268 // Read the AST block. if (ASTReadResult Result = ReadASTBlock(F, ClientLoadCapabilities)) + return Failure; yaron.keren wrote: > Result is unused now. Thanks

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Now that I am in the process of implementing the processing of the "CPU" feature, I've realized the decision to store the CPU and HWMult information as enums instead of strings has some downsides that may outweigh the benefits: - All string values passed to options need

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

rpbeltran added a comment. This patch seems like a great contribution! Really glad to see this being added. I did have a question though on why this only appears to catch "&" vs "&&" instead of doing the same for "|" vs "||". It seems like both operators have roughly the same potential for

[PATCH] D108387: [WebAssembly] Restore builtins and intrinsics for pmin/pmax

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra updated this revision to Diff 367532. tra added a comment. Fixed an error spotted by reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108247/new/ https://reviews.llvm.org/D108247 Files: clang/include/clang/Basic/Cuda.h

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

yaron.keren added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4268 // Read the AST block. if (ASTReadResult Result = ReadASTBlock(F, ClientLoadCapabilities)) + return Failure; Result is unused now. Comment

  1   2   >