On Wed, Jul 18, 2012 at 12:10 PM, Peter Kümmel wrote:
> On 18.07.2012 11:58, Nicolas Desprès wrote:
>>
>> On Tue, Jul 17, 2012 at 11:39 PM, Bill Hoffman
>> wrote:
>>>
>>> On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
>
>
> On 7/17/201
On 18.07.2012 11:58, Nicolas Desprès wrote:
On Tue, Jul 17, 2012 at 11:39 PM, Bill Hoffman wrote:
On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to
cmNinjaTargetGe
On 18.07.2012 11:58, Nicolas Desprès wrote:
On Tue, Jul 17, 2012 at 11:39 PM, Bill Hoffman wrote:
On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to
cmNinjaTargetGe
On Tue, Jul 17, 2012 at 11:39 PM, Bill Hoffman wrote:
> On 7/17/2012 1:43 PM, Peter Kümmel wrote:
>>
>> On 17.07.2012 19:32, Bill Hoffman wrote:
>>>
>>> On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to
cmNinjaTargetGenerator which
On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to
cmNinjaTargetGenerator which
forwards the call to the Local/Global classes.
Lets just add the friend stuff for now so
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to cmNinjaTargetGenerator which
forwards the call to the Local/Global classes.
Lets just add the friend stuff for now so we can get the dashboard
building again.
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to cmNinjaTargetGenerator which
forwards the call to the Local/Global classes.
Lets just add the friend stuff for now so we can get the dashboard
building again.
Thanks.
--
Bill Hoffman
Kitware, Inc.
28
On Tue, Jul 17, 2012 at 7:21 PM, Peter Kümmel wrote:
> On 17.07.2012 19:11, Nicolas Desprès wrote:
>>
>>
>> I don't like the friend keyword either but I try to follow the current
>> architecture of CMake.
>
>
> Yes, I know.
>
>
>> In cmLocalUnixMakefileGenerator you can see that:
>>
>>friend c
On 17.07.2012 19:11, Nicolas Desprès wrote:
I don't like the friend keyword either but I try to follow the current
architecture of CMake.
Yes, I know.
In cmLocalUnixMakefileGenerator you can see that:
friend class cmMakefileTargetGenerator;
friend class cmMakefileExecutableTargetGener
On Tue, Jul 17, 2012 at 7:01 PM, Peter Kümmel wrote:
> On 17.07.2012 15:39, Nicolas Desprès wrote:
>>
>> On Tue, Jul 17, 2012 at 3:29 PM, Bill Hoffman
>> wrote:
>>>
>>> On 7/17/2012 8:10 AM, Peter Kümmel wrote:
On 17.07.2012 13:45, David Cole wrote:
>
>
>
> Peter, ca
On 17.07.2012 15:39, Nicolas Desprès wrote:
On Tue, Jul 17, 2012 at 3:29 PM, Bill Hoffman wrote:
On 7/17/2012 8:10 AM, Peter Kümmel wrote:
On 17.07.2012 13:45, David Cole wrote:
Peter, can you rebase this on current 'master', push this to our stage
as a branch, and merge it to 'next'...?
On Tue, Jul 17, 2012 at 3:29 PM, Bill Hoffman wrote:
> On 7/17/2012 8:10 AM, Peter Kümmel wrote:
>>
>> On 17.07.2012 13:45, David Cole wrote:
>>>
>>>
>>> Peter, can you rebase this on current 'master', push this to our stage
>>> as a branch, and merge it to 'next'...?
>>>
>>
>> Done. Let's see wha
On 7/17/2012 8:10 AM, Peter Kümmel wrote:
On 17.07.2012 13:45, David Cole wrote:
Peter, can you rebase this on current 'master', push this to our stage
as a branch, and merge it to 'next'...?
Done. Let's see what happens on CDash.
Looks ok, but is not building on Borland:
http://open.cda
On 17.07.2012 13:45, David Cole wrote:
Peter, can you rebase this on current 'master', push this to our stage
as a branch, and merge it to 'next'...?
Done. Let's see what happens on CDash.
peter
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.c
On Tue, Jul 17, 2012 at 6:27 AM, Peter Kümmel wrote:
> On 17.07.2012 10:43, Nicolas Desprès wrote:
>>
>> I have pushed a new version of ninja-fix-macosx which fix BundleTest,
>> CFBundleTest, enable them for clang and re-factor some code. Tested on
>> MacOSX and Linux. Let me know what do you thin
On 17.07.2012 10:43, Nicolas Desprès wrote:
I have pushed a new version of ninja-fix-macosx which fix BundleTest,
CFBundleTest, enable them for clang and re-factor some code. Tested on
MacOSX and Linux. Let me know what do you think.
https://github.com/polrop/CMake/commits/ninja-fix-macosx
Chee
I have pushed a new version of ninja-fix-macosx which fix BundleTest,
CFBundleTest, enable them for clang and re-factor some code. Tested on
MacOSX and Linux. Let me know what do you think.
https://github.com/polrop/CMake/commits/ninja-fix-macosx
Cheers,
Nico
On Tue, Jul 10, 2012 at 4:55 PM, Pet
On 10.07.2012 16:41, Nicolas Desprès wrote:
On Tue, Jul 10, 2012 at 2:51 PM, Peter Kümmel wrote:
On 07.07.2012 20:54, Nicolas Desprès wrote:
I have pushed the re-factor patch. Let me know what do you think. I
have tested on Linux and MacOSX with the Makefile and Ninja generator
and both work
On Tue, Jul 10, 2012 at 2:51 PM, Peter Kümmel wrote:
> On 07.07.2012 20:54, Nicolas Desprès wrote:
>>
>>
>> I have pushed the re-factor patch. Let me know what do you think. I
>> have tested on Linux and MacOSX with the Makefile and Ninja generator
>> and both work fine.
>>
>
> I've tested it here
On 07.07.2012 20:54, Nicolas Desprès wrote:
I have pushed the re-factor patch. Let me know what do you think. I
have tested on Linux and MacOSX with the Makefile and Ninja generator
and both work fine.
I've tested it here and BundleTest still fails.
It doesn't install the "Resource" files.
L
On Sat, Jul 7, 2012 at 9:02 PM, Claus Klein wrote:
> On 07.07.2012, at 20:54, Nicolas Desprès wrote:
>
> I have pushed the re-factor patch. Let me know what do you think. I
> have tested on Linux and MacOSX with the Makefile and Ninja generator
> and both work fine.
>
>
> Which OS version and Tool
On 07.07.2012, at 20:54, Nicolas Desprès wrote:
I have pushed the re-factor patch. Let me know what do you think. I
have tested on Linux and MacOSX with the Makefile and Ninja generator
and both work fine.
Which OS version and Tools do you have installed?
I merged in your patch and have still
On Fri, Jul 6, 2012 at 9:56 PM, Bill Hoffman wrote:
> On 7/6/2012 12:45 PM, Nicolas Desprčs wrote:
>>
>> Both work. Generally I use helper class with language not supporting
>> multiple inheritance but if you prefer not to use it that's not a
>> problem. I'll do the patch. Thanks for answering.
>
On 7/6/2012 12:45 PM, Nicolas Desprès wrote:
Both work. Generally I use helper class with language not supporting
multiple inheritance but if you prefer not to use it that's not a
problem. I'll do the patch. Thanks for answering.
Great, thanks for doing the work. Lets go with the helper class, s
On Fri, Jul 6, 2012 at 3:52 PM, Bill Hoffman wrote:
> On 7/6/2012 7:33 AM, Nicolas Desprès wrote:
>>
>> I agree. Any idea how you would like to re-factor it? I am thinking
>> about using multiple inheritance by introducing a cmOSXBundleGenerator
>> class with CreateFramework and CreateAppBundle. W
On 7/6/2012 7:33 AM, Nicolas Desprès wrote:
I agree. Any idea how you would like to re-factor it? I am thinking
about using multiple inheritance by introducing a cmOSXBundleGenerator
class with CreateFramework and CreateAppBundle. WDYT?
Cheers,
Nico
Thanks, this is great.
I am not a big fan of
On Fri, Jul 6, 2012 at 1:29 PM, Peter Kümmel wrote:
> On 06.07.2012 12:54, Nicolas Desprès wrote:
>>
>> Hi,
>>
>> I finally found the time to fix the Ninja generator on OS X. Mainly I
>> have fixed ExportImport and Qt4Deploy. I based my work on jkp's work
>> (https://github.com/jkp/CMake/commits/j
I agree. Any idea how you would like to re-factor it? I am thinking
about using multiple inheritance by introducing a cmOSXBundleGenerator
class with CreateFramework and CreateAppBundle. WDYT?
Cheers,
Nico
On Fri, Jul 6, 2012 at 1:13 PM, David Cole wrote:
> We should re-factor it sooner (not lat
On 06.07.2012 12:54, Nicolas Desprès wrote:
Hi,
I finally found the time to fix the Ninja generator on OS X. Mainly I
have fixed ExportImport and Qt4Deploy. I based my work on jkp's work
(https://github.com/jkp/CMake/commits/jkp/ninja-generator). Although
there are other patches in this branch,
We should re-factor it sooner (not later).
This is great, thank you very much!
But we should definitely re-factor it before merging it to 'master'
Thx,
David
On Fri, Jul 6, 2012 at 7:05 AM, Nicolas Desprès
wrote:
> I forgot to say that most of the code is duplicated from the Makefile
> gener
I forgot to say that most of the code is duplicated from the Makefile
generator. I have left some todo but this code will need to be
factored sooner or later.
On Fri, Jul 6, 2012 at 12:54 PM, Nicolas Desprès
wrote:
> Hi,
>
> I finally found the time to fix the Ninja generator on OS X. Mainly I
>
Hi,
I finally found the time to fix the Ninja generator on OS X. Mainly I
have fixed ExportImport and Qt4Deploy. I based my work on jkp's work
(https://github.com/jkp/CMake/commits/jkp/ninja-generator). Although
there are other patches in this branch, I just included commits fixing
tests. We could
32 matches
Mail list logo
