[GitHub] [hadoop] aajisaka commented on issue #1618: MAPREDUCE-7240.Exception 'Invalid event: TA_TOO_MANY_FETCH_FAILURE at…

2019-10-23 Thread GitBox
aajisaka commented on issue #1618: MAPREDUCE-7240.Exception 'Invalid event: TA_TOO_MANY_FETCH_FAILURE at… URL: https://github.com/apache/hadoop/pull/1618#issuecomment-545770276 In addition, would you create a pull request for trunk instead of branch-2.8? ---

[GitHub] [hadoop] aajisaka closed pull request #1666: HDDS-2348.Remove log4j properties for org.apache.hadoop.ozone

2019-10-23 Thread GitBox
aajisaka closed pull request #1666: HDDS-2348.Remove log4j properties for org.apache.hadoop.ozone URL: https://github.com/apache/hadoop/pull/1666 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [hadoop] aajisaka commented on issue #1666: HDDS-2348.Remove log4j properties for org.apache.hadoop.ozone

2019-10-23 Thread GitBox
aajisaka commented on issue #1666: HDDS-2348.Remove log4j properties for org.apache.hadoop.ozone URL: https://github.com/apache/hadoop/pull/1666#issuecomment-545770034 Thanks @chimney-lee for creating a PR for hadoop-ozone repo. Closing this. ---

[GitHub] [hadoop] aajisaka commented on issue #1618: MAPREDUCE-7240.Exception 'Invalid event: TA_TOO_MANY_FETCH_FAILURE at…

2019-10-23 Thread GitBox
aajisaka commented on issue #1618: MAPREDUCE-7240.Exception 'Invalid event: TA_TOO_MANY_FETCH_FAILURE at… URL: https://github.com/apache/hadoop/pull/1618#issuecomment-545769835 SUCCEEDED task is transitioned to FAILED when TA_TOO_MANY_FETCH_FAILURE event occurs, so it is natural that SUCCE

[GitHub] [hadoop] aajisaka commented on a change in pull request #1618: MAPREDUCE-7240.Exception 'Invalid event: TA_TOO_MANY_FETCH_FAILURE at…

2019-10-23 Thread GitBox
aajisaka commented on a change in pull request #1618: MAPREDUCE-7240.Exception 'Invalid event: TA_TOO_MANY_FETCH_FAILURE at… URL: https://github.com/apache/hadoop/pull/1618#discussion_r338401085 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-

[GitHub] [hadoop] aajisaka commented on a change in pull request #1618: MAPREDUCE-7240.Exception 'Invalid event: TA_TOO_MANY_FETCH_FAILURE at…

2019-10-23 Thread GitBox
aajisaka commented on a change in pull request #1618: MAPREDUCE-7240.Exception 'Invalid event: TA_TOO_MANY_FETCH_FAILURE at… URL: https://github.com/apache/hadoop/pull/1618#discussion_r338400432 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-

[GitHub] [hadoop] hadoop-yetus commented on issue #1673: HDFS-14638. [Dynamometer] Fix scripts to refer to current build structure.

2019-10-23 Thread GitBox
hadoop-yetus commented on issue #1673: HDFS-14638. [Dynamometer] Fix scripts to refer to current build structure. URL: https://github.com/apache/hadoop/pull/1673#issuecomment-545735831 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:---

[GitHub] [hadoop] jojochuang commented on issue #1673: HDFS-14638. [Dynamometer] Fix scripts to refer to current build structure.

2019-10-23 Thread GitBox
jojochuang commented on issue #1673: HDFS-14638. [Dynamometer] Fix scripts to refer to current build structure. URL: https://github.com/apache/hadoop/pull/1673#issuecomment-545732915 @smengcl would you like to review this? Th

[GitHub] [hadoop] tasanuma opened a new pull request #1673: HDFS-14638. [Dynamometer] Fix scripts to refer to current build structure.

2019-10-23 Thread GitBox
tasanuma opened a new pull request #1673: HDFS-14638. [Dynamometer] Fix scripts to refer to current build structure. URL: https://github.com/apache/hadoop/pull/1673 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pul

[GitHub] [hadoop] hadoop-yetus commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot

2019-10-23 Thread GitBox
hadoop-yetus commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670#issuecomment-545708834 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hadoop] hadoop-yetus commented on issue #1672: HDFS-14910. Rename Snapshot with Pre Descendants Fail With IllegalArgumentException

2019-10-23 Thread GitBox
hadoop-yetus commented on issue #1672: HDFS-14910. Rename Snapshot with Pre Descendants Fail With IllegalArgumentException URL: https://github.com/apache/hadoop/pull/1672#issuecomment-545705717 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot

2019-10-23 Thread GitBox
zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670#issuecomment-545695573 This patch misses considering dir to dir overwrite scenario, will modify and push later, thx. --

[GitHub] [hadoop] hadoop-yetus commented on issue #1671: HADOOP-16665. Filesystems to be closed if they failed during initialize().

2019-10-23 Thread GitBox
hadoop-yetus commented on issue #1671: HADOOP-16665. Filesystems to be closed if they failed during initialize(). URL: https://github.com/apache/hadoop/pull/1671#issuecomment-545666451 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:---

[GitHub] [hadoop] jojochuang opened a new pull request #1672: HDFS-14910. Rename Snapshot with Pre Descendants Fail With IllegalArgumentException

2019-10-23 Thread GitBox
jojochuang opened a new pull request #1672: HDFS-14910. Rename Snapshot with Pre Descendants Fail With IllegalArgumentException URL: https://github.com/apache/hadoop/pull/1672 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the t

[GitHub] [hadoop] dineshchitlangia commented on a change in pull request #1670: HDFS-14925. Rename operation should check nest snapshot

2019-10-23 Thread GitBox
dineshchitlangia commented on a change in pull request #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670#discussion_r338241039 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/name

[GitHub] [hadoop] hadoop-yetus commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot

2019-10-23 Thread GitBox
hadoop-yetus commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670#issuecomment-545602150 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hadoop] steveloughran commented on issue #1671: HADOOP-16665. Filesystems to be closed if they failed during initialize().

2019-10-23 Thread GitBox
steveloughran commented on issue #1671: HADOOP-16665. Filesystems to be closed if they failed during initialize(). URL: https://github.com/apache/hadoop/pull/1671#issuecomment-545585572 regression testing in progress. I haven't written any tests to explicitly explore the new codepat

[GitHub] [hadoop] steveloughran opened a new pull request #1671: HADOOP-16665. Filesystems to be closed if they failed during initialize().

2019-10-23 Thread GitBox
steveloughran opened a new pull request #1671: HADOOP-16665. Filesystems to be closed if they failed during initialize(). URL: https://github.com/apache/hadoop/pull/1671 Patches FileSystem to do this, and for S3A have it stop services during init exception handling. Also r

[jira] [Commented] (HADOOP-16665) Filesystems to be closed if they failed during initialize()

2019-10-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958151#comment-16958151 ] Steve Loughran commented on HADOOP-16665: - I'm implementing robust cleanup in s

[jira] [Assigned] (HADOOP-16665) Filesystems to be closed if they failed during initialize()

2019-10-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-16665: --- Assignee: Steve Loughran > Filesystems to be closed if they failed during initiali

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1667: HDFS-14308. DFSStripedInputStream curStripeBuf is not freed by unbuff…

2019-10-23 Thread GitBox
avijayanhwx commented on a change in pull request #1667: HDFS-14308. DFSStripedInputStream curStripeBuf is not freed by unbuff… URL: https://github.com/apache/hadoop/pull/1667#discussion_r338210796 ## File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1667: HDFS-14308. DFSStripedInputStream curStripeBuf is not freed by unbuff…

2019-10-23 Thread GitBox
avijayanhwx commented on a change in pull request #1667: HDFS-14308. DFSStripedInputStream curStripeBuf is not freed by unbuff… URL: https://github.com/apache/hadoop/pull/1667#discussion_r338210796 ## File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop

[GitHub] [hadoop] cxorm commented on issue #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos.

2019-10-23 Thread GitBox
cxorm commented on issue #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos. URL: https://github.com/apache/hadoop/pull/1640#issuecomment-545553004 > Most of the changes look good; that input stream cleanup looks like it will break the code as a closed stream will always get passed a

[GitHub] [hadoop] jojochuang commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot

2019-10-23 Thread GitBox
jojochuang commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670#issuecomment-545538271 @bshashikant could you help review this PR? This is an automa

[GitHub] [hadoop] steveloughran commented on issue #1668: HADOOP-16645. S3A Delegation Token extension point to use StoreContext.

2019-10-23 Thread GitBox
steveloughran commented on issue #1668: HADOOP-16645. S3A Delegation Token extension point to use StoreContext. URL: https://github.com/apache/hadoop/pull/1668#issuecomment-545531745 Happy to take the patch. I have my own PR to clean up the binding; https://github.com/apache/hadoop/

[GitHub] [hadoop] steveloughran commented on issue #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos.

2019-10-23 Thread GitBox
steveloughran commented on issue #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos. URL: https://github.com/apache/hadoop/pull/1640#issuecomment-545529030 Most of the changes look good; that input stream cleanup looks like it will break the code as a closed stream will always get pa

[GitHub] [hadoop] hadoop-yetus commented on issue #1661: HADOOP-16484. S3A to warn or fail if S3Guard is disabled

2019-10-23 Thread GitBox
hadoop-yetus commented on issue #1661: HADOOP-16484. S3A to warn or fail if S3Guard is disabled URL: https://github.com/apache/hadoop/pull/1661#issuecomment-545527968 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[GitHub] [hadoop] steveloughran commented on a change in pull request #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos.

2019-10-23 Thread GitBox
steveloughran commented on a change in pull request #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos. URL: https://github.com/apache/hadoop/pull/1640#discussion_r338152515 ## File path: hadoop-cloud-storage-project/hadoop-cos/src/main/java/org/apache/hadoop/fs/cosn/CosNativ

[GitHub] [hadoop] steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider

2019-10-23 Thread GitBox
steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider URL: https://github.com/apache/hadoop/pull/1614#issuecomment-545526777 I like all tests in our code to provide enough diagnostics on failure that we can work out what went wrong purely from the

[GitHub] [hadoop] steveloughran commented on issue #1661: HADOOP-16484. S3A to warn or fail if S3Guard is disabled

2019-10-23 Thread GitBox
steveloughran commented on issue #1661: HADOOP-16484. S3A to warn or fail if S3Guard is disabled URL: https://github.com/apache/hadoop/pull/1661#issuecomment-545518267 Thanks for the changes; looks good. One issue: is "org.apache.hadoop.fs.s3a.s3guard.disabled_warn_level" the right

[GitHub] [hadoop] zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot

2019-10-23 Thread GitBox
zhjwpku commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670#issuecomment-545517326 @manojpec, please help to review this patch :) This is an automa

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1661: HADOOP-16484. S3A to warn or fail if S3Guard is disabled

2019-10-23 Thread GitBox
hadoop-yetus removed a comment on issue #1661: HADOOP-16484. S3A to warn or fail if S3Guard is disabled URL: https://github.com/apache/hadoop/pull/1661#issuecomment-543251581 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|---

[GitHub] [hadoop] steveloughran closed pull request #1591: HADOOP-16629: support copyFile in s3afilesystem

2019-10-23 Thread GitBox
steveloughran closed pull request #1591: HADOOP-16629: support copyFile in s3afilesystem URL: https://github.com/apache/hadoop/pull/1591 This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Commented] (HADOOP-16658) S3A connector does not support including the token renewer in the token identifier

2019-10-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957984#comment-16957984 ] Hudson commented on HADOOP-16658: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Co

[GitHub] [hadoop] zhjwpku opened a new pull request #1670: HDFS-14925. Rename operation should check nest snapshot

2019-10-23 Thread GitBox
zhjwpku opened a new pull request #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670 If the src directory or any of its descendant is snapshottable and the dst directory or its any of its ancestors is snapshottable, we consid

[jira] [Resolved] (HADOOP-16658) S3A connector does not support including the token renewer in the token identifier

2019-10-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-16658. - Fix Version/s: 3.3.0 Resolution: Fixed > S3A connector does not support includin

[GitHub] [hadoop] steveloughran commented on issue #1664: HADOOP-16658 - S3A connector does not support including the token ren…

2019-10-23 Thread GitBox
steveloughran commented on issue #1664: HADOOP-16658 - S3A connector does not support including the token ren… URL: https://github.com/apache/hadoop/pull/1664#issuecomment-545502822 LGTM; thanks for changes +1 and merged to trunk -

[GitHub] [hadoop] steveloughran closed pull request #1664: HADOOP-16658 - S3A connector does not support including the token ren…

2019-10-23 Thread GitBox
steveloughran closed pull request #1664: HADOOP-16658 - S3A connector does not support including the token ren… URL: https://github.com/apache/hadoop/pull/1664 This is an automated message from the Apache Git Service. To res

[jira] [Assigned] (HADOOP-16658) S3A connector does not support including the token renewer in the token identifier

2019-10-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-16658: --- Assignee: Philip Zampino > S3A connector does not support including the token rene

[jira] [Commented] (HADOOP-16614) Missing leveldbjni package of aarch64 platform

2019-10-23 Thread Eric Yang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957953#comment-16957953 ] Eric Yang commented on HADOOP-16614: The patch looks good to me. I will commit if

[jira] [Resolved] (HADOOP-16316) S3A delegation tests fail if you set fs.s3a.secret.key

2019-10-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-16316. - Resolution: Duplicate HADOOP-16477 is the same issue; this came first but that has a PR

[GitHub] [hadoop] hadoop-yetus commented on issue #1664: HADOOP-16658 - S3A connector does not support including the token ren…

2019-10-23 Thread GitBox
hadoop-yetus commented on issue #1664: HADOOP-16658 - S3A connector does not support including the token ren… URL: https://github.com/apache/hadoop/pull/1664#issuecomment-545480247 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hadoop] bgaborg commented on issue #1661: HADOOP-16484. S3A to warn or fail if S3Guard is disabled

2019-10-23 Thread GitBox
bgaborg commented on issue #1661: HADOOP-16484. S3A to warn or fail if S3Guard is disabled URL: https://github.com/apache/hadoop/pull/1661#issuecomment-545472813 The last commit contains fixes based on the review. This is an

[GitHub] [hadoop] pzampino commented on issue #1664: HADOOP-16658 - S3A connector does not support including the token ren…

2019-10-23 Thread GitBox
pzampino commented on issue #1664: HADOOP-16658 - S3A connector does not support including the token ren… URL: https://github.com/apache/hadoop/pull/1664#issuecomment-545440963 I've made the suggested changes, and re-ran the tests (which passed again). -

[jira] [Commented] (HADOOP-16656) Document FairCallQueue configs in core-default.xml

2019-10-23 Thread Dinesh Chitlangia (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957846#comment-16957846 ] Dinesh Chitlangia commented on HADOOP-16656: [~smeng] Thank you for checkin

[jira] [Comment Edited] (HADOOP-16657) Move remaining log4j APIs over to slf4j in hadoop-common.

2019-10-23 Thread Minni Mittal (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957803#comment-16957803 ] Minni Mittal edited comment on HADOOP-16657 at 10/23/19 11:57 AM: ---

[jira] [Comment Edited] (HADOOP-16657) Move remaining log4j APIs over to slf4j in hadoop-common.

2019-10-23 Thread Minni Mittal (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957803#comment-16957803 ] Minni Mittal edited comment on HADOOP-16657 at 10/23/19 11:56 AM: ---

[jira] [Commented] (HADOOP-16657) Move remaining log4j APIs over to slf4j in hadoop-common.

2019-10-23 Thread Minni Mittal (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957803#comment-16957803 ] Minni Mittal commented on HADOOP-16657: --- Following files in hadoop-common project

[jira] [Updated] (HADOOP-16657) Move remaining log4j APIs over to slf4j in hadoop-common.

2019-10-23 Thread Minni Mittal (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Minni Mittal updated HADOOP-16657: -- Attachment: HADOOP-16657.001.patch > Move remaining log4j APIs over to slf4j in hadoop-common

[GitHub] [hadoop] hadoop-yetus commented on issue #1667: HDFS-14308. DFSStripedInputStream curStripeBuf is not freed by unbuff…

2019-10-23 Thread GitBox
hadoop-yetus commented on issue #1667: HDFS-14308. DFSStripedInputStream curStripeBuf is not freed by unbuff… URL: https://github.com/apache/hadoop/pull/1667#issuecomment-545340879 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[jira] [Commented] (HADOOP-16656) Document FairCallQueue configs in core-default.xml

2019-10-23 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957628#comment-16957628 ] Siyao Meng commented on HADOOP-16656: - [~dineshchitlangia] Thanks for the comment.