Crash using HEAD

2014-05-14 Thread Richard Röjfors
Hi, I started using: 74dbbc974550aac32610e5bf6448e93811e06ff8 Now I experience this crash 100% of the times when wifi is to be enabled: 00:40:30 connmand[991]: src/technology.c:set_propert

Re: Connman crashes when loosing network

2014-05-14 Thread Patrik Flykt
Hi, On Thu, 2014-05-15 at 06:15 +, Marcel Mulder wrote: > Hi, > > Does nobody know what is going when connman does an abort with signal > 11? It is reproducible en a very simple setup. It is a connection via > a WiFi extender from which the wireless connection is lost. > I made a new

RE: Connman crashes when loosing network

2014-05-14 Thread Michael Trimarchi
Hi Il 15/mag/2014 08:15 "Marcel Mulder" ha scritto: > > Hi, > > Does nobody know what is going when connman does an abort with signal 11? It is reproducible en a very simple setup. It is a connection via a WiFi extender from which the wireless connection is lost. > I made a new build with HEAD e9

RE: Connman crashes when loosing network

2014-05-14 Thread Marcel Mulder
Hi, Does nobody know what is going when connman does an abort with signal 11? It is reproducible en a very simple setup. It is a connection via a WiFi extender from which the wireless connection is lost. I made a new build with HEAD e96a2cb241debd7a65971d30f28e903b9a1da49b but that does not cha

[PATCH 0/2] test: Code style issues and P2P Invite

2014-05-14 Thread Eduardo Abinader
This patchset solves code style minor issues and adds P2P invite and its signal. Eduardo Abinader (2): test: Fix code style in p2p-on-supplicant test: Added P2P invite call and signal result test/p2p-on-supplicant | 31 --- 1 file changed, 28 insertions(+), 3 dele

[PATCH 1/2] test: Fix code style in p2p-on-supplicant

2014-05-14 Thread Eduardo Abinader
Just complying to code style. --- test/p2p-on-supplicant | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/p2p-on-supplicant b/test/p2p-on-supplicant index 025bf6e..68b4996 100755 --- a/test/p2p-on-supplicant +++ b/test/p2p-on-supplicant @@ -21,8 +21,8 @@ DBUS_PROPERTIE

[PATCH 2/2] test: Added P2P invite call and signal result

2014-05-14 Thread Eduardo Abinader
Invite discovered P2P peer to join or form a group. --- test/p2p-on-supplicant | 26 ++ 1 file changed, 26 insertions(+) diff --git a/test/p2p-on-supplicant b/test/p2p-on-supplicant index 68b4996..3e6f277 100755 --- a/test/p2p-on-supplicant +++ b/test/p2p-on-supplicant @@

Re: Unreachable favorite network

2014-05-14 Thread Lorn Potter
On 14 May 2014, at 11:27 pm, Julien Massot wrote: > Hi ConnMan developers, > > My users are requesting stronger than before to be able to remove > unreachable favorites services. > > At the moment it's not possible with ConnMan API. > > I understand that returning unreachable networks is qui

Re: Unreachable favorite network

2014-05-14 Thread Marcel Holtmann
Hi Julien, > My users are requesting stronger than before to be able to remove > unreachable favorites services. > > At the moment it's not possible with ConnMan API. > > I understand that returning unreachable networks is quiet confusing, > but I think their request is legitimate. > > Often th

Re: Unreachable favorite network

2014-05-14 Thread Julien Massot
Hi Patrick, On Wed, May 14, 2014 at 4:02 PM, Patrik Flykt wrote: > > Hi, > > On Wed, 2014-05-14 at 15:27 +0200, Julien Massot wrote: > > I understand that returning unreachable networks is quiet confusing, > > but I think their request is legitimate. > > > > Often they think they remove

Re: Unreachable favorite network

2014-05-14 Thread Julien Massot
Hi Tomasz, On Wed, May 14, 2014 at 3:46 PM, Tomasz Bursztyka < tomasz.burszt...@linux.intel.com> wrote: > Hi Julien, > > > Often they think they remove all the favorite networks in the UI list, >> and they don't understand that some networks are still stored. >> > > What do they want to do? Sel

Re: Unreachable favorite network

2014-05-14 Thread Patrik Flykt
Hi, On Wed, 2014-05-14 at 15:27 +0200, Julien Massot wrote: > I understand that returning unreachable networks is quiet confusing, > but I think their request is legitimate. > > Often they think they remove all the favorite networks in the UI list, > and they don't understand that some n

Re: [RFC 1/3] wifi: Don't fetch interface name from device structure

2014-05-14 Thread Patrik Flykt
On Tue, 2014-05-06 at 12:41 +0300, Patrik Flykt wrote: > Update the code to use connman_inet_ifname() when fetching the > interface name. This allows the interface name to be removed from > the device structure, as the interface name is not requested > from the device structure elsewhere. Commit m

Re: [PATCH 0/3 v2] Various fixes around P2P

2014-05-14 Thread Patrik Flykt
On Wed, 2014-05-14 at 15:41 +0300, Tomasz Bursztyka wrote: > My first version of the patchset was made on top of up-coming patches... Applied all three patches, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.

Re: Unreachable favorite network

2014-05-14 Thread Tomasz Bursztyka
Hi Julien, Often they think they remove all the favorite networks in the UI list, and they don't understand that some networks are still stored. What do they want to do? Selectively removing some known networks, or removing all known ones? If it's the later, a small script could just do that

Unreachable favorite network

2014-05-14 Thread Julien Massot
Hi ConnMan developers, My users are requesting stronger than before to be able to remove unreachable favorites services. At the moment it's not possible with ConnMan API. I understand that returning unreachable networks is quiet confusing, but I think their request is legitimate. Often they thi

[PATCH 2/3] technology: Fix a false positive null dereference

2014-05-14 Thread Tomasz Bursztyka
P2P technology cannot exist without wifi technology, so if P2P is present, wifi is present as well. Thus what coverity thinks is a null dereference is a false positive here. Reported by Daniel Wagner --- src/technology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tec

[PATCH 3/3] wifi: Check the returned code when registering the P2P technology driver

2014-05-14 Thread Tomasz Bursztyka
Reported by Daniel Wagner --- plugins/wifi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 7c412ef..988ca1a 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -1885,8 +1885,11 @@ static void p2p_support(GSupplicantInterface *inte

[PATCH 1/3] gsupplicant: Fix an emptyness test on an array

2014-05-14 Thread Tomasz Bursztyka
Reported by Daniel Wagner --- gsupplicant/supplicant.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 8a16663..b483f9b 100644 --- a/gsupplicant/supplicant.c +++ b/gsupplicant/supplicant.c @@ -2411,10 +2411,12 @@ sta

[PATCH 0/3 v2] Various fixes around P2P

2014-05-14 Thread Tomasz Bursztyka
My first version of the patchset was made on top of up-coming patches... Tomasz Bursztyka (3): gsupplicant: Fix an emptyness test on an array technology: Fix a false positive null dereference wifi: Check the returned code when registering the P2P technology driver gsupplicant/supplica

Re: [PATCH 2/2] test: Arg parsing for p2p-on-supplication

2014-05-14 Thread Patrik Flykt
On Wed, 2014-05-14 at 07:39 -0400, Eduardo Abinader wrote: > Argument parsing functionality for commands and options: > - dbus is now wpa_s property > - help is being shown from the command_list built in arg > parse time > - Added enum like class (ArgFields) for future optio

Re: [PATCH 1/2] test: Minor typos removal in p2p-on-supplicant

2014-05-14 Thread Patrik Flykt
On Wed, 2014-05-14 at 07:39 -0400, Eduardo Abinader wrote: > Removed minor typo issues in p2p-on-supplicant. Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] network: Properly remove addresses When DHCPv4 lease is lost

2014-05-14 Thread Patrik Flykt
On Wed, 2014-05-14 at 09:35 +0300, Patrik Flykt wrote: > As addresses were not properly removed, the D-Bus API showed IP > addresses even if the interface addresses and routing is removed > when the DHCP lease has been lost. Also ensure that the network > is no longer associating, should the lease

Re: [PATCH] agent: fix a double free in agent message handling

2014-05-14 Thread Patrik Flykt
On Wed, 2014-05-14 at 09:12 +0300, Hannu Mallat wrote: > It could happen that cleaning up the pending message in > agent_receive_message() would as a side effect clear the last > reference to the service via driver context unref function pointer. > Service cleanup would then call connman_agent_canc

Re: [PATCH v3] rtnl: Don't watch slave interfaces

2014-05-14 Thread Patrik Flykt
On Tue, 2014-05-13 at 10:43 -0700, Justin Maggard wrote: > If you are using a bond interface, the bond interface and the slave > interfaces will share the same MAC address. This can eventually > cause connman to crash, because several things depend on a unique > MAC address per interface. Applied

Re: [PATCH] agent: check for NULL parameter

2014-05-14 Thread Patrik Flykt
On Wed, 2014-05-14 at 09:22 +0300, Hannu Mallat wrote: > Check for reply parameter being NULL before using it. Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 2/2] test: Arg parsing for p2p-on-supplication

2014-05-14 Thread Patrik Flykt
On Wed, 2014-05-14 at 06:25 -0400, Eduardo Abinader wrote: > Should I resend the patch or send a new one fixing this issue? Yes, please. Once you do that, please add a version to the patch message like so: 'git format-patch --cover-letter --subject-prefix="PATCH v3" ...'. This way it's much easier

[PATCH 1/2] test: Minor typos removal in p2p-on-supplicant

2014-05-14 Thread Eduardo Abinader
Removed minor typo issues in p2p-on-supplicant. --- test/p2p-on-supplicant | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/p2p-on-supplicant b/test/p2p-on-supplicant index e845c88..734396e 100755 --- a/test/p2p-on-supplicant +++ b/test/p2p-on-supplicant @@ -185,7 +185,

[PATCH 2/2] test: Arg parsing for p2p-on-supplication

2014-05-14 Thread Eduardo Abinader
Argument parsing functionality for commands and options: - dbus is now wpa_s property - help is being shown from the command_list built in arg parse time - Added enum like class (ArgFields) for future options in arg parsing --- test/p2p-on-supplicant | 174 +

Re: [PATCH 2/2] test: Arg parsing for p2p-on-supplication

2014-05-14 Thread Eduardo Abinader
Hi Tomasz, On Wed, May 14, 2014 at 2:54 AM, Tomasz Bursztyka wrote: > Hi Eduardo, > > Minor issue: > >> @@ -100,37 +105,33 @@ class Wpa_s: >> bus.add_signal_receiver(self.__InterfaceRemoved, path=WPA_PATH, >> signal_name='InterfaceRemoved') >>