[PATCH 30/34] tethering: Avoid shadowing index variable

2012-07-16 Thread Jukka Rissanen
--- src/tethering.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/tethering.c b/src/tethering.c index decb112..0905b3b 100644 --- a/src/tethering.c +++ b/src/tethering.c @@ -131,15 +131,15 @@ static GDHCPServer *dhcp_server_start(const char

[PATCH 31/34] wpad: Avoid shadowing index variable

2012-07-16 Thread Jukka Rissanen
--- src/wpad.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/wpad.c b/src/wpad.c index 4e5834e..771a4b1 100644 --- a/src/wpad.c +++ b/src/wpad.c @@ -126,7 +126,7 @@ int __connman_wpad_start(struct connman_service *service) struct connman_wpad

[PATCH 32/34] wispr: Avoid shadowing index variable

2012-07-16 Thread Jukka Rissanen
--- src/wispr.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/wispr.c b/src/wispr.c index 9412f1e..9d4de6d 100644 --- a/src/wispr.c +++ b/src/wispr.c @@ -859,26 +859,26 @@ int __connman_wispr_start(struct connman_service *service, { struct co

[PATCH 33/34] 6to4: Avoid shadowing index variable

2012-07-16 Thread Jukka Rissanen
--- src/6to4.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/6to4.c b/src/6to4.c index 340b69e..5990265 100644 --- a/src/6to4.c +++ b/src/6to4.c @@ -137,13 +137,13 @@ static int tunnel_add_route() { struct __connman_inet_rtnl_handle rth;

[PATCH 34/34] bridge: Avoid shadowing index variable

2012-07-16 Thread Jukka Rissanen
--- src/bridge.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/bridge.c b/src/bridge.c index 2849ef7..f251e2e 100644 --- a/src/bridge.c +++ b/src/bridge.c @@ -112,28 +112,28 @@ int __connman_bridge_remove(const char *name) int __connman_bridge_

Re: [PATCH] rtnl: support PPP connections

2012-07-16 Thread Jukka Rissanen
Hi Forest, On 06/21/2012 12:06 AM, Forest Bond wrote: From: Forest Bond The ARP header type for PPP connections is ARPHRD_PPP (512). --- src/rtnl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/rtnl.c b/src/rtnl.c index 4f50219..a0e393b 100644 --- a/src/rtnl.c

Re: [PATCH 00/13] NTP: Address Failures to Synchronize

2012-07-16 Thread Jukka Rissanen
Hi Grant, On 07/16/2012 07:47 PM, Grant Erickson wrote: This patch set is an omnibus roll-up of several patches submitted Friday and over the weekend to address BMC#25486 . Two key problems are addressed in this set: 1) The NTP client will send

Re: [PATCH] gdhcp: Set client state to INIT_SELECTING on restart

2012-07-16 Thread Jukka Rissanen
Hi Forest, On 07/16/2012 04:09 PM, Forest Bond wrote: From: Forest Bond With the previous behavior, we would end up sending a discover message and then ignoring the reply due to the client state mismatch, so a restart would never result in successful acquisition of a lease. RFC 2131 specifies

Re: [PATCH] Emit PropertyChanged signal for the Clock.Time property if ntp sets a new time

2012-07-17 Thread Jukka Rissanen
Hi Fernando, On 07/16/2012 01:16 PM, Fernando Herrera wrote: --- src/clock.c | 14 ++ src/connman.h |1 + src/ntp.c |1 + 3 files changed, 16 insertions(+) diff --git a/src/clock.c b/src/clock.c index e2cc19f..f3f118a 100644 --- a/src/clock.c +++ b/src/clock.c @

Re: making ConnMan do DNS instead of writing /etc/resolv.conf

2012-07-18 Thread Jukka Rissanen
Hi Erik, On 07/18/2012 03:06 PM, Erik Bernoth wrote: Hi Marcel, thanks for your reply! 2012/7/18 Marcel Holtmann : Hi Erik, actually ConnMan creates a local DNS proxy and cache at localhost. And it should put 127.0.0.1 nameserver in /etc/resolv.conf. The -r option forces ConnMan to disable

Re: connman fails with Aborting (signal 4)

2012-07-20 Thread Jukka Rissanen
Hi Jan, On 07/20/2012 11:45 AM, Jan Pohanka wrote: Hello, I'd like to try connman on our embedded system on arm (dm365) with linux. There are two interfaces eth0 and wlan0 (both as usb dongles). After running connman it unfortunately fails immediately with following log. Could you please give

Re: [PATCH] technology: save tethering identifier and passphrase

2012-07-24 Thread Jukka Rissanen
Hi Julien, On 07/24/2012 01:31 PM, Julien Massot wrote: --- src/technology.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/src/technology.c b/src/technology.c index 6d020cb..74871a6 100644 --- a/src/technology.c +++ b/src/technology.c @@ -31

Re: BUG# 25559 - Enhance Wi-Fi connection

2012-07-24 Thread Jukka Rissanen
Hi Danny, On 07/24/2012 03:00 PM, Danny Jeongseok Seo wrote: BUG# 25559 - Enhance Wi-Fi connection Current ConnMan, the DHCP process shows quite worse performance than Android and iPhone. I have tested with TIZEN-ConnMan (0.78.4) and only IPv4 case. (with the same H/W) ConnMan takes 3.12 (aver

Re: [PATCH 0/5] dhcp: Enhance Wi-Fi connection

2012-07-25 Thread Jukka Rissanen
Hi Danny, On 07/25/2012 09:36 AM, Danny Jeongseok Seo wrote: This patch set is to skip DHCP discovery if server address already known. Bug# 2559 - Enhance Wi-Fi connection Most of the patches do not apply because they are malformed (long lines ar

Re: [PATCH 0/5] dhcp: Enhance Wi-Fi connection

2012-07-25 Thread Jukka Rissanen
On 07/25/2012 12:09 PM, Jukka Rissanen wrote: Hi Danny, On 07/25/2012 09:36 AM, Danny Jeongseok Seo wrote: This patch set is to skip DHCP discovery if server address already known. Bug# 2559 - Enhance Wi-Fi connection <https://bugs.meego.com/show_bug.cgi?id=25559> Most of the patches

Re: [PATCH 0/5] dhcp: Enhance Wi-Fi connection

2012-07-25 Thread Jukka Rissanen
On 07/25/2012 12:39 PM, Jukka Rissanen wrote: On 07/25/2012 12:09 PM, Jukka Rissanen wrote: Hi Danny, On 07/25/2012 09:36 AM, Danny Jeongseok Seo wrote: This patch set is to skip DHCP discovery if server address already known. Bug# 2559 - Enhance Wi-Fi connection <https://bugs.meego.

Re: BeagleBone - must unplug Ethernet before wireless can connect

2012-07-26 Thread Jukka Rissanen
Hi Jerrill, On 07/26/2012 06:26 AM, Jerrill Johnson wrote: On the BeagleBone, one must disconnect the Ethernet cable before a wireless connection can be made. Out of curiosity, what's the reason for this limitation? Thanks, Jerrill There is no such limitation in connman side. Perhaps you coul

Re: Ethernet Preference over Cellular

2012-07-26 Thread Jukka Rissanen
Hi Brian, On 26 July 2012 20:35, Brian Ruptash wrote: > I'm using connman 1.1 and ofono 1.7 on an embedded device with a 3G/GPRS > modem, Ethernet, and eventually I'll add USB cdc_ethernet. > > But that's not what I want ;) I need to use the Ethernet/cdc_ethernet > interfaces for debug/developme

Re: BeagleBone - must unplug Ethernet before wireless can connect

2012-07-27 Thread Jukka Rissanen
Hi Jerrill, On 07/27/2012 05:02 AM, Jerrill Johnson wrote: On Thu, Jul 26, 2012 at 4:12 AM, Jukka Rissanen < jukka.rissa...@linux.intel.com> wrote: Hi Jerrill, On 07/26/2012 06:26 AM, Jerrill Johnson wrote: On the BeagleBone, one must disconnect the Ethernet cable before a wi

[PATCH 1/3] connection: Add more debugging when setting VPN routes

2012-07-27 Thread Jukka Rissanen
--- src/connection.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/src/connection.c b/src/connection.c index d40f428..2e5cea6 100644 --- a/src/connection.c +++ b/src/connection.c @@ -149,6 +149,9 @@ static void set_vpn_routes(struct gateway_data *new_gateway, char *dest;

[PATCH 0/3] Misc VPN fixes

2012-07-27 Thread Jukka Rissanen
connect to OpenConnect VPN once. Cheers, Jukka Jukka Rissanen (3): connection: Add more debugging when setting VPN routes connection: Set VPN default route to the VPN interface provider: Allow VPN connection if not in connected state src/connection.c | 27 +++ src

[PATCH 2/3] connection: Set VPN default route to the VPN interface

2012-07-27 Thread Jukka Rissanen
Do not bother setting individual routes for default gateway because they do not seem to work properly (there is extra and incorrect route created). For VPN we set the whole interface as a default gateway route. Example of non working routes: Kernel IP routing table Destination Gateway

[PATCH 3/3] provider: Allow VPN connection if not in connected state

2012-07-27 Thread Jukka Rissanen
Allow user to connect to VPN via dbus and supplying all VPN parameters if the provider already exists but the VPN is not in connected state. This means that the user can call the Manager.ConnectProvider interface multiple times to connect to VPN service. This patch is needed so that OpenConnect ca

Re: BeagleBone tethering support (in lieu of adhoc support)

2012-07-30 Thread Jukka Rissanen
Hi Jerrill, On 07/27/2012 09:35 PM, Jerrill Johnson wrote: So your adapter supports ad-hoc > mode. To support tethering, your > adapater needs support AP(or master) > mode. Another thing is that your kernel needs CONFIG_BRIDGE enabled. Bests Jeff Jeff, Thanks for the info. I wasn't

Re: Reconnect after switching IPv4 method from off to dhcp or manual

2012-07-30 Thread Jukka Rissanen
Hi Jonathan, On 07/28/2012 07:42 AM, Jonathan Liu wrote: Hi, I have IPv4 method set to dhcp. If I set it to off, wait a few moments and set it back to dhcp the connection is not restored. Same thing happens if I switch from off to manual. Is this a bug or do I need to do something else to resto

Re: [PATCH v2 2/2] wifi: try only once when connecting to a non-favorite service

2012-07-30 Thread Jukka Rissanen
Hi Julien, On 07/30/2012 12:04 PM, Julien Massot wrote: --- plugins/wifi.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 8f3fc6c..6856ee2 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -1423,12 +1423,20 @@ static connm

Re: BeagleBone tethering support (in lieu of adhoc support)

2012-07-31 Thread Jukka Rissanen
Hi Jerrill, On 07/31/2012 05:35 AM, Jerrill Johnson wrote: On Mon, Jul 30, 2012 at 3:50 AM, Jukka Rissanen < jukka.rissa...@linux.intel.com> wrote: Hi Jerrill, See http://linuxwireless.org/en/**users/Drivers<http://linuxwireless.org/en/users/Drivers> I have D-link DWA-160

Re: BeagleBone tethering support (in lieu of adhoc support)

2012-08-02 Thread Jukka Rissanen
Hi Jerrill, On 08/02/2012 01:21 AM, Jerrill Johnson wrote: On Tue, Jul 31, 2012 at 5:58 AM, Jukka Rissanen < jukka.rissa...@linux.intel.com> wrote: Hi Jerrill, The culprit is probably the wpa_supplicant, it needs CONFIG_AP set in the config file when supplicant is compiled. You can se

[PATCH 1/2] ipconfig: Add function to check if the ipconfig is OFF

2012-08-02 Thread Jukka Rissanen
--- src/connman.h |1 + src/ipconfig.c | 19 +++ 2 files changed, 20 insertions(+) diff --git a/src/connman.h b/src/connman.h index 6726078..f2c75de 100644 --- a/src/connman.h +++ b/src/connman.h @@ -316,6 +316,7 @@ void __connman_ipconfig_set_prefixlen(struct connman_ipco

[PATCH 0/2] Fix IPv46 method setting from OFF to DHCP/AUTO

2012-08-02 Thread Jukka Rissanen
both IPv4 and IPv4 methods are OFF, then skip the service. This patch fixes this bug https://bugs.meego.com/show_bug.cgi?id=25587 Cheers, Jukka Jukka Rissanen (2): ipconfig: Add function to check if the ipconfig is OFF service: Do not try to connect to service that cannot create connec

[PATCH 2/2] service: Do not try to connect to service that cannot create connection

2012-08-02 Thread Jukka Rissanen
Check if the service IPv4/6 ipconfig is turned OFF, in this case do not try to connect to that service because it will not succeed. Fixes BMC#25587 --- src/service.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/service.c b/src/service.c index dfe1752..90e280d 1006

[RFC 0/5] Separate routing table for each interface

2012-08-06 Thread Jukka Rissanen
Hi, This patchset provides functionality for setting up a separate routing table for each interface. The patchset needs cgroup patches from Daniel to fully support application based routing so this is just preliminary work. Cheers, Jukka Jukka Rissanen (5): inet: Add functions to setup fwmark

[RFC 1/5] inet: Add functions to setup fwmark to routing table

2012-08-06 Thread Jukka Rissanen
--- src/connman.h |2 ++ src/inet.c| 77 + 2 files changed, 79 insertions(+) diff --git a/src/connman.h b/src/connman.h index 6726078..71ea1ba 100644 --- a/src/connman.h +++ b/src/connman.h @@ -193,6 +193,8 @@ int __connman_inet_rt

[RFC 3/5] device: Add fw marker setter and getter

2012-08-06 Thread Jukka Rissanen
--- src/connman.h |2 ++ src/device.c | 17 + 2 files changed, 19 insertions(+) diff --git a/src/connman.h b/src/connman.h index c70e5cc..5d125ea 100644 --- a/src/connman.h +++ b/src/connman.h @@ -500,6 +500,8 @@ void __connman_device_set_reconnect(struct connman_device *d

[RFC 2/5] inet: Add function to setup default route to a routing table

2012-08-06 Thread Jukka Rissanen
--- src/connman.h |1 + src/inet.c| 63 + 2 files changed, 64 insertions(+) diff --git a/src/connman.h b/src/connman.h index 71ea1ba..c70e5cc 100644 --- a/src/connman.h +++ b/src/connman.h @@ -195,6 +195,7 @@ int __connman_inet_rtn

[RFC 4/5] device: Set the fwmark for a device

2012-08-06 Thread Jukka Rissanen
--- src/device.c | 41 + 1 file changed, 41 insertions(+) diff --git a/src/device.c b/src/device.c index 2ec544d..c9e643d 100644 --- a/src/device.c +++ b/src/device.c @@ -72,6 +72,17 @@ struct connman_device { uint32_t fwmark; }; +/* + * Tie th

[RFC 5/5] ipconfig: Set a default route to a routing table

2012-08-06 Thread Jukka Rissanen
--- src/ipconfig.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 5e34ac0..5d597de 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -1206,11 +1206,14 @@ int __connman_ipconfig_gateway_add(struct connman_ipconfig *ipconfig)

[PATCH v2 1/4] ipconfig: Add function to check if the ipconfig is OFF

2012-08-07 Thread Jukka Rissanen
--- src/connman.h |1 + src/ipconfig.c | 19 +++ 2 files changed, 20 insertions(+) diff --git a/src/connman.h b/src/connman.h index 721f9af..e72bc2a 100644 --- a/src/connman.h +++ b/src/connman.h @@ -316,6 +316,7 @@ void __connman_ipconfig_set_prefixlen(struct connman_ipco

[PATCH v2 0/4] Fix IPv46 method setting from OFF to DHCP/AUTO

2012-08-07 Thread Jukka Rissanen
Hi, this v2 version splits the patch a bit more and removes the service state change when we are just changing the IPv4 method. Cheers, Jukka Jukka Rissanen (4): ipconfig: Add function to check if the ipconfig is OFF service: Do not try to connect to service that cannot create

[PATCH v2 2/4] service: Do not try to connect to service that cannot create connection

2012-08-07 Thread Jukka Rissanen
Check if the service IPv4/6 ipconfig is turned OFF, in this case do not try to connect to that service because it will not succeed. Fixes BMC#25587 --- src/service.c | 16 1 file changed, 16 insertions(+) diff --git a/src/service.c b/src/service.c index dfe1752..abd429c 100644

[PATCH v2 3/4] service: Do not set the service state when changing IPv4 method

2012-08-07 Thread Jukka Rissanen
The service state will be set to proper state if we are actually doing the connection so do not set the state when we are just setting the IPv4 method. --- src/service.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index abd429c..e4c13dc 10

[PATCH v2 4/4] service: Initiate autoconnect after changing ipconfig method

2012-08-07 Thread Jukka Rissanen
--- src/service.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/service.c b/src/service.c index e4c13dc..9275e54 100644 --- a/src/service.c +++ b/src/service.c @@ -2945,6 +2945,7 @@ static int set_ipconfig(struct connman_service *service, method == CO

[PATCH v2 0/4] Misc VPN fixes

2012-08-07 Thread Jukka Rissanen
Hi, this v2 only adds patch #4 where we check if the VPN server or user is trying to set invalid host route to VPN server via the VPN tunnel. That will not work so we must discard that route. Cheers, Jukka Jukka Rissanen (4): connection: Add more debugging when setting VPN routes

[PATCH v2 1/4] connection: Add more debugging when setting VPN routes

2012-08-07 Thread Jukka Rissanen
--- src/connection.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/src/connection.c b/src/connection.c index d40f428..2e5cea6 100644 --- a/src/connection.c +++ b/src/connection.c @@ -149,6 +149,9 @@ static void set_vpn_routes(struct gateway_data *new_gateway, char *dest;

[PATCH v2 2/4] connection: Set VPN default route to the VPN interface

2012-08-07 Thread Jukka Rissanen
Do not bother setting individual routes for default gateway because they do not seem to work properly (there is extra and incorrect route created). For VPN we set the whole interface as a default gateway route. Example of non working routes: Kernel IP routing table Destination Gateway

[PATCH v2 3/4] provider: Allow VPN connection if not in connected state

2012-08-07 Thread Jukka Rissanen
Allow user to connect to VPN via dbus and supplying all VPN parameters if the provider already exists but the VPN is not in connected state. This means that the user can call the Manager.ConnectProvider interface multiple times to connect to VPN service. This patch is needed so that OpenConnect ca

[PATCH v2 4/4] provider: Discard routes to VPN server via VPN tunnel

2012-08-07 Thread Jukka Rissanen
These obsolete routes must be discarded as we cannot contact VPN server via VPN tunnel. --- src/provider.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/provider.c b/src/provider.c index ebc7055..7ba1670 100644 --- a/src/provider.c +++ b/src/provider.c @@ -466,6 +466,17 @@

[PATCH v3 0/4] Misc VPN fixes

2012-08-08 Thread Jukka Rissanen
Hi, this v3 resolves the VPN server address if necessary. This is needed so that we can discard any routes to VPN server via VPN tunnel. Cheers, Jukka Jukka Rissanen (4): connection: Add more debugging when setting VPN routes connection: Set VPN default route to the VPN interface

[PATCH v3 1/4] connection: Add more debugging when setting VPN routes

2012-08-08 Thread Jukka Rissanen
--- src/connection.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/src/connection.c b/src/connection.c index d40f428..2e5cea6 100644 --- a/src/connection.c +++ b/src/connection.c @@ -149,6 +149,9 @@ static void set_vpn_routes(struct gateway_data *new_gateway, char *dest;

[PATCH v3 3/4] provider: Allow VPN connection if not in connected state

2012-08-08 Thread Jukka Rissanen
Allow user to connect to VPN via dbus and supplying all VPN parameters if the provider already exists but the VPN is not in connected state. This means that the user can call the Manager.ConnectProvider interface multiple times to connect to VPN service. This patch is needed so that OpenConnect ca

[PATCH v3 2/4] connection: Set VPN default route to the VPN interface

2012-08-08 Thread Jukka Rissanen
Do not bother setting individual routes for default gateway so for VPN we set the whole interface as a default gateway route. --- src/connection.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/src/connection.c b/src/connection.c index 2e5cea6..7212af3

[PATCH v3 4/4] provider: Discard routes to VPN server via VPN tunnel

2012-08-08 Thread Jukka Rissanen
These obsolete routes must be discarded as we cannot contact VPN server via VPN tunnel. If the VPN server address is not yet resolved, we do that while starting the VPN client process. Example of non working routes: Kernel IP routing table Destination Gateway Genmask Flags Metr

[PATCH 0/2] Disconnect VPN when underlaying service disconnects

2012-08-09 Thread Jukka Rissanen
Hi, The VPN connection was not disconnected in all cases when the service that was serving the VPN was disconnected. Cheers, Jukka Jukka Rissanen (2): inet: Add function to return route to a given host connection: Disconnect VPN when underlaying service disconnects src/connection.c

[PATCH 1/2] inet: Add function to return route to a given host

2012-08-09 Thread Jukka Rissanen
--- src/connman.h |6 +++ src/inet.c| 160 + 2 files changed, 166 insertions(+) diff --git a/src/connman.h b/src/connman.h index e72bc2a..6593360 100644 --- a/src/connman.h +++ b/src/connman.h @@ -153,6 +153,12 @@ int __connman_refr

[PATCH 2/2] connection: Disconnect VPN when underlaying service disconnects

2012-08-09 Thread Jukka Rissanen
Fixes BMC#25128 --- src/connection.c | 109 ++ 1 file changed, 68 insertions(+), 41 deletions(-) diff --git a/src/connection.c b/src/connection.c index 7212af3..a26a13a 100644 --- a/src/connection.c +++ b/src/connection.c @@ -106,10 +106,7 @@ s

[PATCH 0/2] Ignore received DHCP hostname option

2012-08-09 Thread Jukka Rissanen
Hi, This patchset disables the setting of system hostname according to received DHCP hostname option if system config file option is set. This one fixes https://bugs.meego.com/show_bug.cgi?id=25597 Cheers, Jukka Jukka Rissanen (2): main: Introduce main.conf option to disable DHCP hostname

[PATCH 1/2] main: Introduce conf file option to ignore DHCP hostname option

2012-08-09 Thread Jukka Rissanen
The DisableDHCPHostnameOption in system config file can be used to ignore the received DHCP hostname option (12). --- src/main.c| 13 + src/main.conf |6 ++ 2 files changed, 19 insertions(+) diff --git a/src/main.c b/src/main.c index 1e4809f..70c73ef 100644 --- a/src/mai

[PATCH 2/2] dhcp: Apply received hostname option according to conf file setting

2012-08-09 Thread Jukka Rissanen
We do not use the received DHCP hostname option (12) if system config file setting (DisableDHCPHostnameOption) says so. Fixes BMC#25597 --- src/dhcp.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/dhcp.c b/src/dhcp.c index 3425b6d..ab3b0cf 100644 --- a/src/d

[PATCH v2 1/2] main: Introduce conf file option to disable hostname updates

2012-08-10 Thread Jukka Rissanen
The AllowHostnameUpdates in system config file can be used to ignore the hostname update request that for example can be received via DHCP hostname option. --- src/main.c| 13 + src/main.conf |5 + 2 files changed, 18 insertions(+) diff --git a/src/main.c b/src/main.c in

[PATCH v2 0/2] Ignore received DHCP hostname option

2012-08-10 Thread Jukka Rissanen
://bugs.meego.com/show_bug.cgi?id=25597 Cheers, Jukka Jukka Rissanen (2): main: Introduce conf file option to disable hostname updates dhcp: Apply received hostname option according to conf file setting src/dhcp.c| 10 +++--- src/main.c| 13 + src/main.conf |5

[PATCH v2 2/2] dhcp: Apply received hostname option according to conf file setting

2012-08-10 Thread Jukka Rissanen
We do not use the received DHCP hostname option (12) if system config file setting says so. Fixes BMC#25597 --- src/dhcp.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/dhcp.c b/src/dhcp.c index 3425b6d..9d1a95e 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -2

[PATCH 0/2] Wait VPN connection establishment before replying the user

2012-08-10 Thread Jukka Rissanen
new VPN connect methods work the same way i.e., they wait until the connection is ready before replying the user. Cheers, Jukka Jukka Rissanen (2): service: Allow setting path when sending pending dbus reply provider: Return reply to user after connection is established src/connman.h |5

[PATCH 1/2] service: Allow setting path when sending pending dbus reply

2012-08-10 Thread Jukka Rissanen
--- src/connman.h |3 ++- src/network.c |2 +- src/service.c | 11 +++ 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/connman.h b/src/connman.h index e72bc2a..ddf2491 100644 --- a/src/connman.h +++ b/src/connman.h @@ -629,7 +629,8 @@ void __connman_service_se

[PATCH 2/2] provider: Return reply to user after connection is established

2012-08-10 Thread Jukka Rissanen
We only return a reply to user that is trying to connect to VPN, after the connection is established. Now all the user initiated service or provider connect requests work the same way. --- src/connman.h |2 ++ src/provider.c | 17 + src/service.c | 21

[PATCH] service: Disconnect provider after connection timeout

2012-08-13 Thread Jukka Rissanen
The provider was not disconnected after a connection timeout. This lead to weird issues in VPN code; like following provider connect request would disconnect the earlier VPN connection and report EALREADY to the user. --- src/service.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/s

[PATCH v2 0/2] Disconnect VPN when underlaying service disconnects

2012-08-14 Thread Jukka Rissanen
Hi, v2 changes the patch according to Patrik's comments. Cheers, Jukka Jukka Rissanen (2): inet: Add function to return route to a given host connection: Disconnect VPN when underlaying service disconnects src/connection.c | 104 ++--- src/conn

[PATCH v2 1/2] inet: Add function to return route to a given host

2012-08-14 Thread Jukka Rissanen
The netlink message handling is modified from iproute.c in iproute2 package. --- src/connman.h |4 ++ src/inet.c| 149 + 2 files changed, 153 insertions(+) diff --git a/src/connman.h b/src/connman.h index 492595d..f2fcecc 100644 ---

[PATCH v2 2/2] connection: Disconnect VPN when underlaying service disconnects

2012-08-14 Thread Jukka Rissanen
Fixes BMC#25128 --- src/connection.c | 104 +- 1 file changed, 63 insertions(+), 41 deletions(-) diff --git a/src/connection.c b/src/connection.c index 7212af3..c7b1f62 100644 --- a/src/connection.c +++ b/src/connection.c @@ -106,10 +106,7 @@ s

[PATCH v2 0/3] Wait VPN connection establishment before replying the user

2012-08-14 Thread Jukka Rissanen
Hi, v2 returns EINPROGRESS to the caller if there is already a provider connection pending Cheers, Jukka Jukka Rissanen (3): service: Allow setting path when sending pending dbus reply service: Remember provider pending dbus message provider: Return EINPROGRESS to the caller when connect

[PATCH v2 1/3] service: Allow setting path when sending pending dbus reply

2012-08-14 Thread Jukka Rissanen
--- src/connman.h |3 ++- src/network.c |2 +- src/service.c | 11 +++ 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/connman.h b/src/connman.h index f2fcecc..89fe7db 100644 --- a/src/connman.h +++ b/src/connman.h @@ -629,7 +629,8 @@ void __connman_service_se

[PATCH v2 2/3] service: Remember provider pending dbus message

2012-08-14 Thread Jukka Rissanen
The provider connect dbus reply message is stored in service until provider is connected. --- src/connman.h |3 +++ src/service.c | 26 ++ 2 files changed, 29 insertions(+) diff --git a/src/connman.h b/src/connman.h index 89fe7db..305f09f 100644 --- a/src/connman.h +

[PATCH v2 3/3] provider: Return EINPROGRESS to the caller when connect is pending

2012-08-14 Thread Jukka Rissanen
--- src/provider.c | 29 - src/service.c |6 ++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/src/provider.c b/src/provider.c index 52f3ade..251d0b0 100644 --- a/src/provider.c +++ b/src/provider.c @@ -898,6 +898,7 @@ int __connman_provider_c

[PATCH 1/2] wifi: Scan hidden AP always

2012-08-20 Thread Jukka Rissanen
We should scan hidden AP even if the AP is not marked as autoconnectable so that the user is able to connect to it manually. --- plugins/wifi.c |7 --- 1 file changed, 7 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 6329bf3..13c4d0f 100644 --- a/plugins/wifi.c +++ b/plug

[PATCH 0/2] Show hidden and saved AP in scan list

2012-08-20 Thread Jukka Rissanen
://bugs.meego.com/show_bug.cgi?id=24779 Cheers, Jukka Jukka Rissanen (2): wifi: Scan hidden AP always wifi: Ignore duplicate hidden AP plugins/wifi.c | 105 +++- 1 file changed, 74 insertions(+), 31 deletions(-) -- 1.7.9.5

[PATCH 2/2] wifi: Ignore duplicate hidden AP

2012-08-20 Thread Jukka Rissanen
We must not add duplicate entries to list of hidden AP. There can be more that one service file for each AP if we have multiple wifi cards in the system. Fixes BMC#24779 --- plugins/wifi.c | 98 ++-- 1 file changed, 74 insertions(+), 24 deleti

[PATCH 0/3] Manual pages for connman

2012-08-21 Thread Jukka Rissanen
Hi, this patch adds manual pages for connman and main.conf Cheers, Jukka Jukka Rissanen (3): git: Do not ignore connman manual pages doc: Manual page for connman doc: Manual page for connman configuration file .gitignore |2 ++ doc/connman.8 | 79

[PATCH 1/3] git: Do not ignore connman manual pages

2012-08-21 Thread Jukka Rissanen
--- .gitignore |2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 0570e4a..1b6f74a 100644 --- a/.gitignore +++ b/.gitignore @@ -59,6 +59,8 @@ unit/test-nat doc/*.bak doc/*.stamp doc/connman.* +!doc/connman.8 +!doc/connman.conf.5 doc/connman-*.txt doc/*.sgml

[PATCH 3/3] doc: Manual page for connman configuration file

2012-08-21 Thread Jukka Rissanen
--- doc/connman.conf.5 | 100 1 file changed, 100 insertions(+) create mode 100644 doc/connman.conf.5 diff --git a/doc/connman.conf.5 b/doc/connman.conf.5 new file mode 100644 index 000..5500a17 --- /dev/null +++ b/doc/connman.conf.5 @@ -

[PATCH 2/3] doc: Manual page for connman

2012-08-21 Thread Jukka Rissanen
--- doc/connman.8 | 79 + 1 file changed, 79 insertions(+) create mode 100644 doc/connman.8 diff --git a/doc/connman.8 b/doc/connman.8 new file mode 100644 index 000..7297cf8 --- /dev/null +++ b/doc/connman.8 @@ -0,0 +1,79 @@ +.\" con

[PATCH] device: Refactor device scan function

2012-08-21 Thread Jukka Rissanen
In wifi plugin this means that we combine three wifi scan functions (normal, fast, hidden) into one scan function. --- include/device.h |4 +- plugins/iwmx.c |5 +- plugins/wifi.c | 146 +++--- src/device.c | 12 ++--- 4 files chan

[PATCH v2 0/2] Show hidden and saved AP in scan list

2012-08-21 Thread Jukka Rissanen
Hi, The v2 removes the unnecessary ssid hex conversion in add_scan_param() function in patch #2. Cheers, Jukka Jukka Rissanen (2): wifi: Scan hidden AP always wifi: Ignore duplicate hidden AP plugins/wifi.c | 76 ++-- 1 file changed

[PATCH v2 1/2] wifi: Scan hidden AP always

2012-08-21 Thread Jukka Rissanen
We should scan hidden AP even if the AP is not marked as autoconnectable so that the user is able to connect to it manually. --- plugins/wifi.c |7 --- 1 file changed, 7 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 6329bf3..13c4d0f 100644 --- a/plugins/wifi.c +++ b/plug

[PATCH v2 2/2] wifi: Ignore duplicate hidden AP

2012-08-21 Thread Jukka Rissanen
We must not add duplicate entries to list of hidden AP. There can be more that one service file for each AP if we have multiple wifi cards in the system. Fixes BMC#24779 --- plugins/wifi.c | 69 +--- 1 file changed, 46 insertions(+), 23 deleti

[PATCH] vpn: Accept true or 1 as a boolean value

2012-08-22 Thread Jukka Rissanen
Currently user is able to set the boolean VPN config value only by setting the variable to "yes". This is not very intuitive so accept also the value of "true" or "1". --- plugins/l2tp.c |4 +++- plugins/pptp.c |4 +++- plugins/vpnc.c |4 +++- 3 files changed, 9 insertions(+), 3 deleti

[RFC] doc: VPN daemon API descriptions

2012-08-23 Thread Jukka Rissanen
--- doc/vpn-connection-api.txt | 123 doc/vpn-manager-api.txt| 51 ++ doc/vpn-overview.txt | 60 + 3 files changed, 234 insertions(+) create mode 100644 doc/vpn-connection-api.txt create mode 100644 d

[RFC] VPN daemon in connman

2012-08-23 Thread Jukka Rissanen
. Cheers, Jukka Jukka Rissanen (1): doc: VPN daemon API descriptions doc/vpn-connection-api.txt | 123 doc/vpn-manager-api.txt| 51 ++ doc/vpn-overview.txt | 60 + 3 files changed, 234 insertions

[PATCH 0/3] PPTP and L2TP use unresolved VPN gateway address

2012-08-23 Thread Jukka Rissanen
Hi, the PPTP and L2TP plugins ask "Host" variable from provider. This variable can contain hostname that is not resolved. There will be a new "HostIP" variable (by patch #1) that should be used instead. This fixes https://bugs.meego.com/show_bug.cgi?id=25658 Cheers, Jukka

[PATCH 1/3] provider: Return VPN gateway IP address

2012-08-23 Thread Jukka Rissanen
--- src/provider.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/provider.c b/src/provider.c index 251d0b0..3af6f19 100644 --- a/src/provider.c +++ b/src/provider.c @@ -1099,7 +1099,13 @@ const char *connman_provider_get_string(struct connman_provider *provider

[PATCH 2/3] l2tp: Get VPN gateway resolved IP address

2012-08-23 Thread Jukka Rissanen
We should not use the Host variable from provider as it can contain non-resolved address. --- plugins/l2tp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/l2tp.c b/plugins/l2tp.c index 5a655e6..adada4f 100644 --- a/plugins/l2tp.c +++ b/plugins/l2tp.c @@ -218,7 +218

[PATCH 3/3] pptp: Get VPN gateway resolved IP address

2012-08-23 Thread Jukka Rissanen
We should not use the Host variable from provider as it can contain non-resolved address. Fixes BMC#25658 --- plugins/pptp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/pptp.c b/plugins/pptp.c index 9db1b89..2437d06 100644 --- a/plugins/pptp.c +++ b/plugins/pptp

Re: [RFC] doc: VPN daemon API descriptions

2012-08-23 Thread Jukka Rissanen
Hi Daniel, On 08/23/2012 03:53 PM, Daniel Wagner wrote: Hi Jukka, On 23.08.2012 12:15, Jukka Rissanen wrote: --- doc/vpn-connection-api.txt | 123 doc/vpn-manager-api.txt| 51 ++ doc/vpn-overview.txt | 60

Re: [PATCH 0/8] New CLI

2012-08-24 Thread Jukka Rissanen
Hi Ceara, please use "git send-email" when sending patches so that the individual patches are nicely threaded under the cover letter mail. Then some comments: - I see mixed usage of fprintf(stdout,...) and printf(...). Please use one or the other for consistency, I would recommend printf() b

Re: [PATCH 0/8] New CLI

2012-08-24 Thread Jukka Rissanen
I forgot these comments from my earlier mail: - in services list you print "C" if the service is connected. Please use the "R" for ready and "O" for online status like in python script. Also print the autoconnect status with letter "A" (if autoconnectable service) like in test-connman python s

Re: [PATCH 0/8] New CLI

2012-08-24 Thread Jukka Rissanen
Hi Daniel, On 08/24/2012 02:13 PM, Daniel Wagner wrote: Hi Jukka On 24.08.2012 12:39, Jukka Rissanen wrote: - check also the dbus/dbus-glib.h existence, unfortunately you need to do some trickery as the header file is not directly under /usr/include Stupid question: Does this mean we get an

[RFC 0/6] New VPN daemon

2012-08-28 Thread Jukka Rissanen
Comments? Anything totally wrong? Do this instead of that? Cheers, Jukka Jukka Rissanen (6): doc: VPN daemon API descriptions ipconfig: Move IP address API into separate ipaddress.c file device: Move device creation func into device.c log: Give program name and version in log init main: Do

[RFC 1/6] doc: VPN daemon API descriptions

2012-08-28 Thread Jukka Rissanen
--- doc/vpn-connection-api.txt | 118 doc/vpn-manager-api.txt| 50 +++ doc/vpn-overview.txt | 60 ++ 3 files changed, 228 insertions(+) create mode 100644 doc/vpn-connection-api.txt create mode 100644

[RFC 2/6] ipconfig: Move IP address API into separate ipaddress.c file

2012-08-28 Thread Jukka Rissanen
Done so that connman_ipaddress_* functions can be used from separate vpn daemon. --- Makefile.am |5 +- include/ipaddress.h | 56 +++ include/ipconfig.h | 19 + src/connman.h |2 +- src/dhcp.c |4 +- src/ipaddress.c | 200 +++

[RFC 3/6] device: Move device creation func into device.c

2012-08-28 Thread Jukka Rissanen
The device creation function should be part of device.c and not inet.c. After this change the inet.c can be used by separate vpn daemon. --- include/device.h |1 + include/inet.h|1 - plugins/iwmxsdk.c |4 +- src/detect.c |2 +- src/device.c | 178 ++

[RFC 4/6] log: Give program name and version in log init

2012-08-28 Thread Jukka Rissanen
This allows the correct output when the log functions are used from separate vpn daemon. --- src/connman.h |3 ++- src/log.c |5 +++-- src/main.c |3 ++- unit/test-nat.c |2 +- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/connman.h b/src/connman.h

[RFC 5/6] main: Do not call provider init/cleanup any more

2012-08-28 Thread Jukka Rissanen
The vpn functionality is provided by separate vpn daemon. --- src/main.c |2 -- 1 file changed, 2 deletions(-) diff --git a/src/main.c b/src/main.c index 75b8171..e4bb206 100644 --- a/src/main.c +++ b/src/main.c @@ -544,7 +544,6 @@ int main(int argc, char *argv[]) __connman_technology

<    1   2   3   4   5   6   7   8   9   10   >